Activity
From 08/02/2021 to 08/08/2021
08/08/2021
- 11:41 PM Revision dc2eb6f7 (git): * 2021-08-09 [ci skip]
- 11:40 PM Revision 48c43f77 (git): Rework the readline test to be more robust.
- - Capture that the child is started by initial log line.
- More robust handling of child status reaping.
- Direct exit without sucess mesage if `#readline` receives input. -
06:33 PM Feature #18070 (Open): `attr` should be removed
- I'm digging through some older Ruby versions and discovered that `attr` was deprecated in Ruby 1.9. We still are seeing support for it in Ruby 3.0
Unless there are internals that require its existence, is it time to remove this deprec... -
02:30 PM Feature #18069 (Open): `instance_exec` is just ignored when the block is originally a method
I know you can't `instance_exec` a proc which is generated by `Method#to_proc` because it has its original instance's context. But, in such a case, raising `ArgumentError` would be the ideal behavior.
```ruby
f = -> (x) { a + x }
...-
02:21 PM Feature #18068 (Closed): Silence LoadError only if it is for rubygems itself
- **Background**
The "Optionally load did_you_mean and RubyGems" PR (https://github.com/ruby/ruby/pull/2764) attempted to prevent raising `LoadError` when requiring `rubygems` because it might not be available optionally when Ruby is ... -
01:09 PM Bug #18067 (Rejected): Composite procs with `instance_exec` aren't executed within the context of the receiver
- ```ruby
func1 = -> (x) { x + y }
class A
def y
10
end
end
A.new.instance_exec(1, &func1) # => 11
func2 = -> (x) { x * 2 }
f = func1 >> func2
A.new.instance_exec(1, &f) # => undefined local variable or method `y' f... - 10:12 AM Revision 3a8cadcf (git): Reduce chance to receive EBADF when closing an IO from another thread.
-
08:13 AM Revision 587f501c (git): Make bit flags `reason` unsigned
-
06:43 AM Revision ca2dd6d3 (git): Use #full_message instead of #backtrace_locations
-
06:13 AM Revision f8196456 (git): Suppress warnings when GC_ENABLE_INCREMENTAL_MARK == 0
-
04:01 AM Revision 3922394c (git): Bump patchlevel.
-
04:00 AM Bug #18053: Crashes and infinite loops when generating partial backtraces in Ruby 3.0+
- ruby_3_0 c07545bbf82068f4fd92a5ccfa2b09bb96b39adb.
-
03:35 AM Bug #18053: Crashes and infinite loops when generating partial backtraces in Ruby 3.0+
- Hello Jeremy,
Thank you for your great work on the partial backtrace optimization and deep understanding for the stable branch maintenance. I'd like to adopt your 3rd option. I will merge your PR after confirming the CI passed with it. -
03:59 AM Revision c07545bb (git): Fix multiple bugs in partial backtrace optimization
- This fixes multiple bugs found in the partial backtrace
optimization added in 3b24b79.
These bugs occurs when passing a start argument to caller where
the start argument lands on a iseq frame without a pc.
Before this commit, the follow... -
03:01 AM Bug #18065: 3.0.2 - possible memory leak in Hash#transform_keys!
- ruby_3_0 d6b8b37a2608a0fbb8bcfd10356bb25f9ebbe1fe merged revision(s) e5dd40b1f3a11f48d566413ab347ce0cfdd94960.
-
03:00 AM Revision d6b8b37a (git): merge revision(s) e5dd40b1f3a11f48d566413ab347ce0cfdd94960: [Backport #18065]
- Stop force-recycling evacuated array [Bug #18065]
---
hash.c | 1 -
1 file changed, 1 deletion(-) -
12:25 AM Revision 40ccb87a (git): Show backtrace locations when I/O timed out
- 12:25 AM Revision c6398d3d (git): * 2021-08-08 [ci skip]
08/07/2021
-
08:35 PM Bug #18066: Load did_you_mean/error_highlight even with --disable-gems
- However, I am not sure what is the impact in case Ruby can be build with `--disable-gems` configuration option (if that is possible).
-
08:30 PM Bug #18066 (Rejected): Load did_you_mean/error_highlight even with --disable-gems
- I guess that did_you_mean was not possible to load without RubyGems, when it used to be bundled gem. Since it is default gem, therefore part of StdLib and always available on load path, it should not be related to --disable-gems anymore....
-
07:43 PM Bug #15790: Strange interaction between autoload and $LOADED_FEATURES
- Eregon (Benoit Daloze) wrote in #note-8:
> Their description should still match the tested behavior though,
> ...
OK, I pushed another commit for that. -
06:18 PM Bug #15790: Strange interaction between autoload and $LOADED_FEATURES
- BTW, Zeitwerk has its own "Ruby compatibility suite" for language details the implementation relies on. Like, you can override autoloads, remove_const does not execute autoloads, etc.: https://github.com/fxn/zeitwerk/blob/main/test/lib/z...
-
06:14 PM Bug #15790: Strange interaction between autoload and $LOADED_FEATURES
- Indeed, to me, this belongs to the contract of these APIs and should be documented.
The documentation of `Module#autoload` should say what happens if the file is not found, if the file is found but raises, if the file is found and is ... -
06:01 PM Bug #15790: Strange interaction between autoload and $LOADED_FEATURES
- Thanks, it's fine to modify these specs.
Their description should still match the tested behavior though,
for "does not remove the constant from Module#constants if the loaded file does not define it, but leaves it as 'undefined'"
s... -
04:24 PM Bug #15790: Strange interaction between autoload and $LOADED_FEATURES
- jeremyevans0 (Jeremy Evans) wrote in #note-6:
> I updated the pull request to remove the constant instead of just deleting the autoload. If it passes CI, I'm fine with that approach.
Removing the constant breaks 4 specs:
```
ruby... -
03:48 PM Bug #15790: Strange interaction between autoload and $LOADED_FEATURES
- I updated the pull request to remove the constant instead of just deleting the autoload. If it passes CI, I'm fine with that approach.
-
01:17 PM Bug #15790: Strange interaction between autoload and $LOADED_FEATURES
- Indeed, the concept of undefined constants for me is dubious. An autoload claims that the constant should be in the given file, but you don't know until the file is evaluated. So, it has been always surprising to me that the constants AP...
-
01:14 PM Bug #15790: Strange interaction between autoload and $LOADED_FEATURES
- I deleted my previous comment, misunderstood the situation.
Yeah, in my view if you fire an autoload, the autoload should be removed regardless of the outcome. Additionally, if the constant has not been defined, it should be removed (... -
10:53 AM Bug #15790: Strange interaction between autoload and $LOADED_FEATURES
- Maybe we should remove the constant as well if we remove the autoload?
I think that would be natural and simpler semantically.
Currently there is some really strange semantics around that, which lead to a lot of complexity (e.g., the c... -
01:58 PM Revision 1fe73128 (git): Use TERM=xterm for tests on Solaris
-
12:16 PM Revision f092a960 (git): Set TERM env for some CI environments
-
11:09 AM Feature #10917: Add GC.stat[:total_time] when GC profiling enabled
- byroot (Jean Boussier) wrote in #note-6:
> Ideally we'd return a float, but as noted by @jasonrclark, it's not easy to return anything else than `size_t` without breaking the `size_t rb_gc_stat(VALUE)` C API.
If that precision is needed... -
09:32 AM Revision 6e60fc29 (git): Group commands on GitHub Actions
-
05:18 AM Revision ac7986f4 (git): Remove unneeded rb_fiber_transfer_kw declaration
-
03:50 AM Revision 9b3fcfbb (git): Suppress unused-result warnings
- * Hide read function warning in string_spec_RSTRING_PTR_read function
* The type of `read` may be `ssize_t`
Co-authored-by: Nobuyoshi Nakada <nobu@ruby-lang.org> -
03:41 AM Bug #18065 (Closed): 3.0.2 - possible memory leak in Hash#transform_keys!
- Applied in changeset commit:git|e5dd40b1f3a11f48d566413ab347ce0cfdd94960.
----------
Stop force-recycling evacuated array [Bug #18065] -
01:06 AM Bug #18065: 3.0.2 - possible memory leak in Hash#transform_keys!
- It looks likely related to commit:84d9a9afc0b49d095541acb9832f8b12fb506e19.
-
12:03 AM Bug #18065 (Closed): 3.0.2 - possible memory leak in Hash#transform_keys!
- I found what may be a memory leak in Hash#transform_keys! in version 3.0.2
This sample code will reproduce the issue. It quickly consumes gigabytes of memory when running on 3.0.2, but has very normal memory usage on 3.0.1. I test... -
03:34 AM Revision e5dd40b1 (git): Stop force-recycling evacuated array [Bug #18065]
-
02:01 AM Bug #18062: Ruby with enabled LTO segfaults during build
- OK, how about this?
https://github.com/ruby/ruby/pull/4716
08/06/2021
-
10:40 PM Bug #13864: Rinda multicast test failures due to missing default route
- This appears to still be an issue in the master branch. I submitted an upstream pull request to fix it: https://github.com/ruby/rinda/pull/1
-
10:12 PM Bug #18061: Execshield test: libruby.so.N.N.N: FAIL: property-note test because no .note.gnu.property section found
- ```
On another side, we have an Intel CET [2], [3]:
"Control-flow Enforcement Technology (CET) provides the following capabilities to defend
against ROP/JOP style control-flow subversion attacks:
- Shadow Stack - return address prote... -
12:39 PM Bug #18061: Execshield test: libruby.so.N.N.N: FAIL: property-note test because no .note.gnu.property section found
- Thanks for the patch! Let me check it.
-
12:26 PM Bug #18061: Execshield test: libruby.so.N.N.N: FAIL: property-note test because no .note.gnu.property section found
- That seems the same as a section generated by GCC.
-
10:04 PM Bug #17183 (Closed): Float round working weirdly
- Applied in changeset commit:git|d16b68cb2204eeb5af8bd39149202b630374c67f.
----------
Use Rational for Float#round with ndigits > 14
ndigits higher than 14 can result in values that are slightly too
large due to floating point limitatio... -
10:04 PM Bug #14635 (Closed): Float#round(n) returns a wrong result when n is big
- Applied in changeset commit:git|d16b68cb2204eeb5af8bd39149202b630374c67f.
----------
Use Rational for Float#round with ndigits > 14
ndigits higher than 14 can result in values that are slightly too
large due to floating point limitatio... -
10:03 PM Revision d16b68cb (git): Use Rational for Float#round with ndigits > 14
- ndigits higher than 14 can result in values that are slightly too
large due to floating point limitations. Converting to rational
for the calculation and then back to float fixes these issues.
Fixes [Bug #14635]
Fixes [Bug #17183]
Co-... -
09:47 PM Bug #15790: Strange interaction between autoload and $LOADED_FEATURES
- This is still an issue in the master branch. One way to fix this is to delete the autoload if the constant isn't present after the file is loaded. I submitted a pull request for that: https://github.com/ruby/ruby/pull/4715
-
08:47 PM Feature #10917: Add GC.stat[:total_time] when GC profiling enabled
- > FWIW TruffleRuby and JRuby both have a :time value in GC.stat and it represents the total GC time, in milliseconds
Ah that's good to know. Thank you!
In this case I think the patch could look like this: https://github.com/Shopif... -
08:03 PM Feature #10917: Add GC.stat[:total_time] when GC profiling enabled
- FWIW TruffleRuby and JRuby both have a `:time` value in `GC.stat` and it represents the total GC time, in milliseconds (`GarbageCollectorMXBean#getCollectionTime` provides this data on the JVM)
(No GC::Profiler needed to query it)
If thi... -
11:15 AM Feature #10917: Add GC.stat[:total_time] when GC profiling enabled
- I'd like to restart the discussion on this as I recently hit the same issue.
> With incremental GC (incremental marking and lazy sweep) consume very short time for each step.
Indeed. However when running a web service, even if ind... -
07:16 PM Bug #17362 (Closed): Thread core dump
-
05:28 PM Bug #18053: Crashes and infinite loops when generating partial backtraces in Ruby 3.0+
- I committed my rewrite of backtrace generation (commit:1a05dc03f953830564c272665c47a61e53550f3e), which fixes these issues in master/3.1. I took the examples from this issue and added them as tests in that commit.
For Ruby 3.0, there ... -
05:15 PM Bug #18053 (Closed): Crashes and infinite loops when generating partial backtraces in Ruby 3.0+
- Applied in changeset commit:git|1a05dc03f953830564c272665c47a61e53550f3e.
----------
Make backtrace generation work outward from current frame
This fixes multiple bugs found in the partial backtrace
optimization added in 3b24b7914c1693... - 05:15 PM Revision 0d3520b0 (git): * 2021-08-07 [ci skip]
-
05:15 PM Revision 1a05dc03 (git): Make backtrace generation work outward from current frame
- This fixes multiple bugs found in the partial backtrace
optimization added in 3b24b7914c16930bfadc89d6aff6326a51c54295.
These bugs occurs when passing a start argument to caller where
the start argument lands on a iseq frame without a pc... -
04:46 PM Bug #18064 (Closed): Backport fix for bug 7844 (include/prepend satisfiable module dependencies are not satisfied)
-
07:32 AM Bug #18064: Backport fix for bug 7844 (include/prepend satisfiable module dependencies are not satisfied)
- Upgrading Ruby from 2.7 to 3.0 is too much work just for this bug fix
Especially when many existing gems don't work properly in 3.x
This backport is required to address
[an issue about usage of a gem](https://github.com/panorama-ed... -
07:27 AM Bug #18064 (Closed): Backport fix for bug 7844 (include/prepend satisfiable module dependencies are not satisfied)
- Bug:
https://bugs.ruby-lang.org/issues/7844
Already merged PR with fix (merged into 3.0):
https://github.com/ruby/ruby/pull/3796
I have already created a PR for backport:
https://github.com/ruby/ruby/pull/4711 -
02:16 PM Bug #18062: Ruby with enabled LTO segfaults during build
- nobu (Nobuyoshi Nakada) wrote in #note-8:
Thx, this helps. Howeverer, there is more:
~~~
(gdb) r -I./lib -I. -I.ext/common ./tool/runruby.rb --extout=.ext -- --disable-gems "./libexec/rdoc" --root "." --encoding=UTF-8 --all --ri -... -
12:10 PM Bug #18062: Ruby with enabled LTO segfaults during build
- vo.x (Vit Ondruch) wrote in #note-5:
> ~~~
> ...
I've missed here.
-
10:30 AM Bug #18062: Ruby with enabled LTO segfaults during build
- I should probably include a few more lines from the log which include the build options:
~~~
gcc -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-... -
10:22 AM Bug #18062: Ruby with enabled LTO segfaults during build
- nobu (Nobuyoshi Nakada) wrote in #note-4:
> Maybe a strict aliasing issue?
The patch changes the error:
~~~
./miniruby -I./lib -I. -I.ext/common ./tool/generic_erb.rb -c -o encdb.h ./template/encdb.h.tmpl ./enc enc
<internal:ra... -
12:30 PM Bug #18054 (Closed): No rule to make target 'thread_fd_close.c', needed by 'thread_fd_close.o'
- Eregon (Benoit Daloze) wrote in #note-5:
> `make clean` is sometimes needed when building CRuby (correct C files dependencies is still a mess to this day, not CRuby-specific).
> ...
Thanks, that helped. -
11:55 AM Bug #18054: No rule to make target 'thread_fd_close.c', needed by 'thread_fd_close.o'
- duerst (Martin Dürst) wrote in #note-4:
> ```
> ...
This file should be updated, but actually wasn't.
Could you try again after removing that file? -
10:14 AM Bug #18054: No rule to make target 'thread_fd_close.c', needed by 'thread_fd_close.o'
- `make clean` is sometimes needed when building CRuby (correct C files dependencies is still a mess to this day, not CRuby-specific).
Would that help here? -
08:59 AM Bug #18054: No rule to make target 'thread_fd_close.c', needed by 'thread_fd_close.o'
- nobu (Nobuyoshi Nakada) wrote in #note-3:
> You can remove the old directory, and `ext/-test-/exts.mk` file.
Many thanks for your help. I removed both the directory and the file. Now I'm getting the following:
```
transdb.h uncha... -
11:58 AM Revision d868c8f0 (git): Make jobserver available
-
11:20 AM Misc #18039: DevelopersMeeting20210819Japan
- * [Feature #10917] Add GC.stat[:total_time] (byroot)
* Time spent in GC is a very important metric for application performance monitoring.
* Right now only `GC::Profiler` can be used, but it is ill suited when there are multiple call... -
07:35 AM Bug #7844: include/prepend satisfiable module dependencies are not satisfied
- Thanks @jeremyevans0 for informing the backport request before I create the backport ticket
A backport ticket is created:
https://bugs.ruby-lang.org/issues/18064
I have provided the reason for requesting this backport to 2.7 in th... -
04:34 AM Revision 3e7fb4b9 (git): Check the result of tigetstr
-
04:33 AM Revision 9bfb8ea6 (git): Fix caching of curses_dl
-
01:39 AM Revision 7af21a78 (git): test/reline/test_terminfo.rb: skip when setupterm fails
- http://rubyci.s3.amazonaws.com/solaris11-gcc/ruby-master/log/20210806T000008Z.fail.html.gz
```
1) Error:
Reline::Terminfo::Test#test_tigetstr:
Reline::Terminfo::TerminfoError: The terminfo database could not be found.
/export/home/...
08/05/2021
-
06:55 PM Revision e687b6f4 (git): Show Readline::VERSION for debugging
- 06:50 PM Revision 983630b5 (git): * 2021-08-06 [ci skip]
-
06:50 PM Revision 9b56668b (git): Omit test_interrupt_in_other_thread with Editline
-
06:17 PM Revision 6414334d (git): Fix reversal of assertion result
-
06:15 PM Revision cd57b39f (git): Fix control structure to preperly catch Timeout::Error
-
05:51 PM Revision 7bcbee37 (git): Fix the result of checking the existence of constants being reversed
-
05:49 PM Bug #18061: Execshield test: libruby.so.N.N.N: FAIL: property-note test because no .note.gnu.property section found
- It seems we can check if the `.note.gnu.property` exists in a binary file by the command `readelf -S --wide <file>`. The binary file `ruby` has it. But the file `libruby.so.3.1.0` doesn't it.
```
$ readelf -S --wide ruby
There are 4... -
05:10 PM Bug #18061: Execshield test: libruby.so.N.N.N: FAIL: property-note test because no .note.gnu.property section found
- By the way, I found a case generating ".note.gnu.property section" in the OpenSSL project.
https://github.com/openssl/openssl/commit/51994e505dbb1cd0dd76869ec962e2948b77b585
The commit message explains how they verified the change. S... -
03:52 PM Bug #18061: Execshield test: libruby.so.N.N.N: FAIL: property-note test because no .note.gnu.property section found
- I applied the patch for the Ruby 3.0.2 in RHEL 8, built. But I still see the failed message.
```
annocheck: Version 9.65.
Hardened: libruby.so.3.0.2: FAIL: property-note test because no .note.gnu.property section found
Hardened: Re... -
03:38 PM Bug #7844: include/prepend satisfiable module dependencies are not satisfied
- PickachuEXE on GitHub requested this be backported to 2.7: https://github.com/ruby/ruby/pull/4711 . This does affect backwards compatibility, so I'm not sure it is something that should be backported. The 2.7 branch maintainer (@usa) wi...
-
03:29 PM Bug #17806: Bad interaction between method cache, prepend, and refinements
- Hi @mk, from the description you gave, it's possible that you are running into #17725.
I would try running these two lines before requiring the test file that contains the | call:
```
iseq = RubyVM::InstructionSequence
iseq.compile... -
11:49 AM Bug #17806: Bad interaction between method cache, prepend, and refinements
- Hi @alanwu,
at GitLab we are currently working on making our application Ruby 3 ready.
We are running into a strange issue in our test suite where refinements fails to be applied when everything suggests they should be.
During m... -
02:52 PM Feature #18045: Variable Width Allocation Phase II
- Hi @duerst, thank you for the feedback. Thank you for adding it to the committer meeting, we will wait for their feedback before proceeding further.
> Using powers of 2 slot sizes is the "trusted and true" way of handling this, but ma... -
12:55 AM Feature #18045: Variable Width Allocation Phase II
- I think this should really be discussed seriously at least once at a committer's meeting. I have added it to #18039.
Using powers of 2 slot sizes is the "trusted and true" way of handling this, but may lead to some memory overhead. W... -
02:10 PM Bug #12706: Hash#each yields inconsistent number of args
- I just ran into this since I hadn't been aware of this change.
What I find odd about this change is that it introduces a new inconsistency: the behavior of related Enumerable methods such as `map` is now different to that of `each` (i... -
01:30 PM Revision bda56a03 (git): Build rubyspec CAPI extensions
-
11:32 AM Bug #18062: Ruby with enabled LTO segfaults during build
- Maybe a strict aliasing issue?
-
08:42 AM Bug #18062: Ruby with enabled LTO segfaults during build
- vo.x (Vit Ondruch) wrote in #note-2:
> I'd say it goes sideways somewhere here:
> ...
Actually, this is weird:
~~~
Breakpoint 1, vm_ccs_push (cc=0x55555595ddf0, ci=0x22f100140003, ccs=0x555555a31f80, klass=93824996623120) at ./incl... -
08:30 AM Bug #18062: Ruby with enabled LTO segfaults during build
- I'd say it goes sideways somewhere here:
https://github.com/ruby/ruby/blob/0db68f023372b634603c74fca94588b457be084c/vm_insnhelper.c#L1708
I'm not sure why the `rb_id_table_lookup` does not provide any value for `css`, but there is ... -
08:11 AM Bug #18062: Ruby with enabled LTO segfaults during build
- GDB output:
~~~
$ gdb ./miniruby
GNU gdb (GDB) Fedora 10.2-6.fc35
Copyright (C) 2021 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are fr... -
07:56 AM Bug #18062 (Closed): Ruby with enabled LTO segfaults during build
- After a while, I am trying to enable LTO for Ruby in Fedora. Previously I hit #17052, but now I observe issues much earlier during compliation already:
~~~
./miniruby -I./lib -I. -I.ext/common ./tool/generic_erb.rb -c -o encdb.h ./t... -
10:39 AM Revision 1cb5a669 (git): Show log when timed out
-
10:05 AM Bug #18054: No rule to make target 'thread_fd_close.c', needed by 'thread_fd_close.o'
- duerst (Martin Dürst) wrote in #note-2:
> Do you mean `ext/-test-/thread_fd_close` should no longer exist? Or something else?
Yes,renamed as `ext/-test-/thread_fd`.
You can remove the old directory, and `ext/-test-/exts.mk` file. -
08:08 AM Bug #18054: No rule to make target 'thread_fd_close.c', needed by 'thread_fd_close.o'
- (sorry this answer is late)
nobu (Nobuyoshi Nakada) wrote in #note-1:
> Do `ext/-test-/thread_fd` directory and `Makefile` there exist?
The directory exists, but the Makefile doesn't exist.
> ...
This says `make: *** No rule ... -
10:02 AM Feature #18063 (Open): io_uring implementation
- https://www.youtube.com/watch?v=TYq_ohhYZ9A
-
08:25 AM Revision a97837de (git): Fix a link [ci skip]
-
08:14 AM Revision ae275f67 (git): Show WorkingSetSize as RSS on Windows
-
08:11 AM Revision 228b3e43 (git): check GC.enable'd status
- Check GC.enable'd status before and after test execution.
Write this checker in gc_checker.rb, it was renamed from
gc_compact_checker.rb. -
05:48 AM Revision 405644f3 (git): Revert "Removed extinit.o from main programs"
- This reverts commit ac86fcbfd0bab8667d277aa575bc5b81e5135d3c.
This change broke "--disable-shared --with-static-linked-ext". -
05:15 AM Revision 3bb64109 (git): Use equivalent `__FILE__`
-
04:58 AM Revision 594c3df9 (git): Tests for Windows can run only on Windows
- Should not directly require "reline/windows.rb" which should be
loaded by "reline.rb". -
12:33 AM Misc #18039: DevelopersMeeting20210819Japan
- * [Feature #18045] Variable Width Allocation Phase II (peterzhu2118)
* Variable Width Allocation is a major change to Ruby internals and therefore should be discussed seriously.
08/04/2021
-
09:16 PM Feature #18045: Variable Width Allocation Phase II
- Hello! We’re still looking for feedback on this. If there are no concerns, we’ll merge it next week.
- 08:11 PM Revision bc8bc072 (git): * 2021-08-05 [ci skip]
- 08:11 PM Revision 1fd0a2e4 (git): Reenable GC at the end of test
- The test disables GC but never reenables it. Before this patch, running
all tests would have a peak RSS in the main process of >4GB. After this
patch, peak RSS in the main process is <500MB. -
04:39 PM Bug #18061: Execshield test: libruby.so.N.N.N: FAIL: property-note test because no .note.gnu.property section found
- Thanks for the patch! Let me check it.
-
04:20 PM Bug #18061: Execshield test: libruby.so.N.N.N: FAIL: property-note test because no .note.gnu.property section found
- Does it work just by adding an empty section?
-
01:37 PM Bug #18061 (Closed): Execshield test: libruby.so.N.N.N: FAIL: property-note test because no .note.gnu.property section found
- I found an issue in our company's internal test called "execshield" by a security tool annobin - annocheck command [1][2].
```
Hardened: libruby.so.2.7.4: FAIL: property-note test because no .note.gnu.property section found
```
H... -
02:35 PM Revision 042d4c81 (git): Remove an unused variable
-
11:39 AM Revision 5f2987d6 (git): Fix relative paths from core_assertions.rb
-
09:29 AM Revision 6e55facd (git): Run interrupt test except on Windows
-
09:29 AM Revision aba10ea6 (git): Add a load path to require 'helper'
-
09:29 AM Revision 335c1282 (git): Show the log of test_interrupt_in_other_thread when failed
-
09:29 AM Revision 17ef7a98 (git): Check the existence of the test classes
-
09:29 AM Revision 5ca0a51f (git): Add a test for handling SIGINT in other thread
-
09:29 AM Revision de93b8b0 (git): Handle SIGINT in other thread correctly
- Co-authored-by: Koichi Sasada <ko1@atdot.net>
-
09:29 AM Revision 5bb7b571 (git): Use Symbol of signal for trap
-
08:05 AM Bug #14137: Windows / MinGW - Regexp - Character Properties - General Category
- I agree with @jeremyevans0, but would like to add that
```
ruby -e 'p (/\p{L}/.match("a"))'
```
will produce `#<MatchData "a">` also in any situation that is using UTF-8. That will be on almost all current Linux/Unix,... versions, an... -
07:59 AM Revision 1f2b3f25 (git): Remove an extraneous escape
- Since a3fb97465df3, this string is not inside the here-document.
-
06:01 AM Misc #18059: Which FL_USERx are open to extension libraries?
- duerst (Martin Dürst) wrote in #note-6:
> Dan0042 (Daniel DeLorme) wrote in #note-4:
> ...
Sorry, I should have been more specific the first time round. One question is whether extension libraries are allowed to use some flags. The oth... -
03:53 AM Misc #18059: Which FL_USERx are open to extension libraries?
- Dan0042 (Daniel DeLorme) wrote in #note-4:
> Actually I have so many questions about flags,...
> ...
Yes, please!
-
03:40 AM Revision 80c180df (git): merge revision(s) b8386f7f7f6d7a7d76481e02d389d0f5211f0f2c:
- Prepend DebugSystem to VCS class only
And revert 24e5f1c982966c379220b1bbb26b4e0320180fa1, pepending to
Kernel did not affect the top level methods before 3.0.
---
tool/lib/vcs.rb | 3 ---
too...
08/03/2021
-
11:47 PM Misc #18059: Which FL_USERx are open to extension libraries?
- Dan0042 (Daniel DeLorme) wrote in #note-4:
> I thought it meant those flags have a different usage for each class. No?
Correct.
> ...
Upper 32 bits are not available on 32-bit system of course.
We didn't think those bits were nee... -
03:48 PM Misc #18059: Which FL_USERx are open to extension libraries?
- shyouhei (Shyouhei Urabe) wrote in #note-1:
> The "USER" terminology never seriously meant anything I guess.
I thought it meant those flags have a different usage for each class. No?
Actually I have so many questions about flags, ... -
01:37 PM Misc #18059: Which FL_USERx are open to extension libraries?
- I think it could also make sense to deprecate those macros (e.g., by making them use functions marked as deprecated) and eventually remove them, if no C extension should use them.
That would also mean that e.g. the `date` gem cannot use... -
01:32 PM Misc #18059: Which FL_USERx are open to extension libraries?
- Those specs were added because gems rely on it (https://github.com/oracle/truffleruby/issues/1884).
`rbtree3` is an example: https://github.com/kyrylo/rbtree3/blob/850e9d76c22b0766bc2bc36987b11aed05eb2bb4/rbtree.c#L19
`gem-codesearch '... -
03:11 AM Misc #18059: Which FL_USERx are open to extension libraries?
- I guess none of them are open for extension libraries. For instance `FL_USER0` is `FL_SINGLETON`. It is obvious that the flag cannot be abused in any other ways than how we currently use it.
The "USER" terminology never seriously me... -
12:38 AM Misc #18059 (Closed): Which FL_USERx are open to extension libraries?
- Often the following failure occurs in `test-spec`.
```
RBasic support for regular objects supports copying the flags from one object over to the other FAILED
Expected 81920 == 33636352
to be truthy but was false
/tmp/ruby/v3/src/t... -
09:48 PM Misc #18039: DevelopersMeeting20210819Japan
- * [Bug #13392] TracePoint return event location is incorrect for methods defined with define_method (alanwu)
* There are two PRs available, one more complex but opens the possibility for future optimizations. Which do you prefer?
* [... -
01:48 AM Misc #18039: DevelopersMeeting20210819Japan
- * [Feature #18051] Move symbols exported under internal (nobu)
* Some symbols exported in headers under `internal` are declared and used in some extension libraries.
These seem OK to be moved to public headers.
* `ruby_s... -
12:41 AM Misc #18039: DevelopersMeeting20210819Japan
- * [Misc #18059] Which `FL_USER`x are open to extension libraries? (nobu)
* (need comment) -
09:47 PM Bug #13392: TracePoint return event location is incorrect for methods defined with define_method
- I implemented an alternative fix that is more complicated but allows for future optimizations here: https://github.com/ruby/ruby/pull/4637
Some relevant details about it are in Jeremy's GitHub PR. -
09:31 PM Bug #18060 (Closed): Infinite loop when b_return TracePoint raises
- The following program loops indefinitely:
```ruby
puts("PID: #{$$}")
class Foo
define_singleton_method(:foo) { return }
end
counter = 0
TracePoint.trace(:b_return) do |tp|
$stdout.write(counter, ' ', tp.inspect, "\r")
... - 08:39 PM Revision 6e8bbabc (git): * 2021-08-04 [ci skip]
- 08:39 PM Revision c463a5e0 (git): Fix indentation in string.c
- 7 spaces were used for 2 levels of indentation. This commit changes it
to use 8 spaces. -
11:56 AM Bug #18048: Thread#join can break with fiber scheduler unblock fails or blocks.
- I see the git:2d4f29e77e883c29e35417799f8001b8046cde03 was pushed as the retry of 13f8521c630a15c87398dee0763e95f59c032a94.
I will pay attention on the RubyCI for a while. - 10:23 AM Revision 2d4f29e7 (git): Fix potential hang when joining threads.
- If the thread termination invokes user code after `th->status` becomes
`THREAD_KILLED`, and the user unblock function causes that `th->status` to
become something else (e.g. `THREAD_RUNNING`), threads waiting in
`thread_join_sleep` will ... -
09:16 AM Revision 785c70e7 (git): [DOC] mention how the command is passed to the shell [ci skip]
-
03:10 AM Bug #18011 (Closed): `Method#parameters` is incorrect for forwarded arguments
- Applied in changeset commit:git|4c3140d60f6f94504842a4d0c0d79752a87aec8d.
----------
Add keyrest to ruby2_keywords parameters [Bug #18011] - 03:10 AM Revision b5e94916 (git): * 2021-08-03 [ci skip]
-
01:56 AM Revision 4c3140d6 (git): Add keyrest to ruby2_keywords parameters [Bug #18011]
08/02/2021
-
08:31 PM Bug #18058: 3.1.0-dev with MJIT enabled Zlib::BufError during `gem install`
- Here you go:
```
/usr/local/lib/ruby/3.1.0/rubygems/package.rb:698:in `read': buffer error (Zlib::BufError)
from /usr/local/lib/ruby/3.1.0/rubygems/package.rb:698:in `block in verify_gz'
from /usr/local/lib/ruby/3.1.0/rubygems/pa... -
08:28 PM Bug #18058: 3.1.0-dev with MJIT enabled Zlib::BufError during `gem install`
- > Do you know if we can let Bundler show the backtrace?
It's `rubygems` not bundler. I don't know how make it print the backtrace, but I can take a look. Worst case I can probably directly patch it to let the error bubble up. -
08:26 PM Bug #18058: 3.1.0-dev with MJIT enabled Zlib::BufError during `gem install`
- Do you know if we can let ~~Bundler~~ rubygems (you're right, it wasn't Bundler) show the backtrace? The first step to fix this is to increase reproduction probability, and the backtrace information might be helpful for reproducing the i...
-
11:45 AM Bug #18058 (Closed): 3.1.0-dev with MJIT enabled Zlib::BufError during `gem install`
- It doesn't always happen (maybe 5-10% of the cases), but since I added MJIT to our CI builds I've been seeing this error a lot.
I was able to reproduce it in `docker run -it rubylang/ruby:master-nightly-bionic` after 15 or so tries:
... -
02:16 PM Feature #18057: Introduce Array#mean
- @nobu - yup, you are correct. The expected behaviour should be like this
```ruby
[1,2].mean #=> 1.5
``` -
01:54 PM Feature #18057: Introduce Array#mean
- When `ary` has only `Integer`s, `ary.sum` is also an `Integer` and `ary.sum / ary.length` too.
```ruby
[1,2].sum #=> 3
[1,2].sum / 2 #=> 1
```
I don't think this is the expected result, no?
So it should be `ary.sum.quo(ary.leng... -
01:14 PM Feature #18057: Introduce Array#mean
- 💡 You can also use the [Refinements](https://www.alchemists.io/projects/refinements/#_mean) gem which also provides `#mean` support.
-
04:46 AM Feature #18057: Introduce Array#mean
- Thank you @mrkn!
I didn't know about enumerable-statistics, and I can definitely use this in my projects!!
I wish I knew about it sooner! -
04:42 AM Feature #18057: Introduce Array#mean
- I definitely prefer using `mean` over `average`!
-
03:41 AM Feature #18057: Introduce Array#mean
- I created [enumerable-statistics gem](https://github.com/mrkn/enumerable-statistics) to provide the methods for calculating precise statistical summary in Array and Enumerable. Does this gem fit your use cases?
I think this is unnece... -
01:50 AM Feature #18057: Introduce Array#mean
- oh goodness... that is embarrassing... Thank you for catching my error... 🙏
-
01:43 AM Feature #18057: Introduce Array#mean
- ggmichaelgo, thanks for the reply. I have thought that what you wrote as the comment in the example code snippet are the expected return values. You made clear in note#3 that they are not. Then, what are they representing? If they are ra...
-
01:26 AM Feature #18057: Introduce Array#mean
- Hello Sawa! I apologize for the confusion... (this is my first time contributing, and I am hoping to contribute more :D)
For this function, I am trying to calculate the arithmetic mean.
I have been developing a stock price analytics ... -
01:05 AM Feature #18057: Introduce Array#mean
- The proposal is unclear. It seems to be neither arithmetic nor geometric mean. What kind of average do you have in mind? What is the reason you think that kind of average is particularly needed? What does the block do?
-
12:22 AM Feature #18057: Introduce Array#mean
- I have created PR for this feature :)
https://github.com/ruby/ruby/pull/4699
-
12:02 AM Feature #18057 (Open): Introduce Array#mean
- Introduce Array#average to calculate the average value of an array.
```ruby
array = [1, 2, 3]
array.mean # 2
array = [1.5, 2.2, 3.1]
array.mean(&:round) # 2.3333333333333335
array = [-3, -2, -1]
array.mean { |e| e.abs } # 2
... -
08:23 AM Revision 731315bf (git): Use codeql-config.yml for codeql-action/init
-
08:23 AM Revision 0292ec9b (git): Removed paths-ignore because it's not affect with cpp
-
08:23 AM Revision 954852f7 (git): Removed unnecessary configuration for the latest version of actions/checkout
-
03:39 AM Revision 8b466ea5 (git): Use `${{}}` for if statement
- 03:09 AM Revision 7f4e8680 (git): Fix documentation of #<=> and #casecmp [ci skip]
- Descriptions for return values of -1 and 1 were reversed.
-
03:06 AM Revision 378e8cda (git): Using RBOOL macro
- 01:18 AM Revision 3688b476 (git): * 2021-08-02 [ci skip]
-
01:18 AM Revision 4453280b (git): Stop infinite object allocation to get rid of OOM killer