Activity
From 07/29/2021 to 08/04/2021
08/04/2021
-
09:16 PM Feature #18045: Variable Width Allocation Phase II
- Hello! We’re still looking for feedback on this. If there are no concerns, we’ll merge it next week.
- 08:11 PM Revision bc8bc072 (git): * 2021-08-05 [ci skip]
- 08:11 PM Revision 1fd0a2e4 (git): Reenable GC at the end of test
- The test disables GC but never reenables it. Before this patch, running
all tests would have a peak RSS in the main process of >4GB. After this
patch, peak RSS in the main process is <500MB. -
04:39 PM Bug #18061: Execshield test: libruby.so.N.N.N: FAIL: property-note test because no .note.gnu.property section found
- Thanks for the patch! Let me check it.
-
04:20 PM Bug #18061: Execshield test: libruby.so.N.N.N: FAIL: property-note test because no .note.gnu.property section found
- Does it work just by adding an empty section?
-
- I found an issue in our company's internal test called "execshield" by a security tool annobin - annocheck command [1][2].
```
Hardened: libruby.so.2.7.4: FAIL: property-note test because no .note.gnu.property section found
```
H... -
02:35 PM Revision 042d4c81 (git): Remove an unused variable
-
-
-
-
-
-
-
- Co-authored-by: Koichi Sasada <ko1@atdot.net>
-
-
08:05 AM Bug #14137: Windows / MinGW - Regexp - Character Properties - General Category
- I agree with @jeremyevans0, but would like to add that
```
ruby -e 'p (/\p{L}/.match("a"))'
```
will produce `#<MatchData "a">` also in any situation that is using UTF-8. That will be on almost all current Linux/Unix,... versions, an... -
- Since a3fb97465df3, this string is not inside the here-document.
-
- duerst (Martin Dürst) wrote in #note-6:
> Dan0042 (Daniel DeLorme) wrote in #note-4:
> ...
Sorry, I should have been more specific the first time round. One question is whether extension libraries are allowed to use some flags. The oth... -
- Dan0042 (Daniel DeLorme) wrote in #note-4:
> Actually I have so many questions about flags,...
> ...
Yes, please!
-
03:40 AM Revision 80c180df (git): merge revision(s) b8386f7f7f6d7a7d76481e02d389d0f5211f0f2c:
- Prepend DebugSystem to VCS class only
And revert 24e5f1c982966c379220b1bbb26b4e0320180fa1, pepending to
Kernel did not affect the top level methods before 3.0.
---
tool/lib/vcs.rb | 3 ---
too...
08/03/2021
-
- Dan0042 (Daniel DeLorme) wrote in #note-4:
> I thought it meant those flags have a different usage for each class. No?
Correct.
> ...
Upper 32 bits are not available on 32-bit system of course.
We didn't think those bits were nee... -
03:48 PM Misc #18059: Which FL_USERx are open to extension libraries?
- shyouhei (Shyouhei Urabe) wrote in #note-1:
> The "USER" terminology never seriously meant anything I guess.
I thought it meant those flags have a different usage for each class. No?
Actually I have so many questions about flags, ... -
01:37 PM Misc #18059: Which FL_USERx are open to extension libraries?
- I think it could also make sense to deprecate those macros (e.g., by making them use functions marked as deprecated) and eventually remove them, if no C extension should use them.
That would also mean that e.g. the `date` gem cannot use... -
- Those specs were added because gems rely on it (https://github.com/oracle/truffleruby/issues/1884).
`rbtree3` is an example: https://github.com/kyrylo/rbtree3/blob/850e9d76c22b0766bc2bc36987b11aed05eb2bb4/rbtree.c#L19
`gem-codesearch '... -
03:11 AM Misc #18059: Which FL_USERx are open to extension libraries?
- I guess none of them are open for extension libraries. For instance `FL_USER0` is `FL_SINGLETON`. It is obvious that the flag cannot be abused in any other ways than how we currently use it.
The "USER" terminology never seriously me... -
- Often the following failure occurs in `test-spec`.
```
RBasic support for regular objects supports copying the flags from one object over to the other FAILED
Expected 81920 == 33636352
to be truthy but was false
/tmp/ruby/v3/src/t... -
09:48 PM Misc #18039: DevelopersMeeting20210819Japan
- * [Bug #13392] TracePoint return event location is incorrect for methods defined with define_method (alanwu)
* There are two PRs available, one more complex but opens the possibility for future optimizations. Which do you prefer?
* [... -
- * [Feature #18051] Move symbols exported under internal (nobu)
* Some symbols exported in headers under `internal` are declared and used in some extension libraries.
These seem OK to be moved to public headers.
* `ruby_s... -
- * [Misc #18059] Which `FL_USER`x are open to extension libraries? (nobu)
* (need comment) -
- I implemented an alternative fix that is more complicated but allows for future optimizations here: https://github.com/ruby/ruby/pull/4637
Some relevant details about it are in Jeremy's GitHub PR. -
- The following program loops indefinitely:
```ruby
puts("PID: #{$$}")
class Foo
define_singleton_method(:foo) { return }
end
counter = 0
TracePoint.trace(:b_return) do |tp|
$stdout.write(counter, ' ', tp.inspect, "\r")
... - 08:39 PM Revision 6e8bbabc (git): * 2021-08-04 [ci skip]
- 08:39 PM Revision c463a5e0 (git): Fix indentation in string.c
- 7 spaces were used for 2 levels of indentation. This commit changes it
to use 8 spaces. -
- I see the git:2d4f29e77e883c29e35417799f8001b8046cde03 was pushed as the retry of 13f8521c630a15c87398dee0763e95f59c032a94.
I will pay attention on the RubyCI for a while. - 10:23 AM Revision 2d4f29e7 (git): Fix potential hang when joining threads.
- If the thread termination invokes user code after `th->status` becomes
`THREAD_KILLED`, and the user unblock function causes that `th->status` to
become something else (e.g. `THREAD_RUNNING`), threads waiting in
`thread_join_sleep` will ... -
-
- Applied in changeset commit:git|4c3140d60f6f94504842a4d0c0d79752a87aec8d.
----------
Add keyrest to ruby2_keywords parameters [Bug #18011] - 03:10 AM Revision b5e94916 (git): * 2021-08-03 [ci skip]
-
08/02/2021
-
08:31 PM Bug #18058: 3.1.0-dev with MJIT enabled Zlib::BufError during `gem install`
- Here you go:
```
/usr/local/lib/ruby/3.1.0/rubygems/package.rb:698:in `read': buffer error (Zlib::BufError)
from /usr/local/lib/ruby/3.1.0/rubygems/package.rb:698:in `block in verify_gz'
from /usr/local/lib/ruby/3.1.0/rubygems/pa... -
- > Do you know if we can let Bundler show the backtrace?
It's `rubygems` not bundler. I don't know how make it print the backtrace, but I can take a look. Worst case I can probably directly patch it to let the error bubble up. -
08:26 PM Bug #18058: 3.1.0-dev with MJIT enabled Zlib::BufError during `gem install`
- Do you know if we can let ~~Bundler~~ rubygems (you're right, it wasn't Bundler) show the backtrace? The first step to fix this is to increase reproduction probability, and the backtrace information might be helpful for reproducing the i...
-
- It doesn't always happen (maybe 5-10% of the cases), but since I added MJIT to our CI builds I've been seeing this error a lot.
I was able to reproduce it in `docker run -it rubylang/ruby:master-nightly-bionic` after 15 or so tries:
... -
02:16 PM Feature #18057: Introduce Array#mean
- @nobu - yup, you are correct. The expected behaviour should be like this
```ruby
[1,2].mean #=> 1.5
``` -
- When `ary` has only `Integer`s, `ary.sum` is also an `Integer` and `ary.sum / ary.length` too.
```ruby
[1,2].sum #=> 3
[1,2].sum / 2 #=> 1
```
I don't think this is the expected result, no?
So it should be `ary.sum.quo(ary.leng... -
01:14 PM Feature #18057: Introduce Array#mean
- 💡 You can also use the [Refinements](https://www.alchemists.io/projects/refinements/#_mean) gem which also provides `#mean` support.
-
- Thank you @mrkn!
I didn't know about enumerable-statistics, and I can definitely use this in my projects!!
I wish I knew about it sooner! -
- I definitely prefer using `mean` over `average`!
-
03:41 AM Feature #18057: Introduce Array#mean
- I created [enumerable-statistics gem](https://github.com/mrkn/enumerable-statistics) to provide the methods for calculating precise statistical summary in Array and Enumerable. Does this gem fit your use cases?
I think this is unnece... -
- oh goodness... that is embarrassing... Thank you for catching my error... 🙏
-
01:43 AM Feature #18057: Introduce Array#mean
- ggmichaelgo, thanks for the reply. I have thought that what you wrote as the comment in the example code snippet are the expected return values. You made clear in note#3 that they are not. Then, what are they representing? If they are ra...
-
- Hello Sawa! I apologize for the confusion... (this is my first time contributing, and I am hoping to contribute more :D)
For this function, I am trying to calculate the arithmetic mean.
I have been developing a stock price analytics ... -
- The proposal is unclear. It seems to be neither arithmetic nor geometric mean. What kind of average do you have in mind? What is the reason you think that kind of average is particularly needed? What does the block do?
-
- I have created PR for this feature :)
https://github.com/ruby/ruby/pull/4699
-
- Introduce Array#average to calculate the average value of an array.
```ruby
array = [1, 2, 3]
array.mean # 2
array = [1.5, 2.2, 3.1]
array.mean(&:round) # 2.3333333333333335
array = [-3, -2, -1]
array.mean { |e| e.abs } # 2
... -
08:23 AM Revision 731315bf (git): Use codeql-config.yml for codeql-action/init
-
-
-
- 03:09 AM Revision 7f4e8680 (git): Fix documentation of #<=> and #casecmp [ci skip]
- Descriptions for return values of -1 and 1 were reversed.
-
03:06 AM Revision 378e8cda (git): Using RBOOL macro
- 01:18 AM Revision 3688b476 (git): * 2021-08-02 [ci skip]
-
08/01/2021
-
- ruby_3_0 6f4ab641bb1035c5811e42e43320112e4a502a0e merged revision(s) 345db8f2aa373a31c619c8f85bd372f0a20829c1.
-
- Ignore 7z unless available
`DebugSystem#system` is prepended in vcs.rb and defaulted to
`exception: true`.
---
tool/make-snapshot | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-) -
- Avoid pointless attempts to open .so file if already required
When attempting to require a file without an extension that has
already been required or provided with an .so extension, only
look for files with an .... -
- I think fa0279d947c3962c3f8c32852278d3ebb964cb19 should be backported too.
But it could introduce a tiny incompatibility. I'd like to investigate the another workarounds of the issue. -
- ruby_3_0 0dbb3c15dbe9b7693ea362c94ed8939d20cba083 merged revision(s) b360588cd3cbac5fb4f004aa53a8fdc715906719.
-
- Sort feature index arrays by the priority of file types [Bug #15856]
When looking for libraries to load with a feature name without
extension, `.rb` files are given priority. However, since the
feature index arra... -
-
-
- Maybe only miniruby needs to disable ASLR?
07/31/2021
-
- Applied in changeset commit:git|3b52230452980f3afc6a7380276ea62f7c65e517.
----------
Define functions using rb_wait_for_single_fd [Bug #18046] - 09:49 PM Revision d99b10ac (git): * 2021-08-01 [ci skip]
-
-
05:15 PM Bug #18056 (Third Party's Issue): Found this while running rails server
- This issue is from the sassc gem, not Ruby itself: https://github.com/sass/sassc-ruby/issues/218
-
02:10 PM Bug #18056 (Third Party's Issue): Found this while running rails server
- ``` ruby
-- Crash Report log information --------------------------------------------
See Crash Report log file under the one of following:
* ~/Library/Logs/DiagnosticReports
* /Library/Logs/DiagnosticReports
for mor... -
-
12:30 PM Bug #17561: The timeout option for Addrinfo.getaddrinfo is not reliable on Ruby 2.7.2
- merged into ruby_2_7 at d9ff8b3e86a03499a5c6bc36fae1592914a25b9c
-
01:15 PM Revision 242f024b (git): [ruby/error_highlight] Keep it work if paren exists after receiver
- https://github.com/ruby/error_highlight/commit/b79d679bbd
-
- merged into ruby_2_7 at 2a7235421fcd59b449c84306d059f22b4c5f0865
-
12:27 PM Revision 2a723542 (git): Fix SortedSet not being sorted the first time when rbtree is used
- Fixes [Bug #17841]
- 12:25 PM Revision 4b371d6a (git): * 2021-07-31 [ci skip]
-
- This was already ignored on platforms that do not implement
getaddrinfo_a. Using getaddrinfo_a causes issues with many
calls to Addrinfo.getaddrinfo and also when using
Addrinfo.getaddrinfo with fork.
I would have updated the documentat... -
- Does this work?
```diff
diff --git a/configure.ac b/configure.ac
index d018e8a6f4f..2d91972c218 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1176,6 +1176,10 @@ main()
ac_cv_func_close=no
],
[netbsd*], [ LIBS="-lm $LIBS"
+ AC... - 02:40 AM Revision 4ab52816 (git): * 2021-07-31 [ci skip]
-
- Shell reserved words and special built-in commands can be placed
at only the beginning of the command (except for leading white
spaces). -
01:02 AM Bug #17583: Segfault on large stack(RUBY_THREAD_VM_STACK_SIZE)
- Hi, could you backport this to Ruby 3.0?
07/30/2021
-
- The environment variable `RUBYSHELL` is used only on Windows, as
well as `COMSPEC`. -
- * Use a longer string as <= 23 characters it's embedded on CRuby and
the value of rb_str_capacity() is implementation-specific. -
09:30 AM Feature #18055: Introduce
- Hi Matz!
I see value in it, since it gives us one unified way, to call libraries:
Where ever you do it, when ever you do it, it is always the most optimal choice.
Currently, users shy away from using autoload, since its riddled with u... -
08:06 AM Feature #18055: Introduce
- Can you explain how `introduce` solves the issue? How it is better than `require` and `autoload`?
Matz.
-
- Currently, ``autoload`` provides the ability to load libraries on the fly, also called lazy loading, in order to avoid huge startup times.
This has some disadvantages, who already lead nearly to its [discontinuation](https://bugs.ruby... -
- Do `ext/-test-/thread_fd` directory and `Makefile` there exist?
Probably `make -C ext/-test-/thread_fd_close distclean` may help you.
Although `configure-ext` should remove no longer existing directory but may have a bug for deeper p... -
- Changed since 55bf0ef1aa7c936b564b883196de1ace4be4cc7e.
-
- This test appears to cause failures in some environments.
07/29/2021
-
11:41 PM Bug #18053: Crashes and infinite loops when generating partial backtraces in Ruby 3.0+
- jeremyevans0 (Jeremy Evans) wrote in #note-1:
> At this point, I think reverting the optimization in 3.0 is the best way forward. We can switch to the new algorithm in 3.1. However, if people would like to keep the optimization in 3.0... -
- Thanks for the report. I can confirm both of the issues. I checked with my rewrite of the backtrace generation algorithm (https://github.com/ruby/ruby/pull/4671), and confirmed that it fixes both of these issues, in addition to a separ...
-
- In Ruby 3.0+ there are some cases where generating a partial backtrace will hang (due to an infinite loop) or segfault. This is also an issue in Ruby master.
``` ruby
def foo
caller_locations(2, 1).inspect # this will segv
# ca... -
- When running `make` on the newest `master` checkout, I get the following error:
```
transdb.h unchanged
generating makefiles ext/configure-ext.mk
ext/configure-ext.mk unchanged
make[1]: Entering directory '/home/duerst/ruby3'
mak... -
- Applied in changeset commit:git|9931e2f5091e95dd947de3b3a00167ae2fd5194a.
----------
Improve performance of Integer#digits
This speeds up performance by multiple orders of magnitude for
large integers.
Fixes [Bug #14391]
Co-authored-... -
- This speeds up performance by multiple orders of magnitude for
large integers.
Fixes [Bug #14391]
Co-authored-by: tompng (tomoya ishida) <tomoyapenguin@gmail.com> -
09:09 PM Bug #18046: Missing include leads to build breakage of glib2 on head
- I think either option is okay.
The macro could be considered slight incompatibility since it breaks `have_function` type checks in `extconf.rb` - but consider that we should advise people to avoid these functions if possible, use the ... -
- The problem seems `RUBY_IO_READABLE`,
how about moving the `enum`s to include/ruby/internalintern/io.h?
Or turning the macros into functions again? -
- Applied in changeset commit:git|64ac984129a7a4645efe5ac57c168ef880b479b2.
----------
Make RubyVM::AbstractSyntaxTree.of raise for method/proc created in eval
This changes Thread::Location::Backtrace#absolute_path to return
nil for meth... -
- This changes Thread::Location::Backtrace#absolute_path to return
nil for methods/procs defined in eval. If the realpath of an iseq
is nil, that indicates it was defined in eval, in which case you
cannot use RubyVM::AbstractSyntaxTree.of... -
-
-
-
- https://github.com/ruby/reline/commit/b0b75fcd27
-
- https://github.com/ruby/reline/commit/320f09055c
-
- https://github.com/ruby/reline/commit/8e62e46e33
-
- https://github.com/ruby/reline/commit/de234dc875
- 05:27 PM Revision 5b9f3ed3 (git): [ruby/reline] Fixed Ctrl+Enter key in Windows.
- https://github.com/ruby/reline/commit/0c38e39023
-
- https://github.com/ruby/reline/commit/b60b3b76cd
-
- https://github.com/ruby/reline/commit/9a25ee9f12
-
- OpenBSD doesn't support tiparm, only tparm. I'm not sure if the
two are compatible, but this at least this allows me to run irb
on OpenBSD.
https://github.com/ruby/reline/commit/0ce2b34e2b - 05:27 PM Revision 1bf768d2 (git): [ruby/reline] Added support for Numpad divide key on Windows.
- https://github.com/ruby/reline/commit/84577da0c4
-
- The yamatanooroti gem can't emulate numpad key pressing...
https://github.com/ruby/reline/commit/8e9da1aeaf -
05:27 PM Revision 03f8c271 (git): [ruby/reline] Windows cmd: Don't type anything when pressing ALT keys alone
- Fixes #298
https://github.com/ruby/reline/commit/72acfcd27a -
- https://github.com/ruby/reline/commit/940cdaa301
-
- https://github.com/ruby/reline/commit/a0d946a398
-
- https://github.com/ruby/reline/commit/17721e477e
-
- https://github.com/ruby/reline/commit/7ef9805b35
-
- This was fixed in commit:230111802c2b9dcb8f391b489ff52a9dc0b41b87.
-
01:55 PM Bug #18052 (Closed): Find のignore_error オプションが、文字化けファイル遭遇時の例外に対応していない (Windows)
Find.find(".", ignore_error: true ) を指定しても、文字化けするファイルに出会った場合には、
ignore せずに例外を起こしてしまうようです。
https://docs.ruby-lang.org/ja/latest/class/Find.html
# Background
C:\>ver
Microsoft Windows [Version 10.0.19043.1110]
C:\ruby -v
r...-
- Applied in changeset commit:git|87b327efe6c1f456c43b3f105c7a92a5a7effe93.
----------
Do not check pending interrupts when running finalizers
This fixes cases where exceptions raised using Thread#raise are
swallowed by finalizers and no... -
- Applied in changeset commit:git|87b327efe6c1f456c43b3f105c7a92a5a7effe93.
----------
Do not check pending interrupts when running finalizers
This fixes cases where exceptions raised using Thread#raise are
swallowed by finalizers and no... -
- This fixes cases where exceptions raised using Thread#raise are
swallowed by finalizers and not delivered to the running thread.
This could cause issues with finalizers that rely on pending interrupts,
but that case is expected to be ra... -
- On -DUSE_EMBED_CI=0, there are more GC allocations and the old code
didn't keep old_operands[0] reachable while allocating. On a Debian
based system, I get a crash requiring erb under GC stress mode. On
macOS, tool/transcode-tblgen.rb ru... - 03:14 PM Revision 12d4da74 (git): * 2021-07-30 [ci skip]
-
- Point out that the method should be used for backwards compatibility
with code prior to Ruby 3.0 instead of Ruby 2.7. It's still needed
in Ruby 2.7. It isn't needed in Ruby 3.0, as the methods using it
could switch to delegating both po... -
- Update bundled_gems to pass test-bundled-gems on macOS.
---
gems/bundled_gems | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Update bundled_gems
---
gems/bundled_gems | 2 +-
... -
-
-
-
-
- 06:54 AM Revision e99d2d06 (git): [ruby/psych] fix: use git repository link for LibYAML in docs
- LibYAML has moved from their previous Mercurial based hosting on BitBucket to a git repository on GitHub. This commit updates the `Psych` module's documentation to point to this new repository, instead of the old one which is now a 404.
... - 06:54 AM Revision b11638ee (git): [ruby/psych] require 'delegate' explicitly
- https://github.com/ruby/psych/commit/51a9ce13db
- 06:53 AM Revision 60b02db5 (git): [ruby/net-http] Enforce write timeout when body_stream is used
- The existing implementation of `Net::HTTP#write_timeout` relies on
`Net::BefferedIO` to trigger the `Net::WriteTimeout` error. This commit
changes `send_request_with_body_stream` to remove the optimization that
was making `Net::HTTP#writ... -
-
05:18 AM Revision 1e04571d (git): [ruby/set] Improve What's Here links
- https://github.com/ruby/set/commit/76b056c3b9
-
- https://github.com/ruby/set/commit/dd787a3988
-
05:18 AM Revision 899194f3 (git): [ruby/set] gemspec: This gem exposes 0 executables
- This change removes unused configuration.
https://github.com/ruby/set/commit/6c2338d699 -
- https://github.com/ruby/set/commit/35b69e9d69
-
- https://github.com/ruby/set/commit/1a73ab9047
-
- Implements [Feature #17838]
https://github.com/ruby/set/commit/d9b389bafa -
04:51 AM Revision 27fb9d27 (git): test/socket/test_socket.rb: skip on Solaris
- The test fails on Solaris 10. Maybe due to the IPv6 configuration on the
server, but I have no idea at all. I've asked @ngoto to investigate the
issue, so will tentatively skip the tests on Solaris
http://rubyci.s3.amazonaws.com/solaris... -
-
01:49 AM Revision 656b49ec (git): Bundle RBS 1.3.3 (#4688)