Project

General

Profile

Activity

From 07/19/2021 to 07/25/2021

07/25/2021

08:09 PM Bug #16608 (Closed): ConditionVariable#wait should return false when timeout exceeded
Applied in changeset commit:git|070557afc4ca83876b951fe090806b59e3867ae5.
----------
Distinguish signal and timeout [Bug #16608]
nobu (Nobuyoshi Nakada)
08:09 PM Revision 165a098f (git): * 2021-07-26 [ci skip]
git[bot]
08:09 PM Revision 070557af (git): Distinguish signal and timeout [Bug #16608]
nobu (Nobuyoshi Nakada)
06:47 PM Bug #18043 (Third Party's Issue): pod install failed on iMac (24-inch, M1, 2021) macOS Big Sur Version: 11.4 (20F71)
jeremyevans0 (Jeremy Evans)
11:26 AM Bug #18043: pod install failed on iMac (24-inch, M1, 2021) macOS Big Sur Version: 11.4 (20F71)
The same as #17988 (and others related to Ethon on M1 Mac). Should be closed as a third party's issue. xtkoba (Tee KOBAYASHI)
10:25 AM Bug #18043 (Third Party's Issue): pod install failed on iMac (24-inch, M1, 2021) macOS Big Sur Version: 11.4 (20F71)
% pod install
Analyzing dependencies
/Library/Ruby/Gems/2.6.0/gems/ffi-1.15.3/lib/ffi/library.rb:275: [BUG] Bus Error at 0x0000000104838000
ruby 2.6.3p62 (2019-04-16 revision 67580) [universal.arm64e-darwin20]
-- Control frame inform...
rahulshinde (Rahul Shinde)
05:36 PM Bug #18018: Float#floor / truncate sometimes result that is too small.
jeremyevans0 (Jeremy Evans) wrote in #note-3:
> This issue also goes the other direction:
> ...
Well, that `f` *is* the same float (291.4), I don't understand your point, sorry.
> marcandre (Marc-Andre Lafortune) wrote:
> ...
Maybe...
marcandre (Marc-Andre Lafortune)
03:13 PM Bug #15856: Performance of redundant `Kernel.require` is slow when many gems are activated
Thanks for working on this and coming up with a 100% backwards compatible fix! <3 deivid (David Rodríguez)
11:08 AM Bug #15856 (Closed): Performance of redundant `Kernel.require` is slow when many gems are activated
Applied in changeset commit:git|b360588cd3cbac5fb4f004aa53a8fdc715906719.
----------
Sort feature index arrays by the priority of file types [Bug #15856]
When looking for libraries to load with a feature name without
extension, `.rb` f...
nobu (Nobuyoshi Nakada)
11:58 AM Revision 8897098b (git): Update bundled_gems
znz (Kazuhiro NISHIYAMA)
11:07 AM Revision 02facb86 (git): * 2021-07-25 [ci skip]
git[bot]
05:51 AM Revision e2aaed04 (git): merge revision(s) 292230cbf926e9892596ea37fd4567f0c49ab73c:
Fixed leaked global symbols
---
gc.c | 14 +++++++++-----
vm_insnhelper.c | 7 ++++---
vm_insnhelper.h | 2 +-
vm_sync.c | 4 ++--
vm_sync.h | 6 ++++--
...
nagachika (Tomoyuki Chikanaga)
05:19 AM Revision 0a5f22cc (git): merge revision(s) 73cd4951de20bf989747013b1e62a202f12ac2d2,6e6be107dd0c820afc4db68d09110ad96c4aebdd:
Reduced GitHub Actions
Moved leaked-globals before check.
---
.github/workflows/macos.yml | 4 +++-
.github/workflows/ubuntu.yml | 8 +++-----
2 files changed, 6 insertions(+), 6 deletions(-)
...
nagachika (Tomoyuki Chikanaga)
05:11 AM Bug #17666: Thread#join hangs when Fiber.set_scheduler is set
ruby_3_0 95dc88c88869541dd0eccafd14924d78c8d7f427 merged revision(s) 5f69a7f60467fa58c2f998daffab43e118bff36c. nagachika (Tomoyuki Chikanaga)
04:49 AM Revision 95dc88c8 (git): partially merge revision(s) 5f69a7f60467fa58c2f998daffab43e118bff36c: [Backport #17666]
Co-authored-by: Samuel Williams <@ioquatix>
https://github.com/nagachika/ruby/pull/1/commits/2cee515f024f3295945f312cb6b052f972f9c93d
nagachika (Tomoyuki Chikanaga)
04:47 AM Revision dc7ad028 (git): bump up bundled rbs and typeprof version to pass test-bundled-gems.
nagachika (Tomoyuki Chikanaga)
04:13 AM Revision ec5bc132 (git): bump up bundled rbs and typeprof version to pass test-bundled-gems.
nagachika (Tomoyuki Chikanaga)

07/24/2021

02:59 PM Revision b360588c (git): Sort feature index arrays by the priority of file types [Bug #15856]
When looking for libraries to load with a feature name without
extension, `.rb` files are given priority. However, since the
feature index arrays were not in that order of priority, but in
the order in which they were loaded, a lower pri...
nobu (Nobuyoshi Nakada)
08:58 AM Revision 971d24cd (git): * 2021-07-24 [ci skip]
git[bot]
05:31 AM Revision eec45a93 (git): Escape unprintable chars only, without surrounding quotes
nobu (Nobuyoshi Nakada)

07/23/2021

10:27 PM Bug #18018 (Feedback): Float#floor / truncate sometimes result that is too small.
The algorithm for `Float#floor` with the `ndigits` argument is basically (omitting the overflow/underflow handling):
```ruby
class Float
def floor_ndigits(ndigits)
x = (10**ndigits).to_f
(self * x).floor / x
end
end
...
jeremyevans0 (Jeremy Evans)
09:30 PM Bug #17728 (Closed): [BUG] Segmentation fault at 0x0000000000000000
jeremyevans0 (Jeremy Evans)
07:38 PM Bug #15856: Performance of redundant `Kernel.require` is slow when many gems are activated
I've reviewed @nobu's patch and think that we should go with that approach. It avoids the backwards compatibility issues with @deivid's approach while still fixing the performance issue. I submitted a pull request for it: https://githu... jeremyevans0 (Jeremy Evans)
07:15 PM Bug #13154 (Rejected): URI::Generic, == operator, normalize!
I agree with @phluid61, plain path provided to `URI.parse` should not be treated as implicit `file` scheme. Such a change would break backwards compatibility for the methods mentioned, and I think `URI.parse('http://foo/bar').merge(URI.... jeremyevans0 (Jeremy Evans)
07:08 PM Feature #10473: Change Date#to_datetime to use local time
I don't think this is a bug. `Time` defaults to local time, and `DateTime` to UTC:
```ruby
Time.parse('2021-07-23')
# => 2021-07-23 00:00:00 -0700
DateTime.parse('2021-07-23')
#<DateTime: 2021-07-23T00:00:00+00:00 ((2459419j,0s...
jeremyevans0 (Jeremy Evans)
04:22 PM Feature #18042 (Feedback): YARV code optimization
Hi! Long period of time I think about programmatically code optimization for YARV. In compiled languages like C/C++ the compiler can do whatever it wants with the code and does for performance optimization. Firstly, ruby developers think... motoroller (Iskandar Gohar)
10:01 AM Bug #17429: Prohibit include/prepend in refinement modules
shugo (Shugo Maeda) wrote in #note-22:
> In the current implementation, the module in cref is replaced with the refinement like Module#dup, so constants in the imported module are not accessible from the copied methods.
Could you sho...
Eregon (Benoit Daloze)
03:43 AM Revision 8cc18703 (git): [NEWS] added [Feature #17798] [ci skip]
nobu (Nobuyoshi Nakada)
03:41 AM Revision 53857313 (git): [NEWS] adjusted formats [ci skip]
nobu (Nobuyoshi Nakada)
03:01 AM Feature #17798 (Closed): exception in finalizer
Applied in changeset commit:git|fc4dd45d0142221880d1b2c9b54dee0597be2b78.
----------
Show exception in finalizer [Feature #17798]
nobu (Nobuyoshi Nakada)
03:01 AM Revision 37799503 (git): Suppress exception message in finalizer [Feature #17798]
nobu (Nobuyoshi Nakada)
03:01 AM Revision fc4dd45d (git): Show exception in finalizer [Feature #17798]
nobu (Nobuyoshi Nakada)
03:01 AM Revision 63e5f4df (git): Access rb_execution_context_t::errinfo directly
nobu (Nobuyoshi Nakada)
01:25 AM Revision b726c4ee (git): Use rb_equal
It can be optimized and handles Qnil properly. nobu (Nobuyoshi Nakada)
01:25 AM Revision 4da07ac2 (git): Finalizers no longer store the safe level
nobu (Nobuyoshi Nakada)

07/22/2021

09:02 PM Bug #18041 (Feedback): [BUG] Segmentation fault - ruby 2.5.8p224 (2020-03-31 revision 67882) [aarch64-linux]
applenotbanana (Apple Banana) wrote in #note-1:
> is it problem with excon?
Excon is a pure ruby gem, and the segfault appears to occur in openssl, so my guess would be no. In any case, Ruby 2.5 is no longer supported, Please try wi...
jeremyevans0 (Jeremy Evans)
08:36 PM Bug #18041: [BUG] Segmentation fault - ruby 2.5.8p224 (2020-03-31 revision 67882) [aarch64-linux]
is it problem with excon? applenotbanana (Apple Banana)
08:31 PM Bug #18041 (Closed): [BUG] Segmentation fault - ruby 2.5.8p224 (2020-03-31 revision 67882) [aarch64-linux]
/usr/local/lib/ruby/2.5.0/openssl/buffering.rb:388: [BUG] Segmentation fault at 0x0020ffffaf56467c
ruby 2.5.8p224 (2020-03-31 revision 67882) [aarch64-linux]
-- Control frame information ----------------------------------------------...
applenotbanana (Apple Banana)
06:13 PM Revision fc78a089 (git): * 2021-07-23 [ci skip]
git[bot]
06:13 PM Revision 86e0eecc (git): [ruby/irb] Fix #256
Support int that follow on symbeg in IRB
https://github.com/ruby/irb/commit/90cb27b1bd
osyo (manga osyo)
03:55 PM Feature #17798: exception in finalizer
https://github.com/ruby/ruby/pull/4670 nobu (Nobuyoshi Nakada)
02:10 PM Revision 62661dd9 (git): Don't recompute the heap page
We already page the page of the zombie calculated. Don't recalculate the
page.
peterzhu2118 (Peter Zhu)
02:10 PM Revision 018f3961 (git): Don't set flags in finalize_list
The call after it to `heap_page_add_freeobj` will set the flags. peterzhu2118 (Peter Zhu)
06:41 AM Revision 75f60e5a (git): Sort out quad_t related macros
nobu (Nobuyoshi Nakada)
06:41 AM Revision fc50b2ea (git): Remove unneeded function declarations
S_H_ (Shun Hiraoka)
05:10 AM Revision e4b68ab7 (git): [DOC] Fixed the description of regexp alternations [ci skip]
Ulysses Zhan
05:02 AM Revision d6b8819b (git): Refactor rb_proc_call_with_block function
S_H_ (Shun Hiraoka)
05:02 AM Revision e882905d (git): Refactor sym_each_i function
S_H_ (Shun Hiraoka)
02:56 AM Bug #17666: Thread#join hangs when Fiber.set_scheduler is set
Thank you for your confirmation and adding a test!
I will create a patch for ruby_3_0 branch based on your pull request.
nagachika (Tomoyuki Chikanaga)
02:48 AM Bug #18014: Memory leak in GC when using Ractors
ruby_3_0 a215c6d0448764131cbbb48b476dc698b51c2273 merged revision(s) 119697f61e2b2b157816a8aa33aada5863959900,4a627dbdfd1165022fa9e716ba845e937b03773d. nagachika (Tomoyuki Chikanaga)
02:45 AM Bug #18014: Memory leak in GC when using Ractors
Thank you for reviewing. I will commit the patch soon. nagachika (Tomoyuki Chikanaga)
02:48 AM Revision 186900d1 (git): * 2021-07-22 [ci skip]
git[bot]
02:47 AM Revision a215c6d0 (git): partially merge revision(s) 119697f61e2b2b157816a8aa33aada5863959900,4a627dbdfd1165022fa9e716ba845e937b03773d: [Backport #18014]
[Bug #18014] Fix rb_gc_force_recycle unmark before sweep
If we force recycle an object before the page is swept, we should clear
it in the mark bitmap. If we don't clear it in the bitmap, then during
sweeping we ...
nagachika (Tomoyuki Chikanaga)
12:58 AM Revision e3cda754 (git): Remove useless casts
nobu (Nobuyoshi Nakada)
12:52 AM Revision a4e39112 (git): Cast to size_t instead of int
len and *retlen are size_t since r22957
(commit:4de12b6ae9a7fc1e28ada4b62291a78f28ae7528).
nobu (Nobuyoshi Nakada)

07/21/2021

06:40 PM Revision 31144fe9 (git): Change GC verification to walk all pages
`gc_verify_internal_consistency_` does not walk pages in the tomb heap
so numbers were off. This commit changes it to walk all allocated pages.
peterzhu2118 (Peter Zhu)
05:07 PM Bug #18038 (Closed): Invalid interpolation in heredocs
Applied in changeset commit:git|b940a453572b5c3ed5c0951647929e14f5843a7d.
----------
Fix interpolated heredoc
This fixes https://bugs.ruby-lang.org/issues/18038. The provided
reproduction showed that this happens in heredocs with doubl...
eileencodes (Eileen Uchitelle)
05:06 PM Revision f5f70106 (git): * 2021-07-22 [ci skip]
git[bot]
05:06 PM Revision b940a453 (git): Fix interpolated heredoc
This fixes https://bugs.ruby-lang.org/issues/18038. The provided
reproduction showed that this happens in heredocs with double
interpolation. In this case `DSTR` was getting returned but needs to be
convered to a `EVSTR` which is what is...
eileencodes (Eileen Uchitelle)
11:44 AM Revision fa308a68 (git): Update bundled_gems
nobu (Nobuyoshi Nakada)
11:44 AM Revision c25cf1ea (git): Drop optional commit hash when updated
nobu (Nobuyoshi Nakada)
10:32 AM Revision 04b5e85b (git): Look up ruby_digit36_to_number_table
Instead of scanning ruby_hexdigits. nobu (Nobuyoshi Nakada)
08:40 AM Revision b2749e00 (git): * 2021-07-21 [ci skip]
git[bot]
07:28 AM Revision 1c80e0e6 (git): Use typeprof supporting rbs 1.3
nobu (Nobuyoshi Nakada)

07/20/2021

10:37 PM Bug #17486: Build fails on darwin due to libtool being removed
> ld: warning: ignoring file ../../libruby.3.0-static.a, building for macOS-x86_64 but attempting to link with file built for macOS-x86_64
This message appears to be contradictory.
Isn’t `ranlib` working?
nobu (Nobuyoshi Nakada)
04:55 PM Bug #17486: Build fails on darwin due to libtool being removed
This is still failing for me on Big Sur with 3.0.2. I have made sure to uninstall gmake and coreutils from MacPorts but it is still failing. If I revert commit I mentioned in the original report then it builds fine on Big Sur under all c... dark.panda (J Smith)
07:41 PM Bug #18038: Invalid interpolation in heredocs
I opened a PR here: https://github.com/ruby/ruby/pull/4664
I also confirmed that this is broken in the same way in Ruby 2.5, 2.6, and 2.7
eileencodes (Eileen Uchitelle)
01:26 PM Feature #18040 (Rejected): Why should `foo(1 if true)` be an error?
One way to see it is to just forget that Jeremy called it statement.
One of the parser rule is named `stmt` and yes the produced AST node does return a value, like everything in Ruby.
It's not realistic for the Ruby grammar to accomm...
Eregon (Benoit Daloze)
08:27 AM Feature #18040: Why should `foo(1 if true)` be an error?
> implicit casting from a statement to an expression within a method definition body
It's not just the method body, `x if y` without parens is an expression in any compound expression block which evaluates to its last expression value...
bughit (bug hit)
05:53 AM Feature #18040: Why should `foo(1 if true)` be an error?
It looks like the reason bughit is insisting is because of the description in the book that they cite. And indeed, if `1 if false` in the method definition given in note 3 is not an expression, then `2` is, and it could be taken that the... sawa (Tsuyoshi Sawada)
12:46 PM Feature #17745 (Closed): `IO#close_on_exec=` returns different value when called with `send, __send__, public_send` or not
Applied in changeset commit:git|42745ecae3ce95774f2fcc66467320471ca0460a.
----------
Remove meaningless IO#close_on_exec= spec [Feature #17745]
nobu (Nobuyoshi Nakada)
12:45 PM Revision 42745eca (git): Remove meaningless IO#close_on_exec= spec [Feature #17745]
nobu (Nobuyoshi Nakada)
12:45 PM Revision bc1323ce (git): Use RB_INTEGER_TYPE_P
nobu (Nobuyoshi Nakada)
11:36 AM Revision 261dca2e (git): [ruby/irb] Support non-English code page message
https://github.com/ruby/irb/commit/e7d71fea46 aycabta (aycabta .)
08:47 AM Bug #12235: URI.encode issue with square brackets
I just ran into this. My app is generating URLs which it cannot then parse. robb (Robb Shecter)
07:53 AM Bug #17429: Prohibit include/prepend in refinement modules
Eregon (Benoit Daloze) wrote in #note-20:
> One more issue reported due these confusing semantics of include/prepend inside `refine`: #18021.
> ...
I've implemented Refinement#import in https://github.com/shugo/ruby/pull/3
In the cu...
shugo (Shugo Maeda)
05:47 AM Revision 5e7675d4 (git): * 2021-07-20 [ci skip]
git[bot]
05:46 AM Revision 2e670430 (git): Use UNREACHABLE instead of fall through
znz (Kazuhiro NISHIYAMA)

07/19/2021

08:41 PM Feature #18040: Why should `foo(1 if true)` be an error?
bughit (bug hit) wrote in #note-5:
> jeremyevans0 (Jeremy Evans) wrote in #note-4:
> ...
The reason that `foo(1 if false)` is a syntax error is due to a parsing failure. The parser considers it a statement (`stmt`) and not an expressi...
jeremyevans0 (Jeremy Evans)
07:56 PM Feature #18040: Why should `foo(1 if true)` be an error?
jeremyevans0 (Jeremy Evans) wrote in #note-4:
> You may want to read the definition of `stmt` in parse.y, particularly this part: https://github.com/ruby/ruby/blob/eed5e8f796ab18e2e0a436dab83e35504ae3ded0/parse.y#L1481
You can call it a...
bughit (bug hit)
07:23 PM Feature #18040: Why should `foo(1 if true)` be an error?
bughit (bug hit) wrote in #note-2:
> jeremyevans0 (Jeremy Evans) wrote in #note-1:
> ...
You may want to read the definition of `stmt` in parse.y, particularly this part: https://github.com/ruby/ruby/blob/eed5e8f796ab18e2e0a436dab83e35...
jeremyevans0 (Jeremy Evans)
07:22 PM Feature #18040: Why should `foo(1 if true)` be an error?
```rb
def foo
2
1 if false
end
p foo
```
foo returns nil, the value of the last expression `1 if false`, no parens required since there's no ambiguity, as there isn't any in `foo(1 if true)`
bughit (bug hit)
07:11 PM Feature #18040: Why should `foo(1 if true)` be an error?
jeremyevans0 (Jeremy Evans) wrote in #note-1:
> `1 if true` is a statement and not an expression
`1 if true` is an expression (as pretty much everything in ruby) whose value is nil, if the condition is false, else the modified subexp...
bughit (bug hit)
07:03 PM Feature #18040: Why should `foo(1 if true)` be an error?
`1 if true` is a statement and not an expression, and you can only pass expressions as method arguments. `(1 if true)` is an expression, which is why it is allowed. Consider how `foo(1 if true)` would work with multiple arguments, and yo... jeremyevans0 (Jeremy Evans)
06:47 PM Feature #18040 (Rejected): Why should `foo(1 if true)` be an error?
There's no ambiguity here that should require another set of parens `foo((1 if true))` bughit (bug hit)
08:51 AM Misc #18017: Broken links from Revision e86c1f6f to changed files
I've seen many times as well. Sometimes refreshing the page works. Eregon (Benoit Daloze)
05:13 AM Misc #18017 (Closed): Broken links from Revision e86c1f6f to changed files
I already filed this issue to https://github.com/ruby/b.r-l.o/issues/124 . But I have no enough time to investigate this. Sorry.
hsbt (Hiroshi SHIBATA)
08:21 AM Revision 036f26a4 (git): Add `fall through`
Pointed out by Coverity Scan
```
** CID 1487522: Control flow issues (MISSING_BREAK)
/error.c: 1273 in exc_full_message()
```
znz (Kazuhiro NISHIYAMA)
08:18 AM Revision fa239e04 (git): Remove unneeded quotes [ci skip]
nobu (Nobuyoshi Nakada)
07:46 AM Misc #10032 (Closed): Matrix classについて
Matrix has been extracted as the bundled gem for Ruby 3.1. We can discuss about Matrix class on https://github.com/ruby/matrix hsbt (Hiroshi SHIBATA)
02:59 AM Revision 95dd4613 (git): [ruby/racc] Removed pre-setup from gemspec
https://github.com/ruby/racc/commit/2f6f02e5c1 hsbt (Hiroshi SHIBATA)
02:59 AM Revision dbcfc8d4 (git): [ruby/racc] Removed needless files from gemspec
https://github.com/ruby/racc/commit/d044ae883f hsbt (Hiroshi SHIBATA)
02:59 AM Revision b5b3cd27 (git): [ruby/racc] Move document from library directory
https://github.com/ruby/racc/commit/2e8d7d286d hsbt (Hiroshi SHIBATA)
02:54 AM Revision 7217f60b (git): [ruby/racc] Removed generate code from parser.rb. It's already migrated by rake task
https://github.com/ruby/racc/commit/ec7d01980a hsbt (Hiroshi SHIBATA)
01:57 AM Revision ab2bd3ff (git): test/openssl/test_x509cert.rb: Prevent "unused variable" warning
mame (Yusuke Endoh)
01:34 AM Revision 91ffce8f (git): [ruby/did_you_mean] Prevent "warning: ambiguity between regexp and two divisions"
```
test/did_you_mean/spell_checking/test_uncorrectable_name_check.rb:13: warning: ambiguity between regexp and two divisions: wrap regexp in parentheses or add a space after `/' operator
```
http://rubyci.s3.amazonaws.com/ubuntu/ruby-ma...
mame (Yusuke Endoh)
 

Also available in: Atom