Activity
From 06/24/2021 to 06/30/2021
06/30/2021
-
11:57 PM Bug #17885: require_relative and require should be compatible with each other when symlinked files are used
- I've submitted a pull request to prevent loading the same realpath multiple times: https://github.com/ruby/ruby/pull/4615
- 11:23 PM Revision 1467328e (git): More general matrix "configure" parameter, add `--with-coroutine=pthread`.
- 11:23 PM Revision 42130a64 (git): Replace copy coroutine with pthread implementation.
-
09:42 PM Revision 9c953195 (git): rbinstall.rb: get rid of making directories when dryrun
- 08:16 PM Revision 8ee24840 (git): [ruby/irb] Update ls.rb without requiring Set, because Set is one of standard libraries
- https://github.com/ruby/irb/commit/7092ad2ab5
- 08:12 PM Revision 518d3938 (git): * 2021-07-01 [ci skip]
-
08:12 PM Revision 4a3df352 (git): Use stride passed into os_obj_of_i
-
-
02:26 PM Feature #17992: Upstreaming the htmlentities gem into CGI#.(un)escape_html
- I'm reasonably convinced that augmenting the existing `unescapeHTML` API is off the table, for performance reasons.
I plan to add this under a new `(de|en)code_html_entities` name.
It could be parameterized just like HTMLEntities, ... -
08:48 AM Feature #17992: Upstreaming the htmlentities gem into CGI#.(un)escape_html
- Sorry, forgot to give a link to a human-readable table of html5 entities: https://html.spec.whatwg.org/multipage/named-characters.html#named-character-references.
-
- It is difficult to make this complete without overdoing it because there are many different kinds of entity sets. The htmlentities gem distinguishes three (html4, xhtml1, and expanded). Both html4 and xhtml1 come in at around 250 entitie...
-
- Eregon (Benoit Daloze) wrote in #note-12:
> and if possible one that does not involve twice the number of heredocs than needed.
It is intentional to indent inside here-docs and separate interpolation-enabled and -disabled parts.
-
12:06 PM Revision acbddbe6 (git): [ruby/irb] Rescue a specific error
- Rescuing StandardError is prone to bugs caused by a typo or obsoleted methods.
https://github.com/ruby/irb/commit/eb5260fcd5 -
11:55 AM Revision e8c2b03e (git): [ruby/irb] Fix error on `ls object_cant_define_singleton`
- such as `ls 42`, `ls :sym` and so on
https://github.com/ruby/irb/commit/b1d436a853 -
-
08:33 AM Revision b6c910e1 (git): [ruby/error_highlight] Allow the development version (= master branch) of Ruby 3.1
- https://github.com/ruby/error_highlight/commit/2dca1446c9
-
-
06:36 AM Feature #18015: Replace copy coroutine with pthread implementation.
- +1
-
04:29 AM Feature #18015: Replace copy coroutine with pthread implementation.
- This is currently blocking <https://bugs.ruby-lang.org/issues/18005>. Pull request: <https://github.com/ruby/ruby/pull/4606>.
-
- The copy coroutine is unique in that it uses a private stack area. It is also tricky to implement as it uses setjmp/longjmp to update the stack & instruction pointer. Because of this, pointers to stack allocated data are only valid while...
-
06:03 AM Bug #18016 (Closed): fiddle\types.rb typealias maybe wrong
- in ...\lib\ruby\3.0.0\fiddle\types.rb
module Fiddle
module Win32Types
def included(m) # :nodoc:
m.module_eval{
# ...
typealias "HANDLE", "uintptr_t"
# ...
typealias "HINSTANCE", "unsi... -
-
-
- https://github.com/ruby/error_highlight/commit/8d483c251e
-
- https://github.com/ruby/error_highlight/commit/acb2046a82
-
- https://github.com/ruby/error_highlight/commit/f40a1de20e
-
- https://github.com/ruby/error_highlight/commit/e0c90c72c3
-
-
01:58 AM Bug #17887 (Closed): Missed constant lookup after prepend
- Applied in changeset commit:git|3dd3ea092acead6179033f2c95525ffc5b8bb6ff.
----------
Use Module#ancestors order in recursive constant lookup
Before this commit, const_get with inherit=true and constant lookup
expressions searched the a... -
-
- Before this commit, const_get with inherit=true and constant lookup
expressions searched the ancestors of the starting point in an order
different from `starting_point.ancestors`.
Items in the ancestry list introduced through prepend we... -
- Applied in changeset commit:git|8118d435d000adec3023a0ff509baa11cc73fabb.
----------
rb_warn_deprecated_to_remove_at [Feature #17432]
At compilation time with RUBY_DEBUG enabled, check if the removal
version has been reached. - 01:47 AM Revision dcd1eedb (git): * 2021-06-30 [ci skip]
-
-
-
-
- At compilation time with RUBY_DEBUG enabled, check if the removal
version has been reached.
06/29/2021
-
- # GitHub PR: https://github.com/ruby/ruby/pull/4613
When a Ractor is removed, the freelist in the Ractor cache is not returned to the GC, leaving the freelist permanently lost.
The following script demonstrates the issue. It iterat... -
-
- I've merged my PR https://github.com/ruby/ruby/pull/4586, created a new repository https://github.com/ruby/error_highlight
, and released a new gem https://rubygems.org/gems/error_highlight.
I will monitor the CI, but please let me k... -
- Eregon (Benoit Daloze) wrote in #note-3:
> IMHO in Ruby 3+ it should return `[[:rest, :*], [:keyrest, :**], [:block, :&]]`.
> ...
I think methods that use `ruby2_keywords`, either explicitly or implicitly through argument forwarding, s... -
09:58 AM Bug #18011: `Method#parameters` is incorrect for forwarded arguments
- IMHO in Ruby 3+ it should return `[[:rest, :*], [:keyrest, :**], [:block, :&]]`.
The fact that it uses `ruby2_keywords` internally is an implementation detail that I don't think needs to leak into Method#parameters. -
06:09 AM Bug #18011: `Method#parameters` is incorrect for forwarded arguments
- jeremyevans0 (Jeremy Evans) wrote in #note-1:
> Forwarded arguments is implemented as `(*args, &block)` with `ruby2_keywords`, not as `(*args, **kwargs, &block)`. If you add `def wrapper4(*r, &b) = wrapped(*r, &b),` to `methods` and the... -
- Forwarded arguments is implemented as `(*args, &block)` with `ruby2_keywords`, not as `(*args, **kwargs, &block)`. If you add `def wrapper4(*r, &b) = wrapped(*r, &b),` to `methods` and then `ruby2_keywords :wrapper4` after `methods`, you...
-
- When asking a method about its parameters, forwarded arguments say they are a rest and a block (`wrapper1` in the example below).
However, when we use that signature, it raises an ArgumentError (`wrapper2` in the example below).
When I... -
- This hack should be removed after the minitest side is updated.
https://github.com/seattlerb/minitest/pull/880 -
-
- ```
$ ./local/bin/ruby -e '1.time {}'
-e:1:in `<main>': undefined method `time' for 1:Integer (NoMethodError)
1.time {}
^^^^^
Did you mean? times
```
https://bugs.ruby-lang.org/issues/17930 -
- When running btest there is a crash when compiled with
RGENGC_CHECK_MODE=4. The crash happens because `during_gc` is not
turned off before `gc_marks_check` is called, causing the marking to
happen on the main mark stack instead of mark s... -
12:05 PM Bug #18013: Unexpected results when mxiing negated character classes and case-folding
- duerst (Martin Dürst) wrote in #note-2:
> Just a question: What's the purpose of nested character classes?
They are useful in combination with the set intersection operator `&&`. They let you, e.g., exclude characters from some chara... -
- Just a question: What's the purpose of nested character classes?
I didn't even know that there was such a thing as nested character classes.
Depending on the purpose of nested character classes, the right way to handle things may d... -
- This is a simpler reproducer.
```
irb(main):003:0> /[^a]/i.match("a")
=> nil
irb(main):004:0> /[[^a]]/i.match("a")
=> #<MatchData "a">
``` -
- ```
irb(main):001:0> /[^a-c]/i.match("A")
=> nil
irb(main):002:0> /[[^a-c]]/i.match("A")
=> #<MatchData "A">
```
The two regular expressions above match different strings, because the character classes denote different sets of ch... - 11:54 AM Revision 5e75280c (git): Add basic test for updated IO wait functions.
-
- Some Unicode characters case-fold to strings of multiple code points, e.g. the ligature `\ufb00` can match the string `ff`.
```
irb(main):001:0> /\A[\ufb00]\z/i.match("\ufb00")
=> #<MatchData "ff">
irb(main):002:0> /\A[\ufb00]\z/i.m... -
08:28 AM Feature #16978: Ruby should not use realpath for __FILE__
- > Unfortunately, if __FILE__ uses realpath, unless you also change the behavior of $0
The "entrypoint" script could behave differently, but maybe that would be confusing. -
- Make description more readable.
-
- ... instead of exact matching. I'm now creating a built-in gem that
modifies Exception's error message, so the expectation value is changed.
IMO, it is good to check that did_you_mean suggestion is NOT added in
the uncorrectable case.
... -
- Previously, did_you_mean used `msg.end_with?(suggestion)` to check if
its suggestion is already added.
I'm now creating a gem that also modifies Exception's message. This
breaks did_you_mean's duplication check.
This change makes the ch... -
- Previously, DidYouMean::Correctable#original_message did
`method(:to_s).super_method.call` to call the original to_s method by
skipping Correctable#to_s.
I'm now creating a gem that prepends another to_s method to NameError,
which confu... -
- https://github.com/ruby/did_you_mean/commit/fbe5aaaae8
- 06:49 AM Revision 8356d9e3 (git): Start v1.6.0 development
- https://github.com/ruby/did_you_mean/commit/3f69171813
-
06/28/2021
-
- Applied in changeset commit:git|d795f494a89e0d9498dfedc54b8a98acc2bc4d7b.
----------
Avoid `free(3)`ing invalid pointer
Fixes [Bug #17794] -
- 09:06 PM Revision 983c9ad3 (git): * 2021-06-29 [ci skip]
-
- Fixes [Bug #17794]
-
- vo.x (Vit Ondruch) wrote in #note-13:
> Dan0042 (Daniel DeLorme) wrote in #note-12:
> ...
It's not difficult to make `__FILE__` use `realpath`:
```diff
@@ -10307,6 +10307,14 @@ numparam_nested_p(struct parser_params *p)
retur... -
- @alanwu came up with a much simpler fix for this issue, so I closed my pull request in favor of his. @nobu, could you please review his pull request: https://github.com/ruby/ruby/pull/4585 ?
-
-
-
-
- I tested this with RubyInstaller-head on Windows and the problem appears to have been resolved. Even without an empty `:search` option, ruby raises an exception almost immediately. As commit:9edc162583a4f685332239f6249745ad9b518cbe has...
-
- gdbm was removed in commit:edcc29dcff1b269b7748ab83adf21b2f3f97ebff
-
-
- This appears to be fixed as of Ruby 2.1. I was able to recreate the issue in 2.0, but not in 2.1. I also tested the latest RubyInstaller-head, and the problem is still fixed.
-
- This issue appears to have been fixed, probably in Ruby 3.0. Using the latest RubyInstaller-head:
```
D:\zz-können2>D:\zz-können2\Ruby31-x64\bin\ruby.exe -v --disable-gems -e "p $:.first.encoding, $:.first; require 'uri'"
ruby 3.1.... -
- I didn't have the core dump and this issue only happens very rarely. I just caught it again today and this time I have the core dump. I forwarded it to @tenderlovemaking.
-
- ```
irb(main):001:0> /ff/i.match("\ufb00")
=> #<MatchData "ff">
irb(main):002:0> /[f]f/i.match("\ufb00")
=> #<MatchData "ff">
irb(main):003:0> /f[f]/i.match("\ufb00")
=> nil
irb(main):004:0> /[f][f]/i.match("\ufb00")
=> nil
irb(ma... -
- This is a follow up to [issue 4044](https://bugs.ruby-lang.org/issues/4044). Its fix (https://github.com/k-takata/Onigmo/issues/4) handled the cases that were reported in the original issue, but there are other cases, which were omitted ...
-
- Reduce duplications
* ID caluculations of the same name
* checks against the same name
* registration to the root module hash - 03:10 AM Revision ac8c674a (git): * 2021-06-28 [ci skip]
-
- @matz Thank you for your comment! Then, I'll pick up `error_highlight`. I will update and then merge my PR later.
-
02:27 AM Feature #17930: Add column information into error backtrace
- The `pretty` from `pretty print` strongly suggests beautifying indentation, which the proposed feature doesn't provide.
So I vote for `highlight` or `emphasize`.
Matz.
-
06/27/2021
-
- I read the source code of rustc. https://github.com/rust-lang/rust/tree/master/compiler/rustc_errors
The feature name seems to be "rustc_errors", which is not helpful for my proposal to decide the gem name, but I found some inspiring ... -
- Okay thanks. As far as I take a glance at the references that you showed, the word seems to be mainly used for a "cause". However, the underline in my proposal is not necessarily a cause, so I'm unsure whether it is more appropriate.
... -
01:22 PM Feature #17930: Add column information into error backtrace
- duerst (Martin Dürst) wrote in #note-25:
> If all of pretty/emphasis/highlight are problematic, what's your suggestion?
I already gave suggestions.
mame (Yusuke Endoh) wrote in #note-26:
> ...
I had English in mind. The link https://eo... -
- @duerst It sounds similar to prettyprint which is an existing built-in gem. As far as I know, there is no grammatical rules about a gem name. I don't find any consistent rule when I see prettyprint, power_assert, did_you_mean, debug, etc...
-
- sawa (Tsuyoshi Sawada) wrote in #note-24:
> To my understanding, the word "prettify" means and has been used to add cosmetics to the output, like adding line breaks and indenting or adding colors. The words "emphasis" and "highlight" ar... -
- To my understanding, the word "prettify" means and has been used to add cosmetics to the output, like adding line breaks and indenting or adding colors. The words "emphasis" and "highlight" are in a similar vein. The functionality in que...
-
- mame (Yusuke Endoh) wrote in #note-22:
> Thank you for suggestions about the name. For the record, @pocke and @naruse like "pretty_error". I'll bring this to the next dev-meeting and ask @matz to pick up.
I'm not convinced about "pre... -
-
-
- Moved the check just after `rb_yield`.
And I found that `each_codepoint` also had a similar bug.
@wyhaines Could you add a spec for the method? -
- Applied in changeset commit:git|13939d61b4b69bd109c5f41303c79868d639fa44.
----------
Check if closed after each yield [Bug #17661] -
- +1. While we aim to obviate `keyword_init` in [Feature #16806], unless we also intend to deprecate the option (for now we don't), we'd need to have the check to correctly write a deserializer of Structs.
-
01:56 AM Feature #18008 (Closed): `keyword_init?` method for Struct
- I'd like to know whether my struct was initialized with `keyword_init: true` or not.
This information is useful when writing a deserializer (attached an example below).
```ruby
S1 = Struct.new(:a, :b, keyword_init: true)
S2 = Struc... -
-
- https://github.com/ruby/irb/pull/249 actually slowed down how `code` is
concatenated. The original way of creating `code` is faster.
[before]
user system total real
2.420137 0.005364 2.425501 ( 2.426264)
[after... -
- https://github.com/ruby/irb/commit/2b79e9ad21
06/26/2021
-
-
-
07:33 PM Bug #12052 (Closed): String#encode with xml option returns wrong result for totally non-ASCII-compatible encodings
- Applied in changeset commit:git|e86c1f6fc53433ef5c82ed2b7a4cc9a12c153e4c.
----------
Work around issue transcoding issue with non-ASCII compatible encodings and xml escaping
When using a non-ASCII compatible source and destination enco... -
- jeremyevans0 (Jeremy Evans) wrote in #note-3:
> It looks like this issue occurs when using both multibyte source and destination encoding. If either the source or destination encoding is not multibyte, the issue doesn't occur:
> ...... - 07:32 PM Revision b1428b27 (git): * 2021-06-27 [ci skip]
-
- When using a non-ASCII compatible source and destination encoding
and xml escaping (the :xml option to String#encode), the resulting
string was broken, as it used the correct non-ASCII compatible
encoding, but contained data that was ASC... -
-
06/25/2021
-
- I took the first steps in incorporating this gem, starting with:
```bash
git subtree add \
--prefix=lib/cgi/htmlentities \
https://github.com/threedaymonk/htmlentities \
master
```
Which puts the entire `htmlent... -
- jeremyevans0 (Jeremy Evans) wrote in #note-3:
> So a possible way to work around the issue until it can be properly fixed would be to detect the case where both source and destination are multibyte, switch the destination to UTF-8, then... -
- duerst (Martin Dürst) wrote in #note-2:
> Sorry to @jeremyevans0, but I have to disagree. This is a bug. We can disagree about how important it is to fix this bug, but it's a bug nevertheless. First, xml: :text works correctly in other ... -
- Sorry to @jeremyevans0, but I have to disagree. This is a bug. We can disagree about how important it is to fix this bug, but it's a bug nevertheless. First, xml: :text works correctly in other encodings even if the source and destinatio...
-
- Coverity Scan emulates gcc but seems not to support this attribute
correctly. - 03:15 PM Revision c86f03be (git): * 2021-06-26 [ci skip]
-
- This broke coverage CI
```
1) Failure:
TestRequire#test_load_syntax_error [/home/runner/work/actions/actions/ruby/test/ruby/test_require.rb:228]:
Exception(SyntaxError) with message matches to /unexpected/.
[SyntaxError] exception exp... -
01:50 PM Bug #18007: Help developers of C extensions meet requirements in "doc/extension.rdoc"
- nobu (Nobuyoshi Nakada) wrote in #note-1:
> I don't think the configuration option is needed.
> ...
Thank you for your review. I've updated the pull request.
-
- I don't think the configuration option is needed.
And `Check_Type(klass, T_CLASS);` can be in `rb_data_object_check`. -
- A pull request for this feature has been submitted at https://github.com/ruby/ruby/pull/4604
## Problem being solved
This option is intended to help developers of C extensions to check if their code meets the requirements explained... -
- Thank you for suggestions about the name. For the record, @pocke and @naruse like "pretty_error". I'll bring this to the next dev-meeting and ask @matz to pick up.
Eregon (Benoit Daloze) wrote in #note-21:
> How about using a "core... -
- mame (Yusuke Endoh) wrote in #note-17:
> I've created a PR to add a new default gem to extend the error message of NameError: https://github.com/ruby/ruby/pull/4586
Is a gem needed here?
I like this feature, but I think it is very... -
- Would be good to add this for 3.1, as it will avoid some pretty expensive heap walks (ObjectSpace.each_object) just to get a list of subclasses.
-
11:11 AM Feature #17845: Windows Ruby - ucrt build?
- Thinking a bit more about the ABI incompatibilities convinced me more about the need to differentiate the ruby platforms on Windows. So I added another patch to https://github.com/ruby/ruby/pull/4599 which sets `CONFIG['arch']` and `RUBY...
-
09:56 AM Revision 5ffb313c (git): Revert "Revert "[ruby/reline] Fix failed test""
- I'm so sorry, the previous revert was just a mistake.
This reverts commit 9103c3ba8bc09f287f69ca322f58faa34e003f2e. -
- This reverts commit 491591c7cee842601118efc2698e0e41283827b3.
- 08:42 AM Revision bf376cae (git): [ruby/reline] Fix missing require.
- https://github.com/ruby/reline/commit/010b28dfe9
- 08:42 AM Revision e7884818 (git): [ruby/reline] Avoid using blocking `IO.select`.
- https://github.com/ruby/reline/commit/de94746393
-
08:42 AM Revision d340b091 (git): [ruby/reline] Fix failed test
- For ruby/ruby repository's AppVeyor CI (Windows environment), `Reline::IOGate.encoding` will be changed from `UTF-8` to `Windows-31J` after the test is run.
So, when `test/reline/test_key_actor_emacs.rb` is loaded, `Reline::IOGate.encodi... -
08:27 AM Revision b048fd57 (git): Followed up 66d2fc7989d741bf5a73286233139901cecb4fc2
-
08:26 AM Revision b036a44e (git): [ruby/racc] Remove Object monkey patch
- I don't think we need this monkey patch anymore, so lets remove it!
https://github.com/ruby/racc/commit/464485e912 -
- https://github.com/ruby/racc/commit/fe3183b1ff
-
- https://github.com/ruby/racc/commit/5af1a42a3b
-
- https://github.com/ruby/racc/commit/d66cd12166
-
- It is unclear why this was implemented, I assume
it was for performance back in 2006.
However today, this compression defeats bytecode caching
entirely and end up being counter productive.
https://github.com/ruby/racc/commit/ae3703c1d0 -
- Applied in changeset commit:git|be230615d016e27d5b45b465d1481f6ecf7f1d28.
----------
Remove shift of ep when computing Proc#hash
The shift was causing far fewer unique values of hash than expected.
Fix pointed out by xtkoba (Tee KOBAY...
06/24/2021
-
- After an extensive session with gdb, I've determined that this isn't an issue with `String#encode`, and it isn't a bug.
`"<\0>\0".encode("utf-16le", "utf-16le", xml: :text)` returns the same string as `"<\0>\0".force_encoding("u... -
- Maybe related to #17748.
-
- I was unable to recreate this issue in my OpenBSD environment. However, I was able to recreate the issue on Windows. I think the issue is due to domain searching. As a work around, you can try specifying an empty `search` option:
``... -
08:56 PM Bug #18006 (Closed): Resolv::DNS#getaddress takes minutes to resolve a domain with no DNS records in 3.0 (was quick in 2.7)
- Hello team,
Calling `getaddress` on a domain that returns `NXDOMAIN` takes 2.5 minutes in Ruby 3.0, unless the domain is in FQDN form (with a trailing dot). I'll try to take a look and figure out what's happening, but I'm not familiar... -
- I'm not sure whether this behavior was originally expected, but I think changing it at this point isn't worth the backwards compatibility breakage. For example, consider the following:
```ruby
dir = File.dirname(string) # string cou... -
- The shift was causing far fewer unique values of hash than expected.
Fix pointed out by xtkoba (Tee KOBAYASHI)
Fixes [Bug #17951] -
- The rbs pull request has been merged. So we just need to wait for the next rbs gem release and for bundled gems to be updated, then we can merge the pull request.
-
- Applied in changeset commit:git|a2592702ae4c18662a162805aa06d88046742f05.
----------
Actually ignore FNM_CASEFOLD flag in Dir.glob
This was already documented as being ignored, but it wasn't being
ignored, causing an issue in a particu... - 07:22 PM Revision 3ab68b91 (git): * 2021-06-25 [ci skip]
-
- This was already documented as being ignored, but it wasn't being
ignored, causing an issue in a particular case where a UTF-8
pattern was provided and a filename was tested that wasn't valid
UTF-8.
Fixes [Bug #14456] -
-
-
-
- mame (Yusuke Endoh) wrote in #note-17:
>
> ...
I think that, to pinpoint the origin of an error out of some things, the expression "offending ..." is usually used. So I suggest something along the lines of `offending_method`, `offendi... -
- mame (Yusuke Endoh) wrote in #note-17:
> BTW, I'd like to hear opinions from you, especially English native people, about the feature name. I tentatively named it "error_squiggle". Squiggle means a wavy underline used to indicate an... -
-
-
-
-
-
03:48 AM Revision 0fbdaaf7 (git): rand_bytes: prefer rng->get_bytes
- Because why not. There was no use case of rng->get_bytes before this
changeset. -
- It looks that the patch makes sense. Thank you!