Activity
From 06/20/2021 to 06/26/2021
06/26/2021
-
11:37 PM Revision bf789af2 (git): Added macros for days in month
-
-
07:33 PM Bug #12052 (Closed): String#encode with xml option returns wrong result for totally non-ASCII-compatible encodings
- Applied in changeset commit:git|e86c1f6fc53433ef5c82ed2b7a4cc9a12c153e4c.
----------
Work around issue transcoding issue with non-ASCII compatible encodings and xml escaping
When using a non-ASCII compatible source and destination enco... -
12:42 AM Bug #12052: String#encode with xml option returns wrong result for totally non-ASCII-compatible encodings
- jeremyevans0 (Jeremy Evans) wrote in #note-3:
> It looks like this issue occurs when using both multibyte source and destination encoding. If either the source or destination encoding is not multibyte, the issue doesn't occur:
> ...... - 07:32 PM Revision b1428b27 (git): * 2021-06-27 [ci skip]
-
- When using a non-ASCII compatible source and destination encoding
and xml escaping (the :xml option to String#encode), the resulting
string was broken, as it used the correct non-ASCII compatible
encoding, but contained data that was ASC... -
05:08 PM Bug #14591 (Closed): Files with invalid multi-byte characters will cause Find::find() to raise EINVAL exception
-
06/25/2021
-
09:08 PM Feature #17992: Upstreaming the htmlentities gem into CGI#.(un)escape_html
- I took the first steps in incorporating this gem, starting with:
```bash
git subtree add \
--prefix=lib/cgi/htmlentities \
https://github.com/threedaymonk/htmlentities \
master
```
Which puts the entire `htmlent... -
- jeremyevans0 (Jeremy Evans) wrote in #note-3:
> So a possible way to work around the issue until it can be properly fixed would be to detect the case where both source and destination are multibyte, switch the destination to UTF-8, then... -
- duerst (Martin Dürst) wrote in #note-2:
> Sorry to @jeremyevans0, but I have to disagree. This is a bug. We can disagree about how important it is to fix this bug, but it's a bug nevertheless. First, xml: :text works correctly in other ... -
- Sorry to @jeremyevans0, but I have to disagree. This is a bug. We can disagree about how important it is to fix this bug, but it's a bug nevertheless. First, xml: :text works correctly in other encodings even if the source and destinatio...
-
05:30 PM Revision 457a4913 (git): Disable RBIMPL_ATTR_DEPRECATED for Coverity Scan build
- Coverity Scan emulates gcc but seems not to support this attribute
correctly. - 03:15 PM Revision c86f03be (git): * 2021-06-26 [ci skip]
-
- This broke coverage CI
```
1) Failure:
TestRequire#test_load_syntax_error [/home/runner/work/actions/actions/ruby/test/ruby/test_require.rb:228]:
Exception(SyntaxError) with message matches to /unexpected/.
[SyntaxError] exception exp... -
01:50 PM Bug #18007: Help developers of C extensions meet requirements in "doc/extension.rdoc"
- nobu (Nobuyoshi Nakada) wrote in #note-1:
> I don't think the configuration option is needed.
> ...
Thank you for your review. I've updated the pull request.
-
- I don't think the configuration option is needed.
And `Check_Type(klass, T_CLASS);` can be in `rb_data_object_check`. -
- A pull request for this feature has been submitted at https://github.com/ruby/ruby/pull/4604
## Problem being solved
This option is intended to help developers of C extensions to check if their code meets the requirements explained... -
- Thank you for suggestions about the name. For the record, @pocke and @naruse like "pretty_error". I'll bring this to the next dev-meeting and ask @matz to pick up.
Eregon (Benoit Daloze) wrote in #note-21:
> How about using a "core... -
12:54 PM Feature #17930: Add column information into error backtrace
- mame (Yusuke Endoh) wrote in #note-17:
> I've created a PR to add a new default gem to extend the error message of NameError: https://github.com/ruby/ruby/pull/4586
Is a gem needed here?
I like this feature, but I think it is very... -
- Would be good to add this for 3.1, as it will avoid some pretty expensive heap walks (ObjectSpace.each_object) just to get a list of subclasses.
-
11:11 AM Feature #17845: Windows Ruby - ucrt build?
- Thinking a bit more about the ABI incompatibilities convinced me more about the need to differentiate the ruby platforms on Windows. So I added another patch to https://github.com/ruby/ruby/pull/4599 which sets `CONFIG['arch']` and `RUBY...
-
09:56 AM Revision 5ffb313c (git): Revert "Revert "[ruby/reline] Fix failed test""
- I'm so sorry, the previous revert was just a mistake.
This reverts commit 9103c3ba8bc09f287f69ca322f58faa34e003f2e. -
- This reverts commit 491591c7cee842601118efc2698e0e41283827b3.
- 08:42 AM Revision bf376cae (git): [ruby/reline] Fix missing require.
- https://github.com/ruby/reline/commit/010b28dfe9
- 08:42 AM Revision e7884818 (git): [ruby/reline] Avoid using blocking `IO.select`.
- https://github.com/ruby/reline/commit/de94746393
-
08:42 AM Revision d340b091 (git): [ruby/reline] Fix failed test
- For ruby/ruby repository's AppVeyor CI (Windows environment), `Reline::IOGate.encoding` will be changed from `UTF-8` to `Windows-31J` after the test is run.
So, when `test/reline/test_key_actor_emacs.rb` is loaded, `Reline::IOGate.encodi... -
08:27 AM Revision b048fd57 (git): Followed up 66d2fc7989d741bf5a73286233139901cecb4fc2
-
08:26 AM Revision b036a44e (git): [ruby/racc] Remove Object monkey patch
- I don't think we need this monkey patch anymore, so lets remove it!
https://github.com/ruby/racc/commit/464485e912 -
- https://github.com/ruby/racc/commit/fe3183b1ff
-
- https://github.com/ruby/racc/commit/5af1a42a3b
-
- https://github.com/ruby/racc/commit/d66cd12166
-
08:23 AM Revision 71344a1d (git): [ruby/racc] Stop compressing integer lists
- It is unclear why this was implemented, I assume
it was for performance back in 2006.
However today, this compression defeats bytecode caching
entirely and end up being counter productive.
https://github.com/ruby/racc/commit/ae3703c1d0 -
- Applied in changeset commit:git|be230615d016e27d5b45b465d1481f6ecf7f1d28.
----------
Remove shift of ep when computing Proc#hash
The shift was causing far fewer unique values of hash than expected.
Fix pointed out by xtkoba (Tee KOBAY...
06/24/2021
-
- After an extensive session with gdb, I've determined that this isn't an issue with `String#encode`, and it isn't a bug.
`"<\0>\0".encode("utf-16le", "utf-16le", xml: :text)` returns the same string as `"<\0>\0".force_encoding("u... -
10:20 PM Bug #18006: Resolv::DNS#getaddress takes minutes to resolve a domain with no DNS records in 3.0 (was quick in 2.7)
- Maybe related to #17748.
-
- I was unable to recreate this issue in my OpenBSD environment. However, I was able to recreate the issue on Windows. I think the issue is due to domain searching. As a work around, you can try specifying an empty `search` option:
``... -
08:56 PM Bug #18006 (Closed): Resolv::DNS#getaddress takes minutes to resolve a domain with no DNS records in 3.0 (was quick in 2.7)
- Hello team,
Calling `getaddress` on a domain that returns `NXDOMAIN` takes 2.5 minutes in Ruby 3.0, unless the domain is in FQDN form (with a trailing dot). I'll try to take a look and figure out what's happening, but I'm not familiar... -
- I'm not sure whether this behavior was originally expected, but I think changing it at this point isn't worth the backwards compatibility breakage. For example, consider the following:
```ruby
dir = File.dirname(string) # string cou... -
- The shift was causing far fewer unique values of hash than expected.
Fix pointed out by xtkoba (Tee KOBAYASHI)
Fixes [Bug #17951] -
- The rbs pull request has been merged. So we just need to wait for the next rbs gem release and for bundled gems to be updated, then we can merge the pull request.
-
- Applied in changeset commit:git|a2592702ae4c18662a162805aa06d88046742f05.
----------
Actually ignore FNM_CASEFOLD flag in Dir.glob
This was already documented as being ignored, but it wasn't being
ignored, causing an issue in a particu... - 07:22 PM Revision 3ab68b91 (git): * 2021-06-25 [ci skip]
-
- This was already documented as being ignored, but it wasn't being
ignored, causing an issue in a particular case where a UTF-8
pattern was provided and a filename was tested that wasn't valid
UTF-8.
Fixes [Bug #14456] -
-
-
-
09:49 AM Feature #17930: Add column information into error backtrace
- mame (Yusuke Endoh) wrote in #note-17:
>
> ...
I think that, to pinpoint the origin of an error out of some things, the expression "offending ..." is usually used. So I suggest something along the lines of `offending_method`, `offendi... -
- mame (Yusuke Endoh) wrote in #note-17:
> BTW, I'd like to hear opinions from you, especially English native people, about the feature name. I tentatively named it "error_squiggle". Squiggle means a wavy underline used to indicate an... -
-
-
-
-
-
03:48 AM Revision 0fbdaaf7 (git): rand_bytes: prefer rng->get_bytes
- Because why not. There was no use case of rng->get_bytes before this
changeset. -
- It looks that the patch makes sense. Thank you!
06/23/2021
-
-
06:59 PM Bug #17801: repeated read from PTY blocks all Fibers
- Yes, this works. Thank you.
master.nonblock = true -
10:32 AM Bug #17801: repeated read from PTY blocks all Fibers
- This works for me if I set:
```
master.nonblock = true
```
Can you try it and report back?
We could consider making this the default. -
- Thank you, Eileen!
-
06:34 PM Bug #18001 (Closed): AddressSanitizer finding heap-buffer-overflow in iseq_peephole_optimize
- Applied in changeset commit:git|31f4d262736c224a37e7c630a0790d40b11cdd57.
----------
Check type of instruction - can be INSN or ADJUST
If the type is ADJUST we don't want to treat it like an INSN so we have
to check the type before rea... -
- Bug fix here https://github.com/ruby/ruby/pull/4601
-
- If the type is ADJUST we don't want to treat it like an INSN so we have
to check the type before reading from `insn_info.events`.
[Bug #18001] [ruby-core:104371]
Co-authored-by: Aaron Patterson <tenderlove@ruby-lang.org> -
- Applied in changeset commit:git|8209b735807d449c0a870562ee240585127ee100.
----------
Evacuate transient heap when enabling ractors
If the GC has been disabled we need to re-enable it so we can evacuate
the transient heap.
Fixes https:... - 05:03 PM Revision b29c48ef (git): * 2021-06-24 [ci skip]
-
- If the GC has been disabled we need to re-enable it so we can evacuate
the transient heap.
Fixes https://bugs.ruby-lang.org/issues/17985
[Bug #17985] [ruby-core:104260]
Co-authored-by: Aaron Patterson <tenderlove@ruby-lang.org> - 03:47 PM Revision 263f9662 (git): merge revision(s) 17aeff3e77e6fe0d37a9943dd93bcb16c4bb9f66,1616dcb16ef34ebf4ffc2167292f9a779f3e121e,1616dcb16ef34ebf4ffc2167292f9a779f3e121e:
- make-snapshot: get rid of circular dependency
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66865 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
---
tool/make-snapshot | 5 ++---
1 file changed, 2 insertions(+... - 02:42 PM Revision 2fb435b3 (git): Add Related link from String#hash to Object#hash
- We came across a bug in our code because we assumed `String#hash` to be consistent across Ruby processes, which was incorrect.
Our search lead us to `Object#hash` which has the right warning that `String#hash` doesn't. We also noticed t... -
- I opened a pull request to ruby including the above patches: https://github.com/ruby/ruby/pull/4599
One remaining issue is about the gem platform. It is currently:
* `Gem::Platform.local.to_s` => "x64-mingw32" # equal in MSVCRT and... -
- Thanks for the workaround, it does work for that very specific gem, however gems checking for specific Ruby APIs are broken by it. e.g. `stackprof`
```ruby
require 'mkmf'
if have_func('rb_postponed_job_register_one') &&
have_fun... -
- Applied in changeset commit:git|7c31ecd3accd75d164b4f87b0651b47f31da286d.
----------
Add parentheses to avoid pointless condition
Pointed out by xtkoba (Tee KOBAYASHI).
Fixes [Bug #17946] -
- Pointed out by xtkoba (Tee KOBAYASHI).
Fixes [Bug #17946] -
-
- I already made some changes in `reline`.
I'm experimenting with relaxing `rb_protect`: https://github.com/ruby/ruby/pull/4598 -
- This is a multi-faceted issue.
Firstly, we need to make some library changes, remove `IO.select`, etc from `reline` and so on.
Then, we need to make `$stdin` non-blocking (maybe by default - was planned).
Finally, we need to fig... -
-
-
-
09:04 AM Feature #18004: Add Async to the stdlib
- shan (Shannon Skipper) wrote in #note-2:
> It seemed nice for Ruby to also ship with a concurrent I/O library if a preferred one can be adopted.
Or implement Promises plus await/async in Ruby maybe? The async and await combo especially... -
08:05 AM Feature #18004: Add Async to the stdlib
- > Hello. Async is an awesome gem that I basically support. But there are whole lot of other gems that are equally awesome. What do you think makes async gem so special among other gems that it would be worth being added into the core? Th...
-
- Hello. Async is an awesome gem that I basically support. But there are whole lot of other gems that are equally awesome. What do you think makes async gem so special among other gems that it would be worth being added into the core? ...
-
- Remove environment variables which can affect the default
configurations. -
-
-
-
- https://github.com/ruby/rdoc/commit/8460a36d84
-
- https://github.com/ruby/rdoc/commit/f6cca9bd2f
-
- https://github.com/ruby/rdoc/commit/fb264c4cc4
Co-authored-by: Nobuyoshi Nakada <nobu@ruby-lang.org> -
- https://github.com/ruby/rdoc/commit/f8d1087ce5
-
-
- Extracted repeated code as update_classvariable_cache. When cvc
table is not set in getclassvariable, an empty table was created
but it has no id and would cause [BUG], so made the code same as
setclassvariable. -
01:23 AM Revision 46ff44ef (git): Add nilclass.rb to .document
-
-
-
12:23 AM Revision 87e52ee3 (git): Fix a link [ci skip]
06/22/2021
- 09:34 PM Revision ad588456 (git): * 2021-06-23 [ci skip]
-
- Related to https://bugs.ruby-lang.org/issues/18001
Co-authored-by: Aaron Patterson <tenderlove@ruby-lang.org> -
- Adding Async to the stdlib would signal a clear concurrency story for Ruby 3 to compliment Ractor-based parallelism. I don't know how ioquatix feels about adding Async to stdlib, but I wanted to propose it since we keep getting questions...
-
- Pushed a fix here: https://github.com/ruby/ruby/pull/4596
- 01:32 PM Revision de779f4a (git): [ruby/irb] Sort ls result ordered by anscestry
- https://github.com/ruby/irb/commit/fdd5c0a71e
- 11:51 AM Revision bce0021f (git): [Documentation] Fix typo, formatting in `time.c`
- Backticks do not result in code formatting.
-
- See https://github.com/ruby/ruby/pull/4595 which implements non-blocking `Kernel#system`.
-
- Here is a particularly weird/complex example usage of heredocs in tests:
https://github.com/ruby/ruby/blob/eef3c08edc2fc74496cdc1e4d89798d053e32561/test/ruby/test_thread.rb#L1380-L1394
It does not syntax highlight, it is very hard to... - 11:18 AM Revision eef3c08e (git): Fix NEWS formatting.
- 11:16 AM Revision e01fa2f6 (git): Add fiber scheduler news.
-
- Many functions are still going through C functions which take file descriptors fd argument, and internally we need to create an IO object to handle this correctly in the fiber scheduler. This is slightly inefficient, so we should rework ...
- 10:48 AM Revision fcc6fd23 (git): Rework `sysread` to use blocking `read_internal_locktmp`.
- 10:48 AM Revision 45e65f30 (git): Deprecate and rework old (fd) centric functions.
- 10:17 AM Revision 3deb5d71 (git): Direct io for accept, send, sendmsg, recvfrom, and related methods.
-
- http://rubyci.s3.amazonaws.com/ubuntu/ruby-master/log/20210622T063005Z.log.html.gz
```
/home/chkbuild/chkbuild/tmp/build/20210622T063005Z/ruby/test/rubygems/helper.rb:1565: warning: method redefined; discarding old stub
/home/chkbuild/ch... -
- https://github.com/ruby/readline-ext/commit/8541aaccb5
-
06/21/2021
- 05:40 PM Revision e2599a35 (git): * 2021-06-22 [ci skip]
-
05:38 PM Revision c1741df1 (git): What's Here for Numeric and Comparable
-
-
-
-
-
-
-
-
-
- This reverts commit 089a26b0a619a649b1958061df8f21a6cdc6cacd.
-
- Now ISeq#to_a includes the node_id list for each bytecode instruction.
I want a way to retrieve the AST::Node instance corresponding to an
instruction for a research purpose including TypeProf-based LSP server. -
10:45 AM Bug #18002 (Assigned): s390x: Tests failing without LC_ALL env
- The following failures happened in RubyCI on our s390x Ubuntu focal server.
On the server, RubyCI (ruby/chkbuild) is executed with LC_ALL not set, by cron.
I found the unset `LC_ALL` causes the failures on the s390x server. This does n... -
-
-
09:03 AM Revision 5cc11845 (git): [ruby/irb] Improve stackprof measure
- Allow usage of more detailed args when setting stackprof callback.
Signed-off-by: Ulysse Buonomo <buonomo.ulysse@gmail.com>
https://github.com/ruby/irb/commit/c9d101f450 -
- https://github.com/ruby/reline/commit/5917e3a337
-
- https://github.com/ruby/reline/commit/301ed11bec
-
- https://github.com/ruby/reline/commit/5354d02e03
-
- https://github.com/ruby/reline/commit/acd8f8efbb
-
- https://github.com/ruby/reline/commit/bb6ea232c2
-
- https://github.com/ruby/reline/commit/2e6fdca5c6
-
- https://github.com/ruby/reline/commit/24a2489b62
-
- https://github.com/ruby/reline/commit/c39615e1dd
-
- https://github.com/ruby/reline/commit/69beca2863
-
- https://github.com/ruby/reline/commit/4b74c3d83a
-
- https://github.com/ruby/reline/commit/af6f6ed088
-
- https://github.com/ruby/reline/commit/4a3e308163
-
- https://github.com/ruby/reline/commit/1e287d10cc
-
- https://github.com/ruby/reline/commit/74a7ffaa2f
-
- https://github.com/ruby/reline/commit/8daa392ba6
-
- This fixes an error when output is redirected:
```
$ run_ruby -rreline -e '$stderr.puts Reline::Unicode.calculate_width("\u221a").inspect' </dev/null >/dev/null
/home/jeremy/tmp/ruby/lib/reline/ansi.rb:189:in `raw': Operation not suppor... -
- To fix Reline::TestRendering#test_binding_for_vi_movement_mode.
https://github.com/ruby/reline/commit/0df3d2a1dc -
- This closes https://github.com/ruby/reline/issues/103.
https://github.com/ruby/reline/commit/213e0523d5 -
- In Japan, so many programmers used EUC-JP to write text files that contain
Japanese. Many .inputrc files which contain EUC-JP are still being copied and
used. This commit supports the whole encoding of what user set including UTF-8.
ref... -
- This needs https://github.com/aycabta/yamatanooroti/pull/19, which is released
by yamatanooroti gem 0.0.7, to test with yamatanooroti.
https://github.com/ruby/reline/commit/06c1f45da1 -
08:58 AM Revision a049dfd1 (git): [ruby/reline] ensure reline's encoding is used when reading inputrc character values
- This change ensures we use `Reline::IOGate`'s `encoding` when converting
characters from their integer values.
This fixes an issue that may occur if you have UTF characters in your
`.inputrc`, but your default encoding isn't set.
For e... -
- https://github.com/ruby/irb/commit/75aa8d159b
-
- Looks interesting. Can you hide AST implementation inside `Thread::Backtrace::Location` and expose some meta data like column start/offset?
-
- I've created a PR to add a new default gem to extend the error message of NameError: https://github.com/ruby/ruby/pull/4586
```
$ ./local/bin/ruby -e '1.time {}'
-e:1:in `<main>': undefined method `time' for 1:Integer (NoMethodError... -
- 02:08 AM Revision 86b5c15e (git): * 2021-06-21 [ci skip]
-
06/20/2021
-
06:10 PM Bug #18001: AddressSanitizer finding heap-buffer-overflow in iseq_peephole_optimize
- What are exactly steps to compile ruby under ASan?