Activity
From 06/13/2021 to 06/19/2021
06/19/2021
-
06:34 PM Bug #18001: AddressSanitizer finding heap-buffer-overflow in iseq_peephole_optimize
- For me
```ruby
require "coverage"
Coverage.start
```
causes an ASan error:
```
$ ruby -v
ruby 3.1.0dev (2021-06-10T23:31:51Z master 9210f8df7f) [x86_64-linux]
$ ruby -e 'require "coverage"; Coverage.start'
=================... -
04:37 PM Bug #18001 (Closed): AddressSanitizer finding heap-buffer-overflow in iseq_peephole_optimize
- **Summary**
Using Ruby's `coverage` functionality and loading crafted Ruby will lead to memory usage errors in `iseq_peephole_optimize`.
**Background**
We've used Valgrind in the Nokogiri test suite for many years; and since R... -
05:37 AM Bug #15634: TracePoint seems to be skipping some methods.
- ioquatix (Samuel Williams) wrote in #note-5:
> I wouldn't say this bug is fixed. Adding documentation just clarifies the current behaviour but does not help resolve or improve on the original problem.
Well, it depends on whether you ... -
02:33 AM Bug #15634: TracePoint seems to be skipping some methods.
- I wouldn't say this bug is fixed. Adding documentation just clarifies the current behaviour but does not help resolve or improve on the original problem.
I would say, the line tracepoint is confusing at best, as one might expect it to... -
01:55 AM Bug #15634 (Closed): TracePoint seems to be skipping some methods.
- Applied in changeset commit:git|72a4e1d3bbbdfff71ec2c6b2ddb3b9323193cacd.
----------
Tweak description of TracePoint :line event
"code" here is too ambiguous. TracePoint events only occur if there
is a new statement or expression on th... -
-
- "code" here is too ambiguous. TracePoint events only occur if there
is a new statement or expression on that line, not if the line
is a continuation of a previous statement or expression and there
is no new statement or expression on the... -
- The `name2ctype.{h.blt,kwd,src}` files were removed in commit:2f87f9e63b9f88b6fe1f26c315a64d41f8adc0a5.
06/18/2021
-
- This issue dates to the introduction of the newline code in commit:c26ab1ef1c1129198695edf2212774a084147228. It looks like `newline: :lf` was originally planned, but never implemented. However, the state it was left in resulted in `new...
-
-
- After thinking more regarding this issue, if we want no overhead by default, and only overhead if this feature is enabled via a command line flag (similar to JRuby's `--debug` flag), one possibility is to just use BMETHOD (or ISEQ) metho...
-
- A workaround would be to place a dummy `libruby-static.a` wherever `ld` can find it.
```
!<arch>
``` -
06:30 PM Bug #18000 (Closed): have_library doesn't work when ruby is compiled with --disable-shared --disable-install-static-library
- Related [Feature #12845]
If you compile ruby with `--disable-shared --disable-install-static-library`, then many C-extension won't compile anymore. For instance `RedCloth`
```ruby
# extconf.rb
require 'mkmf'
CONFIG['warnflags']... -
- The cause of this issue is the same as #13392. I've verified the pull request I submitted for that issue (https://github.com/ruby/ruby/pull/4588) will also fix this issue.
-
- This is basically the same issue as #15634. The default argument evaluation is not considered a separate expression, so no line event is generated. If you force it to use a separate expression by wrapping in parentheses, you can get a ...
-
-
- This issue is still present in the master branch. However, the range of T_FIXNUM is an implementation detail, especially since Integer unification in Ruby 2.4, so I do not think this is a bug. I think we wouldn't be opposed to increas...
-
- The reason there is no event emitted for Line 17 in the example (#note-1) is there is no new expression/statement on that line. It is a continuation of the previous expression. I think we should adjust the documentation for the :line e...
-
- This isn't an issue specific to monkey patches or aliased methods. This is a general issue with the :return event handling of bmethods (methods defined using blocks instead of with `def`). The return event handling occurs after the rel...
-
- I'm assuming this is still the case, but I cannot verify it as I don't have an environment that supports DTrace. I've submitted a pull request to document how to enable the DTrace probes, but a committer with actual DTrace knowledge wil...
-
- Currently, there is a skip instead of a failure if the unicode data files are not available. I tried changing this from a skip to a failure, but it resulted in the CI jobs that run tests failing: https://github.com/jeremyevans/ruby/runs...
- 05:03 PM Revision 53a094ea (git): * 2021-06-19 [ci skip]
-
05:02 PM Revision b91b3bc7 (git): Add a cache for class variables
- Redo of 34a2acdac788602c14bf05fb616215187badd504 and
931138b00696419945dc03e10f033b1f53cd50f3 which were reverted.
GitHub PR #4340.
This change implements a cache for class variables. Previously there was
no cache for cvars. Cvar acces... -
10:13 AM Revision 9d96837d (git): Bump matrix version to 0.4.2
-
08:43 AM Misc #17886 (Closed): DevelopersMeeting20210617Japan
-
02:58 AM Revision bdeaa60e (git): Make frozen Time Ractor-shareable
-
02:51 AM Misc #17997: DevelopersMeeting20210715Japan
- * [Feature #17938] Keyword alternative for boolean positional arguments (MatheusRich)
* I think we should address this in the whole std lib (incrementally). Matz seemed positive about it.
* What should we do if both positional and ke... -
- Another alternative would be allowing setting positional args through keyword args:
``` ruby
def respond_to?(symbol, include_all = false) # as is today
# ...
end
obj = Object.new
obj.respond_to?(:some_method, include_all: tru... -
- Applied in changeset commit:git|1de063a10b5c5c71d0602c961862b8396702dbb1.
----------
Add section on build requirements to the README
I'm not sure that this is section is complete (may be missing
requirements), or accurate (minimum auto... -
- I'm not sure that this is section is complete (may be missing
requirements), or accurate (minimum automake or bison versions
may not be correct). However, I think it's useful, and we can
adjust it in the future to add requirements or ad... -
- In http://rubyci.s3.amazonaws.com/raspbian10-aarch64/ruby-master/log/20210617T223805Z.log.html.gz the following error message is observed:
```
1) Error:
TestMethod#test_zsuper:
Timeout::Error: execution of assert_separately expir...
06/17/2021
-
-
10:17 PM Bug #17993: Ruby process stuck in rb_sigwait_sleep
- I think I have tracked the problem to libev. Kudu uses libev for its reactor, and libev installs a signal handler for SIGCHLD (http://pod.tst.eu/http://cvs.schmorp.de/libev/ev.pod):
> Libev grabs SIGCHLD as soon as the default event ... -
- As far as I can tell looking at the kudu source, none of the threads created by the kudu library installs a SIGCHLD handler. But this certainly feels related, because `system` behaves as expected if I ignore SIGCHLD prior to calling it....
-
- I doubt if installation of `SIGCHLD` handler is relevant. It is true that the handler for `SIGCHLD` is changed in `Webserver::Start()` (`src/kudu/server/webserver.cc`):
```c
sighandler_t sig_chld = signal(SIGCHLD, SIG_DFL);
/* ... */
... -
- Is the `build_client` function installing a SIGCLD handler? The code path in the backtrace is what is taken when #system uses SIGCLD/SIGCHLD for waiting, and maybe a separate SIGCLD handler interfers with that.
Since this worked on Ru... -
- This issue still exists in the master branch. I've submitted a pull request for @tompng's patch: https://github.com/ruby/ruby/pull/4584
-
- I tested this using RubyInstaller versions on Windows. This appears related to regexp encoding, and not a bug, with the same behavior between Ruby 2.0 and 3.0:
```
C:\>c:\Ruby30-x64\bin\ruby -e "p(/\p{L}/.match('a'))"
-e:1: invalid... -
- This reproduces for me on x86_64-linux using HoneyryderChuck/minitest issue-872 873ffd8.
In addition to hanging, there appear to be two more (nondeterministic) errors. A full log is attached.
```
/var/tmp/ruby/yyy/minitest/lib/min... -
01:45 PM Bug #17998 (Closed): ractor: process hanging (with ractors initialized, but not being used)
- I couldn't figure out how to reproduce this in a more contained way, so I'll share what I'm doing [in this minitest branch](https://github.com/HoneyryderChuck/minitest/tree/issue-872).
I'm trying to make minitest's parallel mode use r... -
- This is still an issue in the master branch. The problem can be solved by actually ignoring `File::FNM_CASEFOLD`, which is something that the `Dir.glob` documentation says that it does. I've submitted a pull request that fixes this: htt...
-
- ... which is formally called EXPERIMENTAL_ISEQ_NODE_ID.
See also ff69ef27b06eed1ba750e7d9cab8322f351ed245.
https://bugs.ruby-lang.org/issues/17930 -
- RubyVM::AST.of(Thread::Backtrace::Location) returns a node that
corresponds to the location. Typically, the node is a method call, but
not always.
This change also includes iseq's dump/load support of node_ids for each
instructions. -
- Previously Backtrace::Location had two possible states:
LOCATION_TYPE_ISEQ and LOCATION_TYPE_ISEQ_CALCED. The former had the
location information as PC, and the latter had it as lineno.
Once lineno was caluculated, the state was changed ... -
- mame (Yusuke Endoh) wrote in #note-2:
> BTW, do you have any concern against merging my current PR? It just clarifies the current behavior of IO.read and adds `File.read` alias. We can implement the deprecation warnings later if it is a... -
- Jeremy, thanks you for your comment.
jeremyevans0 (Jeremy Evans) wrote in #note-1:
> Honestly, I don't think `read` makes sense as a class method on socket classes, so maybe we can avoid the issue by undefing it (after a deprecation ... -
- My only concern is that File isn't the only subclasses of IO. There are also:
```
UNIXServer
UNIXSocket
UDPSocket
TCPServer
TCPSocket
IPSocket
Socket
BasicSocket
```
Do we want `Socket.read` to handle `|` specially (as `I... -
- `IO.read` creates a subprocess when a given file name starts with a `|` character.
```
irb(main):001:0> IO.read("| ls /etc/passwd")
=> "/etc/passwd\n"
```
To disable this feature, `File.read` can be used.
```
irb(main):002:0... -
- I believe this is asking for a section on build requirements to be added to the README, which seems useful for me. I added a pull request for this: https://github.com/ruby/ruby/pull/4582. I'm not sure if there are missing requirements...
- 05:34 PM Revision ed3e30fc (git): * 2021-06-18 [ci skip]
-
- by merging `rb_ast_body_t#line_count` and `#script_lines`.
Fortunately `line_count == RARRAY_LEN(script_lines)` was always
satisfied. When script_lines is saved, it has an array of lines, and
when not saved, it has a Fixnum that represe... -
- This option makes the parser keep the original source as an array of
the original code lines. This feature exploits the mechanism of
`SCRIPT_LINES__` but records only the specified code that is passed to
RubyVM::AST.of or .parse, instead... -
- * [Feature #17994] Clarify `IO.read` behavior and add `File.read` method (mame)
* Jeremy pointed that `Socket.read` is callable but does not make sense. Should we deprecate the use of `IO.read` against a receiver different than `IO` a... -
- # The next dev meeting
**Date: 2021/07/15 13:00-17:00**
Place/Sign-up/Agenda/Log: https://github.com/ruby/dev-meeting-log/blob/master/DevelopersMeeting20210715Japan.md
- Dev meeting *IS NOT* a decision-making place. All decisions ... -
- After giving this some more thought, I agree that find should ignore EINVAL errors, just as it ignores similar errors such as ENAMETOOLONG. I submitted an upstream pull request for this: https://github.com/ruby/find/pull/2
-
04:05 PM Feature #17992: Upstreaming the htmlentities gem into CGI#.(un)escape_html
- I don't know anything about anything, but having a basic-but-fast operation that only does the bare minimum for security, makes sense to me.
I just want to push for a more complete alternative to exist in some form or another. -
-
-
05:47 AM Bug #17098: Float#negative? reports negative zero as not negative
- Unless there's any particular (real-world) reason to distinguish floating positive zero and negative zero, I'd like to keep the current behavior.
And as @mrkn suggested, `Float#sign` may be useful to distinguish those two zeros, but it... -
02:58 PM Revision c639b588 (git): Refactor heap_set_increment
- heap_set_increment essentially only calls heap_allocatable_pages_set.
They only differ in behaviour when `additional_pages == 0`. However,
this is only possible because heap_extend_pages may return 0. This
commit also changes heap_extend... -
- mame (Yusuke Endoh) wrote in #note-12:
> We discussed this issue in today's dev-meeting. @akr suggested that
> ...
In keeping with the spirit that `Kernel#pp` is more expanded than `Kernel#p`, I suggest `PP.ppp`. :) -
- We discussed this issue in today's dev-meeting. @akr suggested that
1. To make the default size to be io/console's winsize (width)
2. Instead of changing `Kernel#pp`, extend `PP.pp` to accept keywords `out` and `width`
3. If we want... -
- We discussed this ticket at today's dev-meeting. We agreed that we should change nothing for this.
Indeed it looked an unintentional change, but it is too late to revert the behavior because Ruby 2.6 was released three years ago and i... -
- I brought this ticket to the agenda of today's dev-meeting, and confirmed that matz has already accepted this.
The accepted implementation approach is (1) to extend `RubyVM::AST.of` to accept `Thread::Backtrace::Location` to get the n... -
- We discussed this ticket in today's dev-meeting.
Many committers agreed that the categorized method list with one-line summary is good to have. The traditional name-only list is in ABC order, which is less useful.
It is definitely ... -
01:33 PM Feature #13396: Net::HTTP has no write timeout
- There's an open issue on `Net::HTTP#write_timeout` not working when `body_stream` is used: https://bugs.ruby-lang.org/issues/17933
I'm just sharing this here for visibility. -
09:58 AM Bug #11779: Module#using does not make sense as a method
- `Module#using` has a granularity of "constant lexical scope", i.e., a scope that is only changed by `module` or `class` keywords.
Maybe the docs should be improved in this regard?
Current docs say this
```
Import class refinement... -
- It seems great. The code complexity is my concern. But I agree with trying it.
Matz.
-
06:54 AM Feature #16962 (Feedback): Make IO.for_fd autoclose option default to false
-
- We don't close 0 (stdin), 1 (stdout), 2 (stderr) because
they can be used from various library.
If we close 2, next open() return 2.
Assume that we open a database file.
If open() returns 2 for the database,
the database would be ... -
-
05:46 AM Bug #17561: The timeout option for Addrinfo.getaddrinfo is not reliable on Ruby 2.7.2
- About 2.7, to make raise `ArgumentError` (or other exception) is not acceptable because it's **stable* branch.
I strongly hope to fix this problem at master branch and the fix can be backportable, but at this time, we should simply igno... -
- I agree it should be a bug. @nobu, could you review @jeremyevans's patch? I'd like to see if the fix causes any compatibility issue.
Matz. -
- The following one-liner is the repro named `thread-pipe-read-close.rb` the aim of which is essentially the same as that of "IO#close raises an IOError with a clear message" test in `spec/ruby/core/io/close_spec.rb`.
```ruby
r, w = IO... -
03:28 AM Bug #17995 (Closed): Slow down when mjit and Ractor are being used at same time
When using --jit and Ractor at same time, benchmark would be slow down with recursion function such like Tarai function an Fibonacci function.
The slow down is confirmed under both gcc(linux) and mingw64(windows MSYS2).
Test en...-
- In ruby/ruby test actions, number of "leaked tempfile" messages
are shown on Windows.
As Windows disallows removing open files, `Tempfile#unlink` fails
silently before `#close`.
Close then unlink by `#close!` instead.
https://github.co... -
- * --braces-after-func-def-line
* --dont-cuddle-else
* --procnames-start-lines
* --space-after-for
* --space-after-if
* --space-after-while
06/16/2021
-
- This is still an issue in the master branch. I've submitted a pull request that should fix the problem: https://github.com/ruby/ruby/pull/4578
- 09:09 PM Revision 4e097226 (git): * 2021-06-17 [ci skip]
- 09:09 PM Revision c1a7e86f (git): * expand tabs. [ci skip]
- Tabs were expanded because the file did not have any tab indentation in unedited lines.
Please update your editor config, and use misc/expand_tabs.rb in the pre-commit hook. -
09:09 PM Revision c10d5085 (git): Enable frozen_string_literal in builtin_iseq_load
- Currently this has a fairly minor effect as strings are not used heavily
inside the builtins (outside of warnings, requires, and errors).
Hopefully this allows us to use strings in the future where appropriate. -
- I have a very simple client for kudu (https://kudu.apache.org/) implement as a wrapper that I invoke with FFI. After creating a kudu client with `KuduClientBuilder::Build()`, subsequent calls to `system` cause the ruby interpreter to bl...
-
- This is still an issue in the master branch. I've submitted a pull request for it: https://github.com/ruby/ruby/pull/4577. The pull request uses @wanabe's fix and a test based on @buzztaiki's example.
-
- I looked into this, and with the current TracePoint design, it does not appear possible. For `:raise` events, the `raised_exception` is stored in `trace_args->data`. This is the same location that the return value is stored for `:retur...
-
-
- Ruby 2.6 is in security maintenance mode, and this does not appear to be a security issue. CI testing on AppVeyor shows the master branch is passing for both Visual Studio 2013 and 2015. So I think this can be closed. If you can reprod...
-
- This appears to be fixed starting in Ruby 2.7 (also works in 3.0):
```
D:\Евгений>C:\Ruby26-x64\bin\ruby -I D:\Евгений -e "require 'logger'"
Traceback (most recent call last):
2: from -e:1:in `<main>'
1: from C:/Ru... -
- This appears to be fixed starting in Ruby 2.5 (also works in 2.6, 2.7, and 3.0):
```
C:\>C:\Ruby24-x64\bin\gem list bundler
*** LOCAL GEMS ***
bundler (2.2.20)
C:\>C:\Ruby25-x64\bin\gem list bundler
*** LOCAL GEMS ***
... -
- This is fixed in Ruby 2.7.3 (and also works in 3.0.1 and master). As Ruby 2.6 is in security maintenance mode, the change will not be backported to Ruby 2.6, so this can be closed.
-
- https://github.com/ruby/psych/pull/480 was merged, which fixed this issue.
-
-
- I submitted a pull request to rbs to fix the failure (https://github.com/ruby/rbs/pull/683) I also updated the ruby pull request (https://github.com/ruby/ruby/pull/4256) to rebase it on the current master branch. Once the rbs pull reques...
-
- commit:78677f105df79e45dec451b56947509fc71c6f57 fixed this issue for the master branch. It was backported to 3.0 in commit:95aff214687a5e12c3eb57d056665741e734c188. Ruby 2.7 still fails due to this, so commit:78677f105df79e45dec451b5694...
-
- I believe this was fixed by commit:78677f105df79e45dec451b56947509fc71c6f57, which disabled dtrace by default when building on FreeBSD. Ruby 3.0 and the master branch can both build correctly on FreeBSD 12.2 (tested on RubyCI). We have ...
-
03:02 PM Feature #17845: Windows Ruby - ucrt build?
- @larkanis
> Do you want to switch your ruby-logo build to UCRT as well or add it as another architecture?
I think adding as another architecture would be best? Maybe tag it as `ruby-ucrt`?
> ...
I'll open an issue about add... -
02:08 PM Feature #17845: Windows Ruby - ucrt build?
- The [rubyinstaller-head nightly build](https://github.com/oneclick/rubyinstaller2/releases/tag/rubyinstaller-head) is compiled with MINGW-UCRT since a few days. So all projects that use [ruby-setup](https://github.com/ruby/setup-ruby) wi...
-
- On Mingw-w64 `_CrtSetReportMode` is defined in `crtdbg.h` as
```
#define _CrtSetReportMode(t,f) ((int)0)
```
thus I believe the definition in `win32/win32.c` makes no difference although it may cause a `-Wmacro-redefined` warning. -
- Thank you @xtkoba for working on this! I replaced my previous patches by the above patches [in rubyinstaller2-packages](https://github.com/oneclick/rubyinstaller2-packages/pull/15/files).
One thing I noticed is that you disabled the c... -
- Apparently this case was optimized in Ruby 3.0. Using the benchmark code provided:
```
$ for x in 25 26 27 30; do ruby$x -v; for y in 1 2 3; do ruby$x t/t51.rb; done; done
ruby 2.5.9p229 (2021-04-05 revision 67939) [x86_64-openbsd]... -
-
- Mitigate the security risk:
https://devcraft.io/2021/01/07/universal-deserialisation-gadget-for-ruby-2-x-3-x.html
https://github.com/ruby/net-protocol/commit/a9970437e8 -
- One potential issue with caching the non-blocking state in Ruby is that a C extension might call fcntl() directly on the fd of an IO to change its non-blocking state.
Not sure if that's done in practice, but it could be an issue. -
07:10 AM Bug #17664: Behavior of sockets changed in Ruby 3.0 to non-blocking
- > In the uring backend, for read/write operations, set the IO to blocking and then revert it afterwards.
Why would you need to revert it? In practically all cases I can think of, you're going to do all I/O for a given fd on the same s... -
- Thanks @normalperson - I understand you aren't interested much in Ruby but wish you the best. Thanks for chiming in promptly.
I probably wouldn't characterise this as an incompatibility, because this problem can surface if the user ex... -
12:57 AM Bug #17664: Behavior of sockets changed in Ruby 3.0 to non-blocking
- samuel@oriontransfer.net wrote:
> I welcome discussion on this point, but for certain, I believe
> Ruby being non-blocking by default makes sense and that
> approach was proposed by Eric, and I agreed with it and
> finally enabled i... -
09:15 AM Bug #16921: s390x: random test failures for timeout or segmentation fault
- If someone will still see the issue, please let us know.
-
- I have not seen this issue for a while on the Fedora s390x build server. I also have not seen it on Travis s390x pipeline and our s390x server. So, I would close this for now.
-
-
- Fix up c2d9967f78d2e6f93f8d9876c2b3ab25aa6b86e7.
-
- Applied in changeset commit:git|c2d9967f78d2e6f93f8d9876c2b3ab25aa6b86e7.
----------
Configure ioctl request argument type [Bug #17759] -
-
03:57 AM Feature #17992: Upstreaming the htmlentities gem into CGI#.(un)escape_html
- Note that escaping and unescaping are not symmetric. There may be a point in keeping escaping to the minimum for performance reasons. However, when it comes to unescaping, it would be useless unless all escaped characters are completely ...
-
02:30 AM Bug #17986: Ractor is stdlib Socket unfriendly
- This hack has a limitation which i faced with specs.
For socket testing purposes i have i small [class](https://github.com/kvokka/dtn/blob/master/spec/support/socket_recorder.rb) (It should be adjusted for using with Ractors, share it... -
- Starting in Ruby 3.0, it appears `ENV["PATH"]` is unmodified after the call to `system`. In prior versions of Ruby, it was modified by the call to `system`. This is probably related to the changes to `ENV` in Ruby 3.0, which will not b...
-
- I tested this and it appears fixed by commit:63a5412db7138297a2e7513067ef80dad7a3b4b4. It may be worthwhile to backport that commit to Ruby 2.7.
-
- As this appears fixed in Ruby 2.6+, and Ruby 2.5 is out of support, I'm going to close this.
06/15/2021
-
- This change was originally proposed and implemented by @normalperson.
The outward interface does not change, but you are right it can impact io_uring implementation.
I know this is a problem and ran into the same issue.
I don't know h... -
-
-
-
- I've submitted a pull request to fix this issue using a mutex: https://github.com/ruby/zlib/pull/27
It passes the script that @mame developed, but there may still be multithreaded issues remaining. I didn't trace all code to see if it... -
- > I don't think the behavior you are showing is a bug, so I think this should be closed. However, I'll wait for a while and see if another core team member feels differently.
Thank you @jeremyevans0 for the idea, you gave me TIL!
... -
- The code you are showing (`make_shareable` with a socket) is broken because in order to be shareable, an object must be immutable, and a socket cannot really be immutable and usable.
You can work around it using `for_fd` (this should ... -
- **Description**
In the process of playing with Ractors was found, that there is no way to use stdlib Sockets.
My intent was to implement bidirectional connection with Socket using Ractors.
This small console snippet is self expl... -
- k0kubun (Takashi Kokubun) wrote in #note-1:
> Could you clarify a bit more context about why you'd like to escape these characters not supported in CGI.escapeHTML?
We have a dataset of user content that contains HTML entities (whethe... -
08:50 PM Feature #17992 (Feedback): Upstreaming the htmlentities gem into CGI#.(un)escape_html
- Could you clarify a bit more context about why you'd like to escape these characters not supported in `CGI.escapeHTML`?
I believe `CGI.escapeHTML` has been primarily used to avoid breaking the DOM structure by escaping dynamic contents... -
- Hi there,
I was looking to unescape some HTML entities in a String, and I discovered that `CGI#.(un)escape_html` is **really** limited. Many StackOverflow questions share a similar disappointment, and point users to using the [htmlent... -
- Thank you for pointing this out. I agree that parentheses must have been intended in this case. I submitted a pull request to add them: https://github.com/ruby/ruby/pull/4575
-
-
- This makes sense to me. However, there is a explicit test currently that array arguments are not accepted. So this must be considered a feature request and not a bug. I've submitted an upstream pull request that implements this feature: ...
-
- I have submitted a pull request with @xtkoba's fix: https://github.com/ruby/ruby/pull/4574
-
-
-
-
-
- I've submitted a pull request upstream to fix this: https://github.com/ruby/date/pull/34
-
05:18 PM Misc #17886: DevelopersMeeting20210617Japan
- * [Feature #17763] Add an inline cache for class variables
* This seems to speed up Rails applications at the cost of some code complexity. Can we merge it? -
03:30 PM Bug #17991: [TEST, CRASH] TestBugReporter#test_bug_reporter_add
- Patch for add2line somehow helped:
```
fedora-rawhide gcc 11.1.1 now ok
voidlinux 10.2.1 still ok
```
4 crashes are gone.
-
- Current summary:
```
all gcc below:
fedora-rawhide 11.1.1 - crash
archlinux 11.1.0 - ok
voidlinux 10.2.1 - ok
alpinelinux 10.2.1 - ok
solaris11 10.2.0 - ok
all clang below:
fedora-rawhide 12.0.1 - ok
```
I will test the patch asap. -
- This reminds me of #17794. Could you try the patch in #17794 (https://bugs.ruby-lang.org/attachments/8822) and see if the situation changes?
-
- Testing host is latest Fedora Rawhide.
I see 4 tests which crashed by `double free or corruption (out)`. This is one of them, rest 3 are `TestRubyOptions#test_segv_*` group.
```
[ 5452/20801] TestBugReporter#test_bug_reporter_add = 0.... - 03:09 PM Revision d4db18d6 (git): * 2021-06-16 [ci skip]
-
-
- Ruby 2.6 is in security maintenance mode and this does not appear to be a security issue. Can you reproduce this crash on the master branch?
-
- Isn't this yet another instance of TPI?
```
Code Type: ARM-64 (Native)
(...)
6 libsystem_platform.dylib 0x000000019fbf1c44 _sigtramp + 56
7 ffi_c.bundle 0x00000001029968d4 prep_trampoline + ... -
07:13 AM Bug #17987 (Closed): Ruby报错
- You may have encountered a bug in the Ruby interpreter or extension libraries.
Bug reports are welcome.
For details: https://www.ruby-lang.org/bugreport.html -
-
- I believe this issue could be closed.
Fix already in the tree:
https://github.com/ruby/ruby/commit/90cad6e14745d812f042df61a6455db022be7389
-
-
11:59 AM Bug #17990 (Open): Inconsistent behavior of Regexp quantifiers over characters with complex case foldings
- With case insensitive Regexps, the string `"ff"` is considered equal to the string `"\ufb00"` with a single ligature character.
```
irb(main):001:0> /ff/i.match("\ufb00")
=> #<MatchData "ff">
```
This behavior also persists when ... -
- When a Regexp uses the case-insensitive flag, strings are compared by first case folding them and then comparing the case foldings for equality. When a literal string is encountered in a Regexp source, the pattern analyzer tries to enume...
-
- > Switching to feature request.
Makes sense. Hopefully the example of matching HTTP headers makes it a compelling case for such. -
- I believe that this is the same issue as #17862, #17922, and https://github.com/typhoeus/ethon/issues/193.
-
08:47 AM Bug #17988 (Third Party's Issue): pod update on Mac mini M1 with Big Sur after moving project from iMac. Xcode 12.4
- The pod update fails.
davidrussell@Mac-mini NowBoarding_1701 % pod update
/System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/universal-darwin20/rbconfig.rb:229: warning: Insecure world writable dir /Users/davidru... -
-
05:51 AM Bug #17561: The timeout option for Addrinfo.getaddrinfo is not reliable on Ruby 2.7.2
- Although I can't reproduce the issue on my machine (I tried several times), I agree that this should be removed from 2.7.
I will create a patch. -
- @Glass_saga Could you handle this?
-
04:47 AM Bug #17561: The timeout option for Addrinfo.getaddrinfo is not reliable on Ruby 2.7.2
- confirmed on my machine:
```
$ ruby -ve "require 'resolv'; 10000.times { |i| p [i, Addrinfo.getaddrinfo('2130706433', 80, nil, :STREAM, timeout: 0)] }"
ruby 2.7.3p183 (2021-04-05 revision 6847ee089d) [x86_64-linux]
*** stack smashi... -
05:05 AM Bug #17098: Float#negative? reports negative zero as not negative
- If you have pragmatic demands that need to distinguish `-0.0` and `+0.0`, what do you think to propose the introduction of `Float#signbit`?
-
- The current behavior is consistent with the behavior of the integer zero:
```
irb(main):001:0> 0.negative?
=> false
irb(main):002:0> 0.positive?
=> false
``` - 03:04 AM Revision f0818982 (git): [ruby/ostruct] v0.4.0
- https://github.com/ruby/ostruct/commit/8534f69e4e
-
12:35 AM Bug #17880 (Closed): [BUG] We are killing the stack canary set by `opt_setinlinecache` - Applied in changeset commit:git|2088a457981b0f71a3bfd14871ed5b6f0d090e6a.
----------
[Bug #17880] Set leaf false on opt_setinlinecache (#4565)
This change fixes the bug described in https://bugs.ruby-lang.org/issues/17880.
Checking `r... - 12:34 AM Revision 2088a457 (git): [Bug #17880] Set leaf false on opt_setinlinecache (#4565)
- This change fixes the bug described in https://bugs.ruby-lang.org/issues/17880.
Checking `ractor_shareable_p` will cause the method to call back into
Ruby. Anything calling this method can't be a leaf instruction,
otherwise it could cra...
06/14/2021
-
- The fact that only symbol keys are supported is documented (https://docs.ruby-lang.org/en/master/doc/syntax/pattern_matching_rdoc.html#label-Patterns), so this is expected and not a bug. Switching to feature request.
-
- Can you send me a core file and I can take a look?
-
- About 1% of our CI jobs fail with this error.
If necessary I can try to find a repro, but these GC issues are hard to pin down because they require GC.stress which is very slow.
```
<OBJ_INFO:gc_mark_ptr@gc.c:6687> 0x00007f6717407... -
- The attached script (named `bug17882-gcmod.rb`) is a modification of `bootstraptest/test_ractor.rb:224` that reads:
```ruby
def test n
# (...snip...)
end
GC.disable # newly added
p 30.times.map{|i|
test i
}
GC.start # ... - 04:28 PM Revision a09ddfc4 (git): [lib/ostruct] Fix YAML test
- 04:28 PM Revision 52369fc5 (git): [lib/ostruct] Allow overriding of `block_given?`
- 03:04 PM Revision fc98602e (git): * 2021-06-15 [ci skip]
-
-
-
- https://github.com/ruby/ostruct/commit/bb253be3e9
-
- 01:53 PM Revision 931ea7cf (git): Add fallback block to `OpenStruct#delete_field` (#1409)
-
01:37 PM Revision 90cad6e1 (git): prefer cc/gcc over clang on solaris
- requested by tankf33der at https://bugs.ruby-lang.org/issues/17949#change-92430
-
- These methods are not !-suffixed, and the messages were very
confusing. - 10:09 AM Revision 1ab71a5b (git): Fix fiber scheduler address resolve solaris tests
- 10:07 AM Revision 25921fe1 (git): Revert "Suppress gcc11 clobbered warning"
- This reverts commit f0f9e77b65990001bd2acb42e1c6b673f6324425.
-
08:35 AM Bug #17951: Collisions in Proc#hash values for blocks defined at the same line
- It was there since 1.9 as far as I can see https://github.com/ruby/ruby/commit/a3e1b1ce7ed7e7ffac23015fc2fde56511b30681#diff-2672918174f926386106967d117f11da8aa1905772dcf48fce53694386e4a666R658-R668
-
- A possible fix:
```diff
--- a/proc.c
+++ b/proc.c
@@ -1451,7 +1451,7 @@ rb_hash_proc(st_index_t hash, VALUE prc)
GetProcPtr(prc, proc);
hash = rb_hash_uint(hash, (st_index_t)proc->block.as.captured.code.val);
hash... - 05:56 AM Revision 050a8954 (git): Wake up join list within thread EC context. (#4471)
- * Wake up join list within thread EC context.
* Consume items from join list so that they are not re-executed.
If `rb_fiber_scheduler_unblock` raises an exception, it can result in a
segfault if `rb_threadptr_join_list_wakeup` is not w... -
-
-
- 04:21 AM Revision 2792acc8 (git): Add scheduler hook `Addrinfo.getaddrinfo`. (#4375)
- Co-authored-by: Bruno Sutic <code@brunosutic.com>
-
- Applied in changeset commit:git|688b217706546c2bc9a0926de246dc29d0935261.
----------
time.c: Check if defined(RUBY_MSVCRT_VERSION) to build on Solaris
Fixes [Bug #17947] -
- Fixes [Bug #17947]
- 01:09 AM Revision 09ea2bb0 (git): * 2021-06-14 [ci skip]
-
- ```
p RubyVM::AbstractSyntaxTree.parse("::Foo += 1").children
#=> before: [[], nil, (OP_CDECL@1:0-1:10 (COLON3@1:0-1:10 :Foo) :+ (LIT@1:9-1:10 1))]
#=> after: [[], nil, (OP_CDECL@1:0-1:10 (COLON3@1:0-1:5 :Foo) :+ (LIT@1:9-1:10 1))]
```
06/13/2021
-
- A separate ticket for `-Wparentheses` warning issue: #17946
-
- Or should `extconf.rb` be improved to notice deprecation?
```
../../../ext/date/date_core.c:7803:17: warning: 'timezone' is deprecated: Only provided for source compatibility; this variable might not always be accurate when linking t... -
- `_WIN64` is not defined on i386-mingw32 + ucrt.
-
- Here is PR.
https://github.com/ruby/ruby/pull/4375 -
- I ran that patch on our CI, and confirm that the crash is entirely gone. Thank you!
-
- Please disable default clang-llvm selection by default on Solaris.
All tests above passed with `CC=gcc ./configure --enable-shared --disable-rpath`. -
- You were right, this is llvm's issue.
Ruby successfully passed all tests under GCC on Solaris SPARC.
```
...
...
PASS all 1488 tests
exec ./miniruby -I./lib -I. -I.ext/common ./tool/runruby.rb --extout=.ext -- --disable-gems "./b... -
-
- As well as 2366c681166a1dab95de6b9ca8ffcaae18aadd39.
-
-
- jemalloc (5.2.1 at least) cannot compile in C++ on macOS SDK, due
to conflicts on exception specification. -
05:09 AM Bug #17948: Backport d74e5d5b4fba41a9120b3ed2762cf765478605ad (Crash more nicely when the VM isn't fully set up)
- ruby_3_0 f0a1c063490d69f0868876deed74ad52db63cf4b merged revision(s) d74e5d5b4fba41a9120b3ed2762cf765478605ad.
-
- Crash more nicely when the VM isn't fully set up
If we crash but the VM isn't fully alive, we can get an infinite loop.
---
vm_dump.c | 62 ++++++++++++++++++++++++++++++++------------------------------
... - 04:45 AM Revision cba92b32 (git): * 2021-06-13 [ci skip]
-
04:44 AM Revision d54f74a4 (git): Refactor rb_block_call function
- rb_block_call and rb_block_call_kw have similar code.
So, using rb_block_kw function in rb_block_call function for refactoring.