Activity
From 08/20/2020 to 08/26/2020
08/26/2020
-
08:43 PM Bug #17030: Enumerable#grep{_v} should be optimized for Regexp
- What about this?
```ruby
2.times do
p $~ # depends on match *below*
rx =~ str
end
```
Now imagine if `2.times` is replaced by `foo`; a priori we can't know if or how many times the block will be executed. So what I was tr... -
07:31 PM Bug #17030: Enumerable#grep{_v} should be optimized for Regexp
- Dan0042 (Daniel DeLorme) wrote in #note-15:
> But static analysis has other limits
Good example but it is easily resolved: assume `v` isn't a Regexp and we may get a false positive, which is not a big issue. There will be other false... -
- > Couldn't static analysis of the code determine in most cases if match data need be generated or not?
scivola20 had a good idea, but this is even better. We can automatically get the best performance without having to manually optimi... -
- fatkodima (Dima Fatko) wrote in #note-13:
> In many cases, probably yes, but again, `case-when`, when arguments/consts/etc instead of local vars are used - it is hard to tell if them are regexes or not.
That's not really what I'm pro... -
05:01 PM Bug #17030: Enumerable#grep{_v} should be optimized for Regexp
- marcandre (Marc-Andre Lafortune) wrote in #note-12:
> Maybe it would be best to start a different thread as none of these proposals have a relation to `grep{_v}` without block not being optimized.
I have already implemented a patch to m... -
- Couldn't static analysis of the code determine in most cases if match data need be generated or not?
This is Ruby, so I can think of some corner cases where things like `const_get(:Regexp).last_match` would be impacted (in theory), wh... -
- sawa (Tsuyoshi Sawada) wrote in #note-10:
> I feel scivola20 (sciv ola)'s idea promising, but have a concern that it is going to introduce the same kind of mess as when `"string"f` notation was introduced (same "f" used due to frozen and... -
08:27 PM Bug #17048: Calling initialize_copy on live modules leads to crashes
- Yes, nobu's patch fixes the crash. It is technically a breaking change though, so maybe it needs approval from Matz?
Side note, the bug still exists on master as of [today](https://wandbox.org/permlink/afSmo1UbL9wnIBmq). -
06:11 PM Bug #17131: Time.at(time) != time in certain cases
- The check for `to_int` in addition to `to_r` is deliberate. The related code comment states: `test to_int method availability to reject non-Numeric objects such as String, Time, etc which have to_r method`. So that is not a bug.
I'v... -
05:49 PM Bug #17131 (Closed): Time.at(time) != time in certain cases
- ## Problem
According to the [spec](https://github.com/ruby/ruby/blob/445e5548c9da906a2d7a490e660328b2893d07d1/spec/ruby/core/time/at_spec.rb#L89):
```ruby
describe "with an argument that responds to #to_r" do
it "coerce... -
- Pull request submitted: https://github.com/ruby/ruby/pull/3458
-
- Method#super_method currently does not work correctly for aliased methods. Here's a simple example:
```ruby
class A
def m1; p :A_m1 end
def m2; p :A_m2 end
end
class B < A
def m1; p :B_m1; super end
alias m2 m1
end
... -
- I'm able to reproduce this issue on Windows (`ruby 2.7.0p0 (2019-12-25 revision 647ee6f091) [x64-mingw32]`), but not on OpenBSD (probably expected).
On Windows, this doesn't just affect IO#gets, it also affects IO#read and likely othe... -
12:36 PM Revision 445e5548 (git): Fixed error messages at non-ascii %string terminator
-
-
09:05 AM Feature #17127: Some TrueClass methods are faster if implemented in Ruby
- these method able to speeding up implemented by Ruby code.
- `TrueClass#^`
- `TrueClass#&`
benchmark:
```yaml
benchmark:
to_s: |
true.to_s
inspect: |
true.inspect
or: |
true | false
xor: |
true ^ false
and: |... -
08:40 AM Misc #17041: DevelopersMeeting20200831Japan
- The meeting was postponed to the next Monday (31th Aug.) for some reason.
-
01:16 AM Misc #17041: DevelopersMeeting20200831Japan
- * [Feature #16812] Allow slicing arrays with ArithmeticSequence (mrkn)
* I found the wrong test case, so the implementation was also in wrong state. The proposed patch has been fixed.
* There are opposing opinions in the following ... -
08:39 AM Bug #17129: bundle install `eventmachine` and `sassc` fails since 914b2208ab3eddec478cdc3e079e6c30d0f0892c
- It only reproduces with Ruby using`rubylang/ruby:master-nightly-bionic`.
It does not reproduce ruby installed by `rbenv install 2.8.0-dev` at local Ubuntu 18.04.5 LTS, then I do not know how to provide `config.log`, yet. -
08:10 AM Bug #17129: bundle install `eventmachine` and `sassc` fails since 914b2208ab3eddec478cdc3e079e6c30d0f0892c
- Is there a way for me to get the `config.log` which has to be created during compiling ruby itself? It must contain the reason why the C++ compiler was rejected.
-
- bundle install `eventmachine` and `sassc` fails since 914b2208ab3eddec478cdc3e079e6c30d0f0892c
Ruby on Rails CI against ruby 2.8.0dev using rubylang/ruby:master-nightly-bionic docker image has been failing since https://buildkite.com/... -
07:43 AM Feature #17104: Do not freeze interpolated strings when using frozen-string-literal
- Non-freezing interpolated strings is good thing to reduce allocations.
I think it is possible if most developers understands difference of interpolated and non-interpolated strings.
-
07:30 AM Feature #17125: Remove Thread.exclusive
- We checked gems which use this API and they look obsoleted.e
We should check the impact with preview.
Go ahead -
- It looks implementation detail and concurrent gems already supports new headers.
Go ahead -
06:35 AM Feature #17122: Add category to Warning#warn
- If we can accept the compatibility issue, I support it.
However, I'm not sure the "category" is a last attribute, so to make stable API, accept `**kw` is one idea (but it increases runtime overhead). -
- We discussed about it and I recognized the motivation is how to shorten the migration period (to reuse conflicts feature or to delete barrier features) and I understand the advantages of this proposal.
IMO off-by-default and on-by-defau... - 05:28 AM Revision 72cb9bc5 (git): [webrick][DOC] Describe the stance of WEBrick about its security and utilization (#3457)
- WEBrick is not recommended for the production use. We need to explicitly
describe this fact in the document to avoid troubles due to misunderstanding. -
- Gauche scheme interpreter has same issue and Kawai-san (the author of Gauche) investigate it.
http://blog.practical-scheme.net/gauche/20200722-ratnum-flonum
08/25/2020
-
11:37 PM Bug #17030: Enumerable#grep{_v} should be optimized for Regexp
- I feel scivola20 (sciv ola)'s idea promising, but have a concern that it is going to introduce the same kind of mess as when `"string"f` notation was introduced (same "f" used due to frozen and fast, but this is just coincidental). Peopl...
-
- I have implemented a simple PoC - https://github.com/ruby/ruby/pull/3455.
I got the following results.
## Enumerable#grep
```ruby
ARR = %w[foobar foobaz bazquux hello world just making this array longer]
REGEXP = /o/
FAST_REG... -
- I like @scivola20 's idea and would like to try to implement it.
Before starting, @nobu, wdyt, is this something that will be merged? -
- - [Feature #14723] python's buffer protocol clone (mrkn)
- I renamed `buffer` to `memory_view`.
- This name is already used in Python for the Python object wrapper of `PyBuffer`.
- I've added tests for some functions and ... -
-
- I think this was fixed by commit:92b2d5816ae04375cef7e3909bf69954e1833160.
-
- The pull request was merged (https://github.com/ruby/io-console/pull/16), so this can be closed.
-
09:09 PM Revision a84a2e87 (git): Comply with guide for method doc: hash.c (#3454)
- Methods reviewed (a few not modified):
key
delete
shift
delete_if
reject!
reject
slice
except
values_at
fetch_values
select
select!
keep_if -
05:50 PM Revision 92b2d581 (git): Add documentation to "dcompact" callback and "parent" member
-
05:14 PM Revision 326d89b7 (git): Correctly account for heap_pages_final_slots so it does not underflow
- `rb_objspace_call_finalizer` creates zombies, but does not do the correct accounting (it should increment `heap_pages_final_slots` whenever it creates a zombie). When we do correct accounting, `heap_pages_final_slots` should never underf...
- 03:47 PM Revision 8c030b5c (git): * 2020-08-26 [ci skip]
-
- Methods:
::new
::[]
::try_convert
#rehash
#[]
#fetch
#default
#default=
#default_proc
#default_proc= -
12:17 PM Revision 2e3a7f70 (git): Promote nkf to default gems
- 09:11 AM Revision 8d68f54c (git): Fix erb executable
- Run ERb processing unconditionally since __FILE__ and $0 doesn't match
in a gem context.
08/24/2020
-
-
11:11 PM Bug #17094 (Closed): PTY methods with blocks
- Applied in changeset commit:git|9e25eb308d4fae9a10e120c2b4601916cc38336c.
----------
Update PTY.open documentation to document it yields a single argument [ci skip]
For a regular block, accepting two arguments is fine as the array
will... - 11:11 PM Revision 1b34d843 (git): * 2020-08-25 [ci skip]
-
- For a regular block, accepting two arguments is fine as the array
will be autosplatted. However, a lambda that accepts two arguments
will not work.
We could change the implementation to yield two arguments instead
of an array with a s... -
- I've added a pull request with a fix for this: https://github.com/ruby/ruby/pull/3452
-
- The enabled-by-default deprecation warnings have following effects.
- Good Effect: It makes developers more aware of the problem. (including users noticing and creating a issue)
- Bad Effect: Users ignore warnings or stop ruby upgrade
... -
- +1
I think this is more important than having a general Set syntax as discussed in #5478. Being able to use `%ws[foo bar].include?(str)` is a double-plus of not creating a new object each time and having O(1) efficiency. -
- > matz: Positive to introduce Set into core. But we need to first introduce a set literal. { x, y, z } is good, but JavaScript uses it as another meanings, so it would bring confusion.
I have to ask, is [lack of] similarity with javas... -
- That's great news.
Was there discussion for a *frozen* set literal of symbols / strings as I proposed in #16994? For sets that need to be mutable or containing different types of objects, I find the existing `Set[...]` quite convenien... -
- We discussed this issue at the last-month meeting.
https://github.com/ruby/dev-meeting-log/blob/master/DevelopersMeeting20200720Japan.md
> matz: Positive to introduce Set into core. But we need to first introduce a set literal. { x... -
- k0kubun (Takashi Kokubun) wrote in #note-3:
> off topic: If you write an entire ticket in English, I think you should post your ticket to ruby-core to attract more audiences instead of ruby-dev, which has been for tickets written in Jap... -
- Dan0042 (Daniel DeLorme) wrote in #note-37:
> > I thought that this would be a useful substitute of symbol-key Hash (like JSON data) which we can read the values by `s.name` instead of `s[:name]`.
> ...
I thought so. Thus, I wanted to... -
- > I thought that this would be a useful substitute of symbol-key Hash (like JSON data) which we can read the values by `s.name` instead of `s[:name]`.
This is the same thing stated in the Feature proposal, and I would also like this, ... -
- 👍
I'd like to have optional `start` and `stop` arguments for `find_index`, `find`, `bsearch` and `bsearch_index`.
As mentionned, a typical usecase is to repeat a lookup, but another one is to lookup a range of indices (e.g. which e... -
-
07:35 AM Feature #17103: Add a :since option to ObjectSpace.dump_all
- > this feature strongly connected with trace_object_allocations, right?
Indeed.
> ...
I changed:
```
Objects that were allocated with object allocation tracing disabled are not dumped.
```
to:
```
Objects that were allo... -
- this feature strongly connected with `trace_object_allocations`, right? so please write it on document.
what happens on without `trace_object_allocations`? it is unclear. -
06:58 AM Revision cb7634c1 (git): Fix links [ci skip]
-
-
- Without the patch:
```ruby
require "digest"
p Digest::SHA256 #=> Digest::SHA256
p Digest::SHA2 #=> Digest::SHA2
```
With the patch:
```ruby
require "digest"
p Digest::SHA256 #=> Digest::SHA256
p Digest::SHA2 #=> unini...
08/23/2020
-
09:07 PM Feature #6309: Add a reference queue for weak references
- This still seems like a good idea. Any update?
- 05:10 PM Revision f292bb24 (git): * 2020-08-24 [ci skip]
-
- Further compliance with https://github.com/ruby/ruby/blob/master/doc/method_documentation.rdoc#details-and-examples-
-
- 12:46 PM Revision 4f7ff9c9 (git): * 2020-08-23 [ci skip]
-
- Added some cross compilers that we can run on GitHub Workflow runner
environments. Because they are cross compilers we cannot run the
generated binary. The added matrix are compile-only. -
- > > When it comes to optimization, though, I would assume that the keywords are all symbols would open a lot more doors.
> ...
If a Hash contains only Symbol keys I can easily imagine an optimized implementation that takes advantage of S...
08/22/2020
-
09:59 AM Bug #16853: calling bla(hash, **kw) with a string-based hash passes the strings into **kw (worked < 2.7)
- FWIW I also find the `where("table.id" => 42)` example unconvincing.
That could work just fine with `def where(conditions)`, no need and it seems no much gains for keyword arguments there. -
- sylvain.joyeux (Sylvain Joyeux) wrote in #note-9:
> Keyword splat would not allow anything but symbols as keys pre-2.7.
Indeed, so what happens is the Hash is magically split in two if it has non-Symbol keys (or `raise`s with `**`):
... -
- They are rather annoying than being useful to us.
-
02:54 AM Feature #15974: Warn in verbose mode on defining a finalizer that captures the object
- A partial solution to this but with a better implementation is at https://github.com/ruby/ruby/pull/3444.
-
- It seems `clang --save-temps` does not interface well with
tool/update-deps. Prefer gcc for that purpose. -
- STRIP now depends on compilers, not on OS. Previous check against
$target_os does no longer work. -
- https://rubyci.org/logs/rubyci.s3.amazonaws.com/freebsd12/ruby-master/log/20200821T223002Z.fail.html.gz
```
process.c:5593:37: error: implicit conversion loses integer precision: 'long' to 'int' [-Werror,-Wshorten-64-to-32]
while ((g...
08/21/2020
-
- Applied in changeset commit:git|a0273d67d044dc9fe25313e0854a33374b990e8a.
----------
Avoid a use after free in VM assertion
If the thread for the current EC has been killed, don't check
the VM ptr for the EC (which gets it via the thre... -
- I think I've found a solution. If the thread for the EC has been killed, then don't check that the VM pointer matches, because the thread's memory (including the VM pointer) will have been freed. I've added a pull request that fixes th...
-
- If the thread for the current EC has been killed, don't check
the VM ptr for the EC (which gets it via the thread), as that will
have already been freed.
Fixes [Bug #16907] -
- "Trivial" typically means "returns a new empty Array."
-
08:37 PM Bug #16853: calling bla(hash, **kw) with a string-based hash passes the strings into **kw (worked < 2.7)
- > If there is a call like foo(**h), and h has both Symbol and non-Symbol keys, in <2.7 the Hash is "split" which I find extremely confusing and it's also slowing things down by always having to consider "there might be an extra positiona...
-
06:37 PM Feature #17127: Some TrueClass methods are faster if implemented in Ruby
- off topic: If you write an entire ticket in English, I think you should post your ticket to ruby-core to attract more audiences instead of ruby-dev, which has been for tickets written in Japanese.
-
- Most of the CI issues were when running with asserts, so I compiled with asserts enabled and ran tests. It took quite a while, and no problems were noted:
```
Finished tests in 82924.634324s, 0.2518 tests/s, 67.0770 assertions/s.
2... -
- * Remove nil-return examples from hash.c
-
03:54 PM Bug #17128: test_io_console.rb fails on actual console
- Jeremy, thank you for the suggestion! I will do that now.
-
- leam (Leam Hall) wrote in #note-1:
> I have opened Bug 17128, to handle an edge case in a test. I have
> ...
I'm not sure whether the change is correct, but if you would like to submit a pull request for it, you should do so to the up... -
- I have opened Bug 17128, to handle an edge case in a test. I have
working code to fix the issue, but am still learning the Ruby process
for contributing.
Is this small enough to do a pull request for? Is there a better way to
r... -
- When running "make test-all TESTS=io/console/test_io_console" on the current Ruby source, the following error is generated if the test is run on the server console:
Run options:
--seed=37271
"--ruby=./miniruby -I./lib -I. -I.ex... -
- CI failures observed for old Sun C++. We don't want to hustle, as newer
versions are okay. Just check the sanity and rule out insane compilers. -
- AC_PROG_CC_C99 calls AC_PROC_CC, which calls _AC_PROG_CC_G, which sets
default CFLAGS, whose contents are not customisable. We don't welcome
this behaviour.
The exact same thing happens for CXXFLAGS in AC_PROG_CXX. - 03:33 PM Revision 7263fd6f (git): * 2020-08-22 [ci skip]
-
- `llvm-strip-7` is a sane valid strip command that LLVM 7 ships, albeit
it does not understand `--version`. It is a bad idea to check that
option. Instead just see if the command actually strips something. A
copy of `/bin/sh` should su... -
02:22 PM Feature #17016: Enumerable#accumulate
- I'd like to propose that we name this method `#accumulate`. @matz do you think that is an acceptable name?
-
-
-
-
-
- At first, I misunderstood this feature. I thought that this would be a useful substitute of symbol-key Hash (like JSON data) which we can read the values by `s.name` instead of `s[:name]`.
However, it is not. This use is potentially... -
- In case of cross-compilation, GCC might provide its own linker. Its
behaviour seems slightly different from that of gcc(1). This is not a
big deal for normal situations, but the difference can cause libtool to
go mad.
We ship bundled ... -
- Caused CI failures on environments without sane C++ compilers.
-
- Historically `$program_transform_name` has been put in front of
`AC_CANONICAL_TARGET`. Previous commit changes it, which affects the
name of generated ruby binary when cross-compiling. I _guess_ the
historical behaviour is a bug (name ... -
- These days as link-time optimisations spread accross compilers, they
tend to ship their own version of ld, ar, etc. Why not detect such
things if any. Users can select compilers by ./configure --with-gcc=
whatever, or select individual... -
- Because we check HAVE_STMT_AND_DECL_IN_EXPR in configure, it is peoven
to work in C. But C++ situation can be different. Oracle Developer
Studio is another example of such things. -
- I found a way to suppress particular kind of warnings via pragmas.
-
- Oracle Developer Studio's C++ preprocessor started to understand
__has_cpp_attribute since version 12.5, and is broken. After looking
around for a while I found Boost and ICU also had this issue before.
Let me add workaround for it. -
08/20/2020
- 05:10 PM Revision 6ba038af (git): * 2020-08-21 [ci skip]
-
- Removes references to *-convertible thingies.
-
02:48 PM Feature #16986: Anonymous Struct literal
- ko1 (Koichi Sasada) wrote in #note-34:
> how about `%struct{a: 1, b: 2}` (and `%value{...}` if needed)?
> ...
I like it! IMO, it's one of the most "natural to read" options and is undoubtedly easier to write than `Struct.new(:a, :b, :c... -
- Some TrueClass methods are faster if implemented in Ruby code.
like this.
```ruby
class TrueClass
def to_s
"true".freeze
end
alias_method :inspect, :to_s
def |(bool)
true
end
end
```
benchmark f... -
- > About raw fds, I don't think we necessarily need to deprecate C APIs, the conversion fd->IO could be done in C (when calling the scheduler) or Ruby code (in the scheduler).
The latest PR does it in C, and it's implementation detail ... -
- Here is new PR:
https://github.com/ruby/ruby/pull/3434
> [NEED TO CHANGE] doc/fiber.rdoc
We will update it.
> ...
Removed. However, I would like to add, that if we do not have some kind of support for finding blocking behaviour in Ru... -
- I hadn't thought of `method /a /x` or `method /a /<newline>other_method`, indeed.
This warning is only there when there is ambiguity between two divisions and a regexp literal, right?
If so, could we reword the warning to "ambiguit... -
- In your example, `/[a-z]` looks very likely a regexp because of `[`, but how about `/a`?
Or `match? /(a` ...lines... `)/x`?
There are many possibilities. -
- Removes references to *-convertible thingies.
-
-
08:14 AM Bug #17126: String#gsub fails to escape single quote for shell
- Got it. I missed that completely in the documentation, thinking it wasn't related to our use of `\'`.
Thanks a lot for explaining and for supporting the Ruby programming language in the open-source community. -
07:44 AM Bug #17052: Ruby with LTO enabled has issues with SIGSEGV handler
- vo.x (Vit Ondruch) wrote in #note-4:
> Thank you for the investigation. There is a whole thread on Fedora devel mailing list:
> ...
This is the link:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/messag... -
- Thank you for the investigation. There is a whole thread on Fedora devel mailing list:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/OAD6BEN6UMVIXAEI5EDS5COUYFSPNLZN/
I have posted results of yo... -
- Meanwhile it can not be a bad idea for us to avoid SEGV even when DWARF is broken.
-
- Yes I can reproduce this on my machine.
```
% LC_ALL=C gdb --args ./miniruby -e'Process.kill("SIGSEGV",$$)'
GNU gdb (Ubuntu 8.2-0ubuntu1~18.04) 8.2
Copyright (C) 2018 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version ... -
04:24 AM Revision 6509652c (git): Skip irb/test_history on Windows too
-
-
03:21 AM Bug #16680: Symlink folder in $LOAD_PATH does not work with autoload
- nobu (Nobuyoshi Nakada) wrote in #note-6:
> I can't reproduce it with the master.
> ...
Cool, good news, so, it was fixed on our master, right?