Activity
From 08/18/2020 to 08/24/2020
08/24/2020
-
11:44 PM Revision e6ac1fb6 (git): Specify the executable of erb
-
11:11 PM Bug #17094 (Closed): PTY methods with blocks
- Applied in changeset commit:git|9e25eb308d4fae9a10e120c2b4601916cc38336c.
----------
Update PTY.open documentation to document it yields a single argument [ci skip]
For a regular block, accepting two arguments is fine as the array
will... - 11:11 PM Revision 1b34d843 (git): * 2020-08-25 [ci skip]
-
- For a regular block, accepting two arguments is fine as the array
will be autosplatted. However, a lambda that accepts two arguments
will not work.
We could change the implementation to yield two arguments instead
of an array with a s... -
10:33 PM Bug #17112: Resolv.getaddress fails with IPv6 link-local addresses
- I've added a pull request with a fix for this: https://github.com/ruby/ruby/pull/3452
-
05:42 PM Feature #16345: Don't emit deprecation warnings by default.
- The enabled-by-default deprecation warnings have following effects.
- Good Effect: It makes developers more aware of the problem. (including users noticing and creating a issue)
- Bad Effect: Users ignore warnings or stop ruby upgrade
... -
03:18 PM Feature #16994: Sets: shorthand for frozen sets of symbols / strings
- +1
I think this is more important than having a general Set syntax as discussed in #5478. Being able to use `%ws[foo bar].include?(str)` is a double-plus of not creating a new object each time and having O(1) efficiency. -
- > matz: Positive to introduce Set into core. But we need to first introduce a set literal. { x, y, z } is good, but JavaScript uses it as another meanings, so it would bring confusion.
I have to ask, is [lack of] similarity with javas... -
12:55 PM Feature #16989: Sets: need ♥️
- That's great news.
Was there discussion for a *frozen* set literal of symbols / strings as I proposed in #16994? For sets that need to be mutable or containing different types of objects, I find the existing `Set[...]` quite convenien... -
04:13 AM Feature #16989: Sets: need ♥️
- We discussed this issue at the last-month meeting.
https://github.com/ruby/dev-meeting-log/blob/master/DevelopersMeeting20200720Japan.md
> matz: Positive to introduce Set into core. But we need to first introduce a set literal. { x... -
02:34 PM Feature #17127: Some TrueClass methods are faster if implemented in Ruby
- k0kubun (Takashi Kokubun) wrote in #note-3:
> off topic: If you write an entire ticket in English, I think you should post your ticket to ruby-core to attract more audiences instead of ruby-dev, which has been for tickets written in Jap... -
- Dan0042 (Daniel DeLorme) wrote in #note-37:
> > I thought that this would be a useful substitute of symbol-key Hash (like JSON data) which we can read the values by `s.name` instead of `s[:name]`.
> ...
I thought so. Thus, I wanted to... -
- > I thought that this would be a useful substitute of symbol-key Hash (like JSON data) which we can read the values by `s.name` instead of `s[:name]`.
This is the same thing stated in the Feature proposal, and I would also like this, ... -
- 👍
I'd like to have optional `start` and `stop` arguments for `find_index`, `find`, `bsearch` and `bsearch_index`.
As mentionned, a typical usecase is to repeat a lookup, but another one is to lookup a range of indices (e.g. which e... -
-
07:35 AM Feature #17103: Add a :since option to ObjectSpace.dump_all
- > this feature strongly connected with trace_object_allocations, right?
Indeed.
> ...
I changed:
```
Objects that were allocated with object allocation tracing disabled are not dumped.
```
to:
```
Objects that were allo... -
04:49 AM Feature #17103: Add a :since option to ObjectSpace.dump_all
- this feature strongly connected with `trace_object_allocations`, right? so please write it on document.
what happens on without `trace_object_allocations`? it is unclear. -
06:58 AM Revision cb7634c1 (git): Fix links [ci skip]
-
-
- Without the patch:
```ruby
require "digest"
p Digest::SHA256 #=> Digest::SHA256
p Digest::SHA2 #=> Digest::SHA2
```
With the patch:
```ruby
require "digest"
p Digest::SHA256 #=> Digest::SHA256
p Digest::SHA2 #=> unini...
08/23/2020
-
09:07 PM Feature #6309: Add a reference queue for weak references
- This still seems like a good idea. Any update?
- 05:10 PM Revision f292bb24 (git): * 2020-08-24 [ci skip]
-
05:10 PM Revision 1d3e87a2 (git): Remove checks for self returned in array.c and hash.c examples (#3446)
- Further compliance with https://github.com/ruby/ruby/blob/master/doc/method_documentation.rdoc#details-and-examples-
-
- 12:46 PM Revision 4f7ff9c9 (git): * 2020-08-23 [ci skip]
-
12:45 PM Revision 2c4c088a (git): .github/workflows/compilers.yml: more compilers
- Added some cross compilers that we can run on GitHub Workflow runner
environments. Because they are cross compilers we cannot run the
generated binary. The added matrix are compile-only. -
- > > When it comes to optimization, though, I would assume that the keywords are all symbols would open a lot more doors.
> ...
If a Hash contains only Symbol keys I can easily imagine an optimized implementation that takes advantage of S...
08/22/2020
-
09:59 AM Bug #16853: calling bla(hash, **kw) with a string-based hash passes the strings into **kw (worked < 2.7)
- FWIW I also find the `where("table.id" => 42)` example unconvincing.
That could work just fine with `def where(conditions)`, no need and it seems no much gains for keyword arguments there. -
- sylvain.joyeux (Sylvain Joyeux) wrote in #note-9:
> Keyword splat would not allow anything but symbols as keys pre-2.7.
Indeed, so what happens is the Hash is magically split in two if it has non-Symbol keys (or `raise`s with `**`):
... -
- They are rather annoying than being useful to us.
-
02:54 AM Feature #15974: Warn in verbose mode on defining a finalizer that captures the object
- A partial solution to this but with a better implementation is at https://github.com/ruby/ruby/pull/3444.
-
- It seems `clang --save-temps` does not interface well with
tool/update-deps. Prefer gcc for that purpose. -
- STRIP now depends on compilers, not on OS. Previous check against
$target_os does no longer work. -
- https://rubyci.org/logs/rubyci.s3.amazonaws.com/freebsd12/ruby-master/log/20200821T223002Z.fail.html.gz
```
process.c:5593:37: error: implicit conversion loses integer precision: 'long' to 'int' [-Werror,-Wshorten-64-to-32]
while ((g...
08/21/2020
-
- Applied in changeset commit:git|a0273d67d044dc9fe25313e0854a33374b990e8a.
----------
Avoid a use after free in VM assertion
If the thread for the current EC has been killed, don't check
the VM ptr for the EC (which gets it via the thre... -
- I think I've found a solution. If the thread for the EC has been killed, then don't check that the VM pointer matches, because the thread's memory (including the VM pointer) will have been freed. I've added a pull request that fixes th...
-
- If the thread for the current EC has been killed, don't check
the VM ptr for the EC (which gets it via the thread), as that will
have already been freed.
Fixes [Bug #16907] -
- "Trivial" typically means "returns a new empty Array."
-
08:37 PM Bug #16853: calling bla(hash, **kw) with a string-based hash passes the strings into **kw (worked < 2.7)
- > If there is a call like foo(**h), and h has both Symbol and non-Symbol keys, in <2.7 the Hash is "split" which I find extremely confusing and it's also slowing things down by always having to consider "there might be an extra positiona...
-
06:37 PM Feature #17127: Some TrueClass methods are faster if implemented in Ruby
- off topic: If you write an entire ticket in English, I think you should post your ticket to ruby-core to attract more audiences instead of ruby-dev, which has been for tickets written in Japanese.
-
- Most of the CI issues were when running with asserts, so I compiled with asserts enabled and ran tests. It took quite a while, and no problems were noted:
```
Finished tests in 82924.634324s, 0.2518 tests/s, 67.0770 assertions/s.
2... -
- * Remove nil-return examples from hash.c
-
03:54 PM Bug #17128: test_io_console.rb fails on actual console
- Jeremy, thank you for the suggestion! I will do that now.
-
- leam (Leam Hall) wrote in #note-1:
> I have opened Bug 17128, to handle an edge case in a test. I have
> ...
I'm not sure whether the change is correct, but if you would like to submit a pull request for it, you should do so to the up... -
- I have opened Bug 17128, to handle an edge case in a test. I have
working code to fix the issue, but am still learning the Ruby process
for contributing.
Is this small enough to do a pull request for? Is there a better way to
r... -
- When running "make test-all TESTS=io/console/test_io_console" on the current Ruby source, the following error is generated if the test is run on the server console:
Run options:
--seed=37271
"--ruby=./miniruby -I./lib -I. -I.ex... -
- CI failures observed for old Sun C++. We don't want to hustle, as newer
versions are okay. Just check the sanity and rule out insane compilers. -
- AC_PROG_CC_C99 calls AC_PROC_CC, which calls _AC_PROG_CC_G, which sets
default CFLAGS, whose contents are not customisable. We don't welcome
this behaviour.
The exact same thing happens for CXXFLAGS in AC_PROG_CXX. - 03:33 PM Revision 7263fd6f (git): * 2020-08-22 [ci skip]
-
- `llvm-strip-7` is a sane valid strip command that LLVM 7 ships, albeit
it does not understand `--version`. It is a bad idea to check that
option. Instead just see if the command actually strips something. A
copy of `/bin/sh` should su... -
02:22 PM Feature #17016: Enumerable#accumulate
- I'd like to propose that we name this method `#accumulate`. @matz do you think that is an acceptable name?
-
-
-
-
-
- At first, I misunderstood this feature. I thought that this would be a useful substitute of symbol-key Hash (like JSON data) which we can read the values by `s.name` instead of `s[:name]`.
However, it is not. This use is potentially... -
- In case of cross-compilation, GCC might provide its own linker. Its
behaviour seems slightly different from that of gcc(1). This is not a
big deal for normal situations, but the difference can cause libtool to
go mad.
We ship bundled ... -
- Caused CI failures on environments without sane C++ compilers.
-
- Historically `$program_transform_name` has been put in front of
`AC_CANONICAL_TARGET`. Previous commit changes it, which affects the
name of generated ruby binary when cross-compiling. I _guess_ the
historical behaviour is a bug (name ... -
- These days as link-time optimisations spread accross compilers, they
tend to ship their own version of ld, ar, etc. Why not detect such
things if any. Users can select compilers by ./configure --with-gcc=
whatever, or select individual... -
- Because we check HAVE_STMT_AND_DECL_IN_EXPR in configure, it is peoven
to work in C. But C++ situation can be different. Oracle Developer
Studio is another example of such things. -
- I found a way to suppress particular kind of warnings via pragmas.
-
- Oracle Developer Studio's C++ preprocessor started to understand
__has_cpp_attribute since version 12.5, and is broken. After looking
around for a while I found Boost and ICU also had this issue before.
Let me add workaround for it. -
08/20/2020
- 05:10 PM Revision 6ba038af (git): * 2020-08-21 [ci skip]
-
- Removes references to *-convertible thingies.
-
02:48 PM Feature #16986: Anonymous Struct literal
- ko1 (Koichi Sasada) wrote in #note-34:
> how about `%struct{a: 1, b: 2}` (and `%value{...}` if needed)?
> ...
I like it! IMO, it's one of the most "natural to read" options and is undoubtedly easier to write than `Struct.new(:a, :b, :c... -
- Some TrueClass methods are faster if implemented in Ruby code.
like this.
```ruby
class TrueClass
def to_s
"true".freeze
end
alias_method :inspect, :to_s
def |(bool)
true
end
end
```
benchmark f... -
- > About raw fds, I don't think we necessarily need to deprecate C APIs, the conversion fd->IO could be done in C (when calling the scheduler) or Ruby code (in the scheduler).
The latest PR does it in C, and it's implementation detail ... -
- Here is new PR:
https://github.com/ruby/ruby/pull/3434
> [NEED TO CHANGE] doc/fiber.rdoc
We will update it.
> ...
Removed. However, I would like to add, that if we do not have some kind of support for finding blocking behaviour in Ru... -
- I hadn't thought of `method /a /x` or `method /a /<newline>other_method`, indeed.
This warning is only there when there is ambiguity between two divisions and a regexp literal, right?
If so, could we reword the warning to "ambiguit... -
09:41 AM Bug #17124: Wrong "ambiguous first argument" warning
- In your example, `/[a-z]` looks very likely a regexp because of `[`, but how about `/a`?
Or `match? /(a` ...lines... `)/x`?
There are many possibilities. -
- Removes references to *-convertible thingies.
-
-
08:14 AM Bug #17126: String#gsub fails to escape single quote for shell
- Got it. I missed that completely in the documentation, thinking it wasn't related to our use of `\'`.
Thanks a lot for explaining and for supporting the Ruby programming language in the open-source community. -
07:44 AM Bug #17052: Ruby with LTO enabled has issues with SIGSEGV handler
- vo.x (Vit Ondruch) wrote in #note-4:
> Thank you for the investigation. There is a whole thread on Fedora devel mailing list:
> ...
This is the link:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/messag... -
- Thank you for the investigation. There is a whole thread on Fedora devel mailing list:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/OAD6BEN6UMVIXAEI5EDS5COUYFSPNLZN/
I have posted results of yo... -
- Meanwhile it can not be a bad idea for us to avoid SEGV even when DWARF is broken.
-
- Yes I can reproduce this on my machine.
```
% LC_ALL=C gdb --args ./miniruby -e'Process.kill("SIGSEGV",$$)'
GNU gdb (Ubuntu 8.2-0ubuntu1~18.04) 8.2
Copyright (C) 2018 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version ... -
04:24 AM Revision 6509652c (git): Skip irb/test_history on Windows too
-
-
03:21 AM Bug #16680: Symlink folder in $LOAD_PATH does not work with autoload
- nobu (Nobuyoshi Nakada) wrote in #note-6:
> I can't reproduce it with the master.
> ...
Cool, good news, so, it was fixed on our master, right?
08/19/2020
- 11:32 PM Revision eae7aef0 (git): [DOC] Improve Hash's doc for missing keys
- 11:32 PM Revision a586ccf2 (git): [DOC] Improve and simplify key egality documentation for Hash
-
- Removes references to *-convertible thingies.
-
08:39 PM Bug #10222: require_relative and require should be compatible with each other when symlinks are used
- I recently encountered this issue on v2.7.1, when symlinked directories were included in the $RUBYLIB environment variable. I was not experiencing the issue on v2.5.1 with the exact same setup however. Has the bug regressed, or was $RUBY...
-
- I recently confirmed this bug still exists on the most recent 2.5 release, 2.5.8. Was this fix ever backported to the 2.5 branch?
-
- how about `%struct{a: 1, b: 2}` (and `%value{...}` if needed)?
(znz-san's idea and it seems nice) -
- `\'` means something special in a sub/gsub replacement string, see the documentation for details: https://docs.ruby-lang.org/en/2.7.0/String.html#method-i-gsub
As the documentation explains, use four backslashes:
```ruby
puts "Hel... -
- Hi, I don't know if I'm misunderstanding how `String#gsub` works, but I encountered an issue in the Ruby "git" gem with escaping single quotes for shell, which I fixed and [contributed back](https://github.com/ruby-git/ruby-git/pull/480)...
-
- mame (Yusuke Endoh) wrote in #note-10:
> My another idea is to call `Warning.warn_deprecated` or `Warning.warn_experimental` before the general `Warning.warn`.
I prefer this approach unless we decide to add categories for all warnings. -
- I've added this ticket to the next dev-meeting agenda.
@byroot Yes, an arity check would work.
My another idea is to call `Warning.warn_deprecated` or `Warning.warn_experimental` before the general `Warning.warn`. I'm not sure if ... -
- I'd like to second this feature request. We used the same workflow in Shopify, and still have a bunch of regexps today to raise on deprecations that would break on 2.8. Having a simple category symbol would make all this much easier.
... -
- Hi Eileen,
First of all, thank you not only for contributing to Ruby but also for working hard on keyword argument separation for GitHub code base!
I think that this feature is reasonable, but I concern its compatibility.
```
m... -
- * [Feature #17122] Add category to Warning#warn (mame)
* I'd like to hear opinions from the committers -
* [Feature #17125] Remove `Thread.exclusive` (znz)
* `Thread.exclusive` is deprecated since 2.3.-
03:19 PM Bug #17020 (Closed): ObjectSpace.trace_object_allocations_stop raises if called before trace_object_allocations_start
- I merged. Thanks for the patch
-
- I can't close, but this is fixed in a74df67244199d1fd1f7a20b49dd5a096d2a13a2
-
- 03:09 PM Revision 7d01d881 (git): * 2020-08-20 [ci skip]
-
- If the passed string is frozen, bare and not shared, then there
is no need to duplicate it.
Ref: 4ab69ebbd7cef8539f687e1f948845d076461dc6
Ref: https://bugs.ruby-lang.org/issues/11386 -
- >racc.gemspec says s.licenses = ["MIT"].
It's my mistake. It should be use "Ruby" license. I fixed at https://github.com/ruby/racc/commit/f600effadaec9e389fc336309021640c565c7232.
> ...
racc uses Ruby license now. If some files sho... -
- Great! I have also updated LEGAL in https://github.com/ruby/ruby/pull/3082
The situation is much better than before now. Thank you. -
-
- https://github.com/ruby/racc/commit/a1aeecff03
-
- Because Editline erases all histories in Readline::HISTORY when
Readline.readline is called. -
- Here you are: https://github.com/ruby/ruby/pull/3424/commits/f762b2952976905bc658df799890b0e9b61d558f
-
- `Thread.exclusive` is deprecated since 2.3.
```
% docker run -it --rm rubylang/all-ruby env ALL_RUBY_SINCE=ruby-1.8 ./all-ruby -r thread -e 'Thread.exclusive{}'
ruby-1.8.0
...
ruby-2.3.0-preview1
ruby-2.3.0-preview2 Thread.excl... -
-
- It seems almost no internal codes use RHASH_TBL any longer. Why not
just eliminate it entirely, so that the macro can be purely ext-only. -
-
- Former ROBJECT_IV_INDEX_TBL macro included RCLASS_IV_INDEX_TBL, which is
not disclosed to extension libraies. The macro was kind of broken. Why
not just deprecate it, and convert the internal use into an inline
function. -
-
- Compaction makes collisions in the weak map more likely. For now, clear
the tracing information before the test run so we get accurate results -
-
- The allocation tracing code keeps essentially a weak reference to
objects that have been allocated (storing the allocation information
along with the weak ref). Compacting the heap would break references in
this weak map, so the wrong v... - 12:46 AM Revision 371c051c (git): * 2020-08-19 [ci skip]
-
08/18/2020
-
- ```sh
$ ruby -v -e "x='a'; x.match? /[a-z]/"
ruby 2.8.0dev (2020-07-30T14:07:06Z master 352895b751) [x86_64-darwin18]
-e:1: warning: ambiguous first argument; put parentheses or a space even after `/' operator
```
There is no `/` ... -
07:04 PM Feature #17122: Add category to Warning#warn
- > I don't think we should add a category keyword if the only usage is for deprecation warnings. If we are going to do this, I think:
> ...
As Aaron mentioned, categories already have warnings. My use-case is for deprecations, but that d... -
- larskanis (Lars Kanis) wrote in #note-19:
> @tenderlovemaking The issue in FFI is still unsolved. Could you please have a look at the questions above? Or may I open a new issue for discussion?
Hi Lars,
Sorry I totally missed your ... -
06:14 PM Bug #17023: How to prevent String memory to be relocated in ruby-ffi
- @tenderlovemaking The issue in FFI is still unsolved. Could you please have a look at the questions above? Or may I open a new issue for discussion?
-
- Issue #16122 gave me this idea:
I we already had `Struct::Value`, then I think it would make a lot of sense to allow the following syntax:
`%v{ a: 1, b: 2, c: 3 }` **v** short for Struct.**V**alue => immutable: true, enumerable: fa... -
04:05 PM Feature #17059: epoll as the backend of IO.select on Linux
- Yes. I was just figured out that the scheduler is an example in the tests, where the real scheduler is designed to be separated from the ruby-core.
-
- In other words I don't think we need to have selectors in Ruby core.
That's part of the beauty of this new scheduler API: it lets you implement it in various way, including how do you want to wait for IO. -
- dsh0416 (Delton Ding) wrote in #note-16:
> I would try to use these methods to deal with the registration then, and replace the `IO.select` in the `Scheduler#run` for performance.
Where do you see `IO.select` in the `Scheduler`?
Her... -
- ```
/home/chkbuild/chkbuild/tmp/build/20200818T123003Z/ruby/test/irb/test_history.rb:16:
warning: assigned but unused variable - result_output
/home/chkbuild/chkbuild/tmp/build/20200818T123003Z/ruby/test/irb/test_history.rb:34:
warning: ... -
- Regarding naming, based on what we discussed I think these are good candidates:
* `Scheduler#wait_io`, `Scheduler#wait_fiber`
* `Fiber.schedule { ... }` (instead of just `Fiber { }` which confuses many about the semantics)
About raw... -
- Thanks @ko1, we will prepare an update taking into consideration your feedback and the ongoing discussions.
-
- Nobu and I reviewed spec and implementation.
There are several topics.
## [NEED TO CHANGE] doc/fiber.rdoc
The file name is `fiber`, but almost describe about the fiber scheduler.
Changing the file name into fiber_scheduler or des... -
-
- I fixed the licenses field in the default gems at https://github.com/ruby/ruby/commit/8fb02b7a97
-
-
-
-
-
-
- https://github.com/ruby/irb/commit/f4bcdf4375
-
- https://github.com/ruby/reline/commit/4a0d32a3d0
-
- https://github.com/ruby/reline/commit/9bd54b7f1c
-
10:09 AM Revision d1b06229 (git): [ruby/reline] Use the standard SPDX ID for license in gemspec
- It is better to use SPDX ID for license field:
https://guides.rubygems.org/specification-reference/#license=
ref: https://spdx.org/licenses/Ruby.html
https://github.com/ruby/reline/commit/8468a727e5 -
- Co-authored-by: Quentin Sabah <quentin.sabah@gmail.com>
https://github.com/ruby/reline/commit/5526e9f7ee -
- https://github.com/ruby/reline/commit/96583c6336
-
10:08 AM Revision 44b24ab4 (git): [ruby/reline] Support mode icon
- Co-authored-by: aycabta <aycabta@gmail.com>
https://github.com/ruby/reline/commit/067b618123 -
- because inputrc will be read when starting up
https://github.com/ruby/reline/commit/0a30464385 -
- https://github.com/ruby/reline/commit/3bf7c7d722
-
- https://github.com/ruby/reline/commit/8d7df88e98
-
- Catch Errno::EIO what will be occurred if the console terminates I/O before
Reline finishes rendering.
https://github.com/ruby/reline/commit/e51eaa6d43 - 10:03 AM Revision f0d3d4fe (git): [ruby/reline] Add home/end mapping for urxvt and relatives
- https://github.com/ruby/reline/commit/c30b293f1c
-
- Could the feature index track that both `.rb` and `.so` have been loaded and if so short-circuit the search?
It would still do a search every time if only the .so is loaded (like currently), but it seems features which only exist as `... -
03:06 AM Bug #15856: Performance of redundant `Kernel.require` is slow when many gems are activated
- Idempotency is a property of an operation within a system. `require` may be idempotent, its particular use is not. You mean redundant, not idempotent.
-
- https://github.com/ruby/irb/commit/f1a775af47
-
- https://github.com/ruby/irb/commit/8e3f81d428
-
- https://github.com/ruby/irb/commit/be2937abd5
-
- https://github.com/ruby/irb/commit/6dfd59400d
-
- https://github.com/ruby/irb/commit/933841af11
-
- https://github.com/ruby/irb/commit/3ea9fd9ed0
-
- https://github.com/ruby/irb/commit/420e7d2270
-
- https://github.com/ruby/irb/commit/0ac3bc7296
-
- https://github.com/ruby/irb/commit/9e4423b6e1
-
- https://github.com/ruby/irb/commit/824473e880
-
- https://github.com/ruby/irb/commit/5044eb2730
-
- https://github.com/ruby/irb/commit/82efd370eb
-
- https://github.com/ruby/irb/commit/71ba754e8e
-
- https://github.com/ruby/irb/commit/826ae909c9
-
- ```
/home/chkbuild/chkbuild/tmp/build/20200818T033004Z/ruby/test/fiber/test_backtrace.rb:9:
warning: ambiguous first argument; put parentheses or a space even after
`/' operator
/home/chkbuild/chkbuild/tmp/build/20200818T033004Z/ruby/tes...