Activity
From 07/09/2020 to 07/15/2020
07/15/2020
-
11:44 PM Bug #17023: How to prevent String memory to be relocated in ruby-ffi
- tenderlove@ruby-lang.org wrote:
> Right, that makes sense. I really need to document this (and
> I apologize for not doing so already), but
> `rb_gc_register_address` will pin your objects. When you know
> you're done with the ref... -
08:00 PM Bug #17023: How to prevent String memory to be relocated in ruby-ffi
- larskanis (Lars Kanis) wrote in #note-7:
> So actually I was looking for something like `rb_obj_mark_unmovable()` to pin the string. FFI could call this function on all string pointers passed to C. In FFI we don't know how long the stri... -
07:35 PM Bug #17023: How to prevent String memory to be relocated in ruby-ffi
- Thank you Aaron for looking into this! The patch avoids that the particular string is relocated, but unfortunately the patch is not sufficient to avoid relocation of any strings given to FFI. A slightly modified version of the script fai...
-
04:56 PM Feature #16987: Enumerator::Lazy vs Array methods
- I used Lazy all the time. There is nothing to be done here about its popularity.
FWIW, People knew about it, but choose not to rely on it because they want to support old versions of Ruby.
Hence, it is not very popular in open-source s... -
04:40 PM Bug #17017: Range#max & Range#minmax incorrectly use Float end as max
- jeremyevans0 (Jeremy Evans) wrote in #note-10:
> With current Ruby, you should use an endless range instead of range with an infinite end.
Endless ranges are 2.6+. Ruby 2.5 is not yet EOL. RuboCop supports 2.4 and other gems support ... -
03:58 PM Bug #17017: Range#max & Range#minmax incorrectly use Float end as max
- marcandre (Marc-Andre Lafortune) wrote in #note-9:
> jeremyevans0 (Jeremy Evans) wrote in #note-7:
> ...
With current Ruby, you should use an endless range instead of range with an infinite end.
The previous behavior of returning `F... -
- jeremyevans0 (Jeremy Evans) wrote in #note-7:
> koic (Koichi ITO) wrote in #note-6:
> ...
I should have been more clear when I commented to take care of Infinity, but I believe that previous behavior should remain. Since there is no `I... -
07:19 AM Bug #17017: Range#max & Range#minmax incorrectly use Float end as max
- Thank you for your reply. For now I've learned that updating to `(42.to_f..Float::INFINITY)` will prevent the error.
-
- koic (Koichi ITO) wrote in #note-6:
> I encountered a breaking change in RuboCop repository when using ruby 2.8.0dev.
> ...
Yes, it is expected behavior, at least to me. I believe the Ruby 2.7 behavior is wrong, because a range that s... -
- I encountered a breaking change in RuboCop repository when using ruby 2.8.0dev.
https://github.com/rubocop-hq/rubocop/blob/v0.88.0/lib/rubocop/comment_config.rb#L110
So, I have a question. Is this an expected behaviour?
Ruby 2.7.1... -
- Sure
```
Calculating -------------------------------------
short_backtrace 28.315k (± 7.1%) i/s - 141.984k in 5.044733s
long_backtrace 24.168k (± 8.7%) i/s - 120.900k in 5.050243s
no_caller_locations ... -
02:30 PM Bug #17031: `Kernel#caller_locations(m, n)` should be optimized
- Could you post the results of running that on your computer?
Then it's easier to see your point without needing to reproduce. -
02:33 PM Revision 9f4b7fc8 (git): Check warning flags only if available to run with old versions
-
- For the name I think just `scan` would be best then.
And accept the fact it's completely unrelated to `String#scan`. -
- Applied in changeset commit:git|579645d9f870fa4116dcd3200bbbb6e2c0b7f400.
----------
Fixed infinite loop at error in printing cause [Bug #17033] -
04:45 AM Bug #17033: Infinite Traceback when encountering an Exception while catching an Exception
- NickHackman (Nick Hackman) wrote:
> In Ruby 2.7.1 when an Exception occurs and another occurs when handling the first one it results in an infinite Traceback that doesn't mention the error.
> ...
If this is an actual issue is it possib... -
- In Ruby 2.7.1 when an Exception occurs and another occurs when handling the first one it results in an infinite Traceback that doesn't mention the error.
```ruby
class MyException < StandardError
def initialize(obj)
@obj = ob... -
-
-
07:05 AM Revision 5783d0db (git): Import remaining changes
- The "sync with commits" scripts failed to properly import these for some
reason. -
- This error happen in a CI run, and as it is currently, it doesn't give
any useful information about the underlying cause. Let's not swallow the
original error.
https://github.com/rubygems/rubygems/commit/8c17ba2f45 -
- https://github.com/rubygems/rubygems/commit/58d9a3de5b
-
07:05 AM Revision fd709382 (git): [rubygems/rubygems] Tag the specs with :readline
- The newly added specs needs to be tagged as
:readline, otherwise they fail on Windows with
the backtrace: `ZeroDivisionError: divided by 0`.
Such issues are already being skipped on Windows.
Signed-off-by: Utkarsh Gupta <utkarsh@debian... -
- Since this PR was made because we missed checking
RuboCop offenses with different flags, therefore
adding tests so that all flag combinations are
tested.
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
https://github.com/rubygems/rub... -
- https://github.com/rubygems/rubygems/commit/679008f23a
-
- The Gemfile wasn't properly put in the last commit.
As a result, Layout/EmptyLines inspected an offense
in the Gemfile.
This also fixes the spec w.r.t change in the task
default.
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
https... -
- If the blank lines aren't used, then rubocop tries to
sort them in alphabetical order within their section.
Thus, adding lines so rubocop considers them as
different sections and doesn't try to sort them.
Signed-off-by: Utkarsh Gupta <u... -
- In case of multiple Rake tasks, the default tasks would
look something like this:
`task default: [:spec, :rubocop]`
Instead, they should use %i and look something like this:
`task default: %i[spec rubocop]`
Signed-off-by: Utkarsh Gupta... -
- With #3731 and #3740 merged, this covers up the
remaining part of the issues.
This was discovered when one tries to create a gem
with a different framework.
Could be reproduced with:
`bundle gem foo --ext --test=test-unit`
Signed-off-by... -
07:05 AM Revision 40f73b3a (git): [rubygems/rubygems] Avoid calling LoadError#message because of its slowness
- Instead we can rely on `LoadError#path`
https://github.com/rubygems/rubygems/commit/16d5c3b43c -
- https://github.com/rubygems/rubygems/commit/27e0e4ecb6
-
- https://github.com/rubygems/rubygems/commit/cdc201f5c4
-
- Since our helpers now raise by default if the subcommand fails, these
will never actually fail and are not necessary.
https://github.com/rubygems/rubygems/commit/6153b9321e -
- Right now, we're not specifying the version constraints
on RuboCop that is shipped when a new gem is created.
This can break specs which runs rubocop on a new
skeleton gem as the newer versions of RuboCop are
released.
This commit ensur... -
- Everything is already fetched locally.
https://github.com/rubygems/rubygems/commit/9c304639b1 -
- https://github.com/rubygems/rubygems/commit/6e0c28d3ab
-
- It simplifies things and should avoid issues like the one we had where
the master branch had a bad `.gitattributes` file and changing it on a
PR would be disregarded.
In order for this to work, we need to make sure to fetch all tags fro... -
- ruby_core has an 'ast.rb' file that gets in the
middle and breaks this spec, so it's better we skip
this test on this workflow for now.
Also, slightly change the spec name from "run" to
"runs" and change the last assertion, it's cleaner... -
- With older versions of rubocop, the dependency on
`jaro_winkler` seems to be a pain.
However, in the later versions of rubocop, this
dependency was dropped. So we only need to use
the older version for ruby2.3.
Signed-off-by: Utkarsh Gu... -
- because rubocop configuration inheritance is
messed up and when using `--ignore-parent-exclusion`,
even though the exit status is 0, the example
still fails because of the configuration issue.
Signed-off-by: Utkarsh Gupta <utkarsh@debia... -
- The later RuboCop versions don't work with ruby2.3
so we should lock the version to what works with
ruby2.3 as we haven't dropped the support yet.
And since we're using the older version of rubocop,
also fix `Max` value of `LineLength` ... -
- Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
https://github.com/rubygems/rubygems/commit/83e330fa87 -
- With this, it will be ensured that the generated
(skeleton) gem will have no offenses.
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
https://github.com/rubygems/rubygems/commit/47411262e0 -
- Previously, we were using the old syntax like:
`task :default => :spec`, but now this commit
uses the new Ruby 1.9 hash syntax.
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
https://github.com/rubygems/rubygems/commit/b41d0fdb56 -
- Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
https://github.com/rubygems/rubygems/commit/730b770f8a -
- since without that, evaluating the gemspec from
outside `File.expand_path( __dir__)` won't work.
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
https://github.com/rubygems/rubygems/commit/9e5e52a1d9 -
- Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
https://github.com/rubygems/rubygems/commit/e2ee0b7de3 -
- These offenses appear when you create a gem with
`bundle gem foo` and run `rubocop` over it.
Initially, there were around 45 offenses detected,
but with #3731 and this, the number of offenses
have been reduced to 2.
Signed-off-by: Utka... -
- https://github.com/rubygems/rubygems/commit/1fe24e471d
-
- Since we don't show this output by default, it's better to be verbose
in case we happen to need more info.
https://github.com/rubygems/rubygems/commit/baa4ccf5a6 -
07:05 AM Revision 23cf99e9 (git): [rubygems/rubygems] Bundler specs - Windows - remove skips, File.open => File.readlines
- Using File.open without a block leaves a file reference that causes issues with file operations
commands/binstubs_spec.rb
install/gems/compact_index_spec.rb
install/gems/dependency_api_spec.rb
install/gems/standalone_spec.rb
runtime/exe... -
- Added one skip for:
bundle binstubs <gem>
when the gem exists in the lockfile
when generating bundle binstub outside bundler
should abort
https://github.com/rubygems/rubygems/commit/b77b484889 -
- Windows normal shell requires binstubs with *.cmd extensions
https://github.com/rubygems/rubygems/commit/b46326eb1f - 06:57 AM Revision 48ba9b61 (git): Update actions/cache from v1 to v2
- Signed-off-by: Sora Morimoto <sora@morimoto.io>
-
04:36 AM Revision c25d249e (git): RBasci::flags (VALUE) doesn't match int.
- The type of RBasic::flags is VALUE, and INT2FIX(flags) does not
make sense. Use correct type to represent. - 02:22 AM Revision dfe88350 (git): * 2020-07-15 [ci skip]
-
-
07/14/2020
-
07:56 PM Bug #17032 (Closed): BigDecimal's `to_d` behaves inconsistent compared to `to_f`
- I would expect `to_f` and `to_d` to behave identically. Specifically, `nil.to_d` should behave like `nil.to_f`.
```ruby
require 'bigdecimal'
require 'bigdecimal/util'
nil.to_f # => 0.0
nil.to_d # >> NoMethodError (undefined method... -
- `Kernel#caller_locations(1, 1)` currently appears to needlessly allocate memory for the whole backtrace.
It allocates ~20kB for a 800-deep stacktrace, vs 1.6 kB for a shallow backtrace.
It is also much slower for long stacktraces: ab... -
06:20 PM Feature #17016: Enumerable#accumulate
- Eregon (Benoit Daloze) wrote in #note-6:
> Maybe `prefix_sum` or just `prefix` or something like that would work?
> ...
I agree that including "sum" in the name is confusing. I think that "prefix_sum" is just used to describe the sum o... -
- shyouhei (Shyouhei Urabe) wrote in #note-10:
> It might be possible to let inject be lazy if we ignore backwards compatibility. But how do we partially evaluate that lazy enumerator then?
I think this is the crux of the issue. Becau... -
- nobu (Nobuyoshi Nakada) wrote in #note-4:
> Even without a block, `grep` sets `$~` to the last match result.
I agree with @eregon, doesn't seem like it makes much sense to use that.
There's also no valid reason it should set `$~` ... -
- nobu (Nobuyoshi Nakada) wrote in #note-4:
> Even without a block, `grep` sets `$~` to the last match result.
I guess cases using `$~` after the call to `grep` are very rare (notably because only the last match of the Enumerable would... -
- Even without a block, `grep` sets `$~` to the last match result.
-
- You are right for `grep` with a block, we can't necessarily optimize, but we should optimize `grep` without a block, no?
-
01:24 AM Bug #17030: Enumerable#grep{_v} should be optimized for Regexp
- Yes but E#grep's allocating MatchData is by spec. You can observe `$&` etc. by passing a block to it.
```ruby
p %w[q w e r].grep(/./) { $~ }
```
So this is at least a breaking change. -
- This is no longer used.
-
- Was my bad to assume sp_inc was positive. Real criteria is the
calculated sp is non-negative. We have to assert that. -
- OpenSSL 1.1.1d is out-of-date a little.
With which version of ruby did you build it?
07/13/2020
-
10:06 PM Bug #17027: Connection leak possibility in Net::FTP#transfercmd
- https://github.com/ruby/net-ftp/pull/2
-
- Your patch looks good to me. However, the net/ftp library is maintained in a separate repository. Please submit your patch as a pull request to https://github.com/ruby/net-ftp/pulls.
-
- Is this patch correct?
Should I close connection use `shutdown` and `read`?
```diff
--- /Users/koshigoe/.rbenv/versions/2.7.1/lib/ruby/2.7.0/net/ftp.rb.orig 2020-07-13 19:41:53.000000000 +0900
+++ /Users/koshigoe/.rbenv/versions/2.... -
- Fixed only about ACTIVE mode?
-
- Oops
https://bugs.ruby-lang.org/issues/9872 -
- https://github.com/ruby/ruby/blob/bad7ab35d1e38f47b09f15fc5750387ac73b2286/lib/net/ftp.rb#L542-L556
https://github.com/ruby/net-ftp/blob/14d2544190f7e4b77b41a3fd0c676f5b8ebd238c/lib/net/ftp.rb#L542-L556
The connection `conn` may not ... -
09:51 PM Feature #16984: Remove write barrier exemption for T_ICLASS
- Edit: I noticed that T_ICLASS wasn't marking the shared method and constant table on master. My notes
about reducing the number of `gc_mark` references on the heap were incorrect.
-
09:01 PM Bug #17029: URI.parse considers https://example.com/### invalid when browsers consider it valid
- It's not valid according to RFC 3986 (the URI standard) but that is pretty old now. I suspect switching from the IETF URI spec to the WHATWG URL spec would have other consequences, too.
-
- This does seem like a bug to me. It looks like `https://example.com/###` should be an valid URL with a fragment of `##`. However, the uri library is maintained in a separate repository. Please submit this as an issue to https://github...
-
05:33 PM Bug #17029 (Closed): URI.parse considers https://example.com/### invalid when browsers consider it valid
- I have a form with `<input type="url" required>` and in the backend, I try to extract the domain with `URI.parse(url).host`
A user was able to submit a value like `https://example.com/###` which passed the browser's validation check, ... -
- Code to reproduce by @fatkodima:
```ruby
require 'benchmark-ips'
require 'benchmark-memory'
arr = %w[foobar foobaz bazquux hello world just making this array longer]
REGEXP = /o/
def select_match(arr)
arr.select { |e| e.match?(REGE... -
- Currently,
```ruby
array.select { |e| e.match?(REGEXP) }
```
is about three times faster and six times more memory efficient than
```ruby
array.grep(REGEXP)
```
This is because `grep` calls `Regexp#===`, which creates use... -
- This is fixed in 6e7e7c1e577d6c2276e9a8cc85c28c55c46c2618. I tried cherry picking the commit to ruby_2_7, but got a conflict. I've attached the patch with the conflict resolved.
Thanks for reporting this! -
05:09 PM Bug #17017 (Closed): Range#max & Range#minmax incorrectly use Float end as max
- Applied in changeset commit:git|8900a25581822759daca528d46a75e0b743fc22e.
----------
Fix Range#{max,minmax} for range with integer beginning and non-integer end
Previously, for inclusive ranges, the max would show up as the
end of the ... -
- Previously, for inclusive ranges, the max would show up as the
end of the range, even though the end was not an integer and would
not be the maximum value. For exclusive ranges, max/minmax would
previously raise a TypeError, even though... - 05:07 PM Revision a1bcfbe3 (git): * 2020-07-14 [ci skip]
-
05:06 PM Revision 46d1777a (git): Remove --jit-min-calls for now
- --jit-min-calls=5 is too unstable
-
-
- I've submitted a pull request to the ipaddr repository for this: https://github.com/ruby/ipaddr/pull/24
-
01:06 PM Bug #17028 (Feedback): On the latest OpenSSL adaptation
- Can you file its details to http://github.com/ruby/openssl?
-
12:19 PM Bug #17028 (Closed): On the latest OpenSSL adaptation
- I just compiled ruby, but it failed to compile under OpenSSL 1.1.1d. Due to changes in ABI and detection macro, there were various errors. I even modified the following file to complete the compilation:
1. Note the full code of `opens... -
- [26c179d7e7e7] fixes SEGV at non-numeric argument to `ObjectSpace._id2ref`.
[26c179d7e7e7]: https://bugs.ruby-lang.org/projects/ruby-master/repository/git/revisions/26c179d7e7e7ae0eb21050659c3e8778358230ab -
- Applied in changeset commit:git|c2a6295ec04a191c689d22254ac1ad5d665e27ad.
----------
Make the mkmf methods private in the global [Bug #16896] -
-
- * RUN_OPTS needs to be specified for overriding it
* Add --jit-min-calls=5 -
04:28 AM Bug #17025 (Closed): `Time#ceil` does not work like `Rational#ceil` or `Float#ceil`
- ## Current behavior
```
irb(main):011:0> time = Time.utc(2016, 4, 23, 0, 0, "0.123456789".to_r)
irb(main):012:0> time.ceil(9)
=> 2016-04-23 00:00:00.12345679 UTC
irb(main):013:0> time.ceil(10)
=> 2016-04-23 00:00:00 1234567891/10... -
- * [Feature #13381] Expose rb_fstring and its family to C extensions (tenderlove)
* Can we expose the fstring family of functions? It seems the answer is "yes" but we need a better name (is this the current status?) -
-
- Stacks are emulated in MJIT, must not touch the original VM stack.
See also http://ci.rvm.jp/results/trunk-mjit-wait@silicon-docker/3061353 -
02:33 AM Revision 16bc9bf7 (git): [DOC] Use https:// instead of http:// [ci skip]
07/12/2020
-
- Instead of doubling the invokebuiltin logic here and there, use the same
insns.def definition for both MJIT/non-JIT situations. -
-
- This commit fixes compiler error on MSVC. %p on that platform is not
suitable to represent a compile-time constant.
https://ci.appveyor.com/project/ruby/ruby/builds/34017163/job/vj2a8uk3gwv9yxak#L24381 -
-
-
- We can obtain the verbatim source code of Primitive.cexpr!. Why not
paste that content into the JITed program. -
- Noticed that struct rb_builtin_function is a purely compile-time
constant. MJIT can eliminate some runtime calculations by statically
generate dedicated C code generator for each builtin functions. -
- It might be possible to let inject be lazy if we ignore backwards compatibility. But how do we partially evaluate that lazy enumerator then?
-
- nobu (Nobuyoshi Nakada) wrote in #note-8:
> It has a backward incompatibility on the return value.
> ...
Right, `inject` might return anything, not necessarily an Array and so returning a "lazy Enumerator" instead will be unwanted in a... -
- Eregon (Benoit Daloze) wrote in #note-7:
> nobu (Nobuyoshi Nakada) wrote in #note-5:
> ...
It has a backward incompatibility on the return value.
I’m afraid if it’s acceptable.
-
- Stack scanning should prevent `a` from moving, so you shouldn’t need to do anything to pin this. I will also try this against the master branch, and if it’s fixed there I’ll find the commit that fixed it. Regardless objects that are on...
-
- Right, it's used here: https://github.com/ruby/ruby/blob/5d02c1dd14648d95178ac5ec756f5b03fe00d549/ext/-test-/cxxanyargs/extconf.rb#L12
The PR sounds good then, thanks! -
- Eregon (Benoit Daloze) wrote in #note-8:
> I think `MakeMakefile.foo` usages are fine, so how about using `module_function`, so on `include` they are private, and when used on the singleton class (`MakeMakefile.foo`) they are public?
... -
- nobu (Nobuyoshi Nakada) wrote in #note-3:
> Why do you need to use mkmf outside extconf.rb?
Actually the issue above happened inside `extconf.rb`.
But `extconf.rb` might require anything, including `FFI`, so there can conflicts in `... -
- I think `MakeMakefile.foo` usages are fine, so how about using `module_function`, so on `include` they are private, and when used on the singleton class (`MakeMakefile.foo`) they are public?
-
- shyouhei (Shyouhei Urabe) wrote in #note-5:
> I'd be happy to rewrite cxxanyargs' extconf.rb if there is an alternative way without a receiver.
I don't think you have to rewrite it, it feels better way for the future.
https://github... -
- I'd be happy to rewrite cxxanyargs' extconf.rb if there is an alternative way without a receiver.
- 03:35 PM Revision 5d02c1dd (git): * 2020-07-13 [ci skip]
-
- * removed out-of-date and duplicate list
* stated that everything synced from github -
-
-
-
- Applied in changeset commit:git|99a9c3fe2eaab8157765d792dc871da6daea0327.
----------
Fixed yday and wday with timezone [Bug #17024] -
- https://github.com/ruby/ruby/pull/3312
-
- 08:30 AM Revision 90935ff2 (git): * 2020-07-12 [ci skip]
- 08:30 AM Revision 9b433d34 (git): bidecimal: improve tests' independence (#3297)
- Tests depending on the rounding mode must specify the appropriate rounding
mode and restore to the original mode at the end.
07/11/2020
-
- nobu (Nobuyoshi Nakada) wrote in #note-5:
> That sounds like `Enumerator::Lazy` needs `#inject` and `#each_with_object` methods to me.
A lazy `#inject` sounds useful. -
- parker (Parker Finch) wrote in #note-4:
Thanks for your reply, I think it will help to discuss this issue at the dev meeting.
Maybe `prefix_sum` or just `prefix` or something like that would work?
Having `sum` in it is kind of con... -
- parker (Parker Finch) wrote in #note-2:
> Good question! Using `#inject` or `#each_with_object` cannot be done lazily. We need to pass a lazy enumerator *after* applying the fold-like operation. As a toy example, instead of `[1, 2, 3]` w... -
01:01 PM Revision 3b96ad9b (git): Enhanced RDoc for Array#fill (#3301)
- * Enhanced RDoc for Array#fill
* Update array.c
There's one more at 5072. I'll get it.
Co-authored-by: Eric Hodel <drbrain@segment7.net>
* Update array.c
Co-authored-by: Eric Hodel <drbrain@segment7.net>
* Update array.c
Co-autho... -
12:40 PM Bug #17024: Times with timezones return incorrect wday and yday
- For example:
```
$ irb -r tzinfo
irb(main):001:0> Time.new(2020, 1, 1, 0, 0, 0, TZInfo::Timezone.get('America/New_York')).wday
=> 7
irb(main):002:0> Time.new(2020, 1, 1, 0, 0, 0, TZInfo::Timezone.get('America/New_York')).yday
=> 0
... -
- The timezone support added to Time in Ruby 2.6 does not appear to handle wday and yday.
I don't know what the most appropriate fix is, but looking at time.c and [the commit which introduced the timezone feature](https://github.com/rub... -
- As it doesn't seem to occur in the master but only in 2.7, I'll close this and set "Backport to 2.7" required, although I'm not sure if it is a bug.
Aaron, could you tell which commit fixed this? -
12:24 AM Bug #17023 (Assigned): How to prevent String memory to be relocated in ruby-ffi
-
- > IMHO, as Date.parse is too heuristic & magical for humans
I agree, what about ISO-8601? -
- Please file at https://github.com/ruby/date.
IMHO, as `Date.parse` is too heuristic & magical for humans, I don't think we should encourage using it. -
- I found that `ext/-test-/cxxanyargs/extconf.rb` calls `try_link` with a receiver.
-
- Why do you need to use mkmf outside extconf.rb?
-
07:23 AM Revision bad7ab35 (git): test/lib/jit_support.rb: Let JIT tests skip on centos8
- It has the same issue as RHEL 8. k0kubun said he will fix later
-
07:10 AM Revision b4c893a6 (git): OpenSSL 1.1.1 introduces a new '.include' directive. Update our config
- parser to support that.
As mentioned in the referenced GitHub issue, we should use the OpenSSL
API instead of implementing the parsing logic ourselves, but it will
need backwards-incompatible changes which we can't backport to stable
ve... -
-
- imemo_callcache and imemo_callinfo were not handled by the `objspace`
module and were showing up as "unknown" in the dump. Extract the code for
naming imemos and use that in both the GC and the `objspace` module.
07/10/2020
-
- Applied in changeset commit:git|021cec938af55a7ef368eadc99a6e3ff2252510e.
----------
Clarify behavior of super in method in module included in refinement [ci skip]
Fixes [Bug #16977] -
- Fixes [Bug #16977]
-
- After more analysis, I've determined that this issue is due to CREF handling in method lookup in `search_refined_method`. It fails in the lexical case because the module is affected by the refinement (refinement blocks have an implicit ...
-
- @chrisseaton Exactly, the string is considered `const char *` as mentioned here for the `:string` type: https://github.com/ffi/ffi/wiki/Types#user-content-types
-
07:51 PM Bug #17023: How to prevent String memory to be relocated in ruby-ffi
- > The user has to ensure on Ruby level that the string isn't GC'ed
The contract has always been more than that - the user must also not modify the string, as this may cause the character pointer to be reallocated. -
- [ruby-ffi](https://github.com/ffi/ffi) allows to pass String objects to C by using the `:string` argument type. This way the string memory returned by `RSTRING_PTR` is passed to the C function. The user has to ensure on Ruby level that t...
-
- > The name `scan` seems confusing at least, since it has nothing to do with `String#scan`.
> ...
Ah sorry, I forgot to mention that the term "scan" is what this operation is typically called in functional programming (see [here](https:/... -
- I agree with @eregon that making the above methods private would be desirable. However I searched on github for code examples of public methods of `MakeMakefile` and found at least these two:
* https://github.com/cloudavail/snippets/blo... -
- Applied in changeset commit:git|ddd9704ae9bf884d867b6f57a16c095a79393fff.
----------
Encode ' as ' when using encode(xml: :attr)
Fixes [Bug #16922] - 04:34 PM Revision c786954b (git): * 2020-07-11 [ci skip]
-
- Fixes [Bug #16922]
-
- I've added a pull request that fixes this issue: https://github.com/ruby/ruby/pull/3306
-
04:09 PM Feature #16739: Allow Hash#keys and Hash#values to accept a block for filtering output
- sawa (Tsuyoshi Sawada) wrote in #note-5:
> Includes a duplicate of #14788.
I just want to note that this is proposal is for a *more powerful* feature than what's proposed in #14788, because both the key and value would be available to t... -
- Dan0042 (Daniel DeLorme) wrote in #note-12:
> So has anyone considered silencing warnings when they originate from gems? I mean, the warning already includes that information:
> ...
This is simple to do with the warning gem:
```ruby... -
01:58 PM Feature #17000: 2.7.2 turns off deprecation warnings by default
- It seems to me the big issue is that developers have little power over warnings that come from gems. If the gem that produces warnings has not been patched yet, you have to wait for an update and suffer the warnings in the meantime.
S... -
-
08:16 AM Feature #16986: Anonymous Struct literal
- Maybe `{a = 1, b = "hello world"}`?
-
-
- which is checked by the first guard. When JIT-inlined cc and operand
cd->cc are different, the JIT-ed code might wrongly dispatch cd->cc even
while class check is done with another cc inlined by JIT.
This fixes SEGV on railsbench. -
-
-
-
- Ko1 doesn't like previous code.
-
- Struct assignment using a compound literal is more readable than before,
to me at least. It seems compilers reorder assignments anyways.
Neither speedup nor slowdown is observed on my machine. -
- Static assertions shall be done using STATIC_ASSERT these days.
-
- These assertions are purely static. Ned not be checked on-the-fly.
-
- Made it a bit readable.
-
- Surprised to see such a waste of time in this super duper hot path.
-
02:37 AM Feature #17022 (Third Party's Issue): Addition of method Kernel#Date
- What if we have a method `Kernel#Date` that delegates to `Date.parse`? Dates could be written in a more natural way, right?
```ruby
Date("2020-01-13") - Date("2019-01-13")
```
Capitalized methods are defined on the `Kernel` modul... -
- jaruga (Jun Aruga) wrote in #note-12:
> Is it possible to do backport the fixes to Ruby 2.7?
> ...
After releasing RG 3.1.5 contains the above patches, We will request to merge it to `ruby_2_7` branch.
07/09/2020
-
- backported into ruby_2_7 at 1ee1684a4a3edb26b5aa32acc967b9ef26284d42, 06ab2791c38c431e08bc8d9381c9a1ca727297c4, b971bad49b95d4c1f68bb2242d4267355f1cd497 and a0bb4eb04512b3f8ca50ec5fa72e3d4a8278ca46.
-
- I cannot find relevant commit with hash `8e694129305a3978313cf4bcd463c6aa2ba9ceb4`.
Maybe you meant `5c2508060b79b4299a18d05511d3530ad14b1b7a` and/or `2480ef904c66812cf366e5d9bc8a9c3c20bbf271` ? -
-
-
-
-
- I agree that this is a bug, and your pull request is a good way to fix it. I have squash merged your pull request. Thank you @pocke!
-
10:01 PM Bug #16982 (Closed): Define instance_methods and so on explicitly on classes generated by DelegateClass
- Applied in changeset commit:git|ba81bc24e62d03cc0f4c05cf4e2b378696631568.
----------
Add instance_methods to class generated by DelegateClass
Also, make DelegateClass.instance_method fallback to superclass.
Fixes [Bug #16982] -
- Also, make DelegateClass.instance_method fallback to superclass.
Fixes [Bug #16982] - 09:50 PM Revision 7a479b30 (git): * 2020-07-10 [ci skip]
-
- Applied in changeset commit:git|e1bbb9ea9ce205320267783960cfb2e9215d5f52.
----------
Document that Kernel#load will load relative to current directory [ci skip]
Update and format the Kernel#load documentation to separate the
three case... -
- TheSmartnik (Nikita Misharin) wrote in #note-2:
> nobu (Nobuyoshi Nakada) wrote in #note-1:
> ...
I don't think so. `load` has always been able to load files that exist relative to the current directory, and `require` has not. Techni... -
- Update and format the Kernel#load documentation to separate the
three cases (absolute path, explicit relative path, other), and
also document that it raises LoadError on failure.
Fixes [Bug #16988] -
09:47 PM Feature #16978: Ruby should not use realpath for __FILE__
- > this code would change behavior:
Absolutely, different `$LOAD_PATH` must result in different behavior.
> ...
This is actually where I am coming from. I am not 100 % sure what is the spec of `require`, but I would expect that `req... -
- The "main file" (the file passed to `ruby myfile.rb` is also special in that `__FILE__` and `$0` can both be relative paths (basically the same path as passed on the command line).
-
- I don't think this is a bug. `__FILE__` is documented as follows: `The path to the current file.` Which path (real, absolute, relative, expanded) is not specified.
Not using the real path would lead to behavior that depends on the f... -
- The name `scan` seems confusing at least, since it has nothing to do with `String#scan`.
And `*_left` has no precedent in Ruby.
It seems it's basically recording the history of each block call (+ the initial value), maybe a name expr... -
- * [Feature #17016] Enumerable#scan_left (parker)
* There is a [pull request](https://github.com/ruby/ruby/pull/3078) to implement `#scan_left`, i.e. the [scan](https://en.wikipedia.org/wiki/Prefix_sum#Scan_higher_order_function) opera... -
- * [Feature #17000] 2.7.2 turns off deprecation warnings by default (mame)
* It is already decided that we fix, but it has been discussed how to fix. (Nagachika-san will not attend the meeting, but I'd like to hear opinions from commit... -
- * [Feature #17004] Provide a way for methods to omit their return value (shyouhei)
* Is it a nice trick that we want to have, or a bad tool that is too easy to be abused? -
-
- Skip jit_test on some new RubyCI envs for now
Propagate JIT skip to all tests -
11:57 AM Bug #17021 (Closed): "arm64" and "arm" are mixed in RbConfig on Apple silicon
- When I checked the value of `RbConfig::CONFIG` on the Apple silicon macOS,e I found "arm64" and "arm" are mixed as following.
```
$ ruby -v
ruby 2.8.0dev (2020-07-09T09:14:53Z master addbb7d16e) [arm64-darwin20]
$ ruby -e 'requ... -
- disable to show the maximum number of threads.
On Deiban 9 environment, the thread tests failed and
this maximum threads information can finish up the machine
resources. To check it, I turned-off showing this inf... -
-
- As explained in the PR, I have no idea how to write a regression test, because as long as `ObjectSpace.trace_object_allocations_start` was called at least once in the program, it no longer fails afterwards. That is what led me to think i...
-
- A possible alternative might be an exception, I thought first, but it isn’t a single condition.
Could you add the test? -
- How difficult it is to just disable some warnings!
I think that byroot is right here. Unfortunately, the practice of `$VERBOSE=true` is not so popular, so it will make many libraries "too verbose". Many unrelated warnings will makes... - 04:56 AM Revision cb0404cc (git): * 2020-07-09 [ci skip]
-