Activity
From 05/21/2020 to 05/27/2020
05/27/2020
-
11:23 PM Feature #16848: Allow callables in $LOAD_PATH
- byroot (Jean Boussier) wrote in #note-21:
> I'm afraid that's a dead link.
I fixed the link on Redmine. -
05:00 PM Feature #16848: Allow callables in $LOAD_PATH
- > `$LOAD_PATH.unshift(dir) unless $LOAD_PATH.include?(dir)`
That specific case would degrade properly. Assuming the `include?` returns `false` because that path is now handled by Rubygems/Bundler, it simply mean you'll disable caching... -
04:16 PM Feature #16848: Allow callables in $LOAD_PATH
- > not sure what you mean by that. Like right now you can ` $LOAD_PATH.unshift(Object.new)` and it won't break `$LOAD_PATH.include?(path)`.
If you look in existing gems you'll find lots of stuff like `$LOAD_PATH.unshift(dir) unless $LOAD... -
11:05 PM Bug #16608: ConditionVariable#wait should return false when timeout exceeded
- I agree with @Eregon that we can probably change the return value of ConditionVariable#wait in Ruby 3. As it always returns true currently, it's worthless and nothing should be relying on it.
I can see that changing `Mutex#sleep` to ... -
10:13 PM Bug #16653 (Rejected): Weird behaviour of Resolv module
- I've looked into this more. The underlying cause is that Resolv expects nameservers to be specified as IP addresses, not as domain names. When using multiple nameservers, Resolv tries to match the IP address of the nameserver respondin...
-
09:19 PM Feature #15771: Add `String#split` option to set `split_type string` with a single space separator
- I think it's worth mentioning nobu's comment from the dev meeting:
> have wanted to deprecate that behavior for years, and made non-nil $/ warned.
So what about finally deprecating this behavior? If the incompatibility is too bad it'... -
01:34 PM Feature #15771: Add `String#split` option to set `split_type string` with a single space separator
- @sawa, for your "use-case", `line.split(/ /, 2)` is far better than `line.split(" ", 2, literal: true)`, I think, no matter what keyword we'd choose.
+ shorter
+ clearer
+ need to rewrite anyway
Matz.
-
04:59 AM Feature #15771: Add `String#split` option to set `split_type string` with a single space separator
- I have a particular use case. I was creating a file that describes UTF-8 characters, which included lines like this:
```
002 !"#$%&'()*+,-./
003 0123456789:;<=>?
004 @ABCDEFGHIJKLMNO
```
The first three characters of each line descri... -
04:52 AM Feature #15771: Add `String#split` option to set `split_type string` with a single space separator
- Dan0042 (Daniel DeLorme) wrote in #note-10:
> That optimization is nice to have, but I think the point of this ticket is that it's currently not possible to have an arbitrary string separator.
I agree.
Dan0042 (Daniel DeLorme) wrote in... -
08:43 PM Bug #16841 (Feedback): Some syntax errors are thrown from compile.c
- This doesn't seem to be a bug, it is by design. Trying to move all syntax errors into the parser is probably too difficult to justify the effort even if it is possible.
If you want to more fully check for valid syntax without having ... -
08:16 PM Misc #16916 (Closed): [Documentation] Method: Net::HTTPHeader#set_form
- Applied in changeset commit:git|fa380208fe4ef36cd6a8535d3ac43e61c7935f1c.
----------
Improve documentation for Net::HTTPHeader#set_form [ci skip]
Fixes [Misc #16916] -
08:13 PM Revision fa380208 (git): Improve documentation for Net::HTTPHeader#set_form [ci skip]
- Fixes [Misc #16916]
-
07:07 PM Feature #16828: Introduce find patterns
- From the implementation linked above:
```ruby
case [0, 1, 2]
in [*, a, *]
p a #=> 0; non-greedy match
end
case [0, 1, 2]
in [*, b, 2, *]
p b #=> 1; backtracking
end
```
So yes, it supports "backtracking" in a certai... -
12:09 AM Feature #16828: Introduce find patterns
- Accepted. But we have to clarify the term "backtracking" here. It does backtrack but not with a guard, right?
Matz.
-
12:07 AM Feature #16828: Introduce find patterns
- Suppose we have the following code:
```
json = {name: "Alice", children: [{name: "Bob", age: 6}, {name: "Chad", age: 4}]}
case json
in {name: "Alice", children: [{name: "Bob", age: age}]}
p age
end
```
It doesn't match because ... -
06:08 PM Bug #16695: Stack consistency error when using the return value
- Through trial and error, I've determined this is caused by the branchif/branchnil/branchunless optimization, self described as a super nasty hack. I've submitted a pull request to disable this optimization (https://github.com/ruby/ruby/...
-
05:20 PM Feature #12901: Anonymous functions without scope lookup overhead
- Can we visit this again which if we go with 1:) add a new construct we could solve https://bugs.ruby-lang.org/issues/11630 - serializing functions
also, if we add new constructs we can add a multi-method version - https://bugs.ruby-lang... - 03:15 PM Revision 9cfef5b4 (git): * 2020-05-28 [ci skip]
-
03:13 PM Revision 93ccb8e8 (git): Remove platform directory when distclean or more [ci skip]
- At the time of clean-platform, platform directory may not be empty
because of parallel build. -
02:46 PM Revision 6dbc3a28 (git): autoconf may not be available
-
02:31 PM Revision 139839b8 (git): [ci skip] Enhanced Rdoc for Hash (#3143)
- * Enhanced Rdoc for Hash
* Respond to review
* Nudge CI testing.
Respond to review -
02:12 PM Feature #16847 (Closed): Cache instruction sequences by default
-
10:39 AM Feature #16847: Cache instruction sequences by default
- > We'd rather improve Bootsnap if they need support from the core.
Ok. Then we can close this issue.
That part of Bootsnap doesn't need any support from core, it works fine except for what I explained, it takes the blame for many i... -
12:12 AM Feature #16847: Cache instruction sequences by default
- I am negative. Cacheing compiled binary caused a lot of problems in Python, especially with multiple versions installed. We'd rather improve Bootsnap if they need support from the core.
Matz.
-
08:41 AM Revision 083a17a8 (git): Carve out mjit_exec_slowpath
- and mark it as COLDFUN on JIT, assuming enqueue usually happens on VM.
-
06:48 AM Revision a3f498e4 (git): Fix max, min, minmax documentation (#3131)
- They only need that all objects implement <=>,
but the documentation said it needs Comparable. -
06:46 AM Revision 752041ca (git): Update Enumerable::Yielder#to_proc document (#3142)
-
06:37 AM Revision 64c5bf57 (git): Fix non-existent method reference in Enumerator.produce document (#3141)
-
06:24 AM Revision 9d71373c (git): Mark vm_stackoverflow as NOINLINE COLDFUNC on JIT
- to reduce code size and improve locality of hot code.
-
06:01 AM Revision 61b14bb3 (git): Eliminate a call instruction on JIT cancel path
- by calling combined functions specialized for each cancel type.
I'm hoping to improve locality of hot code, but this patch's impact should
be insignificant. -
05:30 AM Revision 4cabd77e (git): Removed a trailing space [ci skip]
-
04:13 AM Revision 0f8b5819 (git): Merged recipes for the same target
-
03:40 AM Revision 51fa4c9f (git): Removed obsolete forwarding DLL recipe
- It has never been created by default, and no reason to keep binary
compatibility against extension libraries for ruby 1.8.
1. `LIBRUBY_SO` on Cygwin was named originally.
- 94089e82a12:: `$(RUBY_INSTALL_NAME)-cygwin.dll`
- f0ba57... -
02:26 AM Revision 0fcb2dd5 (git): add static modifier for rb_str_ord func
05/26/2020
-
11:56 PM Feature #15771 (Feedback): Add `String#split` option to set `split_type string` with a single space separator
- I get the point, but we still need a concrete use-case. (Unlike tabs and commas) Space-separated CSV is not common, and consequent spaces are considered as one space usually. I still feel like it's a theoretical concern.
Besides that,... -
10:48 PM Bug #16823 (Closed): Bundler related manual pages are corrupted
- Applied in changeset commit:git|e0b40ef5d8173aff304c81f93516e1246e3c042c.
----------
Don't convert bundler man pages from mdoc to man
These man pages are already in man format and assuming they are
mdoc format breaks things.
Fixes [Bu... -
09:06 PM Bug #16823: Bundler related manual pages are corrupted
- I've confirmed this bug and submitted a pull request to fix it: https://github.com/ruby/ruby/pull/3147
-
10:47 PM Revision e0b40ef5 (git): Don't convert bundler man pages from mdoc to man
- These man pages are already in man format and assuming they are
mdoc format breaks things.
Fixes [Bug #16823] -
10:37 PM Bug #16695: Stack consistency error when using the return value
- This is due to a bug in the optimizer. Adding `return COMPILE_OK;` to the top of `iseq_peephole_optimize` fixes the problem.
Instructions before (optimization/broken):
```
== disasm: #<ISeq:<main>@-e:1 (1,0)-(1,52)> (catch: FALSE... -
10:35 PM Misc #16916 (Closed): [Documentation] Method: Net::HTTPHeader#set_form
- Since this revision / commit
- SVN Revision 65230
- https://bugs.ruby-lang.org/projects/ruby-master/repository/ruby_2_6/revisions/65230
- https://svn.ruby-lang.org/cgi-bin/viewvc.cgi/trunk/lib/net/http.rb?view=log&pathrev=65... -
10:03 PM Bug #16753 (Closed): ruby -run -e httpd . -p 8080 , not support CJK directorys .
- I merged this patch upstream: https://github.com/ruby/webrick/pull/42
-
09:54 PM Bug #16696 (Closed): 'OpenSSL 1.1.1e 17 Mar 2020' causes failure in Ruby OpenSSL stdlib
-
09:20 PM Bug #16777 (Closed): IRB in Ruby 2.7 hangs on pasting long here document
-
08:18 PM Bug #16771 (Closed): Segmentation fault when inspecting a bound method
-
08:02 PM Bug #16765 (Closed): Crash when use sass image-url in email layout
-
05:07 PM Revision 962c302a (git): test/drb/test_drbssl.rb: skip LeakChecker as openssl keeps /dev/random
- and /dev/urandom intentionally. OpenSSL::PKey::RSA.new opens the two
random generators and keeps the file descriptors.
https://github.com/openssl/openssl/blob/93f99b681ab5a1cf7062053323e09b0cad5ff854/crypto/rand/rand_unix.c#L674
They ... -
03:30 PM Revision 135c6a4b (git): fiddle: need to update configure after updating config tools
- 03:28 PM Revision f8e703e2 (git): * 2020-05-27 [ci skip]
-
03:20 PM Revision 5429deb0 (git): lib/open3.rb: make sure that pipes are closed
- Attempting to invoke a non-existent command led to the leak of fds.
http://rubyci.s3.amazonaws.com/graviton2/ruby-master/log/20200526T140004Z.log.html.gz
```
[ 9101/20195] TestGemExtCmakeBuilder#test_self_build = 0.01 sLeaked file descr... -
02:30 PM Feature #16848: Allow callables in $LOAD_PATH
- > the "vast majority of the cases" involve something like $LOAD_PATH.include?(path) and string duck-typing doesn't help with that.
@Dan0042 not sure what you mean by that. Like right now you can ` $LOAD_PATH.unshift(Object.new)` and ... -
02:01 PM Feature #16848: Allow callables in $LOAD_PATH
- > $LOAD_PATH as a "view"
This is what I proposed at comment #16.
Maybe there are two strategies:
(1) extend $LOAD_PATH.
(2) introduce $LOAD_PATH2 and deprecate $LOAD_PATH.
(3) other great idea?
Several years ago I tried this topic wh... -
01:12 PM Feature #16848: Allow callables in $LOAD_PATH
- > ### String duck-typing
It seems to me that apart from adding a path to $LOAD_PATH (which is a non-issue), the "vast majority of the cases" involve something like `$LOAD_PATH.include?(path)` and string duck-typing doesn't help with t... -
09:55 AM Feature #16848: Allow callables in $LOAD_PATH
- Sorry I missed your answer from 5 days ago. I wish I'd answered before your second meeting (Redmine no longer send notifications...).
> Could you propose another proposal to care compatibility?
To be honest I kinda expected this co... -
07:58 AM Feature #16848 (Feedback): Allow callables in $LOAD_PATH
- As I described, the current approach has a compatibility issue.
Could you propose another proposal to care compatibility?
In discussion at devmeeting, there is possibility to introduce a feature to help `$LOAD_PATH` observing which b... -
02:23 PM Feature #8661: Add option to print backtrace in reverse order (stack frames first and error last)
- Don't mind, I was not clear.
-
11:29 AM Feature #8661: Add option to print backtrace in reverse order (stack frames first and error last)
- mame (Yusuke Endoh) wrote in #note-43:
> The order had been already reverted in #note-31.
Ah, thx and sorry to miss that :blush: -
10:57 AM Feature #8661: Add option to print backtrace in reverse order (stack frames first and error last)
- The order had been already reverted in #note-31.
-
07:08 AM Feature #8661: Add option to print backtrace in reverse order (stack frames first and error last)
- Have the commit changed the order or introduced just the option? It seems to that just the later, which is not what was agreed in #note-27
-
04:28 AM Feature #8661 (Closed): Add option to print backtrace in reverse order (stack frames first and error last)
- Committed at 39365b46e250162f278cb36aa148bc2a92b1b84a. Thanks!
-
02:20 PM Revision eb20d2f4 (git): include debug option in slack notification
-
02:10 PM Revision a809caa4 (git): remove duplication.
-
02:04 PM Revision 68e987c3 (git): GH actions with RUBY_DEBUG (#3144)
- Add GH actions with -DRUBY_DEBUG
-
01:58 PM Bug #16914 (Closed): Hash.new with `default_proc` returns this `default_proc` instead of calling it sometimes
-
09:45 AM Bug #16914 (Closed): Hash.new with `default_proc` returns this `default_proc` instead of calling it sometimes
- Hello,
First of all, I want to apologize because this bug report will not be realized at all in good shape. I encounter this problem on a rails application currently in production, but I am unable to reproduce it. I failed to provide ... -
10:17 AM Revision 5917fe23 (git): _GNU_SOURCE is needed for mkostemp on Cygwin
-
07:58 AM Revision 17d17de0 (git): Get rid of redefinition of memcpy on mingw
-
07:58 AM Revision 04eb05a8 (git): Prefer configured printf format for mingw gcc 10
-
06:14 AM Revision d63bba1e (git): [DOC] Use note-list to pretend original plain-text looks [ci skip]
-
06:09 AM Feature #16832 (Closed): Use #name rather than #inspect to build "uninitialized constant" error messages
- Applied in changeset commit:git|7d5da30c9e9c572f6ef0aaccc1ca0e724966e2ee.
----------
Test for [Feature #16832] -
06:09 AM Revision 7d5da30c (git): Test for [Feature #16832]
-
05:10 AM Revision 385ac07f (git): Use receiver #name rather than #inspect to build NameError message
-
04:38 AM Bug #16906 (Closed): Calling Thread#thread_variable? in IRB sometimes produce wrong result
- Applied in changeset commit:git|4e1f2283b432e833bd4e6f7724ba0496760e68e8.
----------
Make Thread#thread_variable? similar to #thread_variable_get
Don't use rb_check_id, which only works for pinned symbols.
Switch inadvertent creation t... -
02:57 AM Bug #16906: Calling Thread#thread_variable? in IRB sometimes produce wrong result
- That approach didn't work as there are tests for inadvertent symbol creation. To fix that, we need to force ID creation in thread_local_set. I've updated the pull request to use that approach, and made thread_variable_get use the same i...
-
02:34 AM Bug #16906: Calling Thread#thread_variable? in IRB sometimes produce wrong result
- I can confirm this bug. It's because `thread_variable?` uses different code than `thread_variable_get` and `thread_variable_set`. Removing the `rb_check_id` and switching `ID2SYM` to `rb_to_symbol` fixes it. I've added a pull request ...
-
04:38 AM Revision 4e1f2283 (git): Make Thread#thread_variable? similar to #thread_variable_get
- Don't use rb_check_id, which only works for pinned symbols.
Switch inadvertent creation test for thread_variable? to
only check for pinned symbols, same as thread_variable_get
and thread_variable_set.
Make key variable name in thread_lo... -
02:59 AM Feature #16824: Follow RubyGems naming conventions for the stdlib
- nobu (Nobuyoshi Nakada) wrote in #note-13:
> Nonsense.
Nobu, I feel deeply offended by your impoliteness and lack of respect.
yuki24 (Yuki Nishijima) wrote in #note-14:
> ...
This is great, well done! -
02:20 AM Feature #16824: Follow RubyGems naming conventions for the stdlib
- While I understand the intention of this request, I'm not sure this would be practically useful for us. As mentioned above, there are definitely gem names that people are already too familiar with, that we probably don't want to rename, ...
-
02:03 AM Feature #16824 (Rejected): Follow RubyGems naming conventions for the stdlib
- Nonsense.
-
01:49 AM Feature #16824 (Open): Follow RubyGems naming conventions for the stdlib
- Let's not close this because the original request is not be accepted at 100%
Any volunteer to double-check the list and figure out which gem names are available and which could possibly be reclaimed?
I can help to register the name... -
02:47 AM Bug #16912 (Closed): Fiber#raise has a mismatch between implementation and documentation
- Applied in changeset commit:git|faab5cbeb762adec4983d603d71e72add5108249.
----------
Fix documentation for Fiber#raise [ci skip]
Fixes [Bug #16912] -
02:46 AM Revision faab5cbe (git): Fix documentation for Fiber#raise [ci skip]
- Fixes [Bug #16912]
05/25/2020
-
11:33 PM Feature #16913 (Open): Add `ARGF#each_io`
- Add an iterator for each file supplied on the command line, or STDIN. `ARGF#each_io`
## Current Status
Often, we need to do something with individual files ARGF knows about rather than the concatenation of them. We can combine `ARG... -
07:49 PM Revision c9fe4ebd (git): cause SEGV for the test.
- 21991e6ca5 enables `__builtin_assume()` for clang and it seems
skip SEGV on rb_class_of() with unexpected value. This test expects
a [BUG] output, so this patch causes [BUG] to show [BUG] message.
https://github.com/ruby/ruby/runs/70708... -
06:21 PM Feature #16837 (Closed): Can we make Ruby 3.0 as fast as Ruby 2.7 with the new assertions?
- Applied in changeset commit:git|21991e6ca59274e41a472b5256bd3245f6596c90.
----------
Use RUBY_DEBUG instead of NDEBUG
Assertions in header files slows down an interpreter, so they should be
turned off by default (simple `make`). To ena... - 06:21 PM Revision 7bafc9f4 (git): * 2020-05-26 [ci skip]
-
06:21 PM Revision 4ac42874 (git): Update include/ruby/assert.h
- Co-authored-by: 卜部昌平 <shyouhei@ruby-lang.org>
-
06:21 PM Revision 21991e6c (git): Use RUBY_DEBUG instead of NDEBUG
- Assertions in header files slows down an interpreter, so they should be
turned off by default (simple `make`). To enable them, define a macro
`RUBY_DEBUG=1` (e.g. `make cppflags=-DRUBY_DEBUG` or use `#define` at
the very beggining of the... -
03:33 PM Bug #16912 (Closed): Fiber#raise has a mismatch between implementation and documentation
- Fiber#raise has a mismatch between implementation and documentation for "created" fiber.
RDoc:
> Raises an exception in the fiber at the point at which the last Fiber.yield was called, or at the start if neither resume nor rais... -
12:01 PM Misc #16911 (Closed): Travis: unstable non-x86_64 jobs
- I would like to open this ticket to track and fix the issues for Travis non-x86_64 jobs, as I saw the following commits now.
Travis s390x-linux is too unstable
https://github.com/ruby/ruby/commit/f72bec2cea313f7a72a6f907f3dd64f766e91... -
11:12 AM Revision b10b3792 (git): Fix failures in ./spec/bundler/quality_spec.rb
- ```
Failures:
1) The library itself does not contain any warnings
Failure/Error: raise "Invoking #{method}!(#{args.map(&:inspect).join(", ")}) failed:\n#{last_command.stdboth}"
RuntimeError:
Invoking sys_exec!("ruby ... -
11:08 AM Revision fcc8be01 (git): Fix a failure in bundle version with version outputs the version with build metadata
- ```
1) bundle version with version outputs the version with build metadata
Failure/Error: expect(out).to match(/\ABundler version #{Regexp.escape(Bundler::VERSION)} \(\d{4}-\d{2}-\d{2} commit #{COMMIT_HASH}\)\z/)
expected ... -
11:08 AM Revision 67d2a715 (git): Fix a error in a `before(:suite)` hook
- https://github.com/ruby/actions/runs/703745101?check_suite_focus=true#step:16:27
```
An error occurred in a `before(:suite)` hook.
Failure/Error: contents = File.read(version_file)
Errno::ENOENT:
No such file or directory @ rb_sysopen... -
06:20 AM Revision 45ffab36 (git): Added entries about RubyGems and Bundler
-
02:09 AM Misc #16805: Coroutine's license is unclear
- @odaira Can you confirm/are you okay for your ppcle64 implementation to be released under the MIT License?
-
02:08 AM Bug #16814: Segmentation fault in GC while running test/ruby/test_fiber.rb on s390x
- Can you check if this is still a problem, I merged my changes which should make this test more reliable. But I did not fix any underlying problems.
-
02:02 AM Revision 2225aa98 (git): [DOC] Turned note-lists into label-lists [ci skip]
- 01:19 AM Revision 089dcfbf (git): * 2020-05-25 [ci skip]
-
01:17 AM Revision 06321ea2 (git): RBIMPL_ATTR_DEPRECATED: disable for GCC10
- GCC 10.x seems buggy here. See also https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95302
-
01:09 AM Feature #15277: at_exec
- I would like to add a use-case that I'm encountering right now.
I would like to call prctl(PR_SET_PDEATHSIG, ...) in order to ensure that a spawned process is always killed regardless of how cleanly the parent process exits. I couldn'...
05/24/2020
-
05:24 PM Bug #16904: rubygems: psych: superclass mismatch for class Mark (TypeError)
- There was merged this [1] PR, which should resolve the issue even without removal of the `gem` call. I have not verified it myself, but the test case was modeled after my test case in comment #note-10, so I am positive about its function...
-
04:34 PM Misc #16910: BasicObject is resolved in BasicObject
- Ah! I read too fast too :). Appreciate the followup!
-
02:52 PM Misc #16910: BasicObject is resolved in BasicObject
- Actually I looked too fast, the correct location is
https://github.com/ruby/ruby/blob/b10c9d201222b144df7d63660d1c731af53c4ae2/class.c#L551-L559
So it's defined as a constant of itself (BasicObject) and not Object because Object is n... -
02:45 PM Misc #16910 (Closed): BasicObject is resolved in BasicObject
-
12:39 PM Misc #16910: BasicObject is resolved in BasicObject
- This can be closed (can't do it myself apparently).
-
12:37 PM Misc #16910: BasicObject is resolved in BasicObject
- Ahhh, that explains it. That code says this is intentional and definitely not a bug.
Thanks a lot Benoit!
-
10:19 AM Misc #16910: BasicObject is resolved in BasicObject
- As you found, I think it's just a special case that BasicObject has a constant named "BasicObject".
It's defined here in CRuby:
https://github.com/ruby/ruby/blob/b10c9d201222b144df7d63660d1c731af53c4ae2/class.c#L569
And here in TruffleR... -
09:41 AM Misc #16910: BasicObject is resolved in BasicObject
- Ah, forgot to add that I saw this
```ruby
BasicObject.constants # => [:BasicObject]
```
Could it be the case that `BasicObject` is special-cased somehow? If so, where in the source code? -
09:39 AM Misc #16910 (Closed): BasicObject is resolved in BasicObject
- I categorized this as Misc because I do not really know if this is a bug, or perhaps I miss some special rule in the resolution of relative constants.
Basically, I would expect
```ruby
class C < BasicObject
BasicObject
end
``... -
02:47 PM Revision c6c02331 (git): [ruby/rdoc] Check uninitialized instance variable in test
- https://github.com/ruby/rdoc/commit/3dcd5ddbb6
-
02:47 PM Revision 3169ffc0 (git): [ruby/rdoc] Add frozen string literal support
- https://github.com/ruby/rdoc/commit/daac9d0471
-
02:47 PM Revision 37b8a7af (git): [ruby/rdoc] Add instance_methods because instance_method_list should be obsolete
- https://github.com/ruby/rdoc/commit/9b1da32254
-
02:47 PM Revision e6d1363a (git): [ruby/rdoc] Fixed inverted CSS for note-list and label-list
- https://github.com/ruby/rdoc/commit/a13d6439da
-
02:47 PM Revision 32e0ff26 (git): [ruby/rdoc] Delegate ERB args correctly
- https://github.com/ruby/rdoc/commit/82ff37a822
-
02:47 PM Revision 7e7981c8 (git): [ruby/rdoc] Treat multiple Ruby methods calling the same C method as aliases
- Previously, only calls to rb_define_alias were treated as aliases.
This treats calls to rb_define_method with the same C function as
aliases, with the first function defined being the primary method.
This move the dedup code from the C ... -
02:47 PM Revision f52a4690 (git): [ruby/rdoc] Process crossref before tidylink
- The crossref must be linked before tidylink because Klass.method[:sym] will be
processed as a tidylink first and will be broken.
https://github.com/ruby/rdoc/commit/0f47baf6d2 - 02:47 PM Revision c79f9ea6 (git): [ruby/rdoc] Escape method names in HTML
- The following is invalid HTML:
<a href="Array.html#method-i-3C-3C"> -
10:34 AM Bug #11188: Method#inspect for chaining alias methods
- Nice, in fact this was already the behavior in TruffleRuby and JRuby.
-
03:39 AM Bug #11188 (Closed): Method#inspect for chaining alias methods
- This patch was merged in commit:adecd43197d5ea2a62a618a5c9be653bcf009c62.
-
09:05 AM Feature #16650 (Closed): Ruby 2.6.* and 2.7* no longer compile on latest Mingw64
- It seems working now, by compiling with gcc 10.1.0.
-
08:08 AM Bug #16905: Ruby required to build Ruby on Haiku?
- > parse.y file has been modified, or its timestamp changed at least.
I didn't edited that file and haven't changed the timestamp, so while your idea makes sense, i don't trust this error message at all, as this is from make, not from ... -
03:33 AM Bug #16852: Refining Enumerable fails with ruby 2.7
- I've added https://github.com/ruby/ruby/pull/3140 to fix this. It works by ensuring an origin for Enumerable directly after it is created. It does the same for Comparable and Kernel, since I think the issue could affect them.
-
01:53 AM Revision b10c9d20 (git): [DOC] Added document for rb_check_symbol() [ci skip]
-
01:35 AM Revision 8b8b7c78 (git): Enhanced Rdoc for Hash (#3139)
-
12:53 AM Bug #16908: Strange behaviour of Hash#shift when used with `default_proc`.
- I would expect Hash#shift to return either a key-value tuple or nil. Returning the default value is, honestly, incomprehensible.
05/23/2020
- 07:01 PM Revision 0b161774 (git): * 2020-05-24 [ci skip]
-
07:01 PM Revision f27e0d90 (git): ext/fiddle/fiddle.gemspec: avoid require lib/fiddle/version.rb
- It loads `ext/fiddle/lib/fiddle/version.rb`, which causes constant
redefinition warning:
http://rubyci.s3.amazonaws.com/ubuntu2004/ruby-master/log/20200523T153003Z.log.html.gz
```
[ 6317/20193] TestDefaultGems#test_validate_gemspec/home... -
02:16 PM Bug #16787 (Closed): [patch] allow Dir.home to work for non-login procs when $HOME not set
- Applied in changeset commit:git|c15cddd1d515c5bd8dfe8fb2725e3f723aec63b8.
----------
Allow Dir.home to work for non-login procs when $HOME not set
Allow the 'Dir.home' method to reliably locate the user's home directory when
all three ... -
02:16 PM Revision c15cddd1 (git): Allow Dir.home to work for non-login procs when $HOME not set
- Allow the 'Dir.home' method to reliably locate the user's home directory when
all three of the following are true at the same time:
1. Ruby is running on a Unix-like OS
2. The $HOME environment variable is not set
3. The pro... -
01:04 PM Revision 39cb1930 (git): Search pkg-config with ac_tool_prefix [Bug #16909]
- Should prefer a prefixed version over the bare pkg-config for
cross compiling. -
12:39 PM Bug #16908: Strange behaviour of Hash#shift when used with `default_proc`.
- In other words, the current semantics of `return hash.default(nil) if hash.empty?` feel hacky and actually harmful to me.
The user probably never expects to have the default_proc called with a `nil` key in many cases. -
12:37 PM Bug #16908: Strange behaviour of Hash#shift when used with `default_proc`.
- Maybe `Hash#shift` should not call the `default_proc` or use `Hash#default`?
I.e., it would always return `nil` if `Hash#empty?`.
I think that would be more intuitive and probably compatible enough. -
02:53 AM Bug #16908: Strange behaviour of Hash#shift when used with `default_proc`.
- ioquatix (Samuel Williams) wrote in #note-2:
> @jeremyevans0 I agree with your assessment, however that hash does not have default_proc so I assume that it would return `nil` after all key-value pairs are `shift`ed out. That's different... -
02:38 AM Bug #16908: Strange behaviour of Hash#shift when used with `default_proc`.
- @jeremyevans0 I agree with your assessment, however that hash does not have default_proc so I assume that it would return `nil` after all key-value pairs are `shift`ed out. That's different from invoking `default_proc` and returning `[ni...
-
02:26 AM Bug #16908: Strange behaviour of Hash#shift when used with `default_proc`.
- While your particular example is non-intuitive, there is a simple explanation for it. The first time `hash.shift` is called, `hash` is empty, so it returns the default value (`0`). It gets the default value by calling the default_proc f...
-
02:15 AM Bug #16908 (Closed): Strange behaviour of Hash#shift when used with `default_proc`.
- I don't have any strong opinion about this, but I observed the following behaviour which I thought was confusing. Maybe it's okay, or maybe we should change it to be more consistent.
```
hash = Hash.new{|k,v| k[v] = 0}
hash.shift ... -
12:20 PM Revision b722182e (git): Revert "Search pkg-config by AC_CHECK_TOOL [Bug #16909]"
- This reverts commit 6006ab8cf93a0e06d9d65213eff3117965c9bd0c.
AC_CHECK_TOOL does not have REJECT argument. -
11:58 AM Bug #16909 (Closed): pkg-config search should use AC_CHECK_TOOL instead of AC_CHECK_PROG
- Applied in changeset commit:git|6006ab8cf93a0e06d9d65213eff3117965c9bd0c.
----------
Search pkg-config by AC_CHECK_TOOL [Bug #16909]
It should use AC_CHECK_TOOL to automatically search for a prefixed
version and not just the bare pkg-c... -
04:28 AM Bug #16909 (Closed): pkg-config search should use AC_CHECK_TOOL instead of AC_CHECK_PROG
- pkg-config is a toolchain variable akin to the compiler/linker/etc... it should use AC_CHECK_TOOL to automatically search for a prefixed version and not just the bare pkg-config.
-
10:52 AM Revision 6006ab8c (git): Search pkg-config by AC_CHECK_TOOL [Bug #16909]
- It should use AC_CHECK_TOOL to automatically search for a prefixed
version and not just the bare pkg-config. -
08:24 AM Revision b2976a4f (git): Fixup d48c92aa04ffd3a1cecef599eaa5e4409aab2fe4
-
07:44 AM Revision d48c92aa (git): Rename TestScheduler* to TestFiber for convention of the test directory
-
05:56 AM Revision 0b2fc4cf (git): extlibs.rb: make symlink only if the target exists
-
05:34 AM Revision 3015a7aa (git): [ruby/fiddle] Improve documentation on how to correctly free memory and free memory in tests (#33)
- https://github.com/ruby/fiddle/commit/e59cfd708a
- 05:29 AM Revision 24b615e8 (git): [ruby/fiddle] Export Fiddle::VERSION
- https://github.com/ruby/fiddle/commit/1b93a2d9db
- 05:29 AM Revision 74a4558c (git): [ruby/fiddle] Update file list
- https://github.com/ruby/fiddle/commit/b04cb92d7b
- 05:29 AM Revision d5c0018a (git): [ruby/fiddle] Fix a typo
- https://github.com/ruby/fiddle/commit/445ca6b501
- 05:29 AM Revision a0dcdd64 (git): [ruby/fiddle] Bump version
- https://github.com/ruby/fiddle/commit/f8fb7c4823
- 05:29 AM Revision 13f64333 (git): [ruby/fiddle] Add Fiddle::VERSION
- https://github.com/ruby/fiddle/commit/9dcf64c096
- 05:29 AM Revision 5fb7ca33 (git): [ruby/fiddle] Add missing spec.extensions
- https://github.com/ruby/fiddle/commit/2ce36b1fdc
- 05:29 AM Revision 77cc1394 (git): [ruby/fiddle] Fix assignment to array within struct (#26)
- * Allow access to a struct's underlying memory with `struct[offset, length]`.
https://github.com/ruby/fiddle/commit/24083690a6 - 05:29 AM Revision 4a835621 (git): [ruby/fiddle] Make array access override compatible with base class (#25)
- * Allow access to a struct's underlying memory with `struct[offset, length]`.
* Make accessing a struct's underlying memory more convenient.
* refactor memory access unit tests for improved clarity
https://github.com/ruby/fiddle/comm... - 05:29 AM Revision aa1d3c7d (git): [ruby/fiddle] Initialize memory to 0 when calling Fiddle.malloc(). (#24)
- https://github.com/ruby/fiddle/commit/8414239ca3
-
03:31 AM Revision ad729a1d (git): Fix origin iclass pointer for modules
- If a module has an origin, and that module is included in another
module or class, previously the iclass created for the module had
an origin pointer to the module's origin instead of the iclass's
origin.
Setting the origin pointer corr... -
02:12 AM Misc #16805: Coroutine's license is unclear
- https://github.com/ruby/ruby/pull/3137
-
02:10 AM Bug #16907 (Closed): Probable use-after-free in VM assertion
- The following Ruby program fails with VM assertions enabled on OpenBSD (code taken from `test_caller_to_enum` in `test/ruby/test_backtrace.rb`):
```ruby
def foo
return to_enum(__method__) unless block_given?
r... - 12:43 AM Revision fdb31aa7 (git): Time.xmlschema: Clarify error and docs
- It parses a (date)time, not a date.
-
12:36 AM Revision da484c31 (git): Enhanced Rdoc for Hash
05/22/2020
-
10:28 PM Revision f8647343 (git): Remove a bunch of files that were deleted upstream
- 10:28 PM Revision 2ec5f324 (git): * 2020-05-23 [ci skip]
-
10:28 PM Bug #16736 (Closed): Prepending blank module breaks super call in aliased method
- Applied in changeset commit:git|c745a60634260ba2080d35af6fdeaaae86fe5193.
----------
Fix origin iclass pointer for modules
If a module has an origin, and that module is included in another
module or class, previously the iclass created... -
10:27 PM Revision 36f29b59 (git): Fixed wrong usage rm_rf for cleanup the default gems in sync tool
-
02:54 PM Revision 8d798e7c (git): Revert "Fix origin iclass pointer for modules"
- This reverts commit c745a60634260ba2080d35af6fdeaaae86fe5193.
This triggers a VM assertion. Reverting until the issue can be
debugged. -
02:36 PM Revision c745a606 (git): Fix origin iclass pointer for modules
- If a module has an origin, and that module is included in another
module or class, previously the iclass created for the module had
an origin pointer to the module's origin instead of the iclass's
origin.
Setting the origin pointer corr... -
01:33 PM Feature #16824 (Rejected): Follow RubyGems naming conventions for the stdlib
- The first proposal was rejected. We should discuss each stdlib like `ostruct`.
-
01:29 PM Bug #16846 (Closed): Commit - win32ole: separate global variable declarations and definitions - backport?
-
01:27 PM Misc #16893 (Closed): Create Rosetta Code page on website
- We handle the official website that is https://www.ruby-lang.org/en/ on https://github.com/ruby/www.ruby-lang.org/.
Can you submit this idea or suggestion about Roseeta Code? Thanks. -
12:24 PM Revision ef13558f (git): Revert a commit miss in "Fixed potential memory leak"
- This reverts an unintentional change in commit
79d9528ddca1dfe2dd99287dc88fd7c2b30f7137. -
11:32 AM Revision df5fd1d0 (git): Fixup 1d079a0c5d4d80860a4d6d692344124fe5c562b5
-
11:32 AM Revision 1d889c96 (git): Sync Bundler PR #3624 with HEAD commits
-
11:32 AM Revision 93ebf964 (git): Revert 1f011cccb16ca9e8ee378cb5a9d4c14459afd68c
-
11:32 AM Revision 26367367 (git): Marked the failing examples with the current master branch on ruby repository
-
11:32 AM Revision 9c275229 (git): Glob the all man files provided by bundler upstream
-
11:32 AM Revision c7ebeb7e (git): Sync Bundler PR #3624
- 04:49 AM Revision f4f157fc (git): Suppress warnings no inline ruby debug (#3107)
- * Suppress unused warnings occurred due to -fno-inline
* Suppress warning occurred due to RUBY_DEBUG=1 -
03:05 AM Revision ac395754 (git): Enhanced rdoc for Hash (#3129)
-
02:51 AM Revision d707c92a (git): add static modifier for rb_hash_keep_if func
-
02:51 AM Revision e5354de9 (git): add static modifier for rb_hash_select_bang func
-
02:51 AM Revision 7c4e0859 (git): add static modifier for rb_hash_select func
-
02:38 AM Bug #16906 (Closed): Calling Thread#thread_variable? in IRB sometimes produce wrong result
- Consider this script:
``` ruby
Thread.current.thread_variable_set("ab", 12)
puts Thread.current.thread_variable?("ab")
puts Thread.current.thread_variable?(:ab)
puts Thread.current.thread_variable?("ab")
```
When I put the scr... -
02:23 AM Bug #16900 (Closed): Disposable call-cache introduced memory leak
- Applied in changeset commit:git|cbd45af2a9bec871ee023e6be57c5f32b22280fe.
----------
fix memory leak of ccs
rb_callable_method_entry() creates ccs entry in cc_tbl, but this
code overwrite by insert newly created ccs and overwrote ccs n... -
02:23 AM Revision cbd45af2 (git): fix memory leak of ccs
- rb_callable_method_entry() creates ccs entry in cc_tbl, but this
code overwrite by insert newly created ccs and overwrote ccs never
freed.
[Bug #16900] -
02:12 AM Revision 74cd607c (git): Run major GC three times to make sure the minor GC reason
- Same as 02705b27be207fce57bd0253251f81108c7ed57b
http://ci.rvm.jp/results/trunk-random1@phosphorus-docker/2955433
```
1)
TestGc#test_start_full_mark [/tmp/ruby/v3/src/trunk-random1/test/ruby/test_gc.rb:61]:
Expected :oldmalloc to be n... -
01:42 AM Bug #16905: Ruby required to build Ruby on Haiku?
- According to the log,
```
executable host ruby is required. use --with-baseruby option.
uncommon.mk:866: recipe for target 'parse.c' failed
make: *** [parse.c] Error 1
```
parse.y file has been modified, or its timestamp change... -
01:38 AM Bug #8446: sdbm fails to fetch existing key if many elements in it
- Agreed on removal.
Sdbm seems unmaintained 30 years, and having other bugs (or limitations) on storing large values too.
05/21/2020
-
09:50 PM Revision 79d9528d (git): Fixed potential memory leak
- Create a wrapper object first, then buffer allocation which can
fail. -
08:31 PM Misc #16802: Prefer use of RHS assigment in documentation
- I'm also not a big fan, but even if it becomes official it's not a good idea documentation-wise as it currently distinguishes cases where the return is self; there's no way to do this with the right assignment operator.
```
hsh.merge!(o... - 07:09 PM Revision 38a4f617 (git): * 2020-05-22 [ci skip]
-
07:08 PM Revision a53e2850 (git): Unpin and update VM references
- This commit just unpins and updates VM references
-
06:53 PM Bug #16900: Disposable call-cache introduced memory leak
- Great report!
https://github.com/ruby/ruby/pull/3128 -
04:16 PM Feature #16848: Allow callables in $LOAD_PATH
- One concern we found is some scripts expect `$:` contains String objects which represent a path.
Typically some scripts (gems) find a file in a `$:` (`$:.each{|path| ...}`). It will be a compatibility issue.
Maybe we need a trick to keep... -
11:51 AM Bug #16904: rubygems: psych: superclass mismatch for class Mark (TypeError)
- vo.x (Vit Ondruch) wrote in #note-8:
Upstream ticket: https://github.com/rubygems/rubygems/issues/3647 -
11:31 AM Bug #16904: rubygems: psych: superclass mismatch for class Mark (TypeError)
- vo.x (Vit Ondruch) wrote in #note-8:
Actually my original intention was to try this with disabled gems and it seems Ruby itself behaves as I would expect:
~~~
$ ruby --disable-gems -e '(1..3).each {|psych| $:.unshift("psych#{psych... -
11:29 AM Bug #16904: rubygems: psych: superclass mismatch for class Mark (TypeError)
- BTW I don't understand how this could work:
~~~
$ for psych in psych{1..3}; do mkdir $psych; echo "puts '$psych'" > $psych/psych.rb; done
$ find .
.
./psych2
./psych2/psych.rb
./psych1
./psych1/psych.rb
./psych3
./psych3/ps... -
09:53 AM Bug #16904: rubygems: psych: superclass mismatch for class Mark (TypeError)
- > What's wrong in Fedora?
Thank you for checking the issue on your environment.
In Fedora Ruby, there is no default gem psych gemspec: there is no file such as /usr/share/gems/specifications/default/psych-*.gemspec .
You can see htt... -
08:07 AM Bug #16904: rubygems: psych: superclass mismatch for class Mark (TypeError)
- vo.x (Vit Ondruch) wrote in #note-4:
> Just FTR, the patch just hides this issue, it does not resolve it.
BTW this [1] is my original RubyGems ticket which you can use to get pointers to various related issues such as [2].
[1]: ... -
07:59 AM Bug #16904: rubygems: psych: superclass mismatch for class Mark (TypeError)
- Also, I believe that call to `require 'psych'` should result to subsequent calls of `require 'psych'` to be no-op. This is apparently not the case.
-
07:56 AM Bug #16904: rubygems: psych: superclass mismatch for class Mark (TypeError)
- What is wrong with Ruby?
~~~
$ ruby -v
ruby 2.7.1p83 (2020-03-31 revision a0c7c23c9c) [x86_64-linux]
$ gem env
RubyGems Environment:
- RUBYGEMS VERSION: 3.1.2
- RUBY VERSION: 2.7.1 (2020-03-31 patchlevel 83) [x86_64-linux]
- INST... -
02:36 AM Bug #16904: rubygems: psych: superclass mismatch for class Mark (TypeError)
- After installing psych 3.1.0, no error found.
What's wrong in Fedora?
```sh
$ for ruby in ruby2.{2..7}; do $ruby -rpsych -e 'p [RUBY_VERSION, Gem.load_yaml, Psych::VERSION]'; done
["2.2.10", true, "3.1.0"]
["2.3.8", true, "3.1.0"]... -
02:26 AM Bug #16904: rubygems: psych: superclass mismatch for class Mark (TypeError)
- I can't see that error in 2.7 too.
```sh
$ for ruby in ruby2.{0..7}; do $ruby -rpsych -e 'p [RUBY_VERSION, Gem.load_yaml, Psych::VERSION]'; done
["2.0.0", true, "2.0.0"]
["2.1.9", true, "2.0.5"]
["2.2.10", true, "2.0.8"]
["2.3.8"... -
06:26 AM Feature #16891: Restore Positional Argument to Keyword Conversion
- A sole positional argument does in fact work, and I am a big fan of the pattern matching feature (enough that once we're on 2.7, I'm considering `-W:no-experimental`), but I hadn't thought about the combination of the two, and I certainl...
-
12:58 AM Feature #16891: Restore Positional Argument to Keyword Conversion
- Hi, @ziggythehamster, thank you for your feedback, and I'm sorry for troubling you.
In this case, I think you can accept the Hash argument as a positional one. How about this?
```ruby
class SomeProcessor
def <<(hash)
foo ... -
04:31 AM Revision ba7f4bb0 (git): Synchronized non-inline version rb_scan_args with the inline version
-
04:31 AM Revision 62b47196 (git): Added UNREACHABLE_RETURN
- To get rid of a void function at the end of non-void function.
-
04:27 AM Revision 3eb3f7bb (git): test/ruby/test_optimization.rb: Proc creation test should count :T_DATA
- instead of :TOTAL of ObjectSpace.count_objects.
This test had failed very occasionally:
https://rubyci.org/logs/rubyci.s3.amazonaws.com/centos8/ruby-master/log/20200521T033004Z.fail.html.gz
```
1) Failure:
TestRubyOptimization#test_b... -
02:17 AM Bug #16903 (Closed): Compilation error on x86_64-cygwin
- Applied in changeset commit:git|6f167da65b799435f94af3c5d39a80968e284f44.
----------
Fixed a variable name [Bug #16903]
Fix up of 0e3b0fcdba7
From: fd0 (Daisuke Fujimura) -
01:47 AM Revision 6f167da6 (git): Fixed a variable name [Bug #16903]
- Fix up of 0e3b0fcdba7
From: fd0 (Daisuke Fujimura) -
12:58 AM Revision 43725c60 (git): rb_scan_args_set: make it slightly readable
- This is a pure refactoring that improves understanding of what is going
on. Not a big win though.