Activity
From 04/26/2020 to 05/02/2020
05/02/2020
-
09:08 PM Misc #16747: Repository reorganization request
- vo.x (Vit Ondruch) wrote in #note-7:
> Also, not sure what is the rationale for mainsrc, but at the first look, I couldn't find the sources, because it is somehow unexpected name (at least to me).
Indeed, I missed that, why `mainsrc`... -
09:05 PM Misc #16747: Repository reorganization request
- vo.x (Vit Ondruch) wrote in #note-7:
> Also, not sure what is the rationale for mainsrc, but at the first look, I couldn't find the sources, because it is somehow unexpected name (at least to me).
`src` is what people are used to, so... -
06:45 PM Misc #16747: Repository reorganization request
- shyouhei (Shyouhei Urabe) wrote in #note-5:
> - For instance ccan is a header-only library. Should it be placed under include?
It is not just header only library, but vendored code. It would be nice if this kind of code lives outsid... -
- IMHO it's best if `include/` in the repository corresponds closely to what ends up in the install dir.
So I prefer ccan in `src/`.
`make test*` uses the repository dir, so adding anything else under `include/` would expose it to thos... -
09:31 AM Misc #16747: Repository reorganization request
- Great work, thank you.
Questions/discussions related to header files:
- For instance ccan is a header-only library. Should it be placed under include?
- What about for instance vm_core.h etc?
- Should files under include be instal... -
03:21 AM Misc #16747: Repository reorganization request
- https://github.com/nobu/ruby/tree/feature/src-dir is the status quo.
-
03:23 PM Revision 224f29c8 (git): spec/ruby/core/process/clock_getres_spec.rb: lax the resolution limit
- Android is Linux, but the clock resolution is 10 milliseconds.
I think that 1 microsecond is too strict for embedded environment.
This change laxes the limit to 10 milliseconds. - 03:16 PM Revision fe2a832a (git): * 2020-05-03 [ci skip]
-
-
-
-
-
-
- The exact exit status value of command failed to run is not a
spec, but a platform dependent implementation detail. Just it is
not "success". -
- Applied in changeset commit:git|a2be428c5fec31b8adbd5ac087e7637ddf7e54d0.
----------
Fix ObjectSpace::WeakMap#key? to work if the value is nil
* Fixes [Bug #16826] -
- I'll fix this.
-
- ```
$ ruby -e 'map=ObjectSpace::WeakMap.new; map[:foo] = 4; p map; p map.key? :foo'
#<ObjectSpace::WeakMap:0x000055fbe0c38c00: :foo => 4>
true # OK
$ ruby -e 'map=ObjectSpace::WeakMap.new; map[:foo] = nil; p map; p map.key? :foo'... -
- * Fixes [Bug #16826]
-
-
-
-
- As fork(2) is deprecated, its calls must be guarded by
`COMPILER_WARNING_IGNORED(-Wdeprecated-declarations)`.
All usages of fork(2) in process have been alread guarded. A new call
to fork(2) was added in ruby.c with f22c4ff359498ab342e4... -
- shyouhei (Shyouhei Urabe) wrote in #note-2:
> If you want the complete list, new macros are:
> ...
I took a look, these look fine to me, they seem almost all about portability, except `RUBY3_ANYARGS_DISPATCH*`.
I think most of those... -
- Interesting.
As `JSON.generate` converts the keys by `to_s`, it can be funnier.
```sh
$ ruby -rjson -e 'puts JSON.generate({"main"=>"string", :main=>"symbol", self=>"object"})'
{"main":"string","main":"symbol","main":"object"}
`... -
11:30 AM Bug #16825 (Third Party's Issue): JSON#generate gives invalid json string
- Hello Guys! First of all, thank you for working on the Ruby language.
I observed a peculiarity while playing around with `JSON#generate`. When hash contains keys of the same word/literal but as symbol and string in the same hash, the ... -
- I think it would be good to make it a habit to justify any syntax change with some motivation.
For instance, I would suggest making sure the point is clear in the ticket before accepting a syntax change.
I don't see much examples her... -
09:15 AM Misc #16775: DevelopersMeeting20200514Japan
- * [Feature #15771] Add `String#split` option to set `split_type string` with a single space separator (sawa)
* Proposal by 284km. Allow splitting literally by `" "` when the argument is `" "`. -
- - [Misc #16747] Repository reorganization request (shyouhei)
- @hsbt says:
> I remember @nobu has the working branch about this.
I would like to know its current situation.
-
- shevegen (Robert A. Heiler) wrote in #note-9:
> The optionparser situation is indeed quite ... peculiar to me:
> ...
It has been available since 6 years ago, for your [Feature #9864].
```
$ ruby -roptionparser -e 'ARGV.parse!' -- -... -
01:42 AM Feature #16824: Follow RubyGems naming conventions for the stdlib
- The optionparser situation is indeed quite ... peculiar to me:
require 'optparse'
OptionParser.new
My brain has a hard time with it. I'd prefer:
require 'optionparser'
or
require 'option_parser' # <- would...
05/01/2020
-
11:53 PM Feature #16824: Follow RubyGems naming conventions for the stdlib
- @marcandre AFAIK some gem ownerships were already transferred back to claim std-lib names. Looking at those examples, majority of those conflicts could be solved in the same way if needed (long-term).
The main question in here is if R... -
07:33 PM Feature #16824 (Open): Follow RubyGems naming conventions for the stdlib
-
- We can't do this in general, sadly. For example, there exist two gems `file-utils` and `file_utils`, both of which use `require 'file_utils'` to be used.
Some other gems are conflict free (e.g. neither `open_struct` or `open-struct` a... -
02:54 PM Feature #16824: Follow RubyGems naming conventions for the stdlib
- @naruse @nobu The "use case" for this is Rubyists nowadays have a very strong intuition that "Foo::BarBaz" module typically required via `foo/bar_baz` path. This convention is encouraged by tutorials (including RubyGems' linked above, wi...
-
- The same also works for English.rb which is part of Ruby itself. It is very confusing to do `require 'English'` (require file with initial capital letter).
-
- @naruse I was thinking about the same for a while as well. My use-case in here is simple. I often require 'secure_random' since that should be standard filename for file defying SecureRandom class/module, but actually I end up with error...
-
01:48 PM Feature #16824: Follow RubyGems naming conventions for the stdlib
- Features should have use cases.
-
-
03:33 AM Feature #16824 (Rejected): Follow RubyGems naming conventions for the stdlib
- It's been really nice that most gems these days follow the RubyGems naming convention, so you know exactly what to require just from seeing the gem name: https://guides.rubygems.org/name-your-gem/
I wonder if it would be possible to a... - 05:41 PM Revision bb2ca762 (git): * 2020-05-02 [ci skip]
-
05:40 PM Revision 72c0612c (git): Skip Solaris RubyCI TestJIT for now
- to be investigated later
https://rubyci.org/logs/rubyci.s3.amazonaws.com/solaris10-gcc/ruby-master/log/20200501T160004Z.fail.html.gz -
-
- Also renamed as like as a constant.
-
- caused by 818d6d33368a396d9cd3d1a34a84015a9e76c5c8, for now.
I'll take a look at them tomorrow. -
- to fix
https://ci.appveyor.com/project/ruby/ruby/builds/32577700/job/yh61rom35wt2uv39
It was for JIT compaction, and we don't support it on mswin. -
- As zero variadic macro argument, `rb_scan_args(argc, argv, "")`
(or `"0"`), means 0-arity method and should be defined so, that
case doesn't need to consider. -
-
-
- as well. And also unit->c_file doesn't exist in mswin.
https://github.com/ruby/ruby/runs/635915704 -
08:46 AM Bug #16780 (Assigned): Net::FTP PUT command issuing Net::ReadTimeout too quickly
- @naruse It seems that the change was introduced by your commit. Could you check it?
-
- to improve code locality.
Using benchmark-driver/sinatra with 100 methods JIT-ed,
[Before] 12149.97 rps
1.3M /tmp/_ruby_mjit_p31171u145.so
[After] 12818.83 rps
260K /tmp/_ruby_mjit_p32155u145.so
(VM is 13714.89 rps) -
- While `tool/sync_default_gems` can be useful to overwrite files, in some circumstances it won't help (e.g. different changes in both directories). I also wanted to move commits across repositories and not loose history.
I found a soluti... -
-
-
- to child compile_status
- 07:25 AM Revision 6eed4d1b (git): [ruby/matrix] v0.3.0
- 07:25 AM Revision 9b5675b3 (git): [ruby/matrix] Add Matrix#adjoint [#14]
- Patch adapted from Alessandro Minali
- 07:25 AM Revision 07fd6dc4 (git): [ruby/matrix] Optimize Matrix#*
- 07:25 AM Revision 3cb038cc (git): [ruby/matrix] Fix Matrix#orthogonal?
- 07:25 AM Revision 7d360efe (git): [ruby/matrix] Fix Matrix#unitary? [#14]
-
-
- I'm trying to make it possible to include all JIT-ed code in a single C
file. This is needed to guarantee uniqueness of all function names -
- because we support JIT compaction on it
-
- Running C compiler for JIT compaction inside a critical section may lock
main thread for a long time when it triggers GC. As I'm planning to
increase this duration a bit, I'd like to make sure this doesn't stop
the world.
For now, I cho... -
04/30/2020
-
- I do not have a strong preference here either way; I guess one can reason in
favour for both behaviour types/styles, and I think a primary point in the
suggestion is that it refers to startless/endless situations, such as "5..",
whic... -
- (First of all, I understand that the proposed change can break code, but I expect it not to be a large amount empirically.)
I propose that methods that slice an array (`#slice` and `#[]`) and return a sub-array in the normal case, sho... -
07:18 PM Misc #16775: DevelopersMeeting20200514Japan
- * [Feature #9758] Allow setting SSLContext#extra_chain_cert in Net::HTTP (stan3)
* useful to allow https with cert chain, small patch, few :+1s -
- * [Feature #16822] Array slicing: nils and edge cases (zverok)
* Never return `nil` from `ary[start...end]` even if out of arrays' bounds - 05:32 PM Revision 9014c900 (git): * 2020-05-01 [ci skip]
-
05:32 PM Revision 5a9d2da7 (git): Remove deprecated rb_require_safe
-
- IRB::ReadlineInputMethod#initialize sets via IRB.set_encoding.
-
12:20 PM Bug #16823 (Closed): Bundler related manual pages are corrupted
- We recently found out that bundler related manual pages we get by building and installing ruby 2.6 (and as far as I can tell all newer versions as well) are corrupted (we are building with `--with-mantype=man`).
The reason is that, e.... -
- Your proposal to distinguish `nil` from `false` is ad hoc, and is not a real solution for your use case, which is to add a value to a hash only when it does not yet have a corresponding key.
Following your way of doing it, you would sti... -
- bsarrazin (Ben Sarrazin) wrote in #note-7:
> Kotlin has this feature, Swift has this feature, many other languages have this feature.
No. Kotlin does not have this feature (distinguish `false` and `null`). It is a really bad idea f... -
04:16 AM Feature #16821: gem version notation for "rational version" compatibility
- Thank you for the quick response. Yes, I will do refile there. Sorry for mistakenly filing here.
-
- Can you report it to rubygems' upstream? It has its own tracker: https://github.com/rubygems/rubygems
-
-
- 02:48 AM Revision 14b5a3b4 (git): * 2020-04-30 [ci skip]
-
- Readline::VERSION may not be a single word, e.g EditLine wrapper
when linked with editline.
04/29/2020
-
11:24 PM Feature #16150: Add a way to request a frozen string from to_s
- I can confirm that Discourse bench and Discourse works with symbol-fstring today.
Old versions of pry were broken, but stuff seems fine now. -
- When a gemspec wants to express a version requirement, we typically use the `'~> '` notation like this:
```ruby
spec.add_dependency 'nokogiri', '~> 1.8'
```
This indicates compatibility following the "rational versioning" as descri... -
08:05 PM Feature #13820: Add a nil coalescing operator
- Kotlin has this feature, Swift has this feature, many other languages have this feature.
Ruby _needs_ this feature :D
```ruby
"a truthy value" || foo("something else") # The operator also short circuits so the method `foo` will neve... -
10:13 AM Revision 7e5253d1 (git): [ruby/irb] Suppress "method redefined" warning
- https://github.com/ruby/irb/commit/5f0aee56fa
-
- https://github.com/ruby/irb/commit/cdbb9dfc9f
-
- https://github.com/ruby/irb/commit/a6fe58e916
-
- https://github.com/ruby/reline/commit/13420197b8
-
- https://github.com/ruby/reline/commit/298144b06a
-
- And unlimited is default.
https://github.com/ruby/reline/commit/f5149c3ca6 -
- https://github.com/ruby/reline/commit/9bdbed9cbc
-
- https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html
> All paths set in these environment variables must be absolute.
> ...
https://github.com/ruby/reline/commit/45af6eea77 -
- OK, thank you for clarification. Then we don't have to bother them in LEGAL.
-
08:50 AM Bug #16820: LEGAL is out of sync
- I see.
> If you didn't intend to change their license (== they are still dual-licensed), then their gemspec shall be updated to reflect that info like s.licenses = ["Ruby", "BSD-2-Clause"].
We should update it to gemspec files esp... -
- @hsbt Did you want to change license of those libraries from Ruby's to "BSD only"? Then we should list up all of them in LEGAL. If you didn't intend to change their license (== they are still dual-licensed), then their gemspec shall be...
-
- Should we update the sentence about dual license with BSD-2-Clause to `LEGAL` file? I'm not sure what your expectation.
-
- At the very beginning of `LEGAL`, it reads:
> All the files in this distribution are covered under either the Ruby's
> ...
This means that the exception list must be comprehensive. If we miss someone else's software there, it would ... -
- It may contain symbolic links.
-
-
04/28/2020
-
- @sam.saffron I'll let @ioquatix reply in more details but my point of view on that is:
#13618 is not flexible, and rather hardcodes everything including the scheduler, the IO selectors, etc, which would add a huge implementation cost to... -
- My big concern here is that this does not cover why #13618 was deficient and this complete greenfield implementation solves the issues it had?
#13618 had kqueue and epoll implementations which this would leave unimplemented, as far a... -
-
- Partially revert adab82b9a71f60ad1c7f4f8c134a5ae9198ab32a and
c63b5c6179d700ceacf5cae8d3ee86da1294c781.
The issue that these commits attempt to address was maybe fixed with
1c7f5a57125001447dc6173847dc68aa50bd8e93. - 03:01 PM Revision 31a4ee4c (git): * 2020-04-29 [ci skip]
-
- Even without this limit, these assertions almost certainly cause a
NoMemoryError by removing the fix in 72ad8595f20. -
-
-
03:33 AM Feature #16818: Rename `Range#%` to `Range#/`
- I visualise a bag of grain. If I'm asked to divide it by three, I will make three piles of grain. If I'm asked to modulate it by three, I will make many piles, each of three grains.
> why you need to refer to complex numbers
This i... -
- inopinatus (Joshua GOODALL) wrote in #note-8:
> their division seems intuitively identical to cutting a line into parts. [...] Division is therefore cutting that line into parts
That is exactly what I am saying (although I am not sure ... - 02:39 AM Revision 3acdb318 (git): * 2020-04-28 [ci skip]
-
- https://github.com/rubygems/rubygems/commit/d4486ca061
-
02:04 AM Revision 5b77fc8a (git): [rubygems/rubygems] Remove commented out code
- https://github.com/rubygems/rubygems/commit/42aa0d7ebc
-
- Some tests had failed under `umask 077` mode. As far as I investigated,
there is no actual bug. All failures were caused by tests that create a
wrong-permission file or expect wrong permission.
This changeset fixes the tests.
https:/... -
- English.rb is extracted to the default gems at
https://github.com/ruby/ruby/commit/2c5764ec223d976e0d0da1494596a1519104be3e
https://github.com/rubygems/rubygems/commit/532f488c0b
04/27/2020
-
- > x / y reads "divide x by y", not "divide x into y parts"
I'm not sure I understand the difference, but nevertheless I agree with Eragon's intuition.
To me, a range is not a matrix, not a sequence either. I think of ranges as int... -
06:18 PM Bug #16819 (Assigned): Line reporting off by one when reporting line of a hash?
- If I run this program:
```
TracePoint.new(:line) { |t| p t.lineno}.enable
def foo(a, b) # 2
a + b # 3
end # 4
# 5
foo 1, 2 # 6
# 7
A = { # 8
a: 1, # 9
b: 2... -
10:58 AM Feature #16150: Add a way to request a frozen string from to_s
- Could we consider `Symbol#to_s` retuning frozen strings again?
We've been running with https://github.com/Shopify/symbol-fstring for a about 5 months now, and I think the backward incompatibility problem is much less important now.
... -
-
- Couldn't figure out failed/fixed versions.
-
- That bug has been fixed by ec0c394b9eb, and the test has been
added by 181ffea5e04. -
12:41 AM Revision fd2df584 (git): Fix a typo [ci skip]
04/26/2020
-
11:43 PM Feature #16818: Rename `Range#%` to `Range#/`
- Eregon (Benoit Daloze) wrote in #note-2:
> Just my opinion, but I find `%` a lot more intuitive, and would find `/` very confusing in this context.
> ...
I agree. Of course, `/` and `%` are related, so it's no surprise that there are a... -
- > x / y reads "divide x by y", not "divide x into y parts".
Makes sense.
It is language difference probably: in my native Ukrainian (and Russian I was taught in school) it reads as (roughly translating) "divide into y"; therefore... -
- zverok (Victor Shepelev) wrote in #note-4:
> I'd say that `(5..14) / 3` reads definitely like "split the range into 3 parts" (expecting, IDK, 3 sub-ranges or jumps over `(14-5) / 3` spans).
x / y reads "divide x by y", not "divide x in... -
- I'd say that `(5..14) / 3` reads definitely like "split the range into 3 parts" (expecting, IDK, 3 sub-ranges or jumps over `(14-5) / 3` spans).
`(5..14) % 3` at least reads (for me) like "range 5—14 `<something>` 3", bearing no imme... -
- I somewhat agree with sawa's comment that % on Range may confuse some ruby
folks; I think % is more typically the modulo operator? I can not say how
strong this confusion may be, perhaps small, perhaps not, but I concur with
his origi... -
- Just my opinion, but I find `%` a lot more intuitive, and would find `/` very confusing in this context.
One interpretation of `%` here is `by` or "so that (element % n) is always the same, starting with the Range#begin value" -
- `Range#%` was introduced as an alias of `Range#step` by 14697, but it is counter-intuitive and confusing.
Iteration in the following:
```ruby
((5..14) % 3).each{|i| p i}
#>> 5
#>> 8
#>> 11
#>> 14
```
is not based on `x % y... -
- FYI: I re-enabled the test in question with 93ed465dcdc866013cd93c3662937497900c8086
-
- Revert 9948addda67f4b7a6e3575f1eba9025f998811d2.
It is now discussed in https://bugs.ruby-lang.org/issues/16814, and an
assert is added with a217d3cedce3f5aa5c27a1ce6c72b65ec37da057.
It would be good to give it a try. -
- 03:54 PM Revision 33767d1e (git): * 2020-04-27 [ci skip]
-
-
-
-
- yield `home_dir` when HOMEDIR is not falsy only.
https://github.com/ruby/ruby/blob/d0f41aa2382612022162d033ddb3d9c9cc62099e/lib/rdoc/ri/paths.rb#L43
```
yield home_dir, :home if home and HOMEDIR
```
https://rubyci.org/logs/ruby... -
-
-
-
03:39 AM Revision 034b8472 (git): remove unused rb_str_clear define (#3059)
-
- https://rubyci.org/logs/rubyci.s3.amazonaws.com/scw-ad7f67/ruby-master/log/20200425T175405Z.fail.html.gz
```
4) Error:
TestRDocServlet#test_asset:
NoMethodError: undefined method `replace' for nil:NilClass
/home/chkbuild/build/2020...