Activity
From 03/26/2020 to 04/01/2020
04/01/2020
-
10:54 PM Misc #16750: Change typedef of VALUE for better type checking
- I think the motivation to make C extensions safer is great here, but I see many problems with this approach.
TruffleRuby until recently typed `VALUE` (and `ID`) as `void*` (because TruffleRuby+Sulong store managed Java objects in ther... -
06:54 PM Misc #16750: Change typedef of VALUE for better type checking
- Affecting 62,213 lines is huge. That's at least 62,213 places where an error could be introduced by using the incorrect union member or something similar.
If we were going to consider this, it would be helpful to have a list of previ... -
06:22 PM Misc #16750 (Open): Change typedef of VALUE for better type checking
- VALUE is currently defined as `typedef unsigned long VALUE`, but as we all know that only creates an _alias_, not an actual _type_. Since the compiler gives no warnings when comparing with other integer values, it's easy to have bugs suc...
-
05:49 PM Bug #16748: Different behaviour between a hash and multi-Array when passing 2 arguments to a proc
- mame (Yusuke Endoh) wrote in #note-3:
> The behavior of 2.5.5 was wrong. `Array#map` yields each element, in this case, `['one', 'two']`, an array of two elements. The lambda requires two arguments, but one array is passed, which shou... -
03:54 PM Bug #16748 (Rejected): Different behaviour between a hash and multi-Array when passing 2 arguments to a proc
- The behavior of 2.5.5 was wrong. `Array#map` yields each element, in this case, `['one', 'two']`, an array of two elements. The lambda requires two arguments, but one array is passed, which should raise "wrong number of arguments".
... -
- In Ruby 2.5.5 i get what i'm expecting
```ruby
test = -> (one, two) { one }
[['one', 'two']].map(&test)
=> ["one"]
```
In Ruby 2.7.0 this doesn't work
```ruby
test = -> (one, two) { one }
[['one', 'two']].map(&test)
wrong num... -
- Linux now supports lchmod :tada:
-
03:50 PM Bug #16749 (Closed): File.lchmod specs fails on linux since glibc 2.31.9000
- I observe following test errors on Fedora Rawhide when building against glibc 2.31.9000:
~~~
1)
File.lchmod returns false from #respond_to? FAILED
Expected true to be false
/builddir/build/BUILD/ruby-2.7.0/spec/ruby/core/file/lchm... -
- Okay seriously. You should have written many "simple" method definitions that have only one expression:
```ruby
# three-line style
def value
@val
end
# one-line style
def value; @val; end
```
Surprisingly, according to the followin... -
06:32 AM Feature #16746: Endless method definition
- I totally agree with the idea **seriously**, (far better than #5054, #5065 and #12241) but don't like the syntax. First I thought
```ruby
def foo(a) = expression
```
But it is a conflicting syntax.
Matz
-
01:25 AM Feature #16746: Endless method definition
- > I'm paranoid that the ends end Ruby. I hope Ruby is endless.
With so many cancellations of events this year, we may not want to
want to jinx ruby too much for the 3.0 release this year because
then 3.0 itself may become the endle... -
- Ruby syntax is full of "end"s. I'm paranoid that the ends end Ruby. I hope Ruby is endless.
So, I'd like to propose a new method definition syntax.
```ruby
def: value(args) = expression
```
As you see, there is no "end".
... -
- Actually, Ruby 2.7 also needs https://github.com/ruby/ruby/commit/a19228f878d955eaf2cce086bcf53f46fdf894b9
-
10:29 AM Revision fad0a145 (git): Revert "[ruby/etc] Deprecate names under `Struct`"
- This reverts commit 919b175afc389f8df6a3caa05ffdd28f5fc4bfca.
Since 604689628dc64d050a68f1ebe5e06f9105474936, to let `try_run`
work before LIBRUBY_SO is installed, `try_link` links against the
static library which defines even symbols u... -
- https://github.com/ruby/etc/commit/25c538120c
-
- Revert "Added build:mingw" e1674c18f5a0faf881b362363f428d139baef3b4.
https://github.com/ruby/etc/commit/d8f1dd85d3 -
07:20 AM Feature #16650: Ruby 2.6.* and 2.7* no longer compile on latest Mingw64
- I find that answer quite surprising. The RubyInstaller for windows is based on msys and mingw64 (and has been for many years):
https://rubyinstaller.org/add-ons/devkit.html -
07:10 AM Misc #16747: Repository reorganization request
- I strongly agreed on this. In GitHub, `README.md` was located with the long scroll action.
I remember @nobu has the working branch about this. -
06:58 AM Misc #16747 (Assigned): Repository reorganization request
- Back in 0.49, there were only 60 files and 3 directories at the root of this project. This was already at some level, but OK-ish. Now, as we are reaching 3.0, we currently have 167 files and 26 directories. The project has grown up. ...
-
-
-
05:10 AM Revision 151f8be4 (git): Make JIT-ed leave insn leaf
- to eliminate sp / pc moves by cancelling JIT execution on interrupts.
$ benchmark-driver benchmark.yml -v --rbenv 'before --jit;after --jit' --repeat-count=12 --output=all
before --jit: ruby 2.8.0dev (2020-04-01T03:48:56Z master 5a81562... -
- It is not needed to test itself, but the element should be tested
instead. - 02:49 AM Revision 57a36a16 (git): * 2020-04-01 [ci skip]
- 02:49 AM Revision 3e386d76 (git): Fix helper to not assume glibc
- 02:49 AM Revision 0091fac1 (git): Patch assembly so that it aligns properly
- 02:49 AM Revision 519a69b5 (git): ucontext doesn't exist in a musl-libc env; use native assembly
03/31/2020
-
- I think this may go only after a ruby 3.0 release. Personally I'd love to simplify
all of Date, Time and DateTime - but I guess that would mean even more backwards
incompatible changes. :) -
09:01 PM Feature #16745 (Open): Improving Date and DateTime comparison
- Currently, when a Date and DateTime are compared, the Date is treated as a DateTime with time "00:00:00 +0000". This results in behavior which could be surprising when the other DateTime is not in UTC ("+0000"):
```ruby
date = Date.... -
08:12 PM Bug #16743: problem with multi threading [BUG] Segmentation fault
- Also, do you happen to be running on Ubuntu Bionic Beaver?
-
- I see that you use `chingu-pathfinding` which includes a native extension.
To make the problem smaller, could you try reproducing without that library? -
05:46 PM Feature #16744: Flag to load current bundle without using bundle exec
- I understand your comment on my issue better now that we discussed it...
It does appear that Bundler added in the past few years the ability to detect that the `bundle exec` target is a Ruby script with an appropriate shebang, where app... -
- > Given that latest Bundler no longer creates a subprocess for bundle exec
Your example is incorrect. `exec` reuses process ID.
```
$ jruby -e 'puts $$; exec %{jruby -e "puts $$"}'
85727
85727
``` -
- > I think so far very few people know about -G, mostly because MRI doesn't have it.
Sadly I don't believe the Rubinius folks ever submitted a feature request. It might have been discussed briefly on the ruby-core list. -
- Given that latest Bundler no longer creates a subprocess for `bundle exec`, I think we don't need this anymore.
Or did I miss something?
https://github.com/rubygems/rubygems/issues/3246#issuecomment-606764738 -
- Added missing link to the RubyGems/Bundler issue I mentioned.
> But, I don't think we want to force using a Gemfile on every gem command.
This *must* be opt-in. There are many cases where you will not want to automatically pull in ... -
- I think supporting `-G` would be valuable, because then it could be used interchangeably on multiple Ruby implementations.
I think so far very few people know about `-G`, mostly because MRI doesn't have it.
Solving it directly in R... -
- ioquatix (Samuel Williams) wrote in #note-2:
> Can we change the hashbang line to have -G and then get `bundle exec` like behaviour for all shims?
Extra arguments in the shebang line are not respected on all OS IIRC.
And `require 'b... -
01:46 PM Revision 46a5d1b4 (git): bump teeny version to 2.6.7.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_6@67883 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 12:13 PM Revision 6d20bf22 (git): merge revision(s) 47a1872cd8b901b8aab6dedce7fa3807c97d290d: [Backport #16681]
- Use osuosl instead of GitHub releases
Because the package provided by GitHub releases is different from sourceware.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@67881 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- This might not be a bug, but the change is needed for #16634 commit:2339be74e737b4c5f5330f845af2e7db0c7450e1, so please backport to 2.7.
- 11:40 AM Revision d5e7ea9e (git): merge revision(s) 61b7f86248bd121be2e83768be71ef289e8e5b90
- * ext/socket/init.c: do not return uninitialized buffer
Resize string buffer only if some data is received in
BasicSocket#read_nonblock and some methods.
Co-Authored-By: Samuel Williams <samuel.williams@orion... -
- ext/socket/init.c: do not return uninitialized buffer
Resize string buffer only if some data is received in
BasicSocket#read_nonblock and some methods.
Co-Authored-By: Samuel Williams <samuel.williams@oriontransfer.co.nz>
git-svn-id... -
- Resize string buffer only if some data is received in
BasicSocket#read_nonblock and some methods.
Co-Authored-By: Samuel Williams <samuel.williams@oriontransfer.co.nz> - 10:54 AM Revision 17840bae (git): Bump version to 2.4.10
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@67874 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
10:51 AM Bug #16698: Backport security fix for CVE-2020-10663
- ruby_2_4 r67873 merged revision(s) 36e9ed7fef6eb2d14becf6c52452e4ab16e4bf01.
- 10:51 AM Revision 68180523 (git): merge revision(s) 36e9ed7fef6eb2d14becf6c52452e4ab16e4bf01: [Backport #16698]
- backport 80b5a0ff2a7709367178f29d4ebe1c54122b1c27 partially as a
securify fix for CVE-2020-10663. The patch was provided by Jeremy Evans.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_6@67856 b2dd03c8-39d4... -
10:44 AM Revision a0c7c23c (git): v2.7.1p83
-
- BasicSocket#read_nonblock and some methods changes the size of a buffer
string, but when no data is available, the buffer is returned as
uninitialized.
Co-Authored-By: Samuel Williams <samuel.williams@oriontransfer.co.nz> -
- 07:31 AM Revision 5caee291 (git): * 2020-03-31 [ci skip]
-
07:10 AM Revision bb93659f (git): Fix pp when passed a empty ruby2_keywords-flagged hash as array element (#2966)
- This causes problems because the hash is passed to a block not
accepting keywords. Because the hash is empty and keyword flagged,
it is removed before calling the block. This doesn't cause an
ArgumentError because it is a block and not... -
- It originally had a string literal, but it no longer has one.
- 06:17 AM Revision d83ac4ec (git): * 2020-03-31 [ci skip]
-
- JIT support of dd723771c11.
$ benchmark-driver -v --rbenv 'before;before --jit;after --jit' benchmark/mjit_exivar.yml --repeat-count=4
before: ruby 2.8.0dev (2020-03-30T12:32:26Z master e5db3da9d3) [x86_64-linux]
before --jit: ruby 2.8....
03/30/2020
- 10:47 PM Revision d4e1eb1d (git): merge revision(s) 4adb2d655dcd54b28366b4d17e86b21e2b622cd1: [Backport #16738]
- Make RbConfig::CONFIG values mutable [Bug #16738]
As `RbConfig.expand` modifies the argument and involved `CONFIG`
values, its values should be mutable.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@678... -
- ruby_2_5 r67871 merged revision(s) 62743.
- 10:44 PM Revision 209f3451 (git): merge revision(s) 62743: [Backport #16687]
- Fix FrozenError on `Ripper.slice`
Currently `Ripper.slice` raises a FrozenError
```ruby
require 'ripper'
p Ripper.slice('foo', 'ident')
```
```
/path/to/g/lib/ruby/2.6.0/ripper/l... - 10:33 PM Revision 8580c093 (git): merge revision(s) 8a6ba10f9dd456cf54de800203cf04bbe42271fb: [Backport #12392]
- Do not make disabled directories at installation [Bug #12392]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@67870 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
10:23 PM Feature #16744: Flag to load current bundle without using bundle exec
- Just so I understand this more clearly, could bin stubs use this in a shim to avoid needing to use `bundle exec`?
```
koyoko% cat /home/samuel/.rbenv/versions/2.7.0/bin/bake
#!/usr/bin/env ruby
#
# This file was generated by RubyGems.
... -
- The `bundle exec` command is used by Ruby users primarily to start up a Ruby command or application with only its specific locked dependencies wired up. Unfortunately to do this it currently double-launches, executing a second Ruby comma...
-
- ruby_2_5 r67869 merged revision(s) 36e9ed7fef6eb2d14becf6c52452e4ab16e4bf01.
- 10:22 PM Revision b379ecd8 (git): merge revision(s) 36e9ed7fef6eb2d14becf6c52452e4ab16e4bf01: [Backport #16698]
- backport 80b5a0ff2a7709367178f29d4ebe1c54122b1c27 partially as a
securify fix for CVE-2020-10663. The patch was provided by Jeremy Evans.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_6@67856 b2dd03c8-39d4... - 10:11 PM Revision 67b77240 (git): merge revision(s) 6e6844320de989cb88a154e2ac75066ccea1bba2: [Backport #16619]
- Fixed duplicated warning
As `command_rhs` is always a "value expression", `command_asgn`
does not need the same check.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@67868 b2dd03c8-39d4-4d8f-98ff-823fe69... -
- ruby_2_5 r67867 merged revision(s) 6a2d779027818eda418c9118f700b36816e833a5.
- 10:05 PM Revision fdffe91d (git): merge revision(s) 6a2d779027818eda418c9118f700b36816e833a5: [Backport #16681]
- Switch to download libffi source package to github releases from
sourceware.org
[Bug #16681]
(cherry picked from commit 86022167461dc90b70164e2bb23316959bbfd6ba)
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/bran... -
- ruby_2_5 r67866 merged revision(s) 77596fb7a91cc119b25ac9e19b3c8682709765b4.
- 09:51 PM Revision 2655e657 (git): merge revision(s) 77596fb7a91cc119b25ac9e19b3c8682709765b4: [Backport #16138]
- Do not turn on keyword_init for Struct subclass if keyword hash is
empty
This was accidentally turned on because there was no checking for
Qundef.
Also, since only a single keyword is currently supporte... -
- ruby_2_5 r67865 merged revision(s) 4f19666e8b144600e959e4673f79d63f98bd637d.
- 09:49 PM Revision 77d84046 (git): merge revision(s) 4f19666e8b144600e959e4673f79d63f98bd637d: [Backport #16508]
- `Regexp` in `MatchData` can be `nil`
`String#sub` with a string pattern defers creating a `Regexp`
until `MatchData#regexp` creates a `Regexp` from the matched
string. `Regexp#last_match(group_name)` accessed it... -
- ruby_2_5 r67864 merged revision(s) d6a2bce64a7fa1099e507e1d36b5f1533f42f60f,c687be4bc01c9ce52ea990945d9304d6fe59fe9b.
- 09:46 PM Revision b4446de7 (git): merge revision(s) d6a2bce64a7fa1099e507e1d36b5f1533f42f60f,c687be4bc01c9ce52ea990945d9304d6fe59fe9b: [Backport #16159]
- time.c (find_time_t): fix round-to-zero bug
`find_time_t` did not work correctly for year older than the Epoch
because it used C's integer division (which rounds negative to zero).
For example, `TIme.new(1933)` ... - 09:37 PM Revision ac6dd2fe (git): merge revision(s) 203b7fa1ae8cc40d41c38d684f70b3fea7fae813,0131fab749fb76800de09e49a6abf910201c5b58,9c0cd5c569ba22bc68d1a77ad6580a275cd99639,c144d7215b3444fa36d28d540b60170a5b30743d: [Backport #16196]
- Guard static variable first
* ext/openssl/ossl_asn1.c (Init_ossl_asn1): register the static
variable to grab an internal object, before creating the object.
otherwise the just-created object could get collect... - 09:26 PM Revision bc7d6e66 (git): merge revision(s) 463092b84da7933f307cc8747f948f68ef19f5fd: [Backport #16279]
- Update rake-12.3.3.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@67862 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_5 r67861 merged revision(s) c9423b016cfeab852bc5a829e55e0a11f80b3ab7,0b1e26398e018116180bf41cb63887f77d5d1b82,78ee2c245331e353e218b8fac9ca722a2bcd8fea.
- 09:21 PM Revision ec3e09c1 (git): merge revision(s) c9423b016cfeab852bc5a829e55e0a11f80b3ab7,0b1e26398e018116180bf41cb63887f77d5d1b82,78ee2c245331e353e218b8fac9ca722a2bcd8fea: [Backport #15968]
- marshal.c: check instance variable count
* marshal.c (w_obj_each): ensure that no instance variable was
added while dumping other instance variables. [Bug #15968]
Hoisted out w_ivar_each
marshal.c: ... -
- ruby_2_5 r67860 merged revision(s) 78ef2d0f331c3e056ee367214710b41722de2fe0.
- 09:11 PM Revision 07ae2fe9 (git): merge revision(s) 78ef2d0f331c3e056ee367214710b41722de2fe0: [Backport #15935]
- merge revision(s) 8b3774be3dd9f472bddd99e84e3c9fe2ff99d7ac: [Backport
#15935]
Fix memory leak
* string.c (str_make_independent_expand): free independent buffer.
[Bug# 15935]
... -
-
- ruby_2_7 b5fa156b7907b8ea1baf8b9f0cb6a66b0fecb3d4.
-
- Applied in changeset commit:git|b385f7670ffa420790bc548747fa4b58c4c5d8f6.
----------
Clear all trace events during teardown
Since 0c2d81dada, not all trace events are cleared during VM teardown.
This causes a crash when there is a trac... - 10:15 AM Revision d04856bd (git): * 2020-03-30 [ci skip]
-
- Since 0c2d81dada, not all trace events are cleared during VM teardown.
This causes a crash when there is a tracepoint for
`RUBY_INTERNAL_EVENT_GC_EXIT` active during teardown.
The commit looks like a refactoring commit so I think this c... -
10:09 AM Revision 0057fe40 (git): Ruby 2.7 backport about IRB (#2990)
- * [ruby/reline] Sort completion list
#### Legacy mode:
```console
$ irb --legacy
irb(main):001:0> l[TAB][TAB]
lambda load local_variables loop
```
#### Before this patch:
```console
$ irb
irb(ma... -
09:47 AM Revision 7a2177ea (git): Use `--depth` on pull request
- `--shallow-since=yesterday` for COMMIT_NUMBER_OF_DAY of `tool/actions-commit-info.sh`.
COMMIT_NUMBER_OF_DAY is mainly for master branch.
And `--shallow-since=yesterday` may fail on pull request.
So this revert to `--depth` on pull request. -
-
-
- But it will be back with OpenSSL 3.x, I am afraid.
-
- ruby_2_6 r67859 merged revision(s) 4adb2d655dcd54b28366b4d17e86b21e2b622cd1.
-
- Make RbConfig::CONFIG values mutable [Bug #16738]
As `RbConfig.expand` modifies the argument and involved `CONFIG`
values, its values should be mutable.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_6@6785... -
04:18 AM Bug #16743: problem with multi threading [BUG] Segmentation fault
- ko1 (Koichi Sasada) wrote in #note-1:
> > already tested with different versions of ruby
> ...
In versions 2.6.5 and 2.7.0:
* [BUG] Segmentation fault........
In version 2.5.7:
```
/home/paulorja/tcc/ircardia/ws-game-map/lib/... -
01:47 AM Bug #16743: problem with multi threading [BUG] Segmentation fault
- > already tested with different versions of ruby
which versions? does it include 2.5? - 03:57 AM Revision 293c6d9b (git): [rubygems/rubygems] Remove deprecated + broken rubygems/source_local.
- It has been deprecated for 3 years, and has been broken for that entire
period. (It required itself, instead of `rubygems/source/local`.)
Closes #3158.
https://github.com/rubygems/rubygems/commit/2f01a272d0 -
03:54 AM Revision 9d5e7d6c (git): [rubygems/rubygems] Revert "Remove Gem::DependencyInstaller#find_gems_with_sources"
- This reverts commit 04c79d3eb9d9803d9fae78575b125b325b97206e.
Final removal is postponed until next year until we find a better way to
manage deprecations.
https://github.com/rubygems/rubygems/commit/3e1cf918a5 -
- That line means that the class supports both `URI`'s and `String`'s
being passed to `initialize`. I don't see how that's related to 1.8.
https://github.com/rubygems/rubygems/commit/77aeff4515 -
- https://github.com/rubygems/rubygems/commit/84c89275b8
-
- https://github.com/rubygems/rubygems/commit/6fa0b1b679
-
- https://github.com/rubygems/rubygems/commit/9e21fe7f58
-
- https://github.com/rubygems/rubygems/commit/d45cd34a67
-
- Makes it easier to rubocop.
https://github.com/rubygems/rubygems/commit/26b31248ae -
- So it matches the style used by bundler.
https://github.com/rubygems/rubygems/commit/ab0580fd65 - 03:41 AM Revision f987302c (git): * 2020-03-30 [ci skip]
-
- Since 0c2d81dada, not all trace events are cleared during VM teardown.
This causes a crash when there is a tracepoint for
`RUBY_INTERNAL_EVENT_GC_EXIT` active during teardown.
The commit looks like a refactoring commit so I think this c... -
- As Jeremy mentioned, I have considered the changeset as a new features for [Feature #5180].
I will fill Backport field. -
- ruby_2_6 r67858 merged revision(s) 4c019f5a626523e99e2827ed917802e3097c380d,c3584dfacce4d0f2058d8403de6fdce4fd4d686b.
-
- check ar_table after `#hash` call
ar_table can be converted to st_table just after `ar_do_hash()`
function which calls `#hash` method. We need to check
the representation to detect this mutation.
[Bug #16...
03/29/2020
-
- What's up guys?
Im working in a personal project. It is a MMO browser game. I'm using HTML5 for front-end and Ruby for websocket backend.
I created enemies with a simple AI who walks and defends himself. Each enemies runs on a new ... -
06:30 PM Bug #16696: 'OpenSSL 1.1.1e 17 Mar 2020' causes failure in Ruby OpenSSL stdlib
- See:
https://mta.openssl.org/pipermail/openssl-announce/2020-March/000168.html
Change will be reverted in 1.1.1f, release on 31-Mar-10 . Please close. -
- I agree that `RbConfig.windows?` seems intuitive to me, in the sense that it would or
could or should refer to the windows (Microsoft) platform.
I also concur with the explanation given.
As for `RbConfig.host_os` - I have no real prefe... -
- Also worth nothing `RUBY_PLATFORM =~ /(mswin|mingw)/` is hacky and incomplete, and there are many subtle variants of that check such as `RUBY_PLATFORM =~ /win32|mingw|bccwin|cygwin/`.
`RbConfig.windows?` would be far more reliable and e... -
- I think adding these two methods would greatly clarify platform checks:
```ruby
RbConfig.windows? # obvious, much clearer than RUBY_PLATFORM =~ /(mswin|mingw)/
RbConfig.host_os # same as RbConfig::CONFIG['host_os'], but much shorter
... -
- * [Feature #16742] `RbConfig.windows?` and `RbConfig.host_os` (eregon)
* Thoughts? Should we add them? -
- * [Bug #14541] Class variables have broken semantics, let's fix them (jeremyevans0)
* Is it OK to commit pull request to turn class variable warnings into RuntimeErrors? -
- It was moved from defs/gmake.mk at 88f4ebac83a, for use in
dependency rule lines. -
- I'm curious for what purpose you need to escape paths.
To pass it to another program, it is better to `spawn` or `system` with split array.
-
- I agree with @znz. IMO, a gem named `cmdwords` or something would be a good start for the feature instead of directly extending `shellwords`.
-
- I think adding `Shellwords.cmdescape` is better than changing `Shellwords.shellescape`.
Some environments on Windows support both bash and cmd. -
- `time_with_zone.zone.should == (time_with_zone - 60*60).zone` fails when
the time is immediately before the change of summer time.
https://rubyci.org/logs/rubyci.s3.amazonaws.com/unstable11s/ruby-master/log/20200328T232504Z.fail.html.gz... -
03/28/2020
-
- CI of 5806c54447439f2ba22892e4045e78dd80f96f0c did not succeed
https://travis-ci.org/github/ruby/ruby/jobs/668072714 -
- 07:45 PM Revision addf43d7 (git): * 2020-03-29 [ci skip]
-
- https://github.com/ruby/irb/commit/dc59afe4f6
-
06:16 PM Feature #16741 (Open): Implement Shellwords.shellescape correctly for Windows
- `shellwords` module was originally designed and developed for *NIX, and currently works like this:
```ruby
require 'shellwords'
Shellwords.shellescape("/home/me/test with space.txt")
# => "/home/me/test\\ with\\ space.txt"
She... -
-
-
- * Since the spec might not spend any time in system calls.
-
-
- * Otherwise it might segfault, since C has no idea of the type of varargs,
and the C code must assume all varargs are VALUE. -
- * Almost all platforms return incorrect values for Process.clock_getres,
it should be removed: https://bugs.ruby-lang.org/issues/16740 -
- In #16740 I propose to remove this API because it almost always returns incorrect and useless values.
-
- clock_getres(2) is incorrect (doesn't match the actual resolution for many clocks), buggy (e.g. can return negative values) on almost all platforms and for almost all clock_id.
This is an observation based running specs for it:
https... -
- * It segfaults on MRI.
-
- https://github.com/ruby/ruby/runs/541455267
```
1)
RbConfig::CONFIG libdir/LIBRUBY_SO is the path to libruby and it exists if and only if ENABLE_SHARED FAILED
Expected File.exist? "d:/Ruby26-x64/lib/x64-msvcrt-ruby260.dll"
to be truthy b... -
- As the currently released/snapshot tarballs should contain the
bundled gems extracted already, RUNRUBY is not required when
building from them with GNU make. -
-
-
- I think the wrong terminating argument cannot work.
To stop the noisy CI failures, the spec is tentatively suspended.
03/27/2020
-
-
-
- ruby-lang.org no longer has a DNS A record. And https://www.ruby-lang.org now has a valid SSL certificate. So I think this can be closed.
-
- matz (Yukihiro Matsumoto) wrote in #note-8:
> Although the use of class variables is not recommended (like global variables), proposed behavior changes introduce huge incompatibility.
> ...
I've submitted a pull request to convert the ... - 09:14 PM Revision ecf874ed (git): * 2020-03-28 [ci skip]
-
- ruby_2_7 5ccf57f23eb7a35ac699edc2fc598c47fa1844a0.
-
- (cherry picked from commit 501f2c44e6ae79c02a5c4d0f872fc7fa77258fcf)
-
- (cherry picked from commit c8d0bf0156878df03a71fffc97c44abf7333d5d7)
-
-
- Applied in changeset commit:git|e1e4ea8fa91a0c62dea69977d989d0bb2b526b64.
----------
Set external encoding correctly for File.open('f', FILE::BINARY) on Windows
Previously, the external encoding was only set correctly for
File::BINARY ... -
- I agree with @nobu that this isn't a bug on !Windows. The documentation for `File::Constants::BINARY` states "disable line code conversion", nothing about setting binary mode. I guess the constant name is a bit misleading, but due to b...
- 06:31 PM Revision d214c188 (git): * 2020-03-28 [ci skip]
-
- Previously, the external encoding was only set correctly for
File::BINARY if keyword arguments were provided. This copies
the logic for the keyword arguments case to the no keyword
arguments case. Possibly it should be refactored into ... -
- commit:54072e329cab7207fba133caba4fc12b45add8f9 was added as a feature in Ruby 2.7, and we only backport bug fixes to released versions, not features. You will have to upgrade to Ruby 2.7 if you would like this to work, using the new `:...
-
-
- This is the related commit for backporting: commit:67bb95936d241bd452f3bcfb76276e0ab61234f0.
Note that Ruby 2.5 will be moving from the normal maintenance phase to the security maintenance phase in about 4 days. -
- https://github.com/ruby/reline/commit/f4eac8c76f
-
- The test seems to fail sometimes due to a warning message of circular
require on very slow machine.
```
1) Failure:
TestDigest::TestDigestParen#test_race_mixed [/export/home/rubyci/unstable10s/tmp/build/20200326T091911Z/ruby/test/dige... -
- (cherry picked from commit 65dd50fc25f6522536d5c4749055384bde1f9371)
-
- (cherry picked from commit f5c904c2a907013e22ff74bc3686952c5448d493)
-
05:57 AM Revision 93aaa0bc (git): Allow trailing comma in hash pattern
- (cherry picked from commit d25a4f413dce6ad3a8baaf61591415b9a8cce082)
-
- As `RbConfig.expand` modifies the argument and involved `CONFIG`
values, its values should be mutable.
(cherry picked from commit 4adb2d655dcd54b28366b4d17e86b21e2b622cd1) -
-
03:33 AM Revision 39c965f2 (git): [ci skip] Doc-only enhancements for Hash
- About the defalut values.
-
- The ff98931dac is the fix for 23444302d9 and the 23444302d9 have not been backported into ruby_2_6 branch. 23444302d9 seems a kind of performance improvement.
I will restore Backport field to 2.6: DONE. -
- I created the patch for ruby_2_6 branch (attatched file).
But the test_ar2st failed.
```
1) Failure:
TestHash#test_ar2st [/Users/nagachika/opt/ruby-2.6/src/ruby_2_6/test/ruby/test_hash.rb:1749]:
<"{0=>0, 1=>1, 2=>2, 3=>3, 4=>4...
03/26/2020
- 05:14 PM Revision 18aff426 (git): * 2020-03-27 [ci skip]
-
05:14 PM Revision 0d5db771 (git): Fix AppVeyor pull request CI (#2983)
-
- ruby_2_7 ab6f78bc926f6fc12dc8d7846056fc9c04d63ead.
-
- ruby_2_7 95c3bb6c426a11253644a86137bb67c542fd5799.
- 02:51 PM Revision 572021c6 (git): * 2020-03-26 [ci skip]
-
- ruby_2_7 2a3027b7b54a3118731f70c9e88aabbd495bb9fe.
-
- "test_close_after_socket_close" checks if ssl.close is no-op even after
the wrapped socket is closed. The test itself is fair, but the other
endpoint that is reading the SSL connection may fail with SSLError:
"SSL_read: unexpected eof w... -
- RHASH_AR_TABLE_SIZE() has assertion that it is a ar_talbe.
The last commit breaks this assumption so check ar_table first.
(cherry picked from commit c3584dfacce4d0f2058d8403de6fdce4fd4d686b) -
- ar_table can be converted to st_table just after `ar_do_hash()`
function which calls `#hash` method. We need to check
the representation to detect this mutation.
[Bug #16676]
(cherry picked from commit 4c019f5a626523e99e2827ed917802e309... -
- RB_NOGVL_UBF_ASYNC_SAFE is wrongly specified because flags
is not checked.
[Bug #15499] 23444302
(cherry picked from commit ff98931daca1265e5bd33025d160c77e452c399e) -
- 21994b7fd686f263544fcac1616ecf3189fb78b3 removed the write barrier that
was present in rb_hash_aset(). Re-insert it to not crash during GC.
[Bug #16689]
(cherry picked from commit 713dc619f5372a645b66bef9dacee217c4101cb4) -
- (cherry picked from commit 8a6ba10f9dd456cf54de800203cf04bbe42271fb)
-
- Mainly for pry compatibility in test
https://github.com/k-tsj/power_assert/commit/dcc14cbef48d9790187fa400a5df7531d81a5971
Also include "Show full_message if available"
https://github.com/k-tsj/power_assert/commit/53ce0400bf47f722830d66... -
- 09:06 AM Revision b0b6d0a6 (git): * remove trailing spaces. [ci skip]
-
- https://github.com/ruby/uri/commit/1bcb1203ad
- 09:06 AM Revision 5e9e1629 (git): [ruby/uri] Remove revision lines from comments
- https://github.com/ruby/uri/commit/f1c133a7d6
- 09:06 AM Revision 92a238a2 (git): [ruby/uri] Add support for WebSockets
- https://github.com/ruby/uri/commit/805a95786a
- 09:06 AM Revision 844ff7ea (git): [ruby/uri] Simplify construction of URI instances using parser interface.
- https://github.com/ruby/uri/commit/c145017dd7
-
- So that we don't need to search the LOAD_PATH, given that we know which
files we want to load in advance.
https://github.com/ruby/uri/commit/cbecefb788 -
- https://github.com/ruby/reline/commit/623dffdd75
-
- https://github.com/ruby/reline/commit/2a8061daec
-
- https://github.com/ruby/reline/commit/b0f32f5de4
-
- https://github.com/ruby/reline/commit/f092519525
-
- https://github.com/ruby/reline/commit/bce7e7562b
-
- https://github.com/ruby/reline/commit/962ebf5a1b
-
- https://github.com/ruby/irb/commit/13572d8cdc
-
- The old implementation performance test code:
require 'objspace'
puts "%.5g MB" % (ObjectSpace.memsize_of_all * 0.001 * 0.001)
/\A.*\Z/ !~ ('abc' * 20_000_000)
puts "%.5g MB" % (ObjectSpace.memsize_of_all * 0.001 * 0.001... -
- https://github.com/ruby/irb/commit/0a641a69b0
-
- To fix this properly, we'd need to configure timeout for the server and
the client because waiting for compilation takes time.
Until we figure out how to do it, let me skip this.