Activity
From 03/13/2020 to 03/19/2020
03/19/2020
-
11:33 PM Misc #16693: DevelopersMeeting20200410Japan
- * [Feature #15921] R-assign (rightward-assignment) operator
* Curious to hear from matz about this. I think this feature is convenient in the REPL and can improve readability in real code if used well. -
09:18 PM Feature #16699 (Feedback): Silence/ignore particular warnings from some parts of the code (in a .rb file)
- `Warning.warn` added in ruby 2.4 offers the core infrastructure that allows this. The warning gem (https://rubygems.org/gems/warning) offers a nice API to support the filtering of such warnings, assuming they are correctly prefixed by t...
-
08:54 PM Feature #16699 (Feedback): Silence/ignore particular warnings from some parts of the code (in a .rb file)
- I would like to make it possible to briefly enable or disable particular warnings: those related to modifying a constant or a method.
It is possible to silence a specific warning as in:
SOME_CONSTANT = 42
old_verbose_value... -
05:40 PM Bug #16698 (Closed): Backport security fix for CVE-2020-10663
- As announced at https://www.ruby-lang.org/en/news/2020/03/19/json-dos-cve-2020-10663/, you can upgrade the JSON gem to 2.3.0 to work around the security issue. However, that brings in new features and not just the security fix. The sec...
-
12:55 PM Bug #16139: setinstancevariable on MJIT may not check frozen flag
- ruby_2_6 r67846 merged revision(s) c14b67b2a8cf60b37cfb221d8b97c6eb91833522.
-
04:45 AM Bug #16139: setinstancevariable on MJIT may not check frozen flag
- > As my previous comment https://bugs.ruby-lang.org/issues/16139#note-1 says:
Ah! I overlooked it.
Thank you! -
03:38 AM Bug #16139: setinstancevariable on MJIT may not check frozen flag
- As my previous comment https://bugs.ruby-lang.org/issues/16139#note-1 says:
> Note for backporter:
> ...
Changing it to `successes_count: 1` seems fine. -
12:55 PM Revision 4ab2353d (git): merge revision(s) c14b67b2a8cf60b37cfb221d8b97c6eb91833522: [Backport #16139]
- Check frozen flag on MJIT setinstancevariable
It does not seem to have a significant performance impact, hopefully?
```
$ benchmark-driver -v benchmark.yml --rbenv 'before --jit;after --jit' --repeat-count=24 --... -
11:56 AM Feature #16697 (Rejected): Hash.ruby2_keywords_hash?(value) should support any object
- But currently it raises, which makes it needlessly inconvenient to use:
```ruby
> Hash.ruby2_keywords_hash?({})
=> false
> ...
Traceback (most recent call last):
5: from /home/eregon/.rubies/ruby-trunk/bin/irb:23:in `<main>'... -
09:11 AM Revision 7cc7627c (git): Fix typos [ci skip]
-
07:25 AM Bug #16694: JIT vs hardened GCC with PCH
- k0kubun (Takashi Kokubun) wrote in #note-2:
> > I worry that with disabled PCH, the Ruby performance with JIT will be even worser without JIT.
> ...
But how about performance? It has to lead to slower compilation (at least the second t... -
03:44 AM Bug #16694: JIT vs hardened GCC with PCH
- > As it turns out, this is because GCC in RHEL is fully hardened. Unfortunately, due to GCC design, when GCC is fully hardened, it cannot properly handle PCH due to memory address relocation.
> ...
Good to know, thanks for sharing it.
... -
04:46 AM Bug #16695: Stack consistency error when using the return value
- Thank you for the interesting report.
I confirmed that this has existed since 1.9.1 at least, by wrapping in a method.
```
$ ruby1.9 -e 'def f;x = false; y = (return until x unless x);end;f'
-e:1: [BUG] Stack consistency error (sp:... -
04:25 AM Revision b6833ff5 (git): Get rid of redefinition of `rb_execution_context_t`
- Regardless of the order to include "vm_core.h" and "builtin.h".
-
02:53 AM Bug #16696: 'OpenSSL 1.1.1e 17 Mar 2020' causes failure in Ruby OpenSSL stdlib
- Any Windows RubyInstaller builds that contain OpenSSL stdlib 2.1.0 or later are built with OpenSSL 1.1.1. They are also built with a current set of MSYS2/MinGW packages. The current MSYS2/MinGW OpenSSL package is 1.1.1e.
Hence, back... -
02:21 AM Bug #16696 (Closed): 'OpenSSL 1.1.1e 17 Mar 2020' causes failure in Ruby OpenSSL stdlib
- Failure first appeared in ruby-loco MinGW build, also repo'd using OpenSSL CI testing on Ubuntu Ruby 2.7.0.
See:
https://github.com/ruby/openssl/runs/517945310#step:7:529
and MinGW build here:
https://github.com/ruby/ruby/runs/51... -
01:48 AM Revision eeb178dc (git): .travis.yml: allow arm64-linux to fail
- Ditto for a833eb29f7eaced61919b7ed19e830a3905e8a8b
-
01:38 AM Revision 79b4aca9 (git): Ignore TestJITDebug in mswin RubyCI for now
- It's still pending to be implemented. To be enabled later when it's
implemented. -
01:27 AM Bug #12706: Hash#each yields inconsistent number of args
- Does this cause any issue in practice?
AFAIK it's not worth the incompatibility and could break many things.
We had to follow MRI behavior here for Hash#each and Hash#map in TruffleRuby, e.g., https://github.com/oracle/truffleruby/is... - 01:26 AM Revision 4eeeb110 (git): * 2020-03-19 [ci skip]
-
01:20 AM Revision a833eb29 (git): .travis.yml: allow arm32-linux to fail
- It seems fragile now, seemingly due to environmental issues. Lets allow
it to fail for a while. Reported by Jun Agura <jaruga@redhat.com>
[ruby-core:97540] -
01:17 AM Bug #16466: `*args -> *args` delegation should be warned when the last hash has a `ruby2_keywords` flag
- matz (Yukihiro Matsumoto) wrote in #note-3:
> this makes warn-hunting (especially for Rails core contributors) more difficult.
Can you explain that?
AFAIK this will make code use `ruby2_keywords` in more places, but those places wil... -
01:13 AM Bug #16466: `*args -> *args` delegation should be warned when the last hash has a `ruby2_keywords` flag
- This means adding `ruby2_keywords` is not only cumbersome and difficult, but it's also not sufficient as a reminder of which methods to update in Ruby 3+.
This is an implementation detail leak, and I think it makes no sense for other ... -
01:04 AM Feature #16175: Object#clone(freeze: true) is inconsistent with Object#clone(freeze: false)
- To clarify I'm not against the PR, but it seems a very niche use-case to me with no real-world example, and IMHO the documentation was clear enough.
I think #clone is about copying state, not about changing other aspects like freezing w... -
12:57 AM Feature #16175: Object#clone(freeze: true) is inconsistent with Object#clone(freeze: false)
- I'm confused, I thought `clone(freeze: true)` would be the same as `clone()`, i.e., freeze the cloned object only if the original object was frozen.
I don't think it's good to make #clone also #freeze if the original object was not fr...
03/18/2020
-
12:32 PM Bug #16139: setinstancevariable on MJIT may not check frozen flag
- I'd like to backport c14b67b2a8cf60b37cfb221d8b97c6eb91833522 into ruby_2_6 branch, but I got the following test failure with the changeset.
```
1) Failure:
TestJIT#test_inlined_setivar_frozen [/Users/nagachika/opt/ruby-2.6/src/ruby_2... -
11:59 AM Revision 0b9719f6 (git): merge revision(s) ee1334189b95cb5e7785e3415b332a7a76879ac3:
- Fix uplevel
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_6@67845 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
11:28 AM Bug #16695 (Closed): Stack consistency error when using the return value
- Some versions of ruby occur `Stack consistency error` by following the reproduction code.
## Reproduction code
```ruby
x = false; y = (return until x unless x)
```
## Per versions
- 2.3.8
- `unexpected return (LocalJumpE... -
11:24 AM Bug #12392: configure --with-sitedir=no --with-sitearchdir=no --with-vendordir=no --with-vendorarchdir=no が機能しない
- ruby_2_6 r67844 merged revision(s) 8a6ba10f9dd456cf54de800203cf04bbe42271fb.
-
11:24 AM Revision d9697bbe (git): merge revision(s) 8a6ba10f9dd456cf54de800203cf04bbe42271fb: [Backport #12392]
- Do not make disabled directories at installation [Bug #12392]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_6@67844 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
08:43 AM Bug #16694 (Assigned): JIT vs hardened GCC with PCH
-
08:30 AM Bug #16694 (Closed): JIT vs hardened GCC with PCH
- Preparing Ruby package for RHEL 8, I observe the following error:
~~~
$ cd /builddir/build/BUILD/ruby-2.6.3/
$ make test-all TESTS=test/ruby/test_rubyvm_mjit.rb
Run options: "--ruby=./miniruby -I./lib -I. -I.ext/common ./tool/r... -
04:57 AM Revision afd23ed0 (git): Added link to the ticket [ci skip]
03/17/2020
- 07:10 PM Revision f4fc81fe (git): * 2020-03-18 [ci skip]
-
07:09 PM Revision d2c41b1b (git): Reduce allocations for keyword argument hashes
- Previously, passing a keyword splat to a method always allocated
a hash on the caller side, and accepting arbitrary keywords in
a method allocated a separate hash on the callee side. Passing
explicit keywords to a method that accepted a... -
07:09 PM Revision ac04b778 (git): Make {**{}} return unfrozen empty hash
- Previously, method call keyword splats and hash keyword splats
were compiled exactly the same. This is because parse-wise, they
operate on indentical nodes when it comes to compiling the **{}.
Fix this by using an ugly hack of temporar... -
05:11 PM Feature #16175: Object#clone(freeze: true) is inconsistent with Object#clone(freeze: false)
- Pull request 2954 was merged early today, so I was able to work on this. I submitted https://github.com/ruby/ruby/pull/2969 to implement it.
In the recent dev meeting notes, @akr stated `freeze: nil` should be supported, but @matz sa... -
12:41 PM Misc #16693: DevelopersMeeting20200410Japan
- * [Feature #16428] Add `Array#uniq?`, `Enumerable#uniq?` (greggzst)
* it seems to be an easier solution to check directly if an enumerable is uniq instead of using uniq with other means
* [Feature #15166] 2.5 times faster implementati... -
10:47 AM Revision 3325194a (git): Get rid of bogus warning by VC
- ```
c:\projects\ruby\mjit_worker.c(1219) : warning C4090: 'function' : different 'const' qualifiers
```
It seems confused by passing "pointer to pointer to const object",
not "pointer to const object". -
10:46 AM Revision 165e4572 (git): Check if `freeze` option is given
- 10:37 AM Revision e609fd58 (git): * 2020-03-17 [ci skip]
-
10:37 AM Revision 290d6086 (git): support builtin for Kernel#clone
03/16/2020
-
08:33 PM Feature #16463: Fixing *args-delegation in Ruby 2.7: ruby2_keywords semantics by default in 2.7.1
- Thanks for explaining your thoughts in details.
> The last reason is the migration path. Currently (some) Rails core contributors use the recent master (which raises errors instead of warnings) to detect/fix keyword argument warnings.... -
05:45 PM Feature #16463: Fixing *args-delegation in Ruby 2.7: ruby2_keywords semantics by default in 2.7.1
- Benoit, thank you for your efforts on this issue. Too bad about the result but it was worth the shot. Considering matz chose to cancel the deprecation of the flip-flop operator for the sake of compatibility, I'm surprised that for keywor...
-
02:58 AM Feature #16463 (Closed): Fixing *args-delegation in Ruby 2.7: ruby2_keywords semantics by default in 2.7.1
-
02:58 AM Feature #16463: Fixing *args-delegation in Ruby 2.7: ruby2_keywords semantics by default in 2.7.1
- I have investigated this proposal for a long time and concluded we cannot accept the proposal.
The first reason is the impact of the change. Although it works for most of the delegation cases, it also changes the behavior of all rest ... -
04:37 PM Bug #16682: Ruby 2.7.0p0 crash on exit if there is an active RUBY_INTERNAL_EVENT_GC_EXIT tracepoint
- Posting here in case it gets lost. This issue is unrelated to #16689.
I have a patch for this issue at https://github.com/ruby/ruby/pull/2959. -
04:36 AM Bug #16682 (Assigned): Ruby 2.7.0p0 crash on exit if there is an active RUBY_INTERNAL_EVENT_GC_EXIT tracepoint
-
04:32 PM Feature #16175: Object#clone(freeze: true) is inconsistent with Object#clone(freeze: false)
- I'll work on implementing this after https://github.com/ruby/ruby/pull/2954 is merged or closed, as I don't want to cause conflicts for that pull request.
-
04:16 AM Feature #16175: Object#clone(freeze: true) is inconsistent with Object#clone(freeze: false)
- I accept the proposal. As @jeremyevans0 stated, it's slightly backward-incompatible but trivial.
Matz. -
04:29 PM Bug #16519: pp [Hash.ruby2_keywords_hash({})] shows `[nil]`
- jeremyevans0 (Jeremy Evans) wrote in #note-19:
> Eregon (Benoit Daloze) wrote in #note-18:
> ...
Pull requested submitted: https://github.com/ruby/ruby/pull/2966
Things need to be handled differently in 2.7 as 2.7 will do empty keyw... -
02:59 PM Misc #16693 (Closed): DevelopersMeeting20200410Japan
- # The next dev meeting
**Date: 2020/04/10 13:00-17:00**
Place/Sign-up/Agenda/Log: https://docs.google.com/document/d/1Gcs38tvI6_dQ5sgy8CNUIVZbt0c_y_Z2GrCAoDwh5wg/edit#
- Dev meeting *IS NOT* a decision-making place. All decisions ... -
02:58 PM Misc #16661 (Closed): DevelopersMeeting20200316Japan
-
02:38 PM Bug #12671 (Closed): Hash#to_proc result is not a lambda, but enforces arity
- Applied in changeset commit:git|d514ba8e17106c6d159c3902ac5456d6269731f8.
----------
`Proc` made by `Hash#to_proc` should be a lambda [Bug #12671]
Like `Symbol#to_proc` (f0b815dc670b61eba1daaa67a8613ac431d32b16) -
01:45 PM Bug #12671: Hash#to_proc result is not a lambda, but enforces arity
- This ticket was briefly discussed at today's dev meeting, and matz said that the result of Hash#to_proc should be a lambda.
-
02:38 PM Revision d514ba8e (git): `Proc` made by `Hash#to_proc` should be a lambda [Bug #12671]
- Like `Symbol#to_proc` (f0b815dc670b61eba1daaa67a8613ac431d32b16)
-
02:30 PM Revision 304538e6 (git): Fix typos [ci skip]
-
02:17 PM Bug #12706 (Closed): Hash#each yields inconsistent number of args
- Applied in changeset commit:git|47141797bed55eb10932c9a722a5132f50d4f3d8.
----------
hash.c: Do not use the fast path (rb_yield_values) for lambda blocks
As a semantics, Hash#each yields a 2-element array (pairs of keys and
values). S... -
08:30 AM Bug #12706: Hash#each yields inconsistent number of args
- It was caused by the optimization introduced in 2.1. It should check if a block is a lambda before making optimization.
We worry about compatibility but let's fix it in 2.8(3.0) and see it can cause problems. Please mark the change as *... -
02:17 PM Revision 47141797 (git): hash.c: Do not use the fast path (rb_yield_values) for lambda blocks
- As a semantics, Hash#each yields a 2-element array (pairs of keys and
values). So, `{ a: 1 }.each(&->(k, v) { })` should raise an exception
due to lambda's arity check.
However, the optimization that avoids Array allocation by using
rb_... -
01:07 PM Bug #16689: [BUG] try to mark T_NONE object
- I tested the patch against our CI and can confirm it does fix the problem.
-
10:28 AM Revision 4be2a891 (git): The upstream repository of bundler was changed rubygems/rubygems now.
- https://github.com/rubygems/rubygems/pull/3166
-
09:07 AM Bug #16692: net/http SNI not RFC 6066 compliant & wrong certificate hit
- Seems [https://github.com/ruby/ruby/commit/54072e329cab7207fba133caba4fc12b45add8f9](this 2.7 patch) fix the problem.
Would be interesting to backport it to 2.6. -
08:56 AM Bug #12547: Remove ONIG_UNICODE_VERSION_... in enc/unicode/case-folding.rb, casefold.h
- These macros are to ensure that Unicode data files and the header/source files are for the same version.
You won't see them unless something went wrong. -
08:49 AM Bug #12392 (Closed): configure --with-sitedir=no --with-sitearchdir=no --with-vendordir=no --with-vendorarchdir=no が機能しない
- Applied in changeset commit:git|8a6ba10f9dd456cf54de800203cf04bbe42271fb.
----------
Do not make disabled directories at installation [Bug #12392] -
08:29 AM Bug #12780: BigDecimal#round returns different types depending on argument
- `#round` with the argument less than 1 (`n < 1`) should return `Integer` value.
Matz.
-
08:26 AM Revision 8a6ba10f (git): Do not make disabled directories at installation [Bug #12392]
-
08:12 AM Bug #12666 (Feedback): Fatal error: glibc detected an invalid stdio handle
- Sorry for a late reply, but I think we have touched this area since you reported. Does this still happen?
-
08:10 AM Bug #12551 (Open): Exception accessing file with long path on windows
- As Python can do it, we know it is theoretically possible. But the priority is low for us, core developers. If someone sends us a pull-request, we'd be happy to review.
Matz.
-
08:08 AM Bug #12599 (Rejected): For CLang, increase inline-threshold to get 7%-10% speedup of optcarrot
- Af I wrote above, inlining should be handled in fine grained way.
-
08:02 AM Bug #12548 (Closed): Rounding modes inconsistency between round versus sprintf
- It is inconsistent but fixing either way could cause problems. I vote for keeping as it is.
Matz.
-
07:40 AM Bug #12368 (Rejected): default encoding of Integer#chr
- ユースケースが失念されたってことで一旦閉じることに。
-
04:49 AM Bug #16466 (Closed): `*args -> *args` delegation should be warned when the last hash has a `ruby2_keywords` flag
- For the sake of consistency and completeness, this is required, but this makes warn-hunting (especially for Rails core contributors) more difficult.
So I vote for keeping this behavior.
Matz. -
04:37 AM Bug #16497 (Assigned): StringIO#internal_encoding is broken (more severely in 2.7)
-
02:06 AM Revision 0f2f07a9 (git): Adjusted indents [ci skip]
-
02:01 AM Revision ad10760b (git): proc.c: Remove non-sense /* fall through */
03/15/2020
-
11:04 PM Bug #16692 (Closed): net/http SNI not RFC 6066 compliant & wrong certificate hit
- Hi,
Currently, net/http set the SNI to the address you want to connect to.
https://github.com/ruby/ruby/blob/master/lib/net/http.rb#L1025-L1026
This is maybe a wrong assumption because you can want to connect to a specific IP addr... -
10:12 PM Bug #16689 (Closed): [BUG] try to mark T_NONE object
- Applied in changeset commit:git|713dc619f5372a645b66bef9dacee217c4101cb4.
----------
Add missing write barrier for Hash#transform_values{,!}
21994b7fd686f263544fcac1616ecf3189fb78b3 removed the write barrier that
was present in rb_hash... - 10:12 PM Revision 4ea83569 (git): * 2020-03-16 [ci skip]
-
10:11 PM Revision 713dc619 (git): Add missing write barrier for Hash#transform_values{,!}
- 21994b7fd686f263544fcac1616ecf3189fb78b3 removed the write barrier that
was present in rb_hash_aset(). Re-insert it to not crash during GC.
[Bug #16689] -
09:15 PM Bug #16519: pp [Hash.ruby2_keywords_hash({})] shows `[nil]`
- Eregon (Benoit Daloze) wrote in #note-18:
> @jeremyevans0 Could you take a look for the 2.7 backport?
Sure, I'll take a look tomorrow and see if I can fix it locally and submit a pull request for the ruby_2_7 branch. -
04:09 PM Bug #16519: pp [Hash.ruby2_keywords_hash({})] shows `[nil]`
- @jeremyevans0 Could you take a look for the 2.7 backport?
-
12:04 PM Bug #16519: pp [Hash.ruby2_keywords_hash({})] shows `[nil]`
- ```
1) Failure:
PPTestModule::PPCycleTest#test_hash [/Users/naruse/work/ruby_2_7/test/test_pp.rb:133]:
<"{0=>{...}}\n"> expected but was
<"{[0, {...}]=>{}}\n">.
2) Failure:
PPTestModule::PPSingleLineTest#test_hash [/Users/nar... -
05:27 PM Bug #16497: StringIO#internal_encoding is broken (more severely in 2.7)
- @naruse one of my two "weird" cases is not fixed yet:
```ruby
def test(io)
str = io.read
[io.external_encoding, io.internal_encoding, str, str.encoding]
end
str = 'Україна'.encode('KOI8-U')
test(StringIO.new(str, 'r:KOI8... -
01:07 PM Bug #16497: StringIO#internal_encoding is broken (more severely in 2.7)
- ruby_2_7 47b08728cf3d0441a3da4dc1dcdd578817b0e036.
-
09:44 AM Bug #16497 (Closed): StringIO#internal_encoding is broken (more severely in 2.7)
- Applied in changeset commit:git|e257c08f2ec27e2d66cdfa7e2415deb492522e22.
----------
[ruby/stringio] StringIO#initialize default to the source string encoding
[Bug #16497]
https://github.com/ruby/stringio/commit/4958a5ccab -
05:20 PM Feature #12919 (Rejected): Net::FTP does not have a default open_timeout
- Looks not a bug. And there is no discussion from OP for three years. Closing the ticket.
-
04:43 PM Bug #12564 (Closed): Sometimes test_settracefunc.rb segfaults in exec_hooks_body (vm_trace.c)
- I'm monitoring rubyci results about one year, but I have not seen this error. I guess this is fixed. If you still see this error, let me know.
-
03:37 PM Feature #16665: Add an Array#except_index method
- alex_golubenko (Alex Golubenko) wrote in #note-10:
> I also heard from developers, that they faced tricky challenges where this method could help. :)
Then it would be really nice if you could show these tricky challenges here; that w... -
01:21 PM Revision f14409c9 (git): Enclosed version constant
-
01:15 PM Revision 1ad9b231 (git): Added guard against [Bug #16497]
-
01:13 PM Revision a8ced388 (git): [ruby/stringio] Bump version to 0.1.1
- https://github.com/ruby/stringio/commit/05d75e5e66
-
11:53 AM Revision 47b08728 (git): [ruby/stringio] StringIO#initialize default to the source string encoding
- [Bug #16497]
https://github.com/ruby/stringio/commit/4958a5ccab
(cherry picked from commit e257c08f2ec27e2d66cdfa7e2415deb492522e22) -
11:52 AM Revision 3efbd527 (git): Do not autosplat when calling proc with empty keyword splat
- With the removal of the splatted argument when using an empty
keyword splat, the autosplat code considered an empty keyword
splat the same as no argument at all. However, that results
in autosplat behavior changing dependent on the cont... -
11:45 AM Bug #16560: Proc autosplats first argument if called with one argument and empty keyword splat
- ruby_2_7 e74d2a42b274844ed020ed121ee2f11c626c5fec.
- 10:35 AM Revision c858a10c (git): * 2020-03-15 [ci skip]
-
10:35 AM Revision a36ead3f (git): Prevent unloading methods used in root_fiber while calling another Fiber (#2939)
- Fixing SEGVs like:
http://ci.rvm.jp/results/trunk-mjit-wait@silicon-docker/2744905
http://ci.rvm.jp/results/trunk-mjit-wait@silicon-docker/2744420
http://ci.rvm.jp/results/trunk-mjit-wait@silicon-docker/2741400
[Bug #16664]
(cherry pick... -
10:35 AM Revision 17e925b9 (git): Avoid infinite loop on --jit-wait
- (cherry picked from commit a8dcab723316997d9e01c89d6df969edce75bdca)
-
10:35 AM Revision c6944377 (git): Fix SimpleDelegator respond_to? regression
- In 2.6, SimpleDelegator would always use the target `respond_to?`
In 2.7.0 it doesn't if the target does not inherit from Object.
This breaks compatibility for delegated objects that inherit
from BasicObject and redefine `respond_to?`.... -
10:35 AM Revision d07a6dc1 (git): delegate.rb: fixed keyword arguments in DelegateClass
- `Delegator.delegating_block` should delegate keyword arguments
separately. [ruby-core:96949]
(cherry picked from commit 9bcf4f3db26249772c983896ebbc9ff41f4614db) -
10:35 AM Revision e70d52b0 (git): Make ruby2_keywords methods correctly handle **{} optimization
- Previously, this code:
ruby2_keywords def foo(*a) a.last end
foo(**{})
Returned an empty frozen hash. However, the final hash should
not be frozen in this case, as it wouldn't be if foo accepted
a keyword splat.
Use a new unfroze... -
10:35 AM Bug #16606: SimpleDelegator no longer call respond_to? on the delegated object if it's a BasicObject
- ruby_2_7 771a5b1a0cbf69531060330340a000704be71239.
-
10:30 AM Bug #16664: Backport request: MJIT unloads methods used in a main thread when calling a Fiber
- ruby_2_7 f915d4ff33450975cc3a7a70d0dc4dd2bf4cfed1.
-
09:43 AM Revision e257c08f (git): [ruby/stringio] StringIO#initialize default to the source string encoding
- [Bug #16497]
https://github.com/ruby/stringio/commit/4958a5ccab -
09:25 AM Revision d79890cb (git): Avoid doubly showing debug counters
- when RubyVM.show_debug_counters is explicitly called.
According to the original description in 70fd099220446e39bb80eb0bb32870ce12134619,
I think it's not intended to use the exit counter at all, and I'd like
to skip it when I need to ex... -
07:24 AM Revision f6a54e6e (git): Add debug counter for unload_units
- changing add_iseq_to_process's debug counter name as well for comparison
-
04:59 AM Bug #16677: Negative integer powered (**) to a float number results in a complex
- The most confusing part of the current behaviour is that (it superficially looks like) the precedence relation between the three operations (i) `-`, (ii) typical method call (using a period), and (iii) `**` does not follow transitivity, ...
-
03:02 AM Bug #16677: Negative integer powered (**) to a float number results in a complex
- @matz,
I find your statement a bit confusing. You vote for "keeping precedence" but the entire point of this bug report is that `-2.to_i ** 2.2` does _not_ respect the precedence rules. For example `-2.to_s` results in "-2" rather than f... -
04:13 AM Revision 67fbc122 (git): Resurrect test_jit_debug.rb
- Revert "Temporarily drop test_jit_debug.rb"
This reverts commit 5437d7c879585fbdb0c294298eb76cc563e01c69.
Skipped some CIs which were failing previously. -
04:02 AM Revision 6e405b26 (git): Use a human-readable funcname with --jit-debug
- for perf output like:
Samples: 100K of event 'cycles:ppp', Event count (approx.): 1007750000
Children Self Command Shared Object Symbol
+ 81.58% 1.47% ruby ruby [.] rb_vm_exec
+ 81.... -
03:51 AM Revision deb1c7b9 (git): Revert "Use a human-readable funcname with --jit-debug"
- This reverts commit cecebf55c476ae936f3e880477dfb62149143c46.
debugging test failure... - 03:43 AM Revision 71f6f46b (git): * 2020-03-15 [ci skip]
-
03:42 AM Revision cecebf55 (git): Use a human-readable funcname with --jit-debug
- for perf output like:
Samples: 100K of event 'cycles:ppp', Event count (approx.): 1007750000
Children Self Command Shared Object Symbol
+ 81.58% 1.47% ruby ruby [.] rb_vm_exec
+ 81....
03/14/2020
-
11:46 AM Misc #16661: DevelopersMeeting20200316Japan
- Sorry to miss the deadline as well, I only noticed now the update on #16463 since there was no comment there.
-
11:46 AM Misc #16661: DevelopersMeeting20200316Japan
- * [Bug #16466] `*args -> *args` delegation should be warned when the last hash has a `ruby2_keywords` flag (eregon)
* Since it seems #16463 will be rejected, it's needed to fix this to not make migration to Ruby 3 worse. -
11:43 AM Bug #16466: `*args -> *args` delegation should be warned when the last hash has a `ruby2_keywords` flag
- What about this ticket?
Such code will simply break in Ruby 3 if we don't warn so I don't think there is much of a choice here.
It should be in 2.7.1 too as it's a fix of a missing warning necessary to migrate to Ruby 3. -
11:32 AM Feature #16463: Fixing *args-delegation in Ruby 2.7: ruby2_keywords semantics by default in 2.7.1
- From the [meeting log](https://docs.google.com/document/d/1IqCMl27w7KYeCpke6-dCfPV3TLfP2ObnDDw5TNOelsc):
Discussion:
akr: This proposal makes incompatible between 2.6 and 2.7(.1). When ruby2_keywords is not used, it should be compati... - 11:27 AM Revision b3fabedc (git): * 2020-03-14 [ci skip]
-
11:24 AM Bug #16642: Splatted empty hash literal produces frozen hash object
- ruby_2_7 commit:7804720c631d309b2f19457e703ecfb47a59589f.
-
11:21 AM Bug #16519: pp [Hash.ruby2_keywords_hash({})] shows `[nil]`
- What's the failure?
-
06:39 AM Bug #16519: pp [Hash.ruby2_keywords_hash({})] shows `[nil]`
- Just merging 28d31ead34baff1c4abc0d7d902ef4bc1d576fb2 into ruby_2_7 causes test failure
-
11:19 AM Bug #16619: Error message of "x = return 1" is doubled
- ruby_2_7 eabf35a5d298c68f45dc600477fc586d7b868788.
-
11:18 AM Bug #15608: What should be the correct output for Method#inspect with singleton methods?
- ruby_2_7 0d24fb774d84d4a99454ce10fd343da00049a588.
-
11:08 AM Bug #13724: make install does not install bundled gems
- Fixed by https://github.com/ruby/ruby/pull/2951
- 09:17 AM Revision 66619455 (git): * 2020-03-14 [ci skip]
-
09:16 AM Revision 459670d4 (git): Fix bundled gems installation on a fresh clone
-
09:16 AM Revision 956e220a (git): Use new `prepare-gems` target when possible
-
07:32 AM Revision e7555d46 (git): Drop MinGW build from AppVeyor
- in favor of #2791
(cherry picked from commit b00418732c89ce42c1c4cef57d08344659fbdd2b) -
07:15 AM Revision 0d24fb77 (git): Don't display singleton class in Method#inspect unless method defined there
- Previously, if an object has a singleton class, and you call
Object#method on the object, the resulting string would include
the object's singleton class, even though the method was not
defined in the singleton class.
Change this so the... -
07:12 AM Revision eabf35a5 (git): Fixed duplicated warning
- As `command_rhs` is always a "value expression", `command_asgn`
does not need the same check. [Bug #16619]
(cherry picked from commit 6e6844320de989cb88a154e2ac75066ccea1bba2) -
07:01 AM Bug #16649: Object with [] method doesn't work as String#encode's fallback
- ruby_2_7 fa48a26d886d86469a0075d91d152252e9fc0c8c.
-
07:00 AM Revision fa48a26d (git): Fixed symbol misused as ID
- `rb_funcallv_public` and `rb_respond_to` require an `ID`, not a
`Symbol`. [Bug #16649]
(cherry picked from commit 8b6e2685a4b7c7de905f7ed60c02ef85e0724754) -
12:30 AM Bug #16689: [BUG] try to mark T_NONE object
- I bisected it to this commit:
```
commit 21994b7fd686f263544fcac1616ecf3189fb78b3
Avoid rehashing keys in transform_values
Previously, calling transform_values would call rb_hash_aset for each
key, needing to rehash it and look...
03/13/2020
-
08:26 PM Feature #16665: Add an Array#except_index method
- Dan0042 (Daniel DeLorme) wrote in #note-9:
> That implementation would return an empty array for `[true,nil,nil].except_index(0)`
> ...
Sure, the final implementation was:
``` ruby
def except_index(*indicies)
to_delete = Arr... -
02:30 PM Bug #16519: pp [Hash.ruby2_keywords_hash({})] shows `[nil]`
- ruby_2_7 e85d49e4a91a3ca007468a23d8568f7f886e7e5b.
-
02:28 PM Bug #16639: ARGF.each_line(chomp: true) cannot call without warning
- ruby_2_7 3e7e1b965b06f3c843972d7e2f6e3d040374d67f.
-
02:27 PM Revision 3e7e1b96 (git): Pass keyword arguments to IOs properly [Bug #16639]
- (cherry picked from commit 041c2932e336b509b0ddc1fdbd9f160bce8d4893)
-
02:27 PM Bug #16689: [BUG] try to mark T_NONE object
- The repro also crashes on a [recent master](https://github.com/ruby/ruby/commit/de15a26e9e297c9cc3171b1d40ef7776ca5838df). It looks like a hash somewhere is corrupted?
```
-- C level backtrace information --------------------------------... -
02:26 PM Bug #16634: DRb remote method call with keyword argument occurs warning message of deprecated on Ruby 2.7.0, and fails on Ruby 2.8.0dev
- ruby_2_7 2339be74e737b4c5f5330f845af2e7db0c7450e1.
-
02:26 PM Bug #16607: retried require does not raise Exception even if a library has SyntaxError
- ruby_2_7 c7e0ce67430b5e312eb626a2c2f4b6a810b3b68b.
-
02:26 PM Bug #16681: Backport commit related libffi url
- ruby_2_7 6a2d779027818eda418c9118f700b36816e833a5.
-
02:26 PM Bug #16509: puts from a thread seem to be missing linefeed when run in ruby 2.7.0 console
- ruby_2_7 60d98fad86da1ada204c53789431ac0f5f3390ff.
-
02:09 PM Misc #16661: DevelopersMeeting20200316Japan
- Sorry for adding tickets past the deadline, but I believe these 3 bugs warrant being addressed in the upcoming 2.7.1 release.
-
02:08 PM Misc #16661: DevelopersMeeting20200316Japan
- * [Bug #16689] [BUG] try to mark T_NONE object (byroot)
* Cause Ruby to crash when the heap gets past a certain size.
* Looks like a bug in GC
* This is a total blocker for us to upgrade to 2.7.x
* [Bug #16682] Ruby 2.7.0p0 cra... -
01:38 PM Revision 2339be74 (git): lib/drb/drb.rb: Use ruby2_keywords for keyword separation
- [Bug #16634]
(cherry picked from commit fb472ca7adbaceb35aae1b3a6b948720ffc9eb53) -
01:34 PM Revision c7e0ce67 (git): Add the loaded feature after no exception raised
- Retrying after rescued `require` should try to load the same
library again. [Bug #16607]
(cherry picked from commit 7d6903dc476f982e7b432adbeef3a3d9372a309f) -
01:31 PM Revision 7518b4e9 (git): fix the order of definition
-
01:27 PM Revision de15a26e (git): tool/redmine-backporter.rb: fix typo
-
01:23 PM Revision fcaa00e5 (git): Use osuosl instead of GitHub releases
- Because the package provided by GitHub releases is different from sourceware.
(cherry picked from commit 47a1872cd8b901b8aab6dedce7fa3807c97d290d) -
01:23 PM Revision 6a2d7790 (git): Switch to download libffi source package to github releases from sourceware.org
- [Bug #16681]
(cherry picked from commit 86022167461dc90b70164e2bb23316959bbfd6ba) -
01:10 PM Revision 60d98fad (git): [ruby/io-console] Set `OPOST` when `intr` is true
- To enable implementation-defined output processing, for the
compatibility with readline. [Bug #16509]
https://bugs.ruby-lang.org/issues/16509
https://github.com/ruby/io-console/commit/8c8b0b6757
(cherry picked from commit 4e56ec4ef74c... -
01:08 PM Revision 9f504bb4 (git): Separate objspace argument for rb_gc_disable and rb_gc_enable
- (cherry picked from commit aeaf0dc55595b8a5bfdd92007fb85ef13855c632)
-
12:53 PM Bug #16596: racc does not install grammar.en.rdoc
- ruby_2_7 047dfbdf69e1a300109c729c66b6a761032402dd.
-
12:53 PM Revision 047dfbdf (git): Skip empty directories to install [Bug #16596]
- (cherry picked from commit 33d02e6bc7502c5a3f09c59908a8c9f08a474b8d)
-
12:51 PM Revision 5bdbee96 (git): Squashed commit of the following: [Backport #16516]
- commit c98c492578d898dc07a04b8240d8d5b1508ffafa
Author: Nobuyoshi Nakada <nobu@ruby-lang.org>
Date: Fri Jan 17 16:56:53 2020 +0900
Added test for f38b3e8c707ebdcad05aa9485cf1760640b74fbb
commit f38b3e8c707ebdcad05aa9485cf1760640b... -
12:51 PM Revision a9284ecb (git): Disable GC until VM objects get initialized [Bug #16616]
-
12:51 PM Revision 215eb86a (git): Increase the frozen_strings table initial size
- It was set to 1000 in a4a2b9be7a55bb61d17cf9673ed0d2a93bb52d31.
However on ruby-2.7.0p0, there are much more than 1k frozen string right after boot:
```
$ ruby -robjspace -e 'p ObjectSpace.each_object(String).select { |s| s.frozen? && ... -
12:48 PM Bug #16516: [BACKPORT] AST locations with numbered parameter
- ruby_2_7 d5c84cf9769101eb14e379330e5b211a568bf020.
-
12:40 PM Bug #16514: Documentation mistake for method syntax (splat/array parameter)
- ruby_2_7 3c93ed59773ca547239850d16f06451afbb0aeec.
-
12:38 PM Bug #16616: Large RUBY_THREAD_VM_STACK_SIZE causes segmentation fault
- ruby_2_7 1ead0268811c230897f32c5dbf58511000e8d6c6.
- 12:32 PM Revision 8a54630a (git): * 2020-03-13 [ci skip]
-
12:31 PM Revision 3c93ed59 (git): Update documentation for Array/Hash Argument section of methods.rdoc
- [Bug #16514]
-
12:27 PM Bug #16486: Hash.ruby2_keywords?(hash) and Hash.ruby2_keywords!(hash)
- ruby_2_7 9820f9ee0aaccd78e6e0489e8915d3925c6ee97c.
-
12:27 PM Bug #16331: fails to build with BSD make when any -j option is given (including -j 1)
- ruby_2_7 a930174d798b58ee10493bf192d277ffe08518a7.
-
12:26 PM Bug #16624: Backport de3883e7823c89ce90d7661ef5bb3b7eb60968db
- ruby_2_7 95ab9cd8f453099d7649dc0e0eec55ea891340f5 [Backport #16624].
-
12:24 PM Bug #16598: Backport af899503 to ruby_2_7
- ruby_2_7 716e05b82338d75452e86c999ae3e5874a642ecd [Backport #16598].
-
12:23 PM Bug #16406: `(lambda_proc << normal_proc).lambda?` should return false
- ruby_2_7 52bb32d6b71365cb24273de3eed5a712206815f3 [Backport #16406].
-
12:16 PM Bug #16503: "ret: 2, hash modified during iteration" error in Ruby 2.7.0
- ruby_2_7 8e8841f6bf58031a1fe5b0dbacb5a1fb442102df.
-
09:19 AM Bug #16677 (Closed): Negative integer powered (**) to a float number results in a complex
- I vote for keeping precedence, for compatibility's sake. All other things (e.g. consistency between languages) are trivial.
Matz. -
06:34 AM Revision 88f4ebac (git): Update and extract for each gem
-
05:51 AM Revision 0cd7be99 (git): Avoid referring to an old value of realloc
- OpenBSD RubyCI has failed with SEGV since 4bcd5981e80d3e1852c8723741a0069779464128.
https://rubyci.org/logs/rubyci.s3.amazonaws.com/openbsd-current/ruby-master/log/20200312T223005Z.fail.html.gz
This was because `status->cc_entries` coul... -
05:23 AM Revision 43e18c68 (git): Mark all cc_entries associated to compiled_iseq
-
05:21 AM Revision 8562bfd1 (git): Move code to mark jit_unit's cc_entries to mjit.c
-
04:34 AM Bug #13152: Numeric parsing differences between ruby <-> crystal
- wolframalpha.com
```
-2**4 =
-16
```
```
-2^4 =
-16
```
-
01:43 AM Revision a90117c8 (git): Skip test_abort_tls with --jit-wait for now
- Perhaps the server blocks for an unexpectedly long time by waiting for
JIT. As it's usually passing, I don't think it's detecting a bug.