Activity
From 02/18/2020 to 02/24/2020
02/24/2020
-
11:38 PM Feature #16648: improve GC performance by 5% with builtin_prefetch
- I ran the patch on some included GC benchmarks in the repo and it doesn't seem to be a pure win (built-ruby is the patched version):
```
$ make benchmark ITEM=gc_ COMPARE_RUBY=/opt/rubies/2.8.0-clean/bin/ruby OPTS=-v
/opt/rubies/2.6.... -
09:41 PM Feature #16597: missing poll()
- There is a bug with handling POLLNVAL in the new code.
-
09:26 PM Bug #16642 (Closed): Splatted empty hash literal produces frozen hash object
- This was already fixed in master at commit:f8a8f055123bc81fc13fa295b936504196df0da4, which changed it so ruby2_keywords does not pass empty keyword splats as hashes. Passing empty keyword splats as hashes is not needed in Ruby 3, it is ...
-
05:10 PM Feature #16652 (Closed): Use RubyGems facilities to install Gems during Ruby installation
- Currently, `tools/rbinstall` uses quite some custom code to install gems instead of using functionality available in RubyGems. I don't think this is good, because the code is non transparent ATM and it is duplicating functionality, which...
-
02:58 PM Bug #16647 (Closed): Redefining $/ causes irb to misbehave
- It was a problem with Reline. I fixed it by https://github.com/ruby/reline/pull/129.
> My personal opinion is we should deprecate all these variables affecting default separators,
> ...
I think so, but...maybe, so many beginners use ... -
09:03 AM Bug #16647: Redefining $/ causes irb to misbehave
- Related to https://bugs.ruby-lang.org/issues/14240
changing these variables is deprecated now, and it shows a warning -
06:55 AM Bug #16651 (Closed): Extensions Do Not Compile on Mingw64 with mingw32-make
- When mkmf.rb creates a Makefile for an extension, it will generate something that looks like this:
```makefile
srcdir = .
topdir = C/MSYS64/USR/LOCAL/ruby-2.7.0/include/ruby-2.7.0
hdrdir = $(topdir)
arch_hdrdir = C:/MSYS64/USR/LOC... -
- Using the latest version of mingw64 and msys2, neither ruby 2.6.5 nor 2.7.0 compile.
The issue is with miniruby.exe - it gets built but does not work. For example:
$ ./miniruby.exe -v
Returns nothing (I assume it is crashing but... -
06:41 AM Bug #16649 (Closed): Object with [] method doesn't work as String#encode's fallback
- Applied in changeset commit:git|8b6e2685a4b7c7de905f7ed60c02ef85e0724754.
----------
Fixed symbol misused as ID
`rb_funcallv_public` and `rb_respond_to` require an `ID`, not a
`Symbol`. [Bug #16649] -
06:24 AM Bug #16649 (Closed): Object with [] method doesn't work as String#encode's fallback
- `String#encode` document says fallback can be a Hash, a Proc, a Method or an object which has `[]` method.
> Sets the replacement string by the given object for undefined character. The object should be a Hash, a Proc, a Method, or a... -
- `rb_funcallv_public` and `rb_respond_to` require an `ID`, not a
`Symbol`. [Bug #16649] -
-
- rss 0.2.9 is tagged without the "v" prefix.
-
02/23/2020
-
11:53 PM Feature #16456: Ruby 2.7 argument delegation (...) should be its own kind of parameter in Method#parameters
- I'd definitely like to see this as well. It'd be useful for Sorbet since it uses the parameters method to reconstruct methods when generating scaffolds for gem methods and other Ruby code.
https://github.com/sorbet/sorbet/blob/29a967a... - 03:28 PM Revision f88d209b (git): * 2020-02-24 [ci skip]
-
03:28 PM Revision 281b3500 (git): Add pattern matching documentation
- Add separate doc/syntax/pattern_matching.rdoc, add
link to control_expressions.rdoc.
The documentation is "reverse-engineered" from Ruby 2.7
behavior and early preview presentations, and corrected
by pattern-matching feature author @k-tsj. -
02:24 PM Feature #16511: Staged warnings and better compatibility for keyword arguments in 2.7.1
- Thanks for writing that out.
I think in general tracking whether a Hash is keywords or positional dynamically makes everything complicated.
Long-term, I think it's clear we want to know syntactically whether a Hash is keyword argumen... -
- Out of curiosity, why do you overwrite $/?
My personal opinion is we should deprecate all these variables affecting default separators,
they tend to break any non-trivial program, not just IRB, and explicit seems always clearer. -
- Applied in changeset commit:git|6298ec2875a6f1a1e75698c96ceac94362f20bcf.
----------
Warn non-nil `$\` [Feature #14240] -
-
-
-
- This reverts commit c7b71af9e21b3f0b8fe413a3c20cf4bd633c40d0, as
an example in bundler expects untouch PATH.
02/22/2020
-
- These are two different things. Ruby always warns for assigning to an existing constant, regardless of using `const_set` or `CONST = ...`. It does not support using `CONST = ...` inside a method, though `const_set` is allowed. Similar...
-
- Can you please run the failing code from the command line and include the output? The awd files provided are binary files and I have no idea how to read them, and the diag file doesn't include the necessary information.
It appears th... -
06:03 PM Feature #16648 (Open): improve GC performance by 5% with builtin_prefetch
- The mark phase of non-incremental major GC is (I believe) dominated by pointer chasing. One way we can improve that is by prefetching cachelines from memory before they are accessed, to reduce stalls. I did some experimenting, and the ...
- 03:38 PM Revision f85ca4c8 (git): * 2020-02-23 [ci skip]
-
03:32 PM Revision 77dcc2c8 (git): hash.c: [DOC] fix examples for ENV.merge!
-
-
02:05 AM Bug #16646: OpenSSL::VERSION is not defined (moved to ruby/openssl)
- See https://github.com/ruby/openssl/issues/347
Please close. OpenSSL should have a new release soon... -
-
- Thanks for the fix nobu! (https://github.com/ruby/ruby/commit/5b29ea0845c14092abd866ce0183c52635bade4c)
-
- Applied in changeset commit:git|5b29ea0845c14092abd866ce0183c52635bade4c.
----------
Proc from Symbol needs a receiver
So its arity should be -2 instead of -1.
[Bug #16640]
https://bugs.ruby-lang.org/issues/16640#change-84337 -
-
-
02:54 AM Revision f744d801 (git): check USE_MJIT
- iseq->body->jit_unit is not available if USE_MJIT==0 .
-
02:26 AM Misc #16645: Non-warned change of behavior in 2.7 for non-symbol keys
- > treating non-Symbol keys as keywords if the method accepts arbitrary keywords is expected behavior
Yes, I was aware of that, it's just that I always thought of this as simply an _additional_ behavior; previously `**hash` would raise a... -
- Yes, treating non-Symbol keys as keywords if the method accepts arbitrary keywords is expected behavior, as mentioned in the Ruby 2.7.0 release notes (https://www.ruby-lang.org/en/news/2019/12/25/ruby-2-7-0-released/). This is a deliber...
-
- So its arity should be -2 instead of -1.
[Bug #16640]
https://bugs.ruby-lang.org/issues/16640#change-84337 -
- Unused CI (introduced from peephole optimization, etc) can be NULL
so introduce NULL check. -
01:25 AM Revision af12e386 (git): More ENV rdoc [ci skip]
-
- In ruby/ruby, the tests run on both readline & reline by creating four test classes:
```
TestReadline
TestReadlineHistory
TestRelineAsReadline
TestRelineAsReadlineHistory
```
Reline inports the test files and uses them in its CI. Addi... -
- Applied in changeset commit:git|b9007b6c548f91e88fd3f2ffa23de740431fa969.
----------
Introduce disposable call-cache.
This patch contains several ideas:
(1) Disposable inline method cache (IMC) for race-free inline method cache
* ... - 12:59 AM Revision d7984d0f (git): * remove trailing spaces. [ci skip]
-
- This patch contains several ideas:
(1) Disposable inline method cache (IMC) for race-free inline method cache
* Making call-cache (CC) as a RVALUE (GC target object) and allocate new
CC on cache miss.
* This technique allo... -
- Now, rb_call_info contains how to call the method with tuple of
(mid, orig_argc, flags, kwarg). Most of cases, kwarg == NULL and
mid+argc+flags only requires 64bits. So this patch packed
rb_call_info to VALUE (1 word) on such cases. If w...
02/21/2020
-
-
04:54 PM Misc #16645: Non-warned change of behavior in 2.7 for non-symbol keys
- I can not answer your question but I believe matz mentioned the change several times in different
talks before. So a deprecation phase makes no real sense, unless matz and the core team wants
to postpone the change past ruby 3.0 - but ... -
- In ruby 2.7 non-symbol keys are now accepted as keywords, resulting in the following change in behavior:
```ruby
def foo(*a,**h) p [a,h] end
foo("a"=>42)
# [[{"a"=>42}], {}] in 2.6
# [[], {"a"=>42}] in 2.7
```
Given that the... -
04:51 PM Bug #16647 (Closed): Redefining $/ causes irb to misbehave
- If I start irb and then do:
``` ruby
$/ = "asdf"
```
then every character I type shows a newline on the irb console. Previous versions of ruby do not have this behavior, and it is annoying. -
- There are several ways to fix this, maybe add to openssl.rb?
Noticed in several platforms... - 03:45 PM Revision 5a89c057 (git): * 2020-02-22 [ci skip]
-
- With refinements, too.
-
-
-
- https://github.com/ruby/irb/commit/dbc7b059c7
-
12:30 PM Revision 8d3b7f0f (git): Fixed net-pop, smtp, protocol and imap task for sync tool
-
-
-
- test/net/http/test_https.rb: rename fixture methods to read_fixture
because it conflicts with test-unit gem. -
11:41 AM Bug #16337: kernel_gem.rb:68 - ThreadError
- I guess this is because you're not using the latest rubygems. Could you run `gem env version` and check that you have a rubygems version older than 3.1?
You need to request upgrading rubygems to google-fluentd, maybe here: https://git... -
10:57 AM Bug #16643: Array#dig converts keywords to positional hash
- jeremyevans0 (Jeremy Evans) wrote in #note-3:
> Dan0042 (Daniel DeLorme) wrote in #note-2:
> ...
I personally think that it should not be equivalent. `obj.dig(a, b, c)` was introduced as a safe-navigation like `obj[a][b][c]`, so I thi... -
- Dan0042 (Daniel DeLorme) wrote in #note-2:
> Are you seriously telling me that you consider it normal and correct that `obj.dig(**kw)` is _not_ equivalent to `[obj].dig(0, **kw)` ???
It should be equivalent, if `dig` is defined corre... -
- Are you seriously telling me that you consider it normal and correct that `obj.dig(**kw)` is _not_ equivalent to `[obj].dig(0, **kw)` ???
I will note that your first example produces `2` whether keywords are passed with RB_PASS_CALLED... -
-
-
- As mentioned in https://bugs.ruby-lang.org/issues/16511#note-17
it seems very unlikely this triggers in practice, because indeed who would bother with an extra `**` when the method doesn't take keyword arguments?
Maybe for the case the... -
- The arity should actually be `-2` which means 1 required arguments + any number of optional arguments.
- 04:31 AM Revision 4643bf5d (git): * 2020-02-21 [ci skip]
-
02/20/2020
-
- This behavior is deliberate. `dig` should only be overridden if you want to be able to access objects stored inside the object. dig should accept `*args`, using the first element to look inside the object, and passing the remaining arg...
-
- The following behavior for `dig` looks very weird to me:
```ruby
o=Object.new
def o.dig(**kw) p [kw] end
o.dig(x:1)
#no warning
#[{:x=>1}]
[o].dig(0, x:1)
#warning: Using the last argument as keyword parameters is deprecat... -
- steveb3210 (Stephen Blackstone) wrote in #note-16:
> Unforunately Miller-Rabin is not a deterministic test for arbitrarily large n - its only the work in the paper https://arxiv.org/pdf/1509.00864.pdf that allows us to provide functional... -
07:19 PM Feature #16468: Switch to Miller-Rabin for Prime.prime?
- Attached is the latest diff.
-
- Dan0042 (Daniel DeLorme) wrote in #note-15:
> I think it would be interesting to expose the algorithm for larger numbers. So you could have `miller_rabin` which allows any integer, and `prime?` which checks the value and either call `mi... -
- I think it would be interesting to expose the algorithm for larger numbers. So you could have `miller_rabin` which allows any integer, and `prime?` which checks the value and either call `miller_rabin` or raise ArgumentError.
-
- - Add bounds check
- Add test
-
07:08 PM Feature #16644 (Rejected): qualified const init (self::CONST1 = 1) should be allowed in methods
- ```rb
module Mod1
def self.define_consts
const_set(:CONST1, :CONST1)
# this is actual const re-assignment but only a warning
const_set(:CONST1, :CONST1)
# this is const initialization but becomes an ... -
- An extension that makes poll() features available and does not require integration into ruby core is eventmachine.
-
- to allow Intel C++ compiler to read ruby.h.
This is similar to 9930481a239fa7182429f3c3942ea033fb9b0320 -
-
-
-
- > my thoughts were: if respond_to_missing? returns true once, does this have any effect on this cache? even if it might later return false?
Just now, no effect. -
- ko1 (Koichi Sasada) wrote in #note-14:
> Hanmac (Hans Mackowiak) wrote in #note-13:
> ...
my thoughts were: if `respond_to_missing?` returns true once, does this have any effect on this cache? even if it might later return false? -
- I'll merge this patch tomorrow.
If you have any suggestion, please tell me.
-
- It has been deprecated since 2011.
https://github.com/ruby/rdoc/commit/5c2aa0f77d -
08:08 AM Revision c3cd9258 (git): Use `brew upgrade` instead of `brew update`
-
07:44 AM Bug #16641: Backport request: MJIT crashes on a certain flow of branches
- 2.7 backport is done at commit:eaee631d5eda03f77ec39ec6fc1826a06ab06205.
- 07:36 AM Revision 0149863d (git): * 2020-02-20 [ci skip]
-
- when the next insn is already compiled by former branches.
-
- Get rid of double writing.
-
02:46 AM Revision 75863554 (git): comma at the end of enum is a C++11ism
- Comma at the end of enum is allowed in C since C99. We can use them
internally. However when it comes to extension libraries, they could be
written in different C++ versions. We cannot assume sometihng. Public
headers shall keep compa... -
- Recent (since 2012 maybe?) MSVC ships a header named xkeycheck.h, which
(kindly!) aborts compilation on redefinition of C++ keywords. Let's not
define this in case of C++. -
- The `cxx.try_compile` command in this file kicks `cxx.have_devel?`
internally, which recursively calls `cxx.try_link` with a different
source code. We don't want that happen (the source code compiled in
this file must be the first one).... -
- Namely glibc has this macro on -DFORTIFY_SOURCE. We have to prevent
macro redefinition with different macro body. -
- `make leaked-globals` points out that this function is leaked. This has
not been detected in our CI because it is defined only when
VM_CHECK_MODE is nonzero.
Just make it static and everytihng goes well. -
- This is a ruby method with arity zero. Which means, this function takes
one argument (that is self). -
- GC_DEBUG=1 makes this test fail because it changes the size of struct
RVALUE. I don't think the test is useful then. Let's just skip. -
- Starting clang 11, casts between pointer and (narrower-than-pointer) int
are now warned. However all such thing in our repository are guaranteed
safe. Let's suppress the warnings. -
- Actually, looks like I didn't read the bug report closely enough. This is a different issue, and suggests that we should either recognize the frozen hash in the `ruby2_keywords` case and dup it, or remove the optimization.
The issue ... -
- I agree it is a bug. I'm not sure it is worth fixing. Basically, the reason behind it is the parser doesn't separate hash compilation from keyword argument compilation, and the optimization for `**{}` as the only keyword argument ends ...
02/19/2020
-
-
-
-
- This is really interesting. It means that mixing double-splat with positional-only methods was _already_ discouraged.
It feels kinda weird to be more strict about keyword/positional separation in general, but to become more more lenie... -
- When splatting an empty hash literal, internally it's optimized using a global frozen hash object, but this implementation detail can leak into the ruby code outside:
```ruby
ruby2_keywords def foo(*a) a.last end
h = foo(**{})
h[1]... -
- * [Feature #16511] Staged warnings and better compatibility for keyword arguments in 2.7.1 (Dan0042)
* All the benefits of separation of keyword/positional arguments.
* Less disruptive migration in the near term; only the strict nece... - 03:14 PM Revision 4bc16244 (git): * 2020-02-20 [ci skip]
-
-
08:05 AM Misc #16515: one of authoritative name server of ruby-lang.org "pichu.netlab.jp" not responding DNS query
- Nice to hear that 🎉
-
- ## Problem
~~~ruby
def a(b)
".#{b unless b == 1}" if true
end
print(a(0))
~~~
This script `test.rb` crashes by `ruby --disable-gems --jit-verbose=1 --jit-min-calls=1 --jit-wait test.rb`.
## Patch
I fixed this in commit... -
- when the next insn is already compiled by former branches.
-
- Applied in changeset commit:git|f0b815dc670b61eba1daaa67a8613ac431d32b16.
----------
`Proc` made by `Symbol#to_proc` should be a lambda [Bug #16260] -
-
- alanwu (Alan Wu) wrote in #note-15:
> If I understand this correctly, the proposed implementation can trigger an allocation on the GC heap for a CC when there is a cache miss.
Correct.
> ...
Yes.
> I'm particularly worried abou... - 04:47 AM Revision 90d082e3 (git): * 2020-02-19 [ci skip]
-
04:47 AM Revision 5fd5666d (git): support multi-run test for test_readline.rb
-
02/18/2020
-
11:30 PM Bug #16613 (Closed): Vagrant encounters segmentation fault when starting previously correctly working box
- Turns out that this appears to have been due to some corruption in the box itself. Changing the Ruby version solved nothing. Starting over with a new box resulted in a working staging server again. Looks like I was misled by the error re...
-
09:53 PM Bug #16640: Symbol#to_proc reports -1 for arity
- Actually this can be closed, as it doesn't make sense for arity > 1.
-
- Oh nice I didn't see that @zverok.
-
- #9250 was closed with the reason
> The proc created by Symbol#to_proc is not a lambda, but a proc
But in #16260, it was discussed that `Symbol#to_proc` behaves more like lambda, and so hopefully all of its introspection methods (`#... -
- To add some context, this came up because of https://github.com/rails/rails/pull/38474 - specifically https://github.com/rails/rails/blob/2fa1f7c48151617e13b4ad6ca065e47c8d7b42d0/activesupport/lib/active_support/callbacks.rb#L460-L461. T...
-
- Ooo just found https://bugs.ruby-lang.org/issues/9520. I kind of get the argument to keep it consistent with other procs, but this is still a special case within block types, and it will fail if you call it without an argument.
-
- When you create a proc using `Symbol#to_proc` syntax, it reports the arity as -1, even though the required number of arguments is actually 1. This can happen based on `lambda(&:hash)`, `proc(&:hash)`, or `some_method(&:hash)`. Opened a P...
-
- * [Feature #16463] Fixing *args-delegation in Ruby 2.7: ruby2_keywords semantics by default in 2.7.1 (eregon)
* It would be good to decide.
* We can also discuss it at the RubyKaigi dev meeting, but is that not too late for 2.7.1? -
01:39 PM Bug #14891: Pathname#join has different behaviour to File.join
- zverok (Victor Shepelev) wrote in #note-7:
> > I am wondering about the current behavior of Pathname#join, too. Are there any useful use cases for `Pathname.new('/a').join('/c', '/b').to_s #=> "/b"`
> ...
Thank you for your explanation... -
- > I am wondering about the current behavior of Pathname#join, too. Are there any useful use cases for `Pathname.new('/a').join('/c', '/b').to_s #=> "/b"`
I believe that `Pathname#join` acts kinda like `cd` in the shell: `cd x` is "go ... -
- I am wondering about the current behavior of Pathname#join, too. Are there any useful use cases for `Pathname.new('/a').join('/c', '/b').to_s #=> "/b"`? I think it should be `Pathname.new('/a').join('/c', '/b').to_s #=> "/a/c/b` like Fil...
- 06:30 AM Revision ccc3b911 (git): * 2020-02-18 [ci skip]
-
06:30 AM Revision 789c1df1 (git): increment teeny
-
06:09 AM Revision 0643eb2e (git): Fix typo s/test_ruby2_keywords_hash!/test_ruby2_keywords_hash/
- In #2818, `Hash.ruby2_keywords!` has renamed to `Hash.ruby2_keywords_hash`.
-
- It was found that a feature to check and add ruby2_keywords flag to an
existing Hash is needed when arguments are serialized and deserialized.
It is possible to do the same without explicit APIs, but it would be
good to provide them as a... -
- Applied in changeset commit:git|041c2932e336b509b0ddc1fdbd9f160bce8d4893.
----------
Pass keyword arguments to IOs properly [Bug #16639] -
- `ARGF.each_line` with keyword arguments shows warnings on 2.7.0, and does not work on current master.
```
$ ruby -v
ruby 2.7.0p0 (2019-12-25 revision 647ee6f091) [x86_64-darwin18]
$ ruby -e 'p ARGF.each_line(chomp: true).first' < /... -
- 02:35 AM Revision 38070ccd (git): * 2020-02-18 [ci skip]
-
-
- https://github.com/ruby/io-console/commit/41b6f09574
-
- Merged in commit:527829423088f09cf2f708be12bb4337d640dc69