Activity
From 02/04/2020 to 02/10/2020
02/10/2020
-
11:39 PM Bug #16623 (Closed): Windows ENV encoding
- Actions has some issues with Windows CI, most related to the console encoding. I thought I'd start with the spec tests and see what was failing.
On a standard Windows 10 desktop, console encoding is IBM437. ENV.keys and ENV.values a... -
- @ViktorO
Thanks for the report. In the future, please provide information about the failure, what version of Visual Studio/msvc it was built with, the commit, etc.
While converting ruby-loco to Actions, I also started building msw... -
03:13 PM Bug #16622 (Closed): mswin build was failed with the current master branch #3121
- The current master branch (218ca18) was failed with mswin CI environment of ruby core team.
Regards, Viktor at https://frontit.dk/ -
07:40 PM Feature #16150: Add a way to request a frozen string from to_s
- For making Symbol#to_s frozen, see #16153.
-
- Here is a POC PR by @byroot to implement this: https://github.com/ruby/ruby/pull/2872
-
02:56 PM Feature #16621: Second block parameter of Pathname#glob to be relative path from self
- (Just trying to get some more details - I have no particular opinion per se as I
tend to almost exclusively use Dir[] myself, so this is more for ruby users who
use Pathname in general.)
Would this change have any potential backward... -
12:44 PM Feature #16621 (Open): Second block parameter of Pathname#glob to be relative path from self
- I often write such a code:
```rb
some_dir = Pathname("some/dir")
some_dir.glob("**/*.html") do |path|
rel_path = path.relative_path_from(some_dir)
# ...
end
```
If Pathname#glob yields the relative path from self as a sec... -
02:17 PM Bug #16619 (Closed): Error message of "x = return 1" is doubled
-
- The error message of
```rb
x = return 1
```
is **doubled** such as:
```
sample.rb:1: void value expression
x = return 1
sample.rb:1: void value expression
x = return 1
```
-
12:41 PM Revision 2dea81f4 (git): Don't refer Date in the document for Time.
-
11:51 AM Revision 2d1cb93d (git): Update readline-ext entry at docs
-
11:07 AM Bug #16620 (Closed): [BUG] Segmentation fault at 0x0000000103bae000
- I have started to see this bug today. I did not recently upgrade any gems. The trigger seems to be the first find of an instance of the User model. Here is the trace:
-- Control frame information ---------------------------------... -
10:41 AM Revision 6891fd15 (git): Don't use upstream ext/readline/depend
-
08:15 AM Feature #16614: New method cache mechanism for Guild
- does this has any effect or is affected by method missing?
like should method missing be cached like that? (I think maybe not?) -
07:49 AM Revision 8474e6ae (git): Use github.run_id in notification payload URL
-
05:13 AM Revision 912ef0b5 (git): Revert "gc.c: make the stack overflow detection earlier under s390x"
- This reverts commit a28c166f787710227c6aac54befd72778f041485.
This change didn't help.
According to odaira, the issue was fixed by increasing `ulimit -s`. -
- As `command_rhs` is always a "value expression", `command_asgn`
does not need the same check. -
-
- michals (Michal Suchánek) wrote in #note-26:
> Test with unix socket
Test needs expected results. -
03:19 AM Revision f83781c8 (git): rb_enc_str_asciionly_p expects T_STRING
- This `str2` variable can be non-string (regexp etc.) but the previous
code passed it directly to rb_enc_str_asciionly_p(), which expects its
argument be a string. Let's enforce that constraint. -
02:13 AM Bug #16618 (Closed): Ensure called twice when raise in ensure
- Under very specific circumstances (a `return` with code after it), a `raise` in an `ensure` block causes the `ensure` block to be called twice after rescuing in a `rescue` block above it.
Here is a very small reproduction case:
```...
02/09/2020
-
04:33 PM Feature #16505 (Closed): Improve preformance of `RubyVM::InstructionSequence#to_binary`
- Applied in changeset commit:git|6e5e6a40c4c35aee1cfb7d0effa47354f80baa9e.
----------
Deduplicate objects efficiently when dumping iseq to binary
We were inefficient in cases where there are a lot of duplicates due to
the use of linear ... -
- [Feature #16505]
-
- [Feature #16505]
-
- We were inefficient in cases where there are a lot of duplicates due to
the use of linear search. Use a hash table instead.
These cases are not that rare in the wild.
[Feature #16505] - 04:27 PM Revision 2079f436 (git): * 2020-02-10 [ci skip]
-
04:27 PM Revision 9c5a2fed (git): Fix readline build dependency
-
- On Arch, sending a signal in a loop seems hardly to yield the execution.
```
1) Error:
TestThreadQueue#test_queue_with_trap:
Timeout::Error: execution of assert_in_out_err expired timeout (10 sec)
```
https://rubyci.org/logs/rubyci.s3... -
-
- https://github.com/ruby/readline-ext/commit/b0b5f709bd
-
- https://github.com/ruby/readline-ext/commit/8c33abb13c
-
- https://github.com/ruby/readline-ext/commit/1df99d1481
-
- https://github.com/ruby/readline-ext/commit/106c31fc1b
-
- https://github.com/ruby/readline-ext/commit/c0a6303168
-
- https://github.com/ruby/readline-ext/commit/efaca4a5f4
-
- This reverts commit 425b2064d394639101854c83a061a0918b33b857.
This cherry-pick was a mistake. -
- Applied in changeset commit:git|e3e96e3faa1683c8ee832cb6da6f9f96d18b0d77.
----------
Check if bindable against the refined target [Bug #16617] -
07:59 AM Bug #16617 (Closed): I can have instance methods bound to objects which are not their owner
- Usually, an UnboundMethod can only be bound to objects of its owner. However, sometimes the limitations can be circumvented. See the following example:
```ruby
class A
def foo
self.class
end
end
class B
end
module R
Bar = ... -
-
- Applied in changeset commit:git|0f05b234fba2d961f1740c094a83f9831c15b210.
----------
Disable GC until VM objects get initialized [Bug #16616] -
04:13 AM Bug #16616 (Closed): Large RUBY_THREAD_VM_STACK_SIZE causes segmentation fault
- - How to reproduce: ``RUBY_THREAD_VM_STACK_SIZE=100000000 ./ruby --disable-gems -e 'p 1'``
- Expected: only ``1`` is shown.
- Observed: Segmentation fault: 11
- Version: ruby 2.7.0p0 (2019-12-25 revision 647ee6f091) [x86_64-darwin18... -
-
-
-
06:59 AM Revision b7e0831e (git): Enhance rdoc for ENV
-
- ```
% RBENV_VERSION=2.6.5 ruby -r matrix -e 'Vector[1]*Vector[2] rescue p($!)'
#<ExceptionForMatrix::ErrOperationNotDefined: Operation(*) can't be defined: Vector op Vector>
% RBENV_VERSION=2.7.0 ruby -r matrix -e 'Vector[1]*Vector[2]... -
- On s390x, TestFiber#test_stack_size fails with SEGV.
https://rubyci.org/logs/rubyci.s3.amazonaws.com/rhel_zlinux/ruby-master/log/20200205T223421Z.fail.html.gz
```
TestFiber#test_stack_size [/home/chkbuild/build/20200205T223421Z/ruby/te... -
- MSpec requires Ruby 2.4 or more recent.
-
- Under some Ext4 filesystem settings, a timestamp is limited up to
0x37fffffff (2446-05-10).
https://ext4.wiki.kernel.org/index.php/Ext4_Disk_Layout#Inode_Timestamps
> Therefore, timestamps should not overflow until May 2446.
Actually t...
02/08/2020
-
10:53 PM Bug #16612: Enumerator::ArithmeticSequence#last with float range produces incorrect value - Since past few days/weeks, the Redmine threading is broken. Can somebody
please look into this?
Thx.
Vít
Dne 07. 02. 20 v 9:58 muraken@gmail.com napsal(a):
> Issue #16612 has been updated by mrkn (Kenta Murat... -
- A few years later this still caught me as a big surprise:
https://github.com/ruby/openssl/pull/319#issuecomment-583781961
Most C software is fully built/installed with `./configure && make && make install`, why should Ruby be any dif... -
08:43 PM Feature #14609: Let `Kernel#p` without an argument print the receiver
- What about `obj.tap`?
```ruby
construct_url
.then{|url| Faraday.get(url)}
.body
.then{|response| JSON.parse(response)}.tap
.dig('object', 'id')
.then{|id| id || '<undefined>'}.tap
.then{|id| "server:#{id}"}
```
Currently, `tap` without... -
07:05 PM Feature #14609: Let `Kernel#p` without an argument print the receiver
- larskanis (Lars Kanis) wrote in #note-21:
> +1 for `obj.p`, but I don't like the alternative names. IMHO `obj.p` is the natural extension of `Kernel#p`. Any other name doesn't feel right. Does the current `p() => nil` really justify a r... -
06:53 PM Feature #14609: Let `Kernel#p` without an argument print the receiver
- +1 for `obj.p`, but I don't like the alternative names. IMHO `obj.p` is the natural extension of `Kernel#p`. Any other name doesn't feel right. Does the current `p() => nil` really justify a reject of such a useful feature?
- 05:56 PM Revision acb9b734 (git): * 2020-02-09 [ci skip]
-
- https://github.com/ruby/reline/commit/41deb1a3d9
-
-
03:03 AM Feature #16614: New method cache mechanism for Guild
- tenderlovemaking (Aaron Patterson) wrote in #note-2:
> I have one question, do pCMC's contain entries from only *that* class, or that class plus parents?
plus parents.
Assume:
* there are 3 classes `C3 < C2 < C1` and
* make an... - 12:57 AM Revision c76484c3 (git): * 2020-02-08 [ci skip]
- 12:57 AM Revision 07c98537 (git): Clarified documentation in rb_integer_unpack [ci skip]
- I struggled figuring out which of the pack/unpack functions goes into which direction and the two first sentences were of the documentation were:
* Import an integer into a buffer.
* Export an integer into a buffer.
It sounds like both ...
02/07/2020
-
05:34 PM Feature #16614: New method cache mechanism for Guild
- This is great!
I have one question, do pCMC's contain entries from only *that* class, or that class plus parents? -
- To make `CCs` data structure (CI/CC pair entries), CI is also VALUE. But most of case (instead of using keyword parameters) it can be packed in VALUE like Fixnum.
This fix is https://github.com/ruby/ruby/pull/2888/commits/db33bf07d5dc... -
I'm developing a brand new method caching mechanism for Guild and further improvements.
Important ideas:
* (1) Disposable inline method cache (IMC) for race-free inline method cache
* Making call-cache (CC) as a RVALUE (GC tar...-
04:02 PM Feature #16597: missing poll()
- Test with unix socket
-
- Adding test fixup. With this tests pass on master/2.6/2.5
-
02:30 PM Revision b76a21aa (git): support multi-run test for test/did_you_mean/spell_checking/test_class_name_check.rb
-
- shugo (Shugo Maeda) wrote in #note-3:
> ko1 suggested Mutex#release (new version of Mutex#sleep) for backward compatibility.
`release` sounds like `unlock` as in `acquire/release` is similar to `lock/unlock`.
So I think we need a di... -
07:37 AM Bug #16608: ConditionVariable#wait should return false when timeout exceeded
- nobu (Nobuyoshi Nakada) wrote in #note-2:
> How about https://github.com/ruby/ruby/pull/2884
ko1 suggested Mutex#release (new version of Mutex#sleep) for backward compatibility.
What do you think of it?
-
- How about https://github.com/ruby/ruby/pull/2884
-
-
- The suggestion is fairly short; might help to expand a bit, in particular why it would be
necessary/useful.
Two comments from me in regards to the proposal:
1) Is there a defining difference towards e. g. the attr* family? Perhaps... -
12:18 PM Feature #16615 (Open): Group style access scope for macros
- Given a method `.bar`, which defines an instance method `#baz` on a class, and returns the defined method's name as a symbol (`:baz`).
```
class Foo
private
# On evaluation defines a method and returns its name.
# In cur... -
-
-
-
08:58 AM Bug #16612 (Assigned): Enumerator::ArithmeticSequence#last with float range produces incorrect value
-
- `err` in `ruby_float_step_size` seems too big in this case.
-
- Function pointers are not void*. See also
ce4ea956d24eab5089a143bba38126f2b11b55b6
8427fca49bd85205f5a8766292dd893f003c0e48 -
- Against changes of the `assert_separately` prologue code.
- 04:47 AM Revision dedcf62b (git): * 2020-02-07 [ci skip]
-
-
- Auto runner should not run in forked processes in separated tests.
-
- As SystemExit is ignored, it is just useless.
-
- Ruby 2.3 is no longer supported. Does the error still occur if you update to Ruby 2.5, 2.6, or 2.7?
FWIW, it appears to have crashed when updating the access and modification times of files. -
12:37 AM Bug #16613 (Closed): Vagrant encounters segmentation fault when starting previously correctly working box
- Have four identical vagrant boxes for staging of Rails sites. All have functioned fine, including three of them today. However, one box segfaults on startup. See attached crash report, which concludes "You may have encountered a bug in t...
02/06/2020
-
11:43 PM Feature #16610: net/imap: support IMAP4 ID extension (RFC2971)
- Fixed some bugs in the original patch. Added a test for the request formatting.
-
09:24 PM Feature #13067: TrueClass,FalseClass to provide `===` to match truthy/falsy values.
- Although I like the minimalism and cleverness of `:itself.to_proc`, I don't think it reads as nicely. It also does not `inspect` nicely. For example,
```ruby
raise "value does not match #{pattern.inspect}" unless pattern === value
... -
- Recently, I had a use case for this. I was writing an assertion helper method which accepts a comparison operator (e.g. `:==`, `:!=`, `:===`, etc) to `send` to the expected value. For my use case, having `!==` would be nice for a few r...
-
- I'm unsure if the bug is in `last` or in `each`.
```ruby
# last seems correct
[7] pry(main)> (0.24901079128550474r + 34.00010700985213r * 10).to_f
=> 340.2500808898068
[8] pry(main)> 340.25008088980684
=> 340.25008088980684
# ... -
07:26 PM Bug #16612 (Closed): Enumerator::ArithmeticSequence#last with float range produces incorrect value
- **Steps to reproduce**
``` shell
% ruby -e 'p ((0.24901079128550474)...(340.25008088980684)).step(34.00010700985213).last'
340.2500808898068
```
**Expected result**
Last value should match the value produced by the following:
... -
-
- This was added in Ruby 2.5, so I think this issue can be closed.
-
- AlexWayfer (Alexander Popov) wrote in #note-7:
> There are problems with Sequel Models, which have `#to_hash` method (implicit conversion), and Memery gem, which defines methods with `*args, **kwargs, &block` (`**kwargs` was added after... -
01:25 PM Bug #14909: Method call with object that has to_hash method crashes (method with splat and keyword arguments)
- There are problems with Sequel Models, which have `#to_hash` method (implicit conversion), and Memery gem, which defines methods with `*args, **kwargs, &block` (`**kwargs` was added after warning from Ruby 2.7).
So, Sequel Models as arg... -
- This reverts commit d767da428c28b7b9fec56b383bb32f6f76c6ad26.
It fails with spec/ruby/core/kernel/require_spec.rb:5 -
- The original commit was https://github.com/rubygems/rubygems/pull/3119
-
12:57 PM Revision d767da42 (git): [rubygems/rubygems] Fix require issue with file extension priority
- If `require "a"` is run when two folders have been specified in the -I
option including a "a.rb" file and a "a.so" file respectively, the ruby
spec says that the ".rb" file should always be preferred. However, the
logic we added in https... -
- https://github.com/rubygems/rubygems/commit/912d141a35
-
- This condition is too restrictive in my opinion. If a user has a pre
version of rubygems installed, she should be fully responsible for it,
and we shouldn't restrict any functionality.
Also, why is a new prerelease disallowed but an old... -
-
- Redirect the output of separated child process to
`MiniTest::Unit.output`. -
-
- RDoc says nothing about them. Added an example that
ConditionVariable#wait can be woken up by
ConditionVariable#signal, instead. -
-
- Check if threads are stopped by Thread#stop? instead of the status
name. -
- Pointer to this field is passed to ATOMIC_CAS. We have to use
rb_atomic_t for that purpose. -
- The same as 8427fca49bd85205f5a8766292dd893f003c0e48.
-
- Let me quote ISO/IEC 9899:2018 section 6.5.15:
> Constraints
> ...
(snip)
Here, `*option` is a const struct rb_compile_option_struct. OTOH
`COMPILE_OPTION_DEFAULT` is a struct rb_compile_option_struct, without
const. These two are _n... -
- There are cases when sizeof(int) == sizeof(long) == sizeof(size_t). On
such cases however int and long are incompatible types in theory. We
should not assume typedef long size_t, because on Solaris size_t is
actually a typedef of int.
... -
- Namely recent Sun C compiler has this function, and is not a GCC.
Meanwhile the code without RUBY_JMP_BUF assumes GCC. We have to define
the macro when we detect __builtin_setjmp for non-GCC compilers. -
- Predefined macros are practices not very well recommended, but can be
better than having no documents at all. Without those predefined
macros, Doxygen confused for instace PUREFUNC(int foo()) to be a
declaration of PUREFUNC, not foo. -
- Now that we have C++ header files, why not let their indents follow our
way. - 01:38 AM Revision d16f4220 (git): * 2020-02-06 [ci skip]
-
01:38 AM Revision 26ffd6e4 (git): Increase the frozen_strings table initial size
- It was set to 1000 in a4a2b9be7a55bb61d17cf9673ed0d2a93bb52d31.
However on ruby-2.7.0p0, there are much more than 1k frozen string right after boot:
```
$ ruby -robjspace -e 'p ObjectSpace.each_object(String).select { |s| s.frozen? && ...
02/05/2020
-
- There is some issue with TCP sockets:
LD_LIBRARY_PATH=. ./ruby -I. -Ilib -I.ext/common -I.ext/x86_64-linux/ tcp_test.rb
`select: [[:@sock], [:@sock], []]
poll: [[:@sock], [:@sock], [], []]
select: [[], [:@sock], []]
poll: [[], [:@sock... -
- I use this with local (UNIX) sockets but did not backport the current patchset to my production ruby version yet. I did not test TCP sockets.
-
- michals (Michal Suchánek) wrote in #note-8:
> This one, and it does not work. There is another place that needs to be patched.
Is there a test for socket?
I have interest in TCP. -
- It looks like SNI support has already been added to FTP, HTTP, IMAP, and POP. I think that SMTP is the only `Net::Protocol` class remaining.
Since it's used by all of the `Net::Protocol` classes, does it make more sense to move this i... -
- IMAP servers often strongly recommend clients to report their ID, for
usage statistics and bug reports. Clients may also find server IDs
useful for the same reasons.
Although the RFC requires otherwise, some servers do make it a sof... -
04:28 PM Misc #16360: Enabling IBM PowerPC/Z cases in Travis CI
- https://bugs.ruby-lang.org/issues/16360#note-7
I am still debugging for the "stack level too deep (SystemStackError)" issue that happens on only ppc64le.
When I was debugging with following file,
```
$ cat spec/ruby/library/soc... -
02:17 PM Bug #16609 (Closed): `#sample` not working with blocks properly
- `#sample` do not take blocks. They are just ignored. It's one of the limitations of Ruby language.
Matz.
-
01:02 PM Bug #16609 (Closed): `#sample` not working with blocks properly
- This may be a bug, it may be an uncoded/partially working feature. Running `#sample` with a block doesn't complain or throw an error; The following code runs, but doesn't execute correctly.
```
a = [1, 2, 3, 4, 5, 6]
a.sample(&:even... -
- The following program prints `false` on Ruby 1.8, but `true` on Ruby 1.9 or later.
```
require "monitor"
m = Monitor.new
c = m.new_cond
m.synchronize { p c.wait(0.1) }
```
However, it's not critical because most programs check... - 12:42 AM Revision 940cd3b9 (git): * 2020-02-05 [ci skip]
-
- To output to the STDOUT of the parent process according to the
parallel test protocol, should send to the `MiniTest::Unit.output`
instead of each own STDOUT. -
02/04/2020
-
-
- Updated patchset. Passes basic test but not TestParallel. For some reason it segfaults.
LD_LIBRARY_PATH=. ./ruby -I. -Ilib -I.ext/common -I.ext/x86_64-linux/ test.rb
`select: [[:@inpipe, :@outpipe, :@errpipe], [:@inpipe, :@outpipe, :@... -
- This one, and it does not work. There is another place that needs to be patched.
LD_LIBRARY_PATH=. ./ruby -I. -Ilib -I.ext/common -I.ext/x86_64-linux/ test.rb
`select: [[:@inpipe, :@outpipe, :@errpipe], [:@inpipe], []]
poll: [[:@inpip... -
- Is there a test?
-
12:51 PM Revision 390a9d3b (git): just use STDOUT
-
- before:
```
open(p1 = v1, p2 = v2, p3 = v3)
``` -
-
- * [Feature #15722] `Kernel#case?` (sawa)
* `"foo".case?(Symbol, String) # => true` -
-
- Applied in changeset commit:git|7d6903dc476f982e7b432adbeef3a3d9372a309f.
----------
Add the loaded feature after no exception raised
Retrying after rescued `require` should try to load the same
library again. [Bug #16607] -
06:18 AM Bug #16607 (Closed): retried require does not raise Exception even if a library has SyntaxError
- From shell:
```
% echo "class C" > c.rb
% ruby -e 'begin p require "./c" ; rescue SyntaxError; end; p require "./c"; C'
```
**expected result:** SyntaxError
**2.7 and current master output:**
```
false
Traceback (most rece... -
07:20 AM Misc #16515: one of authoritative name server of ruby-lang.org "pichu.netlab.jp" not responding DNS query
- Also, support.netlab.jp is not responding IPv6 DNS query.
```
% drill support.netlab.jp AAAA
;; ->>HEADER<<- opcode: QUERY, rcode: NOERROR, id: 45087
;; flags: qr rd ra ; QUERY: 1, ANSWER: 1, AUTHORITY: 0, ADDITIONAL: 0
;; QUESTIO... -
- Retrying after rescued `require` should try to load the same
library again. [Bug #16607] -
-