Activity
From 12/26/2019 to 01/01/2020
01/01/2020
-
10:08 PM Feature #16470: Issue with nanoseconds in Time#inspect
- I'd guess it's partly due to the Float itself losing precision.
But indeed it's quite unpretty. Maybe we should use #rationalize since that's closer to the Float#inspect output?
There is a usability problem here, it's basically impos... -
03:04 PM Feature #16470 (Closed): Issue with nanoseconds in Time#inspect
- Ruby 2.7 added nanosecond representation to the return value of `Time#inspect` method.
Nanosecond is displayed as `Rational` as in the following example:
```ruby
t = Time.utc(2007, 11, 1, 15, 25, 0, 123456.789)
t.inspect # => "20... -
07:16 PM Feature #16471 (Open): Two feature requests for WeakRef: get original object, callback feature
- I'd like to request two features for `WeakRef`. I'll explain what I want, then provide a real world use case.
First, add the ability to pull the original object out of the `WeakRef` object, something like this:
```ruby
myhash = {}... -
- Dan0042 (Daniel DeLorme) wrote:
> Maybe just one more push and we can reach the point where the hidden keyword hash flag can be made explicit via a subclass of `Hash`, and then we'd have a nice clean object-oriented design [like I attem... -
- I think one of the main advantages of doing this is a much better migration path.
Imagine I have this code, which works fine in Ruby 2.6:
```ruby
def foo(*args)
bar(*args)
end
def bar(*args)
cdr(*args)
end
def cdr(*a... - 01:55 PM Revision 076f24c2 (git): bignum.c: extract bdigits_to_mpz and bdigits_from_mpz (#2805)
-
12:08 PM Bug #16469 (Closed): Wrong warning message at `URI.encode` and `URI.decode`
- # Sample code
``` ruby
enc_uri = URI.encode("http://example.com/?a=\11\15")
URI.decode(enc_uri)
```
# Actual
```ruby
irb(main):005:0> enc_uri = URI.encode("http://example.com/?a=\11\15")
(irb):3: warning: URI.escape is obsolete... -
11:05 AM Feature #16029: Expose fstring related APIs to C-extensions
- @sam.saffron I agree that both would be nice.
> then new fstrings can be created using todays awkward API
You mean `rb_funcall(str, rb_intern("-@"))` ? -
06:06 AM Revision afd3f64f (git): Redmine /projects/ruby-trunk is now redirected
- to /projects/ruby-master
-
- trunk branch was deleted.
-
- Done
```
k0kubun@svn:/var/git/ruby.git/refs/heads$ cat /var/git/ruby.git/refs/heads/trunk
ref: refs/heads/master
k0kubun@svn:/var/git/ruby.git/refs/heads$ sudo rm /var/git/ruby.git/refs/heads/trunk
```
```
$ git push github :t... -
- FYI: rvm ruby-head was fixed to use master branch in https://github.com/rvm/rvm/pull/4840 (thanks havenwood!) and therefore Travis ruby-head is also using master branch. I think we have no significant blocker for removing trunk branch an...
-
- The format is the same as Travis / AppVeyor now.
12/31/2019
-
- Similar to 4fb6643f31cdee33184043ce17c42001274c4392.
This is motivated by the lack of the same feature in GitHub Actions. -
- When `make all` fails, we should not run tests and output of such run is
confusing. -
10:53 PM Revision 69731b24 (git): Fixup a6864f6d2f39bcd1ff04516591cc18d4027ab186
-
- Applied in changeset commit:git|a6864f6d2f39bcd1ff04516591cc18d4027ab186.
----------
Removed the old executables of racc
[ruby-core:93516][Feature #15982]
https://github.com/ruby/racc/pull/123 -
- [ruby-core:93516][Feature #15982]
https://github.com/ruby/racc/pull/123 - 10:41 PM Revision e1c363f8 (git): [bundler/bundler] Add ruby2_keywords
- https://github.com/bundler/bundler/commit/29d932d72d
-
- `make check` runs test -> test-all -> test-spec, and other CIs follow that too.
-
- We're actually using it for PR :p
-
05:35 PM Revision 860753ea (git): Actions MinGW - fix test-all (#2803)
-
-
05:30 PM Feature #16456: Ruby 2.7 argument delegation (...) should be its own kind of parameter in Method#parameters
- I think that the `[[:rest, :"..."], [:keyrest, :"..."], [:block, :"..."]]` solution looks like a good option, as it keeps roughly the same behaviour while adding the differentiation between `*args, &blk` and `...`.
-
05:04 PM Revision 049292e3 (git): Add load path and require for ruby/ruby
-
- https://github.com/ruby/irb/commit/1f3a84ab6b
- 03:02 PM Revision 287bfb69 (git): * 2020-01-01 [ci skip]
-
03:02 PM Revision 1a186223 (git): Update GitHub Actions Badges
- - Generated by [npx github-actions-badge](https://github.com/azu/github-actions-badge)
- Add MJIT -
- 02:32 PM Revision a118bb80 (git): [ruby/irb] Add tests for RubyLex
- The set_auto_indent method calculates the correct number of spaces for
indenting a line. We think there might be a few bugs in this method so
we are testing the current functionality to make sure nothing breaks
when we address those bugs... -
02:32 PM Revision 337ba56a (git): [ruby/reline] Degenerate the terminal size to [$LINES, $COLUMNS] if it is unknown
- This is a workaround for https://github.com/ruby/irb/issues/50
https://github.com/ruby/reline/commit/5725677d1a - 01:48 PM Revision e082f416 (git): Introduce BIGNUM_EMBED_P to check BIGNUM_EMBED_FLAG (#2802)
- * bignum.h: Add BIGNUM_EMBED_P
* bignum.c: Use macros for handling BIGNUM_EMBED_FLAG -
11:52 AM Revision 4ce28b58 (git): speed up set intersect
-
10:43 AM Revision 0cf75e38 (git): Split test_nomethod_error.rb
-
-
-
- `NoMethodError` has been raised instead of `FrozenError`.
-
- It died again https://github.com/ruby/ruby/runs/368837347
- 09:31 AM Revision 918fe2ed (git): Fix Object#inspect documentation
- Starting from ruby 2.7.0, there's no longer a connection between the hexadecimal
number that #inspect shows and the object's ID. -
-
-
- Minitest has the released tags now.
-
- TestRelineAsReadline#test_input_metachar passes on MinGW
- 08:27 AM Revision 56a74659 (git): Copy-editing NEWS file on "is now warned" messages (#2783)
- The phrase "[doing X] is now warned" is not grammatically correct in
English as it is lacking an object. We can make these sentences read
better by switching to "[doing X] will now display a warning" instead. -
-
-
- like "{platform} / make ({make target}, ...)"
-
-
- in favor of #2791
-
- * MinGW - skip spec in spec/ruby/optional/capi/thread_spec.rb
C-API Thread function rb_thread_call_without_gvl
-- runs a C function with the global lock unlocked and unlocks IO with the generic RUBY_UBF_IO
stops/freezes spec test... -
- This reverts commit 75e8dd58f69c190c9698d0133942032903fb2f07.
We seem to randomly hit another issue these days:
https://github.com/ruby/ruby/runs/368756135
https://github.com/ruby/ruby/runs/368756191 -
06:46 AM Feature #16029: Expose fstring related APIs to C-extensions
- @byroot
I think it heavily depends on usage... MySQL gem / PG would benefit from "lookup" followed by "create fstring if missing" cause vast majority of string it is creating when querying tables.
My proposal is for the minimal bu... -
- related, see this for for the string api
https://bugs.ruby-lang.org/issues/16029#change-82018 -
03:06 AM Bug #16455: coroutine ucontext uses deprecated POSIX getcontext/swapcontext/makecontext, absent in musl and uclibc
- There is also a missing include for copy to work with musl:
```
+--- a/coroutine/copy/Context.h
++++ b/coroutine/copy/Context.h
+@@ -13,6 +13,7 @@
+ #include <string.h>
+ #include <stdlib.h>
+ #include <alloca.h>
++#include <sy... -
- nobu (Nobuyoshi Nakada) wrote:
> luizluca (Luiz Angelo Daros de Luca) wrote:
> ...
I created a patch to fix the build with musl/uclibc:
```
--- a/configure.ac
+++ b/configure.ac
@@ -2344,7 +2344,10 @@ AS_CASE([$rb_cv_coroutine], ... -
- Needed for `UNALIGNED_MEMBER_ACCESS` using `COMPILER_WARNING_`*
macros. -
02:09 AM Feature #16461: Proc#using
- Eregon (Benoit Daloze) wrote:
> This still has the problem that it mutates the Proc, what should happen if another Thread concurrently does `block.using(OtherRefinement)` ?
It doesn't mutate the Proc, but the block, and if OtherRefin...
12/30/2019
-
11:26 PM Bug #16406 (Closed): `(lambda_proc << normal_proc).lambda?` should return false
- Applied in changeset commit:git|3264a00958f56e1ba75a95c93e59fc9cccf323e8.
----------
Fix Proc#<< spec
[Bug #16406] -
- Should be addressed by https://git.ruby-lang.org/ruby.git/commit/?id=99c7b0b7ea789643bef60085ab59e4b62011ef8b
-
- [Bug #16406]
- 10:48 PM Revision f1ea5d22 (git): * 2019-12-31 [ci skip]
-
- * Deciding lambdaness of (f << g) using g
* Use version guards for spec changes -
- nobu (Nobuyoshi Nakada) wrote:
> luizluca (Luiz Angelo Daros de Luca) wrote:
> ...
Yes. And it also affects uclibc.
autoconf should test for getcontext/swapcontext/makecontext at link time as musl do have them declared (but not impl... -
07:27 PM Feature #16468 (Closed): Switch to Miller-Rabin for Prime.prime?
- The miller-rabin algorithm is a non-deterministic primality test, however it is known that below 2**64, you can always get a deterministic answer by only checking a=[2,3,5,7,11,13,17,19,23, 29, 31, 37]
Given that Prime.prime? would ne... -
06:23 PM Feature #16463: Fixing *args-delegation in Ruby 2.7: ruby2_keywords semantics by default in 2.7.1
- My apologies, it seems I overestimated the meaning of "I think Eregon is correct". And perhaps you missed the part where I emphasized "might", as I never meant to imply you were 100% behind the idea. So hard to convey nuances in writing ...
-
04:34 PM Feature #16463: Fixing *args-delegation in Ruby 2.7: ruby2_keywords semantics by default in 2.7.1
- Dan0042 (Daniel DeLorme) wrote:
> Wow, we've finally reached the point where even Jeremy thinks `ruby2_keywords` by default *might* be the better choice.
That is not what I wrote. You either did not read or understand what I wrote ... -
- Wow, we've finally reached the point where even Jeremy thinks `ruby2_keywords` by default *might* be the better choice. I didn't think I'd see that. Maybe just one more push and we can reach the point where the hidden keyword hash flag c...
-
- jeremyevans0 (Jeremy Evans) wrote:
> Without this, we would probably also have to warn on all cases where a keyword flagged hash is treated as keywords.
Yes, I think that warning should be just as precise as an explicit `ruby2_keywor... -
- zverok (Victor Shepelev) wrote:
> What I believe about the first one that it has the most _interesting consequences_: it allows to write shorter and more DRY code by introducing _new concept_ (which leads to thinking "where it can lead ... -
02:41 PM Feature #16435: Array#to_proc
- @Dan0042
> If I understand correctly, you are saying that of these: ... you consider that the first one provides some kind of clarity of understanding that you don't find in the other three and that leads to better design?
That's a... -
- If I understand correctly, you are saying that of these:
```ruby
list.select(&:condition?)
list.select{.condition?}
list.select{_1.condition?}
list.select{|x|x.condition?}
```
you consider that the first one provides some kind... -
- It's a nice idea, and I rather like the original syntax proposed for its high readability, even though it would require adjusting our expectations. It's very different from usual ruby but since it's in the very limited context of a param...
-
- @harrisonb I don't feel like I can add anything substantial to what I've already said. Just two clarifications:
1. If something in my comments has sounded angrily/mockingly/disrespectful, I am genuinely sorry. It was not my intention ... -
- Class variables need to be in the proper class context.
The following code raises a `NameError` too.
```ruby
class FooClass::BarClass
@@bar # NameError (uninitialized class variable @@bar in FooClass::BarClass)
end
```
You hav... -
12:44 AM Bug #16467 (Rejected): Fetching a class variable with instance_eval fails with NameError
- Trying to fetch a class variable using `instance_eval` fails with `uninitialized class variable @variable_name in Object (NameError)`.
Reproduction program:
``` ruby
class FooClass
def initialize
@foo = "foo"
@@bar = "b... -
-
07:54 AM Misc #16464: Which core objects should support deconstruct/deconstruct_keys?
- These probably should be filed as separate feature requests. I'm already using PM in production and the idea about deconstructing `Time` instances also came into my mind. `Object#deconstruct` is a lot more subtle, I wouldn't say it's _th...
-
- > 1 in Integer(..0)
> ...
Same here. It looks like trying to convert a beginless range to an Integer. I understand how `Object#deconstruct` would work with the array pattern to allow this, but it feels a bit hacky. An object with `d... -
- mame (Yusuke Endoh) wrote:
> `Point[x: 1, y: 2, z: 3]` corresponds elegantly to `Point[x: a, y: b, z: c]`. We cannot write `Point{x: 1, y: 2, z: 3}`.
I understand the idea but for me this backfired. Because it looks **exactly** like... - 12:59 AM Revision aed5afda (git): * 2019-12-30 [ci skip]
-
12:59 AM Revision e8821876 (git): syntax.rdoc: remove "experimental" from refinements (#2796)
12/29/2019
-
- In the future it will be possible to combine `...` with other parameters. So if we think about what `parameters` would return in cases like these...
```ruby
method(def foo(a, *args, ...); end).parameters
#possibility 1 => [[:req, :a], [... -
- One thing to consider before deciding whether this behavior should be the default is how to deprecate it if we decide to remove it later. With `ruby2_keywords`, we would just warn when `ruby2_keywords` is called. Without this, we would...
-
- jeremyevans0 (Jeremy Evans) wrote:
> If we want to do this, we should at least add a method to remove the `ruby2_keywords` flag in the cases where it causes problems.
Thank you for the example.
I'm not sure we need that, it's very... -
- Eregon (Benoit Daloze) wrote:
> Which I think means, there is exactly 0 case where ruby2_keywords semantics are not wanted.
> ...
```ruby
def foo(x, y: $stderr)
y.puts x.inspect
end
def bar(*args)
args.each do |arg|
foo... -
- FWIW, I tried to rebase Jeremy's branch on top of 2.7.0:
https://github.com/ruby/ruby/compare/v2_7_0...eregon:ruby2_keywords-by-default
There were a few conflicts though, I'm not sure it's correct.
All specs but one pass. `test-all`... -
- Eregon (Benoit Daloze) wrote:
> > If a method is intended to accept only positional arguments, and if a keyword is passed to the method, it must be warned.
> ...
Oops, sorry. I was confused again.
Currently, we have only one unsett... -
- mame (Yusuke Endoh) wrote:
> I'm against this change unless many real-world, difficult-to-avoid problems are reported.
Here is an example: https://github.com/rails/rails/pull/38105#discussion_r361842686
I think nobody is able to exp... -
- mame (Yusuke Endoh) wrote:
> I'm against this change unless many real-world, difficult-to-avoid problems are reported.
Agreed. Further, so far, not that many problems have been reported, and the problems reported are not difficult t... -
- I'm against this change unless many real-world, difficult-to-avoid problems are reported.
If I understand Rafael correctly, Rails issue seems to be avoidable by automatical `ruby2_keywords` in `method_added`. It is not clean, but may... -
- Should we close this?
I agree with @headius here.
`using` with a lexical block (i.e., `using(refinement) do ... end`, not `using(&proc)`) might be a good alternative (#12281).
Although `refinement` there would need to be constant fo... -
- As explained in some previous comments, if you want to check if a value is on or after the beginning of the range and on or before the end of the range, use `cover?`. `include?` should only be used if you want to check the argument is o...
-
- Previously, the args rest array was modified, but that was changed in commit:299a13612e54accd9d3661bafde8f67142a78d54 due to the issues it caused. Duping the array before modifying it should fix those issues, at the cost of an extra arr...
-
- (This ticket is derived from https://github.com/rails/rails/pull/38105#discussion_r361798251)
Currently, the following code displays no warnings.
```ruby
def baz(**kw)
end
def bar(*args)
baz(*args)
end
ruby2_keywords de... -
- This still has the problem that it mutates the Proc, what should happen if another Thread concurrently does `block.using(OtherRefinement)` ?
Also it still seems inefficient, at least if there are `block.using(refinement)` with differe... -
06:15 PM Feature #16460: External names for keyword parameters in method definitions
- zverok (Victor Shepelev) wrote:
> You propose to introduce the "same" construct, which means something
> ...
I think at the core, I am suggesting introducing something _new_. While there
is certainly merit to discussion of what is the... -
- This issue closed at https://github.com/ruby/ruby/commit/93116569145bbff34355e08722c6689487d8b858
-
- There is no action for the next in this ticket.
-
- hsbt (Hiroshi SHIBATA) wrote:
> I ignore to run btest on cygwin environment of GitHub Actions recently. I will completely remove it if no one maintains it.
Agreed for the removal. Adding a CI without its active maintainer is harmful. -
- I ignore to run btest on cygwin environment of GitHub Actions recently. I will completely remove it if no one maintains it.
-
- https://github.com/ruby/ruby/pull/1896 has been merged.
-
-
- Applied in changeset commit:git|2ef8d5beeebf759c5dd0754bb99cbcfbad3f368e.
----------
ext/openssl/ossl_ssl.c: nodoc for private methods
[Misc #11712][ruby-core:71565] -
- [Misc #11712][ruby-core:71565]
-
-
-
-
-
-
- https://github.com/ruby/racc/pull/123
-
- I removed them at Ruby 2.7.
-
- Your patch seems eventually same as:
```diff
diff --git a/struct.c b/struct.c
index 79131db2bd..07bfe59b97 100644
--- a/struct.c
+++ b/struct.c
@@ -326,9 +326,7 @@ static VALUE
setup_struct(VALUE nstr, VALUE members, int keywor... -
- https://github.com/ruby/ruby/pull/2795
-
- It was reported in http://blade.nagaokaut.ac.jp/cgi-bin/scat.rb/ruby/ruby-list/50860
-
- The following code is warned:
```ruby
Sample2 = Struct.new(:s1, :s2, :s3) do
def initialize(a1:, a2:)
super(a1, a2, a1 + a2)
end
end
p Sample2.new(a1:1, a2:2)
#=> test.rb:6: warning: Using the last argument as k... -
- https://github.com/ruby/io-console/commit/baaf929041
-
04:12 AM Revision e5c441a4 (git): Optimize Array#rotate!(n) for n = 1 and n = -1
- For the most common cases of `rotate!` one place to the right or to the
left, instead of doing some reversals of the array we just keep a single
value in a temporary value, use memmove and then put the temporary
value where it should be. -
- Is it an issue of `TracePoint#instruction_sequence`?
-
03:59 AM Revision a0d1fd16 (git): Fix documentation of Dir#each_child
-
12/28/2019
-
- 10:13 PM Revision 290711e1 (git): * 2019-12-29 [ci skip]
-
10:13 PM Revision a04c5359 (git): Use __func__ as rb_cv_function_name_string on OpenBSD
- The use of RUBY_WERROR_FLAG causes this test to fail on OpenBSD
platforms that use the binutils linker (ld.bfd) instead of the
llvm linker (ld.lld), due to warnings added to the binutils linker
in OpenBSD.
Removing the RUBY_WERROR_FLAG ... -
- Related to this branch rename from "trunk" to "master", we previously renamed the Redmine project name from "Ruby trunk" to "Ruby master". Today, for consistency I also renamed its internal identifier `ruby-trunk` to `ruby-master` which ...
-
05:59 PM Feature #16446: Enumerable#take_*, Enumerable#drop_* counterparts with positive conditions
- I understand some people are thinking that adding all these methods is doing too much.
I came up with an idea of using just one method: `cut`. It works like `String#partition` when it does not take an argument (but unfortunately, the ... -
- rafaelfranca (Rafael França) wrote:
> This solution would be my first choice if for some reason Rails needs to ask users to change their code to use `ruby2_keywords`.
Nice to hear.
I wonder if Rails and other gems really need to go ... -
- I should be more precise about "*args-delegation broke in Ruby 2.7 for keyword arguments.".
For example, let's take this simple example from https://eregon.me/blog/2019/11/10/the-delegation-challenge-of-ruby27.html:
```ruby
def ta... -
03:59 PM Feature #16463: Fixing *args-delegation in Ruby 2.7: ruby2_keywords semantics by default in 2.7.1
- This solution would be my first choice if for some reason Rails needs to ask users to change their code to use `ruby2_keywords`.
In our current problem, users define Mailers and those mailers have actions, that are public methods in t... -
01:26 PM Feature #16463: Fixing *args-delegation in Ruby 2.7: ruby2_keywords semantics by default in 2.7.1
- Sorry for the semi off-topic comment. Personally I switched back to ruby 2.6.5p114 for the time
being, mostly due to my own laziness. I do not use keyword arguments in my own code base, but
I had several warnings; a few in FileUtils, b... -
- Another way to look at this, do we really want the Ruby language between versions 2.7 and 3.warn to have no natural (syntactic) way to do delegation?
(and instead have to use the ugly ruby2_keywords workaround)
That seems so lame to me... -
- Ruby 2.7.0 is out.
It aims to warn for every keyword argument change that will happen in Ruby 3.0.
Most warnings are useful: adding `**`, etc is needed to not break code when migrating to 3.0.
Ruby 2.7 also aims at remaining compati... -
04:31 PM Feature #5400: Remove flip-flops in 2.0
- nagachika (Tomoyuki Chikanaga) wrote:
> I backported 4e038a7e into ruby_2_6 at r67792.
Really happy this feature is reintroduced into ruby after discuss. -
- mame (Yusuke Endoh) wrote:
> Unfortunately, I cannot reproduce the issue. To isolate the problem, could you uninstall "looksee" gem and check if the issue is still reproducible with other gems that use autoload?
> ...
Sorry, i am desc... -
- Unfortunately, I cannot reproduce the issue. To isolate the problem, could you uninstall "looksee" gem and check if the issue is still reproducible with other gems that use autoload?
```
$ gem install looksee
Building native extens... -
- I don't know how to exactly describe this issue, following is try to reproduce.
We can use a gem named "looksee", it was supported ruby 2.7 ready.
same issue happen on several gem, looksee is just for a sample for describe this issu... -
- @Dan0042 well, it could be a "Stockholm syndrome" on my side, but I tend to believe thinking "I want something `to_proc`-able here" leads me to structure code more clearly, and understand "what should be where". (I already expressed this...
-
- >> It is unlike anything that exists in Ruby (I can't remember a thing where two names separated by space would be a standalone syntax and not just a shortcut, say `puts x` === `puts(x)`)
> ...
Exactly my point. The Rubyists eye is tr... -
- zverok (Victor Shepelev) wrote:
> It also means _exactly_ "...and put in this variable" in this cases:
> ...
I stand corrected! That is a compelling refutation of my point.
> * It is unlike _anything_ that exists in Ruby (I can't ... -
- > it reverses the common meaning of `=>` in Ruby of `key => value`.
But what is "common" meaning? `key => value` just means "key corresponds to value" (which you also can read "parameter name corresponds to (=>) local variable").
I... -
- zverok (Victor Shepelev) wrote:
> I'd say, considering new pattern-matching examples, something with `=>` _might_ work (while still looking ugly) [...]
See, to me, this seems *more* confusing as it reverses the common meaning of `=>`... -
- Jut two points to add:
* the feature like this _might_ be useful for arguments named as Ruby keywords/core methods (e.g. things like `run :some_task, if: :condition?`, `convert(value, raise: false)`, `schedule(:worker, in: 5.minutes)`... -
- > What is `foo`?
In this case, `foo` would be a (JavaScript) `Object`. In using this syntax, you are presuming that `foo` would have the properties `nameOfOneProperty` or `nameOfAnotherProperty`, though if it did not have either of th... -
- Though I don’t remember exactly, once I proposed a similar syntax.
And it was rejected then `local_variable_get` was introduced instead. -
- > A suggested syntax might be
def name(external_name internal_name:)
Isn't this syntax already reserved/used for keyword arguments?
> ...
matz knows crystal; he even donated a seizable sum to crystal way before that
donati... -
- What is `foo`?
-
- Hello! This is my first time filing an issue and I was unable to find anything similar. I apologize if one already exists.
In other languages (such as JavaScript, Swift, and Crystal), it is possible to have two names for a given keywo... -
- I think when possible every object should support deconstructing IF
it makes sense. If it walks like a duck, talks like a duck, then it
can be dequacked (deconstructed like a duck).
I guess one question may be how useful something i... -
- Now, when pattern matching is out, I believe it is worth discussing which core and standard library objects should be matchable "out of the box".
My proposals, as of now, are:
**1. `Object#deconstruct`, returning `[self]`.**
Jus... -
-
- We don't find it useful anymore, because notifications from many other
CIs are mixed. -
-
04:21 AM Feature #6810: `module A::B; end` is not equivalent to `module A; module B; end; end` with respect to constant lookup (scope)
- My oldest Ruby 1.8.2 (2004-12-25) also says `A::B.f # => 1` for that example. That Ruby is 15 years old. The example showing `A::B.f # => 0` is 7 years old. I suspect that `A::B.f # => 0` was a copy mistake, and Ruby always had `A::B....
-
- ## Overview
I propose Proc#using to support block-level refinements.
```ruby
module IntegerDivExt
refine Integer do
def /(other)
quo(other)
end
end
end
def instance_eval_with_integer_div_ext(obj, &block)
... -
01:51 AM Bug #16459: <internal:trace_point>:346: [BUG] Segmentation fault at 0x0000000000000008
- @ko1 can you review https://github.com/ruby/ruby/pull/2788
Maybe it's band aid, but doesn't fix real issue (why it's null in the first place). -
- ```
Process 83135 stopped
* thread #1, name = 'ruby', stop reason = signal SIGSEGV: invalid address (fault address: 0x8)
frame #0: 0x00007fb5f7194410 libruby.so.2.7`rb_iseqw_new [inlined] iseqw_new(iseq=0x0000000000000000) at iseq... -
- For reference, here is the library code which is triggering the crash: https://github.com/ioquatix/covered/blob/20fa509da47db93819d7b83578d102effe2ce977/lib/covered/source.rb#L39
Here is some debugging output at the point of the crash... -
- My code coverage gem which makes extensive use of `script_compiled` is causing segfault on 2.7.0 when accessing `event.instruction_sequence`. I didn't notice any issue in older rubies.
```
<internal:trace_point>:346: [BUG] Segmentati...
12/27/2019
- 11:45 PM Revision bf04fe08 (git): Remove "All Rights Reserved." from Copyright statement.
- 11:41 PM Revision f96216df (git): Remove "All Rights Reserved." from Copyright statement.
-
- OpenBSD is the only platform that uses this support by default,
and it did not work because while OpenBSD supports alloca, it does
not include alloca.h.
This should be backported to Ruby 2.7.
From George Koehler -
09:09 PM Feature #5481: Gemifying Ruby standard library
- marcandre (Marc-Andre Lafortune) wrote:
> vo.x (Vit Ondruch) wrote:
> ...
You can compare the bundler.gemspec from Ruby and upstream:
https://github.com/ruby/ruby/blob/master/lib/bundler/bundler.gemspec
https://github.com/bundler/b... -
08:35 PM Feature #5481: Gemifying Ruby standard library
- hsbt (Hiroshi SHIBATA) wrote (over 1 year ago):
> > @marcandre
> ...
There was an issue with `prime` library not beeing synced, I haven't checked others yet. It would be important to know if we can automatize this, and who's responsibi... -
- @hsbt ah, thanks, I didn't know about `ruby tool/sync_default_gems.rb`. I doubled checked the code and the algorithm currently is in the subdirectory iff there is one, so what I did was correct and sufficient:
https://github.com/ruby/... -
- As a note for the future:
Since unary operations like `-@` and `~@` use the `@` sigil to represent the receiver, I think it would make sense for the callable instance method object to have a syntax like `@.hoge` -
- I think the positive counterparts of `take_while/drop_while` should be `take_until/drop_until`. And although `take_upto` and `drop_upto` are nicely intuitive and descriptive, I can't think of any good names for their negative counterpart...
-
- ```ruby
my_hash = Hash.new({})
my_hash[:my_key].merge!(value: '')
id = my_hash.default.object_id
p ObjectSpace.each_object.find { |o| o.object_id == id }
#=> {:value=>""} -- it exists
my_hash = nil # allow myhash __and its de... -
- This is as per spec.
You typically never want a hash's default to be mutable. Try to name that default in your head (e.g. `X={}; my_hash= Hash.new(X)`, this might help understand it.
You may want to do instead: `Hash.new{ |h, k| h[... -
04:36 PM Bug #16457: Invisible keys on hash when defining hash with Hash.new({})
- So does it mean when main hash lost his references, this new allocated hash will also be collected by GC? I haven't get a chance to test it (also don't know how to do proper test :) )
-
- The logic of this behavior is:
1. `my_hash[:my_key]` returns `my_hash.default` (not assigning it to any key)
2. `my_hash[:my_key].merge!(value: '')` updates this object
3. Now this object is available for ANY key in its updated form, ... -
- When using ``` Hash.new()``` to initialize a hash, we all know for undefined it will return specific value which sent as a parameter to the ```Hash.new``
But when doing something like that keys get invisible
```ruby
my_hash: Hash.ne... -
- In the [DevelopersMeeting20191017Japan log](https://docs.google.com/document/d/1-IC98nOPY_FZnne2PXILYAaxt6PqHfhphAI908K3vD8/edit) there was "Future work: lead argument handling is postponed", so clearly there was the intention of adding ...
-
- @matz Could you reply to this?
Particularly:
> But the primary purpose of Ruby ... is method delegation.
Indeed, and I believe we also want to extract leading arguments in many delegation use cases.
`...` not supporting leading a... -
- The method is defined in line *146*, i.e. it is `nil`'s `#try` method:
```
def try(_method_name = nil, *, **)
nil
end
```
https://github.com/rails/rails/blob/fe097fa629f0975316736f08c3ae00600055ef06/activesupport/lib/active_s... -
- I'm trying to remove all warnings from my library and there is a warning related to keyword arguments that is firing when I believe it should not.
The warning is:
```
/Users/rafaelfranca/src/rails/globalid/lib/global_id/global_id.... -
- > Is there an advantage to have its own type of parameter?
I believe the advantages of doing this are:
- If Ruby ever introduces a new type of parameter, the result of `#parameters` won't need to change for existing code which us... -
- > I think it should be:
```ruby
[[:rest, :*], [:keyrest, :**], [:block, :&]]
```
(I have a deja vu we already discussed it :)))
Names are redundant, it should be just
```ruby
[[:rest], [:keyrest], [:block]]
```
Like this:
... -
- I think it should be:
```ruby
[[:rest, :*], [:keyrest, :**], [:block, :&]]
```
because that's what it will act like in Ruby 3.0+.
Is there an advantage to have its own type of parameter?
That would make usages of `#parameters` ... -
- A method defined with `...` as its parameter list is equivalent to one defined with `*args, &blk`, according to `Method#parameters`.
```ruby
def foo(...); end
p method(:foo).parameters
# => [[:rest, :*], [:block, :&]]
```
Even ... -
-
- 03:47 PM Revision fe3d9d28 (git): * 2019-12-28 [ci skip]
-
-
-
- zunda (zunda an) wrote:
> For now, this can be worked around with making sure to have the `readpartial` method return an unfrozen empty string:
Yes, that looks like a good fix to me.
I would indeed expect usages of `read` and `readp... -
12:13 AM Feature #16150: Add a way to request a frozen string from to_s
- With help by mame-san, I found `nil.to_s` returning a frozen empty string (`""`) broke the http gem on ruby-2.7.0. I wonder how other gems maybe affected.
The code raises `FrozenError` when trying to `force_encoding` after `read`ing a... -
-
- [Bug #16437]
-
- This is for 8a705245e55575d4d310a2e956b89a36a5931971.
-
-
- luizluca (Luiz Angelo Daros de Luca) wrote:
> I tried to disable it with --without-coroutine, --with-out-coroutine and --with-coroutine=no, but it is innocuous or try to use a "no" implementation.
Does `—-with-coroutine=copy` work? -
-
01:17 AM Revision 8c5430e2 (git): reroute macro conflicts on OpenBSD
- OpenBSD's <sys/endian.h> has its own swap32() etc. We have to avoid
name conflicts.
See also https://rubyci.org/logs/rubyci.s3.amazonaws.com/openbsd-current/ruby-master/log/20191226T210011Z.log.html.gz#miniruby -
12/26/2019
-
- Dan0042 (Daniel DeLorme) wrote:
> `take_while_after` is rather unwieldy, so in terms of naming maybe I can suggest:
> ...
Such methods are the same as the cases 6 and 7 in my proposal #16446. -
- `take_while_after` is rather unwieldy, so in terms of naming maybe I can suggest:
```ruby
str.each_line(chomp: true).take_from{ _1 == '<<' }.take_upto{ _1 == '>>' }
``` -
- In all honesty, the more time goes, the less I like the various proposals that replace a block by the convert-to-proc `&` operator.
It looks to me like all the examples could be just as succintly represented with numbered parameters, ... -
- marcandre (Marc-Andre Lafortune) wrote:
> I'm was actually wondering why they are in the main repository at all...
The problem of .gemspec files is that they are scattered all across the repository. The .gemspec should live either in... -
- Also against.
I agree that the double question mark looks weird in `foo? ? 1 : 2`, but that's just a code formatting issue and doesn't warrant such an exceptional syntax. xBartu's suggestion is good, or you could customize your editor... -
10:32 AM Feature #16451: Special ternary operator for methods ending in `?`
- I am also against the proposal.
Having said that I love using one-liners but newcomers to Ruby (from another language) will presumably look for current syntax.
This might be a bit odd yet we can advocate the following:
``` rub... -
10:15 AM Feature #16451: Special ternary operator for methods ending in `?`
- nobu (Nobuyoshi Nakada) wrote:
> A method ends with `?` also can take argument(s), so the proposed syntax introduces an ambiguity which doesn't seem solvable.
I won't claim to be an expert in how the interpreter works, so I'll take y... -
- A method ends with `?` also can take argument(s), so the proposed syntax introduces an ambiguity which doesn't seem solvable.
-
- > one of the key points of Ruby's attractiveness is how far it goes to reduce boilerplate in a logical and humane way. There is a non-neglectible gap between "human" consistency and "computer" (formal) consistency.
+1, very much. I'm ... -
07:53 AM Feature #15973: Let Kernel#lambda always return a lambda
- Ok, make a new ticket about define_method. How about lambda?
Koichi
> 2019/12/26 4:34、zverok.offline@gmail.comのメール:
>
> Issue #15973 has been updated by zverok (Victor Shepelev).
>
>
> Ugh, let me be a bit philosophical h... -
- Hello,
While building ruby 2.7.0 for mips with musl, it fails:
```
linking miniruby /home/luizluca/prog-local/openwrt/trunk/staging_dir/toolchain-... - 03:47 PM Revision 30dbd9e4 (git): * 2019-12-27 [ci skip]
-
-
- http://ci.rvm.jp/results/trunk-theap-asserts@silicon-docker/2525210
-
-
- Noticed that internal/stdbool.h and addr2line.c are the only two place
where missing/stdbool.h is included. Why not delete the file so that
we can merge internal/stdbool.h and missing/stdbool.h into one. -
- Saves comitters' daily life by avoid #include-ing everything from
internal.h to make each file do so instead. This would significantly
speed up incremental builds.
We take the following inclusion order in this changeset:
1. "ruby/con... -
- The same as 41bc766763dba63ae2529f2f9070b8e26399745c. Read that commit
for what is happening. -
- These headers need no rewrite. Just add some minor tweaks, like
addition of #include lines. Mainly cosmetic.
TIMET_MAX_PLUS_ONE was deleted because the macro was used from only
one place (directly write expression there). -
- Rearranged contents, then added MJIT_FUNC_EXPORTED function
declarations. -
- Rather trivial, added missed MJIT_FUNC_EXPORTED function declaration.
-
- Some declatations are moved from internal/parse.h, to reflect the fact
that they are defined in symbol.c. -
- Reduced the number of macros defined in the file. Also made it explicit
for MJIT_FUNC_EXPORTTED functions to be so. -
- Eliminate macros for better readability.
-
- Eliminated the macro to convert into an inline function.
-
- Annotated MJIT_FUNC_EXPORTED functions as such. Declaration of
rb_sym_to_proc is moved into this file because the function is defined
in proc.c rather than string.c. -
- Eliminated macros. As a side effect struct RBasicRaw is no longer
required because we can now define anonymous structs inside of inline
functions. -
- Improved readability by reducing the use of macros. Also moved some
part of internal/compilers.h into this file, because it seems to be the
right place for them. -
- Rearrange macro orders for better readability.
-
- Reduce macros for readability. Also transplanted some part of
internal/file.h into here because the delcared functions are in fact
defined in error.c. -
- This file containes other materials than in compile.c. I could perhaps
split them into files, but felt overkill. Just add comments that
describe the situations. -
- Rearrange contents for better readability, reduce macros for the same
reason, and mark MJIT_FUNC_EXPORTED functions as such. -
- Eliminated macros. Also marked MJIT_FUNC_EXPORTED functions as such.
Some of them are declared in constant.h so edited that file also. -
- Arrange contents and eliminate macros, to make them readable.
Macro IFUNC_NEW was deleted because there was only one usage. -
- This file has almost nothing to do. Added some #ifdef lines and
rearranged file contents.
Those macros are unable to translate into inline functions, because they
are used as lvalues of assignments. -
- Replace macros with inline functions of equivalent contents, for much
improved readability. -
- Reduce macros to make them inline functions, as well as mark
MJIT_FUNC_EXPORTED functions explicitly as such.
Definition of ar_hint_t is simplified. This has been the only possible
definition so far. -
- Marked MJIT_FUNC_EXPORTED functions as such. Other changes are rather
cosmetic. -
- Turn macros into inline functions for better readability. Also add
rb_int128t2big delcaration, which was missing. -
- Add #include lines, move FIXNUM_POSITIVE_P etc. from numeric.h.
-
- ISO/IEC 9899:2011 section 7.2 states that <assert.h> must define
static_assert. Use it when available. -
- Not a big rewrite. Just to make those macros readable.
-
- Improving readability by converting some macros into inline functions.
Also improved support for recent x86_64 processors, which have better
instructions for the purposes. -
- With these macros implemented we can write codes just like we can assume
the compiler being clang. MSC_VERSION_SINCE is defined to implement
those macros, but turned out to be handy for other places. The -fdeclspec
compiler flag is nec... -
- Now that we no longer support old compilers, we can safely delete
several obsolete #ifdef gurads. Also because (as of writing) it is
impossible to compile the program using C++ compilers, lets just
entirely prohibit __cplusplus to reduc... -
- This is tentative. For the sake of simplicity we partially revert
commits e9cb552ec96, ee85a6e72b and 51edb300425. Will decouple them
once again when we are ready. -
- One day, I could not resist the way it was written. I finally started
to make the code clean. This changeset is the beginning of a series of
housekeeping commits. It is a simple refactoring; split internal.h into
files, so that we can... -
- Include what is necessary.
-
- duerst (Martin Dürst) wrote:
> mame (Yusuke Endoh) wrote:
> ...
Yes, I meant 2020/01/09. Thanks :-) -
- (I honestly promised to stop doing this...)
* [Feature #16441] Enumerable#take_while_after (zverok)
* Just like `take_while`, but also returns the matched element; practical examples are shown
* [Feature #16435] Array#to_proc (zve... -
08:23 AM Misc #16454: DevelopersMeeting20200116Japan
- mame (Yusuke Endoh) wrote:
> Please add a ticket number by one week ago about the meeting date.
Do you mean "by one week before the meeting date"? In English, "ago" can only be used for the past, not for the future.
-
- Carry-over:
* [Bug #8841] Module#included_modules and prepended modules (mame)
* Module#include? and Module#included_modules regard prepended modules as included (not well documented); Module#included is not called when the module ... -
- I'd like to set the comment deadline for the agenda. Please add a ticket number by one week ago about the meeting date. (I'll go through the tickets before the meeting.)
-
- # The next dev meeting
**Date: 2020/01/16 13:00-17:00**
Place/Sign-up/Agenda/Log: https://docs.google.com/document/d/1NxNMc7tlt-olPRyRQDhAjZWw30Atr6a-rfQxQ9BRXfY
- Dev meeting *IS NOT* a decision-making place. All decisions should... -
09:06 AM Feature #16290 (Closed): Add Ruby C API to acquire aligned memory
-
-
-
- 81e377023c490998a3fec245ca2fb2b3c710c2c6
-
05:13 AM Bug #16453 (Closed): irb crashes when using array literal and heredoc
- I wanted to type like this:
``` ruby
[<<FOO]
hello
FOO
```
But IRB crashed after input "hello" (and return):
```
irb(main):001:-" [<<FOO]
irb(main):002:-" helloTraceback (most recent call last):
32: from /Users/jnito/... -
- methodmissing (Lourens Naudé) wrote:
> Thanks for the consideration and discussing the proposal. Do you mean file a refactored version of this ticket which has drifted in scope on the Feature tracker with the memory improvements?
Sor... -
03:08 AM Feature #16375: Right size regular expression compile buffers for literal regexes and on Regexp#freeze
- mame (Yusuke Endoh) wrote:
> @nobu will review the patch.
> ...
Thanks for the consideration and discussing the proposal. Do you mean file a refactored version of this ticket which has drifted in scope on the Feature tracker with the m... -
- @nobu will review the patch.
@methodmissing Could you file a ticket about performance improvement and/so refactoring into the Feature tracker? -
- At the previous dev meeting, matz said that let's give it a try :-)
For the record: `Regexp.new` should continue to return unfrozen Regexp instance.
I'll review the pull request. -
- At the previous dev meeting, matz said that it should display a warning dynamically, i.e., not at the parsing time but when the variables are assigned. Variable aliases should be also warned. @jeremyevans0, could you please progress?
-
- At the previous meeting, matz said it should return true. Will do.
-
- This ticket was discussed at the previous dev meeting, and @nobu will review the patch and merge it if okay.
- 01:58 AM Revision dced0e57 (git): * 2019-12-26 [ci skip]
-
01:55 AM Revision 537a1cd5 (git): 2.8.0 (tentative; to be 3.0.0) development has started.