Activity
From 12/21/2019 to 12/27/2019
12/27/2019
- 11:45 PM Revision bf04fe08 (git): Remove "All Rights Reserved." from Copyright statement.
- 11:41 PM Revision f96216df (git): Remove "All Rights Reserved." from Copyright statement.
-
11:01 PM Revision f05416c9 (git): Fix coroutine copy implementation on OpenBSD
- OpenBSD is the only platform that uses this support by default,
and it did not work because while OpenBSD supports alloca, it does
not include alloca.h.
This should be backported to Ruby 2.7.
From George Koehler -
09:09 PM Feature #5481: Gemifying Ruby standard library
- marcandre (Marc-Andre Lafortune) wrote:
> vo.x (Vit Ondruch) wrote:
> ...
You can compare the bundler.gemspec from Ruby and upstream:
https://github.com/ruby/ruby/blob/master/lib/bundler/bundler.gemspec
https://github.com/bundler/b... -
08:35 PM Feature #5481: Gemifying Ruby standard library
- hsbt (Hiroshi SHIBATA) wrote (over 1 year ago):
> > @marcandre
> ...
There was an issue with `prime` library not beeing synced, I haven't checked others yet. It would be important to know if we can automatize this, and who's responsibi... -
- @hsbt ah, thanks, I didn't know about `ruby tool/sync_default_gems.rb`. I doubled checked the code and the algorithm currently is in the subdirectory iff there is one, so what I did was correct and sufficient:
https://github.com/ruby/... -
08:51 PM Feature #16264: Real "callable instance method" object.
- As a note for the future:
Since unary operations like `-@` and `~@` use the `@` sigil to represent the receiver, I think it would make sense for the callable instance method object to have a syntax like `@.hoge` -
- I think the positive counterparts of `take_while/drop_while` should be `take_until/drop_until`. And although `take_upto` and `drop_upto` are nicely intuitive and descriptive, I can't think of any good names for their negative counterpart...
-
08:04 PM Bug #16457: Invisible keys on hash when defining hash with Hash.new({})
- ```ruby
my_hash = Hash.new({})
my_hash[:my_key].merge!(value: '')
id = my_hash.default.object_id
p ObjectSpace.each_object.find { |o| o.object_id == id }
#=> {:value=>""} -- it exists
my_hash = nil # allow myhash __and its de... -
- This is as per spec.
You typically never want a hash's default to be mutable. Try to name that default in your head (e.g. `X={}; my_hash= Hash.new(X)`, this might help understand it.
You may want to do instead: `Hash.new{ |h, k| h[... -
04:36 PM Bug #16457: Invisible keys on hash when defining hash with Hash.new({})
- So does it mean when main hash lost his references, this new allocated hash will also be collected by GC? I haven't get a chance to test it (also don't know how to do proper test :) )
-
- The logic of this behavior is:
1. `my_hash[:my_key]` returns `my_hash.default` (not assigning it to any key)
2. `my_hash[:my_key].merge!(value: '')` updates this object
3. Now this object is available for ANY key in its updated form, ... -
- When using ``` Hash.new()``` to initialize a hash, we all know for undefined it will return specific value which sent as a parameter to the ```Hash.new``
But when doing something like that keys get invisible
```ruby
my_hash: Hash.ne... -
- In the [DevelopersMeeting20191017Japan log](https://docs.google.com/document/d/1-IC98nOPY_FZnne2PXILYAaxt6PqHfhphAI908K3vD8/edit) there was "Future work: lead argument handling is postponed", so clearly there was the intention of adding ...
-
06:15 PM Feature #16378 (Open): Support leading arguments together with ...
- @matz Could you reply to this?
Particularly:
> But the primary purpose of Ruby ... is method delegation.
Indeed, and I believe we also want to extract leading arguments in many delegation use cases.
`...` not supporting leading a... -
- The method is defined in line *146*, i.e. it is `nil`'s `#try` method:
```
def try(_method_name = nil, *, **)
nil
end
```
https://github.com/rails/rails/blob/fe097fa629f0975316736f08c3ae00600055ef06/activesupport/lib/active_s... -
05:55 PM Bug #16458 (Rejected): Ruby 2.7 warning firing in the wrong situations
- I'm trying to remove all warnings from my library and there is a warning related to keyword arguments that is firing when I believe it should not.
The warning is:
```
/Users/rafaelfranca/src/rails/globalid/lib/global_id/global_id.... -
05:35 PM Feature #16456: Ruby 2.7 argument delegation (...) should be its own kind of parameter in Method#parameters
- > Is there an advantage to have its own type of parameter?
I believe the advantages of doing this are:
- If Ruby ever introduces a new type of parameter, the result of `#parameters` won't need to change for existing code which us... -
- > I think it should be:
```ruby
[[:rest, :*], [:keyrest, :**], [:block, :&]]
```
(I have a deja vu we already discussed it :)))
Names are redundant, it should be just
```ruby
[[:rest], [:keyrest], [:block]]
```
Like this:
... -
- I think it should be:
```ruby
[[:rest, :*], [:keyrest, :**], [:block, :&]]
```
because that's what it will act like in Ruby 3.0+.
Is there an advantage to have its own type of parameter?
That would make usages of `#parameters` ... -
- A method defined with `...` as its parameter list is equivalent to one defined with `*args, &blk`, according to `Method#parameters`.
```ruby
def foo(...); end
p method(:foo).parameters
# => [[:rest, :*], [:block, :&]]
```
Even ... -
-
- 03:47 PM Revision fe3d9d28 (git): * 2019-12-28 [ci skip]
-
-
-
- zunda (zunda an) wrote:
> For now, this can be worked around with making sure to have the `readpartial` method return an unfrozen empty string:
Yes, that looks like a good fix to me.
I would indeed expect usages of `read` and `readp... -
12:13 AM Feature #16150: Add a way to request a frozen string from to_s
- With help by mame-san, I found `nil.to_s` returning a frozen empty string (`""`) broke the http gem on ruby-2.7.0. I wonder how other gems maybe affected.
The code raises `FrozenError` when trying to `force_encoding` after `read`ing a... -
08:55 AM Bug #16406 (Assigned): `(lambda_proc << normal_proc).lambda?` should return false
-
- [Bug #16437]
-
07:07 AM Revision 4db89828 (git): Add test_completion_with_indent_and_completer_quote_characters
- This is for 8a705245e55575d4d310a2e956b89a36a5931971.
-
-
- luizluca (Luiz Angelo Daros de Luca) wrote:
> I tried to disable it with --without-coroutine, --with-out-coroutine and --with-coroutine=no, but it is innocuous or try to use a "no" implementation.
Does `—-with-coroutine=copy` work? -
04:06 AM Revision 729b7ce2 (git): Add check_warning_flags to leakchecker
-
01:17 AM Revision 8c5430e2 (git): reroute macro conflicts on OpenBSD
- OpenBSD's <sys/endian.h> has its own swap32() etc. We have to avoid
name conflicts.
See also https://rubyci.org/logs/rubyci.s3.amazonaws.com/openbsd-current/ruby-master/log/20191226T210011Z.log.html.gz#miniruby -
12/26/2019
-
11:13 PM Feature #16441: Enumerable#take_while_after
- Dan0042 (Daniel DeLorme) wrote:
> `take_while_after` is rather unwieldy, so in terms of naming maybe I can suggest:
> ...
Such methods are the same as the cases 6 and 7 in my proposal #16446. -
- `take_while_after` is rather unwieldy, so in terms of naming maybe I can suggest:
```ruby
str.each_line(chomp: true).take_from{ _1 == '<<' }.take_upto{ _1 == '>>' }
``` -
- In all honesty, the more time goes, the less I like the various proposals that replace a block by the convert-to-proc `&` operator.
It looks to me like all the examples could be just as succintly represented with numbered parameters, ... -
- marcandre (Marc-Andre Lafortune) wrote:
> I'm was actually wondering why they are in the main repository at all...
The problem of .gemspec files is that they are scattered all across the repository. The .gemspec should live either in... -
- Also against.
I agree that the double question mark looks weird in `foo? ? 1 : 2`, but that's just a code formatting issue and doesn't warrant such an exceptional syntax. xBartu's suggestion is good, or you could customize your editor... -
10:32 AM Feature #16451: Special ternary operator for methods ending in `?`
- I am also against the proposal.
Having said that I love using one-liners but newcomers to Ruby (from another language) will presumably look for current syntax.
This might be a bit odd yet we can advocate the following:
``` rub... -
10:15 AM Feature #16451: Special ternary operator for methods ending in `?`
- nobu (Nobuyoshi Nakada) wrote:
> A method ends with `?` also can take argument(s), so the proposed syntax introduces an ambiguity which doesn't seem solvable.
I won't claim to be an expert in how the interpreter works, so I'll take y... -
- A method ends with `?` also can take argument(s), so the proposed syntax introduces an ambiguity which doesn't seem solvable.
-
- > one of the key points of Ruby's attractiveness is how far it goes to reduce boilerplate in a logical and humane way. There is a non-neglectible gap between "human" consistency and "computer" (formal) consistency.
+1, very much. I'm ... -
07:53 AM Feature #15973: Let Kernel#lambda always return a lambda
- Ok, make a new ticket about define_method. How about lambda?
Koichi
> 2019/12/26 4:34、zverok.offline@gmail.comのメール:
>
> Issue #15973 has been updated by zverok (Victor Shepelev).
>
>
> Ugh, let me be a bit philosophical h... -
08:03 PM Bug #16455 (Closed): coroutine ucontext uses deprecated POSIX getcontext/swapcontext/makecontext, absent in musl and uclibc
- Hello,
While building ruby 2.7.0 for mips with musl, it fails:
```
linking miniruby /home/luizluca/prog-local/openwrt/trunk/staging_dir/toolchain-... - 03:47 PM Revision 30dbd9e4 (git): * 2019-12-27 [ci skip]
-
-
12:20 PM Revision 7bf44e92 (git): `#include "internal/debug"` seems to be needed in assert mode
- http://ci.rvm.jp/results/trunk-theap-asserts@silicon-docker/2525210
-
-
- Noticed that internal/stdbool.h and addr2line.c are the only two place
where missing/stdbool.h is included. Why not delete the file so that
we can merge internal/stdbool.h and missing/stdbool.h into one. -
- Saves comitters' daily life by avoid #include-ing everything from
internal.h to make each file do so instead. This would significantly
speed up incremental builds.
We take the following inclusion order in this changeset:
1. "ruby/con... -
- The same as 41bc766763dba63ae2529f2f9070b8e26399745c. Read that commit
for what is happening. -
- These headers need no rewrite. Just add some minor tweaks, like
addition of #include lines. Mainly cosmetic.
TIMET_MAX_PLUS_ONE was deleted because the macro was used from only
one place (directly write expression there). -
- Rearranged contents, then added MJIT_FUNC_EXPORTED function
declarations. -
- Rather trivial, added missed MJIT_FUNC_EXPORTED function declaration.
-
- Some declatations are moved from internal/parse.h, to reflect the fact
that they are defined in symbol.c. -
- Reduced the number of macros defined in the file. Also made it explicit
for MJIT_FUNC_EXPORTTED functions to be so. -
- Eliminate macros for better readability.
-
- Eliminated the macro to convert into an inline function.
-
- Annotated MJIT_FUNC_EXPORTED functions as such. Declaration of
rb_sym_to_proc is moved into this file because the function is defined
in proc.c rather than string.c. -
- Eliminated macros. As a side effect struct RBasicRaw is no longer
required because we can now define anonymous structs inside of inline
functions. -
- Improved readability by reducing the use of macros. Also moved some
part of internal/compilers.h into this file, because it seems to be the
right place for them. -
- Rearrange macro orders for better readability.
-
- Reduce macros for readability. Also transplanted some part of
internal/file.h into here because the delcared functions are in fact
defined in error.c. -
- This file containes other materials than in compile.c. I could perhaps
split them into files, but felt overkill. Just add comments that
describe the situations. -
- Rearrange contents for better readability, reduce macros for the same
reason, and mark MJIT_FUNC_EXPORTED functions as such. -
- Eliminated macros. Also marked MJIT_FUNC_EXPORTED functions as such.
Some of them are declared in constant.h so edited that file also. -
- Arrange contents and eliminate macros, to make them readable.
Macro IFUNC_NEW was deleted because there was only one usage. -
- This file has almost nothing to do. Added some #ifdef lines and
rearranged file contents.
Those macros are unable to translate into inline functions, because they
are used as lvalues of assignments. -
- Replace macros with inline functions of equivalent contents, for much
improved readability. -
- Reduce macros to make them inline functions, as well as mark
MJIT_FUNC_EXPORTED functions explicitly as such.
Definition of ar_hint_t is simplified. This has been the only possible
definition so far. -
- Marked MJIT_FUNC_EXPORTED functions as such. Other changes are rather
cosmetic. -
- Turn macros into inline functions for better readability. Also add
rb_int128t2big delcaration, which was missing. -
- Add #include lines, move FIXNUM_POSITIVE_P etc. from numeric.h.
-
- ISO/IEC 9899:2011 section 7.2 states that <assert.h> must define
static_assert. Use it when available. -
- Not a big rewrite. Just to make those macros readable.
-
- Improving readability by converting some macros into inline functions.
Also improved support for recent x86_64 processors, which have better
instructions for the purposes. -
- With these macros implemented we can write codes just like we can assume
the compiler being clang. MSC_VERSION_SINCE is defined to implement
those macros, but turned out to be handy for other places. The -fdeclspec
compiler flag is nec... -
- Now that we no longer support old compilers, we can safely delete
several obsolete #ifdef gurads. Also because (as of writing) it is
impossible to compile the program using C++ compilers, lets just
entirely prohibit __cplusplus to reduc... -
- This is tentative. For the sake of simplicity we partially revert
commits e9cb552ec96, ee85a6e72b and 51edb300425. Will decouple them
once again when we are ready. -
- One day, I could not resist the way it was written. I finally started
to make the code clean. This changeset is the beginning of a series of
housekeeping commits. It is a simple refactoring; split internal.h into
files, so that we can... -
- Include what is necessary.
-
- duerst (Martin Dürst) wrote:
> mame (Yusuke Endoh) wrote:
> ...
Yes, I meant 2020/01/09. Thanks :-) -
- (I honestly promised to stop doing this...)
* [Feature #16441] Enumerable#take_while_after (zverok)
* Just like `take_while`, but also returns the matched element; practical examples are shown
* [Feature #16435] Array#to_proc (zve... -
08:23 AM Misc #16454: DevelopersMeeting20200116Japan
- mame (Yusuke Endoh) wrote:
> Please add a ticket number by one week ago about the meeting date.
Do you mean "by one week before the meeting date"? In English, "ago" can only be used for the past, not for the future.
-
- Carry-over:
* [Bug #8841] Module#included_modules and prepended modules (mame)
* Module#include? and Module#included_modules regard prepended modules as included (not well documented); Module#included is not called when the module ... -
- I'd like to set the comment deadline for the agenda. Please add a ticket number by one week ago about the meeting date. (I'll go through the tickets before the meeting.)
-
- # The next dev meeting
**Date: 2020/01/16 13:00-17:00**
Place/Sign-up/Agenda/Log: https://docs.google.com/document/d/1NxNMc7tlt-olPRyRQDhAjZWw30Atr6a-rfQxQ9BRXfY
- Dev meeting *IS NOT* a decision-making place. All decisions should... -
09:06 AM Feature #16290 (Closed): Add Ruby C API to acquire aligned memory
-
-
-
- 81e377023c490998a3fec245ca2fb2b3c710c2c6
-
05:13 AM Bug #16453 (Closed): irb crashes when using array literal and heredoc
- I wanted to type like this:
``` ruby
[<<FOO]
hello
FOO
```
But IRB crashed after input "hello" (and return):
```
irb(main):001:-" [<<FOO]
irb(main):002:-" helloTraceback (most recent call last):
32: from /Users/jnito/... -
- methodmissing (Lourens Naudé) wrote:
> Thanks for the consideration and discussing the proposal. Do you mean file a refactored version of this ticket which has drifted in scope on the Feature tracker with the memory improvements?
Sor... -
03:08 AM Feature #16375: Right size regular expression compile buffers for literal regexes and on Regexp#freeze
- mame (Yusuke Endoh) wrote:
> @nobu will review the patch.
> ...
Thanks for the consideration and discussing the proposal. Do you mean file a refactored version of this ticket which has drifted in scope on the Feature tracker with the m... -
- @nobu will review the patch.
@methodmissing Could you file a ticket about performance improvement and/so refactoring into the Feature tracker? -
- At the previous dev meeting, matz said that let's give it a try :-)
For the record: `Regexp.new` should continue to return unfrozen Regexp instance.
I'll review the pull request. -
- At the previous dev meeting, matz said that it should display a warning dynamically, i.e., not at the parsing time but when the variables are assigned. Variable aliases should be also warned. @jeremyevans0, could you please progress?
-
- At the previous meeting, matz said it should return true. Will do.
-
- This ticket was discussed at the previous dev meeting, and @nobu will review the patch and merge it if okay.
- 01:58 AM Revision dced0e57 (git): * 2019-12-26 [ci skip]
-
01:55 AM Revision 537a1cd5 (git): 2.8.0 (tentative; to be 3.0.0) development has started.
12/25/2019
-
- shevegen (Robert A. Heiler) wrote:
> I am slightly against this proposal.
> ...
While I'm not going to argue that `if else end` statements read nicer than the ternary statement. Reality is that the ternary terms to be the preferred opt... -
- sawa (Tsuyoshi Sawada) wrote:
> The current ternary operator does not work that way. It works like this:
> ...
You are right, I've corrected the example -
- The current ternary operator does not work that way. It works like this:
```ruby
question_method? ? 'was true' : 'was false' # => 'was false'
``` -
04:37 PM Feature #16451: Special ternary operator for methods ending in `?`
- I am slightly against this proposal.
To me personally it does not make a lot of sense to differ between the
trailing character of a method in regards to the ternary operator. IMO
the ternary operator should not discriminate against ... -
- When a method ends in `?`, we should be able to skip the `?` in the ternary operator. For example, we should be able to do:
```ruby
question_method? true_statement : false_statement
```
This shouldn't interfere with implementatio... -
08:54 PM Bug #16437: Codespell report for Ruby 2.6.5 (and 2.7.0-rc1)
- Just for completeness
https://fossies.org/linux/misc/ruby-2.7.0.tar.gz/codespell.html
Great! -
- Ugh, let me be a bit philosophical here (how many times I promised myself to not engage in discussions about Ruby's "spirit"? I've lost count.)
I understand the point you are speaking from (language implementer's background, who const... -
- zverok (Victor Shepelev) wrote:
> Seem it will have an awful impact on any DSLs?..
Which is IMHO a perfect example of how dangerous that is.
What if it's `skip_if { |user| return 42 }`?
Do you expect that to return from the surroun... -
- > On a related note I think we should also prohibit `define_method(&non_lambda)` because that confusingly treats the same block body differently (e.g., the same return in the code means something different).
Seem it will have an awful... -
- On a related note I think we should also prohibit `define_method(&non_lambda)` because that confusingly treats the same block body differently (e.g., the same `return` in the code means something different).
-
- ko1 (Koichi Sasada) wrote:
> more aggressive proposal is obsolete `lambda` call, and use `->` (maybe it is too aggressive).
Sounds even better to me, but I guess that might be disruptive for everyone to adopt `-> {}` style.
It would... -
- ko1 (Koichi Sasada) wrote:
> This is one idea: how about to prohibit `lambda(&...)` method call? (block literal is always prohibited)
I think you mean non-literal block (`&`) becomes prohibited.
> ...
And whether it's `lambda(&...... -
- I noticed 2.7 was released without any official pattern matching documentation, other than the link to the (outdated) presentation.
I don't know, maybe this work is already in progress internally, or maybe it consciously left this way... -
06:12 PM Bug #14918: Use Reline for fallback of ext/readline
- aycabta (aycabta .) wrote:
> Ruby loses readline standard library when the system doesn't have libreadline during Ruby installation, At https://bugs.ruby-lang.org/issues/11084, @hsbt proposed pure Ruby implementation. But I think that r... -
- Actually, `in User(id: id, name: "Bob")` should work.
@docx what do you think of that form?
I would argue that's more similar to both `Integer()`-like constructors and `User.new(id: 1, name: "Bob")` constructors.
`Point[x: 1, y: 2... -
- https://github.com/ruby/reline/commit/b41024e317
-
-
09:50 AM Revision a52e364e (git): fix version regexp
-
-
- https://github.com/ruby/reline/commit/b41024e317
-
-
-
-
-
- This require causes circular require.
```
$ touch empty_file
$ RUBYGEMS_GEMDEPS=empty_file ./local/bin/ruby -w -e ''
/home/mame/work/ruby/local/lib/ruby/2.7.0/rubygems/core_ext/kernel_require.rb:92: warning: /home/mame/work/ruby/local/... - 06:21 AM Revision 27453b04 (git): Update the version of bigdecimal to 2.0.0 (#2784)
-
-
- rb_iseq_complete() can be used by MJIT.
-
- On USE_LAZY_LOAD=1, the iseq should be loaded. So rb_iseq_check()
is needed. Furthermore, now lazy loading with builtin_function_table
is not supported, so it should cancel lazy loading. -
- [Bug #16450]
-
- Range#max with an endless range raises an explicit exception, so Range#min with a beginless range do the same.
```
$ ruby -e '(0..).max'
Traceback (most recent call last):
1: from -e:1:in `<main>'
-e:1:in `max': cannot get the ma... -
-
-
-
-
-
-
- https://github.com/ruby/readline/commit/42b71f3fc0
-
- https://github.com/ruby/readline/commit/e49e942053
-
- https://github.com/ruby/readline/commit/a2cf437c8f
-
- https://github.com/ruby/readline/commit/d2363cad33
-
- https://github.com/ruby/readline/commit/03126372b5
-
- https://github.com/ruby/readline-ext/commit/f5abaf5be1
-
- https://github.com/ruby/reline/commit/923f97d068
-
-
12:38 AM Bug #16449 (Closed): Bundler is 2.1.1 in master, not 2.1.2 ?
- Applied in changeset commit:git|1857b4427817755bb0879ca67e1b2f3276f95d4c.
----------
Merge Bundler 2.1.2 from bundler/bundler.
[Misc #16449][ruby-core:96458] -
-
12/24/2019
-
11:41 PM Revision 8e6d51e0 (git): Sync did_you_mean
-
-
-
05:04 PM Bug #16449 (Closed): Bundler is 2.1.1 in master, not 2.1.2 ?
- NEWS mentions that Bundler has been updated to 2.1.2, but lib/bundler/version.rb
https://github.com/ruby/ruby/blob/5220145ea289d9eb955b373f31773fab2d4f0271/lib/bundler/version.rb
is showing 2.1.1. Normally I think I've seen NEWS d... -
- [Misc #16449][ruby-core:96458]
-
09:13 PM Revision da0a0bae (git): NEWS: add meaning of "CoW" ("copy-on-write")
-
-
07:54 PM Revision f3067deb (git): Revert "Add NEWS entry about Module#name performance (#2779)" (#2781)
- This reverts commit 3e9221d94a12b54c1285923b642364acdbc31c7e.
-
-
- more aggressive proposal is obsolete `lambda` call, and use `->` (maybe it is too aggressive).
-
- This is one idea: how about to prohibit `lambda(&...)` method call? (block literal is always prohibited)
3.0: deprecation warning and show 3.1 will raise exception for `lambda(&...)`
3.1: raise exception for `lambda(&...)`
same as... -
04:51 PM Feature #14912: Introduce pattern matching syntax
- Thanks @mame for explanation and response.
That kinda make sense with the `Point[]`. Is this universal for any class?
I was playing with it and could not make it, for example when I have implemented my own class with `deconstruct_... -
- These functions are enabled only on USE_DEBUG_COUNTER=1.
- 04:00 PM Revision 9b617ffa (git): * 2019-12-25 [ci skip]
-
-
-
-
- https://github.com/ruby/irb/commit/4bb1340687
-
-
-
-
-
-
- It doesn't behave the same as the delete-char.
-
-
-
-
- I've updated my pull request to update [the article of Ruby 3's keyword argument separation](https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/).
https://github.com/ruby/www.ruby-l... -
- @naruse also approved. Thank you for quick replies.
-
- Approved.
Matz.
-
- @marcandre
You have to wait for matz and naruse's approvals! I'll ask them. -
- > I think no user expects that the "subclass relation" is different than the order of ancestors, isn't it?
Regardless whether users know or not, they are actually different. Consider:
```ruby
module M; end
class C; prepend M; en... -
- >s it that releases of the json gem will be done from the ruby/ruby repository?
No. We can merge commits from ruby/ruby to flori/json and release it. -
-
- This reverts commit e57d6194218efc73c30f3fed9dd321d2e357030b.
Test fails:
http://ci.rvm.jp/results/trunk-gc-asserts@ruby-sky1/2518563
http://ci.rvm.jp/results/trunk-gc_compact@silicon-docker/2518533 -
-
-
- nobu (Nobuyoshi Nakada) wrote:
> * I see the word "unuseful" in some online dictionaries.
Yes, but that doesn't mean it's best. As an example, "unuseful" shows up on Google about 363,000 times, but "useless" shows up on Google abou... -
- And as I added fixing typos in ChangeLog file taking from git-notes, the file in the next package will be fixed.
-
- Thank you, yes, "exapmle" in test/openssl/test_x509name.rb is intentional to test malformed RDN by a typo.
And for others:
* Fixed the typos in debug_counter.h and error.c.
* I see the word "unuseful" in some online dictionaries.
* `... -
-
-
-
02:54 AM Bug #16398: Active Support unit test error since caac5f777ae288b5982708b8690e712e1cae0cf6
- This issue has been addressed by https://github.com/rails/rails/pull/38069 .
-
- Sorry, I've forgotten completely.
Updated the [patch](https://github.com/ruby/ruby/pull/2778), but it is sorry to be too late for 2.7. -
-
-
-
- https://docs.google.com/document/u/1/d/1W_wrFsFxxU1MepA6HBpfl-9h-nLD8EBsgMsS7yTDvHE/pub
-
- [Bug #16437]
-
- English version pages seem no longer provided.
-
01:30 AM Revision f09a4ff2 (git): Added NEWS for Feature 15373
-
- Numbered parameter is not an experimental feature,
confirmed by Matz.
https://twitter.com/yukihiro_matz/status/1209271452798607361 -
- The IRB maintainer @aycabta has determined to remove the message. https://github.com/ruby/ruby/commit/0e528ae9cb5c1078e4d07287e403cb548e97f0a3
-
- https://github.com/ruby/reline/commit/55d4dfec1e
-
- https://github.com/ruby/irb/commit/8da0c74640
-
- https://github.com/ruby/irb/commit/d9a7844f50
12/23/2019
-
-
- https://github.com/ruby/rdoc/commit/c65e14d112
-
-
- https://github.com/ruby/rdoc/commit/74d3984324
-
- https://github.com/ruby/rdoc/commit/957d041ae0
-
10:12 PM Feature #16446: Enumerable#take_*, Enumerable#drop_* counterparts with positive conditions
- sawa (Tsuyoshi Sawada) wrote:
> wishdev (John Higgins) wrote:
> ...
Nothing wrong with that at all - but I think adding a :reverse options to the methods would accomplish a right to left search feature.
As I said - declaring what y... -
- wishdev (John Higgins) wrote:
>I prefer simpler examples
> ...
My intention of including two `0`s in the example was to show that there remains an asymmmetry; the search is done from the left, not from the right. In principle, we can s... -
- The answer here is simplicity (declarative) as opposed to wordsmithing.
We need to add an drop_until and take_until to handle 5-8 and drop_while and take_while handle 1-4
All 4 methods get a new parameter "bucket" which determines wher... -
- I have not thought about the proposal here quite much so far, sorry (and admittedly I may need
to do so on a fresh morning as I am a bit tired).
Just two brief comments:
- Some of the examples remind me a bit of .select/.reject/.... -
- #16441 led me to think about the issue more generally. When we want to split a series of iterations by the first element that satisfies (or dissatisfies) a condition, we have three factors to consider.
(1) Whether we want the conditio... -
- Great, thanks.
Pushed. -
05:47 PM Feature #16289: Reduce duplicated warnings for the change of Ruby 3 keyword arguments
- I'm fine with @marcandre's changes.
-
- Sounds clearer to me with @marcandre's changes.
-
- @marcandre , thank you for creating a pull request.
Your proposal:
old: The last argument is used as keyword parameters; maybe ** should be added to the call
new Using the last argument as keyword parameters is deprecated; maybe *... -
- I'm glad this was merged in, but disappointed the error message still doesn't mention that this is a deprecation warning.
Wouldn't it be cleared with https://github.com/ruby/ruby/pull/2776 ? - 09:47 PM Revision 819b6040 (git): Reword keyword arguments warning messages to convey these are deprecation warnings
-
-
-
- 07:17 PM Revision aa01441f (git): * 2019-12-24 [ci skip]
-
-
- Re `obj.is_a?(mod)` we can consider it as `obj.singleton_class.ancestors.include?(mod)` or even `obj.class.ancestors.include?(mod)` in this case.
That's consistent with `ancestors`. -
- At the very least it's inconsistent with the order of Module#ancestors:
```ruby
module M; end
class C; prepend M; end
> C.ancestors
=> [M, C, Object, JSON::Ext::Generator::GeneratorMethods::Object, PP::ObjectMixin, Kernel, BasicOb... -
- The current behavior is consistent. The rdoc of `Module#<` says:
```
call-seq:
mod < other -> true, false, or nil
Returns true if <i>mod</i> is a subclass of <i>other</i>.
```
Note that subclass is not directly related ... -
02:29 PM Feature #12655: Accessing the method visibility
- mri/2.x.0/internal.h:1363:11: error: conflicting types for ‘rb_st_copy’
1363 | st_table *rb_st_copy(VALUE obj, struct st_table *orig_tbl);
looks like this has changed in ruby 2.7
we would have appreciated the public methods from ... -
-
02:01 PM Bug #16448: regex global variables are working differently depending on scope
- It is very unexpected.(
Thank you. -
- `$~` is not a global variable, but a kind of local variable. `String#gsub` assigns the match data to `$~` of its caller. `data.gsub(/test/, &f1)` assigns `$~` of the scope of `check`. The lambda `f1` reads `$~` of the toplevel scope, ...
-
- Hi, everyone.
I am trying to write a code similar to this
``` ruby
#!/usr/bin/env ruby
def check(f1)
f2 = ->(match) { p match; p $~ }
data = "hello test test test"
data.gsub(/test/, &f1)
data.gsub(/test/, &f... -
-
- Yes, your mentioned types of false positives are often found and I had tried to eliminate them before. Some nevertheless overseen ones are now also excluded. Additionally the mentioned sub-directories of external gems are now also exclud...
-
-
- hsbt (Hiroshi SHIBATA) wrote:
> We will handle the new feature of JSON with ruby/ruby repo in the future.
I'm not sure what you mean, could you clarify?
Is it that releases of the json gem will be done from the ruby/ruby repository? -
- naruse did release json-2.3.0 from the current master branch of ruby/ruby.
We will handle the new feature of JSON with ruby/ruby repo in the future. -
- @marcandre
You can pick the commits from ruby/* repository like this.
```
# git clone from the upstream repository and copy from the upstream repository with cp -rf. It's lost the git commits.
ruby tool/sync_default_gems.rb rubyg... -
- @hsbt is your tool to do this published somewhere?
In particular I noticed that some `gemspec` files are not in the same spot (e.g. `lib/matrix/matrix.gemspec` vs `lib/ostruct.gemspec`).
I'm moving one in the main repo, but it's no... -
- Thank you for contributing.
I and naruse got the approval for releasing the new version of JSON from flori.
So, I can merge and release them. But It's too late for releasing Ruby 2.7. I'm going to handle it in 2020. -
- Sorry for bothering the core tracker.
I understand (though, only partially) that JSON standard library is in a weird state "it is kinda maintained but we can't contact maintaner" (is there no way to just move the project's main repo und... -
- knu (Akinori MUSHA) wrote:
> Which does `hash1.transform_keys(hash2)` iterate over, hash1's keys or hash2's keys?
My intention of including the key `:author` in `hash` was to show that the iteration is done over the receiver (your `... -
- As for the behavior when both a hash argument and a block are given, I suggested in the issue to have the block applied after the hash has applied:
**Original proposal**
```ruby
hash.transform_keys({created: :created_at, updated: :u... -
- matz (Yukihiro Matsumoto) wrote:
> FYI, we do not accept a similar change to `transform_values`.
Matz - Do you mean "we reject a similar change to `transform_values`", or do you mean "we have not yet accepted a similar change to `t... -
-
- wmap_finalize expects id2ref() returns a corresponding object
even if the object is dead. Make id2ref_obj_tbl() for this
purpose. -
-
- This is intentional. There was no way to distinguish Time objects that differ in a fraction of a second.
The behavior of Time#to_s kept unchanged for compatibility.
Matz.
-
- `Time#inspect` shows a fractional number.
```
irb(main):001:0> Time.at(0.5)
=> 1970-01-01 09:00:00.5 +0900
irb(main):002:0> Time.at(0.1)
=> 1970-01-01 09:00:00 3602879701896397/36028797018963968 +0900
```
Is this intentional? - 06:59 AM Revision 7779ade4 (git): NEWS: Fix issue reference [#15807] [DOC]
- 06:55 AM Revision dadf1255 (git): README: Add Range#minmax to the list of potential incompatibilities [#15929] [DOC]
- 06:48 AM Revision 3e1adf57 (git): README: Improve wording [DOC]
- 06:40 AM Revision 7df2503b (git): NEWS: Hint at potential incompatibility with Range#minmax [#15807]
-
- objspace->id_to_obj_tbl can contain died objects because of lazy
sweep, so that it should check liveness. -
-
- [ruby-core:96227] [Feature #16419]
-
- This reverts commit 1bf8d5e9797f6304b2e27cb7f42d467f84de0ff4.
Because 204dc3f39f12b4e2640555306bd1dd4530344277 reverts 61aff0cd189e67fa6f2565639ad0128fa33b88fc - 02:54 AM Revision 204dc3f3 (git): Revert "Should return "." for File.extname("file.") also on Windows"
- We want to introduce consistency and better compatibility with unixen,
but the Windows APIs doues not have consistency fundamentally and
we can not found any logical way...
This reverts commit 61aff0cd189e67fa6f2565639ad0128fa33b88fc. - 02:48 AM Revision 048f797b (git): [ruby/prime] Bump version
- 02:48 AM Revision 446c243d (git): [ruby/ostruct] Bump version
- 02:48 AM Revision 9be3295d (git): [ruby/ostruct] Create OpenStruct::VERSION
- 02:48 AM Revision 49d94248 (git): [ruby/ostruct] Move gemspec
- 02:48 AM Revision 48d1acdf (git): [ruby/matrix] Bump version
-
-
-
- "X" must be used in conjunction with "+".
-
12:52 AM Misc #15843: Make "trunk" a symbolic-ref of "master" on git.ruby-lang.org
- Reminder to everyone:
> 2020 1/1: trunk branch cannot be git fetched and git pushed anymore.
The ruby.git's "trunk" branch will be deleted within 10 days. -
-
- docx (Lukas Dolezal) wrote:
> I wonder what do you think about only allowing curly brackets for hash pattern, and only square brackets for array pattern?
The rationale of the current design I've heard from @ktsj is to fit the pattern... -
-
- This reverts commit f85e8d2a8b2a37740334db4fd92ef820f05ddbc5.
It violated the limit of width (> 80) and caused the test failure
12/22/2019
-
- Fixed misspellings reported at [Bug #16437]
-
- In #2612 I made two typos (extra ,, and copy-pasted
same line of code instead of showing two different
ones), fixing them. -
-
-
- Hi, I was playing with the type/hash patterns (2.7.0-preview3), and I find this confusing and non-intuitive:
while generic hash pattern uses curly brackets e.g.
```in {id: id, name: "Bob"}```
when added type to it, it has to b... -
-
- * fix list in #flat_map
* fix wrong indentation in #filter_map and #with_index
* other small fixes -
- https://github.com/ruby/reline/commit/be17740e82
-
- A patch to suppress the warning when started as `console`.
```diff
diff --git a/lib/irb/init.rb b/lib/irb/init.rb
index 2af872fd03..464b33ae03 100644
--- a/lib/irb/init.rb
+++ b/lib/irb/init.rb
@@ -31,6 +31,8 @@
@TRACER_INI... -
- I guess we may provide an API to hide or alter the message for rails console and other tools. Pull request is welcome to ruby/irb.
-
11:02 AM Misc #16444: What is the reason for the warning of IRB?
- Thanks for your feedback. OK. I understood that too late to discuss and a message is as expected.
I think it would be good if the message could be configurable, but I will also consider expanding the options on the library side. Th... -
- I believe that it is too late to discuss "opt-in or opt-out?".
IMO, the quality of the new IRB is not so low. But it highly depends upon environments (OS, terminal, how to use, etc.), so we want people to use the new version, give fe... -
- Agreed for compatibility - may be better to retain the old behaviour as-is.
I believe it was not a deliberate change but an oversight since the author
of reline here on the issue tracker also mentioned compatibility being
an importa... -
- Ruby 2.7 always shows a warning when starting IRB. Why is this necessary?
Of course, ways to suppress the warning have been suggested.
However, libraries that extend IRB, such as `rails console` and `aruba`, may not receive argumen... - 03:17 PM Revision 3a18e43c (git): * 2019-12-23 [ci skip]
-
- at 61aff0cd189e67fa6f2565639ad0128fa33b88fc [Bug #15267]
-
-
- * Change === docs to mention it uses cover?
* Add different example to === docs to showcase
behavior better
* Change include? docs to mention cover?
and clarify the difference -
-
-
-
-
-
02:12 PM Revision 890c834e (git): Enhancements for ENV doc
- 02:01 PM Revision 54be15f3 (git): [Doc] Fix sample in Encoding#names
- 02:01 PM Revision 9654241d (git): [Doc] Fix wrong example in Encoding.aliases
-
- jschleus (Jens Schleusener) wrote:
> There was now also a check done for Ruby master but since the according tarball isn't embedded into the Fossies standard services a test folder was used:
> ...
Some are not misspells (a part of path... -
- There was now also a check done for Ruby master but since the according tarball isn't embedded into the Fossies standard services a test folder was used:
https://fossies.org/linux/test/ruby-master.tar.gz/codespell.html
(https://foss... -
- Fixed misspellings reported at [Bug #16437], missed and a new
typo. -
- Does this log mean the following libraries are stopped by `make` due to the first failure in `cxxanyargs` or in yet another branch?
> ```
> ...
> ``` -
10:02 AM Bug #16331: fails to build with BSD make when any -j option is given (including -j 1)
- I executed following shell script on my FreeBSD test environment and got attached log file.
``` shell
#!/bin/sh
LANG=C
(
echo System Information:
echo --------------------------------------------------------------------... -
-
-
-
- At least as of Ruby 2.6.5, I get a different output from above for at least one of the examples:
```ruby
N = 0
module A
module B
def self.f; N; end
end
N = 1
end
N = 0
A::B.f # => 1
``` -
-
-
12/21/2019
-
- * Use Queue for synchronization.
* Don't use `sleep 0.2` and use `th.join` because created thread
can raise an exception after 0.2 seconds. -
- @matz Is it OK to warn for this in the next Ruby version?
I think it's going to highlight wrong usages (good) and I would expect there are very few usages of `lambda(&existing_proc)`.
The warnings were implemented in https://github... -
- https://github.com/ruby/reline/commit/e98ad3b486
-
-
- Applied in changeset commit:git|75acbd5f0076970d48bc423c2b058adbdb5da9e8.
----------
compile.c: avoid newarraykwsplat for arguments
`foo(*rest, post, **empty_kw)` is compiled like
`foo(*rest + [post, **empty_kw])`, and `**empty_kw` is ... -
- same as: `p(*nil, nil, **{})`
```
(gdb) bt
#0 0x00005555557d6de0 in CALLER_REMOVE_EMPTY_KW_SPLAT (cfp=0x7ffff6bc4fa0, calling=<optimized out>, calling=<optimized out>, ci=0x555555c4e6e0)
at /home/ko1/src/ruby/trunk/vm_insnhelp... -
04:38 PM Bug #16442 (Closed): Segmentation fault when calling a method with array splat and empty kwargs splat
- `a=[1];b(*a, 2, **{})`
~~~
$ ruby -e "a=[1];b(*a, 2, **{})"
-e:1: [BUG] Segmentation fault at 0x0000000000000005
ruby 2.7.0preview3 (2019-11-23 master b563439274) [x86_64-darwin19]
~~~
~~~
$ ./miniruby -e "a=[1];b(*a, 2, **{}... -
- `foo(*rest, post, **empty_kw)` is compiled like
`foo(*rest + [post, **empty_kw])`, and `**empty_kw` is removed by
"newarraykwsplat" instruction.
However, the method call still has a flag of KW_SPLAT, so "post" is
considered as a keyword ... -
- See https://docs.ruby-lang.org/en/master/GC.html#method-c-compact
Typically, I'd just submit a documentation PR, but I am not sure I can properly explain what it does and when it should be used. -
- 05:42 PM Revision 61aff0cd (git): Should return "." for File.extname("file.") also on Windows
- But not changes another cases, such as "file.rb."
[Bug #15267] - 04:58 PM Revision 29ea228e (git): * 2019-12-22 [ci skip]
-
-
- Follow up of the previous commit
https://github.com/ruby/irb/commit/ab207353d3 -
- Fixes #47
https://github.com/ruby/irb/commit/6b8eca4635 -
- The old version of cursor_pos discards the input buffer, which made IRB
ignore the input immediately after IRB is invoked.
This change keeps the input before cursor_pos by using ungetc.
https://github.com/ruby/reline/commit/4a8cca331f -
- https://github.com/ruby/reline/commit/b111cde3c3
-
04:52 PM Feature #6810: `module A::B; end` is not equivalent to `module A; module B; end; end` with respect to constant lookup (scope)
- I just inadvertently made a dup of this issue (#16430) and would like to throw my hat in the ring as supporting this change.
Honestly, this literally the first time since I started ruby that I encountered something in the language th... -
- This is of course only my personal opinion, but I believe that long
names can be somewhat problematic. Now I myself use really very
long method names, but for ruby as a "basic building block" (that
is the core parts), I think the shor... -
- Flip-flop is the winner!!!
-
- The method is just like `#take_while`, but also includes the item where condition became true.
Examples of usefulness:
```ruby
str = <<DOC
prologue
<<
1
2
3
>>
epilogue
DOC
```
Imagine we want to take everything starti... -
- > Does a Date range represent a series of individual days between May 1st and May 31th, like `[2019-05-01 00:00:00, 2019-05-02 00:00:00..... 2019-05-31 00:00:00]` ? Or it represents a continuous time range that starts from May 1st's 00:0...
-
03:05 PM Bug #16440: Date range inclusion behaviors are inconsistent
- To: wishdev (John Higgins)
> (and in fact on my system - the to_time option returns false instead of true).
Sorry that I accidentally tested my code in a Rails console instead of pure irb. The result for that case should be `false`... -
- I have no strong opinion either way but I can understand the
assumption by st0012 to some extent. For example, I personally
always seem to think more about .include? than .cover?, largely
because I simply use .include? a lot more. I ... -
- Changing the flag at runtime causes problems, mainly editors' syntax highlighting, `ruby -c` etc.
How about a new "magic comment" pragma?
```ruby
# -*- experimental-syntax: true -*-
```
or, more strictly
```ruby
# -*- experiment... -
- Applied in changeset commit:git|85a337f986fe6da99c7f8358f790f17b122b3903.
----------
Kernel#lambda: return forwarded block as non-lambda proc
Before this commit, Kernel#lambda can't tell the difference between a
directly passed literal... -
- Before this commit, Kernel#lambda can't tell the difference between a
directly passed literal block and one passed with an ampersand.
A block passed with an ampersand is semantically speaking already a
non-lambda proc. When Kernel#lambd... -
-
-
- mame (Yusuke Endoh) wrote:
> If you want to request a feature, please research the old tickets. I've found #6810.
Ok, thanks. I tried searching before submitting this, but I apparently didn't use the right terms. -
- If you want to request a feature, please research the old tickets. I've found #6810.
-
- Fixed small bug in initial description.
-
- sawa (Tsuyoshi Sawada) wrote:
> What is the purpose of writing the code in three different files? It only looks to me that it is making things more complicated.
I was trying to offer a minimal (non)-working example. The benefit arise... -
- mame (Yusuke Endoh) wrote:
> It is by design. See "Scope" section of https://github.com/ruby/ruby/blob/master/doc/syntax/modules_and_classes.rdoc
Ok, I see that, but is this a good design? I would argue not and am therefore changing... -