Activity
From 12/09/2019 to 12/15/2019
12/15/2019
-
11:58 PM Misc #14632: [ANN] git.ruby-lang.org
- A very small but important correction:
mame (Yusuke Endoh) wrote:
> All the Ruby committers,
> ...
This is an important reminder: You will not be able to push any change to git.ruby-lang.org after 1st Jan.
2020 unless your committe... -
01:41 PM Misc #14632: [ANN] git.ruby-lang.org
- All the Ruby committers,
This is an important reminder: You will not be able to push any change to git.ruby-lang.org after 1st Jan. 2020 unless your committer email address is not listed in https://github.com/ruby/ruby-commit-hook/blo... -
02:51 PM Bug #16392: test-all failure Windows - TestEncoding#test_nonascii_library_path
- @nobu,
In a ps window:
```
ruby 2.7.0dev (2019-12-12T23:58:42Z master 1140625cd3) [x64-mswin64_140]
Encoding filesystem Windows-1252
Encoding locale IBM437
```
In both cmd & ps windows:
```
ruby 2.7.0dev (2019-12-15T07:4... -
01:47 PM Bug #16392: test-all failure Windows - TestEncoding#test_nonascii_library_path
- What encodings are used as the "filesystem" and "locale"?
-
02:20 PM Feature #15966: Introducing experimental features behind a flag, disabled by default
- I have feelings non unlike @Eregon's. Citing from my comment in [remove method-reference operator](https://bugs.ruby-lang.org/issues/16275) (which removal may, or may not be a good thing, but that's not the point currently):
> ....
>... -
01:49 PM Feature #15966: Introducing experimental features behind a flag, disabled by default
- Some more thoughts on a similar subject by the author of RuboCop in a blog post:
https://metaredux.com/posts/2019/12/06/ruby-where-do-we-go-now.html
There are interesting discussions in the Reddit of that blog post:
https://www.redd... -
- Applied in changeset commit:git|e8c62836a6292bf2f691de458b24ea50c51b452a.
----------
IO#set_encoding_by_bom should err when encoding is already set
Except for ASCII-8BIT. [Bug #16422] -
- Except for ASCII-8BIT. [Bug #16422]
-
- https://github.com/ruby/ruby-commit-hook/commit/ddc83bea6fe6f4696e140b605db10ef0c922bba6
-
- `.mailmap` can be used To show canonical names and email addresses.
It is helpful for statistics of committers. -
11:09 AM Revision a83c46e3 (git): Add more debug info
- closed server doesn't have useful info.
So call inspect before close.
And add local debug code in comment.
https://rubyci.org/logs/rubyci.s3.amazonaws.com/unstable11x/ruby-master/log/20191215T092405Z.fail.html.gz
```
1) Failure:
IMAPT... -
08:28 AM Bug #16354: Memory corruption in Enumerable#reverse_each
- ruby_2_6 r67835 merged revision(s) ff41663403d3eb76d95f465cb94e14d2faaa04d1.
-
- Fix memory corruption in Enumerable#reverse_each [ruby-dev:50867]
[Bug #16354]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_6@67835 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
08:22 AM Feature #15829: Object#then_if(condition){}
- How about `call`ing a condition object if it's callable instead of simply using value as a condition?
```
class Object
def then_if(condition, &block)
if condition
if (condition.respond_to?(:call) && condition.call(self... -
- ruby_2_6 r67834 merged revision(s) 203b7fa1ae8cc40d41c38d684f70b3fea7fae813,0131fab749fb76800de09e49a6abf910201c5b58,9c0cd5c569ba22bc68d1a77ad6580a275cd99639,c144d7215b3444fa36d28d540b60170a5b30743d.
-
- Guard static variable first
* ext/openssl/ossl_asn1.c (Init_ossl_asn1): register the static
variable to grab an internal object, before creating the object.
otherwise the just-created object could get collect... -
07:48 AM Revision 980ddca4 (git): Prepare to release rubygems-3.1.0
-
07:41 AM Revision 9f431600 (git): Delegate should be supported now
- Since `did_you_mean` dropped its dependency on it.
-
-
-
-
- ruby_2_6 r67833 merged revision(s) 463092b84da7933f307cc8747f948f68ef19f5fd.
-
- Update rake-12.3.3.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_6@67833 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_6 r67832 merged revision(s) c9423b016cfeab852bc5a829e55e0a11f80b3ab7,0b1e26398e018116180bf41cb63887f77d5d1b82,78ee2c245331e353e218b8fac9ca722a2bcd8fea.
-
- marshal.c: check instance variable count
* marshal.c (w_obj_each): ensure that no instance variable was
added while dumping other instance variables. [Bug #15968]
Hoisted out w_ivar_each
marshal.c: ... -
07:12 AM Misc #16407: Add .github/workflows/cygwin.yml
- > Could you investigate and fix it?
Sorry, I have no idea now...
If develop is hindered, you can revert it.
-
- https://docs.ruby-lang.org/ja/2.0.0/method/Kernel/m/abort.html
には「引数を省略した呼び出し時に $! が nil でなければその例外の メッセージを標準エラー出力 $stderr に出力」されるとありますが、 1.9 から出力されなくなっているようです。
```
% docker run -it --rm rubylang/all-ruby env ALL_RUBY_SINCE=ruby-1.6 ... -
- same as `rand(endless_range)`
Before:
```
$ ruby -e 'rand(..1)'
Traceback (most recent call last):
2: from -e:1:in `<main>'
1: from -e:1:in `rand'
-e:1:in `-': nil can't be coerced into Integer (TypeError)
```
After:
``... -
03:21 AM Bug #14387: Ruby 2.5 を Alpine Linux で実行すると比較的浅めで SystemStackError 例外になる
- I tried to reproduce this issue, but it was not reproduced today.
Is this issue fixed?
ruby:2.5-alpine
```
$ docker-compose build; docker-compose up
Building web
Step 1/2 : FROM ruby:2.5-alpine
---> 5ccd5d2d442a
Step 2/2 : COP... -
- anastasiastowers (Anastasia Stowers) wrote:
> Using the > and < symbols makes sense to compare Time only with the knowledge of the underlying unix time system being used.
I don’t think that knowledge necessary.
Rather, the time is c... -
12:20 AM Bug #16423 (Closed): Ruby Crash
- I was working with RubyMine, and tried to run the project, when it crashed and generated a report. The console output told me to submit the bug report
12/14/2019
-
- `IO#set_encoding_by_bom` docs [say](https://ruby-doc.org/core-2.7.0.preview3/IO.html#method-i-set_encoding_by_bom):
> If ios is not binmode or **its encoding has been set already**, an exception will be raised.
In reality this does... -
- @jeremyevans0 yeah, thanks, I see now.
-
04:36 PM Bug #16421 (Closed): public_send with empty keyword arguments (Ruby version < 2.7)
- You should use `ruby2_keywords`:
```ruby
def delegate(name, *args, &block)
public_send(name, *args, &block)
end
ruby2_keywords :delegate if respond_to?(:ruby2_keywords, true)
```
Then things will work correctly. Thi... -
- Probably it is something that I've just missed, so it is more a question than bug report.
In Ruby < 2.7, I'd implement "delegate everything" method as such:
```ruby
def delegate(name, *args, &block)
@something.public_send(name, *... -
04:06 PM Feature #16420: Warning[:experimental]=false
- Although I can not say whether the specific API proposed here is useful or not (matz may just
have to decide on the API for general use), I agree with the statement of controlling/toggling
the "noise" level, based on different needs by... -
- Current master always warn pattern matching syntax.
It discourage users try them.
Another noisy warnings can stop by `Warning[:deprecated]=false`.
So I think the future may be more useful if `Warning[:experimental]=false` or `Warn... -
- I ran Actions CI and saved the vc140 build as an artifact:
ruby 2.7.0dev (2019-12-12T23:58:42Z master 1140625cd3) [x64-mswin64_140]
Using it locally, had the same error as MinGW.
```
1) Failure:
TestEncoding#test_nonascii_li... -
-
- This reverts commit 5f56a5fc9be9ea7b088795c2d3871c2352a020c2.
`FrozenError.new(mesg, nil).receiver` should not raise an
ArgumentError. - 03:15 PM Revision 52b1ba0b (git): * 2019-12-15 [ci skip]
-
-
-
- BTW, I think it would be good to include other Ruby implementations (cc @headius @enebo) in this discussion,
since I think we all want to support a stable API for ASTs longer term.
As a concrete case, `actionview_precompiler` is usin... -
- The ticket was closed unintentionally, I reopen it.
What's the way to mention an issue in a commit but not close it?
I clarified in the documentation that RubyVM::AbstractSyntaxTree is not stable API:
https://github.com/ruby/ruby/co... -
- Applied in changeset commit:git|b4b22b9278007b106fe40c0191f8dcf5e7e8c0f2.
----------
Clarify in the documentation that RubyVM::AbstractSyntaxTree is not stable API
* See [Feature #14844]. -
-
- * See [Feature #14844].
-
- FWIW, Java has such a concept too that they call "incubator modules" and basically just have the new experimental API under `jdk.incubator` (https://www.azul.com/openjdk-more-speed-less-haste/ for details).
I think we should introduce... -
- FWIW, Java has such a flag to enable experimental ("preview") features (I didn't know when writing this issue).
It's a single command-line flag called `--enable-preview`.
https://www.azul.com/openjdk-more-speed-less-haste/
They alre... -
- Whether to use a positional argument or a keyword argument was discussed in #15751. I don't have a strong feelings either way (one of the patches I added in #15751 supported keyword arguments), and I don't think @eregon or @nobu had str...
-
- Other exception classes with receiver accept recevier as keyword argument of new.
But FrozenError.new accept as positional argument.
I think keyword argument is better consistency.
```
% git grep 'receiver[:=]' ../error.c
../error... -
-
-
02:40 AM Revision e2708068 (git): Drop delegate dependency
- Original comment:
https://github.com/ruby/did_you_mean/commit/2f26c9ee770f28da0942c42cbc9e5800535b75e1 -
01:33 AM Feature #16039: Array#contains? to check if one array contains another array
- There's some similarity with #15198, to the point that I can re-use my suggestion from there:
It might make sense to use ary1.to_set.superset?(ary2). That way it makes explicit the fact that ary1 must be converted to a set. But Set#su...
12/13/2019
-
11:27 PM Bug #15882: OpenSSL::X509::Name.parse usage
- Thanks for the patch.
Since there wasn't any recent movement, I submitted a pull request with it as requested by jeremyevans0.
I made sure to credit you in the commit description since you did all the work.
https://github.com/ruby... -
11:13 PM Bug #15882 (Closed): OpenSSL::X509::Name.parse usage
- Fixed in gem.
-
09:07 PM Revision f3240eb6 (git): NEWS: fix pattern matching example
-
07:58 PM Feature #14183: "Real" keyword argument
- > That was already legal if foo did not accept keyword arguments. :)
my full example was this
```rb
def foo(a: nil, **args)
args
end
foo(a: 1, 'a' => 2, 1 => 3, nil => 4, true => 5, Object.new => 6)
```
This is not le... -
- bughit (bug hit) wrote:
> So after this improvement, nonsense like this:
> ...
That was already legal if `foo` did not accept keyword arguments. :)
As keyword argument splats have always been just plain hashes, and not a separate ty... -
- So after this improvement, nonsense like this:
```rb
foo(a: 1, 'a' => 2, 1 => 3, nil => 4, true => 5, Object.new => 6)
```
becomes legal
and useful functionality like this destructuring example
```rb
words
.select { |pa... -
06:30 PM Feature #16244: Add a Time#before? and Time#after? method
- Using the > and < symbols makes sense to compare Time only with the knowledge of the underlying unix time system being used.
Although this is the way that we choose to store values of it in our systems, Time is special because it has ... - 03:40 PM Revision 835703c6 (git): * 2019-12-14 [ci skip]
-
- https://github.com/ruby/irb/commit/236590882c
-
-
-
-
-
-
-
-
11:27 AM Feature #15425: Store MJIT header into Ruby versioned directory.
- The two attached patches might improve the issue. The `0001-Store-MJIT-header-into-Ruby-versioned-directory-1.patch` includes the `ruby_version` in the header name, while the `0001-Store-MJIT-header-into-Ruby-versioned-directory-2.patch`...
-
-
- This is very likely created here:
https://github.com/ruby/ruby/blob/40026a408df5e3576380f6c1d8bf6c119fa2e32b/common.mk#L241
But it is not clear to me under what conditions this directory is used. -
-
-
08:55 AM Revision 97a17a51 (git): readable function names for inline functions.
- Now, C functions written by __builtin_cexpr!(code) and others are
named as "__builtin_inline#{n}". However, it is difficult to know
what the function is. This patch rename them into
"__builtin_foo_#{lineno}" when cexpr! is in 'foo' method. -
- > Please don't put ideological thoughts on me, that's not a good basis for debate.
Oh no, I'm not. Sorry for the misunderstanding. I was mostly replying to comments in #8948, but I ended up posting here because this is the ticket that...
12/12/2019
-
11:58 PM Revision 1140625c (git): Allow more than one major version number in target_os
-
11:54 PM Revision c2dfc6d8 (git): Show a menu before a document
- IRB should show a menu first if a completed list has plural items. But just
shows document without menu if a completed list with plural items includes a
perfect matched item. The behavior is a bug. This commit fixes it. -
-
- +1
https://github.com/ruby/ruby/pull/2738 was merged, thanks for the PR! -
05:12 PM Misc #16408: Ruby docs list incorrect method signatures for PTY::getpty/PTY::spawn
- Turns out `IO.pipe` would result in `"bar\n"` instead of `"bar\r\n"` (`PTY.open` results in strings that end in `"\r\n"`). Given the rest of the file's test cases all expect strings that end in `"\r\n"`, I thought that sticking to conven...
-
- I believe this feature is not needed anymore. Feature #15215 was implemented which supports setting an ipaddr separately from the host name, so you can connect to any IP address and still use the host name passed to `Net::HTTP.new`.
-
- When configuring Ruby with `--with-os-version-string=none` on Mac OS, the `target_os` is set to `darwin1`.
This is happening because the regex's generated by `configure.ac` that form the `os_version_style_transform` in the `configure`... - 03:05 PM Revision fa5f7a8f (git): * 2019-12-13 [ci skip]
-
-
-
-
- Paths start with the root are absolute on cygwin, regardless the
drive letter. -
-
10:09 AM Feature #16377: Regexp literals should be frozen
- > just for the sake of Communicating the Holy Gospel of Immutability?
Please don't put ideological thoughts on me, that's not a good basis for debate.
> ...
And if they were frozen, they could be.
> so we're not actually leakin... -
- https://rubyci.org/logs/rubyci.s3.amazonaws.com/unstable11x/ruby-master/log/20191212T072406Z.fail.html.gz
-
- control frame detailed info on RUBY_DEBUG=ci should also show
self information. -
06:50 AM Bug #11636 (Closed): super in instance_eval in a method defined in a module is invoked with a wrong receiver
- Applied in changeset commit:git|55b7ba368696033f2e89b77cbcd4a05dec97b139.
----------
Make super in instance_eval in method in module raise TypeError
This makes behavior the same as super in instance_eval in method
in class. The reason... -
- This makes behavior the same as super in instance_eval in method
in class. The reason this wasn't implemented before is that
there is a check to determine if the self in the current context
is of the expected class, and a module itself ... -
05:19 AM Revision 1a4a9bdb (git): proper initialization of struct RVALUE
- This changeset makes no difference unless GC_DEBUG is on. When that flag is
set, struct RVALUE is bigger than struct RObject. We have to take care of the
additional fields. Otherwise we get a SIGSEGV like shown below.
The way obj is ... -
- %p is for void *. Becuase fprintf is a function with variadic arguments
automatic cast from any pointer to void * does not work. We have to be
explicit. -
- I missed this in bc3e7924bc66d3ef77b219c72f3e59cc154550a3 because the
function is inside of a #ifdef. -
03:15 AM Misc #16417 (Rejected): Mark WEBrick::HTTPUtils.escape as obsolete in line with URI.escape/encode deprecation
- URI.escape has been deprecated for some time now with a warning. This calls `DEFAULT_PARSER.escape` which is `RFC2396_Parser.escape`. At Discourse we have just done some cleanup to remove usage of `URI.escape` and noticed that `WEBrick::...
-
- 79eb5e1acac2339c6ec71db723298bdfcd92b233 implemented
RUBY_TEST_GC_COMPACT=1 so why not make it also possible via the command
line argument. -
12/11/2019
-
-
- My comment here is not primarily related to the threadstarter's comment, but
indirectly. I am struggling a little bit in a cgi/www environment where debug
is a bit difficult. The log files (from lighttpd) show broken pipes related to
... - 07:33 PM Revision 50ae8895 (git): debug_counter.c: include ruby/config.h before stdio.h
- to define _LARGE_FILES
-
-
07:07 PM Revision 7dbbba38 (git): Make sure we don't push MOVED or NONE on the stack
-
- RUBY_TEST_GC_COMPACT=1 enables GC.compact checker which calls
GC.compact after each test. -
- 06:13 PM Revision fe450233 (git): * 2019-12-12 [ci skip]
-
- This makes reference updating look similar to marking, and may avoid
dereferencing a wrong pointer. -
- Isn't part of the problem, that the `ruby_version` variable is read much later than it is used for configuration of MJIT header names? These are the relevant lines:
https://github.com/ruby/ruby/blob/40026a408df5e3576380f6c1d8bf6c119fa... -
- > So maybe respecting --with-ruby-version in the header file name (or removing the version fragment) is the only thing we need to discuss/implement here?
That would be good start. The version there is probably useless.
This is the ... -
- There are created suspicious include directories:
~~~
$ cd /usr/local/include/
[vondruch@localhost include]$ tree
.
└── ruby-2.7.0
├── ruby
│ ├── assert.h
│ ├── backward
│ │ ├── classext.h
│ │ ... -
- koic (Koichi ITO) wrote:
> Thank you very much. It is solved by `**h`.
> ...
Unless I'm missing something, it should be sufficient to drop the braces in the yield, so you are calling the block with keywords instead of a hash:
```rub... -
- This can be solved by refactoring, but yeah it's much more complicated than just adding `**` to the appropriate places :-(
```ruby
def do_something(*args, &block)
yield 'yield_self', {expected: 'then'}
end
def print_something(... -
09:25 AM Feature #14183: "Real" keyword argument
- Thank you very much. It is solved by `**h`.
However, in the following complicated case, it seems difficult to solve using `**h`. This is an interesting use case :-)
```ruby
def do_something(*args, &block)
yield 'yield_self', {exp... -
- Actually scratch that. This might be issue in one of my patches. Sorry for the noise.
-
- Building Ruby, there are some suspicious include directories created:
~~~
$ cd /usr/local/include/
$ tree
.
└── ruby-2.7.0
├── ruby
│ ├── assert.h
│ ├── backward
│ │ ├── classext.h
│ │ ├── cx... -
- I really hope this does not go through.
Regexp literals have been "unduplicated" like this since at least 1.8 and we've never had problems. And now we should freeze them and introduce an incompatibility just for the sake of Communicat... -
- Oops sorry! Applied your patch, thanks!
-
-
- Applied in changeset commit:git|cae657c32492a9b4e72b5e290c143e2c84d4c42d.
----------
Fix .travis.yml to keep s390x-linux as allow_features
[Misc #16360] -
12:49 PM Misc #16360: Enabling IBM PowerPC/Z cases in Travis CI
- You see that "s390x-linux" case was disappeared on the latest master branch Travis now.
https://travis-ci.org/ruby/ruby/builds/623632919
I think it was a wrong way.
The modification to add s390x-linux case to allow_failures could ... -
- Okay, moved to allow_failures.
-
- Applied in changeset commit:git|47a365dd580f2dfe0f0d56155587dfdf2fc7afb7.
----------
Move s390x-linux to allow_failures matrix
ref [Misc #16360] -
- > Hi jaruga (Jun Aruga) ReiOdaira (Rei Odaira)
> ...
But anyway, frequent failures make it difficult to keep trunk sound. Could you contact on Travis CI and fix the issue?
Hi mame (Yusuke Endoh).
Sure, I will take a look at the code... -
- Hi @jaruga @ReiOdaira
Unfortunately, s390x Travis CI fails too frequently.
https://travis-ci.org/ruby/ruby/jobs/623537864
https://travis-ci.org/ruby/ruby/jobs/623487659
https://travis-ci.org/ruby/ruby/jobs/623482529
https://trav... -
- [Misc #16360]
-
- ref [Misc #16360]
-
- https://github.com/ruby/forwardable/commit/aa07c55f3f
-
- This restores compatibility with previous versions. This behavior
was previously undefined, but it makes sense for the name of the
defined method to be returned.
https://github.com/ruby/forwardable/commit/a52ef3451e -
-
- * [Feature #16377] Regexp literals should be frozen (byroot)
* Regexp literals always reference the same mutable instance. This allow to leak global state with `instance_variable_set`
* Change already accepted by Matz about 2 years... -
-
-
- On mingw this test fails and not solved long time, so skip it.
Please revert it when it solved.
https://ci.appveyor.com/project/ruby/ruby/builds/29458671/job/9nbcjnfe6p0xnxoe -
- Thread#to_s returns simple Object#to_s until Ruby 2.4.
-
- `builtin_binary` is sorted by miniruby loading order and this
loading order should be same on ruby. So we can believe sorted
order of `builtin_binary` on boot time. -
-
- because commit info are not necessary in env.
-
-
04:41 AM Bug #16384: Cannot cross-compile 2.7: undefined method `each_builtin' for RubyVM:Class (NoMethodError)
- Updated the description to refer to `rake-compiler/rake-compiler` instead of `qnighy/rake-compiler`. The necessary change to reproduce the problem has landed to upstream.
-
-
- because foo.rb in build directory breaks test-bundler
https://github.com/ruby/ruby/runs/343168046#step:20:125 -
- Hi,
The test fails frequently on cygwin. Could you investigate and fix it?
https://github.com/ruby/ruby/actions?page=1&query=branch%3Amaster+workflow%3ACygwin
Also, it only runs `make btest`.
I'm negative against adding the ... -
-
-
- related https://bugs.ruby-lang.org/issues/16177
-
- Applied in changeset commit:git|85e43e1dfecef69b935c48c235cc20f21bd4f0d4.
----------
Fix Enumerator::Lazy#with_index
* Make it correctly handle lambdas
* Make it iterate over the block if block is given
The original implementation was... -
- * Make it correctly handle lambdas
* Make it iterate over the block if block is given
The original implementation was flawed, based on lazy_set_method
instead of lazy_add_method.
Note that there is no implicit map when passing a block,... - 02:59 AM Revision 8a80bfcf (git): Make Thread#to_s consistent with Method and Proc to_s
-
- 02:25 AM Revision 7e9b1609 (git): Added documentation for integer range sums (#1593)
- 02:25 AM Revision 86e2c013 (git): * remove trailing spaces. [ci skip]
-
- Co-Authored-By: Sutou Kouhei <kou@cozmixng.org>
-
- On cross-compilation, compiled binary can no be created because
compiled binary should be created by same interpreter (on cross-
compilation, host ruby is used to build ruby (BASERUBY)).
So that cross-compilation system loads required sc... -
- prelude.c is an automatically generated file by template/prelude.c.tmpl.
However it does not contain any required functions. So remove it from
dependency.
Also miniprelude.c is included by mini_builtin.c and does not need
to make minipr... -
- `gem_prelude.rb` is not compiled yet. This patch compile it to
compiled binary. -
-
02:15 AM Revision 69aa927a (git): Indicate `find_all` and `select` methods are aliases.
- This matches the documentation for `Enumerable::inject` and `Enumerable::reduce` which are also aliases.
- 02:13 AM Revision 0fafb83b (git): * 2019-12-11 [ci skip]
-
12/10/2019
-
- I have a possible fix for this: https://github.com/ruby/ruby/pull/2742
After CI completes, I'll try to merge it so it makes 2.7.0-rc1. -
- I agree this is a bug. The with_index block should be called with two arguments, not an array with one argument.
The reason this happens is that `Enumerator::Lazy#with_index` ends up calling `Enumerator::Yielder#<<` (`yielder_yield_p... -
01:09 PM Bug #16414 (Closed): Incompatible behavior of Proc/lambda with single argument when using `Enumerator::Lazy#with_index`
- The following code raised an error `wrong number of arguments (given 1, expected 2) (ArgumentError)` in master.
```
$ ruby -e 'lambda = -> (s, i) { "#{i}:#{s}" }; p %w(a b c).each.lazy.with_index.map(&lambda).first(2)'
# expected re... -
04:51 PM Feature #15425: Store MJIT header into Ruby versioned directory.
- > why the file is versioned
Basically rubyarchhdrdir directory should protect the header from different Ruby versions, but you almost proved that it's necessary when you passed `--with-rubyhdrdir=/usr/include --with-rubyarchhdrdir=/u... -
- It seems stored in the `rubyarchhdrdir` already.
```
$ LC_ALL=C tree usr/include/
usr/include/
|-- rb_mjit_min_header-2.7.0.h
|-- ruby
| |-- assert.h
| |-- backward
| | |-- classext.h
| | |-- cxxanyargs.hpp
| | ... -
-
- Thank you for the report and tests.
As for the `option` tests, `PTY.spawn` can fail after `PTY.open`, so could you separate `ensure` or use the block form of `PTY.open`?
And as it doesn't seem necessary to be `PTY`, doesn't `IO.pipe` s... -
- タイムアウトの方は、unstable11s の /etc/hosts がおかしな設定になっていたためで、設定の方を直してもらったので大丈夫なはずです。（3be3948870f6589343c4aecb541e22fae7751b47 と 188c2b67c9365fcf75a595186d95c325f06b9182）
BUG の方は忘れてしまったのですが、なんか直したような記憶があり、いますでにskipなしでも動いてるので多分大丈夫ではないかと思います。
... -
-
- https://github.com/ruby/logger/commit/d6c01cc652
-
- https://github.com/ruby/logger/commit/bcd7e227e8
-
- Fixes Ruby Bug 16349.
https://github.com/ruby/logger/commit/b1b6d06f2d -
- Consider 'now' and 'everytime' as valid values for the previous
behavior of rotating everytime.
Fixes Ruby Bug 15977
https://github.com/ruby/logger/commit/f92979a376 - 11:58 AM Revision eb18cb3e (git): [ruby/logger] Honor Logger#level overrides
- https://github.com/ruby/logger/commit/7365c995bf
-
- I made a PR for it: https://github.com/ruby/ruby/pull/2738
-
- [Proc#to_s returns "... file:line" instead of "...@file:line"](https://bugs.ruby-lang.org/issues/16101), but `Thread#to_s` includes `@`.
I think changing `Thread#to_s` too is better for consistency. -
10:54 AM Bug #16413: Net::FTP#put で書き込みエラーが発生した時のコネクション切断
- ありがとうございます。
アップロード失敗時にコネクションが残らないことが確認できました。 -
10:28 AM Bug #16413: Net::FTP#put で書き込みエラーが発生した時のコネクション切断
- 履歴を見た感じ特に理由は無さそうですね。
https://github.com/ruby/ruby/pull/2737 で直りますでしょうか -
- ### 疑問
`Net::FTP#storbinary` などをみると、 `conn.write` で例外が発生した際に `conn.close` を呼ばない実装だと思います。
https://github.com/ruby/ruby/blob/7be550d046c726c2a3aa625ceb260d9b2268fb5a/lib/net/ftp.rb#L683-L707
一方で `Net::FTP#retrbinary` では `conn.shutdo... -
- 54072e329cab7207fba133caba4fc12b45add8f9
-
-
-
-
-
-
- It produced a warning about type cast in LLP64 (i.e., windows).
-
-
-
-
- https://github.com/ruby/io-console/commit/ae5c72e481
-
- https://github.com/ruby/io-console/commit/21338ab287
-
- https://github.com/ruby/io-console/commit/499ff3de48
-
-
- Merged at 1bdabaa6b13344c195698ca5b0ced323cb93e2e1. Thank you for the contribution.
-
05:32 AM Revision 1bdabaa6 (git): base64.rb: improve performance of Base64.urlsafe_encode64
- * lib/base64.rb: avoid unnecessary memory allocations
-
-
- and add more stop_pool after stop_service
-
-
-
- I'm aware of `**nil` and it's true that it provides fully safe keyword extension. But you have to admit it's not likely to become common practice amongst rubyists. You'd have to add it to every regular method in advance, just in case it ...
-
- ... like we do so for struct timeval at several hundreds of lines above.
Depending on OS/Compiler, this can be the first place for the struct to
appear. To make sure the struct is global, we need a forward
declaration at this point. -
- https://rubyci.org/logs/rubyci.s3.amazonaws.com/ubuntu1604/ruby-master/log/20191210T003005Z.log.html.gz
```
.../test/ruby/test_keyword.rb:2711: warning: `*' interpreted as argument prefix
``` -
01:16 AM Bug #16288: Segmentation fault with finalizers, threads
- I was fiddling around a bit, and trying to understand how things work, for my own edification.
``` diff
diff --git a/eval.c b/eval.c
index 1eeaec56cb..097a105b33 100644
--- a/eval.c
+++ b/eval.c
@@ -238,6 +238,7 @@ ruby_cleanup(... -
- Because the test fails under HTTP proxy settings.
https://rubyci.org/logs/rubyci.s3.amazonaws.com/solaris10-gcc/ruby-master/log/20191210T000004Z.fail.html.gz
```
1) Failure:
TestNetHTTPS#test_get_SNI_failure [/export/home/users/chkbui...
12/09/2019
-
- https://github.com/ruby/www.ruby-lang.org is the repository of the web site. I've created a pull request https://github.com/ruby/www.ruby-lang.org/pull/2304
Thanks! -
- I think the tracker is ok since it is the official ruby-site. "Bug", though, usually
refers to ruby itself (e. g. MRI ruby written in C and compiled); might be put
into Misc here, but it's not really that important either way. -
04:02 PM Bug #16409 (Closed): Ruby User's Guide 404
- On the webpage https://www.ruby-lang.org/en/documentation/ , when you click on the "Ruby User's Guide" (which is a link to http://www.rubyist.net/~slagell/ruby/), the page gives you a 404 error.
I apologize if this is not the proper ... -
- Dan0042 (Daniel DeLorme) wrote:
> Yeah, `**!?` in itself was a joke placeholder intended to mean "insert funky new syntax here but I'm not sure what exactly"
> ...
Actually, if you want safe keyword extension, you can do so for new met... -
- Yeah, `**!?` in itself was a joke placeholder intended to mean "insert funky new syntax here but I'm not sure what exactly"
It's true that one rationale of keyword argument separation was to allow safe keyword extension. This would ha... -
- I don't think adding **!? would be a good idea. I'd also ideally keep
the complexity in ruby less, when possible; it's (to me) interesting
to see that keywords add to the complexity. Ideally it should be so
simple for everyone to unde... -
- The problem of safe keyword extension has been [described like this](https://bugs.ruby-lang.org/issues/14183#note-29):
```ruby
#We have an existing method
def debug(*args)
args.each {|arg| puts arg.inspect }
end
#It can be in... -
- In general, optimization should be invisible from users (except performance). This kind of redefinition checks in VM are carefully designed to be invisible.
Apparently, `Struct#select` is defined for the sake of performance improveme... -
- In the case that a method is overridden _only_ for optimization's sake, the override check is simply the equivalent of deoptimizing when a required constraint doesn't hold. This is pretty common in a VM right?
-
- Matz, do you accept the suggested patch?
To be honest, I'm negative against this patch. It brings false consistency. The current behavior is very easy to explain; `Struct#select` is just overridden. A redefinition check is a magic. -
- Reline performs completion in a case-insensitive fashon if
Readline.completion_case_fold or completion-ignore-case of .inputrc are set
"on". -
09:18 PM Feature #15605: json library needs more frequent releases
- I can build and push the json gem for JRuby any time. I'm on the ruby-lang slack today, just tell me what repo/branch needs to be pushed out!
-
08:18 PM Feature #9758: Allow setting SSLContext#extra_chain_cert in Net::HTTP
- This change is still blocking X509 certificate presentation with Net::HTTP, specifically when an intermediate certificate is required. The current workaround is to create a mixin for the Net::HTTP module (see the blog post linked in the ...
-
06:38 PM Bug #16399: TracePoint.stat disappeared in Ruby-2.7.0-preview3
- Thank you for taking the time to test out 2.7.0-preview3!
-
- @hsbt Would you mind to reconsider as we are getting closer to the release?
-
- I observe the following spec error:
~~~
$ make test-all TESTS="spec/ruby/core/file/utime_spec.rb" MSPECOPT="-fs"
./revision.h unchanged
ruby 2.7.0dev (2019-12-09 master c2dc27d643) [x86_64-linux]
... -
04:22 PM Bug #15794: Can not start Puma with Rails after bundle install
- dportalesr (Daniel Portales) wrote:
> dohaibac (Bac Do) wrote:
> ...
After install memcached i got the message ../../active_record/connection_adapters/postgresql_adapter.rb:651: bla bla bla
I tried update ruby from 2.3.7 to 2.4.X... -
- Committed at commit:f45c0dc23980d7fd8167d290ea7c354cf2cdb500.
-
06:59 AM Feature #16404: Add Proc#ruby2_keywords
- It is ugly, and I personally don't want to add it to the language. But I have to admit it solves the real-world issues in some cases. So I accept. This might be removed sometime in Ruby3.x (after proper deprecation process).
Matz.
- 03:10 PM Revision 562fd754 (git): * 2019-12-10 [ci skip]
-
- This allows passing keywords through a normal argument splat in a
Proc. While needing ruby2_keywords support for methods is more
common, there is code that delegates keywords through normal
argument splats in procs, including code in Ra... -
- From what I remember of Windows, `Find.find('D:')` would search in the current directory of D:
My guess is that you're actually executing the first script from `D:\Downloads\Ruby 2.5.3\rbL\comp\` and the second script from `D:\` (or may... -
06:55 AM Misc #16396: What is the reason for this behaviour of Find.find?
- > pp Dir['/tmp/**/**/']
Hello, I loved your alternative, from now on I'll use Dir.
Regarding the "bug" of Find I think I can prove it one of these days I report it. -
- And I can trigger different errors:
~~~
$ make test-all TUST="" TESTS="test/optparse/test_did_you_mean.rb test/ruby/test_env.rb"
fatal: not a git repository (or any of the parent directories): .git
./revision.h unchanged
Run optio... -
- This is shorter reproducer:
~~~
$ make test-all TESTS="test/optparse/test_did_you_mean.rb test/ruby/test_env.rb"
fatal: not a git repository (or any of the parent directories): .git
./revision.h unchanged
Run options: "--ruby=./mi... -
- Ah, finally I understand where does the issue comes from. I execute the test suite via:
~~~
$ ./configure && make -j && make test-all TESTS="-v "
~~~
(actually this is the specific command [1]) and apparently the `TESTS` comes fr... -
- ruby_2_6 r67831 merged revision(s) 7d805e67f3275aef066d77aa9c32bef715c362ed.
-
- Avoid triggering autoload in Module#const_defined?(String)
[Bug #15780]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_6@67831 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_6 r67830 merged revision(s) e1b592b508c72a56ae012869d97fe1580ff87246,d10451f3fd51f577e704db770de48d05044eb45c.
-
- ruby_2_6 r67830 merged revision(s) e1b592b508c72a56ae012869d97fe1580ff87246,d10451f3fd51f577e704db770de48d05044eb45c.
-
- test_module.rb: fix a typo
* test/ruby/test_module.rb (TestModule#test_nested_get): fix a
typo. nested module's name is a qualified path.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67471 b2dd03c8-39d4-... -
-
- Applied in changeset commit:git|54072e329cab7207fba133caba4fc12b45add8f9.
----------
Add ipaddr optional parameter to Net::HTTP#start
to replace the address for TCP/IP connection [Feature #5180]
There're 3 layers of hostname:
* host a... -
-
- Applied in changeset commit:git|54072e329cab7207fba133caba4fc12b45add8f9.
----------
Add ipaddr optional parameter to Net::HTTP#start
to replace the address for TCP/IP connection [Feature #5180]
There're 3 layers of hostname:
* host a... -
- Duplicated with #5180.
Since there're 3 layers:
* host address for TCP/IP
* TLS server name
* HTTP Host header
In this use case, I think you wan to set different value for IP layer.
If you forget to change HTTP Host header, it wi... -
- to replace the address for TCP/IP connection [Feature #5180]
There're 3 layers of hostname:
* host address for TCP/IP
* TLS server name
* HTTP Host header value
To test DNS round robin or check server certificate from server local,
peop... -
-
- The assigned value to `ENV` are stored in the process's environment variable.
The encoding of `ENV[key]` is set as locale.
You can get the locale encoding by `Encoding.find("locale")` which is decided based on `Encoding.locale_charma... -
- It is intentional according to naruse. The encoding of ENV depends on the environment variable LANG.
-
-
- This commits are based with:
https://github.com/ruby/logger/commit/f067f7d1aa743b467d633ec6d1790bd93ed9e25b
https://github.com/ruby/logger/commit/86058f420d8f6909500cccceb24f58bef0597b4d
https://github.com/ruby/logger/commit/... -
10:17 AM Revision ff7cc0dc (git): [ruby/logger] 1.4.1
- https://github.com/ruby/logger/commit/5987f518d1
-
- https://github.com/ruby/logger/commit/31efbb29ff
-
- https://github.com/ruby/logger/commit/8127ce0b56
-
10:17 AM Revision 6158e28f (git): [ruby/logger] Avoid creating [] and "" when logging an Exception that has no backtrace
- https://github.com/ruby/logger/commit/75fd308053
-
- https://github.com/ruby/logger/commit/a057eede7b
-
- https://github.com/ruby/logger/commit/5f70168ac5
-
- It is feature.
What it does when it's specified `xml: :text` is just like below:
```ruby
"\u016f".encode('ISO-2022-JP', fallback: proc { |c| "&\#x#{c.encode('UTF-8').ord.to_s(16)};" }).encode('UTF-8')
``` -
-
-
-
-
-
- As a general principle, I agree with Jeremy. But for this case only, @Eregon's "90% compatibility" sounds too tempting.
When we need to ask upgrading Ruby versions, it's far easier for users to upgrade within 2.5 or 2.6 than to 2.7 (or 3... -
- (This is the second try of 036bc1da6c6c9b0fa9b7f5968d897a9554dd770e.)
If iseq is GC'ed, the pointer of iseq may be reused, which may hide a
deprecation warning of keyword argument change.
http://ci.rvm.jp/results/trunk-test1@phosphorus... -
-
-
- This reverts commit 036bc1da6c6c9b0fa9b7f5968d897a9554dd770e.
This caused a failure on iseq_binary mode.
http://ci.rvm.jp/results/trunk-iseq_binary@silicon-docker/2474587
Numbering iseqs is not trivial due to dump/load. -
- This reverts commit 751a9b32e5a53336768eb878de1827245a3292bf.
-
-
- @koic, would this not be good enough for your case?
```ruby
str = 'Hello, %<foo>s, %<bar>s'
ary = [foo: 'foo', bar: 'bar']
ary.each do |h|
format(str, **h)
end
```
But I have to say this would not even have been an issue ... -
- The function assumed that the LSB of `callee` was 0.
-
- If iseq is GC'ed, the pointer of iseq may be reused, which may hide a
deprecation warning of keyword argument change.
http://ci.rvm.jp/results/trunk-test1@phosphorus-docker/2474221
```
1) Failure:
TestKeywordArguments#test_explicit_s... -
- A quick search yields the following files that have both a rb and so version:
```
/opt/ruby/2.7/lib/ruby/gems/2.7.0/gems/redcarpet-3.5.0/lib
redcarpet.so
/opt/ruby/2.7/lib/ruby/gems/2.7.0/gems/debug_inspector-0.0.3/lib
de... -
02:13 AM Bug #16402: UTF-16LE BOM causing regex match to fail with "invalid byte sequence in UTF-8"
- Submitted a question to httpclient on https://github.com/nahi/httpclient/issues/413