Activity
From 10/31/2019 to 11/06/2019
11/06/2019
-
11:12 PM Revision e58814d1 (git): Revert "Use a monotonically increasing number for object_id"
- This reverts commit bd2b314a05ae9192b3143e1e678a37c370d8a9ce.
-
10:59 PM Revision bd2b314a (git): Use a monotonically increasing number for object_id
- This changes object_id from being based on the objects location in
memory (or a nearby memory location in the case of a conflict) to be
based on an always increasing number.
This number is a Ruby Integer which allows it to overflow the ... -
10:16 PM Revision d1630d41 (git): Promote open3 to default gems
-
-
-
-
10:12 PM Misc #16234: Enabling ARM 64/32-bit cases by Drone CI
- Fixed in 40e161a61238625e1ef021311759b2159be5b50a
-
- RUBY_PLATFORM is `armv8l-linux-eabi` there, I'll adapt the `platform_is` guard.
-
- About the clock_getres() specs, it seems they fail because I guess on Drone CI, clock_getres(CLOCK_PROCESS_CPUTIME_ID) returns 1ns, but it seems CLOCK_PROCESS_CPUTIME_ID results are all in 10ns (last digit is always 0).
Probably we ca... -
07:26 PM Misc #16234: Enabling ARM 64/32-bit cases by Drone CI
- As another issue, there are 2 test failures in spec/ruby/core/process/clock_getres_spec.rb on Drone CI arm32 case.
https://cloud.drone.io/ruby/ruby/619/1/2
```
1)
Process.clock_getres matches the clock in practice for Process::CL... -
- Shall we add debug code to investigate a random "make install" error on arm64 to `.travis.yml`?
At least we can remove current existing debugging code for Mac OSX after "make install" in `.travis.yml`.
This pull-request is the sugges... -
- I sent a pull-request to fix following failure on Travis arm64.
https://github.com/ruby/ruby/pull/2653
```
1)
Process.spawn joins the specified process group if pgroup: pgid FAILED
Expected (STDOUT): "0"
but got: "34876... -
- * See https://bugs.ruby-lang.org/issues/16234#note-16
-
08:45 PM Feature #16295: Chainable aliases for String#-@ and String#+@
- byroot (Jean Boussier) wrote:
> phluid61 (Matthew Kerwin) wrote:
> ...
I think most of that functionality is equivalent to implementation detail, as far as String itself is concerned. Deduplication is a concern of the ObjectSpace.
I... -
10:59 AM Feature #16295: Chainable aliases for String#-@ and String#+@
- phluid61 (Matthew Kerwin) wrote:
> It doesn't exactly fit the way messages are named in Ruby, but how about:
> ...
`-@` does more than freezing the string, it also lookup the fstring table and potentially returns you a pre-existing ins... -
05:53 PM Revision a1be11eb (git): Revert "Remove arm64 from allow_failures"
- This reverts commit 212f4d49bac844b3c0fa52f2185b3df30aa62e75.
It worked on PR, but master branch builds have another build issue.
https://travis-ci.org/ruby/ruby/jobs/608303393 -
- 05:09 PM Revision 7750edd1 (git): * 2019-11-07 [ci skip]
- 05:08 PM Revision f5c7fc49 (git): Fix spawn_spec.rb for Travis arm64 environment.
- The process group id (/proc/[pid]/stat 5th field) is 0
in the Travis arm64 environment.
This is a case where it is available.
$ cat /proc/4543/stat
4543 (ruby) S 4525 4525 1384 34818 4525 4194304 37443 1754841 0 0 366 105 2291 391 20 0... -
- > I think we all agree this is a good way to "deprecate" methods returning mutable strings and let them return frozen strings in the future, isn't it?
> ...
Agreed, not sure if we can still hope for the `Symbol#to_s` to make it to 2.7, ... -
- Dan0042 (Daniel DeLorme) wrote:
> And for that I think it's necessary to handle the situation of `str = str.dup if str.frozen?` which is a pretty common pattern in ruby code.
Right, it is useful for that pattern at least.
I think `S... -
- hsbt (Hiroshi SHIBATA) wrote:
> This discussion started with "how big the incompatibility is?" at https://bugs.ruby-lang.org/issues/16150#note-18
> ...
Thank you for the more detailed explanation.
IMHO, requiring to update (not upgr... -
- duerst (Martin Dürst) wrote:
> I didn't find the text "a possible incompatibility reported by one user" anywhere in this issue.
It's my interpretation and the only piece of information I had so far from https://github.com/heroku/hero... -
- This discussion started with "how big the incompatibility is?" at https://bugs.ruby-lang.org/issues/16150#note-18
The old version of Rails is incompatible. And I also got the issue of `middleman` depends on `memoist`. So, my company b... -
12:29 AM Feature #16150: Add a way to request a frozen string from to_s
- Just to cross-check:
Eregon (Benoit Daloze) wrote:
> I find it frustrating that the change is reverted without much else than "a possible incompatibility reported by one user"
I didn't find the text "a possible incompatibility r... -
03:46 AM Bug #16293 (Closed): Numbered parameter confirmation in Ruby 2.7
- Applied in changeset commit:git|82e840ad15bba42b399a21de746967a731240ec2.
----------
Numbered parameter cannot appear outside block now [Bug #16293] -
- > ```ruby
> ...
The "outside block" warning is shown at assignment to a local variable looks like a numbered parameter.
There is no assignment.
> ```ruby
> ...
This is a bug.
As numbered parameter looks like an ordinary variable n... -
12:58 AM Bug #16293: Numbered parameter confirmation in Ruby 2.7
- Thank you all.
I updated text. -
-
-
-
- For instance, `Rational.allocate` is undefined.
```ruby
Rational.allocate #=> undefined method `allocate' for Rational:Class (NoMethodError)
```
But it can be called by `Class.instance_method(:allocate)`.
```ruby
Class.instan... -
01:11 AM Feature #16294: Make MatchData frozen and forbid MatchData.allocate
- I'm not against the proposal itself, but is it okay to introduce an incompatibility at this time? cc: @naruse
-
- It would be OK to remove `MatchData.allocate`, I think.
And `Regexp.allocate` too, but rubyspec has a couple of code using `Regexp.allocate`. -
- Applied in changeset commit:git|aa94245a09887f95bc0cd353b3462108d76d13ed.
----------
Undefine MatchData.allocate [Feature #16294] -
12:56 AM Feature #16296: Alternative behavior for `...` in method body if `...` is not in method definition
- This proposal would change ... though and add a new meaning.
People then have to remember that ... can be omitted in
definitions too.
I am not sure that this is the same use case as the prior one
where ... had to be used in both t... -
12:46 AM Revision 5251d189 (git): Time#strftime does not support `%Q`
- ```
% ruby -r date -e 't=Time.utc(2001,2,3,4,5,6,7);p t; p [t, t.to_date, t.to_datetime].map{|d|d.strftime("%Q")}'
2001-02-03 04:05:06.000007 UTC
["%Q", "981158400000", "981173106000"]
```
11/05/2019
-
-
- I'm sorry if the above is rude.
I find it frustrating that the change is reverted without much else than "a possible incompatibility reported by one user" and for which we already have a plan to address it easily (just use the latest ... -
- naruse (Yui NARUSE) wrote:
> As already Matz stated, I reverted this at bea322a3.
So you reverted without a single case that was actually problematic due to the change?
I'm very disappointed, deprecation without a proper explanation... -
- If that change is reverted, could we make it a deprecation instead?
Any idea how such deprecation warning would be implemented? -
08:38 AM Feature #16150 (Open): Add a way to request a frozen string from to_s
- Eregon (Benoit Daloze) wrote:
> I agree it's not ideal, but I also feel it's really not the biggest problem for Ruby 2.7 in production, and we already have a good plan.
> ...
Yes, keyword argument is the most difficult challenge for Ru... -
- FWIW, I think it would be better to freeze all Method and UnboundMethod objects.
Is there any use-case for adding instance variables to them? -
- I like `#dedup` for `String#-@`, partly for the relation with `#dup`.
For `String#+@`, I'd propose `#buffer` like `buf = ''.buffer`.
I don't like `mut`. -
- It doesn't exactly fit the way messages are named in Ruby, but how about:
```ruby
alias -@ frozen
alias +@ thawed
``` -
- I agree that + and - are not very elegant, as names. They are not very meaningful (as names).
On the other hand they are short, so from this point of view, useful in a practical manner,
but this is actually the main reason why I pref... -
- Original discussion https://bugs.ruby-lang.org/issues/16150?next_issue_id=16147&prev_issue_id=16153#note-40
In #16150, @headius raised the following concern about `String#-@` and `String#+@`:
headius (Charles Nutter) wrote:
> > No... -
04:53 PM Feature #16296 (Open): Alternative behavior for `...` in method body if `...` is not in method definition
- In #16253 we settled on a syntax where the remainder arguments captured via `...` in the method definition can be forwarded via `...` in the method body. I think that was the correct decision.
But I can't forget about the use case [pr... -
- Ripper reuses parse.y for its implementation. Ripper changes the
grammar productions to sometimes return Ruby objects. This Ruby objects
are put in to the parser's stack, so they must be kept alive. This is
where the "mark_ary" comes ... -
- The present behaviour:
```ruby
def _1; end
```
seems correct and osyo's example of expecting a warning instead seems incorrect to me, unless
he meant it in in some other context. (It is indeed difficult to break the suggestion d... -
- It is difficult for me to analyze this ticket, too. Could you write your expectations and the actual results?
```ruby
# expected: warning: `_1' is used as numbered parameter
# actual: no warning
def hgoe(_1)
end
```
```ruby
... -
- I couldn't understand your request. Please summarize actual and expect behavior with your request.
-
## Overview
I want to make a final check on the behavior of Numbered parameter( No warning or Warning or Error).
There is a difference in [DevelopersMeeting20190829Japan logs](https://docs.google.com/document/d/1XypDO1crRV9uNg1_ajx...- 03:39 PM Revision d47b6434 (git): * 2019-11-06 [ci skip]
- 03:31 PM Revision 07f2062c (git): Improve string literal concatenation for C++11
- Downstream C++ projects that compile with C++11 or newer and include
the generated config.h file issue compiler warnings. Both C and C++
compilers do string-literal token pasting regardless of whitespace
between the tokens to paste. C++ ... -
- We've been recently bitten by this.
Does the merge of [#15553] makes https://github.com/ruby/ruby/pull/1806 functional? -
- Currently, `MatchData.allocate` is allowed, but almost every MatchData method called on it `raise TypeError, 'uninitialized Match'`.
I think MatchData should be frozen, none of its internal fields are mutable and I don't see any use c... -
- * [Feature #16293] Numbered parameter confirmation in Ruby 2.7
* Numbered parameter confirmation in Ruby 2.7 -
12:06 PM Revision 6aacef49 (git): Assert return value of Readline.readline only if Ruby is before 2.7
-
11:57 AM Revision c4b627e2 (git): Only taint on Ruby <2.7
- Ruby 2.7 deprecates taint and it no longer has an effect.
-
- Untaint is deprecated and has no effect on Ruby 2.7+.
-
11:38 AM Feature #16275: Revert `.:` syntax
- I'm also in favor of what Tim stated but at the same time, I want to point out, that the way it is now is not optimal from the performance point of view.
Ruby gives you a new instance of a `#Method` class. Even when you’re fetching th... -
- Makes sense to me what mame wrote, so +1; marcandre's suggestion for a deprecation-specific
notice makes sense as well and may be useful past ruby 3.0 (if ruby 4.x may have more
incompatibilites than ruby 3.0; then there could be more ... -
- NOTE: warning message should be improved if this is deprecated before 2.7.0.
-
03:30 AM Feature #13083 (Open): Regexp#{match,match?} with a nil argument are deprecated and will raise a TypeError in Ruby 3.0
- Eregon (Benoit Daloze) wrote:
> shugo (Shugo Maeda) wrote:
> ...
Thank you.
I reopen this issue for further discussion. -
-
- Make `MultiFormatter` a module and extend the formatter specified
by "-f" option. -
- Rmoved optional parameter `printed_exceptions`, and clear
`exceptions` just after printing each exception, instead. -
- Let the method of `DottedFormatter` subclasses have the same
arity. -
- This reverts commit 6ffc045a817fbdf04a6945d3c260b55b0fa1fd1e.
-
07:46 AM Feature #16290: Add Ruby C API to acquire aligned memory
- naruse (Yui NARUSE) wrote:
> shyouhei (Shyouhei Urabe) wrote:
> ...
In case of this request, ImageMagick already _does_ have aligned allocator. If we provide one we would use any of 5 backends but that is not required at all. They al... -
- shyouhei (Shyouhei Urabe) wrote:
> I'm not in favor of this. There are many ways to allocate a memory region, like mmap(2). Do we have to provide ruby counterparts for every and all of them?
rb_aligned_malloc uses 5 underlying impl... -
- I'm not in favor of this. There are many ways to allocate a memory region, like mmap(2). Do we have to provide ruby counterparts for every and all of them?
-
- jonathanhefner (Jonathan Hefner) wrote:
> duerst (Martin Dürst) wrote:
> ...
In my sentence above, 'that' refers to 'an O(n) implementation'. Naive implementations don't have that problem, but they are slow (O(n²)).
> Here is a naiv... - 06:31 AM Revision 853d91a0 (git): Fix coroutine support on win32
- Ruby master branch currently fails on win32 MINGW at this spec:
https://github.com/ruby/spec/blob/master/core/thread/element_set_spec.rb
MINGW makes use of setjmp3() implemented in MSVCRT.DLL.
This function traverses the SEH list up to ... -
- I don't have a control on docs.ruby-lang.org. Please file another ticket or issue on https://github.com/ruby/docs.ruby-lang.org/issues to get its maintainer's attention.
-
- ISO/IEC 9899:1999 section 6.7.8 specifies the values of static
storage which are not explicitly initialized. According to that
these initializers can be omitted. Doing so improvoes future
compatibility against addition / deletion of th... -
- Noticed that rb_method_basic_definition_p is frequently called.
Its callers include vm_caller_setup_args_block(),
rb_hash_default_value(), rb_num_neative_int_p(), and a lot more.
It seems worth caching the method resolution part. Major... -
- Years ago I thought we don't need any per-class extension of rb_obj_freeze. However it seems rb_str_freeze is a thing and rb_ary_freeze can benefit the same way. I think it's now clear that there should be a C API that does `rb_funcall...
-
- Applied in changeset commit:git|8869384367a1b5e856b2f4b7b7d56296c71a572c.
----------
Moved Init_encoding from wrong place [Bug #16292] -
-
-
11/04/2019
-
- Instead run test-bundled-gems.rb by `ENV['RUBY']`, which should be
set by runruby.rb. -
- We track recursion in order to not infinite loop in ==, inspect, and
similar methods by keeping a thread-local 1 or 2 level hash. This allows
us to track when we have seen the same object (ex. using inspect) or
same pair of objects (ex. ... -
-
11:03 PM Revision 74bb8fb3 (git): More rdoc for ENV
-
09:49 PM Bug #16288: Segmentation fault with finalizers, threads
- ```
modified lib/timeout.rb
@@ -94,7 +94,7 @@ def timeout(sec, klass = nil, message = nil) #:yield: +sec+
ensure
if y
y.kill
- y.join # make sure y is dead.
+ # y.join # make sure y... -
- mame (Yusuke Endoh) wrote:
> Thank you for the report and the great investigation! I could reproduce the issue by using your example: https://github.com/mainameiz/segfault_app
Thanks for checking in to it.
> ...
Yes, I think ther... -
- Actually, after rereading what Jonathan wrote, he referred not to "true" values
per se, but as to whether "non nil values" are to be included. So perhaps I
misunderstood his comment. I think that filter still applies to the .select
an... -
- Jonathan recently added this to the upcoming developer discussion (at https://bugs.ruby-lang.org/issues/16262),
in regards as to whether the current behaviour is correct, or whether it should include non-nil values as well.
The quest... -
09:35 PM Feature #11660: a falsy value (similar to js undefined) that facilitates forwarding of default arguments
- > Ruby having a single nil, instead of JavaScript's null and undefined, is a net benefit, in my opinion.
undefined signals the absence of a value and makes possible composable default value design, where missing arguments can be forw... -
05:42 PM Feature #11660: a falsy value (similar to js undefined) that facilitates forwarding of default arguments
- bughit (bug hit) wrote:
> The penalty the language pays is it has a demoware, checklist item, default value feature, where in any non-trivial scenario you have to produce the default value twice, first the intermediate default value thr... -
- > The "penalty" I pay for this is one line of code
The penalty the language pays is it has a demoware, checklist item, default value feature, where in any non-trivial scenario you have to produce the default value twice, first the int... -
- alanwu (Alan Wu) wrote:
> Since the beginning of time (correct me if I'm wrong), the two falsy values in Ruby has been `false` and `nil`, period.
> ...
I Agree. Not saying there's no benefit, but this is too big a change for too small ... -
10:24 AM Feature #11660: a falsy value (similar to js undefined) that facilitates forwarding of default arguments
- The "penalty" I pay for this is one line of code like `period = Undefined.default(period, :day)`. Given this doesn't occur very often I don't see how "compiler support" would be beneficial.
-
09:13 PM Misc #16262: DevelopersMeeting20191128Japan
- * [Feature #15323] Enumerable#filter_map
* This feature has already been merged, but there may have been some confusion regarding the implementation.
* It currently selects only truthy values, but should it select all non-nil value... -
- I use monkey-patched versions of these in many of my Ruby scripts. They have a few benefits vs. the alternatives:
* vs. `split` + `first` / `last`
* using `split` can cause an unintended result when the delimiter is not present, e... -
- Related to this change, would it be possible to redirect https://docs.ruby-lang.org/en/trunk/ to https://docs.ruby-lang.org/en/master/ ? There are links in various third-party docs and online articles which still point to https://docs.r...
-
- duerst (Martin Dürst) wrote:
> Well, that assumes that the block return values can be ordered. But it's easy to create cases where values can be compared for equality, but not ordered. Example: `[1, 'abc']`.
I'm not sure that I follo... -
05:51 PM Bug #16292 (Closed): Allow RDoc & YARD to find Encoding class doc's
- Documentation code (RDoc, YARD) cannot pick up the class comments for Encoding after the following commit:
https://github.com/ruby/ruby/commit/6546aed4757be07f4932326e1eb41a5d69141acf
A solution is to move lines 1919 thru 1924 above ... -
-
- Removed `if` conditions separating `test-bundled-gems`, and pass
`TESTOPTS` and `TEST_BUNDLED_GEMS_ALLOW_FAILURES` via `env`. -
-
- This commit is to attempt fixing this error:
http://ci.rvm.jp/results/trunk-gc-asserts@ruby-sky1/2353281
Each non-full heap_page struct contains a reference to the next page
that contains free slots. Compaction could fill any page, ... -
- > > If they only warn once, they are not that annoying, and people may be less inclined to fix the issue.
> ...
I think the issue is more that in a long-lived process you'll get only a few warnings in a large log, and it may be easy to ... -
-
- Eregon (Benoit Daloze) wrote:
> For this discussion, I would focus on having this for Strings only initially.
Fair enough. I don't see much point in having this for objects other than strings. Focusing on strings might simplify the i... - 03:07 PM Revision bd3463ee (git): * 2019-11-05 [ci skip]
-
-
-
- I like to share my investigation about below issue (random error) at "make install" on arm64 environment.
https://travis-ci.org/ruby/ruby/jobs/606916890#L2412
```
cp: cannot create regular file '../../.ext/common/json.rb': Permiss... -
- It is unnatural and probably a typo.
-
- Is there a benefit to the change apart from consistency? A concrete benefit I mean.
-
01:45 PM Feature #16291 (Assigned): Introduce support for resize in rb_ary_freeze and prefer internal use of rb_ary_freeze and rb_str_freeze for String and Array types
- References Github PR https://github.com/ruby/ruby/pull/2640
### Why?
While working on https://github.com/ruby/ruby/pull/2037#issuecomment-548633141 I also looked at the `rb_ary_freeze` helper to determine if the same optimization o... -
- This reverts commit ba35c14325ebbf1da8f200df83c45ee9937ff8a1.
This is because ripper fails symbol lookup error. -
- It is unnatural and probably a typo.
-
09:16 AM Feature #16290 (Closed): Add Ruby C API to acquire aligned memory
- Related to https://github.com/ruby/ruby/pull/2614
I have required to acquire aligned memory in Ruby C-extension library (https://github.com/rmagick/rmagick/pull/832).
I want an API that notifies acquired size to Ruby GC.
Of course... -
-
-
- It looks like hanging up when fetching from a remote first time.
-
- https://github.com/ruby/racc/commit/a887ebe529
- 12:18 AM Revision 046be65c (git): * 2019-11-04 [ci skip]
-
11/03/2019
-
- > For this purpose I built a special value a while ago
What purpose? Surely you understand that your special value, having no compiler support, does not trigger default value computations.
You are making my point. Your Undefined is... -
- For this discussion, I would focus on having this for Strings only initially.
I don't think it's about the "grand design of immutability", but rather a tool to ease migration towards frozen Strings for some APIs.
My main concern abou... -
- Dan0042 (Daniel DeLorme) wrote:
> Since returning a frozen string from Symbol#to_s [was reverted](https://bugs.ruby-lang.org/issues/16150#change-82420), it looks like this proposal is still relevant.
It's not reverted (yet at least). -
-
-
-
- shugo (Shugo Maeda) wrote:
> Code like `/regex/ =~ str` has often been used when `str` may be `nil`, and such code has been rewritten using Regexp#match? after Ruby 2.4.
> ...
That's a good point.
We can still discuss on this ticket w... -
- kachick (Kenichi Kamiya) wrote:
> How about https://github.com/ruby/ruby/pull/2637?
I merged that PR, thank you.
Regexp#{match,match?} with a nil argument now just warns.
The plan is then to make them raise TypeError in Ruby 3.0. -
- matz (Yukihiro Matsumoto) wrote:
> Thank you for the input. If you can provide a more detailed situation, it would be better.
My situation is the same as Rafael's, and I fixed my code using the safe navigation operator:
https://... -
-
-
- 10:03 AM Revision 985e6ced (git): * 2019-11-03 [ci skip]
-
10:03 AM Revision 31110d82 (git): Improve warning message
- https://github.com/ruby/ruby/pull/2637#discussion_r341812475
-
11/02/2019
-
03:47 PM Feature #16289: Reduce duplicated warnings for the change of Ruby 3 keyword arguments
- > If they only warn once, they are not that annoying, and people may be less inclined to fix the issue.
It's a warning about an upcoming incompatibility, once should be serious enough!
Maybe it should be reworded to emphasize serio... -
- What's the performance with this patch for a call site that would warn?
```
$ chruby ruby-2.7.0-preview2
$ ruby -rbenchmark/ips -e 'def m(**kw); end; h = {a: 1}; Benchmark.ips { |x| x.report { m(h) } }'
... many warnings ...
... -
- What I worry about is Jeremy's comment in the PR:
> In terms of idea, whether we want this feature depends on how annoying we want the warnings to be. If they warn every call, they are very annoying and it will push people to fixing t... -
- The plan is Rails 6 users can update to Rails 6.0.1 and Rails 5.2 users can update to Rails 5.2.4 (assuming 5.2.4 will be released before 2.7, we need to confirm with Rails devs).
That should be easy and recommended for security and oth... -
- For this purpose I built a [special value](https://github.com/dry-rb/dry-core/blob/99e4035148af729298430aefe85b4c93cb318195/lib/dry/core/constants.rb#L41) a while ago. It has been working fine all this time. I don't think there's a need ...
-
12:32 AM Feature #11660: a falsy value (similar to js undefined) that facilitates forwarding of default arguments
- Since the beginning of time (correct me if I'm wrong), the two falsy values in Ruby has been `false` and `nil`, period.
Adding another falsy value is a big change.
> the missing/undefined second arg to f3 invocation flows all the way... -
-
- Thank you for the report and the great investigation! I could reproduce the issue by using your example: https://github.com/mainameiz/segfault_app
Currently, starting a thread in a finalizer is dangerous. The termination of the inte...
11/01/2019
-
- It's conceivable that it can be done without a keyword, there are other way to refer to special values.
However what do you have against a null coalescing operator? It's needed regardless of this issue, || and ||= are inadequate becau... -
- bughit (bug hit) wrote:
> The value would be `missing`. Adding something like `missing` to the language would need to be coupled with a null coalescing operator which would cover both nil and missing (but not false). Something like `??`... -
- > Other than arity, it seems like you would want to use the new argument forwarding syntax
I didn't know about new syntax, is that in 2.7? However, I don't think that's general enough. In javascript you can forward individual argument... -
- Other than arity, it seems like you would want to use the new argument forwarding syntax:
```ruby
def foo(default1 = some_expression)
end
def bar(...)
foo(...)
end
def foobar(...)
bar(...)
end
```
The major issue ... -
- Compared to javascript default arg values are far less useful in ruby because of the lack of this forwarding capability.
This issue is 4 years old, can ruby core at least consider this? -
11:37 PM Feature #16150: Add a way to request a frozen string from to_s
- This issue is also fixed on Rails 5.2 and will be released in the next version of Rails.
Users of any version of Rails below 5.2 are already abandoned. The Rails core team don't support those versions anymore. So, they already need to... -
- >So if that issue is caused by Rails, it should be fixed before any stable release of Ruby 2.7 comes out.
This change affects many developers, company and applications with upgrading work. How about Rails 5.2 and 5.1 users? Do we aban... -
- @rafaelfranca told me Rails 6.0.1 is scheduled for November 5, way before the Ruby 2.7 release (see https://weblog.rubyonrails.org/2019/10/31/Rails-6-0-1-rc1-released/).
So if that issue is caused by Rails, it should be fixed before any... -
- hsbt (Hiroshi SHIBATA) wrote:
> This change must be reverted.
I don't think it's fair to decide that on your own, from apparently just one issue.
Could you detail the situation, i.e., in which place the problem occurs and why can'... -
08:54 AM Feature #16150: Add a way to request a frozen string from to_s
- OK, frozen `Symbol#to_s` should be reverted. Maybe we can challenge in the future (with the deprecation process first).
Matz.
-
- This change must be reverted.
I got the issue report from Heroku users.
https://github.com/heroku/heroku-buildpack-ruby/issues/833#issuecomment-548592514
When Rails 6.0.0 and old version users specified Ruby 2.7, Their applicati... -
- How about https://github.com/ruby/ruby/pull/2637?
-
- I think everyone agrees this is too breaking (just look at how many call sites need to be changed in Rails and other gems),
and it's very easy to deprecate the old behavior by warning when passing `nil` in Ruby 2.7.
The only question... -
- The detailed situation.
Rails and other libraries and codebases rely on `/regex/.match?(nil)` to return false. This change is making that method to raise an error in that situation.
Changing this behavior on Ruby 2.7 means that app... -
- Thank you for the input. If you can provide a more detailed situation, it would be better.
Matz.
-
- +1 for deprecation too. My text editor had been broken by this change, and Vim was needed to fix it.
-
- +1 for deprecation. The removal is too harsh.
-
02:41 AM Feature #13083: Regexp#{match,match?} with a nil argument are deprecated and will raise a TypeError in Ruby 3.0
- I am 100% with Rafael here, this is a very risky change, Rails and Sprockets are only a couple of projects, there will be tons of stuff that will not be caught.
Why not deprecate this for now and then next release it can be removed? -
- A little bit more data:
I added some more debugging statements, and I found that the main thread goes from being marked with the THREAD_KILLED status to THREAD_STOPPED_FOREVER
This appears to happen in thread_join_sleep in thread.c... -
- 03:15 PM Revision e6f0fd8a (git): * 2019-11-02 [ci skip]
-
-
- Since returning a frozen string from Symbol#to_s [was reverted](https://bugs.ruby-lang.org/issues/16150#change-82420), it looks like this proposal is still relevant.
Is it realistic to wish for this in 2.7? The sooner the better imho. -
- > It leads a memory leak.
Theoretically, yes. Even if iseqs of caller or callee are free'd, the corresponding records are not free'd. But honestly I don't think it is worth elaborating the feature for some reasons:
(1) in practic... -
- It leads a memory leak.
And different warnings won't be suppressed too? -
- Definite +1 for me. I thought there was already an issue about this but looks I was mistaken.
-
- ## Problem
Currently, the interpreter emits 200 lines of warnings against the following program.
```ruby
def foo(**opt); end
100.times { foo({kw:1}) }
```
```
$ ./miniruby -e 'def foo(**opt); end; 100.times { foo({kw:1}) }'
... - 09:40 AM Revision 10c2a085 (git): Clean up implementation of SOCKSSocket, its confusing and undocumented
- 09:39 AM Revision 68e0bfcd (git): Prefer libsocksd over libsocks
- 09:39 AM Revision b8004103 (git): Support libsocksd socks library for SOCKSSocket
-
- I think this meant to mention `MatchData`? This is a breaking change, but
should be a minor one. -
-
- https://github.com/ruby/date/commit/9bc6e30a82
-
- https://github.com/ruby/date/commit/ae14e5f293
-
- This gets the time zone abbreviations from
https://www.timeanddate.com/time/zones/, and adds unambiguous time
zones not already present in zonetab.list. See bin/update-abbr
for the program used.
This regenerates zonetab.h using prereq.... - 07:59 AM Revision 51825c04 (git): * 2019-11-01 [ci skip]
-
- Apply __attribute__((__returns_nonnull__)) when available.
-
- malloc can fail. Should treat such situations.
-
- Looking at gc.c, rb_aligned_malloc contains `return NULL;` so it
has to be taken care of. Note however that posix_memalign(3posix)
does _not_ set errno. -
- clang also supports __attribute__((__alloc_size__)) so why not use
it when the compiler says it does. -
- I can think of other cursed usages of private taking a block.
```ruby
class Foo
Bar = proc do
Baz = 1
def foo
Baz
end
end
end
class Bar
private(&Foo::Bar)
end
```
Should what happen?
- Possi... -
- Oh! Looks like I missed that part of the proposal! Now the `def o.hello; end` question makes a lot more sense. Sorry, Alan.
If we break this down a bit, this proposal can potentially set the visibility (within the block) for
1. ins...
10/31/2019
-
- Hi,
This is a tricky one and I am still working on narrowing it down, but I will report what I have so far.
I compiled a version of 2_6_6 from github: ruby 2.6.6p116 (2019-10-02 revision 67825) [x86_64-linux]
I have a minimal Ra... -
- I know this change is to make the code consistent but this is a backward incompatible change and I don't think it should be applied to Ruby 2.7 without deprecation. The fact that we need to change Rails and many other gems to make this w...
-
- The extra complication comes from this part of the original proposal:
```ruby
private do
def self.some_private_class_method
puts "I'm also private - principle of least surprise"
end
end
```
This is different from the no... -
- > There is no problem with fibers/threads currently, because the visibility is stored in the scope (not in the class itself). You stated `When the private method toggles the visibility state of the current class/module`, implying this w...
-
- Dan0042 (Daniel DeLorme) wrote:
> Ok, but how is this different from the regular syntax? The exact same issue applies to this:
> ...
Are you sure? You can test this by using queues to synchronize:
```ruby
class A
end
Q1 = Queu... -
- Ok, but how is this different from the regular syntax? The exact same issue applies to this:
```ruby
class A
end
Thread.new do
class A
def pub; end
end
end
class A
private
def priv; end
end
```
If there'... -
- Dan0042 (Daniel DeLorme) wrote:
> Also I'd like to ask how fibers are relevant to this? When the `private` method toggles the visibility state of the current class/module, does that have anything to do with fibers?
```ruby
class A
... -
- I don't see why all the opposition to this. It's a very simple, very intuitive and clear syntax. It fits well with the rest of ruby and the usage of blocks in general.
alanwu (Alan Wu) wrote:
> ```ruby
> ...
I think @adh1003 was pr... -
- adh1003 (Andrew Hodgkinson) wrote:
> duerst (Martin Dürst) wrote:
> ...
I'm not advocating any particular coding style. There are many coding styles that make it clear that `private` applies to a range of methods. There are not many ... -
- I have no strong opinion against this issue. In #7019, I just said that it was too late to introduce the feature into Ruby 2.0 because I was the release manager for 2.0.
I'm curious about Rails developers' opinion. I hear that they ... -
- shyouhei (Shyouhei Urabe) wrote:
> Curious where were those abbreviation from. According to `git log -G`, It was introduced in this commit https://github.com/ruby/ruby/commit/dc9cd6a8c22ad04baa7498fd0cbc5d519ed73be0 but no description ... -
- Curious where were those abbreviation from. According to `git log -G`, It was introduced in this commit https://github.com/ruby/ruby/commit/dc9cd6a8c22ad04baa7498fd0cbc5d519ed73be0 but no description came with it.
Maybe it's better t... -
12:46 AM Bug #16286 (Closed): DateTime.parse timezone errors
- Trying to parse a DateTime using Australian time zone abbreviations doesn't work:
```
>> DateTime.parse('2019-10-31 10:49:52.36400 AEST')
=> #<DateTime: 2019-10-31T10:49:52+00:00 ((2458788j,38992s,364000000n),+0s,2299161j)>
# offse... -
- Dan0042 (Daniel DeLorme) wrote:
> So "fe80::1%fxp0" is not even recognized as an IP address. This could result in unpleasantness in cases like this:
> ...
Good point. We would probably want to fix socket to support this before adding ... -
- Looks like this testcase was in the original IPAddr commit from 2002:
```
commit 9ec0a96ad4235f2054976eab6c04efbe62b3c703
Author: knu <knu@b2dd03c8-39d4-4d8f-98ff-823fe69b080e>
Date: Mon Dec 23 17:07:49 2002 +0000
* MANIFEST... -
- I don't think this is a bug. The decision to not support zone identifiers seems deliberate as there are tests that using a zone identifier raises an exception:
```ruby
assert_raise(IPAddr::InvalidAddressError) { IPAddr.new("fe80::1%... -
-
- I'm not sure this is a bug, but it certainly seems like a bug to me. `IPAddr#include?` must consider the netmask of the receiver in order to work, for it not to consider the netmask of the argument seems wrong.
Attached is a patch th... -
- I am not sure whether this is a bug. `eql?` considers the netmask, but `==` does not. So if you want to consider the netmask, you can currently use `eql?`. Changing `==` to be the same as `eql?` could cause backwards compatibility issue...
-
- If I need such repeating accesses, I'll use `values_at` instead.
Probably, the word `first` is misleading.
If it were `head` or `lead`, the meaning would be clear.
-
- I meant to suggest this earlier, but then I think I did not; if I actually did, then please excuse my forgetfulness and
close the issue request here. I am very unorganized (also in reallife).
Anyway - I will be as short as possible h... -
- https://github.com/ruby/zlib/commit/3e98e4cac3
-
- Before this change, it was not possible to write out zero for the
timestamp part of a Gzip file's header, as calling GzipWriter#mtime with
zero was ignored.
Judging from the docs for `GzipWriter#mtime=`, it should be possible to
indicat... -
09:33 AM Bug #16284: Net/HTTP consuming multiple times more memory compared to other libraries
- Hey Yusuke, thanks for checking this out. I have tried this out on my friends machines and one of them has exactly the same results as I, but other has the results that are matching yours. All three of us are using MacBooks (although dif...
-
- This is fixed by commit:d6ed7a984c8fd991ce2614d2f228239f8eb490b5. Thank you for reporting and patch!
-
- Fixes Ruby Bug 16281.
-
- Follow up of 473882e01f7e55753733e2607ace633b5041f11f
-
-
- Ruby 2.7 deprecates taint and it no longer has an effect.
The lack of taint support should not cause a problem in
previous Ruby versions.
https://github.com/ruby/stringio/commit/60ee9ccd95 -
- This reverts commit af01edd7d8575f544f647dbe8cde5b6ae535d459.
Revert requested by Yui Naruse.
https://github.com/ruby/date/commit/875d563557 - 06:51 AM Revision fce940aa (git): [ruby/date] introduce Date::Error, raise Date::Error for every
- "invalid <anything>" type of exception
https://github.com/ruby/date/commit/3e55c09ba4 -
- https://github.com/ruby/fileutils/commit/5ac9a8a1f7
-
- https://github.com/ruby/gdbm/commit/bd2e7f6647
-
- Ruby 2.7 deprecates taint and it no longer has an effect.
The lack of taint support should not cause a problem in
previous Ruby versions.
https://github.com/ruby/gdbm/commit/f9aaa1a08d -
- Ruby 2.7 deprecates taint and it no longer has an effect.
The lack of taint support should not cause a problem in
previous Ruby versions.
https://github.com/ruby/zlib/commit/21711ed0ce -
- It turned out that for Ruby, the only thing that changed was that there are some more tests.
Implemented with https://github.com/ruby/ruby/commit/c54635c08b, NEWS updated with https://github.com/ruby/ruby/commit/bc7fbb6f02. -
- Also fixed some grammatical errors. [ci skip]
-
- For people who haven't yet switched from trunk to master, when you push, you'll get a message saying:
```
remote: @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
remote: @ WARNING: THE TRUNK BRANCH OF RUBY.GIT IS DEPRE... -
04:23 AM Feature #6362: Modular exponentiation/inverse
- FYI:
* Modular exponentiation is implemented in Ruby 2.5 . https://ruby-doc.org/core/Integer.html#method-i-pow
* I created a patch gem to calculate a usual/modular multiplicative inverse. https://www.rubydoc.info/gems/numeric_inver... -
- * Ignode to change ext/json/depend
* Fixed to ignore json_pure files -
- This reverts commit e1bf29314feee6aaf535917da0178e868e7ff3fa.
I'm not sure why this broke stuff, I need to investigate later. -
- This commit is to attempt fixing this error:
http://ci.rvm.jp/results/trunk-gc-asserts@ruby-sky1/2353281
Each non-full heap_page struct contains a reference to the next page
that contains free slots. Compaction could fill any page, ...