Activity
From 10/16/2019 to 10/22/2019
10/22/2019
-
10:58 PM Misc #16262: DevelopersMeeting20191128Japan
- * [Feature #16262] Enumerable#each_tuple, and [Feature #4539] Array#zip_with
* `zip_with` really comes in handy on occasion, and is available in many programming languages, in particular functional programming languages.
-
- Dan0042 (Daniel DeLorme) wrote:
> It's worth pointing out the desired difference with regards to lambdas a bit more explicitly:
> ...
What you want to do here is in many other languages done with `zip_with`:
```ruby
[1, 2, 3].zip_w... -
08:52 PM Feature #16261: Enumerable#each_splat and Enumerator#splat
- @eregon Thank you very much for the enlightenment!
That means the code above could be rewritten like this. And at that point it's doubtful if `tuple` is even needed.
```ruby
class Enumerator
def splat
return to_enum(:splat... -
07:33 PM Feature #16261: Enumerable#each_splat and Enumerator#splat
- FYI there is Enumerable#each_entry:
> Calls block once for each element in self, passing that
> ...
I think many methods already yield multiple arguments rather than an Array of arguments, `zip` being one of the exception.
So I'm no... -
- Note that `each{ |*item| yield(item) }` doesn't work because of #16166.
-
02:10 PM Feature #16261: Enumerable#each_splat and Enumerator#splat
- @Dan0042 super-good points, thanks!
I'd say that `Enumerable#each_tuple`/`Enumerable#each_splat` + `Enumerator#tuple`/`Enumerator#splat` is a most powerful and straightforward combination. -
- It's worth pointing out the desired difference with regards to lambdas a bit more explicitly:
```ruby
[1, 2, 3].zip([4, 5, 6]).map(&:+) # ArgumentError (wrong number of arguments (given 0, expected 1))
[1, 2, 3].zip([4, 5... -
- The Unicode Consortium just released version 12.1 of emoji, see http://blog.unicode.org/2019/10/emoji-121-release-168-emoji-added.html.
This is unrelated to Version 12.1.0 of Unicode itself (which introduced a single new character, fo... -
- jeremyevans0 (Jeremy Evans) wrote:
> In CRuby, it's not significantly more complicated. The callee may need to add the literal keywords to a hash anyway (if callee uses a keyword splat). Moving that hash to the last positional argume... -
09:41 PM Bug #16271 (Closed): Cannot build taglib-ruby gem on ruby-2.7.0-preview2
- Attempting to build the taglib-ruby gem on ruby-2.7.0-preview2 fails with error messages such as:
```
taglib_base_wrap.cxx:2101:9: error: no matching function for call to 'rb_rescue'
if (rb_rescue(RUBY_METHOD_FUNC(SWIG_AUX_NUM2U... -
07:37 PM Feature #16253: Shorthand "forward everything" syntax
- Going to do a writeup on this later tonight if anyone wants to proof-read it, it'll be interesting to see what the wider community thinks but I really like it.
Also really loving the attention to detail Jeremy's been giving lately, re... -
06:36 PM Bug #16148: bugs.ruby-lang.org is not sending email notifications for watched issues - test
-
06:23 PM Bug #16148: bugs.ruby-lang.org is not sending email notifications for watched issues
- test
-
- test
-
- I think this is related:
```ruby
proc{ |a,b| [a,b] }.call(1,2) #=> [1, 2]
proc{ |*ab| ab }.call(1,2) #=> [1, 2]
proc{ |a,b| [a,b] }.call([1,2]) #=> [1, 2]
proc{ |*ab| ab }.call([1,2]) #=> [[1, 2]]
```
I *really* thin... -
- I do not think this code is actually a problem. The restriction on transferred fibers is:
```
You cannot resume a fiber that transferred control to another one.
This will cause a double resume error. You need to transfer control
b... -
05:53 PM Revision 46f175ed (git): Use cppflags to pass preprocessor options
-
- Of all Hash methods, only select/reject/select!/reject!/keep_if/delete_if have that behavior. That's fairly inconsistent, but more importantly it doesn't seem like this inconsistency is on purpose. There is no test for this case in test/...
-
- You need to look at the functions passed to `rb_hash_foreach`:
```c
static int
each_pair_i(VALUE key, VALUE value, VALUE _)
{
rb_yield(rb_assoc_new(key, value));
return ST_CONTINUE;
}
static int
select_i(VALUE key, V... -
04:29 PM Bug #16270: Strange behavior on Hash's #each and #select method.
- I am not entirely sure where there is a lack of consistency or why the
C code is necessary. I assume that you may have been confused about
Kernel#p perhaps? It is rare that people combine .select with p,
whereas this behaviour is more... -
04:13 PM Bug #16270 (Closed): Strange behavior on Hash's #each and #select method.
- The following is some example code:
``` ruby
sample_hash = {
"246" => {
"price" => "8000",
"note" => ""
},
"247" => {
"price" => "8000",
"note" => ""
},
"248" => {
... -
-
- DL was removed in commit:07308c4d30b8c5260e5366c8eed2abf054d86fe7.
If this still occurs when using Fiddle directly, please submit a new bug report for that. -
-
-
- 03:42 PM Revision 1a80ee45 (git): * 2019-10-23 [ci skip]
-
- So that requiring it succeeds even if that forward compatibility
gem is not installed. -
-
01:15 PM Revision 99ca5705 (git): tool/release.sh uses ruby-actions' result
- https://github.com/ruby/actions
-
-
-
- Receives an output of `tool/make-snapshot` and genarete
* Markdown format for release note
* a patch for branches.yml, downloads.yml, and releases.yml of w.r-l.o -
-
11:06 AM Revision 501b517d (git): NEWS: add a URL about the performance improvement of CGI.escapeHTML
-
-
-
-
05:06 AM Revision 22845176 (git): test/ruby/test_exception typo fix
-
- Not compatible with concurrent-ruby dependency
-
03:21 AM Revision 97a03a03 (git): Add a cron job to keep CPDEBUG working
-
- The declarations went out-of-sync in dcfb7f6.
-
- It sounds like an interesting way to improve functional programming in ruby. I can definitely see the point of having a proper functional syntax instead of trying to hack everything via symbols. But I'm not sure it's the best way. At th...
10/21/2019
-
11:55 PM Bug #9664 (Closed): cannot resume transferred Fiber even if it should resume
- Applied in changeset commit:git|fa8ac91e957a076f6df1adaecad7896817138009.
----------
Fix Fiber#transfer
Fiber#transfer previously made it impossible to resume the fiber
if it was transferred to (no resuming the target of Fiber#transfer... -
- This bug still exists in the master branch, and I agree with @cremes as to the cause. When calling Fiber#transfer, the transferred flag needs to be set on the source fiber, not the target fiber, and it should be unset on the target fibe...
-
- Applied in changeset commit:git|fa8ac91e957a076f6df1adaecad7896817138009.
----------
Fix Fiber#transfer
Fiber#transfer previously made it impossible to resume the fiber
if it was transferred to (no resuming the target of Fiber#transfer... -
- Fiber#transfer previously made it impossible to resume the fiber
if it was transferred to (no resuming the target of Fiber#transfer).
However, the documentation specifies that you cannot resume a fiber
that has transferred to another fib... -
-
-
-
-
-
-
- I've added a pull request to remove the unused `output_method` variable: https://github.com/ruby/irb/pull/31
-
-
- Applied in changeset commit:git|f37cc1c719f12d2cad6032aa4e6f4236f0604992.
----------
Fallback to TCP in resolv if UDP bind raises EACCES
Original patch from Andy Grimm.
Fixes [Bug #10747] -
- Original patch from Andy Grimm.
Fixes [Bug #10747] -
-
-
-
- This appears to be fixed starting in Ruby 2.3 (the first example returns `false` instead of `true` for equality as the owners of the methods are different), probably by commit:5e8a147480f87f19a8b96ad3fb33a25fb4bb19b9.
-
- Applied in changeset commit:git|62d43828770211470bcacb9e943876f981b5a1b4.
----------
Arguments forwarding [Feature #16253] -
-
- It looks like this problem was fixed. While I can get this code to segfault on Ruby <2.5, I can no longer get a segfault for this code starting with Ruby 2.5:
```ruby
class Fixnum
define_method(:to_s) do |*args|
to_default_s... -
- With the changes in #14183, TypeError is no longer raised in any of the examples, as non-Symbol keys can be used inside a hash that is double splatted.
-
- This appears to be fixed by commit:8feb9779182bd4285f3881029fe850dac188c1ac.
-
-
-
- MSP-Greg (Greg L) wrote:
> Sorry, but code that creates thirty empty folders is just wrong, regardless of whether it creates 'problems'...
I disagree that a change that creates thirty empty folders is wrong a priori. This change app... -
- Sorry, but code that creates thirty empty folders is just wrong, regardless of whether it creates 'problems'...
- 04:07 PM Revision 349ad617 (git): * 2019-10-22 [ci skip]
-
04:06 PM Revision ee302f54 (git): add an NEWS entry about [Feature #15575]
-
-
-
01:22 PM Bug #16187: Hash#replace no longer rehashes keys for small (array table) hashes
- This can be closed now. It was fixed by commit b9702590445dfea62d271d0a5c942b7adfaaacdd.
Sorry, I should have linked to this bug in the relevant commit in that changeset. -
01:09 PM Feature #16150: Add a way to request a frozen string from to_s
- Quick update on compatibility with this change.
I opened PRs on the 5 affected gems I found:
- https://github.com/googleapis/google-cloud-ruby/pull/4109
- https://github.com/matthewrudy/memoist/pull/82
- https://github.com/... -
-
-
- A great report. I've fixed the issue. Thank you!
-
- Applied in changeset commit:git|f364564e66d1db1de8e80d669287386595c8bc46.
----------
bignum.c (estimate_initial_sqrt): prevent integer overflow
`Integer.sqrt(0xffff_ffff_ffff_ffff ** 2)` caused assertion failure
because of integer over... -
09:23 AM Bug #16269 (Closed): Every 4 bytes the Integer.sqrt(n) method closes abruptly
- If the variable `size_byte` (starting from 8) is a multiple of 4 the program fails.
But as an example let's start with 9 (which works well).
``` ruby
size_byte = 9
a = (('F' * (size_byte * 2))).to_i(16)
c = a
a *= a
b = Inte... -
- `Integer.sqrt(0xffff_ffff_ffff_ffff ** 2)` caused assertion failure
because of integer overflow. [ruby-core:95453] [Bug #16269] -
- There were too many items in the section in somewhat random order.
This change creates the following five subsections:
* Pattern matching
* The spec of keyword arguments is changed towards 3.0
* Numbered parameter
* proc/lambda without ... -
-
- Applied in changeset commit:git|b9702590445dfea62d271d0a5c942b7adfaaacdd.
----------
Stop making a redundant hash copy in Hash#dup (#2489)
* Stop making a redundant hash copy in Hash#dup
It was making a copy of the hash without rehash... -
- Thank you, I merged it!
- 08:29 AM Revision b9702590 (git): Stop making a redundant hash copy in Hash#dup (#2489)
- * Stop making a redundant hash copy in Hash#dup
It was making a copy of the hash without rehashing, then created an
extra copy of the hash to do the rehashing. Since rehashing creates
a new copy already, this change just uses that reha... -
- it seems difficult to apply this proposal because of compatibility (and productivity). rejected.
-
-
- 74b19e330adbdae2d8e53b58f1a2a7b725e69c8d is needed for 2.6.
-
05:14 AM Bug #16268 (Closed): Consistent segfault with ObjectSpace.count_imemo_objects
- On 2.6.5:
> irb
> ...
Segfaults with:
```
/usr/local/lib/ruby/2.6.0/irb/inspector.rb:109: [BUG] Segmentation fault at 0x0000000000000000
ruby 2.6.5p114 (2019-10-01 revision 67812) [x86_64-linux]
-- Control frame information ... -
-
03:41 AM Feature #13083: Regexp#{match,match?} with a nil argument are deprecated and will raise a TypeError in Ruby 3.0
- I heard this change breaks activerecord.
https://twitter.com/shyouhei/status/1186122901667209216
https://twitter.com/shyouhei/status/1186123025604734976
https://github.com/rails/rails/blob/01336b71af6ac798e48101b4ceb2de00397243aa/ac... - 02:50 AM Revision 215e4b87 (git): * expand tabs. [ci skip]
- Tabs were expanded because previously the file did not have any tab indentation.
Please update your editor config, and use misc/expand_tabs.rb in the pre-commit hook. -
-
02:14 AM Revision 375124be (git): st: Do error check only on non-Ruby
-
- These are found by Coverity.
-
02:09 AM Feature #10098 (Closed): [PATCH] Timing-safe string comparison for OpenSSL::HMAC
- Implemented in upstream. Closing.
-
- Actions has three embedded MSYS2 installs, as they currently install the three Windows Rubies with 'DevKits'. So, MinGW could be built/tested on Actions.
I have a GH action at https://github.com/MSP-Greg/msys2-action that's used in P... -
- As the result order of `DidYouMean::SpellChecker#correct` is
undefined, keep the order of the original candidates. -
-
- Applied in changeset commit:git|27261007eb45adae4d5b30cbafa2ef27a2345b3f.
----------
DidYouMean can be an empty stub module [Bug #16263] -
- 12:11 AM Revision 1d29c9bd (git): * 2019-10-21 [ci skip]
-
- See Ruby issue 16263
10/20/2019
-
- Fix for the test/optparse/test_did_you_mean.rb issue:
https://github.com/ruby/ruby/pull/2581 -
- I bypassed the spec mentioned above:
```
C-API Thread function rb_thread_call_without_gvl
- runs a C function with the global lock unlocked and unlocks IO with the generic RUBY_UBF_IO
```
and with it bypassed, all tests/specs reli... -
- Looking at the commit, the addition of the empty folders appears to be intentional, to result in the same behavior as `gem install --default`. Can you explain what problems this causes?
-
- See https://github.com/ruby/ruby/pull/2580
Duplicating a comment there:
Somewhere between the following two commits, `make install` adds additional empty folders that are created in lib/ruby/gems/2.7.0/gems, most are default gems.
... -
06:21 PM Feature #10098: [PATCH] Timing-safe string comparison for OpenSSL::HMAC
- The above PR has been merged into the OpenSSL gem 🎉
-
- ioquatix (Samuel Williams) wrote:
> I think `...` should be remainder of arguments that aren't explicitly consumed.
If it is the remainder, then it should be placed after all explicit arguments?
```ruby
def foo(pre, opt = nil, *r... -
- The parser itself was easy, but I'm wondering how ripper should treat it.
-
- I hope it is ok to link to one of your blog entries (for those who may ask - I am not
affiliated with zverok nor did I ask him about it prior to that; it may just provide
some more context to the larger topic at hand):
https://zvero... -
-
-
- MonitorMixin::ConditionVariable#wait can be interrupted just after
Monitor#exit_for_cond. So implementation in C. -
- Delegate MonitorMixin#synchronize body to Monitor#synchronize.
It makes guarantee interrupt safe (because Monitor#synchronize is
written in C). I thought Ruby implementation is also safe, but I
got stuck failure <http://ci.rvm.jp/results...
10/19/2019
-
- Fix for the test_exception.rb issue is:
https://github.com/ruby/ruby/pull/2577 -
- I just noticed that the tests are not running in ruby'S CI, see:
https://github.com/ruby/ruby/runs/266527630#step:17:122
Because ruby-loco is running tests against install (with a few patches), they do run in its CI... -
- If did_you_mean is loaded, the following test failure may occur:
TestException#test_nomethod_error_new_receiver [/ruby/test/ruby/test_exception.rb:999]:
<["Message", :foo, #<Object:0x00000000070f5aa8>]> expected but was
<["Message\n... -
- Applied in changeset commit:git|caac5f777ae288b5982708b8690e712e1cae0cf6.
----------
make monitor.so for performance. (#2576)
Recent monitor.rb has performance problem because of interrupt
handlers. 'Monitor#synchronize' is frequently ... -
- Recent monitor.rb has performance problem because of interrupt
handlers. 'Monitor#synchronize' is frequently used primitive
so the performance of this method is important.
This patch rewrite 'monitor.rb' with 'monitor.so' (C-extension)
... - 05:58 PM Revision 434966bf (git): * 2019-10-20 [ci skip]
-
-
- GH PR https://github.com/ruby/ruby/pull/2573 was a work-around that forced using some non-current MSYS2 packages libraries for building. These libraries are only available on Appveyor because their images are out-of-date, a new MSYS2 in...
-
- @nobu, sorry, I am not sure I get your question.
Are you asking about how `.:join.with(' ')` is supposed to work?
It is (theoretical and maybe not the best) example of how "partial application" could look in Ruby. It is not part of ... -
- zverok (Victor Shepelev) wrote:
> **Transition:** `:foo` and `.:foo` could work similarly for some upcoming versions (or indefinitely), with `.:foo` being more powerful alternative, allowing features like `groups_of_lines.map(&.:join.wi... -
- It is a part of thinking about the "argument-less call style" I already made several proposals about.
### Preface
***Argument-less call style*** is what I now call things like `map(&:foo)` and `each(&Notifications.:send)` approache... -
- @nobu
> This checks a directory named the current `Dir` object opened, instead of the opened directory itself.
I am not sure I understand (probably it is my lack of in-depth filesystem work understanding), for what I can tell, we ... -
-
02:56 AM Feature #16253: Shorthand "forward everything" syntax
- The reason to support `...` with other args is something like this:
```ruby
class Controller < Container::Controller
def initialize(command, *arguments, **options, &block)
@command = command
super(*arguments, **options, &...
10/18/2019
-
- ioquatix (Samuel Williams) wrote:
> Here are some real world examples from my code:
> ...
From reading the last dev meeting log (under `Future work: lead argument handling is postponed`), this will not be supported, at least initially.... -
- Here are some real world examples from my code:
```ruby
def self.for(*arguments, &block)
self.new(block, *arguments)
end
# Nicer?
def self.for(..., &block)
self.new(block, ...)
end
```
Module to be prepended:
```ru... -
- I have added pull requests for all upstream projects. After some thought, I think many maintainers may consider dropping Ruby <2.7 support not acceptable. So the pull requests I submitted will continue to work on older Ruby versions. ...
-
- mame (Yusuke Endoh) wrote:
> > Are we OK with just removing the calls to taint/untaint?
> ...
I agree with your points. Here is my implementation plan:
* I will submit pull requests upstream to all projects that remove the calls and... -
- > Are we OK with just removing the calls to taint/untaint?
Each maintainer should determine that.
This is my personal opinion: In principle, we should be conservative against incompatibility. But in regard to `$SAFE`, we can be fl... -
08:26 PM Feature #16261: Enumerable#each_splat and Enumerator#splat
- This reminds me of a neat post showing applicatives in pictures: http://adit.io/posts/2013-04-17-functors,_applicatives,_and_monads_in_pictures.html#applicatives
In Haskell:
```
[(*2), (+3)] <*> [1, 2, 3]
#=> [2,4,6,4,5,6]
```
... -
- Hmmmm.
A slight issue I see with the name "tuple", and then the implicit name addition
".each_tuple", which would then (indirectly) elevate the term tuple.
I know the word tuple from e. g. using tuple in python, but I much prefer ... -
- **UPD:** After discussion in comments, method names changed to "splat"-based.
New methods proposal.
Prototype code:
```ruby
module Enumerable
def each_splat
return to_enum(__method__) unless block_given?
each_entry {... -
- Just a note: "code range" is an implementation-level concept for Strings. For instance there is CR_7BIT which means all characters are < 128.
So I would recommend another method name than `code_range`, as I think that will be confusing.... -
- MSYS source code comes from both gcc.gnu.org & Mingw-w64. Updates to the Mingw-w64 source broke the MinGW build step.
Fixes the issue until Mingw-w64 updates their source, then it should be reverted, see comments in code. -
- * [Feature #16129] Call initialize_clone with freeze: false if clone called with freeze: false (jeremyevans0)
* Without this, use of `clone(freeze: false)` on objects not expecting it leads to unexpected state.
* Allows fixing prob... -
- Carry over:
* [Bug #15912] Allow some reentrancy during TracePoint events (alanwu)
* I have seen quite a few people confused about Byebug's REPL not working as they would expect due to this issue. I think it's important to come up ... -
- Please comment on your favorite ticket numbers you want to ask to discuss with your *SHORT* comment or summary.
(your summary/comment will help us because we don't need to read all of the ticket comments)
*DO NOT* discuss then on thi... - 03:51 PM Revision 7dcc24fd (git): * 2019-10-19 [ci skip]
-
-
- And separate ruby script and executed example.
-
-
- Seems that `Symbol#to_proc` returns `Proc` that has lambda semantics:
```ruby
proc = :+.to_proc
proc.call(1, 2) # => 3
proc.call([1, 2]) # ArgumentError (wrong number of arguments (given 0, expected 1))
```
But if you ask...
```... -
-
-
-
08:30 AM Feature #16120: Omitted block argument if block starts with dot-method call
- Dan0042 (Daniel DeLorme) wrote:
> ```ruby
> ...
my main problem with omitting parameters there is that it can't know which binding you want to use?
i am already have problems with that because i think it should have used the outer ... -
08:19 AM Feature #16120: Omitted block argument if block starts with dot-method call
- Dan0042 (Daniel DeLorme) wrote:
> Am I the only one who thinks the omitted parameter is by far the most DRY and readable in these examples?
Even if you are not, what does it change? Personally, I find this proposal interesting as an ... -
- Dan0042 (Daniel DeLorme) wrote:
> ```ruby
> ...
Sorry, it doesn't feel beautiful to me.
> ```ruby
> ...
It looks confusing.
-
-
07:20 AM Feature #12745: String#(g)sub(!) should pass a MatchData to the block, not a String
- jeremyevans0 (Jeremy Evans) wrote:
> * Passing a second argument to the block breaks if the block is a lambda.
> ...
I prefer to the last approach, but don't like names `subm` and `gsubm`.
How about `repl` and `repl_all`?
JavaScrip... -
-
- Instead of building messages separately.
-
- Dan0042 (Daniel DeLorme) wrote:
> It would really help to have an example that does more than just wrap the intrinsic function calls.
Below is an example which solves Problem: Writen in C: (3) Performance issue: keyword parameters.
... -
-
- Simple comparison between proc/ifunc/method invocations:
```
proc 15.209M (± 1.6%) i/s - 76.138M in 5.007413s
ifunc 15.195M (± 1.7%) i/s - 76.257M in 5.020106s
method 9.836M (± 1.2%) i/s - 49.272M in 5.... -
- As ObjectSpace::WeakMap allows FLONUM as a key, needs the special
deal for its hash. [Feature #16035] -
- My patch was reviewed by @yuki24 and @nobu , and merged. Closing.
-
-
- ```
require 'optparse'
OptionParser.new do |opts|
opts.on("-f", "--foo", "foo") {|v| }
opts.on("-b", "--bar", "bar") {|v| }
opts.on("-c", "--baz", "baz") {|v| }
end.parse!
```
```
$ ruby test.rb --baa
Traceback (most recent call ... -
02:23 AM Revision 5ca5529d (git): Fix warning of generated parser for nested module
-
-
-
-
-
-
- This appears to be fixed in the master branch (printing `foo`), though it is still broken in 2.6. Not sure what commit fixed it.
10/17/2019
-
-
-
-
-
-
- With the separation of keyword arguments and positional arguments in #14183, I think this can be closed.
-
- Vit, do you still get this test suite error?
-
- `$SAFE` is being deprecated in 2.7 and will revert to normal global variable in 3.0, so this can be closed.
-
-
-
-
-
-
-
- It looks like this error message has not been changed. Attached is a patch with a slightly more verbose and descriptive error message:
```ruby
class C1; end
C2 < C1.new; end
# TypeError (superclass must be an instance of Class (gi... -
-
- Fixed by commit:1d5066efb08cbb328ba528a5f8be1708584b659f.
-
-
-
-
-
- Yes!
ObjectSpace.memsize_of_imemo_objects sounds perfect to me.
I also support adding `ObjectSpace.each_iseq` which seems the simplest way to get iteration working.
I get the concern about not wanting to pollute MRI with MRI ... -
- Koichi,
What about rb_str_fstring_lookup and rb_str_fstring_lookup_enc? Both will not create strings so shared strings should not be a problem.
To be honest creation can be somewhat inefficient, the one place I can see this being... -
- Hi.
(1) implementation
Current implementation can have issue (related to shared string) and this issue can cause something wrong behavior for C-extension.
Sorry, we need a time to confirm.
(2) naming
i think it should be `rb... -
08:35 PM Revision 1d564ace (git): Remove unused constant.
- This constant isn't used, so lets remove it.
-
- The global can go bad if the compactor runs, so we need to look up the
constant instead of caching it in a global. -
-
- `test/net/fixtures` was updated in commit:f234e6c3d3170f37508e214cdaef78d4b2584e5a and commit:1e0b49a293d3792826c67b7e05c5fcbd09c9ea6e. Rubygems cert was updated in commit:ae2a904ce9bffedee7d110dc60fd51c0a2879a5b. I think this can be clo...
-
-
- Applied in changeset commit:git|ee821e90741ebedc6c7a3bb0e8b67e59f3a44022.
----------
Update test to handle x32 ABI compiled Ruby on Linux
Suggestion from Laurence Parry.
Fixes [Bug #16030] -
- Suggestion from Laurence Parry.
Fixes [Bug #16030] -
- Matz wants to make it as an extension library, so I moved it as extension library.
-
- I agree this is a bug that should be fixed. I have submitted a pull request to fix it: https://github.com/ruby/thwait/pull/1
-
- > instead of `#select`, shouldn't you use `#find` so it doesn't need to check the others when it already found a match?
No, because it should return nil when there's more than one match. -
- Dan0042 (Daniel DeLorme) wrote:
> +1
> ...
instead of `#select`, shouldn't you use `#find` so it doesn't need to check the others when it already found a match? -
06:24 AM Feature #13683: Add strict Enumerable#single
- ```
[1, 2].mono
[1, 2].solo
[1, 2].alone
``` -
05:59 AM Feature #13683: Add strict Enumerable#single
- I don't like `only` either since these names do not describe the behavior.
Matz. -
05:54 PM Revision 8c0629ba (git): Treat key sequences from getwch() that start from 0 or 0xE0 correctly
-
-
-
- The function getwch() returns some key sequences which start from 0 or 0xE0
with a following key code. Alt+` that is on/off key for input methods gives 0
and 41 so Reline was always ignoring 0 and following keys but numeric keypad
keys g... -
-
-
-
-
-
-
-
- Applied in changeset commit:git|0162e7e6471b639dfeeded29943e9e27c9519826.
----------
Make circular argument reference a SyntaxError instead of a warning
Fixes [Bug #10314] -
- I think it's OK now to make this error.
Matz.
-
- Fixes [Bug #10314]
-
- The blocker on merging the pull request is that test-bundled-gems is failing due to the `rake` test failure. https://github.com/ruby/rake/pull/329 needs to be merged (and I don't have permissions to merge it), and a new rake released an...
-
- Hi @jeremyevans0,
> I've rebased my pull request against master and fixed the conflicts
Thank you for the great work! I've discussed this issue on the developer meeting, and all agreed with the change.
> ...
This should be disc... - 03:46 PM Revision fdfb5100 (git): * 2019-10-18 [ci skip]
-
-
- Merged at commit:2a22a6b2d8465934e75520a7fdcf522d50890caf
-
- This error occurs in sassc, an external gem:
```
c:0059 p:---- s:0449 e:000448 CFUNC :compile_data_context
c:0058 p:0298 s:0444 e:000443 METHOD /Users/johnny/env/ebm/vendor/cache/ruby/2.5.0/gems/sassc-2.2.1/lib/sassc/engine.rb:42
... -
10:18 AM Bug #16259 (Third Party's Issue): Err when running 'rails test'
- Got this error when running 'rails test'
Please ask if something's missing!
Best of luck! -
- @matz About use-cases, there are multiple, like:
* Logging/debug printing some hash with sensitive or too large data excluded:
```ruby
puts "REQUEST: #{request_data.except(:body, :apikey)}
```
* Data tidying:
```r... -
- `Hash#slice` was introduced via discussion in #13563. We didn't see the need for `Hash#except` yet. Any (real world use-case)?
I don't think the name `except` is the best name for the behavior.
Matz. -
- I am so sad :-(
I was really looking forward to using this beautiful syntax instead of numbered parameters which I find so ugly I prefer to use an explicit block variable.
Am I the only one who thinks the omitted parameter is by far th... -
- After reconsideration, I came to the conclusion that we should use numbered parameters instead of this feature.
Thank you for a pretty interesting idea. It was good food for thought.
Matz.
-
-
- Applied in changeset commit:git|e169ad93f44e1944ecf7bb65133fd34e8b868ea8.
----------
Fixed File.extname at a name ending with a dot
File.extname now returns a dot string at a name ending with a dot.
[Bug #15267] -
- https://github.com/ruby/ruby/pull/2565
-
05:41 AM Bug #15267: File.basename + File.extname does not restore the original name
- I think we should change File.extname instead of File.basename, as:
```
File.basename("name.", ".*") #=> "name"
File.extname("name.") #=> "."
```
We can explain File.extname as:
File.extname(x) returns what File.basename(x, ".*... -
- > basename(1) seems to result in the base name with the dot, when stripping a wildcard suffix.
basename(1) doesn't handle wildcard.
https://pubs.opengroup.org/onlinepubs/9699919799/utilities/basename.html -
- File.extname now returns a dot string at a name ending with a dot.
[Bug #15267] - 08:45 AM Revision 2a261909 (git): * remove trailing spaces. [ci skip]
-
- Thank you for your patch.
Conclusion: OK.
Points:
* Current implementation separates ci and cc because of CoW friendliness (ci is immutable data and cc is mutable data). However, there are no measurements how it affect on CoW fr... -
- Proposed change: https://github.com/ruby/ruby/pull/2564
To perform a regular method call, the VM needs two structs, `rb_call_info`
and `rb_call_cache`. At the moment, we allocate these two structures in
separate buffers. In the wors... -
08:44 AM Revision 2a22a6b2 (git): Regexp#match{?} with nil raises TypeError as String, Symbol (#1506)
- * {String|Symbol}#match{?} with nil returns falsy
To improve consistency with Regexp#match{?}
* String#match(nil) returns `nil` instead of TypeError
* String#match?(nil) returns `false` instead of TypeError
* Symbol#match(nil) returns ... -
-
07:53 AM Bug #16257: Gem::Version instances are silently created as singletons
- Fixed and scheduled for rubygems v3.1.0.
-
-
- I feel changing the default behavior of IO#rewind is dangerous.
We use IO#rewind when we modify a file in place.
```
open(filename, "r+") {|f|
f.read
f.rewind
f.truncate(0)
f.write "..."
}
```
If IO#rewind moves t... -
- I agree with fixing this. Nobu will investigate the patch and consider the issue detail.
Matz.
-
-
02:37 AM Misc #16232: DevelopersMeeting20191017Japan
- * [Feature #16142] Implement code_range in Proc and Method - Ruby master - Ruby Issue Tracking System
* Propose an API to get code position of Proc and Method so that we can get body of them (especially of a Proc).
* I want to disc... -
- - [Misc #16258] Combine call info and cache to speed up method invocation
- Looking for feedback and reviews. I think this offers a good perf boost.
- [Bug #15912] Allow some reentrancy during TracePoint events
- I have seen quit... -
- * [[Feature #13083]](https://bugs.ruby-lang.org/issues/13083) {String|Symbol}#match{?} with nil returns falsy as Regexp#match{?}
* Matz said "Those methods (but =~) should consistently raise exceptions." and pull request's conflicts r... -
- hi.
I want to use it when I want to get the block source code.
e.g. https://github.com/osyo-manga/gem-binding-debug
https://github.com/osyo-manga/gem-binding-debug/blob/a5e19728893ddb92ec04170fcd8afbdf43db2eab/lib/binding/debug.rb#L10...
10/16/2019
-
- Applied in changeset commit:git|567e312d1f56c27ecb4fa20deac4311f05ee5507.
----------
Do not raise an exception on a closed DRb socket
This rescues some exceptions that could happen with a closed or
shutdown DRb socket. This can prevent... -
- Applied in changeset commit:git|50b8033d6b7404670ee985de1473fffc10dd7d9c.
----------
Handle subclasses of Exception in drb
This makes it so that client instances that call a method on a
server-side object that raise a subclass of Excep... -
- My previous fix in d0ed935d5bf8c3fce9800742a36e44fb7f63dda4 was
not correct, as pointed out by cremno on GitHub.
This simplifies things by just using Kernel#to_s. Also switch to
bind_call(obj) instead of bind(obj).call for better perfo... -
- This rescues some exceptions that could happen with a closed or
shutdown DRb socket. This can prevent the server from
exiting if an client socket is closed directly after it is
accepted.
Fixes [Bug #8039] -
- This makes it so that client instances that call a method on a
server-side object that raise a subclass of Exception are handled
similarly to those that raise a subclass of StandardError.
Only reraise exceptions that we are fairly sure ... -
- Applied in changeset commit:git|2993b24a1ecc5fa3cc9f140bfd80669c3a3b7b9c.
----------
Warn for calling public/protected/private/module_function without arguments inside method
Calling these methods without an argument does not have the
... -
- nobu (Nobuyoshi Nakada) wrote:
> * Is it necessary that check is placed inside the function `vm_cref_set_visibility`?
> ...
I agree, that makes more sense.
> * `rb_frame_callee` returns the called name, that may be an aliased name.
... -
- * Is it necessary that check is placed inside the function `vm_cref_set_visibility`?
What about calling a separate function where `check_method` flag is 1?
* `rb_frame_callee` returns the called name, that may be an aliased name.
... -
- @nobu Could you review the patch?
-
- Calling these methods without an argument does not have the
desired effect inside a method.
Fixes [Bug #13249] -
- Given the very interesting use case that zverok presented, I'm leaning more in favor of a lexically-scoped "operator" that doesn't need to be present in the method signature. So no invocation via block, just like `super`. Actually, the m...
-
- The disadvantage I see to this proposal is increased complexity. Both internal complexity in the implementation, and also more complexity for the user, as this adds more syntax Ruby programmers need to understand. However, I think the ...
-
- > But it's true that often we want to operate on the arguments before forwarding, so I think maybe an asymmetric syntax like this would work best?
BTW, that's very valid point — similar problem was discussed here: https://bugs.ruby-la... -
- > * Is `*` or `...` an expression? What does `def m(...); a = ...; p a; end; m(1, a: 2) {}` print?
I would tend to say `a = ...` is a syntax error; my intention was to use this only in the argument list of a method call, with an imple... -
- Things to consider:
* Is `*` or `...` an expression? What does `def m(...); a = ...; p a; end; m(1, a: 2) {}` print?
* Do we want to support required arguments before? It would be useful for `method_missing`:
```ruby
def method_mis... -
-
-
- * Makes it easier to copy-paste and add code backticks.
-
- * [Feature #16120] Omitted block argument if block starts with dot-method call (Dan0042)
* last time Matz said "Give me time to consider it"; there is now a patch ready; is it ok to accept?
-
- * [Feature #16150] Add a way to request a frozen string from to_s
* `Symbol#to_s` now returns a frozen string, and this brought at least seven incompatibility issues. To make sure: is it okay to introduce this change in 2.7.0-preview2? -
- * [Feature #16253] Shorthand "forward everything" syntax (mame)
* How about introducing `def foo(...); bar(...); end`? It does not solve the compatibility issue of keyword argument separation, but it would provide a useful shorthand ... -
- * [Feature #16255] Make `monitor.rb` built-in (ko1)
* maybe there is no problem.
* Should we make `MonitorMixin` built-in?
* [Feature #16254] MRI internal: Define built-in classes in Ruby with `__intrinsic__` syntax (ko1)
* onl... -
- Rebased my patch to the latest master and cleaned up the code a bit:
https://github.com/dan42/ruby/commit/11f609af003370396d0e82381b57ea5a73ff6d8a - 03:29 PM Revision e003f29e (git): * 2019-10-17 [ci skip]
-
03:28 PM Revision 5c80dffd (git): Revert "Disable ccache on arm64 build"
- This reverts commit e8124729fbeaf159ae615f61980ee10018ed5134.
It worked once, but soon after that it stopped working again
https://travis-ci.org/ruby/ruby/jobs/598491972 -
-
- Done: https://github.com/rubygems/rubygems/issues/2948
-
- It is an issue of rubygems.
Please report it at https://github.com/rubygems/rubygems/ -
- Attached the full stack trace.
-
- Instantiating `Gem::Version` objects via `new` actually returns singletons, which is not obvious nor is this documented anywhere:
~~~
irb(main):001:0> v1 = Gem::Version.new("2.2.0")
=> #<Gem::Version "2.2.0">
irb(main):002:0> v1.fr... -
- This reverts commit 43015275b9a7f2833c93ad11ea96ae4cb3b7acd7.
`assert_raise_message` in test-unit is different from
`assert_raise_with_message`. It checks the exception message
only, but not the exception class, -
- It should be fixed.
-
-
-
- \o/
-
- How about showing "did you mean" when a unknown option is passed for OptionParser?
```ruby
require 'optparse'
OptionParser.new do |opts|
opts.on("-f", "--foo", "foo") {|v| }
opts.on("-b", "--bar", "bar") {|v| }
opts.on("-... -
- Current design is for compatibility for future changes.
-
- Still some CIs are failing:
https://ci.appveyor.com/project/ruby/ruby/builds/28141041/job/v4hfc99sjefqabkk
http://ci.rvm.jp/results/trunk-vm-asserts@silicon-docker/2317313
I'll fix them later. -
-
-
-
-
- because it started to run on Travis.
-
- Follow up https://github.com/ruby/ruby/pull/2559
According to experiments in https://github.com/ruby/ruby/pull/2560,
disabling cache seems to make arm64 build succeed. -
- Already we have:
```ruby
require 'objspace'
pp ObjectSpace.count_imemo_objects
#=>
{:imemo_env=>42,
:imemo_cref=>177,
:imemo_ment=>3662,
:imemo_iseq=>1194,
:imemo_tmpbuf=>117,
:imemo_ast=>22,
:imemo_svar=>40,
:imemo_... -
-
-
- and let RUBY_DEBUG=1 job test it.
We usually don't use --jit-debug and we should test no --jit-debug by
default. - 03:59 AM Revision d97229de (git): Add arm64 case on Travis. (#2559)
- misc-16234
-
- There's something I'm not sure I understood so I'd like to clarify if this proposal can be described as
A) write the boilerplate `rb_define_class` and `rb_define_method` using a ruby-like macro language;
B) write core classes and m...