Activity
From 09/21/2019 to 09/27/2019
09/27/2019
-
11:03 PM Feature #16166: Remove exceptional treatment of *foo when it is the sole block parameter
- matz (Yukihiro Matsumoto) wrote:
> I think the following code behavior is wrong:
> ...
Here's a pull request for that: https://github.com/ruby/ruby/pull/2502
Note that it breaks some tests/specs. I believe the reason methods with k... -
- It looked into this behavior, which started in Ruby 2.4 (when top level return started being allowed).
`return` not being allowed directly in class/module body is a parse error, because the parser knows that it cannot be valid. Howev... -
10:49 PM Bug #16121: Stop making a redundant hash copy in Hash#dup
- ko1 (Koichi Sasada) wrote:
> I found that
> ...
I tried doing that and it caused test failures because Hash#replace stop rehashing keys in ruby 2.6. I've opened a bug for that: https://bugs.ruby-lang.org/issues/16187
I've opened ht... -
- Here is a script that shows the problem
```ruby
mutable_key = [1]
h = { mutable_key => 'a' }
mutable_key[0] = 2
p(h == {}.replace(h))
```
which outputs `true` in ruby 2.5 and lower versions and `false` in ruby 2.6 and later v... -
10:34 PM Bug #16186 (Closed): Calling Net::HTTP from within an #inspect implementation hang when invoked from p
- Using this script:
``` ruby
require 'net/http'
class Victim
def inspect
puts "before"
Net::HTTP.get('example.com', '/index.html') # this hangs. I haven't tried other network libraries
puts "After"
return "success"
end
... -
06:22 PM Revision d53cf854 (git): Fix warning when doing Struct.new(:x, keyword_init: true){}
- This is due to calling rb_mod_module_eval directly instead of using
rb_funcall_passing_block.
The problem with calling directly is it does not create a new VM
frame, so rb_mod_module_eval was called with no arguments, but with
the keywo... -
- If a method accepts no keywords and was called with a keyword, an
ArgumentError was not always issued previously. Force methods that
accept no keywords to go through setup_parameters_complex so that
an ArgumentError is raised if keyword... -
- This may be too verbose, if so, maybe it should be moved lower in
the document, or to a separate document. -
- Applied in changeset commit:git|a1fda16b238f24cf55814ecc18f716cbfff8dd91.
----------
Optimize Array#flatten and flatten! for already flattened arrays (#2495)
* Optimize Array#flatten and flatten! for already flattened arrays
* Add benc... -
- It looks like I made a mistake in my benchmarking of non-flattened arrays, since flatten! from the first iteration would cause further iterations to actually test with a flat array. It looks like the performance for arrays starting with...
- 04:24 PM Revision 707c4885 (git): * 2019-09-28 [ci skip]
- 04:24 PM Revision a1fda16b (git): Optimize Array#flatten and flatten! for already flattened arrays (#2495)
- * Optimize Array#flatten and flatten! for already flattened arrays
* Add benchmark for Array#flatten and Array#flatten!
[Bug #16119] -
- Applied in changeset commit:git|869e2dd8c8efc1e7a043c9eee82d97c47befbcc7.
----------
Warn for URI.{,un}{escape,encode}, even if not in verbose mode
The verbose mode warning has been present for almost 10 years.
If we ever plan to remov... -
- Applied in changeset commit:git|a2c26fe1c6d49b54494b7c6301cc4c77596eec0c.
----------
Fix fallback in URI.encode_www_form_component to include #
Patch from Matthew Kerwin.
Fixes [Bug #14358] -
- Applied in changeset commit:git|43a16c98df392e726040f0331a3e09d00c53d513.
----------
Do not escape + in Shellwords.escape
+ is not a character that requires escaping in Bourne sh.
Fixes [Bug #14429] -
- Applied in changeset commit:git|2b6a9f3a1ffcdb00bf89798979d475c6d189d419.
----------
Ignore Errno::EPIPE when sending requests in net/http
An EPIPE when sending the request should be ignored. Even if you
cannot write more data, you ma... -
- The verbose mode warning has been present for almost 10 years.
If we ever plan to remove these methods, we should make the warning
a regular deprecation warning so that people are aware.
Implements [Feature #15961] -
- Patch from Matthew Kerwin.
Fixes [Bug #14358] -
- + is not a character that requires escaping in Bourne sh.
Fixes [Bug #14429] -
- An EPIPE when sending the request should be ignored. Even if you
cannot write more data, you may still be able to read the server's
response.
Fixes [Bug #14466] -
12:54 PM Revision 80d0b6f1 (git): Updated bundled_gems
-
12:43 PM Bug #16185: basictest failure on AIX 6.1 for 64bit build
- @kanemoto @reiodaira Could you treat this?
-
11:58 AM Bug #16185 (Feedback): basictest failure on AIX 6.1 for 64bit build
- We are building ruby 2.6.3(both 32 and 64bit) on AIX 6.1.
The build options used for 64bit build are:-
export LDFLAGS="-L/opt/freeware/lib64 -L/opt/freeware/lib -Wl,-blibpath:/opt/freeware/lib64:/usr/lib:/lib"
and for 32bit build are:... -
- Applied in changeset commit:git|79d5332a2da0e2743a77480aebfca256a54a962e.
----------
Drop eliminated catch-entries
Drop catch table entries used in eliminated block, as well as
call_infos. [Bug #16184] -
10:05 AM Bug #16184: Entry persists in catch table even though its labels were removed, which may cause [BUG]
- > And having `position` field of labels initialized (as in my attached patch) makes crash totally impossible.
I think having this field properly initialized is a good idea anyway, so I created a pull request: https://github.com/ruby/r... -
- > So whether Ruby crashes or not depends on the contents of the memory where labels are allocated by compile_rescue function.
And having `position` field of labels initialized (as in my attached patch) makes crash totally impossible. -
- > Could you post a reproducer that reliably crashes Ruby?
I guess this is not really possible to crash Ruby reliably via this issue. Here is a reproducer that crashes on my MIPS32 LE machine one out of 20 times or so:
```ruby
puts... -
- Could you show the backtrace?
-
- Drop catch table entries used in eliminated block, as well as
call_infos. [Bug #16184] -
-
11:23 AM Bug #16151: [PATCH] Fix a class of fstring related use-after-free
- ruby_2_6 r67804 merged revision(s) 93faa011d393bb4b5cf31a0cbb46922f0a5e7cdc.
-
- Tag string shared roots to fix use-after-free
The buffer deduplication codepath in rb_fstring can be used to free the buffer
of shared string roots, which leads to use-after-free.
Introudce a new flag to tag str... -
08:35 AM Feature #16183: Hash#with_default
- zverok (Victor Shepelev) wrote:
> Eregon (Benoit Daloze) wrote:
> ...
Well, yes, but at least in my view, `merge` is a two-sided (symmetric) operation. There are two hashes, and you merge them. It would be strange if one of them is cha... -
06:02 AM Feature #16183: Hash#with_default
- > That means a copy of the Hash is necessary on each call to `#with_default`.
Yes, the same way it is for, say, `merge`, and we still use it in a lot of cases even when source hash would be dropped -- for the sake of chainability:
... -
08:12 AM Feature #16150: Add a way to request a frozen string from to_s
- > In order to safely get a frozen string from an object, you must ALWAYS do `some_str.to_s.dup.freeze`. In order to safely get a mutable string from an object, you must ALWAYS do `some_str.to_s.dup`.
Not exactly, `-@` and `+@` makes t... -
- Applied in changeset commit:git|eff15a269fdc37d2b09cf1dfe8c1b1bf6e377a32.
----------
[EXPERIMENTAL] Make NilClass#to_s, TrueClass#to_s and FalseClass#to_s return a frozen String
* Always the same frozen String for each of these val... -
-
-
- * Always the same frozen String for each of these values.
* Avoids extra allocations whenever calling these 3 methods.
* See [Feature #16150] -
02:39 AM Revision 2082a26d (git): [ruby/fileutils] Bump version to 1.3.0.
- https://github.com/ruby/fileutils/commit/ba3bd6fdfd
-
- https://github.com/ruby/fileutils/commit/17a9de6d9b
-
02:39 AM Revision d5355123 (git): [ruby/fileutils] Reduce global variables
- https://github.com/ruby/fileutils/commit/ba81f024cf
-
- Previously this would copy the symlink root as a symlink instead
of creating a new root directory. This modifies the source
to expand it using File.realpath before starting the copy.
Fixes Ruby Bug 12123
https://github.com/ruby/fileut... -
- Previously this would give an error such as:
TestFileUtils#test_cp_r_dev [c:/fileutils/test/fileutils/test_fileutils.rb:455]:
[RuntimeError] exception expected, not.
Class: <TypeError>
Message: <"no implicit conversion of nil into Strin... -
- If FileUtils is included into another object, and verbose mode is
used, a FrozenError is currently raised unless the object has the
@fileutils_output and @fileutils_label instance variables.
This fixes things so that it does not attempt... -
- https://github.com/ruby/fileutils/commit/20bb9ec789
-
- Previously, this was broken. Trying to copy a FIFO would raise a
NoMethodError if File.mkfifo was defined. Trying to copy a UNIX
socket would raise a RuntimeError as File.mknod is not something
Ruby defines.
Handle the FIFO issue usin... -
- https://github.com/ruby/fileutils/commit/b701353c53
-
- This fixes instance_exec and similar methods. It also fixes
Enumerator::Yielder#yield, rb_yield_block, and a couple of cases
with Proc#{<<,>>}.
This support requires the addition of rb_yield_values_kw, similar to
rb_yield_values2, for p... -
09/26/2019
-
11:53 PM Feature #16150: Add a way to request a frozen string from to_s
- Oh I should point out another problem with the current situation...
```ruby
some_str.to_s.freeze
```
The above code is also unsafe right now, because since `to_s` returns self, we're now freezing the original string!
In order ... -
- > But granted that this now cause this somewhat weird situation where to_s might or might not return a frozen string. that being said it's already kinda the case
Yeah, this is precisely the problem. It is made even worse by the large ... -
- @headius I totally get your opinion on `String#to_s`, however on a very practical standpoint I agree with @eregon:
> Returning a frozen String for String#to_s would just add more allocations, since the current String#to_s just returns... -
- I'm glad to see some smaller parts of this are moving forward. A few updates from my end (JRuby):
* Frozen strings from Symbol etc:
We are on board with making Symbol, nil, true, false, and Module all return frozen strings, and hav... -
- Then store those objects in global variables, and `rb_gc_register_mark_object`.
-
- byroot (Jean Boussier) wrote:
> Over the 502 gems used in the repo, I found 5 impacted gems, all because of `Symbol#to_s`, and all in very minor ways:
A great report. For the record, I add another case I've heard:
* did_you_mean:... -
- @nobu Yes that's what I had in mind, but then from what I understand it means we have to lookup the fstring table every time rather than just return a existing pointer. So it's not really an optimisation, is it?
-
- Ok, so I just finished updating our application to be compatible with both `Symbol#to_s` and `Module#name` returning frozen strings.
Over the 502 gems used in the repo, I found 5 impacted gems, all because of `Symbol#to_s`, and all in... -
- byroot (Jean Boussier) wrote:
> For `nil/true/false` it is a bit trickier because the returned string are ASCII encoded, so I'm not quite sure how to statically create ASCII `fstrings` with the existing APIs.
```C
static VALUE
true... -
- > Do you want to do the PR for nil/true/false as well then?
I tried but I'm quite unsure how to do it, so I don't mind if you handle it.
On a side note I'm currently running our test suite with the following monkey patch:
```rub... -
11:26 AM Feature #16150 (Assigned): Add a way to request a frozen string from to_s
- @byroot Great, I merged your PR.
Sorry, I should have asked first if you wanted to do it.
Do you want to do the PR for `nil`/`true`/`false` as well then? -
- Applied in changeset commit:git|9d0866c7d7b9cbe36a851744a37806e747e0e7a8.
----------
[EXPERIMENTAL] Make Module#name return a frozen String
* Always the same frozen String for a given Module or Class.
* Avoids extra allocations... -
- I got the `Module#name` one ready here: https://github.com/ruby/ruby/pull/2487
For `nil/true/false` it is a bit trickier because the returned string are ASCII encoded, so I'm not quite sure how to statically create ASCII `fstrings` wi... -
- Reopening, the issue was accidentally closed as I merged the Symbol#to_s change.
I will make a PR for nil/true/false.to_s and Module#name to return a frozen String. -
- Applied in changeset commit:git|6ffc045a817fbdf04a6945d3c260b55b0fa1fd1e.
----------
[EXPERIMENTAL] Make Symbol#to_s return a frozen String
* Always the same frozen String for a given Symbol.
* Avoids extra allocations whenever calling... -
12:42 AM Feature #16150: Add a way to request a frozen string from to_s
byroot (Jean Boussier) wrote:
> I get you are worried about `String#to_s`, but what about others that have been mentioned here, namely:
> ...
Ok for the experiment.
Matz.-
10:41 PM Revision 293c6c8c (git): Add compaction support to `rb_ast_t`
- This commit adds compaction support to `rb_ast_t`.
-
- This requires adding rb_proc_call_kw to pass the keyword flag.
-
- We are calling this in a few other files, it is better to have it
in a header than adding prototypes to the other files. - 10:01 PM Revision 31339ef4 (git): Honor Syslog::Logger#level overrides
-
- I've been compiling with:
```
set -lx cflags '-std=c99 -Werror=pedantic -pedantic-errors'
```
But compilation would fail with the following:
```
cont.c:296:90: error: format specifies type 'void *' but the argument has type 'struct ... -
- zverok (Victor Shepelev) wrote:
> So, I propose side-effect-less method, that **is** acceptable for chaining, I believe.
That means a copy of the Hash is necessary on each call to #with_default.
I.e., it would be the same as:
```ru... -
- > Duplicate of #11761
I don't think it is a duplicate, though I haven't clarified an important behavior indeed:
```ruby
h = {a: 1, b: 2}
h2 = h.with_default(3)
h.default # => nil
h2.default # => 3
```
So, I propose side-effec... -
04:36 PM Feature #16183: Hash#with_default
- sawa has it all covered. ;)
The explanation by matz is interesting.
"Use tap. Methods with side-effect should be handled with care. Making it chainable
has little benefit."
Personally I think other names, be these default_set, ... -
03:52 PM Feature #16183: Hash#with_default
- Duplicate of #11761
-
- Reasons: there is no way, currently, to *declaratively* define Hash with default value (for example, to store it in constant, or use in an expression). Which leads to code more or less like this:
```ruby
FONTS = {
title: 'Arial'... -
-
- This function is just a synonym for RB_OBJ_WRITTEN, so we can just
directly call that. -
- We don't use this array anymore so we can remove it
-
- We can mark everything via the instruction objects, so just execute the
write barrier instead of appending to the array -
- `freeze_string` essentially called iseq_add_mark_object_compile_time. I
need to know where all writes occur on the `rb_iseq_t`, so this commit
separates the function calls so we can add write barriers in the right
place. -
- Move the "add mark object" function to the location where we should be
calling RB_OBJ_WRITTEN. I'm going to add verification code next so we
can make sure the objects we're adding to the array are also reachable
from the mark function. -
- This commit scans the ISEQ arena for objects that can be marked and
marks them. This should make the mark array unnecessary. -
-
- We'll scan the secondary arena during GC mark. So, we should only
allocate "markable" instruction linked list nodes out of the secondary
arena. -
- Now we can allocate and free a secondary arena.
-
- This is so we can configure a new arena later
-
- headius (Charles Nutter) wrote:
> If we make the global default to freeze string literals, would `frozen-string-literal: false` for a given file make them mutable?
Yes, in fact shortly after `--enable-frozen-string-literal` was intro... -
- C API updates:
* adjusted indent.
* marked up ANYARGS as RDoc. -
05:30 PM Bug #16178: Numbered parameters: _1 should be the same as |x| and _0 should not exist
- Eregon (Benoit Daloze) wrote:
> Dan0042 (Daniel DeLorme) wrote:
> ...
That's still incomplete, since it doesn't explain why `_1` doesn't decompose when used in lambdas. If it always decomposes, it'd be more self consistent.
Anyways, I... -
-
- Could you post a reproducer that reliably crashes Ruby? Interesting issue!
-
- Of course, while having some strange cache table entries would be pretty ok if they were not used (like it usually happens on x86_64). To make sure they are never used compiler should initialize the `position` field of the labels. I'm at...
-
- When `remove_unreachable_chunk` removes the code from within a rescue block, the catch table entry corresponding the block is not removed. Here is a simple reproducer (tested with ruby 2.5.5):
``` ruby
puts "BEGIN"
if false
b... -
- * got rid of inadvertent label lists.
* marked up resolve_feature_path method names.
* fixed indentation of UnboundMethod#bind_call and marked up as
RDoc. -
- Ensure that argument array size does not overflow as `int`, before
cast in thread_do_start after new thread created. - 03:02 PM Revision 3b9cdc59 (git): * 2019-09-27 [ci skip]
-
-
-
-
-
- It's unlikely anyone would actually hit these. The methods are
private, you only hit this code path if calling these methods
before performing the SSL connection, and there is already a
verbose warning issued. -
- This requires adding rb_proc_call_with_block_kw.
-
-
- The pull request was merged.
-
-
-
-
01:13 PM Revision 41e3c204 (git): Reduce ISeq size of mjit_exec benchmark
- to avoid unwanted memory pressure
-
- Maybe 2.6.4 has same issue.
-
- Applied in changeset commit:git|93faa011d393bb4b5cf31a0cbb46922f0a5e7cdc.
----------
Tag string shared roots to fix use-after-free
The buffer deduplication codepath in rb_fstring can be used to free the buffer
of shared string roots, w... - 11:25 AM Revision 1070456b (git): * remove trailing spaces. [ci skip]
-
- * Always the same frozen String for a given Module or Class.
* Avoids extra allocations whenever calling Module#name.
* See [Feature #16150] -
-
-
-
08:48 AM Revision a2af4730 (git): [rubygems/rubygems] Make sure our modifications to kernel.warn work
- And test the fix we're adding.
https://github.com/rubygems/rubygems/commit/6f86637b98 -
- https://github.com/rubygems/rubygems/commit/cc255b774a
-
- https://github.com/rubygems/rubygems/commit/8cdb2fd66f
-
- Co-authored-by: Yusuke Endoh <mame@ruby-lang.org>
https://github.com/rubygems/rubygems/commit/92892bbc3a - 08:48 AM Revision 0b65a7a1 (git): [rubygems/rubygems] Fix test_gem_attr
- https://github.com/rubygems/rubygems/commit/7c5b66f9ef
-
- https://github.com/rubygems/rubygems/commit/506c5bce49
-
- https://github.com/rubygems/rubygems/commit/b3b5c2d379
-
08:48 AM Revision 73633683 (git): [rubygems/rubygems] add tests
- https://github.com/rubygems/rubygems/commit/8a7e27381c
-
- https://github.com/rubygems/rubygems/commit/1d18b12a26
-
- Previously it wouldn't play nice with the bundler version finder.
https://github.com/rubygems/rubygems/commit/d8bb81556d -
- https://github.com/rubygems/rubygems/commit/0832c079c8
-
- https://github.com/rubygems/rubygems/commit/7fd2460f76
-
- https://github.com/rubygems/rubygems/commit/d4ba75dfd2
-
- https://github.com/rubygems/rubygems/commit/7134c49179
-
- https://github.com/rubygems/rubygems/commit/6405a1e51a
- 08:48 AM Revision 5c872b29 (git): [rubygems/rubygems] Avoid adding OpenSSL::PKey::RSA instances
- https://github.com/rubygems/rubygems/commit/ba021fb4be
- 08:48 AM Revision d1c97ceb (git): [rubygems/rubygems] Update expectation in test_to_ruby_with_rsa_key
- https://github.com/rubygems/rubygems/commit/2e65f7d4ae
- 08:48 AM Revision 2e9c0787 (git): [rubygems/rubygems] Fix indentation in case statement
- https://github.com/rubygems/rubygems/commit/8ac0647659
- 08:48 AM Revision 8f2379b0 (git): [rubygems/rubygems] Make ruby_code method handle OpenSSL::PKey::RSA objects
- https://github.com/rubygems/rubygems/commit/b1d825ab3a
- 08:48 AM Revision 508afe2c (git): [rubygems/rubygems] Set SOURCE_DATE_EPOCH env var if not provided.
- Fixes #2290.
1. `Gem::Specification.date` returns SOURCE_DATE_EPOCH when defined,
2. this commit makes RubyGems set it _persistently_ when not provided.
This combination means that you can build a gem, check the build time,
and use tha... - 08:48 AM Revision 8436b271 (git): [rubygems/rubygems] Add a gem attr to the Gem::Package class.
- https://github.com/rubygems/rubygems/commit/5b81f364ae
-
- * Always the same frozen String for a given Symbol.
* Avoids extra allocations whenever calling Symbol#to_s.
* See [Feature #16150] -
- In #15865, a new syntax `<expr> in <pattern>` was introduced. By using this, we can write:
```
json = { foo: 1, bar: 2}
if json in { foo:, bar: }
p [foo, bar] #=> [1, 2]
end
```
However, we cannot write:
```
p(json in... -
- I wanted to dynamically generate benchmark cases to test various number
of methods. Thus I added a dedicated runner of benchmark-driver. -
- for all compilations and compaction.
Prior to this commit, the last-compiled code has not been used because
MJIT worker is stopped before setting the code, and compaction has also
been skipped.
But it was not intentional and `wait: tru... -
- Yes, it is same as that in irb.
I have attached a log of the output. -
-
- Since the introduction of STR_SHARED_ROOT, the word "shared"
has become very overloaded with respect to String's internal
states. Use a different name for STR_IS_SHARED_M and explain
its purpose. -
- The buffer deduplication codepath in rb_fstring can be used to free the buffer
of shared string roots, which leads to use-after-free.
Introudce a new flag to tag strings that at one point have been a shared root.
Check for it in rb_fstr... -
- Applied in changeset commit:git|3cee99808d629c0ec493955ce8ea019d1f8a637b.
----------
[EXPERIMENTAL] Expression with modifier `in`
[Feature #15865] -
- [Feature #15865]
-
03:46 AM Bug #16135: Segmentation fault in Ruby 2.6.1
- It works in Ruby 2.2.x and Ruby 2.5.x .
-
- GCC emits a lot of false positives for rb_scan_args because:
* `rb_scan_args(argc, argv, "*:", NULL, &opts);` makes `n_mand == 0`,
* `n_mand == argc + 1` implies `argc == -1`, and
* `memcpy(ptr, argv, sizeof(VALUE)*argc);` explodes
How... -
- https://github.com/ruby/io-console/commit/3d69c577a4
-
- https://github.com/ruby/io-console/commit/77ed8d5a06
09/25/2019
-
- > So how about making an experiment by the next preview(2) to see how big the incompatibility is?
Thank you, I will merge https://github.com/ruby/ruby/pull/2437 and mark the change as experimental.
> ...
I agree String#to_s should ... -
- @matz Great to hear.
I get you are worried about `String#to_s`, but what about others that have been mentioned here, namely:
- `NilClass#to_s`
- `TrueClass/FalseClass#to_s`
- `Module#name`
-
07:51 PM Bug #16148: bugs.ruby-lang.org is not sending email notifications for watched issues
- test
-
- The hash-flag approach for ruby2_keywords has been merged at 3b302ea8c95d34d5ef072d7e3b326f28a611e479. That commit uses ruby2_keywords in delegate, fixing the keyword argument separation issues.
-
- This approach uses a flag bit on the final hash object in the regular splat,
as opposed to a previous approach that used a VM frame flag. The hash flag
approach is less invasive, and handles some cases that the VM frame flag
approach do... -
- matz decided to always treat `:` in `rb_scan_args` as `**opt`, so I have merged my `rb_scan_args-colon-always-keyword` branch at 80b5a0ff2a7709367178f29d4ebe1c54122b1c27.
-
- Cfuncs that use rb_scan_args with the : entry suffer similar keyword
argument separation issues that Ruby methods suffer if the cfuncs
accept optional or variable arguments.
This makes the following changes to : handling.
* Treats as *... -
06:05 PM Bug #16181 (Closed): return from a proc in a module/class body returns out of script. Should be LJE.
- return is not allowed from class/module body. But if we insert a return into a block then we can invoke the block then it returns all the way out of the script. This has to be accidental behavior doesn't it? I believe the case below s...
-
- matz (Yukihiro Matsumoto) wrote:
> @eregon [ruby-core:95070] beats me. I am persuaded. I agree with:
> ...
Thank you for your decision.
I think this is going to save many bugs and make numbered parameters significantly simpler.
-
- Dan0042 (Daniel DeLorme) wrote:
> > How would we define the current semantics, without being very complex or confusing?
> ...
That's incomplete, it's much more tricky than that in the now previous semantics:
`_1` is the first numbered... -
12:39 PM Bug #16178: Numbered parameters: _1 should be the same as |x| and _0 should not exist
- > I think `_0` and `_1` are very confusing because people can consider it is sequential meaning. However, the meaning is different.
I agree, but matz chose _0 for the implicit parameter. I think it's a mistake to then use that naming ... -
11:54 AM Bug #16178: Numbered parameters: _1 should be the same as |x| and _0 should not exist
- > Beautifully simple:
> ...
I think `_0` and `_1` are very confusing because people can consider it is sequential meaning. However, the meaning is different.
It is same as `$0` and `$1`, but they are completely different feature (pro... -
11:16 AM Bug #16178: Numbered parameters: _1 should be the same as |x| and _0 should not exist
- Just to make it more polarized, I like the change, it feels more natural.
-
- Dan0042 (Daniel DeLorme) wrote:
> How unfortunate that you managed to persuade matz :-(
Completely agreed. -
- > How would we define the current semantics, without being very complex or confusing?
Beautifully simple:
_0 is a single implicit parameter, as in x in { |x| }
_1 is the first numbered parameter, as in x in { |x,y,z,etc| }
_2 is th... -
- Applied in changeset commit:git|55e1e22b2d44a8a1eca0f6ed2b11dc0f564f7192.
----------
Changed numbered parameters semantics
* `_1` (and no other numbered parameters) to work as `|x|`.
* giving up `_0`.
[ruby-core:95074] [Bug #16178] -
- @eregon [ruby-core:95070] beats me. I am persuaded. I agree with:
* `_1` (and no other numbered parameters) to work as `|x|`.
* giving up `_0`.
Matz. - 03:27 PM Revision 4755e23d (git): * 2019-09-26 [ci skip]
-
-
- IO#ready? returns true or false only, since r50262(1baa57b0033).
-
- If you want random `Float` values up to `max`, use `Random#rand` or `Random.rand` instead of `Kernel#rand`.
-
11:34 AM Bug #16180: Random.rand(max) ignores / is broken when max ceiling value is a float
- your cases are documented there: https://ruby-doc.org/core-2.6.4/Kernel.html#method-i-rand
`When max.abs is greater than or equal to 1, rand returns a pseudo-random integer greater than or equal to 0 and less than max.to_i.abs.`
`N... -
11:07 AM Bug #16180 (Rejected): Random.rand(max) ignores / is broken when max ceiling value is a float
- ruby 2.6.3p62 (2019-04-16 revision 67580) [x86_64-darwin18]
ruby 2.7.0preview1 (2019-05-31 trunk c55db6aa271df4a689dc8eb0039c929bf6ed43ff) [x86_64-darwin18]
Calling `rand` with a float of > 1 always return 0.
Calling `rand` with a... -
- ARY_SHARED_ROOT_P(ary) is true, ARY_HEAP_CAPA(ary) should not
be called. -
- Introduce a new debug counter `obj_ary_extracapa` which counts
arrays which are `len < capa`. -
-
- Could you show what `ruby -e 'puts $:'` print, and is it same as in irb?
-
- We are building ruby 2.6.3(both 32 and 64bit) on AIX 6.1.
The build options used for 64bit build are:-
```
export LDFLAGS="-L/opt/freeware/lib64 -L/opt/freeware/lib -Wl,-blibpath:/opt/freeware/lib64:/usr/lib:/lib"
```
and for 32... -
- It occurs in KysyCore.dll and the extension library calling that DLL.
Have you asked the author? -
- Loading Kysy dll is required in order to run my test cases .
-
-
- I've expanded my pull request to deprecate taint/trust and related methods with verbose warnings, and make the methods no-ops. I believe this implements matz's plan for Ruby 2.7.
The changes involved removing tainting from all includ... -
- * `_1` (and no other numbered parameters) to work as `|x|`.
* giving up `_0`.
[ruby-core:95074] [Bug #16178] -
- I think the following code behavior is wrong:
```ruby
p instance_exec(["a"]){|*foo, **bar| foo } #=> ["a"]
```
It should return `[["a"]]`.
Matz.
-
-
- This reverts commit 5294ded681992ced2ecbd31c814b63265d2f591e.
-
-
- https://github.com/ruby/io-console/commit/a3ad851b6c
-
- https://github.com/ruby/io-console/commit/ab7653c543
09/24/2019
- 11:24 PM Revision 8e8dd88c (git): * 2019-09-25 [ci skip]
-
- It results in a mysterious failure.
https://github.com/ruby/io-console/commit/e3543c3da4 -
- It's all about definitions. How do we explain numbered parameters?
Isn't `_1` the first parameter, as in `x` in `{ |x| }` and `x` in `{ |x,y| }`?
And therefore `_2` the second parameter as in `y` in `{ |x,y| }`?
Of course, `{ |x| ... -
- Here is another inconsistency on current trunk:
```ruby
[1,[2,3]].map { |x| x } # => [1, [2, 3]]
[1,[2,3]].map { |x,| x } # => [1, 2]
[1,[2,3]].map { _1 } # => [1, 2]
[1,[2,3]].map(&-> { _1 }) # => [1, [2, 3]]
[1,[2,3]].map(&... -
- Dan0042 (Daniel DeLorme) wrote:
> `proc{ |x,| }.arity` == 1, so `_1` is consistent with that.
Which sounds like another bug to me, because that block happily accepts more arguments, and should be identical to `|x,*|`, which `proc {|x... -
- zverok (Victor Shepelev) wrote:
> Honestly, we use it pretty frequently in our codebase and find it appealing.
> ...
How frequently compared to just `|x|`? I would guess < 5% on any non-trivial codebase.
But you are right, frequency o... -
- `proc{ |x,| }.arity` == 1, so `_1` is consistent with that.
In order to get the tuples' first value you would need to do `array_of_arrays.map{_2;_1}` because otherwise `_1` would mean the entire tuple.
This argument is really weird... -
- Hmmm. I find underscores to be harder to read in combination with
other parts (e. g. _abc or _123) whereas I use _ quite a bit in my
own code.
I still like @1 @2 @3 etc... - however had, I have to admit that if
the suggestion is to... -
- Some counter-points (that being said, I dislike the "unnamed parameters" idea as a whole, because I am afraid this feature -- being just "shorter" while staying imperative -- will stay in the way of adoption of more promising features li...
-
- nobu (Nobuyoshi Nakada) wrote:
> When `_1` is same as `|x|`, what does `[[1, 2]].map {_1 + _2}` mean?
It means `[[1, 2]].map { |a,b| a + b } # => [3]` of course.
> ...
Yes, just like `Proc#arity` changes.
```ruby
-> { _1 }.arity... -
- When `_1` is same as `|x|`, what does `[[1, 2]].map {_1 + _2}` mean?
The meaning of `_1` changes if `_2` is used or not?
-
- Of course, having `_` as the only unnamed parameter would have `|x|` semantics,
but I guess it's too late for that and now we have `_<n>` parameters. -
- Currently on trunk:
```ruby
array = ["string", 42, [1, 2]]
array.map { |x| x * 2 }
# => ["stringstring", 84, [1, 2, 1, 2]]
array.map { _1 * 2 }
# => ["stringstring", 84, 2]
```
Oops, this trivial code just lost data and com... -
- I ended up rebasing my commits to the latest master and then fiddling with parse.y until I got everything clean and working, including Ripper.
So this is my implementation of omitted parameters based on nobu's original patch:
https://g... -
- I also agree that nobu's patch should be merged.
-
06:31 PM Bug #16173: ENV.delete returns nil when name does not exist and block given
- I, being a member only of The Outer Party, can't merge anything here.
I'm agnostic on whether the change should be to the documentation or to the code. My part was just to note the discrepancy.
Can someone in The Inner Party take ... -
07:08 PM Bug #15244: Method #extname return empty string if filename is dot ('.')
- Example from .NET:
(https://docs.microsoft.com/en-us/dotnet/api/system.io.path.getextension)
```
class Program
{
static void Main(string[] args)
{
string ext = Path.GetExtension("..jpg");
Console.WriteLine(ext);
... -
- As KysyCore.dll is included in the backtrace, that is likely to be the cause of the problem. Is it possible for you to test on a system that doesn't have Kysy loaded when running the tests?
-
- Kysy is not installed in the machine .
The above call stack is from my development environment which has Kysy codebase but not Kysy library installed -
-
-
-
-
- lldb module bundled with Xcode is for Python 3 now.
-
-
- How to reproduce:
1. Create dummy files by `./miniruby -e '%w[a b foo bar test zzz].each{|basename|File.write("#{basename}.rb", "raise %(do not load #{basename}.rb)")}'`
2. Run `ruby/test_autoload.rb` like `make test-all TESTS='ruby... -
- https://github.com/ruby/io-console/commit/9377e37295
-
- To be consistent with `winsize`, changed the cursor position
format from `[x, y]` to `[row, column]`.
https://github.com/ruby/io-console/commit/d1f5ae9286 -
- It seems crashing in ffi-call by rb-readline.
-
02:50 AM Revision 2366c681 (git): suppress meddlesome clang10 warrning
- It says:
vm.c:2519:34: warning: expression does not compute the number of elements in this array; element type is 'const struct __jmp_buf_tag', not 'VALUE' (aka 'unsigned long') [-Wsizeof-array-div]
sizeof(e... -
- cadfaacb2533d47d52dbb5dbefe724d7bf11112e missed it.
09/23/2019
-
- Attached is an alternative approach for implementing this. It uses `VALUE` for the `kwfreeze` variable, so we can use `Qundef` instead of the magic value of `-1` for the default behavior. It also updates the documentation to reflect yo...
-
10:52 PM Bug #16176: Segmentation fault running irb on ruby 2.6.4p104 (2019-08-28 revision 67798) [x64-mingw32]
- Install is from https://github.com/oneclick/rubyinstaller2/releases/download/RubyInstaller-2.6.4-1/rubyinstaller-devkit-2.6.4-1-x64.exe however it seems to work fine under git bash (https://gitforwindows.org/)
me@box MINGW64 ~
$ git ... -
- I'm new to Ruby so bare with me, I have a fresh install of Ruby on a Windows 10 (Build 1803) corporate Dell laptop and getting segmentation fault just trying to launch irb
Dump below
-
10:06 PM Feature #16147: List Comprehensions in Ruby
- Eregon (Benoit Daloze) wrote:
> Just my opinion: I don't think we should have list comprehensions in Ruby.
Thanks I appreciate the feedback!
> ...
You have some very good points! Nested comprehensions can get pretty gnarly. Still... -
- nobu (Nobuyoshi Nakada) wrote:
> sammomichael (Samuel Michael) wrote:
> ...
Hi, I was suggesting a splat operator as one way to create a special syntax, under the hood instead of calling each method it would treat this as a filter map... -
- I think it's important to make a distinction between "immutable" and "frozen".
Some programming languages have immutable data structures, and some programmers find that concept really cool, functional, powerful and whatnot. This is a ... -
- When reading the code it seems like the intent of `foo(test:42)` is for baz to return `[{:test=>42}, {}]` but that's not what I get when running it on 2.7. I get a warning and `[1, {:test=>42}]`. To fix the code on 2.7 I need to change `...
-
- Since I wasn't at the developer meeting I'll post my thoughts/responses to the log here.
> matz: I prefer this style to .map(&:to_s). But I understand it is not flexible enough. Difficult to determine.
This shorthand simplifies one... - 04:28 PM Revision e561e4a8 (git): * 2019-09-24 [ci skip]
-
- Kernel#send takes a different optimized code path that was already
handled. -
- It looks like Kysy is still installed and active according to the C level backtrace:
```
C:\Windows\SYSTEM32\ntdll.dll(RtlCaptureContext+0x3c3) [0x00007ff9c23c9bd3]
E:\code\KYSY-3153\Source\x64\Release\bin\KysyCore.dll(Kysy::PCIAddr... -
- It works fine in Ruby 2.5.6 version
-
- Please find the error output of Segmentation fault with no Kysy installed.
```
Copying E:/code/KYSY-3153/Source/test/../RegisterDef/data/kysy_platdb.json to E:/code/KYSY-3153/Source/x64/Release/bin directory
Run options: --seed 3459... -
- https://github.com/ruby/io-console/commit/b8017509ef
-
- https://github.com/ruby/io-console/commit/a54b6e4dd1
-
08:33 AM Revision b443bdbd (git): Use short wait for select(2)
- It is one of the reasons why paste to IRB is slow.
-
-
- I ran some quick tests on rejecting frozen non-bare strings from the buffer
deduplication code path. On Discourse, about 18% of calls to rb_fstring are
refused with the change in https://bugs.ruby-lang.org/issues/16151#note-5.
So I do...
09/22/2019
-
- At the last developer meeting, matz requested that instead of "k", "e", and "n" modifiers to `rb_scan_args`, a new `rb_scan_args_kw` method be added for that behavior. I have updated the pull request to add that method.
matz also had... -
- IMHO it's better to fix behavior to be consistent with Hash#delete.
And the compatibility risk seems non existent here.
So I think we should change behavior, and not change documentation which would be inconsistent with Hash#delete.
... -
06:29 PM Feature #16119: Optimize Array#flatten and flatten! for already flattened arrays
- nobu (Nobuyoshi Nakada) wrote:
> This patch unrolls the `while`-loop for the already flatten head and seems reasonable.
> ...
Attached is a patch for early return and preventing additional allocs for the empty array case (however not v... -
-
-
- vo.x (Vit Ondruch) wrote:
> However, I wonder if there is some explanation for disabling the test. I see a lot of comments such as `# These clocks in practice on Linux do not seem to match their reported resolution.` or `# These clocks ... -
- Just my opinion: I don't think we should have list comprehensions in Ruby.
They are just a small subset of the far more powerful Enumerable methods, and IMHO are often less readable (e.g., nested list comprehensions in Python are what... -
- sammomichael (Samuel Michael) wrote:
> ```ruby
> ...
It is an `Array` from 0 to 10 now.
> below we propose a syntax in which we splat the for loop to return the stored result not the caller
> ...
Obviously the latter result conflic... -
04:38 PM Bug #14716: SecureRandom throwing an error in Ruby 2.5.1
- I am encountering this in a project as well. In my case, I see this while running rspec regression tests:
```
#<ActionView::Template::Error: failed to get urandom>
./.rvm/rubies/ruby-2.6.3/lib/ruby/2.6.0/securerandom.rb:104:in `uran... -
- 04:04 PM Revision 2afe86e4 (git): * 2019-09-23 [ci skip]
-
- https://sevenzip.osdn.jp/chm/cmdline/switches/method.htm
-
- nobu (Nobuyoshi Nakada) wrote:
> I'm positive about this, except for the performance.
> ...
Using the rdoc gc bench tooling Koichi used in https://bugs.ruby-lang.org/issues/14858, it's difficult to get consistent results between this c... -
- It disables 7z, which seems not to have an option to stop saving
extra file attributes (uid/gid and atime), in order to make zip
packages stable. -
- Extra file attributes (uid/gid and atime) make the packaged zip
file unstable. -
- The original st.c was public domain hash table implementation, but
Ruby's st.c is highly modified, and its data structure is not
compatiblie with the original one.
Therefore, when creating an extension library to wrap C code that uses
t... -
- I agree with Jeremy. It is not a bug.
I think that the wording of `freeze: false` is a bit confusing, but the document explains clearly. Do you have a real-world use case for `clone(freeze: true)`?
Anyway, please do not modify th... -
- @jeremyevans0 thanks for your answer.
Let me explain my point a bit.
I come upon this inconsistency (or what **I** see as an inconsistency) when working on 2.4 version of my [RubyChanges](https://rubyreferences.github.io/rubychange... -
- I sort of agree with zverok at the least for the expectation of freeze: true
working. IMO for boolean toggle-values I would think it is simpler to have
both variants work; then again I don't think I need either of the two variants
mys... -
-
- It was originally static inline, but seemed to be accidentally published
at 8f675cdd00e2c5b5a0f143f5e508dbbafdb20ccd. -
- This function was created as a variant of st_copy with firing write
barrier.
It should have more explicit name, such as st_copy_with_write_barrier.
But because it is used only for copying iv_tbl, so I rename it to
rb_iv_tbl_copy now. If... -
- instead of deprecated BigDecimal.new.
-
- nobu (Nobuyoshi Nakada) wrote:
> I'm positive about this, except for the performance.
> ...
Apologies for the delay in replying.
Using `benchmark-driver` script (running set last as it would taint the others by initializing the loca... -
- `check-snapshot-ruby_2_4` uses `make test` instead of `make check`.
https://github.com/ruby/actions/blob/95692e54f4263501db1508d51c1fb67c03b4f575/.github/workflows/snapshot.yml#L448-L449
`draft-release` use `make check` to make it simpl...
09/21/2019
-
11:24 PM Bug #16174: Feature #15958 triggers Rails unit test failure
- Thanks for the fix. https://github.com/rails/rails/pull/37262 has been merged to master, I think this issue can be closed.
-
- https://github.com/rails/rails/pull/37262
-
- This Rails unit test compares the output of Time using pp.
pp Time class object also changed to show subseconds.
* Ruby 2.6.4
```
$ ruby -v
ruby 2.6.4p104 (2019-08-28 revision 67798) [x86_64-linux]
$ irb
irb(main):001:0> requi... -
- Let me inform one of Rails Active Record unit test get failed since https://bugs.ruby-lang.org/issues/15958
I prefer this change but let me inform because it may be one of incompatibility.
* Steps to reproduce
``` ruby
git clon... - 11:10 PM Revision c020fd6a (git): * 2019-09-22 [ci skip]
-
- Applied in changeset commit:git|2e551356a7a6e74ba07283e000ff16f5d1ea6506.
----------
Make Kernel#{Pathname,BigDecimal,Complex} return argument if given correct type
This is how Kernel#{Array,String,Float,Integer,Hash,Rational} work.
Bi... -
- Applied in changeset commit:git|7470f965650bf17875632f0c5f9e5a4d9de9fc3f.
----------
Fix Module#class_variables for singleton classes of classes/modules
Module#class_variables should reflect class variable lookup. For
singleton classes... -
- This is how Kernel#{Array,String,Float,Integer,Hash,Rational} work.
BigDecimal and Complex instances are always frozen, so this should
not cause backwards compatibility issues for those. Pathname
instances are not frozen, so potentially... -
- Module#class_variables should reflect class variable lookup. For
singleton classes of classes/modules, this means the lookup should
be:
* Singleton Class
* Class
* All Ancestors of Class
Note that this doesn't include modules included ... -
- In reiteration of my main points, Ruby is a dynamic multi-paradigm language which should when possible embrace a variety of modes to achieve the same result.
SO what would be the benefits of list comprehension in Ruby and what wou... -
- An interesting bit here is that there is no way to get back the module from which the method was retrieved, even though it's shown in #inspect:
```
> Range.instance_method :map
=> #<UnboundMethod: Range(Enumerable)#map>
```
Maybe ... -
- `nil` does not respond to `to_hash` though, how do you propose to deal with that?
Should `**` call `to_h` rather than `to_hash`, similar to `*` calling `to_a` and not `to_ary`?
Your comment https://bugs.ruby-lang.org/issues/15381#n... -
- I worked on an alternative approach of using `ruby2_keywords` with a hash flag approach instead of a VM frame flag approach: https://github.com/ruby/ruby/pull/2477 . This approach is significantly less invasive to implement, and I think...
-
- The `freeze: false` option was intended to be: "do not freeze clone if receiver is already frozen". The `Object#clone` documentation states: "#clone copies the frozen (unless `:freeze` keyword argument is given with a false value) and ta...
-
- In #12300, the new keyword `freeze:` was introduced, allowing this:
```ruby
h = {}.freeze
h.clone.frozen?
# => true
h.clone(freeze: false).frozen?
# => false
```
Though, it turns to me that behavior is not symmetric:
```ruby
... -
- I'm still against frozen-string-literal by default. It is arguable if the string creation limits performance so much in real-world programs. We need to first measure how much Ruby can be faster by frozen-string-literal. If it is not s...
-
- Thanks, @alanwu. I'm refreshing diff.txt with more fulsome documentation, along with enhanced testing.
-
- Thanks, @nobu, but I'm not going to propose a change to the functionality.
-
- Comparing with `Hash#delete`, it looks that the document is correct and the code is wrong.
```diff
diff --git i/hash.c w/hash.c
index 8b84a14484..7880178dc8 100644
--- i/hash.c
+++ w/hash.c
@@ -4779,7 +4779,7 @@ env_delete_m(VALU... -
- Matz didn't determine this proposal at the meeting. There were four points discussed:
* Before matz accepts this proposal, he must decide the grand design change: Ruby should be immutable by default?
* If we want to make Ruby gradua... -
- Hmm. I can somewhat understand the proposal, but I believe you would also
add a bit more complexity here; you need to remember that ruby users may
have to understand the idea behind this too, and that adds a bit of
complexity. A bit ... -
- to suppress variable unused warning
-
- I published the Log. Closing.
-
- I've added a pull request that adds warnings to setting/access of $SAFE, as well as public C function that deal with $SAFE: https://github.com/ruby/ruby/pull/2476
As the taint tracking/mechanism is being removed, I was not sure if we ... -
-
04:24 AM Revision e006b992 (git): typedef rb_jmpbuf_t to void *[5] if __builtin_setjmp is used
- The built-in version operates on a buffer of 5 words, much smaller than
the size of jmp_buf defined in libc.
Note, powerpc requires 5 words, while arm and x86_64 just require 3.