Activity
From 09/12/2019 to 09/18/2019
09/18/2019
-
11:47 PM Revision a9cdaaad (git): DEBUG
-
10:57 PM Bug #16151: [PATCH] Fix a class of fstring related use-after-free
- @alanwu
Indeed, it makes sense. Thank you.
I am not familiar with Rails at all so I could be wrong, but I hear ActiveSupport::SafeBuffer inherits String and has an instance variable. Is this class not so used frequently?
https... -
03:13 PM Bug #16151: [PATCH] Fix a class of fstring related use-after-free
- @mame
Thanks for pointing that out. I should clarify what I meant there. In a world where strings don't track taint status, it might make more sense to refuse buffer deduplication for non bare strings.
At that point, my original patc... -
- @alanwu
Just FYI: You said in https://bugs.ruby-lang.org/issues/16152#note-8
> * What do you think about the proposed schedule?
> ...
But, BARE_STRING_P is not only for a tainted string, but also for a string that includes an inst... -
06:16 PM Revision 5177dd8b (git): Add and fix some keyword tests
- Replace [arg=1, args] with [arg, args] so we can actually test
the value correctly.
Add some missing tests for **h3 when method accepts (**args).
Add tests for passing positional hashes to (**args) methods and
check for the expected wa... -
03:56 PM Bug #16171 (Third Party's Issue): Documentation for PP
- Documentation for PP is in https://ruby-doc.org/stdlib-2.4.6/ but it's no longer in https://ruby-doc.org/stdlib-2.5.6/ or subsequent versions.
Was that intentional? - 03:11 PM Revision 2b708ab7 (git): * 2019-09-19 [ci skip]
-
- Look up language module with `MakeMakefile.[]`, insted of a
accessing constant under that module directly, to get rid of
expose the constant to the toplevel inadvertently. -
-
- * [Feature #16120] Omitted block argument if block starts with dot-method call
* `posts.map{ .author.name }` has *beautiful* readability, no incompatibility, changes a syntax error into an intuitive idiom, already implemented in 6 li... -
11:14 AM Misc #16152: DevelopersMeeting20190919Japan
- [Feature #16170] Remove the unmaintained libraries from Ruby 2.7
* Is it ok to remove them? -
- It is exposed to the topleven namespace via included MakeMakefile.
-
-
01:46 PM Revision a491159a (git): Add badges of GitHub Actions [ci skip]
-
01:38 PM Feature #16170: Remove the unmaintained libraries from Ruby 2.7
- Agreed. Might also be simpler to get full support in gem-spec format
for those libraries that are maintained. :)
Some of them I have not even read before at all, such as mutex_m. -
- I'm working to extract standard libraries to rubygems in recent years. So, the standard libraries will be promoted the default gems or bundled gems.
But I suggest removing some of the unmaintained libraries without default/bundled gem... -
- > And I have a path forward that would easily address any breakage: we add a `mutable-string-literal` pragma.
I don't understand, why a new pragma? Is there a reason why the existing `frozen-string-literal: false` is not good enough?
... -
01:00 AM Feature #11473: Immutable String literal in Ruby 3
- > This depends on the ruby code. Some projects will be semi-dormant due to various reasons.
That's for us to address as a community. Are we going to let a single decade-old gem prevent us from moving Ruby forward? What's the threshold... -
11:49 AM Bug #16169: rescue in a method argument
- @mame
> Ruby allows to omit parentheses of method calls
Oh, thanks! In fact, that was the piece of understanding I missed trying to catch how space- and spaceless-versions are different from PoW of the interpreter.
The ticket co... -
09:54 AM Revision 38069a3a (git): Try using Ruby 1.9.3 on Travis xenial
- Isn't it there? http://rubies.travis-ci.org/
-
-
-
-
-
09:26 AM Revision effacde2 (git): [bundler/bundler] Merge all `bundle check --path` specs
- And skip them all for bundler 3.
https://github.com/bundler/bundler/commit/b88936cdc2 - 09:26 AM Revision 434af730 (git): [bundler/bundler] Merge #7340
- 7340: Fix bundle clean issue r=deivid-rodriguez a=deivid-rodriguez
### What was the end-user problem that led to this PR?
The problem was that `bundle clean` is crashing under some conditions.
### What was your diagnosis of the proble... -
- It was suggested a deprecated command as a fix.
https://github.com/bundler/bundler/commit/e330a9a34f -
- https://github.com/bundler/bundler/commit/6e9774b377
-
09:26 AM Revision 4f2f6aeb (git): [bundler/bundler] Add a spec for installing git deps after packaging w/o git
- https://github.com/bundler/bundler/commit/65351c58b8
-
- This reverts commit 3dc509e645abb497e4dc92a7c42be471ff87db0b.
https://github.com/bundler/bundler/commit/b5766564fb -
- This reverts commit 00b095b98fe4bd44950beaf3bc9f1d91eac7b69e.
https://github.com/bundler/bundler/commit/e93bce3b20 -
- This reverts commit 52c5a0eedec34b5d86464b3cf135dc2002486f1d.
https://github.com/bundler/bundler/commit/b4cc36deb9 -
- This reverts commit 3a2d2f025081755bdb38af660897e7b2f749a33a.
https://github.com/bundler/bundler/commit/13cef81582 - 09:26 AM Revision c27aaf1a (git): [bundler/bundler] Fix comments and messages to refer to https url
- https://github.com/bundler/bundler/commit/a86b49f1b9
-
- https://github.com/bundler/bundler/commit/b7fc6f4187
-
- To not mention that the flag is remembered when it's not.
https://github.com/bundler/bundler/commit/82f0b95854 -
- https://github.com/bundler/bundler/commit/0a0e7cf5ec
-
08:29 AM Revision 9118cb24 (git): Fix typos
-
- Why do you use private attr_accessor? You can access its instance variable directly.
Allowing `self.private_method` has a unpreferable side effect; it allows `self.global_function`, i.e., `self.require "foo"`, `self.lambda { }`, `sel... -
02:06 AM Revision bcd5f2e9 (git): delete unused variable
09/17/2019
-
- I agree that Ruby syntax is very subtle. Ruby's parser is a unspeakable monolith of compromise between human intuition and parser limitation.
Consider the following code:
```
foo(x, y, z = ary)
```
It may have two possible in... -
- mame explained that the behaviour is correct (in the context).
Perhaps the documentation could explain that, because I agree
with zverok at the least initially to assume that there should
not be a difference in behaviour between the... -
- This is the same thing as #16092, where I submitted a documentation patch a little while ago.
-
- At 2.4, #12686 was introduced, allowing code like this:
```ruby
foo (Integer(ENV['FOO']) rescue nil)
```
Though, I noticed that in current Ruby correctness of this syntax depends on space after the method name:
```ruby
foo (Int... - 11:23 PM Revision c170e23d (git): * 2019-09-18 [ci skip]
-
- Make sure that vm_yield_with_cfunc can correctly set the empty keyword
flag by passing 2 as the kw_splat value when calling it in
vm_invoke_ifunc_block. Make sure calling.kw_splat is set to 1 and not
128 in vm_sendish, so we can safely ... -
- This makes method_missing take a flag for whether keyword arguments
were passed.
Adds tests both for rb_call_super_kw usage as well as general usage
of super calling method_missing in Ruby methods. -
- > I suspect that the vast majority of Ruby code out there would work out of the box or
> ...
This depends on the ruby code. Some projects will be semi-dormant due to various
reasons.
Semi-old gems for example.
If matz wants peop... -
- I regret missing this "final" decision, but I believe we should reconsider.
> I am sure introducing this could cause HUGE compatibility issue
Truly? We have had the syntactic hacks (.freeze etc), frozen-string-literal pragma, and t... -
09:37 AM Bug #16158: "st" Character Sequence In Regex Look-Behind Causes Illegal Pattern Error When Combined With POSIX Bracket Expressions And Case Insensitivity Flag
- Some more information: The onigmo documentation says (https://github.com/k-takata/Onigmo/blob/master/doc/RE#L270):
```
Subexp of look-behind must be fixed-width.
But top-level alternatives can... -
- I've had a hunch, and have now been able to confirm this hunch:
The problem must be related to the fact that there is a 'st' ligature (U+FB06) in Unicode. The problem occurs for all the other Latin ligatures just before U+FB06, i.e. f... -
- https://github.com/ruby/ruby/runs/224877570#step:3:1008
```
Error: No such file or directory @ dir_s_rmdir - /Users/runner/Library/Caches/Homebrew/downloads/ca756e367eb98d2b525e72b311633c27ffc74eca825a5392153b3488d1adb732--libssh2-1.9.0.... -
- Enable `Ctrl+Y`, which is bound with it by default on BSD-like
systems, for editing. - 06:15 AM Revision b49c1380 (git): * 2019-09-17 [ci skip]
- 06:14 AM Revision f9332ad8 (git): Fix previous history in vi_insert mode
- 06:14 AM Revision a3533bc9 (git): Fix history navigation in vi_insert mode
09/16/2019
-
- 12:37 PM Revision 2a39de19 (git): * 2019-09-16 [ci skip]
-
-
12:20 PM Feature #7639: More freedom for location of comments
- It looks like this feature has been realized by https://bugs.ruby-lang.org/projects/ruby-trunk/repository/git/revisions/3a3f48fb8fbdbb810d9b675159529970015316b9
If I am correct, please close this feature, and thanks, nobu-san.
09/15/2019
-
09:02 PM Misc #16152: DevelopersMeeting20190919Japan
- * [Feature #16168] Add keyword argument separation to C functions using rb_scan_args
* I would like to commit the patch so that methods implemented in C handle keyword argument separation similar to methods implemented in Ruby. -
05:58 PM Misc #16152: DevelopersMeeting20190919Japan
- * [Feature #16155] Add an `Array#intersection` method
* Is this an acceptable method name?
* Should this be a simple alias for `Array#&`, or should it accept multiple arrays as arguments, like `difference` and `union` do? -
- Most Ruby methods implemented as C functions that accept a variable number of arguments use rb_scan_args for argument handling. rb_scan_args supports a `:` character for option hash/keyword arguments, which operates similarly to how key...
-
- Fixing typo. It seems I failed to press the shift key.
-
-
-
- Applied in changeset commit:git|6cad0644248d5acbaf3a2e8de4ff6d88b3dd2cb4.
----------
Try to fetch commits notes to the source tree automatically
[Bug #16167] -
- vo.x (Vit Ondruch) wrote:
> So this is in line with the changes referred here, but I somehow fail to see why the refs/notes/commits are not fetched automatically? Why should I do this myself? Previously, the make-snapshot did not need a... -
- [Bug #16167]
-
-
- Parents commit hashs in logs of merge commits are abbreviated to
necessary length depending on the repositories. Exclude merge
commits from ChangeLog to make it stable. -
09/14/2019
-
09:49 PM Feature #10344: [PATCH] Implement Fiber#raise
- NEWS is updated.
-
- This should only happen if the API is misused. It's much better
to warn here and fix the problem, versus to try to debug TypeErrors
or segfaults later. -
07:46 PM Bug #16167 (Assigned): make-snapshot does not work from fresh checkout
- nobu (Nobuyoshi Nakada) wrote:
> I'm going to deprecate `-exported` option because it can't make stable-checksum tarballs.
I used `-exported` just because I was struggling to get the make-snapshot work, so deprecating the option is f... -
- I'm going to deprecate `-exported` option because it can't make stable-checksum tarballs.
-
- Applied in changeset commit:git|e9c7fc7ca9bc15a9f84bdc356f7b6fac12988ccb.
----------
Continue to export even if no notes/commits
Just exporting may not imply exporting ChangeLog which needs
notes/commits. [Bug #16167] - 05:15 PM Revision 395e5f51 (git): * 2019-09-15 [ci skip]
-
-
- Just exporting may not imply exporting ChangeLog which needs
notes/commits. [Bug #16167] -
- Enters raw-mode but enable interrupts.
https://github.com/ruby/io-console/commit/7cba76561a -
- To prevent the `v` reference from being eliminated before argv is used,
calling `rb_free_tmp_buffer` against `v` explicitly. -
- Needs another room to append an empty hash.
- 10:43 AM Revision 9699a5c5 (git): Update news regarding `Fiber#raise`.
-
- nagachika pointed out that ALLOC_N is actually just malloc, so
this memory wasn't being freed. This shouldn't be a performance
sensitive code path, and will be going away after 2.7, so just
allocate a temp buffer that will be freed late... -
- It is not safe to set this in C functions that can be called from
other C functions, as in the non argument-delegation case, you
can end up calling a Ruby method with a flag indicating keywords
are set without passing keywords.
Introduc... -
- It happens inside “grpc” extension library.
Have you asked them? -
02:25 AM Bug #16136: String corruption in 2.6.4
- ruby_2_6 r67803 merged revision(s) ade1283ca276f7d589ffd3539fbc7b9817f682d5.
-
- Fix a use-after-free bug by avoiding rb_str_new_frozen
`str2 = rb_str_new_frozen(str1)` seems to make str1 a shared string that
refers to str2, but str2 is not marked as STR_IS_SHARED_M nor
STR_NOFREE.
`r...
09/13/2019
- 11:54 PM Revision b2c29bba (git): * remove trailing spaces. [ci skip]
-
- Remove rb_add_empty_keyword, and instead of calling that every
place you need to add empty keyword hashes, run that code in
a single static function in vm_eval.c.
Add 4 defines to include/ruby/ruby.h, these are to be used as
int kw_spla... -
- Dan0042 (Daniel DeLorme) wrote:
> In that case I'd like to make one last suggestion.
> ...
You can't make this an instance-specific flag and easily contain the scope to that method only. The user could pass `args` (not `*args`) as a a... -
- In that case I'd like to make one last suggestion.
For a method with `*args`, if the method is called with keyword arguments, flag `args` in some way (instance variable?) so that, in that method only, a call with `*args` would result ... -
- Dan0042 (Daniel DeLorme) wrote:
> With 2.7, people will be asked to migrate their generic delegations to use `pass_keywords`. Then at some point in the future when 2.6 is no longer supported, `pass_keywords` will be deprecated and they'... -
- There's something I'd like to clarify.
With 2.7, people will be asked to migrate their generic delegations to use `pass_keywords`. Then at some point in the future when 2.6 is no longer supported, `pass_keywords` will be deprecated an... -
- So far, I was using this sequence to get Ruby snapshot:
~~~
git clone https://github.com/ruby/ruby ~/ruby
cd ~/ruby && tool/make-snapshot -packages=xz -git=https://github.com/ruby/ruby tmp
~~~
But that does not work anymore. It ... -
- This sets the correct VM frame flags when using Method#call to
call funcs, and handles empty keyword hashes for cfuncs,
attr_reader, and attr_writer. It also fixes calls to send through
Method#call. It adds tests for all of those, as we... -
- Actually that reminds me - mame mentioned that the ruby core team needs a
motivation/impetus if a change is necessary based on real usage. So I think
this may be a good call for ruby users to comment in particular when it
may affect t... -
- > We need an evidence that the behavior actually confuses
> ...
It does not confuse me because ... I try to avoid it altogether. :D
I think sawa's issue can be a bit shortened (sorry!) to the last
comparison:
instance_exec(["... -
- I agree that Ruby's arguments are insanely complex. In the basic case, `"a"` and `["a"]` are distinguished.
```
p instance_exec("a") {|foo| foo } #=> "a"
p instance_exec(["a"]){|foo| foo } #=> ["a"]
p instance_exec("a") {|*foo... -
- In the parameter signature of a code block for a method that is not involved in method definition or creation of lambda objects, two types of arguments `["a"]` and `"a"` are neutralized:
```ruby
instance_exec(["a"]){|foo, bar| foo} #... -
03:16 PM Revision 98f919ed (git): The stdlib readline should raise Interrupt when pressing C-c
- 03:12 PM Revision 70fe473c (git): * 2019-09-14 [ci skip]
-
- This reverts commit 805b0a481132938638dbd32830cf5dca3910efb1.
-
- This reverts commit 685f12bbca50ff9b7a16b3016b3b8b3f2ac8b796.
-
- This reverts commit 6d9e54816f828983bcf383ce6fce287bd3ca05b9.
-
- test/ruby/test_fiber.rb: reduce the count of object creation to cause
GC
The test consistently fails on OpenBSD.
https://rubyci.org/logs/rubyci.s3.amazonaws.com/openbsd-current/ruby-master/log/20190903T010009Z.... -
- webrick/test_utils.rb: loosen timeout severity
to stabilize CI failure like:
https://rubyci.org/logs/rubyci.s3.amazonaws.com/osx1013/ruby-trunk/log/20181228T114501Z.fail.html.gz
git-svn-id: svn+ssh://ci.ruby-lan... -
-
-
07:24 AM Revision 2da6b328 (git): introduce IBF_(MAJOR|MINOR)_VERSION.
- RubyVM::InstructionSequence.to_binary generates a bytecode binary
representation. To check compatibility with binary and loading
MRI we prepared major/minor version and compare them at loading
time. However, development version of MRI ca... -
09/12/2019
-
- Ok, I misunderstood what `pass_keywords` was doing; I thought it would only apply to `baz(*args)` in this case.
-
- Dan0042 (Daniel DeLorme) wrote:
> After some more thinking I believe the `pass_keywords` behavior would be appropriate for 100% of methods with an argument splat but no keywords.
We do not want this as the default behavior. Consider... -
- After some more thinking I believe the `pass_keywords` behavior would be appropriate for 100% of methods with an argument splat but no keywords.
* If forwarding to a method with no keyword arguments
* The kwarg will be converted t... -
- > Then if you call `foo` with keywords, keywords will be passed to `bar`. This should allow for more backwards compatible behavior with older versions of Ruby.
Ah, great! So we no longer need the RUBY_VERSION check!
I have a feeli... - 03:35 PM Revision 69acf40b (git): * 2019-09-13 [ci skip]
-
- Fixed new Struct-related keyword argument warnings
-
11:19 AM Feature #14781 (Closed): Enumerator.generate - Applied in changeset commit:git|775037613bffe6f90e7af510b7f46a2ac10610be.
----------
Implement Enumerator.produce [Feature #14781] - 11:18 AM Revision ac3e8834 (git): Document and test Enumerator.produce
- Co-authored-by: Victor Shepelev <zverok.offline@gmail.com>
- 11:18 AM Revision 77503761 (git): Implement Enumerator.produce [Feature #14781]
-
09:43 AM Bug #16161: tailcall_optimization may be disabled after r67315
- How about adding `vm_call_iseq_setup_tailcall_opt_start` as same as `vm_call_iseq_setup_normal_opt_start`?
(Copy-and-paste code, sorry!)
```patch
diff --git a/vm_insnhelper.c b/vm_insnhelper.c
index a83e3a952a..4abee2fadd 100644
-... -
-
09:25 AM Feature #16102: `Symbol#call`
- I propose this general solution.
diff --git a/array.c b/array.c
index 3717c3ff34..3809af01cf 100644
--- a/array.c
+++ b/array.c
@@ -6988,6 +6988,7 @@ Init_Array(void)
rb_define_method(rb_cArray, "dig"... -
- I remember the old pickaxe having mentioned ENV as a hash-like
object. I guess the documentation could be updated to include
e. g. specifically a .is_a? Hash check too, and explain that
ENV is not completely a "full" Hash. -
- That is a documentation bug.
-
01:04 AM Bug #16165: Endless ranges have inconsistency between #cover? and #include?
- For the sake of archives & potential future search engine hits - this got fixed a few days ago and will be in whatever public release of Rails comes after 6.0.0.
https://github.com/rails/rails/pull/36460