Activity
From 08/23/2019 to 08/29/2019
08/29/2019
-
09:58 PM Revision 0a9d74f8 (git): Move pread + pwrite tests out of RUBY_ENGINE block
- These tests were guarded by a RUBY_ENGINE of "ruby" even though they test an official Ruby feature (pread/pwrite added in Ruby 2.5). This commit moves them to the top level of the test case so they will run on other implementations.
-
09:51 PM Revision bdc36094 (git): Add some NODE information for lldb
- Just adds a conditional in the lldb scripts so we can more easily debug
NODE objects. -
08:33 PM Feature #16122: Data: simple immutable value object
- @mame, @matz, I updated the description, tried to include a proper rationale for every design decision made.
-
- @mame I understand your concerns. I'll update the description today or tomorrow to include all the terminology and detailed rationale behind the proposal.
-
02:14 PM Feature #16122: Data: simple immutable value object
- I couldn't understand what is "value object", and I found: https://martinfowler.com/bliki/ValueObject.html
Please do not assume that everybody knows such an essay ;-)
No one pointed out the article during the developer's meeting, so we c... -
- @Dan0042 you are (probably) missing `#inspect`, `#==`, `#eql?`, `#hash`, `#to_h` and a bunch of other methods that are pretty trivial, but also important for the "value object".
-
12:50 PM Feature #16122: Data: simple immutable value object
- If I understand correctly, the idea is to have `X=Struct::Value.new(:x,:y,:z)` which is strictly equivalent to
```ruby
class X
def initialize(x=nil, y=nil, z=nil)
@x,@y,@z = x,y,z
end
attr_reader :x, :y, :z
#and othe... -
- @matz Sorry for not sharing more detailed reasoning which led to the current proposal (I explained the "final reasons" in its text, but it is too terse).
So, it went as following:
1\. First, I really wanted just `Struct.new(..., im... -
08:01 AM Feature #16122 (Feedback): Data: simple immutable value object
- The typical solution is `Struct.new(...).freeze`. This doesn't require any enhancement. The other option is `Struct.new(..., immutable: false)`. It looks simpler than the proposed `Struct::Value`.
Matz.
-
07:43 PM Feature #16131: Remove $SAFE, taint and trust
- byroot (Jean Boussier) wrote:
> > 3.2 `taint/trust/untaint/untrust` non-verbose warning when called
> ...
No. Verbose warning means a warning only printed in verbose mode (`ruby -w`, or `$VERBOSE = true`). Non-verbose warning means a... -
06:49 PM Feature #16131: Remove $SAFE, taint and trust
- > 3.2 `taint/trust/untaint/untrust` non-verbose warning when called
Maybe you meant verbose here?
Other than that I agree with the proposed timeline, and as soon as these methods are noop, their cost become mostly null.
Making t... -
- I agree with the removal of `$SAFE` and the taint tracking. Proposed timeline:
2.7:
* Remove taint tracking/mechanism.
* Non-verbose warning on setting/access of `$SAFE`
* `taint`/`trust`/`untaint`/`untrust` become no-ops, verbos... -
07:14 AM Feature #16131 (Closed): Remove $SAFE, taint and trust
- Ruby had Taint checking which is originally introduced in Perl.
https://en.wikipedia.org/wiki/Taint_checking
It was intended to provide a useful tool for handle objects which are come from outside.
Input data is set as tainted by de... -
06:57 PM Revision 94b79bff (git): Add word "Euler's number" to Math::E docs
- When searching for this constant, I landed on the correct page https://ruby-doc.org/core-2.6.4/Math.html however I was using CMD+f to search for "Euler" and did not find it. If we add the full name for this constant then it will be easie...
-
03:35 PM Revision a8b310e1 (git): 7z does not accept gzip's options
- e.g. `GZIP=-9`
-
03:23 PM Bug #11326 (Closed): Defining a writer as a Struct member allowed?
- Applied in changeset commit:git|e51dca2596db9567bd4d698b18b4d300575d3881.
----------
Disallow use of attrset symbols as Struct members
Fixes [Bug #11326] -
- Accepted.
Matz. - 03:23 PM Revision c52d38b7 (git): * 2019-08-30 [ci skip]
-
- Fixes [Bug #11326]
-
02:06 PM Revision 01b723ba (git): Refined warnings against literal in flip-flop
-
-
12:49 PM Revision 2c1e902c (git): Don't pick up lib/readline.rb from ruby/reline
-
-
- typedef struct _COORD {
SHORT X;
SHORT Y; // I wanted to take this...
} COORD, *PCOORD;
typedef struct _CONSOLE_SCREEN_BUFFER_INFO {
COORD dwSize;
COORD dwCursorPosition; // ...of this one
WORD wAttributes; ... -
- typedef struct _CONSOLE_SCREEN_BUFFER_INFO {
COORD dwSize; // 4(SHORT X, Y)
COORD dwCursorPosition; // 4
WORD wAttributes; // 2
SMALL_RECT srWindow; // 8(SHORT Left, Top, Right, ... -
11:50 AM Revision 13b69220 (git): bump up teeny version to 2.6.5.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_6@67799 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Applied in changeset commit:git|a4a19b114ba94b8f28d5a91aee5d595a516006d5.
----------
Allow non-finalizable objects in ObjectSpace::WeakMap
[feature #16035]
This goes one step farther than what nobu did in [feature #13498]
With this p... -
- I think this is the required behavior for `WeakMap` to implement a cache for example. Accepted.
Matz.
-
06:41 AM Feature #16035 (Assigned): Allow non-finalizable objects such as Integer, static Symbol etc in ObjectSpace::WeakMap
- sorry, value is collectable (my misunderstand).
-
-
- `42` never be collected. Is it intentional?
-
- [feature #16035]
This goes one step farther than what nobu did in [feature #13498]
With this patch, special objects such as static symbols, integers, etc can be used as either key or values inside WeakMap. They simply don't have a fina... -
11:10 AM Feature #14781: Enumerator.generate
- I just wrote a draft implementation of Enumerator.produce. I just didn't notice @zverok kindly worked on writing a patch, so I'll review and integrate it later!
-
- I prefer `produce` to `iterate`, `generate` or `from`. Accepted (at least for the experiment).
Matz. -
- @matz Of course. What prompted me to open this feature request is a feature I implemented in Rails where I use this exact pattern: https://github.com/rails/rails/pull/35891 (more specifically https://github.com/rails/rails/blob/48ae1ba36...
-
- I am not sure if the proposal has real-world use-case. Can you elaborate?
Matz.
-
09:34 AM Revision e4be2fda (git): Rule out gcc on Windows
- It seems the combination fails at the moment. Don't know exactly
why but I suspect there can be issues in resolving weak references.
Let's rule them out for now.
https://ci.appveyor.com/project/ruby/ruby/builds/27036383/job/x3c5d54839a... -
- We can check the function pointer passed to
rb_define_singleton_method like how we do so in rb_define_method.
Doing so revealed many arity mismatches. -
- We can check the function pointer passed to rb_define_private_method
like how we do so in rb_define_method. Doing so revealed some
problematic usages of rb_obj_dummy. They had to be split according
to their arity. -
- We can check the function pointer passed to
rb_define_protected_method like how we do so in rb_define_method.
This changeset revealed no prototypes mismatches. -
- We can check the function pointer passed to rb_define_method_id
like how we do so in rb_define_method. This method is relatively
rarely used so there are less problems found than the other APIs. -
- To properly generate documents.
-
- We can check the function pointer passed to rb_define_global_function
like we do so in rb_define_method. It turns out that almost anybody
is misunderstanding the API. -
- We can check the function pointer passed to rb_define_module_function
like how we do so in rb_define_method. The difference is that this
changeset reveales lots of atiry mismatches. -
- The rb_define_method function takes a pointer to ANYARGS-ed functions,
which in fact varies 18 different prototypes. We still need to
preserve ANYARGS for storages but why not check the consistencies if
possible.
Q&As:
Q: Where did th... -
- This is just a trivial mistake introduced in
0f36e8fc03a5c6433972d6bb5f177d5f6e106bac. -
- This is just a trivial mistake introduced in
6c56dae4b23c5c50e351758538141ca26b9aba40. -
- Applied in changeset commit:git|abe12d8b96be3c12618811f22ca01788366f99f8.
----------
Freeze method reference operator object
[Feature #16103] -
- Matz accepted it :tada:
-
- [Feature #16103]
-
07:44 AM Feature #8970: Array.zip and Array.product
- If you use https://bugs.ruby-lang.org/issues/15955, you can write as follows.
```ruby
class UnboundMethod
# apply or other name
def apply(receiver, *args)
bind(receiver).call(*args)
end
end
arrays = [["a", "b"], ["c... -
- I like the OP's idea. It's up to @marcandre
Matz. -
- Accepted. It should raise an error on end-exclusive ranges (`...`).
Matz. -
- I understand there's theoretically exist a situation this feature is useful.
But I think it doesn't exist in practice.
I object to provide an additional utility to support legacy encoding. -
06:50 AM Bug #15908 (Closed): Detecting BOM with non-UTF encoding
- Depending on usage, distinction of UTF-8 (with/without BOM), UTF-16LE without BOM, UTF-16BE with or without BOM, and so on may also be necessary. Also, for Japanese, traditionally distinction between EUC-JP, Shift_JIS, and ISO-2022-JP ca...
-
- This reverts commits:
* d365fd5a024254d7c105a62a015a7ea29ccf3e5d
* d780c3662484d6072b3a6945b840049de72c2096
* aa7211836b769231a2a8ef6b6ec2fd0ec882ef29
* 043f010c28e82ea38978bf8ed885416f133b5b75
* bb4dd7c6af05c7821d572e2592ea3d0cc748d81f
... -
- During today's meeting, it was mentioned that production deployments may not want to include this functionality.
To do this, one solution would be to make this functionality available as a bundled gem. -
- 06:12 AM Revision 07f9cd96 (git): * 2019-08-29 [ci skip]
-
- Agreed.
Matz. -
- After experiments, `|>` have caused more confusion and controversy far more than I expected. I still value the chaining operator, but drawbacks are bigger than the benefit. So I just give up the idea now. Maybe we would revisit the idea...
-
-
-
- After discussion and consideration, we picked `_1`, `_2`... as numbered parameters. I investigated replaced examples, the current `@1` etc. are too confusing with instance variables. So I picked underscore for numbered parameters (a la S...
-
05:05 AM Feature #15588: String#each_chunk and #chunks
- Just an idea, this method may be useful to treat data of fixed-length record format if it accepts multi column lengths, such as
```ruby
records = []
fixed_length_records_data.each_slice(7, 10, 20) do |zip, tel, name|
records.push... -
- As @shyouhei mentioned, we'd like to hear the real-world use-case. Extracting fixed-width records may be the purpose. I'm curious about the OP's opinion.
Matz. -
- Applied in changeset commit:git|761346a9604ca2c79777d1d67fb5dcc3c30dbf69.
----------
Show the previous definition location,
when reopened class/module redefinition mismatched the previous
definition. [Feature #11460] -
- Accepted.
Matz.
-
- usa said it might not work on windows when the install path includes non-ASCII characters. Please check it out, @nobu .
-
- when reopened class/module redefinition mismatched the previous
definition. [Feature #11460] -
- Dan0042 (Daniel DeLorme) wrote:
> ```
> ...
Correct. That is expected, as the method takes no arguments, only keyword parameters.
> ```
> ...
Correct. This is expected, as the method does not support a keyword parameter for `9`.
... -
- I tried testing to see what behavior changes are introduced via this. This is what I found so far.
```
def foo(*c, **f); p [c,f]; end; foo(9=>9, f:12)
before: [[{9=>9}], {:f=>12}]
after: [[], {9=>9, :f=>12}]
```
Good bugfix I th... -
- A range literal in conditional expression is turned into a
flip-flop, as a Range object is never falsy and does not make a
sense. -
-
- This reverts commit bf7a32d22079cc44eb19794e41d82b886d5d17b3.
flip-flop is no longer deprecated.
[Feature #5400] -
- I cannot reproduce this on 2.5.6, 2.6.4, 2.7.0-preview1, or the master branch. It was probably fixed by commit:f91879a7b548284c93743168acfd11e3d2aeefac. If you are still having problems with it, please reopen.
08/28/2019
-
- Attached is a patch that fixes this issue by switching from `rb_block_call` to `rb_funcall_with_block`.
-
- Applied in changeset commit:git|cd0e208963bdf9ee2fec30e83bdc8f6bc77a7b8d.
----------
Document {n}? regexp pattern is optional and not non-greedy [ci skip]
While not consistent with {n,}?, {,m}?, and {n,m}?, it is arguably
more useful, ... -
- While not consistent with {n,}?, {,m}?, and {n,m}?, it is arguably
more useful, as otherwise the ? would have no effect.
Fixes [Bug #15583] -
- This problem appears fixed in 2.6.4 and 2.7.0-preview1 in my environment (OpenBSD-amd64). It still occurs in 2.5.6. If it still occurs for you in 2.6.4, please reopen.
-
- @zverok Thank you!
-
- @mame OK, sorry. I was not sure how the process looks internally (e.g. should I save the space and attention of the reader in agenda by just listing things shortly, or provide the full context in-place). Here are updated descriptions, ju...
-
- zverok (Victor Shepelev) wrote:
> * [Feature #14781] `Enumerator.generate`. Patch provided; Matz seem to have liked the idea and name proposed, can we have it in 2.7?
> ...
The two tickets were discussed at the past meetings. Next tim... -
- Looks like we have too many topics at the next meeting. Please do not expect all tickets to be discussed. Thank you for your understanding.
-
10:58 AM Bug #15900: Resolv::DNS#each_name doesn't accept Resolv::IPv{4,6} against documents
- Could you please backport to 2.5 and 2.6?
-
-
- This reverts commit 6454808c52fff445ff09fefb0fb96988f82aaa3c.
It is no longer needed, as `VCS::SVN#get_revisions` now returns
`Integer` as revision numbers, and `short_revision` should deal
with it. -
- `_FILE_OFFSET_BITS` should be defined before system headers.
-
- Remove jquery.js
Remove debug print [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_6@67797 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Fixed unmatched indent of the closing bracket for
`:irb_current_working_workspace`, and adjusted following elements. - 06:57 AM Revision 2b55df73 (git): `revision` might be an Integer
- 06:45 AM Revision aca4e654 (git): merge revision(s): f308ab2131ee675000926540cbb8c13c91dc3be5
- Remove jquery.js
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@67794 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 06:43 AM Revision 32aca3dd (git): merger revision(s): f308ab2131ee675000926540cbb8c13c91dc3be5
- Remove jquery.js
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@67793 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
-
- I backported 4e038a7e into ruby_2_6 at r67792.
-
- Revert "parse.y: Deprecate flip-flops"
This reverts commit bae638ad5b782c44c80efe33834cb9039279af46.
[Feature #5400]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_6@67792 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 05:00 AM Revision 47403b71 (git): merge revision(s) 989e8ad322afdfa3aa06e74b89fc42aef42895d0:
- Remove debug print [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@67791 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 04:57 AM Revision 73eb2984 (git): merge revision(s) 989e8ad322afdfa3aa06e74b89fc42aef42895d0:
- Remove debug print [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@67790 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
-
- This isn't a bug. It is not in Ruby's control to release memory to the operating system. Ruby just calls `free` on the underlying memory pointer. If the libc `free` function does not end up releasing the memory to the operating system...
-
03:08 AM Feature #15631 (Closed): Let round_capa for ID table not allocate excess capacity for power of 2 ints >= 4 - Applied in changeset commit:git|8e13da1ee83028000e5d7f9f9526379e32765a81.
----------
optimize get_power2 [Feature #15631]
Merged: https://github.com/ruby/ruby/pull/2292 - 02:29 AM Revision 8e13da1e (git): optimize get_power2 [Feature #15631]
- Merged: https://github.com/ruby/ruby/pull/2292
-
-
-
- I don't think the current behavior is a bug, as the parameters for a non-lambda proc are optional. Also, changing the behavior could be backwards incompatible.
I propose instead a `lambda` keyword to `Proc#parameters`, which would re... -
-
-
- Does this issue still occur with 2.5.5 or 2.6.3?
-
- Does this issue still occur with 2.5.5 or 2.6.3?
-
- Testing Ruby versions from 1.9 to 2.7, only Ruby 2.3 does not raise a `NoMethodError` for the example code. I think that can be considered a bug in Ruby 2.3. As Ruby 2.3 is no longer supported, the bug will not be fixed.
-
-
- I don't think that this should be considered a bug. Going from immutable to mutable should not break things, while going from mutable to immutable can. It is true that the using `String#+` can decrease performance slightly, but that sh...
-
-
-
-
- because default value overrides it.
https://help.github.com/en/articles/virtual-environments-for-github-actions#environment-variables -
-
08/27/2019
-
- I do not think the current behavior is a bug. However, supporting implicit conversion seems like a useful feature to add. I've implemented ivoanjo's proposal of `to_st` as an implicit conversion method in the attached patch.
-
07:26 PM Feature #5400: Remove flip-flops in 2.0
- Fyi this currently causes `ri` tab completion to display a warning (https://github.com/scop/bash-completion/issues/343)
```
$ ri mktmpd-e:1: warning: flip-flop is deprecated
Nothing known about RSS::Maker::RSS09::Channel
Did you me... -
- RFC 1035 Section 2.3.4 specifies that UDP messages are limited to 512 octets or less. RFC 6891 confirms this number unless you are using EDNS(0) extensions. It does not appear that `Resolv::DNS` supports EDNS(0), therefore the limit of...
-
- Ripper doesn't track usage of local variables as far as I can see. In `parse.y`, `LVAR_USED` is used to mark local variables as being used. In normal compilation mode, this is set by `mark_lvar_used`, called by `value_expr_check`, call...
-
- `rb_ast_t` holds a reference to this object, so it should mark the
object. Currently it is relying on the `mark_ary` on `node_buffer` to
ensure that the object stays alive. But since the array internals can
move, this could cause a seg... -
- This issue still occurs in the master branch. Attached is a patch that fixes it by detecting changes in pid.
-
- This issue still occurs in the master branch. The originally submitted patch needs a small change to apply. An updated patch is attached.
-
- Hanmac (Hans Mackowiak) wrote:
> @Dan0042 in your list about implicit and explicit you forgot `{ foo }` depending on the method who gets the block, it might does an instance_eval thing where the block self is the block variable
There... -
03:13 PM Feature #16120: Omitted block argument if block starts with dot-method call
- @Dan0042 in your list about implicit and explicit you forgot `{ foo }` depending on the method who gets the block, it might does an instance_eval thing where the block self is the block variable
i know that would need to change of the... -
- @nobu, wow, thank you so much. I never imagined it would be THAT simple to implement.
`O_O @_@ m(_ _)m`
But I do think it would be better with `(parser_numbered_param(p, 0))` in the commit [here](https://github.com/ruby/ruby/commit... -
- Dan0042 (Daniel DeLorme) wrote:
> @mame, The motivation of *this* proposal is related to the **side-by-side** proximity/repetition of `x` in `{|x|x.foo}`. Other proposals may be different. I can only guess at their true motivations. It ... -
- @mame, The motivation of *this* proposal is related to the **side-by-side** proximity/repetition of `x` in `{|x|x.foo}`. Other proposals may be different. I can only guess at their true motivations. It just *seems* to me that the people ...
-
- https://github.com/nobu/ruby/tree/feature/implicit-block-param
-
- - Fix checkout error: `fatal: destination path '.' already exists and is not an empty directory.`
- Remove `GITHUB_SHA` in env, because set automatically
https://help.github.com/en/articles/virtual-environments-for-github-actions#envir... -
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
04:00 PM Misc #16130: [Discussion / Ideas] Finding a good name for the concept of/behind guilds - primarily the NAME
- A Braid of Threads also makes sense in that metaphor. Twine is another option similar to Rope or Yarn.
I do like the name Guild since it's a thing than can be joined to cooperate for a common purpose.
What would the terminology equ... -
01:27 PM Misc #16130: [Discussion / Ideas] Finding a good name for the concept of/behind guilds - primarily the NAME
- If Fiber composes Thread, then Thread composes Yarn, or Rope.
-
11:59 AM Misc #16130: [Discussion / Ideas] Finding a good name for the concept of/behind guilds - primarily the NAME
- (1) The name "Guilds":
To me the name guild implies something that is related to one another.
In medieval days, the concept of a guild was mostly used to refer e. g.
to the "guild of mastersmiths", that is people of a certain prof... -
- In recent presentions this year, and perhaps prior to that as well if I
remember correctly, matz mentioned that the core team (and matz) may be
looking for a good name to the concept of/behind guilds.
The thread here, this issue, is... -
03:56 PM Revision 88a37dc6 (git): Stop passing CC_LIBS in compile_c_to_o
- To fix "gcc: -lgcc: linker input file unused because linking not done" in
https://rubyci.org/logs/rubyci.s3.amazonaws.com/openbsd65/ruby-master/log/20190826T200009Z.log.html.gz
Still I'm intentionally leaving CC_DLDFLAGS_ARGS because ma... -
-
- 03:19 PM Revision 6454808c (git): Treat RUBY_REVISION as an integer on old rubies
-
- a little.
Doing both `git clone --depth=1` and `git reset --hard ${sha}` does not
make sense (the latter command either does nothing or just fails), so I
added non-1 value as a depth.
Maybe we don't need depth=50 for pull_request and s... - 03:12 PM Revision 9928a6a3 (git): * 2019-08-28 [ci skip]
- 03:10 PM Revision 24316a78 (git): Bump version to 2.5.7
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@67786 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
-
- My apologies if I did something inappropriate. I *did* realize there was some duplication, I just thought these issues should be considered part of a single "package". 100% agree with @duerst, what he describes is what I was trying to do.
-
- > I know I shouldn't comment on individual issues here
While I agree, one problem is that e. g. Dan0042 did not read the prior comments here - in
particular he linked in "[Misc #15723] Reconsider numbered parameters", which already w... -
- Dan0042 (Daniel DeLorme) wrote:
> * [Feature #10829] Add to_proc method to the Array class
> ...
I know I shouldn't comment on individual issues here, but I haven't found a better way of commenting on this group of issues (maybe we sho... -
- workflows, because mame said he has never seen it.
-
-
-
- in response to the declaration change in
e3fc30564e9466d6926f9d25a090dcf787bd5c33.
Fixing the AppVeyor mswin CI failure:
https://ci.appveyor.com/project/ruby/ruby/builds/26980881/job/2j6h1qwjnbc8cpop
ref: https://github.com/ruby/ruby/p... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_6@67782 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 12:55 PM Revision 03c737f3 (git): Update rdoc version from 5.0.0 to 5.0.1.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@67781 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_6@67780 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 12:53 PM Revision 8c57255f (git): Update rdoc version from 6.0.1 to 6.0.1.1.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@67779 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- ned (Ned Hadzo) wrote:
> This was reverted, right? https://github.com/ruby/ruby/commit/a0980f2446c0db735b8ffeb37e241370c458a626
It has been re-introduced. The Mojave issue was also fixed. -
07:50 AM Feature #15902: Add a specialized instruction for `.nil?`
- This was reverted, right? https://github.com/ruby/ruby/commit/a0980f2446c0db735b8ffeb37e241370c458a626
-
- It's a result of treating file names as sequences of characters rather than as binary garbage. For some operations, one doesn't really care about the filename itself, so treating it as binary garbage would be okay. But for other operatio...
-
- 09:04 AM Revision e5810659 (git): Skip test_gc_stress_at_startup because it causes SEGV on some platforms
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@67778 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * .github/workflows/doxygen.yml: add a workflow for doxygen in Actions
-
- They lack portability. See also
https://travis-ci.org/shyouhei/ruby/jobs/577164015 -
- After 5e86b005c0f2ef30df2f9906c7e2f3abefe286a2, I now think ANYARGS is
dangerous and should be extinct. This function has only one call site
so adding appropriate prototype is trivial. -
- After 5e86b005c0f2ef30df2f9906c7e2f3abefe286a2, I now think ANYARGS is
dangerous and should be extinct. There is only one usage of
MEMO::u3::func in load.c (where void Init_Foobar(vodi) is registered)
so why not just be explicit. -
- After 5e86b005c0f2ef30df2f9906c7e2f3abefe286a2, I now think ANYARGS is
dangerous and should be extinct. This commit adds a function
prototype for rb_ivar_foreach. Luckily this change revealed no
problematic usage of the function. -
- After 5e86b005c0f2ef30df2f9906c7e2f3abefe286a2, I now think ANYARGS is
dangerous and should be extinct. This commit adds function prototypes
for rb_hash_foreach / st_foreach_safe. Also fixes some prototype
mismatches. -
- After 5e86b005c0f2ef30df2f9906c7e2f3abefe286a2, I now think ANYARGS is
dangerous and should be extinct. This commit uses rb_gvar_getter_t /
rb_gvar_setter_t for rb_define_hooked_variable /
rb_define_virtual_variable which revealed lots ... -
- After 5e86b005c0f2ef30df2f9906c7e2f3abefe286a2, I now think ANYARGS is
dangerous and should be extinct. This commit adds function prototypes
for struct st_hash_type. Honestly I don't understand why they were
commented out at the first ... -
- After 5e86b005c0f2ef30df2f9906c7e2f3abefe286a2, I now think ANYARGS is
dangerous and should be extinct. This commit deletes ANYARGS from
st_foreach. I strongly believe that this commit should have had come
with b0af0592fdd9e9d4e4b863fd... -
- After 5e86b005c0f2ef30df2f9906c7e2f3abefe286a2, I now think ANYARGS is
dangerous and should be extinct. This commit deletes ANYARGS from
rb_thread_create, which seems very safe to do. -
- After 5e86b005c0f2ef30df2f9906c7e2f3abefe286a2, I now think ANYARGS is
dangerous and should be extinct. This commit deletes ANYARGS from
rb_proc_new / rb_fiber_new, and applies RB_BLOCK_CALL_FUNC_ARGLIST
wherever necessary. -
- After 5e86b005c0f2ef30df2f9906c7e2f3abefe286a2, I now think ANYARGS is
dangerous and should be extinct. This commit deletes ANYARGS from
rb_catch, and fixes some bugs revealed by that. -
- After 5e86b005c0f2ef30df2f9906c7e2f3abefe286a2, I now think ANYARGS is
dangerous and should be extinct. This commit deletes ANYARGS from
rb_ensure, which also revealed many arity / type mismatches. -
- After 5e86b005c0f2ef30df2f9906c7e2f3abefe286a2, I now think ANYARGS is
dangerous and should be extinct. This commit deletes ANYARGS from
rb_rescue / rb_rescue2, which revealed many arity / type mismatches. -
- After 5e86b005c0f2ef30df2f9906c7e2f3abefe286a2, I now think ANYARGS is
dangerous and should be extinct. This commit makes rb_iterate free
from ANYARGS. -
- After 5e86b005c0f2ef30df2f9906c7e2f3abefe286a2, I now think ANYARGS is
dangerous and should be extinct. This commit deletes ANYARGS from
struct vm_ifunc, but in doing so we also have to decouple the usage
of this struct in compile.c, wh... -
- After 5e86b005c0f2ef30df2f9906c7e2f3abefe286a2, I now think ANYARGS is
dangerous and should be extinct. Let's start from making
rb_block_call_func_t strict, and apply RB_BLOCK_CALL_FUNC_ARGLIST liberally. -
- Nobu missed it in f0e73fc9862c8d2c57a89349fb79012b826b8245.
-
- Ko1 missed this in d5893b91faa7dc77ca6c9728d1054dabd757aead.
-
- This reverts commit 9bc1667a188392b94971b9b96507af76cbd5f413.
`name` lines are not expanded. -
-
- 05:28 AM Revision 8536f671 (git): merge revision(s) 1613917ae64: [Backport #15784]
- Defer setting gc_stress instead of setting dont_gc
[Bug #15784]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@67777 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ```
In file included from sprintf.c:1256:
./vsnprintf.c:833:8: warning: adding 'int' to a string does not append to the string [-Wstring-plus-int]
IS_PRI_EXTRA_MARK(fmt)) {
^~~~~~~~... -
- I've submitted a pull request to fix this: https://github.com/ruby/webrick/pull/26
-
- Unfortunately, dladdr accepts void*, not const void*, in Solaris.
- 05:02 AM Revision b67fae37 (git): Revert a part of r67767
- it was not necessary for ruby_2_5.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@67776 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- to suppress a warning.
```
signal.c: In function 'ruby_abort':
signal.c:987:1: warning: 'noreturn' function does return
}
^
``` -
- Can you reproduce this bug in 2.5.5 or 2.6.3?
-
- I agree that this is a feature request and not a bug report. I think this is a useful feature, and have submitted a pull request to implement it: https://github.com/ruby/webrick/pull/25
-
- Do these tests still fail after commit:1e54903684aa3c9ea3fe54520157846a1b1f07be?
-
- Spec was removed in commit:c4cc4725ec08f26b9f46b99e38b0eba18f733ddc.
-
-
- I think this is not a bug, but a feature request for IPv6 resolution when no public IPv6 address is present. I think you can only consider this a bug if you think the default behavior should be to return IPv6 addresses in such cases.
... - 03:08 AM Revision 00a7d49b (git): merge revision(s) f1a52d96a59c63d46cb23af60cdcaf38e30e0512 [Backport #15784]
- Defer setting gc_stress until inits done
[Bug #15784]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@67775 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Merge space and slash to character class and add missing `CXX=` before `=g++-4.2`
at 5e10cb04e88c8a95ee44f6cad2bdf264e0dff92a -
- I'm overhauling ripper to multiplex the callback values and the parser union.
https://github.com/nobu/ruby/tree/ripper.value
08/26/2019
-
- I believe that `map(&JSON.:parse)` must be considered together because it is strongly related to the motivation of your proposal. Note that `map(&JSON.:parse)` is incomplete. People will next want to omit a parameter of `map {|x| JSON....
-
- The syntax I propose is definitely not *meant* to absorb all styles. I think any attempt to be everything to everyone is doomed to failure. I do not believe this is a race where only one of the various proposals can win; considering the ...
-
-
10:22 PM Bug #15992: An exception breaks monitor state and cause deadlock
- Should `mon_enter` and `mon_exit` use `Thread.handle_interrupt` inside their method definitions, so they are safe when called directly too?
`Thread.handle_interrupt(Exception => :never)` seems too much for `mon_enter`, I think `Thread... -
- ruby_2_5 r67774 merged revision(s) f91879a7b548284c93743168acfd11e3d2aeefac,9557069299ac3b96691040a541afa65761a724ad.
-
- * [Feature #10829] Add to_proc method to the Array class
* [Feature #12115] Add Symbol#call to allow to_proc shorthand with arguments
* [Feature #15302] Proc#with and Proc#by, for partial function application and currying
* [Misc #157... -
-
-
-
-
-
-
-
-
-
-
- Does this issue still occur with 2.5.5 or 2.6.3?
-
-
-
- Can you try again with 2.5.5 or 2.6.3?
-
- This issue started in Ruby 2.5 and is still present in 2.6. It appears to be related to the code page. If I have a directory with Japanese characters (テスト), the error occurs with my default code page (437), but does not occur if I swit...
-
- I'm afraid the keys to this hash are just integers, and those integers
may look like VALUE pointers when they are not. Since we don't mark the
keys to this hash, it's probably safe to say that none of them have
moved, so we shouldn't tr... -
- This commit just makes `gc_update_table_refs` match `mark_tbl_no_pin`
more closely. -
- I don't think this is a bug. If `eql?` returns true, `hash` must return the same value. Class `X` in this example violates that constraint, resulting in undefined behavior. If you fix class `X`, the behavior is correct in all ruby ver...
-
- Can you try 2.5.5 or 2.6.3 and see if this problem has been fixed?
-
- 05:03 PM Revision 4d9c5875 (git): merge revision(s) f91879a7b548284c93743168acfd11e3d2aeefac,9557069299ac3b96691040a541afa65761a724ad: [Backport #15992]
- handle_interrupt to defend monitor state [Bug #15992]
If an exception is raised from another thread for example Timeout
and this thread is just after `mon_exit`'s `@mon_owner = nil`,
the exception breaks the stat... -
- ruby_2_5 r67773 merged revision(s) d5c33364e3c0efb15e11df417c925afee2cdb9c9.
- 04:49 PM Revision 416249b3 (git): merge revision(s) d5c33364e3c0efb15e11df417c925afee2cdb9c9: [Backport #16105]
- Fixed heap-use-after-free
* string.c (rb_str_sub_bang): retrieves a pointer to the
replacement string buffer just before using it, for the case of
replacement with the receiver string itself. [Bug #16105]
... -
-
- ruby_2_5 r67772 merged revision(s) 5b1bf8dd2d08ae7371ecf025967376bb794ed651.
- 04:44 PM Revision f8efd7f9 (git): merge revision(s) 5b1bf8dd2d08ae7371ecf025967376bb794ed651: [Backport #16099]
- UTF LE is fixed at least the first 2 bytes
* io.c (io_strip_bom): if the first 2 bytes are 0xFF0xFE, it
should be a little-endian UTF, 16 or 32. [Bug #16099]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby... -
-
-
-
-
-
-
-
-
-
-
-
- ruby_2_5 r67771 merged revision(s) ec8e5f5aa64e2a54cf1e303f2b012c98e8d521ba,5a187e26adc8aa32367f294c1496935c7356d386.
- 04:20 PM Revision ef626cd0 (git): merge revision(s) ec8e5f5aa64e2a54cf1e303f2b012c98e8d521ba,5a187e26adc8aa32367f294c1496935c7356d386: [Backport #15952]
- array.c: always check frozenness in Array#unshift. Fixes [Bug #15952]
Closes: https://github.com/ruby/ruby/pull/2251
array.c add back shared array optimization to
ary_ensure_room_for_unshift
Bug fix in... -
- ruby_2_5 r67770 merged revision(s) 8f51da5d41f0642d5a971e4223d1ba14643c6398.
- 04:17 PM Revision 080e04e8 (git): merge revision(s) 8f51da5d41f0642d5a971e4223d1ba14643c6398: [Backport #15946]
- Get rid of undefined behavior
* string.c (rb_str_sub_bang): str and repl can be same.
[Bug #15946]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@67770 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_5 r67769 merged revision(s) 28678997e40869f5591eae60edd9757334426ffb,8797f48373dcfa3ff8e748667732dea8aea4347e.
- 04:16 PM Revision 6b7ebe83 (git): merge revision(s) 28678997e40869f5591eae60edd9757334426ffb,8797f48373dcfa3ff8e748667732dea8aea4347e: [Backport #15937]
- Preserve the string content at self-copying
* string.c (rb_str_init): preserve the embedded content when
self-copying with a capacity. [Bug #15937]
New buffer for shared string
* string.c (rb_str_ini... -
- ruby_2_5 r67768 merged revision(s) ae2a904ce9bffedee7d110dc60fd51c0a2879a5b,165ddfda20f6db8a3149d14c4f431fc242ddab70,fa7a768fdfe5223a29db4fa71b3e6101fb02ad51.
- 04:12 PM Revision 2b97b8e0 (git): merge revision(s) ae2a904ce9bffedee7d110dc60fd51c0a2879a5b,165ddfda20f6db8a3149d14c4f431fc242ddab70,fa7a768fdfe5223a29db4fa71b3e6101fb02ad51: [Backport #16051]
- Update the certificate files to make the test pass on Debian 10
The old certificate files (for example, test/rubygems/ca_cert.pem) were
signed by SHA1. This message digest is considered too weak and rejected
by ... -
- ruby_2_5 r67767 merged revision(s) 9dec4e8fc3a6018261834b5ac9b9877f787b97ca.
- 04:09 PM Revision b49b1d76 (git): merge revision(s) 9dec4e8fc3a6018261834b5ac9b9877f787b97ca: [Backport #15934]
- String#b: Don't depend on dependent string
Registering a string that depend on a dependent string as fstring
can lead to use-after-free. See c06ddfe and 3f95620 for details.
The following script triggers use-aft... -
- ruby_2_5 r67766 merged revision(s) 3f9562015e651735bfc2fdd14e8f6963b673e22a,c06ddfee878524168e4af07443217ed2f8d0954b,3b3b4a44e5.
- 03:58 PM Revision 689a6a0a (git): merge revision(s) 3f9562015e651735bfc2fdd14e8f6963b673e22a,c06ddfee878524168e4af07443217ed2f8d0954b,3b3b4a44e5: [Backport #15792]
- Get rid of indirect sharing
* string.c (str_duplicate): share the root shared string if the
original string is already sharing, so that all shared strings
refer the root shared string directly. indirect shar... -
- ruby_2_5 r67765 merged revision(s) 5e018214e7435030727a97ac49db038d96438e74.
- 03:40 PM Revision 470dae33 (git): merge revision(s) 5e018214e7435030727a97ac49db038d96438e74: [Backport #15720]
- Fix SystemStackError when calling a method in an unused refinement
Fixes [Bug #15720]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@67765 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_5 r67764 merged revision(s) c1d78a7f0ece2004822193a0c1f1fd3dc38c2fdf.
- 03:39 PM Revision 33151275 (git): merge revision(s) c1d78a7f0ece2004822193a0c1f1fd3dc38c2fdf: [Backport #15360]
- do_mutex_lock: release mutex before checking for interrupts (fixes
issue 15360)
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@67764 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_5 r67763 merged revision(s) 6375c68f8851e1e0fee8a95afba91c4555097127,c05eaa93258ddc01e685b6cc3a0da82998a2af48.
- 03:36 PM Revision a9a37695 (git): merge revision(s) 6375c68f8851e1e0fee8a95afba91c4555097127,c05eaa93258ddc01e685b6cc3a0da82998a2af48: [Backport #15839]
- parse.y: function parser_mixed_error & parser_mixed_escape
Fix mixed encoding in heredoc
Heredocs are parsed line-by-line, so we need to keep track of the
temporary encoding of the string. Previously, a heredoc... -
- ruby_2_5 r67762 merged revision(s) 5bab1304af25a843728dbcd2f3594913740aecb0.
- 03:13 PM Revision 7cdacb99 (git): merge revision(s) 5bab1304af25a843728dbcd2f3594913740aecb0: [Backport #15847]
- fix visibility of SecureRandom.gen_random
Aliasing a method preserves its visibility. These aliases turn
formerly-public methods into private. Should make them public
again. [Bug #15847]
git-svn-id: svn+ssh:/... - 03:11 PM Revision d5b23732 (git): * 2019-08-27 [ci skip]
-
- ruby_2_5 r67761 merged revision(s) ea42423908ed055f9039b1dce6e9a232a3b2dd90.
-
- Fixes Ruby Bug 13264
-
- This code did not have the desired effect. I'm not sure if
irb_binding is supposed to be private or not. If not, the private
call can just be removed. - 03:10 PM Revision 6e5e5df1 (git): merge revision(s) ea42423908ed055f9039b1dce6e9a232a3b2dd90: [Backport #15887]
- Keep vm->orig_progname alive
`vm->orig_progname` can be different from `vm->progname` when user
code assigns to `$0`. While `vm->progname` is kept alive by the
global table, nothing marked `vm->orig_progname`.
... -
- ruby_2_5 r67759 merged revision(s) ac00bdc8a8ac2c62a94dd36a7784d15bbcb7df19.
- 03:02 PM Revision 522bc8ad (git): * 2019-08-27
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@67760 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:02 PM Revision 2576b8b2 (git): merge revision(s) ac00bdc8a8ac2c62a94dd36a7784d15bbcb7df19: [Backport #15821]
- Do not modify shared array
[Bug #15821]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@67759 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:54 PM Bug #12356 (Rejected): Vector covector incorrect multiplication with another vector.
- Thanks Jeremy for updating this issue. I double checked and never received the original email notification...
> `Vector` does not have distinction between row and column, there's no column vector notion in the language.
Actually, i... -
- ruby_2_5 r67758 merged revision(s) d0ba4abf1a00339ebbb5d405db3240a8bdb7b68b,54eac83b2ad77ddea84fa6d66c09e0bb014cf61e.
- 02:54 PM Revision 401da791 (git): merge revision(s) d0ba4abf1a00339ebbb5d405db3240a8bdb7b68b,54eac83b2ad77ddea84fa6d66c09e0bb014cf61e: [Backport #15786]
- Add RB_ID_SERIAL_MAX
Hide internal IDs
* parse.y (internal_id): number the ID serial for internal use by
counting down from the neary maximum value, not to accidentally
match permanent IDs.
... -
- ruby_2_5 r67757 merged revision(s) a6a26e42b15c46f117f4fce07a2050e9d727355d.
- 02:45 PM Revision 235e64c2 (git): merge revision(s) a6a26e42b15c46f117f4fce07a2050e9d727355d: [Backport #15906]
- compile.c: Partially revert r63870 which caused wrong optimization
[Bug #15906]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@67757 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_5 r67756 merged revision(s) b72623012d74abdb06210153ed48c9e2fa075bbd.
- 02:39 PM Revision 5586497b (git): merge revision(s) b72623012d74abdb06210153ed48c9e2fa075bbd: [Backport #15775]
- Update broken URL in Float documentation.
[Misc #15775][ruby-core:92332]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@67756 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_5 r67755 merged revision(s) a15f7dd1fb1148c3d586238ee6907875f2e40379.
- 02:37 PM Revision 920b6e15 (git): merge revision(s) a15f7dd1fb1148c3d586238ee6907875f2e40379: [Backport #15803]
- Always mark the string returned by File.realpath as tainted
This string can include elements that were not in either string
passed to File.realpath, even if one of the strings is an
absolute path, due to symlinks... -
- ruby_2_5 r67754 merged revision(s) d118c84b0b9110462e479487ffaf175a75e5718e.
- 02:18 PM Revision 662a3ca8 (git): merge revision(s) d118c84b0b9110462e479487ffaf175a75e5718e: [Backport #15199]
- Fix IO#scanf on pipes on Windows
IO.seek on a pipe on Windows raises Errno::EINVAL instead of
Errno::ESPIPE.
Fixes Ruby Bug #15199
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@67754 b2dd03c8-39... -
- ruby_2_5 r67753 merged revision(s) 5e23b1138f16af0defb184d7deeffadfd2ce3c04.
- 02:15 PM Revision d65f9463 (git): merge revision(s) 5e23b1138f16af0defb184d7deeffadfd2ce3c04 [backport #15820]
- Fix potential memory leak
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@67753 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_5 r67752 merged revision(s) 179045acaf5de8398c321ada86a76f1afb77a796.
- 02:06 PM Revision 59ed372b (git): merge revision(s) 179045acaf5de8398c321ada86a76f1afb77a796: [Backport #14539]
- regparse.c: Suppress duplicated range warning by mere \X
* regparse.c (node_extended_grapheme_cluster): as Unicode 10 has
added Grapheme_Cluster_Break properties to some characters,
remove duplicated ranges f... -
- already fixed on ruby_2_5 at r64428.
-
- ruby_2_5 r67751 merged revision(s) af1e487e9bb763b939dc6704c9a343c9eafa1637.
- 01:49 PM Revision ed7b68a2 (git): merge revision(s) af1e487e9bb763b939dc6704c9a343c9eafa1637: [Backport #15801]
- Updated marked commits for ChangeLog
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@67751 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- This was fixed by the Pull Request above.
- 12:09 PM Revision ccc5b22a (git): Expand JOBS instead of meaningless export (#2402)
- * Expand JOBS instead of meaningless export
* Remove -j option in TESTOPTS of test-bundled-gems
https://github.com/ruby/ruby/runs/203129516#step:10:167
> invalid option: -j3 -
- Comparing indents is easy in very simple cases, but it will harder in complex cases, for instance, after a multiple line expression.
And I suspect this can be found by editors auto-indent. -
- the problem is that the case body can be empty, that doesn't mean the code is wrong.
and like sawa said, it probably needs to check all other braches too, which i don't know is possible there -
- In fact, even indentation level in this particular code does not seem to tell that it was a mistake. The `print_foobar` line is aligned with the other conditions. I would take it that they all belong to the condition.
However, you can... -
- shevegen (Robert A. Heiler) wrote:
> Perhaps the above can still be reported based on additional information,
> ...
There is no way to distinguish these cases syntactically.
Only what I think of is the indent level, too.
-
- Since the previous release date, when the starting message is not
found. -
-
-
- Rules which have used CPPFLAGS will need XCFLAGS or INCFLAGS now.
-
- INCFLAGS is not included in CPPFLAGS on mswin, not to be exported
to rbconfig.rb. -
-
- jeremyevans0 (Jeremy Evans) wrote:
> nobu (Nobuyoshi Nakada) wrote:
> ...
Another point is that compile warnings are for the names.
Use of aliases of them like English.rb will be still silent.
So, [this question](https://bugs.ruby-... -
- nobu (Nobuyoshi Nakada) wrote:
> jeremyevans0 (Jeremy Evans) wrote:
> ...
Agreed. I'm fine dropping these compile warnings if the run-time warnings are considered sufficient.
> > One problem with the implementation in my previous p... -
- This makes it possible for `initialize_clone` to correctly not freeze internal state if the `freeze: false` keyword is passed to `clone`.
If `clone` is called with `freeze: true` or no keyword, do not pass a second argument to `initia... -
- Flags for ruby core such as warning and `_FORTIFY_SOURCE` macro
are not necessary to make fake.rb, except for `RUBY_EXPORT` macro
which prevents to include ruby/backward.h. -
-
- Often uid / gid are 16 bit or 32 bit integers, while VALUE are 32
to 64 bits. They tend to differ in size. Because rb_ensure expects
its callbacks to take VALUE arguments, narrowing must be done by
hand, otherwise data corruption can h... -
- This is an auto-generated header file that does not include anything
interesting. Should skip generating CAPI documents. -
- already backported into ruby_2_5 at r67717
-
- 02:08 AM Revision 4448d586 (git): * 2019-08-26 [ci skip]
-
- Allows CC to be prefixed another path or command, e.g., ccache.
-
- I added a pull request to fix the first issue: https://github.com/flori/json/pull/384
There is an existing pull request to fix the second issue: https://github.com/flori/json/pull/347
08/25/2019
-
- Commited in commit:dd3851d2786412de019350a11e749c56fa5a07cc.
-
-
-
-
- I don't think this is a bug. Most pure Ruby code assumes and does not check that method arguments respond to all methods that the code expects them to respond to. It's generally considered a smell to take code like:
```ruby
def foo(... -
-
-
- Does this rounding error still occur on Fedora i686?
-
-
- Applied in changeset commit:git|e496e96547b64c3a2fa6f285c3bc9bd21a245ac6.
----------
Document that Enumerable#sum may not respect redefinition of Range#each
It already documented that it may not respect redefinition
of Integer#+.
Fixe... -
- This fixes the following in my environment:
misc/expand_tabs.rb:29:in `=~': invalid byte sequence in US-ASCII (ArgumentError)
This switches from =~ to start_with? as a regular expression is
not actually needed here. -
- It already documented that it may not respect redefinition
of Integer#+.
Fixes [Bug #13700] -
- This bug still occurs in the master branch. Attached is a patch that fixes it by checking for interrupts before calling the thread's proc.
-
- If we want to fix `IO#ungetc`, attached is a patch that will fix it.
-
-
-
-
- This doesn't appear to be a bug, even if the behavior is slightly inconsistent between URI::HTTP and URI::FTP. If you can show an actual problem caused by the inconsistency, please reply.
-
- Applied in changeset commit:git|71d97a5ef80a23b0bb1005570ed059580981a467.
----------
Fix sample/drb/http0serv.rb
Previously, trying to use this would result in:
undefined method `uri' for #<DRb::HTTP0::ServerSide:0x00000aec9f1637f8> (... -
- Previously, trying to use this would result in:
undefined method `uri' for #<DRb::HTTP0::ServerSide:0x00000aec9f1637f8> (NoMethodError)
Also, use a relative require to load sample/drb/http0.rb.
Fixes [Bug #13431] -
- I've submitted a pull request to allow `-Float::Infinity...Date.today`: https://github.com/ruby/date/pull/13
-
- I was not sure whether the following behaviour is a bug or not, so I filed this under "feature", mostly because
this may change existing behaviour; and even if I think the current behaviour in this context may not make a
lot of sense, ... -
- icc_version was wrongly defined as "__ICC" on non-icc C compiler, which
caused a warning:
```
./configure: line 8211: test: __ICC: integer expression expected
```
This change adds a sed commend to delete "__ICC". -
- The icc_version guessing was accidentally disabled because of
61885c9b7ca8ccdaf53d7c365fbb86bad3294d88; `AC_PROG_CC_C99` changes
CC like "icc -std=c99", and `AS_CASE(["x$CC"], [xicc],` does not match.
The variable `icc_version` is event... -
11:44 AM Misc #16125: Remove the reserved member from rb_data_type_t as the addition of the compactor callback pushed it over a single cache line
- nobu (Nobuyoshi Nakada) wrote:
> methodmissing (Lourens Naudé) wrote:
> ...
Thanks for the clarification Nobu - I was thrown off by the `pahole` report which did not recognize the consumed element. Would it still make sense to formally... -
- The format is a little weird, and not so helpful either.
-
- `require "webrick/utils.rb"` should load `lib/webrick/utils.rb`, but on
some CI machines, it wrongly loads `test/webrick/utils.rb`, which caused
circular require warning:
https://rubyci.org/logs/rubyci.s3.amazonaws.com/ubuntu/ruby-maste... -
-
-
- The delegate library does not currently handle BasicObject targets, since it assumes the target responds to `respond_to?`. The attached patch works around the issue by binding the Kernel `respond_to?` instance method to the target and t...
-
- This is still a bug in the master branch of irb. I've submitted a pull request to fix it by using a delegate: https://github.com/ruby/irb/pull/24
-
-
-
-
-
- The warning discussed has not been added yet. Attached is a patch that implements it. While it passes `make check`, there may be corner cases it doesn't handle. I would appreciate review of the changes to `vm_cref_set_visibility`.
...
08/24/2019
-
- methodmissing (Lourens Naudé) wrote:
> I'm wondering what the `reserved` member was originally intended for, given introducing the `dcompact` member basically already broke binary compatibility by changing the struct size from `64` -> `... -
- References PR https://github.com/ruby/ruby/pull/2396
I noticed that since the introduction of the `GC.compact` API, struct `rb_data_type_t` spans multiple cache lines with the introduction of the `dcompact` function pointer / callback... -
- Applied in changeset commit:git|04735c48ab44c97cbfd5a5cd37f9a1696e2f5a2b.
----------
Minor documentation fixes [ci skip]
From zverok (Victor Shepelev)
Fixes [Misc #16126] -
- Thanks for the patch, I will merge it shortly.
-
- The patch with some small-ish fixes:
* Enumerator refers to `#enum_for`/`#to_enum` under `Kernel`, while in fact they are documented under `Object`;
* `Kernel#warn` has outdated call sequence;
* `ClosedQueueError` is not mentioned in ... -
- From zverok (Victor Shepelev)
Fixes [Misc #16126] -
- This gets RDoc to pick up the documentation correctly.
Problem pointed out by zverok (Victor Shepelev). - 03:51 PM Revision cf5516de (git): * 2019-08-25 [ci skip]
-
- https://rubyci.org/logs/rubyci.s3.amazonaws.com/gentoo/ruby-master/log/20190824T153002Z.fail.html.gz
```
/home/gentoo/chkbuild/tmp/build/20190824T153002Z/ruby/tool/lib/vcs.rb:577:in `export_changelog': cannot find the beginning revision ... -
-
- The global method cache note references PR https://github.com/ruby/ruby/pull/2302
-
- As per comment from Nobu in https://github.com/ruby/ruby/pull/2303#issuecomment-523248875 , I took an initial stab @ a tighter integration between objspace and the transient heap in https://github.com/ruby/ruby/pull/2400
### Benefits
... -
- Eregon (Benoit Daloze) wrote:
> This is at least inconsistent with Array#delete, which could be used for the same case as above but doesn't end with a `?`.
This is not exactly true, as `Set#delete?` returns self and not the item if d... -
- This is at least inconsistent with Array#delete, which could be used for the same case as above but doesn't end with a `?`.
I don't think there are many good examples for predicates with side effects, is it?
A good part of the Set AP... -
- I don't think this is a bug, I believe it is intentional. Using `?` for mutating methods is uncommon, but not wrong. You can use these like predicate methods, which is probably why they end in `?`:
```ruby
if set.delete?(object)
... -
- https://rubyci.org/logs/rubyci.s3.amazonaws.com/debian8/ruby-master/log/20190824T093005Z.fail.html.gz
```
branches:
* trunk
remotes/origin/trunk
```
and
```
fatal: Remote branch master not found in upstream origin
``` -
-
- ```
compiling ../.././ext/psych/yaml/api.c
../.././ext/psych/yaml/api.c: In function 'yaml_document_delete':
../.././ext/psych/yaml/api.c:1122:7: warning: variable 'context' set but not used [-Wunused-but-set-variable]
} context;
... -
- > If `#curry` gets support for keyword arguments, would it suffice for this case
I don't think so, unfortunately.
1. Of my examples, it covers only `JSON.parse`
* It doesn't cover non-keyword arguments, which, I believe, it sho... -
- > What would a simple implementation of `Struct::Value.new` look like in Ruby code?
Oh, I've probably answered the wrong question... But I am not quite sure I understand yours.
Theoretically, it is just something like this (ignorin... -
- @Eregon, here is rendered version of class' docs: https://zverok.github.io/ruby-rdoc/Struct-Value.html
Basically, it is what is said on the tin: like Struct, just leaner. -
- This sounds interesting to me.
What would a simple implementation of Struct::Value.new look like in Ruby code?
I'm not quite sure what the available API is since it's all described as Struct - some methods. -
- matser branch not found on some CIs
https://rubyci.org/logs/rubyci.s3.amazonaws.com/debian9/ruby-master/log/20190824T063005Z.fail.html.gz
```
fatal: Remote branch master not found in upstream origin
``` -
-
05:10 AM Feature #12093: Eval InstructionSequence with binding
- > does this suffice your use case?
Interesting, I'll need to investigate this - it certainly has potential.
My use case is for experimental tracing work, and I basically want to be
able to pre-compile original source with added in... -
- This is a bug in your code, you are not calling `DRb.start_service` in the client program. The client program needs a DRb server running in order to handle the sending-block-to-remote-method case. See the example in the "Client code" s...
-
-
-
-
-
- Hi,
> So I strongly believe all these feature requests should to be considered together in order to make a decision.
Agreed. And, #15723 (a numbered parameter) is only one proposal that is all-purpose, though I don't like it so mu... -
- I think there's a misunderstanding because this proposal doesn't collide with existing parser behavior. `[].each{ .method }` is currently a SyntaxError.
@osyo wrote:
> However, I think it is difficult to parse in the following cases.... -
- https://rubyci.org/logs/rubyci.s3.amazonaws.com/debian9/ruby-master/log/20190823T213004Z.fail.html.gz
https://rubyci.org/logs/rubyci.s3.amazonaws.com/debian8/ruby-master/log/20190824T003006Z.fail.html.gz -
12:30 AM Feature #16123: Allow calling a private method with `self.`
- Here is a script to help demonstrate the inconsistency, where `self.bar = 123` is allowed by `self.bar` is not.
```ruby
class Foo
def foo
self.bar = 123 # allowed
self.bar # raises
end
private
attr_accessor ...
08/23/2019
-
- I like Hanmac's idea.
``` ruby
Klass.:meth.curry.()
```
Seems very close to:
``` ruby
Klass.:meth.w()
```
I know it has previously been said that `#curry` is a bit of an easter egg. Would it be acceptable to add keyword... -
- A bit of an aside, but it's often just as fast to do two iterations with small collections, since the shorthand parses faster.
posts.map(&:author).map(&:name)
I agree with osyo that it seems this proposal collides with existing... -
- hi.
Its soo good idea.
However, I think it is difficult to parse in the following cases.
```ruby
[10, 20, 30].map{
# 42.to_s(16)
# or
# pp 42
# argument1.to_s(16)
pp 42
.to_s(16)
}
```
-
- How about considering this syntax for implicit block parameter:
```
[10, 20, 30].map{ .to_s(16) } #=> ["a", "14", "1e"]
```
Infinite thanks to @maedi for [the idea](https://bugs.ruby-lang.org/issues/15723#note-19)
This proposal i... -
- I may not completely understand the issue description. What is the inconsistency? (That is a honest
question, by the way; I am not fully understanding the issue domain.)
I am not even entirely sure what a private attribute writer is ... -
- ## Problem
There is an inconsistency between calling a private attribute writer being allowed with `self.value =` syntax and `self.value` not being allowed on a private attribute writer.
Calling a private method in this way can be ... -
10:41 PM Feature #15815: Add option to raise NoMethodError for OpenStruct
- Personally I found the proposed signature confusing, more when taking in account that OpenStruct calls:
```ruby
os = OpenStruct.new(a: 1, exception: true)
# vs
os = OpenStruct.new({a: 1}, exception: true)
```
> I'd like t... -
- I don't think this is a bug, but I'll let marcandre make the determination. `Vector` can't be multipled with `Vector`, you get an error. You can multiple a `Vector` by a `Matrix` and vice-versa by design, and `Vector#covector` returns ...
-
-
- This is still a bug in master. I have filed a pull request upstream to fix it: https://github.com/ruby/fileutils/pull/39.
-
-
-
-
-
- I split up the patch into the 4 attached patches, because I realized there were a few changes that could be emphasized independently, each with their own description of the change. Hopefully that will make the optimization itself in the...
-
- ## Problem
I noticed while profiling object allocations that Hash#dup was allocating 2 objects instead of only 1 as expected. I looked for alternatives for comparison and found that `Hash[hash]` created a copy with only a single obje... -
- * [Feature #16113] Partial application: `fetch(urls).map(&JSON.:parse.w(symbolize_names: true))`
* [Feature #16122] `Struct::Value`: simple immutable value object -
- * [Feature #15991] Allow questionmarks in variable names
* Proposal: Allow `?` in variable names
* In #5781, matz is explicitly against an instance variable that ends with `?`
* How about allowing only local variables ?
-
- * [Feature #15955] UnboundMethod#apply
* The ticket proposes a shortcut to `unbound_method.bind(obj).call(args...)` without allocation of a Method object. There are some use cases, and looks reasonable to me. What do you think? -
- * [Feature #16115] Keyword arguments from method calls or ignore extra hash keys in splat
* It proposes a triple splat (`foo(***opt)`) to pass a keyword hash with filtering out unknown keywords. What do you think? -
- ## Intro (original theoretical part of the proposal)
**Value Object** is a useful concept, introduced by Martin Fowler ([his post](https://martinfowler.com/bliki/ValueObject.html), [Wikipedia Entry](https://en.wikipedia.org/wiki/Value... - 04:41 PM Revision b38ab0a3 (git): * 2019-08-24 [ci skip]
-
-
- Hanmac (Hans Mackowiak) wrote:
> i see in your patch that you not only check for `Array` but for `to_ary` too, which is nice
Right, but that is just preserving the current behaviour. So the `ary.flatten! if ary.any?(Array)` workarou... -
- duerst (Martin Dürst) wrote:
> However, I expect this to be slower on arrays that are 'almost flat', i.e.
> ...
The optimization handles this case by doing a quick `ary_memcpy` of everything up to the first nested array to avoid redund... -
- i see in your patch that you not only check for `Array` but for `to_ary` too, which is nice
@shevegen :
instead of `[input]` i would use `Array(input)` that doesn't create an extra array if input is already one -
- I use .flatten and .flatten! quite a lot in my ruby code, often setting the
initial input from ARGV but also from other sources, such as used from other
ruby classes, w hen I need to have an array - often something like:
def foo... -
- I was afraid that this would be an optimization for flat arrays, but increase time for nested arrays. But that's not the case, because at the bottom, there will be flat arrays, and flattening these will be faster.
However, I expect th... -
- I'm negative to add `ID_NUMPARAM`.
As `rb_is_numparam_id` is not used, and `rb_is_numparam_name` can be implemented without `rb_symname_type`. -
- Here is an experimental patch.
-
- https://github.com/ruby/stringio/commit/b249631c433f800c979be2705bf63555075db2fc#commitcomment-34804150
https://github.com/ruby/stringio/commit/998d6257fb -
09:05 AM Revision d9b73dcc (git): Remove github_action_linux tag from bundler examples.
- Maybe it has fixed at 5a384e2c08704dc7af9d8d3bdfc475eb8c0723aa
-
08:20 AM Revision 3b55394b (git): Ensure all default gems have an gem folder
- Even if they don't ship with any executables. This makes rbinstall
behaviour consistent with rubygems `gem install --default` command. -
07:54 AM Bug #16117: ruby2.6.3(x86) use fiddle faild to load dll in windows7
- Problem solved:
the dll i used compiled by MinGW, the dll need libstdc++-6.dll, after I add **-static-libgcc -static-libstdc++** compile flag to the dll, problem solved! -
-
-
- Here is a benchmark:
```
class Foo
def foo
end
end
meth = Foo.instance_method(:foo)
obj = Foo.new
10000000.times { meth.bind(obj).call } # 1.84 sec
10000000.times { meth.apply(obj) } # 1.04 sec
``` -
- Hi @nelhage and @darkdimius :-)
I'm attaching a patch for `UnboundMethod#apply(obj, *args, &blk)` as a shortcut to `.bind(obj).call(*args, &blk)` without allocation of a Method object.
I have heard the same situation as Sorbet for ... -
-
- If `fill_random_bytes_syscall` were to leak memory, then this Ruby code should show the leak:
```ruby
i = 0; while true; puts i if (i+=1) % 10000000; SecureRandom.bytes(1) end
```
As this shows no leak even with with 600000000 it... -
- Thank you for proposing ideas. They are interesting to me.
As you said in your second example, it is only possible in callee side: changing the method definition to accept a dummy `**` argument.
```
def hello(who:, **)
end
he... -
- I don't think this is a bug. As 0x0dea (D.E. Akers) pointed out, other programs work the same way. However, I think cookie handling in open_uri could be a useful feature. Attached is a patch that implements the necessary support.
I... - 12:46 AM Revision 9ffb0548 (git): * 2019-08-23 [ci skip]
-