Activity
From 08/19/2019 to 08/25/2019
08/25/2019
-
08:47 PM Bug #14121 (Closed): test-all - rename duplicate classes for consistent test count
- Commited in commit:dd3851d2786412de019350a11e749c56fa5a07cc.
-
-
-
-
- I don't think this is a bug. Most pure Ruby code assumes and does not check that method arguments respond to all methods that the code expects them to respond to. It's generally considered a smell to take code like:
```ruby
def foo(... -
-
-
- Does this rounding error still occur on Fedora i686?
-
-
08:02 PM Bug #13700 (Closed): Enumerable#sum may not work for Ranges subclasses due to optimization
- Applied in changeset commit:git|e496e96547b64c3a2fa6f285c3bc9bd21a245ac6.
----------
Document that Enumerable#sum may not respect redefinition of Range#each
It already documented that it may not respect redefinition
of Integer#+.
Fixe... -
- This fixes the following in my environment:
misc/expand_tabs.rb:29:in `=~': invalid byte sequence in US-ASCII (ArgumentError)
This switches from =~ to start_with? as a regular expression is
not actually needed here. -
- It already documented that it may not respect redefinition
of Integer#+.
Fixes [Bug #13700] -
- This bug still occurs in the master branch. Attached is a patch that fixes it by checking for interrupts before calling the thread's proc.
-
- If we want to fix `IO#ungetc`, attached is a patch that will fix it.
-
-
-
-
- This doesn't appear to be a bug, even if the behavior is slightly inconsistent between URI::HTTP and URI::FTP. If you can show an actual problem caused by the inconsistency, please reply.
-
- Applied in changeset commit:git|71d97a5ef80a23b0bb1005570ed059580981a467.
----------
Fix sample/drb/http0serv.rb
Previously, trying to use this would result in:
undefined method `uri' for #<DRb::HTTP0::ServerSide:0x00000aec9f1637f8> (... -
- Previously, trying to use this would result in:
undefined method `uri' for #<DRb::HTTP0::ServerSide:0x00000aec9f1637f8> (NoMethodError)
Also, use a relative require to load sample/drb/http0.rb.
Fixes [Bug #13431] -
- I've submitted a pull request to allow `-Float::Infinity...Date.today`: https://github.com/ruby/date/pull/13
-
03:52 PM Feature #16128 (Open): Would it be possible for ruby to warn about case/when menu options separated by a trailing, but accidental ','?
- I was not sure whether the following behaviour is a bug or not, so I filed this under "feature", mostly because
this may change existing behaviour; and even if I think the current behaviour in this context may not make a
lot of sense, ... -
02:08 PM Revision 365e5b38 (git): configure.ac: Improve icc_version guessing for non-icc environment
- icc_version was wrongly defined as "__ICC" on non-icc C compiler, which
caused a warning:
```
./configure: line 8211: test: __ICC: integer expression expected
```
This change adds a sed commend to delete "__ICC". -
- The icc_version guessing was accidentally disabled because of
61885c9b7ca8ccdaf53d7c365fbb86bad3294d88; `AC_PROG_CC_C99` changes
CC like "icc -std=c99", and `AS_CASE(["x$CC"], [xicc],` does not match.
The variable `icc_version` is event... -
11:44 AM Misc #16125: Remove the reserved member from rb_data_type_t as the addition of the compactor callback pushed it over a single cache line
- nobu (Nobuyoshi Nakada) wrote:
> methodmissing (Lourens Naudé) wrote:
> ...
Thanks for the clarification Nobu - I was thrown off by the `pahole` report which did not recognize the consumed element. Would it still make sense to formally... -
11:10 AM Revision fa5f7771 (git): Drop duration from AppVeyor notification
- The format is a little weird, and not so helpful either.
-
- `require "webrick/utils.rb"` should load `lib/webrick/utils.rb`, but on
some CI machines, it wrongly loads `test/webrick/utils.rb`, which caused
circular require warning:
https://rubyci.org/logs/rubyci.s3.amazonaws.com/ubuntu/ruby-maste... -
09:27 AM Revision c775ab5e (git): `local_path?` is a class method [ci skip]
-
-
- The delegate library does not currently handle BasicObject targets, since it assumes the target responds to `respond_to?`. The attached patch works around the issue by binding the Kernel `respond_to?` instance method to the target and t...
-
- This is still a bug in the master branch of irb. I've submitted a pull request to fix it by using a delegate: https://github.com/ruby/irb/pull/24
-
04:58 AM Revision 1b03d2d7 (git): Revert workaround
-
-
-
-
- The warning discussed has not been added yet. Attached is a patch that implements it. While it passes `make check`, there may be corner cases it doesn't handle. I would appreciate review of the changes to `vm_cref_set_visibility`.
...
08/24/2019
-
- methodmissing (Lourens Naudé) wrote:
> I'm wondering what the `reserved` member was originally intended for, given introducing the `dcompact` member basically already broke binary compatibility by changing the struct size from `64` -> `... -
- References PR https://github.com/ruby/ruby/pull/2396
I noticed that since the introduction of the `GC.compact` API, struct `rb_data_type_t` spans multiple cache lines with the introduction of the `dcompact` function pointer / callback... -
- Applied in changeset commit:git|04735c48ab44c97cbfd5a5cd37f9a1696e2f5a2b.
----------
Minor documentation fixes [ci skip]
From zverok (Victor Shepelev)
Fixes [Misc #16126] -
- Thanks for the patch, I will merge it shortly.
-
05:35 PM Misc #16126 (Closed): Fix small docs inconsistencies
- The patch with some small-ish fixes:
* Enumerator refers to `#enum_for`/`#to_enum` under `Kernel`, while in fact they are documented under `Object`;
* `Kernel#warn` has outdated call sequence;
* `ClosedQueueError` is not mentioned in ... -
- From zverok (Victor Shepelev)
Fixes [Misc #16126] -
- This gets RDoc to pick up the documentation correctly.
Problem pointed out by zverok (Victor Shepelev). - 03:51 PM Revision cf5516de (git): * 2019-08-25 [ci skip]
-
- https://rubyci.org/logs/rubyci.s3.amazonaws.com/gentoo/ruby-master/log/20190824T153002Z.fail.html.gz
```
/home/gentoo/chkbuild/tmp/build/20190824T153002Z/ruby/tool/lib/vcs.rb:577:in `export_changelog': cannot find the beginning revision ... -
-
- The global method cache note references PR https://github.com/ruby/ruby/pull/2302
-
- As per comment from Nobu in https://github.com/ruby/ruby/pull/2303#issuecomment-523248875 , I took an initial stab @ a tighter integration between objspace and the transient heap in https://github.com/ruby/ruby/pull/2400
### Benefits
... -
- Eregon (Benoit Daloze) wrote:
> This is at least inconsistent with Array#delete, which could be used for the same case as above but doesn't end with a `?`.
This is not exactly true, as `Set#delete?` returns self and not the item if d... -
06:45 AM Bug #13102: Confusing method name: Set#delete?
- This is at least inconsistent with Array#delete, which could be used for the same case as above but doesn't end with a `?`.
I don't think there are many good examples for predicates with side effects, is it?
A good part of the Set AP... -
- I don't think this is a bug, I believe it is intentional. Using `?` for mutating methods is uncommon, but not wrong. You can use these like predicate methods, which is probably why they end in `?`:
```ruby
if set.delete?(object)
... -
- https://rubyci.org/logs/rubyci.s3.amazonaws.com/debian8/ruby-master/log/20190824T093005Z.fail.html.gz
```
branches:
* trunk
remotes/origin/trunk
```
and
```
fatal: Remote branch master not found in upstream origin
``` -
-
- ```
compiling ../.././ext/psych/yaml/api.c
../.././ext/psych/yaml/api.c: In function 'yaml_document_delete':
../.././ext/psych/yaml/api.c:1122:7: warning: variable 'context' set but not used [-Wunused-but-set-variable]
} context;
... -
- > If `#curry` gets support for keyword arguments, would it suffice for this case
I don't think so, unfortunately.
1. Of my examples, it covers only `JSON.parse`
* It doesn't cover non-keyword arguments, which, I believe, it sho... -
- > What would a simple implementation of `Struct::Value.new` look like in Ruby code?
Oh, I've probably answered the wrong question... But I am not quite sure I understand yours.
Theoretically, it is just something like this (ignorin... -
- @Eregon, here is rendered version of class' docs: https://zverok.github.io/ruby-rdoc/Struct-Value.html
Basically, it is what is said on the tin: like Struct, just leaner. -
- This sounds interesting to me.
What would a simple implementation of Struct::Value.new look like in Ruby code?
I'm not quite sure what the available API is since it's all described as Struct - some methods. -
- matser branch not found on some CIs
https://rubyci.org/logs/rubyci.s3.amazonaws.com/debian9/ruby-master/log/20190824T063005Z.fail.html.gz
```
fatal: Remote branch master not found in upstream origin
``` -
-
05:10 AM Feature #12093: Eval InstructionSequence with binding
- > does this suffice your use case?
Interesting, I'll need to investigate this - it certainly has potential.
My use case is for experimental tracing work, and I basically want to be
able to pre-compile original source with added in... -
- This is a bug in your code, you are not calling `DRb.start_service` in the client program. The client program needs a DRb server running in order to handle the sending-block-to-remote-method case. See the example in the "Client code" s...
-
-
-
-
-
- Hi,
> So I strongly believe all these feature requests should to be considered together in order to make a decision.
Agreed. And, #15723 (a numbered parameter) is only one proposal that is all-purpose, though I don't like it so mu... -
12:59 AM Feature #16120: Omitted block argument if block starts with dot-method call
- I think there's a misunderstanding because this proposal doesn't collide with existing parser behavior. `[].each{ .method }` is currently a SyntaxError.
@osyo wrote:
> However, I think it is difficult to parse in the following cases.... -
- https://rubyci.org/logs/rubyci.s3.amazonaws.com/debian9/ruby-master/log/20190823T213004Z.fail.html.gz
https://rubyci.org/logs/rubyci.s3.amazonaws.com/debian8/ruby-master/log/20190824T003006Z.fail.html.gz -
12:30 AM Feature #16123: Allow calling a private method with `self.`
- Here is a script to help demonstrate the inconsistency, where `self.bar = 123` is allowed by `self.bar` is not.
```ruby
class Foo
def foo
self.bar = 123 # allowed
self.bar # raises
end
private
attr_accessor ...
08/23/2019
-
11:51 PM Feature #16113: Partial application
- I like Hanmac's idea.
``` ruby
Klass.:meth.curry.()
```
Seems very close to:
``` ruby
Klass.:meth.w()
```
I know it has previously been said that `#curry` is a bit of an easter egg. Would it be acceptable to add keyword... -
- A bit of an aside, but it's often just as fast to do two iterations with small collections, since the shorthand parses faster.
posts.map(&:author).map(&:name)
I agree with osyo that it seems this proposal collides with existing... -
03:36 PM Feature #16120: Omitted block argument if block starts with dot-method call
- hi.
Its soo good idea.
However, I think it is difficult to parse in the following cases.
```ruby
[10, 20, 30].map{
# 42.to_s(16)
# or
# pp 42
# argument1.to_s(16)
pp 42
.to_s(16)
}
```
-
- How about considering this syntax for implicit block parameter:
```
[10, 20, 30].map{ .to_s(16) } #=> ["a", "14", "1e"]
```
Infinite thanks to @maedi for [the idea](https://bugs.ruby-lang.org/issues/15723#note-19)
This proposal i... -
- I may not completely understand the issue description. What is the inconsistency? (That is a honest
question, by the way; I am not fully understanding the issue domain.)
I am not even entirely sure what a private attribute writer is ... -
- ## Problem
There is an inconsistency between calling a private attribute writer being allowed with `self.value =` syntax and `self.value` not being allowed on a private attribute writer.
Calling a private method in this way can be ... -
10:41 PM Feature #15815: Add option to raise NoMethodError for OpenStruct
- Personally I found the proposed signature confusing, more when taking in account that OpenStruct calls:
```ruby
os = OpenStruct.new(a: 1, exception: true)
# vs
os = OpenStruct.new({a: 1}, exception: true)
```
> I'd like t... -
- I don't think this is a bug, but I'll let marcandre make the determination. `Vector` can't be multipled with `Vector`, you get an error. You can multiple a `Vector` by a `Matrix` and vice-versa by design, and `Vector#covector` returns ...
-
-
- This is still a bug in master. I have filed a pull request upstream to fix it: https://github.com/ruby/fileutils/pull/39.
-
-
-
-
-
- I split up the patch into the 4 attached patches, because I realized there were a few changes that could be emphasized independently, each with their own description of the change. Hopefully that will make the optimization itself in the...
-
- ## Problem
I noticed while profiling object allocations that Hash#dup was allocating 2 objects instead of only 1 as expected. I looked for alternatives for comparison and found that `Hash[hash]` created a copy with only a single obje... -
- * [Feature #16113] Partial application: `fetch(urls).map(&JSON.:parse.w(symbolize_names: true))`
* [Feature #16122] `Struct::Value`: simple immutable value object -
- * [Feature #15991] Allow questionmarks in variable names
* Proposal: Allow `?` in variable names
* In #5781, matz is explicitly against an instance variable that ends with `?`
* How about allowing only local variables ?
-
- * [Feature #15955] UnboundMethod#apply
* The ticket proposes a shortcut to `unbound_method.bind(obj).call(args...)` without allocation of a Method object. There are some use cases, and looks reasonable to me. What do you think? -
- * [Feature #16115] Keyword arguments from method calls or ignore extra hash keys in splat
* It proposes a triple splat (`foo(***opt)`) to pass a keyword hash with filtering out unknown keywords. What do you think? -
- ## Intro (original theoretical part of the proposal)
**Value Object** is a useful concept, introduced by Martin Fowler ([his post](https://martinfowler.com/bliki/ValueObject.html), [Wikipedia Entry](https://en.wikipedia.org/wiki/Value... - 04:41 PM Revision b38ab0a3 (git): * 2019-08-24 [ci skip]
-
-
- Hanmac (Hans Mackowiak) wrote:
> i see in your patch that you not only check for `Array` but for `to_ary` too, which is nice
Right, but that is just preserving the current behaviour. So the `ary.flatten! if ary.any?(Array)` workarou... -
- duerst (Martin Dürst) wrote:
> However, I expect this to be slower on arrays that are 'almost flat', i.e.
> ...
The optimization handles this case by doing a quick `ary_memcpy` of everything up to the first nested array to avoid redund... -
07:41 AM Feature #16119: Optimize Array#flatten and flatten! for already flattened arrays
- i see in your patch that you not only check for `Array` but for `to_ary` too, which is nice
@shevegen :
instead of `[input]` i would use `Array(input)` that doesn't create an extra array if input is already one -
- I use .flatten and .flatten! quite a lot in my ruby code, often setting the
initial input from ARGV but also from other sources, such as used from other
ruby classes, w hen I need to have an array - often something like:
def foo... -
02:02 AM Feature #16119: Optimize Array#flatten and flatten! for already flattened arrays
- I was afraid that this would be an optimization for flat arrays, but increase time for nested arrays. But that's not the case, because at the bottom, there will be flat arrays, and flattening these will be faster.
However, I expect th... -
- I'm negative to add `ID_NUMPARAM`.
As `rb_is_numparam_id` is not used, and `rb_is_numparam_name` can be implemented without `rb_symname_type`. -
- Here is an experimental patch.
-
- https://github.com/ruby/stringio/commit/b249631c433f800c979be2705bf63555075db2fc#commitcomment-34804150
https://github.com/ruby/stringio/commit/998d6257fb -
09:05 AM Revision d9b73dcc (git): Remove github_action_linux tag from bundler examples.
- Maybe it has fixed at 5a384e2c08704dc7af9d8d3bdfc475eb8c0723aa
-
08:20 AM Revision 3b55394b (git): Ensure all default gems have an gem folder
- Even if they don't ship with any executables. This makes rbinstall
behaviour consistent with rubygems `gem install --default` command. -
07:54 AM Bug #16117: ruby2.6.3(x86) use fiddle faild to load dll in windows7
- Problem solved:
the dll i used compiled by MinGW, the dll need libstdc++-6.dll, after I add **-static-libgcc -static-libstdc++** compile flag to the dll, problem solved! -
-
-
- Here is a benchmark:
```
class Foo
def foo
end
end
meth = Foo.instance_method(:foo)
obj = Foo.new
10000000.times { meth.bind(obj).call } # 1.84 sec
10000000.times { meth.apply(obj) } # 1.04 sec
``` -
- Hi @nelhage and @darkdimius :-)
I'm attaching a patch for `UnboundMethod#apply(obj, *args, &blk)` as a shortcut to `.bind(obj).call(*args, &blk)` without allocation of a Method object.
I have heard the same situation as Sorbet for ... -
-
- If `fill_random_bytes_syscall` were to leak memory, then this Ruby code should show the leak:
```ruby
i = 0; while true; puts i if (i+=1) % 10000000; SecureRandom.bytes(1) end
```
As this shows no leak even with with 600000000 it... -
- Thank you for proposing ideas. They are interesting to me.
As you said in your second example, it is only possible in callee side: changing the method definition to accept a dummy `**` argument.
```
def hello(who:, **)
end
he... -
- I don't think this is a bug. As 0x0dea (D.E. Akers) pointed out, other programs work the same way. However, I think cookie handling in open_uri could be a useful feature. Attached is a patch that implements the necessary support.
I... - 12:46 AM Revision 9ffb0548 (git): * 2019-08-23 [ci skip]
-
08/22/2019
-
- ## Problem
When doing an object profile from stackprof, I noticed object allocations being made from `Array#flatten!` which was unlike other in-place methods like `Array#uniq!` and `Array#compact!`. In this case, I wanted to optimize... -
08:26 PM Feature #16118 (Open): Array .difference allow custom comparison
- Hello!
I wanted to know if there's any plan to implement the ability to define comparison between individual items in arrays.
Here is where I originally asked the question on Stack Overflow: https://stackoverflow.com/questions/5731... -
- > I think this could open up some possibilities (or a can of worms).
Some can call it a feature, other may call it a bug. :-)
In regards to keyword arguments, though, I would wait a bit and see
how/if https://bugs.ruby-lang.org/is... -
12:01 PM Feature #16115 (Open): Keyword arguments from method calls or ignore extra hash keys in splat
- Just a thought, feel free to insta-close as stupid.
Currently you can do this:
```
def hello(who:)
puts "Hello, #{who}"
end
opts = { who: 'world' }
hello(who)
```
Or:
```
def hello(who:, **_extra_opts) # without e... -
-
-
- with Travis, rather than AppVeyor.
Formerly it was made similar to AppVeyor to provide some normal set of
CI failure notification. But for some reason people preferred a shorter
variant and introduced a1d606c079f6c3d1779d885e0bf2e399125... - 01:47 PM Revision efc89703 (git): * expand tabs. [ci skip]
- Tabs are expanded because previously the file did not have any tab indentation.
Please update your editor config, and use misc/expand_tabs.rb in the pre-commit hook. -
-
- This ticket was resolved with commit:15eaedf805fb2727c79a6c59af6d5f6c2a6d634b.
In addition to that, since people have often objected to "expand tabs" against files which are not related to VM / MJIT (debugging MJIT needs to see prepro... -
- Applied in changeset commit:git|15eaedf805fb2727c79a6c59af6d5f6c2a6d634b.
----------
Add misc/expand_tabs.rb ported from auto-style.rb
This is implemented to close [Misc #16112] because all other options got
at least one objection, and... -
- > I like option 3 because it is optional and something I would use. I don't personally like using tabs.
Okay, I'm going to implement this one because nobody has objected to it and all other options had objections from somebody.
> .... -
- k0kubun (Takashi Kokubun) wrote:
> * It would reduce the number of problems for editors like Sublime Text, VSCode, and Atom.
I'm surprised some of the currently most popular editors can't handle such situations. I'm not using one o... -
- This is implemented to close [Misc #16112] because all other options got
at least one objection, and nobody has objected to this solution.
This code is a little complicated for the purpose, but that's just
because it includes some histo... -
- **testmml_win.rb code:**
```ruby
require 'fiddle'
require 'fiddle/import'
if ARGV.length < 1
puts "Missing libPath argument..."
puts "Usage: ruby HostTest2.rb libPath"
puts "Sample: ruby HostTest2.rb /home/Protocol... -
- I have a dll build by MinGW32 in windows7, in ruby2.2, I could use fiddle dlload this dll success, but in the same system, use 2.6.3 failed to dlload this dll, always report No such file or direcoty.
**///////// Ruby2.2 success load t... -
- I build a RubyTest.dll by C#, In ruby2.2, I could use WIN32OLE.new to create ole object, but in the same system under ruby2.6.3, it failed to create ole object by WIN32OLE.new, is there any different between ruby 2.2 and ruby 2.6.3 in WI...
-
11:59 AM Bug #14716: SecureRandom throwing an error in Ruby 2.5.1
- I have the same issue running ruby 2.6.3 on MacOS 10.14.6 while using guard on a rails project:
```
13:43:07 - INFO - Running: spec/features/foo_spec.rb
Running via Spring preloader in process 17829
Randomized with seed 57737
Ca... -
11:39 AM Revision 0a74fac9 (git): merge revision(s) fd0e3bd2497d4e796b719c7b7154dc3c945f87b1: [Backport #14834]
- fix VC 2013 compile error
It seems the compiler does not support VLAs.
See also: https://ci.appveyor.com/project/ruby/ruby/builds/26392589/job/px6nuiuw4e78weg1
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2... -
- ruby_2_6 r67749 merged revision(s) 9557069299ac3b96691040a541afa65761a724ad.
-
- Avoid creating Hash objects per each mon_synchronize call (#2393)
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_6@67749 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- This shows that there are only two real problems in computer science:
- Giving things proper names
- Documenting code after the code has been written
- Off by one errors
:P
From the candidates, I somewhat like mrkn's suggestio... -
04:58 AM Misc #16114: Naming of "beginless range"
- duerst (Martin Dürst) wrote:
> mrkn (Kenta Murata) wrote:
> ...
Oops! The correct candidates are "a range unbounded below" and "a range unbounded above".
Thanks.
-
- mrkn (Kenta Murata) wrote:
> Other candidates from mathematics:
> ...
Shouldn't this be "a range not bounded below"?
> - lower-unbounded range
> ...
Same thing here.
-
- I know that it is an awkward word, but it came from `Range#begin` and `Range#end`. IMO, you can call it as you like.
-
- > Having `begin?` and `end?` instead of `beginless?` and `endless?` would be more natural, and easy to comprehend.
Agreed. Moreover, `Range#begin` and `#end` just work.
-
03:23 AM Feature #15864: Proposal: Add methods to determine if it is an infinite range
- Having negative meaning in the method name would make it complicated. Having `begin?` and `end?` instead of `beginless?` and `endless?` would be more natural, and easy to comprehend.
In fact, the given use case:
```ruby
def search... -
- Other candidates from mathematical terms:
- `unbounded?` for checking whether `begin` or `end` is `nil`
- `lower_unbounded?`, `left_unbounded?`, or `unbounded_below?` for checking whether `begin` is `nil`
- `upper_unbounded?`, `righ... -
- * [Feature#14183] "Real" keyword argument
* Jeremy and I agreed with Jeremy's proposal. I'd like to ask for matz's final confirmation. -
- - [Feature #15864] Proposal: Add methods to determine if it is an infinite range
- I proposed some candidates from mathematical terms -
12:24 AM Revision d8d8015b (git): Remove footer from message to Slack
08/21/2019
-
- Other candidates from mathematics:
- a range bounded below
- lower-unbounded range
- left-unbounded range
If we use "unbounded" for the minimum value of a range, we should rephrase "endless" with the following candidates:
- a ... -
11:34 PM Misc #16114 (Open): Naming of "beginless range"
- #14799 introduces a "beginless range" to complement the already existing "endless range". However, "beginless" isn't an existing word in English. Since the term for something without a beginning is "beginingless", I'd propose renaming "...
-
- This should be fixed by commit:2b2450ba4bee563e33af0325b7fde8cb1bfd6899.
-
-
-
-
-
- This is still a bug in the master branch. Attached is a patch that
fixes it, making the behavior for super in instance_eval in method
in module the same as super in `instance_eval` in method in class,
raising a `TypeError`.
This i... -
- 08:36 PM Revision 8d804e41 (git): Add abs to Matrix (#2199)
-
-
- k0kubun (Takashi Kokubun) wrote:
> Thanks for your comment, Jeremy. Your opinion makes sense except:
> ...
Basically, I am in favor of removing the "expand tabs" commits (stop trying to enforce whitespace). However, if we do keep the ... -
- Thanks for your comment, Jeremy. Your opinion makes sense except:
> 2) I'm against this. If we do keep the "expand tabs", then it should be applied to modified lines as well as new lines, so that we move in the direction of fewer tabs... -
- Here are my opinions on the options:
0) I'm in favor of this. I certainly encourage the use of spaces over tabs, but auto commits for indentation changes are unnecessary and I don't think the benefit outweighs the cost.
1) I'm aga... -
- There's Option 5; altering commits in pre-receive hook on server side. But I think successful `git push` should never make future `git pull` fail. It is a very surprising behavior and would confuse committers. So I'm rejecting this optio...
-
- > I would love it if (1) can happen.
> ...
However, it's something worth considering.
>
> ...
Despite the Vim's default behavior which shows the mixed indentation well, my Vim configuration had shown it weirdly (well, I couldn't find ... - 03:20 PM Revision 6bdb65c0 (git): * 2019-08-22 [ci skip]
-
-
-
- sometimes Slack notification footer becomes just " at ".
It seems like `github.event.head_commit` is missing. Let me debug the
context. -
- * ~~[Misc #16112] Reduce the possibility of "expand tabs" commit occurrences~~
* Never mind. Resolved before the MTG thanks to @jeremyevans's comment. -
- 9557069299ac3b96691040a541afa65761a724ad is a follow up commit to ease memory consumption impact of f91879a7b548284c93743168acfd11e3d2aeefac. I think it should be backported too.
-
-
- From some testing, it appears this issue no longer occurs in the current version of logger. If you can reproduce this issue with the current version of logger, please post a self contained example showing the problem.
-
-
-
- This appears to have been fixed between 2.4 and 2.5, as the example no longer has a segfault on 2.5, 2.6, 2.7.0-preview1, or the master branch.
-
- This bug still occurs in the master branch. Attached is a patch that fixes the problem by overriding `Ripper::SexpBuilder#on_method_add_block`. This isn't a very clean way to fix it, but I was not able to figure out a way to fix it by ...
08/20/2019
-
- Okay, it is considered deprecated, but the removal won't happen in the near future. Thank you, I see!
-
- I believe the current documentation and code is intentional. I think it is best to consider `String#crypt` deprecated even if we are not emitting warnings for it and we do not have immediate plans to remove it. I would still like to rem...
-
- @jeremyevans0 Let me confirm the state of this ticket. The current rdoc says:
```
Please do
not use this method any longer. It is legacy; provided only for
backward compatibility with ruby scripts in earlier days.
...
If fo... - 11:10 PM Revision a230e65e (git): [bundler/bundler] Freeze time to avoid failures at midnight
- Specify just a string
set @built_at as nil before testing
https://github.com/bundler/bundler/commit/578ec96c9c -
- https://github.com/bundler/bundler/commit/a38161c5be
-
- https://github.com/bundler/bundler/commit/faccc522d1
-
- https://github.com/bundler/bundler/commit/23007cb107
-
- https://github.com/bundler/bundler/commit/52b6b94068
-
- Our current set of specs is the same for all supported rubies, and we
should keep it that way.
https://github.com/bundler/bundler/commit/c9dc0f6f2c -
- https://github.com/bundler/bundler/commit/8c7942d2c6
-
- https://github.com/bundler/bundler/commit/36fb3287f4
-
- I was able to reproduce this on `ruby 1.9.3p551 (2014-11-13) [i386-mingw32]`, but not on any `[x64-mingw32]` compiled Ruby. I installed ruby `2.6.3p62 (2019-04-16 revision 67580) [i386-mingw32]` and was no longer able to reproduce the e...
-
- This appears to have been fixed in commit:c0766464e9ef13418cc719acd674f363b79db29a.
-
- I tried working on this a couple weeks ago and I don't believe the current LALR(1) parser can support it. Attempting to modify the parser to support the behavior you desire leads to many shift/reduce or reduce/reduce conflicts. It is p...
-
- I was able to reproduce the segfault in ruby 2.3 and 2.4, but not in 2.5, 2.6, 2.7.0-preview1, or the master branch, so I think this problem is fixed. If this problem still occurs for you, please reply with your environment details.
-
-
- I've completed work on my keyword-argument-separation branch, and now `make check` passes without any emitted warnings in my environment. To get some early CI testing of this, I have submitted it as a GitHub pull request: https://github...
-
-
02:26 PM Bug #16111: Combining default positional and keyword arguments is resulting in a `to_hash` method call
- Ok, the situation with keyword parameters is now making more sense, despite not being ideal. Since ruby 3 should implement a fix (backwards compatible or not) I am happy for this issue to be closed.
Thanks to those who commented to b... - 04:04 PM Revision 864f23a4 (git): * 2019-08-21 [ci skip]
-
04:04 PM Revision 88b1f2da (git): `rp(obj)` shows func, file and line. (#2394)
- rp() macro for debug also shows file location and function name
such as:
[OBJ_INFO:rb_call_inits@inits.c:73] 0x000056147741b248 ... -
03:21 PM Bug #14716: SecureRandom throwing an error in Ruby 2.5.1
- Hi,
I am having same issue while running seed data (ruby 2.6.3). I am having it while uplaoding attachments.
```
/Users/myuser/.rvm/gems/ruby-2.6.3/gems/activesupport-6.0.0.rc2/lib/active_support/core_ext/securerandom.rb:39:in `bas... -
- It seems that we cannot easily apply job-level [ci skip].
Therefore this commit skips only Tests step if it's [ci skip]. -
- Some CIs report to two channels, and some others report to only one.
This makes it consistent. Only alert channel should be alerted. -
01:08 PM Revision 95570692 (git): Avoid creating Hash objects per each mon_synchronize call (#2393)
-
12:47 PM Bug #9115: Logger traps all exceptions; breaks Timeout
- There're also rescue-clauses for `check_shift_log` and `@dev.write(message)`.
They may raise various exceptions and logger.rb never knows that.
Explicitly passing those exceptions are general way, but are there any exceptions other t... -
- See the code again before discuss.
```ruby
def write(message)
begin
synchronize do
if @shift_age and @dev.respond_to?(:stat)
begin
check_shift_log
rescue
... -
-
-
08:26 AM Misc #16112: Reduce the possibility of "expand tabs" commit occurrences
- I second what Alan said, editing Ruby source with my editor is a nightmare.
On another note, the main objection for getting rid of tabs once and for all seem to be `git blame`, so I wonder wether `git filter-branch` was considered.
... -
- It is defined since ruby 1.9.2.
https://github.com/rubygems/rubygems/commit/84981ca908 -
-
- An aside, but I took a stab at a pure Ruby implementation of keyword argument currying: https://gist.github.com/havenwood/db041566abeac894602c188c77374040
``` ruby
['{"aim":true}', '{"impossible":false}'].map &JSON.:parse.curry.(symb... -
- * These seem to consistenly pass already
* Show actual command when running `make test-bundler`
Current the setup command that installs the necessary gems for testing
bundler was printed, but not the actual command that runs the tests....
08/19/2019
-
- @maciej.mensfeld In latest revisions of IRB and Reline, this problem can't be reproduced. Maybe it's fixed.
-
- A "do" what has followed a token what has EXPR_CMDARG is for a block,
and in other cases "do" is for "while", "until" or "for". -
07:45 PM Bug #16098 (Closed): SEGV with RUBY_ISEQ_DUMP_DEBUG=to_binary make check
- Applied in changeset commit:git|dc0e45e39b37556af8abf6cdb0180e2973041931.
----------
Update moved objects in original_iseq
Without doing this, enabling a TracePoint on a method could lead to use
of moved objects. This was found by runn... -
- Without doing this, enabling a TracePoint on a method could lead to use
of moved objects. This was found by running
`env RUBY_ISEQ_DUMP_DEBUG=to_binary make test-all`, which sets
orignal_iseq then runs the compaction tests and the tracep... -
- I would love it if (1) can happen. Editors like Sublime Text, VSCode and Atom cannot
distinguish between indent size and tab size, so they have trouble handling the
current style. I use Sublime and have to set my indentation size to 8 ... -
09:12 AM Misc #16112: Reduce the possibility of "expand tabs" commit occurrences
- Option 4 is not a lethal tab killer, but nevertheless a good thing to have.
-
- My (weak) vote goes to 1, or 0 (just drop "expand tabs" :-).
-
- ## Problem
* While we agreed to use only spaces for indentation of C code in [Bug #14246], we sometimes hit "expand tabs" commit when we just edit a part of existing lines with hard tab indentation.
* "expand tabs" commit bothers peopl... -
-
-
-
- Should compare minimum required version, and with the particular
macro defined for each version. Also made the error messages
consistent. - 05:05 PM Revision e6b72e8c (git): retrieve current path on macOS
-
- I think that either way, resolving it may not be trivial/simple right now; if you
look at mame's linked in issue above at #14183, it mentions 19 (somewhat) related
issues concerning keyword arguments. Jeremy also pointed out some bugs ... -
- Ok, thanks for the reply. That now makes more sense. I understand why the last positional argument is type-checked but surely trying to convert it using `param#to_hash` is a step too far? Doing so basically means that the last positional...
-
- > I would like to know why the method to_hash is being called
A method call that accepts keywords checks if the last argument is a Hash or not. The check includes attempting to convert it by using `to_hash`. This is the behavior you... -
- Combining default positional and keyword arguments is resulting in a `to_hash` method call when I don't believe it should be. It's affecting some code I am writing. The full details of the behaviour I'm describing can be seen in the atta...
-
04:24 PM Feature #15982: Remove y2racc and racc2y
- Yes, the stable racc has them, but
1. They were never shipped in Ruby, so if they won't be shipped, nobody should miss them.
2. It is not clear if they outputs are useful or reliable, so why to ship them if you can't tell they are us... - 03:21 PM Revision 1408f159 (git): * 2019-08-20 [ci skip]
-
- The second argument of ioctl seems to be int in Android.
Android is not a supported platform, but this one-line change allows
ruby to build by Android NDK r20. -
02:28 PM Bug #16110: Doesn't detect deadlock on Ruby 2.4 and 2.5 on Windows
- Is this specific to 32 bit builds of 2.4 & 2.5? I think 64 bit builds all function as expected...
-
- the Devs should maybe look at `#curry` for this, currently it doesn't support a way to curry keyword arguments
-
- Personally I dislike this proposal primarily due to the name alone. I don't think
a method named .m is good in this context.
We do have short named methods here and there, of course, such as "p" or "pp",
but I feel that these cases ... -
- **Preface:** One of the main "microstructures" of the code we use is chaining methods-with-blocks; and we really love to keep those blocks DRY when they are simple. Currently, for DRY-ing up simple blocks, we have:
* `foo(&:symbol)`
... -
-
09:43 AM Revision 8882986d (git): Drop duplicated sample code (#2389) [ci skip]
- * Drop duplicated sample code
* Drop another style sample
https://github.com/ruby/ruby/pull/2389#issuecomment-522489520
* Update sample list -
- * It can invoke test-unit with envutil.rb
* refute_match of test-unit couldn't handle String instance. -
- ```
sample/observ.rb:30: warning: assigned but unused variable - clock
``` -
- because it has often hanged like
https://travis-ci.org/ruby/ruby/jobs/573691637,
and we also have almost the same test suite on GitHub Actions now, which
seems to be stable in `make check` so far. -
- Kernel#inspect does not call #to_s now
To follow https://github.com/ruby/ruby/commit/fd7dc23d281f38a71fa7f9c32812cd468c4b1788 -
- 08:36 AM Revision 6dd9736c (git): crash report on mac little update
- displaying vm info as Linux and FreeBSD.
checking libproc as it is present only from 10.5 version.
https://github.com/ruby/ruby/pull/2384 -
-
-
-
-
- And this is the current `git ls-remote`. Now it looks more consistent.
## after
```
$ git ls-remote origin
1bd60c66d385142d08f678f8a9563c311cfc3fe8 HEAD
1bd60c66d385142d08f678f8a9563c311cfc3fe8 refs/heads/master
ab6... -
- Done. Here's the full operation log:
```
$ git push origin :v1_3_1_
remote: To git@github.com:ruby/ruby.git
remote: - [deleted] v1_3_1_
To git.ruby-lang.org:ruby.git
- [deleted] v1_3_1_
$ git push origi... -
- I'm going to apply this. I captured the current status of git.ruby-lang.org/ruby.git.
## before
```
$ git ls-remote origin
c5db4c28f9349eb296a360dc08d6b88be66916d1 HEAD
c5db4c28f9349eb296a360dc08d6b88be66916d1 refs... -
- * include/ruby/ruby.h: cast via `unsigned int` explicitly, to get
rid of signed extension by implicit integer promotion. - 06:37 AM Revision 4515bcc9 (git): Omit version.h when merging
-
06:35 AM Bug #15793: Please backport 7b7043e5da8589e01b94575d4ed647e909e5c875
- ruby_2_5 r67748 merged revision(s) f4fe2a76b0564e8e572936dec3bd724ac22b7a44.
- 06:35 AM Revision bad64833 (git): merge revision(s) f4fe2a76b0564e8e572936dec3bd724ac22b7a44: [Backport #15793]
- merge revision(s) 7b7043e5da8589e01b94575d4ed647e909e5c875: [Backport
#15793]
eliminate use of freed memory
rb_io_fptr_finalize_internal frees the memory region.
===============... -
- to suppress a waring for "unused variable"
-
- as it failed randomly https://github.com/ruby/ruby/runs/196712109
-
- Applied in changeset commit:git|39a43d9cd09f8c880d0a70d9cb8ede6d7e6ef583.
----------
Make it as clear as possible that RubyVM is MRI-specific and only exists on MRI (#2113) [ci skip]
* Make it clear as possible that RubyVM is MRI-speci... -
- * Make it clear as possible that RubyVM is MRI-specific and only exists on MRI
* See [Bug #15743].
* Use "CRuby VM" instead of "Ruby VM" for clarity.
* Use YARV rather than "CRuby VM" for documenting RubyVM::InstructionSequence
* Avoi... -
- 05:34 AM Revision 1f3f50fb (git): * expand tabs. [ci skip]
-
- * [Win32] set flag to allow unprivileged users to create symlinks
-
01:44 AM Feature #15215: HTTPS server name indication (SNI): explicit server_name in Net::HTTP
- aspettl (Aaron Spettl) wrote:
> I still like to have this feature. Any opinion on this? Especially @naruse as a maintainer of lib/net/http(s).rb?
> ...
+1 as well -
- This is a designed behaviour. A backslash character is first cooked by the ruby interpreter (to handle `\'` etc), then cooked again by gsub's own preprocessor (to handle `\1` etc). You have to understand exactly what is going on to pla...
-
-
- It was using the same one as original AppVeyor's notification, but it's
just inconsistent with others like Travis and GitHub Actions. -
- by marking continue-on-error.
I dropped it to test Slack notification, and I finished to test it.