Activity
From 08/16/2019 to 08/22/2019
08/22/2019
-
11:58 PM Feature #16119 (Closed): Optimize Array#flatten and flatten! for already flattened arrays
- ## Problem
When doing an object profile from stackprof, I noticed object allocations being made from `Array#flatten!` which was unlike other in-place methods like `Array#uniq!` and `Array#compact!`. In this case, I wanted to optimize... -
08:26 PM Feature #16118 (Open): Array .difference allow custom comparison
- Hello!
I wanted to know if there's any plan to implement the ability to define comparison between individual items in arrays.
Here is where I originally asked the question on Stack Overflow: https://stackoverflow.com/questions/5731... -
07:56 PM Feature #16115: Keyword arguments from method calls or ignore extra hash keys in splat
- > I think this could open up some possibilities (or a can of worms).
Some can call it a feature, other may call it a bug. :-)
In regards to keyword arguments, though, I would wait a bit and see
how/if https://bugs.ruby-lang.org/is... -
12:01 PM Feature #16115 (Open): Keyword arguments from method calls or ignore extra hash keys in splat
- Just a thought, feel free to insta-close as stupid.
Currently you can do this:
```
def hello(who:)
puts "Hello, #{who}"
end
opts = { who: 'world' }
hello(who)
```
Or:
```
def hello(who:, **_extra_opts) # without e... -
03:32 PM Bug #11152 (Closed): Resolv::DNS should use Search Domains provided in /etc/resolv.conf by default
-
-
02:10 PM Revision fd20b321 (git): Make GitHub Actions Slack notification consistent
- with Travis, rather than AppVeyor.
Formerly it was made similar to AppVeyor to provide some normal set of
CI failure notification. But for some reason people preferred a shorter
variant and introduced a1d606c079f6c3d1779d885e0bf2e399125... - 01:47 PM Revision efc89703 (git): * expand tabs. [ci skip]
- Tabs are expanded because previously the file did not have any tab indentation.
Please update your editor config, and use misc/expand_tabs.rb in the pre-commit hook. -
-
- This ticket was resolved with commit:15eaedf805fb2727c79a6c59af6d5f6c2a6d634b.
In addition to that, since people have often objected to "expand tabs" against files which are not related to VM / MJIT (debugging MJIT needs to see prepro... -
- Applied in changeset commit:git|15eaedf805fb2727c79a6c59af6d5f6c2a6d634b.
----------
Add misc/expand_tabs.rb ported from auto-style.rb
This is implemented to close [Misc #16112] because all other options got
at least one objection, and... -
- > I like option 3 because it is optional and something I would use. I don't personally like using tabs.
Okay, I'm going to implement this one because nobody has objected to it and all other options had objections from somebody.
> .... -
05:03 AM Misc #16112: Reduce the possibility of "expand tabs" commit occurrences
- k0kubun (Takashi Kokubun) wrote:
> * It would reduce the number of problems for editors like Sublime Text, VSCode, and Atom.
I'm surprised some of the currently most popular editors can't handle such situations. I'm not using one o... -
- This is implemented to close [Misc #16112] because all other options got
at least one objection, and nobody has objected to this solution.
This code is a little complicated for the purpose, but that's just
because it includes some histo... -
12:22 PM Bug #16117: ruby2.6.3(x86) use fiddle faild to load dll in windows7
- **testmml_win.rb code:**
```ruby
require 'fiddle'
require 'fiddle/import'
if ARGV.length < 1
puts "Missing libPath argument..."
puts "Usage: ruby HostTest2.rb libPath"
puts "Sample: ruby HostTest2.rb /home/Protocol... -
- I have a dll build by MinGW32 in windows7, in ruby2.2, I could use fiddle dlload this dll success, but in the same system, use 2.6.3 failed to dlload this dll, always report No such file or direcoty.
**///////// Ruby2.2 success load t... -
- I build a RubyTest.dll by C#, In ruby2.2, I could use WIN32OLE.new to create ole object, but in the same system under ruby2.6.3, it failed to create ole object by WIN32OLE.new, is there any different between ruby 2.2 and ruby 2.6.3 in WI...
-
11:59 AM Bug #14716: SecureRandom throwing an error in Ruby 2.5.1
- I have the same issue running ruby 2.6.3 on MacOS 10.14.6 while using guard on a rails project:
```
13:43:07 - INFO - Running: spec/features/foo_spec.rb
Running via Spring preloader in process 17829
Randomized with seed 57737
Ca... -
11:39 AM Revision 0a74fac9 (git): merge revision(s) fd0e3bd2497d4e796b719c7b7154dc3c945f87b1: [Backport #14834]
- fix VC 2013 compile error
It seems the compiler does not support VLAs.
See also: https://ci.appveyor.com/project/ruby/ruby/builds/26392589/job/px6nuiuw4e78weg1
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2... -
- ruby_2_6 r67749 merged revision(s) 9557069299ac3b96691040a541afa65761a724ad.
-
- Avoid creating Hash objects per each mon_synchronize call (#2393)
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_6@67749 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- This shows that there are only two real problems in computer science:
- Giving things proper names
- Documenting code after the code has been written
- Off by one errors
:P
From the candidates, I somewhat like mrkn's suggestio... -
04:58 AM Misc #16114: Naming of "beginless range"
- duerst (Martin Dürst) wrote:
> mrkn (Kenta Murata) wrote:
> ...
Oops! The correct candidates are "a range unbounded below" and "a range unbounded above".
Thanks.
-
- mrkn (Kenta Murata) wrote:
> Other candidates from mathematics:
> ...
Shouldn't this be "a range not bounded below"?
> - lower-unbounded range
> ...
Same thing here.
-
12:01 AM Misc #16114: Naming of "beginless range"
- I know that it is an awkward word, but it came from `Range#begin` and `Range#end`. IMO, you can call it as you like.
-
- > Having `begin?` and `end?` instead of `beginless?` and `endless?` would be more natural, and easy to comprehend.
Agreed. Moreover, `Range#begin` and `#end` just work.
-
03:23 AM Feature #15864: Proposal: Add methods to determine if it is an infinite range
- Having negative meaning in the method name would make it complicated. Having `begin?` and `end?` instead of `beginless?` and `endless?` would be more natural, and easy to comprehend.
In fact, the given use case:
```ruby
def search... -
- Other candidates from mathematical terms:
- `unbounded?` for checking whether `begin` or `end` is `nil`
- `lower_unbounded?`, `left_unbounded?`, or `unbounded_below?` for checking whether `begin` is `nil`
- `upper_unbounded?`, `righ... -
- * [Feature#14183] "Real" keyword argument
* Jeremy and I agreed with Jeremy's proposal. I'd like to ask for matz's final confirmation. -
- - [Feature #15864] Proposal: Add methods to determine if it is an infinite range
- I proposed some candidates from mathematical terms -
12:24 AM Revision d8d8015b (git): Remove footer from message to Slack
08/21/2019
-
- Other candidates from mathematics:
- a range bounded below
- lower-unbounded range
- left-unbounded range
If we use "unbounded" for the minimum value of a range, we should rephrase "endless" with the following candidates:
- a ... -
11:34 PM Misc #16114 (Open): Naming of "beginless range"
- #14799 introduces a "beginless range" to complement the already existing "endless range". However, "beginless" isn't an existing word in English. Since the term for something without a beginning is "beginingless", I'd propose renaming "...
-
- This should be fixed by commit:2b2450ba4bee563e33af0325b7fde8cb1bfd6899.
-
-
10:21 PM Revision 1940347f (git): Use () instead of {} for nmake
-
-
-
- This is still a bug in the master branch. Attached is a patch that
fixes it, making the behavior for super in instance_eval in method
in module the same as super in `instance_eval` in method in class,
raising a `TypeError`.
This i... -
- 08:36 PM Revision 8d804e41 (git): Add abs to Matrix (#2199)
-
-
- k0kubun (Takashi Kokubun) wrote:
> Thanks for your comment, Jeremy. Your opinion makes sense except:
> ...
Basically, I am in favor of removing the "expand tabs" commits (stop trying to enforce whitespace). However, if we do keep the ... -
- Thanks for your comment, Jeremy. Your opinion makes sense except:
> 2) I'm against this. If we do keep the "expand tabs", then it should be applied to modified lines as well as new lines, so that we move in the direction of fewer tabs... -
- Here are my opinions on the options:
0) I'm in favor of this. I certainly encourage the use of spaces over tabs, but auto commits for indentation changes are unnecessary and I don't think the benefit outweighs the cost.
1) I'm aga... -
- There's Option 5; altering commits in pre-receive hook on server side. But I think successful `git push` should never make future `git pull` fail. It is a very surprising behavior and would confuse committers. So I'm rejecting this optio...
-
- > I would love it if (1) can happen.
> ...
However, it's something worth considering.
>
> ...
Despite the Vim's default behavior which shows the mixed indentation well, my Vim configuration had shown it weirdly (well, I couldn't find ... - 03:20 PM Revision 6bdb65c0 (git): * 2019-08-22 [ci skip]
-
03:19 PM Revision a9638511 (git): Hoisted out rb_id_metadata
-
-
- sometimes Slack notification footer becomes just " at ".
It seems like `github.event.head_commit` is missing. Let me debug the
context. -
- * ~~[Misc #16112] Reduce the possibility of "expand tabs" commit occurrences~~
* Never mind. Resolved before the MTG thanks to @jeremyevans's comment. -
- 9557069299ac3b96691040a541afa65761a724ad is a follow up commit to ease memory consumption impact of f91879a7b548284c93743168acfd11e3d2aeefac. I think it should be backported too.
-
-
- From some testing, it appears this issue no longer occurs in the current version of logger. If you can reproduce this issue with the current version of logger, please post a self contained example showing the problem.
-
-
04:26 AM Revision 81dfe3c4 (git): Enable more Time TZ tests on OpenBSD
-
- This appears to have been fixed between 2.4 and 2.5, as the example no longer has a segfault on 2.5, 2.6, 2.7.0-preview1, or the master branch.
-
- This bug still occurs in the master branch. Attached is a patch that fixes the problem by overriding `Ripper::SexpBuilder#on_method_add_block`. This isn't a very clean way to fix it, but I was not able to figure out a way to fix it by ...
08/20/2019
-
- Okay, it is considered deprecated, but the removal won't happen in the near future. Thank you, I see!
-
- I believe the current documentation and code is intentional. I think it is best to consider `String#crypt` deprecated even if we are not emitting warnings for it and we do not have immediate plans to remove it. I would still like to rem...
-
- @jeremyevans0 Let me confirm the state of this ticket. The current rdoc says:
```
Please do
not use this method any longer. It is legacy; provided only for
backward compatibility with ruby scripts in earlier days.
...
If fo... - 11:10 PM Revision a230e65e (git): [bundler/bundler] Freeze time to avoid failures at midnight
- Specify just a string
set @built_at as nil before testing
https://github.com/bundler/bundler/commit/578ec96c9c -
- https://github.com/bundler/bundler/commit/a38161c5be
-
- https://github.com/bundler/bundler/commit/faccc522d1
-
11:10 PM Revision ace88852 (git): [bundler/bundler] Parallelize test suite
- https://github.com/bundler/bundler/commit/23007cb107
-
- https://github.com/bundler/bundler/commit/52b6b94068
-
- Our current set of specs is the same for all supported rubies, and we
should keep it that way.
https://github.com/bundler/bundler/commit/c9dc0f6f2c -
- https://github.com/bundler/bundler/commit/8c7942d2c6
-
- https://github.com/bundler/bundler/commit/36fb3287f4
-
- I was able to reproduce this on `ruby 1.9.3p551 (2014-11-13) [i386-mingw32]`, but not on any `[x64-mingw32]` compiled Ruby. I installed ruby `2.6.3p62 (2019-04-16 revision 67580) [i386-mingw32]` and was no longer able to reproduce the e...
-
- This appears to have been fixed in commit:c0766464e9ef13418cc719acd674f363b79db29a.
-
- I tried working on this a couple weeks ago and I don't believe the current LALR(1) parser can support it. Attempting to modify the parser to support the behavior you desire leads to many shift/reduce or reduce/reduce conflicts. It is p...
-
- I was able to reproduce the segfault in ruby 2.3 and 2.4, but not in 2.5, 2.6, 2.7.0-preview1, or the master branch, so I think this problem is fixed. If this problem still occurs for you, please reply with your environment details.
-
-
- I've completed work on my keyword-argument-separation branch, and now `make check` passes without any emitted warnings in my environment. To get some early CI testing of this, I have submitted it as a GitHub pull request: https://github...
-
-
02:26 PM Bug #16111: Combining default positional and keyword arguments is resulting in a `to_hash` method call
- Ok, the situation with keyword parameters is now making more sense, despite not being ideal. Since ruby 3 should implement a fix (backwards compatible or not) I am happy for this issue to be closed.
Thanks to those who commented to b... - 04:04 PM Revision 864f23a4 (git): * 2019-08-21 [ci skip]
-
04:04 PM Revision 88b1f2da (git): `rp(obj)` shows func, file and line. (#2394)
- rp() macro for debug also shows file location and function name
such as:
[OBJ_INFO:rb_call_inits@inits.c:73] 0x000056147741b248 ... -
03:21 PM Bug #14716: SecureRandom throwing an error in Ruby 2.5.1
- Hi,
I am having same issue while running seed data (ruby 2.6.3). I am having it while uplaoding attachments.
```
/Users/myuser/.rvm/gems/ruby-2.6.3/gems/activesupport-6.0.0.rc2/lib/active_support/core_ext/securerandom.rb:39:in `bas... -
- It seems that we cannot easily apply job-level [ci skip].
Therefore this commit skips only Tests step if it's [ci skip]. -
- Some CIs report to two channels, and some others report to only one.
This makes it consistent. Only alert channel should be alerted. -
01:08 PM Revision 95570692 (git): Avoid creating Hash objects per each mon_synchronize call (#2393)
-
12:47 PM Bug #9115: Logger traps all exceptions; breaks Timeout
- There're also rescue-clauses for `check_shift_log` and `@dev.write(message)`.
They may raise various exceptions and logger.rb never knows that.
Explicitly passing those exceptions are general way, but are there any exceptions other t... -
- See the code again before discuss.
```ruby
def write(message)
begin
synchronize do
if @shift_age and @dev.respond_to?(:stat)
begin
check_shift_log
rescue
... -
-
-
08:26 AM Misc #16112: Reduce the possibility of "expand tabs" commit occurrences
- I second what Alan said, editing Ruby source with my editor is a nightmare.
On another note, the main objection for getting rid of tabs once and for all seem to be `git blame`, so I wonder wether `git filter-branch` was considered.
... -
- It is defined since ruby 1.9.2.
https://github.com/rubygems/rubygems/commit/84981ca908 -
-
01:28 AM Feature #16113: Partial application
- An aside, but I took a stab at a pure Ruby implementation of keyword argument currying: https://gist.github.com/havenwood/db041566abeac894602c188c77374040
``` ruby
['{"aim":true}', '{"impossible":false}'].map &JSON.:parse.curry.(symb... -
- * These seem to consistenly pass already
* Show actual command when running `make test-bundler`
Current the setup command that installs the necessary gems for testing
bundler was printed, but not the actual command that runs the tests....
08/19/2019
-
- @maciej.mensfeld In latest revisions of IRB and Reline, this problem can't be reproduced. Maybe it's fixed.
-
- A "do" what has followed a token what has EXPR_CMDARG is for a block,
and in other cases "do" is for "while", "until" or "for". -
07:45 PM Bug #16098 (Closed): SEGV with RUBY_ISEQ_DUMP_DEBUG=to_binary make check
- Applied in changeset commit:git|dc0e45e39b37556af8abf6cdb0180e2973041931.
----------
Update moved objects in original_iseq
Without doing this, enabling a TracePoint on a method could lead to use
of moved objects. This was found by runn... -
- Without doing this, enabling a TracePoint on a method could lead to use
of moved objects. This was found by running
`env RUBY_ISEQ_DUMP_DEBUG=to_binary make test-all`, which sets
orignal_iseq then runs the compaction tests and the tracep... -
- I would love it if (1) can happen. Editors like Sublime Text, VSCode and Atom cannot
distinguish between indent size and tab size, so they have trouble handling the
current style. I use Sublime and have to set my indentation size to 8 ... -
09:12 AM Misc #16112: Reduce the possibility of "expand tabs" commit occurrences
- Option 4 is not a lethal tab killer, but nevertheless a good thing to have.
-
- My (weak) vote goes to 1, or 0 (just drop "expand tabs" :-).
-
- ## Problem
* While we agreed to use only spaces for indentation of C code in [Bug #14246], we sometimes hit "expand tabs" commit when we just edit a part of existing lines with hard tab indentation.
* "expand tabs" commit bothers peopl... -
-
-
-
- Should compare minimum required version, and with the particular
macro defined for each version. Also made the error messages
consistent. - 05:05 PM Revision e6b72e8c (git): retrieve current path on macOS
-
- I think that either way, resolving it may not be trivial/simple right now; if you
look at mame's linked in issue above at #14183, it mentions 19 (somewhat) related
issues concerning keyword arguments. Jeremy also pointed out some bugs ... -
- Ok, thanks for the reply. That now makes more sense. I understand why the last positional argument is type-checked but surely trying to convert it using `param#to_hash` is a step too far? Doing so basically means that the last positional...
-
- > I would like to know why the method to_hash is being called
A method call that accepts keywords checks if the last argument is a Hash or not. The check includes attempting to convert it by using `to_hash`. This is the behavior you... -
- Combining default positional and keyword arguments is resulting in a `to_hash` method call when I don't believe it should be. It's affecting some code I am writing. The full details of the behaviour I'm describing can be seen in the atta...
-
04:24 PM Feature #15982: Remove y2racc and racc2y
- Yes, the stable racc has them, but
1. They were never shipped in Ruby, so if they won't be shipped, nobody should miss them.
2. It is not clear if they outputs are useful or reliable, so why to ship them if you can't tell they are us... - 03:21 PM Revision 1408f159 (git): * 2019-08-20 [ci skip]
-
- The second argument of ioctl seems to be int in Android.
Android is not a supported platform, but this one-line change allows
ruby to build by Android NDK r20. -
02:28 PM Bug #16110: Doesn't detect deadlock on Ruby 2.4 and 2.5 on Windows
- Is this specific to 32 bit builds of 2.4 & 2.5? I think 64 bit builds all function as expected...
-
12:23 PM Feature #16113: Partial application
- the Devs should maybe look at `#curry` for this, currently it doesn't support a way to curry keyword arguments
-
- Personally I dislike this proposal primarily due to the name alone. I don't think
a method named .m is good in this context.
We do have short named methods here and there, of course, such as "p" or "pp",
but I feel that these cases ... -
10:07 AM Feature #16113 (Open): Partial application
- **Preface:** One of the main "microstructures" of the code we use is chaining methods-with-blocks; and we really love to keep those blocks DRY when they are simple. Currently, for DRY-ing up simple blocks, we have:
* `foo(&:symbol)`
... -
10:37 AM Revision 45bed285 (git): Reduce sub-shell and use `&&` instead of `;`
-
09:43 AM Revision 8882986d (git): Drop duplicated sample code (#2389) [ci skip]
- * Drop duplicated sample code
* Drop another style sample
https://github.com/ruby/ruby/pull/2389#issuecomment-522489520
* Update sample list -
- * It can invoke test-unit with envutil.rb
* refute_match of test-unit couldn't handle String instance. -
- ```
sample/observ.rb:30: warning: assigned but unused variable - clock
``` -
- because it has often hanged like
https://travis-ci.org/ruby/ruby/jobs/573691637,
and we also have almost the same test suite on GitHub Actions now, which
seems to be stable in `make check` so far. -
- Kernel#inspect does not call #to_s now
To follow https://github.com/ruby/ruby/commit/fd7dc23d281f38a71fa7f9c32812cd468c4b1788 -
- 08:36 AM Revision 6dd9736c (git): crash report on mac little update
- displaying vm info as Linux and FreeBSD.
checking libproc as it is present only from 10.5 version.
https://github.com/ruby/ruby/pull/2384 -
-
-
-
-
- And this is the current `git ls-remote`. Now it looks more consistent.
## after
```
$ git ls-remote origin
1bd60c66d385142d08f678f8a9563c311cfc3fe8 HEAD
1bd60c66d385142d08f678f8a9563c311cfc3fe8 refs/heads/master
ab6... -
- Done. Here's the full operation log:
```
$ git push origin :v1_3_1_
remote: To git@github.com:ruby/ruby.git
remote: - [deleted] v1_3_1_
To git.ruby-lang.org:ruby.git
- [deleted] v1_3_1_
$ git push origi... -
- I'm going to apply this. I captured the current status of git.ruby-lang.org/ruby.git.
## before
```
$ git ls-remote origin
c5db4c28f9349eb296a360dc08d6b88be66916d1 HEAD
c5db4c28f9349eb296a360dc08d6b88be66916d1 refs... -
- * include/ruby/ruby.h: cast via `unsigned int` explicitly, to get
rid of signed extension by implicit integer promotion. - 06:37 AM Revision 4515bcc9 (git): Omit version.h when merging
-
06:35 AM Bug #15793: Please backport 7b7043e5da8589e01b94575d4ed647e909e5c875
- ruby_2_5 r67748 merged revision(s) f4fe2a76b0564e8e572936dec3bd724ac22b7a44.
- 06:35 AM Revision bad64833 (git): merge revision(s) f4fe2a76b0564e8e572936dec3bd724ac22b7a44: [Backport #15793]
- merge revision(s) 7b7043e5da8589e01b94575d4ed647e909e5c875: [Backport
#15793]
eliminate use of freed memory
rb_io_fptr_finalize_internal frees the memory region.
===============... -
- to suppress a waring for "unused variable"
-
- as it failed randomly https://github.com/ruby/ruby/runs/196712109
-
05:51 AM Feature #15743 (Closed): RubyVM should be renamed to CRuby
- Applied in changeset commit:git|39a43d9cd09f8c880d0a70d9cb8ede6d7e6ef583.
----------
Make it as clear as possible that RubyVM is MRI-specific and only exists on MRI (#2113) [ci skip]
* Make it clear as possible that RubyVM is MRI-speci... -
- * Make it clear as possible that RubyVM is MRI-specific and only exists on MRI
* See [Bug #15743].
* Use "CRuby VM" instead of "Ruby VM" for clarity.
* Use YARV rather than "CRuby VM" for documenting RubyVM::InstructionSequence
* Avoi... -
- 05:34 AM Revision 1f3f50fb (git): * expand tabs. [ci skip]
-
- * [Win32] set flag to allow unprivileged users to create symlinks
-
01:44 AM Feature #15215: HTTPS server name indication (SNI): explicit server_name in Net::HTTP
- aspettl (Aaron Spettl) wrote:
> I still like to have this feature. Any opinion on this? Especially @naruse as a maintainer of lib/net/http(s).rb?
> ...
+1 as well -
- This is a designed behaviour. A backslash character is first cooked by the ruby interpreter (to handle `\'` etc), then cooked again by gsub's own preprocessor (to handle `\1` etc). You have to understand exactly what is going on to pla...
-
-
- It was using the same one as original AppVeyor's notification, but it's
just inconsistent with others like Travis and GitHub Actions. -
- by marking continue-on-error.
I dropped it to test Slack notification, and I finished to test it.
08/18/2019
-
08:09 PM Bug #16110 (Closed): Doesn't detect deadlock on Ruby 2.4 and 2.5 on Windows
- The following code is detected as a deadlock, except in Ruby 2.4 and 2.5 on Windows:
``` sh
ruby -r thread -ve 'Thread.new { Queue.new.shift }.join'
```
You can see it run in this code: https://github.com/JoshCheek/childprocess_e... -
- by using toJson with fields.
-
- for macOS / Windows as well.
Docker-based GitHub Action does not work on these OSes. - 04:50 PM Revision aa5fbb5a (git): * 2019-08-19 [ci skip]
-
-
- This reverts commit d8807e8b1a9d09ee1543e18618b4ef7e8203c616.
We'd need more features. Reverting to customize this later. -
- https://github.com/8398a7/action-slack
https://github.com/marketplace/actions/action-slack -
- Yeah, I personally like vX.Y.Z rather than vX_Y_Z too, especially because it's closer to what `rake release` does by default.
However, newer tags are also tagged as vX_Y_Z, and renaming the new tags would be disruptive unlike renaming... -
- Sorry for the off-track comment from me - quite an epic task. :)
It would be kind of cool if we'd have not only a "time travel" history of all
of ruby in general, including the very old ruby releases by matz (like in the
1990s or so... -
- There are tags with inconsistent names. To browse the history more easily, I propose the following normalization.
**Before and after the renames, I'm going to record `git ls-remote` in this ticket. By doing so, we'd be able to revert t... -
- to clarify what's running for every commit.
-
-
-
- ruby_2_6 r67747 merged revision(s) d5c33364e3c0efb15e11df417c925afee2cdb9c9.
-
- Fixed heap-use-after-free
* string.c (rb_str_sub_bang): retrieves a pointer to the
replacement string buffer just before using it, for the case of
replacement with the receiver string itself. [Bug #16105]
g... -
- Closing https://github.com/ruby/ruby/pull/1998#issuecomment-437700528
-
- Closing as requested at https://github.com/ruby/ruby/pull/1998#issuecomment-437700528
-
- ruby_2_6 r67746 merged revision(s) 5b1bf8dd2d08ae7371ecf025967376bb794ed651.
-
- UTF LE is fixed at least the first 2 bytes
* io.c (io_strip_bom): if the first 2 bytes are 0xFF0xFE, it
should be a little-endian UTF, 16 or 32. [Bug #16099]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_... -
- for consistency. In the pull request, `before_test` was dropped only for
msys2 to fix msys2-only failure. But there's no need to keep it
inconsistent now. -
- * appveyor.yml - OpenSSL vc120 -> 1.0.2, vc140 -> 1.1.1
* Try just using build_script -
06:39 AM Revision 6b42b0c6 (git): Fix document of `GC.start` (#2382)
-
- ruby_2_6 r67745 merged revision(s) 5d33f787169bcc3594d2264726695d58c4a06899,8b162ce9d1003e4e469d8f48cb9a2076fd45b47c.
-
- fix tracepoint + backtrace SEGV
PC modification in gc_event_hook_body was careless. There are (so
to say) abnormal iseqs stored in the cfp. We have to check sanity
before we touch the PC.
This has not ... -
-
- ruby_2_6 r67744 merged revision(s) df317151a5b4e0c5a30fcc321a9dc6abad63f7ed.
-
- should not free local hook_list here.
exec_hooks_postcheck() clean executed hook_list if it is needed.
list_exec is freed if there are no events and this list is local
event (connected to specific iseq). However,... -
05:17 AM Feature #10098: [PATCH] Timing-safe string comparison for OpenSSL::HMAC
- New patch over at https://github.com/ruby/openssl/pull/269
-
- ruby_2_6 r67743 merged revision(s) f1b76ea63ce40670071a857f408a4747c571f1e9,1d1f98d49c9908f4e3928e582d31fd2e9f252f92.
-
- Occupy match data
* string.c (rb_str_split_m): occupy match data not to be modified
during yielding the block. [Bug #16024]
Reuse match data
* string.c (rb_str_split_m): reuse occupied match data. [... -
- https://github.com/bundler/bundler/commit/8ef571ed4e
-
- The version we're vendoring actually relaxed this restriction back to
2.3.0+, so we can always use the vendored version.
https://github.com/bundler/bundler/commit/d366cbfe5d -
- Instead, make sure we always load the local copy of bundler during
specs, and never end up using the default copy.
https://github.com/bundler/bundler/commit/ac655ffeda -
- If we use system bundler, when booting the "outermost" bundler process,
bundler will save the path to the system bundler in BUNDLE_BIN_PATH, and
use it again when booting the "innermost" bundler process (`bundle exec
echo foo`).
That me... -
- https://github.com/bundler/bundler/commit/789dd1864f
-
- https://github.com/bundler/bundler/commit/e4cbb91b7d
-
- https://github.com/bundler/bundler/commit/fb587b9ebb
-
- https://github.com/bundler/bundler/commit/f9cb39e614
-
- https://github.com/bundler/bundler/commit/3995b3345d
- 04:44 AM Revision d80f5399 (git): [bundler/bundler] Fix open default gem error
- https://github.com/bundler/bundler/commit/792d724752
-
- So I can add another context that doesn't run the `before` block.
https://github.com/bundler/bundler/commit/06d0acc45a -
- https://github.com/bundler/bundler/commit/6678747fae
-
- Previously `bundle doctor` would fail on any bundle that does not
include git gems or plugins. This is because the previously used
`Bundler.home` does not exist unless the bundle includes git gems or
plugins. For example, with `bundle co... - 04:43 AM Revision a02dbcec (git): [bundler/bundler] Bundler displays a duplicate gem entries warning even if gems only appear once per group
- https://github.com/bundler/bundler/commit/d18a83109e
-
-
- ruby_2_6 r67742 merged revision(s) f91879a7b548284c93743168acfd11e3d2aeefac.
-
- handle_interrupt to defend monitor state [Bug #15992]
If an exception is raised from another thread for example Timeout
and this thread is just after `mon_exit`'s `@mon_owner = nil`,
the exception breaks the stat... -
-
- Like macos.yml, we don't need to ignore `make check` failure.
08/17/2019
-
- Indeed `eval` with an arbitrary `Binding` doesn't make a sense.
How about `eval` on a given object?
Currently, iseqs eval always on the top-level object without any argument, and I've needed code like:
```ruby
RubyVM::InstructionSe... -
-
-
-
- To reproduce this bug, type one character into irb, then press the
delete key on your keyboard. -
- The source of your problem seem to be the behavior below:
```ruby
p ' \1 '.bytes # => [32, 92, 49, 32]
p ' \\ '.bytes # => [32, 92, 32]
p ' \ '.bytes # => [32, 92, 32]
```
as you can see, two backslashes in a single quote string l... -
06:41 PM Bug #16108: gsub gives wrong results with regex backreferencing and triple backslash
- I have written a script to convert LaTeX indexing files (.idx) to Macrex backup format (.mbk), so that I can import LaTeX-embedded indexes into the Macrex indexing program. A problem arises when I try to convert bold text. LaTeX indicate...
-
- I have written a script to convert LaTeX indexing files (.idx) to Macrex backup format (.mbk), so that I can import LaTeX-embedded indexes into the Macrex indexing program. A problem arises when I try to convert bolded text. LaTeX indica...
-
04:07 PM Feature #9925: rsock_addrinfo uses DNS family AF_UNSPEC for lookup causing high IPv6 AAAA volume
- Thank you Craig! Since your patch was accepted, this ticket is now resolved for me. I'll also mark my Ruby Github PR as resolved by your PR.
-
-
-
-
- 03:33 PM Revision aa00f7b8 (git): * 2019-08-18 [ci skip]
-
- Installed path may contain symbolic links.
-
-
- Thanks to check this issue, so I think we don't need this change now. Please close this thicket.
-
- VM_DEBUG_MODE has been used only here.
-
-
-
-
-
-
-
- https://github.com/bundler/bundler/commit/71a29e286a
-
- https://github.com/bundler/bundler/commit/948a863bd8
-
- https://github.com/bundler/bundler/commit/a4beba4cbf
-
- https://github.com/bundler/bundler/commit/f20c2bdf6a
-
- https://github.com/bundler/bundler/commit/07161ebc1a
-
- https://github.com/bundler/bundler/commit/32520c7020
-
- https://github.com/bundler/bundler/commit/5b503a4bf1
-
- https://github.com/bundler/bundler/commit/91e7fe1b2f
-
- `FileUtils.rm` supports a `Pathname` argument.
https://github.com/bundler/bundler/commit/7d982a5be9 -
- They are implicit inside `gem_command!`.
https://github.com/bundler/bundler/commit/6bdb13c899 -
- https://github.com/bundler/bundler/commit/a4cca66b79
-
- https://github.com/bundler/bundler/commit/7888d621c8
-
- Since I plan to reuse it for something else.
https://github.com/bundler/bundler/commit/5379382198 -
- https://github.com/bundler/bundler/commit/096e53dfe6
-
- https://github.com/bundler/bundler/commit/028dc46f5a
-
- Otherwise I get conflicts when extracting the helper.
https://github.com/bundler/bundler/commit/314c64cd07 -
- https://github.com/bundler/bundler/commit/d35e31d2e0
-
- I want to extract these to path helper methods, but the name `files`
conflict with some builder methods that are also available at the same
level.
https://github.com/bundler/bundler/commit/7844096af0 -
- The `:bundler` gem is not needed in the regular repo either.
https://github.com/bundler/bundler/commit/ca5ce01a9b -
- The logic for choosing `gem_bin` should work here too even if it's not
identical.
https://github.com/bundler/bundler/commit/6ca0271b27 -
- For debuggability.
https://github.com/bundler/bundler/commit/ac3e8db658 -
- https://github.com/bundler/bundler/commit/8eedbecac0
-
- https://github.com/bundler/bundler/commit/37d5dedffe
-
- https://github.com/bundler/bundler/commit/17d4d0de8e
-
- https://github.com/bundler/bundler/commit/cae948f514
-
- https://github.com/bundler/bundler/commit/039604ff95
-
- https://github.com/bundler/bundler/commit/7985bb8e92
-
- https://github.com/bundler/bundler/commit/9437568ab4
-
- https://github.com/bundler/bundler/commit/79fdebd868
-
- https://github.com/bundler/bundler/commit/e483322519
-
- Use shared helper instead.
https://github.com/bundler/bundler/commit/ef55470cc6 -
- https://github.com/bundler/bundler/commit/f2df73bdb4
-
- https://github.com/bundler/bundler/commit/4589a57852
-
- https://github.com/bundler/bundler/commit/afdacd62ac
-
-
- This reverts commit 260ef51a73c067599826c8ab110c53994c1b6226.
This broke the stable versions of Ruby like 2.4 and 2.5 -
-
-
- The extension for require method with rubygems affects this test
case. We need to keep this test for the original method. -
-
-
-
- This reverts commit 75d29db8f965893bb6ab38b9008abc80cdda246e.
-
- * Standardize to load date libary code
> git grep 'require .date.' | wc -l
179
> ...
1
* Simplify -
- 05:24 AM Revision dce1e14e (git): Use more different arguments in Fiber.yield documentation to make it clear (#2170)
- https://github.com/ruby/ruby/pull/2170#issuecomment-489880700
Documentation is for those who don't know, remember, or understand (to any degree) the language, it should attempt to be clear above all other things. The example given is ne... - 05:17 AM Revision 28267cea (git): NetBSD native support of explicit_bzero's like feature (#2145)
-
-
-
-
04:01 AM Bug #10965: logger.rb may not daily rotate
- I do not well understand the problem. Indeed, the logger sees `@dev.stat.mtime`, but it is on only at `#initialize` https://github.com/ruby/logger/blob/4278b3e4ac1d2b2df555f7cde8813c452dc85f03/lib/logger/log_device.rb#L24-L27.
The con... -
-
- It looks the codes around specified are fairly changed from 1.9.3 now. This problem should already have been fixed.
Let me close once. If anyone finds same issue with the latest ruby, please let me know. -
-
- This is already fixed via https://github.com/ruby/ruby/pull/541
-
- [Bug #16107]
-
- Applied in changeset commit:git|11a9f7ab9431b0f361e43b4ac2bd6ee44827d88b.
----------
Search refinement module along nested usings
[Bug #16107] -
- [Bug #16107]
-
03:19 AM Revision 042be439 (git): Improve the doc example of `method_missing`
- Improvements are:
* Use `symbol` instead of `methId`, described in doc
* Add `*args` following method signature
* Rescue error in `roman_to_int` and calls `super`, recommended in doc
* Call invalid `foo` method to Roman object to raise N... -
01:54 AM Bug #16100: Visibility modifiers don't call super correctly when overridden in alternative ways
- Thanks for the explanation, Jeremy. I *think* I understand now. I took a look at the source and made another example to help me understand. I see now that the inconsistency only arises with the argument-less call of the visibility modifi...
-
- I think the changes to support the keyword to last positional hash are minimal. I'm testing a patch now that provides the following behavior:
```ruby
def a(a=1, b:2) [a, b] end;
a('a'=>1, :b=>3)
# 2.6: => [{"a"=>1}, 3]
# my bra... -
- jeremyevans0 (Jeremy Evans) wrote:
> jeremyevans0 (Jeremy Evans) wrote:
> ...
Okay, I'll talk with matz. And so quick rebase, thanks!
> Since this worked in 2.6, we probably want a warning and the same behavior, correct?
That'... -
- This is default: true
https://help.github.com/en/articles/workflow-syntax-for-github-actions#jobsjob_idstrategyfail-fast
When `make check` fails, we do not want to cancel `make test-bundler`. -
12:10 AM Bug #9115: Logger traps all exceptions; breaks Timeout
- > It makes sense for Logger to handle all exceptions by default
I'm not sure I agree with this. There must be some well-defined set of exceptions that could be raised by the code it's executing that should be handled/ignored, e.g. `IO...
08/16/2019
-
- This reverts commit 00cd5d74cecb6aa4a184e57e2b8246ef6e45d458.
-
- It used to be `Enumerator#sum`, now it's range of string which calls
`Enumerable#sum` and causes TypeError. -
- Caused by 00cd5d74ce
-
- jeremyevans0 (Jeremy Evans) wrote:
> I am in favor of the merge and eager to see matz's decision. I'll rebase my branch against master today to make it easier for people to comparison test.
I've rebased my branch against master: htt... -
- mame (Yusuke Endoh) wrote:
> > This Hash might contain numbers or strings as keys, and as such doesn't feel like "keywords arguments" to me.
> ...
I don't have a strong opinion about allowing non-Symbols for keyword hash keys.
With ... -
- Let me reboot the discussion. The problems and some proposals are described in the slides:
https://docs.google.com/presentation/d/16rReiCVzUog3s5vV702LzcIFM2LNcX53AX8m5K8uCZw/edit?usp=sharing
My understanding is that Jeremy's prop... -
- Sorry for leaving this ticket untouched.
Eregon (Benoit Daloze) wrote:
> With Jeremy's proposal, I think there is no need to support non-Symbol keywords.
> ...
Yes indeed, but in my opinion, the behavior is just for compatibility. ... - 10:49 PM Revision e0fc9b7c (git): * 2019-08-17 [ci skip]
-
- https://github.com/rubygems/rubygems/pull/1868 changes the behavior
of require when it used with -I options. Therefore, the options of
ruby repository was different from rubygems/rubygems. -
- https://github.com/rubygems/rubygems/commit/5924286ae2
-
- use ruby_exe in heredocs instead of ruby.exe
https://github.com/rubygems/rubygems/commit/9f1b7d6590 - 10:35 PM Revision 25a327d4 (git): [rubygems/rubygems] Do not mutate uri.query during s3 signature creation
- https://github.com/rubygems/rubygems/commit/c0275ee537
-
- https://github.com/rubygems/rubygems/commit/1133c2f700
-
- https://github.com/rubygems/rubygems/commit/8702f59d32
-
- https://github.com/rubygems/rubygems/commit/bb02953a97
-
- I think this should be more efficient?
https://github.com/rubygems/rubygems/commit/a1de78104f -
- https://github.com/rubygems/rubygems/commit/7964917bbc
-
- There's already a method called `suffix_pattern`, that's different from
this local variable. So, move the local variable to a `suffix_regexp`
that clearly differenciates from `suffix_pattern`.
https://github.com/rubygems/rubygems/commit... - 10:35 PM Revision 89ad5df9 (git): [rubygems/rubygems] Replace domain parameter in Gem::Command#show_lookup_failure with a parameter to suppress suggestions
- https://github.com/rubygems/rubygems/commit/760b7d834f
-
- https://github.com/rubygems/rubygems/commit/fc3f722164
-
- https://github.com/rubygems/rubygems/commit/41e60cdb6b
-
10:35 PM Revision 00cd5d74 (git): [rubygems/rubygems] [Require] Ensure -I beats a default gem
- https://github.com/rubygems/rubygems/commit/6fbda98eb3
-
- https://github.com/rubygems/rubygems/commit/a6375920bf
-
- For consistency with the other specs.
https://github.com/rubygems/rubygems/commit/44b93aec4c -
-
- It makes sense for Logger to handle all exceptions by default, as you don't want Logger breaking otherwise working code. So the default behavior is expected and not a bug.
I think the best way to handle this is to allow the user to s... -
-
- https://github.com/ruby/ruby/pull/2373
-
01:25 PM Bug #16107: Module#refine and Module#using behaved unexpectedly
- (FYI) It works if you `using M1` it in `refine A` .
```ruby
class A
end
module M1
refine A do
def foo
puts "foo"
end
end
end
module M2
refine A do
using M1
# OK
A.new.foo
end
end... -
- I shortened the example a little.
```ruby
class A
end
module M1
refine A do
def foo
puts "foo"
end
end
end
module M2
using M1
refine A do
A.new.foo
end
end
```
It seems that a `refine... -
08:34 AM Bug #16107 (Closed): Module#refine and Module#using behaved unexpectedly
- The issue happened when I tried to run the code below:
``` ruby
# Main.rb
class A
end
class B
end
module M1
refine A do
def foo *args
puts "foo"
end
end
end
using M1
module M2
def self.enable_foo
refin... -
02:39 PM Feature #12093: Eval InstructionSequence with binding
- Understood, I’ve closed the pull request.
-
- Ok. I reject this ticket, and pls remake your proposal if you find a good way.
-
- Yes when I test out Koichi's sample, the iseq look like:
```
disasm: #<ISeq:<compiled>@<compiled>:1 (1,0)-(1,6)> (catch: FALSE)
0000 putself ( 1)[Li]
0001 opt_send_without_... -
- What the last line should output?
```ruby
def a; :m_a end
def b; :m_b end
def bind
a = :l_a
b = :l_b
binding
end
eval('p [a, b]', bind())
#=> [:l_a, :l_b]
RubyVM::InstructionSequence.compile("p [a, b]").eval
#=> [... -
- instead of dumping obj to a string and then saving the string.
It omits object creation. -
-
- https://github.com/ruby/rdoc/commit/f2c63549f7
-
07:29 AM Feature #14784: Comparable#clamp with a range
- Here's a real life use case for `clamp` with Range support:
Our Rails app has quite a few app settings which define ranges of permitted values e.g. `goal_range = (10..1000)`. Values outside of those ranges are clamped which leads to t... -
- This reverts commit b8d759806ff825e1b9344ba34b1a2bc4809d0988.
It's accidentally picked from the upstream repository. -
- https://github.com/bundler/bundler/commit/1a0161b970
-
- https://github.com/bundler/bundler/commit/9256177446
-
- And instead educate users on the preferred, non deprecated, way.
https://github.com/bundler/bundler/commit/9cd6238da2 - 05:30 AM Revision 502ad4d3 (git): [bundler/bundler] Document upcoming changes to remembered options
- https://github.com/bundler/bundler/commit/a1c97fd7c3
-
05:30 AM Revision 3b61019a (git): [bundler/bundler] Add initial Bundler::BuildMetadata Spec
- https://github.com/bundler/bundler/commit/c6458b2727
-
- I think using `--no-git` can be useful when creating gems inside
monorepos.
https://github.com/bundler/bundler/commit/154c687310 -
- https://github.com/bundler/bundler/commit/0b6d973543
-
- This has the benefit that:
* Allows the installation of bundler as a default gem from rubygems to
include man pages.
* Removes the need to build man pages during our tests.
* Makes working with the manifest easier, because we only have ... -
- Since we no longer use `git` to find out the list of files, the comment
is misleading.
https://github.com/bundler/bundler/commit/54d85d5349 -
- Previously under some circunstances (met during some specs), bundler
would print deprecations to a separate UI different from "bundler's UI".
This UI would not be captured by the specs, and thus would be printed to
screen during the spec... -
- So that the examples work in currently supported rubies.
https://github.com/bundler/bundler/commit/b7d4556cde -
- https://github.com/bundler/bundler/commit/8601575490
- 05:30 AM Revision 6412121b (git): [bundler/bundler] Fix typo in comment: attibutes -> attributes
- https://github.com/bundler/bundler/commit/876545805e
-
- Because we're using `config.bisect_runner` which is only available from
3.8.
https://github.com/bundler/bundler/commit/304a187f72 -
- This reverts commit e63e844bc7444c6a489fcde0dc7011c6c4807edd.
It was introduced to resolve some failing tests at the cost of making
the intention of the spec much less clear.
Thanks to the previous fixes we have added to this spec, we ... -
- https://github.com/bundler/bundler/commit/2ed2bbfdec
-
- Previously it was being installed to the :bundle_path
(`/tmp/bundled_app/.bundle`), but the `bundle` helper uses the
`system_gem_path("bin/bundle")`. That means the first `bundle install`in
the spec was actually failing, but not affectin... -
- https://github.com/bundler/bundler/commit/6013c93e81
-
- https://github.com/bundler/bundler/commit/b2abde04aa
-
- https://github.com/bundler/bundler/commit/09ecaf04fa
-
- https://github.com/bundler/bundler/commit/f11c9a2b3f
-
- Previously, if bundler-2.1.0.pre.1 would be installed globally, it would
fail. Now we force that a locally installed version of bundler is used,
so it always passed regardless of which bundler is installed globally.
https://github.com/b... -
- https://github.com/bundler/bundler/commit/c189dfdde0
-
- https://github.com/bundler/bundler/commit/da360659f7
-
- * RUBY_ENGINE and RUBY_ENGINE_VERSION are defined on every modern Ruby.
* There is no such constant as TRUFFLERUBY_VERSION or RBX_VERSION.
https://github.com/bundler/bundler/commit/f9d910403b -
- When Gemfile would specify path sources as relative paths starting with
"./", the lockfile would have inconsistent order on `bundle install` and
`bundle update`.
https://github.com/bundler/bundler/commit/c7532ced89 -
- https://github.com/bundler/bundler/commit/5978a88f33
-
- https://github.com/bundler/bundler/commit/42363091da
-
- The code creates a lot of useless objects.
Instead, using a regexp is shorter and faster. -
-
-
12:57 AM Bug #16106: UnboundMethod owner points to base class
- Indeed, that's why I was surprised. I wasn't expecting `owner` to be a pointer to a class that I wasn't working with.
To correct the code I was working on, I now pass around both the UnboundMethod instance as well as the class, and ig...