Activity
From 08/12/2019 to 08/18/2019
08/18/2019
-
08:09 PM Bug #16110 (Closed): Doesn't detect deadlock on Ruby 2.4 and 2.5 on Windows
- The following code is detected as a deadlock, except in Ruby 2.4 and 2.5 on Windows:
``` sh
ruby -r thread -ve 'Thread.new { Queue.new.shift }.join'
```
You can see it run in this code: https://github.com/JoshCheek/childprocess_e... -
06:40 PM Revision c100e385 (git): Workaround errors on multi-line commit message
- by using toJson with fields.
-
- for macOS / Windows as well.
Docker-based GitHub Action does not work on these OSes. - 04:50 PM Revision aa5fbb5a (git): * 2019-08-19 [ci skip]
-
-
- This reverts commit d8807e8b1a9d09ee1543e18618b4ef7e8203c616.
We'd need more features. Reverting to customize this later. -
- https://github.com/8398a7/action-slack
https://github.com/marketplace/actions/action-slack -
- Yeah, I personally like vX.Y.Z rather than vX_Y_Z too, especially because it's closer to what `rake release` does by default.
However, newer tags are also tagged as vX_Y_Z, and renaming the new tags would be disruptive unlike renaming... -
10:43 AM Misc #16109: Normalize legacy tag names
- Sorry for the off-track comment from me - quite an epic task. :)
It would be kind of cool if we'd have not only a "time travel" history of all
of ruby in general, including the very old ruby releases by matz (like in the
1990s or so... -
- There are tags with inconsistent names. To browse the history more easily, I propose the following normalization.
**Before and after the renames, I'm going to record `git ls-remote` in this ticket. By doing so, we'd be able to revert t... -
- to clarify what's running for every commit.
-
09:08 AM Revision 51edcbad (git): Use master branch instead of trunk.
-
-
07:22 AM Bug #16105: heap-use-after-free in String#sub!
- ruby_2_6 r67747 merged revision(s) d5c33364e3c0efb15e11df417c925afee2cdb9c9.
-
- Fixed heap-use-after-free
* string.c (rb_str_sub_bang): retrieves a pointer to the
replacement string buffer just before using it, for the case of
replacement with the receiver string itself. [Bug #16105]
g... -
- Closing https://github.com/ruby/ruby/pull/1998#issuecomment-437700528
-
- Closing as requested at https://github.com/ruby/ruby/pull/1998#issuecomment-437700528
-
- ruby_2_6 r67746 merged revision(s) 5b1bf8dd2d08ae7371ecf025967376bb794ed651.
-
- UTF LE is fixed at least the first 2 bytes
* io.c (io_strip_bom): if the first 2 bytes are 0xFF0xFE, it
should be a little-endian UTF, 16 or 32. [Bug #16099]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_... -
- for consistency. In the pull request, `before_test` was dropped only for
msys2 to fix msys2-only failure. But there's no need to keep it
inconsistent now. -
06:47 AM Revision cba8166c (git): Appveyor - vc120 use OpenSSL 1.0.2, vc140 use 1.1.1 (#1998)
- * appveyor.yml - OpenSSL vc120 -> 1.0.2, vc140 -> 1.1.1
* Try just using build_script -
06:39 AM Revision 6b42b0c6 (git): Fix document of `GC.start` (#2382)
-
- ruby_2_6 r67745 merged revision(s) 5d33f787169bcc3594d2264726695d58c4a06899,8b162ce9d1003e4e469d8f48cb9a2076fd45b47c.
-
- fix tracepoint + backtrace SEGV
PC modification in gc_event_hook_body was careless. There are (so
to say) abnormal iseqs stored in the cfp. We have to check sanity
before we touch the PC.
This has not ... -
-
- ruby_2_6 r67744 merged revision(s) df317151a5b4e0c5a30fcc321a9dc6abad63f7ed.
-
- should not free local hook_list here.
exec_hooks_postcheck() clean executed hook_list if it is needed.
list_exec is freed if there are no events and this list is local
event (connected to specific iseq). However,... -
05:17 AM Feature #10098: [PATCH] Timing-safe string comparison for OpenSSL::HMAC
- New patch over at https://github.com/ruby/openssl/pull/269
-
- ruby_2_6 r67743 merged revision(s) f1b76ea63ce40670071a857f408a4747c571f1e9,1d1f98d49c9908f4e3928e582d31fd2e9f252f92.
-
- Occupy match data
* string.c (rb_str_split_m): occupy match data not to be modified
during yielding the block. [Bug #16024]
Reuse match data
* string.c (rb_str_split_m): reuse occupied match data. [... -
04:45 AM Revision a77b3b44 (git): [bundler/bundler] Remove unnecessary require
- https://github.com/bundler/bundler/commit/8ef571ed4e
-
- The version we're vendoring actually relaxed this restriction back to
2.3.0+, so we can always use the vendored version.
https://github.com/bundler/bundler/commit/d366cbfe5d -
- Instead, make sure we always load the local copy of bundler during
specs, and never end up using the default copy.
https://github.com/bundler/bundler/commit/ac655ffeda -
- If we use system bundler, when booting the "outermost" bundler process,
bundler will save the path to the system bundler in BUNDLE_BIN_PATH, and
use it again when booting the "innermost" bundler process (`bundle exec
echo foo`).
That me... -
- https://github.com/bundler/bundler/commit/789dd1864f
-
- https://github.com/bundler/bundler/commit/e4cbb91b7d
-
- https://github.com/bundler/bundler/commit/fb587b9ebb
-
- https://github.com/bundler/bundler/commit/f9cb39e614
-
- https://github.com/bundler/bundler/commit/3995b3345d
- 04:44 AM Revision d80f5399 (git): [bundler/bundler] Fix open default gem error
- https://github.com/bundler/bundler/commit/792d724752
-
- So I can add another context that doesn't run the `before` block.
https://github.com/bundler/bundler/commit/06d0acc45a -
- https://github.com/bundler/bundler/commit/6678747fae
-
- Previously `bundle doctor` would fail on any bundle that does not
include git gems or plugins. This is because the previously used
`Bundler.home` does not exist unless the bundle includes git gems or
plugins. For example, with `bundle co... - 04:43 AM Revision a02dbcec (git): [bundler/bundler] Bundler displays a duplicate gem entries warning even if gems only appear once per group
- https://github.com/bundler/bundler/commit/d18a83109e
-
04:40 AM Feature #9925 (Closed): rsock_addrinfo uses DNS family AF_UNSPEC for lookup causing high IPv6 AAAA volume
-
- ruby_2_6 r67742 merged revision(s) f91879a7b548284c93743168acfd11e3d2aeefac.
-
- handle_interrupt to defend monitor state [Bug #15992]
If an exception is raised from another thread for example Timeout
and this thread is just after `mon_exit`'s `@mon_owner = nil`,
the exception breaks the stat... -
-
- Like macos.yml, we don't need to ignore `make check` failure.
08/17/2019
-
11:49 PM Feature #12093: Eval InstructionSequence with binding
- Indeed `eval` with an arbitrary `Binding` doesn't make a sense.
How about `eval` on a given object?
Currently, iseqs eval always on the top-level object without any argument, and I've needed code like:
```ruby
RubyVM::InstructionSe... -
11:05 PM Revision 50623f3d (git): Remove commented out debug print
-
-
-
10:43 PM Revision e9f82585 (git): Don't crash when deleting at the end of the line
- To reproduce this bug, type one character into irb, then press the
delete key on your keyboard. -
- The source of your problem seem to be the behavior below:
```ruby
p ' \1 '.bytes # => [32, 92, 49, 32]
p ' \\ '.bytes # => [32, 92, 32]
p ' \ '.bytes # => [32, 92, 32]
```
as you can see, two backslashes in a single quote string l... -
06:41 PM Bug #16108: gsub gives wrong results with regex backreferencing and triple backslash
- I have written a script to convert LaTeX indexing files (.idx) to Macrex backup format (.mbk), so that I can import LaTeX-embedded indexes into the Macrex indexing program. A problem arises when I try to convert bold text. LaTeX indicate...
-
- I have written a script to convert LaTeX indexing files (.idx) to Macrex backup format (.mbk), so that I can import LaTeX-embedded indexes into the Macrex indexing program. A problem arises when I try to convert bolded text. LaTeX indica...
-
04:07 PM Feature #9925: rsock_addrinfo uses DNS family AF_UNSPEC for lookup causing high IPv6 AAAA volume
- Thank you Craig! Since your patch was accepted, this ticket is now resolved for me. I'll also mark my Ruby Github PR as resolved by your PR.
-
-
-
-
- 03:33 PM Revision aa00f7b8 (git): * 2019-08-18 [ci skip]
-
- Installed path may contain symbolic links.
-
-
02:19 PM Feature #11554: Privatize {Single}Forwardable API
- Thanks to check this issue, so I think we don't need this change now. Please close this thicket.
-
- VM_DEBUG_MODE has been used only here.
-
-
-
-
-
-
-
- https://github.com/bundler/bundler/commit/71a29e286a
-
- https://github.com/bundler/bundler/commit/948a863bd8
-
- https://github.com/bundler/bundler/commit/a4beba4cbf
-
- https://github.com/bundler/bundler/commit/f20c2bdf6a
-
- https://github.com/bundler/bundler/commit/07161ebc1a
-
- https://github.com/bundler/bundler/commit/32520c7020
-
- https://github.com/bundler/bundler/commit/5b503a4bf1
-
- https://github.com/bundler/bundler/commit/91e7fe1b2f
-
- `FileUtils.rm` supports a `Pathname` argument.
https://github.com/bundler/bundler/commit/7d982a5be9 -
- They are implicit inside `gem_command!`.
https://github.com/bundler/bundler/commit/6bdb13c899 -
- https://github.com/bundler/bundler/commit/a4cca66b79
-
- https://github.com/bundler/bundler/commit/7888d621c8
-
- Since I plan to reuse it for something else.
https://github.com/bundler/bundler/commit/5379382198 -
- https://github.com/bundler/bundler/commit/096e53dfe6
-
- https://github.com/bundler/bundler/commit/028dc46f5a
-
- Otherwise I get conflicts when extracting the helper.
https://github.com/bundler/bundler/commit/314c64cd07 -
- https://github.com/bundler/bundler/commit/d35e31d2e0
-
- I want to extract these to path helper methods, but the name `files`
conflict with some builder methods that are also available at the same
level.
https://github.com/bundler/bundler/commit/7844096af0 -
- The `:bundler` gem is not needed in the regular repo either.
https://github.com/bundler/bundler/commit/ca5ce01a9b -
- The logic for choosing `gem_bin` should work here too even if it's not
identical.
https://github.com/bundler/bundler/commit/6ca0271b27 -
- For debuggability.
https://github.com/bundler/bundler/commit/ac3e8db658 -
- https://github.com/bundler/bundler/commit/8eedbecac0
-
- https://github.com/bundler/bundler/commit/37d5dedffe
-
- https://github.com/bundler/bundler/commit/17d4d0de8e
-
- https://github.com/bundler/bundler/commit/cae948f514
-
- https://github.com/bundler/bundler/commit/039604ff95
-
- https://github.com/bundler/bundler/commit/7985bb8e92
-
- https://github.com/bundler/bundler/commit/9437568ab4
-
- https://github.com/bundler/bundler/commit/79fdebd868
-
- https://github.com/bundler/bundler/commit/e483322519
-
- Use shared helper instead.
https://github.com/bundler/bundler/commit/ef55470cc6 -
- https://github.com/bundler/bundler/commit/f2df73bdb4
-
- https://github.com/bundler/bundler/commit/4589a57852
-
- https://github.com/bundler/bundler/commit/afdacd62ac
-
-
- This reverts commit 260ef51a73c067599826c8ab110c53994c1b6226.
This broke the stable versions of Ruby like 2.4 and 2.5 -
-
-
- The extension for require method with rubygems affects this test
case. We need to keep this test for the original method. -
-
-
-
- This reverts commit 75d29db8f965893bb6ab38b9008abc80cdda246e.
-
- * Standardize to load date libary code
> git grep 'require .date.' | wc -l
179
> ...
1
* Simplify -
- 05:24 AM Revision dce1e14e (git): Use more different arguments in Fiber.yield documentation to make it clear (#2170)
- https://github.com/ruby/ruby/pull/2170#issuecomment-489880700
Documentation is for those who don't know, remember, or understand (to any degree) the language, it should attempt to be clear above all other things. The example given is ne... - 05:17 AM Revision 28267cea (git): NetBSD native support of explicit_bzero's like feature (#2145)
-
04:57 AM Revision ccbfb054 (git): Fix typos
-
-
-
04:01 AM Bug #10965: logger.rb may not daily rotate
- I do not well understand the problem. Indeed, the logger sees `@dev.stat.mtime`, but it is on only at `#initialize` https://github.com/ruby/logger/blob/4278b3e4ac1d2b2df555f7cde8813c452dc85f03/lib/logger/log_device.rb#L24-L27.
The con... -
-
- It looks the codes around specified are fairly changed from 1.9.3 now. This problem should already have been fixed.
Let me close once. If anyone finds same issue with the latest ruby, please let me know. -
-
- This is already fixed via https://github.com/ruby/ruby/pull/541
-
- [Bug #16107]
-
- Applied in changeset commit:git|11a9f7ab9431b0f361e43b4ac2bd6ee44827d88b.
----------
Search refinement module along nested usings
[Bug #16107] -
- [Bug #16107]
-
03:19 AM Revision 042be439 (git): Improve the doc example of `method_missing`
- Improvements are:
* Use `symbol` instead of `methId`, described in doc
* Add `*args` following method signature
* Rescue error in `roman_to_int` and calls `super`, recommended in doc
* Call invalid `foo` method to Roman object to raise N... -
01:54 AM Bug #16100: Visibility modifiers don't call super correctly when overridden in alternative ways
- Thanks for the explanation, Jeremy. I *think* I understand now. I took a look at the source and made another example to help me understand. I see now that the inconsistency only arises with the argument-less call of the visibility modifi...
-
- I think the changes to support the keyword to last positional hash are minimal. I'm testing a patch now that provides the following behavior:
```ruby
def a(a=1, b:2) [a, b] end;
a('a'=>1, :b=>3)
# 2.6: => [{"a"=>1}, 3]
# my bra... -
12:33 AM Feature #14183: "Real" keyword argument
- jeremyevans0 (Jeremy Evans) wrote:
> jeremyevans0 (Jeremy Evans) wrote:
> ...
Okay, I'll talk with matz. And so quick rebase, thanks!
> Since this worked in 2.6, we probably want a warning and the same behavior, correct?
That'... -
- This is default: true
https://help.github.com/en/articles/workflow-syntax-for-github-actions#jobsjob_idstrategyfail-fast
When `make check` fails, we do not want to cancel `make test-bundler`. -
12:10 AM Bug #9115: Logger traps all exceptions; breaks Timeout
- > It makes sense for Logger to handle all exceptions by default
I'm not sure I agree with this. There must be some well-defined set of exceptions that could be raised by the code it's executing that should be handled/ignored, e.g. `IO...
08/16/2019
-
- This reverts commit 00cd5d74cecb6aa4a184e57e2b8246ef6e45d458.
-
- It used to be `Enumerator#sum`, now it's range of string which calls
`Enumerable#sum` and causes TypeError. -
- Caused by 00cd5d74ce
-
- jeremyevans0 (Jeremy Evans) wrote:
> I am in favor of the merge and eager to see matz's decision. I'll rebase my branch against master today to make it easier for people to comparison test.
I've rebased my branch against master: htt... -
- mame (Yusuke Endoh) wrote:
> > This Hash might contain numbers or strings as keys, and as such doesn't feel like "keywords arguments" to me.
> ...
I don't have a strong opinion about allowing non-Symbols for keyword hash keys.
With ... -
- Let me reboot the discussion. The problems and some proposals are described in the slides:
https://docs.google.com/presentation/d/16rReiCVzUog3s5vV702LzcIFM2LNcX53AX8m5K8uCZw/edit?usp=sharing
My understanding is that Jeremy's prop... -
- Sorry for leaving this ticket untouched.
Eregon (Benoit Daloze) wrote:
> With Jeremy's proposal, I think there is no need to support non-Symbol keywords.
> ...
Yes indeed, but in my opinion, the behavior is just for compatibility. ... - 10:49 PM Revision e0fc9b7c (git): * 2019-08-17 [ci skip]
-
- https://github.com/rubygems/rubygems/pull/1868 changes the behavior
of require when it used with -I options. Therefore, the options of
ruby repository was different from rubygems/rubygems. -
- https://github.com/rubygems/rubygems/commit/5924286ae2
-
- use ruby_exe in heredocs instead of ruby.exe
https://github.com/rubygems/rubygems/commit/9f1b7d6590 - 10:35 PM Revision 25a327d4 (git): [rubygems/rubygems] Do not mutate uri.query during s3 signature creation
- https://github.com/rubygems/rubygems/commit/c0275ee537
-
- https://github.com/rubygems/rubygems/commit/1133c2f700
-
- https://github.com/rubygems/rubygems/commit/8702f59d32
-
- https://github.com/rubygems/rubygems/commit/bb02953a97
-
- I think this should be more efficient?
https://github.com/rubygems/rubygems/commit/a1de78104f -
- https://github.com/rubygems/rubygems/commit/7964917bbc
-
- There's already a method called `suffix_pattern`, that's different from
this local variable. So, move the local variable to a `suffix_regexp`
that clearly differenciates from `suffix_pattern`.
https://github.com/rubygems/rubygems/commit... - 10:35 PM Revision 89ad5df9 (git): [rubygems/rubygems] Replace domain parameter in Gem::Command#show_lookup_failure with a parameter to suppress suggestions
- https://github.com/rubygems/rubygems/commit/760b7d834f
-
- https://github.com/rubygems/rubygems/commit/fc3f722164
-
- https://github.com/rubygems/rubygems/commit/41e60cdb6b
-
10:35 PM Revision 00cd5d74 (git): [rubygems/rubygems] [Require] Ensure -I beats a default gem
- https://github.com/rubygems/rubygems/commit/6fbda98eb3
-
- https://github.com/rubygems/rubygems/commit/a6375920bf
-
- For consistency with the other specs.
https://github.com/rubygems/rubygems/commit/44b93aec4c -
-
- It makes sense for Logger to handle all exceptions by default, as you don't want Logger breaking otherwise working code. So the default behavior is expected and not a bug.
I think the best way to handle this is to allow the user to s... -
-
- https://github.com/ruby/ruby/pull/2373
-
01:25 PM Bug #16107: Module#refine and Module#using behaved unexpectedly
- (FYI) It works if you `using M1` it in `refine A` .
```ruby
class A
end
module M1
refine A do
def foo
puts "foo"
end
end
end
module M2
refine A do
using M1
# OK
A.new.foo
end
end... -
- I shortened the example a little.
```ruby
class A
end
module M1
refine A do
def foo
puts "foo"
end
end
end
module M2
using M1
refine A do
A.new.foo
end
end
```
It seems that a `refine... -
08:34 AM Bug #16107 (Closed): Module#refine and Module#using behaved unexpectedly
- The issue happened when I tried to run the code below:
``` ruby
# Main.rb
class A
end
class B
end
module M1
refine A do
def foo *args
puts "foo"
end
end
end
using M1
module M2
def self.enable_foo
refin... -
02:39 PM Feature #12093: Eval InstructionSequence with binding
- Understood, I’ve closed the pull request.
-
12:53 PM Feature #12093 (Rejected): Eval InstructionSequence with binding
- Ok. I reject this ticket, and pls remake your proposal if you find a good way.
-
- Yes when I test out Koichi's sample, the iseq look like:
```
disasm: #<ISeq:<compiled>@<compiled>:1 (1,0)-(1,6)> (catch: FALSE)
0000 putself ( 1)[Li]
0001 opt_send_without_... -
- What the last line should output?
```ruby
def a; :m_a end
def b; :m_b end
def bind
a = :l_a
b = :l_b
binding
end
eval('p [a, b]', bind())
#=> [:l_a, :l_b]
RubyVM::InstructionSequence.compile("p [a, b]").eval
#=> [... -
- instead of dumping obj to a string and then saving the string.
It omits object creation. -
-
- https://github.com/ruby/rdoc/commit/f2c63549f7
-
07:29 AM Feature #14784: Comparable#clamp with a range
- Here's a real life use case for `clamp` with Range support:
Our Rails app has quite a few app settings which define ranges of permitted values e.g. `goal_range = (10..1000)`. Values outside of those ranges are clamped which leads to t... -
- This reverts commit b8d759806ff825e1b9344ba34b1a2bc4809d0988.
It's accidentally picked from the upstream repository. -
- https://github.com/bundler/bundler/commit/1a0161b970
-
- https://github.com/bundler/bundler/commit/9256177446
-
- And instead educate users on the preferred, non deprecated, way.
https://github.com/bundler/bundler/commit/9cd6238da2 - 05:30 AM Revision 502ad4d3 (git): [bundler/bundler] Document upcoming changes to remembered options
- https://github.com/bundler/bundler/commit/a1c97fd7c3
-
05:30 AM Revision 3b61019a (git): [bundler/bundler] Add initial Bundler::BuildMetadata Spec
- https://github.com/bundler/bundler/commit/c6458b2727
-
- I think using `--no-git` can be useful when creating gems inside
monorepos.
https://github.com/bundler/bundler/commit/154c687310 -
- https://github.com/bundler/bundler/commit/0b6d973543
-
- This has the benefit that:
* Allows the installation of bundler as a default gem from rubygems to
include man pages.
* Removes the need to build man pages during our tests.
* Makes working with the manifest easier, because we only have ... -
- Since we no longer use `git` to find out the list of files, the comment
is misleading.
https://github.com/bundler/bundler/commit/54d85d5349 -
- Previously under some circunstances (met during some specs), bundler
would print deprecations to a separate UI different from "bundler's UI".
This UI would not be captured by the specs, and thus would be printed to
screen during the spec... -
- So that the examples work in currently supported rubies.
https://github.com/bundler/bundler/commit/b7d4556cde -
- https://github.com/bundler/bundler/commit/8601575490
- 05:30 AM Revision 6412121b (git): [bundler/bundler] Fix typo in comment: attibutes -> attributes
- https://github.com/bundler/bundler/commit/876545805e
-
- Because we're using `config.bisect_runner` which is only available from
3.8.
https://github.com/bundler/bundler/commit/304a187f72 -
- This reverts commit e63e844bc7444c6a489fcde0dc7011c6c4807edd.
It was introduced to resolve some failing tests at the cost of making
the intention of the spec much less clear.
Thanks to the previous fixes we have added to this spec, we ... -
- https://github.com/bundler/bundler/commit/2ed2bbfdec
-
- Previously it was being installed to the :bundle_path
(`/tmp/bundled_app/.bundle`), but the `bundle` helper uses the
`system_gem_path("bin/bundle")`. That means the first `bundle install`in
the spec was actually failing, but not affectin... -
- https://github.com/bundler/bundler/commit/6013c93e81
-
- https://github.com/bundler/bundler/commit/b2abde04aa
-
- https://github.com/bundler/bundler/commit/09ecaf04fa
-
- https://github.com/bundler/bundler/commit/f11c9a2b3f
-
- Previously, if bundler-2.1.0.pre.1 would be installed globally, it would
fail. Now we force that a locally installed version of bundler is used,
so it always passed regardless of which bundler is installed globally.
https://github.com/b... -
- https://github.com/bundler/bundler/commit/c189dfdde0
-
- https://github.com/bundler/bundler/commit/da360659f7
-
05:30 AM Revision 2b0f3aa0 (git): [bundler/bundler] Use the standard RUBY_ENGINE_VERSION instead of JRUBY_VERSION
- * RUBY_ENGINE and RUBY_ENGINE_VERSION are defined on every modern Ruby.
* There is no such constant as TRUFFLERUBY_VERSION or RBX_VERSION.
https://github.com/bundler/bundler/commit/f9d910403b -
- When Gemfile would specify path sources as relative paths starting with
"./", the lockfile would have inconsistent order on `bundle install` and
`bundle update`.
https://github.com/bundler/bundler/commit/c7532ced89 -
- https://github.com/bundler/bundler/commit/5978a88f33
-
- https://github.com/bundler/bundler/commit/42363091da
-
- The code creates a lot of useless objects.
Instead, using a regexp is shorter and faster. -
-
-
12:57 AM Bug #16106: UnboundMethod owner points to base class
- Indeed, that's why I was surprised. I wasn't expecting `owner` to be a pointer to a class that I wasn't working with.
To correct the code I was working on, I now pass around both the UnboundMethod instance as well as the class, and ig...
08/15/2019
-
- Starting in Ruby 2.3, you can do this:
```ruby
begin
instance = klass.new
puts "#inspect output: #{instance.inspect} (#{instance.inspect.length} chars)"
instance.undefined_method
rescue NoMethodError => e
puts "undefined method ... -
- I guess the documentation could mention that behaviour so that other
rubyists won't be confused, as alanwu pointed out e. g:
https://ruby-doc.org/core/UnboundMethod.html#method-i-owner
(Or the other documentation site; I just happ... -
- Yes, this behavior is expected. Changing it would not be backwards compatible.
I think owner in this case means the entity under which the method is originally defined.
Perhaps the documentation can be improved to reflect this. -
- This may not be a bug. It may be my misinterpretation of the feature.
When using UnboundMethod#owner on a class that was created with `Class.new(SomeBaseClass)`, the owner is reported as the `SomeBaseClass `rather than the new class.
... -
- From my testing, this was fixed between Ruby 2.2 and 2.3. Starting with Ruby 2.3, instead of segfaulting, I get:
```
t.rb:5:in `<main>': index 268435456 too big (IndexError)
``` -
-
- This bug is still present in the master branch. I've submitted a pull request to fix it: https://github.com/ruby/forwardable/pull/4
-
-
-
- The full scan of the C source code (`@content.scan`) is very slow.
The old code invokes the scan six times in `do_classes` and
`do_modules`.
This change integrates the six scans into one by merging the regexps.
The integrated regexp is ... -
-
-
-
-
-
-
-
-
- Gem::Specification.default_specifications_dir is deprecated.
-
-
-
- Minitest 6 will err `assert_equal` with `nil`.
https://github.com/seattlerb/minitest/issues/779 -
-
- The old version of `add_tokens` accepts an array of tokens, and
multiple arguments of tokens by using `Array#flatten`.
And `add_token` was an alias to `add_tokens`.
I think it is unnecessarily flexible; in fact, all callsites of
`add_to... -
- This change introduces a wrapper of StringScanner that is aware of the
current position (column and lineno).
It has two advantages: faster and more modular.
The old code frequently runs `@input.byteslice(0, byte_offset).length`
to get t... -
09:02 PM Revision 9d2fed2c (git): Don't echo results of assignment expressions
-
- I think this was fixed by commit:711ece42cddc4737a4b1667b1f20ca74030d0255.
-
- As bigdecimal upstream is in a separate repository, I submitted a pull request for this: https://github.com/ruby/bigdecimal/pull/150.
-
-
- I tried using `gets` with a string with 300 characters on Windows 10, and was not able to reproduce the error (no string truncation). I tried with various versions of Ruby as far back as 1.9.3. I'm not sure if this is still a problem o...
-
- I've added a pull request to add tests for read_smime and write_smime: https://github.com/ruby/openssl/pull/268
-
- When we use `define_method` and `define_singleton_method`,
if we supply block parameters to a block then a generated
method has corresponding parameters.
However, the doc doesn't mention it, so this info has been added. -
-
- after `make update-github`
-
04:38 PM Revision 2665e585 (git): Adding missing test for Net::HTTPGenericRequest initializer (#1835)
- A new exception is raised if an URI::HTTP is received and that object doesn't
have a hostname property.
Complementary to #1278 -
- after doing it once.
-
-
- by directly passing it to Ruby without passing a shell.
Formerly it was broken when $(PULL_REQUEST) included quotes. -
03:42 PM Revision 7c46aa69 (git): Avoid confusion in Array#- and Array#difference docs (#2070)
- My previous attempt to correct #2068 apparently failed and the confusing
wording ("instances") was merged into trunk instead.
This should address any potential confusion. -
- I believe this is not a bug, it is expected behavior. Class variable lookup for singleton classes is different from regular classes. Class variable lookup for singleton classes is (with example class A):
* Singleton Class (A.singlet... -
- 03:20 PM Revision d2070f2e (git): Fix doc in Object#respond_to_missing? (#2239)
- 03:02 PM Revision 715218c4 (git): * 2019-08-16 [ci skip]
-
-
-
- Applied in changeset commit:git|d5c33364e3c0efb15e11df417c925afee2cdb9c9.
----------
Fixed heap-use-after-free
* string.c (rb_str_sub_bang): retrieves a pointer to the
replacement string buffer just before using it, for the case of
... -
- * string.c (rb_str_sub_bang): retrieves a pointer to the
replacement string buffer just before using it, for the case of
replacement with the receiver string itself. [Bug #16105] -
-
-
06:54 AM Feature #16104: Introduce merge_if and merge_if!
- akash (Akash Gupta) wrote:
> The method `merge_if` / `merge_if!` will merge the passed hash in parameter only if the block evaluates to true, otherwise not. Similar to `count` method with a block.
What if the callee has more than one... -
- There is no comment so I pushed this change.
-
- Applied in changeset commit:git|53a55aeff3d409b4894d077f2b3b874fac53e387.
----------
introduce RUBY_ON_BUG envval. (#2331)
`rb_bug()` is called at critical bug, MRI can't run anymore.
To make debug easy, this patch introduces RUBY_ON_B... -
- `rb_bug()` is called at critical bug, MRI can't run anymore.
To make debug easy, this patch introduces RUBY_ON_BUG environment
variable to specify the process which is called with pid.
[Feature #16090] [GH #2331]
RUBY_ON_BUG='gdb -p' ... -
- I also think the `0001-Fallback-to-localhost-if-hostname-is-not-associated-.patch` is a bad approach. We should not force localhost if the hostname given is not associated with an IP address. That sounds like a issue that should be rep...
-
- I think this issue is now solved by beginless and endless ranges.
-
- I don't think this is a bug. `WEBrick::HTTPResponse.header` is a hash, but the values are arrays. So if a request comes in with multiple `WWW-Authenticate` headers, `header['www-authenticate']` should contain an array of all `WWW-Authe...
-
- It looks like this issue was fixed between Ruby 2.4 and 2.5:
```
$ ruby24 -rnet/http -e "p Net::HTTP.start('www.falcom.co.jp', 443, :use_ssl=>true){|http| http.request_get('/'){|res| res.read_body{|c| p c.bytesize; c.force_encoding ...
08/14/2019
-
-
- This issue is unrelated to whether the client defines the same exception class as the server, and the behavior in my testing appears to be the same on 1.8 as in the master branch.
The underlying issue is that the example code here use... -
- This should be fixed by commit:af35f2a61d8027df2e70012ae736f91ee0e41b85.
-
11:16 PM Bug #15449 (Closed): Range#=== is not using cover in Ruby 2.6
- Applied in changeset commit:git|6954ff1dcb538ee6c042872088b64464a1ef6089.
----------
Make Range#=== operate like cover? instead of include? for string ranges
Previously, Range#=== treated string ranges that were not endless or
beginles... - 11:16 PM Revision 132b7eb1 (git): * expand tabs. [ci skip]
-
-
09:24 PM Feature #16104: Introduce merge_if and merge_if!
- Do
```ruby
a.each_with_object(b: 'Ball') {|(k, v), h| h[k] = v if v == 'Apple'}
```
or
```ruby
{b: 'Ball'}.merge(a.select{|k, v| v == 'Apple'})
```
-
- Hmmm. I have mixed feelings about it. I think being able to add something
into e. g. a Hash, based on a conditional inside of the method, may be useful.
We also have at the least one example of "_if", such as for Array:
.dele... -
06:09 PM Feature #16104: Introduce merge_if and merge_if!
- akash (Akash Gupta) wrote:
> The method `merge_if` / `merge_if!` will merge the passed hash in parameter only if the block evaluates to true, otherwise not. Similar to `count` method with a block.
For ex:
`a = {a: 'Apple'}`
`a.... -
- The method `merge_if` / `merge_if` will merge the passed hash in parameter only if the block evaluates to true, otherwise not. Similar to `count` method with a block.
-
-
- Previously, Range#=== treated string ranges that were not endless or
beginless the same as include?, instead of the same as cover?.
I think this was an oversight in 989e07c0f2fa664a54e52a475c2fcc145f06539d,
as the commit message did not ... -
- strcasecmp(3) and String#casecmp? both fold to lowercase.
-
07:41 PM Bug #16105 (Closed): heap-use-after-free in String#sub!
- #15946 caught my eye, so I ran the reproducer there through a build with AddressSanitizer (ASAN) enabled. It looks like String#sub! still has some corruption going on even after the memmove change.
Reproducer:
```
a = "AAAAAAAAAAAAA... -
- Applied in changeset commit:git|d5c60214c45bafc1cf2a516f852394986f9c84bb.
----------
Implement Range#minmax
Range#minmax was previous not implemented, so calling #minmax on
range was actually calling Enumerable#minmax. This is a simpl... -
- Applied in changeset commit:git|d5c60214c45bafc1cf2a516f852394986f9c84bb.
----------
Implement Range#minmax
Range#minmax was previous not implemented, so calling #minmax on
range was actually calling Enumerable#minmax. This is a simpl... -
- Range#minmax was previous not implemented, so calling #minmax on
range was actually calling Enumerable#minmax. This is a simple
implementation of #minmax by just calling range_min and range_max.
Fixes [Bug #15867]
Fixes [Bug #15807] -
- Some tooling depends on the current bytecode, and adding an operand
changes the bytecode. While tooling can be updated for new bytecode,
this support doesn't warrant such a change. -
- > I think it can be an operand of getconst than an argument on the stack, while it is always a constant.
No. It should not be an new operand because we need to change tools which depends on current bytecode. -
- Applied in changeset commit:git|fbcd0652944568c43a6ae427960d909d62ce6a8d.
----------
Remove support for nil::Constant
This was an intentional bug added in 1.9.
The approach taken here is to add a second operand to the
getconstant inst... -
- nobu: I agree, making it an operand instead of a stack argument makes more sense. I'm currently testing a patch for that and will commit if it passes.
-
- I think it can be an operand of `getconst` than an argument on the stack, while it is always a constant.
-
- :+1: great patch! could you commit it?
-
- This bug is still present in the master branch. Attached is a patch that fixes it. It adds a second argument to the getconstant instruction. It would probably be better for performance to add a separate instruction for the case where ...
-
-
- Fixes error when using -Werror,-Wshorten-64-to-32.
- 04:51 PM Revision d053a570 (git): * expand tabs. [ci skip]
-
- This was an intentional bug added in 1.9.
The approach taken here is to add a second operand to the
getconstant instruction for whether nil should be allowed and
treated as current scope.
Fixes [Bug #11718] -
- 04:00 PM Revision 7d32cb76 (git): * 2019-08-15 [ci skip]
-
-
-
02:35 PM Revision 7da40d74 (git): backtrace and backtrace_locations can be nil (#2358)
- Exception#backtrace and Exception#backtrace_locations can both be nil if
not set. The former can be set via `Exception#set_backtrace`, but the
later is only ever set at runtime via `setup_backtrace`. -
- This change broke the minitest.
https://github.com/ruby/ruby/pull/2365/checks?check_run_id=193322770#step:10:168
-
- Applied in changeset commit:git|182a408c2c4113eb316c2a87e35880144afb4498.
----------
change Proc#to_s format ('@...' -> ' ...') (#2362)
Now Proc#to_s returns
"#<Proc:0x00000237a0f5f170@t.rb:1>".
However, it is convenient to select a fi... -
- In [Feature #14145],
https://bugs.ruby-lang.org/issues/14145#note-25
> I think (a space) is better, and it's what we use for Method#inspect in TruffleRuby.
> ...
I tried to introduce this change (`@` -> ` `).
# Compatibility issu... - 02:13 PM Revision 48e9155e (git): Remove strange formatting from English [ci skip]
- \vref is not valid doc syntax
-
- because these tests have failed too often and it's false-positive for
checking healthiness of the master branch. -
-
- because it's shown as just "master" on a pull request which does not
have the check_branch.master job yet.
"check_branch" would be easier to understand and now we can grep it from
master branch. -
- * [Feature #16103] Make the dot-colon method reference frozen
-
12:23 PM Feature #16103 (Closed): Make the dot-colon method reference frozen
- I made a PR to freeze the dot-colon method reference result object (https://github.com/ruby/ruby/pull/2267). Nobu asked to make an issue out of that. I initially discussed that with Matz and Ko1 during the hack challenge in Bristol.
H... -
- The idea is to avoid recursive calls to the same event, but allow other kind of reentrancy. With a real script:
```ruby
line_handler1 = TracePoint.trace(:line) do |tp| # L1
puts "Handler 1 starts (triggered fro... -
- > But then I thought that we could even allow events of the same type, as long as we forbid handlers currently being run from being triggered.
> ...
...
> The idea is running any possible relevant event handler as long as it's not alre... -
- I agree that `ary1.zip(ary2, ary3)` is asymmetric and uncool, but I don't like solving the issue by adding a method of Symbol. `:zip.(*arrays)` looks too cryptic and semantically hacky to me. Rather, I like your #8970: `Array.zip(ary1,...
-
- I have no particular pro/con opinion on the suggested functionality here itself.
In my opinion, this is mostly a design consideration for how "useful" matz
wants to see symbols being used in ruby. (This may not be directly related
t... -
- Related to #6499, #6727, #7444, #8970, #11262.
-
- Since symbols have a `to_proc` method, it is natural to expect that they would appear in a method chain like:
```ruby
:some_symbol.to_proc.call(...)
```
In fact, I have use cases like this:
```ruby
arrays = [["a", "b"], ["c"]... -
- Now we have an endless range which allows us to write `arr[1..]`. It is much less hideous than `arr[1..-1]`, IMO. Do you still want `Array#rest`?
-
- Applied in changeset commit:git|c8f97596b7dd6ffbeb98970f9cc664b0a8a2336e.
----------
Don't accidentally name anonymous module/class
b00f280d4b9569e7153365d7e1c522b3d6b3c6cf introduced
an accidental behavior change in that defining a mo... -
- Done. The [latest commit](https://github.com/ruby/ruby/pull/2337/commits/36e00760a42a09266521fc503a0bda7af632a4e3) has a reference to this ticket.
-
- b00f280d4b9569e7153365d7e1c522b3d6b3c6cf introduced
an accidental behavior change in that defining a module/class under
`m` gives `m` a name when `m` is anonymous.
`ruby -ve 'Module.new { class self::A; end; p name }'` outputs a name
si... -
- 07:25 AM Revision 0971460e (git): * expand tabs.
-
- Now Proc#to_s returns
"#<Proc:0x00000237a0f5f170@t.rb:1>".
However, it is convenient to select a file name by (double-)clicking
on some terminals by separating ' ' instead of '@' like
"#<Proc:0x00000237a0f5f170 t.rb:1>"
[Feature #16101] -
03:59 AM Feature #15915: `@1` cannot be achieved in meta-programming
- When I debug a proc which use the numbered parameters, I can not inspect the numbered parameters.
Because irb use Binding to evaluate input but the numbered parameters can not get from binding.
```ruby
square = -> {
binding.irb
... -
-
-
- This issue is related to scope. In all cases, your call to `private` is calling ruby's default behavior. However, when you call `super`, it just changes the scope of the `super` call to `private`. The scope of your overridden `private...
-
- It seems that the method visibility modifiers don't call `super` correctly when they are overridden in certain ways. I expected the following examples to all behave the same since they are all being defined on the singleton class, but on...
-
-
-
-
-
-
-
- Coverity Scan says:
```
** CID 1452284: Uninitialized variables (UNINIT)
/eval.c: 223 in rb_ec_cleanup()
```
```
>>> CID 1452284: Uninitialized variables (UNINIT)
> ...
``` -
- I think this is a feature request, not a bug report. It does seem like a useful feature, so I've submitted a pull request to irb for it: https://github.com/ruby/irb/pull/22
-
- * include/ruby/io.h (rb_io_enc_t): add typedef.
* io.c (rb_io_extract_modeenc): export. -
- https://github.com/ruby/stringio/commit/b249631c43
-
- https://github.com/ruby/stringio/commit/53def32ba0
-
- https://github.com/ruby/stringio/commit/d28927b561
-
- https://github.com/ruby/stringio/commit/c4a13d41cd
https://github.com/ruby/stringio/commit/359c9f395c -
- https://github.com/ruby/stringio/commit/7b20075ab0
-
- https://github.com/ruby/ruby/runs/192869165
-
- because it has been unstable, and also it sometimes does not work for a
pull request like:
https://github.com/ruby/ruby/pull/2358/checks?check_run_id=192685048#step:4:17 -
- I agree that this is a bug. The comparison that nobu made with `basename(1)` is relevant, but unlike `File.basename`, `basename(1)` does not handle `.*` specially. You can see that `basename(1)` does actually strip the extension even f...
08/13/2019
-
- Attached is a patch that fixes this issue. With the patch:
```ruby
name = 'file.'
File.basename(name, '.*')
# => "file."
File.extname(name)
# => ""
``` -
- Could you rebase the PR with adding this reference `[Bug #16097]` to the commit log?
-
-
- They are used by default gems like forwardable.
* assert_raise_with_message
* assert_warning
* assert_warn -
09:27 PM Feature #15955: UnboundMethod#apply
- > I wonder that people use this pattern! (I'd never used it except test).
This pattern currently represents substantial fraction of allocations that Sorbet runtime does, so building a way to not allocate in this pattern might have a s... -
- It's a good idea since it can save a lot of time for maintainers.
-
- While this feature is still experimental, I wrote a script to automatically check the consistency between Git repositories every 10 minutes. So it's somewhat safe now, and we'd be able to always restore the repository from logs. I'll tak...
-
04:56 PM Feature #15609: Kernel#sleep returns Float instead of Integer
- Hi, I don't know if anyone still wants this feature, but, since I wanted to get started contributing to ruby, I have implemented the following changes in my patch. Should an integer be entered into the function, the function acts like it...
- 03:23 PM Revision 930e637c (git): * 2019-08-14
-
-
- Applied in changeset commit:git|5b1bf8dd2d08ae7371ecf025967376bb794ed651.
----------
UTF LE is fixed at least the first 2 bytes
* io.c (io_strip_bom): if the first 2 bytes are 0xFF0xFE, it
should be a little-endian UTF, 16 or 32. [Bug... -
- ```
$ ruby -e 'File.binwrite("u.txt", "\xff\xfe\x00\x01")'
$ file u.txt
u.txt: Little-endian UTF-16 Unicode text, with no line terminators
$ ruby -e 'p File.open("u.txt", "rb:bom|utf-8", &:external_encoding)'
#<Encoding:UTF-8>
```... -
- * io.c (io_strip_bom): if the first 2 bytes are 0xFF0xFE, it
should be a little-endian UTF, 16 or 32. [Bug #16099] -
- because clone does not checkout exact commit sha, and also we'd need to handle
pull_request on fork, so I tentatively stopped to do this. - 02:00 PM Revision c393734c (git): * expand tabs.
-
02:00 PM Revision dd1344b8 (git): Add compaction callbacks for Enumerator
- This commit gives Enumerator compaction support
-
-
01:48 PM Bug #16026: `Set#count` performance issues
- it might not be able to be generic in Enumerable
for example an Widget might be Enumerable with the child widgets, but its size would be `[width, height]`
for Set#count
```ruby
class Set
def count(*args)
return size if ... -
11:19 AM Bug #16026: `Set#count` performance issues
- I agree that the `return size if !block_given? && respond_to?(:size)` logic should belong to Enumerable. (oh, and also if `item` is not given)
-
- I was okay with changing my implementation to use `#size` - which is what I've done. However, I don't think there is anything wrong with optimising this use case if it doesn't add any overhead to existing use case. Because `Array` does i...
-
- Yes, that was initial proposal (to prohibit other events of the same type, while a handler for a certain event type is running). But then I thought that we could even allow events of the same type, as long as we forbid handlers currently...
-
- Your proposal is, prohibit "same" tracepoint object, right? I misreading that your suggestion is to prohibit same event (when line event handler is working, other line event handler can't be fired, but :class event handler can fire).
... -
-
- What about adding block arguments to `OpenStruct.new` like `Hash` instead of options?
```ruby
h = Hash.new {|hash, key|
raise(IndexError, "hash[#{key}] has no value")
}
# Error: in `block in <main>': hash[1] has no value (Inde... -
09:30 AM Feature #15815: Add option to raise NoMethodError for OpenStruct
- ko1-san
Sorry for being late.
I've added https://bugs.ruby-lang.org/issues/15996?next_issue_id=15993&prev_issue_id=15998#note-17 -
- * [Feature #15815] Add option to raise NoMethodError for OpenStruct (mtsmfm)
* We can use `Symbol#to_proc` with enumerable stuff when we use OpenStruct instead of Hash. For example: `OpenStruct.new(JSON.parse(users)).map(&:id)`
* B... -
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
- `ruby_cleanup` should only be called once per process, before exiting (either via `main`->`ruby_run_node` or `ruby_stop`). It is not expected to free all memory allocated earlier, since the process will be exiting and the operating syst...
-
-
-
- 02:20 AM Revision f78916e3 (git): * expand tabs.
-
- It has not been used for 4 years, since r60856,
e33b1690d06f867e45750bd8e3e8b06d78b5bc26. -
- As `rb_objspace_each_objects_without_setup` doesn't reset and
restore `dont_incremental` flag, renamed the bare iterator as
`objspace_each_objects_without_setup`. `objspace_each_objects`
calls it when called with the flag disabled, wrap... -
- 12:50 AM Revision aec93417 (git): * expand tabs.
-
-
-
- And pass rb_execution_context_t as an argument.
-
08/12/2019
-
-
- Ruby makes `taint` and `untaint` just return the receiver if called on any object that is not considered taintable. That includes all immediate objects (symbols, integers(fixnums), true, false, nil), as well as integers(bignums) and flo...
-
-
- This is not a bug. The documentation suggestions the use of character classes if you want to match whitespace (https://docs.ruby-lang.org/en/trunk/regexp_rdoc.html#label-Free-Spacing+Mode+and+Comments).
-
-
-
-
-
- I don't think this is a bug in `__dir__`. It's just that `__FILE__` inside `eval` depends on either the binding or file argument given to `eval` (in Ruby 3, it will only depend on the file argument, see #4352).
If you rewrite your ex... -
-
- ko1 (Koichi Sasada) wrote:
> ちなみに、私の予想は
> ...
This output would be against my expection. If `C1` prepends `P`, then methods in `P` must be considered before methods in `C1`. Consider `C1.ancestors`:
```ruby
[P, C1, C0, Object, Ke... -
- I agree with ko1's opinion. Attached is a patch that implements his proposal.
Note that this change cannot be made in `method_inspect`, because at that time, the necessary information has already been lost. To implement ko1's propos... -
09:13 PM Bug #14972: Net::HTTP inconsistently raises EOFError when peer closes the connection
- naruse (Yui NARUSE) wrote:
> joshc (Josh C) wrote:
> ...
If you save the first response body, and make a new request with ```Range: bytes=X-Y```, then the `Content-Length` header in the second response should specify the number of byte... -
- Renaming this function. "No pin" leaks some implementation details. We
just want users to know that if they mark this object, the reference may
move and they'll need to update the reference accordingly. -
-
- This was fixed between Ruby 2.2 and 2.3:
`t.rb`:
```ruby
class MyClass < Proc
end
def foo (&x)
p [:foo, x.class]
end
x = Proc.new {|&x| p [:x, x.class]}
z = MyClass.new {}
foo &z
x.call &z
```
output:
```
$ ruby2... -
- It looks like the problem is a kubernetes-specific issue. With your `resolv.conf` file, I get the following for `Resolv::DNS::Config.default_config_hash`:
```
{:nameserver=>["10.7.240.10"], :search=>["staging.svc.cluster.local", "sv... -
- I don't think this is a bug. `TCPServer.new` binds to the first address that matches for the hostname. In your example, you are explicitly binding to the IPv6 address and not the IPv4 address, so if the DNS resolution in your environme...
-
-
- Applied in changeset commit:git|404850e13446c79fb6142f1b32b219753e5cd726.
----------
Remove documentation that fatal cannot be rescued [ci skip]
You can rescue it:
f = ObjectSpace.each_object(Class){|c| break c if c.name == 'fatal'}
b... -
- ```ruby
Thread.start{Thread.stop}
begin
Thread.stop
rescue Exception => fatal
p fatal.class #=> fatal
end
``` -
- The documentation is not accurate indeed.
To be accurate, it is impossible to rescue the `fatal` raised by `rb_fatal` function. -
- `Complex::compatible`, `unknown`, `Rational::compatible` were removed by Ruby 2.6.0. `fatal` is still documented, but that exists even though you cannot reference it directly:
```ruby
f = ObjectSpace.each_object(Class){|c| break c i... -
- You can rescue it:
f = ObjectSpace.each_object(Class){|c| break c if c.name == 'fatal'}
begin
raise f
rescue f
2
end # => 2
It's not a good idea to rescue fatal exceptions you didn't generate
yourself, though.
Fixes [Bug #10691] -
- This is almost implemented. It's still under testing and only available for admin now, but you may see some usages for testing. I'll add one more guard and then enable "write" to merge pull requests for ruby-committers team.
I also no... -
- Experimentally, I'll move GitHub sync from post-receive hook to update hook, which blocks git push a little more. Still most of the behavior would be the same, but you might feel git push became slower.
-
- > we found that we could automatically attach notes to "Rebase and merge"d commits on our git.ruby-lang.org's post-commit hook.
I implemented this in https://github.com/ruby/ruby-commit-hook/blob/d05f66c9df2eabe45f7cb1d8bd3d51c356144e... -
- 04:34 PM Revision e688ab26 (git): * expand tabs.
-
-
- We're already updating the location of default values, so we may as well
unpin them. -
-
- Just a few updates to make the English sound a bit more natural
-
- 03:51 PM Revision 4d3fb247 (git): * 2019-08-13
-
-
-
- This change:
* Added an explanation about back references except \n and \k<n>
(\` \& \' \+ \0)
* Added an explanation about an escape (\\)
* Added some rdoc references
* Rephrased and clarified the reason why double escape is needed, ... -
- * ext/date/date_parse.c (date_zone_to_diff): trim off by zone name
length. -
- * ext/date/date_parse.c (date_zone_to_diff): get rid of copying
the whole argument string. -
-
-
- Closes: https://github.com/ruby/ruby/pull/2346
-
-
-
-
-
-
-
- to propagate exit status to travis_retry properly.
-
- pushing a trivial commit for testing post-receive hook
-
-
09:34 AM Misc #16091 (Closed): gsub
-
- This reverts commit 5ee11a95ffbf194a73d1bea300a35f5d6250d203.
Sorry, timeout(1) was missing. -
- unlike Travis, it seems not used.
-
- because it has failed often on Travis.
-
08:15 AM Feature #14164: [Suggestion] Type system for ruby 3x to be usable for e. g. rubocop or autogenerating crystal code and so forth
- >> Crystal is in many ways similar to ruby;
> ...
To the best of my memory/understanding, it is not a myth, but a _historical_ fact: Crystal started as an attempt to just make a "compiled Ruby" (probably with type system, but "invisib... -
- because somebody may want to remove the duplicated Travis osx usage
later. - 07:11 AM Revision 765cc17c (git): Update IRB man page
-
-
- anyway we don't need authorization here.
Also retry does not seem to work in the original version, so let's
extend this with retries as a separate github action later. -
- because it randomly fails on authorization like:
https://github.com/ruby/ruby/runs/190887455
Also the backoff seems too short. Maybe we need tool/travis_retry.sh for
this too.
Cloning ruby/ruby does not need authorization. We don't need... -
- Use simpler rev-parse to check if pull request was fetched.
-
- As `CHR` should stand for `char` type of C, so exceeding the limit of `char` will make confusion, I guess.
I'm curious for what purpose @silverhammermba needs the range check.
If it is to get a codepoint, I don't think extracting the... -
- Attached is a patch that will add a range check to `NUM2CHR`. However, it breaks a test:
```
1) Error:
TestStringIO#test_putc_nonascii:
RangeError: value to large to convert to char: 12356
/home/jeremy/tmp/ruby/test/stringio/... -
- as we dropped -v.
-
- In Ruby, a space before an opening parenthesis often has significant meanings.
Combining `defined?(a)` higher than `&&` is considered reasonable. -
- There isn't a description of the actual problem caused by this behavior, but I'm guessing, it is something like this:
```ruby
defined? a && defined? b # defined?(a && defined? b)
# => "expression"
defined? (a) && defined? (b) # d... -
- I doubt dropping the existing constant visibility information is intentional behavior. You can work around the current behavior by resetting `private_constant`/`deprecate_constant` inside the autoloaded file, but that leads to duplicati...
- 03:59 AM Revision 63d3c4fe (git): * 2019-08-12
-
- Closes: https://github.com/ruby/ruby/pull/2340
-
- I get a SEGV in `TestSetTraceFunc` when I run `env RUBY_ISEQ_DUMP_DEBUG=to_binary make check`.
The crash doesn't happen when I run just that test file with `make test-all TESTOPTS="test/ruby/test_settracefunc.rb"`.
I only investigated ... -
-
-
-
-
-
-
-
-
-
-
-
-