Activity
From 08/08/2019 to 08/14/2019
08/14/2019
-
11:55 PM Bug #6332 (Closed): Error compiling readline due username_completion_function being undeclared (GCC 4.6)
-
11:53 PM Bug #5618: Exceptions cause DRb connection to be closed
- This issue is unrelated to whether the client defines the same exception class as the server, and the behavior in my testing appears to be the same on 1.8 as in the master branch.
The underlying issue is that the example code here use... -
11:18 PM Bug #6275 (Closed): symbol not found: _environ on Mac OS X
- This should be fixed by commit:af35f2a61d8027df2e70012ae736f91ee0e41b85.
-
11:16 PM Bug #15449 (Closed): Range#=== is not using cover in Ruby 2.6
- Applied in changeset commit:git|6954ff1dcb538ee6c042872088b64464a1ef6089.
----------
Make Range#=== operate like cover? instead of include? for string ranges
Previously, Range#=== treated string ranges that were not endless or
beginles... - 11:16 PM Revision 132b7eb1 (git): * expand tabs. [ci skip]
-
09:25 PM Bug #5527 (Closed): set_trace_func binding incorrect
-
09:24 PM Feature #16104: Introduce merge_if and merge_if!
- Do
```ruby
a.each_with_object(b: 'Ball') {|(k, v), h| h[k] = v if v == 'Apple'}
```
or
```ruby
{b: 'Ball'}.merge(a.select{|k, v| v == 'Apple'})
```
-
08:51 PM Feature #16104: Introduce merge_if and merge_if!
- Hmmm. I have mixed feelings about it. I think being able to add something
into e. g. a Hash, based on a conditional inside of the method, may be useful.
We also have at the least one example of "_if", such as for Array:
.dele... -
06:09 PM Feature #16104: Introduce merge_if and merge_if!
- akash (Akash Gupta) wrote:
> The method `merge_if` / `merge_if!` will merge the passed hash in parameter only if the block evaluates to true, otherwise not. Similar to `count` method with a block.
For ex:
`a = {a: 'Apple'}`
`a.... -
06:07 PM Feature #16104 (Open): Introduce merge_if and merge_if!
- The method `merge_if` / `merge_if` will merge the passed hash in parameter only if the block evaluates to true, otherwise not. Similar to `count` method with a block.
-
09:18 PM Bug #5467 (Closed): ENABLE_VM_OBJSPACE on Windows
-
09:14 PM Revision 6954ff1d (git): Make Range#=== operate like cover? instead of include? for string ranges
- Previously, Range#=== treated string ranges that were not endless or
beginless the same as include?, instead of the same as cover?.
I think this was an oversight in 989e07c0f2fa664a54e52a475c2fcc145f06539d,
as the commit message did not ... -
09:11 PM Revision 082424ef (git): Fold to lowercase intead of uppercase for String#casecmp
- strcasecmp(3) and String#casecmp? both fold to lowercase.
-
07:41 PM Bug #16105 (Closed): heap-use-after-free in String#sub!
- #15946 caught my eye, so I ran the reproducer there through a build with AddressSanitizer (ASAN) enabled. It looks like String#sub! still has some corruption going on even after the memmove change.
Reproducer:
```
a = "AAAAAAAAAAAAA... -
06:23 PM Bug #15807 (Closed): Range#minmax is slow and never returns for endless ranges
- Applied in changeset commit:git|d5c60214c45bafc1cf2a516f852394986f9c84bb.
----------
Implement Range#minmax
Range#minmax was previous not implemented, so calling #minmax on
range was actually calling Enumerable#minmax. This is a simpl... -
06:23 PM Bug #15867 (Closed): Enumerable#minmax inconsistent behavior with Time ranges
- Applied in changeset commit:git|d5c60214c45bafc1cf2a516f852394986f9c84bb.
----------
Implement Range#minmax
Range#minmax was previous not implemented, so calling #minmax on
range was actually calling Enumerable#minmax. This is a simpl... -
06:22 PM Revision d5c60214 (git): Implement Range#minmax
- Range#minmax was previous not implemented, so calling #minmax on
range was actually calling Enumerable#minmax. This is a simple
implementation of #minmax by just calling range_min and range_max.
Fixes [Bug #15867]
Fixes [Bug #15807] -
06:22 PM Revision 661927a4 (git): Switch to using a VM stack argument instead of 2nd operand for getconstant
- Some tooling depends on the current bytecode, and adding an operand
changes the bytecode. While tooling can be updated for new bytecode,
this support doesn't warrant such a change. -
06:03 PM Bug #11718: Constant access on `nil`
- > I think it can be an operand of getconst than an argument on the stack, while it is always a constant.
No. It should not be an new operand because we need to change tools which depends on current bytecode. -
04:51 PM Bug #11718 (Closed): Constant access on `nil`
- Applied in changeset commit:git|fbcd0652944568c43a6ae427960d909d62ce6a8d.
----------
Remove support for nil::Constant
This was an intentional bug added in 1.9.
The approach taken here is to add a second operand to the
getconstant inst... -
04:08 PM Bug #11718: Constant access on `nil`
- nobu: I agree, making it an operand instead of a stack argument makes more sense. I'm currently testing a patch for that and will commit if it passes.
-
07:19 AM Bug #11718: Constant access on `nil`
- I think it can be an operand of `getconst` than an argument on the stack, while it is always a constant.
-
06:35 AM Bug #11718: Constant access on `nil`
- :+1: great patch! could you commit it?
-
05:51 AM Bug #11718: Constant access on `nil`
- This bug is still present in the master branch. Attached is a patch that fixes it. It adds a second argument to the getconstant instruction. It would probably be better for performance to add a separate instruction for the case where ...
-
05:44 PM Bug #15784 (Closed): RUBY_DEBUG=gc_stress dumps core
-
04:59 PM Revision 6ac6de84 (git): Use Qtrue/Qfalse instead of 1/0 for 2nd operand to getconstant
- Fixes error when using -Werror,-Wshorten-64-to-32.
- 04:51 PM Revision d053a570 (git): * expand tabs. [ci skip]
-
04:50 PM Revision fbcd0652 (git): Remove support for nil::Constant
- This was an intentional bug added in 1.9.
The approach taken here is to add a second operand to the
getconstant instruction for whether nil should be allowed and
treated as current scope.
Fixes [Bug #11718] -
04:17 PM Bug #16052 (Closed): net/http get_fields doesn't return correct value for set-cookie
- 04:00 PM Revision 7d32cb76 (git): * 2019-08-15 [ci skip]
-
04:00 PM Revision 938e0752 (git): Add `make update-github PR=1234` to refresh PR (#2368)
-
02:41 PM Revision e173012f (git): Drop obsoleted `make merge-github` task
-
02:35 PM Revision 7da40d74 (git): backtrace and backtrace_locations can be nil (#2358)
- Exception#backtrace and Exception#backtrace_locations can both be nil if
not set. The former can be set via `Exception#set_backtrace`, but the
later is only ever set at runtime via `setup_backtrace`. -
02:14 PM Feature #16101 (Assigned): Proc#to_s returns "... file:line" instead of "...@file:line"
- This change broke the minitest.
https://github.com/ruby/ruby/pull/2365/checks?check_run_id=193322770#step:10:168
-
07:25 AM Feature #16101 (Closed): Proc#to_s returns "... file:line" instead of "...@file:line"
- Applied in changeset commit:git|182a408c2c4113eb316c2a87e35880144afb4498.
----------
change Proc#to_s format ('@...' -> ' ...') (#2362)
Now Proc#to_s returns
"#<Proc:0x00000237a0f5f170@t.rb:1>".
However, it is convenient to select a fi... -
06:58 AM Feature #16101 (Closed): Proc#to_s returns "... file:line" instead of "...@file:line"
- In [Feature #14145],
https://bugs.ruby-lang.org/issues/14145#note-25
> I think (a space) is better, and it's what we use for Method#inspect in TruffleRuby.
> ...
I tried to introduce this change (`@` -> ` `).
# Compatibility issu... - 02:13 PM Revision 48e9155e (git): Remove strange formatting from English [ci skip]
- \vref is not valid doc syntax
-
02:02 PM Revision 9874dca3 (git): Mark bundler / bundled-gems as continue-on-failure
- because these tests have failed too often and it's false-positive for
checking healthiness of the master branch. -
01:36 PM Revision bf77f43b (git): Update the description of check_branch
-
01:22 PM Revision 8be52166 (git): Rename check_branch.master to pull_request.check_branch
- because it's shown as just "master" on a pull request which does not
have the check_branch.master job yet.
"check_branch" would be easier to understand and now we can grep it from
master branch. -
12:40 PM Misc #15996: DevelopersMeeting20190829Japan
- * [Feature #16103] Make the dot-colon method reference frozen
-
12:23 PM Feature #16103 (Closed): Make the dot-colon method reference frozen
- I made a PR to freeze the dot-colon method reference result object (https://github.com/ruby/ruby/pull/2267). Nobu asked to make an issue out of that. I initially discussed that with Matz and Ko1 during the hack challenge in Bristol.
H... -
10:36 AM Feature #15912: Allow some reentrancy during TracePoint events
- The idea is to avoid recursive calls to the same event, but allow other kind of reentrancy. With a real script:
```ruby
line_handler1 = TracePoint.trace(:line) do |tp| # L1
puts "Handler 1 starts (triggered fro... -
06:07 AM Feature #15912: Allow some reentrancy during TracePoint events
- > But then I thought that we could even allow events of the same type, as long as we forbid handlers currently being run from being triggered.
> ...
...
> The idea is running any possible relevant event handler as long as it's not alre... -
09:00 AM Feature #16102: `Symbol#call`
- I agree that `ary1.zip(ary2, ary3)` is asymmetric and uncool, but I don't like solving the issue by adding a method of Symbol. `:zip.(*arrays)` looks too cryptic and semantically hacky to me. Rather, I like your #8970: `Array.zip(ary1,...
-
08:37 AM Feature #16102: `Symbol#call`
- I have no particular pro/con opinion on the suggested functionality here itself.
In my opinion, this is mostly a design consideration for how "useful" matz
wants to see symbols being used in ruby. (This may not be directly related
t... -
07:00 AM Feature #16102: `Symbol#call`
- Related to #6499, #6727, #7444, #8970, #11262.
-
06:59 AM Feature #16102 (Open): `Symbol#call`
- Since symbols have a `to_proc` method, it is natural to expect that they would appear in a method chain like:
```ruby
:some_symbol.to_proc.call(...)
```
In fact, I have use cases like this:
```ruby
arrays = [["a", "b"], ["c"]... -
08:51 AM Feature #6727 (Feedback): Add Array#rest (with implementation)
- Now we have an endless range which allows us to write `arr[1..]`. It is much less hideous than `arr[1..-1]`, IMO. Do you still want `Array#rest`?
-
08:13 AM Bug #16097 (Closed): [PATCH] Don't accidentally name anonymous module/class
- Applied in changeset commit:git|c8f97596b7dd6ffbeb98970f9cc664b0a8a2336e.
----------
Don't accidentally name anonymous module/class
b00f280d4b9569e7153365d7e1c522b3d6b3c6cf introduced
an accidental behavior change in that defining a mo... -
01:23 AM Bug #16097: [PATCH] Don't accidentally name anonymous module/class
- Done. The [latest commit](https://github.com/ruby/ruby/pull/2337/commits/36e00760a42a09266521fc503a0bda7af632a4e3) has a reference to this ticket.
-
08:13 AM Revision c8f97596 (git): Don't accidentally name anonymous module/class
- b00f280d4b9569e7153365d7e1c522b3d6b3c6cf introduced
an accidental behavior change in that defining a module/class under
`m` gives `m` a name when `m` is anonymous.
`ruby -ve 'Module.new { class self::A; end; p name }'` outputs a name
si... -
07:30 AM Revision 1cffd5b4 (git): fix last commit.
- 07:25 AM Revision 0971460e (git): * expand tabs.
-
07:25 AM Revision 182a408c (git): change Proc#to_s format ('@...' -> ' ...') (#2362)
- Now Proc#to_s returns
"#<Proc:0x00000237a0f5f170@t.rb:1>".
However, it is convenient to select a file name by (double-)clicking
on some terminals by separating ' ' instead of '@' like
"#<Proc:0x00000237a0f5f170 t.rb:1>"
[Feature #16101] -
03:59 AM Feature #15915: `@1` cannot be achieved in meta-programming
- When I debug a proc which use the numbered parameters, I can not inspect the numbered parameters.
Because irb use Binding to evaluate input but the numbered parameters can not get from binding.
```ruby
square = -> {
binding.irb
... -
03:52 AM Bug #15924 (Closed): Ripper::Lexer RuntimeError - Ripper FATAL - master/trunk
-
03:51 AM Bug #15767 (Closed): .rvm/rubies/ruby-2.4.4/lib/ruby/2.4.0/timeout.rb:86: [BUG] Segmentation fault at 0x000000010ae58a3a
-
03:50 AM Bug #16100: Visibility modifiers don't call super correctly when overridden in alternative ways
- This issue is related to scope. In all cases, your call to `private` is calling ruby's default behavior. However, when you call `super`, it just changes the scope of the `super` call to `private`. The scope of your overridden `private...
-
03:05 AM Bug #16100 (Closed): Visibility modifiers don't call super correctly when overridden in alternative ways
- It seems that the method visibility modifiers don't call `super` correctly when they are overridden in certain ways. I expected the following examples to all behave the same since they are all being defined on the singleton class, but on...
-
03:08 AM Bug #15984 (Closed): deleting from a collection while iterating on it
-
03:08 AM Bug #15876 (Closed): 1.to_s.encoding != Encoding.default_internal
-
03:07 AM Bug #15904 (Closed): Ruby crashes when executing Pronto gem with Rubocop
-
03:07 AM Bug #15888 (Closed): Segmentation fault at 0x000070000afc2450 ruby 2.5.1p57 (2018-03-29 revision 63029) [x86_64-darwin18]
-
03:06 AM Bug #15835 (Closed): Path traversal symlink - WEBrick
-
03:06 AM Bug #15866 (Closed): [BUG] Segmentation fault at 0x0000000000000020
-
02:47 AM Revision 0623e2b7 (git): Suppress Uninitialized variables by Coverity Scan
- Coverity Scan says:
```
** CID 1452284: Uninitialized variables (UNINIT)
/eval.c: 223 in rb_ec_cleanup()
```
```
>>> CID 1452284: Uninitialized variables (UNINIT)
> ...
``` -
02:35 AM Feature #15371: IRB with ARGV
- I think this is a feature request, not a bug report. It does seem like a useful feature, so I've submitted a pull request to irb for it: https://github.com/ruby/irb/pull/22
-
02:20 AM Revision c744b626 (git): io.c: export rb_io_extract_modeenc
- * include/ruby/io.h (rb_io_enc_t): add typedef.
* io.c (rb_io_extract_modeenc): export. -
02:20 AM Revision cad41bb6 (git): [ruby/stringio] Supported BOM
- https://github.com/ruby/stringio/commit/b249631c43
-
02:20 AM Revision 22e942de (git): [ruby/stringio] Supported `mode:` option
- https://github.com/ruby/stringio/commit/53def32ba0
-
02:20 AM Revision 8b443078 (git): [ruby/stringio] Allow bignum mode
- https://github.com/ruby/stringio/commit/d28927b561
-
02:20 AM Revision e54d349a (git): [ruby/stringio] Added support for older versions
- https://github.com/ruby/stringio/commit/c4a13d41cd
https://github.com/ruby/stringio/commit/359c9f395c -
02:20 AM Revision c8f9e9a2 (git): [ruby/stringio] stringio: encoding support
- https://github.com/ruby/stringio/commit/7b20075ab0
-
01:52 AM Revision 765d6031 (git): Try to fix variable reference on Windows (#2361)
- https://github.com/ruby/ruby/runs/192869165
-
01:22 AM Revision 8a687b8a (git): Stop using official actions/checkout
- because it has been unstable, and also it sometimes does not work for a
pull request like:
https://github.com/ruby/ruby/pull/2358/checks?check_run_id=192685048#step:4:17 -
01:15 AM Bug #15244: Method #extname return empty string if filename is dot ('.')
- I agree that this is a bug. The comparison that nobu made with `basename(1)` is relevant, but unlike `File.basename`, `basename(1)` does not handle `.*` specially. You can see that `basename(1)` does actually strip the extension even f...
08/13/2019
-
11:49 PM Bug #15267: File.basename + File.extname does not restore the original name
- Attached is a patch that fixes this issue. With the patch:
```ruby
name = 'file.'
File.basename(name, '.*')
# => "file."
File.extname(name)
# => ""
``` -
11:48 PM Bug #16097: [PATCH] Don't accidentally name anonymous module/class
- Could you rebase the PR with adding this reference `[Bug #16097]` to the commit log?
-
11:10 PM Bug #15082 (Closed): Memory leak in net/http/response and net/http/header
-
10:44 PM Revision 216d2300 (git): Move some assertions to CoreAssertions. (#2354)
- They are used by default gems like forwardable.
* assert_raise_with_message
* assert_warning
* assert_warn -
09:27 PM Feature #15955: UnboundMethod#apply
- > I wonder that people use this pattern! (I'd never used it except test).
This pattern currently represents substantial fraction of allocations that Sorbet runtime does, so building a way to not allocate in this pattern might have a s... -
08:09 PM Misc #16094: Allow only "Rebase and merge" or "Squash and merge" on GitHub master branch, and sync it on git.ruby-lang.org update hook
- It's a good idea since it can save a lot of time for maintainers.
-
12:36 PM Misc #16094 (Closed): Allow only "Rebase and merge" or "Squash and merge" on GitHub master branch, and sync it on git.ruby-lang.org update hook
- While this feature is still experimental, I wrote a script to automatically check the consistency between Git repositories every 10 minutes. So it's somewhat safe now, and we'd be able to always restore the repository from logs. I'll tak...
-
04:56 PM Feature #15609: Kernel#sleep returns Float instead of Integer
- Hi, I don't know if anyone still wants this feature, but, since I wanted to get started contributing to ruby, I have implemented the following changes in my patch. Should an integer be entered into the function, the function acts like it...
- 03:23 PM Revision 930e637c (git): * 2019-08-14
-
03:23 PM Revision 8827697e (git): Compare actual result
-
02:42 PM Bug #16099 (Closed): UTF-16LE BOM followed by '\0' is missed
- Applied in changeset commit:git|5b1bf8dd2d08ae7371ecf025967376bb794ed651.
----------
UTF LE is fixed at least the first 2 bytes
* io.c (io_strip_bom): if the first 2 bytes are 0xFF0xFE, it
should be a little-endian UTF, 16 or 32. [Bug... -
02:22 PM Bug #16099 (Closed): UTF-16LE BOM followed by '\0' is missed
- ```
$ ruby -e 'File.binwrite("u.txt", "\xff\xfe\x00\x01")'
$ file u.txt
u.txt: Little-endian UTF-16 Unicode text, with no line terminators
$ ruby -e 'p File.open("u.txt", "rb:bom|utf-8", &:external_encoding)'
#<Encoding:UTF-8>
```... -
02:38 PM Revision 5b1bf8dd (git): UTF LE is fixed at least the first 2 bytes
- * io.c (io_strip_bom): if the first 2 bytes are 0xFF0xFE, it
should be a little-endian UTF, 16 or 32. [Bug #16099] -
02:36 PM Revision 79f9c626 (git): Use the official actions/checkout again (#2357)
- because clone does not checkout exact commit sha, and also we'd need to handle
pull_request on fork, so I tentatively stopped to do this. - 02:00 PM Revision c393734c (git): * expand tabs.
-
02:00 PM Revision dd1344b8 (git): Add compaction callbacks for Enumerator
- This commit gives Enumerator compaction support
-
01:56 PM Revision 94ca848c (git): Update the comment in check_branch [ci skip] (#2355)
-
01:48 PM Bug #16026: `Set#count` performance issues
- it might not be able to be generic in Enumerable
for example an Widget might be Enumerable with the child widgets, but its size would be `[width, height]`
for Set#count
```ruby
class Set
def count(*args)
return size if ... -
11:19 AM Bug #16026: `Set#count` performance issues
- I agree that the `return size if !block_given? && respond_to?(:size)` logic should belong to Enumerable. (oh, and also if `item` is not given)
-
01:04 AM Bug #16026: `Set#count` performance issues
- I was okay with changing my implementation to use `#size` - which is what I've done. However, I don't think there is anything wrong with optimising this use case if it doesn't add any overhead to existing use case. Because `Array` does i...
-
01:21 PM Feature #15912: Allow some reentrancy during TracePoint events
- Yes, that was initial proposal (to prohibit other events of the same type, while a handler for a certain event type is running). But then I thought that we could even allow events of the same type, as long as we forbid handlers currently...
-
08:14 AM Feature #15912: Allow some reentrancy during TracePoint events
- Your proposal is, prohibit "same" tracepoint object, right? I misreading that your suggestion is to prohibit same event (when line event handler is working, other line event handler can't be fired, but :class event handler can fire).
... -
12:11 PM Revision e75e548c (git): spec/bundler needs the specific command [ci skip]
-
10:15 AM Feature #15815: Add option to raise NoMethodError for OpenStruct
- What about adding block arguments to `OpenStruct.new` like `Hash` instead of options?
```ruby
h = Hash.new {|hash, key|
raise(IndexError, "hash[#{key}] has no value")
}
# Error: in `block in <main>': hash[1] has no value (Inde... -
09:30 AM Feature #15815: Add option to raise NoMethodError for OpenStruct
- ko1-san
Sorry for being late.
I've added https://bugs.ruby-lang.org/issues/15996?next_issue_id=15993&prev_issue_id=15998#note-17 -
09:29 AM Misc #15996: DevelopersMeeting20190829Japan
- * [Feature #15815] Add option to raise NoMethodError for OpenStruct (mtsmfm)
* We can use `Symbol#to_proc` with enumerable stuff when we use OpenStruct instead of Hash. For example: `OpenStruct.new(JSON.parse(users)).map(&:id)`
* B... -
06:39 AM Revision d0b2e641 (git): Pass rb_execution_context_t* in ruby_run_node
-
06:27 AM Revision ffab84fa (git): Fix a typo [ci skip]
-
05:31 AM Bug #15070 (Closed): configure fails with (probably spurious) 'something wrong with CFLAGS="-g -O2 "' on macOS High Sierra
-
05:31 AM Bug #15001 (Closed): Peek causes cursor to advance when enumerating the lines of a file
-
05:29 AM Bug #14976 (Closed): /usr/local/lib/ruby/gems/2.6.0/gems/fluentd-1.2.4/lib/fluent/event.rb:193: [BUG] Segmentation fault at 0x0000000000000000 ruby 2.6.0preview1 (2018-02-24 trunk 62554) [x86_64-linux]
-
05:28 AM Bug #14910 (Closed): /usr/local/Cellar/ruby/2.5.1/lib/ruby/2.5.0/x86_64-darwin17/openssl.bundle: [BUG] Segmentation fault at 0x0000000000000001
-
05:27 AM Bug #14879 (Closed): Time#+ and Time#- do not preserve receiver's utc_offset if ENV['TZ'] is modified after receiver is created
-
05:27 AM Bug #14849 (Closed): rbenv install 2.4.0 on AWS EC2 on AMI linux box
-
05:26 AM Bug #14810 (Closed): Segfault during travis build (Ruby trunk 63545)
-
05:26 AM Bug #14740 (Closed): You may have encountered a bug in the Ruby interpreter or extension libraries. Bug reports are welcome.
-
05:22 AM Bug #14614 (Closed): Error when running `make update-gems`
-
05:22 AM Bug #14583 (Closed): #method() is reporting the wrong self in exception
-
05:21 AM Bug #14569 (Closed): Ruby dumps core involving XML file
-
05:15 AM Bug #14026 (Closed): RUBY ERROR ON DIVISION with FDIV
-
05:10 AM Bug #13811 (Closed): Ruby 2.4.1 fails to compile inside qemu armhf - signal 11 (Segmentation fault)
-
05:09 AM Bug #13783 (Closed): Memory allocation / GC does not free unused memory
-
04:54 AM Bug #12787 (Closed): Stackoverflow over when alias_method and prepend are used in combination
-
04:52 AM Bug #12679 (Closed): Failed to build ruby on aarch64 with musl libc and gcc 6
-
04:52 AM Bug #12603 (Closed): Segmentation fault random in irb with ruby 2.3.1p112 (2016-04-26 revision 54768) [x86_64-linux-musl]
-
04:50 AM Bug #12476 (Closed): Cygwin current Ruby 2.2.4p230 fails where prev Ruby 2.2.3p173 does not
-
04:50 AM Bug #12465 (Closed): I encountered this issue when I ran rspec
-
04:47 AM Bug #12207 (Closed): [BUG] Segmentation fault at 0x00000000000000 ruby 2.2.3p173 (2015-08-18 revision 51636) [x86_64-darwin14]
-
04:40 AM Bug #11869 (Closed): random hang/SegFault when accessing a missing constant in irb
-
04:20 AM Bug #11542 (Closed): Zlib::DataError: incorrect data check
-
04:18 AM Bug #11511 (Closed): Problem with cyrillic letter И
-
04:18 AM Bug #11490 (Closed): Allocation tracer sometimes attributes allocations to the wrong source file/line
-
04:16 AM Bug #11459 (Closed): Ruby leaks several MB of memory every setup/eval/cleanup cycle.
- `ruby_cleanup` should only be called once per process, before exiting (either via `main`->`ruby_run_node` or `ruby_stop`). It is not expected to free all memory allocated earlier, since the process will be exiting and the operating syst...
-
04:03 AM Bug #11443 (Closed): DNS name resolution takes twice as long as it should when primary name server is unavailable
-
03:24 AM Revision 75d9fa8b (git): Detect VCS from the current directory by default [ci skip]
-
03:24 AM Revision 0d1af9f9 (git): Push commits notes too [ci skip]
- 02:20 AM Revision f78916e3 (git): * expand tabs.
-
02:03 AM Revision c215a6f2 (git): Removed non-VM_OBJSPACE code
- It has not been used for 4 years, since r60856,
e33b1690d06f867e45750bd8e3e8b06d78b5bc26. -
01:56 AM Revision 2f744f53 (git): Refactored `objspace_each_objects`
- As `rb_objspace_each_objects_without_setup` doesn't reset and
restore `dont_incremental` flag, renamed the bare iterator as
`objspace_each_objects_without_setup`. `objspace_each_objects`
calls it when called with the flag disabled, wrap... -
01:33 AM Revision 0c1c42c4 (git): Move rb_objspace_t* in objspace_reachable_objects_from_root to an argument
- 12:50 AM Revision aec93417 (git): * expand tabs.
-
12:47 AM Revision ac656bc2 (git): Hoisted out GPR_DEFAULT_REASON
-
12:47 AM Revision 917d7665 (git): Move rb_objspace_t* in gc_verify_internal_consistency to an argument
-
12:47 AM Revision 0c2d81da (git): Renamed ruby_finalize_{0,1}
- And pass rb_execution_context_t as an argument.
-
12:00 AM Bug #11478 (Closed): symlinks support broken on win32
08/12/2019
-
11:59 PM Bug #11467 (Closed): Memory leak in win32 signal init
-
11:57 PM Bug #11442 (Closed): Bug: Symbols should be taintable.
- Ruby makes `taint` and `untaint` just return the receiver if called on any object that is not considered taintable. That includes all immediate objects (symbols, integers(fixnums), true, false, nil), as well as integers(bignums) and flo...
-
11:37 PM Bug #11437 (Closed): IO.pipe problem on windows console
-
11:35 PM Bug #11399 (Rejected): Regexp's free-spacing mode adding whitespace to character classes
- This is not a bug. The documentation suggestions the use of character classes if you want to match whitespace (https://docs.ruby-lang.org/en/trunk/regexp_rdoc.html#label-Free-Spacing+Mode+and+Comments).
-
11:33 PM Bug #11381 (Closed): String のサブクラスをハッシュのキーに指定した時に hash メソッドが呼ばれない
-
11:33 PM Bug #11359 (Closed): scalar_scanner segmentation fault
-
11:27 PM Bug #11261 (Closed): Time.parse of javascript formatted timestamp: wrong results in certain timezones
-
11:22 PM Bug #11214 (Closed): Cannot Get Correct Binding from inside of C Method
-
11:21 PM Bug #11205 (Closed): Problem with __dir__ or it's description
- I don't think this is a bug in `__dir__`. It's just that `__FILE__` inside `eval` depends on either the binding or file argument given to `eval` (in Ruby 3, it will only depend on the file argument, see #4352).
If you rewrite your ex... -
11:06 PM Bug #4352 (Open): [patch] Fix eval(s, b) backtrace; make eval(s, b) consistent with eval(s)
-
10:59 PM Bug #11189: alias prepended module
- ko1 (Koichi Sasada) wrote:
> ちなみに、私の予想は
> ...
This output would be against my expection. If `C1` prepends `P`, then methods in `P` must be considered before methods in `C1`. Consider `C1.ancestors`:
```ruby
[P, C1, C0, Object, Ke... -
10:23 PM Bug #11188: Method#inspect for chaining alias methods
- I agree with ko1's opinion. Attached is a patch that implements his proposal.
Note that this change cannot be made in `method_inspect`, because at that time, the necessary information has already been lost. To implement ko1's propos... -
09:13 PM Bug #14972: Net::HTTP inconsistently raises EOFError when peer closes the connection
- naruse (Yui NARUSE) wrote:
> joshc (Josh C) wrote:
> ...
If you save the first response body, and make a new request with ```Range: bytes=X-Y```, then the `Content-Length` header in the second response should specify the number of byte... -
08:44 PM Revision aac4d9d6 (git): Rename rb_gc_mark_no_pin -> rb_gc_mark_movable
- Renaming this function. "No pin" leaks some implementation details. We
just want users to know that if they mark this object, the reference may
move and they'll need to update the reference accordingly. -
06:08 PM Bug #11175 (Closed): possible fibers memory leak or risky GC behavior
-
06:02 PM Bug #11160 (Closed): Subclasses of Proc converted when passed to a block
- This was fixed between Ruby 2.2 and 2.3:
`t.rb`:
```ruby
class MyClass < Proc
end
def foo (&x)
p [:foo, x.class]
end
x = Proc.new {|&x| p [:x, x.class]}
z = MyClass.new {}
foo &z
x.call &z
```
output:
```
$ ruby2... -
05:55 PM Bug #11152: Resolv::DNS should use Search Domains provided in /etc/resolv.conf by default
- It looks like the problem is a kubernetes-specific issue. With your `resolv.conf` file, I get the following for `Resolv::DNS::Config.default_config_hash`:
```
{:nameserver=>["10.7.240.10"], :search=>["staging.svc.cluster.local", "sv... -
05:25 PM Bug #11134 (Closed): resolution of "localhost" in windows server 2012 (ipv6 over ipv4)
- I don't think this is a bug. `TCPServer.new` binds to the first address that matches for the hostname. In your example, you are explicitly binding to the IPv6 address and not the IPv4 address, so if the DNS resolution in your environme...
-
05:13 PM Bug #11102 (Closed): Segmentation fault while running the db:create command in Rails
-
05:01 PM Bug #10691 (Closed): Bad or Non-existent class names listed on 'Index of Files, Classes & Methods in Ruby' page.
- Applied in changeset commit:git|404850e13446c79fb6142f1b32b219753e5cd726.
----------
Remove documentation that fatal cannot be rescued [ci skip]
You can rescue it:
f = ObjectSpace.each_object(Class){|c| break c if c.name == 'fatal'}
b... -
05:34 AM Bug #10691: Bad or Non-existent class names listed on 'Index of Files, Classes & Methods in Ruby' page.
- ```ruby
Thread.start{Thread.stop}
begin
Thread.stop
rescue Exception => fatal
p fatal.class #=> fatal
end
``` -
04:56 AM Bug #10691: Bad or Non-existent class names listed on 'Index of Files, Classes & Methods in Ruby' page.
- The documentation is not accurate indeed.
To be accurate, it is impossible to rescue the `fatal` raised by `rb_fatal` function. -
02:49 AM Bug #10691: Bad or Non-existent class names listed on 'Index of Files, Classes & Methods in Ruby' page.
- `Complex::compatible`, `unknown`, `Rational::compatible` were removed by Ruby 2.6.0. `fatal` is still documented, but that exists even though you cannot reference it directly:
```ruby
f = ObjectSpace.each_object(Class){|c| break c i... -
04:56 PM Revision 404850e1 (git): Remove documentation that fatal cannot be rescued [ci skip]
- You can rescue it:
f = ObjectSpace.each_object(Class){|c| break c if c.name == 'fatal'}
begin
raise f
rescue f
2
end # => 2
It's not a good idea to rescue fatal exceptions you didn't generate
yourself, though.
Fixes [Bug #10691] -
04:53 PM Misc #16094 (Assigned): Allow only "Rebase and merge" or "Squash and merge" on GitHub master branch, and sync it on git.ruby-lang.org update hook
- This is almost implemented. It's still under testing and only available for admin now, but you may see some usages for testing. I'll add one more guard and then enable "write" to merge pull requests for ruby-committers team.
I also no... -
11:26 AM Misc #16094: Allow only "Rebase and merge" or "Squash and merge" on GitHub master branch, and sync it on git.ruby-lang.org update hook
- Experimentally, I'll move GitHub sync from post-receive hook to update hook, which blocks git push a little more. Still most of the behavior would be the same, but you might feel git push became slower.
-
08:09 AM Misc #16094: Allow only "Rebase and merge" or "Squash and merge" on GitHub master branch, and sync it on git.ruby-lang.org update hook
- > we found that we could automatically attach notes to "Rebase and merge"d commits on our git.ruby-lang.org's post-commit hook.
I implemented this in https://github.com/ruby/ruby-commit-hook/blob/d05f66c9df2eabe45f7cb1d8bd3d51c356144e... -
04:45 PM Revision 3979f22c (git): Explain the current status of branches [ci skip] (#2350)
- 04:34 PM Revision e688ab26 (git): * expand tabs.
-
04:34 PM Revision 6749682f (git): also unpin `final` on weak maps
-
04:34 PM Revision 76a928ba (git): Unpin default value objects
- We're already updating the location of default values, so we may as well
unpin them. -
04:29 PM Revision 4e418a6c (git): Update check_branch description a little [ci skip]
-
04:21 PM Revision 957bdfba (git): Update docs to use more natural English
- Just a few updates to make the English sound a bit more natural
-
04:03 PM Revision 0f10828f (git): Fix a typo [ci skip]
- 03:51 PM Revision 4d3fb247 (git): * 2019-08-13
-
03:48 PM Revision b8b5e7d5 (git): Stop rewriting message to include PR URL
-
02:44 PM Revision edd25382 (git): Add a quick job to be used for branch protection
-
02:28 PM Revision 8d302c91 (git): string.c (rb_str_sub, _gsub): improve the rdoc
- This change:
* Added an explanation about back references except \n and \k<n>
(\` \& \' \+ \0)
* Added an explanation about an escape (\\)
* Added some rdoc references
* Rephrased and clarified the reason why double escape is needed, ... -
11:41 AM Revision 3fc10eff (git): date_parse.c: trim off
- * ext/date/date_parse.c (date_zone_to_diff): trim off by zone name
length. -
11:41 AM Revision d96feee3 (git): date_parse.c: avoid copying
- * ext/date/date_parse.c (date_zone_to_diff): get rid of copying
the whole argument string. -
11:40 AM Revision e6a0a954 (git): Add another test for frame omitted inlining
-
11:20 AM Revision a5f93060 (git): Simplify sudo specification
-
11:11 AM Revision 18838105 (git): added --disable-install-doc to Windows workflow of GitHub Actions
- Closes: https://github.com/ruby/ruby/pull/2346
-
11:11 AM Revision ab3ab07b (git): Removed configuration of Azure Pipelines
-
11:11 AM Revision 8d50bf40 (git): Try to nmake test
-
11:11 AM Revision 0fd0f745 (git): Try to merge windows 2016 and 2019
-
11:11 AM Revision 040bf4c0 (git): Added windows-2019 workflow
-
11:11 AM Revision 981f0be6 (git): Try to nmake
-
11:11 AM Revision bbc5e97b (git): Migrate Windows 2016 env to GitHub Actions from AzurePipelines
-
10:52 AM Revision 1bec27f0 (git): Add exec to apt-get update
- to propagate exit status to travis_retry properly.
-
10:13 AM Revision f9149c55 (git): Minor wording fix in NEWS [ci skip]
- pushing a trivial commit for testing post-receive hook
-
10:02 AM Revision 066a3498 (git): Include commits notes in ChangeLog
-
09:34 AM Misc #16091 (Closed): gsub
-
08:55 AM Revision 5edf921e (git): Revert "Roughly retry `brew update` on GitHub Actions"
- This reverts commit 5ee11a95ffbf194a73d1bea300a35f5d6250d203.
Sorry, timeout(1) was missing. -
08:46 AM Revision 927a43a5 (git): Drop unused ccache
- unlike Travis, it seems not used.
-
08:44 AM Revision 5ee11a95 (git): Roughly retry `brew update` on GitHub Actions
- because it has failed often on Travis.
-
08:15 AM Feature #14164: [Suggestion] Type system for ruby 3x to be usable for e. g. rubocop or autogenerating crystal code and so forth
- >> Crystal is in many ways similar to ruby;
> ...
To the best of my memory/understanding, it is not a myth, but a _historical_ fact: Crystal started as an attempt to just make a "compiled Ruby" (probably with type system, but "invisib... -
07:37 AM Revision d5250808 (git): Try testing openssl@1.1 on GitHub Actions
- because somebody may want to remove the duplicated Travis osx usage
later. - 07:11 AM Revision 765cc17c (git): Update IRB man page
-
06:14 AM Revision 0d0ff827 (git): rb_trap_exec has been removed since 1.9
-
05:37 AM Revision b1ef1417 (git): We did not have tool/ before checkout
- anyway we don't need authorization here.
Also retry does not seem to work in the original version, so let's
extend this with retries as a separate github action later. -
05:30 AM Revision 4f10a61e (git): Stop relying on actions/checkout
- because it randomly fails on authorization like:
https://github.com/ruby/ruby/runs/190887455
Also the backoff seems too short. Maybe we need tool/travis_retry.sh for
this too.
Cloning ruby/ruby does not need authorization. We don't need... -
05:11 AM Revision 2b3d84d5 (git): Use rev-parse
- Use simpler rev-parse to check if pull request was fetched.
-
04:48 AM Bug #10453: NUM2CHR() does not perform additional bounds checks
- As `CHR` should stand for `char` type of C, so exceeding the limit of `char` will make confusion, I guess.
I'm curious for what purpose @silverhammermba needs the range check.
If it is to get a codepoint, I don't think extracting the... -
02:41 AM Bug #10453: NUM2CHR() does not perform additional bounds checks
- Attached is a patch that will add a range check to `NUM2CHR`. However, it breaks a test:
```
1) Error:
TestStringIO#test_putc_nonascii:
RangeError: value to large to convert to char: 12356
/home/jeremy/tmp/ruby/test/stringio/... -
04:45 AM Revision b1ad628c (git): Resurrect travis_wait for test-all
- as we dropped -v.
-
04:37 AM Bug #10778 (Rejected): `defined?(expr)` should be equivalent to `defined? (expr)` not `(defined? expr)`
- In Ruby, a space before an opening parenthesis often has significant meanings.
Combining `defined?(a)` higher than `&&` is considered reasonable. -
02:21 AM Bug #10778: `defined?(expr)` should be equivalent to `defined? (expr)` not `(defined? expr)`
- There isn't a description of the actual problem caused by this behavior, but I'm guessing, it is something like this:
```ruby
defined? a && defined? b # defined?(a && defined? b)
# => "expression"
defined? (a) && defined? (b) # d... -
04:02 AM Bug #11055: autoload resets private_constant
- I doubt dropping the existing constant visibility information is intentional behavior. You can work around the current behavior by resetting `private_constant`/`deprecate_constant` inside the autoloaded file, but that leads to duplicati...
- 03:59 AM Revision 63d3c4fe (git): * 2019-08-12
-
03:58 AM Revision bf1f8729 (git): Removed duplicated jobs with GitHub Actions.
- Closes: https://github.com/ruby/ruby/pull/2340
-
03:45 AM Bug #16098 (Closed): SEGV with RUBY_ISEQ_DUMP_DEBUG=to_binary make check
- I get a SEGV in `TestSetTraceFunc` when I run `env RUBY_ISEQ_DUMP_DEBUG=to_binary make check`.
The crash doesn't happen when I run just that test file with `make test-all TESTOPTS="test/ruby/test_settracefunc.rb"`.
I only investigated ... -
03:14 AM Revision ed9d59af (git): Added example filter for Linux of GitHub Actions.
-
03:14 AM Revision 8a8f680f (git): Re-use GITHUB_ACTION variables for filtering bundler examples.
-
03:14 AM Revision e96321d0 (git): Removed make check
-
03:14 AM Revision fc97aa93 (git): Fixed the world writable dirs on Ubuntu environment.
-
03:14 AM Revision cfb192a7 (git): Added test-bundled-gems to GitHub Actions
-
03:01 AM Revision 11a09d78 (git): Port ubuntu workflow based on macos
-
02:51 AM Bug #10895 (Closed): /usr/lib/ruby/2.2.0/socket.rb:232: [BUG] rb_sys_fail(getaddrinfo) - errno == 0
-
02:23 AM Bug #10655 (Closed): Segmentation fault on chef-client run
-
02:23 AM Bug #10788 (Closed): Timeout not work with socket
-
02:23 AM Bug #10789 (Closed): X-forwarded-Proto required when using Reverse Proxy
-
02:22 AM Bug #10842 (Closed): rake update to 10.4.2 -> Segmentation fault : ruby 2.1.5p273 (2014-11-13 revision 48405) [x64-mingw32]
-
01:58 AM Bug #10626 (Closed): BUS error from nesting lambda's and calls to methods defined with define_method
-
01:58 AM Bug #10632 (Closed): 2.2rc1 Fails to Compile with Mingw64 NET_LUID
08/11/2019
-
11:26 PM Bug #10314: Default argument lookup fails in Ruby 2.2 for circular shadowed variable names
- Attached is a patch to turn circular argument reference from a warning to a SyntaxError. Do we still want to do that?
-
10:00 PM Feature #14164: [Suggestion] Type system for ruby 3x to be usable for e. g. rubocop or autogenerating crystal code and so forth
- shevegen (Robert A. Heiler) wrote:
> Crystal is in many ways similar to ruby;
It really isn't. I don't know where this myth originated and why it is so widespread and persistent.
> ...
Yes, that is true. However, of the three part... -
09:34 PM Feature #14399: Add Enumerable#product
- jzakiya (Jabari Zakiya) wrote:
> That's interesting because I never intuitively understood the use of `inject`
This is bastardized from Smalltalk. In Smalltalk, method names consist of multiple words and the arguments are written in ... -
09:10 PM Feature #14781: Enumerator.generate
- zverok (Victor Shepelev) wrote:
> > However, literally as I am writing this, a thought pops into my mind: how about Enumerator::produce as the dual to Enumerable#reduce? Scala also has iterate which is the restricted variant of unfold.
... -
08:34 PM Feature #14781: Enumerator.generate
- > However, literally as I am writing this, a thought pops into my mind: how about Enumerator::produce as the dual to Enumerable#reduce? Scala also has iterate which is the restricted variant of unfold.
In the [first](https://bugs.ruby... -
08:06 PM Feature #14781: Enumerator.generate
- zverok (Victor Shepelev) wrote:
> This is alternative proposal to `Object#enumerate` (#14423), which was considered by many as a good idea, but with unsure naming and too radical (`Object` extension). This one is _less_ radical, and, at... -
10:30 AM Feature #14781: Enumerator.generate
- Attached is a patch with the implementation I initially described, and with the name Matz seems to be accepting of (`Enumerator.generate`).
I am not 100% sure about the code (as it is my first contribution to core C code), but at least ... -
08:46 PM Feature #14701: If the object is not frozen, I want to be able to redefine the compound assignment operator.
- It is possible to find sane semantics for this. [Scala](https://scala-lang.org/files/archive/spec/2.13/06-expressions.html#assignment-operators), for example, has the following semantics:
```scala
a ω= b
```
is first tried to be ... -
08:30 PM Feature #16095: 2 Features: remove (simplify) 'new' keyword and Property Shorthand
- **figured out how to do it:**
``` ruby
%P[arg1 arg2]
```
in def initialize:
``` ruby
def initialize(arg1, arg2)
%P[arg1 arg2] # equals to: @arg1 = arg1, @arg2 = arg2
end
```
in hash:
``` ruby
a = 1
b = 2
h = %p[a b]... -
08:00 AM Feature #16095: 2 Features: remove (simplify) 'new' keyword and Property Shorthand
- First, please do not mix requests for irrelevant features in one ticket.
D1mon (Dim F) wrote:
> I correctly understood that this function will be added in version 2.7? https://github.com/ruby/ruby/pull/2231/commits/7da3cdc9aa132307ef... -
07:31 AM Feature #16095: 2 Features: remove (simplify) 'new' keyword and Property Shorthand
- I correctly understood that this function will be added in version 2.7? https://github.com/ruby/ruby/pull/2231/commits/7da3cdc9aa132307eff0e4376ad6a3819940fc2d
-
07:24 AM Feature #16095: 2 Features: remove (simplify) 'new' keyword and Property Shorthand
- Feature 1: I agree that you can do anything with the help of metaprogramming, and this will have to be registered in each library. Therefore, I propose to do this at the language level (Ruby core).
-
08:26 PM Bug #10167: Prime#include?(mod) hangs up
- I've added a pull request for this at https://github.com/ruby/prime/pull/6.
-
08:01 PM Bug #9986: WEBrick content-length being set when transfer-encoding is chunked
- I added a pull request for this: https://github.com/ruby/webrick/pull/24
-
07:44 PM Bug #9868 (Closed): bigdecimal#VpAlloc causes out-of-bounds read
- I think this is fixed by https://github.com/ruby/bigdecimal/commit/e738c1377108baa0c2fd03cdee0eeb1239f627b2.
-
07:43 PM Feature #14967: Any type
- baweaver (Brandon Weaver) wrote:
> In Scala, there's the concept of an Any type which can be used to match anything.
This is a very odd characterization of `scala.Any`. In Scala, `Any` is the *top type* (in the type-theoretical sense... -
07:36 PM Bug #9836: Bad Implementation of Time.strptime
- I tried updating the patch to apply to the master branch (it is attached). It doesn't appear to handle `%W` correctly:
```ruby
str = Time.local(2019, 1, 30).strftime('%w %W %Y')
# => "3 04 2019"
Date.strptime(str, '%w %W %Y')
#... -
07:32 PM Bug #14241: Time.strptime() doesn't support the directive "%W".
- Here's an updated patch that handles `%V`, `%g`, and `%G` as well.
-
06:23 PM Bug #9822: Ruby doesn't respect system OpenSSL configuration
- I submitted a pull request to ruby-openssl to use `OPENSSL_config`: https://github.com/ruby/openssl/pull/267
-
06:23 PM Bug #9833 (Closed): OpenSSL::X509::Certificate#inspect がわかりにくくなっている
- This was fixed between Ruby 2.4 and 2.5:
```
$ ruby24 t/t.rb www.ruby-lang.org 443
#<OpenSSL::X509::Certificate: subject=#<OpenSSL::X509::Name:0x000005eb8490b120>, issuer=#<OpenSSL::X509::Name:0x000005eb8490b058>, serial=#<OpenSSL:... -
05:52 PM Bug #9774 (Closed): Net::HTTP failure to validate certificate
-
05:50 PM Bug #9759 (Closed): [TracePoint API] return event missing when raising exception
-
05:49 PM Bug #9712 (Closed): Dir.entries replace Unicode character with questionmarks
-
05:48 PM Bug #9643 (Closed): error on install dir contain space .
- This should be fixed by commit:4de117a61517e839f2c45eaf45d56fc243d6d5b2, which updated to Rubygems 2.4.1 and removed the use of `RUBYOPT` from `Gem::Ext::ExtConfBuilder.build`.
-
05:43 PM Bug #9641 (Closed): Digest libraries are built incorrectly due to ambiguous location of "extconf.h"
-
05:41 PM Bug #9504 (Feedback): X509 certificate incorrectly loaded (because of try-pem-first-else-asn1)
- I worked on implementing support for adding a :format keyword to `OpenSSL::X509::Certificate#initialize`, allowing you to specify `format: :der` if you didn't want to try loading it as a PEM. A patch for that is attached (for the ruby-o...
-
04:34 PM Bug #9564 (Rejected): Tainted string permitted in Kernel.trap in safe level 1
-
03:40 PM Bug #16097 (Closed): [PATCH] Don't accidentally name anonymous module/class
- My patch in #15765 accidentally introduced a behavior change.
`ruby -ve 'Module.new { class self::A; end; p name }'` outputs a name
similar to `Module#inspect` when it should output `nil` like in Ruby 2.6.x.
I have a pull request to... -
03:12 PM Feature #15236: add support for hash shorthand
- Well, if the syntax is misleading or intersects with an existing design. Make another syntax to work, why cancel (reject) a very cool thing which will make the code smaller (write less) and it will be nice to read the code. ? Please do n...
-
12:18 PM Bug #15965: String#grapheme_clusters does not work with wide encodings
- ruby_2_6 r67741 merged revision(s) 8aecc90974ab1ac87056f77e2cb3406c5c041504,2f6cc15cdb3d64135b29cfd5ee376a5a03ebbee7.
-
12:17 PM Revision ad6ffac7 (git): merge revision(s) 8aecc90974ab1ac87056f77e2cb3406c5c041504,2f6cc15cdb3d64135b29cfd5ee376a5a03ebbee7: [Backport #15965]
- Hoisted out WIDE_ENCODINGS
Fixed String#grapheme_clusters with wide encodings
* string.c (get_reg_grapheme_cluster): make regexp from properly
encoded sources fro wide-char encodings. [Bug #15965]
*... -
10:35 AM Misc #15996: DevelopersMeeting20190829Japan
- * [Feature #14781] `Enumerator.generate`. Patch provided; Matz seem to have liked the idea and name proposed, can we have it in 2.7?
* [Feature #14784] `Comparable#clamp` with a range. Implementation details are discussed, but generally... -
09:33 AM Misc #16096: each in each (multiple uses 'each')
- this method is not suitable since the 3rd search (find_elements) is also used.
Are you saying this is a bug? you can do issue? -
07:41 AM Misc #16094: Allow only "Rebase and merge" or "Squash and merge" on GitHub master branch, and sync it on git.ruby-lang.org update hook
- As @nobu wanted to know which commit is associated to which pull request using git without accessing GitHub, he experimented `git notes` a little bit, and we found that we could automatically attach notes to "Rebase and merge"d commits o...
-
04:29 AM Misc #16094: Allow only "Rebase and merge" or "Squash and merge" on GitHub master branch, and sync it on git.ruby-lang.org update hook
- I'm personally okay with "squash and merge" too, especially because "rebase and merge" cannot update a commit message when we want to add a thing like `[Bug #12345]`. We can allow both "rebase and merge" and "squash and merge", and make ...
-
04:16 AM Misc #16094: Allow only "Rebase and merge" or "Squash and merge" on GitHub master branch, and sync it on git.ruby-lang.org update hook
- "Rebase and merge" makes the target commits unable to track the original pull request from `git log`.
So I propose "squash and merge", or pushing a marking commit at the sync after "rebase and merge". -
07:20 AM Revision 9fe7e042 (git): Note the reference to the pull request [ci skip]
-
06:47 AM Revision 51d9d0f8 (git): Use already fetched pull request [ci skip]
-
05:15 AM Revision 1c7eadf7 (git): Debug which test hangs on mswin
- debugging failure of
https://ci.appveyor.com/project/ruby/ruby/builds/26613960/job/nemi6pvc5s5843io -
03:17 AM Revision 053bee64 (git): Cleanup the duplicated tasks on Azure Pipelines.
- Closes: https://github.com/ruby/ruby/pull/2336
-
03:17 AM Revision 91fcd87f (git): Increase fetch-depth
-
03:17 AM Revision bb2f2425 (git): GitHub Actions does not support ANSI color code. Skip failing examples.
-
03:17 AM Revision c685679e (git): Use check.
-
03:17 AM Revision e7996e0f (git): Try to migrate test-bundler to Actions.
-
02:44 AM Bug #16050: :@ is not parsed correctly
- Ah, but `:@1` is not parsed either, even though it's now (unfortunately) valid as a numbered block parameter.
Depending on how #15723 goes, `:@1` and/or `:@` should be parsed if they are valid identifiers. -
02:26 AM Feature #15192: Introduce a new "shortcut assigning" syntax to convenient setup instance variables
- Instead of an entirely new syntax maybe something like this would be good enough?
```ruby
def set_ivars_from_locals(binding, except: [])
names = binding.local_variables - except
values = eval("["+names.join(",")+"]", binding)
... -
02:01 AM Revision 6017e81b (git): Update power_assert to 1.1.5
-
01:15 AM Revision f731cc09 (git): Use `end_with?` instead of Regexp with missing escape
08/10/2019
-
11:54 PM Misc #16093 (Rejected): Prohibit a "foxtrot merge" instead of a merge commit
-
08:14 PM Misc #16093: Prohibit a "foxtrot merge" instead of a merge commit
- Looks good to me. If I'm not mistaken, neither "Rebase and merge" nor "Squash and merge" create merge commits, they are just fast forward merges, so both could be choices acceptable in the UI.
-
02:35 PM Misc #16093: Prohibit a "foxtrot merge" instead of a merge commit
- k0kubun (Takashi Kokubun) wrote:
> As @marcandre suggested, I thought of an approach to use "Rebase and merge", [Misc #16094]. In that plan, we'll be able to make a pull request "Merged" without creating a merge commit, while we continu... -
09:34 AM Misc #16093 (Feedback): Prohibit a "foxtrot merge" instead of a merge commit
- As @marcandre suggested, I thought of an approach to use "Rebase and merge", [Misc #16094]. In that plan, we'll be able to make a pull request "Merged" without creating a merge commit, while we continue to use git.ruby-lang.org as the Ru...
-
05:02 AM Misc #16093: Prohibit a "foxtrot merge" instead of a merge commit
- > I'm probably missing something, but Github allows rebasing from the UI.
GitHub UI allows "rebase and merge" but
1. Our primary repository is git.ruby-lang.org; we don't use "rebase and merge" on GitHub
2. Because of 1., we need to... -
03:52 AM Misc #16093: Prohibit a "foxtrot merge" instead of a merge commit
- Thank you for your comment.
> I'm probably missing something, but Github allows rebasing from the UI.
There are three situations:
1. The parent of a pull request's commits is master:
* It's the only situation which is *not* ... -
11:32 PM Misc #16096 (Rejected): each in each (multiple uses 'each')
- D1mon (Dim F) wrote:
> **selenium**
> ...
You probably want something like:
```ruby
driver.find_elements(xpath: "...").each do |el|
(el.find_elements(xpath: "...").to_a + el.find_elements(xpath: "...").to_a).each do |e1|
# ... -
11:15 PM Misc #16096: each in each (multiple uses 'each')
- **selenium**
``` ruby
for el in driver.find_elements(xpath: <some_xpath>)
for e1 in el.find_elements(xpath: ...)
...
end
for e2 in el.find_elements(xpath: ...)
...
end
end
```
I need to do two searches in one... -
10:35 PM Misc #16096: each in each (multiple uses 'each')
- In ruby it is in general very rare that deeply nested (and multiple) .each
are necessary.
I recommend to you to use "pp" before you run the loop, such as:
pp obj
Perhaps you have an empty Array there - that happens to me so... -
10:27 PM Misc #16096 (Feedback): each in each (multiple uses 'each')
- Can you explain what you are trying to do, and provide a self-contained example? It is not clear from the description or the code what you think the problem is. I can only guess that the object returned by `a.some_method2` has an `each...
-
09:43 PM Misc #16096 (Rejected): each in each (multiple uses 'each')
- ``` ruby
obj.each {|a|
a.some_method1.each {|b|
... # comes here (enter)
}
a.some_method2.each {|c|
... # does not enter here
}
}
# tried and that way. also does not go
for a in obj
for b ... -
11:30 PM Misc #16091: gsub
- alanwu (Alan Wu) wrote:
> `gsub(pattern, replacement)` always interprets `replacement` as a regex replacement directive.
> ...
Nice, tank you. -
04:12 AM Misc #16091: gsub
- `gsub(pattern, replacement)` always interprets `replacement` as a regex replacement directive.
You can use the block form to substitute verbatim:
```ruby
a = "test ?"
b = "?"
c = "\\&"
a.gsub(b) { c } #=> "test \\&"
```
-
12:24 AM Misc #16091: gsub
- #### on Python 3.7.1
```python
import html
def r():
a = input('Enter original:')
b = input('Enter a pattern to replace:')
c = input('Enter a replacement:')
print(f"a: {a}")
print(f"b: {b}")
print(f"c: {c}")
c = ht... -
12:05 AM Misc #16091 (Open): gsub
-
12:04 AM Misc #16091: gsub
- ```ruby
include ERB::Util
def r
puts "Enter original"
a = gets.chomp
puts "Enter a pattern to replace"
b = gets.chomp
puts "Enter a replacement"
c = gets.chomp
puts "a: #{a}"
puts "b: #{b}"
puts "c: #{c}"
... -
10:40 PM Feature #16095: 2 Features: remove (simplify) 'new' keyword and Property Shorthand
- The net-gain from removing .new would be quite minimal. I also think it is less
readable too, if .new were removed - but even well aside from this, this seems to
be backwards incompatible and may have to require a long transition time ... -
10:22 PM Feature #16095: 2 Features: remove (simplify) 'new' keyword and Property Shorthand
- D1mon (Dim F) wrote:
> 1) feature: remove 'new' keyword:
> ...
`new` is a method, not a keyword. You can already get what you want:
```
module Kernel
private
def A(arg1, arg2)
A.new(arg1, arg2)
end
end
```
Add... -
09:16 PM Feature #16095 (Rejected): 2 Features: remove (simplify) 'new' keyword and Property Shorthand
- **common use:**
``` ruby
class A
def initialize(arg1, arg2)
@arg1 = arg1
@arg2 = arg2
end
end
A.new(1,2)
```
1) feature: remove 'new' keyword:
``` ruby
A(1,2) # shorter and more comfortable
```
2) feature:... -
09:14 PM Revision 2990c2cc (git): Use capture_output instead of capture_io.
- It's preparation for migrating test-unit on upstream.
-
06:46 PM Bug #10220 (Closed): enc/trans/*.c の依存関係不足?
-
06:44 PM Bug #9017 (Closed): irb crash with message "... 'join': incompatible character encodings: ASCII-8BIT and UTF-8 ..."
- This was fixed between Ruby 2.0 and 2.1:
```
$ irb20 -I pyper/lib -r pyper
irb(main):001:0> [''].τmsτ # τ is Greek tau
ArgumentError: no method name given
/usr/local/lib/ruby/2.0/irb.rb:526:in `join': incompatible character encod... -
06:39 PM Bug #10246 (Closed): CSV.parse(csv_string, headers: col_headers) reports undefined method `table'
-
03:54 PM Feature #15912: Allow some reentrancy during TracePoint events
- Regarding your questions, `reopen` would work for me, and regarding passing events, I think a list of the events to be reopened like `TracePoint.new(*events)` would work.
If I understand what you are proposing, we would be giving full... - 03:45 PM Revision 7ee948c3 (git): * 2019-08-11
-
03:44 PM Revision d29bccb3 (git): Adjust indent [ci skip]
-
03:44 PM Revision 46df7fe9 (git): prereq.status deals with removal of nmake VPATH notations [ci skip]
-
03:18 PM Bug #10011 (Closed): Passing a string to Pathname#relative_path_from results in NoMethodError
- This was fixed between Ruby 2.5 and 2.6:
```
$ ruby25 -r pathname -e 'p Pathname.new("/usr/bin/cc").relative_path_from("/usr/bin")'
Traceback (most recent call last):
1: from -e:1:in `<main>'
/usr/local/lib/ruby/2.5/pathn... -
03:15 PM Bug #9850 (Closed): FileUtils.mv shouldn't try to make sure the owner is preserved
-
02:58 PM Bug #9365 (Closed): Sporadic TypeError (wrong argument type Thread (expected VM/thread)) from IO#close (via Net:HTTP)
-
02:57 PM Revision 0609087a (git): Parallelize osx test-all too
-
02:50 PM Bug #8770 (Closed): [PATCH] process.c: avoid EINTR from Process.spawn
-
02:49 PM Bug #8594 (Closed): [BUG] rb_update_max_fd: invalid fd (4) given
-
02:37 PM Bug #8178 (Closed): OpenSSL::PKCS7::SignerInfo
-
02:30 PM Revision c21c0017 (git): Re-enable parallel build/test on OSX
-
02:19 PM Revision 52bd4716 (git): rb_numeric_quo: support Complex
-
11:25 AM Revision c1c85770 (git): Fix wrong pull_request filter
- The specification was not triggered on a pull request.
-
10:50 AM Revision 00e7ef7e (git): Suppress flags messages [ci skip]
-
10:44 AM Revision a6c5ce7a (git): Increase the fetch-depth of GitHub Actions
- because small numbers had made Azure Pipelines in the past and it's
using 20 now. I heard GitHub Actions has more parallelism, so it should
be okay. -
10:38 AM Revision b3903ef2 (git): Set more descriptive labels to workflow
-
10:33 AM Revision 59a8003a (git): Drop confusing label from workflow
- because it's doing more than test-all
-
10:29 AM Revision 6205f955 (git): Escape asterisk on pull request paths
-
10:28 AM Revision e43b3bb4 (git): Skip running GitHub Actions on trunk
-
10:19 AM Revision 9b203959 (git): Rename workflow.yml to macos.yml
- to allow having other workflows separately, and configure `name` to
simplify a tooltip label on GitHub. -
09:30 AM Misc #16094 (Closed): Allow only "Rebase and merge" or "Squash and merge" on GitHub master branch, and sync it on git.ruby-lang.org update hook
- ## Problem
* Our pull request merge strategy confuses contributors, as described in [Misc #16093].
* In [Misc #16093], some committers did not like accepting a merge commit.
## Solution
* Allow using GitHub's "Rebase and merge" (su... -
07:33 AM Revision 5e3fb0b3 (git): Touch the checked out source to fix clock skew on all platform
-
06:48 AM Revision c5fbe2a1 (git): Moved options to $travis_apt_get_options
-
05:57 AM Bug #16087 (Third Party's Issue): Signal.trap(:INT) doesn't work on msys2 mingw64 ?
- This was due to the limit of mintty.
There can be a chance that this will be solved by mintty (and other terminal emulators for Windows) using Windows Pseudo Console in the future, I guess. -
05:38 AM Revision d69ffa4d (git): Expanded f_quo
-
05:31 AM Bug #8542: BigMath::exp modifies its first argument
- This bug is still present in the master branch. This is actually a fairly significant bug since Ruby 2.6, as starting in Ruby 2.6, BigDecimal instances are frozen and should never be mutated. Attached is a patch that fixes this issue. ...
-
05:22 AM Revision 98c22c78 (git): Expanded f_real_p
-
04:42 AM Bug #8400 (Closed): skip `Rinda::TestRingFinger` tests on platforms not implementing `getifaddrs()`
- This should be fixed by commit:66ee8a17852bb7657712afd3ac088a8b9b293d71;
-
04:36 AM Bug #8442 (Closed): sendmesg (blocking) of class BasicSocket is repeatably sent by the ruby kernel
-
04:33 AM Bug #8297: extend & inherited class variable issue
- This bug is still present in the master branch. I think the best way to fix it is to modify `Module#class_variables` for singleton classes of classes/modules to use the same lookup order as `Module#class_variable_get`:
* Singleton Cl... -
04:18 AM Revision ffdef367 (git): Warn instance variable `E`
- It is not dumped, as it is a short alias for `:encoding`.
- 02:43 AM Revision 3c3783ac (git): * expand tabs.
-
02:38 AM Revision ab31693a (git): Share caches for short encoding ivar name.
-
02:26 AM Revision 07e42e88 (git): Close created files [ci skip]
-
12:35 AM Revision 69028247 (git): Fix typo in comment [ci skip]
- s/Thtread/Thread
-
12:34 AM Revision 49f88eb2 (git): Try building workflow on push
-
12:06 AM Revision 789776be (git): Added some examples to the documentation for String#unpack1 because
- there are currently no examples and to contrast with String#unpack.
08/09/2019
-
11:59 PM Misc #16093: Prohibit a "foxtrot merge" instead of a merge commit
- Another +1 for no merge commits.
> Therefore, we have not been able to make a pull request "Merged" when a pull request's branch needs to be rebased before pushing it to the master branch.
I'm probably missing something, but Github... -
05:39 PM Misc #16093: Prohibit a "foxtrot merge" instead of a merge commit
- I updated the description according to my further investigation of the history. Thank you @mame for helping it.
I also prepared a patch to keep a consistent linear history (step 2 of the "Solution") in https://github.com/ruby/ruby-commi... -
04:33 PM Misc #16093: Prohibit a "foxtrot merge" instead of a merge commit
- Apologies, according to the chat history, it turned out that @mame was not the only person opposed to merge commits. I'll update the description to reflect the facts later.
> keep a true linear history, as I find it makes reviewing th... -
04:18 PM Misc #16093: Prohibit a "foxtrot merge" instead of a merge commit
- I prefer rebasing commits on master instead of merging to keep a true linear history, as I find it makes reviewing the history simpler. In my opinion, the "Problem" as specified in the post is not a significant issue, and the disadvanta...
-
03:13 PM Misc #16093 (Rejected): Prohibit a "foxtrot merge" instead of a merge commit
- ## Background
* When we migrated the canonical Ruby repository from Subversion to Git [Misc #14632], in that ticket nobody had objected to allowing a merge commit in the repository.
* At first, we decided to prohibit merge commits beca... -
11:33 PM Revision 9d298b9d (git): Allow Array#join to allocate smaller strings
- rb_str_buf_new always allocates at least 127 bytes of capacity, even
when less is requested.
> ObjectSpace.dump(%w[a b c].join)
{"address":"0x7f935f06ebf0", "type":"STRING", "class":"0x7f935d8b7bb0", "bytesize":3, "capacity":127... -
11:24 PM Bug #8287 (Rejected): Regexp performance issue
- From the general problem statement, and looking at the regexp's nested use of `*` and `+` along with `\g`, this regexp probably exhibits exponential backtracking. See https://docs.ruby-lang.org/en/2.6.0/Regexp.html#class-Regexp-label-Per...
-
11:23 PM Revision b1678338 (git): Fix typo: duplicated the [skip-ci]
-
10:59 PM Misc #16091 (Rejected): gsub
- This is not a bug. Ruby treats `\&` in a replacement string specially, representing the entire matched string (note that `"\\&"` is the same as `'\&'`):
```ruby
"test ?".sub("?", "1\\&2")
=> "test 1?2"
```
So `"\\&"` as a replac... -
10:54 PM Misc #16091: gsub
- @thiaguerd I don't understand - the `String#replace` method only takes one argument - you're calling it with two so that's not going to work for a start. Secondly, the method doesn't replace occurrences of one string with another, which ...
-
10:47 PM Misc #16091: gsub
- shyouhei (Shyouhei Urabe) wrote:
> Really sorry that I have to say I don't understand this report at all. Please tell us about your problem a bit more in detail.
the replacement doesn't happen
try in python and see the diff
```
... -
02:30 PM Misc #16091: gsub
- Really sorry that I have to say I don't understand this report at all. Please tell us about your problem a bit more in detail.
-
10:36 AM Misc #16091 (Feedback): gsub
-
10:10 AM Misc #16091 (Closed): gsub
- ```ruby
a = "test ?"
b = "?"
c = "\\&"
a.gsub(b,c)
``` -
09:25 PM Bug #8219 (Rejected): ruby 2.0.0-p0 socket.recv MSG_OOB problem?
- This issue appears to be specific to Windows, and the master branch still has the same behavior as Ruby 2.0. I do not think this is a bug. Windows appears to allow multiple TCP OOB bytes, where most other implements support only a singl...
-
09:24 PM Bug #16087: Signal.trap(:INT) doesn't work on msys2 mingw64 ?
- I checked:
```
ruby 2.7.0dev (2019-08-09T15:04:06Z master 8d7e0159c0) [x64-mingw32] ruby-loco
ruby 2.6.3p62 (2019-04-16 revision 67580) [x64-mingw32] RubyInstaller2 / OneClick
```
JFYI, tried both in a PowerSh... -
06:51 PM Bug #16092 (Feedback): [doc] precedence of modifier-rescue
- Ok, I'm starting to see. The difference between statements and expressions is why we get this
```ruby
puts( 1 if 2 ) #=> SyntaxError
puts((1 if 2)) #=> 1
puts(if 2;1;end) #=> 1 ...interesting
puts( 1 rescue 2 ) #=> SyntaxErr... -
02:48 PM Bug #16092 (Rejected): [doc] precedence of modifier-rescue
- The current doc about precedence is correct. The behavior you showed is not caused by precedence, but by the grammer itself.
The point is, that `<stmt> rescue <stmt>` is a statement, not an expression. The right side of modifier-if ... -
02:18 PM Bug #16092 (Closed): [doc] precedence of modifier-rescue
- The docs state that modifier-rescue has higher precedence than assignments which have higher precedence than modifier-if. This is true for
`v = expr rescue $! if condition` but not for
`v = expr if condition rescue $!` which is treated... -
04:41 PM Revision 162cf287 (git): Init function is need to link statically
-
04:38 PM Bug #14689: bootsnap gets object index out of range: 266287972352 (IndexError) since r63113
- Would it be possible to backport this patch for ruby2.5? Debian has unfortunately not yet updated to 2.6 and the bug affects Debian's sparc64 port.
The patch as-is doesn't apply to the 2.5 tree. -
04:28 PM Feature #8239 (Closed): Inline rescue bug
- Applied in changeset commit:git|53b3be5d58a9bf1efce229b3dce723f96e820c79.
----------
Fix parsing of mutiple assignment with rescue modifier
Single assignment with rescue modifier applies rescue to the RHS:
a = raise rescue 1 # a = (... -
04:28 PM Bug #8279 (Closed): Single-line rescue parsing
- Applied in changeset commit:git|53b3be5d58a9bf1efce229b3dce723f96e820c79.
----------
Fix parsing of mutiple assignment with rescue modifier
Single assignment with rescue modifier applies rescue to the RHS:
a = raise rescue 1 # a = (... -
05:57 AM Bug #8279: Single-line rescue parsing
- Thank you, it seems fine. I've missed this at all.
-
03:12 AM Bug #8279: Single-line rescue parsing
- This bug is still present in the master branch. Attached is a patch that fixes it, so that multiple assignment with rescue modifier is consistent with single assignment with rescue modifier. After the patch:
```
a = raise rescue 1 #... -
04:25 PM Revision 53b3be5d (git): Fix parsing of mutiple assignment with rescue modifier
- Single assignment with rescue modifier applies rescue to the RHS:
a = raise rescue 1 # a = (raise rescue 1)
Previously, multiple assignment with rescue modifier applied rescue
to the entire expression:
a, b = raise rescue [1, 2] #... -
04:05 PM Revision cecae859 (git): Removed unnecessary headers
-
04:04 PM Revision 88db6fa4 (git): Use ENC_REPLICATE to copy an encoding
- 03:04 PM Revision 8d7e0159 (git): * 2019-08-10
-
03:01 PM Revision a8ba22cd (git): Revert "Removed unused includes"
- This reverts commit c9eb8f82e9febeb634a23bec6aeea915eb25fe26.
The change caused "implicit declaration" warning and actual segfault.
```
/tmp/ruby/v2/src/trunk-gc-asserts/enc/gb2312.c: In function ‘Init_gb2312’:
/tmp/ruby/v2/src/trunk-g... -
02:28 PM Bug #15952: Issue with Array#unshift, sometimes doesn't respect frozenness of array
- ruby_2_6 r67740 merged revision(s) ec8e5f5aa64e2a54cf1e303f2b012c98e8d521ba,5a187e26adc8aa32367f294c1496935c7356d386.
-
02:28 PM Revision e68627da (git): merge revision(s) ec8e5f5aa64e2a54cf1e303f2b012c98e8d521ba,5a187e26adc8aa32367f294c1496935c7356d386: [Backport #15952]
- array.c: always check frozenness in Array#unshift. Fixes [Bug #15952]
Closes: https://github.com/ruby/ruby/pull/2251
array.c add back shared array optimization to
ary_ensure_room_for_unshift
Bug fix in... -
02:10 PM Revision 314b50d7 (git): #include <> for system headers
-
02:08 PM Revision c9eb8f82 (git): Removed unused includes
-
01:48 PM Revision 3ddbba84 (git): gc.c: Double STACKFRAME_FOR_CALL_CFUNC (1024->2048)
- ef64ab917eec02491f6bf7233a4031a8c35385e3 didn't fix the issue, so the
size seems not enough yet.
https://rubyci.org/logs/rubyci.s3.amazonaws.com/osx1014/ruby-master/log/20190809T114503Z.fail.html.gz -
01:42 PM Bug #15946: Undefined behavior can occur with memcpy in String#sub!
- ruby_2_6 r67739 merged revision(s) 8f51da5d41f0642d5a971e4223d1ba14643c6398.
-
01:42 PM Revision ec1666eb (git): merge revision(s) 8f51da5d41f0642d5a971e4223d1ba14643c6398: [Backport #15946]
- Get rid of undefined behavior
* string.c (rb_str_sub_bang): str and repl can be same.
[Bug #15946]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_6@67739 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:41 PM Bug #15937: Segmentation fault when String#initialize given same string with capacity field
- ruby_2_6 r67738 merged revision(s) 28678997e40869f5591eae60edd9757334426ffb,8797f48373dcfa3ff8e748667732dea8aea4347e.
-
01:41 PM Revision ce0d99e4 (git): merge revision(s) 28678997e40869f5591eae60edd9757334426ffb,8797f48373dcfa3ff8e748667732dea8aea4347e: [Backport #15937]
- Preserve the string content at self-copying
* string.c (rb_str_init): preserve the embedded content when
self-copying with a capacity. [Bug #15937]
New buffer for shared string
* string.c (rb_str_ini... -
10:04 AM Feature #16090: RUBY_ON_BUG envval to debug
- In general I think this is fine (if we don't forget to document it :) ).
It would give people a way to influence the behaviour there, if they need to,
e. g. the example you gave via using "gdb -p". So this is a convenience
feature ... -
08:43 AM Feature #16090 (Closed): RUBY_ON_BUG envval to debug
- How about to introduce `RUBY_ON_BUG` environment variable which specify the command launched at `rb_bug()`?
`RUBY_ON_BUG='gdb -p' ruby ...`
In this case, `gdb -p [PID]` is invoked when `rb_bug()` is called.
after that, we can spy ... -
08:48 AM Revision 63384591 (git): restore timeout
-
08:31 AM Revision ef64ab91 (git): gc.c: Increase STACKFRAME_FOR_CALL_CFUNC
- On macOS Mojave, the child process invoked in TestFiber#test_stack_size
gets stuck because the stack overflow detection is too late.
(ko1 figured out the mechanism of the failure.)
This change attempts to detect stack overflow earlier. -
08:07 AM Bug #7877: E::Lazy#with_index should be lazy
- Thank you, I've missed it.
-
07:36 AM Bug #16086 (Closed): OpenStruct method access with a block does not raise
-
07:36 AM Bug #16086: OpenStruct method access with a block does not raise
- > That is OpenStruct, an undefined key does not raise an exception.
> ...
Right, this behavior seems to be universal:
```ruby
> { foo: :bar }[:foo] { 'hello' }
=> :bar
> ...
=> 1
```
> I haven't seen such behavior.
> ...
Hm... -
07:29 AM Revision a4a2dd79 (git): Revert a6e32855d079e8f3806d8be8a5f5cf7b3a967133 partially
- Fix TypeError when typing `''.[TAB]`
-
07:08 AM Revision 3cbd56d5 (git): complement `test_` prefix.
- `make test-all TESTS=name` can specify running test files by name.
name can be dirname ('dir/') or a file ('.../test_foo.rb'). This
patch complement `test_` prefix for a test. So we only need to
specify `TESTS=ruby/hash` which means `TES... -
06:23 AM Revision 26cf4c91 (git): extend timeout to debug.
-
05:11 AM Revision 3b39cc6b (git): gc.h is required on mswin build.
- thread.c requires gc.h on mswin build. Sorry.
-
05:01 AM Revision 6bf8db9a (git): add rp() and bp() in internal.h.
- debug utility macro rp() (rp_m()) and bp() are introduced.
* rp(obj) shows obj information w/o any side-effect to STDERR.
* rp_m(m, obj) is similar to rp(obj), but show m before.
* bp() is alias of ruby_debug_breakpoint(), which is regis... -
04:15 AM Revision cb390e87 (git): Add more runners
- Closes: https://github.com/ruby/ruby/pull/2327
-
04:15 AM Revision 54bdfe27 (git): Run macOS tests on GitHub Actions
- This commit sets up the CI integration on GitHub Actions. We should
give it a try because queue times are lower and I think we get more
CPUs.
Closes: https://github.com/ruby/ruby/pull/2327
Co-Authored-By: John Hawthorn <john@hawthorn.... -
04:08 AM Revision 37eefb11 (git): remove useless include and dependency
-
04:04 AM Revision a9fd5705 (git): double memory limit on MJIT.
- On test with MJIT, sometimes it fails like:
http://ci.rvm.jp/results/trunk-mjit-wait@silicon-docker/2189967 -
02:39 AM Revision 0176e74d (git): Add missing dependency
- just fix CI failure
https://travis-ci.org/ruby/ruby/jobs/569625233 -
02:35 AM Misc #16089: Explain that github prs do not get merged
- Good news is, yesterday I discussed this issue with @mame who was the person opposed to having a merge commit, and we got an idea to solve his problems.
Once it's implemented (work in progress; @mame implemented one, and I'm going to ... -
02:13 AM Bug #15877: Incorrect constant lookup result in method on cloned class
- > solve "duplicate :raise event" [Bug #15877]
sorry my mistake :p -
02:11 AM Bug #15877 (Closed): Incorrect constant lookup result in method on cloned class
- Applied in changeset commit:git|71efad1ed391ee0c5398a76306fdbaaadd4dc52e.
----------
introduce RCLASS_CLONED flag for inline cache.
Methods on duplicated class/module refer same constant inline
cache (IC). Constant access lookup should... - 02:11 AM Revision 4e9382a8 (git): * expand tabs.
-
02:05 AM Revision 71efad1e (git): introduce RCLASS_CLONED flag for inline cache.
- Methods on duplicated class/module refer same constant inline
cache (IC). Constant access lookup should be done for cloned
class/modules but inline cache doesn't check it.
To check it, this patch introduce new RCLASS_CLONED flag which
ar...
08/08/2019
-
11:26 PM Bug #8178: OpenSSL::PKCS7::SignerInfo
- I submitted a pull request upstream to remove the `OpenSSL::PKCS7::SignerInfo#name` method: https://github.com/ruby/openssl/pull/266
-
11:18 PM Bug #14972: Net::HTTP inconsistently raises EOFError when peer closes the connection
- When a range is requested, the content-length of the response is the number of bytes in the partial response, so I would still expect an exception to be raised if the partial response is truncated:
```
$ curl -s -v -r 0-100 -O http... -
11:04 PM Bug #8067 (Closed): Checking a network connection in a loop never succeeds even if the connection is available.
-
11:01 PM Bug #8039: DRB/dRuby server throws an exception when probed on its port
- This bug is still present in the master branch. I've updated drbrain's patch to apply to the master branch, including adding some additional exceptions to rescue.
-
09:38 PM Feature #15939: Dump symbols reference to their fstr in ObjectSpace.dump()
- > Do you need a list of String objects referenced from static symbols?
It would be useful yes. Because otherwise you might see strings with only one reference and thing that you could reclaim there by removing that reference, but in r... -
05:38 AM Feature #15939: Dump symbols reference to their fstr in ObjectSpace.dump()
- Do you need a list of String objects referenced from static symbols?
-
08:54 PM Bug #7881 (Closed): Windows でパスに日本語を含むスクリプトからの require が失敗する
- This appears to have been fixed between Ruby 2.4 and 2.5:
```
D:\テスト>c:\Ruby24-x64\bin\ruby a.rb
a.rb: No such file or directory @ realpath_rec - D:/??? (Errno::ENOENT)
D:\テスト>c:\Ruby25-x64\bin\ruby a.rb
No Problem.
``` -
08:45 PM Bug #7877: E::Lazy#with_index should be lazy
- This bug is still present in the master branch. I've updated nobu's patch to apply to the master branch, which required a significant rewrite. The updated patch is attached.
-
08:10 PM Feature #13241: Method(s) to access Unicode properties for characters/strings
- I had a go at this, and a naive implementation is quite simple. The only issue really is where to store the list of unicode properties.
```ruby
class String
def unicode_properties(*categs)
@@props ||= Hash.new.tap do |hash|
... -
06:29 PM Revision c7acb372 (git): Enable GitHub Actions on Ruby
- This just enables GitHub actions on our repository so we can try it out.
-
05:09 PM Bug #7844: include/prepend satisfiable module dependencies are not satisfied
- This is still a bug in the master branch. I think the main problem in this example is that when calling `Module#include`, you can get a module inserted before the receiver in the lookup chain instead of behind the receiver.
mame correc... -
04:39 PM Misc #16089 (Closed): Explain that github prs do not get merged
- I've updated the wiki to reflect this. If you think additional changes are needed, please reply.
-
04:20 PM Misc #16089: Explain that github prs do not get merged
- I actually realize that this is wrong & that technically it's "accepted pull requests are _often_ closed, not merged, because..."
-
04:19 PM Misc #16089 (Closed): Explain that github prs do not get merged
- The fact that fixes which are accepted still get closed, rather than being merged, is confusing. The (easiest) solution is to modify
https://bugs.ruby-lang.org/projects/ruby/wiki/HowToContribute
Change submit section to something l... -
04:32 PM Bug #16088 (Closed): [patch] Call #to_binary on iseq containing pattern match crashes
- Applied in changeset commit:git|050b932152fb3004c78af223186afe1aa397f06f.
----------
Iseq#to_binary: Add support for NoMatchingPatternError and TypeError
Binary dumping the iseq for `case foo in []; end` used to crash as
there was no h... -
03:33 PM Bug #16088 (Closed): [patch] Call #to_binary on iseq containing pattern match crashes
- Crasher: `miniruby -e 'RubyVM::InstructionSequence.compile("case foo in []; end").to_binary'`
It crashes since there is no handling for dumping `TypeError` and `NoMatchingPatternError` in the binary dumper.
Patch: https://github.com/ru... - 04:32 PM Revision 57288f5d (git): * expand tabs.
-
04:29 PM Revision 050b9321 (git): Iseq#to_binary: Add support for NoMatchingPatternError and TypeError
- Binary dumping the iseq for `case foo in []; end` used to crash as
there was no handling for these exception classes.
Pattern matching generates these classes as operands to `putobject`.
[Bug #16088]
Closes: https://github.com/ruby/rub... -
04:27 PM Revision 830fd041 (git): C99 allows trailing comma in enum
- 03:16 PM Revision c0f49438 (git): * 2019-08-09
-
03:12 PM Revision ad3f7a36 (git): Should require without wrapper module
-
02:35 PM Bug #16087 (Third Party's Issue): Signal.trap(:INT) doesn't work on msys2 mingw64 ?
- My environment is Windows 10 msys2 mingw64
```
yama@JPC00183513 ~/b/p/sample> uname -a
MINGW64_NT-10.0-17763 JPC00183513 3.0.7-338.x86_64 2019-05-27 06:58 UTC x86_64 Msys
yama@JPC00183513 ~/b/p/sample> ruby --version
ruby 2.6.3p62... -
01:40 PM Revision a2067387 (git): Remove temporary directory [ci skip]
-
01:36 PM Revision a9b9f9d1 (git): Revert "Drop -j from msys2 build for debugging"
- This reverts commit b1594ca3d6b72edb60927418482652ce93209499.
Revert "Debug appveyor mingw failure"
This reverts commit fa29f65416f1fb3d734a279855728bb0616dbb34.
Though I preserved V=1 for future debugging. -
01:30 PM Bug #15877 (Open): Incorrect constant lookup result in method on cloned class
- I copied the wrong commit log, sorry.
-
12:31 PM Bug #15877 (Closed): Incorrect constant lookup result in method on cloned class
- Applied in changeset commit:git|76bd0714cf1140ffd64bf564446c76c54f2c4870.
----------
solve "duplicate :raise event" in require too [Bug #15877] -
09:46 AM Bug #15877 (Assigned): Incorrect constant lookup result in method on cloned class
- Re-open. This ticket has been closed accidentally by b004d3e8.
I'll correct commit link. -
08:59 AM Bug #15877 (Closed): Incorrect constant lookup result in method on cloned class
- Applied in changeset commit:git|b004d3e8300ba803d4a499148fa4fc6a690149e6.
----------
solve "duplicate :raise event" [Bug #15877]
Without this patch, "raise" event invoked twice when raise an
exception in "load"ed script.
This patch by ... -
01:28 PM Revision 995c2e95 (git): Reduce unnecessary EXEC_TAG in require
-
01:22 PM Bug #16086 (Feedback): OpenStruct method access with a block does not raise
- kke (Kimmo Lehto) wrote:
> This can cause confusion.
> ...
That is `OpenStruct`, an undefined key does not raise an exception.
And an unused block is silently ignored in common.
> A defined key with a block seems to yield the value... -
08:56 AM Bug #16086 (Closed): OpenStruct method access with a block does not raise
- This can cause confusion.
```ruby
> OpenStruct.new(hello: 'world').each { |k, v| puts k.upcase } # there's no "each" method
=> nil
> OpenStruct.new(hello: 'world').eahc_pair { |k, v| puts k.upcase } # each_pair typo
=> nil... -
01:18 PM Revision 2a6d7fad (git): Arrange installed packages like ruby-loco
- to fix a build error like:
https://ci.appveyor.com/project/ruby/ruby/builds/26547644/job/4j7n41e7in97a9kx
Basically copy-pasted what's currently done in MSP-Greg/ruby-loco.
Co-Authored-By: MSP-Greg <greg.mpls@gmail.com> -
12:27 PM Revision 76bd0714 (git): solve "duplicate :raise event" in require too [Bug #15877]
-
12:27 PM Revision 3d87b774 (git): Use `ec` instead of `th->ec` where the `th` came from the `ec`
-
11:37 AM Revision b1594ca3 (git): Drop -j from msys2 build for debugging
-
09:43 AM Bug #15885 (Closed): Duplicated `:raise` tracepoint event when exception inside `load` call happens
- The patch seems committed at b004d3e8300ba803d4a499148fa4fc6a690149e6. (ticket number reference miss).
- 08:59 AM Revision 29bdfeb0 (git): * expand tabs.
-
08:56 AM Revision b004d3e8 (git): solve "duplicate :raise event" [Bug #15877]
- Without this patch, "raise" event invoked twice when raise an
exception in "load"ed script.
This patch by danielwaterworth (Daniel Waterworth).
[Bug #15877] -
08:36 AM Revision 20cb8e8a (git): main.c: Add doxygen mainpage
- The document is experimentally produced in:
https://rubyci.s3.amazonaws.com/doxygen/modules.html -
08:19 AM Revision b39efb16 (git): Aliases capture_output to capture_io for test-unit compatiblity.
-
05:50 AM Feature #15912: Allow some reentrancy during TracePoint events
- In this case, your solution (allow fire different type of trace) because the problematic case `:line` event and `:class` event are different.
However, maybe it is accidentally. Someone can use `:line` event as usual.
`reopen` will al... -
05:26 AM Feature #15963 (Closed): Add *_start and *_running methods to VM_COLLECT_USAGE_DETAILS API
- Thank you, committed!
1ad0f4e593563d460e3015fc4a2542ce1bb80d6e -
05:22 AM Revision 1ad0f4e5 (git): Add *_clear methods to VM_COLLECT_USAGE_DETAILS API
- Add RubyVM::USAGE_ANALYSIS_INSN_CLEAR, RubyVM::USAGE_ANALYSIS_OPERAND_CLEAR,
and RubyVM::USAGE_ANALYSIS_REGISTER_CLEAR to clear VM instruction hash constants.
Closes: https://github.com/ruby/ruby/pull/2258 -
05:22 AM Revision 1c7d3a13 (git): Add *_start and *_running methods to VM_COLLECT_USAGE_DETAILS API
- Add RubyVM::USAGE_ANALYSIS_INSN_START, RubyVM::USAGE_ANALYSIS_OPERAND_START,
and RubyVM::USAGE_ANALYSIS_REGISTER_START to begin collecting VM instructions.
Add RubyVM::USAGE_ANALYSIS_INSN_RUNNING, RubyVM::USAGE_ANALYSIS_OPERAND_RUNNING,... -
12:17 AM Bug #16085 (Third Party's Issue): when running rspec I get this issue
-
12:14 AM Bug #16085 (Third Party's Issue): when running rspec I get this issue
- Attached the crash log, Not much initial investigation done yet..