Activity
From 07/09/2019 to 07/15/2019
07/15/2019
-
11:46 PM Revision 8e37ef76 (git): Fixed the library path for tools
-
-
-
-
10:53 PM Bug #8397 (Closed): TestBignum#test_interrupt_during_bigdivrem failure
-
-
-
-
-
-
- The script runs as expected on OpenBSD with ruby 2.6. I expect the issue you are experiencing is probably specific to your environment. Can you recreate this issue with a supported version of Ruby, and if so provide more details regard...
- 10:19 PM Revision 325d546d (git): * 2019-07-16
- 10:19 PM Revision a8e4b7b1 (git): * expand tabs.
-
10:18 PM Revision c184a1c2 (git): compile.c: add NO_CHECK for the calls to COMPILE whose result is unused
- to suppress many warnings of Coverity Scan
-
-
-
-
-
10:02 PM Bug #15620: Block argument usage affects lambda semantic
- Here is a patch which restores the 2.4 behavior:
https://github.com/ruby/ruby/pull/2289
Passes make check with VM_CHECK_MODE=1. -
-
- mame (Yusuke Endoh) wrote:
> I think that it is a good idea to fix only Array#uniq first.
Looks like Array#uniq was never fixed. It still returns Array instance if length <= 1 and subclass instance otherwise. Attached is a patch th... -
08:21 PM Feature #16001: Provide an alias to Kernel#caller_locations(1,1) and Kernel#caller(1,1)
- > Right, I'm thinking we should just improve the documentation of `caller` and `caller_locations` then,
> ...
This is quite a common thing to do and it's not only about performance, though the performance aspect is equally important. I ... -
12:47 PM Feature #16001: Provide an alias to Kernel#caller_locations(1,1) and Kernel#caller(1,1)
- Right, I'm thinking we should just improve the documentation of `caller` and `caller_locations` then,
to mention `limit` should be used when possible, otherwise the impact on performance can be very high. -
10:38 AM Feature #16001: Provide an alias to Kernel#caller_locations(1,1) and Kernel#caller(1,1)
- @eregon the answer is in the former version of this issue - 'avoid common beginner mistakes getting full backtrace information' - it improves performance by being obvious when you look in the docs and helping people avoid getting the ful...
-
- chrisseaton (Chris Seaton) wrote:
> This new method allows the user to explicitly say that they only need some of the callers.
`caller` and `caller_locations` already allow that with the `length` argument, which is more flexible.
I ... -
-
- autoload was modified to call `require` in commit:cd465d552c3a00341f4cb7f1d7a793d0ebcb6cde.
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
- This is expected behavior. Without a timezone offset specified, `Time` assumes local time and `DateTime` assumes UTC.
-
- This appears to still be the case in master, but I think this is a feature request for a "laxed" option. I'm not sure if we want to support such an option though.
-
- This is still true in master, but I believe this is expected behavior/spec. This is similar to constants:
```ruby
String.class_eval {A = 1}
Object::A
# => 1
```
If you want to scope constants or class variables, you need to re... -
- This was set to the Ruby 1.8 tracker, but I think it is still an issue currently for all `FileUtils` methods. Changing the default behavior could possibly be done in Ruby 3, and potentially we could add an option for `$stdout` (or anoth...
-
01:14 PM Bug #15986: `TestJIT#test_block_handler_with_possible_frame_omitted_inlining` fails on s390x and armv7hl
- Here are the logs again. I am going to try the latest master and will report back if that helps.
-
12:52 PM Bug #16004: Kernel#lambda captured with Kernel#method doesn't create lambdas
- I think this requires matz to determine which behaviour is the valid or the
better one (as from the other linked discussion too).
I myself almost never use lambdas and only very rarely proc deliberately
so (via e. g. Proc.new or pr... -
- I would guess this is because Method#call introduces an extra frame:
```
$ ruby -e 'def foo; yield; end; method(:foo).call { raise "bar" }'
Traceback (most recent call last):
3: from -e:1:in `<main>'
2: from -e:1:in `call'
... -
- `ruby -e 'p method(:lambda).call{}.lambda?'` prints false on 2.3.x-master(223854ebe8).
I think it should create lambdas.
-
-
09:42 AM Feature #5781: Query attributes (attribute methods ending in `?` mark)
- How about implementing it similarly to Crystal?
attr_accessor? :foo
-
-
08:22 AM Revision c20445ab (git): Require Ruby 2.4 or later because needs lex_state from Ripper
-
-
07:53 AM Feature #16005: A variation of Time.iso8601 that can parse yyyy-MM-dd HH:mm:ss
- > I would be OK with modifying Time.iso8601 to make either T or space a valid date/time separator.
In fact this was my first proposal. I firstly asked @akr about that exact modification on `Time.iso8601`, but he didn't like the idea b... -
- > This seems backwards. Timezone 'Z' denotes UTC, see e.g. https://www.timeanddate.com/time/zones/z.
Indeed. My mistake. -
06:34 AM Feature #16005: A variation of Time.iso8601 that can parse yyyy-MM-dd HH:mm:ss
- matsuda (Akira Matsuda) wrote:
> How about respecting local timezone with `Z`, and doing the UTC without `Z`?
This seems backwards. Timezone 'Z' denotes UTC, see e.g. https://www.timeanddate.com/time/zones/z. -
- For many databases, if the timestamp has a fractional component, the fractional component will be included, and if the type includes a timezone, the timezone offset will be included. For example, on PostgreSQL:
```sql
SELECT CAST(CA... -
- How about respecting local timezone with `Z`, and doing the UTC without `Z`?
-
05:39 AM Feature #16005: A variation of Time.iso8601 that can parse yyyy-MM-dd HH:mm:ss
- Time object needs timezone offset.
"yyyy-MM-dd HH:mm:ss" doesn't contain it.
Always UTC?
-
- Let me propose a String to Time conversion method that can parse "yyyy-MM-dd HH:mm:ss" format, which is very much similar to `Time.iso8601`, but delimits the date part and the time part with a space character.
This format is defined a... - 07:51 AM Revision 5a42dca6 (git): * expand tabs.
-
- If `emesg` is `Qundef`, it is not a message string and then `elen`
(the length of the message) is 0. So `emesg` cannot be `Qundef` in
the `elen != 0` block. Pointed out by Coverity Scan. -
-
-
-
06:07 AM Revision f73ea334 (git): Fixed ruby/spec for Logger::LogDevice changes.
-
-
- 05:43 AM Revision f103ed8b (git): * expand tabs.
-
- to suppress many warnings of Coverity Scan
-
-
- 05:43 AM Revision 58065b87 (git): [ruby/logger] Add option to set the binary mode of the log device
- Without binmode strings with incompatible encoding can't be written in
the file. This is very common in applications that log user provided
parameters.
We need to allow changing the binnary mode because right now it is impossible to use... -
05:43 AM Revision f4064a0a (git): [ruby/logger] Set filename when initializing logger with a File object
- This should allow reopen to work. Requested in ruby issue #14595.
https://github.com/ruby/logger/commit/bd367aff12 - 05:43 AM Revision 2c22051b (git): [ruby/logger] Enable `frozen_string_literal: true` in `logger.rb`.
- https://github.com/ruby/logger/commit/2dc832e901
- 05:43 AM Revision 3fdb9638 (git): [ruby/logger] Prefer require_relative, it's a little bit faster.
- https://github.com/ruby/logger/commit/1e2aab4bea
-
05:43 AM Revision 7ef08562 (git): [ruby/logger] Update logger.gemspec
- https://github.com/ruby/logger/commit/1335a71d98
-
- https://github.com/ruby/logger/commit/255a51dc10
- 05:43 AM Revision bbe157f3 (git): [ruby/logger] split logger classes/modules into separate files
- https://github.com/ruby/logger/commit/f10ce9fff2
-
- `ruby test/logger/test_xxx.rb`
https://github.com/ruby/logger/commit/d3c2402340 - 05:43 AM Revision 47500f20 (git): [ruby/logger] Add support for changing severity using bang methods.
- https://github.com/ruby/logger/commit/ae4c6dfcbb
-
05:43 AM Revision 310198d6 (git): [ruby/logger] Add missing closing "
- https://github.com/ruby/logger/commit/b4b3caae40
-
- Since it uses `&.`, it can't be used on older rubies
https://github.com/ruby/logger/commit/b872f90ab9 - 05:43 AM Revision b9ba07a0 (git): [ruby/logger] dont lock bundler to a specific version in travis
- https://github.com/ruby/logger/commit/eb5ac229a5
- 05:43 AM Revision 99c14fb6 (git): [ruby/logger] remove files that dont need to be included in gem releases
- https://github.com/ruby/logger/commit/9a3be8650f
-
05:29 AM Revision 3dc21289 (git): check return value of blocking_region_begin().
- blocking_region_begin() can return FALSE if it fails to acquire
GVL, so check it. -
-
- str is always zero when evaluating the branch.
Found by Coverity Scan. -
- `(unsigned int)(THREAD_SHIELD_WAITING_MASK>>THREAD_SHIELD_WAITING_SHIFT)`
is 0xffffffff, and w > 0xffffffff is always true.
Coverity Scan pointed out this issue. -
-
-
-
-
-
-
04:59 AM Revision 62f34bd1 (git): doc/globals.rdoc: Add deprecated to TRUE,FALSE,NIL [ci skip]
- They are warned since 2.4.0.
-
04:57 AM Revision 9c38904e (git): Use consistent fetchDepth for all jobs
- a7dd6763bd1dac7952ace46be58083dbea332a0a was not applied for all jobs.
-
-
- This was fixed between 2.0 and 2.1:
```
$ ruby20 -e 'p "\u1036".succ'
"\u1000\u1000"
$ ruby21 -e 'p "\u1036".succ'
"\u1038"
``` -
-
- nobu said that we could be banned if we aggressively downloaded unicode
file from Travis. -
-
- We can use require_relative now.
-
- Applied in changeset commit:git|99afea5328c61d3f212bbb684b33abf0d814f080.
----------
Add bug triaging guide
Implements [Misc #15943] -
- Implements [Misc #15943]
-
-
-
-
- And raise an exception when failed to register an encoding
-
- > 2.7 で、define_method したら ISeq 作るようにするとどうかな、と思っているので、それで一気に解決します。
これでうまくいかない、ということがわかったので、ちょっと宙ぶらりんです。
考えていた解決案：
* (1) proc を受け取る
* (2) proc のパラメータとまったく同じ method iseq を作る
* (3) 受け取ったパラメータを proc に渡す
こんな感じです。
```
foo_body... -
- Attached is a documentation patch to mark this class's methods as implementation and version dependent.
-
- see RUBY_DEBUG for each debug options.
-
-
-
-
-
-
-
- doc/etc.rd.ja は
* 情報が古く、後から追加されたメソッドは載っていない
* <https://docs.ruby-lang.org/ja/latest/library/etc.html> に新しいドキュメントが存在する
という理由から、削除しても良いと思ったのですが、どうでしょうか?
しばらく待ってみて反対がなければ削除しようと思っています。 -
-
- I gave up to organize this. I try to write test files under the tool directory.
-
-
-
- This issue is detected by Coverity Scan.
-
- Having a block for mixing a declaration was confusing.
Also I moved `dev_null` and `pid` to limit their scope. -
- When input `"` or `/` with simple-prompt,
Before:
`"` or `/`
(prompt disappeared and indent is changed)
After:
`"> "` or `/> /`
(indent is unchanged since `>> `) -
-
- RUBY_ASSERT_ALWAYS(expr) ignores NDEBUG (we cannot remove this
assertion). -
-
- The pull request was merged.
-
-
-
-
- Same as 66299e7ca83d379d13abaa5411f3e0419334cabb
-
- Because it's the common library for tool files.
-
- Applied in changeset commit:git|8f7884761e30c453287d73de6ea733d565635ebc.
----------
The default charset of text/* media type is UTF-8.
Thanks for the patch gareth (Gareth Adams). [Bug #15933]
-------
Combines two small, but very r... -
- Thanks for the patch gareth (Gareth Adams). [Bug #15933]
-------
Combines two small, but very related changes
1: Treat HTTPS the same as HTTP
Previously, OpenURI followed guidance in RFC2616/3.7.1:
> When no explicit charset param... -
- This issue is detected by Coverity Scan.
-
- For a certain editor which cannot handle here-document properly.
-
12:24 AM Feature #15939: Dump symbols reference to their fstr in ObjectSpace.dump()
- > Static symbol (immediate value) does not reach any objects
Yeah, I learned more about static symbols since I wrote this patch, I wouldn't include that part anymore. I'd still maintain the dynamic part though.
> ...
Sure. The usag...
07/14/2019
-
- I think checking permission before writing should be avoided.
It causes <https://en.wikipedia.org/wiki/Time-of-check_to_time-of-use>. -
- `File.writable?` uses `eaccess` function of OS.
I think such OS-specific features should be implemented in OS.
Ruby cannot support all features of all OS.
For example, eaccess of GNU/Linux seems that support read-only filesystem.
... -
08:49 PM Bug #16002 (Closed): File.writable?('/tmp/file') returns true even if it's not writable on Linux 4.19+
- Well, on Linux Kernel 4.19+ the fs.protected_regular and fs.protected_fifos sysctls were introduced in order to make some data spoofing attacks harder.
https://github.com/systemd/systemd/blob/03b6fa0c5b51b0d39334ff6ba183a3391443bcf6/N... -
- to suppress Coverity Scan warning.
This expression converted uint8_t to int, and then int to unsigned long.
Now it directly converts uint8_t to unsigned long. -
- 1f99274ccf31ba1f2a4b3ac20a9c6cdc5ae81152 was indenting details with a
hard tab, but other lines are using spaces. -
- similar to 364f43ab7fc5920247fc73423c1428208cf78a4a and
13cb9e6bd2c88d04fc9b21b8f8c1d192c67cd5a2 -
-
- This reverts commit c55de95ff1c4ea6313c2863037703a0e5f0d0f4f.
Probably this is not needed for CI anymore. -
-
- Currently it is completely the same as "make check".
I think it is not worth mentioning now. -
-
-
-
-
- A history line ends with "\" to escape newline if it's a continuous
line. -
- As I guess:
* `tool/update-deps` takes a pretty long time
* adding dependencies is relatively rare
* saving temporary files would not be common
So it is optional now.
It has just started in these days, and I think it is better t... -
- Earlier today, I committed 369ff79394765ce198ac7cee872a8c739d895aaa to address issue #15995.
This did not lead to any testing failures, but to a dependency problem. As the source code was processed correctly and the tests worked, I di... -
- > For some reason nobody seems to have commented here what I think is the original motivation for this
> ...
I think this may have been lost a bit in the discussion because typically aliases are used to use something
differentially, su... -
- > it's not an alias for brevity
Definitely not brevity but clarity certainly. The `caller(1,1)` seems cryptic as compared to `direct_caller` which is more expressive.
> ...
That's a very important point. Limiting the full backtra... -
- > If so, it seems like a very heavy handed way to shorten something that is already fairly short
For some reason nobody seems to have commented here what I think is the original motivation for this new method - it's not an alias for ... -
- Would this be an instance method on Kernel? If so, it seems like a very heavy handed way to shorten something that is already fairly short.
I don't see `caller_locations(1,1)` or `caller(1,1)` very frequently, though.
-
- Eregon (Benoit Daloze) wrote:
> Maybe `direct_caller`?
> ...
That's a very good point. I'd probably lean towards modern API of `caller_locations(1,1)` if we only used a single alias. However, we could follow a pattern and name `caller_... -
- Maybe `direct_caller`?
Would it call `caller_locations(1,1)` or `caller(1,1)`? It can only be one of them. -
- As it is common to use `caller_locations(1,1)` and `caller(1,1)`, this proposes aliases to help get the previous backtrace frame and improve performance by avoiding getting full backtrace information - a common mistake.
The currently ... -
- ruby_marshal_write_long may write 9 bytes, but buf has only 8 bytes.
So the buffer cannot be reused. This issue was found by Coverity Scan. -
-
- because we're not writing ChangeLog anymore.
-
- We've added some more things recently. It seems not worth having almost
the same two entries there anymore. -
-
- znz (Kazuhiro NISHIYAMA) wrote:
> `Method#inspect` separated by ` ` (a space) and `Proc#inspect` separated by `@`.
> ...
I think ` ` (a space) is better, and it's what we use for Method#inspect in TruffleRuby.
My motivation is that se... -
- `Method#inspect` separated by ` ` (a space) and `Proc#inspect` separated by `@`.
I think it is better to be unified, but I have no opinion on which is better.
```
% ruby -ve 'def m;end; p [method(:m), proc{}]'
ruby 2.7.0dev (2019-0... -
- Now, I added source location information.
Adding parameter information is still open. -
- Applied in changeset commit:git|47b04557b01dc109ccafc33db8e80148f07457a9.
----------
Method#inspect with source location.
Method#inspect shows with source location.
[Feature #14145] -
-
-
-
-
-
-
03:33 PM Revision 04e6b90d (git): Remove unused method.
-
03:32 PM Revision 423feb53 (git): [ruby/matrix] Add Matrix::VERSION constant
- Add Matrix::VERSION for the gem version, use it in the gemspec,
and make it also available for library users.
https://github.com/ruby/matrix/commit/65c2bb1fa1 -
- https://github.com/ruby/matrix/commit/2bbb9be233
-
-
-
-
- Remove unused conditional expression to suppress Coverity Scan warnings.
-
-
-
03:13 PM Revision 9806da50 (git): Suppress warnings
-
- https://github.com/ruby/rdoc/commit/55c0627fe0
-
03:11 PM Revision 312d7200 (git): [ruby/rdoc] Correction to include regexp_handling in list of loaded files
- https://github.com/ruby/rdoc/commit/1940b2318c
-
-
- I guess that this check was to detect re-entrance (maybe callcc?).
But currently it does not work as intended. - 03:08 PM Revision 721fc849 (git): * 2019-07-15
-
- To suppress Coverity Scan warning
-
-
- Use more communicative variable name
-
- This change will suppress Coverity Scan warnings
- 02:07 PM Revision 198281a7 (git): [ruby/csv] Fix a bug that strip: true removes newlines
- https://github.com/ruby/csv/commit/5540d35a30
- 02:07 PM Revision 8c0edbd7 (git): [ruby/csv] add options doc :quote_empty (#89)
- https://github.com/ruby/csv/commit/5ca8d79f60
- 02:07 PM Revision 75620c80 (git): [ruby/csv] Add options doc: :write_converters, :write_nil_value, :write_empty_value (#87)
- https://github.com/ruby/csv/commit/5923ee08b7
- 02:07 PM Revision fe40841b (git): [ruby/csv] add document of strip (#88)
- * add document of strip
* modify typo
https://github.com/ruby/csv/commit/de0257dc31 - 02:07 PM Revision c8b82998 (git): [ruby/csv] Bump version
- https://github.com/ruby/csv/commit/3976985008
- 02:07 PM Revision 8392592a (git): [ruby/csv] Don't raise on eof?
- GitHub: fix #86
Reported by krororo. Thanks!!!
https://github.com/ruby/csv/commit/5a8d9d9297 - 02:07 PM Revision 9171f833 (git): [ruby/csv] Refactor range in delete_suffix (#85)
- https://github.com/ruby/csv/commit/7ff57a50e8
- 02:07 PM Revision 864e2a95 (git): [ruby/csv] Bump version
- https://github.com/ruby/csv/commit/312f844693
-
-
- This change will suppress Coverity Scan warnings
-
-
01:29 PM Feature #13179: Deep Hash Update Method
- Gem XKeys, since 2014.
```
require 'xkeys'
h = {}.extend XKeys::Auto # auto Hash/Array
h[:accent, 2, :original] = "the value to set"
# {:accent=>[nil, nil, {:original=>"the value to set"}]}
h = {}.extend XKeys::Hash # Hash only... -
-
-
-
-
-
- by C99 compound literal for array and non-constant array initializer
-
-
- It always returns immediately when len was decremented to zero.
So len is always positive. This change will suppress Coverity Scan
warning. -
-
-
-
-
-
-
- Fortunately a very similar issue was reproductive on my macOS machine. I did the mjit_debug2.diff investigation on my own, and noticed the issue fixed by commit:d8cc41c43be65dd4b17e7a6e38f5a7fdf2b247d6. And the commit fixed the behavior ...
-
- Applied in changeset commit:git|d8cc41c43be65dd4b17e7a6e38f5a7fdf2b247d6.
----------
Fix a wrong buffer size to avoid stack corruption
[Bug #15986] -
- [Bug #15986]
-
-
-
- It's matz issue.
-
- Applied in changeset commit:git|4900a10689036211da79c8189ff7eba11c8c81ee.
----------
socket: use frozen string buffer when releasing GVL
Thanks for the patch by normalperson (Eric Wong) [Bug #14204]. -
- Thanks for the patch by normalperson (Eric Wong) [Bug #14204].
-
-
-
-
-
11:20 AM Misc #15723: Reconsider numbered parameters
- I have used `@1` a bit in different code snippets and in the great majority of cases there is only one argument and "1" really feels out of place. I definitely support `@`, or anything else without a number.
That said, there's still a... -
- like https://dev.azure.com/rubylang/ruby/_build/results?buildId=1637
-
-
-
-
- I reject this issue because 5 years after my feedback.
-
-
- When RUBY_DEBUG is turned on, all RUBY_ASSERT() macros will be
enabled regardless RUBY_NDEBUG. -
-
-
- readlink would return -1 if /proc is not mounted.
Coverity Scan found this issue. -
- for test-all rule, we can specify a file with TESTS option like
`TESTS=test_xxx.rb`. However, we can eliminate last '.rb' suffix
so this patch try with '.rb' suffix if the given path is not available. -
08:46 AM Revision b67b07bd (git): Fix links to headings
- A previous change made the header's id be fully referenced (for the sidebar I believe) but this broke links to them.
This fixes the issue. - 08:45 AM Revision 73904abb (git): * expand tabs.
-
-
-
- Applied in changeset commit:git|4d9504fe13c6470d9da74540f92a247e8c1d9b99.
----------
Delegates 3 arguments for Pathname.glob.
Thanks for the patch by pocke (Masataka Kuwabara) [Feature #14405]. -
- Thanks for the patch by pocke (Masataka Kuwabara) [Feature #14405].
-
-
-
- Applied in changeset commit:git|05aac90a1bcfeb180f5e78ea8b00a4d1b04d5eed.
----------
Warn open-uri's "open" method at Kernel.
Use URI.open instead.
Thanks for the patch by jeremyevans0 (Jeremy Evans) [Misc #15893]. -
- Use URI.open instead.
Thanks for the patch by jeremyevans0 (Jeremy Evans) [Misc #15893]. - 08:16 AM Revision 9987296b (git): * expand tabs.
-
-
- ioquatix (Samuel Williams) wrote:
> We can close this issue, as there exists a satisfactory alternative.
I see.
(I don't change my feeling, https://bugs.ruby-lang.org/issues/13407#note-10 , though) -
- It is intentional behavior.
It intends that preserving the file by a pathname (especially for absolute pathname).
-
- Arguments to f_complex_new2 should not be Complex, or violate the
assertion. -
- Some exception classes accept `receiver:`, but `#inspect` does not show such information.
How about adding receiver (and key) to `#inspect`?
```
KeyError.new("message", receiver: :receiver, key: :key).inspect #=> "#<KeyError: messag... - 07:18 AM Revision 83153bbb (git): * expand tabs.
-
- It always returned 1.
-
- Just for case. This will suppress the warning of Coverity Scan.
-
-
-
06:51 AM Revision 3163a078 (git): fix issue with 'SIGINT' handling in LineEditor#reset
- @old_trap is the string "DEFAULT" and not a callable object (Proc)
if there are no other signal handlers for SIGINT signal to chain. -
- Method#inspect shows with source location.
[Feature #14145] -
-
-
-
-
-
-
- > ko1 (Koichi Sasada) What do you think of the new API caller_locations(debug: true) + Thread::Backtrace::Location#binding, doesn't it make perfect sense?
I heard that one advantage that current `debug_inspector` gem has is we can dec... -
- ```
>> puts ObjectSpace.dump(:foobar)
{"address":"0x7a210c", "type":"SYMBOL", "value":"foobar", "references":["0x7f8dd482c7d8"], "dynamic": false}
```
`address` should be pointer to `RVALUE`, so it is not acceptable.
> ...
Stati... -
-
-
-
-
-
-
- Reopened to consider whether we can make the CESU-8 encoding a dummy encoding now that we have the encoding conversion from/to UTF-8 (see issue #15995).
-
- ivar_cancel label is handling mjit_cancel_ivar_inline instead.
- 05:04 AM Revision ff5b1494 (git): * expand tabs.
-
- to suppress some Coverity Scan warnings
-
- 04:57 AM Revision 1d466424 (git): * expand tabs.
-
- In this case, flush_before_seek is enough.
This change will suppress a warning of Coverity Scan. -
- Just copy-pasting diff from
https://travis-ci.org/ruby/ruby/jobs/558407687 -
- Mostly non-constatnt array initializer, and mixed declarations and code.
-
03:23 AM Feature #5400: Remove flip-flops in 2.0
- matz@ruby.or.jp wrote:
> I hear the negative feedback from the community. OK, I give up.
> The warning should be removed.
Thank you! This saves me the trouble of rewriting a bunch of
random scripts I have.
It seems your positi... -
- Much of this has been available through my XKeys gem since Q2 2014.
```
data = {}.extend XKeys::Auto # Vs ::Hash, uses arrays for int keys
data[:users, 0, :name] # nil
data[:users, 0, :name, :raise => true] # KeyError
data[:users,... -
- Add encoding conversion (transcoding) from UTF-8 to CESU-8
and back. CESU-8 is an encoding similar to UTF-8, but encodes
codepoints above U+FFFF as two surrogates, these surrogates
again being encoded as if they were UTF-8 codepoints. Th...
07/13/2019
-
- This bug still exists. With enough entries in the database, the retrieval error rate gets fairly high (almost 2% at 32k entries):
```
# missed keys, total entries, error rate
2, 4096, 0.00048828125
14, 8192, 0.00170898437
79, 163... -
- 04:32 PM Revision 69a66e8a (git): * 2019-07-14
-
-
- Look forward to further improvements in RDoc to automatically mark
up global variables and global constants. -
-
-
- I documented the new method in [globals.rdoc](https://github.com/ruby/ruby/blob/master/doc/globals.rdoc) and added a NEWS entry.
-
- Thanks for the decision, and thanks to @nobu for already moving the method.
I noticed the documentation is still on RubyVM, I'll try to fix that. -
-
-
- * RDoc does not seem to support documenting singleton object methods,
and making $LOAD_PATH a class as a workaround is too weird. -
-
- * The longer forms are self-explanatory and I believe more often used.
* Same for ARGV and ARGF, describe them there and mention $* and $< just refer to them. -
- FWIW, a long time ago I tried to implement https://bugs.ruby-lang.org/issues/5781#note-7 in MRI but it turned out to be not so easy and I gave up.
-
- matz (Yukihiro Matsumoto) wrote:
> `taint` states will be removed from the language in the near future, along with `$SAFE`.
Do you think it will be removed for Ruby 2.7, or 3.0 maybe?
I searched for a ticket but could not find one f... -
- This issue is closed, it's probably best to discuss on a new one for different ideas.
sawa (Tsuyoshi Sawada) wrote:
> but I do not think that is a big deal.
IMHO it is a big deal, Integer() should return either an `Integer` or `ni... -
03:28 AM Bug #15987: Let `exception` option in `Kernel#Complex`, `Kernel#Float`, `Kernel#Integer`, `Kernel#Rational` be falsy vs. truthy
- nobu (Nobuyoshi Nakada) wrote:
> As for optional parameters, there are some inconsistencies.
> ...
I came up with another alternative.
Since this is about suppressing an exception, I think the concept is close to the optional second... -
09:01 AM Feature #12802: Add BLAKE2 support to Digest
- Wondering if we can review this again?
-
- The reason for this interesting behavior is because the documentation for include flag (2nd argument) for `public_methods` is not precise. It states:
```
If the all parameter is set to false, only those methods
in the receiver will... -
-
- If I understand this correctly, this is a feature request to make `String#sub` and `#sub!` return an `Enumerator` if given a single argument and no block. I'm not sure how useful this would be. With `#sub!`, you can use the enumerator ...
07/12/2019
-
-
-
-
-
-
-
- 10:22 PM Revision cbe623f1 (git): change default value of load_limit (ignore load_limit)
- 09:10 PM Revision 10d7419e (git): * 2019-07-13
-
-
- sawa (Tsuyoshi Sawada) wrote:
> znz (Kazuhiro NISHIYAMA) wrote:
> ...
As for optional parameters, there are some inconsistencies.
> ```ruby
> ...
And other methods fall back `nil` to the default value, e.g., `File.open`. -
- matz (Yukihiro Matsumoto) wrote:
> Options are:
> ...
Both sound fine to me.
nobu implemented the second option.
We can try to keep consistency in the future,
but I think we can't easily change existing methods taking a truthy/fal... -
- znz (Kazuhiro NISHIYAMA) wrote:
> I think `nil` means default behavior.
That does not hold even if you just look at the `Kernel` methods:
```ruby
exit(status=true)
Kernel::exit(status=true)
Process::exit(status=true)
exit!(sta... -
- I think `nil` means default behavior.
```
Integer("") # => ArgumentError
Integer("", exception: nil) # => ArgumentError
Integer("", exception: true) # => ArgumentError
Integer("", exception: false) # => nil
`... -
- Thank you for the next information. Could you also test the new "mjit_debug2.diff" which I attached now in the same way?
> BTW a bit OT, but seeing all the information stored in the rb_mjit_min_header-2.7.0.h, I am not sure the JIT wi... -
- BTW a bit OT, but seeing all the information stored in the rb_mjit_min_header-2.7.0.h, I am not sure the JIT will work for binary distributions such as Fedora/RHEL. There appears to be embedded a lot of information about the machine used...
-
- Here are the logs (bit messy again, but I hope you can get the information).
-
- Thank you. All of the information help me a lot.
It seems that the command line construction is broken for the second compilation in build-armv7hl.log and build-s390x.log, while build-x86_64 seems okay. In this ticket, I attached "mji... -
03:06 PM Feature #15940: Coerce symbols internal fstrings in UTF8 rather than ASCII to better share memory with string literals
- > UTF-8 is a strict super set of ASCII. Any valid ASCII is valid UTF-8.
So is EUC-JP (or Shift_JIS or many other encodings). Even though UTF-8 is the current default source encoding of Ruby, ALL ASCII symbols being in UTF-8 encoding m... -
- Just to extend your example:
```ruby
p "foo".encoding # => "euc-jp"
p :foo.to_s.encoding # => "us-ascii"
p :"注意書".to_s.encoding # => "euc-jp"
#new behavior
p "foo".encoding # => "euc-jp"
p :foo.to_s.encoding # => "utf-... -
- > If I understand your patch correctly
Yes you do.
> ...
I don't know if you are wrong, but at least we don't agree.
My reasoning is as follow:
- Simple symbols (read pure ASCII) have to be coerced into a common encoding so... -
- If I understand your patch correctly:
```ruby
# encoding: euc-jp
#old behavior
p "foo".encoding # => "euc-jp"
p :foo.to_s.encoding # => "us-ascii"
#new behavior
p "foo".encoding # => "euc-jp"
p :foo.to_s.encoding # =>... -
- > First of all, this pull-request itself breaks non UTF-8 programs.
Could you elaborate on this? I don't understand what breaks in non UTF-8 programs. I ran some tests with `# encoding: EUC-JP` and can't find anything breaking.
How... -
- > taint states will be removed from the language in the near future, along with $SAFE.
That is great to hear!
> ...
I'm not sure I understand. But if `taint` is going away in the next release then yes this change is worthless. If n... -
- `taint` states will be removed from the language in the near future, along with `$SAFE`.
I am not positive to change the behavior related to `taint`.
Matz.
-
- Patch: https://github.com/ruby/ruby/pull/2287
There was a previous attempt by Eric Wong to allow deduplication of tainted strings, but it was reverted because of unknown CI issues: https://github.com/ruby/ruby/commit/0493b1ce3a4
Th... -
- Okay, so I implemented fiber pool changes which make it more suitable for 32-bit platform. It required additional book keeping. Essentially, the allocation list and free list became double linked which allows us to remove allocations and...
-
- I did some more research about 32-bit applications.
On Windows (32-bit), the process is limited to 2GB of memory, but address space should be 4GB. This is apparently the same for 32-bit Linux, maybe that includes arm32? There are some... -
- > In general, we should tell this memory usage to GC with rb_gc_adjust_memory_usage(). I don't think it is needed in this case.
Maybe I don't follow you, but I believe fiber memory usage is reported correctly by `fiber_memsize` and `c... -
- > I know you got measurements. please share us.
I added `show_limit` to bootstrap test so we can see for all platforms. However, all platforms I tested could allocate 10,000 fibers easily. e.g. all builds on Travis, AppVeyor, etc. Whe... -
- > which size (xx KB, etc)?
```
#define RUBY_VM_FIBER_VM_STACK_SIZE ( 16 * 1024 * sizeof(VALUE)) /* 64 KB or 128 KB */
#define RUBY_VM_FIBER_VM_STACK_SIZE_MIN ( 2 * 1024 * sizeof(VALUE)) /* 8 KB or 16 KB */... -
- @matz do you mind giving your feedback/opinion if possible?
-
- To run benchmarks:
```
make benchmark ITEM=vm2_fiber
``` -
- Here is a short script you can use to compare fiber allocation performance:
```
GC.disable
puts RUBY_VERSION
system("git log -1 --oneline")
start_time = Time.now
ary = []
(1..).each{|i|
if (i % 1000).zero?
puts "#{Ti... -
- I've removed `2e7b2a0db6 Make default fiber stack size same as thread stack size.` because I think it should be separate PR.
-
- ioquatix (Samuel Williams) wrote:
> @ko1 asked:
> ...
which size (xx KB, etc)?
> > (2) maximum allocatable size
> ...
I know you got measurements. please share us.
> > (3) GC.enable/disable usage (edited)
> ...
In general, we ... -
- @ko1 asked:
> (1) stack size assumption
The fiber pool stack size is (guard page + vm_stack_size + fiber_machine_stack_size).
> ...
On 64-bit platform it's effectively the same, although in some situations it can be better due t... -
- https://github.com/ruby/ruby/pull/2224
This PR improves the performance of fiber allocation and reuse by implementing a better stack cache.
The fiber pool manages a singly linked list of fiber pool allocations. The fiber pool alloc... -
10:15 AM Bug #15993: 'require' doesn't work if there are Cyrillic chars in the path to Ruby dir
- Looks like there is an **ugly workaround**.
1) Ensure to do `chcp 1251` in the current console session.
2) Run Ruby with an option `--disable=gems` so it will not fail initially.
3) Add next code at the very beginning of a script:
... -
- alanwu (Alan Wu) wrote:
> The idea to generate a delegating lambda seems to side-step a lot of the issues posted here.
So then, would it be the same semantics as this?
```ruby
b = proc {|x, y, k:1| x }
l = lambda { |*args, **kwa... -
- Eregon (Benoit Daloze) wrote:
> With current semantics, it returns `:early_return`.
> ...
I agree.
The lambda-ness of Proc object affects control flow: the behavior of "return" and "break".
If lambda(&b) changes the lambda-ness... -
05:31 AM Feature #15973: Let Kernel#lambda always return a lambda
- Yes, I can compromise with delegation scheme, as long as it leaves its own frame in the call stack. An optional method for a proc to prevent such delegation is desirable but can be added later.
-
- The idea to generate a delegating lambda seems to side-step a lot of the issues posted here.
For reference here are some quotes from the log in #15930 (courtesy of ko1):
```ruby
b = proc {|x| x }
lambda(&b) #=> lambda {|x| b[x] }
... -
-
- 06:02 AM Revision a9ff21a2 (git): * 2019-07-12
- 06:02 AM Revision b9ad62ea (git): * remove trailing spaces.
-
- This was fixed in commit:2635984cf2b9b7632f8b35afa2f29d219aba104a. Now Ruby raises if a directory given cannot be removed. It only ignores the exception when deleting parent directories.
Issue 3178 should also been closed, but it is... -
-
- This is expected behavior. As the documentation states:
`raised_exception`: `Value from exception raised on the :raise event`
`return_value`: `Return value from :return, c_return, and b_return event`
You cannot call methods not s... -
-
-
- This difference is probably due to addition of the generational garbage collector introduced in Ruby 2.1, in combination with the specifics of the malloc implementation you are using. hashmemtest2 is expected to perform worse as you are...
-
- Ruby 2.6 added support to `Range#cover?` to accept Range arguments, which you can use instead of `include?`:
```
$ ruby25 -e 'p (1..10).cover?(2..7)'
false
$ ruby26 -e 'p (1..10).cover?(2..7)'
true
``` -
-
- It looks like `$0`, `__FILE__`, and `$PROGRAM_NAME` have been not tainted since 2.1. I'm not sure if this is still considered a bug or not.
-
- Fixed by commit:75a68057c712897bce6d787114ffa72504556756.
07/11/2019
- 11:56 PM Revision a2adcd40 (git): Add note about `STACK_GROW_DIR_DETECTION`.
- 11:56 PM Revision 5c8061a9 (git): Make `stack_check` slightly easier to use in debugger.
- 11:56 PM Revision 012e954b (git): Improved fiber benchmarks. Increase number of iterations.
-
-
-
- The profile library was removed in commit:bc76d8a232bed2e245cd3997ebd9826938f7a738.
-
-
-
- `FileUtils.mv` does rescue `EPERM` failures in `File.chown` for the newly created file if it is on a different file system, and it did so in Ruby 2.1. Ruby now also rescues `EACCESS` failures in `File.chown`. This behavior should be si...
-
- Suppose we change the spec so that `lambda(&nonlambda)` generates a lambda.
Suppose we have the following nonlambda proc:
```ruby
1: foldr = proc do |x, *xs|
2: foo(x, foldr.(xs)) if x ||! xs.empty?
3: end
```
A straight-for... -
11:57 AM Feature #15973: Let Kernel#lambda always return a lambda
- knu (Akinori MUSHA) wrote:
> I don't think the lambda flag should be altered after the creation of a proc, because it's all up to the writer of a block how `return`/`break` etc. in it should work.
akr wrote similar opinion.
This s... -
10:00 AM Feature #15973: Let Kernel#lambda always return a lambda
- I don't think the lambda flag should be altered after the creation of a proc, because it's all up to the writer of a block how `return`/`break` etc. in it should work.
What about just deprecate `lambda` in the long run in favor of the... -
- In my opinion, `lambda` should return `lambda` object as a principle. We need to keep the discussion.
Maybe we can generate a delegating lambda object in this case.
Matz. -
- I'm against it.
Changing lambda <-> proc can violate the intent of programmers who write a block.
It seems good to raise an exception at `lambda(&b)` where b is (non-lambda) proc. -
- This appears to still be a problem in the master branch, though the details have changed slightly. You still need Ctrl-C to reset the state after the `x = "#{x\"}"` line:
```
irb(main):001:0> x = "#{x\"}"
irb(main):001:0> ;
irb(ma... -
- Options are:
* accept normal truthy/falsey value for boolean (using `RTEST()`)
* accept `true`/`false` for boolean; exception for everything else
And we should keep consistency.
Matz.
-
- It doesn't feel good for me to allow arbitrary values other than `true` as truthy.
`nil` as falsy is not so weird... -
- Applied in changeset commit:git|3e7d002118a92fad5934e11c75be6768a1476c1b.
----------
Check exception flag as a bool [Bug #15987] -
- nobu (Nobuyoshi Nakada) wrote:
> this seems coming from `IO#read_nonblock` and so on.
I initially had a feeling that I had seen this opposition between `false` vs. other values somewhere else, but had forgotten where. Now that nobu h... -
- Note: The rdoc of Kernel#Integer says:
> Passing `nil` raises a TypeError, while passing a String that
> ...
and states:
> This behavior can be altered by passing `exception: false`,
> ...
So the current behavior is as documented, at... -
- It's a bug. It should be fixed.
Matz.
-
- That's why I said **experiment**. We need to measure in the real-world application to ensure the change will reduce memory consumption before the release. If not, we should give up the idea. I worry 4% reduction in fstring table is not b...
-
- matz (Yukihiro Matsumoto) wrote:
> If you update the pull-request to use the source encoding, we will merge it for the experiment.
@matz I thought the same, but that makes `:foo` in files with different source encodings no longer the... -
- First of all, this pull-request itself breaks non UTF-8 programs. It should be the source encoding instead of direct UTF-8.
Second, 4% of fstring table is only a fraction of total memory consumption. I am not sure how much effective.
... -
- Just a very brief comment since it was discussed in the last developer meeting, solely on the
syntax issue of %1, %2, versus @1, @2 and :1, :2:
To me personally, %1, %2 is almost the same as @1, @2. I'd still prefer @1 @2 etc... but ... -
- Carry over.
* [Feature #11460] Unhelpful error message when naming a module with the same name as an existing class (nobu)
* [Misc #15805] Let memory sizes of the various IMEMO object types be reflected correctly (methodmissing)
*... -
- I added the following note.
```
**A short summary of a ticket is strongly recommended. We cannot read all discussion of the ticket in a limited time.**
A proposal is often changed during the discussion, so it is very helpful to summ... -
- Please comment on your favorite ticket numbers you want to ask to discuss with your *SHORT* comment or summary.
(your summary/comment will help us because we don't need to read all of the ticket comments)
*DO NOT* discuss then on thi... -
-
-
09:23 AM Misc #15930: DevelopersMeeting20190711Japan
- * [Misc #15805] Let memory sizes of the various IMEMO object types be reflected correctly
* Only the imemo_tmpbuf type's auxiliary malloc heap buffer is factored into `obj_memsize_of`, other imemo types also alloc on the heap
* PR:... -
-
-
- Issue #15931 mentions both https://www.unicode.org/reports/tr26/tr26-4.html and https://docs.oracle.com/javase/8/docs/technotes/guides/jni/spec/types.html#modified_utf_8_strings as definitions of CESU-8, but they are not identical.
Th... -
- As discussed in issue #15931, encoding conversion (transcoding) from/to CESU-8 is missing, so we should add it. When then hopefully can make CESU-8 a dummy encoding.
- 11:14 AM Revision 4018eee4 (git): * expand tabs.
-
-
-
- Apologies for the late reply - I will do some more testing and qualify with a percentage instead.
-
-
- funny_falcon, do you have any opinion?
if no opinion, we'll discuss it one month later and will commit it.
in fact, I can't check algorithm, so we can try it.
ahorek:
could you give me more performance measurements?
* you shou... -
- ko1 will handle this.
-
06:55 AM Bug #15994 (Rejected): irb miscalculates nest level when typing do keyword
- While typing `while`, `until` and `for`, IRB miscalculates indent level after typing `do`.
Without `do`, everything OK.
```
irb(main):001:1* while false
irb(main):002:0> end
=> nil
```
Just after typing `do` (before ENTER), ne... -
- I am against adding experimental flags. The proposed benefits are:
* Stable release: Users can test new features by opt-in. But it only extends the maximum length of moratorium. If we can not decide before the release, we shouldn't me... -
- It is a bug. It has been hidden for 10+ years and seems to be very difficult to fix.
It should be fixed in the long run.
Matz.
-
- This reverts commit bae638ad5b782c44c80efe33834cb9039279af46.
[Feature #5400] -
- I am not entirely against the idea, just worrying compatibility.
Should we experiment `Time#inspect` with fraction output?
Matz. -
- I don't see any rational use of this proposal. Rejection confirmed.
Matz.
-
- I hear the negative feedback from the community. OK, I give up.
The warning should be removed.
Matz.
-
- I wanted to use backquotes for the future macro-like feature. But since it's too big incompatibility, I give up.
Matz.
-
- Applied in changeset commit:git|d77b84ca82e1cef10ef06776a207151ef864b3ca.
----------
$LOAD_PATH.resolve_feature_path
Moved from RubyVM. [Feature #15903] -
- I vote for `$LOAD_PATH.resolve_feature_path`. We need to improve the documentation as well.
Matz.
-
- Moved from RubyVM. [Feature #15903]
-
- It's so good :)
```ruby
users = [
{ id: 1, name: "Homu", age: 13 },
{ id: 2, name: "mami", age: 14 },
{ id: 3, name: "Mado", age: 21 },
{ id: 4, name: "saya", age: 14 },
]
users.select { @1 in { name: /m/, age... -
-
-
-
- This was fixed between Ruby 2.2 and 2.3:
```
$ ruby22 s3.rb
ruby 2.2.10p489 (2018-03-28 revision 63023) [x86_64-openbsd]
Without define_method: foo
With define_method: s3.rb:11:in `block in foo': super called outside of method (... -
- I think the current behavior is the behavior that should be expected. It mirrors the behavior you would expect if you implemented `Proc#curry` in Ruby:
```ruby
class Test
def test_func
140
end
end # => :test_func
p ... -
- I believe this is the intended behavior. You are using a required argument for the `-r` option, so for `--re-run x --rerun y -r --debug` the `-r` option arguments are `['x', 'y', '--debug']`, with no regular arguments. For `--re-run x ...
-
- WEBrick::HTTPProxyServer implementes HTTP proxy using
WEBrick and Net::HTTP.
WEBrick accepts HTTP/1.0 clients and
Net::HTTP uses always HTTP/1.1.
However HTTP/1.1 supports chunked transfer coding HTTP/1.0 doesn't.
Chunked transfer codi...
07/10/2019
-
- I’m trying to build a cross-platform portable application with Ruby onboard and there is a problem on Windows.
A user usually installs it to the Roaming folder which sits inside a user folder which can often have not a Latin name or co... - 06:37 PM Revision d57ce99b (git): * 2019-07-11
-
- So this is my hacked up test case:
~~~
$ git diff
diff --git a/test/ruby/test_jit.rb b/test/ruby/test_jit.rb
index 08494cbbbb..9ace7754d4 100644
--- a/test/ruby/test_jit.rb
+++ b/test/ruby/test_jit.rb
@@ -944,9 +944,15 @@ def as... -
04:12 PM Revision 12762b76 (git): Don't manipulate GC flags directly
- We need to disable the GC around compaction (for now) because object id
book keeping can cause malloc to happen and that can trigger GC. -
- Interesting - I did not know this. sawa finds stuff. :)
Personally I would be in favour of changing the behaviour as Jeremy described (I also think this
may be a bug or perhaps an oddity), but I guess it depends on a) whether matz wa... -
09:15 AM Bug #15992 (Closed): An exception breaks monitor state and cause deadlock
- Applied in changeset commit:git|f91879a7b548284c93743168acfd11e3d2aeefac.
----------
handle_interrupt to defend monitor state [Bug #15992]
If an exception is raised from another thread for example Timeout
and this thread is just after ... -
- lib/monitor.rb provides Monitor.
But its state handling is weak for interrupts caused by Thread.kill for example timeout libraries.
Timeout exception may happen everywhere. If it raised when the thread is executing
```ruby
def ... -
- If an exception is raised from another thread for example Timeout
and this thread is just after `mon_exit`'s `@mon_owner = nil`,
the exception breaks the state of MonitorMixin. To prevent that situation,
it need to block interruption in ... -
- * [Bug #10463] :~@ and :!@ are not parsed correctly (jeremyevans0)
* Can we deprecate the automatic conversion of `~@` to `~` and `!@` to `!` in method names and symbols? -
- * [Feature #15865] `<expr> in <pattern>` expression (mame)
* We have some opinions: scoping, matching strictness, the keyword `in`, and the word order. But all are not specific to the one-line matching. I think it is acceptable if `... -
-
- I agree this is a bug. I am not sure if it is a documentation bug or code bug. The existing documentation for `Array#pack` does suggest the count should specify output bytes (`width of the resulting field`), while the `m` count current...
-
- I agree this is a bug. This has been broken since the code was originally added in commit:18c0a86cc680929bbd8c48f4f45a197e3e68c70a. I added a pull request upstream to fix it: https://github.com/ruby/fileutils/pull/36
-
-
07/09/2019
-
11:18 PM Feature #15991: Allow questionmarks in variable names
- shevegen (Robert A. Heiler) wrote:
> I do not see why this would make the design more "coherent", per se.
I guess "design coherence" is a very subjective notion \^\^"
What I meant by that is that in most cases in Ruby, whether an i... -
06:53 AM Feature #15991: Allow questionmarks in variable names
- I personally often write code like this:
```ruby
class Foobar
attr_reader :completed
def completed?
@completed
end
end
```
This feels unnecessary complex to me. In #12046 it was discussed to allow `attr_reader :... -
- I couldn't find an existing proposal for a local variable that ends with `?`. There are many proposals for "attr_reader :foo?" (#5781 #10720 #11167 #12046), but all the tickets have been rejected. (#5781 is still open, but I guess it i...
-
07:57 PM Feature #15897: `it` as a default block parameter
- As a user of both Kotlin and RSpec, here's my 0.01 cents: I've been using Kotlin for almost 1.5 years, and the implicit `it` is really nice shortcut, without making the code too harder to understand. Even newcomers seem to get `it` prett...
-
- I think we should listen to RSpec users here like @joallard and would welcome more users to reply on this thread.
People who maintain software defining `it` probably have a different view than their users.
If RSpec users understand `it... -
- JonRowe (Jon Rowe) wrote:
> its a "this shadows the most commonly used method in the most downloaded rubygem"[1], its not one or two people this will affect.
It only "shadows" (by that I understand "no longer works in that case") for... -
11:06 AM Feature #15897: `it` as a default block parameter
- @mame I did, I apologise for not making it clear, I'm reiterating it to add weight to the con, its not just a simple "it is somewhat fragile, it may refer to a wrong variable" its a "this shadows the most commonly used method in the most...
-
06:34 PM Feature #15899: String#before and String#after
- I'd like to add my +1 to this idea. Splitting a string by a substring (and only caring about the first result) is a use case I run into all the time. In fact, the example given by @kke of splitting a `Content-Type` HTTP header by the sem...
-
-
-
-
- nobu (Nobuyoshi Nakada) wrote:
> jeremyevans0 (Jeremy Evans) wrote:
> ...
Well, `foo.!@` would be a syntax error with the patch. Is there a reason other than backwards compatibility to keep this automatic aliasing of `!@` to `!` and `... -
- jeremyevans0 (Jeremy Evans) wrote:
> nobu (Nobuyoshi Nakada) wrote:
> ...
Sorry, forgot `@`, I wanted to mean `!foo` and `foo.!@`. -
- nobu (Nobuyoshi Nakada) wrote:
> If `:!@` and `:!` are different things, also `!foo` and `foo.!` are different things.
I don't believe that is true. With the above patch:
```ruby
class A
def !; :! end
def ~; :~ end
end
... -
- If `:!@` and `:!` are different things, also `!foo` and `foo.!` are different things.
This means a backward incompatibility. -
- I did some research, and this is related to the fact that Ruby allows `!@` and `~@` as method names (back to the initial SVN revision for `~@`), silently dropping the `@` from the method name:
```ruby
class A
def !@; :!@ end
de... -
-
- FYI: RubyCI platforms include [RHEL 7.1 s390x][1] and [Ubuntu armv8 (aarch64)][2], and their results are both green at the present time. So the cause would be the other factor than CPU, I guess.
[1]: https://rubyci.org/logs/rubyci.s3... -
- I see. Thanks for the information. At this moment I cannot do anything either, so I'll wait for you to collect the information from the CI system somehow.
-
- I wish this was easier to debug. The problem is that this is test failure and it happens on build system, where I don't have access. Trying to reproduce it on my system, this does not work:
~~~
$ echo "
def multiply(a, b)
a *= b
... -
- This `last_state` is set to `lex.state` just before the `switch`
statement, and `token_flush` nor `nextc` never change the state. - 03:09 PM Revision 57b8ca21 (git): * 2019-07-10
-
- alanwu (Alan Wu) wrote:
> `Kernel#lambda` is in a weird spot. Even though it's a method, making it behave like one has the unfortunate side-effect of allowing proc transformation.
Yes, the semantics of `Kernel#lambda` have always bee... -
- > Can I ask you why you need this feature?
I want to be able to forward a block to `Kernel#lambda`.
`Kernel#lambda` is in a weird spot. Even though it's a method, making it behave like one has the unfortunate side-effect of allowi... -
- It should be OK when passing the buffer from callers, but doesn't work with a library which returns a buffer allocated inside.
FYI: you can allocate the buffer by `rb_str_new(NULL, size_you_want)` at once. -
- Instead of working on a separate buffer then asking Ruby to take ownership, you could make changes to the buffer of a string:
```c
VALUE new_string = rb_str_new("", 0);
rb_str_resize(new_string, size_you_want);
do_work(RSTRING_PTR(... -
-
-
-
-
- I merged it.
-
-
-
- This was fixed between Ruby 2.2 and 2.3:
```
$ irb22
irb(main):001:0> def !; end
=> :!
irb(main):002:0> !
/usr/local/lib/ruby/2.2/irb/input-method.rb:151:in `gets': private method `!' called for false:FalseClass (NoMethodError)
... -
-
- `system` was made more strict for redirection errors between Ruby 2.2 and 2.3:
```
speedstar$ ruby22 -e "p system('true', out: %w(bad/file.txt w))"
nil
speedstar$ ruby23 -e "p system('true', out: %w(bad/file.txt w))"
-e:1:in `s... -
-
-
-
-
-
- This was fixed between 2.1 and 2.2:
```
$ ruby21 -ruri -e "p URI 'http://localhost:3000/?url=google.com&clipRect={"top":0,"left":0,"width":1050,"height":700}'"
/usr/local/lib/ruby/2.1/uri/common.rb:176:in `split': bad URI(is not... -
- I believe this issue was fixed by commit:aa107497cd379b713eba8cecdb9a882bb1e0dd89, which removed the `argc` and `argv` variables in favor of using `rb_execarg_commandline(eargp, &prog)`, and `eargp` and `prog` are always initialized.
-
-
- This issue was fixed between Ruby 2.2 and 2.3:
```
$ ruby23 test.rb
User
$ ruby22 test.rb
.../user.rb:4:in `yield': fiber called across stack rewinding barrier (FiberError)
from .../user.rb:4:in `<top (required)>'
... -
- ruby-doc.org is a third party site, so this would be an issue to report to them. However, `%xdate` no longer appears on the linked page.
-
- I don't think this is a bug, the current behavior is consistent and what I would expect. It would be inconsistent to assume the current year for `%m/%d` format in some cases and not in others. It is better to raise an exception if that...