Activity
From 06/14/2019 to 06/20/2019
06/20/2019
-
11:53 PM Bug #14317 (Rejected): Date.strptime(..., "%U") fails if first day of the week is not in the 0th week.
- I do not think this is a bug. It is reasonable for `Date.strptime` to assume a value of 0/Sunday for `:cwday`/`%u` if `:wnum0`/`%U` is specified without `%u`. In every other case where you specify `%U` without `%u`, you get a Sunday. I...
-
- I do not think the current error message is a bug, and changing the message would be considered a feature. In general, Ruby TypeError messages are not completely descriptive as to the argument and method names. That is not specific to ...
-
11:09 PM Bug #14968: [PATCH] io.c: make all pipes nonblocking by default
- Eric do you mind explaining where we got to with this and how to move forward?
-
- I agree this is a bug that should be fixed, and the patch is a proper way to fix it. Attached is an updated patch that applies against the master branch, along with a test.
-
- While the current code is not really a bug (Shellwords.escape does not guarantee to only escape when required), I agree it makes sense not to escape +. From what I read, in addition to Bourne sh, neither bash nor ksh require escaping +. ...
-
-
- I tried this example against an nginx instance, and received normal HTTP error codes (413 or 404 depending on payload size). However, on some other webservers (OpenBSD httpd and Webrick), I did see EPIPE failures in write_nonblock. Igno...
-
07:20 PM Feature #15777: autoload?(cname, inherit=true)
- > Is it necessary to export rb_autoload_at_p?
> ...
~~No I have no such plan. I did so because it's defined in `variable.c` but called from `load.c` so without that declaration it won't compile:~~
```
load.c:1180:12: error: implicit... -
06:49 AM Feature #15777: autoload?(cname, inherit=true)
- byroot (Jean Boussier) wrote:
> Let me know if you desire further changes.
Fix the bug first.
In `rb_autoload_at_p`, this condition is wrong.
```diff
- while (!autoload_defined_p(mod, id)) {
+ while (RTEST(recur) && autol... -
- Is it necessary to export `rb_autoload_at_p`?
Do you have the plan to use it in extension libraries? -
07:18 PM Feature #15936: on_error in lieu of rescue, raise
- duerst (Martin Dürst) wrote:
> kylemacey (Kyle Macey) wrote:
> ...
Very true! I can certainly do that, I just thought this might have the added benefit of writing more explicit and intentional code, and would eliminate the need to re-r... -
- jeremyevans0 (Jeremy Evans) wrote:
> kylemacey (Kyle Macey) wrote:
> ...
`ensure` fires even if there is no exception. This keyword would only fire when there is an exception. In your example, `job.fail!` would always be called.
Edi... -
- I agree that `File#path` should not be tainted unless the path given was tainted. Attached is a patch that fixes the issue
The code to always taint the result was added in commit:a4934a42cbb84b6679912226581c71b435671f55 in 2003 by ma... -
- This spurious warning appears in ruby 2.5.5, but not in ruby 2.6.3. Please upgrade to Ruby 2.6.3. This should be fixed in 2.5 if commit:179045acaf5de8398c321ada86a76f1afb77a796 is backported.
-
-
- Can you try 2.5.5? It seems likely the problem is fixed there.
-
- I agree that Ruby should consistently use lowercase for IPv6 addresses. However, I don't think we should introduce a dependency on `ipaddr` to `resolv`. For one, it changes how the IPv6 addresses with noncontiguous 0 components are dis...
-
- The error indicates `executable host ruby is required. use --with-baseruby option.` Does the error happen if you use the `--with-baseruby` option when configuring?
-
- This was a bug in `curb`, apparently fixed by https://github.com/taf2/curb/commit/01b715a59fbd4914713104dbf04c1aece2bcdf82 according to https://github.com/taf2/curb/issues/342.
-
- This was a bug in `curb`, apparently fixed by https://github.com/taf2/curb/commit/01b715a59fbd4914713104dbf04c1aece2bcdf82 according to https://github.com/taf2/curb/issues/342.
-
-
05:28 PM Bug #14822 (Closed): [POP3/SSL] net/protocol.rb:44: warning: verify_hostname requires hostname to be set
- Applied in changeset commit:git|4a5e07d8e17a0f62810f983114a88cb1011f971b.
----------
Avoid verbose warning when using Net::POP3 with SSL
Patch from Jos Kamphorst.
Fixes [Bug #14822] -
- I can reproduce this issue, and have confirmed your fix removes the warning. It would have been helpful to mention that this warning is only printed in verbose mode. :)
- 05:28 PM Revision 2ee1c762 (git): * 2019-06-21
-
- Patch from Jos Kamphorst.
Fixes [Bug #14822] -
- I believe this is expected behavior and not a bug. From the man page for `SSL_CTX_set_verify` (https://www.openssl.org/docs/man1.1.1/man3/SSL_CTX_set_verify.html):
```
The verify_callback function is used to control the behaviour wh... -
-
- The segfault is in a external gem (rautomation) that uses FFI: https://github.com/jarmo/RAutomation/blob/7314a7e6f8bbba797d276ca1950abde0cba6897a/lib/rautomation/adapter/win_32/functions.rb#L18-L19
It looks very similar to a bug repor... -
-
02:39 PM Feature #15945: Option to truncate in `String#ljust`, `String#rjust`, and `String#center`
- I do not have any particular pro/con opinion per se as far as the feature itself
is suggested; if anything then I am mostly neutral, perhaps slightly positive as
I can see a (slight?) use case for it - I guess it depends a lot on the p... -
12:00 PM Feature #15945 (Open): Option to truncate in `String#ljust`, `String#rjust`, and `String#center`
- Sometimes, I need to adjust a string to an exact length: Pad if shorter, and truncate if longer. To do that, I need to combine two methods like this:
```ruby
"12".ljust(5, "*")[0, 5] # => "12***"
"1234567".ljust(5, "*")[0, 5]... -
01:27 PM Revision 93356576 (git): Revert "Removed needless file with the upstream repository."
- This reverts commit 5bbfca7b1d4be89d4728203b4610de17bccbefd7.
-
- 11:12 AM Revision 9e7a8a43 (git): Only ignore build directories.
-
10:39 AM Bug #15841: SegFault in OpenSSL::PKey::RSA#private_encrypt
- I creaated a PR, https://github.com/ruby/openssl/pull/258 , about remaining issues.
> 2. if rsa.set_key had called without d argument, rsa.private? should return false.
- 10:36 AM Revision f607e433 (git): Transition root fiber into state FIBER_TERMINATED.
- During fork, it's possible that threads with root fibers are terminated,
but fiber state is not updated. `fiber_verify` will subsequently fail. We
forcefully enter the FIBER_TERMINATED state when terminating the root
fiber. -
-
-
08:40 AM Revision e6fbdde2 (git): Fix a typo [ci skip]
-
- I merged bin/racc at https://github.com/ruby/ruby/compare/1a2546c...754df26.
-
-
-
-
-
- 1.4.16.pre.1 is the teemporary version. It may be changed 1.5.0 or others.
-
07:00 AM Revision c4c47b79 (git): Disable auto indent when move cursor up or down
- This commit suppresses a strange behavior below:
if true
1[cursor]
end
and press down key
if true
1
end -
04:48 AM Feature #15940: Coerce symbols internal fstrings in UTF8 rather than ASCII to better share memory with string literals
- I think this change makes a lot of sense, not only because of the memory savings, but also because of the streamlining for encodings in general.
I agree that the chance of backwards incompatibilities in actual programs is very low. I ... - 04:44 AM Revision e4cafa39 (git): Ensure that vm_stack is cleared in `thread_cleanup_func_before_exec`.
- If `vm_stack` is left dangling in a forked process, the gc attempts to scan
it, but it is invalid and will cause a segfault. Therefore, we clear it
before forking.
In order to simplify this, `rb_ec_clear_vm_stack` was introduced. -
- What @shevegen says: raise it at https://github.com/rubygems/rubygems, please.
-
04:25 AM Bug #15944 (Closed): Simultaneous line feeding and scrolling doesn't work well with irb on tmux
- See attached capture.
I just entered `1+1` repeatedly.
(`1+1` doesn't matter, whatever can cause the same behavior)
The problem is that the line of the expression `irb(main):xxx:0> 1+1` will disappear when the window scrolls.
T... - 03:30 AM Revision c26c5144 (git): Revert failed attempt at fixing invalid usage of vm_stack.
- 02:55 AM Revision 7d9d1ed4 (git): Don't clear cfp, it causes problems.
- 02:16 AM Revision 15c4f6ae (git): Skip `rb_ec_clear_vm_stack` for now.
- 01:41 AM Revision 19931099 (git): * remove trailing spaces.
- 01:41 AM Revision dbc2b89b (git): Ensure `vm_stack` is cleared after fork.
- 12:07 AM Revision 6bf1285b (git): Fix typo in VM_ASSERT.
06/19/2019
- 11:56 PM Revision 62648372 (git): Set `cfp` to null (along with vm_stack) in `rb_fiber_close`.
- 11:32 PM Revision 25049a6e (git): Extra assertions around thread.
- 11:31 PM Revision 91c4ef01 (git): Don't try to dereference NULL cfp.
-
- I would like to add a bug triaging guide to the repository at `doc/bug_triaging.rdoc`, giving recommendations for triaging bugs. Alternatively, this guide could be added as a Wiki page on the bug tracker (`HowToBugTriage`). I plan to s...
-
- dlee (David Lee) wrote:
> Thank you for the update. We know that Ruby 2.5+ has fixed this issue, but we were hoping the fix could be backported. Do you know if there is any workaround to reliably get Regexp to throw those errors?
You... -
08:46 PM Bug #15938: Error thrown undeterministically: `RegexpError: empty range in char class`
- Jeremy,
Thank you for the update. We know that Ruby 2.5+ has fixed this issue, but we were hoping the fix could be backported. Do you know if there is any workaround to reliably get Regexp to throw those errors?
Nobuyoshi,
Thank... -
- `\w` cannot be an edge of range in char-class, as it is not a single char.
-
- I was able to reproduce your issue. However, Ruby 2.4 is in security maintenance phase. As this does not appear to be a security issue, we will not be backporting changes to fix it. Please see https://www.ruby-lang.org/en/downloads/bran...
-
- FYI, these errors are deterministically thrown in ruby versions 2.5+, albeit with a different error message: `unmatched range specifier in char-class`.
-
- When instantiating a Regexp, we only sometimes see `RegexpError: empty range in char class`.
To reproduce:
`100.times { Regexp.new("^([\\w'+-.%]+@[\\w-.]+\\.[A-Za-z]{2,25})(,[\\w+-.%]+@[\\w-.]+\\.[A-Za-z]{2,4}){0,4}$") }`
usually do... -
- I was able to reproduce this issue with the current master branch. I'm not sure why it occurs, though. The thread that is stopped (the main thread) is woken up by the thread that `IRB.irb` spawns before that thread exits. So I am not ...
-
- I think this may be better to raise at https://github.com/rubygems/rubygems - while some
ruby core members contribute to the code of gems, it still seems to fit better to the
github site of rubygems.
To the feature/functionality in ... -
06:44 PM Feature #15942 (Third Party's Issue): gem: Warn on known vulnerable packages
- In comparison to RubyGems, NPM offers builtin warnings when users attempt to install packages with known vulnerabilities. This helps developers to more quickly react to security concerns, updating or replacing their dependencies.
CI a... -
- Using Ruby 2.6's new timezone support for Time, I think you can get the behavior you want, so that time calculations do not change based on `TZ`.
```ruby
ENV['TZ'] = "Pacific/Auckland"
time = Time.at(Time.parse("5pm"), in: TZInfo::T... -
07:36 PM Bug #15941: Issue with String#scrub when given block and receiver is modified in block
- Patch lgtm, thanks!
-
- I can confirm this issue, and agree that handling it similarly to `String#gsub` makes sense. Attached is a patch that does that.
-
- I guess the solution here would be something similar to `String#gsub`, with `str_mod_check`.
-
- This should cause a segmentation fault:
```ruby
s = "abc\u3042\xE3\x80"
loop do
s.scrub{|bytes| s << "more content"; "?" }
end
```
Not something that should happen, but I thought it might cause undesired behavior.
Thank y... -
-
- Applied in changeset commit:git|a0af60c7f2d852faa6d3263874224dd7950bda43.
----------
Remove spec testing undefined behavior
Fixes [Bug #15432] -
- Fixes [Bug #15432]
-
- Applied in changeset commit:git|b9ef35e4c6325864e013ab6e45df6fe00f759a47.
----------
Implement Complex#<=>
Implement Complex#<=> so that it is usable as an argument when
calling <=> on objects of other classes (since #coerce will coerc... - 07:07 PM Revision 208cc6e3 (git): * 2019-06-20
- 07:07 PM Revision fdfe51d1 (git): * expand tabs.
-
-
- This appears to be an issue in the mysql2 gem. It is similar to https://github.com/brianmario/mysql2/issues/1036#issuecomment-487389420. If it is still happening to you, you may want to update that mysql2 issue with details.
-
-
- This segfault occurs in a 3rd party C extension: https://github.com/ruby-gnome2/ruby-gnome2/blob/master/glib2/ext/glib2/rbgobj_type.c#L432-L453
You should probably discuss the issue in https://github.com/ruby-gnome2/ruby-gnome2/issues... -
-
- Implement Complex#<=> so that it is usable as an argument when
calling <=> on objects of other classes (since #coerce will coerce
such numbers to Complex). If the complex number has a zero imaginary
part, and the other argument is a rea... -
- luke-gru (Luke Gruber) wrote:
> Hi Jeremy, thanks for the patch. I agree with the strategy of just dealing with this in `str_uminus` directly instead of fiddling around in the tricky `rb_fstring` function. However there's still an issue... -
- Hi Jeremy, thanks for the patch. I agree with the strategy of just dealing with this in `str_uminus` directly instead of fiddling around in the tricky `rb_fstring` function. However there's still an issue when the string is a regular Str...
-
- I agree that this is a bug. I'm not sure if `rb_fstring`'s behavior should be changed (hopefully a more knowledgeable committer can weigh in), so a conservative approach to fix this is to dup the receiver before passing to `rb_fstring`,...
-
- In order to provide some data, I counted the duplicates in a Redmine heap dump (`ObjectSpace.dump_all`):
Here the counting code:
```ruby
#!/usr/bin/env ruby
# frozen_string_literal: true
require 'json'
fstrings = []
STDIN.ea... -
- Patch: https://github.com/ruby/ruby/pull/2242
It's not uncommon for symbols to have literal string counterparts, e.g.
```ruby
class User
attr_accessor :name
def as_json
{ 'name' => name }
end
end
```
Since the... -
- @nobu I edited the patch the way you suggested. Let me know if you desire further changes.
-
02:10 PM Revision 65944e96 (git): test/racc/test_racc_command.rb: Extend the timeout
- test_opal, test_ruby18, and test_ruby22 are slow tests.
https://rubyci.org/logs/rubyci.s3.amazonaws.com/scw-ad7f67/ruby-master/log/20190619T105405Z.fail.html.gz - 02:05 PM Revision 2abe548f (git): Don't change vm_stack/cfp without acquiring gvl first.
-
12:59 PM Bug #15933: OpenURI: Assign default charset for HTTPS as well as HTTP
- Updated patch attached
-
- Patch: https://github.com/ruby/ruby/pull/2240
Symbols wether they are dynamic or static do hold a reference onto their respective fstring, so it's important to dump these references so that it's possible to see that a String isn't gar... -
-
- Okay, it was merged.
-
- Here is PR: https://github.com/ruby/ruby/pull/2241
-
05:51 AM Feature #15894: Remove support for IA64
- Sounds reasonable.
Matz.
- 11:33 AM Revision 659eda7f (git): * expand tabs.
- 11:30 AM Revision d17344cf (git): Remove IA64 support.
-
- It break the some build environment.
- 09:19 AM Revision b93508b3 (git): * remove trailing spaces, append newline at EOF.
-
-
- Because some environment created the different results from test fixtures.
-
-
-
-
- Co-authored-by: Nobuyoshi Nakada <nobu@ruby-lang.org>
-
-
-
-
-
- 08:39 AM Revision cbe06cd3 (git): * remove trailing spaces, expand tabs.
- 08:39 AM Revision 3e5b885c (git): Rework debug conditional.
- 08:39 AM Revision cb5da39f (git): Use shared implementation of `rb_ec_initialize_vm_stack`.
- 08:39 AM Revision 71470380 (git): Update `stack_start` and `stack_maxsize` according to stack direction.
- 08:39 AM Revision dee0cfbb (git): Specify that size is non-committed memory.
- 08:39 AM Revision 561c9bcf (git): Make sure `alloca` fast path is used (inline assembler).
- 08:39 AM Revision 7cc7269b (git): Use default stack size for worker thread (no th pointer available).
- 08:39 AM Revision 9cb4e772 (git): Handle (empty) backtrace when thread is not born yet.
- 08:39 AM Revision 5855af73 (git): Basic assertions for thread initialization.
- 08:39 AM Revision 8121a523 (git): Use stack size defaults for win32 threads.
- 08:39 AM Revision b8e4bea7 (git): Track how stack was allocated for `cont_free`.
- 08:39 AM Revision 4b3b781c (git): Ensure execution context is cleared after thread is finished.
- 08:39 AM Revision 38791145 (git): Better handling of root fiber.
- 08:39 AM Revision 7c7a1c22 (git): Fix handling of vm_stack_size and avoid trying to deallocate it.
- 08:39 AM Revision b24603ad (git): Move vm stack init into thread.
- 08:39 AM Revision 69195fd9 (git): Show thread and fiber limits as part of bootstrap tests.
- 08:39 AM Revision 3fd83cb6 (git): Improve benchmarks and tests for threads.
- 08:39 AM Revision a6a4e860 (git): Ignore `/build*`.
-
- kylemacey (Kyle Macey) wrote:
> This is coming from a need that I personally face often on the utilities I work on, where I need to update state on an object if something unexpected happens. My company's linter gets upset when I use t... -
- kylemacey (Kyle Macey) wrote:
> What would be a thought on using another keyword that doesn't actually _rescue_ an exception, but performs an operation in the event of an error? Similar to `ensure`, but only in the event of an error.
>... -
- shevegen (Robert A. Heiler) wrote:
> Hmmm.
> ...
Yeah, this is a proposal to extend the available keywords in ruby core. So ideally, there would be release notes and documentation that would help guide people to this new feature.
> ... -
- Applied in changeset commit:git|e690df1f1ef4f791295448f9192d6e027400ee72.
----------
Marshal distant past/future
[Feature #15160] -
- [Feature #15160]
-
- * string.c (rb_str_init): allocate new buffer if the string is
shared. [Bug #15937] -
- I no longer get the segfault if in `rb_str_init`, `return str` is added right after existing check of `(orig == str)`, but then capacity of string won't change.
EDIT: I think I figured out what was going on. If `str` is a shared strin... -
- Sorry, I forgot `puts s` in second script. I still get the segfault even in trunk with your patch, but the embedded small strings case is fixed.
Thank you. -
- Applied in changeset commit:git|28678997e40869f5591eae60edd9757334426ffb.
----------
Preserve the string content at self-copying
* string.c (rb_str_init): preserve the embedded content when
self-copying with a capacity. [Bug #15937] -
- I can't reproduce the buffer corruption nor the segfault, but found the content was cleared on a short string.
Which version did you try? -
01:09 AM Revision 148f50fc (git): Update homebrew on Travis
- because Travis is crashing like "Error: Your Homebrew is outdated.
Please run `brew update`."
https://travis-ci.org/ruby/ruby/jobs/547485832 -
- * string.c (rb_str_init): preserve the embedded content when
self-copying with a capacity. [Bug #15937] -
06/18/2019
- 11:29 PM Revision c9729329 (git): * 2019-06-19
-
-
- Hmmm.
I have not made up my mind so I can not even say whether this may be interesting
or not.
But I think just a few general thoughts:
- People may expect begin/rescue/end, more than any alternatives. They may wonder
what on_... -
- A common bad pattern in ruby is to rescue any exception and accidentally clobber the exception.
```
begin
some_method
rescue StandardError
#
end
```
Most linters will complain if you write rescues like the code above. H... -
- NOTE: I didn't attach a patch or proof of concept fix because I don't know how you want to handle this edge case. The easiest thing would just be to return the original string in `rb_str_init` and not honor the capacity change here.
-
- Reproduction steps:
string buffer corruption:
```ruby
s = "mystring"
s.__send__(:initialize, s, capacity: 1000)
puts s
```
segfault:
```ruby
s = "mystring that can't be embedded because it's too long and therefore must be ... -
03:48 PM Feature #5400: Remove flip-flops in 2.0
- rovf (Ronald Fischer) wrote:
> Do NOT remove this useful feature!!! I used it a lot already in Perl, and now using it in Ruby too. The deprecation warning also causes a lot of headache
Very much this. I find the flip-flop operator ... -
12:47 PM Feature #5400: Remove flip-flops in 2.0
- judofyr (Magnus Holm) wrote:
> Nobody knows them. Nobody uses them. Let's just get rid of flip-flops, shall we?
Do NOT remove this useful feature!!! I used it a lot already in Perl, and now using it in Ruby too. The deprecation warni... -
- * [Feature #5400] Remove flip-flops in 2.0
* Strong objections.
-
02:08 PM Bug #15807: Range#minmax is slow and never returns for endless ranges
- I think it would make sense for `Enumerable#minmax` to just be `[min, max]`, and be overridden on some classes if useful (probably rare).
-
-
-
- Let's stop reporting the failure until it gets stable.
We can see the build status on console with this config anyway. -
12:20 PM Feature #15665: Cannot compile socket extension on Mojave
- @nobu Please update, or is there any reason that this should be a feature instead of a bug?
-
- phluid61 (Matthew Kerwin) wrote:
>
> ...
Sorry, I wasn't clear. Yes the registry itself is in XML/CSV – that's what the `mime_types_data` gem uses to build its dataset – but it doesn't include "default charset parameter" or even detai... -
09:24 AM Bug #15933: OpenURI: Assign default charset for HTTPS as well as HTTP
- gareth (Gareth Adams) wrote:
>
> ...
The entire registry is available as [XML](https://www.iana.org/assignments/media-types/media-types.xml) and each individual registry is available as (ironically) text/csv; e.g. https://www.iana.org... -
- Thanks Matthew,
I've now paid more attention to which RFCs are obsolete and which are still active.
phluid61 (Matthew Kerwin) wrote:
> > So it seems if you're making a change, it should be: ignore the protocol, and default to UTF-... -
-
08:42 AM Bug #15929: Array#minmax is much slower than calling both #min and #max
- jeremyevans0 (Jeremy Evans) wrote:
> We cannot use this approach. [...]
I see, thanks for the explanation! -
- jeremyevans0 (Jeremy Evans) wrote:
> Your recommended implementation greatly improves performance.
I fear this benchmark result "over-idealizes" the performance improvements because `SortedSet#to_a` is memoized [here](https://github... -
- ```
% ruby -e '$,=""; $;=""'
-e:1: warning: non-nil $, will be deprecated
-e:1: warning: non-nil $; will be deprecated
``` -
- * string.c (str_make_independent_expand): free independent buffer.
[Bug# 15935]
Co-Authored-By: luke-gru (Luke Gruber) <luke.gru@gmail.com> -
03:21 AM Bug #15934 (Closed): String#b can lead to memory corruption
- Applied in changeset commit:git|9dec4e8fc3a6018261834b5ac9b9877f787b97ca.
----------
String#b: Don't depend on dependent string
Registering a string that depend on a dependent string as fstring
can lead to use-after-free. See c06ddfe a... - 03:21 AM Revision c770c98a (git): * expand tabs.
-
- Registering a string that depend on a dependent string as fstring
can lead to use-after-free. See c06ddfe and 3f95620 for details.
The following script triggers use-after-free on trunk, 2.4.6, 2.5.5
and 2.6.3. Credits to @wanabe for usi...
06/17/2019
-
- phluid61 (Matthew Kerwin) wrote:
> So it seems if you're making a change, it should be: ignore the protocol, and default to UTF-8 for `text/csv`.
Or rather: ignore the protocol; and consult the IANA registry to see what the individua... -
- A lot of those quoted specs are very, very old, and in some cases obsoleted by newer specs.
HTTP/1.1 Semantics and Content [RFC7231/B](https://tools.ietf.org/html/rfc7231#appendix-B):
> The default charset of ISO-8859-1 for text me... -
- I think this change makes sense and the patch is the simplest way to implement it.
-
- Using `open-uri` to load a document in the following circumstances:
* The `Content-Type` header is `text/*` and *doesn't* specify a charset, e.g. `Content-Type: text/csv`
* The document is loaded from an `https://` URL
…will cause... -
- Now that it has been decided that Ruby 3 will not use frozen string literals by default, I think we should not assume that code that breaks with `--enable-frozen-string-literal` is buggy, just as we should not assume that code that brea...
-
-
-
- Can you reproduce this segfault with 2.6.3 or the master branch?
-
-
- alexis (Alexis Bernard) wrote:
> I kept to investigate the memory leak issue. It seems it comes when OpenSSL::SSL::VERIFY_PEER is enabled and a ca_file is specified :
I tried with your example with 2.7.0-preview1 and it is either not... -
- I agree, we should fix this. The attached patch is my attempt to do so, removing ChangeLog-specific parts and keeping other parts as a guide for commit messages.
-
-
- Your recommended implementation greatly improves performance. From the benchmark in the attached patch:
```
Calculating -------------------------------------
../ruby2/run_ruby run_ruby
mi... -
- Applied in changeset commit:git|c8edf70cd20b9ff72ebd1e9402a556089f6ff204.
----------
Update documentation for File.executable{,_real}? to mention Windows issues
Fixes [Bug #15664] - 09:05 PM Revision 39a8c714 (git): * 2019-06-18
-
- Fixes [Bug #15664]
-
- Hi, I've found a leak that can be reproduced in the following way:
```ruby
loop do
puts "running..."
50.times do
File.open("./test/rexml/data/utf16.xml", external_encoding: 'UTF-16LE', binmode: true) do |f| # mus... -
- The following script triggers use-after-free on trunk(801d0d9), 2.4.6, 2.5.5
and 2.6.3.
```ruby
a = ('j' * 24).b.b
eval('', binding, a)
p a
4.times { GC.start }
p a
```
The consequence is usually that `a` gets corrupted (... -
- janosch-x (Janosch Müller) wrote:
> possible solutions:
> ...
We cannot use this approach. `Enumerable#each` can have side effects, and you cannot iterate twice for `minmax` in the general case. Consider:
```ruby
File.open('...',... -
- After discussion with some OpenBSD developers, the non-POSIX behavior of realpath(3) in OpenBSD will be removed in the future (POSIX realpath(3) requires that all components of the path exist). So I've updated the pull request (https://...
-
-
03:17 PM Bug #11174: threads memory leak
- The problem remains on a manually built glibc 2.28 with ruby 2.7.0dev (2019-06-17T14:25:47Z trunk 801d0d9dd7) [x86_64-linux]. So if the problem is related to glibc, the 2.28 version has no fix yet.
-
-
- * parse.y (value_expr_check): `then` or `else` only `if` is not a
void value expression, as the counterpart is evaluated as `nil`.
[Bug #15932] -
- ioquatix (Samuel Williams) wrote:
> If it's not clear, previous statement is evaluated like:
> ...
It can't be higher precedence than `.`, or it will conflict with other syntaxes too much.
Rather it should be interpreted like as:
```... -
- Applied in changeset commit:git|01b3a3804334be19d013526d3edde2b84399ae43.
----------
Fix wrong "void value expression" error
* parse.y (value_expr_check): if either of `then` or `else`
statements is not a void value expression, the w... -
- When a 'next' or 'break' statement for block/loop control is placed inside an 'if' assignment, the parser outputs an error "void value expression". The same parsing error raises for the ternary operator in the same conditions.
I think... -
- * parse.y (value_expr_check): if either of `then` or `else`
statements is not a void value expression, the whole `if` is not
also a void value expression. [Bug #15932] - 10:56 AM Revision 09a84608 (git): * 2019-06-17
-
- Don't think that this proposal can be applied to any words. A common name is much more dangerous than a pronoun like `it` because it is much more frequently used as a method name.
Actually, the count of "def item()" is 20 times more ... -
- sawa (Tsuyoshi Sawada) wrote:
> I propose to use a new keyword `item`.
I think that is a great proposal.
`it` is nice to read when passed to methods of other objects or when used with binary operators:
```ruby
strings.each { p... -
- I propose to use a new keyword `item`.
* I feel that using a keyword spelt in letters is the right way here since keywords like `self` are used in other cases where we reach for things out of the blue without receiving them through ar... -
08:01 AM Feature #15897: `it` as a default block parameter
- Eregon (Benoit Daloze) wrote:
> shugo (Shugo Maeda) wrote:
> ...
`it` doesn't look ugly at first glance, but `it` makes the language semantics dirty as mame admitted in his proposal.
> I think readability matters a lot to many peopl... -
- * [Feature #15903] Move RubyVM.resolve_feature_path to Kernel.resolve_feature_path
* matz: Could you decide between `Kernel.resolve_feature_path` and `$LOAD_PATH.resolve_feature_path`?
* [Feature #15897] `it` as a default block par... -
- Carry-over tickets.
* [Feature #14912] Introduce pattern matching syntax ([pitr.ch](https://twitter.com/pitr_ch))
* Could the pattern matching be made available as a first-class citizen to be used as a filter when searching in data... -
- Please comment on your favorite ticket numbers you want to ask to discuss with your *SHORT* comment or summary.
(your summary/comment will help us because we don't need to read all of the ticket comments)
*DO NOT* discuss then on thi... -
07:20 AM Feature #15931 (Assigned): encoding for CESU-8
- RubyとJavaのブリッジを開発していて、文字列の変換処理で困っています。
現象）
JavaのUTF-8は非標準的な形式 (https://docs.oracle.com/javase/8/docs/technotes/guides/jni/spec/types.html#modified_utf_8_strings) なので、Ruby側の文字列をそのままUTF-8にエンコードして与えると、Java側ではサロゲートペアに相当する文字を正しく認識できません。
お願... -
- In my own custom, hand-written yaml files I tend to use e. g:
!ruby/symbol foo: bar
for symbols as keys. This would then lead to this Hash, upon
YAML.load_file:
x = YAML.load_file 'foo.yml' # => {:foo=>"bar"}
For pro... -
- Is size in characters or bytes?
-
- I wonder if we should have consistency with `slice` and `each_slice` from `Array`. But honestly, I don't care, just if it's available.
-
- Here is a usecase
https://github.com/socketry/protocol-http2/blob/12875a97e0f82315682191e3bbbaba8b59cb3432/lib/protocol/http2/settings_frame.rb#L236
Because I didn't know `/....../` should be `/....../m` I wasted at least 2 hours o... -
06/16/2019
-
- this is similar to [issue 15807 about Ranges](https://bugs.ruby-lang.org/issues/15807) and maybe also to [13917](https://bugs.ruby-lang.org/issues/13917)
current situation:
- calling `Array#minmax` incurs a performance penalty of a... -
-
03:29 PM Feature #15799: pipeline operator
- Seeing `|>` my assumption would be that you could use it in the functional style, so you could do:
``` ruby
42 |> Integer(exception: false) |> Math.sqrt
```
Instead of:
```ruby
Math.sqrt(Integer(42, exception: false))
```
S... -
08:11 AM Feature #15799: pipeline operator
- The operator doesn't bother me, though I can't think of any time I'd use it.
Several suggested alternatives seem to want to leave the syntax ambiguous, leaving it unclear whether the piped thing is the receiver or the arg and its uncl... -
- At first, I wasn't so sure about how to use such an operator, and honestly, the ASCII symbol `|>` is a bit jarring, but using a font with ligatures you get a better idea of how it's supposed to look, and it does look really great.
I h... -
- I investigated history of pipeline operator. It is very long, so I wrote [an article in my blog](https://mamememo.blogspot.com/2019/06/a-brief-history-of-pipeline-operator.html). In short: In my current opinion, the current spec is som...
-
- Applied in changeset commit:git|53e9908d8afc7f03109b0aafd1698ab35f512b05.
----------
Fix memory leak
* string.c (str_replace_shared_without_enc): free previous buffer
before replaced.
* parse.y (gettable): make sure in advance that ... -
- I managed to track down the leak, and it's related to rb_fstring().
reg_set_source() calls rb_fstring() with the tainted string, and there's a leak when non-"bare" (ivars or tainted) non-embedded strings are
given to rb_fstring().
... -
- * string.c (str_replace_shared_without_enc): free previous buffer
before replaced.
* parse.y (gettable): make sure in advance that the `__FILE__`
object shares a fstring, to get rid of replacement with the
fstring later.
TODO: t... -
- IMO, for `expr::C = lhs`, it should first evaluate `expr` and then do `lhs` because `expr` is left to `lhs`. But I'm unsure whether it should raise a TypeError when `expr` is not a Module. My personal expectation is that `lhs` is evalu...
-
02:30 PM Bug #15928: Constant declaration does not conform to JIS 3017:2013
- There are specs that cover this, so at least it is how Ruby implementors understand that it is intended to be, and it's been this way for a decade or more.
https://github.com/ruby/spec/blob/ff678eb339f16fc5424b25f2e2c82c59c14583be/lan... -
02:28 PM Bug #15928: Constant declaration does not conform to JIS 3017:2013
- s/lhs/rhs/
-
- The order of evaluation in constant declaration does not conform to JIS 3017:2013 11.4.2.2.3.
# Problem
Suppose that we are evaluating the following program.
```ruby
expr::C = rhs
```
The standard seems to be requiring the ... - 02:01 PM Revision d4929f51 (git): * expand tabs.
-
- This reverts commit 44caca11cfa6bea01a1ef738846183f1a56d5658.
The change caused a build failure.
http://ci.rvm.jp/results/trunk-vm-asserts@silicon-docker/2102153 - 01:48 PM Revision 11f8c891 (git): * expand tabs.
-
01:48 PM Bug #15924: Ripper::Lexer RuntimeError - Ripper FATAL - master/trunk
- @nobu
Thanks. Actually, YARD doesn't use the Lexer, but I switched to using it a long time ago, and all the repos shown at https://msp-greg.github.io/ are created using it. Conversely, Lexer is subclassed from Ripper. So what's usi... -
- It is an example of syntax error, cannot be fallen back?
YARD itself just warns it but succeeds.
```
$ echo $'<<\"EOS\n\"\nEOS' > yardtest.rb
$ ~/.gem/ruby/2.7.0/bin/yard doc yardtest.rb
[warn]: Syntax error in `yardtest.rb`:(1... -
- compile.c (NODE_CDECL): Evaluate the module before the value
test/ruby/test_const.rb (test_evaluation_order): added a test case -
- Whether it's YAML or another data format like JSON, I've found it useful on occasion to treat `sprintf()` like a mini templating from a runtime generated Hash like ashmaroli mentioned. Sometimes ERB seems like overkill in quick scripts o...
-
- ashmaroli (Ashwin Maroli) wrote:
> One use-case would be where the Data used by `sprintf` is generated at runtime:
> ...
I do not think that is the duty of string format.
If the YAML file is written by a Ruby program, then you shoul... -
06:46 AM Feature #15927: Allow string keys to be used for String#% and sprintf methods
- > Can you give us some actual use case(s) where such rewriting would not be possible, or very tedious?
One use-case would be where the Data used by `sprintf` is generated at runtime:
```ruby
require 'yaml'
# contents of 'path/to/... -
- I agree with @sawa that there's a difference between gsub (where strings are replaced by strings) and sprintf, where it's interpolating something very close to variables.
A use case such as
```
"foo = %{foo}" % { 'foo' => 'bar' }
`... -
- Thinking about this a bit more generally, I'm wondering whether `Enumerable#minmax` should actually use `rb_funcall` to get `min` and `max`.
This would fix the problem described in this issue.
But perhaps more importantly, it elimi... -
- Thank you Nobu, I thought that might be the case but was unaware as I'm not familiar with the GC subsystem. Also I think shyouhei was saying the same thing, I was just too dense to understand the specifics of what he was saying :)
Hav... -
- `ruby_xfree` != `free`.
Using the former on malloc'ed buffer can cause a crash. -
- jeremyevans0 (Jeremy Evans) wrote:
> Eregon (Benoit Daloze) wrote:
> ...
I would call that entirely unsupported, and if there are ways to detect this, we should probably raise an exception.
Basically, I believe it's undefined behavior... -
- jeremyevans0 (Jeremy Evans) wrote:
> * Disallow modifying `ENV` after `ENV.freeze` (my original patch).
I don't object this behavior itself, just don't consider the current behavior a bug, that is I don't think this should be backpor... -
-
03:21 AM Bug #15801: [BACKPORT] ChangeLogs of 2.5 and 2.6 begin before the 2.4 release
- ruby_2_6 r67711 merged revision(s) af1e487e9bb763b939dc6704c9a343c9eafa1637,6f8ac2cb28f99a4b2588c59ec44eff6ed38c4d3b.
-
- Updated marked commits for ChangeLog
Include the beginning commit in ChangeLog
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_6@67711 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- 02:46 AM Revision 72cc5cf0 (git): * 2019-06-16
-
-
- If it's not clear, previous statement is evaluated like:
```ruby
(Users.where(active: true) => active_users).where(type: "admin") => admin_users
``` -
- There are two areas where I think this is a great addition:
```ruby
x = if foo
bar
else
baz
end
if foo
bar
else
baz
end => x
```
I prefer the latter, because it avoids messing with the indentation/readability of th...
06/15/2019
-
- > My argument for this feature is that String#gsub() and family works with string keys if given a Hash
That is because they replace substrings, in which case it rather does not make sense to express them as symbols. The argument cann... -
- Right now, in the methods sprintf() and String#%, only symbol keys can be used for named interpolation. For example (from the example documentation):
"foo = %{foo}" % { :foo => 'bar' } #=> "foo = bar"
String keys do not work... -
- Eregon (Benoit Daloze) wrote:
> One potential concern here is that even if `ENV` is frozen, C extensions, or native libraries linked by C extensions, might still call e.g., `setenv()` and effectively modify values returned by `ENV` (and... -
- One potential concern here is that even if `ENV` is frozen, C extensions, or native libraries linked by C extensions, might still call e.g., `setenv()` and effectively modify values returned by `ENV` (and even add new environment variabl...
-
- nobu (Nobuyoshi Nakada) wrote:
> I don't think this behavior a bug.
> ...
I think the current situation of `ENV.freeze` not raising an exception but still allowing mutation is a bug. We have two ways to fix it:
* Disallow modifying... -
- Found the issue, below is a repo, which in MinGW master, generates RuntimeError...
```ruby
require 'ripper'
temp = "<<\"EOS\n\" # This has been warned since 2.4\nEOS"
puts '', temp, ''
lexer = Ripper::Lexer.new temp
lexer.l... -
- YARD based docs systems use Ripper for highlighting both source code and 'code snippets' in comments and rdoc/md files.
Using the build shown, I have an error as shown:
```
lib/ruby/2.7.0/ripper/lexer.rb:101:in `lex'
lib/ruby/2.7... -
- I think what puchuu is asking is if he can pass a malloc'd string to a ruby function that will create a new string object that frees the given underlying buffer when the string object is destructed. Having read the code, I didn't come up...
-
- I was working on issue related to code in `rb_fstring`(https://github.com/ruby/ruby/pull/2233) and saw some weird behavior in the function,
freezing the given string if it's not a "bare" string and it's small enough to be embedded.
T... -
- this issue is somewhat similar to https://bugs.ruby-lang.org/issues/15807
current situation, using the example of `SortedSet#min` (without `rbtree`):
- `SortedSet#min` calls `Enumerable#min`
- `Enumerable#min` calls `SortedSet#eac... -
- Kotlin has implemented `it` like this ([docs](https://kotlinlang.org/docs/reference/lambdas.html#it-implicit-name-of-a-single-parameter)).
From purely personal experience, after doing just a little bit of Kotlin, I often feel a tempta... -
- jeremyevans0 (Jeremy Evans) wrote:
> I think this is a bug we should fix, even if it breaks code relying on this bug ("all bug fixes are incompatibilities" :)).
Yes, it is a bit reminiscent of https://xkcd.com/1172/ :)
> ...
Other... -
-
-
-
-
-
-
-
- I'll rename it and squash this commit later,
just wanted to make sure I couldn't lose it
(took a long time to come up with). - 02:09 AM Revision e6aefe2a (git): * 2019-06-15
-
- In some slow CI environments, the invocation of a thread seems very
slow. This causes a test failure to attempt to connect a server that
does not start yet.
https://rubyci.org/logs/rubyci.s3.amazonaws.com/unstable11x/ruby-master/log/20... -
01:53 AM Bug #15763: Segmentation fault in timeout.rb / sleep
- A valid workaround until this is fixed in MacOS - if you can get away without ipv6 - is to have your web server like Puma bind to an ipv4 address like `-b 127.0.0.1` or `-b 0.0.0.0` upon boot and then all is :rainbows:.
-
- I agree with all the commenters that using keyword arguments is crucial (and I prefer `start_at:` (or maybe just `start:`) to `offset:`). I also agree that `Integer#step` seems already good enough. Maybe we could add a line about `Intege...
-
- I've tested on Windows and confirmed this is a bug.
I added a pull request upstream to fix this: https://github.com/ruby/scanf/pull/4
If nobody has objections, I'll merge this in about a week. -
-
-
-
06/14/2019
-
11:59 PM Feature #15923: New independent string without memcpy
- puchuu (Andrew Aladjev) wrote:
> Is it possible to create independent string from source string without memcpy that will be freed automatically?
In C there are several ways to free a memory region, depending how that string was alloc... -
01:51 PM Feature #15923 (Rejected): New independent string without memcpy
- Hello. I've just tried to implement extension for ruby that will provide large binary strings.
I've inspected latest ruby source code and found 2 functions: _rb_str_new_ and _rb_str_new_static_ .
* _rb_str_new_ allocates new memory... -
11:12 PM Feature #15799: pipeline operator
- Matz:
Ruby being a "Lisp-2" means that the pipeline operator couldn't be implemented like a "normal" operator (all of them being translated to methods on Object or etc), but it could be implemented on the parser level, like almost all... -
07:30 PM Feature #15799: pipeline operator
- rogeriochaves (Rogerio Chaves) wrote:
> May I give yet another suggestion? What about :., it would keep the visual effect
> ...
Or \\ maybe. It's much easier to type.
1 + 1 \\ to_s 2 \\ reverse \\ to_i
We can then have |> as an a... -
04:56 PM Feature #15799: pipeline operator
- @cichol Agreed! Here is a working proof of concept for an "operator-less" pipe operator which feels more natural in Ruby: https://github.com/lendinghome/pipe_operator
```ruby
# before
JSON.parse(Net::HTTP.get(URI.parse(url)))
# a... -
01:15 PM Feature #15799: pipeline operator
- Hi,
I want to introduce a way to pipeline method calls in Ruby.
I imagined that the Ruby-styled pipelined calls should be like:
```ruby
1.pipe do
call 1 + _ # => after this line, _ becomes 2
call _ * 3 # => after this line,... -
11:03 AM Feature #15799: pipeline operator
May I give yet another suggestion? What about :., it would keep the visual effect
```ruby
1 + 1
:. to_s 2
:. reverse
:. to_i
```-
10:30 AM Feature #15799: pipeline operator
- From my perspective, the |> operator exists because in functional programming languages you have these increasingly nested function calls which have to end with a stack of parentheses that are hard to read. In Haskell I very frequently u...
-
08:27 AM Feature #15799: pipeline operator
- I wonder if it would be possible to get method objects somehow. `.:` was capable of doing this off of objects, but doing it in the main namespace is not easy.
If pipeline operators in an Elixir style were considered, it may be able to... -
- Unlike JavaScript and Python (Lisp-1 like languages), Ruby is a Lisp-2 like language, in which methods and variable have separated namespaces. In Lisp-1 like languages, `f1 = function; f1()` calls `function` (single namespace).
In a L... -
- That's a very fair point @jeremyevans0, it would introduce two lookup chains even under the most ideal of circumstances. Perhaps if `&` were slightly extended, one could do this:
```ruby
def double(n) n * 2 end
increment = -> n { ... -
05:42 AM Feature #15799: pipeline operator
- I think one big issue here is simply the choice of symbols for this thing. If it were any other symbols, I suspect a lot of people would not have reacted so emotionally.
To most Rubyists who know it, `|>` has a distinctive meaning. It... -
- baweaver (Brandon Weaver) wrote:
> But in summary, I believe this feature could be substantially more expressive and powerful if it adjusted its lookup chain from directly calling on an object to searching the local scope for procs and... -
- @inopinatus We are working on the right side assignment operator. Combine pipelines with it.
Matz.
-
- I have written on my opinions here: https://dev.to/baweaver/ruby-2-7-the-pipeline-operator-1b2d
But in summary, I believe this feature could be substantially more expressive and powerful if it adjusted its lookup chain from directly ... -
02:01 AM Feature #15799: pipeline operator
- Please consider adjusting the precedence of the pipeline operator to be above that of assignment. I was surprised by this outcome:
``` ruby
result = 3 |> pow(2) #=> 9
result #=> 3 (!?!?!)
```
-
- Responses to this change:
- Twitter: https://twitter.com/a_matsuda/status/1139110957450375168
- Reddit: https://www.reddit.com/r/ruby/comments/c059d2/pipeline_operator_in_ruby/
- Github (mentioned above): https://github.com/ruby/rub... -
- Thanks for discussing the issue at the meeting.
I think having singleton-only methods on `Kernel` would be OK, and probably most of us agree having the instance method is not warranted for a rarely-used method.
`Kernel` makes sense t... -
- This ticket was discussed at yesterday dev meeting. Currently there is no singleton method to `Kernel`, so some people were reluctant. Nobu counterproposed `$LOAD_PATH` as above, and matz said he waits for eregon's response to the coun...
-
- shugo (Shugo Maeda) wrote:
> > I think we should never purposefully introduce something ugly in the language.
> ...
That's not what I meant. I'd rather not have something ugly in the language at all.
But I think we can make it not ugl... -
- Eregon (Benoit Daloze) wrote:
> shugo (Shugo Maeda) wrote:
> ...
So let's reject both proposals.
> Preventing overuse is I think best done by limiting to a single argument (as argued in #15723).
I guess `it` will be overused when... -
08:58 PM Bug #13220: Enhance support of Unicode strings manipulation
- Most of these test failures are caused by Ruby operating on code points, not grapheme clusters. There are more and more characters that are only expressed by several code points, and they are not limited to obscure cases, such as "q̈". F...
-
02:53 PM Feature #15899: String#before and String#after
- sawa is right. Just use `partition` and `rpartition`.
-
07:30 AM Feature #15899: String#before and String#after
- How about `first` and `last`?
```ruby
'hello world'.first(2)
=> 'he'
'hello world'.last(2)
=> 'ld'
'hello world'.first
=> 'h'
'hello world'.last
=> 'd'
'hello world'.first(1, ' ')
=> 'hello'
'hello world'.last(1, ' ')
... -
- This has lower precedence, so the latter.
-
10:49 AM Feature #15921: R-assign (rightward-assignment) operator
- where does the rightward assign works and where it is blocked? `y => x` might be treated as Hash Parameter
like `m y => x` is this `m(y) => x` or still `m({y => x})` -
- From https://bugs.ruby-lang.org/issues/15799#change-78465, proposal of the rightward-assignment operator by `=>`.
```
$ ./ruby -v -e '(1..).lazy.map {|x| x*2} => x' -e 'p x.first(10)'
ruby 2.7.0dev (2019-06-12T06:32:32Z feature/rass... -
- I don't think this behavior a bug.
`ENV` is an interface to the system environment variables, so freezing it doesn't affect the underlying system.
And be careful that an object can never be unfrozen anymore, once it got frozen.
For w... -
- Agree - looks like a bug to me as well.
-
02:27 AM Feature #15920: Check frozen state of ENV
- I didn't know `assert_separately`, thank you!
-
12:16 PM Feature #14912: Introduce pattern matching syntax
- I've intentionally focused on use-cases because: I wanted to make clear why Ruby should to support this; and I've included a possible solution only to make it more clear, since I think Kazuki or somebody else who also spend significant t...
-
- https://twitter.com/yukihiro_matz/status/1139454774640726019
-
-
-
- * `any?` `all?` `one?` `none?` already can take pattern argument. ref: https://bugs.ruby-lang.org/issues/11286
* `select` `reject` is proposed to take pattern argument. ref: https://bugs.ruby-lang.org/issues/14197
I would like to use... -
01:02 AM Bug #15857: <=> の右辺が <=> を実装していない場合の振る舞い
- > > @jeremyevans0 Thank you for your comment. About Complex, I agree with most of v2 patch, but I have some comments.
> ...
I don't have a strong opinion, too.
> > About other than Complex, <=> of some classes, such as String and Tim...