Project

General

Profile

Activity

From 05/25/2019 to 05/31/2019

05/31/2019

11:00 PM Misc #15892 (Closed): Appveyor - full MSYS2 update - 5:25
Thanks. I managed to pass the CI with the idea in https://github.com/ruby/ruby/pull/2217, but it added 8 minutes, not 5.
I'm slightly reluctant to add 8 minutes to msys2 build time, so I'll consider applying it when AppVeyor fails on ...
k0kubun (Takashi Kokubun)
09:42 PM Misc #15892: Appveyor - full MSYS2 update - 5:25
I used:
```
pacman -Syuu --noconfirm --noprogressbar --nodeps
pacman -Suu --noconfirm --noprogressbar --nodeps
```
With the current state of the Appveyor MSYS2 system, both are needed. The -y option updates the package database....
MSP-Greg (Greg L)
09:20 PM Misc #15892: Appveyor - full MSYS2 update - 5:25
Thanks to share. As the last appveyor.yml update has worked for only 3 days, the "full MSYS2 update" would be worth trying.
However, as I'm not familiar with MSYS2 and pacman that much, I don't know what exact code you imagine by "ful...
k0kubun (Takashi Kokubun)
06:47 PM Misc #15892 (Closed): Appveyor - full MSYS2 update - 5:25
Just tried a full MSYS2 update on Appveyor, and it took 5:25.
The most recent Ruby build (which finished within minutes of the MSYS2 update) took about 39 minutes, but it may have been waiting. Past builds occasionally take 45 to 50 ...
MSP-Greg (Greg L)
08:29 PM Bug #15876: 1.to_s.encoding != Encoding.default_internal
Hanmac (Hans Mackowiak) wrote:
> is there a way to see if two encoding objects are compatible or can that only be checked on the string?
`Encoding.compatible?` can take Encoding arguments too:
> Encoding.compatible?(Encoding::...
Eregon (Benoit Daloze)
05:37 PM Bug #15876: 1.to_s.encoding != Encoding.default_internal
There is `Encoding.compatible?` which might help to check if two strings/symbols has a common encoding
@naruse i don't know if you are the right contact person for this, but is there a way to see if two encoding objects are compatible...
Hanmac (Hans Mackowiak)
04:10 PM Bug #15876 (Feedback): 1.to_s.encoding != Encoding.default_internal
What is the problem you are actually troubled with?
If it is just a testing problem, I feel it should just use correct assertions.
But if there's a frequent pitfall, I may reconsider it.
naruse (Yui NARUSE)
07:31 PM Bug #15807: Range#minmax is slow and never returns for endless ranges
i had the same problem with minmax in Range.
I made a MR
https://github.com/ruby/ruby/pull/2216
mohsen (Mohsen Alizadeh)
05:44 PM Bug #15891 (Closed): FrozenError when assigning frozen class to constant
Applied in changeset commit:git|c1e52997870a63168835fde49562cb3c822c968a.
----------
Fix FrozenError when assigning frozen class to constant
* variable.c (set_namespace_path): modules/classes can get named
by assignment to constant, ...
nobu (Nobuyoshi Nakada)
01:25 PM Bug #15891 (Closed): FrozenError when assigning frozen class to constant
This code used to work in Ruby 2.6 and before: `C = Class.new.freeze`. Now it raises a FrozenError for class and module instances, while other frozen things seem to still work.
I am not sure if this is a bug or an intentional change. ...
flori (Florian Frank)
05:41 PM Revision c1e52997 (git): Fix FrozenError when assigning frozen class to constant
* variable.c (set_namespace_path): modules/classes can get named
by assignment to constant, even if frozen. [Bug #15891]
nobu (Nobuyoshi Nakada)
05:16 PM Revision aeb9a0ca (git): appveyor.yml again!
This issuse is caused by MSYS2 changing from using ncurses to pdcurses.
Appveyor's MSYS2 is so out-of-date that partial updates are 'troublesome'...
MSP-Greg (Greg L)
05:02 PM Revision 1d37cc19 (git): Update to ruby/spec@cfe908c
Eregon (Benoit Daloze)
05:02 PM Revision f97979ce (git): Update to ruby/mspec@a57a9af
Eregon (Benoit Daloze)
03:41 PM Revision 552c42f5 (git): Seprate raw keystroke config for each platforms
nobu (Nobuyoshi Nakada)
03:03 PM Revision 8fc552ad (git): * 2019-06-01
git[bot]
03:02 PM Revision 88770c2a (git): Support Home and End key to move to beg and end
aycabta (aycabta .)
02:24 PM Bug #15886: return in rescue block breaks Timeout.timeout
moio (Silvio Moioli) wrote:
> Well, as a Timeout.timeout user I would like to be able to wrap any code in a block and have a guarantee it will actually terminate after the specified number of seconds - no matter how the wrapped code loo...
jeremyevans0 (Jeremy Evans)
12:26 PM Bug #15886: return in rescue block breaks Timeout.timeout
Well, as a Timeout.timeout user I would like to be able to wrap any code in a block and have a guarantee it will actually terminate after the specified number of seconds - no matter how the wrapped code looks like and especially if it is... moio (Silvio Moioli)
01:53 PM Revision 21a43489 (git): Use IO#sync= instead of a monkey patch
aycabta (aycabta .)
01:33 PM Revision 73890d9d (git): Flush I/O immediately if RELINE_STDERR_TTY is set
aycabta (aycabta .)
01:15 PM Revision 913661cc (git): Bump irb version to 1.1.0.pre.1.
Becausee the current irb support reline and have many of changes. hsbt (Hiroshi SHIBATA)
12:58 PM Misc #15723: Reconsider numbered parameters
I prefer the single @ syntax as well. It will be a huge help since I don't like using the (&:method) syntax. I like avoiding syntax that intuitively makes code *unnecessarily* slower without much syntactical benefit, even for a languag... konsolebox (K B)
12:44 PM Misc #15723: Reconsider numbered parameters
@shevegen Please do not write such long comments, and express your opinion more concisely.
This helps everyone to read discussions faster and get the main point.
> This is based on the assumption that there has to be a "fix" at all i...
Eregon (Benoit Daloze)
12:16 PM Misc #15723: Reconsider numbered parameters
duerst (Martin Dürst) wrote:
> Can you tell us where and when that talk was given?
At the Ruby committer meeting before RubyKaigi.
Eregon (Benoit Daloze)
12:00 PM Misc #15723: Reconsider numbered parameters
> TBH, I wish the multi numbered parameters feature would not make it in
> ...
This is based on the assumption that there has to be a "fix" at all in the first place
to begin with; and if so, what the assumed "fix" would then be.
Na...
shevegen (Robert A. Heiler)
07:00 AM Misc #15723: Reconsider numbered parameters
Eregon (Benoit Daloze) wrote:
> * Here is a [link to the slides I presented](https://docs.google.com/presentation/d/1oNnZQaYj9yiGTzKV0MB13dxX3Z7_mOGfzhOJIucNfGg/edit?usp=sharing), which highlight most Rubyists who answered my poll disag...
duerst (Martin Dürst)
10:20 AM Revision 1457ad1e (git): [DOC] JIS X 0301 has been updated
[ruby-dev:50790]
* https://www.meti.go.jp/press/2019/05/20190520006/20190520006.html
* https://www.meti.go.jp/press/2019/05/20190520006/20190520006-2.pdf
[ci skip]
nobu (Nobuyoshi Nakada)
07:32 AM Revision 8b39df85 (git): Let irb use an empty file as irbrc
to get rid of side-effect by existing .irbrc file. nobu (Nobuyoshi Nakada)
07:32 AM Revision b632566d (git): UNIX domain socket name length has a certain limit
nobu (Nobuyoshi Nakada)
07:11 AM Bug #15887 (Closed): Process.argv0 can return bad values in Ruby 2.5
Applied in changeset commit:git|ea42423908ed055f9039b1dce6e9a232a3b2dd90.
----------
Keep vm->orig_progname alive
`vm->orig_progname` can be different from `vm->progname` when user
code assigns to `$0`. While `vm->progname` is kept ali...
alanwu (Alan Wu)
04:50 AM Bug #15887: Process.argv0 can return bad values in Ruby 2.5
I've reviewed and tested the pull request and it appears to be the correct fix to me. I confirmed this does crash immediately on 2.5.5, 2.6.3, 2.7.0-preview1, and trunk, and the fix makes it no longer crash. This fix should be backporte... jeremyevans0 (Jeremy Evans)
04:34 AM Bug #15887: Process.argv0 can return bad values in Ruby 2.5
Here's is a one line crasher: `ruby -e '$0 = "hi"; 4.times { GC.start }; Process.argv0.class'`
This crashes 2.5.5 and 2.6.3, but 2.4.6 seems to be immune. Bisect points to 478003f6df40dc79d33c6ec86919f2dde07284be.
I have a PR for this:...
alanwu (Alan Wu)
07:04 AM Revision b1aecef8 (git): Use UNALIGNED_MEMBER_PTR
* internal.h (UNALIGNED_MEMBER_ACCESS, UNALIGNED_MEMBER_PTR):
moved from eval_intern.h.
* compile.c iseq.c, vm.c: use UNALIGNED_MEMBER_PTR for `entries`
in `struct iseq_catch_table`.
* vm_eval.c, vm_insnhelper.c: use UNALIGNED_MEMB...
nobu (Nobuyoshi Nakada)
05:38 AM Revision ea424239 (git): Keep vm->orig_progname alive
`vm->orig_progname` can be different from `vm->progname` when user
code assigns to `$0`. While `vm->progname` is kept alive by the
global table, nothing marked `vm->orig_progname`.
[Bug #15887]
alanwu (Alan Wu)
05:29 AM Bug #15888 (Feedback): Segmentation fault at 0x000070000afc2450 ruby 2.5.1p57 (2018-03-29 revision 63029) [x86_64-darwin18]
Could you try newer version, 2.5.5, 2.6.3 or 2.7.0-preview1? nobu (Nobuyoshi Nakada)
05:05 AM Revision 83f9183a (git): Also GCC 9 provides -Waddress-of-packed-member
nobu (Nobuyoshi Nakada)
04:50 AM Feature #15665: Cannot compile socket extension on Mojave
nobu (Nobuyoshi Nakada) wrote:
> Applied in changeset commit:git|fe3ff5afb07e171fd950623c69abfbabbb2762a3.
> ...
I have verified that the changeset works for 2.6 on my machine. It is currently in trunk, which would go to 2.7 eventually...
franklinyu (Franklin Yu)
01:55 AM Revision d2f663d6 (git): STATIC_ASSERT for VM_METHOD_TYPE_MINIMUM_BITS
nobu (Nobuyoshi Nakada)
01:55 AM Revision d180e405 (git): Add --limit option and default it to 20
nobu (Nobuyoshi Nakada)
01:55 AM Revision 1e9057b5 (git): Prefer the current branch or tag name
nobu (Nobuyoshi Nakada)
01:55 AM Revision fd658ec8 (git): Define RUBY_FULL_REVISION
Only if the short revision differs from the full revision. nobu (Nobuyoshi Nakada)
01:41 AM Bug #11512 (Closed): DelegateClass.#public_{instance_}methods are returning difference values.
Applied in changeset commit:git|e8c710b11a02c6ab82b358fc671a14f378cb1974.
----------
Fix visibility of some methods when using DelegateClass
Public instance methods added to a delegated class after the
creation of the delegate class we...
jeremyevans (Jeremy Evans)
01:41 AM Feature #15842 (Closed): Allow DelegateClass() to module_eval given block
Applied in changeset commit:git|1cd93f1cdfbe6f7e71b05b3f8e707f21d70e94ba.
----------
Allow DelegateClass() to module_eval given block
Methods that return classes often module_eval the given block
(e.g. Class.new and Struct.new). This ...
jeremyevans (Jeremy Evans)
01:34 AM Revision e8c710b1 (git): Fix visibility of some methods when using DelegateClass
Public instance methods added to a delegated class after the
creation of the delegate class were not returned by the
public_instance_methods class method of the delegate class.
Protected instance methods in the delegated class when the
...
jeremyevans (Jeremy Evans)
01:34 AM Revision 1cd93f1c (git): Allow DelegateClass() to module_eval given block
Methods that return classes often module_eval the given block
(e.g. Class.new and Struct.new). This allows DelegateClass to
work similarly. This makes it easier to use DelegateClass
directly without subclassing, so as not to create an ...
jeremyevans (Jeremy Evans)
12:44 AM Revision 856593cc (git): Fix typo :bug: [ci skip]
k0kubun (Takashi Kokubun)

05/30/2019

11:02 PM Bug #15890 (Closed): psych.so is not deterministic
psych.so is not binary identical across builds (it's hash changes), as the order of its sources is random.
You probably want to add a sort to
https://github.com/ruby/ruby/blob/6a5e89e23c433199f926d757481bc3c29fce7854/ext/psych/extcon...
hajma (hajma hajma)
10:31 PM Misc #15874: DevelopersMeeting20190613Japan
* [Misc #15723] Reconsider numbered parameters.
* To matz: Could you agree on Jeremy's single-argument patch?
Eregon (Benoit Daloze)
10:24 PM Revision 6a5e89e2 (git): Set git config to commit mjit-debug
As it failed to commit like:
https://app.wercker.com/ruby/ruby/runs/mjit-test1/5cefd8a8105780001c4f2d5d?step=5cefdd1e48fad200077fa3f8
k0kubun (Takashi Kokubun)
10:19 PM Misc #15723: Reconsider numbered parameters
@matz Could @jeremyevans0 merge his patch for single argument?
* The original author proposed a single argument (#4475).
* Jeremy who proposed the currently implemented syntax [said](https://bugs.ruby-lang.org/issues/15723#note-91)...
Eregon (Benoit Daloze)
09:54 PM Revision cb40a21d (git): Warn compile_error only when input is finished
Let's say we are in progress to write `"foo"`:
```
irb> "fo
```
at this moment, nothing is wrong.
It would be just a normal way to write `"foo"`.
Prior to this commit, the `fo` part was warned because of
5b64d7ac6e7cbf759b859428f12553...
k0kubun (Takashi Kokubun)
09:21 PM Revision 6e052817 (git): Abstract away Ripper::Lexer#scan in IRB::Color#scan
because 5b64d7ac6e7cbf759b859428f125539e58bac0bd made it hard to
understand #colorize_code for me and this change is needed for my next
commit.
k0kubun (Takashi Kokubun)
08:53 PM Revision 8f83fe3b (git): Finish with ^D only when input is completely empty in vi insert mode
aycabta (aycabta .)
08:11 PM Revision a4161b76 (git): Update to ruby/spec@0ba5312
Eregon (Benoit Daloze)
08:11 PM Revision e935a322 (git): Update to ruby/mspec@3cc36d0
Eregon (Benoit Daloze)
07:08 PM Bug #15889 (Closed): Enumerator#each_slice size FloatDomainError with infinite enumerator
Calling `#size` on an infinite `each_slice` Enumerator results in a `FloatDomainError` exception:
``` ruby
1.step.size # => Infinity
1.step.each_slice(2).size # => FloatDomainError
```
```
Traceback (most recent call last):
.....
Freaky (Thomas Hurst)
05:05 PM Bug #15888 (Closed): Segmentation fault at 0x000070000afc2450 ruby 2.5.1p57 (2018-03-29 revision 63029) [x86_64-darwin18]
This happens on a Ruby on Rails app which has recently been upgraded from Ruby version 1 to ruby version 2.5.1 iarobinson (ian robinson)
03:17 PM Feature #15797: Use realpath(3) instead of custom realpath implementation if available
I was able to run the benchmarks in a Linux virtual machine. This includes the benchmarks I added for `File.realdirpath` and for `File.realpath` where the paths that do not exist. `File.realdirpath` always uses the emulated code on Linu... jeremyevans0 (Jeremy Evans)
03:01 PM Revision c55db6aa (git): * 2019-05-31
git[bot]
03:00 PM Revision f7aa80b3 (git): Make the target name unique when BASERUBY=no
nobu (Nobuyoshi Nakada)
02:23 PM Revision ab0c8cc0 (git): Touch Unicode headers and the timestamp before packaging
Not to download Unicode data files at building from the packages. nobu (Nobuyoshi Nakada)
02:13 PM Bug #15884 (Rejected): Time module fails to identify timezone correctly
jeremyevans0 (Jeremy Evans)
12:16 PM Bug #15884: Time module fails to identify timezone correctly
Thanks for such a good explanation John! What you said makes perfect sense so I'm happy to close this as "invalid", or whatever is the most appropriate status. Unfortunately, I don't seem to be able to update the Status on this ticket. Anonymous
01:27 PM Revision f0945176 (git): Fix missing `gitcmd`
nobu (Nobuyoshi Nakada)
01:20 PM Revision 22cd4027 (git): vcs.rb support non-inplace build
naruse (Yui NARUSE)
01:03 PM Revision 92ecf58b (git): parse.y: adjust here-doc error token
* parse.y (here_document): adjust token to the here-doc identifier
in compile_error when a here-document misses the closing
identifier.
nobu (Nobuyoshi Nakada)
12:54 PM Revision b0e2b7a5 (git): Include stack elements left after errors
nobu (Nobuyoshi Nakada)
11:54 AM Revision 279c8e14 (git): Use rebuilt buffer data to rerender all
aycabta (aycabta .)
11:06 AM Revision 74a0e3ec (git): Use start_with? for escaped quote too
aycabta (aycabta .)
09:29 AM Revision ecd0f1d9 (git): Use negative lookahead and start_with?
aycabta (aycabta .)
09:21 AM Revision fcca39fa (git): Fix strange vertical cursor moving when adding a newline at bottom
aycabta (aycabta .)
09:14 AM Revision 39ee412b (git): merge revision(s) dcb6a6ae3e2b8a3e298e7f0d4a3e7f8ff102a30e:[Backport #15845]
Windows simply causes an error to open invalid path
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@67709 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
U.Nakamura
08:12 AM Revision 106843d8 (git): * expand tabs.
git[bot]
08:12 AM Revision 5fc9f000 (git): reorder bitmap clearing.
ko1 (Koichi Sasada)
08:10 AM Revision dd63d7da (git): move pinned_bits[] position in struct heap_page.
pinned_bits are not used frequently (only GC.compact use it) so
move it at the end of struct heap_page.
ko1 (Koichi Sasada)
07:52 AM Revision e15de865 (git): introduce `during_compacting` flag.
Usually PINNED_BITS are not needed (only for GC.compact need it)
so skip updating PINNED_BITS if the marking is not by GC.compact.
ko1 (Koichi Sasada)
06:50 AM Revision 70e87d96 (git): Do not rely on IRB.conf[:MAIN_CONTEXT] before initialize
so that we can colorize binding.irb source lines. k0kubun (Takashi Kokubun)
06:34 AM Revision 55c34b99 (git): Check the end token of heredoc correctly
aycabta (aycabta .)
06:19 AM Revision 5a229b0a (git): Calculate vertical position correctly when rerendering all lines
aycabta (aycabta .)
06:04 AM Revision 90014ddd (git): Fix broken rendering when the last line is auto-wrapped
aycabta (aycabta .)
05:19 AM Revision eae953ba (git): Rerender following lines when line number increased
aycabta (aycabta .)
05:04 AM Revision 1cf9f793 (git): Clear remaining lines when line number decreased
aycabta (aycabta .)
03:38 AM Revision 4a31c1e4 (git): parse.y: continue after heredoc error
* parse.y: continue parsing the rest of the here-document starting
line, after the terminator was not found.
nobu (Nobuyoshi Nakada)
03:29 AM Revision cb520e76 (git): Fix the auto-wrap behabior that was too buggy
aycabta (aycabta .)
01:40 AM Revision f0ded366 (git): Use Regexp#match instead of #match for 1.9 BASERUBY support
jeremyevans (Jeremy Evans)
01:03 AM Revision d2ba80b5 (git): Revert "Fix building with 1.8 BASERUBY"
This reverts commit 05bc14d81a1d7f6af826a92371aeff0c3fb2a67e.
We have decided that the cost of reintroducing support for 1.8
BASERUBY outweighs the benefit. If you are still using 1.8 and want
to build master/trunk, build and install t...
jeremyevans (Jeremy Evans)

05/29/2019

09:54 PM Bug #15887: Process.argv0 can return bad values in Ruby 2.5
Interesting. I just did Process.argv0 in irb and irb crashed right away.
If I put it into a .rb file it works fine. I haven't systematically tested
what causes the issue or whether my crash is related to the one here (I am
on linux ...
shevegen (Robert A. Heiler)
07:43 PM Bug #15887 (Closed): Process.argv0 can return bad values in Ruby 2.5
MacOS 10.14.5 on a clean (source, using ruby-install) installation of Ruby 2.5.5
```
$ ruby --version
ruby 2.5.5p157 (2019-03-15 revision 67260) [x86_64-darwin18]
$ gem install vault vcr virtus webmock webrick
$ echo Process.argv0 |...
joeym (Joey Marianer)
07:13 PM Revision 5867e51e (git): * 2019-05-30
git[bot]
07:12 PM Revision 814eaa25 (git): Do not use rb_iseq_path() while moving ISeq pointers
in GC.compact.
While `in_jit` is false, GC.compact is allowed to run and it may be
moving ISeq-related pointers. So calling rb_iseq_path() when `in_jit`
is true is illegal.
k0kubun (Takashi Kokubun)
03:24 PM Bug #15886 (Rejected): return in rescue block breaks Timeout.timeout
I don't believe this is a bug or specifically related to `Timeout` (or to the other issues you linked). If an exception is raised and an `ensure` or a `rescue` block does an explicit `return` (or a non-local exit such as `throw`), the e... jeremyevans0 (Jeremy Evans)
02:52 PM Bug #15886 (Rejected): return in rescue block breaks Timeout.timeout
Passing `Timeout.timeout` a block with a rescue clause that contains a return statement prevents `Timeout::Error` to be raised as expected.
Reproducer:
``` ruby
require 'timeout'
begin
Timeout.timeout(1) do
begin
...
moio (Silvio Moioli)
01:09 PM Revision 5b64d7ac (git): Colorize errors more
* lib/irb/color.rb (IRB::Color.colorize_code): colorize
`compile_error` part as same as `on_parse_error`.
nobu (Nobuyoshi Nakada)
12:59 PM Revision 12644e8b (git): Get rid of nested string interpolations
* lib/irb/color.rb (IRB::Color.colorize): get rid of nesting string
interpolations not to confuse ruby-mode.el
nobu (Nobuyoshi Nakada)
12:42 PM Revision 1da5c739 (git): parse.y: fix state after ivar/cvar
* parse.y (parse_atmark): return EXPR_END or EXPR_ENDFN, depending
on the previous state, even incomplete names consistently.
nobu (Nobuyoshi Nakada)
11:24 AM Revision 83e905eb (git): Revert "Use "require" just for essential"
This reverts commit ab7a6e1a1651d82d327d155b78a8e3af1d976707. aycabta (aycabta .)
11:21 AM Revision ab7a6e1a (git): Use "require" just for essential
The 559dca509d2a98584b09c7d9a6d74749ce793ad7 contains an excess range in
using "require".
aycabta (aycabta .)
10:29 AM Bug #15885 (Closed): Duplicated `:raise` tracepoint event when exception inside `load` call happens
Hi!
A long time ago, [this ruby-core change](https://github.com/ruby/ruby/commit/1998039ea4f867583d7e37ce200a88490707c330) broke a test in byebug related to post-mortem debugging. See https://github.com/deivid-rodriguez/byebug/issues/...
deivid (David Rodríguez)
09:52 AM Revision fafcbe0e (git): Use reversed get_screen_size correctly on Windows
aycabta (aycabta .)
09:21 AM Revision 5ceff480 (git): ripper: Ripper::Lexer#scan
* ext/ripper/lib/ripper/lexer.rb (Ripper::Lexer#scan): parses the
code and returns the result elements including errors.
[EXPERIMENTAL]
nobu (Nobuyoshi Nakada)
07:48 AM Revision 7c0639f3 (git): Never make a method call from MJIT worker
by showing line number only when it's Fixnum.
When it's not Fixnum, we need to call a method to know the line number.
k0kubun (Takashi Kokubun)
07:22 AM Revision ce7b1132 (git): Do not call FIX2INT while GC.compact may be running
because FIX2INT might crash by moving method entry pointer:
http://ci.rvm.jp/results/trunk-mjit@silicon-docker/2063412
k0kubun (Takashi Kokubun)
07:09 AM Revision 468b475e (git): .travis.yml: Minor reorder for shortening
k0kubun (Takashi Kokubun)
06:04 AM Revision 1a0c3d8d (git): Convert Enumerator to Array for Ruby 1.9.3
String#lines seems to return Enumerator in Ruby 1.9.3, and it does not
respond to #delete_if https://travis-ci.org/ruby/ruby/jobs/538559919
k0kubun (Takashi Kokubun)
05:57 AM Revision 5379ca92 (git): Skip spec broken since a66bc2c01194a9c017c874a30db5b3b6bd95e966
This has not worked since the merge https://travis-ci.org/ruby/ruby/jobs/538438184 k0kubun (Takashi Kokubun)
04:34 AM Revision 068d3275 (git): Colorize compile_error as same as on_parse_error
nobu (Nobuyoshi Nakada)
04:24 AM Revision cc66272e (git): parse.y: flush invalid char
nobu (Nobuyoshi Nakada)
04:24 AM Revision 8552e9d6 (git): Fix shorten-64-to-32 warning
nobu (Nobuyoshi Nakada)
04:16 AM Revision aee36bf1 (git): Fix Possible Control flow issues (DEADCODE)
Coverity Scan says `Execution cannot reach this statement: "poison_object(v);"`,
so do nothing when `ptr` is always 0 without address_sanitizer.
znz (Kazuhiro NISHIYAMA)
04:01 AM Revision e04d10b2 (git): test/rubygems/test_gem_stream_ui.rb (test_ask_for_password): extend the timeout
for Solaris.
https://rubyci.org/logs/rubyci.s3.amazonaws.com/unstable10s/ruby-master/log/20190528T191908Z.fail.html.gz
mame (Yusuke Endoh)
03:30 AM Revision 8187ffa4 (git): Revert "Colorize error part more"
This reverts commit c7f3c222c9b82736c993419daa6bfb643e5c0793. ko1 (Koichi Sasada)
03:12 AM Revision c7f3c222 (git): Colorize error part more
Colorize `compile_error` parts as well as `on_parse_error` parts. nobu (Nobuyoshi Nakada)
03:09 AM Revision 34fe1f7d (git): Create empty revision.tmp if BASERUBY is not yes
nobu (Nobuyoshi Nakada)
01:04 AM Revision 3f132979 (git): Remove extra items because Reline::HISTORY is a sized queue
aycabta (aycabta .)
12:46 AM Revision c86d1fbe (git): Create empty revision.tmp if no BASERUBY
nobu (Nobuyoshi Nakada)
12:14 AM Revision f60a59ed (git): appveyor.yml - update for msys2 - pdcurses, force toolchain
Closes: https://github.com/ruby/ruby/pull/2208
Merging the PR for fixing AppVeyor msys2 failure related to GCC 9 like:
https://ci.appveyor.com/project/ruby/ruby/builds/24877992/job/ned5k4k5rwxnld5j
MSP-Greg (Greg L)
12:05 AM Revision 98ba116d (git): Revert 3b7862c8e88cd7838a53ec083ac5733386400956 causing various CI hangs
and dependent commits c67934b1c3b40dda5f170b032423e520511c68dd and
f0d1dc5cee87dfb023cb43a2db9bcdef5a8dee8f.
RubyCI and ci.rvm.jp are almost dead by timeout since this commit.
---
Revert "Skip a reline test hanging on Wercker since 3b...
k0kubun (Takashi Kokubun)

05/28/2019

11:56 PM Revision 797d7efd (git): Prevent MJIT compilation from running while moving
pointers.
Instead of 4fe908c1643c3f355edd787bb651aefb53b996c0, just locking the MJIT
worker may be fine for this case. And also we might have the same issue
in all `gc_compact_after_gc` calls.
k0kubun (Takashi Kokubun)
11:22 PM Revision 6b5e7123 (git): Make tool/vcs.rb compliant to BASERUBY
People seem to consider BASERUBY is either 1.8 or 1.9 now. Since this
file may be executed by BASERUBY from file2lastrev.rb, I think we should
not rely on Ruby 2.0 in this file for now.
k0kubun (Takashi Kokubun)
11:19 PM Revision e1f62d7f (git): Check the result of file2lastrev.rb if HAVE_BASERUBY
is yes.
We ignored the failure status of file2lastrev.rb on 73da429c36c, but it
was for an environment without BASERUBY. I think we should skip running
file2lastrev.rb on HAVE_BASERUBY=no, and run it and check the status on
HAVE_BASERUB...
k0kubun (Takashi Kokubun)
11:08 PM Revision f0d1dc5c (git): Skip a reline test hanging on Wercker since 3b7862c8e8
like https://app.wercker.com/ruby/ruby/runs/mjit-test1/5cedad11105780001c4e7001?step=5cedaf6b48fad200076fe77b k0kubun (Takashi Kokubun)
11:04 PM Revision 67f75d5b (git): Add TESTOPTS=-v for Wercker test-all --jit-wait
because it's hard to identify which test causes a hang for now. k0kubun (Takashi Kokubun)
09:57 PM Revision 8d837431 (git): Use IO.copy_stream
aycabta (aycabta .)
09:57 PM Revision a4a682c4 (git): Check RUBY_YES_I_AM_NOT_A_NORMAL_USER env to access RubyVM doc
aycabta (aycabta .)
09:57 PM Revision d341bb28 (git): IRB never show RubyVM's doc
aycabta (aycabta .)
09:54 PM Revision d390af36 (git): Encode completed strings corecctly
aycabta (aycabta .)
09:45 PM Revision 3e54ff67 (git): Test BASERUBY: Ruby 1.9.3 on Travis
We have no clear assertion or check of BASERUBY requirement.
I want to make the current situation more explicit.
I'm NOT saying we should support Ruby 1.9.3 here,
but I'm just checking the situation as per 05bc14d81a1d7f6af826a92371aeff...
k0kubun (Takashi Kokubun)
09:15 PM Revision 91f5a8db (git): Update to ruby/spec@0c5c5c1
Eregon (Benoit Daloze)
08:58 PM Revision c67934b1 (git): Remove extra items because Reline::HISTORY is a sized queue
aycabta (aycabta .)
08:53 PM Revision 3b7862c8 (git): Use existing instances for LineEditor and Config
aycabta (aycabta .)
08:41 PM Revision a66bc2c0 (git): Update to ruby/spec@9a501a8
Eregon (Benoit Daloze)
08:27 PM Revision d070523e (git): Drop unused Travis config: universal-darwin17
This has been unused since b7f5c573ef20dbbf5534ee3a45625c7f9d45f2ec. k0kubun (Takashi Kokubun)
08:10 PM Revision 462a63c3 (git): Drop MJIT debug code from GC.compact
As ko1 added some improvements on GC.compact, I want to check if it
solved the problem too.
k0kubun (Takashi Kokubun)
03:37 PM Bug #15884: Time module fails to identify timezone correctly
I think this shows the logic behind what is occurring here.
On my system
Time.new(2002, 12, 1).zone
=> PST
(Time.new(2002, 12, 1) + 60 * 60 * 24 * 180).zone # Add 180 days
=> PDT
Time.new(2002, 12, 1).utc.zone
=> UTC
(Time...
wishdev (John Higgins)
03:05 PM Bug #15884 (Rejected): Time module fails to identify timezone correctly
I think the following snippet is the best summary of the problem I could write:
```
irb(main):001:0> Time.new(2012, 12, 1).utc?
=> false
irb(main):002:0> Time.new(2012, 12, 1).zone == 'UTC'
=> true
```
Anonymous
03:07 PM Revision abd55695 (git): * 2019-05-29
git[bot]
03:00 PM Revision c730c253 (git): parse.y: warn escaped whitespace
* parse.y (warn_space_char_code): warn whitespace characters
escaped with meta/control prefix.
nobu (Nobuyoshi Nakada)
02:46 PM Revision fb568fe7 (git): Added missing predicate macros
nobu (Nobuyoshi Nakada)
01:45 PM Feature #15799: pipeline operator
phluid61 (Matthew Kerwin) wrote:
> `a|:b` means `a | :b` and `a=:b` means `a = :b`
Yes I implied that a space is necessary for |: or =: to be distinguishable. It's better to have that requirement than have the three-character operat...
konsolebox (K B)
11:41 AM Feature #15799: pipeline operator
```ruby
1.. |> take 10 |> map {|x| x*2} |> (x)
```
I believe that the ONLY sane reason for the new operator is ending the long chain with "...and now, put it into variable". The rest is total mistery, however you look at it, e.g. wh...
zverok (Victor Shepelev)
09:33 AM Feature #15799: pipeline operator
`a|:b` means `a | :b` and `a=:b` means `a = :b` phluid61 (Matthew Kerwin)
07:37 AM Feature #15799: pipeline operator
konsolebox (K B) wrote:
> nobu (Nobuyoshi Nakada) wrote:
> ...
Or `=:` which is the reverse of Pascal's assignment operator. Personally I would want it to have it as an alias to `|:` than replace `|:` because `=:` would look good if i...
konsolebox (K B)
04:54 AM Feature #15799: pipeline operator
nobu (Nobuyoshi Nakada) wrote:
> duerst (Martin Dürst) wrote:
> ...
`|>=` looks heavy. Please consider `|:` instead.
konsolebox (K B)
11:26 AM Feature #10344: [PATCH] Implement Fiber#raise
Shortly after I started to work on a library implementing algebraic effects (https://github.com/dry-rb/dry-effects) I stumbled upon lack of `Fiber#raise`. From the user POV it is important to signal improper use of effects with a meaning... decuplet (Nikita Shilnikov)
09:54 AM Misc #15874: DevelopersMeeting20190613Japan
* [Feature #15777] `Module#autoload?(cname, inherit=true)`
* By default `autoload?` also check in the ancestors chain, such option would be consistent with `Module#const_defined?` and totally backward compatible.
* For more context...
byroot (Jean Boussier)
06:59 AM Bug #15880: Wrong precedence of the if modifier in pattern matching
It's clear that the order of evaluation has to be the way it is currently. But in this case, `if` just sounds wrong, not only because of examples such as `puts 1 if condition`, but also because of general English.
So I think changing ...
duerst (Martin Dürst)
06:57 AM Revision 8a2b497e (git): remove obsolete rb_gc_finalize_deferred().
rb_gc_finalize_deferred() is remained for compatibility with
C-extensions. However, this function is no longer working
from Ruby 2.4 (crash with SEGV immediately).
So remove it completely.
ko1 (Koichi Sasada)
05:38 AM Revision 2562b7d7 (git): Unify RELINE_TEST_ENCODING setting
nobu (Nobuyoshi Nakada)
05:38 AM Revision d5f40840 (git): Set read-only with attrib command
nobu (Nobuyoshi Nakada)
05:36 AM Revision 62b3d4c7 (git): Skip following all digits after `@@`
nobu (Nobuyoshi Nakada)
05:28 AM Feature #15879: Proposal: Time#to_i accepts :unit keyword
> In contrast to this, your proposal with Time#to_i seems to return rounded results even though the method name is to_i. I think this is confusing. Is this your intention?
It is not important whether the result is rounded or truncated...
joker1007 (Tomohiro Hashidate)
05:20 AM Revision 40e175b3 (git): Clean a garbage [ci skip]
nobu (Nobuyoshi Nakada)
03:55 AM Revision 05bc14d8 (git): Fix building with 1.8 BASERUBY
jeremyevans (Jeremy Evans)
02:44 AM Revision f3bddc10 (git): use malloc() instead of calloc().
Here malloc() is enough because all elements of the page_list
will be overwrite.
ko1 (Koichi Sasada)
02:44 AM Revision f9401d5d (git): should skip T_ZOMBIE here.
ko1 (Koichi Sasada)
02:44 AM Revision 2229acaa (git): should use heap_eden->total_pages.
The size of page_list is heap_eden->total_pages, but
init_cursors() assumes the size of page_list is `heap_allocated_pages`.
This patch fix it.
ko1 (Koichi Sasada)
02:38 AM Revision 72333286 (git): Fix typos in Ripper::Lexer#inspect and Ripper::Lexer#pretty_print
nobu (Nobuyoshi Nakada)
02:03 AM Revision ccfb12d7 (git): Fix condition..."and" is lowest priority operator, than "="
aycabta (aycabta .)
01:31 AM Revision 7f211bfe (git): use only eden_heaps on GC.compact.
`heap_pages_sorted` includes eden and tomb pages, so we should not
use tomb pages for GC.compact (or we should move all of tomb pages
into eden pages). Now, I choose only eden pages. If we allow to
move Zombie objects (objects waiting fo...
ko1 (Koichi Sasada)
01:31 AM Revision cfd839c1 (git): Suppress warning (uninitialized variable).
ko1 (Koichi Sasada)
01:24 AM Revision fa7a768f (git): Removed inconsistency file from upstream repository of rubygems.
followed up ae2a904ce9bffedee7d110dc60fd51c0a2879a5b hsbt (Hiroshi SHIBATA)
01:07 AM Revision 165ddfda (git): * remove trailing spaces.
git[bot]
01:07 AM Revision ae2a904c (git): Update the certificate files to make the test pass on Debian 10
The old certificate files (for example, test/rubygems/ca_cert.pem) were
signed by SHA1. This message digest is considered too weak and rejected
by OpenSSL 1.1.1 or later. Because of this, the test suite does not
pass on Debian 10.
htt...
mame (Yusuke Endoh)
01:02 AM Revision cf904d9f (git): Avoid doubly building Travis and AppVeyor
but on "master" branch.
For Pull Request, I changed the approach from
d9b338a53f520b2dbb05555f18b8de8072300f40 and
277e68825a8e4d0e6503a32e41f8b1b6c078b567.
k0kubun (Takashi Kokubun)
12:57 AM Feature #15883 (Closed): Include inspect value of object in FrozenError messages
`FrozenError#receiver` was added recently for getting the related object programmatically. However, there are cases where FrozenError is raised and not handled, and in those cases the resulting error messages lack detail, which makes de... jeremyevans0 (Jeremy Evans)
12:06 AM Feature #14683 (Closed): IRB with Ripper
aycabta (aycabta .)
12:06 AM Feature #14787 (Closed): Show documents when completion
aycabta (aycabta .)
12:00 AM Revision 1cdaa17a (git): parse.y: numbered parameter symbol
* parse.y (parse_atmark): numbered parameter name is not allowed
as a symbol regardless the context.
nobu (Nobuyoshi Nakada)

05/27/2019

11:38 PM Revision 57b4df07 (git): Use Reline.completer_quote_characters to complete
aycabta (aycabta .)
09:01 PM Bug #15877: Incorrect constant lookup result in method on cloned class
I tested this on 2.5, 2.4 and the behavior is the same there. Also this applies to subclasses as well. The first class READ determines the values for all of them.
``` ruby
class Unrelated
TEST='UNRELATED'
def test
T...
sag (Stephen Gregory)
08:10 PM Revision 74c88e7c (git): Fix reversed row and column get_screen_size on Windows
aycabta (aycabta .)
07:39 PM Revision f6b62d8f (git): Use Shift+Enter as Meta+Enter on Windows
aycabta (aycabta .)
07:25 PM Revision 8b135cc8 (git): Use VK_MENU instead of VK_LMENU to check ALT on Windows
aycabta (aycabta .)
06:25 PM Revision d5682eb9 (git): Remove unused variable from IRB::InputCompletor
aycabta (aycabta .)
06:23 PM Revision 5e275dd2 (git): Treat :@1, :@@1, @1, and @@1 correctly to check termination
aycabta (aycabta .)
05:13 PM Bug #15882 (Closed): OpenSSL::X509::Name.parse usage
in ruby 2.5 and 2.6 the OpenSSL::X509::Name.parse_ssl method requires strings to start with forward slashes to use it as a delimiter zr2d2 (Zach Rowe)
04:52 PM Revision 7447c7b6 (git): Join next line if deletes newline at end of line
aycabta (aycabta .)
04:51 PM Revision 69c7ad17 (git): Exit only when blank input
aycabta (aycabta .)
04:37 PM Bug #15880 (Rejected): Wrong precedence of the if modifier in pattern matching
This is necessary so the `if` can depend on the variables of the matching, e.g. `in [Integer => x] if x.odd?`
marcandre (Marc-Andre Lafortune)
01:51 PM Bug #15880 (Rejected): Wrong precedence of the if modifier in pattern matching
When "If" is used as an "If modifier" it runs before the expression that it wraps:
``` ruby
=> puts 1 if (puts 2; true)
2
1
```
However, when it's used in the pattern matching destructuring runs first:
``` ruby
class A
def d...
ibylich (Ilya Bylich)
04:32 PM Revision b2b5ed14 (git): Supress duplicated warning
ktsj (Kazuki Tsujimoto)
04:19 PM Feature #15881 (Assigned): Optimize deconstruct in pattern matching
```ruby
class A
def deconstruct
puts 'deconstruct called'
[1]
end
end
case A.new
in [2]
2
in [1]
1
else
end
```
Currently this outputs:
```
deconstruct called
deconstruct called
=> 1
```
Shouldn...
marcandre (Marc-Andre Lafortune)
03:48 PM Revision 9a68aba7 (git): Support OSC and treat \1 \2 correctly
aycabta (aycabta .)
03:21 PM Revision 70166b3c (git): Revert "Support OSC and treat \1 \2 correctly"
This reverts commit 77bfebebc44c5e46ebd156d074081846c037f882. aycabta (aycabta .)
03:20 PM Revision 11778fd2 (git): * 2019-05-28
git[bot]
03:17 PM Revision 77bfebeb (git): Support OSC and treat \1 \2 correctly
aycabta (aycabta .)
02:08 PM Revision 8a2a5822 (git): Colorize error part
nobu (Nobuyoshi Nakada)
02:08 PM Revision b4365e75 (git): Do not make an incomplete escape a valid char
nobu (Nobuyoshi Nakada)
02:08 PM Revision c40003da (git): Ripper#token
* parse.y (ripper_token): added Ripper#token which returns the
current token string. [EXPERIMENTAL]
nobu (Nobuyoshi Nakada)
10:50 AM Feature #15879: Proposal: Time#to_i accepts :unit keyword
I agree with sawa's comment - this is a bit surprising, at the least to me as well. It would
be better to re-use the same idioms, so that ruby users are not surprised by behaviour, if
it can be avoided.
But I think this is only one ...
shevegen (Robert A. Heiler)
10:25 AM Feature #15879: Proposal: Time#to_i accepts :unit keyword
You can also use `Time#to_r`:
```ruby
{
event_id: id,
name: name,
tracked_at: (tracked_at.to_r * 1_000).to_i,
tracked_at_micro: (tracked_at.to_r * 1_000_000).to_i
}
```
At least it's always the same multiply-and-trun...
phluid61 (Matthew Kerwin)
10:17 AM Feature #15879: Proposal: Time#to_i accepts :unit keyword
With `Float#to_i`, the decimal part is truncated, not rounded:
```ruby
123.7.to_i # => 123
123.7.round # => 124
```
In contrast to this, your proposal with `Time#to_i` seems to return rounded results even though the method name ...
sawa (Tsuyoshi Sawada)
10:10 AM Feature #15879: Proposal: Time#to_i accepts :unit keyword
By analogy from `Time#round`, which takes as an argument an integer representing the precision in decimal places, and from `String#to_i`, which takes an integer, I think that passing an integer representing the number of decimal places w... sawa (Tsuyoshi Sawada)
09:22 AM Feature #15879 (Open): Proposal: Time#to_i accepts :unit keyword
I often need Unix time as microseconds or nanoseconds to serialize for other language environments.
For example, Java uses milliseconds(nanoseconds) basically.
In such a situation, current Ruby code is like below.
``` ruby
{
e...
joker1007 (Tomohiro Hashidate)
09:53 AM Misc #15874: DevelopersMeeting20190613Japan
* [Bug #15733] Inconsistent `__FILE__` and `Kernel#__dir__` tagomoris (Satoshi Tagomori)
01:00 AM Misc #15874: DevelopersMeeting20190613Japan
* [Feature #15725] Add `Array#reverse_sort`, `#revert_sort!`, `#reverse_sort_by`, and `#reverse_sort_by!`
I would like to propose these methods as the preferred way for developers to create reverse sorted array, which is to call `sort...
sikachu (Prem Sichanugrist)
07:19 AM Revision b3602f1d (git): check the object is in tomb_heap.
ko1 (Koichi Sasada)
07:12 AM Revision 35146c43 (git): add a space between type and others
ko1 (Koichi Sasada)
07:09 AM Revision b3a6469e (git): add a line break for each error message
ko1 (Koichi Sasada)
05:53 AM Revision 6c1a0755 (git): fix GC.verify_internal_consistency.
Fix debug output to dump more useful information on GC.compact
debugging.
check_rvalue_consistency_force() now accepts `terminate` flag
to terminate a program with rb_bug() or only print error message.
GC.verify_internal_consistency use...
ko1 (Koichi Sasada)
05:53 AM Revision 61da57c7 (git): is_pointer_to_heap() checks also tomb or not.
is_pointer_to_heap(obj) checks this obj belong to a heap page.
However, this function returns TRUE even if the page is tomb page.
This is re-commit of [712c027524].
heap_page_add_freeobj() should not use is_pointer_to_heap(), but
should...
ko1 (Koichi Sasada)
04:58 AM Revision ea6e284d (git): parse.y: removed "parser_" prefix from tokadd_utf8
nobu (Nobuyoshi Nakada)
04:58 AM Revision af17e111 (git): Added #inspect and #pretty_inspect to Ripper::Lexer::Elem
nobu (Nobuyoshi Nakada)
03:58 AM Revision 43730256 (git): open-uri: Regenerate server certificates for tests
OpenSSL 1.1.1 requires 2048 bits or more. This change will fix:
https://rubyci.org/logs/rubyci.s3.amazonaws.com/debian/ruby-master/log/20190527T003004Z.fail.html.gz#test%2Fopen-uri
mame (Yusuke Endoh)
03:27 AM Bug #15875 (Closed): const_defined? behavior inconsistency in 2.6.x series
nagachika (Tomoyuki Chikanaga)
02:47 AM Revision 4c277364 (git): CSI allows empty digit which equals 0
nobu (Nobuyoshi Nakada)
02:19 AM Feature #15878: Make exit faster by not running GC
chrisseaton (Chris Seaton) wrote:
> Is Ruby's GC conservative? So even if a GC is performed at exit are IO buffers guaranteed to be flushed?
Yes and yes. There is a special handling code for process termination, somewhere around htt...
shyouhei (Shyouhei Urabe)
01:55 AM Feature #15878: Make exit faster by not running GC
Is Ruby's GC conservative? So even if a GC is performed at exit are IO buffers guaranteed to be flushed? chrisseaton (Chris Seaton)
01:49 AM Feature #15878: Make exit faster by not running GC
IMHO it is challenging to make a GC-less exit fundamentally safer than exit!
GC does some important tidy-up tasks for you, like ensuring contents in IO buffers flushed.
shyouhei (Shyouhei Urabe)
02:05 AM Revision 0aa9b003 (git): context.rb: hide wrapping lines
* lib/irb/context.rb (IRB::Context#evaluate): separate the code
from wrapping lines to propagate the given exception, not to show
the wrapping lines when SyntaxError.
nobu (Nobuyoshi Nakada)
01:18 AM Revision 9840f52c (git): Use IRB::InputMethod#eof? to quit
aycabta (aycabta .)
01:09 AM Revision 1d301acb (git): Fix rendering bug of ^D
aycabta (aycabta .)
12:53 AM Feature #15725: Proposal: Add Array#reverse_sort, #revert_sort!, #reverse_sort_by, and #reverse_sort_by!
Thank you for your initial feedback. I would like to quote one thing:
> I myself usually use `.sort` and `.sort_by`, and then apply `.reverse` afterwards.
That's definitely the reason why I submit this proposal, because `array.sort...
sikachu (Prem Sichanugrist)

05/26/2019

11:39 PM Revision 9c136f3d (git): Move to next of last line by ^D
aycabta (aycabta .)
11:13 PM Revision 4e2c7783 (git): Check blank history
aycabta (aycabta .)
10:35 PM Revision 2805c55a (git): Move to next of last line by ^C
aycabta (aycabta .)
10:00 PM Revision c49796c9 (git): Reline should move to next line after finished in Readline mode
aycabta (aycabta .)
09:32 PM Revision 29c16b30 (git): Add support for history with Reline backend
Sutou Kouhei
09:04 PM Revision 2c91c5b3 (git): Move to the other line when press <- at head or -> at tail
aycabta (aycabta .)
08:45 PM Revision 716ba4a1 (git): Implement J to join lines in vi command mode
aycabta (aycabta .)
08:01 PM Revision 64dc2183 (git): Remove \1 and \2 that escape CSI before render
aycabta (aycabta .)
07:20 PM Revision c6b7cad5 (git): .azure-pipelines.yml: Add timeout to install dependencies
to avoid cancelling overall build pipeline when stucking there. k0kubun (Takashi Kokubun)
07:13 PM Feature #15878 (Assigned): Make exit faster by not running GC
I noticed that exit takes 0.2 ... I'm trying to write a fast cli, so any improvement here would be great or an option to opt-out of certain cleanup tasks
exit! takes a constant low time
```
ruby -rbenchmark -e 'puts Benchmark.realti...
grosser (Michael Grosser)
06:32 PM Revision 64ee8900 (git): Highlight global variable on IRB
k0kubun (Takashi Kokubun)
06:26 PM Revision 7597f7ec (git): Simplify lexer state matching in #dispatch_seq
for improving readability of the condition. It may be slightly faster, or may not. k0kubun (Takashi Kokubun)
06:10 PM Feature #15751 (Closed): Add FrozenError#receiver
Applied in changeset commit:git|39eadca76b48fc7841da688f6745e40897ec37ff.
----------
Add FrozenError#receiver
Similar to NameError#receiver, this returns the object on which
the modification was attempted. This is useful as it can pin...
jeremyevans (Jeremy Evans)
06:10 PM Revision 5a6c77bb (git): * expand tabs.
git[bot]
06:09 PM Revision 39eadca7 (git): Add FrozenError#receiver
Similar to NameError#receiver, this returns the object on which
the modification was attempted. This is useful as it can pinpoint
exactly what is frozen. In many cases when a FrozenError is
raised, you cannot determine from the context...
jeremyevans (Jeremy Evans)
06:03 PM Revision 89790128 (git): Refactor IRB color dispatch
The reason why we were checking lexer state in addition to token was
that we do not want to colorize local variable, method call, etc., while
they share the :on_ident token with a name of method definition which
should be colored as blue...
k0kubun (Takashi Kokubun)
05:59 PM Revision e73a68eb (git): Support op, cvar, iver, gvar and kw that follow on symbeg in IRB
aycabta (aycabta .)
05:56 PM Revision 12267913 (git): Support :@@cvar and : on colorize
aycabta (aycabta .)
05:23 PM Revision e50aa359 (git): Make the imaginary color on IRB close to pry
and sorted the token names alphabetically. k0kubun (Takashi Kokubun)
05:13 PM Revision 60cc03ff (git): Fix indexes in comments of vi_insert.rb
Previous fix was 2993b361333147f6dfb86a153971c22329ffbaf4. aycabta (aycabta .)
04:59 PM Revision 0f35c79a (git): Fix number literal regexp of IRB completion
aycabta (aycabta .)
04:24 PM Revision e39c950c (git): Use correctly RI output in IRB completion
aycabta (aycabta .)
03:45 PM Revision 2a7821b2 (git): * 2019-05-27
git[bot]
03:40 PM Revision a43c6376 (git): parse.y: broke the terminator condition down
* parse.y (here_document): broke the terminator condition down
into each piece, the positional condition, resetting the
dedented here-document indentation, and matching identifier.
suppress a false warning by icc.
nobu (Nobuyoshi Nakada)
02:46 PM Revision 4f2a7b80 (git): Colorize imaginary and rational literals
nobu (Nobuyoshi Nakada)
01:31 PM Bug #15877: Incorrect constant lookup result in method on cloned class
Running with `RubyVM::InstructionSequence.compile_option = {inline_const_cache: false}` produces the correct result. danielwaterworth (Daniel Waterworth)
09:59 AM Bug #15877 (Closed): Incorrect constant lookup result in method on cloned class
This behavior seems wrong to me:
``` ruby
class Foo
def test
TEST
end
end
Bar1 = Foo.clone
Bar2 = Foo.clone
class Bar1
TEST = 'bar-1'
end
class Bar2
TEST = 'bar-2'
end
# If these two lines are reorder...
danielwaterworth (Daniel Waterworth)
01:29 PM Revision 23270f6f (git): azure-pipelines.yml: Do not notify vs2017 failure
It has not been stable recently. Let's stop notifying them for now. k0kubun (Takashi Kokubun)
09:47 AM Revision 2ce6365f (git): parse.y: adjust error indicator
* parse.y (parser_yylex): adjust the error indicator of unexpected
fraction part.
before:
~~~
1.2.3
^~~
~~~
after:
~~~
1.2.3
^~
~~~
nobu (Nobuyoshi Nakada)
09:24 AM Revision 58308899 (git): test/ruby/test_notimp.rb: Use EnvUtil.timeout for timeout scale factor
nobu (Nobuyoshi Nakada)
08:25 AM Revision 2df2cdcf (git): test/ruby/test_process.rb: Use EnvUtil.timeout for timeout scale factor
https://rubyci.org/logs/rubyci.s3.amazonaws.com/solaris11s-sunc/ruby-master/log/20190526T052508Z.fail.html.gz mame (Yusuke Endoh)
08:23 AM Revision 4668a3a9 (git): test/lib/envutil.rb (EnvUtil.timeout): added.
It is a wrapper for Timeout.timeout with the scale factor applied. mame (Yusuke Endoh)
07:24 AM Revision 02b39dae (git): Fix scanner event at invalid syntax
* parse.y (parser_yyerror, parser_compile_error): revert
r67224 (e5d10cda07b23682e5e4e64d1324e4d3247d4785) "Flush erred
token".
nobu (Nobuyoshi Nakada)
06:23 AM Revision f20af954 (git): test/rubygems/test_gem_stream_ui.rb (test_ask): extend the timeout
for Solaris.
https://rubyci.org/logs/rubyci.s3.amazonaws.com/unstable10s/ruby-master/log/20190525T211908Z.fail.html.gz
mame (Yusuke Endoh)
05:32 AM Revision aaf6c678 (git): Handle keyword symbol in IRB::Color::SymbolState
k0kubun (Takashi Kokubun)
05:29 AM Revision 52b09fce (git): Deal with more syntax highlight edge cases
Please refer to the tests again. k0kubun (Takashi Kokubun)
05:07 AM Revision 8aba3b7a (git): Fix more unintended syntax highlights
See tests for what kind of things are fixed. k0kubun (Takashi Kokubun)
03:58 AM Feature #15797: Use realpath(3) instead of custom realpath implementation if available
I have added a pull request for this feature (https://github.com/ruby/ruby/pull/2205), and made the necessary changes so it passes Travis and AppVeyor. This changes related to fixing encoding issues and working around issues in glibc re... jeremyevans0 (Jeremy Evans)
03:47 AM Revision 13f58ecc (git): Always color Symbol as Yellow on IRB::Color
Symbol color was made blue as a workaround because it was hard to
distinguish `foo`s in `:foo` and `def foo; end` (both are :on_ident).
But I wanted to make it yellow like pry.
`:Struct` had the same problem in :on_const. Because the :o...
k0kubun (Takashi Kokubun)
03:08 AM Bug #15876: 1.to_s.encoding != Encoding.default_internal
@grosser said
> I ran into strange looking test output when I compared .to_s with an expected text, saying that the encoding was different
I thought that some string-comparison assertions (maybe attributed to an external testing fr...
mame (Yusuke Endoh)
02:30 AM Bug #15876: 1.to_s.encoding != Encoding.default_internal
@mame:
What @grosser is saying is that
```
p s1.encoding == s2.encoding #=> false
```
but he expects the result to be true. But you are right that what counts is the equality of the strings, not the encodings.
duerst (Martin Dürst)
12:34 AM Bug #15876: 1.to_s.encoding != Encoding.default_internal
@grosser, could you elaborate your problem? I cannot reproduce the warning. What warning did you see? And how?
```
s1 = 1.to_s
p s1.encoding #=> #<Encoding:US-ASCII>
s2 = "1"
p s2.encoding #=> #<Encoding:UTF-8>
p s1 == s2 ...
mame (Yusuke Endoh)
12:48 AM Revision a516834b (git): test/ruby/test_rubyoptions.rb (test_script_from_stdin): scale timeout
for Solaris.
https://rubyci.org/logs/rubyci.s3.amazonaws.com/unstable10s/ruby-master/log/20190525T131909Z.fail.html.gz
mame (Yusuke Endoh)

05/25/2019

10:45 PM Bug #11363: Fix tests for String#crypt so they pass on OpenBSD
CI looks clean with https://github.com/ruby/ruby/pull/2200, so I'll be committing it in about a week if there are no objections. jeremyevans0 (Jeremy Evans)
10:25 PM Bug #15876: 1.to_s.encoding != Encoding.default_internal
> which is confusing/annoying especially to users that don't know
> ...
I personally finally switched into UTF-8 (oddly enough, primarily due to emoji and
unicode-symbols that can be used for simple indications both on the commandline ...
shevegen (Robert A. Heiler)
05:40 PM Bug #15876 (Closed): 1.to_s.encoding != Encoding.default_internal
I ran into strange looking test output when I compared .to_s with an expected text, saying that the encoding was different, which is confusing/annoying especially to users that don't know how encodings work in ruby.
1.to_s.encoding shou...
grosser (Michael Grosser)
09:15 PM Revision 208ed56e (git): Colorize empty embexpr more on IRB::Color
k0kubun (Takashi Kokubun)
05:32 PM Bug #15872: CSV.parse omits close call when block is given – intended or bug?
FWIW, I believe this is a bug.
> When a block is given and the argument is an IO-like object, it may not reach its end after exiting the each method
You mean if the block interrupts the processing with `break`, `return` or `raise`...
marcandre (Marc-Andre Lafortune)
04:32 PM Revision ec759011 (git): Fix completion menu state calculation
aycabta (aycabta .)
03:48 PM Revision 2993b361 (git): Fix indexes in comments
nobu (Nobuyoshi Nakada)
03:19 PM Revision 98be2037 (git): Support some unhandled syntax highlight
Heredoc, %i, :Foo, { 'a': ... }, ...
:'a' is still half-broken.
k0kubun (Takashi Kokubun)
03:00 PM Revision a4d44b08 (git): * 2019-05-26
git[bot]
03:00 PM Revision d9c41f2d (git): Use Reline.completer_word_break_characters to complete
aycabta (aycabta .)
02:49 PM Revision ada64aa9 (git): Clear IRB::Color escape sequence before newline
because otherwise prompt and other things could be polluted. k0kubun (Takashi Kokubun)
02:26 PM Revision 7c507345 (git): Build trunk branch too to trigger AppVeyor on PR
k0kubun (Takashi Kokubun)
02:24 PM Revision be851692 (git): Build trunk branch too to trigger Travis on PR
k0kubun (Takashi Kokubun)
02:10 PM Revision e2db9f4c (git): Add and use Reline::Unicode.escape_for_print
k0kubun (Takashi Kokubun)
01:31 PM Revision e691b4da (git): Respect --nocolorize on REPL source highlight
k0kubun (Takashi Kokubun)
12:48 PM Feature #15868: Implement `File.absolute_path?`
I added a couple more specs to check that in https://github.com/ruby/ruby/pull/2198/commits/d59a5c93dd4b20aa0898a24fab78a68a2cc84925, but I'm not sure where I can check whether they pass on Windows or not. deivid (David Rodríguez)
08:20 AM Revision 65ce14e7 (git): Added --with-rdoc option
New option to direct formats of RDoc to install. nobu (Nobuyoshi Nakada)
08:16 AM Revision 4fae3c3f (git): Show doc list to install
Show document format list to install, not only enabled or disable. nobu (Nobuyoshi Nakada)
08:16 AM Revision 8fd3b9fc (git): Force update all RDoc at install
RDoc needs to parse all files at once for the cross-reference. nobu (Nobuyoshi Nakada)
07:38 AM Revision 061c781a (git): Drop method obsoleted by b83119be9e9a8611063142541993e4823a025622
We might need to do the same thing in IRB::Color now, but I'm not doing
that as I assume ANSI escape sequence does not come from a user input
though Reline.
k0kubun (Takashi Kokubun)
06:54 AM Revision b83119be (git): Incremental syntax highlight for IRB source lines
Closes: https://github.com/ruby/ruby/pull/2202 k0kubun (Takashi Kokubun)
03:40 AM Bug #15875: const_defined? behavior inconsistency in 2.6.x series
Bisected to commit:bf8cc37b467e1d372e1b01b4d25e9ef6f8cc927f.
Backporting commit:d10451f3fd51f577e704db770de48d05044eb45c to 2.6 fixes this bug.
jeremyevans0 (Jeremy Evans)
02:28 AM Revision 3c6e1a8c (git): Avoid to show warning message with unused variable.
hsbt (Hiroshi SHIBATA)
01:42 AM Revision 7686e33e (git): JSON like label ends by differs from the start
pp Ripper.lex('{ "a": 3 }')
=>
[[[1, 0], :on_lbrace, "{", EXPR_BEG|EXPR_LABEL],
[[1, 1], :on_sp, " ", EXPR_BEG|EXPR_LABEL],
[[1, 2], :on_tstring_beg, "\"", EXPR_BEG|EXPR_LABEL],
[[1, 3], :on_tstring_content, "a", EXPR_BEG|EXPR_LABEL]...
aycabta (aycabta .)
01:28 AM Feature #15799: pipeline operator
I think a pipeline operator can be helpful in a functional language, based on my experience with `$` in Haskell. However, I don't think it is a good idea to implement a replacement for the `.` operator just to avoid parentheses. If it... jeremyevans0 (Jeremy Evans)
01:13 AM Bug #13846 (Closed): Openbsd possible memory leak when using Thread
I did some testing of this recently. With ruby 2.6, the memory use is constant. With ruby 2.5, there is slight memory growth. However, considering the extensive thread changes between ruby 2.5 and ruby 2.6, it is unlikely the particul... jeremyevans0 (Jeremy Evans)
01:06 AM Bug #9606: Ocassional SIGSEGV inTestException#test_machine_stackoverflow on OpenBSD
I haven't seen `TestException#test_machine_stackoverflow` SIGSEGV in a long time on OpenBSD. I'm guessing the numerous improvements in the last 5 years make this is no longer an issue. Is anyone else seeing `TestException#test_machine_... jeremyevans0 (Jeremy Evans)
12:59 AM Bug #14807 (Closed): 2.6.0-preview2 segfaults on OpenBSD due to missing pthread_condattr_init call
Fixed by commit:832b601e49fd402ec7f30b36a95473131e93ae94. As taca explained, PTHREAD_COND_INITIALIZER should not be used for pthread_condattr_t. jeremyevans0 (Jeremy Evans)
12:51 AM Bug #15798 (Closed): Fix threads not waking up on SIGINT when using UBF_TIMER_PTHREAD
Applied in changeset commit:git|1ef39d8d099f145222b9352423af16a2bab6e05b.
----------
Fix process not waking up on signals on OpenBSD
When using UBF_TIMER_PTHREAD (the UBF handler on OpenBSD), the
timer_pthread_fn function will not sign...
jeremyevans (Jeremy Evans)
12:51 AM Revision 809ac9f2 (git): * expand tabs.
git[bot]
12:50 AM Revision 1ef39d8d (git): Fix process not waking up on signals on OpenBSD
When using UBF_TIMER_PTHREAD (the UBF handler on OpenBSD), the
timer_pthread_fn function will not signal the main thread with
SIGVTALRM in cases where timer_pthread is armed before
consume_communication_pipe is called. This is because
c...
jeremyevans (Jeremy Evans)
12:13 AM Misc #15874: DevelopersMeeting20190613Japan
* [Feature #14111] ArgumentErrorが発生した時メソッドのプロトタイプをメッセージに含む
Include the method prototype in the message when `ArgumentError` occurred
* [Feature #14145] Proposal: Better `Method#inspect`
* [Feature #15799] pipeline operator
nobu (Nobuyoshi Nakada)
 

Also available in: Atom