Activity
From 05/08/2019 to 05/14/2019
05/14/2019
-
09:24 PM Feature #15831: Add `Array#extract`, `Hash#extract`, and `ENV.extract`
- nobu (Nobuyoshi Nakada) wrote:
> Why `Array#extract` has no argument but takes a block, while `Hash` and `ENV` are opposite?
I implemented those methods to mirror similar behavior as it is in Active Support, but I also feel like we... -
12:33 AM Feature #15831: Add `Array#extract`, `Hash#extract`, and `ENV.extract`
- Why `Array#extract` has no argument but takes a block, while `Hash` and `ENV` are opposite?
-
06:51 PM Bug #15849: Using hash as first positional argument, mixed with named arguments causes unexpected behavior
- I believe this is the same issue as #12717. We are trying to address this issue in #14183.
-
06:39 PM Bug #15849 (Closed): Using hash as first positional argument, mixed with named arguments causes unexpected behavior
- If the first argument of a method defaults to an empty hash, and there is another keyword argument after it, it does not set first parameter given to the first argument
For example:
``` ruby
data = {}
# This method does not modif... - 03:19 PM Revision 46a47988 (git): * 2019-05-15
-
03:18 PM Revision 2ca537ba (git): Fixing function name
- This function is used for marking / pinning vm stack values, so it
should have "vm" in the function name to be more clear. -
10:35 AM Feature #15848: Silence warning when conditional assignments are wrapped in parentheses
- shevegen (Robert A. Heiler) wrote:
> I can't think of a simple way to controls warnings though :( - I guess if we may have some
> ...
A per-file setting is too broad. Given:
```ruby
if (a = foo)
do_this if a == x
do_that if a =... -
09:43 AM Feature #15848: Silence warning when conditional assignments are wrapped in parentheses
- Personally I tend to try to avoid assignment-styles in if-clauses, but I do have to admit that
I am also using it rarely. But in general I try to just write code that is simple to read at
all times instantly and I am fine with breaking... -
- sawa (Tsuyoshi Sawada) wrote:
> Why do the parentheses indicate that assignment is intended, and not comparison?
It's a convention used in C compilers. The explicit optional parentheses are seen as a hint that this is what the develo... -
08:13 AM Feature #15848: Silence warning when conditional assignments are wrapped in parentheses
- Why do the parentheses indicate that assignment is intended, and not comparison?
-
- Sometime it's convenient to have an assignment in an `if`-condition. The Ruby documentation even contains an example showing this *"most common use of side-effect"* practice:
http://ruby-doc.org/core-2.6.3/doc/syntax/control_expressio... -
08:15 AM Revision b5a3ec7f (git): Remove useless use of a variable in Reline::ANSI
-
-
07:45 AM Revision 4fe0961d (git): Fix typo in debugged C source name
- I failed to collect any debug info in
https://app.wercker.com/ruby/ruby/runs/mjit-test1/5cda57fcab79a30008f195f6?step=5cda6a4e1090c4000800772e
It seems that it's due to this typo. -
-
-
-
-
05:41 AM Bug #15844: VM has trouble releasing memory (?) on NoMethodError
- nobu (Nobuyoshi Nakada) wrote:
> On exiting by an exception, ruby tries to print the exception and `NoMethodError` shows its receiver.
> ...
Recursion should not be a problem. Cycles definitely will be a problem.
> Define your own `... -
-
-
-
-
02:50 AM Bug #15847: SecureRandom#gen_random becomes private after first invocation
- Thank you for reporting! It was my fault. have just pushed a fix.
-
- Applied in changeset commit:git|5bab1304af25a843728dbcd2f3594913740aecb0.
----------
fix visibility of SecureRandom.gen_random
Aliasing a method preserves its visibility. These aliases turn
formerly-public methods into private. Shoul... -
- Aliasing a method preserves its visibility. These aliases turn
formerly-public methods into private. Should make them public
again. [Bug #15847] -
- hsbt (Hiroshi SHIBATA) wrote:
> I update the license of Ruby to racc upstream
How dare you can do such thing? Do you actually own the copyright? -
12:08 AM Feature #15833: Some refactors for shared-root array
- Eregon (Benoit Daloze) wrote:
> I think nowadays RArray should be considered internal and C extensions should not access members of struct RArray directly, as that's very likely going to be incorrect or very complex.
> ...
Thank you to...
05/13/2019
-
- On exiting by an exception, ruby tries to print the exception and `NoMethodError` shows its receiver.
Your `Node` is a recursive construction, so it increases exponentially by the size.
Define your own `inspect` method not to include `... -
10:42 PM Feature #15833: Some refactors for shared-root array
- I think nowadays RArray should be considered internal and C extensions should not access members of struct RArray directly, as that's very likely going to be incorrect or very complex.
I don't think many C extensions use RArray directly... -
-
-
- This prevents the constants from moving.
-
-
- GC is required for pinning / marking objects. If the compactor runs
without pinning everything, then it will blow up, so just return early
if the GC is disabled. -
04:41 PM Feature #8992: Use String#freeze and compiler tricks to replace "str"f suffix
- I recently had to remind myself what kind of magic is hiding behind 'str'.freeze and would like to provide some feedback.
While tactically this may have been justified, strategically this is a wrong direction. This approach moves the ... - 03:32 PM Revision 0215520b (git): * 2019-05-14
-
-
03:07 PM Bug #15847 (Closed): SecureRandom#gen_random becomes private after first invocation
- There seems to be an issue with `SecureRandom#gen_random` becoming private after first invocation:
```
+ $ /tmp/my_ruby/bin/ruby -v
ruby 2.7.0dev (2019-05-13 trunk 082bbdc92e) [x86_64-linux]
```
```
$ /tmp/my_ruby/bin/ruby \
... -
-
12:26 PM Revision 082bbdc9 (git): Update the canonical repository for racc.
-
- See https://bugs.ruby-lang.org/issues/9456#note-13
-
12:14 PM Revision b42303b1 (git): Fix typos
-
- I update the license of Ruby to racc upstream and picked ruby-core changes.
https://github.com/ruby/racc/pull/107
After this is merged, I'm going to merge bin/racc from upstream. -
07:50 AM Bug #15845 (Closed): Backport dcb6a6ae3e
- WindowsのCIでの3Eを消すものです
-
02:29 AM Revision 2dc61381 (git): delegate.rb: don't look for methods on Kernel
- Instead, look for instance methods of Kernel.
Otherwise, instance methods of Module (which are methods of Kernel
itself) are mistakenly believed to exist, and it fails when calling
Kernel.instance_method().
Closes: https://github.com/ru...
05/12/2019
-
08:26 PM Bug #15844 (Rejected): VM has trouble releasing memory (?) on NoMethodError
- When the test case is run, the process goes haywire. I observe RSS bouncing around, and trending upwards. CPU on the process is at 100%.
The test case is a partial implementation of a binary tree which is also a doubly linked list. ... -
-
-
-
-
- When the value is not Proc.
-
- When unknown value comes.
-
-
- - insert_text
- redisplay
- line_buffer
- point
- point=
- vi_editing_mode
- emacs_editing_mode
- vi_editing_mode?
- emacs_editing_mode?
- get_screen_size -
-
-
04:55 PM Bug #15841: SegFault in OpenSSL::PKey::RSA#private_encrypt
- Interesting. I've meant to create a repo that allowed one to write a test, and run it against MinGW, Linux, & OSX builds, using current Ruby builds (2.4 thru trunk).
All darwin18 builds passed, Linux Xenial builds failed, and MinGW b... -
-
03:43 PM Revision 559cad9f (git): Improve doc for Enumerable#include? and member?
- Existing doc for Enumerable#include? and member? has some problems.
* `IO.constants` is not commonly used, and only some know
that `SEEK_SET` is actually included in constants.
* `IO.constants` is actually an Array, not the example i... -
- 03:23 PM Revision d3a702a3 (git): * 2019-05-13
-
-
-
-
- This reverts commit b1767e56b158d8307412a0928a7ac2366541429d.
-
-
- (from my previous comment, I changed a plan for the following one and filed another ticket)
* [Misc #15843] Make "trunk" a symbolic-ref of "master" on git.ruby-lang.org
* Please see "Expected outcome" part. Do you have any objectio... -
- k0kubun (Takashi Kokubun) wrote:
> * Can we decide the date to rename the branch "trunk" to "master"? Does anyone have any objection for it? What do we need to prepare for it?
> ...
Just to get rid of a typo, `symbolic-ref` seems wor... -
- ## Background
* We're using `trunk` branch as a canonical development branch because it has been mirrored to there by git-svn.
* In a usual git repository, a HEAD branch is `master` by default. Using `trunk` instead of `master` is co...
05/11/2019
-
- Methods that return classes often module_eval the given block
(e.g. `Class.new` and `Struct.new`). This allows `DelegateClass` to
work similarly. This makes it easier to use `DelegateClass`
directly without subclassing, so as not to... - 03:52 PM Revision 3211a0a1 (git): * 2019-05-12
-
-
-
-
- The author of set.rb is knu.
-
- I have exactly the same concern as nobu. And that problem stems from the fact that, in this proposal, the condition is given as an argument of the method, which means that it has to be evaluated independently of the return value that app...
-
- As it seems useful only when `condition` doesn't use the parameter `query`, it is questionable to me if it is generic enough to be a language feature.
05/10/2019
-
- I can't say much about the API/name but the functionality looks useful/good in my opinion.
-
-
-
- Revert "Propagate parser_params to rb_yytnamerr"
This reverts commit 15f45ae4d12f14714ab3021b60887d8c7bf4b095. -
- This reverts commit 56528da3efb32bb773b22740c24450246b861e58.
-
-
-
-
-
-
-
- to fix
https://ci.appveyor.com/project/ruby/ruby/builds/24438615/job/yld1utsltxag9dr2 -
- wanabe (_ wanabe) wrote:
> How about delaying `gc_finalize_deferred()` phase after `gc_update_references()`?
Like this:
```
diff --git a/gc.c b/gc.c
index ea4f54ce0e..68d58fcb5e 100644
--- a/gc.c
+++ b/gc.c
@@ -8100,14 +8100,... -
05/09/2019
- 07:28 PM Revision c4d49749 (git): * 2019-05-10
-
-
03:15 PM Bug #15409: OpenStruct error when attribute is called 'method'
- I just encountered this issue trying to pop a json structure into an OpenStruct. It would be great if there was a way to indicate to OpenStruct such that some keywords (e.g. `method`) are safe to be overridden in a particular context.
-
02:40 PM Bug #9089: rb_fix2uint no longer raises a RangeError when given negative values
- I felt uncomfortable with the behavior of `rb_num2ull`. I don't know if it is correct to comment on this ticket, but it seemed to be similar.
The current behavior of `rb_num2ll` is as follows.
|range|behavior|
|---|---|
| val < -... -
- `rb_gc()` calls `garbage_collect()` and `gc_finalize_deferred()`.
Finalizers may create (or recycle) objects, but they can't be pinned because the mark-and-pin phase of `garbage_collect()` is done.
How about delaying `gc_finalize_defer... -
11:19 AM Bug #15841 (Closed): SegFault in OpenSSL::PKey::RSA#private_encrypt
- Hi.
I am writing code that gets rsa private_key using `OpenSSL::PKey::RSA#set_key`.
As a test, I tried to run following code, and got a crash report.
```
require 'openssl'
MODULUS = OpenSSL::BN.new('126914039353434453831661971... -
10:22 AM Feature #15811: Propsing new method for comparing equality of 2 (float) numbers relatively
- wishdev (John Higgins) wrote:
> The tests for this are incorrect and show why this does not work.
> ...
Sorry but I do not really understand what you meant. What I get so far is that you mean the difference of that pair of number (1000... -
- nobu (Nobuyoshi Nakada) wrote:
> I think it should be under `Math` or `Float`, and a independent gem could be a good first step.
I have updated the first gist. It is under Math! I just forgot putting it in gist . Thank you for remind... -
- Indeed, `rb_enc_upper` is used at https://github.com/ruby/ruby/commit/269bd16b28e86d1333969389b7b402f2915e336f#diff-7a2f2c7dfe0bf61d38272aeaf68ac768R1431, while previous `rb_memcicmp` maps to the lowercase.
-
07:35 AM Bug #15816: String#casecmp compares uppercase characters instead of lowercase
- Until ruby 1.8.7, it seemed to use downcase. It was changed at r14227 to support encoding. I think the behavior change was not intended, so this is merely a bug?
```
# ./bin/ruby-1.8.7-p374 -e 'p "a".casecmp("[")'
1
# ./bin/rub... -
- The documentation of `String#casecmp` does not specify how it is is implemented, so it seems fair to consider switching. However, this change is likely to cause backwards compatibility issues. While it seems unlikely there are many app...
-
-
- I am convinced by shyouhei's comment. Please close this feature request.
-
- Related to #15828, a standard method to search configuration files would be nice.
We (naruse and nobu) talked about it and agreed on `Etc.config_file`
To load a config file as Ruby script:
```ruby
Etc.config_file(basename) {|path... -
-
- I withdraw this feature request. Please close it.
-
-
- I now realize that, for the given use case, I can use `with_object` multiple times as follows:
```ruby
e
.each.with_object({}).with_object([]) {|(c, h), a| h[c] ? a.push(c) : h.store(c, true)}
.uniq
```
So I withdraw this featu... -
- This heredoc isn't a syntax error,
```ruby
#encoding: cp932
p <<-STR
\xe9\x9d
\u1234
STR
```
whereas this is.
```ruby
#encoding: cp932
"
\xe9\x9d
\u1234
"
``` -
- joeychou0235 (Joey Chou) wrote:
> - **Have you read our issues document, https://github.com/bundler/bundler/blob/master/doc/contributing/ISSUES.md?**
> ...
Here is not the bug tracker of bundler.
It's https://github.com/bundler/bundle... -
-
-
- nobu committed my fix for this at commit:bb4ac7a6506971dc34b5656f1a69aadc7299fcab
-
02:55 AM Bug #15670: Ripper treats :"sym" as xstring
- YARD is also broken, though I'm not sure how severe is that: https://github.com/lsegal/yard/issues/1243. I suspect this very change.
-
01:04 AM Revision c06ddfee (git): str_duplicate: Don't share with a frozen shared string
- This is a follow up for 3f9562015e651735bfc2fdd14e8f6963b673e22a.
Before this commit, it was possible to create a shared string which
shares with another shared string by passing a frozen shared string
to `str_duplicate`.
Such string lo... -
-
-
12:23 AM Revision f1486fea (git): require 'stringio'
05/08/2019
-
-
- Objects in the finalizer table stay pinned for now. In some cases, the
key could move which would cause a miss when removing the object from
the table (leading to a T_MOVED reference staying in the table). - 10:26 PM Revision 4ff0911c (git): * 2019-05-09
- 10:26 PM Revision 8b12db6e (git): * expand tabs.
-
- `obj_info` will look at references of objects in some cases (for example
it will try to access path information on ISeq objects). But during the
sweep phase, if the referenced object is collected before `obj_info` is
called, then it cou... -
05:37 PM Bug #15838 (Third Party's Issue): IOError: uninitialized stream
- - **What did you do?**
I ran the command `/Users/joeychou/.rbenv/versions/2.3.0/bin/bundle install`
- **What did you expect to happen?**
I expected Bundler to normally install all the gems.
- **What happened instead... -
- While I agree with naruse, it may be worthwhile to mention this briefly at e. g.
https://ruby-doc.org/stdlib/libdoc/webrick/rdoc/WEBrick.html - it could still surprise
users so it could be useful to mention it; perhaps at the section ... -
02:21 PM Feature #15836: [Proposal] Make Module#name and Symbol#to_s return their internal fstrings
- @byroot thanks for sharing the benchmark!
IMO module names should be frozen
even if it's easy to fix, this change could definitely break existing apps that depend on it, see
https://github.com/jruby/jruby/issues/5229 -
11:30 AM Feature #15836: [Proposal] Make Module#name and Symbol#to_s return their internal fstrings
- @mame re benchmark
So I decided to run this against redmine boot, using this branch: https://github.com/redmine/redmine/compare/master...byroot:boot-benchmark
Eager loading is enabled so that the entire codebase is loaded, and it u... -
- > Is HashWithIndifferentAccess the main rationale behind this request?
No. It's simply the poster child of how common `Symbol#to_s` is in code bases.
I shouldn't have mentioned `HashWithIndifferentAccess` because clearly lots of pe... -
03:15 AM Feature #15836: [Proposal] Make Module#name and Symbol#to_s return their internal fstrings
- Is `HashWithIndifferentAccess` the main rationale behind this request?
I have doubts about the usefulness of `HashWithIndifferentAccess` today, now that Rails has protected parameters.
Moreover, now that symbols are garbage collect... -
- I was about to write a long reply, but I think it would become too long, so just a shorter comment.
I use something like this in a "base" gem that I tend to use. Example:
class Foo
class Bar
NAMESPACE = inspect
... -
03:49 AM Feature #15837 (Assigned): Module#name_components
- I sometimes wrote the expression like below to extract the components of class path:
```ruby
klass.name.split('::').last
```
Similar expressions can be found in ruby-trunk:
```
mrkn@mrkn-devel:~/src/github.com/ruby/ruby$ git ... -
- to prevent failure like
https://app.wercker.com/ruby/ruby/runs/mjit-test1/5cd28aa6ab79a30008ee819b?step=5cd28b2403f44600070db083
with --jit-verbose=1. -
-
- [EXPERIMENTAL]
-
-
- see r67347
recent log: https://travis-ci.org/ruby/ruby/jobs/529640417 -
-
- for debugging failure like
https://app.wercker.com/ruby/ruby/runs/mjit-test1/5cc98936ab79a30008eb86fa?step=5cc990d73d81fb0007bb04c3
https://app.wercker.com/ruby/ruby/runs/mjit-test1/5cd18efa23fcb70008ddfd45?step=5cd1908603f4460007076c5a -
-
- Fixing 7d805e67f3275aef066d77aa9c32bef715c362ed
-
- Recently `ruby/spec on Ruby 2.4` seems stable.
- 02:18 AM Revision 6ec43d3d (git): * 2019-05-08
-