Activity
From 03/24/2019 to 03/30/2019
03/30/2019
-
06:39 PM Misc #15739 (Rejected): Improvements needed to documentation of Hash#dig, Array#dig and OpenStruct#dig
- The documentation of these three methods fails to explain how they interact. For example:
h = { a: [1,2,3] }
h.dig(:a, 1) #=> 2
`Hash#dig` is used first:
a = h.dig(:a) #=> [1,2,3]
Then `Array#dig` is invoked:
... -
05:05 PM Misc #15723: Reconsider numbered parameters
- Hi.
I'm aware this issue is just a tip of an iceberg and Matz has the final say,however I'm worried the Ruby project is slipping from its original path. I mean, how easily it gives green-light to half-assed proposals, how there is con... -
11:57 AM Misc #15723: Reconsider numbered parameters
- For me a big problem is that the syntax additions obviously affect what's being valued/promoted and so on. In the example you gave about the safe navigation operator, the real problem is that `f` could be nil in the first place. When you...
-
02:31 PM Bug #15738 (Closed): RUBYOPT disables have precedence over the command line
- Applied in changeset trunk|r67388.
----------
ruby.c: respect features by command line
* ruby.c (process_options): feature options in command line
arguments take precedence over options in RUBYOPT environment
variable. [ruby-core:... -
11:19 AM Bug #15738: RUBYOPT disables have precedence over the command line
- > I would expect the command line arguments always override RUBYOPT arguments.
I agree.
I do not know all specifics but it makes sense to me as to agree with what Benoit
wrote in regards to explicit commandline option(s) being abl... -
- * ruby.c (process_options): feature options in command line
arguments take precedence over options in RUBYOPT environment
variable. [ruby-core:92052] [Bug #15738]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67388 b2dd03c8-39d... -
02:06 PM Bug #15649: Dir.glob regression with braces and Windows drive letters
- ruby_2_6 r67353 merged revision(s) 67332.
-
- Borrowed the style of code/pre from bugs.ruby-lang.org.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67387 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67386 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67385 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:40 AM Bug #15711: Remove use of _id2ref from DRb
- I'm happy to chat/review this code and the overall _id2ref change at RubyKaigi in a few weeks, btw.
03/29/2019
- 11:26 PM Revision 031e2f12 (git): * 2019-03-30
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67384 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
11:26 PM Revision 9249346c (git): mjit_worker.c: explicitly ignore the unused result of RB_DEBUG_COUNTER_INC_IF
- By adding `(void)`. This makes Coverity Scan happy.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67383 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
06:16 PM Bug #15736 (Closed): r67361 Update to ruby/spec@e81b3cd - spec failures on MinGW ?
- I'll close this issue, I filed #15738 for the strange behavior.
-
- MSP-Greg (Greg L) wrote:
> Sorry & fixed. My test code had some `disable=gems` in test-all, and I never cleared it for spec. The new tests aren't happy with that.
Great.
Now, it is weird that the command line doesn't override the ... -
01:45 AM Bug #15736: r67361 Update to ruby/spec@e81b3cd - spec failures on MinGW ?
- @Eregon
Sorry & fixed. My test code had some `disable=gems` in test-all, and I never cleared it for spec. The new tests aren't happy with that.
Note that I run tests in ruby-loco from the install folder, so I don't use make. Esse... -
- From #15736:
It seems unexpected that the command line argument doesn't override the RUBYOPT options:
```
$ RUBYOPT=--disable-gems ruby --enable=gems -e 'p defined?(Gem)'
nil
```
That seems a bug. I would expect the command l... -
02:57 PM Feature #14183: "Real" keyword argument
- mame (Yusuke Endoh) wrote:
> > # My Proposed Alternative
> ...
Correct. Sorry about that.
>
> ...
Correct, in Ruby 3 assuming the behavior changes for keyword arguments are in effect. With your branch+my patch:
```ruby
foo({... -
- Jeremy,
I really appreciate you to use time for this issue. And sorry for my late response.
I have misunderstood some points of your proposal, and now I feel that it is fairly good. But please let me consider for a while... This t... -
02:44 PM Revision 9d047fd3 (git): Add mjit_compile_failures debug counter
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67382 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67381 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- It seems that `debug_counter_show_results_at_exit` could be called
earlier than `mjit_finish` sometimes.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67380 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67379 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67378 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:06 PM Revision 26d56f7b (git): Fix a typo [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67377 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Actually what has randomly failed was `make install`:
https://travis-ci.org/ruby/ruby/jobs/512988177
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67376 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67375 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67374 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- This spec is unstable on our CI environment:
https://gist.github.com/ko1/efa58acf4cd1d7b5bf1f63881537afe8
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67373 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- > I vote for 3 (and hashrockets ;))
I'd add a fourth variant - that is to use both explicit names and
@1 @2 @3. :)
But to keep my comment somewhat short - since hashrockets was mentioned, even with a
twinkling smiley, I initially... -
08:21 AM Misc #15723: Reconsider numbered parameters
- mame (Yusuke Endoh) wrote:
> Vote:
I vote for 3 (and hashrockets ;)) - 06:36 AM Revision ce9e0ffd (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67372 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
06:36 AM Revision 35e677dd (git): use GET_CFP() instead of access reg_cfp directly.
- GET_CFP() macro contains performance counter logic.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67371 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
04:30 AM Feature #15667: Introduce malloc_trim(0) in full gc cycles
- Thanks Sam, a very nice set of results.
Notice that 99th percentile Topic list was faster with the patch, whilst slower with Topic view. So I'm not sure we can say that the patch will always be slower on the worst runs.
Query, what... -
- FYI, here is rb_ps output:
```
(gdb) rb_ps
$1 = (rb_vm_t *) 0x7f3f8e840400
* #<Thread:0x7f3f8e98f330 rb_thread_t:0x7f3f8e80f080 native_thread:0x7f3f9088e780>
29:0x55895629eb90 <rb_queue_pop at thread_sync.c:943>:in `pop'
28:/usr/... -
- With Ruby 2.6, my single-worker application https://github.com/k0kubun/ruboty sometimes stops to respond to a message. `rb_queue_pop` does not seem to be waken up in `rb_sigwait_sleep` in some condition.
```
strace: Process 18699 att... -
- * process.c (rb_f_spawn): fix markups as rdoc.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67370 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * process.c (rb_clock_getres): fix code markups, as `+` can not
include parentheses.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67369 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67368 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- previous retry logic did not work
https://dev.azure.com/rubylang/ruby/_build/results?buildId=266
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67367 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
03/28/2019
-
- @Eregon
> Could you investigate why they fail?
Yes. I haven't had time to check it locally, will check tonite...
-
- @MSP-Greg Could you investigate why they fail?
Those specs look fine and portable from a quick look.
Does "The --enable and --disable flags can be used with frozen-string-literal" passes?
That's very similar, could it be a bug of co... -
- ruby-loco (MinGW trunk) had the following failures in spec tests as of r67365 (r67357 passed)
```
1)
The --enable and --disable flags can be used with gems FAILED
Expected "nil"
to equal "\"constant\""
/ruby/spec/ruby/command_... -
- If that is the case, that might also mean the fix in https://bugs.ruby-lang.org/issues/14998 might not be sufficient.
-
06:46 PM Bug #15735 (Closed): Thread#handle_interrupt does not prevent Thread#kill from interrupting
- https://docs.ruby-lang.org/en/trunk/Thread.html#method-c-handle_interrupt
According to the documentation above, `Thread#handle_interrupt(Exception => :never)` would prevent the interrupts from `Thread#kill`.
In the following code, ... -
05:50 PM Feature #15734 (Open): Parsing of shorthand IPv4 addresses compatible with inet_aton
- Hi Ruby team!
I've created pull request to ipaddr gem: https://github.com/ruby/ipaddr/pull/12
I want it to be merged and included to the version of gem that bundled in Ruby itself.
---
Many applications (like browsers, `curl`, ... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67366 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- This test fails on AppVeyor mswin so often:
https://ci.appveyor.com/project/ruby/ruby/builds/23427134/job/rowv0dohwni0xa37
https://ci.appveyor.com/project/ruby/ruby/builds/22970385/job/qdkqus13bhnyyfxf
https://ci.appveyor.com/project/rub... - 03:25 PM Revision 233267db (git): * 2019-03-29
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67364 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:25 PM Revision 7ce0e963 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67363 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67362 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67361 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67360 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:28 PM Feature #15554: warn/error passing a block to a method which never use a block
- This is great! Ignored blocks can be very confusing.
> A method called by super doesnt warn warning even if this method doesn't use a block.
> ...
Would it be possible for a method called by `super` to only ignore an unexpected block... -
11:44 AM Feature #15554: warn/error passing a block to a method which never use a block
- To detect if a block is used, binding would also need to be detected, e.g.: `def b(arg); arg.eval("yield"); end; def a; b(binding); end`
-
- The reason why this feature was introduced, is that people want a shorthand for `ary.map {|x| x.to_i(16) }` and `ary.map {|x| x.to_i.chr }`.
Vote:
1. Ad-hocly extend `ary.map(&:to_i)`: `ary.map(&:to_i.(16))` and `ary.map(&(:to_i >>... -
12:14 AM Misc #15723: Reconsider numbered parameters
- Eregon (Benoit Daloze) wrote:
> duerst (Martin Dürst) wrote:
> ...
What's easy or hard to read is definitely to quite some extent subjective, but just a few more points:
* You have seen the later many many times over already, but ... -
- So, the main thing I was thinking about is passing blocks that then get silently ignored. I was thinking a good way to solve this would be to have a strict mode, and then I tried to come up with things that could be in a strict mode too....
-
- This suggestion confuses me quite a bit. I am not sure of the use case; or
perhaps I don't quite understand it.
I think what you essentially suggest is to be able to run/interprete any
given .rb file with additional restrictions in ... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67359 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * parse.y: show compile error and the error line separately,
instead of building the error message by snprintf then yyerror.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67358 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67357 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- I have no personal preference here either way but I can also understand Satoshi's
explanation / confusion.
This may be good to suggest for an upcoming developer meeting. __DIR__ might have
an advantage of being faster than a method ... -
02:12 AM Bug #15733 (Rejected): Inconsistent __FILE__ and Kernel#__dir__
- This might be duplicated with #7975, #8098 and #3346, but I believe it's worth to revisit.
Now, Ruby has `__FILE__` keyword and `Kernel#__dir__` method. One is of upper-case chars, and the other is of lower-case chars.
I make mistake... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67356 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67355 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67354 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- dir.c: fix Dir.glob starts with brace
* dir.c (ruby_glob0): expand braces if a glob pattern starts with
brace.
[ruby-core:91728] [Bug #15649]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_6@673... -
- ruby_2_6 r67352 merged revision(s) 67270.
-
- dsym should be treated as string [ruby-core:91852] [Bug #15670]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_6@67352 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_6 r67351 merged revision(s) 67247.
-
- Guard out the test when it is run under root permission
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_6@67351 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:52 AM Feature #15667: Introduce malloc_trim(0) in full gc cycles
- @mame / @carlos attached is a screenshot of side by side testing on live traffic patterns
containers run multiple ruby processes (a few unicorn workers and a sidekiq worker)
standard14 = Ruby 2.6.2 + jemalloc
standard14_a = Ruby 2... -
01:19 AM Feature #15730 (Closed): Add map_with_index method
- Use `map.with_index`.
Matz.
03/27/2019
- 11:56 PM Revision 832bc507 (git): * 2019-03-28
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67350 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67349 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- localhostdotdev (localhost .dev) wrote:
> A lot of issues could be easily prevented with a strict mode, for instance:
> ...
This is being discussed in #15554.
> - $1, $2, etc. variables when matching with a regex would not be create... -
- A lot of issues could be easily prevented with a strict mode, for instance:
- Passing a block to a method that doesn't accept blocks could raise an exception, e.g. methods would be required to explicitly ask for a block (def a(..., &b... -
- matz (Yukihiro Matsumoto) wrote:
> The **possibility** to make code cryptic itself should not be the reason to withdraw a feature.
Agreed. However, so far I think almost every example I saw with more than one @-parameter feels crypti... -
- duerst (Martin Dürst) wrote:
> > ``` ruby
> ...
Actually, I would think `@1`, `@2` start to look much like Perl, i.e. cryptic sigils, that someone not already familiar with them would wonder why would people want to use something so un... -
10:26 AM Misc #15723: Reconsider numbered parameters
- duerst (Martin Dürst) wrote:
> > * The '@n' syntax complicates the idea of what '@' identifies in Ruby, making the language potentially harder to learn.
> ...
Yes, but in my mind it carries misleading hints about the scope of the var... -
- ahvetm (Erik Madsen) wrote:
> I signed up just to comment on this thread, because I also feel that this change is rather weird, and I would like to propose an alternative, that I don't think has been discussed.
> ...
In general I'd agr... -
- > I disagree. To only accept uncontroversial features is the death knell for progress. Design by committee is the last thing Ruby needs.
I'm not a fan of design by committee as well. I was referring to the fact he seemed unhappy with ... -
- I signed up just to comment on this thread, because I also feel that this change is rather weird, and I would like to propose an alternative, that I don't think has been discussed.
I understand the need for the feature, and it's a wel... -
12:32 AM Misc #15723: Reconsider numbered parameters
- joanbm (Joan Blackmoore) wrote:
>
> ...
You forgot to complain about `sym: value` hash syntax, `->` lambdas, `foo(&:bar)` proc-blocks, etc. etc.
Personally I find `@1` the least intrusive bit of syntactic magic added to Ruby in the... -
- I do not have any particularly strong opinion either way. Jabari has made one point,
though, independent of crystal, in that it may make sense to have a corresponding
.map_with_index if .each_with_index exists already. But I think ulti... -
- jzakiya (Jabari Zakiya) wrote:
> I was converting some Ruby code to Crystal on Rosetta Code and came across this Ruby snippet,
> ...
Enumerator#with_index already exists:
```ruby
[1,3,5].map.with_index{ |x, i| (x+i)**2}
=> [1, 16... -
04:58 PM Feature #15730 (Closed): Add map_with_index method
- I was converting some Ruby code to Crystal on Rosetta Code and came across this Ruby snippet,
```
arry.each_with_index.map{ |x,y| ......}
```
where ``arry`` is an array of integers.
This wouldn't convert directly into Crystal (w... -
08:43 PM Feature #15724: Optionally suppress output from IRB for assignment expressions
- Thanks to some feedback on the [PR](https://github.com/ruby/irb/pull/12), I've updated it to use [Ripper](https://ruby-doc.org/stdlib-2.6.2/libdoc/ripper/rdoc/Ripper.html), so it doesn't rely on internals of CRuby ([RubyVM](https://ruby-...
-
08:31 PM Feature #12655: Accessing the method visibility
- I know its been two years already.
but do you think we could get those new methods merged into trunk?
-
06:37 PM Bug #15731: Wrong evaluation of many keyword default arguments in 2.3 - 2.5
- Edits:
Print 1 to ... => Print 0 to ...
Ruby 2.4 bug => Ruby 2.2/2.3/24 bug
Ruby 2.6 ok => Ruby 2.1 and 2.6 ok
We => Me and Maxime Lapointe
-
- I don't know if it's worth fixing at this point, but we found a strange bug with evaluation of default keyword arguments when there are many of them (more than 32).
```
def foo(
k0: puts(0), k1: puts(1), k2: puts(2), k3: puts(3), ... -
- In a test like test/drb/ut_drb_drbssl.rb, `ossl_ssl_connect` (`OpenSSL::SSL::SSLSocket#connect`) sleeps in `rb_wait_for_single_fd` and sometimes it's never waken up.
I think it's related to timer thread elimination in Ruby 2.6 and so I ... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67348 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- headius (Charles Nutter) wrote:
> @eregon Are you talking about the PR? That has the version of code that should be merged into CRuby. The link in the description was just to show the diff in place in our CRuby fork, but it didn't base ... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67347 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
09:51 AM Feature #7148: Improved Tempfile w/o DelegateClass
- I guess this is related:
``` ruby
tf = Tempfile.new
tf.unlink
tf2 = tf.dup
puts tf.fileno
# => 10
puts tf2.fileno
# => 11
tf2.close
print tf2.fileno
# => 11
print tf.fileno
IOError: closed stream
from /usr/local/rvm/rub... - 08:26 AM Revision b51b9d50 (git): * 2019-03-27
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67346 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
08:26 AM Revision 191b99c8 (git): Merge fileutils-1.2.0 from ruby/fileutils.
- It includes the following updates:
* https://github.com/ruby/fileutils/pull/26
* https://github.com/ruby/fileutils/pull/27
* https://github.com/ruby/fileutils/pull/29
* https://github.com/ruby/fileutils/pull/34
git-svn-id: svn+... -
01:44 AM Bug #15727: [BUG] Segmentation fault at 0x0000000000000000 ruby 2.5.3p105 (2018-10-18 revision 65156) [x86_64-linux]
- It may be as the same issue as #14553 and fixed at r66130 that is backport of r63040.
Would you please try ruby-2.5.5?
03/26/2019
-
10:15 PM Misc #15723: Reconsider numbered parameters
- Gray Kemmey summed it up [perfectly](https://bugs.ruby-lang.org/issues/4475#note-20) .
I guess there is really hard to find some adequate counter-argument, defending idea behind #4475 proposal and concluded implementation.
I would ... -
- Syntax-wise I think @1 @2 is better than %1 %2 (see what jeremy wrote, even
the backwards-compatibility issue aside) or \1 \2. But this probably comes
down to aesthetics primarily. We only have a limited subset available in
regards to... -
05:12 PM Misc #15723: Reconsider numbered parameters
- sawa (Tsuyoshi Sawada) wrote:
> I remember someone proposing the backslash `\`. Will that have problems? Are there other alternatives?
What about `\1`, `\2`, etc.?
```ruby
numbers.zip(other_numbers).map{ \1 * \2 }
```
Having ... -
- bozhidar (Bozhidar Batsov) wrote:
> > I definitely prefer @1 over %1 for Ruby, because for me it 'rhymes' with @instance_var and @@class_var, as jeremyevans0 has explained.
> ...
Is there a particular reason why block argument access s... -
- > I definitely prefer @1 over %1 for Ruby, because for me it 'rhymes' with @instance_var and @@class_var, as jeremyevans0 has explained.
That's why I dislike it so much. Block vars would ideally not look like class/instance vars. Apar... -
12:20 PM Misc #15723: Reconsider numbered parameters
- I believe a bare `@` should still be implemented as it reconciles the original need of the ticket of “hard to read code” and “a readable named variable to refer to the first argument“, as well as matz’s “not fully satisfied with the beau...
-
- Answering to 4 different posts in one go, sorry.
bozhidar (Bozhidar Batsov) wrote:
> Btw, using `%1`, `%2`, `%3` is fine, right? How do people feel about that one in general. I'm kind of used to it, because that's how Clojure doe... -
08:16 AM Misc #15723: Reconsider numbered parameters
- bozhidar (Bozhidar Batsov) wrote:
> Btw, using `%1`, `%2`, `%3` is fine, right? How do people feel about that one in general. I'm kind of used to it, because that's how Clojure does it, but I'm curious if it feels very weird in general.... -
- > $it can already be defined, so this is not backwards compatible.
It can, but that's extremely unlikely, so I think the impact to backwards compatibility would be negligible. I've almost never seen anyone define globals themselves. I... -
- PR for the reference queue version is here: https://github.com/ruby/ruby/pull/2104
Won't pass CI because of the missing `weakling` dependency, but should be easy to test locally. -
- I have not written up a patch based on a reference queue, but it would basically just use the `IdWeakRef` class and the `_cleanup` method from the `IdHash` example collection in my "weakling" library:
https://github.com/headius/weakli... -
- @eregon Are you talking about the PR? That has the version of code that should be merged into CRuby. The link in the description was just to show the diff in place in our CRuby fork, but it didn't base that diff against a moment-in-time ...
-
07:24 AM Bug #15728 (Closed): error compiling C - file under Ruby
- Compiler message
/usr/local/include/ruby-2.6.0/ruby/intern.h:506:10: error: expected ‘,’ or ‘;’ before ‘void’
COLDFUNC NORETURN(void rb_memerror(void));
The specified line contains:
COLDFUNC NORETURN(void rb_memerror(void));
And so... -
07:24 AM Bug #15727 (Closed): [BUG] Segmentation fault at 0x0000000000000000 ruby 2.5.3p105 (2018-10-18 revision 65156) [x86_64-linux]
- /home/rails/.rvm/gems/ruby-2.5.3@manage_storage_units/gems/bootsnap-1.3.2/lib/bootsnap/compile_cache/iseq.rb:12: [BUG] Segmentation fault at 0x0000000000000000
ruby 2.5.3p105 (2018-10-18 revision 65156) [x86_64-linux]
-- Control fram... -
06:12 AM Feature #15626: Manual Compaction for MRI's GC (`GC.compact`)
- Okay. Second benchmark run gives essentially the same results:
unpatched: 187.9 reqs/sec, variance 4.1
patched: 179.2 reqs/sec, variance 4.8
So yeah, I'm seeing a performance regression with the patched code with *no* call to GC.c... -
- I'm trying to run this and check speed and stability with Rails Ruby Bench. I'm having an odd bug when I try to use GC.compact. But it may be my fault so I won't post it (yet).
However, I *do* notice a speed regression when running w/...
03/25/2019
-
- Since I think it is best to back proposed behavior changes with a proposed implementation, attached is a patch based on mame's keyword-argument-separation branch that implements my proposal:
* Same behavior as mame's for methods that ... -
- sylvain.joyeux (Sylvain Joyeux) wrote:
> > Does it matter what the exact timeslice is in absolute units, or what matters is how often is a high-priority Thread executed compared to a low-priority Thread?
> ...
OK, then I think it would... -
12:32 PM Feature #15438: Threads can't switch faster than TIME_QUANTUM_(NSEC|USEC|MSEC)
- > Does it matter what the exact timeslice is in absolute units, or what matters is how often is a high-priority Thread executed compared to a low-priority Thread?
The actual underlying behavior matters, actually. If I'm using Linux sc... -
- Great explanation, thanks :)
If it will be multiple params `@1`, `@2`, etc. Can we also have `@` aliasing `@1`? I think it's going to be a common use case to just have the one param. -
- maedi (Maedi Prichard) wrote:
> jeremyevans0, is it possible to have method/property calls that when without an object, reference the "current item" of the block they are in?
> ...
Think about handling:
```ruby
posts.each { puts .a... -
- jeremyevans0, is it possible to have method/property calls that when without an object, reference the "current item" of the block they are in?
```ruby
posts.each { .author = 'Santa Clause' }
```
This stops the range situation (`..`).... -
- pascalbetz (Pascal Betz) wrote:
> Aren't there any other symbols we can use? paragraph, backtick, caret, (double-)dagger, ...?
We should not add any sigils that are non-ASCII. That removes paragraph, dagger, double-dagger.
`^` (c... -
- Why not a single dot? (`.`) It mirrors the UNIX concept of "current directory":
```ruby
[1, 2, 3].each { puts . }
```
With a method/property:
```ruby
posts.each { ..author = 'Santa Clause' }
```
Keeps it simple. Makes it easier... -
- > While I'm not totally against your opinion, I would like you to understand that this feature was not made out of thin air; it was feature requested. People think this is a neat feature. If you are against the feature itself not against...
-
- @sawa Obsoleting and recycling `?` or ` sigils sounded like a nice idea at first, but incompatibility caused by the obsoletion remains years (or even decades). It seems nearly impossible.
Matz.
-
12:12 PM Misc #15723: Reconsider numbered parameters
- shyouhei (Shyouhei Urabe) wrote:
> pascalbetz (Pascal Betz) wrote:
> ...
I know that this feature was not made out of thin air. But out of a 8 year old request that does not show a real benefit (other than "it's a bit shorter").
The h... -
07:47 AM Misc #15723: Reconsider numbered parameters
- Here are some alternative sigils.
Provided that we obsolete the character literal notation `?a # => "a"`, which is rarely used, then we may use the `?` sigil like:
```ruby
[1, 2, 3].each { puts ?1}
```
Provided that we obsolet... -
- As the person who suggested the `@1` syntax, I guess I should give my opinion.
First, any approach that did not use a sigil (e.g. `this` or `it`) would probably break backwards compatibility, and that is not considered acceptable. ... -
- I think the usefulness of this feature is when there's only one parameter. When there's multiple parameters it becomes more confusing to read `@1`, `@2`, `@3` and less confusing to just name the variables.
I think limiting the "magic ... -
- I think there has been strong desire over the years for a shorthand feature like this, and it is unrealistic to ask for the feature to be withdrawn completely.
However, it is true that there is controversy regarding the use of the sig... -
01:33 AM Misc #15723: Reconsider numbered parameters
- pascalbetz (Pascal Betz) wrote:
> `{@1 * @2}` could easily be written as `{|a, b| a * b}` some chars more, yes. But IMHO more readable. I don't think that the language should be extended for something that does not have any benefit besi... -
- in MJIT implementation.
This allows us to drop cfp->bp by just modifying vm_base_ptr in the
future.
No performance impact:
$ benchmark-driver benchmark.yml --rbenv='before::before --disable-gems --jit;bp_::after --disable-gems --jit;v... - 06:58 AM Revision 7976d0d1 (git): * 2019-03-25
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67343 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- cfp->bp was (re-)introduced by Kokubun san, but VM doesn't use it
because I (ko1) want to remove it in a future. But using it make
leave instruction fast because of sp consisntency check.
So now VM uses cfp->bp.
To use cfp->bp, I checke... -
02:52 AM Feature #15626: Manual Compaction for MRI's GC (`GC.compact`)
- > I'll take a look at the core file, but can you give more info so I can try locally?
I just start my current project with passenger installed
I will create a sample project to reproduce this issue
Takes time though (stealing work t... -
- @duerst: looks like he's updated his approach a bit since I last saw the talk (quite awhile ago!) But here's a 2017 version: https://www.youtube.com/watch?v=ptG5HtmvQx8
At around 19:45 he's talking about compacting before fork.
Whe... -
- @mame / @carlos, absolutely, I just need a few more days here, mounting this kind of test is not trivial even with docker containers.
03/24/2019
-
06:02 PM Bug #15726 (Closed): Error compiling Ruby
- Hello,
I'm sorry if I'm reporting that to the wrong place but the errors are so meaningless that it's hard to know where the issue really comes from.
Trying to install Ruby by compiling it, several errors happen. The process follow... -
- > I guess we could ... but on MRI we would still have to "guess" what are both the lowest and highest time slices we want to support forever and embed that in the value. Not really a very good prospect IMO.
Does it matter what the exa... -
- matz (Yukihiro Matsumoto) wrote:
>
> ...
A compromise does not sound like something that should be added to the language.
`{@1 * @2}` could easily be written as `{|a, b| a * b}` some chars more, yes. But IMHO more readable. I don... -
05:51 AM Misc #15459: DevelopersMeeting before/after RubyKaigi2019
- [Feature #15553] `Addrinfo.getaddrinfo` supports timeout
* I would like to have your opinion for patch2.diff -
- I updated the patch.
* get rid of Timeout from ext/socket/lib/socket.rb. If getaddrinfo_a() is not available, timeout is ignored. - 12:28 AM Revision 9f05891c (git): * 2019-03-24
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67341 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:28 AM Revision 831e93d9 (git): Update power_assert to 1.1.4
- This update fixes a failure of test-bundled-gems, so we revert r67275.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67340 b2dd03c8-39d4-4d8f-98ff-823fe69b080e