Activity
From 03/13/2019 to 03/19/2019
03/19/2019
-
11:14 PM Bug #15708: Implicit numbered argument decomposes an array
- Sorry, your inconvenience experience. We have an issue of bugs.ruby-lang.org. I fixed it on this morning(JST).
I removed duplicated issues and copy from them.
@nobu said:
Intended.
It equals
```ruby
a.map{|x,| x} # => [1, 2, ... -
11:57 AM Bug #15708: Implicit numbered argument decomposes an array
- > Honestly, I'm not a fan of the behavior, though.
I think it comes down a lot to personal preferences. For example I actually
like being able to use @NUMBER_HERE :) - although in "production" code,
I may use the oldschool variant s... -
11:26 AM Bug #15708: Implicit numbered argument decomposes an array
- Yes, it is actually intended. `@1` is equivalent to `|at1, at2, at3, ...|`'s `at1`.
```
a = [1, 2, 3]
a.map{|x,| x} # => [1, 2, 3]
a.map{@1} # => [1, 2, 3]
a = [[1], [2], [3]]
a.map{|x,| x} # => [1, 2, 3]
a.map{@1} # => [1, 2... -
11:08 AM Bug #15708 (Rejected): Implicit numbered argument decomposes an array
- In the following, `@1` refers to the entire item iterated:
```ruby
a = [1, 2, 3]
a.map{|x| x} # => [1, 2, 3]
a.map{@1} # => [1, 2, 3]
```
whereas in the following, `@1` refers to the first item achieved by decomposing the item ... -
11:05 PM Bug #15712: DateTime#=== should be defined and compare date and time instead of just the date
- @localhostdotdev
I fixed an issue of our tracker. I deleted 15713-15716. -
05:00 PM Bug #15712 (Closed): DateTime#=== should be defined and compare date and time instead of just the date
- DateTime#=== is inherited from Date#=== without overwriting the #=== method, this leads to DateTime#=== comparing only dates and ignore the time part.
```
DateTime.new(2001, 2, 3) === DateTime.new(2001, 2, 3, 12)
=> false
```
I ... -
05:42 PM Feature #15667: Introduce malloc_trim(0) in full gc cycles
- As a maintainer of the quoted glibc code I'd be really interested in the results of this work. Please share when ready.
-
05:12 PM Bug #15711: Remove use of _id2ref from DRb
- Ok, unfortunately I'm not sure that WeakMap will work for this purpose. It works based on identity (which would not work in implementations where Fixnum-ranged Integers are not guaranteed to be the same object every time), attempts to at...
-
04:47 PM Bug #15711: Remove use of _id2ref from DRb
- I added a mutex and pushed the base implementation as a PR here: https://github.com/ruby/ruby/pull/2102
I can try to work up patches for the other two implementations, but they'll need some additional work within MRI to support. -
04:31 PM Bug #15711: Remove use of _id2ref from DRb
- We almost had agreement on adding a reference queue here: https://bugs.ruby-lang.org/issues/6309
-
03:56 PM Bug #15711 (Closed): Remove use of _id2ref from DRb
- This issue relates to https://bugs.ruby-lang.org/issues/15408
DRb uses `_idref` internally to implement a weak map, and this issue seeks to replace that code with an implementation that does not use `_id2ref`.
We will be deprecatin... -
04:02 PM Feature #15408: Deprecate ObjectSpace._id2ref
- Sorry for the delay folks, I was intermittently blocked from accessing bugs.ruby-lang.org, but things are working now!
I'll move forward with fixing DRb using the logic JRuby ships in https://bugs.ruby-lang.org/issues/15711.
Remain... -
03:25 PM Feature #15626: Manual Compaction for MRI's GC (`GC.compact`)
- We have already discussed in https://bugs.ruby-lang.org/issues/15408 the deprecation and eventual removal of _id2ref, so perhaps we can move these things together.
The additional hashing logic to maintain the Object-to-ID maps will ad... -
09:33 AM Feature #15626: Manual Compaction for MRI's GC (`GC.compact`)
- nateberkopec (Nate Berkopec) wrote:
> > Can we introduce it just after every major (full) gc?
> ...
As an experimental feature shouldn't it be disabled by default and only enabled via something like env variable?
But I do agree that... -
01:10 PM Bug #15672: Lambda implicit arguments, differences between lambda {} and -> {} specifications
- Hanmac (Hans Mackowiak) wrote:
> Duplicate of #15620
It is irrelevant. -
09:40 AM Bug #15623: Ruby 2.6.1 Segmentation Fault in on Phusion Passenger server boot in dev
- Another crash after updating to 2.6.2
ruby 2.6.2p47 (2019-03-13 revision 67232) [x86_64-darwin18]
Not sure they are related to the same issue
```
Process: ruby [42621]
Path: /Users/USER/*/ruby
Ident... -
07:03 AM Bug #15620: Block argument usage affects lambda semantic
- @nobu should this one be closed too?
-
06:23 AM Revision afa1505c (git): parse.y: removed redundant number_arg parser event
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67307 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
06:01 AM Bug #15673 (Closed): Number args + Ripper
- Applied in changeset trunk|r67306.
----------
parse.y: fix var_ref of numbered param in ripper
* parse.y (string_dvar, user_variable): register numbered
parameter in ripper for var_ref.
[ruby-core:91867] [Bug #15673] -
06:01 AM Revision fa66569a (git): parse.y: fix var_ref of numbered param in ripper
- * parse.y (string_dvar, user_variable): register numbered
parameter in ripper for var_ref.
[ruby-core:91867] [Bug #15673]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67306 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:35 AM Revision e39f7e64 (git): parse.y: fix segv with Ripper#yydebug
- * parse.y (parser_token_value_print): in ripper, ID values are
wrapped in NODE_RIPPER at set_yylval_name(), so print the Symbol
wrapped together.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67305 b2dd03c8-39d4-4d8f-98ff-823fe6... -
02:25 AM Revision ae5d9a76 (git): Added Ripper#debug_output
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67304 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:39 AM Bug #15675 (Closed): "fatal - exception reentered" error after installing Ruby 2.5.5
- At first I have 2.5.3 and 2.6.0 which are working fine. Then I started to encounter errors in Heroku after deployment, I tried installing Ruby 2.5.5 since that is the supported version in Heroku in order to replicate the problem. After t...
03/18/2019
-
10:48 PM Feature #4475: default variable name for parameter
- Is there a reason to do this other than to save some typing? I'm not sure we've proposed any terribly real-world cases here where this made code better.
I feel like we already have some single-character patterns around blocks with one... -
05:12 PM Feature #4475: default variable name for parameter
- I also dislike the use of `@` for this. It looks very weird and evokes strong references to instance variables in my mind. I'm not sure which characters exactly are an option, but I think we should avoid the use of `@`. Will something li...
-
03:43 PM Feature #4475: default variable name for parameter
- Would it be possible to make this more inline with other "magic" variables? Such as $1 and $2 for regex. Maybe $blockarg1 and $blockarg2?
-
11:42 AM Feature #4475: default variable name for parameter
- I think @1 @2 is ok, syntax-wise; it reminds me of $1 $2 for regex matching.
The main two advantages I see is that it is short to type; and also easy
to remember.
There is only one thing that I would like to add and this came from... -
10:12 PM Feature #9758: Allow setting SSLContext#extra_chain_cert in Net::HTTP
- I would also love to know about this. I'm running into an issue right now where I'm trying to use ruby (specifically with rest-client, but it's just a wrapper around Net::HTTP) to call out to an API with a client certificate and need a c...
-
08:51 PM Feature #15626: Manual Compaction for MRI's GC (`GC.compact`)
- > Can we introduce it just after every major (full) gc?
I agree. If the necessary steps are Full GC -> Update -> Move -> Full GC, then it would be faster to just compact automatically after a full GC which is already occurring. I unde... -
08:24 PM Feature #15632: Dynamic method references
- Okay, in that case this can be closed.
-
07:33 PM Bug #15673: Number args + Ripper
- I think I found it. I've attached a patch file. Please forgive me if I'm doing this wrong, this is my first contribution.
-
06:28 PM Bug #15673: Number args + Ripper
- Some more investigation yields that `compile_error` is called with:
identifier false is not valid to get -
06:20 PM Bug #15673: Number args + Ripper
- To be clear, I mean that:
``` ruby
require 'ripper'; Ripper.new('[1, 2, 3].map { @1 * 2 }').tap(&:parse).error?
```
returns true
-
02:13 PM Bug #15673 (Closed): Number args + Ripper
- Hi there -
Love the new number args for blocks. When I run
``` ruby
[1, 2, 3].map { @1 * 2 }
```
everything works. However, when I run:
```ruby
require 'ripper'; Ripper.new('[1, 2, 3].map { @1 * 2 }').parse
```
it retu... -
07:22 PM Feature #14183: "Real" keyword argument
- mame,
Thanks for your continued work on this.
I still agree that for methods that accept keyword arguments, we should make changes to avoid the problems that currently exist for keyword arguments.
I still believe that breaking a... -
09:21 AM Feature #14183: "Real" keyword argument
- Sorry for leaving this ticket. Matz, akr and I talked about this issue several times since the last year, and we have never reached a perfect solution. But I try to re-summarize the problem, current proposal, and migration path.
... - 06:30 PM Revision f86e5dae (git): Applied security patches for RubyGems
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@67303 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
05:45 PM Revision 92b0331b (git): Use designated initializers for compile_status
- to make it easier to understand what values are grouped.
Just cosmetic changes.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67302 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
05:28 PM Revision 8b1241d8 (git): Use alloca for stack_size_for_pos as well
- to eliminate necessity of error check and `free`
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67301 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
05:20 PM Revision a75ae6fa (git): Use alloca again instead of malloc and free
- by changing interface of `mjit_copy_cache_from_main_thread`.
This is also fixing deadlock introduced by r67299.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67300 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
04:32 PM Revision 4d426e28 (git): Resurrect r67287 and r67288
- I noticed that r67287 was illegal because memory allocated by `alloca`
was used after the stack is expired.
So I just replaced that with `malloc` and `free` for now.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67299 b2dd03c8-39d4... - 04:14 PM Revision 08e9c58d (git): * 2019-03-19
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67298 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
04:14 PM Revision 78e87b7d (git): Revert "Eliminate mjit_copy_job_t reference from mjit_worker"
- This reverts commit ba51ae0109ee1d1fa7ca90b43da115ea68d7214a.
CI is failing again...
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67297 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:49 PM Bug #15674 (Closed): Regression: ObjectSpace.allocation_sourceline produces the wrong location for allocations, it shows the end of the method instead of the line where the object was created
- Originally I opened this up as an issue in memory profiler https://github.com/SamSaffron/memory_profiler/issues/67, however I was able to isolate the issue to just Ruby 2.6.
ObjectSpace.allocation_sourceline is reporting the line wher... -
02:01 PM Revision ba51ae01 (git): Eliminate mjit_copy_job_t reference from mjit_worker
- Take 2 of r67287.
For some reasons, passing pointer of pointer on stack to a function
and assigning an addresse to a pointer dereferenced from the pointer
seems not working on mswin.
So I achieved to return multiple values by returning... -
12:48 PM Bug #15672 (Closed): Lambda implicit arguments, differences between lambda {} and -> {} specifications
- Applied in changeset trunk|r67295.
----------
parse.y: numbered parameter in lambda
* parse.y (lambda): support numbered parameters, only when no
argument list including empty parentheses, like empty vertical
bars. [ruby-core:9185... -
11:51 AM Bug #15672: Lambda implicit arguments, differences between lambda {} and -> {} specifications
- Koichi said it will be fixed. :)
(I guess this was never intentional, thus a bug.) -
06:12 AM Bug #15672: Lambda implicit arguments, differences between lambda {} and -> {} specifications
- Duplicate of #15620
-
03:34 AM Bug #15672 (Closed): Lambda implicit arguments, differences between lambda {} and -> {} specifications
- Hi
Are the following differences intentional?
```
$ ruby -v
ruby 2.7.0dev (2019-03-18 trunk 67291) [x86_64-darwin18]
```
```
$ cat ptn1.rb
a = -> { p @1 }
a.call(1)
$ ruby ptn1.rb
Traceback (most recent call last):
... -
12:48 PM Revision 964bbc16 (git): parse.y: numbered parameter in lambda
- * parse.y (lambda): support numbered parameters, only when no
argument list including empty parentheses, like empty vertical
bars. [ruby-core:91859] [Bug #15672]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67295 b2dd03c8-39d4... -
12:07 PM Revision f9e5b8d0 (git): Revert "Try disabling Travis cache on darwin"
- This reverts commit 6b136a044205f6e6b66df68cd2da2a9c3e952a7d.
This does not seem to work:
https://travis-ci.org/ruby/ruby/jobs/507646193#L2478
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67294 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
11:46 AM Revision c1dce923 (git): Merge https://github.com/rubygems/rubygems/pull/2684
- to make CI stable. See the PR for details.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67293 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
06:42 AM Revision 17018d4c (git): parse.y: continue after invalid name
- * parse.y (set_yylval_noname): continue after an invalid global,
instance, class variable name, without "unexpected end-of-file"
error.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67292 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
05:12 AM Misc #15459: DevelopersMeeting before/after RubyKaigi2019
- Schedule on 4/17 (Wed)
* 12:00- door open
* 13:00-18:30 meeting w/Matz.
* topics is welcome. please comment on this issue.
* 18:30 close
There are several pre-RubyKaigi parties. pls check them.
-
04:52 AM Misc #15459: DevelopersMeeting before/after RubyKaigi2019
- Further note:
"RubyKaigi 2019 After Hack by Fukuoka.rb!!" https://fukuokarb.connpass.com/event/124406/ is open event.
Anyone can attend! Enjoy.
Thanks,
Koichi -
04:49 AM Misc #15459: DevelopersMeeting before/after RubyKaigi2019
- "After RubyKaigi hack meeting" is merged with "RubyKaigi 2019 After Hack by Fukuoka.rb!!"
https://fukuokarb.connpass.com/event/124406/
Please sign-up this party if you want to attend it even if you already sign-up on doorkeeper.
Det... -
01:52 AM Revision 908b5301 (git): Revert "Request inline cache values from mjit_compile"
- This reverts commit 4161674b2fbea6bdd01783ac5d3b39d88db22972.
Revert "Eliminate mjit_copy_job_t reference from mjit_worker"
This reverts commit d86a1aa045959dfbf5cd472eae0d043180259727.
Reverting them because of CI failures
git-svn-i... -
01:42 AM Revision ba03222d (git): Pack rb_iseq_constant_body from 296 to 288 bytes
- [Fix GH-2099]
From: Lourens Naudé <lourens@bearmetal.eu>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67290 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:18 AM Revision d0e25ed2 (git): parse.y: parser_numbered_param
- * parse.y (parser_numbered_param): hoisted out the contextual
check for numbered parameters.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67289 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
03/17/2019
-
08:56 PM Bug #15662 (Closed): Fix CSV delegation to missing StringIO
- Thanks!
-
09:13 AM Bug #15662: Fix CSV delegation to missing StringIO
- We resolved it in https://github.com/ruby/csv/pull/80. Thank you @kou 🙇♂️!
-
06:29 PM Revision 4161674b (git): Request inline cache values from mjit_compile
- rather than preparing beforehand.
By having this change, implementing inlining by calling
`mjit_copy_cache_from_main_thread` for inlined methods was made
possible.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67288 b2dd03c8-39d4-4... -
06:07 PM Revision d86a1aa0 (git): Eliminate mjit_copy_job_t reference from mjit_worker
- and make `copy_cache_from_main_thread` easier to use.
For implementing inlining later, I'll use `copy_cache_from_main_thread`
inside `mjit_compile`.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67287 b2dd03c8-39d4-4d8f-98ff-823fe6... -
05:12 PM Revision 3fc26f60 (git): Drop rb_mjit_unit from mjit_copy_job
- and guard iseq from GC by marking iseq in mjit_copy_job.
This is a refactoring for implementing inlining later and
should not be fixing or introducing any bugs.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67286 b2dd03c8-39d4-4d8f... -
04:35 PM Revision cebc6407 (git): Fix a typo [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67285 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 04:32 PM Revision 5bd10603 (git): * 2019-03-18
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67284 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
04:32 PM Revision dfb9907c (git): Fix typos [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67283 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:51 PM Revision a72bc2e7 (git): Fix a typo [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67282 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
06:20 AM Revision 6b136a04 (git): Try disabling Travis cache on darwin
- to check if it resolves "Permission denied" problem.
https://travis-ci.org/ruby/ruby/jobs/507381339
https://travis-ci.org/ruby/ruby/jobs/507392198
TBH I'm not exactly sure why it happens, but I don't have infinite time
to understand thi... -
05:32 AM Revision d4b6198d (git): Roughly increase Azure Pipelines fetch depth
- because --depth=1 may randomly break checkout:
https://dev.azure.com/rubylang/ruby/_build/results?buildId=208&view=logs&jobId=7ded14dc-7a77-59da-f40a-71e137ad96c0&taskId=2045950f-1dcd-54a4-4c23-fae2521239c1&lineStart=1554&lineEnd=1555&co... -
05:28 AM Revision 46f5eb5b (git): Update NEWS for --jit option changes [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67279 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
05:21 AM Feature #4475 (Closed): default variable name for parameter
- Applied in changeset trunk|r67278.
----------
Numbered parameters [Feature #4475] -
05:21 AM Revision 12acc751 (git): Numbered parameters [Feature #4475]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67278 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
05:13 AM Revision 0fa4a6a6 (git): Change defaults of --jit options
- * --jit-min-calls: 5 -> 10000
--jit-min-calls=5 obviously can compile non hotspot. This was not a
problem for MJIT-benchmarks and Optcarrot because the former has very
few hot optimiziable methods and the latter is likely to trigger
com... -
04:13 AM Revision 407cd5cc (git): Drop invalid trailing comma in JSON object
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67276 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
03/16/2019
-
10:11 PM Bug #15671 (Third Party's Issue): Segfault
- We hit a segfault in wpscan (https://github.com/wpscanteam/wpscan) using docker (https://hub.docker.com/r/wpscanteam/wpscan) with alpine linux with ruby 2.6.2.
The command line used:
`docker run -it --rm wpscanteam/wpscan --url https... -
04:56 PM Bug #15490: socket.rb - recurring segmentation faults
- We're seeing this issue as well, on Ruby 2.6.1. For us, it occurs towards the end of a fairly large test suite when running one of our legacy Cucumber tests. When we only run the Cucumber section of our test suite (not the whole thing) t...
-
04:53 PM Revision 7fe77cbc (git): Ignore test-bundled-gems failure on CI for now
- ktsj-san recognizes this issue and it's intentionally left failing now.
As failure notification of this task is NOT indicating ruby is broken,
let's stop notifying the failure fo rnow.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@6... - 04:26 PM Revision 5b0bcb0b (git): * 2019-03-17
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67274 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
04:26 PM Revision 46a3b440 (git): Do not build Azure Pipelines on Pull Request
- For 2 reasons:
* bundled_gems tend to be left broken (like now)
* We don't want Slack notification for pull request and it can't be
disabled on Azure Pipelines
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67273 b2dd03c8-39d4-4d8... -
09:52 AM Feature #11741: Migrate Ruby to Git from Subversion
- http://15news.ir
http://9news.ir
http://afexo.ir
http://aloofile.ir
http://aminpayam.ir
http://andishmes.ir
http://arikehvip.ir
http://azargo.ir
http://bassirat.ir
http://belton.ir
http://birligh.ir
http://brmm.ir
http://chag... -
04:11 AM Revision 8ce6748f (git): Notify AppVeyor results to multiple channels
- and simplified config by using dedicated webhook URL.
Sadly AppVeyor YAML does not support alias and so we need to copy-paste
the request body.
memo:
https://slack-files2.s3-us-west-2.amazonaws.com/bot_icons/2018-02-10/314363543719_48.p... -
04:00 AM Bug #15670 (Closed): Ripper treats :"sym" as xstring
- Applied in changeset trunk|r67270.
----------
dsym should be treated as string [ruby-core:91852] [Bug #15670] -
03:54 AM Bug #15670 (Closed): Ripper treats :"sym" as xstring
- Ripperで `:"sym"` をパースするとxstringとして扱われるようになっていますが、
`{"sym": ...}` と同様にstringとして扱われるべきだと思います。
~~~
$ ruby -rripper -e '_, (_, _, s) = Ripper.sexp_raw(%q{:"sym"}); p s'
[:dyna_symbol, [:xstring_add, [:xstring_new], [:@tstring_content, ... - 04:00 AM Revision f044cc10 (git): * 2019-03-16
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67271 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
04:00 AM Revision 7006fdec (git): dsym should be treated as string [ruby-core:91852] [Bug #15670]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67270 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
03/15/2019
-
07:50 PM Bug #15637: Backport RubyGems 3.0.3/2.7.9
- Are there plans to backport the Rubygems security patches to Ruby 2.3? Ruby 2.3 is still in security maintenance status until the end of the month, so I think this would qualify, but I'm not sure.
-
06:37 PM Bug #15087: Segmentation fault with splat and block
- **Hurray**! Confirmed that this no longer crashes and works as expected on _2.5.4_ and _2.6.2_
-
04:04 PM Bug #15669 (Third Party's Issue): This issue was marked as resolved in 2.5.5 release note but I'm still experiencing it
- Users/richardsondackam/.rvm/rubies/ruby-2.5.5/lib/ruby/2.5.0/timeout.rb:86: [BUG] Segmentation fault at 0x00000001085b8a52
ruby 2.5.5p157 (2019-03-15 revision 67260) [x86_64-darwin18]
-- Crash Report log information -----------------... -
01:25 PM Revision e4c184c6 (git): Increase the number of curl retries
- Because retrying 5 times failed.
https://ci.appveyor.com/project/ruby/ruby/builds/23063048/job/k9lykaagfaex74gg
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67269 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:39 PM Feature #15477: Proc#arity returns -1 for composed lambda Procs of known arguments
- For what it is worth, this appears to be an issue when dealing with curried procs as well.
``` ruby
curried_proc = ->(a, b) { a + b }.curry # => <Proc:0x00007fa7698e7700 (lambda)>
first = curried_proc.(1) # => <Proc:0x00007fa76991a0... -
11:32 AM Revision b33a168e (git): bump up teeny version to 2.5.6
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@67268 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
10:21 AM Bug #15384: ssl_certs are duplicated in RubyGems and Bundler
- There is even `Gem::Request.get_cert_files`
-
10:15 AM Bug #15384: ssl_certs are duplicated in RubyGems and Bundler
- vo.x (Vit Ondruch) wrote:
> Is the patch correct? Will it work when RubyGems are updated via `gem update --system`? I have not tested it, just wondering ...
`Gem::RUBYGEMS_DIR` should be probably used to initialize the `rubygems_cert... -
10:03 AM Bug #15384: ssl_certs are duplicated in RubyGems and Bundler
- Is the patch correct? Will it work when RubyGems are updated via `gem update --system`? I have not tested it, just wondering ...
Moreover, I don't understand why Bundler does not use RubyGems facilities for such functionality (but I u... -
07:09 AM Feature #15668: stdlib: Date - Time should return the difference in days
- The error message could indeed be improved.
As for the functionality, I think matz may have to decide whether this
may fit to duck typing or not. In my opinion the distinction between
a "date" and a "time" is a bit arbitrary when we... -
01:41 AM Feature #15668 (Open): stdlib: Date - Time should return the difference in days
- Hi at the ruby/stdlib,
Computing with times and dates is very complicated.
There are so many pitfalls lurking there.
I stumbled about a seemingly simple computation,
involving Date and Time
try:
Date.today - Time.now
=> Type... -
06:54 AM Feature #14759: [PATCH] set M_ARENA_MAX for glibc malloc
- Hongli Lai's [What causes Ruby memory bloat?](https://www.joyfulbikeshedding.com/blog/2019-03-14-what-causes-ruby-memory-bloat.html) post is most-interesting indeed.
That article has given rise to a new issue, opened by Sam Saffron, [... -
06:50 AM Feature #14718: Use jemalloc by default?
- Outstanding research by Hongli Lai, and superbly presented in a post & video that all of us can easily digest.
Sam's new [15667](https://bugs.ruby-lang.org/issues/15667) issue will be very interesting. I tend to agree, if all goes wel... - 05:19 AM Revision d4f7fac6 (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67267 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
05:19 AM Revision c36a6f97 (git): node.h: introduce nd_brace to determine if a hash literal is a keyword
- NODE_HASH#nd_brace is a flag that is 1 for `foo({ k: 1 })` and 0 for
`foo(k: 1)`.
nd_alen had been abused for the flag (and the implementation is
completely the same), but an explicit name is better to read.
git-svn-id: svn+ssh://ci.rub... -
01:19 AM Revision 560bb32f (git): NEWS: adjust indents and escape brackets not to be labeled lists
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67265 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:44 AM Revision 3134b20a (git): Show the source line at an invalid class/instance variable
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67264 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
03/14/2019
-
11:50 PM Feature #15667: Introduce malloc_trim(0) in full gc cycles
- Relevant code in glibc
https://github.com/bminor/glibc/blob/c2d8f0b704c2b828bcd8d517a2376c0240c73c09/malloc/malloc.c#L4448-L4539
https://github.com/bminor/glibc/blob/c2d8f0b704c2b828bcd8d517a2376c0240c73c09/malloc/malloc.c#L4805
-
08:34 PM Feature #15667 (Closed): Introduce malloc_trim(0) in full gc cycles
- Per Hongli's excellent article it looks like malloc_trim can help tremendously with memory bloat issues.
https://www.joyfulbikeshedding.com/blog/2019-03-14-what-causes-ruby-memory-bloat.html#a-magic-trick-trimming
I would like... -
10:51 PM Revision f3210924 (git): merge revision(s) 67261:
- tool/make-snapshot: Use 6-spaces indent for SIZE and digests
to align with release note markdown.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@67263 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 10:43 PM Revision bf4bcaf0 (git): * 2019-03-15
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67262 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
10:43 PM Revision 9e7f197c (git): tool/make-snapshot: Use 6-spaces indent for SIZE and digests
- to align with release note markdown.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67261 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
10:24 PM Bug #14852: please backport thread sync fixes to 2.5
- r62934 was already backported into ruby_2_5 at r66912.
r63309 was already backported into ruby_2_5 at r67259.
-
10:21 PM Revision 703d9f61 (git): merge revision(s) 63309:
- thread_sync.c (condvar_ptr): reset fork_gen after forking
Otherwise the condition variable waiter list will always
be empty, which is wrong :x
[Bug #14725] [Bug #14634]
git-svn-id: svn+ssh://ci.ruby-lang.org/ru... -
10:16 PM Revision dec6bb85 (git): bump up teeny version to 2.5.5
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@67258 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
08:42 PM Bug #15661: Disallow concurrent Dir.chdir with block
- @nobu I actually considered that my first preference, except for the introduction of a new global lock.
I worry about suddenly introducing deadlocks into someone's code, though that code would have to be doing some locking as well as ... -
05:09 AM Bug #15661: Disallow concurrent Dir.chdir with block
- Why not blocking until another block terminates?
-
08:35 PM Feature #14718: Use jemalloc by default?
- I created https://bugs.ruby-lang.org/issues/15667 to track malloc_trim, please post any results you have regarding to production performance there
-
08:02 PM Feature #14718: Use jemalloc by default?
- Came here to find out if indeed ```malloc_trim()``` would be integrated into the garbage collector. If Hongli's findings are true, this is indeed a game changer. Looking forward to seeing the bloat in my apps disappear!
-
04:52 PM Feature #14718: Use jemalloc by default?
- Does Hongli Lai's article _What causes Ruby memory bloat?_ shed any potential light here?
https://www.joyfulbikeshedding.com/blog/2019-03-14-what-causes-ruby-memory-bloat.html#a-magic-trick-trimming
After investigation, he discovered... -
05:25 PM Feature #15438: Threads can't switch faster than TIME_QUANTUM_(NSEC|USEC|MSEC)
- > -5 would still mean "the highest priority", yes, but then e.g. -4 or -3 which starts to mean "high but not highest priority" on MRI would have a different meaning on other implementations, which I believe is undesirable.
-5 means "g... -
04:56 PM Feature #15438: Threads can't switch faster than TIME_QUANTUM_(NSEC|USEC|MSEC)
- > It does not have to know. It will use, say -5 because it is meaningful on MRI. The value is then clamped to -3 by e.g. JRuby where -5 is not meaningful.
-5 would still mean "the highest priority", yes, but then e.g. -4 or -3 which ... -
05:21 PM Bug #15582: default/bundler-1.17.2.gemspec has no file list
- Hi @hsbt!
I assumed this fix would also fix the incorrect file list for the etc gem's gemspec but I didn't try it to make sure and it looks like it didn't fix it actually. On the default ruby 2.6.2 release, the file list is `["etc.so... -
02:40 PM Bug #14725: fatal: No live threads left. Deadlock? since Revision 63215
- r63215 is backported to ruby_2_5 in r66912 but its bug fix r63309 is not backported to ruby_2_5 yet. I confirmed that https://github.com/sorah/repro254stuck stucks with ruby_2_5 branch (r67242) and it's fixed by cherry-picking r63309.
@... -
01:47 PM Revision 4d6e2029 (git): Skip Bundler's test made fail by r67226
- Possible fix would be https://github.com/bundler/bundler/pull/7038,
but Ruby script ending with `^~~` could be wrongly stripped by that?
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67257 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
11:49 AM Bug #15666 (Closed): Backport r67247 (Guard out the test when it is run under root permission)
- This is a ticket for backport management.
r67247 fixes an issue of the test under root permission. -
09:05 AM Bug #10856 (Closed): Splat with empty keyword args gives unexpected results
- Applied in changeset trunk|r67256.
----------
compile.c: fix the corner case of rest and keyword arguments
See https://bugs.ruby-lang.org/issues/10856#note-20 . [Bug #10856] -
08:45 AM Bug #10856: Splat with empty keyword args gives unexpected results
- Another presentation of the bug:
```
def foo; end
foo(*[], {}) #=> does not raise an exception in 2.6
``` -
05:06 AM Bug #10856 (Assigned): Splat with empty keyword args gives unexpected results
- marcandre (Marc-Andre Lafortune) wrote:
> This is not actually fixed.
> ...
This is not completely fixed yet:
```
$ ruby -v
ruby 2.6.0p0 (2018-12-25 revision 66547) [x86_64-linux]
$ ruby -e 'def foo; end; options = {}; args = [];... -
09:04 AM Revision 3db2041f (git): compile.c: fix the corner case of rest and keyword arguments
- See https://bugs.ruby-lang.org/issues/10856#note-20 . [Bug #10856]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67256 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
08:43 AM Revision 146bb252 (git): compile.c (setup_args): process arguments forward
- For unknown reason, setup_args processed the arguments from the last to
the first. This is not only difficult to read, but also inefficient in
some cases. For example, the arguments of `foo(*a1, *a2, *a3)` was
compiled like `a1.dup << ... -
08:13 AM Revision 9800fc26 (git): parse.y: no punctuation instance/class variables
- * parse.y (parse_atmark): exclude punctuation follows @ marks,
whereas it is inclusive after $ mark as some punctuation global
variables exist.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67254 b2dd03c8-39d4-4d8f-98ff-823fe69b... -
07:30 AM Bug #15649: Dir.glob regression with braces and Windows drive letters
- Seeing the same here. Seems like its the braces that are broken on Windows in Ruby 2.6. Rails autoloading feature combines a number of glob patterns into a string for reason, instead of passing in an array.
https://github.com/rails/r... -
06:45 AM Feature #14145: Proposal: Better Method#inspect
- Eregon (Benoit Daloze) wrote:
> My understanding is `#inspect` shows useful information for debugging, so then the source location is very useful, and gives me more than the parameters (e.g., I can find the code, documentation, etc from... - 06:43 AM Revision 277af37b (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67253 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
06:43 AM Revision 4c41dc89 (git): compile.c: factor out "compile_args" from "compile_array"
- compile_array function had three usages: array literal, hash literal,
and method arguments. I think the third is completely different than the
first and second. For example, method arguments and popped are
meaningless; keywords_ptr and ... -
05:57 AM Revision 9c077bbe (git): parse.y: show invalid global variable line
- * parse.y (parse_gvar): show the source line erred by invalid
global variable, and indicate the variable including the wrong
punctuation.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67251 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
05:32 AM Revision ccc933d4 (git): Hoisted out ruby_show_error_line
- * parse.y (ruby_show_error_line): hoisted out from parser_yyerror.
* parse.y (regx_options): revert r67226 and show the error line
separately.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67250 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:03 AM Feature #15665 (Closed): Cannot compile socket extension on Mojave
- The `mkmf.log` is reporting that it cannot find `netinet6/in6.h`. I guess that previously it’s finding it in `/usr/include`, but as we all know Apple removed that path since Mojave. On my machine the current path is:
```
/Application... -
02:48 AM Bug #15384: ssl_certs are duplicated in RubyGems and Bundler
- I made a patch that unifies both certificates. I propose it to bundler upstream.
-
02:18 AM Revision 86c5806c (git): More initializations of YYLTYPE
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67249 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 01:04 AM Revision e20aa14a (git): * 2019-03-14
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67248 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:04 AM Revision 6a860ea0 (git): Guard out the test when it is run under root permission
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67247 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:31 AM Bug #15664 (Closed): File.executable returns incorrect results in Windows 10
- Calling File.executable? <path> in Windows 10 return false for a file with execute permissions set.
03/13/2019
-
11:22 PM Feature #15438: Threads can't switch faster than TIME_QUANTUM_(NSEC|USEC|MSEC)
- > I think it's important, otherwise how is Ruby code supposed to know what are the limits and which value it can use for Thread#priority= ?
It does not have to know. It will use, say -5 because it is meaningful on MRI. The value is th... -
08:10 PM Feature #15438: Threads can't switch faster than TIME_QUANTUM_(NSEC|USEC|MSEC)
- > the semantic of 'priority' right now is very platform-specific anyways
The specific semantics maybe, but the range is platform-agnostic and has always been -3..3 so far.
> ...
I think it's important, otherwise how is Ruby code s... -
05:05 PM Feature #15438: Threads can't switch faster than TIME_QUANTUM_(NSEC|USEC|MSEC)
- `RUBY_THREAD_PRIORITY_MIN` is changed to give the developer the choice to make some threads really low priority, at the cost of switching overhead. Unless I'm mistaken, the semantic of 'priority' right now is very platform-specific anywa...
-
04:40 PM Feature #15438: Threads can't switch faster than TIME_QUANTUM_(NSEC|USEC|MSEC)
- Why is RUBY_THREAD_PRIORITY_MIN changed? This should be discussed in this thread.
Other implementations have to follow this change (e.g. TruffleRuby & JRuby already handle negative priorities AFAIK),
so we need a good spec to ensure ... -
09:55 PM Revision a3cbff05 (git): bump up teeny version to 2.6.3
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_6@67246 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
09:49 PM Feature #15663: Documenting autoload semantics
- May explain why matz wants to remove autoload in the long run. :)
-
06:25 PM Feature #15663 (Open): Documenting autoload semantics
- The semantics of autoload are extremely complicated.
As far as I can see, they are unfortunately not documented.
ruby/spec tries to test [many aspects](https://github.com/ruby/spec/blob/master/core/module/autoload_spec.rb) of it, `... -
08:21 PM Feature #14145: Proposal: Better Method#inspect
- My understanding is `#inspect` shows useful information for debugging, so then the source location is very useful, and gives me more than the parameters (e.g., I can find the code, documentation, etc from a file and line).
I'm not aga... -
08:13 PM Bug #15662 (Assigned): Fix CSV delegation to missing StringIO
- Could you use https://github.com/ruby/csv instead of ruby/ruby?
ruby/csv is the upstream repository. -
04:14 PM Bug #15662: Fix CSV delegation to missing StringIO
- I have opened a PR on GitHub's tracker with the changes: https://github.com/ruby/ruby/pull/2094
-
03:57 PM Bug #15662 (Closed): Fix CSV delegation to missing StringIO
- If you create a CSV from raw content like:
csv = CSV.new("h1,h2")
You'll get method missing when calling `csv.path` but still, get `true` when you call `csv.respond_to?(:path)`.
This tricks 3rd party libraries like carrier... -
03:52 PM Bug #15661: Disallow concurrent Dir.chdir with block
- I sort of agree with headius. I also can not really think of a possible and
deliberate use case for concurrent `Dir.chdir` with a block. Perhaps something
is missing (someone has a use case?) but otherwise I sort of agree with him
here. -
12:19 PM Bug #15661 (Closed): Disallow concurrent Dir.chdir with block
- `Dir.chdir` with a block should disallow concurrent use, since it will almost never produce the results a user expects.
In https://bugs.ruby-lang.org/issues/9785 calls for `Dir.chdir` to be made thread-safe were rejected because the u... -
03:12 PM Misc #15617: Any chance we can ship 2.5.4 sooner rather than later?
- I'm sorry the link in previous post was for Japanese.
English version is here.
https://www.ruby-lang.org/en/news/2019/03/13/ruby-2-5-4-released/ -
03:07 PM Misc #15617 (Closed): Any chance we can ship 2.5.4 sooner rather than later?
- Ruby 2.5.4 was released!
https://www.ruby-lang.org/ja/news/2019/03/13/ruby-2-5-4-released/
Thank you for your patience. -
01:21 PM Feature #15605: json library needs more frequent releases
- FWIW we did just get a json 2.2.0 release. The base problem stands, however.
- 01:44 AM Revision 0d6910df (git): * 2019-03-13
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67244 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:44 AM Revision 8415df61 (git): Remove unnecessary local variable
- newline is always "\n" when it is used.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67243 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:32 AM Bug #15648: Ripper::SCANNER_EVENTS に ignored_sp が含まれていない
- ruby_2_5 r67242 merged revision(s) 67200.
-
12:32 AM Revision 4fd07864 (git): merge revision(s) 67200: [Backport #15648]
- Add ignored_sp event
* ext/ripper/lib/ripper/lexer.rb (Ripper::Lexer): add ignored_sp
event which will be fired from Ripper::Lexer#on_heredoc_dedent
method. [ruby-core:91727] [Bug #15648]
git-svn-id: svn+ss... -
12:27 AM Bug #11472 (Rejected): Some default gems are not installed if GEM_HOME is set during Ruby installation
- I couldn't reproduce it.
```
~ > mkdir .gem_home
~ > set -x GEM_HOME ~/.gem_home
~ > rbenv install 2.5.0-dev
ruby-build: use openssl from homebrew
Cloning https://github.com/ruby/ruby.git...
Installing ruby-2.5.0-dev...
ruby-bu... -
12:21 AM Bug #15555: Dir.mktmpdir checks permissions and raise ArgumentError after yielding to block (ensure) & leaks allocated tempdir
- ruby_2_5 r67241 merged revision(s) 66909.
-
12:21 AM Revision 8fa641a6 (git): merge revision(s) 66909: [Backport #15555]
- tmpdir.rb: permission of user given directory
* lib/tmpdir.rb (Dir.mktmpdir): check if the permission of the
parent directory only when using the default temporary
directory, and no check against user given d... -
12:06 AM Bug #15520: [patch] configure should refuse to build with jemalloc when headers are missing
- ruby_2_5 r67240 merged revision(s) 66779.
-
12:06 AM Revision 7e157824 (git): merge revision(s) 66779: [Backport #15520]
- configure: refuse to build with jemalloc when header is missing
[ruby-core:90964] [Bug #15520]
Freom: Misty De Meo <mistydemeo@github.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@67240 b2dd03c8-39... -
12:03 AM Bug #15488: const_defined?("File::NULL") の挙動
- I have a little concern that this could be an imconpatibility issue. I will skip this change for the next teeny.