Activity
From 01/18/2019 to 01/24/2019
01/24/2019
-
08:04 PM Misc #15546: DevelopersMeeting20190207Japan
- * [Feature [#14344](/issues/14344)] refine at class level (kddeisz)
* Shorter refinement syntax proposed based on common use cases. Proposed either `refine_class` or `using` blocks for shorthand. What do you think?
* [Feature [#14680... -
02:08 PM Misc #15546: DevelopersMeeting20190207Japan
- * [Feature #11076] Enumerable method count_by
* A new name "tally" is proposed. "Tally" is: | → || → ||| → |||| → ~~||||~~. Looks good to me. What do you think? -
04:22 PM Bug #15561 (Rejected): What is Keto Tone? This result of keto tone
-
07:44 AM Bug #15561 (Rejected): What is Keto Tone? This result of keto tone
- What is Keto Tone? This result of keto tone is an enhancement that is exceptionally detailed to copy the fat consuming impacts of real ketosis for brief timeframes. Thusly, it permits you (in principle) to appreciate the advantages of ke...
-
- I have learnt the word "tally" in this thread. Thank you. It looks good to me, a non-native speaker. I have put this on the agenda of the next developers' meeting.
By the way, what is the precise semantics of the method?
Question... -
04:22 AM Feature #11076: Enumerable method count_by
- A histogram refers to counts of items in ranges of otherwise continuous data. But this function is more general than that, so I think `histogram` is too specific a term.
For this native English speaker, `tally` is the most precisely f... -
12:36 PM Feature #15538: Erb indenting / unindenting
- Most of "foo"-"bar" examples seem to be indented strangely. I guess you meant the following one for all like this ("f" and "b" start with the same column), right?
```
3: foo
bar
```
Now, you introduced 4 different new tokens ... -
12:04 PM Feature #15538: Erb indenting / unindenting
- Fixed the 2 -> 4 indentation in the bad example and added the "stop indenting" closing tag `|%>` which would be fine by me.
`<%|=` inside `<%|` would result in:
example code:
```
1
<%|- (2..3).each do |num| -%>
<%= num %>: <%... -
12:36 PM Revision 6375c68f (git): parse.y: function parser_mixed_error & parser_mixed_escape
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66919 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:21 PM Feature #15549: Enumerable#to_reader (or anything enumerable, Enumerator, lazy enums, enum_for results)
- I'm open for other names (#to_readable_stream perhaps?). Important is to acknowledge the validity of this use-case, as there are some constraints depending of where it is used.
For instance, responding to #read is a sufficient require... -
- * parse.y (parse_string): bail out when word-list meets end of
input not to show an extra "unexpected" error message after the
preceding error.
$ ruby -e "%w["
-e:1: unterminated string meets end of file
-e:1: synt... -
10:19 AM Feature #5653: "I strongly discourage the use of autoload in any standard libraries" (Re: autoload will be dead)
- Let me add a couple of things.
In case const_missing is discussed, these are the reasons why implementing autoloading based on const_missing doesn't fly (from memory):
1) The nesting is unknown.
2) Whether the missing constant was... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66917 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
06:06 AM Bug #15500: Behavior of require method in 2.5 is different from 2.4 and 2.6
- @hsbt
I've confirmed that Ruby 2.5 with r66867 loads bigdecimal installed by gem, correctly. -
01:00 AM Bug #15500: Behavior of require method in 2.5 is different from 2.4 and 2.6
- ruby_2_6 r66913 merged revision(s) 66867.
-
- Applied in changeset trunk|r66914.
----------
numeric.c: Fix negative step with float components
* numeric.c (ruby_float_step): fix negative step with float components.
* test/ruby/test_numeric.c (test_step_bug15537): add tests.
* te... -
- 05:30 AM Revision e6084020 (git): * 2019-01-24
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66916 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 05:30 AM Revision 4bcfccdd (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66915 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 05:30 AM Revision 161ece47 (git): numeric.c: Fix negative step with float components
- * numeric.c (ruby_float_step): fix negative step with float components.
* test/ruby/test_numeric.c (test_step_bug15537): add tests.
* test/ruby/test_range.c (test_step_bug15537): add tests.
[Bug #15537] [ruby-core:91101]
From: shuuji... -
- > Would it be possible to have logical ^^ in addition to the bitwise ^ for XOR?
I think it is possible, but we need a good reason to do so. Do you have any use case? -
- I think `!=` is easier to understand than `^^`.
-
- You can write `expr1 ^^ expr2` as `!expr1 != !expr2` in the current Ruby.
If both `expr1` and `expr2` are boolean, you can write `expr1 != expr2`.
I think `^^` can be useful for the case that both `expr1` and `expr2` are not boolean.... -
01:29 AM Feature #15560: Add support for read/write offsets.
- I can imagine it is useful for TCPSocket#write to accept only a part of a buffer crafted by somebody else. But I cannot think of any actual use case when #read is useful with that extension. Do you have one?
-
- Revert r58345 and r58371.
These changes break the behavior of default gems. Bug #13428 says
r58345 is reasonable because gemspec file is installed by `to_ruby_for_cache`
method. But I revert `to_ruby_for_ca...
01/23/2019
-
10:31 PM Bug #15469: Ruby2.6 included `bundler` does not handle specified `csv` gem.
- Should Bundler be a bundled gem (and not a default gem)?
I think this would help a lot, and allow uninstalling the preinstalled bundler if needed.
As mentioned above, it would also keep the Bundler implementation simple by being able... -
02:46 PM Bug #15469: Ruby2.6 included `bundler` does not handle specified `csv` gem.
- I have found out the root cause of this.
# Root Cause
* Bundler has become a built-in gem since Ruby 2.6.
* `$LOAD_PATH` required for bundler is moved from custom gem path ( e.g. `lib/ruby/gems/2.5.0/gems/bundler-1.17.2/lib` ) to ... -
09:47 PM Feature #15553: Addrinfo.getaddrinfo supports timeout
- > Why hrtime.h is included?
It's unnecessary. I'll remove it. -
- Why hrtime.h is included?
-
09:41 PM Bug #15468: Net::Protocol::BufferedIO#write raises NoMethodError when sending large multi-byte string
- Can we please fast track the release of this? It's breaking a ton of stuff.
Stepping back a little bit from this issue, I think we see a picture of Ruby where:
- Handling binary data can cause bugs like this (mismatch between binar... -
- It would be nice if read/write/send/recv/etc methods could accept an offset argument.
e.g.
```
socket = Socket.new(...)
buffer = String.b
socket.read(1024, buffer)
socket.read(1024, buffer, offset: buffer.bytesize)
```
Th... -
05:17 PM Feature #15559 (Open): Logical XOR (^^) operator
- Currently we have bitwise `&` and logical `&&`, and bitwise `|` and logical `||`. Would it be possible to have logical `^^` in addition to the bitwise `^` for XOR?
-
- shevegen (Robert A. Heiler) wrote:
> Personally I think that alias name would make sense. With a new alias the backwards
> ...
An alias would probably be best as otherwise it would cause breaking changes, and I think we'd rather avoid ... -
- Currently it does not on MRI:
```
ruby -e 'begin raise "foo"; rescue => e; c=e.exception "bar"; p c.backtrace; end'
nil
```
But it does on JRuby 9.2.5.0 and TruffleRuby 1.0.0-rc11:
```
truffleruby -e 'begin raise "foo"; rescue =... -
02:14 PM Bug #14634: Queue#push seems to crash after fork
- ruby_2_5 r66912 merged revision(s) 62934,63210,63215,63309.
-
- thread_sync.c: avoid reaching across stacks of dead threads
rb_ensure is insufficient cleanup for fork and we must
reinitialize all waitqueues in the child process.
Unfortunately this increases the footprint of ... -
- Hey! I am the author of Zeitwerk, let me do a quick followup here.
First and foremost, I'd like to be very straightforward saying that if Kernel#autoload is killed tomorrow, that would be fine with me. I'd shutdown Zeitwerk and Rails ... -
- It would be good to have a definite choice on this thread, I'll add it to the developer meeting (#15546).
I think at the last RubyKaigi during the Q/A, it was becoming clear removing #autoload would be a huge breaking change and there a... -
- rafaelfranca (Rafael França) wrote:
> @matz when taking in consideration deprecation/removal of autoload I'd like you to consider that Rails built and plan to use a thread-safe code loader based on `autoload`. See https://medium.com/@fx... -
10:24 AM Feature #15557: A new class that stores a condition and the previous receiver
- Normally I love sawa's suggestions. :)
However had, in this case, I am a little bit biased, which I may explain.
First, I should start here by agreeing with sawa in regards to the use case noted on top is quite common -
I use it m... -
10:21 AM Feature #15557: A new class that stores a condition and the previous receiver
- I played a bit with idea similar to @nobu's, with this syntax:
```ruby
then_if(condition) { action }
then_if(-> { condition }) { action }
```
Explanations:
* boolean vs callable: sometimes, static conditions are useful, sligtly r... -
- What about:
```ruby
foo = default_definition
.when(->(foo) {some_condition(foo)}) {|foo| some_method(foo)}
.when(->(foo) {another_condition(foo)}) {|foo| another_method(foo)}
```
-
09:15 AM Feature #15557 (Open): A new class that stores a condition and the previous receiver
- I often see code like this:
```ruby
foo = default_definition
foo = some_method(foo) if some_condition(foo)
foo = another_method(foo) if another_condition(foo)
...
```
It would be nice if we can write this as a method chain. S... -
- * parse.y (rb_yytnamerr): show single-quoted single char as-is, to
show a quoted closing brace as tSTRING_DEND. e.g.:
$ ./ruby -e '"#{true'
-e:1: syntax error, unexpected end-of-input, expecting '}'
git-svn-id: svn+ssh:/... -
-
- I came up with an idea better than this (https://bugs.ruby-lang.org/issues/15557).
So I withdraw this proposal. Please close it. -
09:25 AM Bug #14353: $SAFE should stay at least thread-local for compatibility
- Just FTR, as per this discussion:
https://lists.fedoraproject.org/archives/list/ruby-sig@lists.fedoraproject.org/message/V234THAZ2ETTFVLJZXJYPH2QO5W7A3KL/
The global $SAFE breaks gettext testsuite:
https://github.com/ruby-gettex... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66910 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Applied in changeset trunk|r66909.
----------
tmpdir.rb: permission of user given directory
* lib/tmpdir.rb (Dir.mktmpdir): check if the permission of the
parent directory only when using the default temporary
directory, and no che... -
- * lib/tmpdir.rb (Dir.mktmpdir): check if the permission of the
parent directory only when using the default temporary
directory, and no check against user given directory. the
security is the user's responsibility in that case.
...
01/22/2019
-
11:37 PM Bug #14972: Net::HTTP inconsistently raises EOFError when peer closes the connection
- I submitted a PR against trunk: https://github.com/ruby/ruby/pull/2074
- 11:22 PM Revision 05c3256b (git): * 2019-01-23
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66908 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * parse.y (set_yylval_str, set_yylval_literal): always imply
add_mark_object.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66907 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:43 PM Revision bdbc8a8f (git): Add more example of `String#dump`
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66906 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- https://github.com/ruby/ruby/commit/bcb9e567c422f535b4871ce2795179af808d0077 changes from `FileUtils.remove_entry_secure` to checking stat and `FileUtils.remove_entry`.
So I think splitting checking and `FileUtils.remove_entry` is not g... -
10:11 AM Bug #15555 (Closed): Dir.mktmpdir checks permissions and raise ArgumentError after yielding to block (ensure) & leaks allocated tempdir
- The current implementation of the `Dir.mktmpdir` is the following:
```ruby
def Dir.mktmpdir(prefix_suffix=nil, *rest)
path = Tmpname.create(prefix_suffix || "d", *rest) {|n| mkdir(n, 0700)}
if block_given?
begin
yie... -
- yystpcpy is always used by yysyntax_error in bison 2.3, but may
not used by other than yytnamerr in newer bison.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66905 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
06:36 AM Feature #15554: warn/error passing a block to a method which never use a block
- I fixed the issues of TestGemRequestSetGemDependencyAPI on upstream repository and merged them at r66904.
-
04:48 AM Feature #15554 (Closed): warn/error passing a block to a method which never use a block
- # Abstract
Warn or raise an ArgumentError if block is passed to a method which does not use a block.
In other words, detect "block user methods" implicitly and only "block user methods" can accept a block.
# Background
Sometime... -
- https://github.com/rubygems/rubygems/commit/1172320540c8c33c59fc1db5191b021c3b2db487
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66904 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * parse.y (rb_yytnamerr): strip enclosing double-quotes, same as
the default yytnamerr except for that single-quotes matching
back-quotes do not stop stripping.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66903 b2dd03c8-39d4-4... - 01:56 AM Revision 5e7d0353 (git): * 2019-01-22
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66902 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66901 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
01/21/2019
-
05:57 PM Feature #5653: "I strongly discourage the use of autoload in any standard libraries" (Re: autoload will be dead)
- @matz when taking in consideration deprecation/removal of autoload I'd like you to consider that Rails built and plan to use a thread-safe code loader based on `autoload`. See https://medium.com/@fxn/zeitwerk-a-new-code-loader-for-ruby-a...
-
- Eregon (Benoit Daloze) wrote:
> Does that preserve the encoding of the String though?
The short answer: yes.
If the encoding is ASCII-compatible, it is preserved via its encoding of the resulting string.
```
s = "Hello こんにちは".... -
- Does that preserve the encoding of the String though?
What about String#inspect, does it also eval() to itself? -
- Committed at r66894. Closing
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66900 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66899 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66898 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- @mame Thanks for the quick fix!
With srand(0), I think we could add some verification, e.g., by computing a checksum of the image. -
- Applied in changeset trunk|r66892.
----------
benchmark/app_aobench.rb: add a magic comment
To support the change of default encoding.
It had not worked correctly since 2.0 :-)
[Bug #15552] -
- > And interestingly, TruffleRuby 1.0.0-rc11 renders an image closer to the expected one:
Closer :-)
This is caused by change of default encoding. The following fixes the issue. It is fortunate that the issue was not caused by wro... - 10:56 AM Revision 502f1594 (git): Improvements to documentation.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66897 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66896 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * configure.ac: check copy_file_range()
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66895 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * [Feature #5632] Attempt to open included class shades it instead. (mame)
* Matz, do you still want to "fix" this issue? And how? -
- The ancient issues that is no response. I'm okay to discuss them with our spare time of this meeting.
* [Feature #11796] [PATCH] Refactor reduce call `get_stat()`: nobu?
* [Feature #11710] [PATCH] Replace `Set#merge` with `Set#merge!... -
08:58 AM Feature #15553: Addrinfo.getaddrinfo supports timeout
- thanks for this PR. Many requests for fully async support in stdlib are blocked by this.
I think on Windows 8+ we can use https://docs.microsoft.com/cs-cz/windows/desktop/api/ws2tcpip/nf-ws2tcpip-getaddrinfoexa to avoid timeout? -
- Currently, we use Timeout in Net::HTTP and other standard libraries.
lib/net/http.rb
```
945 s = Timeout.timeout(@open_timeout, Net::OpenTimeout) {
946 begin
947 TCPSocket.open(conn_address, conn_port, @... -
- * Officially states that String#dump is intended for round-trip.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66894 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Sorry for leaving this ticket untouched.
I cannot remember the detailed story of this ticket, but since 2.6, coverage library has supported `Coverage.result(stop: false, clear: false)`. Is it enough? I still think `Coverage.result=`... -
- Closing due to OP's request.
FYI: Since 2.6, coverage.so has supported `Coverage.result(stop: false, clear: false)`. You may want to check it out. -
- I have forgotten why the status of this ticket is feedback :-) Anyway, it is already released, so there is no change to remove it. Closing.
-
- Branch coverage has been finally implemented in #13901. Thanks!
-
- ささださんと相談しました。
* 世代別 GC がある現在ではおそらく効果は弱いだろう
* Symbol GC が導入されたので、同じことをやると結構複雑になりそう（エントリの削除に対応しないといけない）
ということで、たぶんペイしないだろう、という推定になったので、閉じておきます。 -
- To prevent noise for benchmark result. Just for the case.
[Bug #15552]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66893 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- To support the change of default encoding.
It had not worked correctly since 2.0 :-)
[Bug #15552]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66892 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- A patch from casperisfine (Jean byroot Boussier).
[Fix GH-2012]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66891 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- like this:
http://ci.rvm.jp/results/trunk-mjit-wait@silicon-docker/1636642
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66890 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Ruby 2.1 is EOL today. Can you try with Ruby 2.5? Thanks.
01/20/2019
-
- If changing this API is too complicated due to backwards compatibility, why not introduce new more general API:
```
Method#source -> Source.new(path, line_number, line_count, code, ...)
```
Usage:
```
method.source.code
meth... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66889 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- FWIW, `sizeof(int) == sizeof(long)` is also the case on i686 Linux:
https://travis-ci.org/ruby/ruby/jobs/482143545 -
- For instance, when `sizeof(int) < sizeof(long)` (such as on Linux), then
```c
FIX2INT(nil)
```
raises TypeError.
But when `sizeof(int) == sizeof(long)` (such as on Windows), then it returns `4`.
So the behavior changes from a cal... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66888 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66887 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- @nobu I think we should backport r66769 to Ruby 2.6, could you do it or file an issue for it?
-
- Specifically, the image generated is incorrect.
When modifying the footer of the benchmark like this:
```ruby
alias printf_orig printf
def printf *args
$fp.printf(*args)
end
File.open("ao.ppm", "w") do |fp|
$fp = fp
pr... -
03:07 PM Revision 1c53f86b (git): process.c: [DOC] small improvements
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66886 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66885 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66884 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:02 PM Revision 8fe427c1 (git): * 2019-01-21
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66883 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66882 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- nobu (Nobuyoshi Nakada) wrote:
> `rb_str_set_len` is not the true problem.
> ...
That sounds safer, because indeed as soon as the C code can access the `char*` it can change it.
> Or enclose it only for the core and prohibit in exte... -
02:20 PM Bug #15550: Windows - gem bin files - can't run from bash shell
- An easy way to repo this is to open the Git bash shell, and run `bundle version`. I got an error message of:
```
bash: /c/Greg/Ruby99-x64/bin/bundle: No such file or directory
```
I believe the MSYS2 shell changes PATH, the Git ... -
- As I recall, ruby-loco is no longer touching the gem related files located in the bin folder. Previously, there were two files associated with each gem, one with a .cmd/.bat extension, one without.
Currently, there is just one file w... -
- ruby_2_5 r66881 merged revision(s) 64879.
-
- transcode.c: add GC guard on raise
* transcode.c (econv_s_search_convpath): add GC guard to fix SEGV
on raise.
[Bug #15162] [ruby-core:89172]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@668... -
- ruby_2_5 r66880 merged revision(s) 63334.
-
- object.c: raise on long invalid float string
* object.c (rb_cstr_to_dbl_raise): check long invalid float
string more precisely when truncating insignificant part.
[ruby-core:86800] [Bug #14729]
git-svn-id: s... -
- ruby_2_5 r66879 merged revision(s) 63322.
-
- object.c: fix exponent with underscore
* object.c (rb_cstr_to_dbl_raise): do not ignore exponent part
when the input string longer than internal buffer contains
underscore(s). [ruby-core:86836] [Bug #14731]
... -
- ruby_2_5 r66878 merged revision(s) 63720.
-
- dir.c: define O_CLOEXEC for older systems
SuSE 10 has openat(), but not O_CLOEXEC
Reported-by: wangpeiwen
[ruby-core:87591] [Bug #14864]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@66878 b2dd... -
- ruby_2_5 r66877 merged revision(s) 66401.
-
- Move autoload to toplevel
So that classes which uses Net::HTTP with https can use OpenSSL
namespace for example exception classes like OpenSSL::SSL::SSLError.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_... -
- ruby_2_5 r66876 merged revision(s) 66242.
-
- io.c (io_write_nonblock): add RB_GC_GUARD, io_fflush may switch threads
Since io_fflush may block on mutex or rb_io_wait_readable and
switch threads, we need to ensure the `str' VALUE returned by
`rb_obj_as_strin... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66875 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Applied in changeset trunk|r66873.
----------
[DOC] Refactors documentation for `Forwardable`
[ruby-core:71281] [Misc #11639]
From: Sam Morgan <s_morgan@me.com> - 04:38 AM Revision 27f51081 (git): * 2019-01-20
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66874 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- [ruby-core:71281] [Misc #11639]
From: Sam Morgan <s_morgan@me.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66873 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I misunderstood this could be reproducible in 2.5 but it isn't.
-
01:15 AM Feature #15517: Net::HTTP not recognizing valid UTF-8
- I think this issue is not a duplicate of issue #2567, but it is clearly related.
Checking whether the string is valid UTF-8 is rather easy;
```
string.force_encoding('UTF-8').valid_encoding?
```
should do.
There are some securi...
01/19/2019
-
- I do not have any major pro or con opinion on the functionality as such; I think the
name #to_reader may not be ideal, though. People may confuse or think about
**attr_reader** ; or they may think about **.to_s** , **.to_i** and so for... -
- This is a feature proposal for something I've had to implement before multiple times.
For a lot of IO-related APIs, there is this unspoken (because ruby doesn't have official interfaces) notion of a reader/writer protocol, that is, yo... -
-
- I did not even know that iterator? exists - at first I thought it was something new. :)
I agree with nobu's comment. -
- `block_given?` has been added since 1.6, and `iterator?` is almost never used these days.
I think we can deprecate the latter before Ruby 3. -
- CentOS 5 and Ruby 2.1 are EOL.
-
- r58403 was included in ruby_2_5.
#15500 seems related and r66867 may fix this issue. -
- The versions of Ruby and Rails are outdated today.
-
- This reverts commit 405940234eb7876a063eb7129ca61fcc318a633c.
Not working on MinGW
https://ci.appveyor.com/project/ruby/ruby/builds/21737578/job/09a2tr94vof6fstt
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66872 b2dd03c8-39d4-4d8... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66871 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- assuming that -nostartfiles is just optional for mingw, cygwin, and AIX.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66870 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- >Off topic: can someone give me the grant to copy issues around? It seems disabled for this account.
Enabled it to Developer role now. -
- @shevegen Here you are https://bugs.ruby-lang.org/issues/15546
Off topic: can someone give me the grant to copy issues around? It seems disabled for this account. -
- Could someone add a date + issue for the next developer meeting, please?
I looked at https://bugs.ruby-lang.org/projects/ruby-trunk/issues for when the next
meeting may be, but was unable to find it (assumingly so it may be in Februa... -
- Applied your patch. Thanks for your help!
-
- Applied in changeset trunk|r66869.
----------
mjit_worker.c: do not use GCC_NOSTDLIB_FLAGS for OpenBSD
OpenBSD's GCC compiler has local extensions that break when
`-nostartfiles -nodefaultlibs -nostdlib` is used.
From: Jeremy Evans <m... -
07:12 AM Bug #15548 (Closed): Fix MJIT on OpenBSD when GCC is used to compile
- OpenBSD's GCC compiler has local extensions that break when `-nostartfiles -nodefaultlibs -nostdlib` is used. If you leave those flags in, MJIT doesn't work. `--jit-verbose=2` output on OpenBSD/amd64 with gcc forced as the compiler show...
-
- OpenBSD's GCC compiler has local extensions that break when
`-nostartfiles -nodefaultlibs -nostdlib` is used.
From: Jeremy Evans <merch-redmine@jeremyevans.net>
[Bug #15548]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66869 b2dd... -
- matz (Yukihiro Matsumoto) wrote:
> This is a very interesting idea but at the same time, it's difficult to keep compatibility.
> ...
If we want to support implicit block arguments, in order to best keep compatibility, we would probably... -
05:50 AM Bug #15469: Ruby2.6 included `bundler` does not handle specified `csv` gem.
- I could reproduce too with "Test code".
Also, I could reproduce with simpler code below.
### Gemfile
``` ruby
source "https://rubygems.org"
gem "csv", "1.0.0"
```
### test.rb
```ruby
require "csv"
p csv: CSV::VERS... -
05:24 AM Misc #15546: DevelopersMeeting20190207Japan
- * [Feature #4475] default variable name for parameter (aycabta)
* In #15483, matz said "I feel the expression `ary.map(&(:to_i << :chr))` is far less readable than `ary.map{|x|x.to_i.chr}`.", and "And this can lead to the default bloc... -
- Please comment your favorite ticket numbers you want to ask to discuss with your *SHORT* comment or summary.
(your summary/comment will help us because we don't need to read all of ticket comments)
*DO NOT* discuss then on this ticke... -
- @mrkn
Can you try with Ruby 2.5 applied r66867? -
- Applied in changeset trunk|r66867.
----------
Revert r58345 and r58371.
These changes break the behavior of default gems. Bug #13428 says
r58345 is reasonable because gemspec file is installed by `to_ruby_for_cache`
method. But I... - 03:36 AM Revision 31c862a7 (git): * 2019-01-19
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66868 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- These changes break the behavior of default gems. Bug #13428 says
r58345 is reasonable because gemspec file is installed by `to_ruby_for_cache`
method. But I revert `to_ruby_for_cache` in rbinstall.rb at r58403.
There is no reason ... -
03:30 AM Feature #15517: Net::HTTP not recognizing valid UTF-8
- I'm not sure I think this is exactly the same as https://bugs.ruby-lang.org/issues/2567, as that one has focused on using the HTTP headers to guess the content type. Here I'm pointing out that ASCII-only strings are recognized as UTF8, b...
-
- \o/
I noticed a few differences, or I think I noticed it (I am not entirely sure).
For example, I did not notice "Actions" on the very right hand side before.
I also think there may have been another one or two minor changes in ...
01/18/2019
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66866 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66865 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66864 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Msys shell may not be able to run a command with a drive letter?
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66863 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_6 r66862 merged revision(s) 66796,66797.
-
- No TypeError at nil if exception: false
[ruby-core:91021] [Bug #15525]
No FloatDomainError at non-finitive number if exception: false
[ruby-core:91021] [Bug #15525]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/... -
- `rb_str_set_len` is not the true problem.
Should `RSTRING_PTR` make the object unshared and clear the code range?
Or enclose it only for the core and prohibit in extension libraries?
Hmmm, the last choice may be the best, I think. -
- [ruby-core:91134] [Bug #15543]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66861 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I'll fill Backport field and close this ticket for backport.
Thank you for notice. -
- The change in r58403 should be backported in 2.5.
https://github.com/ruby/ruby/commit/cd8f9904427e6db858a4dcc1dabff60a76cad445 -
- * bootstraptest/test_insns.rb: check RbConfig::LIMITS to support
older BASERUBY.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66860 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- MINIRUBY may not be stable enough to run btest, in developing.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66859 b2dd03c8-39d4-4d8f-98ff-823fe69b080e