Activity
From 12/03/2018 to 12/09/2018
12/09/2018
-
11:14 PM Revision 3628eae2 (git): implement special behavior for Georgian for String#capitalize
- The modern Georgian script is special in that it has an 'uppercase'
variant called MTAVRULI which can be used for emphasis of whole words,
for screamy headlines, and so on. However, in contrast to all other
bicameral scripts, there is no... -
10:19 PM Feature #13581: Syntax sugar for method reference
- > matz (Yukihiro Matsumoto) wrote:
> ...
@matz and @nobu
What do you guys think about this alternative syntax? (working proof of concept: https://github.com/LendingHome/pipe_operator)
-9.pipe { abs | Math.sqrt | to_i }
#=... -
12:35 PM Revision 596d7bde (git): test/rdoc/minitest_helper.rb: partially revert r66286
- to resurrect r65613
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66299 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
06:46 AM Revision 4f131605 (git): conceptually partial backport from r63103, r65567.
- All ISeq#to_binary should rescue to skip when running with coverage.
current trunk (2.6-) has assert_iseq_to_binary.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@66298 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
05:53 AM Bug #15394 (Closed): Ruby adds unexpected HTTP header value when using symbol key
- ## Problem
Because of this, Ruby will set Host header twice if user uses symbol key.
In other words, host header should be set when host header is not given.
See code: https://github.com/ruby/ruby/blob/0777262b1b08722ee99d73fb8c9703... -
- iseq.c: fix build error when VM_CHECK_MODE is enabled
Follow up of r61534. Sorry.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@66297 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- nobu (Nobuyoshi Nakada) wrote:
> What version of cc?
[duerst@stazersee ruby2]$ gcc --version
gcc (GCC) 4.8.3 20140911 (Red Hat 4.8.3-7)
-
02:32 AM Bug #15299: hash.c: warning: ‘bin’ may be used uninitialized in this function
- What version of cc?
It is a false warning.
`bin` is initialized if the hash is not empty, and otherwise `existing` is `FALSE`.
And the line is in a block of `if (existing)`, so unintialized `bin` never reaches there. -
- Seems 2.5.4 has been fixed.
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66296 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- This line, and those below, will be ignored--
D enc/unicode/10.0.0
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66295 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66294 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66293 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- get_uniq_filename never returns NULL but raises an exception on
failure.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66292 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
12/08/2018
- 10:04 PM Revision ab73ef6b (git): Revert "thread_pthread.c: fix memory leak from fork loop leapfrog (v2)"
- This reverts r66290 / commit 043047a8fd5315d98eac38ddbd04ebe8db361817.
Still fails on CI, and I'm not able to reproduce the failure, either :<
http://ci.rvm.jp/results/trunk-test@ruby-sky1/1508228
git-svn-id: svn+ssh://ci.ruby-lang.org... - 09:45 PM Revision 043047a8 (git): thread_pthread.c: fix memory leak from fork loop leapfrog (v2)
- Constantly forking a single-threaded process in a loop leads to
a memory leak when using POSIX timers.
v2: disarm before timer_delete
==> fork_leapfrog.rb <==
require 'io/wait'
Dir.chdir '/proc'
prev = 0
loop do
pid = fork
exit!(0)... - 08:36 PM Revision 1a17766e (git): Revert "thread_pthread.c: fix memory leak from fork loop leapfrog"
- Oops, CI failures...
This reverts r66288 / commit 2b1dcc1dd1eb260fd20ff1e6e0dfb0e5624a3cc6.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66289 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 07:25 PM Revision 2b1dcc1d (git): thread_pthread.c: fix memory leak from fork loop leapfrog
- Constantly forking a single-threaded process in a loop leads to
a memory leak when using POSIX timers.
==> fork_leapfrog.rb <==
require 'io/wait'
Dir.chdir '/proc'
prev = 0
loop do
pid = fork
exit!(0) if pid
# show the number of ... -
05:58 PM Feature #15393: Add compilation flags to freeze Array and Hash literals
- One alternative idea which would achieve a similar goal is having #deep_freeze on core types, and recognizing `{ 'a' => ['b', { 'c' => 'd' }] }.deep_freeze`.
This would be more general, since it would also work for freezing non-constant... -
01:58 PM Feature #15393: Add compilation flags to freeze Array and Hash literals
- About the name - some suggestions if only to show which variants may be
better than others. :)
frozen: true # could say "ruby, freeze as much as you possibly can!"
In other words, that setting/flag could mean that strings, hash... -
12:42 AM Feature #15393 (Open): Add compilation flags to freeze Array and Hash literals
- Hi,
I would like to add VM compilation options to freeze array and hash literals. For example:
~~~ ruby
frozen = RubyVM::InstructionSequence.compile(<<-eocode, __FILE__, nil, 0, frozen_string_literal: true, frozen_hash_and_array_... - 05:39 PM Revision 726ea30a (git): * 2018-12-09
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66287 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
05:39 PM Revision 18911e99 (git): Merge RDoc 6.1.0.beta3 from upstream
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66286 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- ruby_2_5 r66285 merged revision(s) 65667.
-
- Fix for bison 3.2 [Bug #15284]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@66285 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66284 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
06:33 AM Bug #15303: Return tracepoint doesn't fire when tailcall optimization is applied
- ko1 (Koichi Sasada) wrote:
> Cancel tailcall opt when `return` event is specified.
I think anyone who goes through all the trouble to enable tailcall elimination right now relies on it to avoid stack overflow.
Why else would someone... -
01:31 AM Bug #15303: Return tracepoint doesn't fire when tailcall optimization is applied
- Ah, I have another strong idea (forgot to propose).
Cancel tailcall opt when `return` event is specified.
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66283 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Applied in changeset trunk|r66282.
----------
Honor configured ruby header locations as the MJIT header path
[Bug #15391] -
- [Bug #15391]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66282 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- MJIT_MIN_HEADER is passed via a command line option for
mjit_build_dir.so.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66281 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Give the whole MJIT header path name by preloaded shared library
mjit_build_dir.so, than building the path from a given directory
name and the embedded base name.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66280 b2dd03c8-39d4-4d8... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66279 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
12/07/2018
-
08:57 PM Bug #15356: Rack::Deflater on Rails responds with no data on Ruby 2.6.0
- Thanks so much for both of you! I've finally dug into this a little bit further.
First, I could confirm that the problem I first reported here for the simple Rails app with just `Rack::Deflater` added is fixed on `ruby 2.6.0dev (2018-... -
01:33 PM Bug #15356: Rack::Deflater on Rails responds with no data on Ruby 2.6.0
- me@dmitry.it wrote:
> though this patch leads to described behavior, it looks like
> the actual problem can be solved by putting `Rack::Deflater`
> to the proper place in middleware stack:
Asking users to change app config to migr... -
11:49 AM Bug #15356: Rack::Deflater on Rails responds with no data on Ruby 2.6.0
- normalperson (Eric Wong) wrote:
> OK, I'm pretty sure r66268 fixes it. It's still my fault, not
> ...
though this patch leads to described behavior, it looks like the actual problem can be solved by putting `Rack::Deflater` to the pro... -
- OK, I'm pretty sure r66268 fixes it. It's still my fault, not
because of non-blocking I/O, but because of a misguided zlib
optimization, so I'm still a moron :<
Fortunately the damage was limited and the majority of the zlib
memo... -
- Sorry for the delay in getting back to this. Just for your information, unfortunately, I noticed this problem coming back on ruby 2.6.0rc1 (2018-12-06 trunk 66253) [x86_64-linux]. Below is an example Rails app: https://github.com/zunda/m...
-
07:33 PM Bug #15385: Ruby process hang in ensure
- > ujihisa (Tatsuhiro Ujihisa) wrote:
> ...
Could it be related then to https://bugs.ruby-lang.org/issues/14959#note-7 and https://bugs.ruby-lang.org/issues/15392 then? -
- Sounds like a duplicate of #14561. It should be fixed on trunk already.
- 04:48 PM Revision 3458e824 (git): * 2018-12-08
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66278 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66277 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:19 PM Bug #15392 (Closed): Crash in RubyVM::InstructionSequence#to_binary
- The following program causes a crash in Ruby 2.5.3 and 2.5.1 (but not in 2.4.4):
RubyVM::InstructionSequence.compile('a(b: 0) if false').to_binary -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66276 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- > there are 80+ JIT test cases failed
Then, we can't merge, right?
Also most of the changed places are mostly written by @nobu. Reassigning this to him because TBH I have no idea about how multi-arch build is working. -
10:44 AM Bug #15391 (Closed): JIT does not respect configuration options
- JIT does not respect configuration options, mainly the header location options --with-rubyhdrdir, --with-rubyarchhdrdir, but it also ignores --with-ruby-version if I am not mistaken.
So far I came up with the patch attached. But while... -
12:12 PM Revision 0c003350 (git): should not use Internet Explorer
- * spec/ruby/library/win32ole/fixtures/classes.rb: add
SYSTEM_MONITOR_CONTROL_AVAILABLE.
* spec/ruby/library/win32ole/win32ole_method/event_spec.rb: Internet
Explorer is not available in some environment. Instead, try to use
System... -
- Applied in changeset trunk|r66274.
----------
Adjust reserved hash values
The reserved hash values in hash.c must be consistend with st.c.
[ruby-core:90356] [Bug #15389] -
09:30 AM Bug #15389: 9 elements or more larger Hash doesn't show an entry
- @kou you need to debug what sym is, it looks like that it thinks that some of them are already existing
it might also be a bad idea to use such objects as hash keys?
Or debug why hash thinks it already has that key? -
04:25 AM Bug #15389 (Closed): 9 elements or more larger Hash doesn't show an entry
- I don't know this problem is a problem of Racc or Ruby itself yet but I'll share this.
Here is a Ruby script that reproduce this case:
```ruby
require "racc/grammar"
hash = {}
[
[false, 0],
[:error, 1],
[:END, 2],
... -
- The reserved hash values in hash.c must be consistend with st.c.
[ruby-core:90356] [Bug #15389]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66274 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66273 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
11:43 AM Feature #14844: Future of RubyVM::AST?
- Hello. Sorry to step in with a frivolous suggestion, but I just noticed the name `RubyVM::AbstractSyntaxTree` in the RC1 announcement and was surprised by the length of the word when the shorter name "AST" would suffice.
mame (Yusuke ... -
- naruse (Yui NARUSE) wrote:
> `/\p{Grapheme_Cluster_Break=E_Modifier}/` is specially introduced for `/\X/`.
> ...
Ok. `/\p{Grapheme_Cluster_Break=E_Modifier}/` now produces an error. If we get any bug reports, we can still revisit thi... -
10:00 AM Revision a610b1f0 (git): Bump rake-12.3.2 on bundled gems.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66272 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Implemented though a long series of patches, centered on regparse.c.
Related patches start at r65085 and end at r66269. The main patch is r66213.
New tests are at test/ruby/enc/test_grapheme_breaks.rb and test/ruby/enc/test_emoji_bre... -
09:22 AM Feature #15378: URI::InvalidURIError (bad URI(is not URI?)
- ipatovanton (Anton Ipatov) wrote:
> Thank you!
> ...
As far as I can see from the info you gave us, it seems the problem has nothing to do with encodings. -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66271 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Applied in changeset trunk|r66270.
----------
Add UNICODE_EMOJI_VERSION to RbConfig [Feature #15341] -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66270 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
08:32 AM Bug #11335: `ruby -r debug` catchpoint problem - I was able to reproduce the issue on newer Ruby.
```
$ ruby -v
ruby 2.5.1p57 (2018-03-29 revision 63029) [x86_64-openbsd]
```
sigsys (Math Ieu) wrote:
> By looking at `lib/debug.rb`, it looks like that the `set_trace_func` call... -
- > https://bugs.ruby-lang.org/issues/14968
So I'm hoping this can be revisited in the 2.7 timeframe even
if I'm not around.
IMHO it's too late for 2.6, now, but [Bug #15356] was resolved
and it doesn't seem like this had anything... -
- In regparse.c, in function node_extended_grapheme_cluster,
we used a raw if() with exit(1) as a cross-check for our
length calculations for the common node array. Convert this
to an assertion and comment it out because it is not needed
f... - 07:09 AM Revision cc9b57a2 (git): zlib (gzfile_write_raw): do not resize string after .write call
- Apparently, a component of Rails implements a buffering .write
method which keeps the String buffer around and makes it unsafe
for us to clear it after calling .write.
This caused Rack::Deflater to give empty results when enabled.
Fort... -
- In file regparse.c, in function node_extended_grapheme_cluster(),
eliminate code duplication of CRLF and '.' (any character). This
uses the fact that both for Unicode encodings and for non-Unicode
encodings, the first alternative is CRLF... -
06:57 AM Bug #15390 (Third Party's Issue): Error installing nokogiri on ruby-2.6.0-rc1
- I am having issues with installing nokogiri on my Mac, Mojave 10.14.1 (18B75).
~~~ text
nedims-MacBook-Pro:~ nedim$ rvm use ruby-2.6.0-rc1
Using /Users/nedim/.rvm/gems/ruby-2.6.0-rc1
nedims-MacBook-Pro:~ nedim$ gem install nokogi... -
- OK. I'll close this.
-
03:05 AM Bug #15388: CSV parsing behaviour in > 2.5.0
- kou (Kouhei Sutou) wrote:
> It seems that this has been fixed in csv master.
> ...
Thanks. Working fine with version 3.0.1. -
- Arguments validation may be better but we need more works for it. For example, we need to add similar logic to `CSV.read` for this case.
Anyone who wants to work on argument validation should send pull requests to https://github.com/r... -
- It seems that this has been fixed in csv master.
I've released csv gem 3.0.1. Can you try it? -
- dharshandj@gmail.com (Dharshan Bharathuru) wrote:
> I needed a object-key reference in future references instead of index based references.
It doesn't need to write headers. -
- nobu (Nobuyoshi Nakada) wrote:
> Why do you want to write headers when parsing?
I needed a object-key reference in future references instead of index based references. -
- Maybe an error is expected?
```diff
diff --git i/lib/csv.rb w/lib/csv.rb
index dca2a45b6a..e4ad55085c 100644
--- i/lib/csv.rb
+++ w/lib/csv.rb
@@ -687,8 +687,9 @@
# You pass your +str+ to read from, and an optional +options+ ... -
- Why do you want to write headers when parsing?
-
02:25 AM Bug #13880 (Closed): `BigDecimal(string)` should raise on invalid values in `string`
- Fixed in r66222
-
- Fixed in r66222
-
- Fixed in r66222
-
- Fixed in r66222
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66266 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
12/06/2018
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66265 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66264 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- by Bundler.
http://ci.rvm.jp/results/trunk-vm-asserts@silicon-docker/1500762
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66263 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r66262.
----------
Warn redefinitions of some methods on Object
[Bug #5473] [Bug #14670] [Bug #15382] -
- [Bug #5473] [Bug #14670] [Bug #15382]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66262 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66261 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * spec/ruby/library/win32ole/win32ole_method/helpcontext_spec.rb:
Use FileSystemObject. Microsoft Internet Explorer is not available
in some environment.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66260 b2dd03c8-39d4-4d8f-98f... - 06:28 PM Revision 2f1c9e2a (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66259 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- This commit replaces the `newhashfromarray` instruction with a `duphash`
instruction. Instead of allocating a new hash from an array stored in
the Instruction Sequences, store a hash directly in the instruction
sequences and dup it on e... - 06:20 PM Revision 00a31080 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66257 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Co-Authored-By: Krzysztof Rybka <krzysztof.rybka@gmail.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66256 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Hi,
It seems like CSV library in 2.5.0 is not behaving as intended while parsing.
~~~ ruby
header = ["A", "B", "C", "D", "E", "F", "G", "H", "I", "J", "K", "L", "M", "N", "O", "P", "Q"]
csv_str = "10.4710|859.5170|9000.0000|Y||... -
04:29 PM Bug #15114: Ruby で定義したメソッドに `&:hoge` を渡しても refinements が有効にならない
- ありがとうございます。
こちらでも再現できたのでもう少し調査してみます。 - 03:33 PM Revision ea921abd (git): * 2018-12-07
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66255 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:33 PM Revision 0cee9e98 (git): Add missing declaration to export
- Additional fix for r66200:
https://rubyci.org/logs/rubyci.s3.amazonaws.com/icc-x64/ruby-trunk/log/20181206T130002Z.fail.html.gz
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66254 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66252 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66251 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Applied in changeset trunk|r66249.
----------
`script_compiled` TracePoint event [Feature #15287]
* vm_trace.c: add `script_compiled` event. This event invoked
after script compiling and before evaluating compiled script.
Also the ... - 01:42 PM Revision a352ee89 (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66250 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * vm_trace.c: add `script_compiled` event. This event invoked
after script compiling and before evaluating compiled script.
Also the following methods are added:
`TracePoint#compiled_instruction_sequence` method to get compiled
... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66248 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66247 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- This is a ticket for backport management.
-
- ```
This is a rare corner-case probably nobody cares about. (because
socket has IO#sync=false by default). Not critical to fix
or change before 2.6 (I'm not sure if there's a compatibility risk).
Would much appreciate an extra set... -
- r66228 merged https://github.com/ruby/ruby/pull/2005/files#diff-b6f26affdb29910802b4d97a901fe689R92, thanks!
-
- * iseq.c: before this patch, RubyVM::InstructionSequence.of(src) (ISeq in
short) returns different ISeq (wrapper) objects point to one ISeq internal
object. This patch changes this behavior to cache created ISeq (wrapper)
objects a... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66245 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:41 AM Revision 0d4ba7b5 (git): io.c (io_fflush): eliminate redundant rb_io_check_closed
- There is no need to call this function twice in a row since
thread switching won't happen in-between calls to it.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66244 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 10:09 AM Revision aa6dfe71 (git): NEWS: fix typo (maesured => measured) [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66243 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:09 AM Revision 48324dd4 (git): io.c (io_write_nonblock): add RB_GC_GUARD, io_fflush may switch threads
- Since io_fflush may block on mutex or rb_io_wait_readable and
switch threads, we need to ensure the `str' VALUE returned by
`rb_obj_as_string` is visible to GC.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66242 b2dd03c8-39d4-4d8f-... -
- Though internal.h has the prototype, it still shows symbol lookup error...
https://rubyci.org/logs/rubyci.s3.amazonaws.com/icc-x64/ruby-trunk/log/20181206T050002Z.fail.html.gz
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66241 b2dd... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66240 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- regparse.c: In function node_extended_grapheme_cluster(), use function-global
array node_common and use it for list and alternate construction. This is done
so that in case of error, all nodes that have already been constructed can be
co... -
08:37 AM Feature #15230: RubyVM.resolve_feature_path
- It returns false as path when feature is already loaded.
Is it intentional?
```
% rbenv exec irb --simple-prompt -r irb/completion
>> RubyVM.resolve_feature_path('set')
=> [:rb, false]
``` -
06:40 AM Feature #15230 (Closed): RubyVM.resolve_feature_path
- Applied in changeset trunk|r66237.
----------
load.c (RubyVM.resolve_feature_path): New method. [Feature #15230] -
07:49 AM Feature #15378: URI::InvalidURIError (bad URI(is not URI?)
- Thank you!
What do you think is the problem with the encoding?
-
- ipatovanton (Anton Ipatov) wrote:
> ~~~ ruby
> ...
Thank you!
The problem is the "\n" at the very beginning of `self.url`. This is in fact a bad URI.
To fix this, please remove that before calling `URI()`. -
- Especially over checking argc then calling rb_scan_args just to
raise an ArgumentError.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66238 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66237 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
-
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66236 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66235 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
05:25 AM Bug #15385: Ruby process hang in ensure
- This reproduces even without timeout library.
~~~ ruby
def doh
raise
ensure
123 if false
end
doh
~~~
looks like this is because the optimizer removed `if false` or `if nil` without adding `nop` iseq. -
- While playing with mutation testing of my code I've found a weird mutation that hangs Ruby process. The isolated code which triggers this freeze is:
~~~ ruby
require 'timeout'
puts Process.pid
def raise_before_returning
ra... -
- In regparse.c:
* Reduce coode duplication by merging the almost identical functions
create_sequence_node and create_alternate_node into a new function
create_node_from_array, adding a parameter that distinguishes between
creating... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66233 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
-
- * unicode.c: Remove the arrays onigenc_unicode_GCB_ranges_GAZ,
onigenc_unicode_GCB_ranges_E_Base, and onigenc_unicode_GCB_ranges_Emoji,
because they are not needed anymore for Unicode 11.0.0.
* regparse.c: Remove external declaratio...
12/05/2018
-
- @nobu can you close this?
-
- While I agree with Koichi in regards to benchmarks and more code
meaning more maintenance work (naturally), I think it should still
be considered for the trade off being potentially worth it. If there
is time for discussion at the ne... -
- If we introduce special versions for Array, some new code are introduced.
It means the code we need to maintain will be increased.
I think about 20% improvement is not worth compare with the disadvantage.
BTW, I don't check the pa... -
04:26 AM Feature #15380 (Open): faster method lookup for Array#all? #none? #one?
- ## summary
This PR proposes Array-specific implementations for `#all?` , `#none?` and `#one?` to enable faster method lookup.
Before this patch `Array#all?` was not implemented in Array class, so alternatively, `Enumerable#all?` wa... -
- Is there anything I can do to move this forward?
-
- mbj@schirp-dso.com wrote:
> Just curious, is there an associated CI build for these changes?
I check https://rubyci.org/ and http://ci.rvm.jp/ (and get
automated mails from the latter).
There's also TravisCI; but I don't use Jav... -
07:37 PM Bug #15383: Reproducible crash: crash.rb:6: [BUG] unexpected THREAD_KILLED
- Thanks for the quick fix. Also for marking the fix to be backported.
Just curious, is there an associated CI build for these changes? -
- > https://bugs.ruby-lang.org/issues/15383
Thanks, it affects trunk; just more difficult to reproduce
because of thread cache.
I'm a moron for not noticing this when I fixed other bugs :<
r66230 should fix it in trunk and shoul... -
- Applied in changeset trunk|r66230.
----------
thread_sync.c (mutex_ptr): handle mutexes held by parent threads in children
Mutexes may be held by threads which only exist in the parent
process, so their waitqueues may be populated with... -
- Hi,
I'm reporting a reliable crash of the ruby interpreter on contested mutexeses that are accessed in child processes.
I currently think that this happens as the child processes main thread, may be waiting for a parent process sib... -
- ~~~ ruby
RuntimeError ("\nhttp://zapovednik.space/material/stantsija-petropavlovsk"):
~~~
-
- Can I ask you the exact representation of the self.url parameter, not just its printable part? I guess it contains control character, most likely newlines.
just add `raise self.uri.inspect` right before the line you are getting the ex... - 07:01 PM Revision 7eb5775f (git): Revert "fix typoe of r66200"
- This reverts r66229 (commit e941daa6dd114b52356a63d3c3db5684e6c66717)
Many CI failures on this:
http://ci.rvm.jp/results/trunk-jemalloc@silicon-docker/1497858
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66231 b2dd03c8-39d4-4d8f-9... - 06:58 PM Revision 818f1c65 (git): thread_sync.c (mutex_ptr): handle mutexes held by parent threads in children
- Mutexes may be held by threads which only exist in the parent
process, so their waitqueues may be populated with references
to other dead threads. We must reset them at fork.
I am a moron for introducing this bug :<
[ruby-core:90312] ... -
- Agree on the "one rather than two". It is probably redundant after the merge.
I can't answer the second sentence since there may have been (different?)
reasons for adding certificates - but it would make sense to require only
one ra... -
- It is pity that the same ssl_certs are shipped on multiple places, once as part of RubyGems and the other set as part of Bundler. This makes the security review much harder (actually, in Fedora/RHEL packages, we are not supposed to ship ...
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66229 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * include/ruby/defines.h: introduce "COLDFUNC" function attribute
on several compilers for called unlikely functions.
Apply to rb_memerror, rb_warn and rb_bug.
A patch form methodmissing <lourens@bearmetal.eu>.
git-svn-id: svn+... -
- I personally don't see an issue with this spec, besides that it would introduce a breaking change one way or the other. I think it would fix the `next` command in byebug, though. (it would have to rescue when it calls #return_value, thou...
-
- or `raise` on `return_value` ?
it is irregular case. I think tailcall is not normal call (it is same as a method call by lexicial).
```
foo() # tailcall
```
we can see:
```
return_and_call(:foo)
```
and nobody think it... -
- If we return `nil` for `#return_value`, users can't tell whether the nil is from the method actually returning nil, or a `nil` from tailcall.
I think the return event should be reserved for only real returns, because of its name.
I d... -
- Yes, the patch should return `nil` (I forgot to support it).
I think we can change the semantic of tailcall as a method call/return flow I proposed.
What kind of issue on this change?
-
- The main concern I have with this approach is that there is no reasonable value we can make `Tracepoint#return_value` return when we trigger it due to a tailcall:
```
def bar
:"bar's return value"
end
iseq = RubyVM::Instructio... -
- hi,
how about to call `return` event hook at tailcall? There is no need to introduce new API proposed at [Bug #15313].
```
def bar
end
iseq = RubyVM::InstructionSequence.new("def foo; bar; end", __FILE__, __FILE__, __LINE__, t... -
- Overwriting these methods also should be warned, as `Object#initialize`?
https://github.com/nobu/ruby/pull/new/bug/15382-warn-redef -
- Briefly investigated. This is an infinite recursion.
Simplified version:
def respond_to_missing?(s, f)
0 + "foo"
end
0.respond_to?(:foo)
`0 + "foo"` calls `coerce`, which calls `respond_to_missing?` recursi... -
12:07 PM Bug #15382 (Closed): Stack overflow in int_or()
- After some fuzz testing I found a crashing test case.
To reproduce: miniruby ruby_so_int_or
Full ASAN report: https://gist.github.com/fumfel/0a2e01f2ab6794632d017bfd306ffac9
ASAN report:
~~~
==22120==ERROR: AddressSanitizer:... -
- I found `each` does not call `Array.try_convert` so only `for` is affected by redefinition of that method.
```
$ ruby -e 'a = [Struct.new(:to_ary).new([1, 2])]; def Array.try_convert(*);raise;end;a.each {|i, j| p [i, j]}; for i, j in... - 04:15 PM Revision 756914e5 (git): * 2018-12-06
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66227 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * configure.ac (check broken_backtrace code): fix decl. position
error because of `-Werror=declaration-after-statement`.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66226 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:46 PM Bug #14959: Writing a "link_to" method and a "url_helper" with a request parameter under certain "if else" statement in Rails helper crashes with KERN_INVALID_ADDRESS at 0x0000000000000000
- nobu (Nobuyoshi Nakada) wrote:
> The same issue is already marked to backport in #14897.
> ...
I'm still seeing the problem in 2.5.3, so I'm guessing this was never backported? Will it be? -
- normalperson (Eric Wong) wrote:
> cremno@mail.ru wrote:
> ...
To link non msvcrt.dll (msvcrXX and vcruntime), it requires related version of Visual C++ compiler.
Anyway as far as I understand, it already doesn't work with VC6,
And... -
- ruby_2_5 r66225 merged revision(s) 64736,65567.
-
- iseq.c: prefix rb_ to non-static iseq functions
I assume we always prefix rb_ to non-static functions to avoid conflict.
These functions are not exported and safe to be renamed.
iseq.h: ditto
compile.c: ... -
- `make DEFS=-DVM_CHECK_MODE=2 check` で落ちます。
-
- I myself have used *foobar quite a lot in ruby code, such as in:
def foobar(*args)
args.each # and do something then
end
and I have also used &: considerably often too. The most frequent
use case for me personally ... -
08:28 AM Feature #15381: Let double splat call `to_h` implicitly
- Sorry, I meant `to_h`, not `to_hash`.
And in case my intention was not clear, in the example I gave for the double splat, I expected `**nil` to be evaluated as `**{}` due to `nil.to_h # => {}`. -
- The single splat calls `to_a` implicitly on the object (if it is not an array already) so that, for example, we have the convenience of writing conditions in an array literal:
```ruby
a = [
*(:foo if some_condition),
*(:bar if ... - 11:30 AM Revision 5fa8b95d (git): NEWS: update about bigdecimal [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66224 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 11:30 AM Revision 10492c2b (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66223 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 11:30 AM Revision 2810c12a (git): Import bigdecimal 1.4.0.pre.20181205a
- * https://github.com/ruby/bigdecimal/compare/74d25ef..v1.4.0.pre.20181205a
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66222 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 11:29 AM Revision ae88d2fc (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66221 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- This reverts commit 3f708604920f2fd7a105d5f092240737add15ef1.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66220 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- see r65979
[Bug #15291][ruby-dev:50663]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66219 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66218 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66217 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66216 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Applied in changeset trunk|r66215.
----------
lib/monitor.rb: prevent to initialize MonitorMixin twice
and allow to initialize again when obj.dup.
Suggested by Benoit Daloze. [ruby-core:88504] [Feature #15000] -
- and allow to initialize again when obj.dup.
Suggested by Benoit Daloze. [ruby-core:88504] [Feature #15000]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66215 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66214 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Noted. I'll keep deadlock checking and see about implementing
it for auto-fiber (if I continue working on that).
I don't like deadlock checking at all (since I don't want a
nanny programming language), but I'll go along with it if... -
- - common.mk: Change Unicode version to 11.0.0, and Emoji version to 11.0
- test/ruby/enc/test_emoji_breaks.rb: update hard-coded Emoji version
- enc/unicode/11.0.0, enc/unicode/11.0.0/casefold.h, enc/unicode/name2ctype.h:
Add generated... -
07:26 AM Bug #15377: rails unit tests get core dumped
- ko1 (Koichi Sasada) wrote:
> Now recent BigDecimal changes were reverted, and I passed tests now.
> ...
Great! thanks :) -
- Now recent BigDecimal changes were reverted, and I passed tests now.
> Finished in 448.578323s, 15.3998 runs/s, 40.4946 assertions/s.
> ...
mrkn will fix this issue and will re-introduce them.
-
- I mean "critical failure" is your issue (double free).
I could reproduce it. And it seems BigDecimal issue.
If you find more shorter reproducing process, it will help us.
Thanks,
Koichi -
- Matz agreed about naming of "script_compiled".
If others especially English natives have ideas, please tell me.
If no, I'll commit "script_compiled" event some days later.
----
I'm reconsidering "method_added" event because the... -
- how about https://bugs.ruby-lang.org/issues/15303#note-2 ?
-
- Could I ask for some feedback on this?
-
- Before this patch Array#all? was not implemented in Array class
and alternatively Enumerable#all? was used, while #any? has its
own method entry in Array class. Similarly, Array#none? and #one?
also lacks its own implementation.
This pa... - 04:01 AM Revision 7841cb1e (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66211 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 04:01 AM Revision f15cf091 (git): Revert bigdecimal 1.4.0 related commits
- * Revert "Remove unnecessary linker flags"
This reverts commit 49efa01579272d52d28bd361c498d96ca92e986e.
* Revert "Move dependency on gemspec"
This reverts commit bfb64d476578eadd61a738149726da37840f068d.
* Revert "Remove unneces... -
- test-unit-3.2.8 to 3.2.9
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66209 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r66208.
----------
Fix documentation for Warning.warn [ci skip]
Warning.warn does not add any newlines to the message argument.
[Bug #15379]
From: Olle Jonsson <olle.jonsson@gmail.com> -
- Warning.warn does not add any newlines to the message argument.
[Bug #15379]
From: Olle Jonsson <olle.jonsson@gmail.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66208 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- So `struct nmin_data` size is reduced.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66207 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66206 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66205 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
12/04/2018
-
- It's release version of Bundler 2
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66204 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 11:10 PM Revision 76d9da90 (git): mjit.c: remove init_list
- It is not needed since we have LIST_HEAD_INIT initializer in
mjit_worker.c
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66203 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- nobu (Nobuyoshi Nakada) wrote:
> テストでクラッシュするため、一旦revertしました。
パッチを作成してからだいぶ時間が経っていたので手元で `rebase trunk` して最新版を pull request してみましたがこちらは CI が通っていますね。
pull request : https://github.com/ruby/ruby/pull/2039 -
- テストでクラッシュするため、一旦revertしました。
- 10:19 PM Revision d612c44d (git): Enable MJIT on AIX
- * configure.ac: disable using __builtin_setjmp to avoid errors when execution
globally jumps out of JITted code. Specify -std=gnu99 to JIT compilation
to avoid errors regarding the "restrict" keyword in the precompiled header.
Spec... -
08:46 PM Feature #15350: [PATCH] thread_sync.c (queue_sleep): remove deadlock checking
- I agree with Jeremy, that dropping the deadlock detection from `Queue#pop` would be pity. It's a lot easier if you get a clear error message, than debugging a starvation in your process.
A common mistake in [Eventbox](https://github.c... -
08:42 PM Feature #14385: Deprecate back-tick for Ruby 3.
- Eregon (Benoit Daloze) wrote:
> IMHO this is way too incompatible and using %x{} only makes it less nice/readable/intuitive.
> ...
You use the same symbol "`" for the begining and the end of the instruction which is not a good thing to... - 06:48 PM Revision 2dd614af (git): * 2018-12-05
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66201 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Without this icc fails to run.
http://rubyci.s3.amazonaws.com/icc-x64/ruby-trunk/log/20181203T130002Z.diff.html.gz
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66200 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
05:46 PM Bug #15379 (Closed): [PATCH] Fix documentation for Warning.warn
- Warning.warn does not add any newlines to the message argument, this just makes the documentation reflect that.
The new documentation matches the spec in ruby/core/warning/warn_spec.rb. -
- https://travis-ci.org/ruby/ruby/jobs/463317607
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66199 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * https://github.com/ruby/psych/pull/379
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66198 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- which was accidentally reverted by r65904
158562dabb197d6efc53cabe6662177c6ec3f43e
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66197 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I using the ruby 2.5.3 and try to save this url http://zapovednik.space/material/stantsija-petropavlovsk
URI::InvalidURIError (bad URI(is not URI?):
http://zapovednik.space/material/stantsija-petropavlovsk):
~~~ ruby
class FeedE... -
- oops, that's right.
-
- Cygwin/mingw linker should be able to link against shared library
itself. Mswin build sets -def:$(DEFFILE) option by the default.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66196 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66195 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66194 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
10:54 AM Misc #15342: DevelopersMeeting20181212Japan
- [Feature [#15007](https://bugs.ruby-lang.org/issues/15007)] Proposal: Introduce support for cold function attributes (clang and GCC) - reduced scope PR https://github.com/ruby/ruby/pull/2005 (rb_memerror, rb_bug, rb_warn)
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66193 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- In test/ruby/test_regexp.rb and test/ruby/test_string.rb, change
some instances of COMBINING DIAERESIS (U+0308, above) to
COMBINING DIAERESIS BELOW (U+0324) to make it more easily visible
in test output, particularly in the context of do... -
- test which AppVeyor sometimes can't run.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66191 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I can not answer most of these question due to my own lack of knowledge but I agree
with mentioning it in NEWS and with some documentation - in particular I
think the most important mention may be what happens, or what should happen,
... -
06:38 AM Bug #15376 (Closed): Default gems: how will it work exactly?
- Some standard libraries will be gemified in Ruby 2.6+.
1) I believe we need to provide documentation for this. The NEWS file doesn't have much at all. The respective READMEs also have no relevant information and are misleading (see ht... -
- * array.c (ary_take_first_or_last): expected optional argument.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66190 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ko1 (Koichi Sasada) wrote:
>
> ...
Can you follow solutions here: https://stackoverflow.com/questions/22135792/permission-denied-to-create-extension-uuid-ossp
It's the same issue in that thread. -
- all right,
I read https://guides.rubyonrails.org/development_dependencies_install.html#mysql-and-postgresql (thanks Kaneko-san) and I make my username superuser.
I got same critical failure.
Thank you!
-
- Hi, next errors:
https://gist.github.com/ko1/3974289bd0b2686e0cf923301faab5cd
-
07:58 AM Bug #15377: rails unit tests get core dumped
- You can create "activerecord_unittest" database by running this command below:
$ cd activerecord
$ bundle exec rake db:postgresql:build
-
- Hi,
I want to reproduce it, but I got the following error.
> /home/ko1/ruby/tmp/rails/activerecord/lib/active_record/connection_adapters/postgresql_adapter.rb:50:in `rescue in postgresql_connection': FATAL: database "activerecord_... -
- I'm coming from https://github.com/rails/rails/issues/34606#issuecomment-443914170
Basically what happened is that rails Postgres tests started getting core dumped after this commit https://github.com/ruby/ruby/commit/a0e438cd3c28d2ea... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66189 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * Fixed https://github.com/rubygems/rubygems/pull/2506
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66188 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66187 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 06:53 AM Revision aca607a0 (git): unconstify cast to get rid of VC++ warnings
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66186 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66185 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 04:22 AM Revision 35ada33f (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66184 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 04:22 AM Revision 8891bb3b (git): Import bigdecimal-1.4.0.pre-20181204a
- * https://github.com/ruby/bigdecimal/compare/v1.4.0.pre.20181130a..v1.4.0.pre.20181204a
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66183 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 04:22 AM Revision 242ce4b1 (git): Revert "Symbol refinements"
- Due to assertion failures when VM_CHECK_MODE >= 2.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66182 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 04:22 AM Revision 01b20daa (git): Symbol refinements
- * vm_args.c (refine_sym_proc_call): enalbe accidentally disabled
refinements in Symbol#to_proc. [Bug #15114]
From: osyo (manga osyo) <manga.osyo@gmail.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66181 b2dd03c8-39d4-4d8f-... -
- In test/ruby/enc/test_emoji_breaks.rb, in method
TestEmojiBreaks#test_embedded_emoji, change the surrounding characters
from A/Z to the more neutral \t in preparation for upgrade to Unicode 11.0.0.
git-svn-id: svn+ssh://ci.ruby-lang.org... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66179 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- methodmissing (Lourens Naudé) wrote:
> https://github.com/ruby/ruby/pull/2005/files#diff-b6f26affdb29910802b4d97a901fe689R92
:+1: -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66178 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66177 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- On Solaris 10, `echo ~#{ENV['USER']}` As expected
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66176 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
12/03/2018
- 11:53 PM Revision a13b1f50 (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66175 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- This collapses:
```
== disasm: #<ISeq:bar@bench.rb:3 (3,0)-(5,3)> (catch: FALSE)
0000 putobject "a" ( 4)[LiCa]
0002 putobject "b"
0004 putobject ... -
- methodmissing (Lourens Naudé) wrote:
> methodmissing (Lourens Naudé) wrote:
> ...
Fallback to a definition in `defines.h` for clang and GCC 4.3.0+ only as MSVC didn't like the `NORETURN` + `COLDFUNC` combo for `rb_memerror`.
https:/... -
09:33 PM Feature #13483: TracePoint#enable with block for thread-local trace
- @ko1 Was there an update to this proposal?
- 09:00 PM Revision 7712ffc7 (git): process.c (retry_fork_async_signal_safe): fix -Wclobbered on i686
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66173 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
08:05 PM Bug #15375 (Closed): Crash report for Ruby 2.5.3p105
- Hello, Ruby 2.5.3 just crashed with a segfault in my Sidekiq worker. This is on my Mac OS Mojave, and I am using the jemalloc allocator. Ruby was installed using RVM.
I have attached "ruby-crash-report-logs.txt", which contains the ou... - 07:49 PM Revision d5598962 (git): * 2018-12-04
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66172 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 07:49 PM Revision a2264342 (git): process.c: fix ETXTBUSY from MJIT compiler process
- This affects test/ruby/test_process.rb (test_execopt_env_path).
Since MJIT uses vfork+execve in a separate thread, there can be
small window in-between vfork and execve where tmp_script.cmd is
held open by the vforked child. vfork only... -
07:25 PM Feature #15371: IRB with ARGV
- shevegen (Robert A. Heiler) wrote:
> By the way, I find it slightly amusing that python's "there is only
> ...
Its actually only 2 ways if you want a true REPL:
$ python3 -i - alpha beta gamma
>>> import sys
>>> sys.ar... -
- I can not say whether the above is a bug or not; however had a grep
shows that there are two toplevel methods for IRB to make use
of ARGV, both in init.rb:
init.rb: def IRB.setup(ap_path, argv: ::ARGV)
init.rb: def IRB.pa... -
- PHP allows you to pass ARGV in interactive mode:
$ php -a -- alpha beta gamma
php > print $argv[3] . PHP_EOL;
gamma
and Python offers 4 ways:
$ python3 - alpha beta gamma
>>> import sys
>>> print(sys.... -
- As I assume matz is quite busy right now, perhaps it should/could be added to the
upcoming developer meeting at:
https://bugs.ruby-lang.org/issues/15342
Now that the emoji (emo?) zombies wrestling with genies and faeries has been ... -
- i always like the fun you can do with method_missing, but for your example, method_missing always use a symbol for the name, so name.to_sym should just return self or did you do that on purpose?
-
- Proposal enable refinements to `#method_missing`.
It can be used in the following cases.
```ruby
# Access key value with method
using Module.new {
refine Hash do
# name is Symbol or String
def method_missing(name)
self[... -
02:18 PM Feature #15171: [patch] Use OpenSSL 1.1.1 for Appveyor MinGW build
- Sorry for the second message. I did not mention one thing that non Windows users may not be aware of.
Publicly facing Windows Ruby MinGW builds are all self contained. For instance, I locally test on Rubies from 2.2 thru trunk. Tho... -
- Update:
1. There have been several recent commits re OpenSSL 1.1.1 issues.
2. A new install of MSYS2 will install OpenSSL 1.1.1. A pacman update will do the same. To install an older version, one must download a package (outside ... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66170 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66169 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66168 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- This has been unused since r66124.
cc: @mrkn
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66167 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 12:36 PM Revision 888cdf60 (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66166 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * include/ruby/ruby.h: de-transient at
`RARRAY_PTR_USE` and `RARRAY_PTR_USE_START`.
Introduce `RARRAY_PTR_USE_TRANSIENT` and
`RARRAY_PTR_USE_START_TRANSIENT` if you don't want to
de-transient an array. Generally, it is difficult
... -
- in a new variable cc_common_args.
`cflags=-save-temps=obj` makes MJIT fail like:
https://rubyci.org/logs/www.rubyist.net/~akr/chkbuild/debian/ruby-trunk/log/20181203T095000Z.log.html.gz
This rubyci specifies -save-temps=obj in CFLAGS t... -
- 対応遅れてしまいすみません。
ありがとうございます。 -
- Applied in changeset trunk|r66149.
----------
Symbol refinements [Bug #15114] -
- * https://rubyci.org/logs/rubyci.s3.amazonaws.com/ubuntu/ruby-trunk/log/20181203T093003Z.fail.html.gz
* https://rubyci.org/logs/rubyci.s3.amazonaws.com/arch/ruby-trunk/log/20181203T090002Z.fail.html.gz
git-svn-id: svn+ssh://ci.ruby-la... -
- because we mostly use cc_path now and the comment is obsolete (CC_PATH
is now absolute path and the TODO is already resolved).
mjit.c: use CC_COMMON_ARGS[0] directly
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66162 b2dd03c8-39d4... -
- I think some of these changesets are required for stable branches to fix errors on RubyCI.
-
- Note: I attached full logs since some tests were taking way
longer than expected, too, but did not fail. For example:
TestGemRemoteFetcher#test_ssl_connection = 60.17 -
- I fixed a few in r66152 r66153 for webrick and drb.
There's many more than I have time to fix which affect the "openssl"
(which uses a proprietary bug tracker)
"net/*" fixtures need to be updated....
"rubygems" tests are taking... -
- * [Feature #15373] Proposal: Enable refinements to `#method` and `#instance_method`
* [Feature #15374] Proposal: Enable refinements to `#method_missing`
* I want to more refinements! -
- Thank you! shevegen :)
-
- I won't comment on the .: here and not about the first part
of the suggestions here either, but about .source_location
I agree as that would make sense (to me at the least).
Returning something that exists is better than returning
... -
- Proposal enable refinements to `#method` and `#instance_method`.
It can be used in the following cases.
```ruby
# default call to #pp
module P2PP
refine Kernel do
def p obj
pp obj
end
end
end
using P2PP
... -
- s/dimentional/dimensional
From: "yuuji.yaginuma" <yuuji.yaginuma@gmail.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66161 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- melentievm@gmail.com wrote:
> I can't use just `Thread#kill` to not stop thread while it runs `#process`.
> It works fine on macOS because `socket.close` makes read_from_socket fail with Errno::EBADF which is rescued later.
> However... -
09:42 AM Bug #15367: IO.select is not resumed when io-object gets closed
- I'm using `IO.select` with ssl socket as it's suggested in docs https://ruby-doc.org/core-2.5.3/IO.html#method-c-select :
~~~ruby
def read_from_socket
socket.read_nonblock(read_buffer_size)
rescue IO::WaitReadable
... -
- builtin echo of Solaris 10's sh doesn't expand `~`.
https://rubyci.org/logs/rubyci.s3.amazonaws.com/unstable10x/ruby-trunk/log/20181203T061807Z.fail.html.gz
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66160 b2dd03c8-39d4-4d8f-98ff... - 09:34 AM Revision 07a5db2c (git): spec/ruby/core/io/*_spec.rb: explain MJIT failures
- These random failures happen because FD number allocation
is not predictable when multiple threads are running (since
MJIT thread is opening/closing files all the time).
Real-world code practically never relies on predictable FD
number ... - 09:21 AM Revision 89455ff2 (git): NEWS: write about bigdecimal updates
- [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66158 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 09:15 AM Revision f8c15d0b (git): process.c (rb_execarg_init): mark as static
- io.c has not used it since r36229, and we can re-export
it if we need it at another time.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66157 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 08:57 AM Revision 323ddfc1 (git): process.c (rb_f_system): cleanup to use rb_execarg_get
- TypedData_* macros hide assignments and are confusing and too
long for users of giant fonts.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66156 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Due to assertion failures when VM_CHECK_MODE >= 2.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66155 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- mame@ruby-lang.org wrote:
> I understand that the warning will annoy normal non-programmer
> users. However, some of the users may report the warning to
> the author, which leads to the fix before the removal.
Some users will als... -
- I think that the warning is needed. People (at least, I) don't read documents. Even if I noticed, I cannot remember where my code uses String#crypt.
I understand that the warning will annoy normal non-programmer users. However, som... -
- I did not intend to close this ticket. What remains to be discussed is:
- Should we need to add warnings?
- If that is the case, when and how? -
- Applied in changeset trunk|r66154.
----------
string.c: [DOC] deprecate String#crypt [ci skip] [Feature #14915] -
- shyouhei@ruby-lang.org wrote:
> Well, it seems we do not agree whether we should add a
> warning. But is anybody against on documenting the
> deprecation? I think we can:
>
> - Consider String#crypt deprecated as of 2.6.
> - Ad... -
- Well, it seems we do not agree whether we should add a warning. But is anybody against on documenting the deprecation? I think we can:
- Consider String#crypt deprecated as of 2.6.
- Add NEWS about it.
- Add rdoc about it.
Can ... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66154 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 04:51 AM Revision fb0009cf (git): drb: fix tests on Debian sid/unstable with OpenSSL 1.1.1a
- OpenSSL complains abour our keys being small and weak :<
Make them big and strong with 2048-bit RSA keys and SHA256 digests
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66153 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 04:51 AM Revision a063f71a (git): webrick: fix tests on Debian sid/unstable with OpenSSL 1.1.1a
- OpenSSL complains abour our keys being small and weak :<
Make them big and strong with 2048-bit RSA keys and SHA256 digests
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66152 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * vm_args.c (refine_sym_proc_call): enalbe accidentally disabled
refinements in Symbol#to_proc. [Bug #15114]
From: osyo (manga osyo) <manga.osyo@gmail.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66151 b2dd03c8-39d4-4d8f-... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66150 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
04:40 AM Bug #15370: Array#=== in long running loop continually consumes more RAM
- Thanks both of you! :-) I saw some bad advice on StackOverflow and new that `case` worked as follows:
case 2
when *[1,2,3]
puts :winner
end
# => winner
So I had assumed it would work. My mistake. -
- `Array#===` is irrelevant. Your code executes `freq << sum` which extends the array and consumes the memory infinitely, even if you use `Array#member?`. The difference is that `Array#===` is much faster than `Array#member?`. Thus, the...
-
- `Array#===` is not `Array#member?`.
`freq` is an `Array` and `sum` is an `Integer`, so`freq === sum` always returns `false` then `cycle` loops and `freq << sum` repeats forever. -
- I was doing a code challenge and trying to use as few characters as possible (not shown). So instead of using `Array#member?` I tried `Array#===` and it consumed my system's RAM once I switched to that.
The good code here:
fre... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66149 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- MSP-Greg (Greg L) wrote:
> I'm not sure about the effect of short file names. If `test` is a string, and `File.exist? test` is true, then the following should work?
> ...
As far as `test` contains alphabets, yes, probably.
Or maybe `... -
- nobu (Nobuyoshi Nakada) wrote:
> You can't compare path names just by case-insensitiveness, on Windows.
> ...
Thank you for the mention of `File.indentical?`, as I have never noticed that method. Using `File.exist?` does correctly ide... -
- You can't compare path names just by case-insensitiveness, on Windows.
Consider short file names.
You can compare them by `File.identical?` instead, or should use `File.expand_path` before comparison at least. -
- * enumerator.c (enum_chain_total_size): use RARRAY_AREF
instead of RARRAY_PTR_USE because we don't need non-const
ptr.
* enumerator.c (enum_chain_each): ditto.
* enumerator.c (enum_chain_rewind): ditto.
git-svn-id: svn+ssh://ci.r... -
03:40 AM Feature #14183: "Real" keyword argument
- mame (Yusuke Endoh) wrote:
> And, this is a new topic. There is an non-Symbol-key call, like `where("table.id" => 1)` (which was shown by Jeremy Evans). This is difficult to change to keyword argument. To allow this, matz came up wit... -
- I talked with matz about this proposal at Keep Ruby Weird conference (more precisely, Franklin BBQ at Austin). As far as I understand, Matz currently likes syntactical separation of keyword and normal arguments. (Note that it is not de...
-
- From https://github.com/MSP-Greg/ruby/commit/316f60e3befa312320b2cc600d7b59ba64f12329
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66147 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- [Bug #15322]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66146 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:34 AM Bug #15322 (Closed): Time.strptime does not support %3N, %6N, %9N
- Applied in changeset trunk|r66145.
----------
time.rb: remove the unsupported formatting options from the document [ci skip]
Time.strptime does not support %3N, %6N, and %9N.
close [Bug #15322] -
- Thank you for comments. I will commit the patch.
-
- Time.strptime does not support %3N, %6N, and %9N.
close [Bug #15322]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66145 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- The tarball will be reduced by about 568 kB.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66144 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Fixed at r66143. Thanks.
-
- I think `nil` in output is not expetced.
```
% rbenv exec irb --simple-prompt -r irb/completion
>> pp(1..)
1..nil
=> 1..
``` -
- `pp(1..)` should print `"(1..)"` instead of `"(1..nil)"`.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66143 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ast.c (rb_ast_node_type): simplified to return a Symbol without
"NODE_" prefix.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66142 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66141 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66140 b2dd03c8-39d4-4d8f-98ff-823fe69b080e