Activity
From 11/30/2018 to 12/06/2018
12/06/2018
-
11:51 PM Revision 29730310 (git): Dump more timestamps
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66265 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
11:26 PM Revision 33dab9cd (git): accept_loop_spec.rb: avoid random hang
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66264 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- by Bundler.
http://ci.rvm.jp/results/trunk-vm-asserts@silicon-docker/1500762
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66263 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r66262.
----------
Warn redefinitions of some methods on Object
[Bug #5473] [Bug #14670] [Bug #15382] -
- [Bug #5473] [Bug #14670] [Bug #15382]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66262 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66261 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
09:56 PM Revision 3a94b881 (git): should not use Microsoft Internet Controller
- * spec/ruby/library/win32ole/win32ole_method/helpcontext_spec.rb:
Use FileSystemObject. Microsoft Internet Explorer is not available
in some environment.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66260 b2dd03c8-39d4-4d8f-98f... - 06:28 PM Revision 2f1c9e2a (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66259 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
06:28 PM Revision 2f378478 (git): Speed up hash literals by duping
- This commit replaces the `newhashfromarray` instruction with a `duphash`
instruction. Instead of allocating a new hash from an array stored in
the Instruction Sequences, store a hash directly in the instruction
sequences and dup it on e... - 06:20 PM Revision 00a31080 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66257 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Co-Authored-By: Krzysztof Rybka <krzysztof.rybka@gmail.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66256 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
05:47 PM Bug #15388 (Closed): CSV parsing behaviour in > 2.5.0
- Hi,
It seems like CSV library in 2.5.0 is not behaving as intended while parsing.
~~~ ruby
header = ["A", "B", "C", "D", "E", "F", "G", "H", "I", "J", "K", "L", "M", "N", "O", "P", "Q"]
csv_str = "10.4710|859.5170|9000.0000|Y||... -
04:29 PM Bug #15114: Ruby で定義したメソッドに `&:hoge` を渡しても refinements が有効にならない
- ありがとうございます。
こちらでも再現できたのでもう少し調査してみます。 - 03:33 PM Revision ea921abd (git): * 2018-12-07
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66255 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:33 PM Revision 0cee9e98 (git): Add missing declaration to export
- Additional fix for r66200:
https://rubyci.org/logs/rubyci.s3.amazonaws.com/icc-x64/ruby-trunk/log/20181206T130002Z.fail.html.gz
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66254 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:56 PM Revision 1692ccaf (git): add NEWS entries about script_compiled event
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66252 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66251 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Applied in changeset trunk|r66249.
----------
`script_compiled` TracePoint event [Feature #15287]
* vm_trace.c: add `script_compiled` event. This event invoked
after script compiling and before evaluating compiled script.
Also the ... - 01:42 PM Revision a352ee89 (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66250 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * vm_trace.c: add `script_compiled` event. This event invoked
after script compiling and before evaluating compiled script.
Also the following methods are added:
`TracePoint#compiled_instruction_sequence` method to get compiled
... -
01:19 PM Revision 586e018c (git): Added News entries about RubyGems and Bundler.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66248 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66247 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:14 PM Bug #15387 (Closed): Backport r66242 (io.c (io_write_nonblock): add RB_GC_GUARD, io_fflush may switch threads)
- This is a ticket for backport management.
-
11:38 AM Bug #15386 (Open): [PATCH] io.c (rb_io_check_char_readable): do not io_fflush buffered sockets
- ```
This is a rare corner-case probably nobody cares about. (because
socket has IO#sync=false by default). Not critical to fix
or change before 2.6 (I'm not sure if there's a compatibility risk).
Would much appreciate an extra set... -
- r66228 merged https://github.com/ruby/ruby/pull/2005/files#diff-b6f26affdb29910802b4d97a901fe689R92, thanks!
-
- * iseq.c: before this patch, RubyVM::InstructionSequence.of(src) (ISeq in
short) returns different ISeq (wrapper) objects point to one ISeq internal
object. This patch changes this behavior to cache created ISeq (wrapper)
objects a... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66245 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:41 AM Revision 0d4ba7b5 (git): io.c (io_fflush): eliminate redundant rb_io_check_closed
- There is no need to call this function twice in a row since
thread switching won't happen in-between calls to it.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66244 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 10:09 AM Revision aa6dfe71 (git): NEWS: fix typo (maesured => measured) [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66243 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:09 AM Revision 48324dd4 (git): io.c (io_write_nonblock): add RB_GC_GUARD, io_fflush may switch threads
- Since io_fflush may block on mutex or rb_io_wait_readable and
switch threads, we need to ensure the `str' VALUE returned by
`rb_obj_as_string` is visible to GC.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66242 b2dd03c8-39d4-4d8f-... -
- Though internal.h has the prototype, it still shows symbol lookup error...
https://rubyci.org/logs/rubyci.s3.amazonaws.com/icc-x64/ruby-trunk/log/20181206T050002Z.fail.html.gz
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66241 b2dd... -
09:54 AM Revision 9d170240 (git): remove an unused variable
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66240 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- regparse.c: In function node_extended_grapheme_cluster(), use function-global
array node_common and use it for list and alternate construction. This is done
so that in case of error, all nodes that have already been constructed can be
co... -
08:37 AM Feature #15230: RubyVM.resolve_feature_path
- It returns false as path when feature is already loaded.
Is it intentional?
```
% rbenv exec irb --simple-prompt -r irb/completion
>> RubyVM.resolve_feature_path('set')
=> [:rb, false]
``` -
06:40 AM Feature #15230 (Closed): RubyVM.resolve_feature_path
- Applied in changeset trunk|r66237.
----------
load.c (RubyVM.resolve_feature_path): New method. [Feature #15230] -
07:49 AM Feature #15378: URI::InvalidURIError (bad URI(is not URI?)
- Thank you!
What do you think is the problem with the encoding?
-
12:42 AM Feature #15378 (Third Party's Issue): URI::InvalidURIError (bad URI(is not URI?)
- ipatovanton (Anton Ipatov) wrote:
> ~~~ ruby
> ...
Thank you!
The problem is the "\n" at the very beginning of `self.url`. This is in fact a bad URI.
To fix this, please remove that before calling `URI()`. -
- Especially over checking argc then calling rb_scan_args just to
raise an ArgumentError.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66238 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66237 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
-
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66236 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66235 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
05:25 AM Bug #15385: Ruby process hang in ensure
- This reproduces even without timeout library.
~~~ ruby
def doh
raise
ensure
123 if false
end
doh
~~~
looks like this is because the optimizer removed `if false` or `if nil` without adding `nop` iseq. -
01:40 AM Bug #15385 (Closed): Ruby process hang in ensure
- While playing with mutation testing of my code I've found a weird mutation that hangs Ruby process. The isolated code which triggers this freeze is:
~~~ ruby
require 'timeout'
puts Process.pid
def raise_before_returning
ra... -
- In regparse.c:
* Reduce coode duplication by merging the almost identical functions
create_sequence_node and create_alternate_node into a new function
create_node_from_array, adding a parameter that distinguishes between
creating... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66233 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
-
- * unicode.c: Remove the arrays onigenc_unicode_GCB_ranges_GAZ,
onigenc_unicode_GCB_ranges_E_Base, and onigenc_unicode_GCB_ranges_Emoji,
because they are not needed anymore for Unicode 11.0.0.
* regparse.c: Remove external declaratio...
12/05/2018
-
10:11 PM Feature #15380: faster method lookup for Array#all? #none? #one?
- @nobu can you close this?
-
06:23 AM Feature #15380: faster method lookup for Array#all? #none? #one?
- While I agree with Koichi in regards to benchmarks and more code
meaning more maintenance work (naturally), I think it should still
be considered for the trade off being potentially worth it. If there
is time for discussion at the ne... -
- If we introduce special versions for Array, some new code are introduced.
It means the code we need to maintain will be increased.
I think about 20% improvement is not worth compare with the disadvantage.
BTW, I don't check the pa... -
04:26 AM Feature #15380 (Open): faster method lookup for Array#all? #none? #one?
- ## summary
This PR proposes Array-specific implementations for `#all?` , `#none?` and `#one?` to enable faster method lookup.
Before this patch `Array#all?` was not implemented in Array class, so alternatively, `Enumerable#all?` wa... -
09:30 PM Feature #15331: [PATCH] Faster hashing for short string literals
- Is there anything I can do to move this forward?
-
- mbj@schirp-dso.com wrote:
> Just curious, is there an associated CI build for these changes?
I check https://rubyci.org/ and http://ci.rvm.jp/ (and get
automated mails from the latter).
There's also TravisCI; but I don't use Jav... -
07:37 PM Bug #15383: Reproducible crash: crash.rb:6: [BUG] unexpected THREAD_KILLED
- Thanks for the quick fix. Also for marking the fix to be backported.
Just curious, is there an associated CI build for these changes? -
- > https://bugs.ruby-lang.org/issues/15383
Thanks, it affects trunk; just more difficult to reproduce
because of thread cache.
I'm a moron for not noticing this when I fixed other bugs :<
r66230 should fix it in trunk and shoul... -
- Applied in changeset trunk|r66230.
----------
thread_sync.c (mutex_ptr): handle mutexes held by parent threads in children
Mutexes may be held by threads which only exist in the parent
process, so their waitqueues may be populated with... -
- Hi,
I'm reporting a reliable crash of the ruby interpreter on contested mutexeses that are accessed in child processes.
I currently think that this happens as the child processes main thread, may be waiting for a parent process sib... -
- ~~~ ruby
RuntimeError ("\nhttp://zapovednik.space/material/stantsija-petropavlovsk"):
~~~
-
- Can I ask you the exact representation of the self.url parameter, not just its printable part? I guess it contains control character, most likely newlines.
just add `raise self.uri.inspect` right before the line you are getting the ex... - 07:01 PM Revision 7eb5775f (git): Revert "fix typoe of r66200"
- This reverts r66229 (commit e941daa6dd114b52356a63d3c3db5684e6c66717)
Many CI failures on this:
http://ci.rvm.jp/results/trunk-jemalloc@silicon-docker/1497858
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66231 b2dd03c8-39d4-4d8f-9... - 06:58 PM Revision 818f1c65 (git): thread_sync.c (mutex_ptr): handle mutexes held by parent threads in children
- Mutexes may be held by threads which only exist in the parent
process, so their waitqueues may be populated with references
to other dead threads. We must reset them at fork.
I am a moron for introducing this bug :<
[ruby-core:90312] ... -
- Agree on the "one rather than two". It is probably redundant after the merge.
I can't answer the second sentence since there may have been (different?)
reasons for adding certificates - but it would make sense to require only
one ra... -
02:33 PM Bug #15384 (Closed): ssl_certs are duplicated in RubyGems and Bundler
- It is pity that the same ssl_certs are shipped on multiple places, once as part of RubyGems and the other set as part of Bundler. This makes the security review much harder (actually, in Fedora/RHEL packages, we are not supposed to ship ...
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66229 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * include/ruby/defines.h: introduce "COLDFUNC" function attribute
on several compilers for called unlikely functions.
Apply to rb_memerror, rb_warn and rb_bug.
A patch form methodmissing <lourens@bearmetal.eu>.
git-svn-id: svn+... -
- I personally don't see an issue with this spec, besides that it would introduce a breaking change one way or the other. I think it would fix the `next` command in byebug, though. (it would have to rescue when it calls #return_value, thou...
-
- or `raise` on `return_value` ?
it is irregular case. I think tailcall is not normal call (it is same as a method call by lexicial).
```
foo() # tailcall
```
we can see:
```
return_and_call(:foo)
```
and nobody think it... -
- If we return `nil` for `#return_value`, users can't tell whether the nil is from the method actually returning nil, or a `nil` from tailcall.
I think the return event should be reserved for only real returns, because of its name.
I d... -
- Yes, the patch should return `nil` (I forgot to support it).
I think we can change the semantic of tailcall as a method call/return flow I proposed.
What kind of issue on this change?
-
- The main concern I have with this approach is that there is no reasonable value we can make `Tracepoint#return_value` return when we trigger it due to a tailcall:
```
def bar
:"bar's return value"
end
iseq = RubyVM::Instructio... -
- hi,
how about to call `return` event hook at tailcall? There is no need to introduce new API proposed at [Bug #15313].
```
def bar
end
iseq = RubyVM::InstructionSequence.new("def foo; bar; end", __FILE__, __FILE__, __LINE__, t... -
- Overwriting these methods also should be warned, as `Object#initialize`?
https://github.com/nobu/ruby/pull/new/bug/15382-warn-redef -
- Briefly investigated. This is an infinite recursion.
Simplified version:
def respond_to_missing?(s, f)
0 + "foo"
end
0.respond_to?(:foo)
`0 + "foo"` calls `coerce`, which calls `respond_to_missing?` recursi... -
12:07 PM Bug #15382 (Closed): Stack overflow in int_or()
- After some fuzz testing I found a crashing test case.
To reproduce: miniruby ruby_so_int_or
Full ASAN report: https://gist.github.com/fumfel/0a2e01f2ab6794632d017bfd306ffac9
ASAN report:
~~~
==22120==ERROR: AddressSanitizer:... -
- I found `each` does not call `Array.try_convert` so only `for` is affected by redefinition of that method.
```
$ ruby -e 'a = [Struct.new(:to_ary).new([1, 2])]; def Array.try_convert(*);raise;end;a.each {|i, j| p [i, j]}; for i, j in... - 04:15 PM Revision 756914e5 (git): * 2018-12-06
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66227 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * configure.ac (check broken_backtrace code): fix decl. position
error because of `-Werror=declaration-after-statement`.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66226 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:46 PM Bug #14959: Writing a "link_to" method and a "url_helper" with a request parameter under certain "if else" statement in Rails helper crashes with KERN_INVALID_ADDRESS at 0x0000000000000000
- nobu (Nobuyoshi Nakada) wrote:
> The same issue is already marked to backport in #14897.
> ...
I'm still seeing the problem in 2.5.3, so I'm guessing this was never backported? Will it be? -
- normalperson (Eric Wong) wrote:
> cremno@mail.ru wrote:
> ...
To link non msvcrt.dll (msvcrXX and vcruntime), it requires related version of Visual C++ compiler.
Anyway as far as I understand, it already doesn't work with VC6,
And... -
- ruby_2_5 r66225 merged revision(s) 64736,65567.
-
- iseq.c: prefix rb_ to non-static iseq functions
I assume we always prefix rb_ to non-static functions to avoid conflict.
These functions are not exported and safe to be renamed.
iseq.h: ditto
compile.c: ... -
- `make DEFS=-DVM_CHECK_MODE=2 check` で落ちます。
-
- I myself have used *foobar quite a lot in ruby code, such as in:
def foobar(*args)
args.each # and do something then
end
and I have also used &: considerably often too. The most frequent
use case for me personally ... -
08:28 AM Feature #15381: Let double splat call `to_h` implicitly
- Sorry, I meant `to_h`, not `to_hash`.
And in case my intention was not clear, in the example I gave for the double splat, I expected `**nil` to be evaluated as `**{}` due to `nil.to_h # => {}`. -
- The single splat calls `to_a` implicitly on the object (if it is not an array already) so that, for example, we have the convenience of writing conditions in an array literal:
```ruby
a = [
*(:foo if some_condition),
*(:bar if ... - 11:30 AM Revision 5fa8b95d (git): NEWS: update about bigdecimal [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66224 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 11:30 AM Revision 10492c2b (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66223 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 11:30 AM Revision 2810c12a (git): Import bigdecimal 1.4.0.pre.20181205a
- * https://github.com/ruby/bigdecimal/compare/74d25ef..v1.4.0.pre.20181205a
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66222 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 11:29 AM Revision ae88d2fc (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66221 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- This reverts commit 3f708604920f2fd7a105d5f092240737add15ef1.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66220 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- see r65979
[Bug #15291][ruby-dev:50663]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66219 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66218 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66217 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66216 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Applied in changeset trunk|r66215.
----------
lib/monitor.rb: prevent to initialize MonitorMixin twice
and allow to initialize again when obj.dup.
Suggested by Benoit Daloze. [ruby-core:88504] [Feature #15000] -
- and allow to initialize again when obj.dup.
Suggested by Benoit Daloze. [ruby-core:88504] [Feature #15000]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66215 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66214 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Noted. I'll keep deadlock checking and see about implementing
it for auto-fiber (if I continue working on that).
I don't like deadlock checking at all (since I don't want a
nanny programming language), but I'll go along with it if... -
- - common.mk: Change Unicode version to 11.0.0, and Emoji version to 11.0
- test/ruby/enc/test_emoji_breaks.rb: update hard-coded Emoji version
- enc/unicode/11.0.0, enc/unicode/11.0.0/casefold.h, enc/unicode/name2ctype.h:
Add generated... -
07:26 AM Bug #15377: rails unit tests get core dumped
- ko1 (Koichi Sasada) wrote:
> Now recent BigDecimal changes were reverted, and I passed tests now.
> ...
Great! thanks :) -
- Now recent BigDecimal changes were reverted, and I passed tests now.
> Finished in 448.578323s, 15.3998 runs/s, 40.4946 assertions/s.
> ...
mrkn will fix this issue and will re-introduce them.
-
- I mean "critical failure" is your issue (double free).
I could reproduce it. And it seems BigDecimal issue.
If you find more shorter reproducing process, it will help us.
Thanks,
Koichi -
- Matz agreed about naming of "script_compiled".
If others especially English natives have ideas, please tell me.
If no, I'll commit "script_compiled" event some days later.
----
I'm reconsidering "method_added" event because the... -
- how about https://bugs.ruby-lang.org/issues/15303#note-2 ?
-
- Could I ask for some feedback on this?
-
- Before this patch Array#all? was not implemented in Array class
and alternatively Enumerable#all? was used, while #any? has its
own method entry in Array class. Similarly, Array#none? and #one?
also lacks its own implementation.
This pa... - 04:01 AM Revision 7841cb1e (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66211 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 04:01 AM Revision f15cf091 (git): Revert bigdecimal 1.4.0 related commits
- * Revert "Remove unnecessary linker flags"
This reverts commit 49efa01579272d52d28bd361c498d96ca92e986e.
* Revert "Move dependency on gemspec"
This reverts commit bfb64d476578eadd61a738149726da37840f068d.
* Revert "Remove unneces... -
- test-unit-3.2.8 to 3.2.9
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66209 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r66208.
----------
Fix documentation for Warning.warn [ci skip]
Warning.warn does not add any newlines to the message argument.
[Bug #15379]
From: Olle Jonsson <olle.jonsson@gmail.com> -
- Warning.warn does not add any newlines to the message argument.
[Bug #15379]
From: Olle Jonsson <olle.jonsson@gmail.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66208 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- So `struct nmin_data` size is reduced.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66207 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66206 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66205 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
12/04/2018
-
- It's release version of Bundler 2
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66204 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 11:10 PM Revision 76d9da90 (git): mjit.c: remove init_list
- It is not needed since we have LIST_HEAD_INIT initializer in
mjit_worker.c
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66203 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- nobu (Nobuyoshi Nakada) wrote:
> テストでクラッシュするため、一旦revertしました。
パッチを作成してからだいぶ時間が経っていたので手元で `rebase trunk` して最新版を pull request してみましたがこちらは CI が通っていますね。
pull request : https://github.com/ruby/ruby/pull/2039 -
- テストでクラッシュするため、一旦revertしました。
- 10:19 PM Revision d612c44d (git): Enable MJIT on AIX
- * configure.ac: disable using __builtin_setjmp to avoid errors when execution
globally jumps out of JITted code. Specify -std=gnu99 to JIT compilation
to avoid errors regarding the "restrict" keyword in the precompiled header.
Spec... -
08:46 PM Feature #15350: [PATCH] thread_sync.c (queue_sleep): remove deadlock checking
- I agree with Jeremy, that dropping the deadlock detection from `Queue#pop` would be pity. It's a lot easier if you get a clear error message, than debugging a starvation in your process.
A common mistake in [Eventbox](https://github.c... -
08:42 PM Feature #14385: Deprecate back-tick for Ruby 3.
- Eregon (Benoit Daloze) wrote:
> IMHO this is way too incompatible and using %x{} only makes it less nice/readable/intuitive.
> ...
You use the same symbol "`" for the begining and the end of the instruction which is not a good thing to... - 06:48 PM Revision 2dd614af (git): * 2018-12-05
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66201 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Without this icc fails to run.
http://rubyci.s3.amazonaws.com/icc-x64/ruby-trunk/log/20181203T130002Z.diff.html.gz
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66200 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
05:46 PM Bug #15379 (Closed): [PATCH] Fix documentation for Warning.warn
- Warning.warn does not add any newlines to the message argument, this just makes the documentation reflect that.
The new documentation matches the spec in ruby/core/warning/warn_spec.rb. -
- https://travis-ci.org/ruby/ruby/jobs/463317607
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66199 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * https://github.com/ruby/psych/pull/379
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66198 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- which was accidentally reverted by r65904
158562dabb197d6efc53cabe6662177c6ec3f43e
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66197 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I using the ruby 2.5.3 and try to save this url http://zapovednik.space/material/stantsija-petropavlovsk
URI::InvalidURIError (bad URI(is not URI?):
http://zapovednik.space/material/stantsija-petropavlovsk):
~~~ ruby
class FeedE... -
- oops, that's right.
-
- Cygwin/mingw linker should be able to link against shared library
itself. Mswin build sets -def:$(DEFFILE) option by the default.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66196 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66195 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66194 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
10:54 AM Misc #15342: DevelopersMeeting20181212Japan
- [Feature [#15007](https://bugs.ruby-lang.org/issues/15007)] Proposal: Introduce support for cold function attributes (clang and GCC) - reduced scope PR https://github.com/ruby/ruby/pull/2005 (rb_memerror, rb_bug, rb_warn)
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66193 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- In test/ruby/test_regexp.rb and test/ruby/test_string.rb, change
some instances of COMBINING DIAERESIS (U+0308, above) to
COMBINING DIAERESIS BELOW (U+0324) to make it more easily visible
in test output, particularly in the context of do... -
- test which AppVeyor sometimes can't run.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66191 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I can not answer most of these question due to my own lack of knowledge but I agree
with mentioning it in NEWS and with some documentation - in particular I
think the most important mention may be what happens, or what should happen,
... -
06:38 AM Bug #15376 (Closed): Default gems: how will it work exactly?
- Some standard libraries will be gemified in Ruby 2.6+.
1) I believe we need to provide documentation for this. The NEWS file doesn't have much at all. The respective READMEs also have no relevant information and are misleading (see ht... -
- * array.c (ary_take_first_or_last): expected optional argument.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66190 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ko1 (Koichi Sasada) wrote:
>
> ...
Can you follow solutions here: https://stackoverflow.com/questions/22135792/permission-denied-to-create-extension-uuid-ossp
It's the same issue in that thread. -
- all right,
I read https://guides.rubyonrails.org/development_dependencies_install.html#mysql-and-postgresql (thanks Kaneko-san) and I make my username superuser.
I got same critical failure.
Thank you!
-
- Hi, next errors:
https://gist.github.com/ko1/3974289bd0b2686e0cf923301faab5cd
-
07:58 AM Bug #15377: rails unit tests get core dumped
- You can create "activerecord_unittest" database by running this command below:
$ cd activerecord
$ bundle exec rake db:postgresql:build
-
- Hi,
I want to reproduce it, but I got the following error.
> /home/ko1/ruby/tmp/rails/activerecord/lib/active_record/connection_adapters/postgresql_adapter.rb:50:in `rescue in postgresql_connection': FATAL: database "activerecord_... -
- I'm coming from https://github.com/rails/rails/issues/34606#issuecomment-443914170
Basically what happened is that rails Postgres tests started getting core dumped after this commit https://github.com/ruby/ruby/commit/a0e438cd3c28d2ea... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66189 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * Fixed https://github.com/rubygems/rubygems/pull/2506
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66188 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66187 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 06:53 AM Revision aca607a0 (git): unconstify cast to get rid of VC++ warnings
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66186 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66185 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 04:22 AM Revision 35ada33f (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66184 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 04:22 AM Revision 8891bb3b (git): Import bigdecimal-1.4.0.pre-20181204a
- * https://github.com/ruby/bigdecimal/compare/v1.4.0.pre.20181130a..v1.4.0.pre.20181204a
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66183 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 04:22 AM Revision 242ce4b1 (git): Revert "Symbol refinements"
- Due to assertion failures when VM_CHECK_MODE >= 2.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66182 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 04:22 AM Revision 01b20daa (git): Symbol refinements
- * vm_args.c (refine_sym_proc_call): enalbe accidentally disabled
refinements in Symbol#to_proc. [Bug #15114]
From: osyo (manga osyo) <manga.osyo@gmail.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66181 b2dd03c8-39d4-4d8f-... -
- In test/ruby/enc/test_emoji_breaks.rb, in method
TestEmojiBreaks#test_embedded_emoji, change the surrounding characters
from A/Z to the more neutral \t in preparation for upgrade to Unicode 11.0.0.
git-svn-id: svn+ssh://ci.ruby-lang.org... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66179 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- methodmissing (Lourens Naudé) wrote:
> https://github.com/ruby/ruby/pull/2005/files#diff-b6f26affdb29910802b4d97a901fe689R92
:+1: -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66178 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66177 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- On Solaris 10, `echo ~#{ENV['USER']}` As expected
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66176 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
12/03/2018
- 11:53 PM Revision a13b1f50 (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66175 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- This collapses:
```
== disasm: #<ISeq:bar@bench.rb:3 (3,0)-(5,3)> (catch: FALSE)
0000 putobject "a" ( 4)[LiCa]
0002 putobject "b"
0004 putobject ... -
- methodmissing (Lourens Naudé) wrote:
> methodmissing (Lourens Naudé) wrote:
> ...
Fallback to a definition in `defines.h` for clang and GCC 4.3.0+ only as MSVC didn't like the `NORETURN` + `COLDFUNC` combo for `rb_memerror`.
https:/... -
09:33 PM Feature #13483: TracePoint#enable with block for thread-local trace
- @ko1 Was there an update to this proposal?
- 09:00 PM Revision 7712ffc7 (git): process.c (retry_fork_async_signal_safe): fix -Wclobbered on i686
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66173 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
08:05 PM Bug #15375 (Closed): Crash report for Ruby 2.5.3p105
- Hello, Ruby 2.5.3 just crashed with a segfault in my Sidekiq worker. This is on my Mac OS Mojave, and I am using the jemalloc allocator. Ruby was installed using RVM.
I have attached "ruby-crash-report-logs.txt", which contains the ou... - 07:49 PM Revision d5598962 (git): * 2018-12-04
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66172 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 07:49 PM Revision a2264342 (git): process.c: fix ETXTBUSY from MJIT compiler process
- This affects test/ruby/test_process.rb (test_execopt_env_path).
Since MJIT uses vfork+execve in a separate thread, there can be
small window in-between vfork and execve where tmp_script.cmd is
held open by the vforked child. vfork only... -
07:25 PM Feature #15371: IRB with ARGV
- shevegen (Robert A. Heiler) wrote:
> By the way, I find it slightly amusing that python's "there is only
> ...
Its actually only 2 ways if you want a true REPL:
$ python3 -i - alpha beta gamma
>>> import sys
>>> sys.ar... -
- I can not say whether the above is a bug or not; however had a grep
shows that there are two toplevel methods for IRB to make use
of ARGV, both in init.rb:
init.rb: def IRB.setup(ap_path, argv: ::ARGV)
init.rb: def IRB.pa... -
- PHP allows you to pass ARGV in interactive mode:
$ php -a -- alpha beta gamma
php > print $argv[3] . PHP_EOL;
gamma
and Python offers 4 ways:
$ python3 - alpha beta gamma
>>> import sys
>>> print(sys.... -
- As I assume matz is quite busy right now, perhaps it should/could be added to the
upcoming developer meeting at:
https://bugs.ruby-lang.org/issues/15342
Now that the emoji (emo?) zombies wrestling with genies and faeries has been ... -
- i always like the fun you can do with method_missing, but for your example, method_missing always use a symbol for the name, so name.to_sym should just return self or did you do that on purpose?
-
- Proposal enable refinements to `#method_missing`.
It can be used in the following cases.
```ruby
# Access key value with method
using Module.new {
refine Hash do
# name is Symbol or String
def method_missing(name)
self[... -
02:18 PM Feature #15171: [patch] Use OpenSSL 1.1.1 for Appveyor MinGW build
- Sorry for the second message. I did not mention one thing that non Windows users may not be aware of.
Publicly facing Windows Ruby MinGW builds are all self contained. For instance, I locally test on Rubies from 2.2 thru trunk. Tho... -
- Update:
1. There have been several recent commits re OpenSSL 1.1.1 issues.
2. A new install of MSYS2 will install OpenSSL 1.1.1. A pacman update will do the same. To install an older version, one must download a package (outside ... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66170 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66169 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66168 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- This has been unused since r66124.
cc: @mrkn
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66167 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 12:36 PM Revision 888cdf60 (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66166 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * include/ruby/ruby.h: de-transient at
`RARRAY_PTR_USE` and `RARRAY_PTR_USE_START`.
Introduce `RARRAY_PTR_USE_TRANSIENT` and
`RARRAY_PTR_USE_START_TRANSIENT` if you don't want to
de-transient an array. Generally, it is difficult
... -
- in a new variable cc_common_args.
`cflags=-save-temps=obj` makes MJIT fail like:
https://rubyci.org/logs/www.rubyist.net/~akr/chkbuild/debian/ruby-trunk/log/20181203T095000Z.log.html.gz
This rubyci specifies -save-temps=obj in CFLAGS t... -
- 対応遅れてしまいすみません。
ありがとうございます。 -
- Applied in changeset trunk|r66149.
----------
Symbol refinements [Bug #15114] -
- * https://rubyci.org/logs/rubyci.s3.amazonaws.com/ubuntu/ruby-trunk/log/20181203T093003Z.fail.html.gz
* https://rubyci.org/logs/rubyci.s3.amazonaws.com/arch/ruby-trunk/log/20181203T090002Z.fail.html.gz
git-svn-id: svn+ssh://ci.ruby-la... -
- because we mostly use cc_path now and the comment is obsolete (CC_PATH
is now absolute path and the TODO is already resolved).
mjit.c: use CC_COMMON_ARGS[0] directly
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66162 b2dd03c8-39d4... -
- I think some of these changesets are required for stable branches to fix errors on RubyCI.
-
- Note: I attached full logs since some tests were taking way
longer than expected, too, but did not fail. For example:
TestGemRemoteFetcher#test_ssl_connection = 60.17 -
- I fixed a few in r66152 r66153 for webrick and drb.
There's many more than I have time to fix which affect the "openssl"
(which uses a proprietary bug tracker)
"net/*" fixtures need to be updated....
"rubygems" tests are taking... -
- * [Feature #15373] Proposal: Enable refinements to `#method` and `#instance_method`
* [Feature #15374] Proposal: Enable refinements to `#method_missing`
* I want to more refinements! -
- Thank you! shevegen :)
-
- I won't comment on the .: here and not about the first part
of the suggestions here either, but about .source_location
I agree as that would make sense (to me at the least).
Returning something that exists is better than returning
... -
- Proposal enable refinements to `#method` and `#instance_method`.
It can be used in the following cases.
```ruby
# default call to #pp
module P2PP
refine Kernel do
def p obj
pp obj
end
end
end
using P2PP
... -
- s/dimentional/dimensional
From: "yuuji.yaginuma" <yuuji.yaginuma@gmail.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66161 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- melentievm@gmail.com wrote:
> I can't use just `Thread#kill` to not stop thread while it runs `#process`.
> It works fine on macOS because `socket.close` makes read_from_socket fail with Errno::EBADF which is rescued later.
> However... -
09:42 AM Bug #15367: IO.select is not resumed when io-object gets closed
- I'm using `IO.select` with ssl socket as it's suggested in docs https://ruby-doc.org/core-2.5.3/IO.html#method-c-select :
~~~ruby
def read_from_socket
socket.read_nonblock(read_buffer_size)
rescue IO::WaitReadable
... -
- builtin echo of Solaris 10's sh doesn't expand `~`.
https://rubyci.org/logs/rubyci.s3.amazonaws.com/unstable10x/ruby-trunk/log/20181203T061807Z.fail.html.gz
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66160 b2dd03c8-39d4-4d8f-98ff... - 09:34 AM Revision 07a5db2c (git): spec/ruby/core/io/*_spec.rb: explain MJIT failures
- These random failures happen because FD number allocation
is not predictable when multiple threads are running (since
MJIT thread is opening/closing files all the time).
Real-world code practically never relies on predictable FD
number ... - 09:21 AM Revision 89455ff2 (git): NEWS: write about bigdecimal updates
- [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66158 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 09:15 AM Revision f8c15d0b (git): process.c (rb_execarg_init): mark as static
- io.c has not used it since r36229, and we can re-export
it if we need it at another time.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66157 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 08:57 AM Revision 323ddfc1 (git): process.c (rb_f_system): cleanup to use rb_execarg_get
- TypedData_* macros hide assignments and are confusing and too
long for users of giant fonts.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66156 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Due to assertion failures when VM_CHECK_MODE >= 2.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66155 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- mame@ruby-lang.org wrote:
> I understand that the warning will annoy normal non-programmer
> users. However, some of the users may report the warning to
> the author, which leads to the fix before the removal.
Some users will als... -
- I think that the warning is needed. People (at least, I) don't read documents. Even if I noticed, I cannot remember where my code uses String#crypt.
I understand that the warning will annoy normal non-programmer users. However, som... -
- I did not intend to close this ticket. What remains to be discussed is:
- Should we need to add warnings?
- If that is the case, when and how? -
- Applied in changeset trunk|r66154.
----------
string.c: [DOC] deprecate String#crypt [ci skip] [Feature #14915] -
- shyouhei@ruby-lang.org wrote:
> Well, it seems we do not agree whether we should add a
> warning. But is anybody against on documenting the
> deprecation? I think we can:
>
> - Consider String#crypt deprecated as of 2.6.
> - Ad... -
- Well, it seems we do not agree whether we should add a warning. But is anybody against on documenting the deprecation? I think we can:
- Consider String#crypt deprecated as of 2.6.
- Add NEWS about it.
- Add rdoc about it.
Can ... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66154 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 04:51 AM Revision fb0009cf (git): drb: fix tests on Debian sid/unstable with OpenSSL 1.1.1a
- OpenSSL complains abour our keys being small and weak :<
Make them big and strong with 2048-bit RSA keys and SHA256 digests
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66153 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 04:51 AM Revision a063f71a (git): webrick: fix tests on Debian sid/unstable with OpenSSL 1.1.1a
- OpenSSL complains abour our keys being small and weak :<
Make them big and strong with 2048-bit RSA keys and SHA256 digests
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66152 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * vm_args.c (refine_sym_proc_call): enalbe accidentally disabled
refinements in Symbol#to_proc. [Bug #15114]
From: osyo (manga osyo) <manga.osyo@gmail.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66151 b2dd03c8-39d4-4d8f-... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66150 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
04:40 AM Bug #15370: Array#=== in long running loop continually consumes more RAM
- Thanks both of you! :-) I saw some bad advice on StackOverflow and new that `case` worked as follows:
case 2
when *[1,2,3]
puts :winner
end
# => winner
So I had assumed it would work. My mistake. -
- `Array#===` is irrelevant. Your code executes `freq << sum` which extends the array and consumes the memory infinitely, even if you use `Array#member?`. The difference is that `Array#===` is much faster than `Array#member?`. Thus, the...
-
- `Array#===` is not `Array#member?`.
`freq` is an `Array` and `sum` is an `Integer`, so`freq === sum` always returns `false` then `cycle` loops and `freq << sum` repeats forever. -
- I was doing a code challenge and trying to use as few characters as possible (not shown). So instead of using `Array#member?` I tried `Array#===` and it consumed my system's RAM once I switched to that.
The good code here:
fre... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66149 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- MSP-Greg (Greg L) wrote:
> I'm not sure about the effect of short file names. If `test` is a string, and `File.exist? test` is true, then the following should work?
> ...
As far as `test` contains alphabets, yes, probably.
Or maybe `... -
- nobu (Nobuyoshi Nakada) wrote:
> You can't compare path names just by case-insensitiveness, on Windows.
> ...
Thank you for the mention of `File.indentical?`, as I have never noticed that method. Using `File.exist?` does correctly ide... -
- You can't compare path names just by case-insensitiveness, on Windows.
Consider short file names.
You can compare them by `File.identical?` instead, or should use `File.expand_path` before comparison at least. -
- * enumerator.c (enum_chain_total_size): use RARRAY_AREF
instead of RARRAY_PTR_USE because we don't need non-const
ptr.
* enumerator.c (enum_chain_each): ditto.
* enumerator.c (enum_chain_rewind): ditto.
git-svn-id: svn+ssh://ci.r... -
03:40 AM Feature #14183: "Real" keyword argument
- mame (Yusuke Endoh) wrote:
> And, this is a new topic. There is an non-Symbol-key call, like `where("table.id" => 1)` (which was shown by Jeremy Evans). This is difficult to change to keyword argument. To allow this, matz came up wit... -
- I talked with matz about this proposal at Keep Ruby Weird conference (more precisely, Franklin BBQ at Austin). As far as I understand, Matz currently likes syntactical separation of keyword and normal arguments. (Note that it is not de...
-
- From https://github.com/MSP-Greg/ruby/commit/316f60e3befa312320b2cc600d7b59ba64f12329
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66147 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- [Bug #15322]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66146 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:34 AM Bug #15322 (Closed): Time.strptime does not support %3N, %6N, %9N
- Applied in changeset trunk|r66145.
----------
time.rb: remove the unsupported formatting options from the document [ci skip]
Time.strptime does not support %3N, %6N, and %9N.
close [Bug #15322] -
- Thank you for comments. I will commit the patch.
-
- Time.strptime does not support %3N, %6N, and %9N.
close [Bug #15322]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66145 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- The tarball will be reduced by about 568 kB.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66144 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Fixed at r66143. Thanks.
-
- I think `nil` in output is not expetced.
```
% rbenv exec irb --simple-prompt -r irb/completion
>> pp(1..)
1..nil
=> 1..
``` -
- `pp(1..)` should print `"(1..)"` instead of `"(1..nil)"`.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66143 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ast.c (rb_ast_node_type): simplified to return a Symbol without
"NODE_" prefix.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66142 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66141 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66140 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
12/02/2018
-
- Remove unnecessary settings of node_array elements to NULL_NODE.
We can do this because we initialize the whole array to NULL_NODEs
and set everything again to NULL_NODEs when creating a sequence or
alternative node.
Also, fix an index ... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66138 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66137 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 09:41 PM Revision 56d9c8d7 (git): * 2018-12-03
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66136 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- regparse.c: In function node_extended_grapheme_cluster(), introduce function-global
array node_array and use it for sequence and alternate construction. This is done
so that in case of error, all nodes that have already been constructed ... -
- shevegen@gmail.com wrote:
> If I may inquire, how significant would the overhead be?
I'd have to implement it to know for sure...
Thread::Light [Bug #13618] has a process-wide FD map anyways
(similar to the kernel fdtable) to de... -
- On Windows (MinGW), the thread is also sleeping...
-
- If I may inquire, how significant would the overhead be?
While I think Akira's comment is perfectly fine on its own, I
feel that if other people notice a different behaviour between
different operating systems with regards to IO.sel... -
- melentievm@gmail.com wrote:
> https://bugs.ruby-lang.org/issues/15367
> It happens only on linux, tested with 2.5.1, 2.6.0-preview2. On macOS it
> gives error, as expected:
Right, it's platform-specific. I brought it up a few mon... -
- Here is sample code:
~~~ ruby
rp, wp = IO.pipe
t2 = Thread.new { IO.select([rp]) }
# This also does not work:
# t2 = Thread.new { IO.select([rp], nil, [rp]) }
sleep 0.01
rp.close
t2
# => #<Thread:0x00000000089b6ce0@(pry):51 sl... -
04:56 PM Bug #15368 (Closed): Crash Report log information
- MacBook-Pro-de-Saul:social_net saulfranciscoacunagodoy$ rails s
/Users/saulfranciscoacunagodoy/.rvm/gems/ruby-2.6.0-preview2/gems/bootsnap-1.3.2/lib/bootsnap/compile_cache/iseq.rb:18: [BUG] Segmentation fault at 0x0000000000000868
ruby... -
- Now, I'm pretty much only windows, but previously the network I used had Windows, MacOS/OSX, and a few of *nix NAS devices. I vaguely recall some casing issues. Unfortunately, I can't test anything like that now.
Maybe the questions... -
- Now I can't remember why `File::FNM_SYSCASE` is 0 on macOS..., maybe it can select case-sensitive filesystems.
-
- Case-sensitiveness is runtime environment property, and may differ per mounted volumes.
-
- [ruby-list:50718]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66134 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Working through Unicode Standard Annex #29 (version 31, for Unicode 10.0.0), I'm not sure all of the code in node_extended_grapheme_cluster() (in regparse.c) is perfect. But this solves an obvious bug, and we'll leave it at that for Unic...
-
- enc/unicode.c: - Add U+1F93C (WRESTLERS), U+1F9DE (GENIE), and U+1F9DF
to onigenc_unicode_GCB_ranges_E_Base.
- Add comments with character names.
test/ruby/enc/test_emoji_breaks.rb: Activate tests for geni... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66132 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- When compiling ruby trunk, I get a warning on bigdecimal.c:
```
compiling bigdecimal.c
bigdecimal.c:3699:1: warning: ‘Zero’ defined but not used [-Wunused-function]
Zero(void)
^~~~
```
I had a quick look at the code. I indee... -
- ruby_2_5 r66131 merged revision(s) 62776.
-
- This is a ticket for backport management.
r62776 seems required to get rid of failure in some CI environments. -
- test_iseq.rb: skip iseq with coverage
* test/ruby/test_iseq.rb (test_to_binary_with_objects): #to_binary
does not support iseq compiled with coverage, just skip.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ru... -
- ruby_2_5 r66130 merged revision(s) 63040.
-
- compile.c: do not dump unused callinfos
* compile.c (compile_if): rewind callinfo indexes used in
unreachable paths, to get rid of dumping unused callinfos.
[ruby-core:86399] [Bug #14553]
git-svn-id: svn+ssh... - 06:43 AM Revision 4bcdeeb6 (git): Fix rubyspec of bigdecimal for ruby <2.6
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66129 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 05:21 AM Revision e1091526 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66128 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 05:21 AM Revision a7e3516f (git): Fix JSON::Parser against bigdecimal updates
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66127 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 05:21 AM Revision e021386e (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66126 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 05:21 AM Revision c8fb30fc (git): Fix rubyspec against bigdecimal updates
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66125 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 05:21 AM Revision a0e438cd (git): Import bigdecimal-1.4.0.pre-20181130a
- * https://github.com/ruby/bigdecimal/compare/74d25ef..v1.4.0.pre.20181130a
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66124 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66123 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66122 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
12/01/2018
- 11:28 PM Revision b6e33be8 (git): * 2018-12-02
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66121 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * LEGAL: update configure, tool/config.guess, tool/config.sub and
parse.c, to the latest versions.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66120 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- > https://bugs.ruby-lang.org/issues/15356
Btw, I commited as r66093 (git 9d74d402)
Can you confirm current trunk is good for you?
Thanks -
- A comment for future maintainers:
Since `&fib->cont.saved_ec == ruby_current_execution_context_ptr` in the place my patch makes the change, if GC starts below where I set `stack_end` to NULL, the stack doesn't get marked.
This is not a... -
- Okay, I think we are in agreement then.
-
- samuel@oriontransfer.net wrote:
> @normalperson I thought about it a bit more, perhaps both
> ideas should be implemented for maximum protection. We could
> add some notes in the source code too about the
> issue/invariants.
NAK.... -
- @normalperson I thought about it a bit more, perhaps both ideas should be implemented for maximum protection. We could add some notes in the source code too about the issue/invariants.
-
- @normalperson I am open to ideas. I don't know a lot about how thread and GC interact within Ruby, unfortunately it's not an area I spent much time on. So, if you have better proposal, I suggest you implement it. This change included a s...
-
- samuel@oriontransfer.net wrote:
> After I merged this patch,
> https://travis-ci.org/ruby/ruby/jobs/462071967 fails. I am
> testing locally in more detail.
Alan + Sam: thanks for investigating this.
Perhaps an alternative fix w... -
- Okay, it was random failure. That concerns me too. But, it passed now. I'll merge to ruby_2_5 too.
-
- After I merged this patch, https://travis-ci.org/ruby/ruby/jobs/462071967 fails. I am testing locally in more detail.
-
- I looked at the patch it seemed okay.
I committed it to trunk r66111
Once we've confirmed it solves the issue, I will backport 2.5 branch, hopefully it can be included 2.5.4 or next patch release. -
- I will take look at it.
-
04:41 PM Feature #15363: Case insensitive file systems - add info to CONFIG or somewhere?
- unlike ruby, shell's glob finds a file, but it doesn't return a real filename as a result.
```
ls /mnt/c/aaa.txt
=> /mnt/c/aaa.txt (wrong)
ls /mnt/c/aAa.txt
=> /mnt/c/aAa.txt
```
https://ruby-doc.org/core-2.5.0/Dir.html
Note ... -
- @ahorek & Hans,
Thanks for the feedback. Both of you are right, there isn't a trivial solution to this.
Ok to close. The code had an error in it also...
-
- it looks like Ruby checks only a platform for the case-(in)sensivity
for example on WSL I can create a file in my home folder which is case-sensitive
```
touch aAa.txt
touch aaa.txt
```
this creates two separate files
if I do ... -
- i don't think that works that easy because it depends on the filesystem which depends on the location of the file.
For example it might be that it's case insensitive in one location and sensitive on another. -
- This warning has been already removed at r65369, and Ruby 2.6 won't print it. This check is possible in an external lint tool like Rubocop.
-
- This is similar as to what was mentioned in one of the last developer meeting
(or rather the one in **October 2018**, I think).
Let me link to that:
https://docs.google.com/document/d/18f8peqDQ_nkLapK3BWFaAkEHaAIvD6hP0IhdkgDgTJI/p... -
12:21 PM Misc #15364 (Closed): Suppress "shadowing outer local variable" warning for assignments e.g. with "tap"
- The following pattern is quite common when initializing a complex object where some attributes (attr1 and 2) can be set by the initializer, whereas others (attr3 and 4) cannot:
```ruby
# the local variable "thing" does not exist up t... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66119 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * [GSoC] Multi-factor feature for RubyGems https://github.com/rubygems/rubygems/pull/2369
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66118 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 09:29 AM Revision 5cae104e (git): Let sub-directory exts depend on their parent ext
- * ext/extmk.rb: Let sub-directory exts depend on their parent ext.
* template/exts.mk.tmpl: ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66117 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Remove code that tries to remove CR and LF from Grapheme_Cluster_Break=Control.
This code is unnecessary because Grapheme_Cluster_Break=Control already excludes
CR and LF.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66116 b2dd03c8... - 07:31 AM Revision 36b3e41a (git): * remove trailing spaces.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66115 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Introduce new function create_alternate_node() to create an alternative node
from a list of nodes in one go. Use it once (two more uses expected).
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66114 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Thanks @alanwu this has been applied to trunk and should be back-ported to 2.5 shortly as per #15362. As the supplied spec is passing, I'm going to assume this is now fixed. Feel free to open a new bug report if there are further issues....
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66113 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Update for tzdata-2018f
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@66112 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 03:49 AM Revision 4b99725d (git): Avoid GCing dead stack after switching away from a fiber
- Fixes <https://bugs.ruby-lang.org/issues/14561> and discussed
<https://bugs.ruby-lang.org/issues/15362>.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66111 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
-
- to prevent random failure
https://travis-ci.org/ruby/ruby/jobs/461667474
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66110 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- This reverts commit cbdf5a1842cda89347a2c840d23c35f041aead68.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66109 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
11/30/2018
- 11:58 PM Revision cf18fc32 (git): * 2018-12-01
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66108 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 11:58 PM Revision f86b49c1 (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66107 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- This collapses:
```
== disasm: #<ISeq:bar@bench.rb:3 (3,0)-(5,3)> (catch: FALSE)
0000 putobject "a" ( 4)[LiCa]
0002 putobject "b"
0004 putobject ... -
- I was under the impression that Windows was the only case insensitive file system. That is not the case. In RubyGems, there are places in both code and tests where this needs to be accounted for.
Although none come to mind, the same... -
- I committed this in r66095, not sure why it didn't close this.
-
10:47 PM Bug #15362: [PATCH] Avoid GCing dead stack after switching away from a fiber
- Alan,
You're amazing... We're completely blocked on upgrading by this bug. You're a savior
Thanks,
Andrew
-
- Hello! I have a patch that fixes Bug #14561. It's not a platform specific issue but
it affects the default build configuration for MacOS and is causing segfaults on 2.5.x.
I've put the test for this in a separate patch because I'm not ... -
- cremno@mail.ru wrote:
> Back to Visual Studio:
What is the feasability of requiring GCC or clang for Windows builds
instead of supporting VS?
I know GCC can cross-compile for win32, at least; and I got
miniruby to run under WIN... -
02:03 PM Misc #15347: Require C99
- Requiring a more modern version of MSVC should be a given anyway. Currently CRuby still tries to support 6.0 (`_MSC_VER=1200`) which was originally released in 1998 and has seen its last update in 2004. Additional code like in `numeric.c...
-
- I have a patch for this, #15362 if anyone could take a look.
-
- I thought this was fixed already in 2.6 - but obviously not. That's bad :(
-
- Would it possible to get this addressed? It blocking my entire organization from upgrading past Ruby 2.4
It's reproducible on all 2.5 releases as well as the 2.6 preview releases.
It's been reported multiple times:
https://bugs.ru... -
03:47 PM Bug #15333 (Closed): make check fails looking for Bundler 2.0
- Build on a totally clean CentOS 7 box passed without failure. I would attribute this issue to "user's host configuration".
-
- My original failure was on a Fedora 28 box. I am building a CentOS 7 box and still getting the build environment set up for a totally clean build. I apologize for the delay.
-
- I think this was already fixed by introducing benchmark-driver.
~~~
$ make benchmark OPTS="-r time -o simple" ITEM=app_
../revision.h unchanged
/home/k0kubun/.rbenv/shims/ruby --disable=gems -rrubygems -I../benchmark/lib ../benchma... -
- fix r65954; Keep tainty
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@66105 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 11:44 AM Revision 8f23f690 (git): test/ruby/test_io.rb (test_recycled_fd_close): remove hacks
- I think I finally fixed the underlying bug in r65937
("io.c (fptr_finalize_flush): close race leading to EBADF")
I've run this test over 100000 times on a multicore system, now.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66104 b... -
07:59 AM Bug #15361 (Closed): [backport] Import Ruby/OpenSSL 2.1.2
- https://github.com/ruby/openssl/pull/160 (included in Ruby/OpenSSL 2.1.0 and newer) fixes an incompatibility with OpenSSL 1.1.0 and newer. This version of Ruby/OpenSSL was merged into Ruby Trunk and 2.5, but not 2.4:
* https://bugs.rub... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66103 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66102 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
05:25 AM Bug #13746 (Closed): windows-pr gemのRuby 2.4 32bit版でのSEGV
-
- > r66100
Thanks to work on this, Eric. -
- I had my computer spend about 10h to compile Ruby with regexp debug flags activated. It took that long because while Ruby is building, it starts running Ruby scripts with lots of regexp debug output. (I probably should have deactivated d...
- 03:56 AM Revision dc1ecab0 (git): test/testunit/test_parallel.rb: respect subprocess timeout scale
- MJIT tests take longer than 100s on my VM :<
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66101 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 03:56 AM Revision eb38fb67 (git): vm_trace.c: workqueue as thread-safe version of postponed_job
- postponed_job is safe to use in signal handlers, but is not
thread-safe for MJIT. Implement a workqueue for MJIT
thread-safety.
[Bug #15316]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66100 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I have the same concerns.
I'm going to resolve the duplicated vendoring problem at https://github.com/rubygems/rubygems/pull/2026. -
- @colby
Ok. I decided on the longer message.
> snide comment
Snide - 'derogatory or mocking in an indirect way'. @vo.x's comment is direct, and his point about the vendored libraries is valid.
> ...
Something just seems back...