Activity
From 11/26/2018 to 12/02/2018
12/02/2018
-
11:28 PM Revision b56e266d (git): remove unnecessary settings with NULL_NODE in \X implementation
- Remove unnecessary settings of node_array elements to NULL_NODE.
We can do this because we initialize the whole array to NULL_NODEs
and set everything again to NULL_NODEs when creating a sequence or
alternative node.
Also, fix an index ... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66138 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
10:01 PM Revision d80bf2f1 (git): fix last commit (r66135)
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66137 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 09:41 PM Revision 56d9c8d7 (git): * 2018-12-03
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66136 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- regparse.c: In function node_extended_grapheme_cluster(), introduce function-global
array node_array and use it for sequence and alternate construction. This is done
so that in case of error, all nodes that have already been constructed ... -
08:12 PM Bug #15367: IO.select is not resumed when io-object gets closed
- shevegen@gmail.com wrote:
> If I may inquire, how significant would the overhead be?
I'd have to implement it to know for sure...
Thread::Light [Bug #13618] has a process-wide FD map anyways
(similar to the kernel fdtable) to de... -
06:59 PM Bug #15367: IO.select is not resumed when io-object gets closed
- On Windows (MinGW), the thread is also sleeping...
-
06:35 PM Bug #15367: IO.select is not resumed when io-object gets closed
- If I may inquire, how significant would the overhead be?
While I think Akira's comment is perfectly fine on its own, I
feel that if other people notice a different behaviour between
different operating systems with regards to IO.sel... -
- melentievm@gmail.com wrote:
> https://bugs.ruby-lang.org/issues/15367
> It happens only on linux, tested with 2.5.1, 2.6.0-preview2. On macOS it
> gives error, as expected:
Right, it's platform-specific. I brought it up a few mon... -
04:48 PM Bug #15367 (Open): IO.select is not resumed when io-object gets closed
- Here is sample code:
~~~ ruby
rp, wp = IO.pipe
t2 = Thread.new { IO.select([rp]) }
# This also does not work:
# t2 = Thread.new { IO.select([rp], nil, [rp]) }
sleep 0.01
rp.close
t2
# => #<Thread:0x00000000089b6ce0@(pry):51 sl... -
04:56 PM Bug #15368 (Closed): Crash Report log information
- MacBook-Pro-de-Saul:social_net saulfranciscoacunagodoy$ rails s
/Users/saulfranciscoacunagodoy/.rvm/gems/ruby-2.6.0-preview2/gems/bootsnap-1.3.2/lib/bootsnap/compile_cache/iseq.rb:18: [BUG] Segmentation fault at 0x0000000000000868
ruby... -
- Now, I'm pretty much only windows, but previously the network I used had Windows, MacOS/OSX, and a few of *nix NAS devices. I vaguely recall some casing issues. Unfortunately, I can't test anything like that now.
Maybe the questions... -
01:01 PM Feature #15363: Case insensitive file systems - add info to CONFIG or somewhere?
- Now I can't remember why `File::FNM_SYSCASE` is 0 on macOS..., maybe it can select case-sensitive filesystems.
-
- Case-sensitiveness is runtime environment property, and may differ per mounted volumes.
-
- [ruby-list:50718]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66134 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Working through Unicode Standard Annex #29 (version 31, for Unicode 10.0.0), I'm not sure all of the code in node_extended_grapheme_cluster() (in regparse.c) is perfect. But this solves an obvious bug, and we'll leave it at that for Unic...
-
- enc/unicode.c: - Add U+1F93C (WRESTLERS), U+1F9DE (GENIE), and U+1F9DF
to onigenc_unicode_GCB_ranges_E_Base.
- Add comments with character names.
test/ruby/enc/test_emoji_breaks.rb: Activate tests for geni... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66132 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- When compiling ruby trunk, I get a warning on bigdecimal.c:
```
compiling bigdecimal.c
bigdecimal.c:3699:1: warning: ‘Zero’ defined but not used [-Wunused-function]
Zero(void)
^~~~
```
I had a quick look at the code. I indee... -
07:37 AM Bug #15365: backport r62776 (test_iseq.rb: skip iseq with coverage)
- ruby_2_5 r66131 merged revision(s) 62776.
-
- This is a ticket for backport management.
r62776 seems required to get rid of failure in some CI environments. -
- test_iseq.rb: skip iseq with coverage
* test/ruby/test_iseq.rb (test_to_binary_with_objects): #to_binary
does not support iseq compiled with coverage, just skip.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ru... -
- ruby_2_5 r66130 merged revision(s) 63040.
-
- compile.c: do not dump unused callinfos
* compile.c (compile_if): rewind callinfo indexes used in
unreachable paths, to get rid of dumping unused callinfos.
[ruby-core:86399] [Bug #14553]
git-svn-id: svn+ssh... - 06:43 AM Revision 4bcdeeb6 (git): Fix rubyspec of bigdecimal for ruby <2.6
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66129 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 05:21 AM Revision e1091526 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66128 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 05:21 AM Revision a7e3516f (git): Fix JSON::Parser against bigdecimal updates
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66127 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 05:21 AM Revision e021386e (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66126 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 05:21 AM Revision c8fb30fc (git): Fix rubyspec against bigdecimal updates
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66125 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 05:21 AM Revision a0e438cd (git): Import bigdecimal-1.4.0.pre-20181130a
- * https://github.com/ruby/bigdecimal/compare/74d25ef..v1.4.0.pre.20181130a
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66124 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66123 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66122 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
12/01/2018
- 11:28 PM Revision b6e33be8 (git): * 2018-12-02
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66121 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * LEGAL: update configure, tool/config.guess, tool/config.sub and
parse.c, to the latest versions.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66120 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- > https://bugs.ruby-lang.org/issues/15356
Btw, I commited as r66093 (git 9d74d402)
Can you confirm current trunk is good for you?
Thanks -
05:16 PM Bug #15362: [PATCH] Avoid GCing dead stack after switching away from a fiber
- A comment for future maintainers:
Since `&fib->cont.saved_ec == ruby_current_execution_context_ptr` in the place my patch makes the change, if GC starts below where I set `stack_end` to NULL, the stack doesn't get marked.
This is not a... -
06:50 AM Bug #15362 (Closed): [PATCH] Avoid GCing dead stack after switching away from a fiber
- Okay, I think we are in agreement then.
-
- samuel@oriontransfer.net wrote:
> @normalperson I thought about it a bit more, perhaps both
> ideas should be implemented for maximum protection. We could
> add some notes in the source code too about the
> issue/invariants.
NAK.... -
- @normalperson I thought about it a bit more, perhaps both ideas should be implemented for maximum protection. We could add some notes in the source code too about the issue/invariants.
-
- @normalperson I am open to ideas. I don't know a lot about how thread and GC interact within Ruby, unfortunately it's not an area I spent much time on. So, if you have better proposal, I suggest you implement it. This change included a s...
-
- samuel@oriontransfer.net wrote:
> After I merged this patch,
> https://travis-ci.org/ruby/ruby/jobs/462071967 fails. I am
> testing locally in more detail.
Alan + Sam: thanks for investigating this.
Perhaps an alternative fix w... -
- Okay, it was random failure. That concerns me too. But, it passed now. I'll merge to ruby_2_5 too.
-
- After I merged this patch, https://travis-ci.org/ruby/ruby/jobs/462071967 fails. I am testing locally in more detail.
-
- I looked at the patch it seemed okay.
I committed it to trunk r66111
Once we've confirmed it solves the issue, I will backport 2.5 branch, hopefully it can be included 2.5.4 or next patch release. -
- I will take look at it.
-
04:41 PM Feature #15363: Case insensitive file systems - add info to CONFIG or somewhere?
- unlike ruby, shell's glob finds a file, but it doesn't return a real filename as a result.
```
ls /mnt/c/aaa.txt
=> /mnt/c/aaa.txt (wrong)
ls /mnt/c/aAa.txt
=> /mnt/c/aAa.txt
```
https://ruby-doc.org/core-2.5.0/Dir.html
Note ... -
- @ahorek & Hans,
Thanks for the feedback. Both of you are right, there isn't a trivial solution to this.
Ok to close. The code had an error in it also...
-
- it looks like Ruby checks only a platform for the case-(in)sensivity
for example on WSL I can create a file in my home folder which is case-sensitive
```
touch aAa.txt
touch aaa.txt
```
this creates two separate files
if I do ... -
03:51 PM Feature #15363: Case insensitive file systems - add info to CONFIG or somewhere?
- i don't think that works that easy because it depends on the filesystem which depends on the location of the file.
For example it might be that it's case insensitive in one location and sensitive on another. -
03:57 PM Misc #15364 (Closed): Suppress "shadowing outer local variable" warning for assignments e.g. with "tap"
- This warning has been already removed at r65369, and Ruby 2.6 won't print it. This check is possible in an external lint tool like Rubocop.
-
- This is similar as to what was mentioned in one of the last developer meeting
(or rather the one in **October 2018**, I think).
Let me link to that:
https://docs.google.com/document/d/18f8peqDQ_nkLapK3BWFaAkEHaAIvD6hP0IhdkgDgTJI/p... -
12:21 PM Misc #15364 (Closed): Suppress "shadowing outer local variable" warning for assignments e.g. with "tap"
- The following pattern is quite common when initializing a complex object where some attributes (attr1 and 2) can be set by the initializer, whereas others (attr3 and 4) cannot:
```ruby
# the local variable "thing" does not exist up t... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66119 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
11:01 AM Revision 7a46a3b9 (git): Merge rubygems-3.0.0.beta3.
- * [GSoC] Multi-factor feature for RubyGems https://github.com/rubygems/rubygems/pull/2369
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66118 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 09:29 AM Revision 5cae104e (git): Let sub-directory exts depend on their parent ext
- * ext/extmk.rb: Let sub-directory exts depend on their parent ext.
* template/exts.mk.tmpl: ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66117 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Remove code that tries to remove CR and LF from Grapheme_Cluster_Break=Control.
This code is unnecessary because Grapheme_Cluster_Break=Control already excludes
CR and LF.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66116 b2dd03c8... - 07:31 AM Revision 36b3e41a (git): * remove trailing spaces.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66115 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Introduce new function create_alternate_node() to create an alternative node
from a list of nodes in one go. Use it once (two more uses expected).
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66114 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Thanks @alanwu this has been applied to trunk and should be back-ported to 2.5 shortly as per #15362. As the supplied spec is passing, I'm going to assume this is now fixed. Feel free to open a new bug report if there are further issues....
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66113 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Update for tzdata-2018f
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@66112 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 03:49 AM Revision 4b99725d (git): Avoid GCing dead stack after switching away from a fiber
- Fixes <https://bugs.ruby-lang.org/issues/14561> and discussed
<https://bugs.ruby-lang.org/issues/15362>.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66111 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
-
12:37 AM Revision 57005046 (git): tool/downloader.rb: retry Net::OpenTimeout
- to prevent random failure
https://travis-ci.org/ruby/ruby/jobs/461667474
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66110 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:08 AM Revision 5d3aa0ac (git): Revert "Collapse putobject, putobject, newarray"
- This reverts commit cbdf5a1842cda89347a2c840d23c35f041aead68.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66109 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
11/30/2018
- 11:58 PM Revision cf18fc32 (git): * 2018-12-01
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66108 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 11:58 PM Revision f86b49c1 (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66107 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- This collapses:
```
== disasm: #<ISeq:bar@bench.rb:3 (3,0)-(5,3)> (catch: FALSE)
0000 putobject "a" ( 4)[LiCa]
0002 putobject "b"
0004 putobject ... -
- I was under the impression that Windows was the only case insensitive file system. That is not the case. In RubyGems, there are places in both code and tests where this needs to be accounted for.
Although none come to mind, the same... -
- I committed this in r66095, not sure why it didn't close this.
-
10:47 PM Bug #15362: [PATCH] Avoid GCing dead stack after switching away from a fiber
- Alan,
You're amazing... We're completely blocked on upgrading by this bug. You're a savior
Thanks,
Andrew
-
- Hello! I have a patch that fixes Bug #14561. It's not a platform specific issue but
it affects the default build configuration for MacOS and is causing segfaults on 2.5.x.
I've put the test for this in a separate patch because I'm not ... -
- cremno@mail.ru wrote:
> Back to Visual Studio:
What is the feasability of requiring GCC or clang for Windows builds
instead of supporting VS?
I know GCC can cross-compile for win32, at least; and I got
miniruby to run under WIN... -
02:03 PM Misc #15347: Require C99
- Requiring a more modern version of MSVC should be a given anyway. Currently CRuby still tries to support 6.0 (`_MSC_VER=1200`) which was originally released in 1998 and has seen its last update in 2004. Additional code like in `numeric.c...
-
- I have a patch for this, #15362 if anyone could take a look.
-
- I thought this was fixed already in 2.6 - but obviously not. That's bad :(
-
- Would it possible to get this addressed? It blocking my entire organization from upgrading past Ruby 2.4
It's reproducible on all 2.5 releases as well as the 2.6 preview releases.
It's been reported multiple times:
https://bugs.ru... -
03:47 PM Bug #15333 (Closed): make check fails looking for Bundler 2.0
- Build on a totally clean CentOS 7 box passed without failure. I would attribute this issue to "user's host configuration".
-
- My original failure was on a Fedora 28 box. I am building a CentOS 7 box and still getting the build environment set up for a totally clean build. I apologize for the delay.
-
- I think this was already fixed by introducing benchmark-driver.
~~~
$ make benchmark OPTS="-r time -o simple" ITEM=app_
../revision.h unchanged
/home/k0kubun/.rbenv/shims/ruby --disable=gems -rrubygems -I../benchmark/lib ../benchma... -
- fix r65954; Keep tainty
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@66105 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 11:44 AM Revision 8f23f690 (git): test/ruby/test_io.rb (test_recycled_fd_close): remove hacks
- I think I finally fixed the underlying bug in r65937
("io.c (fptr_finalize_flush): close race leading to EBADF")
I've run this test over 100000 times on a multicore system, now.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66104 b... -
07:59 AM Bug #15361 (Closed): [backport] Import Ruby/OpenSSL 2.1.2
- https://github.com/ruby/openssl/pull/160 (included in Ruby/OpenSSL 2.1.0 and newer) fixes an incompatibility with OpenSSL 1.1.0 and newer. This version of Ruby/OpenSSL was merged into Ruby Trunk and 2.5, but not 2.4:
* https://bugs.rub... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66103 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66102 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
05:25 AM Bug #13746 (Closed): windows-pr gemのRuby 2.4 32bit版でのSEGV
-
- > r66100
Thanks to work on this, Eric. -
- I had my computer spend about 10h to compile Ruby with regexp debug flags activated. It took that long because while Ruby is building, it starts running Ruby scripts with lots of regexp debug output. (I probably should have deactivated d...
- 03:56 AM Revision dc1ecab0 (git): test/testunit/test_parallel.rb: respect subprocess timeout scale
- MJIT tests take longer than 100s on my VM :<
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66101 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 03:56 AM Revision eb38fb67 (git): vm_trace.c: workqueue as thread-safe version of postponed_job
- postponed_job is safe to use in signal handlers, but is not
thread-safe for MJIT. Implement a workqueue for MJIT
thread-safety.
[Bug #15316]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66100 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I have the same concerns.
I'm going to resolve the duplicated vendoring problem at https://github.com/rubygems/rubygems/pull/2026. -
- @colby
Ok. I decided on the longer message.
> snide comment
Snide - 'derogatory or mocking in an indirect way'. @vo.x's comment is direct, and his point about the vendored libraries is valid.
> ...
Something just seems back...
11/29/2018
- 11:30 PM Revision d7e4e50b (git): io.c: fix clang -Werror,-Wshorten-64-to-32 on Linux sendfile
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66099 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 11:28 PM Revision 1372c092 (git): io.c: fix clang -Werror,-Wshorten-64-to-32 errors
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66098 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
11:09 PM Bug #15354: Remove Bundler from StdLib
- vo.x (Vit Ondruch) wrote:
> please consider removal of Bundler from StdLib unless upstream demonstrates it can maintain it properly.
Hi, Bundler core team dev here.
What does this even mean? We have been maintaining Bundler "prop... -
06:35 AM Bug #15354: Remove Bundler from StdLib
- I am afraid that my issues won't be addressed as long as independent Bundler is not discontinued and this have not happened for past 10 years. If this was just announced, the two copies of Molinillo could be merged into one for start. Th...
-
- @vo.x
Many of the points you make are true.
I also think about when Travis mucked up their builds (at least trunk, maybe more) with RubyGems & Bundler, and at least a few popular repos/gems had CI issues. You mentioned that many u... - 10:37 PM Revision 6ccc2379 (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66097 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:37 PM Revision f47b38b0 (git): io.c: favor comparisons against zero rather than -1
- On my 32-bit x86 userspace, I get the following .text savings:
text data bss dec hex filename
152971 56 252 153279 256bf io.o.before
152863 56 252 153171 25653 io.o.aft... -
- mame@ruby-lang.org wrote:
> IMO, documentation is not enough. A warning may annoy a user,
> but sudden removal (in future) is much worse.
There should never be a sudden removal.
Honestly, I don't think we should make the first ... -
03:23 PM Feature #14915: Deprecate String#crypt
- mame (Yusuke Endoh) wrote:
> IMO, documentation is not enough. A warning may annoy a user, but sudden removal (in future) is much worse.
> ...
Here's an updated patch that switches to using `rb_warning`, with appropriate updates to th... -
- IMO, documentation is not enough. A warning may annoy a user, but sudden removal (in future) is much worse.
As a first step, how about `rb_warning` instead of `rb_warn`? It prints a warning only when $VERBOSE is enabled. A well-man... -
- merch-redmine@jeremyevans.net wrote:
> File 0001-Deprecate-String-crypt.patch added
I am against the rb_warn call. Documentation change is enough.
Typical users (non-programmers) may not know how to quiet
the warning or fix the... -
- jeremyevans0 (Jeremy Evans) wrote:
> mame (Yusuke Endoh) wrote:
> ...
I've updated the patch to apply against trunk. I would like this change to make 2.6 unless there are objections. Can a committer perform a final review and commit ... -
- Eric Wong wrote:
> tarui@prx.jp wrote:
> > Feature #10548: Callcc is now going obsoleted. Please use Fiber.
> > https://bugs.ruby-lang.org/issues/10548
>
> How about adding --disable-callcc configure option?
>
> https://80x24.... -
- ko1@atdot.net wrote:
> Honestly speaking, we are not sure we can introduce it into
> Ruby 2.6 (incompatibility, stability and so on).
Doesn't look like we can.
> So please commit it and let's try it.
> If we find troubles we ca... -
- In this example code:
```ruby
def foo
[1, 2, 3, 4]
end
```
The array literal uses a `duparray` instruction. Before this patch,
`rb_ary_resurrect` would malloc and memcpy a new array buffer. This
patch changes `rb_ary_resurrect` to u... -
- Applied in changeset trunk|r66093.
----------
disable non-blocking pipes and sockets by default
There seems to be a compatibility problems with Rails +
Rack::Deflater; so we revert this incompatibility.
This effectively reverts r65922... -
- zundan@gmail.com wrote:
> Thanks! The patch actually fixed the problem.
OK, that is surprising...
> > So you're saying this is not a new problem...
>
> First time I noticed this was running a Rails app on `2.6.0-preview1` on H... -
06:40 PM Bug #15356: Rack::Deflater on Rails responds with no data on Ruby 2.6.0
- Thanks! The patch actually fixed the problem.
With `2.6.0-dev` pointing to the binary built as below, the command `curl -H 'Accept-encoding: gzip' -v http://localhost:3000 --raw` prints the HTML data as expected.
~~~
$ cat io.patc... -
- zundan@gmail.com wrote:
> Clarify what I think of causing the problem.
> I'd like to report that a Rails app with `Rack::Deflater`
> enabled responds with a zero-length body on Ruby 2.6.0, to a
> request with `Accept-encoding: gzi... -
- Clarify what I think of causing the problem.
- 08:00 PM Revision 0620c97e (git): * 2018-11-30
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66094 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 08:00 PM Revision 9d74d402 (git): disable non-blocking pipes and sockets by default
- There seems to be a compatibility problems with Rails +
Rack::Deflater; so we revert this incompatibility.
This effectively reverts r65922; but keeps the bugfixes to
better support non-blocking sockets and pipes for future use.
[Bug #1... -
- I can't comment on the issue itself but I wanted to add that I personally do not
use man-pages. I use the commandline "--help" flag, though, and of course online
queries for help (and then I often put useful bits into a local knowledg... -
- BTW I am not sure how the Bundler man pages are imported into Ruby repository, but I think there should be either the source .ronn files or the resulting .txt files and man page files. Not both.
-
- Bundler has nice help, but it is a bit complex [1]. It ideally needs `man` command installed but it definitely needs the help source files, which are not placed on proper location to be reachable by BUndler from StdLib. In that case, Bun...
-
06:13 PM Bug #15360 (Closed): "ThreadError: deadlock; recursive locking" error when recursive lock shouldn't be possible
- I think I've discovered a Ruby bug, possibly introduced in 2.5.
I've attached a reproduction script; running it on Ruby 2.5.0+ (including previews of 2.6.0) seems to always produce a flood of printed `ThreadError: deadlock; recursive ... -
- 非常に詳細なご説明をいただきありがとうございます。
では、標準ライブラリに関しては諦めた上でその他の範囲でC99の一部の機能を使うことにした場合、Solaris 10, 11で、
* 公式の Oracle Developer Studio ではバージョン12以降で動くことを保証する。それ以前のバージョンでは、C99を有効化する方法がある限りconfigureでそれに対応し、それが可能な限りサポートする。
* Fujitsu C Compiler (fcc)... -
03:50 PM Bug #14200: addr2line.c compile error with C89 compilers on Solaris 10
- r63571 で対策された isnan のように、準拠規格によって定義が異なる関数やマクロがあったら、問題は発生するのかもしれません。（今の所、私の環境では、Rubyのコンパイル時には遭遇したことはないので、具体例は無いのですが）
-
- > Soraris 11や10、あるいは9以前に関してそれぞれについて具体的にどのような懸念や副作用があるか
Solaris 9 およびそれ以前はもう考慮する必要はないと思います。
Solaris 10/11 の公式コンパイラである Oracle Developer Studio （旧名称 Oracle Solaris Studio、旧旧名称 Sun Studio）では、遅くともバージョン12以降ではC99をサポートしています。
デフォルトは、12.3... -
- Just FTR trying to build r66092 on Fedora Rawhide [1], x86_64, ppc64le, aarch64, s390x, and armv7hl were properly fortified while only i686 failed to pass [2] the fortification test.
[1]: https://koji.fedoraproject.org/koji/taskinfo... -
- Any chance to get this fixed? It is nice that Ruby has such fancy SIGSEGV handler, but it does not work on all platforms and it makes the matters just worse.
-
- The above issue was fixed in r66087. Thank you.
-
- Eric Wong <normalperson@yhbt.net> wrote:
> samuel@oriontransfer.net wrote:
> > @k0kubun I like the general ideas presented here but the
> > implementation is too heavy/specific for my use case. For
> > example, it won't work on JRub... -
- samuel@oriontransfer.net wrote:
> @k0kubun I like the general ideas presented here but the
> implementation is too heavy/specific for my use case. For
> example, it won't work on JRuby, TruffleRuby, or other
> implementations. That'... -
09:22 AM Revision d7e30434 (git): Remove unused variable in example code [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66092 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- mame (Yusuke Endoh) wrote:
> foonlyboy (Eike Dierks) wrote:
> ...
Another implementation approach is to store the indent-related warnings during compilation, and output them once we hit an error, otherwise discard them. -
- > I'd like to propose,that on a missing 'end'
> ...
Can we get the incomplete(?) parse tree when a syntax error occurred? Note that the source code itself can not be necessarily rescanned because it might be passed via a pipe stream. -
01:08 AM Feature #14244: Better error messages for scripts with non-matching end statements
- I fully agree with Martin that this is one of the most annoying problems.
I used ruby -w on my failing file and it told me (which was helpful)
~~~
333: warning: mismatched indentations at 'end' with 'if' at 332
523: warning: mism... -
- Applied in changeset trunk|r66091.
----------
clear dst Hash on Hash#replace. [Bug #15358]
* hash.c (linear_copy): solve two issues on `Hash#replace`.
(1) fix memory leak
(1-1) don't allocate memory if destination already
... -
- Thank you for your report.
I found a bug and will commit soon.
Thanks,
Koichi -
- * hash.c (linear_copy): solve two issues on `Hash#replace`.
(1) fix memory leak
(1-1) don't allocate memory if destination already
has a memory area.
(1-2) free destination memory if src is NULL.
(2) clear tra... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66090 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66089 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- This reverts commit 110273c53461a9a7ecdcca705346be21f25f50c6.
Try this with r66087
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66088 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r66087.
----------
use __builtin_setjmp on mingw64 [Bug #15348]. -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66087 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
06:19 AM Bug #13438: Fix heap overflow due to configure.in not being updated for HEAP_* -> HEAP_PAGE_* variable renaming
- Oops, stunned that nobody noticed this issue for over a yer.
Had just pushed the patch. Sorry for the delay! -
- Applied in changeset trunk|r66086.
----------
Remove HEAP_ALIGN_LOG setting in configure.ac for OpenBSD/MirOS
The ruby setting was renamed to HEAP_PAGE_ALIGN_LOG, but the
configure.in (now configure.ac) file was not updated, so the
set... -
- jeremyevans0 (Jeremy Evans) wrote:
> shyouhei (Shyouhei Urabe) wrote:
> ...
This was approved back in September 2017, but it didn't make the 2.5 release. I would like it to make the 2.6 release. The latest patch still applies (with o... -
- The ruby setting was renamed to HEAP_PAGE_ALIGN_LOG, but the
configure.in (now configure.ac) file was not updated, so the
setting had no effect. The configure setting is unnecessary
after OpenBSD 5.2 and MirOS has been discontinued (wit... -
- Before this changeset (since r58071) we did not download files
from unicode.org but just touch some files. This is a kind of
hack that people normally don't do at home.
We are caching other files between builds now. Why not also save
... -
- @hsbt
By no means have I looked at how Bundler is used by RG testing, but in trunk, the following line in test_case.rb works in rubygems/rubygems, but not trunk:
```ruby
# If bundler gemspec exists, add to stubs
bundler_gemspec =... -
- I will build a clean box and try again. Thank you.
-
- Some data points from a discussion between @naruse and myself:
- Up to elf (U+1F9DD) is Emoji_Modifier_Base, but genie (U+1F9DE) isn't.
- Emoji_Modifier only includes skin tones (U+1F3FB-1F3FF, light skin tone..dark skin tone)
-... -
- `[` is a meta character in YAML. `- [` starts an array,
so it should end with `]`; but it was not.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66084 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- normalperson (Eric Wong) wrote:
> tenderlove@ruby-lang.org wrote:
> ...
Ok, I'll apply the patch.
> > Does anyone have opinions on this? If not, I'll just apply the patch.
> ...
I tried disabling theap and re-running the test. I... - 01:09 AM Revision 58d74446 (git): * 2018-11-29
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66083 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * lib/time.rb: Move method documents to each methods. And stop
documentation of the abstract and others, which were confusingly
placed at the top of generated documents prior to the abstract
in time.c.
git-svn-id: svn+ssh://ci.ru... -
- Hello, openssl library now has its own tracker. Is it possible to report this issue at ruby/openssl? https://github.com/ruby/openssl/issues
-
12:26 AM Feature #10771: An easy way to get the source location of a constant
- I am glad that this issue is going to be discussed in the next developer meeting, but now that we have a way to know not only the file name and the line number but also the column number/position as well for method definitions, I request...
-
- edchick@gmail.com wrote:
> This is sad we loss another contributor with deep low level knowledge. I read in another thread you won't be hacking in Ruby again, why is that?
There's thousands of potential contributors more knowledgea...
11/28/2018
-
- I couldn't reproduce it.
-
- Related? https://bugs.ruby-lang.org/issues/15354
-
-
- I personally do not use bundler, so I don't mind either way, but I use gems (and would love
to preserve gems how I used them in the last ... 10 years or so; e. g. only using .gemspec
rather than Gemfile).
I understand the discussion... -
- Related? https://bugs.ruby-lang.org/issues/15333
-
- [This is mostly a clone of #13978 which I opened a year ago. Unfortunately, the same points I mentioned there still hold true.]
I understand that given that almost every Ruby user is using Bundler, it would be convenient for quite som... -
- @ko1 Koichi,
I did another ruby-loco build, and it also passed. The 'test repo' I did is here:
https://ci.appveyor.com/project/MSP-Greg/ruby-loco-test/history
Currently it runs three versions of the failing specs. In the fir... -
- @ko1 Koichi,
Thank you. Repeat that. ruby-loco is green.
Going back to last year, I've had intermittent (and sometimes only on appveyor) issues with callcc, the (sometimes considerable) block nesting in the spec suite, and this ... -
- On my msys2 environment, it hits!
On my environemnt,
```
using
```
only this script hangs.
And I found these articles:
http://www.agardner.me/golang/windows/cgo/64-bit/setjmp/longjmp/2016/02/29/go-windows-setjmp-x86.h... -
- When running Sequel's plugin specs, there is a segfault that is dependent on execution order. I have been seeing it on OpenBSD after upgrading from ruby-2.6.0-preview2 to ruby-2.6.0-preview3, and I was not sure if it was OpenBSD specifi...
-
- @k0kubun I like the general ideas presented here but the implementation is too heavy/specific for my use case. For example, it won't work on JRuby, TruffleRuby, or other implementations. That's the major benefit of using a gem for the re...
-
- > https://bugs.ruby-lang.org/issues/13618#change-75238
takashikkbn@gmail.com wrote:
> I'm interested in the "demo server" as a real-world use case
> of Thread::Light. Is the code available somewhere?
I haven't written it, yet. ... -
- > I plan on switching https://public-inbox.org/git/ (my busiest public website) to use a demo server with Thread::Light.
I'm interested in the "demo server" as a real-world use case of Thread::Light. Is the code available somewhere? A... -
- Changes in this iteration:
* reduced stack usage in the select()-based implementation
(also made some io.c changes today in trunk to cut stack)
* refined auto-switching disable for critical sections
I plan on switching https:/... -
- matz@ruby-lang.org wrote:
> The first proposal of auto fiber was fibers with implicit context switch on I/O operations. They are fundamentally not fibers, but threads (without time slice context switching). Since they switch context le... -
10:22 AM Feature #13618: [PATCH] auto fiber schedule for rb_wait_for_single_fd and rb_waitpid
- The first proposal of auto fiber was fibers with implicit context switch on I/O operations. They are fundamentally not fibers, but threads (without time slice context switching). Since they switch context less often, they are less danger...
-
08:01 PM Feature #15357 (Closed): Proc#parameters returns incomplete type information
- The current implementation of Proc#parameters [differentiate between lambda? true and false](https://github.com/ruby/ruby/blob/49cd16bfaf4f03885058ce748119bc8ea2de735a/iseq.c#L2800).
This is presumably due to the fact, that [procs use t... -
- I'd like to report that a Rails app with `Rack::Deflater` enabled responds with a zero-length body on Ruby 2.6.0, to a request with `Accept-encoding: gzip` request header. It seems to happen at least on `x86_64-linux` (Ubuntu 18.04.1; se...
-
06:10 PM Bug #15355 (Closed): Random segmentation faults in development environment
- During development I am getting random crashes of the "rails s" command with the log below.
The crash happens as I browse the front-end of the application I am developing - and independent of the page.
all crash sump also attached
/... -
05:54 PM Feature #9758: Allow setting SSLContext#extra_chain_cert in Net::HTTP
- any feedback on this?
-
03:54 PM Feature #15353 (Closed): Support client certificates with TLS 1.3 and OpenSSL 1.1.1
- A TLS 1.3 server can request a client certificate after the handshake. Clients tell the server during the handshake whether they support this feature.
In OpenSSL 1.1.1, this feature is enabled with the functions SSL_CTX_set_post_hands... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66081 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66080 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66079 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66078 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66077 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66076 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66075 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- ruby_2_5 r66074 merged revision(s) 64799,64800,64801.
-
- fix typo.
* vm_exec.h (DEBUG_END_INSN()): use `ec` instead of `th`.
This macro is used when `VMDEBUG > 0`.
escape all env properly.
* vm_backtrace.c (rb_debug_inspector_open): escape all env using
... -
- ruby_2_5 r66073 merged revision(s) 65954,65955,65958.
-
- Don't use single byte optimization on grapheme clusters
Unicode Text Segmentation considers CRLF as a character. [Bug #15337]
add tests using Unicode test data for grapheme clusters
Add file test/ruby/enc/test_... -
- janfri suggested this issue for the next upcoming developer meeting
at December 2018 so I think it will be approved or rejected then.
I did not yet comment on it so I will comment on it briefly.
- I think the functionality would b... -
12:56 PM Misc #15007: Let all Init_xxx and extension APIs frequently called from init code paths be considered cold
- methodmissing (Lourens Naudé) wrote:
> ko1 (Koichi Sasada) wrote:
> ...
I'm having a hard time getting MSVC to pass for `rb_memerror` https://ci.appveyor.com/project/ruby/ruby/builds/20571215/job/wc9ha9eg36xjiv70 with error `c:\project... -
- > オプションでC99準拠を指定したり、それ相当の _XOPEN_SOURCE を定義すると、
> ...
@ngoto [Misc #15347] というのを検討しておりまして、オプションでC99準拠を指定するか _XOPEN_SOURCE の指定を行なった場合に、Soraris 11や10、あるいは9以前に関してそれぞれについて具体的にどのような懸念や副作用があるかをお聞きしたいと思っております。お時間のある時にお返事いただけないでしょうか。 -
- I don't find this feature useful. If you wanted to raise an error when no block is given, all you have to do is call `yield` within the method body, which will not be an extra code if you are going to use the block somewhere in the metho...
-
- This is an interesting suggestion in the sense that block parameters,
or rather, blocks as a whole, are a bit like additional arguments to
every method in ruby, at all times, optional; but they are also quite
special entities in ruby.... -
01:29 AM Feature #15352 (Open): Mandatory block parameters
- There are too many block parameter assertions (it's kind of idioms: [`raise NoBlockGiven unless glock_given?`](https://github.com/search?q=raise+NoBlockGiven+unless+block_given&type=Code)).
It's very useful if there's a syntax to decl... -
10:52 AM Misc #15342: DevelopersMeeting20181212Japan
- * [Feature #10771] An easy way to get the source location of a constant
-
- I don't have a big pro or con opinion (am neutral here), but perhaps we could move this
to an upcoming developer meeting anyway? -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66072 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66071 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Four more use of create_sequence_node() in node_extended_grapheme_cluster
(a few more to come).
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66070 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * lib/optparse.rb (OptionParser::Switch#initialize): get rid of
`Proc.new` without a block, which may be deprecated in the future.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66069 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * lib/optparse.rb (OptionParser::Switch#compsys): remove useless
backslash which just confuse ruby-mode.el.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66068 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- tarui@prx.jp wrote:
> Feature #10548: Callcc is now going obsoleted. Please use Fiber.
> https://bugs.ruby-lang.org/issues/10548
How about adding --disable-callcc configure option?
https://80x24.org/spew/20181128051213.19518-1-... -
- > That's a fair point. However, considering you can work around
> the current deadlock detection with
> `Thread.new{loop{sleep(1000000)}}` before calling `Queue#pop`,
> the deadlock detection doesn't really cause major problems if
... -
- normalperson (Eric Wong) wrote:
> merch-redmine@jeremyevans.net wrote:
> ...
I use Queue pretty extensively when testing to ensure deterministic behavior in multithreaded code, and I can say it would be a lot more difficult to write su... -
- merch-redmine@jeremyevans.net wrote:
> I expect this would make it more difficult to debug
> multithreaded use of Queue, since ruby would hang instead of
> raising a fatal exception as it does currently (assuming I
> understand the ... -
- I expect this would make it more difficult to debug multithreaded use of Queue, since ruby would hang instead of raising a fatal exception as it does currently (assuming I understand the patch correctly). As multithreaded use of Queue i...
- 04:31 AM Revision e9dbafa5 (git): test_settracefunc (test_tracepoint_enable_with_target_line): less fragile
- Allow us to make other changes to the file and move the method
around without affecting this test.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66067 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66066 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- https://github.com/rubygems/rubygems/pull/2493
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66065 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Temporary ignored configuration of certificate sign.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66064 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- One more use of create_sequence_node() in node_extended_grapheme_cluster
(several more to come).
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66063 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I reopen this ticket as a reminder to fix MinGW test failure by this. Please close this ticket once AppVeyor becomes green with r66062 reverted.
-
- ko1 is fixing this and he suggested to skip it for now
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66062 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:51 AM Bug #14998 (Closed): Race conditions in MonitorMixin when interrupted
- Applied in changeset trunk|r66061.
----------
lib/monitor.rb: avoid race conditions by Thread.handle_interrupt
Suggested by Benoit Daloze. [ruby-core:88502] [Bug #14998] -
- Suggested by Benoit Daloze. [ruby-core:88502] [Bug #14998]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66061 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 01:10 AM Revision db7338fd (git): io.c (rb_update_max_fd): use F_GETFL if possible
- On 64-bit Linux, fstat() needs to fill out a 144 byte struct
while F_GETFL only needs to return 8 bytes.
Fwiw, F_GETFD requires an additional rcu_read_lock and bitmap
check; so it's obviously more expensive than F_GETFL on Linux.
Reduc... -
- * coroutine/win32/Context.asm: old ml version 9 needs CPU
directive before `.model` directive.
* win32/Makefile.sub: specify object directories to separate Win32
and Win64 targets. Win32 rule was overridden by Win64 rule and
just... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66058 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Introduce a new preprocessor macro R_ERR to visually reduce repetitive code
checking for return values and going to the err: label at the end of the
function node_extended_grapheme_cluster().
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/... -
- It was probably me, 7 years ago, in r33844, who started overly
quoting YAML strings. But now, this file grown up 50+ times from
6 lines to more than 300. It is more annoying than convenient to
quote everything to add backslashes here a... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66055 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 12:35 AM Revision b75a4591 (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66054 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 12:35 AM Revision e432c526 (git): io.c: reduce IO.copy_stream stack usage on Linux
- nogvl_copy_file_range and nogvl_copy_stream_sendfile each
used 344 bytes of stack before this change. Now, they are
inlined into nogvl_copy_stream_func which only uses 200 bytes
of stack.
"struct stat" is 144 bytes on my 64-bit Linux.
... -
- There are only four patterns of the last two arguments to quantify_property_node().
By replacing the lower/upper arguments with a single char, we get more expressive
calls, the last argument directly corresponding to the quantifier that ...
11/27/2018
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66051 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- tenderlove@ruby-lang.org wrote:
> I was going to apply this patch, but it modifies `rb_ary_resurrect` and I wanted to double check. `rb_str_resurrect` will create shared strings, so it seems OK for `rb_ary_resurrect` to create shared... -
- In this example code:
~~~ ruby
def foo
[1, 2, 3, 4]
end
~~~
The array literal uses a duparray instruction. Before this patch,
rb_ary_resurrect would malloc and memcpy a new array buffer. This
patch changes rb_ary_resurrect ... -
- thread_sync.c (queue_sleep): remove deadlock checking
Queue may be used inside signal handlers nowadays, so deadlock
checking is unnecessary and prevents single-threaded use.
We don't have deadlock checking for reading pipes/socke... - 10:48 PM Revision 7b5c2d3f (git): enumerator.c (enum_chain_yield_block): use predefined ID
- No point in having rb_intern lookup and cache a predefined ID
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66050 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 10:20 PM Revision a607c866 (git): io.c (struct copy_stream_struct): packing
- Reduce the struct to 80 bytes (from 88) on amd64 to reduce
stack use.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66049 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
10:13 PM Bug #15346: Core dump during GC if covering a special require
- Wow, very fast handling, thank you.
I confirm that this seems to have solved things on my end. Travis has not updated their ruby-head yet, but I assume it will be fine there too.
Thanks again -
- The commit was r66025. (I have no idea why the commit is not automatically related to this ticket.)
I investigated the reason why lineno is 0. In Ruby bytecode, each instruction has lineno information. However, the ensure clause ha... -
-
- This report is awesome. Thank you very much!
The coverage counters are initialized with `counter[lineno - 1] = 0`. However, the lineno of ensure clause is 0 (for unknown reason). So it caused write access for index -1, which broke ... -
- On my environment, (ruby-head, updated today) the following script generates a core dump almost all the time. (I join a core dump to this report)
I am running on Ubuntu 16.04, I first saw the problem on Travis-CI and managed to make t... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66048 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 09:38 PM Revision 793c48b4 (git): * remove trailing spaces.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66047 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66046 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- > We've spent a lot of time for supporting C90 https://github.com/ruby/ruby/search?o=desc&q=c99&s=committer-date&type=Commits.
> It is not only time-consuming but also sometimes sacrifices readability like r66034 (today's commit).
A... -
- k0kubun (Takashi Kokubun) wrote:
> We've spent a lot of time for supporting C90 https://github.com/ruby/ruby/search?o=desc&q=c99&s=committer-date&type=Commits.
> ...
First, thanks for r66034. In this case, it ultimately led to better c... -
- Personally I am not affected either way, so this is for the ruby developers; and those
users who may be affected by the change away from C90 support (which does not include me).
I think it would be nice to drop C90 support, if we say... -
- I would like to add that for Clang, -Werror=declaration-after-statement is ignored in c99 mode due to a bug: https://bugs.llvm.org/show_bug.cgi?id=27493.
Because of this, it's easy to author code that isn't C90 compatible when using Cla... -
- For VC++, I heard from @usa (mswin platform maintainer) that he assumes Microsoft does not declare EOL of old VC++s, so he sometimes drops support of old versions as he thinks okay, and he is thinking about requiring vc12 from Ruby 2.7.
... -
- ## Problem
We've spent a lot of time for supporting C90 https://github.com/ruby/ruby/search?o=desc&q=c99&s=committer-date&type=Commits.
It is not only time-consuming but also sometimes sacrifices readability like r66034 (today's commit... -
- In function node_extended_grapheme_cluster(), store and test
return value from create_sequence_node(). Never forget this!
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66045 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 09:12 PM Revision 87cda89c (git): * remove trailing spaces.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66044 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- In function node_extended_grapheme_cluster(),
move declaration up so that block encompasses all of the regular expression
creation that finally makes up the sequence. Having blocks like this will
be great because it directly shows the ex... -
- We make sure that the newly created tree and all remaining nodes passed in
in the node_array are freed.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66042 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
08:38 PM Revision 50441014 (git): Update to ruby/spec@cdd6ff7
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66041 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 08:38 PM Revision 49cd16bf (git): * 2018-11-28
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66040 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66039 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- This has caused failures in spec/ruby/core/main/using_spec.rb, specifically the first spec.
On Appveyor, trying several versions of both specs, the first one (`eval('using', TOPLEVEL_BINDING)`) fails, the second one (`eval('using "foo... -
07:11 PM Bug #15314: Bundler with 2.6 fails when installing dependencies into a --path with --binstubs
- I confirm this issue is no longer a problem for Heroku. Thanks for your work!
I did hit a segfault though with bootsnap https://gist.github.com/schneems/95ad82f39c8c7f24fe228d3bfda2937e. It looks unrelated, I'll try to reproduce local... -
- * misc/ruby-style.el (ruby-style-c-mode): set ruby-style if the
remote repository is ruby.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66038 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 12:08 PM Revision 5bc8bb36 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66037 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66036 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- -local variable to global variable.
Consider this case:
1. MJIT worker: dequeue ISeq (stop_worker_p was still FALSE)
2. Ruby thread: call Kernel#exec, which calls mjit_finish(FALSE),
sets `stop_worker_p = TRUE`, and fire... -
- ../regparse.c:5908:28: error: initializer for aggregate is not a compile-time constant [-Werror,-Wc99-extensions]
Node* sequence[] = { np1, np2, np3, ((Node* )0) };
^~~
https://travis-ci.org/ruby/ruby/jo... -
- The new function create_sequence_node() uses its second argument
(an array of Node*, from left to right, ending with NULL_NODE)
to create a sequence of expressions using node_new_list().
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk... - 10:15 AM Revision 231930ca (git): * remove trailing spaces.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66032 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- The new function quantify_property_node() combines the functions
create_property_node() and quantify_node(), which frequently appear together.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66031 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66030 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- I hope the situation should be better since r63915 which makes IRB default gem. Now if only the version was properly increased ...
-
- GCC_FLAGS is not an array and CC is finally passed to configure as
single string. Pass CC via the environment variable, so it does
not need to be quoted anymore.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66029 b2dd03c8-39d4-4d8... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66028 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66027 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 07:34 AM Revision a1c4e0c9 (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66026 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- The coverage counters is initialized with `counter[lineno - 1] = 0`,
but lineno may be 0, which led to write access for index -1.
[ruby-core:90085] [Bug#15346]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66025 b2dd03c8-39d4-4d8f-9... -
07:02 AM Revision 4beec667 (git): Merge rdoc-6.1.0.bata2
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66024 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66023 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66022 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66021 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- @shyouhei Thanks for updating this issue correctly.
Thanks for providing some background on `$SAFE`.
I think the goal should be ensuring Ruby has the tools and processes in place to minimise issues like the ones facing NodeJS. Whet... -
- From @mame: http://ruby.11.x6.nabble.com/ruby-core-26388-suggestion-gems-ruby-lang-org-tt3595295.html
-
- At first glance this topic is a bit vague. I like how `unveil(2)` works, but honestly I have no idea if adopting that way prevents dominictarr/event-stream issue.
So at the starting point: may I ask your goal of this thread? Do you ... -
- I would like to start a discussion relating to https://github.com/rubygems/rubygems/issues/2496
I don't know what has been done here already. I know from a computability POV, it's impossible to solve this problem.
That being said, ... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66020 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Similar to rb_typeddata_is_kind_of, except for that inherited type
is not an instance.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66019 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66018 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * iseq.c (iseqw_s_of): `rb_method_iseq(method)` can return NULL.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66017 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 02:45 AM Revision 467c2982 (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66016 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * iseq.c (iseqw_s_of): return given object if the given object is
a `RubyVM::InstructionSequence`. We can specify ISeq for
`TracePoint#enable(target:)`.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66015 b2dd03c8-39d4-4d8f-98f... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66014 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66013 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66012 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66011 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
11/26/2018
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66010 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 08:16 PM Revision 27b1553b (git): * remove trailing spaces.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66009 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * vm_trace.c: `TracePoint#enable(target_line:)` is supported.
This option enables a hook only at specified target_line.
target_line should be combination with target and :line event.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trun... -
- This issue is epic due to its title alone! (I don't quite know whether
there are indeed genie and zombie emojis yet but it makes me curious.)
> except those relating to genies, zombies, and wrestling (THIS IS NOT
> ...
Awww .... :) -
- All the codepoint combinations that turn up in the various emoji files provided by Unicode (currently we use those at https://www.unicode.org/Public/emoji/5.0/) are recognized as grapheme clusters by `String#each_grapheme_cluster`, excep...
-
- > The map(&method(:local_method)) or yield_self(&method(:local_method)) pattern is absolutely real
> ...
Everyone who suggests something tends to think of it as useful and often pretty too. :-)
I personally have become too picky perh... -
- * cont.c (cont_restore_thread): cause error if trace-status is changed.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66007 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * iseq.c (iseq_add_local_tracepoint_i): extract aggregate initialization.
See https://travis-ci.org/ruby/ruby/jobs/459881277
* iseq.c (iseq_remove_local_tracepoint_i): ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66006 b... -
- * iseq.c (iseq_iterate_children): should use cast to `int`.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66005 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r66003.
----------
Support targetting TracePoint [Feature #15289]
* vm_trace.c (rb_tracepoint_enable_for_target): support targetting
TracePoint. [Feature #15289]
Tragetting TracePoint is only enabled on ... - 06:16 PM Revision 61c8247d (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66004 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * vm_trace.c (rb_tracepoint_enable_for_target): support targetting
TracePoint. [Feature #15289]
Tragetting TracePoint is only enabled on specified method, proc
and so on, example: `tp.enable(target: code)`.
`code` should be con... -
- nobu (Nobuyoshi Nakada) wrote:
> About the macro `BUILTIN_SINGLE_BYTE_ENC_IDX_P`, its name is misleading as it is true for UTF-8.
I agree. I removed it.
> ...
Done.
I moved away from using +1 in the buffer size, since it could ... -
- alanwu (Alan Wu) wrote:
> I've taken multi-byte terminators into account and updated my implementation. I've also included a test that should warn us about hash clobbering.
Seems nice.
About the macro `BUILTIN_SINGLE_BYTE_ENC_IDX_... -
- I've taken multi-byte terminators into account and updated my implementation. I've also included a test that should warn us about hash clobbering.
I also noticed that the benchmark that creates many unique fstrings is actually 5% slower... -
- https://ci.appveyor.com/project/ruby/ruby/builds/20558412
removing CloseHandle disallows us to remove the DLL.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66002 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r66001.
----------
vm_trace.c: MJIT-limited thread-safety for postponed_job
[Bug #15316] -
- [Bug #15316]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66001 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 03:12 PM Revision 01e2bf35 (git): * 2018-11-27
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66000 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- because JIT-ed code may still be on stack at this time, unlike
in ruby_cleanup().
This hopes to fix: (take 2)
http://ci.rvm.jp/results/trunk-mjit-wait@silicon-docker/1480207
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65999 b2dd0... -
- This reverts commit 0e6aba22c6b876a36adc39cac5314ce6e626954c.
because it didn't help, at all.
http://ci.rvm.jp/results/trunk-mjit-wait@silicon-docker/1480207
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65998 b2dd03c8-39d4-4d8f-98... -
- http://ci.rvm.jp/results/trunk-mjit-wait@silicon-docker/1480173
It tries to print C backtrace but fails. And core file on the server
seems to be stopping on the irrelevant place due to its own signal
handler for the dump.
And I failed ... - 02:03 PM Revision c8c265f4 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65996 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65995 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- to prevent ruby from leaving MJIT-related files.
test_jit.rb: add a test to prevent that
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65994 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- after MJIT worker stop.
r65928 didn't fix the SEGV. This commit hopes to fix
http://ci.rvm.jp/results/trunk-mjit-wait@silicon-docker/1478576
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65993 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- by Bundler integration, like:
http://ci.rvm.jp/results/trunk-no-mjit@silicon-docker/1479769
This resurrects r65629 which was accidentally reverted by r65904.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65992 b2dd03c8-39d4-4d8f-98... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65991 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- @schneems
I fixed this issue with https://github.com/ruby/ruby/commit/a94332819463589fe4537cc62beb41a0ee354cf3
Can you try the current trunk revision? -
- Testing with r65990 on x86_64 and the test passed. I guess I should not try to build on other arches yet, right?
-
- Add file test/ruby/enc/test_emoji_breaks.rb to test String#each_grapheme_cluster
test data provided by Unicode (at https://www.unicode.org/Public/emoji/#{EMOJI_VERSION}/).
Lines containing emoji for genies, zombies, and wrestling are ig... -
- Object#=~ always returns nil. This behavior is not only unuseful but
also troublesome because it may hide a type error.
This change deprecates Object#=~. For compatibility, NilClass#=~ is
newly introduced. [Feature #15231]
git-svn-i... -
- RubyGems is very indifferent for type.
This change is needed for removal of `Object#=~`. [Feature #15231]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65988 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65987 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- I don't have answers for every questions but for the first one: we enable cron builds for Travis-CI, which run every day. This is a handy occasion to do lots of additional tests. Compare these two results:
- https://travis-ci.org/ru... -
- RDoc::Options#@exclude is initialized as an empty array.
Then, #finish converts it to a regexp or nil and reassign it to @exclude.
Some methods of RDoc assumes that #finish has been already called.
So, this change forces to assign nil to... -
- * [Feature #13581] Syntax sugar for method reference
-
- Please comment your favorite ticket numbers you want to ask to discuss with your *SHORT* comment or summary.
(your summary/comment will help us because we don't need to read all of ticket comments)
*DO NOT* discuss then on this ticke... -
- `@res` is an Array, so `@res =~ /\n\z/` calls `Object#=~` which always
returns nil.
I guess it should be `@res.last =~ /\n\z/`, but the change causes test
failures.
This bug was found during work for removal of `Object#=~`.
[Feature #15... -
- Applied in changeset trunk|r65984.
----------
lib/webrick: explicitly convert header values to a string
The values of @header are expected to be all strings;
WEBrick::HTTPResponse::[]=(key, val) explicitly converts the second
argument ... -
- The values of @header are expected to be all strings;
WEBrick::HTTPResponse::[]=(key, val) explicitly converts the second
argument to a string and assigns it to @header hash.
However, there were some points in WEBrick internal code that ... -
-
- The Emoji version is different from the Unicode version. Currently, the Unicode version is accessible from `RbConfig::CONFIG['UNICODE_VERSION']`, but it's not possible to get the Emoji version.
I need the Emoji version for testing, so... -
- I agree that `#visibility` is the best solution. When somebody mentioned this at the recent Ruby committers' meeting, I immediately thought "that's it". Benoit provides some more background.
There are arguments that this may be misund... -
- * common.mk (ruby.imp): extract the first word on the next lines
of MJIT_FUNC_EXPORTED, regardless the prefix. duplicate symbols
will be removed by `sort -u`.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65983 b2dd03c8-39d4-4d... -
- We can set environment variables to avoid before_script.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65982 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- see r65965
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65981 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Exclude OpenSSL because we don't plan to debug libssl,
also track origins of uninitialized bits.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65980 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
-
-
- Applied in changeset trunk|r65979.
----------
Removed `bundle_ruby` command. Because It's no longer shipped from Bundler 1.0.2.
[Bug #15291][ruby-dev:50663] -
- [Bug #15291][ruby-dev:50663]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65979 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- znz (Kazuhiro NISHIYAMA) wrote:
> How about checking owner object?
Could you commit it if it passes tests?
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65978 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65977 b2dd03c8-39d4-4d8f-98ff-823fe69b080e