Project

General

Profile

Activity

From 11/24/2018 to 11/30/2018

11/30/2018

11:58 PM Revision cf18fc32 (git): * 2018-12-01
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66108 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
11:58 PM Revision f86b49c1 (git): * expand tabs.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66107 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
11:58 PM Revision cbdf5a18 (git): Collapse putobject, putobject, newarray
This collapses:
```
== disasm: #<ISeq:bar@bench.rb:3 (3,0)-(5,3)> (catch: FALSE)
0000 putobject "a" ( 4)[LiCa]
0002 putobject "b"
0004 putobject ...
tenderlovemaking (Aaron Patterson)
11:34 PM Feature #15363 (Open): Case insensitive file systems - add info to CONFIG or somewhere?
I was under the impression that Windows was the only case insensitive file system. That is not the case. In RubyGems, there are places in both code and tests where this needs to be accounted for.
Although none come to mind, the same...
MSP-Greg (Greg L)
11:03 PM Feature #15349 (Closed): Use a shared array for the `duparray` instruction
I committed this in r66095, not sure why it didn't close this. tenderlovemaking (Aaron Patterson)
10:47 PM Bug #15362: [PATCH] Avoid GCing dead stack after switching away from a fiber
Alan,
You're amazing... We're completely blocked on upgrading by this bug. You're a savior
Thanks,
Andrew
aselder (Andrew Selder)
08:22 PM Bug #15362 (Closed): [PATCH] Avoid GCing dead stack after switching away from a fiber
Hello! I have a patch that fixes Bug #14561. It's not a platform specific issue but
it affects the default build configuration for MacOS and is causing segfaults on 2.5.x.
I've put the test for this in a separate patch because I'm not ...
alanwu (Alan Wu)
09:03 PM Misc #15347: Require C99
cremno@mail.ru wrote:
> Back to Visual Studio:

What is the feasability of requiring GCC or clang for Windows builds
instead of supporting VS?

I know GCC can cross-compile for win32, at least; and I got
miniruby to run under WIN...
normalperson (Eric Wong)
02:03 PM Misc #15347: Require C99
Requiring a more modern version of MSVC should be a given anyway. Currently CRuby still tries to support 6.0 (`_MSC_VER=1200`) which was originally released in 1998 and has seen its last update in 2004. Additional code like in `numeric.c... cremno (cremno phobia)
08:27 PM Bug #14561: Consistent 2.5.0 seg fault in GC, related to accessing an enumerator in a thread
I have a patch for this, #15362 if anyone could take a look. alanwu (Alan Wu)
05:20 AM Bug #14561: Consistent 2.5.0 seg fault in GC, related to accessing an enumerator in a thread
I thought this was fixed already in 2.6 - but obviously not. That's bad :( ioquatix (Samuel Williams)
05:18 AM Bug #14561: Consistent 2.5.0 seg fault in GC, related to accessing an enumerator in a thread
Would it possible to get this addressed? It blocking my entire organization from upgrading past Ruby 2.4
It's reproducible on all 2.5 releases as well as the 2.6 preview releases.
It's been reported multiple times:
https://bugs.ru...
aselder (Andrew Selder)
03:47 PM Bug #15333 (Closed): make check fails looking for Bundler 2.0
Build on a totally clean CentOS 7 box passed without failure. I would attribute this issue to "user's host configuration". leam (Leam Hall)
01:14 AM Bug #15333: make check fails looking for Bundler 2.0
My original failure was on a Fedora 28 box. I am building a CentOS 7 box and still getting the build environment set up for a totally clean build. I apologize for the delay. leam (Leam Hall)
02:33 PM Feature #9577 (Closed): [PATCH] benchmark/driver.rb: align columns in text output
I think this was already fixed by introducing benchmark-driver.
~~~
$ make benchmark OPTS="-r time -o simple" ITEM=app_
../revision.h unchanged
/home/k0kubun/.rbenv/shims/ruby --disable=gems -rrubygems -I../benchmark/lib ../benchma...
k0kubun (Takashi Kokubun)
11:59 AM Revision 9234318e (git): merge revision(s) 65956:
fix r65954; Keep tainty
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@66105 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nagachika (Tomoyuki Chikanaga)
11:44 AM Revision 8f23f690 (git): test/ruby/test_io.rb (test_recycled_fd_close): remove hacks
I think I finally fixed the underlying bug in r65937
("io.c (fptr_finalize_flush): close race leading to EBADF")
I've run this test over 100000 times on a multicore system, now.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66104 b...
Eric Wong
07:59 AM Bug #15361 (Closed): [backport] Import Ruby/OpenSSL 2.1.2
https://github.com/ruby/openssl/pull/160 (included in Ruby/OpenSSL 2.1.0 and newer) fixes an incompatibility with OpenSSL 1.1.0 and newer. This version of Ruby/OpenSSL was merged into Ruby Trunk and 2.5, but not 2.4:
* https://bugs.rub...
devurandom (Dennis Schridde)
07:19 AM Revision 26771cad (git): Added words in the comment at r65088 [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66103 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
07:04 AM Revision 157b1090 (git): Update source code URI in bundled_gems [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66102 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
05:25 AM Bug #13746 (Closed): windows-pr gemのRuby 2.4 32bit版でのSEGV
cosmo0920 (Hiroshi Hatake)
05:19 AM Bug #15316: rb_postponed_job_register not thread-safe
> r66100
Thanks to work on this, Eric.
k0kubun (Takashi Kokubun)
05:15 AM Bug #15343: String#each_grapheme_cluster wrongly splits some emoji (genie, zombie, wrestling)
I had my computer spend about 10h to compile Ruby with regexp debug flags activated. It took that long because while Ruby is building, it starts running Ruby scripts with lots of regexp debug output. (I probably should have deactivated d... duerst (Martin Dürst)
03:56 AM Revision dc1ecab0 (git): test/testunit/test_parallel.rb: respect subprocess timeout scale
MJIT tests take longer than 100s on my VM :<
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66101 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Eric Wong
03:56 AM Revision eb38fb67 (git): vm_trace.c: workqueue as thread-safe version of postponed_job
postponed_job is safe to use in signal handlers, but is not
thread-safe for MJIT. Implement a workqueue for MJIT
thread-safety.
[Bug #15316]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66100 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Eric Wong
01:01 AM Bug #15354 (Rejected): Remove Bundler from StdLib
I have the same concerns.
I'm going to resolve the duplicated vendoring problem at https://github.com/rubygems/rubygems/pull/2026.
hsbt (Hiroshi SHIBATA)
12:49 AM Bug #15354: Remove Bundler from StdLib
@colby
Ok. I decided on the longer message.
> snide comment
Snide - 'derogatory or mocking in an indirect way'. @vo.x's comment is direct, and his point about the vendored libraries is valid.
> ...
Something just seems back...
MSP-Greg (Greg L)

11/29/2018

11:30 PM Revision d7e4e50b (git): io.c: fix clang -Werror,-Wshorten-64-to-32 on Linux sendfile
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66099 b2dd03c8-39d4-4d8f-98ff-823fe69b080e Eric Wong
11:28 PM Revision 1372c092 (git): io.c: fix clang -Werror,-Wshorten-64-to-32 errors
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66098 b2dd03c8-39d4-4d8f-98ff-823fe69b080e Eric Wong
11:09 PM Bug #15354: Remove Bundler from StdLib
vo.x (Vit Ondruch) wrote:
> please consider removal of Bundler from StdLib unless upstream demonstrates it can maintain it properly.
Hi, Bundler core team dev here.
What does this even mean? We have been maintaining Bundler "prop...
colby (Colby Swandale)
06:35 AM Bug #15354: Remove Bundler from StdLib
I am afraid that my issues won't be addressed as long as independent Bundler is not discontinued and this have not happened for past 10 years. If this was just announced, the two copies of Molinillo could be merged into one for start. Th... vo.x (Vit Ondruch)
05:51 AM Bug #15354: Remove Bundler from StdLib
@vo.x
Many of the points you make are true.
I also think about when Travis mucked up their builds (at least trunk, maybe more) with RubyGems & Bundler, and at least a few popular repos/gems had CI issues. You mentioned that many u...
MSP-Greg (Greg L)
10:37 PM Revision 6ccc2379 (git): * expand tabs.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66097 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
10:37 PM Revision f47b38b0 (git): io.c: favor comparisons against zero rather than -1
On my 32-bit x86 userspace, I get the following .text savings:
text data bss dec hex filename
152971 56 252 153279 256bf io.o.before
152863 56 252 153171 25653 io.o.aft...
Eric Wong
10:22 PM Feature #14915: Deprecate String#crypt
mame@ruby-lang.org wrote:
> IMO, documentation is not enough. A warning may annoy a user,
> but sudden removal (in future) is much worse.

There should never be a sudden removal.

Honestly, I don't think we should make the first ...
normalperson (Eric Wong)
03:23 PM Feature #14915: Deprecate String#crypt
mame (Yusuke Endoh) wrote:
> IMO, documentation is not enough. A warning may annoy a user, but sudden removal (in future) is much worse.
> ...
Here's an updated patch that switches to using `rb_warning`, with appropriate updates to th...
jeremyevans0 (Jeremy Evans)
11:52 AM Feature #14915: Deprecate String#crypt
IMO, documentation is not enough. A warning may annoy a user, but sudden removal (in future) is much worse.
As a first step, how about `rb_warning` instead of `rb_warn`? It prints a warning only when $VERBOSE is enabled. A well-man...
mame (Yusuke Endoh)
10:32 AM Feature #14915: Deprecate String#crypt
merch-redmine@jeremyevans.net wrote:
> File 0001-Deprecate-String-crypt.patch added

I am against the rb_warn call. Documentation change is enough.

Typical users (non-programmers) may not know how to quiet
the warning or fix the...
normalperson (Eric Wong)
08:31 AM Feature #14915: Deprecate String#crypt
jeremyevans0 (Jeremy Evans) wrote:
> mame (Yusuke Endoh) wrote:
> ...
I've updated the patch to apply against trunk. I would like this change to make 2.6 unless there are objections. Can a committer perform a final review and commit ...
jeremyevans0 (Jeremy Evans)
09:32 PM Feature #10548: remove callcc (Callcc is now going obsoleted. Please use Fiber.)
Eric Wong wrote:
> tarui@prx.jp wrote:
> > Feature #10548: Callcc is now going obsoleted. Please use Fiber.
> > https://bugs.ruby-lang.org/issues/10548
>
> How about adding --disable-callcc configure option?
>
> https://80x24....
normalperson (Eric Wong)
09:22 PM Bug #14968: [PATCH] io.c: make all pipes nonblocking by default
ko1@atdot.net wrote:
> Honestly speaking, we are not sure we can introduce it into
> Ruby 2.6 (incompatibility, stability and so on).

Doesn't look like we can.

> So please commit it and let's try it.
> If we find troubles we ca...
normalperson (Eric Wong)
08:39 PM Revision d46cd60f (git): Use a shared array for the `duparray` instruction
In this example code:
```ruby
def foo
[1, 2, 3, 4]
end
```
The array literal uses a `duparray` instruction. Before this patch,
`rb_ary_resurrect` would malloc and memcpy a new array buffer. This
patch changes `rb_ary_resurrect` to u...
tenderlovemaking (Aaron Patterson)
08:00 PM Bug #15356 (Closed): Rack::Deflater on Rails responds with no data on Ruby 2.6.0
Applied in changeset trunk|r66093.
----------
disable non-blocking pipes and sockets by default
There seems to be a compatibility problems with Rails +
Rack::Deflater; so we revert this incompatibility.
This effectively reverts r65922...
normalperson (Eric Wong)
07:22 PM Bug #15356: Rack::Deflater on Rails responds with no data on Ruby 2.6.0
zundan@gmail.com wrote:
> Thanks! The patch actually fixed the problem.

OK, that is surprising...

> > So you're saying this is not a new problem...
>
> First time I noticed this was running a Rails app on `2.6.0-preview1` on H...
normalperson (Eric Wong)
06:40 PM Bug #15356: Rack::Deflater on Rails responds with no data on Ruby 2.6.0
Thanks! The patch actually fixed the problem.
With `2.6.0-dev` pointing to the binary built as below, the command `curl -H 'Accept-encoding: gzip' -v http://localhost:3000 --raw` prints the HTML data as expected.
~~~
$ cat io.patc...
zunda (zunda an)
10:42 AM Bug #15356: Rack::Deflater on Rails responds with no data on Ruby 2.6.0
zundan@gmail.com wrote:
> Clarify what I think of causing the problem.

> I'd like to report that a Rails app with `Rack::Deflater`
> enabled responds with a zero-length body on Ruby 2.6.0, to a
> request with `Accept-encoding: gzi...
normalperson (Eric Wong)
08:46 AM Bug #15356: Rack::Deflater on Rails responds with no data on Ruby 2.6.0
Clarify what I think of causing the problem. zunda (zunda an)
08:00 PM Revision 0620c97e (git): * 2018-11-30
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66094 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
08:00 PM Revision 9d74d402 (git): disable non-blocking pipes and sockets by default
There seems to be a compatibility problems with Rails +
Rack::Deflater; so we revert this incompatibility.
This effectively reverts r65922; but keeps the bugfixes to
better support non-blocking sockets and pipes for future use.
[Bug #1...
Eric Wong
06:48 PM Bug #15359: Bundler help is not properly integrated
I can't comment on the issue itself but I wanted to add that I personally do not
use man-pages. I use the commandline "--help" flag, though, and of course online
queries for help (and then I often put useful bits into a local knowledg...
shevegen (Robert A. Heiler)
12:48 PM Bug #15359: Bundler help is not properly integrated
BTW I am not sure how the Bundler man pages are imported into Ruby repository, but I think there should be either the source .ronn files or the resulting .txt files and man page files. Not both. vo.x (Vit Ondruch)
12:42 PM Bug #15359 (Closed): Bundler help is not properly integrated
Bundler has nice help, but it is a bit complex [1]. It ideally needs `man` command installed but it definitely needs the help source files, which are not placed on proper location to be reachable by BUndler from StdLib. In that case, Bun... vo.x (Vit Ondruch)
06:13 PM Bug #15360 (Closed): "ThreadError: deadlock; recursive locking" error when recursive lock shouldn't be possible
I think I've discovered a Ruby bug, possibly introduced in 2.5.
I've attached a reproduction script; running it on Ruby 2.5.0+ (including previews of 2.6.0) seems to always produce a flood of printed `ThreadError: deadlock; recursive ...
brockspratlen (Brock Spratlen)
03:58 PM Bug #14200: addr2line.c compile error with C89 compilers on Solaris 10
非常に詳細なご説明をいただきありがとうございます。
では、標準ライブラリに関しては諦めた上でその他の範囲でC99の一部の機能を使うことにした場合、Solaris 10, 11で、
* 公式の Oracle Developer Studio ではバージョン12以降で動くことを保証する。それ以前のバージョンでは、C99を有効化する方法がある限りconfigureでそれに対応し、それが可能な限りサポートする。
* Fujitsu C Compiler (fcc)...
k0kubun (Takashi Kokubun)
03:50 PM Bug #14200: addr2line.c compile error with C89 compilers on Solaris 10
r63571 で対策された isnan のように、準拠規格によって定義が異なる関数やマクロがあったら、問題は発生するのかもしれません。(今の所、私の環境では、Rubyのコンパイル時には遭遇したことはないので、具体例は無いのですが) ngoto (Naohisa Goto)
03:12 PM Bug #14200: addr2line.c compile error with C89 compilers on Solaris 10
> Soraris 11や10、あるいは9以前に関してそれぞれについて具体的にどのような懸念や副作用があるか
Solaris 9 およびそれ以前はもう考慮する必要はないと思います。
Solaris 10/11 の公式コンパイラである Oracle Developer Studio (旧名称 Oracle Solaris Studio、旧旧名称 Sun Studio)では、遅くともバージョン12以降ではC99をサポートしています。
デフォルトは、12.3...
ngoto (Naohisa Goto)
02:47 PM Bug #15335: Ruby 2.6.0 is not properly fortified
Just FTR trying to build r66092 on Fedora Rawhide [1], x86_64, ppc64le, aarch64, s390x, and armv7hl were properly fortified while only i686 failed to pass [2] the fortification test.
[1]: https://koji.fedoraproject.org/koji/taskinfo...
vo.x (Vit Ondruch)
02:14 PM Bug #13758: TestRubyOptions#test_segv_setproctitle segfaults on AARCH64
Any chance to get this fixed? It is nice that Ruby has such fancy SIGSEGV handler, but it does not work on all platforms and it makes the matters just worse. vo.x (Vit Ondruch)
11:36 AM Feature #15289 (Closed): Accept "target" keyword on `TracePoint#enable`
The above issue was fixed in r66087. Thank you. k0kubun (Takashi Kokubun)
11:33 AM Feature #13618: [PATCH] auto fiber schedule for rb_wait_for_single_fd and rb_waitpid
Eric Wong <normalperson@yhbt.net> wrote:
> samuel@oriontransfer.net wrote:
> > @k0kubun I like the general ideas presented here but the
> > implementation is too heavy/specific for my use case. For
> > example, it won't work on JRub...
normalperson (Eric Wong)
12:22 AM Feature #13618: [PATCH] auto fiber schedule for rb_wait_for_single_fd and rb_waitpid
samuel@oriontransfer.net wrote:
> @k0kubun I like the general ideas presented here but the
> implementation is too heavy/specific for my use case. For
> example, it won't work on JRuby, TruffleRuby, or other
> implementations. That'...
normalperson (Eric Wong)
09:22 AM Revision d7e30434 (git): Remove unused variable in example code [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66092 b2dd03c8-39d4-4d8f-98ff-823fe69b080e znz (Kazuhiro NISHIYAMA)
08:57 AM Feature #14244: Better error messages for scripts with non-matching end statements
mame (Yusuke Endoh) wrote:
> foonlyboy (Eike Dierks) wrote:
> ...
Another implementation approach is to store the indent-related warnings during compilation, and output them once we hit an error, otherwise discard them.
duerst (Martin Dürst)
03:52 AM Feature #14244: Better error messages for scripts with non-matching end statements
> I'd like to propose,that on a missing 'end'
> ...
Can we get the incomplete(?) parse tree when a syntax error occurred? Note that the source code itself can not be necessarily rescanned because it might be passed via a pipe stream.
mame (Yusuke Endoh)
01:08 AM Feature #14244: Better error messages for scripts with non-matching end statements
I fully agree with Martin that this is one of the most annoying problems.
I used ruby -w on my failing file and it told me (which was helpful)
~~~
333: warning: mismatched indentations at 'end' with 'if' at 332
523: warning: mism...
foonlyboy (Eike Dierks)
08:04 AM Bug #15358 (Closed): Segfault in rb_transient_heap_mark when running Sequel's specs
Applied in changeset trunk|r66091.
----------
clear dst Hash on Hash#replace. [Bug #15358]
* hash.c (linear_copy): solve two issues on `Hash#replace`.
(1) fix memory leak
(1-1) don't allocate memory if destination already
...
ko1 (Koichi Sasada)
07:43 AM Bug #15358: Segfault in rb_transient_heap_mark when running Sequel's specs
Thank you for your report.
I found a bug and will commit soon.
Thanks,
Koichi
ko1 (Koichi Sasada)
08:03 AM Revision a763e346 (git): clear dst Hash on Hash#replace. [Bug #15358]
* hash.c (linear_copy): solve two issues on `Hash#replace`.
(1) fix memory leak
(1-1) don't allocate memory if destination already
has a memory area.
(1-2) free destination memory if src is NULL.
(2) clear tra...
ko1 (Koichi Sasada)
07:45 AM Revision 2fc56c98 (git): Create empty revision.h when srcdir is write-only [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66090 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
07:07 AM Revision 1a6ae0a9 (git): Always try to update revision.h with GNU make
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66089 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
06:51 AM Revision 16d6a91a (git): Revert "using_spec.rb: skip broken test for MinGW for now"
This reverts commit 110273c53461a9a7ecdcca705346be21f25f50c6.
Try this with r66087
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66088 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
k0kubun (Takashi Kokubun)
06:37 AM Bug #15348 (Closed): r66003 Support targetting TracePoint - MinGW
Applied in changeset trunk|r66087.
----------
use __builtin_setjmp on mingw64 [Bug #15348].
ko1 (Koichi Sasada)
06:37 AM Revision 66e9bfd4 (git): use __builtin_setjmp on mingw64 [Bug #15348].
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66087 b2dd03c8-39d4-4d8f-98ff-823fe69b080e ko1 (Koichi Sasada)
06:19 AM Bug #13438: Fix heap overflow due to configure.in not being updated for HEAP_* -> HEAP_PAGE_* variable renaming
Oops, stunned that nobody noticed this issue for over a yer.
Had just pushed the patch. Sorry for the delay!
shyouhei (Shyouhei Urabe)
06:16 AM Bug #13438 (Closed): Fix heap overflow due to configure.in not being updated for HEAP_* -> HEAP_PAGE_* variable renaming
Applied in changeset trunk|r66086.
----------
Remove HEAP_ALIGN_LOG setting in configure.ac for OpenBSD/MirOS
The ruby setting was renamed to HEAP_PAGE_ALIGN_LOG, but the
configure.in (now configure.ac) file was not updated, so the
set...
shyouhei (Shyouhei Urabe)
04:40 AM Bug #13438: Fix heap overflow due to configure.in not being updated for HEAP_* -> HEAP_PAGE_* variable renaming
jeremyevans0 (Jeremy Evans) wrote:
> shyouhei (Shyouhei Urabe) wrote:
> ...
This was approved back in September 2017, but it didn't make the 2.5 release. I would like it to make the 2.6 release. The latest patch still applies (with o...
jeremyevans0 (Jeremy Evans)
06:16 AM Revision 0b899a25 (git): Remove HEAP_ALIGN_LOG setting in configure.ac for OpenBSD/MirOS
The ruby setting was renamed to HEAP_PAGE_ALIGN_LOG, but the
configure.in (now configure.ac) file was not updated, so the
setting had no effect. The configure setting is unnecessary
after OpenBSD 5.2 and MirOS has been discontinued (wit...
shyouhei (Shyouhei Urabe)
05:26 AM Revision 493955c6 (git): .travis.yml: cache unicode.org files
Before this changeset (since r58071) we did not download files
from unicode.org but just touch some files. This is a kind of
hack that people normally don't do at home.
We are caching other files between builds now. Why not also save
...
shyouhei (Shyouhei Urabe)
05:25 AM Bug #15333: make check fails looking for Bundler 2.0
@hsbt
By no means have I looked at how Bundler is used by RG testing, but in trunk, the following line in test_case.rb works in rubygems/rubygems, but not trunk:
```ruby
# If bundler gemspec exists, add to stubs
bundler_gemspec =...
MSP-Greg (Greg L)
12:27 AM Bug #15333: make check fails looking for Bundler 2.0
I will build a clean box and try again. Thank you. leam (Leam Hall)
04:12 AM Bug #15343: String#each_grapheme_cluster wrongly splits some emoji (genie, zombie, wrestling)
Some data points from a discussion between @naruse and myself:
- Up to elf (U+1F9DD) is Emoji_Modifier_Base, but genie (U+1F9DE) isn't.
- Emoji_Modifier only includes skin tones (U+1F3FB-1F3FF, light skin tone..dark skin tone)
-...
duerst (Martin Dürst)
02:47 AM Revision 2be1cf45 (git): .travis.yml: fix YAML parse error
`[` is a meta character in YAML. `- [` starts an array,
so it should end with `]`; but it was not.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66084 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
shyouhei (Shyouhei Urabe)
01:56 AM Feature #15349: Use a shared array for the `duparray` instruction
normalperson (Eric Wong) wrote:
> tenderlove@ruby-lang.org wrote:
> ...
Ok, I'll apply the patch.
> > Does anyone have opinions on this? If not, I'll just apply the patch.
> ...
I tried disabling theap and re-running the test. I...
tenderlovemaking (Aaron Patterson)
01:09 AM Revision 58d74446 (git): * 2018-11-29
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66083 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
01:09 AM Revision 8ea6c92e (git): time.rb: Move documents and stop others
* lib/time.rb: Move method documents to each methods. And stop
documentation of the abstract and others, which were confusingly
placed at the top of generated documents prior to the abstract
in time.c.
git-svn-id: svn+ssh://ci.ru...
nobu (Nobuyoshi Nakada)
12:42 AM Feature #15353: Support client certificates with TLS 1.3 and OpenSSL 1.1.1
Hello, openssl library now has its own tracker. Is it possible to report this issue at ruby/openssl? https://github.com/ruby/openssl/issues shyouhei (Shyouhei Urabe)
12:26 AM Feature #10771: An easy way to get the source location of a constant
I am glad that this issue is going to be discussed in the next developer meeting, but now that we have a way to know not only the file name and the line number but also the column number/position as well for method definitions, I request... sawa (Tsuyoshi Sawada)
12:22 AM Misc #15347: Require C99
edchick@gmail.com wrote:
> This is sad we loss another contributor with deep low level knowledge. I read in another thread you won't be hacking in Ruby again, why is that?

There's thousands of potential contributors more knowledgea...
normalperson (Eric Wong)

11/28/2018

10:54 PM Bug #15333 (Feedback): make check fails looking for Bundler 2.0
I couldn't reproduce it. hsbt (Hiroshi SHIBATA)
05:13 PM Bug #15333: make check fails looking for Bundler 2.0
Related? https://bugs.ruby-lang.org/issues/15354 leam (Leam Hall)
10:53 PM Bug #15354 (Assigned): Remove Bundler from StdLib
hsbt (Hiroshi SHIBATA)
05:41 PM Bug #15354: Remove Bundler from StdLib
I personally do not use bundler, so I don't mind either way, but I use gems (and would love
to preserve gems how I used them in the last ... 10 years or so; e. g. only using .gemspec
rather than Gemfile).
I understand the discussion...
shevegen (Robert A. Heiler)
05:13 PM Bug #15354: Remove Bundler from StdLib
Related? https://bugs.ruby-lang.org/issues/15333 leam (Leam Hall)
05:11 PM Bug #15354 (Rejected): Remove Bundler from StdLib
[This is mostly a clone of #13978 which I opened a year ago. Unfortunately, the same points I mentioned there still hold true.]
I understand that given that almost every Ruby user is using Bundler, it would be convenient for quite som...
vo.x (Vit Ondruch)
09:36 PM Bug #15348: r66003 Support targetting TracePoint - MinGW
@ko1 Koichi,
I did another ruby-loco build, and it also passed. The 'test repo' I did is here:
https://ci.appveyor.com/project/MSP-Greg/ruby-loco-test/history
Currently it runs three versions of the failing specs. In the fir...
MSP-Greg (Greg L)
06:41 PM Bug #15348: r66003 Support targetting TracePoint - MinGW
@ko1 Koichi,
Thank you. Repeat that. ruby-loco is green.
Going back to last year, I've had intermittent (and sometimes only on appveyor) issues with callcc, the (sometimes considerable) block nesting in the spec suite, and this ...
MSP-Greg (Greg L)
05:22 PM Bug #15348: r66003 Support targetting TracePoint - MinGW
On my msys2 environment, it hits!

On my environemnt,

```
using
```

only this script hangs.


And I found these articles:

http://www.agardner.me/golang/windows/cgo/64-bit/setjmp/longjmp/2016/02/29/go-windows-setjmp-x86.h...
ko1 (Koichi Sasada)
08:54 PM Bug #15358 (Closed): Segfault in rb_transient_heap_mark when running Sequel's specs
When running Sequel's plugin specs, there is a segfault that is dependent on execution order. I have been seeing it on OpenBSD after upgrading from ruby-2.6.0-preview2 to ruby-2.6.0-preview3, and I was not sure if it was OpenBSD specifi... jeremyevans0 (Jeremy Evans)
08:07 PM Feature #13618: [PATCH] auto fiber schedule for rb_wait_for_single_fd and rb_waitpid
@k0kubun I like the general ideas presented here but the implementation is too heavy/specific for my use case. For example, it won't work on JRuby, TruffleRuby, or other implementations. That's the major benefit of using a gem for the re... ioquatix (Samuel Williams)
07:52 PM Feature #13618: [PATCH] auto fiber schedule for rb_wait_for_single_fd and rb_waitpid
> https://bugs.ruby-lang.org/issues/13618#change-75238

takashikkbn@gmail.com wrote:
> I'm interested in the "demo server" as a real-world use case
> of Thread::Light. Is the code available somewhere?

I haven't written it, yet. ...
normalperson (Eric Wong)
12:19 PM Feature #13618: [PATCH] auto fiber schedule for rb_wait_for_single_fd and rb_waitpid
> I plan on switching https://public-inbox.org/git/ (my busiest public website) to use a demo server with Thread::Light.
I'm interested in the "demo server" as a real-world use case of Thread::Light. Is the code available somewhere? A...
k0kubun (Takashi Kokubun)
11:12 AM Feature #13618: [PATCH] auto fiber schedule for rb_wait_for_single_fd and rb_waitpid
Changes in this iteration:

* reduced stack usage in the select()-based implementation
(also made some io.c changes today in trunk to cut stack)

* refined auto-switching disable for critical sections

I plan on switching https:/...
normalperson (Eric Wong)
10:52 AM Feature #13618: [PATCH] auto fiber schedule for rb_wait_for_single_fd and rb_waitpid
matz@ruby-lang.org wrote:
> The first proposal of auto fiber was fibers with implicit context switch on I/O operations. They are fundamentally not fibers, but threads (without time slice context switching). Since they switch context le...
normalperson (Eric Wong)
10:22 AM Feature #13618: [PATCH] auto fiber schedule for rb_wait_for_single_fd and rb_waitpid
The first proposal of auto fiber was fibers with implicit context switch on I/O operations. They are fundamentally not fibers, but threads (without time slice context switching). Since they switch context less often, they are less danger... matz (Yukihiro Matsumoto)
08:01 PM Feature #15357 (Closed): Proc#parameters returns incomplete type information
The current implementation of Proc#parameters [differentiate between lambda? true and false](https://github.com/ruby/ruby/blob/49cd16bfaf4f03885058ce748119bc8ea2de735a/iseq.c#L2800).
This is presumably due to the fact, that [procs use t...
larskanis (Lars Kanis)
07:23 PM Bug #15356 (Closed): Rack::Deflater on Rails responds with no data on Ruby 2.6.0
I'd like to report that a Rails app with `Rack::Deflater` enabled responds with a zero-length body on Ruby 2.6.0, to a request with `Accept-encoding: gzip` request header. It seems to happen at least on `x86_64-linux` (Ubuntu 18.04.1; se... zunda (zunda an)
06:10 PM Bug #15355 (Closed): Random segmentation faults in development environment
During development I am getting random crashes of the "rails s" command with the log below.
The crash happens as I browse the front-end of the application I am developing - and independent of the page.
all crash sump also attached
/...
1ucian (Lucian Lacusta)
05:54 PM Feature #9758: Allow setting SSLContext#extra_chain_cert in Net::HTTP
any feedback on this? stan3 (Tristan Hill)
03:54 PM Feature #15353 (Closed): Support client certificates with TLS 1.3 and OpenSSL 1.1.1
A TLS 1.3 server can request a client certificate after the handshake. Clients tell the server during the handshake whether they support this feature.
In OpenSSL 1.1.1, this feature is enabled with the functions SSL_CTX_set_post_hands...
mkauf (Michael Kaufmann)
02:56 PM Revision 5a9066f2 (git): Executable scripts have been moved to libexec [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66081 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
02:08 PM Revision 4471d4a3 (git): time.c: rescue find_timezone when loading
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66080 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
02:08 PM Revision 2d0833e1 (git): Try with TZInfo and Timezone gems
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66079 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
02:08 PM Revision ab73b305 (git): Time.at in: tz
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66078 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
02:08 PM Revision bdfc701b (git): Timezone at Time.at
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66077 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
02:08 PM Revision 337b4b63 (git): Try Time.find_timezone to convert name to timezone
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66076 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
02:08 PM Revision fe08f99e (git): Try Time.find_timezone to load
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66075 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
01:55 PM Bug #15105: `rb_debug_inspector_open` breaks lazy proc optimization
ruby_2_5 r66074 merged revision(s) 64799,64800,64801. nagachika (Tomoyuki Chikanaga)
01:55 PM Revision e84f8076 (git): merge revision(s) 64799,64800,64801: [Backport #15105]
fix typo.
* vm_exec.h (DEBUG_END_INSN()): use `ec` instead of `th`.
This macro is used when `VMDEBUG > 0`.
escape all env properly.
* vm_backtrace.c (rb_debug_inspector_open): escape all env using
...
nagachika (Tomoyuki Chikanaga)
01:36 PM Bug #15337: String#each_grapheme_cluster wrongly splits "\r\n"
ruby_2_5 r66073 merged revision(s) 65954,65955,65958. nagachika (Tomoyuki Chikanaga)
01:36 PM Revision 29eae8b1 (git): merge revision(s) 65954,65955,65958: [Backport #15337]
Don't use single byte optimization on grapheme clusters
Unicode Text Segmentation considers CRLF as a character. [Bug #15337]
add tests using Unicode test data for grapheme clusters
Add file test/ruby/enc/test_...
nagachika (Tomoyuki Chikanaga)
01:13 PM Feature #10771: An easy way to get the source location of a constant
janfri suggested this issue for the next upcoming developer meeting
at December 2018 so I think it will be approved or rejected then.
I did not yet comment on it so I will comment on it briefly.
- I think the functionality would b...
shevegen (Robert A. Heiler)
12:56 PM Misc #15007: Let all Init_xxx and extension APIs frequently called from init code paths be considered cold
methodmissing (Lourens Naudé) wrote:
> ko1 (Koichi Sasada) wrote:
> ...
I'm having a hard time getting MSVC to pass for `rb_memerror` https://ci.appveyor.com/project/ruby/ruby/builds/20571215/job/wc9ha9eg36xjiv70 with error `c:\project...
methodmissing (Lourens Naudé)
12:36 PM Bug #14200: addr2line.c compile error with C89 compilers on Solaris 10
> オプションでC99準拠を指定したり、それ相当の _XOPEN_SOURCE を定義すると、
> ...
@ngoto [Misc #15347] というのを検討しておりまして、オプションでC99準拠を指定するか _XOPEN_SOURCE の指定を行なった場合に、Soraris 11や10、あるいは9以前に関してそれぞれについて具体的にどのような懸念や副作用があるかをお聞きしたいと思っております。お時間のある時にお返事いただけないでしょうか。
k0kubun (Takashi Kokubun)
12:19 PM Feature #15352: Mandatory block parameters
I don't find this feature useful. If you wanted to raise an error when no block is given, all you have to do is call `yield` within the method body, which will not be an extra code if you are going to use the block somewhere in the metho... sawa (Tsuyoshi Sawada)
11:05 AM Feature #15352: Mandatory block parameters
This is an interesting suggestion in the sense that block parameters,
or rather, blocks as a whole, are a bit like additional arguments to
every method in ruby, at all times, optional; but they are also quite
special entities in ruby....
shevegen (Robert A. Heiler)
01:29 AM Feature #15352 (Open): Mandatory block parameters
There are too many block parameter assertions (it's kind of idioms: [`raise NoBlockGiven unless glock_given?`](https://github.com/search?q=raise+NoBlockGiven+unless+block_given&type=Code)).
It's very useful if there's a syntax to decl...
gfx (Goro FUJI)
10:52 AM Misc #15342: DevelopersMeeting20181212Japan
* [Feature #10771] An easy way to get the source location of a constant janfri (Jan Friedrich)
10:51 AM Feature #11541: Let attr_accessor, _reader & _writer return symbols of the defined methods
I don't have a big pro or con opinion (am neutral here), but perhaps we could move this
to an upcoming developer meeting anyway?
shevegen (Robert A. Heiler)
07:07 AM Revision c80aeb52 (git): remove two unnecessary variables (np2 and np3)
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66072 b2dd03c8-39d4-4d8f-98ff-823fe69b080e duerst (Martin Dürst)
06:43 AM Revision d3b7a10d (git): eliminate intermediate variable in very short block (3 times)
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66071 b2dd03c8-39d4-4d8f-98ff-823fe69b080e duerst (Martin Dürst)
06:21 AM Revision 33c7fa65 (git): use create_sequence_node() four more times
Four more use of create_sequence_node() in node_extended_grapheme_cluster
(a few more to come).
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66070 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
duerst (Martin Dürst)
06:12 AM Revision 2d67a3f4 (git): Get rid of block-less Proc.new
* lib/optparse.rb (OptionParser::Switch#initialize): get rid of
`Proc.new` without a block, which may be deprecated in the future.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66069 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
06:12 AM Revision b7fccecf (git): Remove useless backslash
* lib/optparse.rb (OptionParser::Switch#compsys): remove useless
backslash which just confuse ruby-mode.el.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66068 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
05:22 AM Feature #10548: remove callcc (Callcc is now going obsoleted. Please use Fiber.)
tarui@prx.jp wrote:
> Feature #10548: Callcc is now going obsoleted. Please use Fiber.
> https://bugs.ruby-lang.org/issues/10548

How about adding --disable-callcc configure option?

https://80x24.org/spew/20181128051213.19518-1-...
normalperson (Eric Wong)
05:04 AM Feature #15350: [PATCH] thread_sync.c (queue_sleep): remove deadlock checking
> That's a fair point. However, considering you can work around
> the current deadlock detection with
> `Thread.new{loop{sleep(1000000)}}` before calling `Queue#pop`,
> the deadlock detection doesn't really cause major problems if
...
normalperson (Eric Wong)
03:30 AM Feature #15350: [PATCH] thread_sync.c (queue_sleep): remove deadlock checking
normalperson (Eric Wong) wrote:
> merch-redmine@jeremyevans.net wrote:
> ...
I use Queue pretty extensively when testing to ensure deterministic behavior in multithreaded code, and I can say it would be a lot more difficult to write su...
jeremyevans0 (Jeremy Evans)
03:04 AM Feature #15350: [PATCH] thread_sync.c (queue_sleep): remove deadlock checking
merch-redmine@jeremyevans.net wrote:
> I expect this would make it more difficult to debug
> multithreaded use of Queue, since ruby would hang instead of
> raising a fatal exception as it does currently (assuming I
> understand the ...
normalperson (Eric Wong)
12:17 AM Feature #15350: [PATCH] thread_sync.c (queue_sleep): remove deadlock checking
I expect this would make it more difficult to debug multithreaded use of Queue, since ruby would hang instead of raising a fatal exception as it does currently (assuming I understand the patch correctly). As multithreaded use of Queue i... jeremyevans0 (Jeremy Evans)
04:31 AM Revision e9dbafa5 (git): test_settracefunc (test_tracepoint_enable_with_target_line): less fragile
Allow us to make other changes to the file and move the method
around without affecting this test.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66067 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Eric Wong
03:10 AM Revision 79dd244c (git): Regenerated binstubs of bundler, rdoc and irb.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66066 b2dd03c8-39d4-4d8f-98ff-823fe69b080e hsbt (Hiroshi SHIBATA)
03:08 AM Revision 5dbc6583 (git): Merge rubygems upstream from https://github.com/rubygems/rubygems/commit/2c499655f29070c809dfea9f5fda6fac6850e62e
https://github.com/rubygems/rubygems/pull/2493
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66065 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
hsbt (Hiroshi SHIBATA)
02:38 AM Revision b52761e4 (git): Merge stringio.gemspec from github repository.
Temporary ignored configuration of certificate sign.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66064 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
hsbt (Hiroshi SHIBATA)
01:58 AM Revision b4e39021 (git): use create_sequence_node() once more
One more use of create_sequence_node() in node_extended_grapheme_cluster
(several more to come).
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66063 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
duerst (Martin Dürst)
01:56 AM Feature #15289 (Assigned): Accept "target" keyword on `TracePoint#enable`
I reopen this ticket as a reminder to fix MinGW test failure by this. Please close this ticket once AppVeyor becomes green with r66062 reverted. k0kubun (Takashi Kokubun)
01:53 AM Revision 110273c5 (git): using_spec.rb: skip broken test for MinGW for now
ko1 is fixing this and he suggested to skip it for now
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66062 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
k0kubun (Takashi Kokubun)
01:51 AM Bug #14998 (Closed): Race conditions in MonitorMixin when interrupted
Applied in changeset trunk|r66061.
----------
lib/monitor.rb: avoid race conditions by Thread.handle_interrupt
Suggested by Benoit Daloze. [ruby-core:88502] [Bug #14998]
shugo (Shugo Maeda)
01:51 AM Revision 6ec1720a (git): lib/monitor.rb: avoid race conditions by Thread.handle_interrupt
Suggested by Benoit Daloze. [ruby-core:88502] [Bug #14998]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66061 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
shugo (Shugo Maeda)
01:10 AM Revision db7338fd (git): io.c (rb_update_max_fd): use F_GETFL if possible
On 64-bit Linux, fstat() needs to fill out a 144 byte struct
while F_GETFL only needs to return 8 bytes.
Fwiw, F_GETFD requires an additional rcu_read_lock and bitmap
check; so it's obviously more expensive than F_GETFL on Linux.
Reduc...
Eric Wong
01:04 AM Revision c5fe904f (git): Fix for coroutine/win32/Context.obj
* coroutine/win32/Context.asm: old ml version 9 needs CPU
directive before `.model` directive.
* win32/Makefile.sub: specify object directories to separate Win32
and Win64 targets. Win32 rule was overridden by Win64 rule and
just...
nobu (Nobuyoshi Nakada)
01:04 AM Revision db67f542 (git): win32/Makefile.sub: add flags for AS
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66058 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
12:53 AM Revision 97a8334c (git): introduce macro R_ERR to reduce repetitive code
Introduce a new preprocessor macro R_ERR to visually reduce repetitive code
checking for return values and going to the err: label at the end of the
function node_extended_grapheme_cluster().
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/...
duerst (Martin Dürst)
12:49 AM Revision 7cb09658 (git): .travis.yaml: unquote
It was probably me, 7 years ago, in r33844, who started overly
quoting YAML strings. But now, this file grown up 50+ times from
6 lines to more than 300. It is more annoying than convenient to
quote everything to add backslashes here a...
shyouhei (Shyouhei Urabe)
12:48 AM Revision 14f47dea (git): Removed redundant empty line.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66055 b2dd03c8-39d4-4d8f-98ff-823fe69b080e hsbt (Hiroshi SHIBATA)
12:35 AM Revision b75a4591 (git): * expand tabs.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66054 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
12:35 AM Revision e432c526 (git): io.c: reduce IO.copy_stream stack usage on Linux
nogvl_copy_file_range and nogvl_copy_stream_sendfile each
used 344 bytes of stack before this change. Now, they are
inlined into nogvl_copy_stream_func which only uses 200 bytes
of stack.
"struct stat" is 144 bytes on my 64-bit Linux.
...
Eric Wong
12:28 AM Revision 42cb4fed (git): reduce number of arguments on quantify_property_node()
There are only four patterns of the last two arguments to quantify_property_node().
By replacing the lower/upper arguments with a single char, we get more expressive
calls, the last argument directly corresponding to the quantifier that ...
duerst (Martin Dürst)

11/27/2018

11:57 PM Revision eaf9bc00 (git): Add Float::INFINITY or nil to call-seq of Enumerator::Chain#size [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66051 b2dd03c8-39d4-4d8f-98ff-823fe69b080e znz (Kazuhiro NISHIYAMA)
11:32 PM Feature #15349: Use a shared array for the `duparray` instruction
tenderlove@ruby-lang.org wrote:
> I was going to apply this patch, but it modifies `rb_ary_resurrect` and I wanted to double check. `rb_str_resurrect` will create shared strings, so it seems OK for `rb_ary_resurrect` to create shared...
normalperson (Eric Wong)
10:10 PM Feature #15349 (Closed): Use a shared array for the `duparray` instruction
In this example code:
~~~ ruby
def foo
[1, 2, 3, 4]
end
~~~
The array literal uses a duparray instruction. Before this patch,
rb_ary_resurrect would malloc and memcpy a new array buffer. This
patch changes rb_ary_resurrect ...
tenderlovemaking (Aaron Patterson)
10:52 PM Feature #15350 (Open): [PATCH] thread_sync.c (queue_sleep): remove deadlock checking
thread_sync.c (queue_sleep): remove deadlock checking
Queue may be used inside signal handlers nowadays, so deadlock
checking is unnecessary and prevents single-threaded use.
We don't have deadlock checking for reading pipes/socke...
normalperson (Eric Wong)
10:48 PM Revision 7b5c2d3f (git): enumerator.c (enum_chain_yield_block): use predefined ID
No point in having rb_intern lookup and cache a predefined ID
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66050 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Eric Wong
10:20 PM Revision a607c866 (git): io.c (struct copy_stream_struct): packing
Reduce the struct to 80 bytes (from 88) on amd64 to reduce
stack use.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66049 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Eric Wong
10:13 PM Bug #15346: Core dump during GC if covering a special require
Wow, very fast handling, thank you.
I confirm that this seems to have solved things on my end. Travis has not updated their ruby-head yet, but I assume it will be fine there too.
Thanks again
MaxLap (Maxime Lapointe)
08:00 AM Bug #15346: Core dump during GC if covering a special require
The commit was r66025. (I have no idea why the commit is not automatically related to this ticket.)
I investigated the reason why lineno is 0. In Ruby bytecode, each instruction has lineno information. However, the ensure clause ha...
mame (Yusuke Endoh)
07:40 AM Bug #15346 (Closed): Core dump during GC if covering a special require
mame (Yusuke Endoh)
07:40 AM Bug #15346: Core dump during GC if covering a special require
This report is awesome. Thank you very much!
The coverage counters are initialized with `counter[lineno - 1] = 0`. However, the lineno of ensure clause is 0 (for unknown reason). So it caused write access for index -1, which broke ...
mame (Yusuke Endoh)
05:46 AM Bug #15346 (Closed): Core dump during GC if covering a special require
On my environment, (ruby-head, updated today) the following script generates a core dump almost all the time. (I join a core dump to this report)
I am running on Ubuntu 16.04, I first saw the problem on Travis-CI and managed to make t...
MaxLap (Maxime Lapointe)
09:50 PM Revision 7c4a422d (git): fix order of subexpressions for Hangul
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66048 b2dd03c8-39d4-4d8f-98ff-823fe69b080e duerst (Martin Dürst)
09:38 PM Revision 793c48b4 (git): * remove trailing spaces.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66047 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
09:38 PM Revision 06bd42a7 (git): introduce two more uses of create_sequence_node in node_extended_grapheme_cluster
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66046 b2dd03c8-39d4-4d8f-98ff-823fe69b080e duerst (Martin Dürst)
09:32 PM Misc #15347: Require C99
> We've spent a lot of time for supporting C90 https://github.com/ruby/ruby/search?o=desc&q=c99&s=committer-date&type=Commits.
> It is not only time-consuming but also sometimes sacrifices readability like r66034 (today's commit).

A...
normalperson (Eric Wong)
09:16 PM Misc #15347: Require C99
k0kubun (Takashi Kokubun) wrote:
> We've spent a lot of time for supporting C90 https://github.com/ruby/ruby/search?o=desc&q=c99&s=committer-date&type=Commits.
> ...
First, thanks for r66034. In this case, it ultimately led to better c...
duerst (Martin Dürst)
06:35 PM Misc #15347: Require C99
Personally I am not affected either way, so this is for the ruby developers; and those
users who may be affected by the change away from C90 support (which does not include me).
I think it would be nice to drop C90 support, if we say...
shevegen (Robert A. Heiler)
05:39 PM Misc #15347: Require C99
I would like to add that for Clang, -Werror=declaration-after-statement is ignored in c99 mode due to a bug: https://bugs.llvm.org/show_bug.cgi?id=27493.
Because of this, it's easy to author code that isn't C90 compatible when using Cla...
alanwu (Alan Wu)
04:15 PM Misc #15347: Require C99
For VC++, I heard from @usa (mswin platform maintainer) that he assumes Microsoft does not declare EOL of old VC++s, so he sometimes drops support of old versions as he thinks okay, and he is thinking about requiring vc12 from Ruby 2.7.
...
k0kubun (Takashi Kokubun)
03:53 PM Misc #15347 (Closed): Require C99
## Problem
We've spent a lot of time for supporting C90 https://github.com/ruby/ruby/search?o=desc&q=c99&s=committer-date&type=Commits.
It is not only time-consuming but also sometimes sacrifices readability like r66034 (today's commit...
k0kubun (Takashi Kokubun)
09:23 PM Revision 99d451f5 (git): correctly handle return value from create_sequence_node()
In function node_extended_grapheme_cluster(), store and test
return value from create_sequence_node(). Never forget this!
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66045 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
duerst (Martin Dürst)
09:12 PM Revision 87cda89c (git): * remove trailing spaces.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66044 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
09:12 PM Revision 81868891 (git): declare array for sequence at start of code creating sequence
In function node_extended_grapheme_cluster(),
move declaration up so that block encompasses all of the regular expression
creation that finally makes up the sequence. Having blocks like this will
be great because it directly shows the ex...
duerst (Martin Dürst)
09:00 PM Revision 7086aae3 (git): make sure all nodes are correctly freed in create_property_node()
We make sure that the newly created tree and all remaining nodes passed in
in the node_array are freed.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66042 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
duerst (Martin Dürst)
08:38 PM Revision 50441014 (git): Update to ruby/spec@cdd6ff7
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66041 b2dd03c8-39d4-4d8f-98ff-823fe69b080e Eregon (Benoit Daloze)
08:38 PM Revision 49cd16bf (git): * 2018-11-28
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66040 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
08:38 PM Revision eae7fbb6 (git): Update to ruby/mspec@820486a
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66039 b2dd03c8-39d4-4d8f-98ff-823fe69b080e Eregon (Benoit Daloze)
07:42 PM Bug #15348 (Closed): r66003 Support targetting TracePoint - MinGW
This has caused failures in spec/ruby/core/main/using_spec.rb, specifically the first spec.
On Appveyor, trying several versions of both specs, the first one (`eval('using', TOPLEVEL_BINDING)`) fails, the second one (`eval('using "foo...
MSP-Greg (Greg L)
07:11 PM Bug #15314: Bundler with 2.6 fails when installing dependencies into a --path with --binstubs
I confirm this issue is no longer a problem for Heroku. Thanks for your work!
I did hit a segfault though with bootsnap https://gist.github.com/schneems/95ad82f39c8c7f24fe228d3bfda2937e. It looks unrelated, I'll try to reproduce local...
schneems (Richard Schneeman)
01:47 PM Revision 04711158 (git): ruby-style.el: ruby-style-c-mode by VCS [ci skip]
* misc/ruby-style.el (ruby-style-c-mode): set ruby-style if the
remote repository is ruby.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66038 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
12:08 PM Revision 5bc8bb36 (git): * properties.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66037 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
12:08 PM Revision fc9509bd (git): Merge bundler-2.0.0.pre.2 from upstream.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66036 b2dd03c8-39d4-4d8f-98ff-823fe69b080e hsbt (Hiroshi SHIBATA)
12:00 PM Revision 86cb3d31 (git): mjit_worker.c: promote mjit_copy_job from function
-local variable to global variable.
Consider this case:
1. MJIT worker: dequeue ISeq (stop_worker_p was still FALSE)
2. Ruby thread: call Kernel#exec, which calls mjit_finish(FALSE),
sets `stop_worker_p = TRUE`, and fire...
k0kubun (Takashi Kokubun)
11:24 AM Revision c3fe3078 (git): regparse.c: conform C90
../regparse.c:5908:28: error: initializer for aggregate is not a compile-time constant [-Werror,-Wc99-extensions]
Node* sequence[] = { np1, np2, np3, ((Node* )0) };
^~~
https://travis-ci.org/ruby/ruby/jo...
k0kubun (Takashi Kokubun)
11:04 AM Revision 9e2455b7 (git): introduce helper function create_sequence_node()
The new function create_sequence_node() uses its second argument
(an array of Node*, from left to right, ending with NULL_NODE)
to create a sequence of expressions using node_new_list().
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk...
duerst (Martin Dürst)
10:15 AM Revision 231930ca (git): * remove trailing spaces.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66032 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
10:15 AM Revision 8f9c00d2 (git): introduce helper function quantify_property_node()
The new function quantify_property_node() combines the functions
create_property_node() and quantify_node(), which frequently appear together.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66031 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
duerst (Martin Dürst)
09:44 AM Revision 69443998 (git): introduce helper function quantify_node() to wrap function node_new_quantifier
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66030 b2dd03c8-39d4-4d8f-98ff-823fe69b080e duerst (Martin Dürst)
08:53 AM Feature #5313 (Closed): Please drop IRB's version in favour of Ruby version
I hope the situation should be better since r63915 which makes IRB default gem. Now if only the version was properly increased ... vo.x (Vit Ondruch)
08:39 AM Revision 186ff0eb (git): .travis.yml: avoid bashism
GCC_FLAGS is not an array and CC is finally passed to configure as
single string. Pass CC via the environment variable, so it does
not need to be quoted anymore.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66029 b2dd03c8-39d4-4d8...
nobu (Nobuyoshi Nakada)
08:39 AM Revision b6854df4 (git): .travis.yml: discard config.cache if CC changed
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66028 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
08:39 AM Revision b6f73c90 (git): .travis.yml: split commands
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66027 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
07:34 AM Revision a1c4e0c9 (git): * expand tabs.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66026 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
07:34 AM Revision b7561daf (git): compile.c: prevent out-of-bound initialization of coverage counters
The coverage counters is initialized with `counter[lineno - 1] = 0`,
but lineno may be 0, which led to write access for index -1.
[ruby-core:90085] [Bug#15346]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66025 b2dd03c8-39d4-4d8f-9...
mame (Yusuke Endoh)
07:02 AM Revision 4beec667 (git): Merge rdoc-6.1.0.bata2
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66024 b2dd03c8-39d4-4d8f-98ff-823fe69b080e aycabta (aycabta .)
06:44 AM Revision 7aaf5b28 (git): Embed the Emoji version
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66023 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
05:42 AM Revision b02f3731 (git): restore using_spec.rb
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66022 b2dd03c8-39d4-4d8f-98ff-823fe69b080e ko1 (Koichi Sasada)
04:13 AM Revision aa449359 (git): use explicit property name when creating nodes for "Grapheme_Cluster_Break=Extend"
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66021 b2dd03c8-39d4-4d8f-98ff-823fe69b080e duerst (Martin Dürst)
04:10 AM Feature #15344: Being proactive about Ruby security
@shyouhei Thanks for updating this issue correctly.
Thanks for providing some background on `$SAFE`.
I think the goal should be ensuring Ruby has the tools and processes in place to minimise issues like the ones facing NodeJS. Whet...
ioquatix (Samuel Williams)
04:06 AM Feature #15344: Being proactive about Ruby security
From @mame: http://ruby.11.x6.nabble.com/ruby-core-26388-suggestion-gems-ruby-lang-org-tt3595295.html ioquatix (Samuel Williams)
03:06 AM Feature #15344: Being proactive about Ruby security
At first glance this topic is a bit vague. I like how `unveil(2)` works, but honestly I have no idea if adopting that way prevents dominictarr/event-stream issue.
So at the starting point: may I ask your goal of this thread? Do you ...
shyouhei (Shyouhei Urabe)
01:10 AM Feature #15344 (Feedback): Being proactive about Ruby security
I would like to start a discussion relating to https://github.com/rubygems/rubygems/issues/2496
I don't know what has been done here already. I know from a computability POV, it's impossible to solve this problem.
That being said, ...
ioquatix (Samuel Williams)
03:56 AM Revision b62e466f (git): use 'Regional_Indicator' script property instead of fixed constants
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66020 b2dd03c8-39d4-4d8f-98ff-823fe69b080e duerst (Martin Dürst)
03:19 AM Revision b549d14c (git): Add rb_typeddata_is_instance_of
Similar to rb_typeddata_is_kind_of, except for that inherited type
is not an instance.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66019 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
03:12 AM Revision a9ace575 (git): enable another assertion
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66018 b2dd03c8-39d4-4d8f-98ff-823fe69b080e ko1 (Koichi Sasada)
03:02 AM Revision 2b44228d (git): fix for ISeq.of(method).
* iseq.c (iseqw_s_of): `rb_method_iseq(method)` can return NULL.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66017 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
ko1 (Koichi Sasada)
02:45 AM Revision 467c2982 (git): * expand tabs.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66016 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
02:45 AM Revision 33dc8a5c (git): `RubyVM::ISeq.of` accept ISeq.
* iseq.c (iseqw_s_of): return given object if the given object is
a `RubyVM::InstructionSequence`. We can specify ISeq for
`TracePoint#enable(target:)`.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66015 b2dd03c8-39d4-4d8f-98f...
ko1 (Koichi Sasada)
02:18 AM Revision 2e075759 (git): add some comments in function node_extended_grapheme_cluster() [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66014 b2dd03c8-39d4-4d8f-98ff-823fe69b080e duerst (Martin Dürst)
01:25 AM Revision 7bbe9d41 (git): ALWAYS_INLINE implies inline always
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66013 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
12:44 AM Revision eea3fe0a (git): enable at least one behavior
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66012 b2dd03c8-39d4-4d8f-98ff-823fe69b080e ko1 (Koichi Sasada)
12:39 AM Revision b0ba0595 (git): to debug https://ci.appveyor.com/project/ruby/ruby/builds/20566898/job/hda29416yal9h6hn use binary search
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66011 b2dd03c8-39d4-4d8f-98ff-823fe69b080e ko1 (Koichi Sasada)

11/26/2018

11:30 PM Revision 51196cf5 (git): improve messages for test failures
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66010 b2dd03c8-39d4-4d8f-98ff-823fe69b080e duerst (Martin Dürst)
08:16 PM Revision 27b1553b (git): * remove trailing spaces.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66009 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
08:16 PM Revision 72e60a04 (git): `TracePoint#enable(target_line:)` is supported. [Feature #15289]
* vm_trace.c: `TracePoint#enable(target_line:)` is supported.
This option enables a hook only at specified target_line.
target_line should be combination with target and :line event.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trun...
ko1 (Koichi Sasada)
08:12 PM Bug #15343: String#each_grapheme_cluster wrongly splits some emoji (genie, zombie, wrestling)
This issue is epic due to its title alone! (I don't quite know whether
there are indeed genie and zombie emojis yet but it makes me curious.)
> except those relating to genies, zombies, and wrestling (THIS IS NOT
> ...
Awww .... :)
shevegen (Robert A. Heiler)
09:02 AM Bug #15343 (Closed): String#each_grapheme_cluster wrongly splits some emoji (genie, zombie, wrestling)
All the codepoint combinations that turn up in the various emoji files provided by Unicode (currently we use those at https://www.unicode.org/Public/emoji/5.0/) are recognized as grapheme clusters by `String#each_grapheme_cluster`, excep... duerst (Martin Dürst)
08:10 PM Feature #13581: Syntax sugar for method reference
> The map(&method(:local_method)) or yield_self(&method(:local_method)) pattern is absolutely real
> ...
Everyone who suggests something tends to think of it as useful and often pretty too. :-)
I personally have become too picky perh...
shevegen (Robert A. Heiler)
07:59 PM Revision 6e33c16f (git): Give up support for cross-callcc set_trace_func.
* cont.c (cont_restore_thread): cause error if trace-status is changed.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66007 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
ko1 (Koichi Sasada)
06:48 PM Revision d35bfdac (git): fix for ansi-pedantic compile option.
* iseq.c (iseq_add_local_tracepoint_i): extract aggregate initialization.
See https://travis-ci.org/ruby/ruby/jobs/459881277
* iseq.c (iseq_remove_local_tracepoint_i): ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66006 b...
ko1 (Koichi Sasada)
06:27 PM Revision f6fea2b2 (git): fix type error.
* iseq.c (iseq_iterate_children): should use cast to `int`.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66005 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
ko1 (Koichi Sasada)
06:16 PM Feature #15289 (Closed): Accept "target" keyword on `TracePoint#enable`
Applied in changeset trunk|r66003.
----------
Support targetting TracePoint [Feature #15289]
* vm_trace.c (rb_tracepoint_enable_for_target): support targetting
TracePoint. [Feature #15289]
Tragetting TracePoint is only enabled on ...
ko1 (Koichi Sasada)
06:16 PM Revision 61c8247d (git): * expand tabs.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66004 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
06:16 PM Revision 96990203 (git): Support targetting TracePoint [Feature #15289]
* vm_trace.c (rb_tracepoint_enable_for_target): support targetting
TracePoint. [Feature #15289]
Tragetting TracePoint is only enabled on specified method, proc
and so on, example: `tp.enable(target: code)`.
`code` should be con...
ko1 (Koichi Sasada)
04:32 PM Feature #15331: [PATCH] Faster hashing for short string literals
nobu (Nobuyoshi Nakada) wrote:
> About the macro `BUILTIN_SINGLE_BYTE_ENC_IDX_P`, its name is misleading as it is true for UTF-8.
I agree. I removed it.
> ...
Done.
I moved away from using +1 in the buffer size, since it could ...
alanwu (Alan Wu)
01:47 PM Feature #15331: [PATCH] Faster hashing for short string literals
alanwu (Alan Wu) wrote:
> I've taken multi-byte terminators into account and updated my implementation. I've also included a test that should warn us about hash clobbering.
Seems nice.
About the macro `BUILTIN_SINGLE_BYTE_ENC_IDX_...
nobu (Nobuyoshi Nakada)
04:39 AM Feature #15331: [PATCH] Faster hashing for short string literals
I've taken multi-byte terminators into account and updated my implementation. I've also included a test that should warn us about hash clobbering.
I also noticed that the benchmark that creates many unique fstrings is actually 5% slower...
alanwu (Alan Wu)
04:13 PM Revision 2c9259e6 (git): test_jit.rb: skip a test for Windows for now
https://ci.appveyor.com/project/ruby/ruby/builds/20558412
removing CloseHandle disallows us to remove the DLL.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66002 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
k0kubun (Takashi Kokubun)
03:47 PM Bug #15316 (Closed): rb_postponed_job_register not thread-safe
Applied in changeset trunk|r66001.
----------
vm_trace.c: MJIT-limited thread-safety for postponed_job
[Bug #15316]
k0kubun (Takashi Kokubun)
03:47 PM Revision 67485fee (git): vm_trace.c: MJIT-limited thread-safety for postponed_job
[Bug #15316]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66001 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
k0kubun (Takashi Kokubun)
03:12 PM Revision 01e2bf35 (git): * 2018-11-27
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66000 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
03:12 PM Revision 98a2b053 (git): process.c: avoid dlclose before exec
because JIT-ed code may still be on stack at this time, unlike
in ruby_cleanup().
This hopes to fix: (take 2)
http://ci.rvm.jp/results/trunk-mjit-wait@silicon-docker/1480207
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65999 b2dd0...
k0kubun (Takashi Kokubun)
03:12 PM Revision 5b125011 (git): Revert "process.c: try to workaroun SEGV by r65994"
This reverts commit 0e6aba22c6b876a36adc39cac5314ce6e626954c.
because it didn't help, at all.
http://ci.rvm.jp/results/trunk-mjit-wait@silicon-docker/1480207
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65998 b2dd03c8-39d4-4d8f-98...
k0kubun (Takashi Kokubun)
02:45 PM Revision 0e6aba22 (git): process.c: try to workaroun SEGV by r65994
http://ci.rvm.jp/results/trunk-mjit-wait@silicon-docker/1480173
It tries to print C backtrace but fails. And core file on the server
seems to be stopping on the irrelevant place due to its own signal
handler for the dump.
And I failed ...
k0kubun (Takashi Kokubun)
02:03 PM Revision c8c265f4 (git): * properties.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65996 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
02:02 PM Revision 79f3b6b5 (git): Do not load rubygems when disabled
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65995 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
01:39 PM Revision 08e1705e (git): process.c: finish MJIT prior to #exec
to prevent ruby from leaving MJIT-related files.
test_jit.rb: add a test to prevent that
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65994 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
k0kubun (Takashi Kokubun)
12:50 PM Revision a3bb9f10 (git): mjit_worker.c: disable running copy job
after MJIT worker stop.
r65928 didn't fix the SEGV. This commit hopes to fix
http://ci.rvm.jp/results/trunk-mjit-wait@silicon-docker/1478576
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65993 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
k0kubun (Takashi Kokubun)
12:36 PM Revision af6adb99 (git): lib/rubygems/indexer.rb: suppress random test-all error
by Bundler integration, like:
http://ci.rvm.jp/results/trunk-no-mjit@silicon-docker/1479769
This resurrects r65629 which was accidentally reverted by r65904.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65992 b2dd03c8-39d4-4d8f-98...
k0kubun (Takashi Kokubun)
12:23 PM Revision a2456daf (git): Sync the executables of rdoc from upstream repository.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65991 b2dd03c8-39d4-4d8f-98ff-823fe69b080e hsbt (Hiroshi SHIBATA)
12:11 PM Bug #15314 (Feedback): Bundler with 2.6 fails when installing dependencies into a --path with --binstubs
@schneems
I fixed this issue with https://github.com/ruby/ruby/commit/a94332819463589fe4537cc62beb41a0ee354cf3
Can you try the current trunk revision?
hsbt (Hiroshi SHIBATA)
11:38 AM Bug #15335: Ruby 2.6.0 is not properly fortified
Testing with r65990 on x86_64 and the test passed. I guess I should not try to build on other arches yet, right? vo.x (Vit Ondruch)
09:03 AM Revision 0409290e (git): add tests for grapheme clusters using Unicode Emoji test data
Add file test/ruby/enc/test_emoji_breaks.rb to test String#each_grapheme_cluster
test data provided by Unicode (at https://www.unicode.org/Public/emoji/#{EMOJI_VERSION}/).
Lines containing emoji for genies, zombies, and wrestling are ig...
duerst (Martin Dürst)
07:55 AM Revision ebff9dc1 (git): object.c: Deprecate Object#=~ and add NilClass#=~`
Object#=~ always returns nil. This behavior is not only unuseful but
also troublesome because it may hide a type error.
This change deprecates Object#=~. For compatibility, NilClass#=~ is
newly introduced. [Feature #15231]
git-svn-i...
mame (Yusuke Endoh)
07:13 AM Revision f7e94df0 (git): lib/rubygems: explicitly clarify the type for =~ matching
RubyGems is very indifferent for type.
This change is needed for removal of `Object#=~`. [Feature #15231]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65988 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
mame (Yusuke Endoh)
05:46 AM Revision 0edc36b9 (git): lib/rubygems/command.rb: remove meaningless code
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65987 b2dd03c8-39d4-4d8f-98ff-823fe69b080e mame (Yusuke Endoh)
05:46 AM Misc #15336: Duplicate builds on travis-ci?
I don't have answers for every questions but for the first one: we enable cron builds for Travis-CI, which run every day. This is a handy occasion to do lots of additional tests. Compare these two results:
- https://travis-ci.org/ru...
shyouhei (Shyouhei Urabe)
05:46 AM Revision e0dd7b4d (git): test/rdoc/test_rdoc_rdoc.rb: add dummy finish
RDoc::Options#@exclude is initialized as an empty array.
Then, #finish converts it to a regexp or nil and reassign it to @exclude.
Some methods of RDoc assumes that #finish has been already called.
So, this change forces to assign nil to...
mame (Yusuke Endoh)
05:45 AM Misc #15342: DevelopersMeeting20181212Japan
* [Feature #13581] Syntax sugar for method reference
aycabta (aycabta .)
05:05 AM Misc #15342 (Closed): DevelopersMeeting20181212Japan
Please comment your favorite ticket numbers you want to ask to discuss with your *SHORT* comment or summary.
(your summary/comment will help us because we don't need to read all of ticket comments)
*DO NOT* discuss then on this ticke...
mame (Yusuke Endoh)
05:32 AM Revision 03cde6c8 (git): lib/rdoc/markup/: Remove wrong call to `=~` against Array
`@res` is an Array, so `@res =~ /\n\z/` calls `Object#=~` which always
returns nil.
I guess it should be `@res.last =~ /\n\z/`, but the change causes test
failures.
This bug was found during work for removal of `Object#=~`.
[Feature #15...
mame (Yusuke Endoh)
05:29 AM Feature #15231 (Closed): Remove `Object#=~`
Applied in changeset trunk|r65984.
----------
lib/webrick: explicitly convert header values to a string
The values of @header are expected to be all strings;
WEBrick::HTTPResponse::[]=(key, val) explicitly converts the second
argument ...
mame (Yusuke Endoh)
05:29 AM Revision 7a635a7d (git): lib/webrick: explicitly convert header values to a string
The values of @header are expected to be all strings;
WEBrick::HTTPResponse::[]=(key, val) explicitly converts the second
argument to a string and assigns it to @header hash.
However, there were some points in WEBrick internal code that ...
mame (Yusuke Endoh)
05:03 AM Misc #15229 (Closed): DevelopersMeeting20181122Japan
mame (Yusuke Endoh)
04:53 AM Feature #15341 (Closed): Provide emoji version as RbConfig::CONFIG['UNICODE_EMOJI_VERSION']
The Emoji version is different from the Unicode version. Currently, the Unicode version is accessible from `RbConfig::CONFIG['UNICODE_VERSION']`, but it's not possible to get the Emoji version.
I need the Emoji version for testing, so...
duerst (Martin Dürst)
04:42 AM Feature #11689: Add methods allow us to get visibility from Method and UnboundMethod object.
I agree that `#visibility` is the best solution. When somebody mentioned this at the recent Ruby committers' meeting, I immediately thought "that's it". Benoit provides some more background.
There are arguments that this may be misund...
duerst (Martin Dürst)
03:47 AM Revision b1ad07bd (git): common.mk: simplify for ruby.imp
* common.mk (ruby.imp): extract the first word on the next lines
of MJIT_FUNC_EXPORTED, regardless the prefix. duplicate symbols
will be removed by `sort -u`.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65983 b2dd03c8-39d4-4d...
nobu (Nobuyoshi Nakada)
02:46 AM Revision bf5c84a4 (git): .travis.yml: avoid bashism
We can set environment variables to avoid before_script.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65982 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
shyouhei (Shyouhei Urabe)
02:31 AM Revision 9e2acbca (git): un.rb: add more options for httpd to help message [ci skip]
see r65965
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65981 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
znz (Kazuhiro NISHIYAMA)
02:21 AM Revision 213fbd81 (git): .travis.yml: update MSAN setups [ci skip]
Exclude OpenSSL because we don't plan to debug libssl,
also track origins of uninitialized bits.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65980 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
shyouhei (Shyouhei Urabe)
02:13 AM Bug #15333 (Assigned): make check fails looking for Bundler 2.0
hsbt (Hiroshi SHIBATA)
02:08 AM Bug #15339 (Assigned): CI - add checks for std-lib CLI ?
hsbt (Hiroshi SHIBATA)
01:54 AM Bug #15291 (Closed): ruby-2.6.0-preview3でbin/bundle_rubyがインストールされる
Applied in changeset trunk|r65979.
----------
Removed `bundle_ruby` command. Because It's no longer shipped from Bundler 1.0.2.
[Bug #15291][ruby-dev:50663]
hsbt (Hiroshi SHIBATA)
01:54 AM Revision aa2d27e4 (git): Removed `bundle_ruby` command. Because It's no longer shipped from Bundler 1.0.2.
[Bug #15291][ruby-dev:50663]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65979 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
hsbt (Hiroshi SHIBATA)
01:43 AM Feature #15000: Prevent to initialize MonitorMixin twice
znz (Kazuhiro NISHIYAMA) wrote:
> How about checking owner object?
Could you commit it if it passes tests?
shugo (Shugo Maeda)
01:43 AM Revision e5906952 (git): Use libexec for distination directory.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65978 b2dd03c8-39d4-4d8f-98ff-823fe69b080e hsbt (Hiroshi SHIBATA)
01:23 AM Revision f944f8cc (git): Followed up r65963. Use libexec directory with sync tool.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65977 b2dd03c8-39d4-4d8f-98ff-823fe69b080e hsbt (Hiroshi SHIBATA)

11/25/2018

11:16 PM Revision 0889346d (git): add several emoji data files to UNICODE_EMOJI_DOWNLOAD for download
In common.mk, add the files emoji-sequences.txt, emoji-test.txt,
emoji-variation-sequences.txt, and emoji-zwj-sequences.txt to
UNICODE_EMOJI_DOWNLOAD for download with `make update-unicode-property-files`.
These files will be used for au...
duerst (Martin Dürst)
08:04 PM Bug #15339: CI - add checks for std-lib CLI ?
Added 3 lines to rbinstall.rb, added bundle_ruby to Bundler's executables.
Both are minor fixups to r65963. Passes on Appveyor. Patch file updated. Nothing changed re Travis...
MSP-Greg (Greg L)
01:38 PM Bug #15339: CI - add checks for std-lib CLI ?
@junaruga
1) I believe I have seen discussions on whether `make install` should be included in CI or not.
2) The test suites can be run before `make install`.
3) I'm not a good choice for making changes re Makefile, especially f...
MSP-Greg (Greg L)
12:01 PM Bug #15339: CI - add checks for std-lib CLI ?
How about creating this check in make task "make test" or "make test-all"?
Anonymous
04:21 AM Bug #15339: CI - add checks for std-lib CLI ?
Sorry for not mentioning it, but GH PR is just for Appveyor. Not sure if code should be added to all Travis builds...
PR CI failed for all three builds on Appveyor. All errors similar to:
```
\usr\bin\bundle --version
C:/usr/bi...
MSP-Greg (Greg L)
03:56 AM Bug #15339 (Closed): CI - add checks for std-lib CLI ?
Currently, CI is largely ignorant of the install.
Adding checks for the std-lib items with binstubs/executables is simple and adds a minimal amount of time to the CI.
See [GitHub PR #2028](https://github.com/ruby/ruby/pull/2028).
MSP-Greg (Greg L)
04:23 PM Bug #15340 (Closed): Time.local behaving inconsistently for excess days after 2038
Applied in changeset trunk|r65974.
----------
Normalize month-mday before finding epoch
Especially over the year 2038, 30 Feb and so on may cause odd behavior
on validating found epoch with given year-month-day [Bug #15340]
naruse (Yui NARUSE)
04:14 PM Bug #15340: Time.local behaving inconsistently for excess days after 2038
> I thought I observed a case 2038-02-30 is recognized as 2038-03-01 when ENV['TZ']=nil, but just now I couldn't reproduce the case. It might be my mistake in operations, but let me leave the log just in case. (It might be because I was ... naruse (Yui NARUSE)
02:53 PM Bug #15340 (Closed): Time.local behaving inconsistently for excess days after 2038
Time.local accepts a day of month that exceeds the largest day of the month, for example, 2018-02-31. The behavior looks inconsistent before v.s. after 2038. Are they expected behavior?
The behavior looks somewhat reasonable before 20...
dmikurube (Dai MIKURUBE)
04:23 PM Revision b1a40c10 (git): * 2018-11-26
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65975 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
04:23 PM Revision 2c652768 (git): Normalize month-mday before finding epoch
Especially over the year 2038, 30 Feb and so on may cause odd behavior
on validating found epoch with given year-month-day [Bug #15340]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65974 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
naruse (Yui NARUSE)
12:31 PM Revision dd782579 (git): Fix locations of NODE_UNDEF in undef with multiple args
* parse.y: Fix the beginning position of trailing NODE_UNDEF.
e.g. The location of the NODE_UNDEF for `b` is fixed:
```
undef a, b
```
* Before
```
NODE_UNDEF (line: 1, location: (1,6)-(1,10))
```
* After
```
...
yui-knk (Kaneko Yuichiro)
11:02 AM Revision 9a4d1207 (git): create function create_property_node to extract recurring functionality
Refactoring: In regparse.c, extract creation of a new CClass node and
initialization using a property into a new function create_property_node().
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65972 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
duerst (Martin Dürst)
10:12 AM Revision fc6243a6 (git): deal with ONIGENC_CASE_IS_TITLECASE flag on lowercase characters
In the function onigenc_unicode_case_map() in enc/unicode.c, deal
with the case that the ONIGENC_CASE_IS_TITLECASE flag is set on
lowercase characters. This is in preparation for Georgian Mtavruli,
which are uppercase but not titlecase, ...
duerst (Martin Dürst)
09:32 AM Feature #15338: Provide way for C extensions to query if global variable is defined
As for the implementation, this `rb_gv_defined` will add new ID just by asking if the gv is defined. nobu (Nobuyoshi Nakada)
08:32 AM Revision 867d3985 (git): ChangeLog compatibility [ci skip]
* tool/vcs.rb (VCS::GIT#export_changelog): improve the
compatibility with svn-log.
remained differences are:
- in svn-log
- accented characters, left/right single quotation marks, and
non-break spaces are translated to ...
nobu (Nobuyoshi Nakada)
08:31 AM Revision 87b03e8c (git): parser: improve error messages
[Fix GH-2011]
From: Akim Demaille <akim.demaille@gmail.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65969 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
06:07 AM Revision 2b9448fd (git): NEWS: fix markup [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65968 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
04:05 AM Revision 98f8baf9 (git): No new entry when getting undefined global variable
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65967 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
03:36 AM Revision 7ac1ff5f (git): Prefer ALLOCV over ALLOCA
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65966 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
03:36 AM Revision 70751a24 (git): un.rb: more options for httpd
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65965 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
03:22 AM Feature #15331: [PATCH] Faster hashing for short string literals
One idea is to shrink `MEMO_HASH_LEN_MAX` for a wide-char terminators. nobu (Nobuyoshi Nakada)
03:10 AM Bug #15332: coverage and InstructionSequence regression
I don't have an important use case, no. marcandre (Marc-Andre Lafortune)
01:20 AM Bug #5060 (Closed): Executables in bin folder conflict with their gem versions.
Applied in changeset trunk|r65963.
----------
Use stub executables generated by RubyGems istead of original executables.
It resolved the conflict issues when invoking `gem i rdoc` and the binstub
issues with Bundler and Rails.
[Bug #...
hsbt (Hiroshi SHIBATA)
01:20 AM Revision 9ba098f1 (git): * properties.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65964 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
01:20 AM Revision a9433281 (git): Use stub executables generated by RubyGems istead of original executables.
It resolved the conflict issues when invoking `gem i rdoc` and the binstub
issues with Bundler and Rails.
[Bug #5060][ruby-core:38257][Fix GH-2023]
* https://github.com/rubygems/rubygems/pull/2338
* https://github.com/heroku/hero...
hsbt (Hiroshi SHIBATA)

11/24/2018

09:40 PM Feature #14982: Improve namespace system in ruby to avoiding top-level names chaos
> As you can see, it is bundled twice. The problem is that although there should be one copy of Molinillo, there are two copies, which artificially differs in namespace, to avoid collision if there was Molinillo gem installed.
In that...
ciconia (Sharon Rosner)
09:09 PM Feature #14982: Improve namespace system in ruby to avoiding top-level names chaos
Not mentioning that Bundler bundles other libraries, such as net-http-persistent and Thor. It would make update of this libraries easier, e.g. they could be submodule in code base, because they would not need modified namespace. vo.x (Vit Ondruch)
09:05 PM Feature #14982: Improve namespace system in ruby to avoiding top-level names chaos
Eregon (Benoit Daloze) wrote:
> Or is there any hidden problem in there?
Yes, support of older RubyGems I suppose.
vo.x (Vit Ondruch)
08:35 PM Feature #14982: Improve namespace system in ruby to avoiding top-level names chaos
IMHO, the case of Molinillo is the job of RubyGems/Bundler developers to solve: settle on one version, and reuse RubyGems' vendored copy for Bundler.
Or is there any hidden problem in there?
Eregon (Benoit Daloze)
05:04 PM Feature #14982: Improve namespace system in ruby to avoiding top-level names chaos
ciconia (Sharon Rosner) wrote:
> > Would you mind to show us, how it could help to improve situation with things like Molinillo bundled twice in Ruby, once in RubyGems, second time in Bundler?
> ...
Molinillo is not external dependency...
vo.x (Vit Ondruch)
08:51 PM Bug #15329 (Closed): Native implementation of coroutines - segfault
Great, thanks for the report. Let me know if you have any other issues. ioquatix (Samuel Williams)
05:59 PM Bug #15329: Native implementation of coroutines - segfault
good news! I can confirm it's fixed by https://github.com/ruby/ruby/commit/f33adbc11e0fa0a2bd73b96ee3a3529481eb111d . Thanks! ahorek (Pavel Rosický)
05:48 AM Bug #15329: Native implementation of coroutines - segfault
Can you please try trunk now? This issue might be fixed. ioquatix (Samuel Williams)
08:42 PM Feature #15338: Provide way for C extensions to query if global variable is defined
> https://bugs.ruby-lang.org/issues/15338

> Let's introduce third function `rb_gv_defined` to complement `rb_gv_get` and `rb_gv_set`.

> PS: At the moment I'm doing `if
> (RTEST(rb_eval_string("defined?($XX) && $XX"))) { ... }` bu...
normalperson (Eric Wong)
08:21 PM Feature #15338 (Open): Provide way for C extensions to query if global variable is defined
As far as I can tell, there is no way for C extension to check if global variable is defined. I can `rb_gv_get`, but that produces warning when `$VERBOSE = true`.
Let's introduce third function `rb_gv_defined` to complement `rb_gv_get...
graywolf (Gray Wolf)
08:12 PM Bug #14968: [PATCH] io.c: make all pipes nonblocking by default
Greg.mpls@gmail.com wrote:
> Using `ruby 2.6.0dev (2018-11-24 trunk 65959) [x64-mingw32]`, applied the patch in msg 32, passed all tests.

Thanks, committed as r65962

> bootstraptest suite is back to mid 40's, it had jumped to m...
normalperson (Eric Wong)
06:02 PM Bug #14968: [PATCH] io.c: make all pipes nonblocking by default
@normalperson Eric,
Using `ruby 2.6.0dev (2018-11-24 trunk 65959) [x64-mingw32]`, applied the patch in msg 32, passed all tests.
bootstraptest suite is back to mid 40's, it had jumped to mid to high 80's.
Thanks, Greg
MSP-Greg (Greg L)
05:11 PM Bug #14968: [PATCH] io.c: make all pipes nonblocking by default
@normalperson Eric,
> Do you have any more details on the slowdown (e.g. profiling info?)
I pointed it out thinking it might help with the issues. I concentrated more on determining what's failing in test-all.
> ...
(Same as r...
MSP-Greg (Greg L)
08:52 AM Bug #14968: [PATCH] io.c: make all pipes nonblocking by default
Greg.mpls@gmail.com wrote:
>
> @normalperson Eric,
>
> After a few more builds, the intermittent test failures seem to be:
> TestIO#test_readpartial_lock

r65948 might help with that one (does IO#nonblock= work for you?)

> ...
normalperson (Eric Wong)
07:59 PM Revision 608b9c29 (git): io.c: disable nonblocking-by-default on win32 pipes
Lets admit Windows will always be too different from POSIX-like
platforms and non-blocking may never work as well or consistently.
[ruby-core:90042] [ruby-core:90044] [Bug #14968]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65962...
Eric Wong
07:54 PM Revision cc6020b7 (git): * 2018-11-25
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65961 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
07:54 PM Revision a5e91822 (git): * common.mk: revise r65767 because AIX's grep does not support -A
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65960 b2dd03c8-39d4-4d8f-98ff-823fe69b080e Rei Odaira
04:02 PM Feature #8258: Dir#escape_glob
mame (Yusuke Endoh) wrote:
> Eregon (Benoit Daloze) wrote:
> ...
Because you'd want to list files whose name is actually "foo[bar]baz.txt"?
I see, makes sense.
My impression is everyone knows "glob'ing" and Dir.glob but very few kn...
Eregon (Benoit Daloze)
03:58 PM Bug #15335: Ruby 2.6.0 is not properly fortified
Thx. I hope I'll be able to check it on Monday. vo.x (Vit Ondruch)
11:35 AM Bug #15335: Ruby 2.6.0 is not properly fortified
I've merged the first set of changes into trunk, for amd64 - @vo.x if you confirm this has fixed the issue I will extend to other architectures. ioquatix (Samuel Williams)
11:12 AM Bug #15335: Ruby 2.6.0 is not properly fortified
I'm attempting to fix this issue here: https://github.com/ruby/ruby/pull/2027
@vo.x do you mind trying to build that PR?
ioquatix (Samuel Williams)
09:19 AM Bug #15335: Ruby 2.6.0 is not properly fortified
Thanks Eric. Those two suggestions are really helpful. I'll investigate it now. ioquatix (Samuel Williams)
07:52 AM Bug #15335: Ruby 2.6.0 is not properly fortified
> https://bugs.ruby-lang.org/issues/15335#change-75132

samuel@oriontransfer.net wrote:
> How can we solve this problem?

Fedora can configure with --disable-fiber-coroutine option
as a stopgap...

> I.e. the coroutines assembly...
normalperson (Eric Wong)
07:30 AM Bug #15335: Ruby 2.6.0 is not properly fortified
How can we solve this problem? ioquatix (Samuel Williams)
07:18 AM Bug #15335 (Assigned): Ruby 2.6.0 is not properly fortified
mame (Yusuke Endoh)
03:50 PM Feature #11689: Add methods allow us to get visibility from Method and UnboundMethod object.
mame (Yusuke Endoh) wrote:
> FYI: The reason why matz does not like the term "visibility", is because the method attribute is not a visibility. In fact, all methods are visible in Ruby. Instead, the method attribute restricts how and ...
Eregon (Benoit Daloze)
01:10 PM Feature #11689: Add methods allow us to get visibility from Method and UnboundMethod object.
FYI: The reason why matz does not like the term "visibility", is because the method attribute is not a visibility. In fact, all methods are visible in Ruby. Instead, the method attribute restricts how and where it can be called. We br... mame (Yusuke Endoh)
12:40 PM Feature #11689: Add methods allow us to get visibility from Method and UnboundMethod object.
I think visibility is the perfect, accurate and unambiguous term for this (e.g., it's even used in the documentation of #private).
Returning the corresponding Symbol also seems very intuitive.
So take my vote as +1 for Method#visibil...
Eregon (Benoit Daloze)
06:43 AM Feature #11689: Add methods allow us to get visibility from Method and UnboundMethod object.
I don't think that `send("#{method.visibility}_instance_methods")` would be a frequent, strongly-recommended idiom. You can do it more explicitly as follows.
```
def visibility(method)
case
when method.public? then "public_...
mame (Yusuke Endoh)
12:48 PM Revision 865313df (git): assertions for r65956
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65959 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
12:33 PM Revision 33afc9e0 (git): remove guard against bug #15337, because it is fixed
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65958 b2dd03c8-39d4-4d8f-98ff-823fe69b080e duerst (Martin Dürst)
12:26 PM Revision 64148e66 (git): * expand tabs.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65957 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
12:26 PM Revision 1f973165 (git): fix r65954; Keep tainty
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65956 b2dd03c8-39d4-4d8f-98ff-823fe69b080e naruse (Yui NARUSE)
12:12 PM Bug #15337: String#each_grapheme_cluster wrongly splits "\r\n"
Once we have a fix for this bug, it should be backported to all the versions that implement \X and that we still support. duerst (Martin Dürst)
11:53 AM Bug #15337 (Closed): String#each_grapheme_cluster wrongly splits "\r\n"
Applied in changeset trunk|r65954.
----------
Don't use single byte optimization on grapheme clusters
Unicode Text Segmentation considers CRLF as a character. [Bug #15337]
naruse (Yui NARUSE)
08:52 AM Bug #15337 (Closed): String#each_grapheme_cluster wrongly splits "\r\n"
The method `each_grapheme_cluster` on the `String` class wrongly splits CRLF into two clusters, as follows:
```
[duerst@stazersee ruby2]$ ./ruby -e 'puts "\r\n".each_grapheme_cluster.to_a.inspect'
["\r", "\n"]
[duerst@stazersee rub...
duerst (Martin Dürst)
12:10 PM Revision 7599b3f6 (git): add tests using Unicode test data for grapheme clusters
Add file test/ruby/enc/test_grapheme_breaks.rb to test String#each_grapheme_cluster
and \X extended grapheme cluster matcher in regular expressions against test data
provided by Unicode (ucd/auxiliary/GraphemeBreakTest.txt).
Some lines ...
duerst (Martin Dürst)
11:53 AM Revision 7850586a (git): Don't use single byte optimization on grapheme clusters
Unicode Text Segmentation considers CRLF as a character. [Bug #15337]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65954 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
naruse (Yui NARUSE)
11:35 AM Revision f33adbc1 (git): Ensure stack is correctly protected
See https://bugs.ruby-lang.org/issues/15335 for more details.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65953 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Samuel Williams
11:35 AM Revision e64f71f8 (git): Change Makefile rule for assembly to use .S rather than .s
It is more conventional to use compiler to pre-process and
assemble the `.S` file rather than forcing Makefile to use `.s`.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65952 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Samuel Williams
10:29 AM Revision 09142238 (git): Makefile.in: use ASMEXT in implicit rules
Use $(ASMEXT) instead of `.s` directly, as well as `.SUFFIXES:`
line.
Also, use the same suffix at compiling from `.c`. These are
different things traditionally, but we won't mix same name files
with `.c` and `.s`.
git-svn-id: svn+ssh...
nobu (Nobuyoshi Nakada)
08:38 AM Feature #15144 (Closed): Enumerator#chain
Applied in changeset trunk|r65949.
----------
Implement Enumerator#+ and Enumerable#chain [Feature #15144]
They return an Enumerator::Chain object which is a subclass of
Enumerator, which represents a chain of enumerables that works as...
knu (Akinori MUSHA)
08:38 AM Revision 94ec8e0d (git): Add entries regarding Enumerator::Chain to NEWS
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65950 b2dd03c8-39d4-4d8f-98ff-823fe69b080e Akinori MUSHA
08:38 AM Revision 045b0e54 (git): Implement Enumerator#+ and Enumerable#chain [Feature #15144]
They return an Enumerator::Chain object which is a subclass of
Enumerator, which represents a chain of enumerables that works as a
single enumerator.
```ruby
e = (1..3).chain([4, 5])
e.to_a #=> [1, 2, 3, 4, 5]
e = (1..3).each + [4, 5]
...
Akinori MUSHA
08:23 AM Revision c0e20037 (git): io.c: wait on FD readability w/o GVL reacquisition
Since non-blocking I/O is the default after [Bug #14968],
we will hit it more often and cause more acquisition/release
of GVL to wait on single FD.
This also lets us avoid touching the temporal string locking
as much and lets us clean u...
Eric Wong
08:21 AM Feature #15286: Proposal: Add Kernel.#expand(*args)
OK, Thank you, matz :)
osyo (manga osyo)
07:10 AM Bug #15332: coverage and InstructionSequence regression
The change itself is actually not intended.
But I'm unsure if it should handle ISeq-loaded code as a measuring target, because currently eval-loaded code is not a target:
```
require 'coverage'
Coverage.start
eval("puts 'hi'", bin...
mame (Yusuke Endoh)
05:35 AM Feature #15331: [PATCH] Faster hashing for short string literals
Ah I see the problem with wide-char encodings now. There are some C APIs that write a codepoint-wide terminator at `arr[RSTRING_EMBED_LEN]`, which can clobber the hash memo.
I will benchmark to see if fetching the encoding struct is slo...
alanwu (Alan Wu)
04:34 AM Revision 8c8e72fb (git): Add clean-srcs
Add `clean-srcs` target to clean sources in the build directory,
and `realclean-srcs` target to clean autogenerated sources in the
source directory. Also `realclean-srcs-extra` target to clean
sources which are generatable but need to i...
nobu (Nobuyoshi Nakada)
04:33 AM Revision 65cec46e (git): Make ext/etc/constdefs.h by srcs-ext
Make platform independent header, ext/etc/constdefs.h, by `make
srcs-ext`.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65946 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
02:31 AM Revision 64591128 (git): Fix argument order.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65945 b2dd03c8-39d4-4d8f-98ff-823fe69b080e Samuel Williams
02:31 AM Revision 4b0a256e (git): Enable msys2 to check build status.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65944 b2dd03c8-39d4-4d8f-98ff-823fe69b080e Samuel Williams
12:55 AM Revision ba9a6f89 (git): Fix r65926 test_dir.rb for windows (tilde)
[Fix GH-2022]
From: MSP-Greg <greg.mpls@gmail.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65943 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
k0kubun (Takashi Kokubun)
 

Also available in: Atom