Project

General

Profile

Activity

From 11/13/2018 to 11/19/2018

11/19/2018

11:28 PM Revision 95e09343 (git): test_process.rb: Process.daemon seems irrelevant [ci skip]
in the backtrace:
http://ci.rvm.jp/results/trunk-mjit@silicon-docker/1468677
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65816 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
k0kubun (Takashi Kokubun)
11:06 PM Bug #15307: TestJIT#test_{catching_deep_exception,compile_insn_throw,lambda_longjmp} segfaults with gcc-8 -fcf-protection
Could you try building and running test_jit with r65815? k0kubun (Takashi Kokubun)
11:05 PM Bug #15307 (Closed): TestJIT#test_{catching_deep_exception,compile_insn_throw,lambda_longjmp} segfaults with gcc-8 -fcf-protection
Applied in changeset trunk|r65815.
----------
configure.ac: avoid crashing MJIT with -fcf-protection
by avoiding using __builtin_longjmp, like r64983.
[Bug #15307]
k0kubun (Takashi Kokubun)
10:29 PM Bug #15307: TestJIT#test_{catching_deep_exception,compile_insn_throw,lambda_longjmp} segfaults with gcc-8 -fcf-protection
Cool, thanks a lot. It looks like a new option of gcc. I reproduced your issue with:
```
./configure CC="gcc-8" CFLAGS="-fcf-protection"
```
I'll think about how to deal with this.
k0kubun (Takashi Kokubun)
02:55 PM Bug #15307: TestJIT#test_{catching_deep_exception,compile_insn_throw,lambda_longjmp} segfaults with gcc-8 -fcf-protection
Just confirmed that removing just `-fcf-protection` from the initial flag set makes the test pass. vo.x (Vit Ondruch)
02:39 PM Bug #15307: TestJIT#test_{catching_deep_exception,compile_insn_throw,lambda_longjmp} segfaults with gcc-8 -fcf-protection
It seems that `-fcf-protection` makes the difference. IOW this makes the test (specifically testing with test_lambda_longjmp) fail:
~~~
CFLAGS="-fcf-protection" \
CXXFLAGS="-fcf-protection" \
LDFLAGS="" \
FFLAGS="" \
FCFLAGS="" ....
vo.x (Vit Ondruch)
12:02 PM Bug #15307: TestJIT#test_{catching_deep_exception,compile_insn_throw,lambda_longjmp} segfaults with gcc-8 -fcf-protection
and possibly -fasynchronous-unwind-tables -fstack-clash-protection as well k0kubun (Takashi Kokubun)
12:01 PM Bug #15307: TestJIT#test_{catching_deep_exception,compile_insn_throw,lambda_longjmp} segfaults with gcc-8 -fcf-protection
Could you try eliminating -fstack-protector-strong? k0kubun (Takashi Kokubun)
11:53 AM Bug #15307: TestJIT#test_{catching_deep_exception,compile_insn_throw,lambda_longjmp} segfaults with gcc-8 -fcf-protection
I have tried to reduce the hardening options:
~~~patch
--- /a
+++ /b
@@ -16,12 +16,10 @@
* enable shared libs: yes
* dynamic library ext: so
* CFLAGS: ${optflags} ${debugflags} ${warnflags}
- * LDFLA...
vo.x (Vit Ondruch)
11:05 PM Revision 00fac76e (git): configure.ac: avoid crashing MJIT with -fcf-protection
by avoiding using __builtin_longjmp, like r64983.
[Bug #15307]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65815 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
k0kubun (Takashi Kokubun)
10:41 PM Bug #15285: lambda return behavior regression from #14639
I also ran into this problem in ruby 2.5.3.
This is a little confusing because there are two things being changed here:
1. How arguments are handled in a passed &lambda, which was asked for in #14639
2. How return is handled in a pa...
jhawthorn (John Hawthorn)
10:10 PM Revision 27322735 (git): revert r65807
it didn't work.
http://ci.rvm.jp/results/trunk-mjit@silicon-docker/1468677
and skips broken tests for now. But this issue should be fixed soon.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65814 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
k0kubun (Takashi Kokubun)
10:08 PM Bug #15320 (Open): IO.popen with MJIT worker thread may deadlock
k0kubun (Takashi Kokubun)
01:33 PM Bug #15320 (Closed): IO.popen with MJIT worker thread may deadlock
Applied in changeset trunk|r65807.
----------
process.c: do not run signal handler before fork
to prevent from proceeding one for MJIT while it's not safe yet.
By that situation, MJIT worker could be waiting for compiler process foreve...
k0kubun (Takashi Kokubun)
01:02 PM Bug #15320 (Closed): IO.popen with MJIT worker thread may deadlock
In r65785, we added `mjit_pause` on `before_fork_ruby`. We seem to have introduced a few deadlocks by that. This was discussed in https://bugs.ruby-lang.org/issues/15316, but I filed a separate ticket because this issue is independent fr... k0kubun (Takashi Kokubun)
09:33 PM Bug #15310: [PATCH] thread_pthread.c: close race from UBF_TIMER and non-GVL-releasing thread
lars@greiz-reinsdorf.de wrote:
> Do you have an exploit to trigger the described issue?

Not yet, was just thinking about it again, now, though...

> https://bugs.ruby-lang.org/issues/15310#change-74957
normalperson (Eric Wong)
09:11 PM Bug #15310: [PATCH] thread_pthread.c: close race from UBF_TIMER and non-GVL-releasing thread
Do you have an exploit to trigger the described issue?
larskanis (Lars Kanis)
06:42 PM Bug #15318: net/imap socket backward compatibility broken in ruby 2.5+
karis10@f5foster.com wrote:
> https://bugs.ruby-lang.org/issues/15318

"Socket.tcp" been part of the public Ruby API for around 10 years
already. socksify should be supporting it in addition to TCPSocket;
because there is code whi...
normalperson (Eric Wong)
06:05 PM Bug #15318: net/imap socket backward compatibility broken in ruby 2.5+
ahorek (Pavel Rosický) wrote:
> It wasn't intentional, but I think you shouldn't depend on TCPSocket anyway.
> ...
One more comment about it if you don't mind. Internal interfaces being created for some reason, and there was a reason t...
karis10 (bug reporter)
04:05 PM Bug #15318: net/imap socket backward compatibility broken in ruby 2.5+
It wasn't intentional, but I think you shouldn't depend on TCPSocket anyway.
1/ Net::IMAP doesn't expose @socket in a public api
2/ it isn't documented that Net::IMAP will always use TCPSocket
@nobu what's your opinion? we should at...
ahorek (Pavel Rosický)
01:13 PM Bug #15318: net/imap socket backward compatibility broken in ruby 2.5+
ahorek (Pavel Rosický) wrote:
> ok, IMAP uses Socket.tcp instead of TCPSocket, so if you patch TCPSocket directly it won't work anymore.
> ...
I understand your intentions and don't know what are you going to do next, but it's not a go...
karis10 (bug reporter)
10:52 AM Bug #15318: net/imap socket backward compatibility broken in ruby 2.5+
ok, IMAP uses Socket.tcp instead of TCPSocket, so if you patch TCPSocket directly it won't work anymore.
the intention was to get rid of Timeout.timeout {} and make these libraries fully async
there are simmilar pending changes for...
ahorek (Pavel Rosický)
08:26 AM Bug #15318: net/imap socket backward compatibility broken in ruby 2.5+
nobu (Nobuyoshi Nakada) wrote:
> Could you elaborate how it is broken?
Sure.
~~~ ruby
require 'net/imap'
require 'net/pop'
require 'socksify'
Socksify::debug = true
Socksify::proxy('127.0.0.1', 1080) do |_|
# in ruby 2.4...
karis10 (bug reporter)
08:18 AM Bug #15318: net/imap socket backward compatibility broken in ruby 2.5+
ahorek (Pavel Rosický) wrote:
> https://github.com/ruby/ruby/commit/5bf395f4cbd43bf64abcf6cc19daf834d2a02046#diff-4b4baaf75652a369c39b0b76e81ad54d
> ...
I was talking about this exactly change:
~~~ diff
< @sock = TCPSocket.open...
karis10 (bug reporter)
05:57 AM Bug #15318: net/imap socket backward compatibility broken in ruby 2.5+
https://github.com/ruby/ruby/commit/5bf395f4cbd43bf64abcf6cc19daf834d2a02046#diff-4b4baaf75652a369c39b0b76e81ad54d
Hi, the mentioned change was reverted and never released in any stable version.
ahorek (Pavel Rosický)
02:32 AM Bug #15318 (Feedback): net/imap socket backward compatibility broken in ruby 2.5+
Could you elaborate how it is broken? nobu (Nobuyoshi Nakada)
03:00 PM Revision 797098f8 (git): * 2018-11-20
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65813 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
03:00 PM Revision de790435 (git): ruby/ruby.h: void rb_scan_args_verify
* include/ruby/ruby.h (rb_scan_args_verify): void the never used
result.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65812 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
02:21 PM Revision 9c336391 (git): appveyor.yml: separately execute test_bignum
because that may crash worker with -j.
https://ci.appveyor.com/project/ruby/ruby/builds/20403179/job/mkdcb6uy8qn2djgl
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65811 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
k0kubun (Takashi Kokubun)
02:00 PM Revision b756b25c (git): ruby.c: do not surface MJIT to user
In some places, both JIT and MJIT are being used, but it could be
confusing for new comers. We're not explaining MJIT on NEWS file or release
notes as well. So we consider MJIT as an internal term of implementation
like YARV.
configure....
k0kubun (Takashi Kokubun)
01:48 PM Revision 83aff333 (git): internal.h: resurrect --disable-mjit-support
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65809 b2dd03c8-39d4-4d8f-98ff-823fe69b080e k0kubun (Takashi Kokubun)
01:43 PM Bug #15319 (Closed): Since r65735, tool/mjit_archflag.sh related error on Solaris 10
Applied in changeset trunk|r65808.
----------
fix for Solaris sh
* Makefile.in (mjit_config.h): removed unnecessary assignment.
* tool/mjit_archflag.sh (define_arch_flags): need to quote on
Solaris. [ruby-dev:50669] [Bug #15319]
nobu (Nobuyoshi Nakada)
01:36 PM Bug #15319: Since r65735, tool/mjit_archflag.sh related error on Solaris 10
これでどうでしょうか。
```diff
diff --git a/Makefile.in b/Makefile.in
index f1d5258ad9..b8db70f5c8 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -601,7 +601,7 @@ mjit_config.h:
quote "MJIT_DLDFLAGS MJIT_ARCHFLAG" $(MJIT_DLDFLAGS); \
...
nobu (Nobuyoshi Nakada)
09:44 AM Bug #15319: Since r65735, tool/mjit_archflag.sh related error on Solaris 10
どうやら ` indent=$${archs+ } define_arch_flags; \` の行で/bin/shのエラーが発生しているようです。
つまり `${archs+ }` の閉じ括弧が単体のコマンドとして認識されているようです。
ngoto (Naohisa Goto)
09:35 AM Bug #15319 (Closed): Since r65735, tool/mjit_archflag.sh related error on Solaris 10
r65735以降、手元の Solaris 10 上でのコンパイルがエラーになります。
コンパイラは gcc, Oracle Developer Studio のどちらでもダメでした。
r65738においてのgccでの最後の方のコンパイル時の出力を抜粋すると以下の通りです。
~~~
gcc -O -m64 -D_FORTIFY_SOURCE=2 -fstack-protector -fno-strict-overflow -DRUBY_DEVEL=1 -f...
ngoto (Naohisa Goto)
01:43 PM Revision 3f84ef97 (git): fix for Solaris sh
* Makefile.in (mjit_config.h): removed unnecessary assignment.
* tool/mjit_archflag.sh (define_arch_flags): need to quote on
Solaris. [ruby-dev:50669] [Bug #15319]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65808 b2dd03c8-39d...
nobu (Nobuyoshi Nakada)
01:40 PM Bug #15315: ec_switch can still lose interrupts
> 1) will remain dangerous
Is this about Bug #15316?
k0kubun (Takashi Kokubun)
01:33 PM Revision e205cd80 (git): process.c: do not run signal handler before fork
to prevent from proceeding one for MJIT while it's not safe yet.
By that situation, MJIT worker could be waiting for compiler process forever
http://ci.rvm.jp/results/trunk-mjit@silicon-docker/1468033
[Bug #15320]
git-svn-id: svn+ssh:/...
k0kubun (Takashi Kokubun)
01:21 PM Revision 759cfd3b (git): configure.ac: rename extra_warning as extra_warnflags
Adjusted to warnflags variable. This variable will have flags for
warnings, but not a warning itself.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65806 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
10:57 AM Feature #15317: How to deal with obsolete property values in Unicode 11.0.0
shevegen (Robert A. Heiler) wrote:
> Could a warning be issued as well, at the least for a transition period?
I warning might make sense, but then we would get into the question of whether we need a warning for those cases w
here pr...
duerst (Martin Dürst)
10:15 AM Revision 33fed2d0 (git): configure.ac: respect extra_warnflags if given
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65805 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
09:52 AM Revision 72135687 (git): string.c: setbyte silently ignores upper bits
The behaviour of String#setbyte has been depending on the width
of int, which is not portable. Must check explicitly.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65804 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
shyouhei (Shyouhei Urabe)
09:42 AM Revision d1372430 (git): .travis.yml: do not pass unnecessary warnflags
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65803 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
08:57 AM Bug #14998: Race conditions in MonitorMixin when interrupted
Eregon (Benoit Daloze) wrote:
> From https://bugs.ruby-lang.org/issues/14859#note-9
> ...
How about the following code?
```ruby
def wait(timeout = nil)
Thread.handle_interrupt(Exception => :never) do
@monitor.__...
shugo (Shugo Maeda)
08:10 AM Bug #14359 (Closed): IO#ungetbyte integer overflow
Applied in changeset trunk|r65802.
----------
io.c: ungetbyte silently ignores upper bits
The behaviour of IO#ungetbyte has been depending on the width of
Fixnums. Fixnums should be invisible nowadays. It must be a
bug. Fix [Bug #14359]
shyouhei (Shyouhei Urabe)
08:10 AM Revision 412b6b5b (git): io.c: ungetbyte silently ignores upper bits
The behaviour of IO#ungetbyte has been depending on the width of
Fixnums. Fixnums should be invisible nowadays. It must be a
bug. Fix [Bug #14359]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65802 b2dd03c8-39d4-4d8f-98ff-823fe6...
shyouhei (Shyouhei Urabe)
07:00 AM Revision 38adc0c1 (git): _colorize_result_prepare.m4: do not save CONFIGURE_TTY
redirection to a tty, file or pipe is not a permanent status.
`rb_cv_` prefix means that it should be saved/restored across
re-configurations.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65801 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
06:52 AM Revision 74564fbe (git): Makefile.in: reconfig with the original warnflags
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65800 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
06:52 AM Revision 4863a93d (git): .travis.yml: use dedicated flags
* .travis.yml: use dedicated flags, cflags and others, not to
override optflags, warnflags and debugflags.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65799 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
06:48 AM Revision 6bdca5d8 (git): array.c: avoid (VALUE)--
This args[1]-- overflows when it is zero. Should do that only
when we can say it is nonzero.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65798 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
shyouhei (Shyouhei Urabe)
05:04 AM Misc #15229: DevelopersMeeting20181122Japan
* [Feature #15317] How to deal with obsolete property values in Unicode 11.0.0
* A clear idea on this is needed to upgrade to Unicode 11.0.0.
* [Feature #13890] Allow a regexp as an argument to 'count', to count more interesting th...
duerst (Martin Dürst)
05:04 AM Revision 1a5b274e (git): .travis.yml: -Wno-unknown-warning-option is needed, too.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65797 b2dd03c8-39d4-4d8f-98ff-823fe69b080e shyouhei (Shyouhei Urabe)
04:59 AM Feature #12698: Method to delete a substring by regex match
matz (Yukihiro Matsumoto) wrote:
> I don't think it's worth adding which is easily done by `sub/gsub`.
If put this way, it's easy to agree. But looking at it starting from `String#delete`, it feels annoying that `String#delete` doesn...
duerst (Martin Dürst)
04:25 AM Bug #15280: r65509 - bundler & make install, no CLI
@hsbt
Sorry, I should have added some more info. It's a Windows build, and there are three *.cmd files in bin:
bundle.cmd
bundle_ruby.cmd
bundler.cmd
bundler.cmd which doesn't work, has one 'ruby' line
```
load File.expand_pa...
MSP-Greg (Greg L)
03:22 AM Bug #15280 (Feedback): r65509 - bundler & make install, no CLI
I couldn't reproduce them.
```
~/D/g/b/bundler (master) > ruby -v
ruby 2.6.0dev (2018-11-18 trunk 65790) +JIT [x86_64-darwin18]
~/D/g/b/bundler (master) > bundle version
Bundler version 2.0.0.pre.1 (2018-11-19 commit unknown)
~/D...
hsbt (Hiroshi SHIBATA)
03:08 AM Revision 9f6c0270 (git): .travis.yml: extra CFLAGS to suppress warnings
When CFLAGS is passed on travis, warnflags seems not working.
Let's add them directly to prevent clang form messing up the logs.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65796 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
shyouhei (Shyouhei Urabe)
03:01 AM Revision e0dba078 (git): -Wno-unused-value [ci skip]
Without this option clang outputs tons of warnings, which
are annoying. See https://travis-ci.org/ruby/ruby/jobs/456553420#L1817
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65795 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
shyouhei (Shyouhei Urabe)
02:58 AM Revision 45a89c0a (git): sort lines [ci skip]
... for aethetic reasons.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65794 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
shyouhei (Shyouhei Urabe)
02:43 AM Feature #15286: Proposal: Add Kernel.#expand(*args)
And, what do you expect for keywords, e.g., `__FILE__`, `__LINE__`, `self`, `super`, and etc? nobu (Nobuyoshi Nakada)
02:20 AM Feature #15286: Proposal: Add Kernel.#expand(*args)
Interesting feature, but I don't think the name `Kernel#expand` is acceptable.
Maybe an instance method of `Binding`?
And I think it should raise a `NameError` instead of a `NoMethodError` on invalid names.
nobu (Nobuyoshi Nakada)
12:52 AM Bug #15316: rb_postponed_job_register not thread-safe
I see.
> If you can't solve it, can you wait until after the 11/22
developers meeting?
Sure. I hope we'll release the fix on rc1, so I'll try to fix that anyway.
I hope auto-fiber will be in 2.6 too :)
k0kubun (Takashi Kokubun)
12:33 AM Bug #15316: rb_postponed_job_register not thread-safe
takashikkbn@gmail.com wrote:
> Well, I seem to have introduced at least two deadlocks by
> that. I already fixed the first one, and I'm going to fix the
> second one
> http://ci.rvm.jp/results/trunk-mjit@silicon-docker/1467162.
>
...
normalperson (Eric Wong)
12:07 AM Bug #15316: rb_postponed_job_register not thread-safe
Well, I seem to have introduced at least two deadlocks by that. I already fixed the first one, and I'm going to fix the second one http://ci.rvm.jp/results/trunk-mjit@silicon-docker/1467162.
I'll take a deeper look when I come home to...
k0kubun (Takashi Kokubun)

11/18/2018

11:29 PM Revision becdfee6 (git): * 2018-11-19
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65793 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
11:29 PM Revision 9cbfb177 (git): Also clean ruby-runner.o and ruby.imp [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65792 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
11:29 PM Revision c8ab2634 (git): update-deps: fix runtime error [ci skip]
* tool/update-deps (init_global): environment strings are frozen.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65791 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
01:32 PM Revision 524e4cc9 (git): mjit.c: fix deadlock introduced by r65785
in mjit_pause() fired by before_fork_ruby(). When calling
RUBY_VM_CHECK_INTS() in mjit_pause()'s loop, other threads may call
start_worker() which sets `stop_worker_p = FALSE` and it could wait for
MJIT worker stop forever even while `st...
k0kubun (Takashi Kokubun)
10:43 AM Feature #15317: How to deal with obsolete property values in Unicode 11.0.0
Could a warning be issued as well, at the least for a transition period?
On a side note, does anyone happen to know how perl5/perl6 and python handle
these situations? Perhaps if what they do makes sense, we could have a
consistent...
shevegen (Robert A. Heiler)
09:35 AM Feature #15317 (Closed): How to deal with obsolete property values in Unicode 11.0.0
http://www.unicode.org/versions/Unicode11.0.0/#Migration contains the following:
> Four Grapheme_Cluster_Break and Word_Break classes have become obsolete and are no longer used: E_Base, E_Modifier, Glue_After_Zwj, and E_Base_GAZ. Tho...
duerst (Martin Dürst)
10:26 AM Bug #15318 (Rejected): net/imap socket backward compatibility broken in ruby 2.5+
Hi,
I use net/pop and net/imap libraries and sometimes I need my pop/imap connections to be socksified or proxified (through TCPSocket initialize method modifications: https://github.com/Shopify/socksify-ruby). Upgrading to ruby 2.5.3 f...
karis10 (bug reporter)
09:32 AM Revision 9edbcbcb (git): wercker.yml: debug problematic test on test-all
Some test seems to hang
https://app.wercker.com/ruby/ruby/runs/mjit-test1/5bf1221c183106002855989c?step=5bf1225987436a0006192c31
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65789 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
k0kubun (Takashi Kokubun)
09:22 AM Revision fcd8412d (git): test_jit.rb: loosen output check
for interleaving between processes
https://gist.github.com/ko1/ace0374825377b41628d4590b7377601
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65788 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
k0kubun (Takashi Kokubun)
08:44 AM Revision 9b850d1a (git): test_jit.rb: dump information to debug test failure
debugging
http://ci.rvm.jp/results/trunk-vm-asserts@silicon-docker/1466123
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65787 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
k0kubun (Takashi Kokubun)
08:40 AM Bug #15316: rb_postponed_job_register not thread-safe
> OK, please do.
Done, in r65785. Comments from your point of view would be much appreciated.
> ...
looks fine.
> Somewhat related. We need to ensure a consistent state of the queue (either postponed_job or workqueue).
In a s...
k0kubun (Takashi Kokubun)
08:22 AM Bug #15316: rb_postponed_job_register not thread-safe
takashikkbn@gmail.com wrote:
> Oh by the way, I have a patch which was created yesterday but
> I was too busy to commit that yet. (I'll commit that shortly.)

OK, please do.

I am also testing a minor cleanup:
https://80x24.org/s...
normalperson (Eric Wong)
08:09 AM Bug #15316: rb_postponed_job_register not thread-safe
Thanks to report that.
> My goal is also to support MJIT in forked processes
Oh by the way, I have a patch which was created yesterday but I was too busy to commit that yet. (I'll commit that shortly.)
I think thread-safety of p...
k0kubun (Takashi Kokubun)
06:52 AM Bug #15316: rb_postponed_job_register not thread-safe
> https://bugs.ruby-lang.org/issues/15316

> So it looks like we need a THREAD-SAFE (not necessarily async-safe)
> version of rb_postponed_job_register. Or a one-off API for MJIT...
> job registration for MJIT.

I think I will in...
normalperson (Eric Wong)
04:49 AM Bug #15316 (Closed): rb_postponed_job_register not thread-safe
Consider following execution timeline for two threads, t1 and t2.
(should be 2 columns, I only have fixed-width fonts for display)
```
t1 t2 (mjit-worker)
-----------------------------------------...
normalperson (Eric Wong)
08:25 AM Revision 57efe84b (git): * expand tabs.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65786 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
08:25 AM Revision fe6974a8 (git): mjit_worker.c: support MJIT in forked Ruby process
by launching MJIT worker thread in child Ruby process.
See the comment before `mjit_child_after_fork` for details.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65785 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
k0kubun (Takashi Kokubun)
08:23 AM Revision 0a7a5a7a (git): thread.c: rb_fiber_atfork has nothing to do with mjit.c [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65784 b2dd03c8-39d4-4d8f-98ff-823fe69b080e k0kubun (Takashi Kokubun)
08:22 AM Revision bdf5eb3b (git): mjit_worker.c: fix typo [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65783 b2dd03c8-39d4-4d8f-98ff-823fe69b080e k0kubun (Takashi Kokubun)
08:22 AM Revision 05159044 (git): test_jit.rb: fix typo [ci skip]
we don't have such VM register
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65782 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
k0kubun (Takashi Kokubun)
06:22 AM Misc #15229: DevelopersMeeting20181122Japan
mame@ruby-lang.org wrote:
> https://bugs.ruby-lang.org/issues/15229

[Bug #14968] make all pipes and sockets non-blocking by default
normalperson (Eric Wong)
05:12 AM Misc #15229: DevelopersMeeting20181122Japan
* [Feature #15302] Proc#with and Proc#by, for partial function application and currying (Ritchie Buitre)
* Convenient methods for functional programming.
RichOrElse (Ritchie Buitre)
04:34 AM Revision 644f2013 (git): vm_trace.c (rb_postponed_job_flush): use rb_atomic_t for mask
ec->interrupt_mask will remain rb_atomic_t and is 32-bit on some
64-bit systems while "unsigned long" is 64-bits. So avoid
mismatching lengths and stick to rb_atomic_t.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65781 b2dd03c8-3...
Eric Wong
04:21 AM Revision 5c334727 (git): common.mk: dependency of io.c for r65779
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65780 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
03:37 AM Revision eb959292 (git): io.c: include vm_core.h for VM_UNREACHABLE
Thanks to Greg L <greg.mpls@gmail.com> for the report
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65779 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Eric Wong
01:37 AM Revision 0cdd4596 (git): * 2018-11-18
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65778 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
01:37 AM Revision b5bb5ed0 (git): io.c (novl_wait_for_single_fd): VM_UNREACHABLE instead of assert
This respects VM_CHECK_MODE and is more consistent with
the rest of our code.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65777 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Eric Wong
01:37 AM Revision e4c9a70c (git): * expand tabs.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65776 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
01:37 AM Revision 9a8b75a7 (git): vm_core.h (rb_thread_set_current*): convert to static inline
We already use "static inline" heavily and there should be no
penalty for modern compilers; this adds type-checking, too.
This will make future changes easier-to-review.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65775 b2dd03c8-...
Eric Wong
12:50 AM Bug #15315 (Assigned): ec_switch can still lose interrupts
ec_switch and thread switching may still lose interrupts
trap interrupt is OK because of r64062
Not OK:
1) postponed job interrupt from MJIT worker
This is trickiest to solve because it also affects thread switching,
not...
normalperson (Eric Wong)

11/17/2018

04:54 PM Feature #15302: Proc#with and Proc#by, for partial function application and currying
shevegen (Robert A. Heiler) wrote:
> I am not sure if the API seems ok. I am also not sure if matz
> ...
Thank you for taking the time to review my proposal and for the suggestions.
To illustrate more clearly how **`Symbol#with`** wor...
RichOrElse (Ritchie Buitre)
10:56 AM Feature #15302: Proc#with and Proc#by, for partial function application and currying
I am not sure if the API seems ok. I am also not sure if matz
wants to have `Symbol`s have methods such as `.with()`. For example,
to me personally it is not entirely clear why "with 2" would
be equal to "n * 2" as such.
I am also...
shevegen (Robert A. Heiler)
01:42 AM Revision 2b894084 (git): test/mkmf/base.rb: use CC_WRAPPER same as the toplevel
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65774 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
01:28 AM Bug #15312: Ruby gives me wrong result for plus operation
You can write rational numbers by `r` suffix.
```ruby
p 0.1r + 0.2r #=> (3/10)
```
As I found these literals (`r` and `i`) have not been mentioned in `doc/syntax/`, added them now (r65773).
nobu (Nobuyoshi Nakada)
01:21 AM Revision 077a15c8 (git): [DOC] rational and imaginary literals [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65773 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)

11/16/2018

11:27 PM Revision 9d6968f1 (git): * 2018-11-17
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65772 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
11:27 PM Revision 0a10c46d (git): * properties.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65771 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
11:27 PM Revision 3ec3d7d9 (git): Switch to 2-0-stable branch of bundler/bundler repository from our fork repository.
https://github.com/bundler/bundler/tree/2-0-stable
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65770 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
hsbt (Hiroshi SHIBATA)
10:43 PM Bug #15314 (Assigned): Bundler with 2.6 fails when installing dependencies into a --path with --binstubs
hsbt (Hiroshi SHIBATA)
10:34 PM Bug #15314 (Closed): Bundler with 2.6 fails when installing dependencies into a --path with --binstubs
When using Ruby 2.6 and installing gems via bundler's `--path` option, there is an exception:
~~~ text
$ ruby -v
ruby 2.6.0preview3 (2018-11-06 trunk 65578) [x86_64-darwin17]
$ rails -v
Rails 5.2.1
$ rails new myapp-2-6
$ cd mya...
schneems (Richard Schneeman)
08:10 PM Bug #15313 (Closed): [PATCH] Let debuggers know when a tail call happens
## Background
The popular debugger "byebug" relies on tracepoint events to implement a few core functionality such as "next".
The "next" command needs to pause execution when the VM reaches the next line on the same stack frame. As the...
alanwu (Alan Wu)
06:37 PM Bug #15312 (Rejected): Ruby gives me wrong result for plus operation
See also https://0.30000000000000004.com/
marcandre (Marc-Andre Lafortune)
06:34 PM Bug #15312: Ruby gives me wrong result for plus operation
This is not a bug, that's how floating point arithmetic works in accordance with the IEEE 754 standard.
You can read more about that on Wikipedia or in this article: https://docs.oracle.com/cd/E19957-01/806-3568/ncg_goldberg.html
T...
Anonymous
05:43 PM Bug #15312 (Rejected): Ruby gives me wrong result for plus operation
Run into this weird issue today. Tried that on rubies 2.5.1p57 and ruby 2.5.3p105 (i believe this is latest stable at the moment).
Here is how to reproduce it
```
$ irb
2.5.3 :001 > 2.6 + 0.1
=> 2.7
2.5.3 :002 > 2.7 + 0.1
=...
kot-begemot (Max Zet)
05:21 PM Bug #15307: TestJIT#test_{catching_deep_exception,compile_insn_throw,lambda_longjmp} segfaults with gcc-8 -fcf-protection
Actually here is the documentation of build flags:
https://src.fedoraproject.org/rpms/redhat-rpm-config/blob/master/f/buildflags.md
vo.x (Vit Ondruch)
08:41 AM Bug #15307: TestJIT#test_{catching_deep_exception,compile_insn_throw,lambda_longjmp} segfaults with gcc-8 -fcf-protection
k0kubun (Takashi Kokubun) wrote:
> I'm not so familiar with redhat-hardened things. I have some questions:
> ...
It is the default and mandatory settings for the build of all packages on Fedora/RHEL. The last hardening changes were pr...
vo.x (Vit Ondruch)
03:00 AM Bug #15307: TestJIT#test_{catching_deep_exception,compile_insn_throw,lambda_longjmp} segfaults with gcc-8 -fcf-protection
I'm not so familiar with redhat-hardened things. I have some questions:
* Why are you using the "hardened" options? Is it default on your environment?
* Do these tests succeed if you strip the hardened options on the same environment...
k0kubun (Takashi Kokubun)
02:13 PM Bug #15304: Package build with extensions is not reproducible
Regarding files under `usr/​lib/​ruby/​gems/​2.​5.​0/​extensions/​x86_64-​linux/​2.​5.​0/​msgpack-​1.​2.​4/​`, I think that rubygems is lazy not to select files properly.
And `.​/​usr/​lib/​ruby/​gems/​2.​5.​0/​gems/​msgpack-​1.​2.​4/​e...
nobu (Nobuyoshi Nakada)
12:44 PM Bug #15304: Package build with extensions is not reproducible
nobu (Nobuyoshi Nakada) wrote:
> These (and `page-Makefile.ri`) are all garbages after installation.
Hmm, I'm not sure to understand, because several distributions have these files remaining in the `install-dir` provided to `rubygem`...
lewo (lewo lewo)
12:21 PM Bug #15304: Package build with extensions is not reproducible
lewo (lewo lewo) wrote:
> I think the `mkmf.log` should not be written in the `install-dir`. But what about the `Makefile`? Could it be still used after the ruby gem build? If not, it could also be removed from the `install-dir`.
The...
nobu (Nobuyoshi Nakada)
08:21 AM Bug #15304: Package build with extensions is not reproducible
nobu (Nobuyoshi Nakada) wrote:
> Why are such files packaged?
These files are written by `gem intall` in the directory specified by the `--install-dir` option. Distributions are taking this whole direcory to create the distribution p...
lewo (lewo lewo)
12:11 PM Bug #15311 (Closed): `make check` causes `warning: No mjit_build_directory`
Applied in changeset trunk|r65769.
----------
Makefile.in: test-almost also needs mjit_build_dir.so
[ruby-core:89830] [Bug #15311]
nobu (Nobuyoshi Nakada)
07:37 AM Bug #15311 (Closed): `make check` causes `warning: No mjit_build_directory`
`make help` says:
```
check: equals make test test-all test-spec
```
But `make check` does not depend `test-all` acctually, it does not create `mjit_build_dir.so`.
So `make check` outputs many `warning: No mjit...
znz (Kazuhiro NISHIYAMA)
12:11 PM Revision f632ecd0 (git): Makefile.in: test-almost also needs mjit_build_dir.so
[ruby-core:89830] [Bug #15311]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65769 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
09:49 AM Feature #12115: Add Symbol#call to allow to_proc shorthand with arguments
I have a related proposal #15302 with a different implementation and interface. RichOrElse (Ritchie Buitre)
09:07 AM Feature #15306: Generate prelude.c using miniruby
In this specific case, I am concerned about the possibility of patching Ruby, specifically #8566.
It is, unfortunately, a bit more complex with the bootstrapping. Ideally, the content of tarball should be the same as the content of th...
vo.x (Vit Ondruch)
12:22 AM Feature #15306: Generate prelude.c using miniruby
On Thu, Nov 15, 2018 at 7:10 PM Eric Wong <normalperson@yhbt.net> wrote:
> > I don't see any reason why prelude.c should be included in
> > source tarball
>
> I agree with this part, BASERUBY is already a build requirement
> of Rub...
shyouhei (Shyouhei Urabe)
09:04 AM Revision ffd9a7ea (git): pack.c: cast from double to float can be undefined
Generally speaking, a value of double is not always representable
when demoted to a float. ISO C defines what to do when such
conversion loses precision, but leaves it undefined when the
value is completely out of range. (cf: ISO/IEC 989...
shyouhei (Shyouhei Urabe)
07:08 AM Revision 3c7852f8 (git): common.mk: hack to export symbols for MJIT in ruby.imp
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65767 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
06:52 AM Revision e2074a35 (git): test/excludes/_wercker: remove obsoleted pipeline name
from excludes directory names. test-mjit-wait / test-mjit are combined
and distributed as mjit-test1 and mjit-test2 now.
So the subdirectory names are changed to option names, --jit and --jit-wait.
git-svn-id: svn+ssh://ci.ruby-lang.or...
k0kubun (Takashi Kokubun)
06:52 AM Revision fe7773b9 (git): common.mk: fix the pattern to be hidden
* common.mk (ruby.imp): consider symbol prefix, remove InitVM, and
fix internal symbols start with a dot.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65765 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
06:52 AM Revision 34cc6fef (git): Make some internal functions static
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65764 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
06:51 AM Revision 429245aa (git): Prefix rb_ec_set_vm_stack
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65763 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
06:47 AM Revision f98e323e (git): appveyor.yml: skip reverting comment improvement [ci skip]
This part was not intended in r65760
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65762 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
k0kubun (Takashi Kokubun)
06:45 AM Revision 4686869f (git): * properties.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65761 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
06:45 AM Revision c2ed1ede (git): appveyor.yml: give up running test_push_over_ary_max
because separately running it without -j didn't work.
Revert "appveyor.yml: run memory-exchausting test separately"
This reverts commit r65703.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65760 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
k0kubun (Takashi Kokubun)
04:32 AM Revision 1d66574a (git): [DOC] mention class method `new` [ci skip]
* NEWS: mention `new` class methods, instead of `initialize`
insetance methods whic are not called by users directly.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65759 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
04:25 AM Revision cb153527 (git): [doc] Fix grammar typo in Pty_init() docstring [ci skip]
[Fix GH-2014]
From: Olle Jonsson <olle.jonsson@gmail.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65758 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
k0kubun (Takashi Kokubun)
04:21 AM Revision b90bac32 (git): Test for undef'ed method in class hierachy
This probably should have been `#bar` on the instance of class `Undef2` all along
[Fix GH-2015]
From: Alex Snaps <alex.snaps@gmail.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65757 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
k0kubun (Takashi Kokubun)
04:05 AM Revision a9723e96 (git): numeric.c: avoid division by zero
Forgot to add in r65751.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65756 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
shyouhei (Shyouhei Urabe)
03:34 AM Revision 73549c50 (git): bignum.c: fix bug in big2dbl()
I was wrong at r65753.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65755 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
shyouhei (Shyouhei Urabe)
03:09 AM Revision 1a84c57e (git): bignum.c: avoid (size_t)--
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65754 b2dd03c8-39d4-4d8f-98ff-823fe69b080e shyouhei (Shyouhei Urabe)
02:59 AM Revision ca149140 (git): bignum.c: BDIGIT might or might not integer-promote
BDIGIT can be unsigned int or unsigned short, depending on BDIGIT_DBL.
Given that, unsigned int and unsigned short are different in how
integer promotion works. BOGLO assumes its argument is wider than
BDIGIT, which is not always true. ...
shyouhei (Shyouhei Urabe)
02:43 AM Bug #15130: Nested Timeouts hang on cygwin
Ping again on https://bugs.ruby-lang.org/issues/15130

> This 3rd patch goes on top of the previous two:
>
> https://80x24.org/spew/20181015223141.18303-1-e@80x24.org/raw
>
> The 3 patch series should be:
>
> thread_p...
normalperson (Eric Wong)
02:34 AM Revision 6732423b (git): enc/unicode.c: 'a' is bigger than 'A'
In ASCII, 'a' is bigger than 'A'. Which means 'A' - 'a' is a negative
number (-32, to be precise). In C, the type of 'a' and 'A' are signed
int (cf: ISO/IEC 9899:1990 section 6.1.3.4). So 'A' - 'a' is also a
signed int. It is `(signed in...
shyouhei (Shyouhei Urabe)
02:30 AM Bug #15310 (Open): [PATCH] thread_pthread.c: close race from UBF_TIMER and non-GVL-releasing thread
thread_pthread.c: close race from UBF_TIMER and non-GVL-releasing thread
A Ruby thread may run without releasing the GVL if there is no
contention. And there may be no contention because another
thread missed its wakeup and needs t...
normalperson (Eric Wong)
01:56 AM Bug #15309: ECB is broken

test encrypt :
FAILED!
test decrypt :
OK!
sevk (kk kk)
01:55 AM Bug #15309 (Closed): ECB is broken
~~~ ruby
#!/usr/bin/env ruby
require 'openssl'
# AES-128 ECB mode test vectors
KEY = ["2b7e151628aed2a6abf7158809cf4f3c"].pack("H*")
PLAINTEXT = ["6b...
sevk (kk kk)
01:52 AM Revision 3a083985 (git): avoid division by zero
* cvt(): use signbit() instead of 1/d < 0
* w_float(): ditto
* ruby_float_step_size(): unit==0 check shall be prior to divisions
* arith_seq_float_step_size(): ditto
* rb_big_divide(): same as r65642
* fix_divide(): ditto
* rb_big_fdiv_d...
shyouhei (Shyouhei Urabe)
12:37 AM Revision a3b92a5d (git): rbinstall.rb: do not install rdoc flag files [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65750 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
12:28 AM Revision 9b38ed53 (git): bignum.c: suppress unused variable warning
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65749 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
12:25 AM Revision 027cf467 (git): pack.c: refine warning
* pack.c (unknown_directive): refine warning message at unknown
directive in unpack too, and quote unprintable characters.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65748 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
12:25 AM Revision 6a6d0379 (git): pack.c: adjust indent [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65747 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)

11/15/2018

11:04 PM Feature #15305: [PATCH] include/ruby/ruby.h (RB_ALLOCV*): remove GC guard
nobu@ruby-lang.org wrote:
> https://bugs.ruby-lang.org/issues/15305#change-74878

> LGTM.
> It might be a result by trial&error.

OK, r65744

Any comment about the atomics in rb_free_tmp_buffer? Thanks.

> I also don't get th...
normalperson (Eric Wong)
12:44 PM Feature #15305: [PATCH] include/ruby/ruby.h (RB_ALLOCV*): remove GC guard
LGTM.
It might be a result by trial&error.
nobu (Nobuyoshi Nakada)
09:46 AM Feature #15305 (Assigned): [PATCH] include/ruby/ruby.h (RB_ALLOCV*): remove GC guard
include/ruby/ruby.h (RB_ALLOCV*): remove unnecessary GC guard
At least I'm not seeing how it's necessary, as it defeats
optimization at allocation time (instead of protecting the
VALUE from being GC-ed)
Anyways, there's a measura...
normalperson (Eric Wong)
10:28 PM Revision ecb959bd (git): * 2018-11-16
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65746 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
10:28 PM Revision 9c8119e7 (git): * expand tabs.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65745 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
10:28 PM Revision 51aaf74b (git): include/ruby/ruby.h (RB_ALLOCV*): remove unnecessary GC guard
text data bss dec hex filename
3535061 21232 72944 3629237 3760b5 ruby.before
3534141 21232 72944 3628317 375d1d ruby.after
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65744 b2dd03c8...
Eric Wong
09:17 PM Feature #15144 (Assigned): Enumerator#chain
I'm working on this and the implementation of Enumerator#+(enum) and Enumerator#chain(*enums) is about to complete.
Matz, what do you think about the name "chain"? Python has [chain()](https://docs.python.org/3/library/itertools.html...
knu (Akinori MUSHA)
08:15 PM Feature #14038: Use rb_execution_context_t instead of rb_thread_t to represent execution context
FWIW, this changed seems to cause SegFaults on a regular basis on OS X
https://bugs.ruby-lang.org/issues/14714
https://bugs.ruby-lang.org/issues/14561
https://bugs.ruby-lang.org/issues/15308
https://bugs.ruby-lang.org/issues/14334
aselder (Andrew Selder)
05:37 PM Bug #14714: Ruby 2.5.1 Segmentation Fault in GC
I'm also running into this same SegFault while running a Rails app (https://bugs.ruby-lang.org/issues/15308).
Same symptoms, Mac OS X, and segfault in rb_execution_context_mark()
aselder (Andrew Selder)
04:56 PM Bug #15308 (Closed): SegFault in GC under Ruby 2.5.3 on OS X
We recently upgraded our rails app from Ruby 2.4.5 to Ruby 2.5.3 and we started getting SegFaults in random places on our developer machines, all OS x. It doesn't appear to be affecting our production environment which is Linux based.
...
aselder (Andrew Selder)
12:37 PM Bug #15304 (Third Party's Issue): Package build with extensions is not reproducible
Why are such files packaged? nobu (Nobuyoshi Nakada)
08:16 AM Bug #15304 (Third Party's Issue): Package build with extensions is not reproducible
The build of a package with extensions, such as msgpack, is not reproducible due to temporary filenames appearing in the generated Makefile [1]:
```
grep gem lib/ruby/gems/2.5.0/gems/msgpack-1.2.4/ext/msgpack/Makefile
sitearchdir = ...
lewo (lewo lewo)
12:37 PM Bug #15307: TestJIT#test_{catching_deep_exception,compile_insn_throw,lambda_longjmp} segfaults with gcc-8 -fcf-protection
> BTW output the code with some markup 1 is a nice idea, but apparently,
> ...
Redmine can be a bit annoying. In that case it may have been possible
to perhaps write the initial code with proper indent, and add the
tests in a reply t...
shevegen (Robert A. Heiler)
11:24 AM Bug #15307: TestJIT#test_{catching_deep_exception,compile_insn_throw,lambda_longjmp} segfaults with gcc-8 -fcf-protection
The hardening options come from:
https://src.fedoraproject.org/rpms/redhat-rpm-config/blob/master/f/redhat-annobin-cc1
https://src.fedoraproject.org/rpms/redhat-rpm-config/blob/master/f/redhat-hardened-cc1
https://src.fedoraproject....
vo.x (Vit Ondruch)
11:16 AM Bug #15307: TestJIT#test_{catching_deep_exception,compile_insn_throw,lambda_longjmp} segfaults with gcc-8 -fcf-protection
BTW output the code with some markup [1] is a nice idea, but apparently, it does the attached output unreadable in Redmine :/ Therefore please check the ruby-core:89812 if the output is not readable for you.
[1]: https://github.com/ru...
vo.x (Vit Ondruch)
11:06 AM Bug #15307 (Closed): TestJIT#test_{catching_deep_exception,compile_insn_throw,lambda_longjmp} segfaults with gcc-8 -fcf-protection
~~~
1) Failure:
TestJIT#test_catching_deep_exception [/builddir/build/BUILD/ruby-2.6.0-preview3/test/ruby/test_jit.rb:654]:
Failed to run script with JIT:
```
def catch_true(paths, prefixes) # catch_except_p: TRUE
prefixes.ea...
vo.x (Vit Ondruch)
10:58 AM Feature #13581: Syntax sugar for method reference
> I like solutions for real problems, not imaginary.
The `map(&method(:local_method))` or `yield_self(&method(:local_method))` pattern is absolutely real and very useful. My point was, we have plenty in our current codebase (and no, t...
zverok (Victor Shepelev)
10:26 AM Feature #13581: Syntax sugar for method reference
zverok (Victor Shepelev) wrote:
> > Just an opinion
> ...
I just try to use good (existing) sides of a language. Ruby already has nice `Symbol#to_proc` syntax. And yes, different "syntax sugars" allow to use different design approaches...
AlexWayfer (Alexander Popov)
10:09 AM Feature #13581: Syntax sugar for method reference
> Just an opinion
It is funny how when you show some imaginary code, quick-written just to illustrate the point of a language feature, people tend to discuss this code's design approaches instead.
Yes, obviously, in the situation ...
zverok (Victor Shepelev)
10:02 AM Feature #13581: Syntax sugar for method reference
zverok (Victor Shepelev) wrote:
> @nobu
> ...
Just an opinion:
```ruby
processed =
some_input
.compact
.map { |element| ProcessingItem.new(element) } # or `.map(&ProcessingItem.method(:new))`
.reject(&:spoiled?)
...
AlexWayfer (Alexander Popov)
08:42 AM Feature #13581: Syntax sugar for method reference
@nobu
> If `.:` will be introduced, I think it should obey that syntax too, and allowing it without the receiver feels confusing.
Can you please show some example of confusing statements? I can't think of any from the top of my hea...
zverok (Victor Shepelev)
01:50 AM Feature #13581: Syntax sugar for method reference
zverok (Victor Shepelev) wrote:
> Am I correct that receiver-less call, like `something.map(&.:puts)`, will be impossible?
To allow that, `.:puts` should be a sole expression by itself.
However ruby has the line continuation for “fl...
nobu (Nobuyoshi Nakada)
10:12 AM Feature #15306: Generate prelude.c using miniruby
v.ondruch@tiscali.cz wrote:
> https://bugs.ruby-lang.org/issues/15306

> I don't see any reason why prelude.c should be included in
> source tarball

I agree with this part, BASERUBY is already a build requirement
of Ruby and mak...
normalperson (Eric Wong)
09:56 AM Feature #15306 (Closed): Generate prelude.c using miniruby
I don't see any reason why prelude.c should be included in source tarball and why it should not be generated by miniruby. Please see the attached patch.
Please note this is a clone of #10554, which was closed just because it was old, ...
vo.x (Vit Ondruch)
09:03 AM Revision 06e2873e (git): eval_error.c: log10(0) is ERANGE
By definition, the logarithm of 0 is negative infinity. This is a
pole error (cf: cf: ISO/IEC 9899:1999 section 7.12.1 paragraph 3) and
of course, cannot fit into an `int` value. We have to resort to
INT_MIN.
git-svn-id: svn+ssh://ci...
shyouhei (Shyouhei Urabe)
08:33 AM Revision b7f5c573 (git): .travis.yml: give up mac universal binary [ci skip]
OK, nobody is actively willing to maintain this configuration. Just
stop annoying people by build failures. See:
https://travis-ci.org/ruby/ruby/jobs/455377387
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65742 b2dd03c8-39d4-4d8...
shyouhei (Shyouhei Urabe)
07:37 AM Revision abf72810 (git): .travis.yml: -j3 [ci skip]
Now that ccache is enabled. Compilations are made IO heavy, not CPU
bound. This means parallel jobs beyond CPU count could gain more
speed. From my experiment, I can conclude the good old "number of
cores plus one" tactics works the b...
shyouhei (Shyouhei Urabe)
07:34 AM Revision 906c8788 (git): * expand tabs.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65740 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
07:34 AM Revision 86d1fc88 (git): suppress integer overflow warnings
* util.c: annotate as NO_SANITIZE
* bignum.c: avoid (size_t)--
* marshal.c: ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65739 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
shyouhei (Shyouhei Urabe)
06:22 AM Revision a4278400 (git): . command in some sh cannot take arguments
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65738 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
06:17 AM Revision f98004c0 (git): hash.c: cast from double to unsigned is undefined
When a negative double is casted into an unsigned type, that operation
is undefined (cf: ISO/IEC 9899:1990 section 6.2.9.3). Recent versions
of C kindly footnotes that "The remaindering operation performed when
a value of integer type i...
shyouhei (Shyouhei Urabe)
05:22 AM Revision ef5eacc0 (git): * properties.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65736 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
05:22 AM Revision 3dac8eda (git): tool/mjit_archflag.sh: separated, too many escapes
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65735 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
05:10 AM Revision 2212c1dc (git): bignum.c: ee should be signed
In C, signed + unsigned of the same size results in unsigned (cf:
ISO/IEC 9899:1990 section 6.2.1.5). However `num` is signed here.
Which means the addition must be done in signed.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@6573...
shyouhei (Shyouhei Urabe)
04:06 AM Bug #14862 (Closed): Time.parse does not handle the time zone
Closed at request of original proposer. duerst (Martin Dürst)
03:45 AM Revision 42d797d8 (git): Revert "Use CC without ccache as MJIT_CC"
because CI failed: https://travis-ci.org/ruby/ruby/builds/455313917
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65733 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
znz (Kazuhiro NISHIYAMA)
03:01 AM Revision ae680303 (git): Use CC without ccache as MJIT_CC
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65732 b2dd03c8-39d4-4d8f-98ff-823fe69b080e znz (Kazuhiro NISHIYAMA)
02:25 AM Revision 7855c23a (git): .travis.yml: enable ccache
Travis has `cache: ccache` feature so let us enable it. Also, because
`config.cache` is generated during the compilation why not cache that
file for a later use. [fix GH-2013]
Caveats:
- When something went wrong, cache entries can b...
shyouhei (Shyouhei Urabe)
02:22 AM Feature #6284: Add composition for procs
pabloh (Pablo Herrero) wrote:
> Is adding composition methods to the `Symbol` class still being considered?
No, I don't think that we consider a `Symbol` object a method.
nobu (Nobuyoshi Nakada)

11/14/2018

10:04 PM Feature #13618: [PATCH] auto fiber schedule for rb_wait_for_single_fd and rb_waitpid
> https://bugs.ruby-lang.org/issues/13618

Should we bother supporting them? AFAIK they're
tricky/surprising for regular Thread and maybe we should stick
to message passing (e.g. SizedQueue)

It would involve moving th->pending_i...
normalperson (Eric Wong)
10:04 PM Bug #595: Fiber ignores ensure clause
> However, I'm also working on making all sleeping functions
> (native_sleep/rb_wait_for_single_fd/rb_thread_fd_select) method
> perform auto-Fiber scheduling.
>
> Unfortunately, that still interacts badly when people use
> regula...
normalperson (Eric Wong)
09:04 PM Revision ebdf9f07 (git): * 2018-11-15
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65730 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
09:04 PM Revision 8945eeda (git): Fix syntax on Binding.irb documentation [ci skip]
There was incorrect backticks (`) instead of plus signs to denote method
references, and a typo.
[Fix GH-2016]
From: Olivier Lacan <hi@olivierlacan.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65729 b2dd03c8-39d4-4d8f-98ff-8...
k0kubun (Takashi Kokubun)
07:13 PM Bug #15303 (Closed): Return tracepoint doesn't fire when tailcall optimization is applied
After a tailcall, the "return" tracepoint event is only fired once. Normally, after a call at the end of a method, the return event is fired twice, once for the callee returning and once for the caller returning.
The following script ou...
alanwu (Alan Wu)
05:33 PM Feature #6284: Add composition for procs
nobu (Nobuyoshi Nakada) wrote:
> I've forgotten to post the patch to use `<<` and `>>`.
> ...
Is adding composition methods to the Symbol class still being considered?
pabloh (Pablo Herrero)
03:21 PM Bug #14738: Failed to load_from_binary on 2.5.1
ruby_2_5 r65728 merged revision(s) 62772. nagachika (Tomoyuki Chikanaga)
03:21 PM Revision b1944e41 (git): merge revision(s) 62772: [Backport #14738]
compile.c: fix load_from_binary
* compile.c (ibf_load_iseq_each): realpath may be nil. follow up
r59709. [fix https://github.com/Shopify/bootsnap/issues/132]
From: nobu <nobu@b2dd03c8-39d4-4d8f-98ff-823fe69b...
nagachika (Tomoyuki Chikanaga)
02:46 PM Feature #13581: Syntax sugar for method reference
I think `.:` is better than `:::` but it is not very pretty either. I have
no better suggestion, though. Good syntax is not easy to use. :(
I agree with the functionality by the way.
shevegen (Robert A. Heiler)
02:12 PM Revision ed778c2a (git): rational.c (nurat_div): use the dedicated function nurat_to_f
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65727 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
12:25 PM Bug #14862: Time.parse does not handle the time zone
okay, it seems like, they should not be the same. Thank you very much - we figured it out. I think we can close this one.
Thanks for your time.
mifrill (Aleksey Strizhak)
09:53 AM Revision 33758ded (git): * expand tabs.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65726 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
09:53 AM Revision a6e88715 (git): numeric.c: avoid division by zero
same as r65642.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65725 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
shyouhei (Shyouhei Urabe)
08:30 AM Feature #15301: Symbol#call, returning method bound with arguments

> What I personally found with method_missing is that it can become very confusing.
My proposal have absolutely nothing to do with `method_missing`.
> ...
It is not, it is standard Ruby feature since Ruby 1.9, AFAIK (everything t...
zverok (Victor Shepelev)
06:07 AM Feature #15301: Symbol#call, returning method bound with arguments
shevegen (Robert A. Heiler) wrote:
> [[1, -2], [-3, -4]].map(&:map.(&:abs)) # => [[1, 2], [3, 4]]
> ...
You probably misunderstood what the example is doing. `map` is not repeated per say here. You can replace the first one by `fla...
marcandre (Marc-Andre Lafortune)
08:21 AM Revision ed42b010 (git): test_ftp.rb: loosen another timeout requirement
for Travis osx.
https://travis-ci.org/ruby/ruby/jobs/454864155
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65724 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
k0kubun (Takashi Kokubun)
07:44 AM Revision 2a477e0e (git): test_ftp.rb: loosen timeout for Travis osx
https://travis-ci.org/ruby/ruby/jobs/454798071
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65723 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
k0kubun (Takashi Kokubun)
07:38 AM Revision 158562da (git): test_gem_stream_ui.rb: loosen timeout for --jit-wait
https://app.wercker.com/ruby/ruby/runs/mjit-test2/5beba9be183106002852f8a6?step=5bebc1a087436a0006f94a22
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65722 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
k0kubun (Takashi Kokubun)
06:56 AM Feature #15302 (Open): Proc#with and Proc#by, for partial function application and currying
**Proc#by** allows currying implicitly
~~~ ruby
class Proc
def by(*head)
return self if head.none?
curry(head.size.next).(*head)
end
end
class Method
def by(*head)
to_proc.by(*head)
end
end
class Sym...
RichOrElse (Ritchie Buitre)
04:50 AM Revision c2ef40d2 (git): .travis.yml: specify git -q
We are not interested in git(1) output.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65721 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
shyouhei (Shyouhei Urabe)
04:42 AM Revision f34e8ff6 (git): Add RbConfig.fire_update!
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65720 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
04:34 AM Misc #15129 (Closed): DevelopersMeeting20181010Japan
hsbt (Hiroshi SHIBATA)
04:34 AM Misc #14981 (Closed): DevelopersMeeting20180913Japan
hsbt (Hiroshi SHIBATA)
04:34 AM Misc #14921 (Closed): DevelopersMeeting20180809Japan
hsbt (Hiroshi SHIBATA)
03:52 AM Revision 7a823be8 (git): * expand tabs.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65719 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
03:52 AM Revision cc07dc7c (git): thread.c (rb_thread_fd_select): favor rb_thread_* when no FDs
select() is a crap API for even sleeping on sigwait_fd, so favor
the native_sleep-based functions when there are no FDs, instead.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65718 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Eric Wong
02:27 AM Revision cb592b37 (git): defs/known_errors.def: update on macOS Mojave Xcode 10.1
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65717 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
02:27 AM Revision 2c989a6f (git): Makefile.in: update-known-errors
* Makefile.in (update-known-errors): update defs/known_errors.def
by using errno(1).
* defs/known_errors.def: sort alphabetically for merger.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65716 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
12:43 AM Revision eea3536e (git): .travis.yml: add empty lines for readability [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65715 b2dd03c8-39d4-4d8f-98ff-823fe69b080e shyouhei (Shyouhei Urabe)

11/13/2018

11:06 PM Revision 6716bca6 (git): * properties.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65714 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
11:06 PM Revision 3bd8eb68 (git): test/excludes/../TestWEBrickUtils.rb: exclude unstable test
for now. This seems to get unstable after r65691.
test/excludes/_travis/osx: renamed from test/excludes/_travis because
it's only for osx builds.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65713 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
k0kubun (Takashi Kokubun)
09:36 PM Revision 6876140d (git): * 2018-11-14
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65712 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
09:36 PM Revision 1ec3039a (git): .travis.yml: stop allowing osx failure
it seems to be more stable than the timing we upgraded travis image.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65711 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
k0kubun (Takashi Kokubun)
08:21 PM Misc #15229: DevelopersMeeting20181122Japan
* [Feature #15301] `Symbol#call`, returning method bound with arguments zverok (Victor Shepelev)
03:28 PM Feature #15301: Symbol#call, returning method bound with arguments
> I understand and respect core team's reluctance for adding new methods to core classes
Ultimately it is up to matz, but I believe it is not so much reluctance, but more the
general question "will this be of benefit to many people"....
shevegen (Robert A. Heiler)
02:42 PM Feature #15301: Symbol#call, returning method bound with arguments
@Hanmac yeah, I myself invented and discarded several generations of similar things throughout my carreer.
But without too much of "going meta" (like hard-to-debug and guess "where it is from" `method_missing` tricks), I believe my su...
zverok (Victor Shepelev)
02:10 PM Feature #15301: Symbol#call, returning method bound with arguments
I once had a similar script (> 3 years old), but i extened it to be chainable
~~~ ruby
class Symbol
class SymbolHelper
def initialize(obj,methId,*args)
@obj= obj
@args=args
@methId=methId
end
...
Hanmac (Hans Mackowiak)
01:43 PM Feature #15301 (Closed): Symbol#call, returning method bound with arguments
In one Reddit discussion I've got stuck with this simple, yet seemingly powerful idea, not sure if it was discussed anytime previously (can't find on the bug tracker, but maybe I am just bad at searching):
```ruby
class Symbol
def...
zverok (Victor Shepelev)
02:56 PM Revision 27f4058f (git): Makefile.in: `$` for shell needs to be escaped in Makefile
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65710 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
02:39 PM Bug #15244: Method #extname return empty string if filename is dot ('.')
This is still present. TiSer (Sergey Ti)
02:35 PM Revision b93023f8 (git): Remove duplicated assignment
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65709 b2dd03c8-39d4-4d8f-98ff-823fe69b080e znz (Kazuhiro NISHIYAMA)
12:39 PM Bug #15300 (Closed): rb_frame_method_id_and_class deprecated in 2.6
Coming from [jasonroelofs/rice#105](https://github.com/jasonroelofs/rice/issues/105), related to #14192.
As far as I understand, this API has been deprecated, thus Rice won't compile anymore.
~~~
detail/method_data.cpp:19:48: erro...
paddor (Patrik Wenger)
11:23 AM Feature #12698: Method to delete a substring by regex match
matz (Yukihiro Matsumoto) wrote:
> I don't think it's worth adding which is easily done by `sub/gsub`.
Easily done, yes, but Ruby being a very expressive language, the following two are not equally readable:
* `"foo test bar".gsub...
svoop (Sven Schwyn)
09:39 AM Bug #15299 (Closed): hash.c: warning: ‘bin’ may be used uninitialized in this function
When compiling the latest version of trunk, I get some warnings in hash.c, as follows:
```
compiling hash.c
hash.c: In function ‘linear_update’:
hash.c:849:24: warning: ‘bin’ may be used uninitialized in this function [-Wmaybe-unin...
duerst (Martin Dürst)
07:19 AM Revision 59f1a69a (git): .travis.tml: reintroduce exclusions for osx
Sorry, seen the failures again. Was a wrong idea to delete
the --exclude.
See https://travis-ci.org/ruby/ruby/jobs/454329443#L2233
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65708 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
shyouhei (Shyouhei Urabe)
07:17 AM Revision b5b19a7c (git): .travis.yml: eliminate remaining --color=never [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65707 b2dd03c8-39d4-4d8f-98ff-823fe69b080e shyouhei (Shyouhei Urabe)
06:20 AM Revision dde0e30c (git): Pathname: Have #relative_path_from accept String argument.
[Fix GH-1975]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65706 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Marc-Andre Lafortune
06:17 AM Revision 5ad8e42b (git): test_function.rb: loosen delta boundary
On osx build https://travis-ci.org/ruby/ruby/jobs/454309945,
```
1) Failure:
Fiddle::TestFunction#test_nogvl_poll [/Users/travis/build/ruby/ruby/test/fiddle/test_function.rb:95]:
slept amount of time.
Expected |200 - 322| (122) to be <=...
k0kubun (Takashi Kokubun)
06:16 AM Revision c878cf50 (git): Moved REVISION_FORCE before uncommon.mk
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65704 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
05:46 AM Revision 5f376ce0 (git): appveyor.yml: run memory-exchausting test separately
r65690 had no impact
https://ci.appveyor.com/project/ruby/ruby/builds/20253561/job/p5u235m8xx85t9o5.
Gave up to solve the issue inside the test.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65703 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
k0kubun (Takashi Kokubun)
04:55 AM Revision 3b257773 (git): .travis.yml: specify --tty=no
To reduce the amount of output, prefer --tty=no instead of
--color=never. This option not only disables color output but also
kill some tty-related features, like spinners. Travis limits its
output by the physical size of the log, not ...
shyouhei (Shyouhei Urabe)
04:51 AM Revision 3d5be5f8 (git): date_core.c: use static ID variables
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65701 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
04:33 AM Revision 598a4bfb (git): .travis.yml: delete test-all options for osx
While we are experiencing build failures, no hangs had been
seen for a while. Also it seems the excluded tests now pass.
I think it's time to delete this line.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65700 b2dd03c8-39d4-4d8f...
shyouhei (Shyouhei Urabe)
04:29 AM Revision 93f91eb6 (git): date_core.c: obey to the allocation framework
* ext/date/date_core.c (date_initialize): separate from
date_s_civil and obey the allocation framework.
* ext/date/date_core.c (datetime_initialize): ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65699 b2dd03c8-39d4-4d8f-9...
nobu (Nobuyoshi Nakada)
04:29 AM Revision 0fa71d44 (git): date_core.c: respect COMPLEX_DAT bit
* ext/date/date_core.c (d_lite_marshal_load): respect COMPLEX_DAT
bit in the pre-allocated structure.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65698 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
04:29 AM Revision 8655d073 (git): date_core.c: keep COMPLEX_DAT bit
* ext/date/date_core.c (d_lite_initialize_copy): do not change
COMPLEX_DAT bit, as the structure does not change. initialize
member-wise instead.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65697 b2dd03c8-39d4-4d8f-98ff-823fe...
nobu (Nobuyoshi Nakada)
04:29 AM Revision 53ad55e4 (git): date_core.c: set/reset COMPLEX_DAT
* ext/date/date_core.c (set_to_simple, set_to_complex): always
set/reset COMPLEX_DAT bit, which is very tightly bound to the
structure.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65696 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
03:24 AM Revision 45295303 (git): gmake.mk: force updating revision.h
Since `.revision.time` recipe needs `$(BASERUBY)`, it should not
try to get updated unconditionally, or tarballs fail to build on
environments where BASERUBY is not available.
All developers who build frequently use GNU make anyway, don...
nobu (Nobuyoshi Nakada)
02:58 AM Revision bad98efe (git): .travis.yml: allow osx failures [experimental]
Tests are failing due to network timeouts. Temporary allow failrues for them.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65694 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
shyouhei (Shyouhei Urabe)
02:19 AM Revision 9d9e1a4d (git): addr2line.c: more on suppressing warnings
See also: https://travis-ci.org/ruby/ruby/jobs/454269559#L1898
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65693 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
shyouhei (Shyouhei Urabe)
02:06 AM Revision ceab9f36 (git): common.mk: force updating revision.h on each commit
by making .revision.time PHONY. Prior to this commit, RUBY_DESCRIPTION
has been updated only when version.h (or tool/file2lastrev.rb) is updated.
.revision.time (REVISION_H) target internally has IFCHANGE to update
revision.h. So it doe...
k0kubun (Takashi Kokubun)
02:03 AM Revision 48fe4012 (git): .travis.yml: update VM images
xeinal for Linux and xcode 10.1 for osx. Also deleted few outdated
lines that are no longer necessary.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65691 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
shyouhei (Shyouhei Urabe)
01:35 AM Revision 601f4b6f (git): test_array.rb: try to avoid NoMemoryError on AppVeyor
We somehow hit NoMemoryError twice on that place.
https://ci.appveyor.com/project/ruby/ruby/builds/20224556/job/hlgt963e0cgjbj3c
https://ci.appveyor.com/project/ruby/ruby/builds/20250696/job/gm559bu2jbd6youm
Let me try firing GC here.
...
k0kubun (Takashi Kokubun)
12:40 AM Revision 2a70978d (git): * 2018-11-13
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65689 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
12:40 AM Revision 7f6691ae (git): suppress integer overflow warnings
* random.c: annotate rb_hash_start with NO_SANITIZE (seed.key.hash + h
overflows and that seems intentional)
* bignum.c: avoid (size_t)--
* cont.c: ditto
* util.c: ditto
* vm_insnhelper.c: ditto
git-svn-id: svn+ssh://ci.ruby-lang.or...
shyouhei (Shyouhei Urabe)
 

Also available in: Atom