Activity
From 11/12/2018 to 11/18/2018
11/18/2018
- 11:29 PM Revision becdfee6 (git): * 2018-11-19
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65793 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
11:29 PM Revision 9cbfb177 (git): Also clean ruby-runner.o and ruby.imp [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65792 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * tool/update-deps (init_global): environment strings are frozen.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65791 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:32 PM Revision 524e4cc9 (git): mjit.c: fix deadlock introduced by r65785
- in mjit_pause() fired by before_fork_ruby(). When calling
RUBY_VM_CHECK_INTS() in mjit_pause()'s loop, other threads may call
start_worker() which sets `stop_worker_p = FALSE` and it could wait for
MJIT worker stop forever even while `st... -
10:43 AM Feature #15317: How to deal with obsolete property values in Unicode 11.0.0
- Could a warning be issued as well, at the least for a transition period?
On a side note, does anyone happen to know how perl5/perl6 and python handle
these situations? Perhaps if what they do makes sense, we could have a
consistent... -
09:35 AM Feature #15317 (Closed): How to deal with obsolete property values in Unicode 11.0.0
- http://www.unicode.org/versions/Unicode11.0.0/#Migration contains the following:
> Four Grapheme_Cluster_Break and Word_Break classes have become obsolete and are no longer used: E_Base, E_Modifier, Glue_After_Zwj, and E_Base_GAZ. Tho... -
10:26 AM Bug #15318 (Rejected): net/imap socket backward compatibility broken in ruby 2.5+
- Hi,
I use net/pop and net/imap libraries and sometimes I need my pop/imap connections to be socksified or proxified (through TCPSocket initialize method modifications: https://github.com/Shopify/socksify-ruby). Upgrading to ruby 2.5.3 f... -
- Some test seems to hang
https://app.wercker.com/ruby/ruby/runs/mjit-test1/5bf1221c183106002855989c?step=5bf1225987436a0006192c31
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65789 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- for interleaving between processes
https://gist.github.com/ko1/ace0374825377b41628d4590b7377601
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65788 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- debugging
http://ci.rvm.jp/results/trunk-vm-asserts@silicon-docker/1466123
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65787 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- > OK, please do.
Done, in r65785. Comments from your point of view would be much appreciated.
> ...
looks fine.
> Somewhat related. We need to ensure a consistent state of the queue (either postponed_job or workqueue).
In a s... -
08:22 AM Bug #15316: rb_postponed_job_register not thread-safe
- takashikkbn@gmail.com wrote:
> Oh by the way, I have a patch which was created yesterday but
> I was too busy to commit that yet. (I'll commit that shortly.)
OK, please do.
I am also testing a minor cleanup:
https://80x24.org/s... -
- Thanks to report that.
> My goal is also to support MJIT in forked processes
Oh by the way, I have a patch which was created yesterday but I was too busy to commit that yet. (I'll commit that shortly.)
I think thread-safety of p... -
- > https://bugs.ruby-lang.org/issues/15316
> So it looks like we need a THREAD-SAFE (not necessarily async-safe)
> version of rb_postponed_job_register. Or a one-off API for MJIT...
> job registration for MJIT.
I think I will in... -
- Consider following execution timeline for two threads, t1 and t2.
(should be 2 columns, I only have fixed-width fonts for display)
```
t1 t2 (mjit-worker)
-----------------------------------------... - 08:25 AM Revision 57efe84b (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65786 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- by launching MJIT worker thread in child Ruby process.
See the comment before `mjit_child_after_fork` for details.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65785 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65784 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65783 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- we don't have such VM register
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65782 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- mame@ruby-lang.org wrote:
> https://bugs.ruby-lang.org/issues/15229
[Bug #14968] make all pipes and sockets non-blocking by default -
05:12 AM Misc #15229: DevelopersMeeting20181122Japan
- * [Feature #15302] Proc#with and Proc#by, for partial function application and currying (Ritchie Buitre)
* Convenient methods for functional programming. - 04:34 AM Revision 644f2013 (git): vm_trace.c (rb_postponed_job_flush): use rb_atomic_t for mask
- ec->interrupt_mask will remain rb_atomic_t and is 32-bit on some
64-bit systems while "unsigned long" is 64-bits. So avoid
mismatching lengths and stick to rb_atomic_t.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65781 b2dd03c8-3... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65780 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:37 AM Revision eb959292 (git): io.c: include vm_core.h for VM_UNREACHABLE
- Thanks to Greg L <greg.mpls@gmail.com> for the report
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65779 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 01:37 AM Revision 0cdd4596 (git): * 2018-11-18
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65778 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 01:37 AM Revision b5bb5ed0 (git): io.c (novl_wait_for_single_fd): VM_UNREACHABLE instead of assert
- This respects VM_CHECK_MODE and is more consistent with
the rest of our code.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65777 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 01:37 AM Revision e4c9a70c (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65776 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 01:37 AM Revision 9a8b75a7 (git): vm_core.h (rb_thread_set_current*): convert to static inline
- We already use "static inline" heavily and there should be no
penalty for modern compilers; this adds type-checking, too.
This will make future changes easier-to-review.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65775 b2dd03c8-... -
- ec_switch and thread switching may still lose interrupts
trap interrupt is OK because of r64062
Not OK:
1) postponed job interrupt from MJIT worker
This is trickiest to solve because it also affects thread switching,
not...
11/17/2018
-
- shevegen (Robert A. Heiler) wrote:
> I am not sure if the API seems ok. I am also not sure if matz
> ...
Thank you for taking the time to review my proposal and for the suggestions.
To illustrate more clearly how **`Symbol#with`** wor... -
- I am not sure if the API seems ok. I am also not sure if matz
wants to have `Symbol`s have methods such as `.with()`. For example,
to me personally it is not entirely clear why "with 2" would
be equal to "n * 2" as such.
I am also... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65774 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- You can write rational numbers by `r` suffix.
```ruby
p 0.1r + 0.2r #=> (3/10)
```
As I found these literals (`r` and `i`) have not been mentioned in `doc/syntax/`, added them now (r65773). -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65773 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
11/16/2018
- 11:27 PM Revision 9d6968f1 (git): * 2018-11-17
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65772 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 11:27 PM Revision 0a10c46d (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65771 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
11:27 PM Revision 3ec3d7d9 (git): Switch to 2-0-stable branch of bundler/bundler repository from our fork repository.
- https://github.com/bundler/bundler/tree/2-0-stable
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65770 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
-
10:34 PM Bug #15314 (Closed): Bundler with 2.6 fails when installing dependencies into a --path with --binstubs
- When using Ruby 2.6 and installing gems via bundler's `--path` option, there is an exception:
~~~ text
$ ruby -v
ruby 2.6.0preview3 (2018-11-06 trunk 65578) [x86_64-darwin17]
$ rails -v
Rails 5.2.1
$ rails new myapp-2-6
$ cd mya... -
08:10 PM Bug #15313 (Closed): [PATCH] Let debuggers know when a tail call happens
- ## Background
The popular debugger "byebug" relies on tracepoint events to implement a few core functionality such as "next".
The "next" command needs to pause execution when the VM reaches the next line on the same stack frame. As the... -
06:37 PM Bug #15312 (Rejected): Ruby gives me wrong result for plus operation
- See also https://0.30000000000000004.com/
-
06:34 PM Bug #15312: Ruby gives me wrong result for plus operation - This is not a bug, that's how floating point arithmetic works in accordance with the IEEE 754 standard.
You can read more about that on Wikipedia or in this article: https://docs.oracle.com/cd/E19957-01/806-3568/ncg_goldberg.html
T... -
05:43 PM Bug #15312 (Rejected): Ruby gives me wrong result for plus operation
- Run into this weird issue today. Tried that on rubies 2.5.1p57 and ruby 2.5.3p105 (i believe this is latest stable at the moment).
Here is how to reproduce it
```
$ irb
2.5.3 :001 > 2.6 + 0.1
=> 2.7
2.5.3 :002 > 2.7 + 0.1
=... -
05:21 PM Bug #15307: TestJIT#test_{catching_deep_exception,compile_insn_throw,lambda_longjmp} segfaults with gcc-8 -fcf-protection
- Actually here is the documentation of build flags:
https://src.fedoraproject.org/rpms/redhat-rpm-config/blob/master/f/buildflags.md -
- k0kubun (Takashi Kokubun) wrote:
> I'm not so familiar with redhat-hardened things. I have some questions:
> ...
It is the default and mandatory settings for the build of all packages on Fedora/RHEL. The last hardening changes were pr... -
- I'm not so familiar with redhat-hardened things. I have some questions:
* Why are you using the "hardened" options? Is it default on your environment?
* Do these tests succeed if you strip the hardened options on the same environment... -
- Regarding files under `usr/lib/ruby/gems/2.5.0/extensions/x86_64-linux/2.5.0/msgpack-1.2.4/`, I think that rubygems is lazy not to select files properly.
And `./usr/lib/ruby/gems/2.5.0/gems/msgpack-1.2.4/e... -
12:44 PM Bug #15304: Package build with extensions is not reproducible
- nobu (Nobuyoshi Nakada) wrote:
> These (and `page-Makefile.ri`) are all garbages after installation.
Hmm, I'm not sure to understand, because several distributions have these files remaining in the `install-dir` provided to `rubygem`... -
- lewo (lewo lewo) wrote:
> I think the `mkmf.log` should not be written in the `install-dir`. But what about the `Makefile`? Could it be still used after the ruby gem build? If not, it could also be removed from the `install-dir`.
The... -
- nobu (Nobuyoshi Nakada) wrote:
> Why are such files packaged?
These files are written by `gem intall` in the directory specified by the `--install-dir` option. Distributions are taking this whole direcory to create the distribution p... -
- Applied in changeset trunk|r65769.
----------
Makefile.in: test-almost also needs mjit_build_dir.so
[ruby-core:89830] [Bug #15311] -
07:37 AM Bug #15311 (Closed): `make check` causes `warning: No mjit_build_directory`
- `make help` says:
```
check: equals make test test-all test-spec
```
But `make check` does not depend `test-all` acctually, it does not create `mjit_build_dir.so`.
So `make check` outputs many `warning: No mjit... -
- [ruby-core:89830] [Bug #15311]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65769 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I have a related proposal #15302 with a different implementation and interface.
-
- In this specific case, I am concerned about the possibility of patching Ruby, specifically #8566.
It is, unfortunately, a bit more complex with the bootstrapping. Ideally, the content of tarball should be the same as the content of th... -
12:22 AM Feature #15306: Generate prelude.c using miniruby
- On Thu, Nov 15, 2018 at 7:10 PM Eric Wong <normalperson@yhbt.net> wrote:
> > I don't see any reason why prelude.c should be included in
> > source tarball
>
> I agree with this part, BASERUBY is already a build requirement
> of Rub... -
- Generally speaking, a value of double is not always representable
when demoted to a float. ISO C defines what to do when such
conversion loses precision, but leaves it undefined when the
value is completely out of range. (cf: ISO/IEC 989... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65767 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- from excludes directory names. test-mjit-wait / test-mjit are combined
and distributed as mjit-test1 and mjit-test2 now.
So the subdirectory names are changed to option names, --jit and --jit-wait.
git-svn-id: svn+ssh://ci.ruby-lang.or... -
- * common.mk (ruby.imp): consider symbol prefix, remove InitVM, and
fix internal symbols start with a dot.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65765 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65764 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65763 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- This part was not intended in r65760
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65762 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 06:45 AM Revision 4686869f (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65761 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- because separately running it without -j didn't work.
Revert "appveyor.yml: run memory-exchausting test separately"
This reverts commit r65703.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65760 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * NEWS: mention `new` class methods, instead of `initialize`
insetance methods whic are not called by users directly.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65759 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- [Fix GH-2014]
From: Olle Jonsson <olle.jonsson@gmail.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65758 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- This probably should have been `#bar` on the instance of class `Undef2` all along
[Fix GH-2015]
From: Alex Snaps <alex.snaps@gmail.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65757 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Forgot to add in r65751.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65756 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I was wrong at r65753.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65755 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65754 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- BDIGIT can be unsigned int or unsigned short, depending on BDIGIT_DBL.
Given that, unsigned int and unsigned short are different in how
integer promotion works. BOGLO assumes its argument is wider than
BDIGIT, which is not always true. ... -
- Ping again on https://bugs.ruby-lang.org/issues/15130
> This 3rd patch goes on top of the previous two:
>
> https://80x24.org/spew/20181015223141.18303-1-e@80x24.org/raw
>
> The 3 patch series should be:
>
> thread_p... -
- In ASCII, 'a' is bigger than 'A'. Which means 'A' - 'a' is a negative
number (-32, to be precise). In C, the type of 'a' and 'A' are signed
int (cf: ISO/IEC 9899:1990 section 6.1.3.4). So 'A' - 'a' is also a
signed int. It is `(signed in... -
- thread_pthread.c: close race from UBF_TIMER and non-GVL-releasing thread
A Ruby thread may run without releasing the GVL if there is no
contention. And there may be no contention because another
thread missed its wakeup and needs t... -
01:56 AM Bug #15309: ECB is broken
test encrypt :
FAILED!
test decrypt :
OK!
-
- ~~~ ruby
#!/usr/bin/env ruby
require 'openssl'
# AES-128 ECB mode test vectors
KEY = ["2b7e151628aed2a6abf7158809cf4f3c"].pack("H*")
PLAINTEXT = ["6b... -
- * cvt(): use signbit() instead of 1/d < 0
* w_float(): ditto
* ruby_float_step_size(): unit==0 check shall be prior to divisions
* arith_seq_float_step_size(): ditto
* rb_big_divide(): same as r65642
* fix_divide(): ditto
* rb_big_fdiv_d... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65750 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65749 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * pack.c (unknown_directive): refine warning message at unknown
directive in unpack too, and quote unprintable characters.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65748 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65747 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
11/15/2018
-
- nobu@ruby-lang.org wrote:
> https://bugs.ruby-lang.org/issues/15305#change-74878
> LGTM.
> It might be a result by trial&error.
OK, r65744
Any comment about the atomics in rb_free_tmp_buffer? Thanks.
> I also don't get th... -
- LGTM.
It might be a result by trial&error.
-
- include/ruby/ruby.h (RB_ALLOCV*): remove unnecessary GC guard
At least I'm not seeing how it's necessary, as it defeats
optimization at allocation time (instead of protecting the
VALUE from being GC-ed)
Anyways, there's a measura... - 10:28 PM Revision ecb959bd (git): * 2018-11-16
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65746 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:28 PM Revision 9c8119e7 (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65745 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:28 PM Revision 51aaf74b (git): include/ruby/ruby.h (RB_ALLOCV*): remove unnecessary GC guard
- text data bss dec hex filename
3535061 21232 72944 3629237 3760b5 ruby.before
3534141 21232 72944 3628317 375d1d ruby.after
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65744 b2dd03c8... -
09:17 PM Feature #15144 (Assigned): Enumerator#chain
- I'm working on this and the implementation of Enumerator#+(enum) and Enumerator#chain(*enums) is about to complete.
Matz, what do you think about the name "chain"? Python has [chain()](https://docs.python.org/3/library/itertools.html... -
08:15 PM Feature #14038: Use rb_execution_context_t instead of rb_thread_t to represent execution context
- FWIW, this changed seems to cause SegFaults on a regular basis on OS X
https://bugs.ruby-lang.org/issues/14714
https://bugs.ruby-lang.org/issues/14561
https://bugs.ruby-lang.org/issues/15308
https://bugs.ruby-lang.org/issues/14334 -
- I'm also running into this same SegFault while running a Rails app (https://bugs.ruby-lang.org/issues/15308).
Same symptoms, Mac OS X, and segfault in rb_execution_context_mark()
-
- We recently upgraded our rails app from Ruby 2.4.5 to Ruby 2.5.3 and we started getting SegFaults in random places on our developer machines, all OS x. It doesn't appear to be affecting our production environment which is Linux based.
... -
- Why are such files packaged?
-
- The build of a package with extensions, such as msgpack, is not reproducible due to temporary filenames appearing in the generated Makefile [1]:
```
grep gem lib/ruby/gems/2.5.0/gems/msgpack-1.2.4/ext/msgpack/Makefile
sitearchdir = ... -
- > BTW output the code with some markup 1 is a nice idea, but apparently,
> ...
Redmine can be a bit annoying. In that case it may have been possible
to perhaps write the initial code with proper indent, and add the
tests in a reply t... -
- The hardening options come from:
https://src.fedoraproject.org/rpms/redhat-rpm-config/blob/master/f/redhat-annobin-cc1
https://src.fedoraproject.org/rpms/redhat-rpm-config/blob/master/f/redhat-hardened-cc1
https://src.fedoraproject.... -
- BTW output the code with some markup [1] is a nice idea, but apparently, it does the attached output unreadable in Redmine :/ Therefore please check the ruby-core:89812 if the output is not readable for you.
[1]: https://github.com/ru... -
- ~~~
1) Failure:
TestJIT#test_catching_deep_exception [/builddir/build/BUILD/ruby-2.6.0-preview3/test/ruby/test_jit.rb:654]:
Failed to run script with JIT:
```
def catch_true(paths, prefixes) # catch_except_p: TRUE
prefixes.ea... -
10:58 AM Feature #13581: Syntax sugar for method reference
- > I like solutions for real problems, not imaginary.
The `map(&method(:local_method))` or `yield_self(&method(:local_method))` pattern is absolutely real and very useful. My point was, we have plenty in our current codebase (and no, t... -
10:26 AM Feature #13581: Syntax sugar for method reference
- zverok (Victor Shepelev) wrote:
> > Just an opinion
> ...
I just try to use good (existing) sides of a language. Ruby already has nice `Symbol#to_proc` syntax. And yes, different "syntax sugars" allow to use different design approaches... -
- > Just an opinion
It is funny how when you show some imaginary code, quick-written just to illustrate the point of a language feature, people tend to discuss this code's design approaches instead.
Yes, obviously, in the situation ... -
- zverok (Victor Shepelev) wrote:
> @nobu
> ...
Just an opinion:
```ruby
processed =
some_input
.compact
.map { |element| ProcessingItem.new(element) } # or `.map(&ProcessingItem.method(:new))`
.reject(&:spoiled?)
... -
- @nobu
> If `.:` will be introduced, I think it should obey that syntax too, and allowing it without the receiver feels confusing.
Can you please show some example of confusing statements? I can't think of any from the top of my hea... -
- zverok (Victor Shepelev) wrote:
> Am I correct that receiver-less call, like `something.map(&.:puts)`, will be impossible?
To allow that, `.:puts` should be a sole expression by itself.
However ruby has the line continuation for “fl... -
- v.ondruch@tiscali.cz wrote:
> https://bugs.ruby-lang.org/issues/15306
> I don't see any reason why prelude.c should be included in
> source tarball
I agree with this part, BASERUBY is already a build requirement
of Ruby and mak... -
- I don't see any reason why prelude.c should be included in source tarball and why it should not be generated by miniruby. Please see the attached patch.
Please note this is a clone of #10554, which was closed just because it was old, ... -
- By definition, the logarithm of 0 is negative infinity. This is a
pole error (cf: cf: ISO/IEC 9899:1999 section 7.12.1 paragraph 3) and
of course, cannot fit into an `int` value. We have to resort to
INT_MIN.
git-svn-id: svn+ssh://ci... -
- OK, nobody is actively willing to maintain this configuration. Just
stop annoying people by build failures. See:
https://travis-ci.org/ruby/ruby/jobs/455377387
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65742 b2dd03c8-39d4-4d8... -
- Now that ccache is enabled. Compilations are made IO heavy, not CPU
bound. This means parallel jobs beyond CPU count could gain more
speed. From my experiment, I can conclude the good old "number of
cores plus one" tactics works the b... - 07:34 AM Revision 906c8788 (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65740 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * util.c: annotate as NO_SANITIZE
* bignum.c: avoid (size_t)--
* marshal.c: ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65739 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65738 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- When a negative double is casted into an unsigned type, that operation
is undefined (cf: ISO/IEC 9899:1990 section 6.2.9.3). Recent versions
of C kindly footnotes that "The remaindering operation performed when
a value of integer type i... - 05:22 AM Revision ef5eacc0 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65736 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65735 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- In C, signed + unsigned of the same size results in unsigned (cf:
ISO/IEC 9899:1990 section 6.2.1.5). However `num` is signed here.
Which means the addition must be done in signed.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@6573... -
- Closed at request of original proposer.
-
- because CI failed: https://travis-ci.org/ruby/ruby/builds/455313917
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65733 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65732 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Travis has `cache: ccache` feature so let us enable it. Also, because
`config.cache` is generated during the compilation why not cache that
file for a later use. [fix GH-2013]
Caveats:
- When something went wrong, cache entries can b... -
- pabloh (Pablo Herrero) wrote:
> Is adding composition methods to the `Symbol` class still being considered?
No, I don't think that we consider a `Symbol` object a method.
11/14/2018
-
- > https://bugs.ruby-lang.org/issues/13618
Should we bother supporting them? AFAIK they're
tricky/surprising for regular Thread and maybe we should stick
to message passing (e.g. SizedQueue)
It would involve moving th->pending_i... -
- > However, I'm also working on making all sleeping functions
> (native_sleep/rb_wait_for_single_fd/rb_thread_fd_select) method
> perform auto-Fiber scheduling.
>
> Unfortunately, that still interacts badly when people use
> regula... - 09:04 PM Revision ebdf9f07 (git): * 2018-11-15
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65730 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- There was incorrect backticks (`) instead of plus signs to denote method
references, and a typo.
[Fix GH-2016]
From: Olivier Lacan <hi@olivierlacan.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65729 b2dd03c8-39d4-4d8f-98ff-8... -
- After a tailcall, the "return" tracepoint event is only fired once. Normally, after a call at the end of a method, the return event is fired twice, once for the callee returning and once for the caller returning.
The following script ou... -
05:33 PM Feature #6284: Add composition for procs
- nobu (Nobuyoshi Nakada) wrote:
> I've forgotten to post the patch to use `<<` and `>>`.
> ...
Is adding composition methods to the Symbol class still being considered? -
03:21 PM Bug #14738: Failed to load_from_binary on 2.5.1
- ruby_2_5 r65728 merged revision(s) 62772.
-
- compile.c: fix load_from_binary
* compile.c (ibf_load_iseq_each): realpath may be nil. follow up
r59709. [fix https://github.com/Shopify/bootsnap/issues/132]
From: nobu <nobu@b2dd03c8-39d4-4d8f-98ff-823fe69b... -
- I think `.:` is better than `:::` but it is not very pretty either. I have
no better suggestion, though. Good syntax is not easy to use. :(
I agree with the functionality by the way. -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65727 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:25 PM Bug #14862: Time.parse does not handle the time zone
- okay, it seems like, they should not be the same. Thank you very much - we figured it out. I think we can close this one.
Thanks for your time. - 09:53 AM Revision 33758ded (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65726 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- same as r65642.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65725 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
> What I personally found with method_missing is that it can become very confusing.
My proposal have absolutely nothing to do with `method_missing`.
> ...
It is not, it is standard Ruby feature since Ruby 1.9, AFAIK (everything t...-
- shevegen (Robert A. Heiler) wrote:
> [[1, -2], [-3, -4]].map(&:map.(&:abs)) # => [[1, 2], [3, 4]]
> ...
You probably misunderstood what the example is doing. `map` is not repeated per say here. You can replace the first one by `fla... -
- for Travis osx.
https://travis-ci.org/ruby/ruby/jobs/454864155
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65724 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- https://travis-ci.org/ruby/ruby/jobs/454798071
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65723 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- https://app.wercker.com/ruby/ruby/runs/mjit-test2/5beba9be183106002852f8a6?step=5bebc1a087436a0006f94a22
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65722 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- **Proc#by** allows currying implicitly
~~~ ruby
class Proc
def by(*head)
return self if head.none?
curry(head.size.next).(*head)
end
end
class Method
def by(*head)
to_proc.by(*head)
end
end
class Sym... -
- We are not interested in git(1) output.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65721 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65720 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
-
-
- 03:52 AM Revision 7a823be8 (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65719 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:52 AM Revision cc07dc7c (git): thread.c (rb_thread_fd_select): favor rb_thread_* when no FDs
- select() is a crap API for even sleeping on sigwait_fd, so favor
the native_sleep-based functions when there are no FDs, instead.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65718 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65717 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * Makefile.in (update-known-errors): update defs/known_errors.def
by using errno(1).
* defs/known_errors.def: sort alphabetically for merger.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65716 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65715 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
11/13/2018
- 11:06 PM Revision 6716bca6 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65714 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- for now. This seems to get unstable after r65691.
test/excludes/_travis/osx: renamed from test/excludes/_travis because
it's only for osx builds.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65713 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 09:36 PM Revision 6876140d (git): * 2018-11-14
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65712 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- it seems to be more stable than the timing we upgraded travis image.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65711 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * [Feature #15301] `Symbol#call`, returning method bound with arguments
-
- > I understand and respect core team's reluctance for adding new methods to core classes
Ultimately it is up to matz, but I believe it is not so much reluctance, but more the
general question "will this be of benefit to many people".... -
- @Hanmac yeah, I myself invented and discarded several generations of similar things throughout my carreer.
But without too much of "going meta" (like hard-to-debug and guess "where it is from" `method_missing` tricks), I believe my su... -
02:10 PM Feature #15301: Symbol#call, returning method bound with arguments
- I once had a similar script (> 3 years old), but i extened it to be chainable
~~~ ruby
class Symbol
class SymbolHelper
def initialize(obj,methId,*args)
@obj= obj
@args=args
@methId=methId
end
... -
- In one Reddit discussion I've got stuck with this simple, yet seemingly powerful idea, not sure if it was discussed anytime previously (can't find on the bug tracker, but maybe I am just bad at searching):
```ruby
class Symbol
def... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65710 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
02:39 PM Bug #15244: Method #extname return empty string if filename is dot ('.')
- This is still present.
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65709 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:39 PM Bug #15300 (Closed): rb_frame_method_id_and_class deprecated in 2.6
- Coming from [jasonroelofs/rice#105](https://github.com/jasonroelofs/rice/issues/105), related to #14192.
As far as I understand, this API has been deprecated, thus Rice won't compile anymore.
~~~
detail/method_data.cpp:19:48: erro... -
11:23 AM Feature #12698: Method to delete a substring by regex match
- matz (Yukihiro Matsumoto) wrote:
> I don't think it's worth adding which is easily done by `sub/gsub`.
Easily done, yes, but Ruby being a very expressive language, the following two are not equally readable:
* `"foo test bar".gsub... -
- When compiling the latest version of trunk, I get some warnings in hash.c, as follows:
```
compiling hash.c
hash.c: In function ‘linear_update’:
hash.c:849:24: warning: ‘bin’ may be used uninitialized in this function [-Wmaybe-unin... -
- Sorry, seen the failures again. Was a wrong idea to delete
the --exclude.
See https://travis-ci.org/ruby/ruby/jobs/454329443#L2233
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65708 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65707 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 06:20 AM Revision dde0e30c (git): Pathname: Have #relative_path_from accept String argument.
- [Fix GH-1975]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65706 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- On osx build https://travis-ci.org/ruby/ruby/jobs/454309945,
```
1) Failure:
Fiddle::TestFunction#test_nogvl_poll [/Users/travis/build/ruby/ruby/test/fiddle/test_function.rb:95]:
slept amount of time.
Expected |200 - 322| (122) to be <=... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65704 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- r65690 had no impact
https://ci.appveyor.com/project/ruby/ruby/builds/20253561/job/p5u235m8xx85t9o5.
Gave up to solve the issue inside the test.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65703 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- To reduce the amount of output, prefer --tty=no instead of
--color=never. This option not only disables color output but also
kill some tty-related features, like spinners. Travis limits its
output by the physical size of the log, not ... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65701 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- While we are experiencing build failures, no hangs had been
seen for a while. Also it seems the excluded tests now pass.
I think it's time to delete this line.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65700 b2dd03c8-39d4-4d8f... -
- * ext/date/date_core.c (date_initialize): separate from
date_s_civil and obey the allocation framework.
* ext/date/date_core.c (datetime_initialize): ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65699 b2dd03c8-39d4-4d8f-9... -
- * ext/date/date_core.c (d_lite_marshal_load): respect COMPLEX_DAT
bit in the pre-allocated structure.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65698 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ext/date/date_core.c (d_lite_initialize_copy): do not change
COMPLEX_DAT bit, as the structure does not change. initialize
member-wise instead.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65697 b2dd03c8-39d4-4d8f-98ff-823fe... -
- * ext/date/date_core.c (set_to_simple, set_to_complex): always
set/reset COMPLEX_DAT bit, which is very tightly bound to the
structure.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65696 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Since `.revision.time` recipe needs `$(BASERUBY)`, it should not
try to get updated unconditionally, or tarballs fail to build on
environments where BASERUBY is not available.
All developers who build frequently use GNU make anyway, don... -
- Tests are failing due to network timeouts. Temporary allow failrues for them.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65694 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- See also: https://travis-ci.org/ruby/ruby/jobs/454269559#L1898
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65693 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- by making .revision.time PHONY. Prior to this commit, RUBY_DESCRIPTION
has been updated only when version.h (or tool/file2lastrev.rb) is updated.
.revision.time (REVISION_H) target internally has IFCHANGE to update
revision.h. So it doe... -
- xeinal for Linux and xcode 10.1 for osx. Also deleted few outdated
lines that are no longer necessary.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65691 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- We somehow hit NoMemoryError twice on that place.
https://ci.appveyor.com/project/ruby/ruby/builds/20224556/job/hlgt963e0cgjbj3c
https://ci.appveyor.com/project/ruby/ruby/builds/20250696/job/gm559bu2jbd6youm
Let me try firing GC here.
... - 12:40 AM Revision 2a70978d (git): * 2018-11-13
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65689 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * random.c: annotate rb_hash_start with NO_SANITIZE (seed.key.hash + h
overflows and that seems intentional)
* bignum.c: avoid (size_t)--
* cont.c: ditto
* util.c: ditto
* vm_insnhelper.c: ditto
git-svn-id: svn+ssh://ci.ruby-lang.or...
11/12/2018
-
- While I am not sure if ArgumentError for all entries would be the proper
solution, I agree that there may be more elegant solutions to the
above problem set - aka when a nil value is passed as parameter (may
happen accidentally too, i... -
06:08 PM Misc #15298 (Closed): Inconsistent date errors
- When using Date, if you initialize an invalid date you'll get an `ArgumentError`:
```ruby
Date.new(1999, 1, 32) # => ArgumentError: invalid date
```
This is as expected.
If you provide `nil` as any of the three arguments, yo... -
06:14 PM Bug #14929: [PATCH] thread.c (do_select): fix leak on exception
- Could you backport below commits for test/ruby/test_io.rb#test_select_leak from ruby_2_5 or trunk to ruby_2_4 branch?
## ruby_2_5 branch
```
$ git diff ruby_2_4..ruby_2_5 test/ruby/test_io.rb
...
def test_select_leak
- as... -
03:59 PM Misc #15294: Add warnings for invalid ERB trim modes
- Thank you!
-
- I thought warning message should provide information that helps to fix the warning, so I modified your patch but applied that in r65671. Thanks.
-
- Applied in changeset trunk|r65671.
----------
erb.rb: warn invalid trim_mode [Misc #15294]
From: Justin Collins <justin@presidentbeef.com> -
- I've forgotten to post the patch to use `<<` and `>>`.
https://github.com/nobu/ruby/tree/feature/6284-proc-composition -
- @nobu Awesome!
Am I correct that receiver-less call, like `something.map(&.:puts)`, will be impossible?
Is it a voluntary design decision, or limitation of what can be parsed? -
- https://github.com/nobu/ruby/tree/feature/13581-methref_op
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65687 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- The "osx build randomly fails with `-j`" happens on make -j test-all.
Should be safe to do make -j all.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65686 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- space_size can be zero here, under the following script. We would
better bail out before bptr calculation.
% ./miniruby --dump=i -e '* = nil'
== disasm: #<ISeq:<main>@-e:1 (1,0)-(1,7)> (catch: FALSE)
0000 putnil ... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65684 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65683 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65682 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65681 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65680 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:26 AM Revision 75521b8c (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65679 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- same as r65642.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65678 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- read_escaped_byte() returns values of range -1...256. -1 indicates
error. So the function basically expects char to be 0..255 range.
There is no such guarantee. `char` is not always unsigned. We
need to explicitly declare chbuf to be u... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65676 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- The unary ~ operator excercises integer promotion of the operand
_before_ actually applying bitwise complement (cf: ISO/IEC 9899:1990
section 6.3.3.3). Which means `~buf[i]` is in fact
`(int)~(int)buf[i]`.
The problem is, when buf[i] i... -
- For some reason this very useful method was undocumented since it was added in
493e48897421d176a8faf0f0820323d79ecdf94a which makes finding it in the docs
impossible before this change.
I've added a detailed example with sample code bec... - 12:53 AM Revision 8db14201 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65673 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65672 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- From: Justin Collins <justin@presidentbeef.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65671 b2dd03c8-39d4-4d8f-98ff-823fe69b080e