Activity
From 10/24/2018 to 10/30/2018
10/30/2018
-
11:48 PM Bug #14867: Process.wait can wait for MJIT compiler process
- > holding vm->waitpid_lock across two Ruby method calls won't work.
Oh, I see.
> ...
Kind of right. But as replied previously, my assumption is:
"That had been hidden until MJIT postponed_job was introduced and MJIT stopped to s... -
04:22 PM Bug #14867: Process.wait can wait for MJIT compiler process
- takashikkbn@gmail.com wrote:
> @normalperson By the way, is there any plan to apply
> `rb_f_system`-like changes to `rb_f_spawn` as well? Many of
> "1. waitpid" deadlocks seem to come from a process created by
> `rb_f_spawn`, and al... -
- @normalperson By the way, is there any plan to apply `rb_f_system`-like changes to `rb_f_spawn` as well? Many of "1. waitpid" deadlocks seem to come from a process created by `rb_f_spawn`, and also I guess those waitpid-related race cond...
-
- > I'm testing this patch for ccan/list in rb_mjit_unit:
> ...
It's okay to merge it. Migration to ccan/list was one of things I wanted to do later. Though, as said above, I'll resurrect compact_units to clean up them on ruby_cleanup any... -
- > Howeever, I think I found an old bug. Accessing unit->iseq->body outside of critical section seems wrong and I hit a segfault:
Thanks to report, I'll take a look at that once I go home. -
04:00 AM Bug #14867: Process.wait can wait for MJIT compiler process
- @normalperson
r65437 passed.
> very odd, it's breaking in bigdecimal which isn't affected by any changes in internal.h
I saw that, and knew I could look at it all day and never find the cause. The builds with and without the pa... -
- > compact_units list is useless and you have no plans for it right?
Oh, it's intended to be "List of compacted so files which will be deleted in `mjit_finish()`" so the current behavior is a bug. I'll fix it shortly, so please leave i... -
- > I am going to move more data into rb_mjit_unit struct for state
> management using callbacks and events. It looks like
> rb_mjit_unit_node is useless so I will get rid of it and
> embed ccan/list node into rb_mjit_unit.
>
> com... -
- takashikkbn@gmail.com wrote:
> Congrats, while mswinci's vc12-x64 is not finished yet, r65437
> at least worked on AppVeyor CI (mswin, mingw). That seems to
> work on Windows now.
Thank you for update, I was refreshing rubyci.org ... -
- Congrats, while mswinci's vc12-x64 is not finished yet, r65437 at least worked on AppVeyor CI (mswin, mingw). That seems to work on Windows now.
-
- > *sigh* reverted r65434
> None of these errors seem related, even
> http://mswinci.japaneast.cloudapp.azure.com/vc12-x64/ruby-trunk/log/20181030T003541Z.fail.html.gz
Trying r65437
```
diff --git a/9ee245cba9 b/13af9d182c
index ... -
- > > I normally just build mingw, so I'm not testing the mswin/vc builds. I added the patch, and several build errors, starting at line 2254 of the attached log. I then removed the patch, and all built fine...
>
> Greg: very odd, it... -
11:43 PM Bug #15271 (Closed): Segfault (null pointer deref) in parse.y:1354
- Applied in changeset trunk|r65460.
----------
parse.y: last location from bison
* parse.y (command): set the last location from the location
managed by bison, so that other nodes are not needed.
[ruby-core:89648] [Bug #15271] -
09:36 PM Bug #15271 (Closed): Segfault (null pointer deref) in parse.y:1354
- Reproducer and crash:
~~~
jtruba@dev118:~/rubies/ruby-trunk$ ./ruby -e 'a **{}'
./ruby: [BUG] Segmentation fault at 0x0000000000000028
ruby 2.6.0dev (2018-10-26 trunk 65379) [x86_64-linux]
-- Control frame information ------------... -
- * parse.y (command): set the last location from the location
managed by bison, so that other nodes are not needed.
[ruby-core:89648] [Bug #15271]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65460 b2dd03c8-39d4-4d8f-98ff-823fe6... -
- I could collect 2 test failure information:
https://app.wercker.com/ruby/ruby/runs/test-mjit-wait/5bd8a253191eda0006545d47?step=5bd8a29387436a0006842ef0
https://app.wercker.com/ruby/ruby/runs/test-mjit-wait/5bd8c6e0191eda0006547273?step=... -
10:55 PM Revision 35796756 (git): fix type.
- * internal.h (RHASH_ARRAY_SIZE_RAW): should be `int` because
it returns n<=8.
* hash.c (RHASH_ARRAY_BOUND_RAW): ditto.
* hash.c (RHASH_ARRAY_SIZE_RAW): remove a duplicated definition.
* hash.c (linear_keys, linear_values): return `l... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65457 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * string.c (rb_str_format_m): should pass `int`.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65456 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r65454.
----------
support theap for T_HASH. [Feature #14989]
* hash.c, internal.h: support theap for small Hash.
Introduce RHASH_ARRAY (li_table) besides st_table and small Hash
(<=8 entries) are managed... -
- Do we have non-micro benchmark results for this? Maybe gcbench-rdoc on [Bug #14858] is the one?
> rails_ruby_bench project rails_ruby_bench with parameters : 8 workers, 1500 iterations
> ...
These things are mentioned for investigati... - 10:12 PM Revision d4f1187d (git): * remove trailing spaces, expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65455 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * hash.c, internal.h: support theap for small Hash.
Introduce RHASH_ARRAY (li_table) besides st_table and small Hash
(<=8 entries) are managed by an array data structure.
This array data can be managed by theap.
If st_table is ne... - 10:03 PM Revision ca83ed8d (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65453 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * struct.c: members memory can use theap.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65452 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * variable.c: now instance variable space has theap supports.
obj_ivar_heap_alloc() tries to acquire memory from theap.
* debug_counter.h: add some counters for theap.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65451 b2dd03c8... - 09:54 PM Revision 43739223 (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65450 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * transient_heap.c, transient_heap.h: implement TransientHeap (theap).
theap is designed for Ruby's object system. theap is like Eden heap
on generational GC terminology. theap allocation is very fast because
it only needs to bump ... -
- Reproducer:
~~~
jtruba@dev118:~/rubies/ruby-trunk$ xxd ../repro5
00000000: 3c3c 7e30 270a 200a 3023 7b7d 0a30 <<~0'. .0#{}.0
jtruba@dev118:~/rubies/ruby-trunk$
~~~
Crash:
~~~
jtruba@dev118:~/rubies/ruby-trunk$ ./ruby ../r... -
09:19 PM Bug #15269: Process.setproctitle has odd behaviour on Mac OS X
- I will test on another language, e.g. Python and see if it works or not.
-
- It isn't ruby specific.
Seems like an issue of htop, it just does not update the info.
-
- On Mac OS X, using `Process.setproctitle` does seem to update when inspecting the process using `ps` but doesn't seem to update the process title in `htop`.
I don't know why.
Here is my test script.
```ruby
#!/usr/bin/env ruby
... - 09:02 PM Revision 69b8ffcd (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65448 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65447 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * variable.c: now instance variable space has theap supports.
obj_ivar_heap_alloc() tries to acquire memory from theap.
* debug_counter.h: add some counters for theap.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65446 b2dd03c8... -
- Applied in changeset trunk|r65444.
----------
introduce TransientHeap. [Bug #14858]
* transient_heap.c, transient_heap.h: implement TransientHeap (theap).
theap is designed for Ruby's object system. theap is like Eden heap
on gener... - 08:46 PM Revision f926f799 (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65445 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * transient_heap.c, transient_heap.h: implement TransientHeap (theap).
theap is designed for Ruby's object system. theap is like Eden heap
on generational GC terminology. theap allocation is very fast because
it only needs to bump ... - 06:26 PM Revision b51724aa (git): mjit.c (free_list): clear .length
- For robustness against future changes. There should be no impact
at the moment,here, but we may call mjit_finish more than once
in a process lifetime in the future (implementing "stop"
instead of just "pause")
git-svn-id: svn+ssh://ci.r... -
04:16 PM Bug #15262: WeakRef::RefError for object that is still in use
- I agree, this appears to a be a bug in WeakRef. The Adder instance is not garbage collected, but you still get a `WeakRef::RefError` when referencing it through the WeakRef instance. Here's a slightly modified example that just prints ...
-
03:08 PM Bug #15262: WeakRef::RefError for object that is still in use
- @nobu I updated the bug report, so that it should be more understandable now, what's going wrong.
-
- larskanis (Lars Kanis) wrote:
> > It waits just once.
> ...
Why do you think so? - 03:39 PM Revision a5582e69 (git): * 2018-10-31
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65442 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- I don't think we fixed that, but if so, I would like to see more test
failures. Previous failures didn't keep enough C-backtrace information
about the failure and it's hard to debug for now.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/t... -
- because it's not supported by this file. Also, shared `def_iseq_ptr`
instead of copying the main definition of it.
vm_core.h: moved `def_iseq_ptr` to this place. added `inline` to avoid
compiler warnings since it's not used in some file... -
02:50 PM Bug #15270: [PATCH] Fix TracePoint for code loaded using ISeq.load_from_binary
- Typos
-
- Hello. This is a patch for Bug #14702, which I don't think is fully addressed.
The tests in the patch should fail on both trunk and ruby_2_5.
~~~
Fix TracePoint for nested iseq loaded from binary [Bug #14702]
When loading... -
02:18 PM Feature #15230: RubyVM.resolve_feature_path
- If it's reliable enough (I think it is) to detect native extensions by the file extension (.so, .dylib)
then I think that should be preferred as it would simplify the method's result. -
02:00 PM Feature #15230: RubyVM.resolve_feature_path
- `:r` means `.rb` and `:s` means `.so`, I guess :-)
It is not absolutely necessary. But it would be somewhat useful for a static analysis tool of Ruby programs because such a tool typically needs to skip `.so` files. -
- What's the leading one letter Symbol in the return value?
That seems fairly cryptic.
Do you need it? I would expect such a method to return a path, i.e., a String. -
- I think it's very bad style to modify the return value of #inspect, and some objects do already return frozen strings for #inspect.
So I think it would be a fair enough to change as it seems to have very low risk, i.e.,
it would only b... - 03:22 AM Revision fae6c6bf (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65439 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65438 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 01:34 AM Revision f7c0cc36 (git): process.c: implement rb_f_system without toggling ruby_nocldwait
- Following how mjit_worker.c currently works, rb_f_system
now ensures the VM-wide waitpid lists is locked before
creating a new process via fork/vfork.
This ensures other rb_waitpid callers cannot steal work and
there are no possible rac... - 01:12 AM Revision fbee3b8f (git): revert r65434
- http://mswinci.japaneast.cloudapp.azure.com/vc12-x64/ruby-trunk/log/20181030T003541Z.fail.html.gz
I have no chance of getting anything to work on proprietary platforms :<
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65436 b2dd03c8-... -
12:47 AM Feature #15236: add support for hash shorthand
- janfri (Jan Friedrich) wrote:
> I think the use of destructuring for this is much more Rubyish than the ES6 syntax.
Agreed that destructuring hash is very much ruby, since destructuring array is already supported.. but, I think suppo...
10/29/2018
- 11:52 PM Revision 76f08cec (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65435 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 11:52 PM Revision 8227c91d (git): process.c: implement rb_f_system without toggling ruby_nocldwait
- Following how mjit_worker.c currently works, rb_f_system
now ensures the VM-wide waitpid lists is locked before
creating a new process via fork/vfork.
This ensures other rb_waitpid callers cannot steal work and
there are no possible rac... -
- Greg.mpls@gmail.com wrote:
> normalperson (Eric Wong) wrote:
>
> > Greg: everything should be confined to *nix for now, but can you
> > make sure I didn't break anything on Windows? Thanks.
>
> Eric,
>
> I normally just bu... -
- normalperson (Eric Wong) wrote:
> Greg: everything should be confined to *nix for now, but can you
> ...
Eric,
I normally just build mingw, so I'm not testing the mswin/vc builds. I added the patch, and several build errors, sta... -
- Today I took a deeper look at how rb_waitpid is currently working. After reading that, while I couldn't exactly figure out which part is wrong, my bets are:
* There's a race condition around some of SIGCHLD by gcc/clang process spawn ... -
- takashikkbn@gmail.com wrote:
> > Ah, so the waitpid from #system is on /bin/rm (I missed that earlier)
>
> For http://ci.rvm.jp/results/trunk-mjit-wait@silicon-docker/1431394, yes. Others http://ci.rvm.jp/results/trunk-mjit-wait@si... -
- > The other thing is MJIT multi-threading/synchronization seems tricky-to-debug right now, and making it event-based should be beneficial for reliability.
Yeah, if the performance regression by moving to event-based implementation is ... -
- takashikkbn@gmail.com wrote:
> Issue #14867 has been updated by k0kubun (Takashi Kokubun).
>
> > I think we'll have to support non-blocking/event-based waitpid in Windows for auto-fiber/Thread::Light, anyways. So making MJIT worker ... -
- * vm_eval.c (local_var_list_init): use `rb_hash_new_compare_by_id()`
directly instead of manipulating st_table.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65433 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 06:00 PM Revision 90a97887 (git): * 2018-10-30
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65432 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 06:00 PM Revision 708142ca (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65431 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * class.c (rb_keyword_error_new): use RARRAY_AREF() because
RARRAY_CONST_PTR() can introduce additional overhead in a futre.
Same fixes for other files.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65430 b2dd03c8-39d4-4d8f-98f... -
03:38 PM Bug #15268 (Closed): Solarisでtest/drb/test_drbssl.rbが落ちる
- 他のテストの結果が隠れてしまうので今は skip しているのですが、Solaris で test/drb/test_drbssl.rb が落ちます。
ほぼ同じような TCPSocket 直接と UNIXSocket では落ちていないので、Ruby/OpenSSL 側の問題ではないかと思っているので、担当者を openssl にしておきます。
症状としては
- https://rubyci.org/logs/rubyci.s3.amazonaws.com... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65429 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:08 PM Feature #15261: Expose rl_variable_value as Readline.variable_value
- I would recommend to you, if you would like to, to add your request to the next
developer meeting at:
https://bugs.ruby-lang.org/issues/15229
It is such a small change that it may be quickly approved before the upcoming
x-mas rel... -
- > It waits just once.
Yes, but the one event is sent after all 10 threads have been called, so that `@count` is decremented to 0.
The same error is present, when we wait for 10 calls to the queue. So the class can actually be simpl... -
- larskanis (Lars Kanis) wrote:
> It does: `initialize` waits for all threads to have called `Adder#add` at the last line at `@qu.deq` . It only returns after this event.
It waits just once. -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65428 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
06:40 AM Misc #15265: Documentation for `Object#instance_variable_set` is inaccurate and pejorative
- mame (Yusuke Endoh) wrote:
> Indeed, it looks a very subjective view of the author (Dave Thomas). Though, I can't understand its subtlety because I'm not a native speaker.
> ...
I agree with Yusuke here. The wording is slightly odd fo... -
- Indeed, it looks a very subjective view of the author (Dave Thomas). Though, I can't understand its subtlety because I'm not a native speaker.
It might have been just a joke, but anyway, more or less, he wanted to say that "do not us... -
- Related to #15224, I found the case `File.basename(name, '.*')+File.extname(name) == File.basename(name)` is not true.
```ruby
name = 'file.'
File.basename(name, '.*') #=> "name"
File.extname(name) #=> ""
```
Both do not contai... -
- Merged https://github.com/ruby/rdoc/pull/660
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65427 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- If `File.extname("..jpg")` returns `".jpg"`, `File.basename("..jpg", ".*")` should return `"."` without that part, to restore the original name from from these results.
It is different from basename(1).
```
$ basename ..jpg '.*'
..... -
03:21 AM Revision c80f3f70 (git): less verbose code by sharing attribute definitions
- The idea behind this commit is that handles_sp and leaf are two
concepts that are not mutually independent. By making one explicitly
depend another, we can reduces the number of lines of codes written,
thus making things concise.
git-... -
- This enhances stability of the generated source code (namely
insns_info.inc) across attribute insertion / deletion. It does
not change the compiled binary at all; just a bit of readability.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/...
10/28/2018
-
- Hello. I don't think this issue is fully fixed.
I have put together a patch that has a fix and tests that fail on both trunk and ruby_2_5 for your consideration:
I've opened up a ticket for this patch: #15270
~~~
Fix TracePoi... -
05:03 PM Revision 437dd881 (git): Revert "Add test for cause on pty"
- This reverts commit r65422.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65424 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 04:06 PM Revision 13cde0a1 (git): * 2018-10-29
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65423 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65422 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
02:50 PM Bug #14678: Segmentation fault in pg
- Yes. I'm not sure but they are binary incompatible.
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65421 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * time.c (tm_initialize): allow 7th argument as well as
Time#initialize, but just ignore.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65420 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65419 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Here're my plans.
> ## timezone argument to `Time.at`
> ...
To add `in` keyword argument.
```ruby
Time.at(1540000000, in: Timezone.fetch("Asia/Colombo")) #=> 2018-10-20 07:16:40 +0530
```
> ## look-up timezone by the name
> ... -
- Thanks @nobu for looking at the issue!
> This method doesn't wait these threads which run start_adder.
It does: `initialize` waits for all threads to have called `Adder#add` at the last line at `@qu.deq` . It only returns after thi... -
- larskanis (Lars Kanis) wrote:
> Although `start_adder` works with a `WeakRef`, the `Adder` object should still be GC marked, since `Adder.new` doesn't return before all calls to `start_adder` finished.
> ...
This method doesn't wait ... -
- `p`を何も表示されないということは通常ないのですが、`sock`や`client_addrinfo`はどうなっているでしょうか。
また、「問題なく表示」されるコードはどのようなものでしょうか。 -
- Yes I agree. That phrasing is not necessary.
There is more than one way to do many things in ruby. A good example is .send()
versus .public_send(). I think matz's philosophy is closer towards .send() (which
makes more sense to me an... -
04:11 AM Misc #15265 (Closed): Documentation for `Object#instance_variable_set` is inaccurate and pejorative
- The v2.5.1 documentation for this method states, in part, "Sets the instance variable named by symbol to the given object, thereby frustrating the efforts of the class's author to attempt to provide proper encapsulation." The phrase begi...
-
10:49 AM Bug #15264 (Rejected): [PATCH] vm_trace.c (postponed_job_register): only hit main thread
- Duplicates with #15263
-
09:13 AM Bug #13930: Exception is caught in rescue above ensure
- I think it's due to `compile_next()` and `add_ensure_iseq()`.
The following is a reduced script result.
```
$ ruby -e 'iseq = RubyVM::InstructionSequence.compile("1.times do; begin; p :loop; next; rescue; p :NG_rescue; ensure; rai... -
09:10 AM Feature #14145: Proposal: Better Method#inspect
- guilhermereiscampos (Guilherme Reis Campos) wrote:
> zverok (Victor Shepelev) wrote:
> ...
Because they can be arbitrary Ruby code and Ruby is a Turing-complete language, which means that figuring out statically what the default value ... -
- ko1 (Koichi Sasada) wrote:
> I don't have strong opinions on your proposal, but source location information seems also helpful. Which is important or both?
I find source location (FILE:LINE) very valuable for debugging, e.g. to know ... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65418 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- > I think we'll have to support non-blocking/event-based waitpid in Windows for auto-fiber/Thread::Light, anyways. So making MJIT worker thread be a Ruby Thread (or Thread::Light) would allow it to hook into process.c APIs. I don't think...
-
- takashikkbn@gmail.com wrote:
> > 2. Get rid of MJIT worker thread and rely on SIGCHLD + non-blocking waitpid. I don't know the portability problems in Windows, though.
>
> It sounds interesting and it could be reasonable since the m... -
- > I haven't looked at it in detail, but it adds extra synchronization overhead for a slightly more up-to-date cache, right?
Correct.
> ...
This part may not be correct. The introduction of synchronization did not spoil the benchmar... -
- on msys2 because it sometimes crashes worker like
https://ci.appveyor.com/project/ruby/ruby/builds/19853558/job/8v1ehnv40bggiode
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65417 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:19 AM Feature #15239: [patch] test-spec win32ole
- Thank you for your help. I prefer to use MSXML.Document for WIN32OLE_EVENT specs.
Because I think other (light and more standard) COM objects (like Scripting.Dictionary) have features for other specs.
I applied the win32ole_event part... -
- @suke
I'd like to help. I just ran CI again on the branch I created the PR from, it passed in both Travis & Appveyor.
I can't rebase due to conflicts, but I can get around that quickly. If it's done a file at a time, it will take... -
- @k0kubun & @suke
When I did the patch, I saw no reason to have non Windows builds requiring the classes.rb file if they weren't using it. Hence, for many of the files in the patch, the only change is to move the `
require_relative '... -
- Please look at the patch. It modifies several files. Removing the rescue block without patching the other files will break non windows builds. It passes on Travis. Twice.
Before this issue, and before the PR, I've used the patch i... -
- @suke r65401 is breaking CI on Linux like https://gist.github.com/ko1/2c561f9185492f339cf7a763ea219e79, so the assumption "this file is required on Windows only" seems not correct. I reverted that in r65402. Could you check it?
-
- * spec/ruby/library/win32ole/fixtures/classes.rb: remove rescue block
because this file is required when platform is Windows.
* spec/ruby/library/win32ole/win32ole/_getproperty_spec.rb:
fixtures/classes is required when platform is W... -
- * spec/ruby/library/win32ole/win32ole/ole_methods_spec.rb: refactoring.
remove Internet Explorer.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65415 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * spec/ruby/library/win32ole/fixtures/event.xml use MSXML.DOMDocument
instead of InternetExplorer.Application. InternetExplorer.Application
is not available on some environments. Thanks to MSP-Greg (Greg L).
* spec/ruby/library/win32... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65413 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * spec/ruby/library/win32ole/win32ole_event/new_spec.rb: use
MSXML.DOMDocument. InternetExplorer.Application is not available on
some environments. Thanks to MSP-Greg (Greg L).
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65412... -
- * compile.c (ibf_dump_object_hash): use `rb_hash_foreach()`
instead of using `st_foreach()`.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65411 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * spec/ruby/library/win32ole/win32ole/shared/setproperty.rb: use
Scripting.Dictionary. InternetExplorer.Application is not available on
some environments. Thanks to MSP-Greg (Greg L).
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trun... -
- * spec/ruby/library/win32ole/win32ole/ole_put_methods_spec.rb: use
Scripting.Dictionary. InternetExplorer.Application is not available on
some enviroments. Thanks to MSP-Greg (Greg L).
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/tru... -
- * spec/ruby/library/win32ole/win32ole/ole_methods_spec.rb: use Scripting
Dictionary. InternetExplorer.Application is not available on some
environments. Thanks to MSP-Greg (Greg L).
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@... -
- * spec/ruby/library/win32ole/win32ole/ole_obj_help_spec.rb: use
Scripting.Dictionary. InternetExplorer.Application is not available on
some environments. Thanks to MSP-Greg (Greg L).
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65406 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * spec/ruby/library/win32ole/win32ole/ole_method_spec.rb: recuire in
platform_is block.
* spec/ruby/library/win32ole/win32ole/ole_func_methods_spec.rb: ditto.
* spec/ruby/library/win32ole/win32ole/shared/ole_method.rb: use
Scripting.... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65404 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * lib/rdoc/parser/c.rb (RDoc::Parser::C#deduplicate_call_seq):
skip dynamically added methods at runtime, because the class
name is unknown and the defined methods are not accessible from
that class.
git-svn-id: svn+ssh://ci.ruby-... -
- Because it does break Linux CI like:
https://gist.github.com/ko1/2c561f9185492f339cf7a763ea219e79
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65402 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * spec/ruby/library/win32ole/fixtures/classes.rb: remove rescue block
because this file is required on Windows only.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65401 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * spec/ruby/library/win32ole/win32ole/ole_func_methods_spec.rb: use
Scripting.Dictionary. InternetExplorer.Application is not available on
some environment. Thanks to MSP-Greg (Greg L).
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/tr...
10/27/2018
-
11:56 PM Feature #14145: Proposal: Better Method#inspect
- zverok (Victor Shepelev) wrote:
> ```ruby
> ...
I wonder why is not possible to extract the default values?
-
- * spec/ruby/library/win32ole/invoke_spec.rb: use Scripting.Dictionary
instead of InternetExplorer.Application. InternetExplorer.Application
is not available on some environment. Thanks to MSP-Greg (Greg L).
git-svn-id: svn+ssh://ci.... -
- ```
vm_trace.c (postponed_job_register): only hit main thread
Since postponed_job_register may be called in a signal handler,
only the main thread is safe to touch as other threads may
become invalid. Furthermore, the problem with... -
- ```
vm_trace.c (postponed_job_register): only hit main thread
Since postponed_job_register may be called in a signal handler,
only the main thread is safe to touch as other threads may
become invalid. Furthermore, the problem with... -
- _getproperty spec.
* spec/ruby/library/win32ole/_getproperty_spec.rb: use
Scripting.Dictionary. InternetExplorer.Application is not available on
some environment. (Thanks to MSP-Greg (Greg L))
git-svn-id: svn+ssh://ci.ruby-lang.org... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65397 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65396 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * spec/ruby/library/win32ole/fixtures/classes.rb: add
WIN32OLESpecs::MSXML_AVAILABLE
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65395 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 09:45 PM Revision 1064376b (git): * 2018-10-28
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65394 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Print `cause` of the exception if the exception is not caught and printed
its backtraces and error message [Feature #8257]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65393 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- takashikkbn@gmail.com wrote:
> Thank you for your quick and detailed reply. For 1, I'll try
> to acquire GVL from MJIT worker thread to resolve this issue.
> In that case possibly we could just synchronously finish the
> copy job du... -
- Thank you for your quick and detailed reply. For 1, I'll try to acquire GVL from MJIT worker thread to resolve this issue. In that case possibly we could just synchronously finish the copy job during the lock and avoid using postponed_jo...
-
- takashikkbn@gmail.com wrote:
> In this case, 3 threads are blocking in:
>
> 1. `rb_thread_io_blocking_region` called from `rb_read_internal` called from `io_readpartial`
> 2. `native_ppoll_sleep` called inside `rb_waitpid`
> 3. (M... -
- Recently we see 2 types of deadlocks on CI with --jit or --jit-wait.
## 1. waitpid on #system, #`, or Process.waitpid
http://ci.rvm.jp/results/trunk-mjit-wait@silicon-docker/1431775
http://ci.rvm.jp/results/trunk-mjit-wait@silicon... -
- Given the following program:
```ruby
require "weakref"
Thread.abort_on_exception = true
class Adder
def self.start_adder(obj, oid)
obj.add
end
def initialize
@qu = Queue.new
count = 10
count.times... -
03:10 PM Feature #15261 (Closed): Expose rl_variable_value as Readline.variable_value
- I would like to propose exponsing rl_variable_value as Readline.variable_value, it would be useful in pry.
Pull request: https://github.com/ruby/ruby/pull/1995 -
- from terminate_spec.rb, as suggested here:
https://github.com/ruby/ruby/commit/c7220bd3dea0a113b81f267cc3b656da7d7d7abb#commitcomment-31068714
to guard other inclusions.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65392 b2dd03c8-... -
- Sounds good to me to use the MSXML object.
The patch looks good from a quick look. -
- suke (Masaki Suketa) wrote:
Thanks for looking at it. Apologies for not testing on Travis.
> I'm afraid your patch would fail on environment except Windows (on Linux, etc).
Sorry, I thought I had 'windows guards' on everything,... -
- Thank you for your patch. I'm reeding your patch now. And I'm afraid
your patch would be fail on environment except Windows (on Linux, etc).
I'll modify your patch and marge it. Thank you again. -
- and move retry logic to internal method
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65391 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * The 2.3 alias in RVM seems to resolve to 2.3.7.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65390 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- to this spec as well, since the same issue was reproduced here
https://ci.appveyor.com/project/ruby/ruby/builds/19842006/job/y35ae6bquf4t3x30
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65389 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65388 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65387 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- It looks like mspec worker may immediately die on Linux as well.
https://travis-ci.org/ruby/ruby/jobs/447018758
Dropping -j and add -fs to know which test dies.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65386 b2dd03c8-39d4-4d8f... -
- @knu Could you share your opinion?
I also wonder, why are these operations raising an error with non-Set arguments?
Is it to avoid e.g. Array which would have a slow O(n) `include?` check?
Otherwise any Enumerable would work with th... -
- Hanmac (Hans Mackowiak) wrote:
> hm i especially hate such part of code:
> ...
Existing code style is orthogonal to this issue.
Please make a separate issue or pull request if you would like to change it :) -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65385 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 07:22 AM Revision b16d73ae (git): Update the example of local variable shadowing
- I came up with this snippet when we were trying to convince Matz.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65384 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:20 AM Feature #14136: Implement #empty? on more classes
- jeremyevans0 (Jeremy Evans) wrote:
> bozhidar (Bozhidar Batsov) wrote:
> ...
Yeah, I completely agree with you. Excellent point about using `size` in different contexts! Generally I'm not trying to suggest changes for the sake of makin... -
- which I tried to avoid skipping this in r65311, but the test seems not
working under some high load of ci.rvm.jp.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65383 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
10/26/2018
-
08:30 PM Revision 8f0eb44d (git): string.c: improve docs for String#strip and related
- * string.c: [DOC] improve docs for String#{strip,lstrip,rstrip}{,!}:
small clarification, avoid referring to the receiver as `str'
(does not appear in the call-seq of the generated HTML docs),
enable links for cross-references, sim... - 05:08 PM Revision ab99fd06 (git): * 2018-10-27
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65381 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- It disables cross-references to the classes/modules, even if those
are defined in other places. I suspect this is not an intentional
behavior, however make a workaround for the time being.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/tr... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65379 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65378 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65377 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65376 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- because it may silently die like
https://ci.appveyor.com/project/ruby/ruby/builds/19813015/job/a99c4hrs69g4iorg
and we can't know which test was bad.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65375 b2dd03c8-39d4-4d8f-98ff-823fe6... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65374 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 06:18 AM Revision ea9961f9 (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65373 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65372 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- > But I got some spec failures due to singleton class (below). I
> haven't investigated, yet, but I think there may be an existing
> bug in hash.c, because my shorter patch ought to work...
Maybe this is an appropriate simplificat... -
- chopraanmol1@gmail.com wrote:
> I think so far it looks good, let me know if I did something wrong while running the above benchmark.
I agree, so I've committed your patch as-is for r65371.
I wanted to try a shorter patch:
htt... -
- Applied in changeset trunk|r65371.
----------
hash.c: aset deduplicates un-tainted string
We revisit [Bug #9188] since st.c is much improved since then,
and benchmarks against so_k_nucleotide seem to indicate little
or no performance c... - 05:32 AM Revision 1e83e15a (git): hash.c: aset deduplicates un-tainted string
- We revisit [Bug #9188] since st.c is much improved since then,
and benchmarks against so_k_nucleotide seem to indicate little
or no performance change compared to before.
[ruby-core:89555] [Feature #15251]
From: Anmol Chopra <chopraanm... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65370 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- You can now write the following without warning.
user = User.all.find {|user| cond(user) }
Fixes [Feature #12490].
A patch from Soutaro Matsumoto <matsumoto@soutaro.com>.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65369 b2d... -
- I forgot to add the copyright of the patch...
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65368 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r65367.
----------
parse.y: remove "shadowing outer local variable" warning
You can now write the following without warning.
user = User.all.find {|user| cond(user) }
Fixes [Feature #12490]. -
- You can now write the following without warning.
user = User.all.find {|user| cond(user) }
Fixes [Feature #12490].
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65367 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 01:47 AM Revision df38879a (git): * 2018-10-26
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65366 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65365 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
10/25/2018
-
10:43 PM Bug #15255 (Rejected): Change in protected handling 2.3 -> 2.4,2.5
- It looks like when moving to 2.4 and higher, the access to protected method has changed. In the following case:
~~~ ruby
class Foo
def bar(objects)
objects.map(&:baz)
end
protected
def baz
self.inspect
en... -
09:56 PM Bug #15254 (Rejected): Array#slice should not treat the index past the last element as a special case
- This is per spec.
Here's one way to see the start indices:
```
[ :a, :b, :c ]
# ^ ^ ^ ^
# 0 1 2 3
# -3 -2 -1
```
Other indices (4, -4) are out of bounds and will result in `nil` return. -
09:44 PM Bug #15254 (Rejected): Array#slice should not treat the index past the last element as a special case
- Array#slice should not treat the index past the last element as a special case. This causes Array#slice(start, length) has inconsistent behavior when given out of bounds values for the start parameter. It sometimes returns an array, and ...
-
01:11 PM Bug #15253 (Closed): Arduinoとの接続においてSocket.tcp_server_loop中で$stderr.puts、pなどが使用できない
- サーバーにおいて以下のコードを動かしています。
```ruby
require 'socket'
Socket.tcp_server_loop("", 49088) {|sock, client_addrinfo|
Thread.new {
begin
number_of_copied_bytes = IO.copy_stream(sock, sock)
$stderr.puts number_of_copied... -
10:50 AM Misc #15202: Adding Coverity Scan to CI to see the result casually
- > Instead of that, It looks good to me that someone could see the result of coverity scan casually anytime to fix those in long term.
Current Travis CI "pedanticism" test case to output compiler warnings with `-Wall` and `-Wextra` is ... -
- > Let me close this now. Thank you for the report!
Yeah, thank you for closing. I saw the updated .travis.yaml.
osx & OpenSSL 1.1.1, i686 (32-bit), valgrind, a case to show compiler warnings, and etc.
Great work!
-
- Let me close this now. Thank you for the report!
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65364 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
07:05 AM Feature #15251: Hash aset should deduplicate non tainted string
- @normalperson I also benchmarked so_k_nucleotide mentioned in https://bugs.ruby-lang.org/issues/9188 with following command
~~~
benchmark-driver benchmark/so_k_nucleotide.yml -e "path_to_patched_binary" -e "path_to_trunk_binary" -e "... -
- as failing
https://app.wercker.com/ruby/ruby/runs/test-mjit-wait/5bd092a89b1e440006d5780d?step=5bd092e3591ca80007258400
now and it needs some fix.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65363 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * debug_counter.h: add `gc_major_oldmalloc`.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65362 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65361 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * time.c (time_localtime): check if `vtm.zone` is a simple zone
name string before trying to call the conversion method. since
r64952, `Time.getlocal` on UTC time has lost the performance
about 45%, due to this call. the performa...
10/24/2018
-
- * debug_counter.h: add new debug counters to count GC.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65359 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- chopraanmol1@gmail.com wrote:
> https://bugs.ruby-lang.org/issues/15251
> I'm not sure if current behavior is expected one or a bug. So fell free to
> change tracker type.
current behavior is intentional because of a regression ... -
- I'm not sure if current behavior is expected one or a bug. So feel free to change tracker type.
Currently Hash ASET checks if non-tainted string exists in fstring table or not, if it doesn't then ruby duplicates string and freeze it. ... -
07:12 PM Bug #15252 (Closed): hitting what seems like a gc segfault at random
- I apologize as I don't have a reproducible test case but I'm hoping by sharing the trace that others may be able to chime in on what is happening:
~~~
00:05:24.566 Running tests in parallel: |=========/jenkins/.rvm/gems/ruby-2.4.4@in... -
- test-all2 is taking much longer time than test-all1 now.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65358 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 03:41 PM Revision d82a7612 (git): * 2018-10-25
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65357 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- I assumed somehow this check was not needed, but it did need.
By canceling this instead of just warning here, we didn't lose the
current performance so much.
test_jit.rb: test the case that reproduces SEGV by that.
TestGemStreamUI.rb: ... -
- This seems to have been fixed in r65190.
~~~
$ ./ruby --version
ruby 2.6.0dev (2018-10-24 trunk 65355) [x86_64-linux]
$ ./ruby -e '-888888888888888i**88888888888888'
-e:1: warning: in a**b, b may be too big
$
~~~ -
- nobu (Nobuyoshi Nakada) wrote:
> Maybe fixed by r65190?
Yes, looks fixed.
~~~
$ ASAN_OPTIONS=detect_leaks=0 ./ruby -v
ruby 2.6.0dev (2018-10-24 trunk 65097) [x86_64-linux]
$ ASAN_OPTIONS=detect_leaks=0 ./ruby ../repro2
../repr... -
- Maybe fixed by r65190?
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65355 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:05 PM Bug #15250 (Closed): Concurrent fibers segfault when thread caching is disabled
- ~~~ ruby
500.times do
Array.new(200) { |n|
Thread.new {
Fiber.new {
readable = open(__FILE__)
Fiber.yield readable.read(1)
}.resume
}
}.each(&:join)
end
~~~
Getting the segfault doesn... -
- As Wercker is managing workflow by GUI, the commit had no impact for
behavior... I already fixed the workflow on GUI. Let revert that to
change it back to natural order.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65354 b2dd03c8-3... -
- to reduce time taken for finishing all jobs.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65353 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 12:13 PM Revision 789244e1 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65352 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- which are under investigation. I'm debugging it right now, but let's
make it green to stop bothering other development.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65351 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Yes, 2.4 is ok but 2.5 crashes.
```
$ ruby2.4 -v -e 'i = 0; %w(1) || 2 while (i += 1) < 100; p i'
ruby 2.4.5p335 (2018-10-18 revision 65137) [x86_64-darwin18]
100
```
```
$ ruby2.5 -v -e 'i = 0; %w(1) || 2 while (i += 1) < 100; ... -
11:48 AM Bug #15245: Heap buffer overflow (write of size 8) in vm.inc
- I think r59892 introduce this bug. I'll fill Backport field according to the changeset timing. I didn't confirm it's actually reprodusible on stable branches.
-
- Applied in changeset trunk|r65350.
----------
compile.c: fix peephole optimization
* compile.c (iseq_peephole_optimize): should `pop` before jump
instruction which succeeds to `newarray` of a literal object,
not after. [ruby-core:... -
- Applied in changeset trunk|r65350.
----------
compile.c: fix peephole optimization
* compile.c (iseq_peephole_optimize): should `pop` before jump
instruction which succeeds to `newarray` of a literal object,
not after. [ruby-core:... -
- I guess this is as same as #15245.
```
$ echo -n "2557 0024 7f54 0020 7c7c 6e54 5a20 7768 696c 6523 4054 456d 6520 7e6f 5b0a 0a0a 0a0a 0a0a 0a69 3d31"|xxd -r -p|ruby --dump=insns
-:9: warning: found `= literal' in conditional, shoul... -
- * compile.c (iseq_peephole_optimize): should `pop` before jump
instruction which succeeds to `newarray` of a literal object,
not after. [ruby-core:89536] [Bug #15245]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65350 b2dd03c8... - 10:29 AM Revision cd0181dd (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65349 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- for now. It's randomly failing on test-mjit-wait.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65348 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- TestParallel in test/testunit/... seems to be slow. Let's see if this
contributes to loosen timeout or not.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65347 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- It randomly failed.
https://app.wercker.com/ruby/ruby/runs/test-mjit-wait/5bcfd19aa9806e000655c598?step=5bcfd1d5acc4510006e00f77
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65346 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * insns.def (newhashfromarray): `rb_hash_bulk_insert()` can call
Ruby methods like #hash so that it should not be a leaf insn.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65345 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65344 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * insns.def (newhashfromarray): added to replace `core_hash_from_ary`
method to eliminate method call overhead.
On my environment, I got the following benchmark results:
x = {x: 1}
modified: 7864988.6 i/s
...