Project

General

Profile

Activity

From 09/28/2018 to 10/04/2018

10/04/2018

11:33 PM Revision 4484390f (git): * expand tabs.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64918 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
11:33 PM Revision f8f77d84 (git): use RARRAY_AREF().
* struct.c (setup_struct): no need to use Array raw ptr here.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64917 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
ko1 (Koichi Sasada)
09:34 PM Misc #15202: Adding Coverity Scan to CI to see the result casually
> However there are around 1000 "not important" issues.
I think the ruby core team always likes to remove bugs from ruby, if these reports
constitute real bugs that is. At the github page of mruby one can see that some sort of
syste...
shevegen (Robert A. Heiler)
03:06 PM Misc #15202: Adding Coverity Scan to CI to see the result casually
I had run the Coverity Scan analysis on CI (twice a week), and I had checked the result only when I felt like. But recently I forgot it completely. By this ticket, I have just noticed that the analysis has not worked since Feb. 2018 :-... mame (Yusuke Endoh)
02:06 PM Misc #15202 (Open): Adding Coverity Scan to CI to see the result casually
Recently I reported issues detected by code analysis tool mainly using Coverity Scan.
The 9 issues categorized as "important" was fixed by #15116. (Thank you!)
> https://bugs.ruby-lang.org/issues/15116
> ...
However there are aro...
jaruga (Jun Aruga)
03:22 PM Revision 509d8f81 (git): * 2018-10-05
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64916 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
03:22 PM Revision daf19474 (git): check argument type.
* iseq.c (iseqw_s_compile): check argument type (T_STRING) to
avoid SEGV.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64915 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
ko1 (Koichi Sasada)
02:20 PM Bug #15203 (Closed): test-all WEBrick - fixes needed for Azure Pipelines - three asserts, line endings
Attached is a patch with fixes needed for the test-all WEBrick tests when run on Azure pipelines (vc12, vc14, mingw). These have not been needed for Appveyor builds, nor for local testing on mingw builds.
The changes involve line end...
MSP-Greg (Greg L)
02:00 PM Revision 103a0b98 (git): lldb_rp: support Symbol [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64914 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
01:53 PM Bug #15200: RubyVM::InstructionSequence can not compile to binary from method call with hash in 'if false' expression
okwrtdsh (Tadashi Okawara) wrote:
> ## This throws an error:
> ...
It seems the same as https://bugs.ruby-lang.org/issues/14553#note-3 = ruby-core:86400.
```
$ ./miniruby -v -e 'RubyVM::InstructionSequence.compile("if false\nfoo ba...
wanabe (_ wanabe)
08:21 AM Bug #15200: RubyVM::InstructionSequence can not compile to binary from method call with hash in 'if false' expression
Seems fixed by a series of commits: 61846 61913 62615 62621 62622 62772 62777 62778 62787 62791 62796 62807 62856 63098 63099 63101 63102 63103 63113 63116 63117 63118 63119 63167 63368 nobu (Nobuyoshi Nakada)
01:37 AM Bug #15200 (Closed): RubyVM::InstructionSequence can not compile to binary from method call with hash in 'if false' expression

## These works as expected:
* `if true`
~~~
$ ruby -e 'RubyVM::InstructionSequence.compile("if true\nfoo bar: 1\nend").to_binary'
~~~
* method call without hash arguments
~~~
$ ruby -e 'RubyVM::InstructionSequence.compile(...
okwrtdsh (Tadashi Okawara)
10:34 AM Feature #14839: How to deal with capitalizing Georgian in Unicode 11.0.0
The current implementation of String.capitalize is not just a problem in Georgian, but also in other languages like Dutch. Words beginning with „ij“ must be titlecased with a leading „IJ“, e. g. „IJsbeer“ (polar bear). This should be als... spixi (Marius Spix)
06:29 AM Revision c4e433a8 (git): Support ubasecrt.dll 10.0.17763.1 included in Windows 10 October 2018 Update
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64913 b2dd03c8-39d4-4d8f-98ff-823fe69b080e U.Nakamura
02:28 AM Feature #15198: Array#intersect?
- Interesting. Can you share a bit more detail about your "if two arrays intersect but not actually caring about the intersection" use case? For instance if you have open sourced such code, a URL for it helps us a lot.
- If you have...
shyouhei (Shyouhei Urabe)
12:57 AM Bug #15199 (Closed): scanf.rb broken with io from IO.pipe (MinGW or Windows?)
scanf.rb seems to be broken when using an io from a pipe.
The following code is used in IO#scanf:
link: https://github.com/ruby/ruby/blob/d4b0efc010a45e904ecdad2dd74374b5c74e61e3/lib/scanf.rb#L661-L664
```ruby
begin
seek(sta...
MSP-Greg (Greg L)

10/03/2018

10:34 PM Feature #15181: Azure pipelines vc builds? help needed
@naruse
Thanks for the info. Until I can get it stable, I'll stick with what I'm using. Last build:
https://dev.azure.com/MSP-Greg/ruby/_build/results?buildId=164&view=logs
test-all passed on vc12 & mingw, vc14 had an erro...
MSP-Greg (Greg L)
07:45 AM Feature #15181: Azure pipelines vc builds? help needed
Nice!
> No bison, sed, openssl, or 7z to help with installing them.
JFYI, I usually use Git for Windows SDK and vcpkg to install dependency.
https://gitforwindows.org/
https://github.com/Microsoft/vcpkg
naruse (Yui NARUSE)
08:07 PM Feature #15198 (Closed): Array#intersect?
I frequently find myself needing to determine if two arrays intersect but not actually caring about the intersection, so I write code like:
~~~ ruby
(a1 & a2).any?
~~~
It would be nice to have an **intersect?** convenience method o...
c4am95 (Travis Hunter)
07:19 PM Revision d4b0efc0 (git): * 2018-10-04
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64912 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
07:19 PM Revision a9d3601b (git): fileutils.rb: restore documentation for FileUtils
* lib/fileutils.rb: [DOC] restore documentation for FileUtils module
which became undocumented with r63430.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64911 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
stomar (Marcus Stollsteimer)
05:57 PM Feature #15192: Introduce a new "shortcut assigning" syntax to convenient setup instance variables
> marcandre wrote
> ...
I think this is a bit difficult to say, because we can always reason that one small feature that
is added, is just one more tiny little baby step.
But say that you combine lots of baby steps ... all very si...
shevegen (Robert A. Heiler)
06:13 AM Feature #15192: Introduce a new "shortcut assigning" syntax to convenient setup instance variables
I still don't agree with the proposed syntax.
The option I can accept is something like (`as` is not the only option):
```ruby
def initialize(name: as @name, age: as @age)
...
end
```
Matz.
matz (Yukihiro Matsumoto)
03:16 AM Feature #15192: Introduce a new "shortcut assigning" syntax to convenient setup instance variables
I am surprised this syntax has been repeatedly requested and rejected since 7 years ago.
Write assigning code maybe is not a big problem to developers, but cause Ruby has Struct to solve the assigning problem, so at least it is a prob...
jjyr (Jinyang Jiang)
12:18 AM Feature #15192: Introduce a new "shortcut assigning" syntax to convenient setup instance variables
At the previous deverlopers' meeting (Sep.), I brought #5825 up for discussion. Matz said that he still dislikes this syntax. (Personally I like it.) mame (Yusuke Endoh)
04:06 PM Bug #15197 (Third Party's Issue): Segmentation fault in Ruby script cache_store.rb from homebrew on macOS Mojave
Execution of command 'brew doctor' from terminal (CLI) leads to Segmentation fault - complete copy of terminal output and files mentioned in the following snippet are attached:
/usr/local/Homebrew/Library/Homebrew/cache_store.rb:24: [...
Dr.-Big-Man (Dr. Matthias H. Fröhlich)
12:57 PM Revision 0bceb471 (git): Improve docs for RubyVM::AST and RubyVM::AST::Node
* ast.c: [DOC] fix error in code example for RubyVM::AST::Node#type
(r63604 changed the return value of RubyVM::AST::Node#children);
enable link to RubyVM::AST.parse method; other minor improvements.
git-svn-id: svn+ssh://ci.ruby-la...
stomar (Marcus Stollsteimer)
09:54 AM Revision cdb312ab (git): lldb_rp: support T_CLASS,T_MODULE,T_ICLASS [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64909 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
09:54 AM Revision 8885389b (git): lldb_rp: use append_command_output [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64908 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
07:43 AM Revision 9df3c856 (git): Set indent_size of reg*.[ch] to 2 [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64907 b2dd03c8-39d4-4d8f-98ff-823fe69b080e znz (Kazuhiro NISHIYAMA)
06:48 AM Revision b68f2a4b (git): Use cd -P
Setting PWD in the process does not let `cd` traverse symlinks in
/bin/sh on macOS.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64906 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
06:19 AM Feature #15195: Deal with new Japanese era
Both plans are OK, but the latter seems fun for this big event. naruse (Yui NARUSE)
05:57 AM Feature #15195 (Closed): Deal with new Japanese era
As most people in Japan should know by now, a new era of the Japanese calendar will start in May 2019.
It is not clear when the new era name will be announced, but it may be at rather short notice.
The Unicode consortium has made u...
duerst (Martin Dürst)
05:59 AM Misc #15129: DevelopersMeeting20181010Japan
* [Feature 15195] How to deal with new Japanese era
* We should prepare early (even if it's just to check that we need to do nothing)
duerst (Martin Dürst)
05:45 AM Feature #14839: How to deal with capitalizing Georgian in Unicode 11.0.0
duerst (Martin Dürst) wrote:
> I just noticed that `String.capitalize` is actually more difficult than I thought. It is a no-op when applied to lowercase, but it will produce mixed case when applied to all uppercase text.
On the Un...
duerst (Martin Dürst)
04:49 AM Revision 1af64187 (git): support --with-arch=x86_64h
Recent apple machines describe themselves being x86_64h. That
architecture is somehow supported by their C compiler and at least
by recent clang. However config.sub does not know that fact so
making universal binary targeting it is rej...
shyouhei (Shyouhei Urabe)
04:37 AM Revision 39c4aeec (git): Fix wrong use of BIGNUM_EMBED_LEN_NUMBITS
* internal.h (BIGNUM_EMBED_LEN_SHIFT): BIGNUM_EMBED_LEN_NUMBITS is the
bit width of embedded bignum length, and BIGNUM_EMBED_LEN_SHIFT is
the bit offset of it. These two values happened to equal by chance,
however they are differe...
nobu (Nobuyoshi Nakada)
04:27 AM Revision fb35457f (git): lldb_rp: support more types [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64903 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
04:07 AM Revision 7c496b66 (git): lldb_rp: fix the order of results [ci skip]
The outputs from HandleCommand are printed immediately before print
statements. Fix the order in `result` by capturing the outputs.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64902 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)

10/02/2018

08:29 PM Feature #15192: Introduce a new "shortcut assigning" syntax to convenient setup instance variables
This has been requested a lot :-)
I still feel like it would be very practical, introduces no incompatibility, and is also very intuitive (at least to me). I feel that no Rubyist would have trouble learning what `def initialize(@somet...
marcandre (Marc-Andre Lafortune)
08:13 AM Feature #15192: Introduce a new "shortcut assigning" syntax to convenient setup instance variables
I personally tend to use (slower) setter-methods rather than initialization within `initialize()`
itself. Normally only for somewhat larger classes though; for small classes that do not do much,
I often don't bother writing setter meth...
shevegen (Robert A. Heiler)
06:42 AM Feature #15192: Introduce a new "shortcut assigning" syntax to convenient setup instance variables
This isn't Matz's but my experience. When "we want to do something more than just assigning instance variables", that "something" tends to include cancellation of creating new object -- maybe because we are returning a cached instance, ... shyouhei (Shyouhei Urabe)
06:18 AM Feature #15192: Introduce a new "shortcut assigning" syntax to convenient setup instance variables
Matz thinks this is handy only when you write `#initialize`, which only is not worth adding a new syntax for methods in general. Do you have any situations other than `#initialize` where this is useful? shyouhei (Shyouhei Urabe)
04:54 AM Feature #15192 (Assigned): Introduce a new "shortcut assigning" syntax to convenient setup instance variables
Motivation:
Introduce a new syntax for convenient setup instance variables for objects.
The problem:
Currently, setup instance variables in Ruby is too verbose.
Basically, we need to write the meaningless assigning code again ...
jjyr (Jinyang Jiang)
07:14 PM Revision 3cfe3051 (git): lldb_rp: reload debug info if not loaded yet [ci skip]
As debug infos in shared libraries are not accessible until loaded,
retry loading the infos when needed.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64901 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
06:52 PM Bug #15190: Null pointer dereference in process_options -- OOB read (size of 8 bytes)
2.5 also segfaults.
2.4 and earlier don't segfault, but fail with exit code 1.
As just a shebang code is also valid code, this should be backported to those versions.
nobu (Nobuyoshi Nakada)
06:51 PM Bug #15190 (Closed): Null pointer dereference in process_options -- OOB read (size of 8 bytes)
Applied in changeset trunk|r64900.
----------
Just a shebang is valid code
[ruby-core:89240] [Bug #15190]
nobu (Nobuyoshi Nakada)
06:51 PM Revision 4e133fdb (git): Just a shebang is valid code
[ruby-core:89240] [Bug #15190]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64900 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
06:03 PM Revision e1966b31 (git): Get rid of calling to_f in rat2dbl_without_to_f
[Bug #15189]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64899 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
04:55 PM Bug #15189: Multiple OOB reads (of size 4) in rb_bigzero_p
I'm not sure what caused the difference, and `call_cfunc_1` does not appear in both code on my machine.
That function should be simple enough to be eliminated by tail-call optimization.
nobu (Nobuyoshi Nakada)
04:42 PM Bug #15189 (Closed): Multiple OOB reads (of size 4) in rb_bigzero_p
Applied in changeset trunk|r64897.
----------
Fix Rational of Float
[ruby-core:89239] [Bug #15189]
nobu (Nobuyoshi Nakada)
02:25 PM Bug #15189: Multiple OOB reads (of size 4) in rb_bigzero_p
nobu (Nobuyoshi Nakada) wrote:
> Thank you for the report.
> ...
Thank you for the info about `\0`, I'll keep an eye out for that.
The reproducers were deduplicated based on a hash of their crash backtrace, using `afl-collect` from ...
bannable (Joe Truba)
12:26 PM Bug #15189: Multiple OOB reads (of size 4) in rb_bigzero_p
Thank you for the report.
Your reproducers seem often duplicated, and note that `\0` is treated as the EOF in the parser and anything after it has no effect at all.
Reduced (but not smallest) code are:
```
crash01/reproducer:111r...
nobu (Nobuyoshi Nakada)
04:42 PM Revision 80359687 (git): * 2018-10-03
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64898 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
04:42 PM Revision 603f95a0 (git): Fix Rational of Float
[ruby-core:89239] [Bug #15189]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64897 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
04:23 PM Feature #15181: Azure pipelines vc builds? help needed
@naruse
I've got vc12, vc14, and mingw all building and passing btest and test-basic.
Given that the current Appveyor build takes approx 90 minutes, and an Azure pipelines build could cut that down to approx 35 to 40 minutes, I tho...
MSP-Greg (Greg L)
07:28 AM Feature #14839: How to deal with capitalizing Georgian in Unicode 11.0.0
Changed from Misc to Feature. The Feature would be to add some option(s) to relevant methods such as `String#upcase`. The baseline (Feature rejected) is that there is no need for options.
`String#downcase` is unproblematic. `String#sw...
duerst (Martin Dürst)
07:13 AM Misc #15129: DevelopersMeeting20181010Japan
* [Feature #14839] How to deal with capitalizing Georgian in Unicode 11.0.0
I need feedback on this to be able to implement in in time for the Ruby 2.6 release.
duerst (Martin Dürst)
01:56 AM Revision 25ea4dc6 (git): * 2018-10-02
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64896 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
01:56 AM Revision 92b469e7 (git): Install HTML docs if produced
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64895 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)

10/01/2018

09:36 PM Bug #15191: Segfault in bignum.c bigtrunc()
And a second, slightly different, reproducer:
~~~
5555i**-515*45E555i**-511581115i**515*45E555i**-511555i**-51E555i**-511581115i**-515*45E55 == 5**-511551158111111
~~~
bannable (Joe Truba)
09:31 PM Bug #15191 (Closed): Segfault in bignum.c bigtrunc()
Reproducer:
~~~
jtruba@sf201:~/crashes/ruby/crash09$ cat reproducer
?% "a"*1*1**111%11**-11911**111
jtruba@sf201:~/crashes/ruby/crash09$
~~~
Crash and valgrind report:
~~~
jtruba@sf201:~/crashes/ruby$ valgrind ~/rubies/ruby-tru...
bannable (Joe Truba)
09:13 PM Bug #15190 (Closed): Null pointer dereference in process_options -- OOB read (size of 8 bytes)
When passed "#!" with no newline as a script, rb_parser_compile_string and load_file can return null, causing process_options to later perform a null pointer dereference.
This happens in 2.5 and trunk, but not 2.3 or 2.4.
Reproduce...
bannable (Joe Truba)
08:21 PM Bug #15189 (Closed): Multiple OOB reads (of size 4) in rb_bigzero_p
An AFL fuzzing session against 6b4d78fc43 this weekend and turned up 17 crashes in rb_bigzero_p.
I suspect that all of these are the same underlying bug -- they are all a 4 byte OOB read in rb_bigzero_p -- so I'm including all of them...
bannable (Joe Truba)
08:05 PM Misc #15186: `SecureRandom.random_number` is not documented
nobu (Nobuyoshi Nakada) wrote:
> It is a method of `Random::Formatter`, not of `SecureRandom`.
> ...
Oh... Nobuyoshi, thank you for pointing out! I missed it completely :(.
artur86 (Artur *)
12:44 PM Misc #15186 (Closed): `SecureRandom.random_number` is not documented
It is a method of `Random::Formatter`, not of `SecureRandom`.
https://ruby-doc.org/core-2.6.0.preview2/Random/Formatter.html#method-i-random_number
nobu (Nobuyoshi Nakada)
11:17 AM Misc #15186 (Closed): `SecureRandom.random_number` is not documented
I wonder if there is any reason why `SecureRandom.random_number` is not documented.
https://ruby-doc.org/stdlib-2.4.4/libdoc/securerandom/rdoc/SecureRandom.html
artur86 (Artur *)
07:01 PM Feature #14143: Thread.report_on_exception should be true by default
headius (Charles Nutter) wrote:
> I am really liking the flow of
> ...
Has these been any more discussion/movement around such a feature? my google-fu is failing me, and this is something that would be very useful so that I can push th...
stefan.sedich (Stefan Sedich)
06:36 PM Bug #15188 (Closed): Incorrect warning "assigned but unused variable" when using ripper with $VERBOSE = true
The following code:
require 'ripper'

class Parser < Ripper
def warn(fmt, *args)
puts "#{filename}:#{lineno} - #{fmt % args}"
end
end

if __FILE__ == $0 then
$VERBOSE = true
...
cout (Paul Brannan)
02:59 PM Feature #15151: String#slice!(0,..) creates a duplicate of original string
@nobu can you look into this? Thank you. chopraanmol1 (Anmol Chopra)
02:48 PM Revision 6b4d78fc (git): lldb_cruby.py: T_DATA support [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64894 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
01:45 PM Bug #15187 (Closed): IPv6 x-forwarded-host results in "bad URI" error
A request that normally works with IPv4 is failing for IPv6. The webrick server is running behind Apache2, which is setting the x-forwarded-* headers.
```
$ curl -k https://[fd20:8b1e:b255:8154:250:56ff:fea8:4d84]/something
<!DOCTYP...
kwinters (Ken Winters)
01:33 PM Bug #15179: Segfault caused by only 'loop{ x<<[] }'
## 補足
overcommitを無効とした場合でも,ubuntu 18.04LTSの場合でのみsegfaultが発生する事象はまだ残りました.ただし,ここで示したコードだけで再現できる事象ではなく,適当な検証コードを用意は出来ていません.大量のオブジェクトを割り当てた場合である点は同じですが,異なる原因であるかもしれません.
OS側に原因を求めるべきであるようにも思いますが,記録のため書き残しておきます.
aki.k (亜樹 小林)
04:09 AM Bug #15179: Segfault caused by only 'loop{ x<<[] }'
ありがとうございます.
~~~
$ cat /proc/sys/vm/overcommit_memory
0
$ sudo sh -c "echo 2 > /proc/sys/vm/overcommit_memory"
$ cat /proc/sys/vm/overcommit_memory
2
$ ruby -e 'x=[]; loop { x<<[] }'
[FATAL] failed to allocate memory
~~~
ご指...
aki.k (亜樹 小林)
03:32 AM Bug #15179 (Feedback): Segfault caused by only 'loop{ x<<[] }'
Linuxのオーバーコミットが怪しいと思うんですが、`vm.overcommit_memory` を無効に設定しても同じ現象が発生しますか? yugui (Yuki Sonoda)
12:02 PM Bug #14897: Unexpected behavior of `if` in specific code
ruby_2_5 r64893 merged revision(s) 63868,63870. nagachika (Tomoyuki Chikanaga)
12:02 PM Revision 06289734 (git): merge revision(s) 63868,63870: [Backport #14897]
Fix a bug of peephole optimization
```
if L1
L0:
jump L2
L1:
...
L2:
```
was wrongly optimized to:
```
unless L2
L0:
L1:...
nagachika (Tomoyuki Chikanaga)
08:53 AM Feature #14839: How to deal with capitalizing Georgian in Unicode 11.0.0
Some notes summarizing some discussions on Unicode-related lists and my current conclusions from these discussions:
- One problem is that fonts supporting MTAVRULI (using upper case to make it easier for everybody) are not yet availab...
duerst (Martin Dürst)
07:50 AM Revision b74f7fc3 (git): Removed Windows version condition
Seems all MSVC runtimes fails with EINVAL, regardless Windows version.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64892 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
06:22 AM Revision 574d844a (git): * 2018-10-01
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64891 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
06:22 AM Revision f0eecb15 (git): remove old VM profile counters.
* vm_insnhelper.c: remove `vm_profile_counter` because
it is replaced with debug_counters.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64890 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
ko1 (Koichi Sasada)
03:16 AM Bug #15137: Can't run brew cleanup
I guess this is a same issue as https://github.com/Homebrew/brew/issues/4923 = https://github.com/Homebrew/brew/issues/4943 = https://github.com/Homebrew/brew/pull/4949. wanabe (_ wanabe)
03:05 AM Feature #14802: Update Unicode data to Unicode Version 11.0.0
naruse (Yui NARUSE) wrote:
> Just a note, the definition of extended grapheme cluster is changed in Unicode 11
This is mentioned at http://www.unicode.org/versions/Unicode11.0.0/, so I was (vaguely) aware of it, but thanks for the re...
duerst (Martin Dürst)
02:23 AM Feature #15182 (Closed): Update extended grapheme cluster implementation for Unicode 11
Reported by naruse (Yui NARUSE) at https://bugs.ruby-lang.org/issues/14802#change-74213:
The definition of extended grapheme cluster is changed in Unicode 11 (Unicode® Standard Annex #29
UNICODE TEXT SEGMENTATION revision 33: https:/...
duerst (Martin Dürst)

09/30/2018

08:04 PM Feature #14097: Add union and difference to Array
@nobu this is not closed yet as https://github.com/ruby/ruby/pull/1758 is not merged yet. I have just rebased. ;) ana06 (Ana Maria Martinez Gomez)
07:03 PM Feature #15181 (Closed): Azure pipelines vc builds? help needed
Wasn't long ago that all the Appveyor CI did was a vc120 job. Now, with three jobs, it can get quite backed up. Also, Appveyor seems to be inconsistent, as the test times can vary quite a bit, along with intermittent failure issues.
...
MSP-Greg (Greg L)
04:53 PM Bug #15180 (Third Party's Issue): Segmentation fault at 0x00000001097ffffe
I have an alias called brewitup in my .zshrc that runs
~~~
brew update; brew upgrade; brew prune; brew cleanup; brew doctor
~~~
When I ran this it got hung up and gave me the error:
~~~
/usr/local/Homebrew/Library/Homebrew/cache...
hdaugherty (Holden Daugherty)
04:12 PM Bug #15130: Nested Timeouts hang on cygwin
@duerst
I thought that Cygwin & MSYS2/MinGW share some code (or may have some time ago). When running the code above, output as below:
```
ruby 2.6.0dev (2018-09-30 trunk 64889) [x64-mingw32]
Before sleeping
After sleeping, bef...
MSP-Greg (Greg L)
09:19 AM Bug #15130: Nested Timeouts hang on cygwin
duerst (Martin Dürst) wrote:
> This then also 'hangs', with CPU usage 0.0%. My understanding would be that this means that `strace` doesn't have much to show because there's nothing going on on the Ruby side.
Attached is the rest o...
duerst (Martin Dürst)
09:08 AM Bug #15130: Nested Timeouts hang on cygwin
normalperson (Eric Wong) wrote:
Eric, many thanks for your answers, and sorry to be late with my replies.
> If you don't hit Ctrl-C, what is the CPU usage of that script?
> ...
Using the Windows Task Manager, it's 0.0%.
> Als...
duerst (Martin Dürst)
12:16 PM Feature #11815: Proposal for method `Array#difference`
And analogously an method 'Array#intersection' would be valuable. Implementation could share most code. febeling (Florian Ebeling)
09:22 AM Bug #15179 (Closed): Segfault caused by only 'loop{ x<<[] }'
Segmentation fault is caused after many objects allocation instead of '強制終了'.
About 30sec and 16-26GB memory used.
## 環境
OS: Ubuntu 18.04LTS ja (日本語Remix) on VMware ESXi 6.7
RAM: 32GB
`apt install ruby-dev`
`user@ruby:~$ ruby...
aki.k (亜樹 小林)
02:22 AM Revision f886d716 (git): * expand tabs.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64889 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
02:22 AM Revision d7ea94fb (git): mjit_compile.c: improve assertion message
intentionally inserting tab to this line to test svn bot.
Also expanding the all tabs in this file, since this file does not exist
in old versions and so there's no risk of conflict on backport.
git-svn-id: svn+ssh://ci.ruby-lang.org/r...
k0kubun (Takashi Kokubun)

09/29/2018

05:49 PM Revision ef69efef (git): no-op if it is T_STRING
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64887 b2dd03c8-39d4-4d8f-98ff-823fe69b080e naruse (Yui NARUSE)
05:49 PM Revision 47a02bff (git): * 2018-09-30
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64886 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
05:49 PM Revision 19e6af9f (git): * expand tabs.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64885 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
05:49 PM Revision 7bcc535a (git): Remove unnecessary use of function pointer
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64884 b2dd03c8-39d4-4d8f-98ff-823fe69b080e naruse (Yui NARUSE)
03:54 PM Bug #14807: 2.6.0-preview2 segfaults on OpenBSD due to missing pthread_condattr_init call
Hi,
Wheather `PTHREAD_COND_INITIALIZER` is work on OpenBSD or not, it should be used for initialize `pthread_cond_t` variable and
it should not be used for initialize `pthread_condattr_t` variable since they are diffrernet type and i...
taca (Takahiro Kambe)
03:43 PM Bug #15178 (Closed): Wrong paramaters passing to pthread_setname_np(3)
Ruby 2.6.0-preview2の動作を調べている途中で見つけました。
[Bug #9586]の修正r45713で、NetBSDの場合のpthread_setname_np(3)の引数を修正しています。
ここは第2引数と第3引数を入れ替えるのではなく、単に二重引用符を適切にquoteするだけとすべき
だったのではないでしょうか。
また、実際にthread_pthread.cで`SET_CURRENT_THREAD_NAME`を介してpthread_...
taca (Takahiro Kambe)
02:14 PM Feature #11815: Proposal for method `Array#difference`
I could use this method for fixing this bug [1] in ActiveRecord.
To me it looks like a valuable addition.
It's about replacing collection associations which can be partially persisted, with persisted records being handled differen...
febeling (Florian Ebeling)
11:12 AM Bug #15177 (Closed): 起動した後にTZを変更するとTime#utcがずれることがある
起動時に `TZ` を `right/Asia/Tokyo` にしていると `Time#utc` でローカルタイムと同じ時分秒になりますが、 `TZ=Asia/Tokyo` で起動してから `ENV['TZ']='right/Asia/Tokyo'` で変更すると `Time#utc` の結果がうるう秒のぶんだけずれます。
```
$ TZ=Asia/Tokyo ruby -ve "ENV['TZ']='right/Asia/Tokyo';t=Time.at(2...
znz (Kazuhiro NISHIYAMA)
07:21 AM Revision fe0818c4 (git): common.mk: upgrade benchmark_driver
since maybe r64870 implicitly depends on
https://github.com/benchmark-driver/benchmark-driver/pull/47 too.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64883 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
k0kubun (Takashi Kokubun)
07:04 AM Revision a0ff2a6a (git): Expand gemspec path to the real path
`make install` has loaded forwardable.rb twice, from
forwardable.gemspec and prime.gemspec.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64882 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
06:47 AM Bug #15162 (Closed): Encoding::Converter.search_convpath(Encoding::ASCII_8BIT, Encoding::Emacs_Mule) crashes on MinGW
Applied in changeset trunk|r64879.
----------
transcode.c: add GC guard on raise
* transcode.c (econv_s_search_convpath): add GC guard to fix SEGV
on raise.
[Bug #15162] [ruby-core:89172]
Anonymous
06:46 AM Bug #15162: Encoding::Converter.search_convpath(Encoding::ASCII_8BIT, Encoding::Emacs_Mule) crashes on MinGW
Thank you for test.
This issue seems to be related to #12411 fix.
h.shirosaki (Hiroshi Shirosaki)
06:47 AM Revision b8c23ce3 (git): * expand tabs.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64881 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
06:47 AM Revision 29b2ea6b (git): Revert search_convpath spec
Remove .name since SEGV on MinGW is fixed.
[ruby-core:89200]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64880 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
h.shirosaki (Hiroshi Shirosaki)
06:47 AM Revision b965781e (git): transcode.c: add GC guard on raise
* transcode.c (econv_s_search_convpath): add GC guard to fix SEGV
on raise.
[Bug #15162] [ruby-core:89172]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64879 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
h.shirosaki (Hiroshi Shirosaki)
12:45 AM Bug #15175 (Closed): Segfault (Invalid read of size 4) in rb_bigzero_p
Applied in changeset trunk|r64877.
----------
rational.c: may be float
* rational.c (f_muldiv): Integer#** can return Rational with Float
right now. [ruby-core:89212] [Bug #15175]
nobu (Nobuyoshi Nakada)
12:45 AM Revision 4add701a (git): * expand tabs.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64878 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
12:45 AM Revision 36c4713e (git): rational.c: may be float
* rational.c (f_muldiv): Integer#** can return Rational with Float
right now. [ruby-core:89212] [Bug #15175]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64877 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
12:43 AM Revision c655db52 (git): * 2018-09-29
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64876 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
12:43 AM Revision 85aee954 (git): Split assertion expressions
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64875 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)

09/28/2018

10:56 PM Bug #15175 (Closed): Segfault (Invalid read of size 4) in rb_bigzero_p
My build is built with jemalloc, but the crash also happens without.
Note: this error only happens when ruby is run with --disable=gems. I'm unsure why.
Reproducer:
~~~
jtruba@sf201:~/rubies/ruby-trunk-clean$ cat poc
V = 1118111...
bannable (Joe Truba)
10:45 PM Bug #15174 (Rejected): Sorting array of elements using "&:size" block, in which more than 1 element
An expected behavior. nobu (Nobuyoshi Nakada)
10:25 PM Bug #15174: Sorting array of elements using "&:size" block, in which more than 1 element
You want `sort_by`, not `sort`:
~~~ ruby
[1..2, 4..5].sort_by(&:size)
# => [1..2, 4..5]
~~~
The difference in behavior between `{ |x| x.size }` and `(&:size)` is due to how ruby handles `Symbol#to_proc` when multiple arguments a...
jeremyevans0 (Jeremy Evans)
09:30 PM Bug #15174 (Rejected): Sorting array of elements using "&:size" block, in which more than 1 element
Example with ranges(first with what defined bug), but also tested on strings, symbols, integers
Good
~~~ ruby
[1..2].sort { |x| x.size }
[1..2, 4..5].sort { |x| x.size }
[1..2].sort(&:size)
~~~
Bad
~~~ ruby
[1..2, 4..5].sort...
Mr_Cartoon (Mr Cartoon)
06:04 PM Misc #15129: DevelopersMeeting20181010Japan
* [Feature #15144] `Enumerator#chain` zverok (Victor Shepelev)
12:50 PM Bug #15173: Segmentation fault
When I replace this:
~~~ ruby
16 return [] unless s3.file_exists?(date, region_dirname)
17 CSV.parse(s3.contents(date, region_dirname)).drop(1).map do |value|
18 with_date = value.push(date.to_s)
...
dmartindelorme (Dorian Martin)
08:05 AM Bug #15173 (Closed): Segmentation fault
Here is the code I'm trying to run:
~~~ ruby
6 def self.sync(db, s3, from, to)
7 db.create_table(SQL::Schema.table(TABLE_NAME))
8 from = Date.parse(from)
9 to = Date.parse(to)
10 keys = SQL::Sch...
dmartindelorme (Dorian Martin)
09:23 AM Revision a9375ab3 (git): Adjust indent [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64874 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
09:16 AM Bug #15162: Encoding::Converter.search_convpath(Encoding::ASCII_8BIT, Encoding::Emacs_Mule) crashes on MinGW
MSP-Greg (Greg L) wrote:
> Benoit - I can't seem to ping you using either @eregon or @Eregon
Odd, not sure why it doesn't work.
Eregon (Benoit Daloze)
12:43 AM Bug #15162: Encoding::Converter.search_convpath(Encoding::ASCII_8BIT, Encoding::Emacs_Mule) crashes on MinGW
@hsbt & @h.shirosaki
I apologize for that mistake. I hope to not make it again.
We have a saying something like 'foot in mouth' referring to speech. I'm not sure what the equivalent is for written... Thanks, Greg
MSP-Greg (Greg L)
12:24 AM Bug #15162: Encoding::Converter.search_convpath(Encoding::ASCII_8BIT, Encoding::Emacs_Mule) crashes on MinGW
@MSP-Greg
You mistake to mention about `@shirosaki`, not `@hsbt`.
hsbt (Hiroshi SHIBATA)
06:25 AM Revision 41aa841a (git): Add Range#% to call-seq [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64873 b2dd03c8-39d4-4d8f-98ff-823fe69b080e znz (Kazuhiro NISHIYAMA)
05:28 AM Revision f251ce9f (git): don't use GC::Profiler on default.
* benchmark/gc/gcbench.rb: disable GC::Profiler on default.
add -p option instead.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64872 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
ko1 (Koichi Sasada)
03:35 AM Revision aa1023ed (git): add debug counters more.
* debug_counter.h: add debug counters to count frame state transitions:
* frame_R2R: Ruby frame to Ruby frame
* frame_R2C: Ruby frame to C frame
* frame_C2C: C frame to C frame
* frame_C2R: C frame to Ruby frame
* vm_insnhelper....
ko1 (Koichi Sasada)
03:32 AM Revision cebd2c4a (git): add small utility for benchmarking.
* benchmark/lib/load.rb: add small utility which requires
benchmark-driver.rb. You can load this file and can
use benchmark-driver.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64870 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
ko1 (Koichi Sasada)
02:42 AM Feature #13618: [PATCH] auto fiber schedule for rb_wait_for_single_fd and rb_waitpid
shannonskipper@gmail.com wrote:
> Thread::Light seems nice. Or how about Thread::Feather? A
> thread as lights as a feather.

Sorry, but no to "Feather". Again, I don't want to introduce new
usage of words.

"Light" is common us...
normalperson (Eric Wong)
02:19 AM Feature #14697 (Closed): Introducing Range#% as an alias to Range#step
Applied in changeset trunk|r64869.
----------
range.c: Add Range#%
[Feature #14697] [ruby-core:86588]
mrkn (Kenta Murata)
02:18 AM Revision 85f192b0 (git): range.c: Add Range#%
[Feature #14697] [ruby-core:86588]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64869 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Kenta Murata
01:10 AM Revision b7d63679 (git): * 2018-09-28
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64868 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
01:10 AM Revision df5ec410 (git): add debug counters more.
* debug_counter.h: add the following counters.
* frame_push: control frame counts (total counts).
* frame_push_*: control frame counts per every frame type.
* obj_*: add free'ed counts for each type.
* gc.c: ditto.
* vm_insnhelpe...
ko1 (Koichi Sasada)
12:48 AM Feature #15166: 2.5 times faster implementation than current gcd implmentation
No, no. You can just use `__builtin_ctzl` when it is available. All you need is check if it is available or not, and keep the original code for the case where `__builtin_ctzl` is unavailable. Gcc and clang provide it, so it is actuall... mame (Yusuke Endoh)
 

Also available in: Atom