Activity
From 09/19/2018 to 09/25/2018
09/25/2018
-
11:31 PM Revision ac178357 (git): Expand spec files to realpaths
- * spec/mspec/lib/mspec/utils/script.rb (MSpecScript#entries): expand
the given spec path to the realpath, not to require a library by
realpath and symbolic link path from the spec file.
reapply r64749 and r64751 overridden by r648... -
10:33 PM Feature #15161 (Closed): making gcd faster for 3x3
- It already uses the variant of the binary (Stein's) algorithm.
https://github.com/ruby/ruby/blob/3abbaab1a7a97d18f481164c7dc48749b86d7f39/rational.c#L285-L307
See #13503. -
09:05 PM Feature #15161: making gcd faster for 3x3
- I think a benchmark may be useful to the issue here.
I don't think the ruby team minds any speed improvement but what
is usually done is to verify any potential gain through benchmarks
(e. g. optcarrot for, I think, ruby 3x3 goals). -
06:14 PM Feature #15161 (Closed): making gcd faster for 3x3
- With the goal of making Ruby as fast as possible for 3x3 I would like to propose
a faster implementation of the ``gcd`` function. I use ``gcd`` a lot in my
``primes-utils`` gem, and in cryptography and Number Theory problems.
The cu... -
10:20 PM Misc #15129: DevelopersMeeting20181010Japan
- * [Feature #11505] Module#=== should call #kind_of? on the object rather than rb_obj_is_kind_of which only searches the ancestor heirarchy
* This would allow patterns as Decorator and Proxy to work with case statements. -
08:30 PM Bug #15152: Thread Crashes
- It turns out the Ubuntu computer was freezing due to an unstable overclock of the RAM. Perhaps the thread crashed because my code or a library I'm using is not thread safe.
- 06:47 PM Revision 3abbaab1 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64844 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
06:47 PM Revision e2d74af3 (git): Update to ruby/mspec@2bca8cb
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64843 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 06:13 PM Revision 2466288d (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64842 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
06:13 PM Revision cdc614cd (git): refactoring debug_counter.
- * debug_counter.h: add comments for each counters.
* debug_counter.h: add some counters (see added comments for details).
* obj_newobj
* obj_newobj_slowpath
* obj_newobj_wb_unprotected
* obj_hash_empty
* obj_hash_under4
* ob... -
05:26 PM Revision 989fc2de (git): appveyor.yml: increase timeout for vs
- because `TestThreadQueue#test_queue_with_trap` is too unstable
especially on vs140.
https://ci.appveyor.com/project/ruby/ruby/build/9731/job/sevjm9lrmssg4dub
Increasing timeout may not fix the issue, but let me test this first to
check ... -
- as a workaround to fix the build pipeline broken by r64824,
because optimizing Ruby should be prioritized higher than supporting unused jokes.
In the current build system, exceeding 200 insns somehow crashes C
extension build on some of... -
- This reverts commit r64829. I'll prepare another temporary fix, but I'll
separately commit that to make it easier to revert that later.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64838 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:50 PM Bug #15160 (Closed): ArgumentError: year too big to marshal
- I encountered the problem, that marshaling a Time object does not always work.
Try run following commands in irb that will raise an error:
~~~ ruby
Marshal.dump(Time.new(1900))
#Traceback (most recent call last):
# 3: fro... - 03:31 PM Revision 3f4d174c (git): * 2018-09-26
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64837 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:31 PM Revision f73d504c (git): dir.c: fix glob with recursive and brace
- Fixed bug that glob with recursive and braces (**/{a,b}) pattern
fails.
[Feature #13167]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64836 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- join_path uses malloc. So free is required.
[Feature #13167]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64835 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:05 PM Bug #15159 (Third Party's Issue): Some options of win32screenshot gem not working with Ruby 2.5.1.
- Hello,
The following options are not working for the win32screenshot gem (or possibly rautomation) in Ruby 2.5.1. The error I get is below. I have attached a log as well. The code works in Ruby 2.4.4.
C:/Selenium_Ruby/runtime/li... - 01:42 PM Revision 7ef91e62 (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64834 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64833 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
11:26 AM Feature #11625: Unlock GVL for SHA1 calculations
- Hi,
I had a similar problem like Aaron, but with MD5 instead of SHA1. I stumbled upon this thread and completed the patch for all digest algorithms.
Hope it helps!
best,
Steve
- 10:41 AM Revision b3484e59 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64832 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64831 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64830 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
09:32 AM Bug #15130: Nested Timeouts hang on cygwin
- duerst@it.aoyama.ac.jp wrote:
> When I run this, I get all the expected output, as follows:
> ```
> Before sleeping
> After sleeping, before method call
> Before sleeping in method
> After sleeping in method
> ```
> but this scr... -
- duerst@it.aoyama.ac.jp wrote:
> normalperson (Eric Wong) wrote:
>
> > Is there something which shows system call traces which could be
> > useful in diagnosing this?
>
> `strace` seems to do that, see https://cygwin.com/cygwin... -
06:32 AM Bug #15130: Nested Timeouts hang on cygwin
- I managed to create a very short script that seem so recreate the problem (or at least something similar).
It seems to happen with a `Timeout` inside a `Timeout` (I didn't manage to create a problem with only one `Timeout`).
Here's... -
- normalperson (Eric Wong) wrote:
> Is there something which shows system call traces which could be
> ...
`strace` seems to do that, see https://cygwin.com/cygwin-ug-net/strace.html.
```
strace ./ruby -ropen-uri -e 'open "http://... -
- duerst@it.aoyama.ac.jp wrote:
> What I was wondering is: Why do things get stuck in a case
> where the Timeout isn't actually invoked (as far as I
> understand). Shouldn't the program just move ahead? Any
> background information on... -
- duerst@it.aoyama.ac.jp wrote:
> normalperson (Eric Wong) wrote:
> > This brings the Cygwin pthreads timer thread closer to what was
> > in 2.5 by setting ec->interrupt_flag (via rb_threadptr_check_signal):
> >
> > https://80x2... -
- What I was wondering is: Why do things get stuck in a case where the Timeout isn't actually invoked (as far as I understand). Shouldn't the program just move ahead? Any background information on what may be happening and why is appreciat...
-
- normalperson (Eric Wong) wrote:
> This brings the Cygwin pthreads timer thread closer to what was
> ...
Thanks!
Should I use together with or separately from 0001-thread_pthread.c-fall-back-to-UBF_TIMER_PTHREAD-for-.patch ?
-
- https://github.com/rubygems/rubygems/issues/2408
-
04:03 AM Feature #15156 (Third Party's Issue): Have a 'c_headers' specifier in Gem::Specification.
- Currently if one Ruby gem depends on the C extension of another Ruby gem, the only way
find the header of that gem is to run a `Gem::Specification.find_by_name` in the extconf.rb
of the gem needing the header and then adding the folder... -
- AppVeyor msys2/MinGW build started to fail like:
https://ci.appveyor.com/project/ruby/ruby/build/9722/job/b94kixi004klmye3
Until I can investigate that, I revert this for now.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64829 b2d... -
- foonlyboy (Eike Dierks) wrote:
> I believe that `%p` is for pointers.
It's true in C, but Ruby does not show bare pointers.
`%p` calls `inspect` instead.
> ...
I meant that such library would need to stick the old behavior or
br... -
12:53 AM Feature #15149: extend string format to nil safe
- Hi nobu,
thanks for your reply, let's talk about this
I believe that `%p` is for pointers.
Actually `%p` already behaves like this:
```ruby
'%p' % nil #=> "nil"
```
(I was not aware of that)
Please explain your complaints a... -
03:02 AM Bug #15154 (Closed): OpenBSD make(1) can't build node_name.inc
- The [make(1)](https://man.openbsd.org/make) command in OpenBSD can't build node_name.inc of Ruby trunk in an out-of-source build. GNU make works. OpenBSD make misses node.h in the source directory, and tries to use node.h in the build ...
09/24/2018
- 11:23 PM Revision b0156ad0 (git): * 2018-09-25
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64828 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * test/lib/test/unit.rb (Test::Unit::SubprocessOption#non_options):
set timeout scale after parsing options. the option value will be
set after returning from setup_options.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64827 b... -
- Any object which has `#write` method can be assigned to `$stderr`, so we should not expect `$stderr` to have `p`, I think.
-
- Feature suggestion #15112 Introduce the new singleton method STDERR.p (by Kenta Murata)
I am mostly curious what the ruby core team thinks about Kenta Murata's proposal; it probably will not take too much time away discussing it briefly... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64826 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64825 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- not optimizing Array#& and Array#| because vm_insnhelper.c can't easily
inline it (large amount of array.c code would be needed in vm_insnhelper.c)
and the method body is a little complicated compared to Integer's ones.
So I thought only... -
- > https://bugs.ruby-lang.org/issues/15146
Thanks, committed as r64823 -
- Applied in changeset trunk|r64823.
----------
webrick: raise EOFError in parse when read line is nil
[Bug #15146]
From: Justin Li <git@justinli.net> - 07:48 AM Revision 1aef602d (git): webrick: raise EOFError in parse when read line is nil
- [Bug #15146]
From: Justin Li <git@justinli.net>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64823 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64822 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- which was solved by r64820
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64821 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- by sharing vm_call_iseq_setup_normal. This is a retry of r64280.
vm_insnhelper.c: Remove unused argument `ci` and pass `me` instead of
`cc` to share this with JIT. Declare this with ALWAYS_INLINE to make
sure this function is inlined in... - 03:14 AM Revision b96ff9e0 (git): * 2018-09-24
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64819 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:14 AM Revision b0daae1d (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64818 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * lib/rubygems/core_ext/kernel_warn.rb (Kernel#warn): skip
kernel_require.rb's frames when `uplevel` option is given.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64817 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Rather it feels the role of `inspect`, that is used by `%p`.
Regarding the compatibility, that new format string can't work with earlier versions.
That means libraries which want to support earlier versions can't use it.
09/23/2018
-
- When I run my rails test suite with the parallel_test gem a thread crashes. The test suite completely passes when I don't run the tests in parallel and it also works fine when I run unit tests in parallel, but if I run enough system test...
-
03:27 PM Feature #15151 (Open): String#slice!(0,..) creates a duplicate of original string
- String#slice! when used at beginning of string (e.g. slice!(0,10)) calls rb_str_drop_bytes which creates shared string for non embedded string. str_modify_keep_cr clears the flag of shared string which is called before rb_str_drop_bytes....
-
- * test/test_win32api.rb: suppress a warning, which we know already
well.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64816 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- duerst@it.aoyama.ac.jp wrote:
>
> Please tell me what I can do to help you solve this problem.
Oops, I guess pthread_kill isn't going to work in cygwin :x
This brings the Cygwin pthreads timer thread closer to what was
in 2.5 ... -
- > https://bugs.ruby-lang.org/issues/14807#change-74146
Right, already in trunk at r63548
And back to Jeremy's earlier comment:
> It's defined but I don't think it would be usable:
>
> /usr/include/pthread.h:#define PTHREAD_CON... -
- After this commit is merged, some CIs that has -DVM_CHECK_MODE=2 and continue to test latest revision started to randomly crash "TestGem#test_load_plugins":
http://ci.rvm.jp/results/trunk-asserts@silicon-docker
http://ci.rvm.jp/results...
09/22/2018
-
- On Appveyor, WIN32OLE sometimes fails due to a system shutdown, and
`@ie` is not assigned.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64815 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I'd like to suggest a new modifier for the string format
(aka the printf-style format string)
## Examples
### Current
~~~
'%s' % nil => ''
'%d' % nil => Exception: TypeError: can't convert nil into Integer
~~~
### Suggestio... -
-
06:14 PM Bug #15148 (Rejected): String::instance_methods size is different String#methods size after call pp method - I'm sorry, my English is poor.i'm sorry i find this is not a bug, please help me close this issue,
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64814 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 08:13 PM Revision 450107ef (git): * 2018-09-23
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64813 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- c.f. https://github.com/mistydemeo/tigerbrew/issues/473
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64812 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
06:08 PM Bug #14807: 2.6.0-preview2 segfaults on OpenBSD due to missing pthread_condattr_init call
- Hi,
The similar problem occurs on NetBSD 8.0_STABLE. (And I belive it would be occur on 7.2.)
`PTHREAD_COND_INITIALIZER` is for `pthread_cond_t` not for `pthread_condattr_t`.
So, initializing `condattr_mono` (via `condattr_monoto... -
05:11 PM Bug #15147 (Third Party's Issue): Mac OSX (brew) reported: You may have encountered a bug in the Ruby interpreter or extension libraries
- running: brew update --verbose on my Mac. Note: brew doctor seems to have a similar error. The runtime asked me to report this to you folks, so I am.
==> Checking dependents for broken library links
/usr/local/Homebrew/Librar... -
03:31 PM Bug #15146 (Closed): [PATCH] webrick: raise EOFError in parse when read line is nil
- If the IO object being read during parse returned `nil` from `gets`, a NoMethodError would be raised calling `bytesize` on `nil`. Instead, an `EOFError` should be returned. This bug has been present since r14260.
https://github.com/ru... - 01:11 AM Bug #13167 (Closed): Dir.glob is 25x slower since Ruby 2.2
- Applied in changeset trunk|r64810.
----------
dir.c: performance fix with braces
Braces were expended before ruby_glob0(). This caused to call
replace_real_basename() for same plain patterns repeatedly.
Move blace expansion into glob_h... - 01:11 AM Revision 50c16d52 (git): * 2018-09-22
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64811 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Braces were expended before ruby_glob0(). This caused to call
replace_real_basename() for same plain patterns repeatedly.
Move blace expansion into glob_helper() in ruby_glob0() to reduce
replace_real_basename() call.
This fix changes th... -
12:06 AM Feature #15145: chained mappings proposal
- koenhandekyn (koen handekyn) wrote:
> proposal allow
> ...
Is it possible for you to share your trivial implementation of passing more than one block to a method? :)
It is true that the implementation of something like:
~~~ ruby
...
09/21/2018
-
- > Obviously, the effect could be reached with flat_map
I always found that name weird so ... assumingly that it is the same
as .flatten.map, I always used the latter. :-)
(I don't recall flat_map offhand and I happily admit that I... -
07:00 PM Feature #15144 (Closed): Enumerator#chain
- I am not sure I am not missing something, but...
```ruby
[1, 2, 3].each.chain([3, 4, 5].each) # => Enumerator
```
...seem to be a useful pattern.
It especially shows itself in case of lazy enumerators, representing several long... -
- (I think you filed this in the wrong section; right now it is under Bugs, but it looks
like a feature so it should go into
https://bugs.ruby-lang.org/projects/ruby-trunk/issues?set_filter=1&tracker_id=2 )
At any rate, to the sugges... -
07:27 PM Feature #15145 (Open): chained mappings proposal
- propsal, have map accept array of method references to make chained mapping simpler with suggestion to implement it to behave like the &. operator so that intermediate nil values just ripple through as nil values
proposal allow
~~... -
05:58 PM Feature #13618: [PATCH] auto fiber schedule for rb_wait_for_single_fd and rb_waitpid
- Thread::Light seems nice. Or how about Thread::Feather? A thread as light as a feather.
-
02:17 PM Feature #10208 (Closed): Passing block to Enumerable#to_h
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64809 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- [Fix GH-1958]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64808 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 10:19 AM Revision 2def5250 (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64807 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- [Fix GH-1958]
From: Jun Aruga <jaruga@redhat.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64806 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
08:53 AM Revision 2617dfa9 (git): Fix sample code [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64805 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- The same issue is already marked to backport in #14897.
Please wait for 2.5.2. -
08:17 AM Bug #14959: Writing a "link_to" method and a "url_helper" with a request parameter under certain "if else" statement in Rails helper crashes with KERN_INVALID_ADDRESS at 0x0000000000000000
- I'm not sure if it's going to be backported to current stable version 2.5 but let me clarify couple things just in case for future.
* This is issue does not depend neither rails nor bootsnap
* Yet another minimal reproducible code to... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64804 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- I agree with Eric.
It is too annoying to rewrite flip-flop.
A patch for flip-flop I found today is:
```diff
diff --git a/tool/enc-unicode.rb b/tool/enc-unicode.rb
index d953014952..c05d02358c 100755
--- a/tool/enc-unicode.rb
... - 07:19 AM Revision 89874314 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64803 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * tool/darwin-cc: ld in Apple's recent Xcode warns text-based stub
files, which are probably caused by Apple's broken package.
hide such (and architecture deprecation) warnings during
configuration to pass TRY_LDFLAGS.
git-svn-id:... -
- Applied in changeset trunk|r64800.
----------
escape all env properly.
* vm_backtrace.c (rb_debug_inspector_open): escape all env using
`rb_vm_stack_to_heap()` before making bindings.
[Bug #15105]
There is a complicated story of... - 06:41 AM Revision 02cb9c93 (git): * remove trailing spaces.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64801 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * vm_backtrace.c (rb_debug_inspector_open): escape all env using
`rb_vm_stack_to_heap()` before making bindings.
[Bug #15105]
There is a complicated story of this issue:
Without this patch, IFUNC frame does not escaped. A IFUNC ... -
- * vm_exec.h (DEBUG_END_INSN()): use `ec` instead of `th`.
This macro is used when `VMDEBUG > 0`.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64799 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I applied the patch, but got the same problem: I had to use Ctrl-C, and got essentially the same backtrace:
Traceback (most recent call last):
15: from -e:1:in `<main>'
14: from /cygdrive/c/Data/ruby_test_patch_pthre... -
- normalperson (Eric Wong) wrote:
> Martin: can you try the attached patch? And please commit it if it works.
Thanks a lot for your patch. I'm working on trying it out, but I will only have the results later in my (Japanese) afternoon... -
- Martin: can you try the attached patch? And please commit it if it works.
```
thread_pthread.c: fall back to UBF_TIMER_PTHREAD for Cygwin
UBF_TIMER_NONE is not useful until we can make all I/O
non-blocking <https://b... -
04:14 AM Feature #14722: python's buffer protocol clone
- I agree with this request and filed a similar bug: https://bugs.ruby-lang.org/issues/13767.
-
02:23 AM Feature #15143: Extend `Enumerable#to_h`
- nobu (Nobuyoshi Nakada) wrote:
> OK, not only `Enumerable`, but `Array`, `Hash`, `ENV`, `NilClass` and `Struct` too?
Thanks for reminding me about that and implementing it. -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64798 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
09/20/2018
-
10:40 PM Bug #14972: Net::HTTP inconsistently raises EOFError when peer closes the connection
- If `@socket.read clen, dest` reads fully `clen` bytes then that seems ok. But if it can read fewer than `clen` bytes, then we should keep reading until we read `clen` bytes or reach EOF.
- 06:24 PM Revision 9b2cf4fb (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64797 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 06:24 PM Revision 19fe6552 (git): Matrix: Add #reflexive? method. [Fix GH-1730]
- Adapted from a patch by Yilo
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64796 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r64794.
----------
Enumerable#to_h with block and so on
[Feature #15143] -
- `nil` isn't an `Enumerable`, so it's irrelevant.
-
- OK, not only `Enumerable`, but `Array`, `Hash`, `ENV`, `NilClass` and `Struct` too?
-
- Matz, thanks for confirmation. I am happy with my original proposal.
-
07:27 AM Feature #15143: Extend `Enumerable#to_h`
- I don't agree with @mame's idea. The return value from the block should be strictly 2 elements array.
Matz.
-
- I changed my mind when I approved `to_h`.
Matz.
-
- mame (Yusuke Endoh) wrote:
> If the block returns an array whose length is > 2, how does it behave?
> ...
My original proposal is to follow the behaviour of the current `map.{...}.to_h`, which means to raise `ArgumentError: wrong array... -
- Sorry that I missed the previous duplicate proposals (I found that I had even commented on one of them, which I had forgotten about). But it looks like four years have passed since then, and the situation has changed perhaps. Or, it may ...
-
06:25 AM Feature #15143: Extend `Enumerable#to_h`
- nobu (Nobuyoshi Nakada) wrote:
> Have you changed the mind since #10208?
Or since... #666!
-
- If the block returns an array whose length is > 2, how does it behave?
```
%w(aa1 ab2 ba3 bb4).to_h {|s| s.chars }
#=> { "a" => { "a" => "1",
"b" => "2" },
"b" => { "a" => "3",
"b" => "4" }... -
- Have you changed the mind since #10208?
-
- Sounds reasonable. Accepted.
Matz. -
- I forgot to mention that people alternatively do:
```ruby
(1..5).each_with_object({}){|x, h| h[x] = x ** 2}
#=> {1=>1, 2=>4, 3=>9, 4=>16, 5=>25}
```
which may be more optimal than calling `map`. The proposed feature also has the... -
- Often, we call `Array#to_h` to the result of `Enumerable#map`:
```ruby
(1..5).map{|x| [x, x ** 2]}.to_h
#=> {1=>1, 2=>4, 3=>9, 4=>16, 5=>25}
```
I am thinking of a feature to do this in a single method call.
Currently, `Enum... - 03:06 PM Revision a64338ce (git): * 2018-09-21
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64795 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- [Feature #15143]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64794 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64793 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
02:00 PM Feature #10208: Passing block to Enumerable#to_h
- So, exactly the same proposal linked above got accepted. The name wasn't actually a problem!
Well, congratulations anyway! 😆 -
09:41 AM Misc #15136: Fix -Wparentheses warnings
- > I will update and rebase my pull-request for the way.
I updated and rebased my pull-request now!
You can pick up and merge a part of the pull-request, if you like it.
-
- > IIRC, matz has rejected the 1st case, and preferred explicit comparison with 0.
@nobu you mean basically like this?
```
if (success = compile_c_to_o(c_file, o_file)) {
```
to
```
if ((success = compile_c_to_o(c_file,... -
- Those 2 cases are actually different.
IIRC, matz has rejected the 1st case, and preferred explicit comparison with 0.
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64792 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- > https://bugs.ruby-lang.org/issues/15130#change-74114
I think I know what's going on (but need to do offline stuff).
Should have a patch for you to test in a few hours. -
- This issue doesn't exist before #15072 started at r64485 and made it impossible to check whether open-uri works or not. I'm assigning this to Eric (normalperson) because it may well be timeout-related. Sorry if that turns out not to be t...
-
05:31 AM Revision d6d444d6 (git): fix typo [ci skip]
- This error does not happen right now so this typo is
not serious, unless you locally edit insns.def.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64791 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- duerst (Martin Dürst) wrote:
> That fix worked, thanks! Committed with r64635, okay on travis, not sure about other CIs.
Sorry for reopening. It seemed to work, but it left #15130. So I'm reopening this.
The issue here started wit... -
- Applied in changeset trunk|r64787.
----------
Add union method to Array
I introduce a `union` method equivalent to the `|` operator, but which
accept more than array as argument. This improved readability, and it
is also coherent with ... -
- Avoid repeating code and improve readability in `rb_ary_or` and
`rb_ary_union_multi`. Similaty as done with `rb_ary_union`.
[Fix GH-1747] [Feature #14097]
From: Ana María Martínez Gómez <ammartinez@suse.de>
git-svn-id: svn+ssh://ci.ru... -
- `Array#uniq` is not really related with `Array#|`, so I replaced it by
`Array#union`.
[Fix GH-1747] [Feature #14097]
From: Ana María Martínez Gómez <ammartinez@suse.de>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64789 b2dd03c8-... -
- Avoid repeating code and improve readability in `rb_ary_or` and
`rb_ary_union_multi`.
[Fix GH-1747] [Feature #14097]
From: Ana María Martínez Gómez <ammartinez@suse.de>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64788 b2dd03c8-... -
- I introduce a `union` method equivalent to the `|` operator, but which
accept more than array as argument. This improved readability, and it
is also coherent with the `+` operator, which has a similar `concat`
method. The method doesn't ... -
- Applied in changeset trunk|r64786.
----------
parse.y: fix block passing with empty kwargs
* parse.y (arg_blk_pass): preceeding arguments node may be NULL when
an empty keyword argument hash splat is optimized away.
[ruby-core:8889... -
- mame (Yusuke Endoh) wrote:
> Good catch. My patch for #15052 will fix this issue.
We have never agreed with how to fix #15052 yet. Nobu is working on this issue without behavior change. -
- * parse.y (arg_blk_pass): preceeding arguments node may be NULL when
an empty keyword argument hash splat is optimized away.
[ruby-core:88890] [Bug #15087]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64786 b2dd03c8-39d4-4d8f-9...
09/19/2018
-
10:11 PM Feature #14097: Add union and difference to Array
- @matz
> The final proposal seems reasonable. Accepted.
Great to read that! 🎉
I have just rebased in [the PR](https://github.com/ruby/ruby/pull/1747), looking forward to see the `Array#union` method in Ruby!
@shevegen
> ...... -
05:30 PM Bug #15142 (Third Party's Issue): Bug in the Ruby interpreter or extension libraries
- ~|2]> brew cleanup
Removing: /usr/local/Cellar/sqlite/3.24.0... (11 files, 3.5MB)
/usr/local/Homebrew/Library/Homebrew/cache_store.rb:35: [BUG] Segmentation fault at 0x000000011d7ffffe
ruby 2.3.7p456 (2018-03-28 revision 63024) [unive... - 05:12 PM Revision b06bcff4 (git): * 2018-09-20
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64785 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 05:12 PM Revision d93dcd28 (git): net/http: Improve net/http header error message.
- Patch by Matt Larraz. [Fix GH-1849].
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64784 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- > You say "I fixed the warnings". So why is this issue still open.
Sorry it's mistake. Correctly I fixed the warnings on my git repository, and sent pull-request. And not merged in the main repository's trunk.
The patch is here.
... -
- jaruga (Jun Aruga) wrote:
> Before the modification, there were 18 warnings for `-Wparentheses`.
My crude guess is that all of them would be for cases such as "assignment in a context where a truth value is expected" (first paragraph... -
- https://www.ruby-lang.org/en/news/2018/06/20/support-of-ruby-2-2-has-ended/
[ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64783 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Could you try the latest version of 2.3?
Note that 2.3 series is security maintenance status already, and ordinary bug fixes will not be released anymore. -
07:33 AM Bug #15140 (Closed): Bug in Interpreter or Extension Libraries
- ```
13:03:32 ASP.1 | started with pid 8751
13:03:33 ASP.1 | /home/psqa/.rvm/gems/ruby-2.3.3/gems/bundler-1.16.2/lib/bundler/remote_specification.rb:34: [BUG] Segmentation fault at 0x00000000000000
13:03:33 ASP.1 | ruby 2.3.3p222 (2... - 08:23 AM Revision 41cf596d (git): process.c (waitpid_cleanup): unconditionally remove from waiters
- This is the safer option, as there seems to be cases where checking
waitpid_state.ret is insufficient in ensure. I'm not 100% sure
why this is, but this change was required for my work-in-progress
Thread::Light patch series, too...
git... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64781 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 02:10 AM Revision f7f216ed (git): [DOC] Add changes to Hash#merge in NEWS [#15111]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64780 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- As per Marc-Andre's comment. [Refs GH-1951]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64779 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r64777.
----------
* hash.c (rb_hash_merge): Accepts zero or more hashes as arguments
Hash#merge, merge!, and update could merge exactly two hashes.
Now, they accepts zero or more hashes as arguments so that ... -
- As I recall, Matz has accepted this ticket at the day of developers' meeting. I'll commit it soon.
- 01:59 AM Revision d6a06a76 (git): * 2018-09-19
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64778 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Hash#merge, merge!, and update could merge exactly two hashes.
Now, they accepts zero or more hashes as arguments so that it can merge
hashes more than two.
This patch was created by Koki Ryu <liukoki@gmail.com> at Ruby Hack
Challenge #... -
- akr (Akira Tanaka) wrote:
> We can create `{}` with a special instance variable to distinguish them.
I'm impressed by your creativity :-)
So, would we have the following?
```
def foo(**opt)
opt.instance_variable_get(:@no_ke...