Activity
From 09/12/2018 to 09/18/2018
09/18/2018
-
11:00 PM Bug #15139 (Third Party's Issue): Bug in Interpreter or Extension Libraries
- This is reference to upgrading Ruby from Homebrew on a 2017 MacBook Pro running OS X (MacOS) High Sierra 10.13.6 (17G65)
Ruby -v:
ruby 2.3.7p456 (2018-03-28 revision 63024) [universal.x86_64-darwin17]
I attempted a "brew upgrade" ... -
05:12 PM Bug #15138 (Closed): non-symbol keyword in double splat, such as **{2 => 3}, raises TypeError or not
- I found that non-symbol keyword in double splat, such as `**{2 => 3}`,
raises TypeError in a situation and doesn't raise in another situation:
```
% ./ruby -ve '
def m(*a) p a end
m(k: 1, **{2 => 3}) # [{:k=>1, 2=>3}]
m(**{4 => 5... -
04:24 PM Misc #15129: DevelopersMeeting20181010Japan
- [[Feature #15123]](https://bugs.ruby-lang.org/issues/15123) Enumerable#compact proposal (greggzst)
It simplifies working with large and small collections so one doesn't have to remember that can't use `#compact` when enumerator is retur... -
- My fourth idea: FL_USERn flag in `{}'.
-
- akr (Akira Tanaka) wrote:
> If it is not acceptable, I have second idea:
My third idea is to use an instance variable to distinguish
the two kind of `{}`.
We can create `{}` with a special instance variable to distinguish them.... -
- mame (Yusuke Endoh) wrote:
> akr (Akira Tanaka) wrote:
> ...
Yes. I hope that the incompatibility is acceptable.
If it is not acceptable, I have second idea:
We can use a special frozen empty Hash object instead of nil.
```
NO... -
02:16 AM Bug #15078: Hash splat of empty hash should not create a positional argument.
- akr (Akira Tanaka) wrote:
> How about def `m(**kw) end` binds kw to nil if the last Hash argument is not taken as keyword arguments and
> ...
Very clever :-)
As Mame-san points out, it would be a source of incompatibility. I would r... -
12:08 AM Bug #15078: Hash splat of empty hash should not create a positional argument.
- akr (Akira Tanaka) wrote:
> How about def `m(**kw) end` binds kw to nil if the last Hash argument is not taken as keyword arguments and
> ...
I agree that it is one of the reasonable design choices, but does it break the following code... -
02:56 PM Bug #15137 (Third Party's Issue): Can't run brew cleanup
- I'm using Homebrew for Mac and I recently ran an update, followed by an upgrade. As usual, I ran cleanup afterward using "brew cleanup". Unfortunately the cleanup crashed. I cannot complete a brew cleanup and I'm getting the following e...
-
02:49 PM Misc #15136: Fix -Wparentheses warnings
- Before the modification, there were 18 warnings for `-Wparentheses`.
```
$ make >& make.log
$ grep -r Wparentheses make.log | wc -l
18
```
-
- Currently the `-Wno-parentheses` was set.
I assumed if we could fix the warning, we could remove the `-Wno-parentheses`.
I fixed the warnings, because the warning is used as a default on Fedora Project build environment.
I sent pull... - 01:52 PM Revision a4675d9d (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64776 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:52 PM Revision e7db9df9 (git): vm_insnhelper.c: always use bool-ish value
- for CC_SET_FASTPATH condition. Just a cosmetic change to unify the
styling with other lines.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64775 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:55 PM Revision c49559f1 (git): Skip EHOSTUNREACH by host issues
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64774 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:49 PM Bug #15135 (Closed): Refining #initialize method not working
- From the reference (https://docs.ruby-lang.org/en/2.5.0/syntax/refinements_rdoc.html):
>Refinements are lexical in scope.
> ...
So `initialize` which is called outside of the scope will not be overridden.
Matz. -
09:37 AM Bug #15135 (Closed): Refining #initialize method not working
- See the following example:
```
class C
def initialize(arg)
puts arg
end
end
module M
refine C do
def initialize(arg1, arg2)
puts arg1, arg2
end
end
end
using M
C.new("foo") # works
C.new("f... - 12:48 PM Revision 36850b78 (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64773 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- because it's actually setting fastpath to cc instead of ci since r51903.
vm_insnhelper.c: ditto
mjit_compile.c: ditto
tool/ruby_vm/views/_mjit_compile_send.erb: ditto
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64772 b2dd03c8-39d... -
09:58 AM Feature #5400: Remove flip-flops in 2.0
- Just a quick opinion, deprecation is part of the migration part, better warn in a release in between than break functionality immediately.
We also warn for continuation FWIW.
I support removing flip-flops, it looks like a legacy stra... -
09:22 AM Feature #5400: Remove flip-flops in 2.0
- mame@ruby-lang.org wrote:
> There were some programs that used flip-flops in build
> scripts. I rewrote them to a code that does not use
> flip-flops. The work was harder than I expected.
>
> Honestly I'm unsure if deprecation of... -
- Thank you, fixed it now.
-
- Thank you for clarifying it!
By the way, I saw your commit for the fix.
https://github.com/ruby/ruby/commit/eddd630
```
- close(slave);
+ if (slave < 0 && slave > 2) (void)!close(slave);
```
It seems that the `close`... -
- POSIX states successfully opened file descriptors should be **non-negative**.
http://pubs.opengroup.org/onlinepubs/9699919799/functions/open.html#tag_16_357_04
> #### RETURN VALUE
> ...
pty.c should be more defensive too, thank you ... -
- * ext/pty/pty.c (chfunc): fix a typo of an operator. pointed out by
jaruga (Jun Aruga) at [ruby-core:89058]. [Bug #15116]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64771 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r64770.
----------
Lazy Enumerator reduce intermediate array creation
[ruby-core:87907] [Bug #14908] [Fix GH-1912]
From: Anmol Chopra <chopraanmol1@gmail.com> -
06:43 AM Bug #14908: Enumerator::Lazy creates unnecessary Array objects.
- No objection. I guess @nobu is trying to fix it.
-
05:48 AM Bug #14908: Enumerator::Lazy creates unnecessary Array objects.
- All the responses for the proposed patch are positive till date. @shyouhei can we go ahead with this now?
-
- [ruby-core:87907] [Bug #14908] [Fix GH-1912]
From: Anmol Chopra <chopraanmol1@gmail.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64770 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
08:37 AM Revision ec6c0757 (git): Merge upstream revision of rubygems/rubygems.
- This commits includes tiny bugfix and new features listed here:
* Add --re-sign flag to cert command by bronzdoc: https://github.com/rubygems/rubygems/pull/2391
* Download gems with threads. by indirect: https://github.com/rubyge... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64768 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
07:15 AM Bug #15121 (Rejected): Memory Leak on rb_id2name(SYM2ID(sym))
- Yes, it is expected.
We separate all symbols into two categories:
* static symbols: used by method name and so on. They are not GC'ed managed.
* dynamic symbols: created by Ruby program like `str.to_sym`.
Static symbols are use... -
- Very interesting.
akr (Akira Tanaka) wrote:
> The flag will be true if method call uses k => v, k: v, "k": v or **h and
> ...
I agree that hash separation is not a good idea. I'm wondering if `(k = :a) => v` should be accepted. It i... -
- `keyword_given?` provides information about the caller side.
The information is not related to callee side.
There is no chance to call `keyword_given?` if ArgumentError is raised, though.
For simplicity, I assume keys for keyword ar... -
- Until we convince Matz, I pushed a gem `require_relative_dir` which hopefully can be helpful to others.
- 12:22 AM Revision 32fd8649 (git): * 2018-09-18
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64767 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * ext/pty/pty.c (chfunc): should not close the slave fd if it is 0..2.
[ruby-core:89043] [Bug #15116]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64766 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
09/17/2018
-
- Negative fd means `open(2)` failed.
-
- Thank you for checking my code!
> > Fix leaked handle variable "n" in process.c.
> ...
About above thing,
I compared process.c#rb_daemon with pty.c#chfunc .
Similar implementation, but a little different.
https://github.com/ru... -
- Thank you, I missed the reference to this ticket in the commit log.
-
09:56 AM Bug #15118: Method [] & []= does not respect frozen_string_literal: true comment
- @nobu : should this ticket be closed or not yet?
it seems fixed in 64745 -
07:01 PM Bug #15082: Memory leak in net/http/response and net/http/header
- I kept to investigate the memory leak issue. It seems it comes when OpenSSL::SSL::VERIFY_PEER is enabled and a ca_file is specified :
~~~ ruby
require "net/http"
require "openssl"
def repeat_https_get
uri = URI("https://exampl... -
02:56 PM Feature #14183: "Real" keyword argument
- akr (Akira Tanaka) wrote:
> I have an idea to separate positional arguments and keyword arguments without incompatibility.
I like this idea of allowing per-method handling of arguments. Just to confirm my understanding of the propos... -
- I have an idea to separate positional arguments and keyword arguments without incompatibility.
Basic idea is introducing an flag, keyword_given,
which means the last argument is a Hash object which represent keyword argument.
(The n... -
- akr (Akira Tanaka) wrote:
> In this behavior, following two should be same behavior (in Ruby 2.X), I think.
> ...
Oops. ```def f(*a, *kw) g(*a, *kw) end``` was wrong.
I wanted to write ```def f(*a, **kw) g(*a, **kw) end```
Also, ... -
- mame (Yusuke Endoh) wrote:
> ```
> ...
How about def `m(**kw) end` binds kw to nil if the last Hash argument is not taken as keyword arguments and
`m(**{})` add {} and `m(**nil)` don't add anything to arguments.
{}/nil distinguis... -
04:31 AM Bug #15130 (Closed): Nested Timeouts hang on cygwin
- After using `make; make runnable`, the following one-liner hangs:
```
./ruby -ropen-uri -e 'open "http://web.mit.edu/index.html"'
```
This happens on any http URI, but not for local files. The above URI is just an example. I wou... - 01:31 AM Revision 7c5d475d (git): * 2018-09-17
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64765 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- tool/update-deps: tweak the comment to make sure it should be built in
the source directory, because building ruby outside source directory
failed on my trial.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64764 b2dd03c8-39d4-4d8f-9...
09/16/2018
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64763 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- ../addr2line.c: In function ‘fill_lines’:
../addr2line.c:709:8: warning: ‘file’ may be used uninitialized in this function [-Wmaybe-uninitialized]
if (file != NULL) {
^
../addr2line.c:535:11: warning: ‘filesize’ may be used ... -
- Please comment your favorite ticket numbers you want to ask to discuss with your *SHORT* comment or summary.
(your summary/comment will help us because we don't need to read all of ticket comments)
*DO NOT* discuss then on this ticke... -
12:04 PM Misc #15012: Testing on latest version gcc on Travis CI - I just noticed the environment variables line for gcc-8 test case on `.travis.yml` are removed by the great hack in `configure.ac`.
That's amazing!
Thank you for the improvement.
https://github.com/ruby/ruby/commit/f677ba8
```
... - 04:18 AM Revision 1a6c2734 (git): lib/matrix: Fix potential bug of Vector#angle_with
- Could happen for some linearly dependent vectors.
Patch by Vasiliy Petrov. [Fix GH-1803]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64761 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 04:00 AM Revision 24924022 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64760 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 04:00 AM Revision c22b8537 (git): Alias Struct#select as Struct#filter. Patch by Kenichi Kamiya.
- [Fix GH-#1862] [#1784]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64759 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 03:24 AM Revision 2b3982ad (git): node.c: Typo fix. Patch by Shuichi Tamayose. [ci skip] [Fix GH-1880]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64758 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 02:49 AM Revision 2521b079 (git): [DOC] Improve String#strip documentation.
- Patch by Josh Goldberg. [Fix GH-1933] [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64757 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 02:45 AM Revision 18fe4959 (git): Add some missing documentation to Queue#{close|deq} [ci skip]
- Patch by Lars Kanis. [Fix GH-1949]
* Describe the impact of Queue#close to Queue#deq .
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64756 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 02:42 AM Revision 4452e857 (git): array.c: Optimize rb_ary_and. Patch by Stefan Schüßler. [Fix GH-1938]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64755 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
09/15/2018
-
- Applied in changeset trunk|r64753.
----------
encoding.c: check external encoding
* encoding.c (rb_enc_get_index): external encoding may not be Data
object. [ruby-core:89016] [Bug #15122] - 04:27 PM Revision 4e62527c (git): * 2018-09-16
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64754 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * encoding.c (rb_enc_get_index): external encoding may not be Data
object. [ruby-core:89016] [Bug #15122]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64753 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
-
- Thank you for the analyzing.
jaruga (Jun Aruga) wrote:
> The summary is
> ...
The above seems valid.
And the followings are false positive.
> * Fix passing freed pointer as an argument in gc.c.
The pointer is never derefere... -
- Eregon (Benoit Daloze) wrote:
> No, #compact only removes `nil`: `["a" ,false ,nil].compact` => `["a", false]`.
Lol, ouch, not sure how I could be so confused when I wrote that, sorry!
-
11:06 AM Feature #15123: Enumerable#compact proposal
- I think if the meaning is consistent (e. g. .compact meaning to eliminate
nil values from a given collection) then this seems ok. Perhaps this could
be added for the next developer meeting. -
- marcandre (Marc-Andre Lafortune) wrote:
> Also `compact` is roughly `select(&:itself)`, not `reject(&:nil?)` which would wrongly keep `false`.
No, #compact only removes `nil`: `["a" ,false ,nil].compact` => `["a", false]`.
-
- Proposal seems acceptable to me.
Just to be clear: I imagine that `Lazy#compact` would still be lazy. Also `compact` is roughly `select(&:itself)`, not `reject(&:nil?)` which would wrongly keep `false`. -
- Applied in changeset trunk|r64752.
----------
Work on Benchmark::Tms documentation [ci skip]
[ruby-core:88874] [Bug #15080]
From: Richard Wardin <shalmezad@gmail.com> -
- [ruby-core:88874] [Bug #15080]
From: Richard Wardin <shalmezad@gmail.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64752 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64751 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * Fix leaked storage in addr2line.c.
* Fix for "top_root" leaking the resource.
[Fix GH-1956]
From: Jun Aruga <jaruga@redhat.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64750 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * spec/mspec/lib/mspec/utils/script.rb (MSpecScript#entries): expand
the given spec path to the realpath, not to require a library by
realpath and symbolic link path from the spec file.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/tr... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64748 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64747 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Fixed in
https://bugs.ruby-lang.org/projects/ruby-trunk/repository/revisions/64745
-
- mame (Yusuke Endoh) wrote:
> Yes. Your proposal looks the best semantics so far for Ruby 2.X, at least to me. Note that akr-san is also reasonable: from 2.0, a method call has always passed the same value array and a block, without de... -
- marcandre (Marc-Andre Lafortune) wrote:
> I'm sorry if I sounded like I had a "complete" solution, since Akr-san is right, there is no such perfect semantics.
Don't mind; I had considered your proposal in a few days, but I couldn't f... - 02:20 AM Revision 0279a90c (git): * 2018-09-15
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64746 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * compile.c (iseq_compile_each0): Use `opt_aref`/`opt_aset` over
`opt_aref_with`/`opt_aset_with` when frozen_string_literal: true,
not to resurrect the index string on non-Hash receiver.
[Fix GH-1957]
From: chopraanmol1 <chopraanmo...
09/14/2018
-
10:36 PM Bug #15122: Segfault when mashaling an IO object
- `git bisect` shows this is from https://bugs.ruby-lang.org/projects/ruby-trunk/repository/ruby-git/revisions/a2c7d0cea999bc8f8e6deb89bcee5eb80ba13ea2 = r64178.
I guess pipe IO doesn't have internal_encoding nor external_encoding. -
05:07 PM Bug #15122 (Closed): Segfault when mashaling an IO object
- When I run:
~~~
$ ruby -e "Marshal.dump(IO.pipe[1])"
~~~
## Expected behavior:
I would expect a TypeError
## Actual behavior:
I get a Segfault:
~~~
-e:1: [BUG] Segmentation fault at 0x0000000000000020
ruby 2.6.0dev (201... -
- I'm in favor of this proposal. It simplifies working with large and small collections so one doesn't have to remember that can't use `#compact` when enumerator is returned and have to fall back to `#reject(:nil?)`.
-
05:30 PM Feature #15123 (Feedback): Enumerable#compact proposal
- Hi!
While Enumerable does not provide `#compact` method, it requires changing code in some cases to substitute array with enumerator.
For example, to reduce memory usage it's usual to change `large_array.map { to_heavy_object }.cha... -
- mame (Yusuke Endoh) wrote:
>
> ...
I'm sorry if I sounded like I had a "complete" solution, since Akr-san is right, there is no such perfect semantics. Proof
```
# Let foo be some method of unknown signature
# Forward bar to fo... -
- Marc-Andre,
marcandre (Marc-Andre Lafortune) wrote:
> * Proposed semantics *
I thought it looked good. However, I introduced it to some committers at the developers' meeting, and akr-san showed it was still incomplete:
```
de... -
- I believe this is expected. Once you ask for the ID of a dynamic symbol, Ruby needs to create a real symbol, and once the real symbol is created, it can never be garbage collected.
You can replace your `leak_sym` method with the foll... -
02:00 PM Bug #15121 (Rejected): Memory Leak on rb_id2name(SYM2ID(sym))
- @ohler55 mentioned in https://github.com/ohler55/oj/issues/501 that calling `rb_id2name(SYM2ID(sym))` seems to lock symbols in memory but I couldn't find any issue open for that. So I'm just opening one just in case, but pls close if thi...
-
01:58 PM Bug #15120: Segfault when using ActiveRecord
- Added stdout/stdin.
-
- Whenever I do some of the MySQL migrations in my project I get a segfault. One example of a command that triggers this error is:
```
RAILS_ENV=test bundle exec rake db:migrate
```
I tried to get a smaller reproducable case, but r... -
- To be clear, those 9 issues about mainly leaked resource in the attached report file are marked as "important" by the analysis tool for ruby 2.5.1 + some patch files.
Total 9
* 1 COPY_PASTE_ERROR
* 7 RESOURCE_LEAK
* 1 USE_AFTER_FRE... - 01:19 PM Revision fa457e65 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64744 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Revert "Removed old elisp files. New upstream repository was moved https://github.com/ruby/elisp."
This reverts commit 7eedd308b841e7b8eb4bc36211d28faf3521ee92.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64743 b2dd03c8-39d4-4d... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64742 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64741 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- > It seems specific to glibc
That should be "glibc malloc"; and only old versions. The bug
is fixed in glibc 2.28, at least; likely earlier. (glibc takes
forever to build) It's present in 2.24-11+deb9 on Debian.
MALLOC_ARENA_M... -
- hartator@gmail.com wrote:
> Issue #11174 has been updated by hartator (Julien Khaleghy).
> Any idea if it's already fixed somewhere else, or you guys
> still working on it?
I missed it, too :x (and now I'm too sleepy to continue... -
09:17 AM Bug #11174: threads memory leak
- ko1 (Koichi Sasada) wrote:
> Sorry I missed it.
Thanks for the awesome work on MRI.
I still have the same issue on Ruby 2.5.1 (ruby 2.5.1p57 (2018-03-29 revision 63029) [x86_64-linux-gnu]):
~~~ ruby
VmRSS: 60116 kB
VmRSS: ... -
- shevegen (Robert A. Heiler) wrote:
>
> ...
I was working on reducing memory allocation on roo gem. While profiling (with memory_profiler gem) I observed string literal being allocated multiple time at specific locations even after add... -
- Interesting.
I just tested with this code:
~~~ruby
#!/System/Index/bin/ruby -w
# Encoding: ISO-8859-1
# frozen_string_literal: true
# =========================================================================== #
NopProc = proc... -
- Calling `["something"]` on object or proc (non-hash aref implementation) does not respect `frozen_string_literal: true` comment
### Script:
~~~ruby
# frozen_string_literal: true
require 'benchmark'
require 'memory_profiler'
c... -
- See also ISO9899:1999 section 7.8.1 paragraph 3.
The #ifndef is for C compilers older than C99.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64740 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64739 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 07:44 AM Revision b80ea712 (git): * 2018-09-14
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64738 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Now that we can say for sure if an instruction calls a method or
not internally, it is now possible to reroute the bugs that
forced us to revert the "move PC around" optimization.
First try: r62051
Reverted: r63763
See also: r63999
-... -
05:28 AM Bug #14364: Regexp last match variable in procs
- This may be a specification. [This](https://docs.ruby-lang.org/ja/latest/method/Kernel/v/=7e.html)(it's written in japanese) page says `$~` is local scope and thread local.
The following code describes this behavior. The `a` can be re...
09/13/2018
-
- Funny idea with the picture. :D
-
- The final proposal seems reasonable. Accepted.
Matz.
-
- I think the consensus at the last ruby developer meeting in September 2018 was to go for
it ( https://docs.google.com/document/d/1RgKID1guTYC6AbhCQxs_bRiViyefIbFefA--KwLEx10/edit
e. g. "all: let's go" as summary note ).
-
- Thread::Light sounds ok to me personally. I think the more informal name "Lite"
may have some people wonder about that particular informal name (well aside
from the association normalperson had), so I think Light is a better name
here.
-
- matz@ruby-lang.org wrote:
> The latest proposal includes time slice scheduling, so it is
> ...
Thanks for the comment.
I haven't implemented timeslice, yet, so I won't :)
> I object to the name `Thread::Coro`. If being lightweight ... -
- The latest proposal includes time slice scheduling, so it is not a cooperative thread. I object to the name `Thread::Coro`. If being lightweight is the biggest characteristic, it should be `Thread::Lite` or `Thread::Light`.
Matz.
-
- I agree with both what Kenta Murata and what Jeremy Evans wrote (to explain,
I have no personal preference; I think both `.p()` would be useful anyway and
I think this was the spirit of the original suggestion; I love p and pp).
Mar... -
- mrkn (Kenta Murata) wrote:
> I sometimes write `STDERR.puts obj.inspect` to print debug message to standard error.
> ...
I've heard it is preferable to use `$stderr` (the current standard error stream) instead of `STDERR` (the original... -
- `#warn` writes to `STDERR`. What about `warn_p` or something similar?
-
06:15 AM Feature #15112 (Assigned): Introducing the short form of `STDERR.puts expr.inspect`.
- I sometimes write `STDERR.puts obj.inspect` to print debug message to standard error.
I want to write it as `STDERR.p obj`.
It can be realized by introducing `p` singleton method in `STDERR` object. -
- I think it is good to have more documentation. I would however
had perhaps replace the word Python with Ruby (or Duck or
something else), if possible. -
- I think nobu committed it already (if it is the same one)
https://git.ruby-lang.org/ruby.git/commit/?id=384fda18b885872aacf225ac6ad7805fb101e497
I guess it is a useful change; reminds me a bit of the did-you-mean gem, in spirit at
... -
07:05 AM Feature #15113 (Closed): Show warnings on unused blocks with Enumerable#all? any? one? none?
- Let Array#any? (and related enumerable methods alike) to express warnings in case blocks are left unused.
**Background**
Certain methods in Array silently ignore the given blocks without any warnings, which sometimes causes 'invisibl... -
- I assume we always prefix rb_ to non-static functions to avoid conflict.
These functions are not exported and safe to be renamed.
iseq.h: ditto
compile.c: ditto
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64736 b2dd03c8-39d4-4d8f... -
- When running a code analysis tool including several sub tools (mainly Coverty [1]), some issues were detected by it.
You can refer attached issues_report.txt for detail.
Some issues in the issues_report.txt might be false positive.
... -
- because cc->call is NULL by default and it is not overridden by
vm_search_super_method if OPT_CALL_FASTPATH is 0. So this macro is not
just a switch for optimization but now it's mandatory.
vm_insnhelper.c: cosmetic change. Use boolean-... -
12:06 PM Feature #6823 (Closed): Where/how should ruby-mode issues be reported?
- Applied in changeset trunk|r64734.
----------
Remove old ruby-mode.el
Use emacs bundled ruby-mode.el instead.
[Feature #6823] [ci skip] -
- Use emacs bundled ruby-mode.el instead.
[Feature #6823] [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64734 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- [Fix GH-1953]
From: Koji Onishi <fursich0@gmail.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64733 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- On FreeBSD we're going to switch to the GNU-ish version of qsort_r().
POSIX is also considering standardizing that one. To prevent faulty
calls, we have a macro in place to throw a compiler error if a BSD-style
qsort_r() call is performe... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64731 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
10:56 AM Feature #15111: Make the number of arguments of `Hash#merge` variable
- If no argument is given to `Hash#merge`, the receiver itself is returned. In this way, `Hash` instance can revieve `Array` as arguments without concerning if the `Array` is empty.
```ruby
hash1 = {a: 1, b: 2}
hashes = return_array_o... -
- # Abstract
Make the number of arguments of `Hash#merge` variable.
# Background
In many websites such as Stack Overflow and Qiita, many people are seeking how to merge more than three hashes.
https://stackoverflow.com/questions... -
08:45 AM Bug #15084 (Closed): Backport r64476
-
08:17 AM Misc #14981: DevelopersMeeting20180913Japan
- * [Feature #15114] Ruby で定義したメソッドに `&:hoge` を渡しても refinements が有効にならない
-
- Current status is here:
1. Migrate toolchain like `tool/make-snapshot` to git.ruby-lang.org from svn.ruby-lang.org.
Not yet, We need to update make-snapshot and backport tool for stable branches.
2. Improve cgit and access confi... -
08:14 AM Bug #15114 (Closed): Ruby で定義したメソッドに `&:hoge` を渡しても refinements が有効にならない
- ## 概要
Ruby 2.4 で以下のように『refinements で追加したメソッドが `&:twice` で呼び出せる』ようになりました。
```ruby
# 新しく String#twice を refinements で追加
using Module.new {
refine String do
def twice
self + self
end
end
}
# OK
p ["homu", "mami", ... -
- > 0001-dir.c-performance-fix-with-braces.patch
> ...
I'm wondering whether this incompatibility is critical or not.
Anyway the easiest way is just merge it and wait the feedback from Rails. -
- Thank you for the patch, let's try, please commit the patch for braces.
-
07:53 AM Bug #14908: Enumerator::Lazy creates unnecessary Array objects.
- I'm the original author of Enumerator & Yielder and I don't think I particularly intended to make `<<` accept many arguments. `<<` was an alias of `yield`, and I just didn't bother to make a separate function. So, I'd say go ahead.
-
- Is it a specification? When you pass 'fg4534253dd' to `DateTime#parse`, [`parse_ddd`](https://github.com/ruby/ruby/blob/480a21f435d2917190c087206bbffbd3d532824a/ext/date/date_parse.c#L1894) is called. It doesn't parse from begin of strin...
-
- Hi, ioquatix.
I send an invitation of the ruby core team. Please check it. -
- OK, it sounds reasonable. We will give you commit privilege.
Matz.
-
-
- I removed them from branches directory now.
https://svn.ruby-lang.org/repos/ruby/branches/ -
- I think you can just move them to under tags.
-
- ```
half-baked-1.9
KEIJU
KOSAKO
matzruby
mvm
new_gc
rexml_adds_tests
ricsin
RUBY
ruby_m17n
SER
SHIGEO
SPCOLTRIN
testunit
unlabeled-1.1.1
unlabeled-1.39.2
win32-unicode-test
```
I will move them into tags. -
- This reverts commit r64711, because EXEC_EC_CFP on JIT-ed code does not
call jit_func with the patch when catch_except_p is true. It wasn't intentional.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64730 b2dd03c8-39d4-4d8f-98ff-823... -
- ../thread.c:1219:18: warning: format specifies type 'unsigned long' but the argument has type 'rb_hrtime_t'
(aka 'unsigned long long') [-Wformat]
end, now);
^~~
../thread.c:1219:23: warning: format... -
- and possibly memory access for iseq->body may be reduced.
No significant impact for performance on Optcarrot.
* before
fps: 55.03865935187656
fps: 57.16854675983188
fps: 57.672458407661765
fps: 58.28989837869383
fps: 58.80503815099268
... -
- I vote for #tapp.
Matz.
-
- How about:
```ruby
self.P
```
:P -
- I have one idea. We can use `\it` (backslash-it) or `\1` instead of `it`. `\1` means the first argument and `\n` refers `n`th argument.
`\`-something is not used, but `\` means line continuation. -
- * node.h (enum node_type): removed unused macros which redefine the
same name enum values, and probably had ended the historical role.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64710 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- This is mostly cosmetic. Should generate a slightly readable
vm.inc output.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64709 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- vs140 tends to die with 10s timeout on TestThreadQueue#test_queue_with_trap
https://ci.appveyor.com/project/ruby/ruby/build/9610/job/di9durc5rv0dwhor
https://ci.appveyor.com/project/ruby/ruby/build/9598/job/t7wugyn1sm57lbw3
git-svn-id: ... - 01:43 AM Revision 8a7b4b39 (git): thread.c (rb_thread_atfork): reinitialize current th->interrupt_lock
- Another thread may be holding th->interrupt_lock while our
current thread calls fork. Therefore we must reinitialize our
own th->interrupt_lock in the child process because the owner
of the lock is only in the parent. The original pare... -
- I see. Thank you for the experiment and taking time for the investigation.
-
- I am sorry in advance, I've decided to withdraw this ticket and its patch.
I tried to reveal what's going on and explain it, but end up getting nowhere.
I also tried to explain the reason that I had reached to `vm_search_super_method...
09/12/2018
-
10:32 PM Bug #15050: GC after forking with fibers crashes
- @normalperson
Eric,
Sorry been busy with 'this is a bigger mess than I thought' kinds of things.
I just ran ruby-loco on r64706 'fiber: fix crash on GC after forking', and the build passed.
Thanks, Greg -
- Applied in changeset trunk|r64703.
----------
share VM stack between threads and fibers if identical in size
ec->vm_stack is always allocated with malloc, so stack cache for
root fiber (thread stack) and non-root fibers can be shared a... -
- sameer.deshmukh93@gmail.com wrote:
> @hsbt what do you think about writing the docs within C API
> files like `ruby.h`, `intern.h` and `extension.h` itself so
> that ruby-doc.org can run doxygen on them to generate the
> relevant ... - 08:49 PM Revision 12409ad2 (git): fiber: fix crash on GC after forking
- Remove the remainder of ROOT_FIBER_CONTEXT use and unnecessary
differences between the root and non-root fiber. This makes
it easier to follow new root fiber at fork time.
Multiple sources of truth often leads to bugs, as in this case.... - 08:49 PM Revision d40694de (git): cont.c (fiber_memsize): do not rely on ROOT_FIBER_CONTEXT
- We can check if the fiber we're interested in is the
th->root_fiber for the owner thread, so there is no need to use
ROOT_FIBER_CONTEXT.
Note: there is no guarantee th->ec points to
&th->root_fiber->cont.saved_ec, thus vm::thread_memsiz... -
- Applied in changeset trunk|r64703.
----------
share VM stack between threads and fibers if identical in size
ec->vm_stack is always allocated with malloc, so stack cache for
root fiber (thread stack) and non-root fibers can be shared a... - 08:49 PM Revision 7ae24709 (git): cont.c (ec_set_vm_stack): avoid needless casting
- Am I missing something, here? Casting was totally unnecessary
and ugly...
[ruby-core:88929]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64704 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 08:49 PM Revision c99b9eb0 (git): share VM stack between threads and fibers if identical in size
- ec->vm_stack is always allocated with malloc, so stack cache for
root fiber (thread stack) and non-root fibers can be shared as
long as the size is the same. The purpose of this change is to
reduce dependencies on ROOT_FIBER_CONTEXT.
[... -
- * [Feature #13618] auto-fiber name, is "Thread::Coro" OK?
How should Mutex work between coroutines?
Queue/SizedQueue works, now (not sure about signal handler). -
- > It goes on top of my coro-r64610 branch posted at [ruby-core:88800]:
> https://public-inbox.org/ruby-core/20180901131301.5peghdyrtmks5mka@dcvr
>
> Several tests are skipped because Thread::Coro#stop?/#status/#[]=
> aren't impleme... -
06:43 PM Misc #15109 (Closed): Improve safe navigation operator's docs
- Reason: [current docs](http://ruby-doc.org/core-2.5.1/doc/syntax/calling_methods_rdoc.html) look this way (in "Receiver" section, one paragraph before last):
> You may use `&.` to designate a receiver, then `my_method` is not invoked ... - 04:05 PM Revision 2bd4c514 (git): * 2018-09-13
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64702 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64701 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * time.c (time_utc_or_local): split into time_s_mkutc and
time_s_mktime without utc flag.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64700 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- because using memcpy here actually made performance worse.
In Optcarrot,
* for loop
fps: 55.90428960597268
fps: 57.21690379342434
fps: 58.41751168279789
fps: 58.7317470613203
fps: 62.81371000202459
fps: 63.02541045417479
fps: 63.7732402... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64698 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 08:51 AM Revision 98fa0ab4 (git): [DOC] Modify descriptions for ArithmeticSequence
- [ci-skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64697 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 08:36 AM Revision 1595421c (git): [DOC] Add the documentation of ArithmeticSequence
- [ci-skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64696 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:48 AM Feature #14982: Improve namespace system in ruby to avoiding top-level names chaos
- Please allow me to humbly present [this design and implementation of import semantics](https://gitlab.com/lloeki/pak) aiming to solve precisely the current issue, taking inspiration from Go and Python.
Basically it implements a `Packa... - 07:35 AM Revision 11ff6569 (git): enumerator.c: Fix ArithmeticSequence for complex step
- Make sure Enumerator::ArithmeticSequence#each to work well
for a complex step value.
This reverts commit ca47fb329a1d48af3e1009620bdb18e931c9f188.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64695 b2dd03c8-39d4-4d8f-98ff-823fe69b... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64694 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 05:52 AM Revision ca47fb32 (git): Revert "enumerator.c: Fix ArithmeticSequence for complex step"
- This reverts commit 0a0f8238d02a2dfff4cd2892408e14cb826cec7e.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64693 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- bozhidar (Bozhidar Batsov) wrote:
> > Yeah, in this case I'd argue that it's better to use some `top-level` methods of `File` instead, but in general every object that has the notion of size should also have the option of emptiness. Tha... -
05:12 AM Feature #14136: Implement #empty? on more classes
- bozhidar (Bozhidar Batsov) wrote:
> phluid61 (Matthew Kerwin) wrote:
> ...
Also I'm curious who'd claim that adding an empty method doesn't make sense for something like `Tempfile` or `StringIO`. -
- phluid61 (Matthew Kerwin) wrote:
> mikegee (Michael Gee) wrote:
> ...
Yeah, in this case I'd argue that it's better to use some `top-level` methods of `File` instead, but in general every object that has the notion of size should also ... - 05:35 AM Revision 0a0f8238 (git): enumerator.c: Fix ArithmeticSequence for complex step
- Make sure Enumerator::ArithmeticSequence#each to work well
for a complex step value.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64692 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- String#freeze can be redefined to be destructive. While such
redefinition is definitely weird, it should be possible. Resurrect
the string to prepare for that sort of things.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64691 b2... -
- Simply use DISPATCH_ORIGINAL_INSN instead of rb_funcall. This is,
when possible, overall performant because method dispatch results are
cached inside of CALL_CACHE. Should also be good for JIT.
----
trunk: ruby 2.6.0dev (2018-09-12 t... -
-
- This instruction can be written without rb_funcall. It not only boosts
performance of case statements, but also makes room of future JIT
improvements. Because opt_case_dispatch is about optimization this
should not be a bad thing to hav...