Activity
From 08/02/2018 to 08/08/2018
08/08/2018
-
08:51 PM Feature #14869: Proposal to add Hash#===
- I had mentioned this in the `Array#===` topic for consideration: https://bugs.ruby-lang.org/issues/14916#note-6
In the comparison, we are returning false if the other value is not a Hash:
(line 4011)
```ruby
if (!RB_TYPE_P(hash2,... -
- I've noticed that this will always return false if the other value is not an array:
(line 4011 of patch)
```ruby
if (!RB_TYPE_P(ary2, T_ARRAY)) return Qfalse;
```
Have we considered potentially checking if the object responds to... -
01:21 PM Feature #14916: Proposal to add Array#===
- > I think there is a potential incompatibility here, due to changing the behavior of #===.
> ...
こちらですが、互換性を壊さないように `===` だけではなくて `==` でも比較するようにし、いずれかの比較演算子の結果が真であれば `true` を返すように変更してみました。
```ruby
String === String
# => false
[Str... -
08:23 PM Feature #14975: String#append without changing receiver's encoding
- I think this should be filed under Feature simply because it may change
existing functionality. -
03:35 AM Feature #14975: String#append without changing receiver's encoding
- One other option would be to add `String#append` which preserves encoding.
-
- I'm not sure where this fits in, but in order to avoid garbage and superfluous function calls, is it possible that `String#<<`, `String#concat` or the (proposed) `String#append` can avoid changing the encoding of the receiver?
Right n... -
06:37 PM Feature #6284: Add composition for procs
- matz (Yukihiro Matsumoto) wrote:
> We need more discussion if we would add combination methods to the `Symbol` class.
> ...
A little sugar on Symbol does look really nice: https://gist.github.com/havenwood/d305b42f5b542e9de1eaa8e56ba6b... - 03:36 PM Revision 86f6fa45 (git): * 2018-08-09
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64237 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:36 PM Revision a6cb8552 (git): needs openssl/opensslv.h
- * ext/openssl/extconf.rb: LIBRESSL_VERSION_NUMBER is defined in
openssl/opensslv.h. fix up r64101.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64236 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * common.mk: rules using MJIT_HEADER_SUFFIX, which to be overriden
in defs/universal.mk, must be in common.mk, not Makefile.in.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64235 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:28 PM Feature #14426 (Closed): [PATCH] openssl: reduce memory allocation in OpenSSL::Buffering#do_write
- The patch is now in ruby/openssl (upstream)'s master branch and Ruby trunk.
For the record, the GitHub Pull Requests are:
https://github.com/ruby/ruby/pull/1924
https://github.com/ruby/openssl/pull/212 -
- When TLS 1.3 is in use, the session ticket may not have been sent yet
even though a handshake has finished. Also, the ticket could change if
multiple session ticket messages are sent by the server. Use
SSLContext#session_new_cb instead o... -
- Sync with the current tip of master branch, 62436385306c of
ruby/openssl.git. Changes can be found at:
https://github.com/ruby/openssl/compare/v2.1.1...62436385306c
--------------------------------------------------------------... -
01:50 PM Revision 4b13656e (git): fix MSG_OOB spec
- * OOBINLINE should be set for accepted socket
* When OOBINLINE is set, MSG_OOB shouldn't be passed to recv
Merge spec/ruby's commit 5b418374f8006318434ee9a2366382d004f585df
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64232 b2dd03... -
01:45 PM Misc #14921: DevelopersMeeting20180809Japan
- - [Feature #14973] Proposal of percent literal to expand Hash
-
- https://github.com/ruby/chkbuild/blob/c0448670a9a5cb85f283bc639806ba09b294557f/chkbuild/ruby.rb#L847
Merge ruby/spec's commit 5a6ac7dbef3d59fe279303bf3346d92f1e620f12
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64231 b2dd03c8-39d... -
12:48 PM Revision 4078be54 (git): rename several internal macros in time.c
- TIME_UTC_P -> TZMODE_UTC_P
TIME_SET_UTC -> TZMODE_SET_UTC
TIME_LOCALTIME_P -> TZMODE_LOCALTIME_P
TIME_SET_LOCALTIME -> TZMODE_SET_LOCALTIME
TIME_FIXOFF_P -> TZMODE_FIXOFF_P
TIME_SET_FIXOFF -> TZMODE_SET_FIXOFF
TIME_COPY_GMT -> TZMODE_COP... -
11:50 AM Revision 0f904ff1 (git): Update comment of tzmode [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64229 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
11:22 AM Feature #13618: [PATCH] auto fiber schedule for rb_wait_for_single_fd and rb_waitpid
- [snipping some bits, because I can only speak to what I know]
On Wed, 8 Aug 2018 at 18:50, Eric Wong <normalperson@yhbt.net> wrote:
>
> samuel@oriontransfer.net wrote:
>
> > In particular, when handling HTTP/2 with multiple strea... -
08:53 AM Feature #13618: [PATCH] auto fiber schedule for rb_wait_for_single_fd and rb_waitpid
- samuel@oriontransfer.net wrote:
> I've been playing around with my gem async and I've come to
> the conclusion that it is a great way to do IO, but it does
> have some cases that need to be considered carefully.
Right.
> In par... -
- Eric that is a great update.
I've been playing around with my gem async and I've come to the conclusion that it is a great way to do IO, but it does have some cases that need to be considered carefully.
In particular, when handling... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64228 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- This removes zone_table and use fstring instead.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64227 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ko1@atdot.net wrote:
> ko1 (Koichi Sasada) wrote:
> > One off topic question. `list_empty()` is thread-safe?
>
> Sorry it should be safe (I misread as other operation. sorry).
Right, good question, though... for register_ubf_li... -
05:53 AM Bug #14945: [PATCH] thread.c (blocking_region_end): clear ubf before unregister_ubf_list
- ko1 (Koichi Sasada) wrote:
> One off topic question. `list_empty()` is thread-safe?
Sorry it should be safe (I misread as other operation. sorry).
-
- :+1:
One off topic question. `list_empty()` is thread-safe?
-
08:37 AM Bug #14976 (Closed): /usr/local/lib/ruby/gems/2.6.0/gems/fluentd-1.2.4/lib/fluent/event.rb:193: [BUG] Segmentation fault at 0x0000000000000000 ruby 2.6.0preview1 (2018-02-24 trunk 62554) [x86_64-linux]
- [root@sh_02 fluentd]# fluentd -c /alidata/install/fluentd/conf/datahub.conf
2018-08-08 16:31:29 +0800 [info]: parsing config file is succeeded path="/alidata/install/fluentd/conf/datahub.conf"
2018-08-08 16:31:35 +0800 [warn]: 'pos_fil... -
- ko1@atdot.net wrote:
> I don't think it is good idea to support
> `Thread#preemptible=false` because someone can misuse this
> feature as "locking" like `Thread.exclusive` on Ruby 1.8 (this
> method prevented thread switching. From ... -
- # The following is the fact I want to clear
(fix me if my understanding is wrong)
I believe this proposal is equals to auto-fiber from user perspective except "how to create" and implementation.
The created concurrent entity (CE... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64226 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- ko1@atdot.net wrote:
> I don't know about these deleted code. Who introduced?
Looks like akr did, but no reasoning was given (r47437, commit
42becbddc24ed347d67e479cccfabcc3404b24ae ) (2014-09-06))
I thought it was there longer ... -
- I don't know about these deleted code. Who introduced?
- 07:26 AM Revision 953b7a20 (git): mjit.c: remove old comment about WNOHANG and SIGCHLD [ci skip]
- [Bug #14867] implemented exactly what was needed (for POSIX
platforms, at least).
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64225 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- > Oh, different test, that is test_timestampns getting stuck.
sorry.
> ...
No. It raw Linux machine.
-
- > The question then becomes: What happens when Guilds land?
I have an optimistic opinion.
If transient heap successes, there are no big issue on it.
(too optimistic? :p)
-
- sam.saffron (Sam Saffron) wrote:
> Koichi / Nobu
> ...
We are not maintainers for both versions, but I think we shouldn't backport it because we can change this parameter by an environment variable.
-
- off-topic `:p`:
If we have a lightweight communication channel between user-process and OS, we can choose this technique harder.
https://www.azul.com/files/c4_paper_acm2.pdf propose to add sharing remap table between OS and user pr... -
- We can close this issue, as there exists a satisfactory alternative.
-
- I also agree that this is confusing, and the only way to fix it would really be to rename `concat` to `append`. There is a proposal for something like this here: https://bugs.ruby-lang.org/issues/14033
-
- I would like to propose to extend this method to be binary safe.
If the destination string uses `Encoding::BINARY`, the append operation should be a memcpy which doesn't affect the receiver's encoding. -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64224 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 01:16 AM Revision 3b8b6688 (git): spec/ruby/library/socket/*: fix hanging on FreeBSD 11.1
- There are still other test failures which need fixing on FreeBSD.
Keep an eye on:
http://rubyci.s3.amazonaws.com/freebsd11zfs/ruby-trunk/recent.html
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64223 b2dd03c8-39d4-4d8f-98ff-823f...
08/07/2018
-
11:04 PM Bug #14974: "if" statement executes wrong branch
- jeremyevans0 (Jeremy Evans) wrote:
> This appears to be a duplicate of #14897.
Yes, it is already fixed in trunk. Please wait for the next release. Anyway, thank you for the report!
OT: I'm surprised that multiple persons encoun... -
06:44 PM Bug #14974 (Closed): "if" statement executes wrong branch
- This appears to be a duplicate of #14897.
-
06:32 PM Bug #14974 (Closed): "if" statement executes wrong branch
- I've stumbled over a rather weird bug where Ruby 2.5+ executes an `else` branch of a condition when it should not. The best minimal example I could come up with is this:
~~~
def broken
foo = 1
if is_true or is_false
foo = ... -
- > > or I will have to revert and reintroduce timer-thread :<
>
> reverted for now :< r64203
Btw, using POSIX timers is a solution for this; because
timer_settime(2) is async-signal safe and I can call it
from signal handlers.
... -
- I do not have any particular opinion about "Any Type" as of yet,
neither pro or con, but just as to what Mr. Beaver wrote here:
"[...] If we choose to pursue pattern matching [Feature #14912]
further, I believe a wildcard type would... -
04:49 PM Revision 29ccaf6e (git): appveyor.yml: make sure MJIT is tested on AppVeyor
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64222 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- By this commit's changes in other files, now MJIT started to work on VC++.
Unfortunately some features are still broken and they'll be fixed later.
This also suppresses cl.exe's default output to stdout because there
seems to be no opti... -
- I can not read japanese but I believe I can understand part of this
proposal (the ruby code examples).
If I understood the examples correctly then one part of the proposal
is to add support for:
%h( )
(Possibly meaning t... -
- ## 概要
変数名から `{ 変数名: 変数の値 }` という Hash を定義するための %記法の提案です。
以前からちょくちょく[提案されていた](https://bugs.ruby-lang.org/issues/14579)
```ruby
x = 1
y = 2
h = {x:, y:}
p h #=> {:x=>1, :y=>2}
```
のような ES6 ライクな構文を `{}` 構文ではなくて %記法で定義するものになります... - 03:14 PM Revision 7fef5883 (git): * 2018-08-08
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64220 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Since `=` is considered as delimiter in `()` of `for`, having
`-DRUBY_DEVEL=1` in CPPFLAGS had resulted in:
#define MJIT_OPTFLAGS "-DMJIT_HEADER", \
"-DRUBY_DEVEL", \
"1", \
Even escaped `for %I in (... -DRUBY_DEVEL^=1)` does no... -
01:08 PM Revision dfd6787f (git): Silence Net::HTTP warning in test.
- https://github.com/ruby/webrick/pull/8
Co-authored-by: Espartaco Palma <>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64218 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r64216.
----------
Add missing test for WEBrick::HTTPAuth::Htgroup.
[Bug #14866][ruby-core:87602]
https://github.com/ruby/webrick/pull/10
Co-authored-by: TSUYUSATO Kitsune <make.just.on@gmail.com> - 12:56 PM Revision 68fac148 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64217 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- [Bug #14866][ruby-core:87602]
https://github.com/ruby/webrick/pull/10
Co-authored-by: TSUYUSATO Kitsune <make.just.on@gmail.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64216 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- They should work separatedly from Ruby core repository.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64215 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64214 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:30 PM Bug #14964: [MJIT] missing builtin methods
- ok, I attached full build logs and my env vars.
output_witharch_81.txt - ```--with-arch-64='barcelona'``` or ```ARCH_FLAG='barcelona'```
(gcc bug?)
```
during RTL pass: final
../ruby_2_6/array.c: In function 'sort_by_i':
../ruby_... -
- They are assigned automatically when pushing gem file to rubygems.org.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64213 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64212 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64211 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- https://github.com/ruby/dbm/pull/3
Co-authored-by: Yasuhiro KIMURA <>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64210 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- https://github.com/ruby/cmath/pull/2
Co-authored-by: MATSUBARA Nobutada
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64209 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:20 AM Bug #14972 (Closed): Net::HTTP inconsistently raises EOFError when peer closes the connection
- If chunked transfer encoding is used, and the peer closes the connection while the caller is reading data, then the `Net::HTTP::Response#read_body` method will raise `EOFError`. If chunked transfer encoding is not used (and an explicit `...
-
07:12 AM Bug #14971 (Closed): error: implicit declaration of function ‘rb_vm_call0
- I get the errors below when making `make up install-nodoc`.
I'm not at v64208.
```
compiling vm.c
In file included from vm_insnhelper.c:1570:0,
from vm.c:310:
vm_args.c: In function ‘vm_to_proc’:
vm_args.c:813:1... -
- Greg.mpls@gmail.com wrote:
> All of the test-all failures show something similar to:
> ```
> [Errno::ENOENT] exception expected, not.
> Class: <Errno::EBADF>
> ```
Thanks Greg. The following patch (on top of my previous one) mi... -
02:44 AM Bug #14968: [PATCH] io.c: make all pipes nonblocking by default
- @normalperson Eric,
The zip of all the logs is at
https://ci.appveyor.com/api/buildjobs/pwyhyvkao2nssxy1/artifacts/zlogs_trunk_2018-08-07_64208.7z
All of the test-all failures show something similar to:
```
[Errno::ENOENT] exc... -
- (シェルスクリプトの uniq と違って) ruby の uniq は sort 済みかどうかに依存していないので、 `.sort.uniq` よりも `.uniq.sort` の方が良いと思います。
- 01:17 AM Revision e9b63a84 (git): * 2018-08-07
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64208 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- defined in XCFLAGS.
This change resolves following link errors in MJIT:
```
rb_mjit_header-2.6.0.obj : error LNK2001: unresolved external symbol rb_cObject
rb_mjit_header-2.6.0.obj : error LNK2001: unresolved external symbol rb_cFalseC...
08/06/2018
-
- > ARCH_FLAG="-march=barcelona" works, but it isn't propagated to CFLAGS, so it doesn't have the desired effect. I think setting CFLAGS directly shouln't be a problem.
> ...
See also: https://github.com/ruby/ruby/blob/24daf1400b5336eb22c... -
- ARCH_FLAG="-march=barcelona" works, but it isn't propagated to CFLAGS, so it doesn't have the desired effect. I think setting CFLAGS directly shouln't be a problem.
It looks like it doesn't work only on MSYS1. I did the same on Linux ... -
- Greg.mpls@gmail.com wrote:
> The build log is at
> https://ci.appveyor.com/api/buildjobs/d0s8pbatmb7ax667/log
>
> I can attach it if that would be helpful. Thanks, Greg
Thanks, seeing the "ASYNC BUG" and EACCESS was enough.
I ... -
- @normalperson
The patch was fine, but the Appveyor build stopped.
Earlier, r64206 built fine, and I added the patch, which also built on that.
The build log is at
https://ci.appveyor.com/api/buildjobs/d0s8pbatmb7ax667/log
I ... -
- > > https://bugs.ruby-lang.org/issues/14968
>
> Updated patch on top of r64203 since I restored timer-thread :<
>
> https://80x24.org/spew/20180806053511.2421-1-e@80x24.org/raw
Greg, btw, does the above patch work on Windows?... -
- > Bug #14968: [PATCH] io.c: make all pipes nonblocking by default
> https://bugs.ruby-lang.org/issues/14968
Updated patch on top of r64203 since I restored timer-thread :<
https://80x24.org/spew/20180806053511.2421-1-e@80x24.org/raw -
- Crap, I always planned to have something like this for [Feature #13618]
(auto-Fiber); but introducing a race condition for Timer-thread
elimination in [Misc #14937] forced me to introduce this early.
Anyways, I might have to revert ... -
- Updated patch to default close_others to false
-
06:27 PM Feature #14938: Provide API to get same result as ruby -wc
- > This warning dispatches on_arg_ambiguous method.
> ...
How can I find the list of all events for warning and compile error?
When should I use compile_error?
https://docs.ruby-lang.org/en/2.5.0/Ripper.html#method-i-compile_error
... -
- My fork passed on Appveyor:
https://ci.appveyor.com/project/MSP-Greg/ruby/build/7#L4336 -
- * [Feature #14944] Support optional inherit argument for Module#method_defined?
-
- * [Bug #14968] io.c: make all pipes nonblocking by default
* [Misc #14937] timer-thread elimination depends on [Bug #14968] -
- [Feature #14967] Any type - Adds a wildcard type, primarily for use in Pattern Matching type syntaxes
This would be related to, and give more expressive power to the following features:
[Feature #14869] Proposal to add Hash#=== (no... -
02:32 PM Feature #14916: Proposal to add Array#===
- I think there is a potential incompatibility here, due to changing the behavior of #===.
The fact `Module#===` doesn't return true for mod === mod exacerbates the issue.
For instance,
~~~ ruby
v = [String, 42]
case v
when [Stri... -
12:46 PM Bug #14970 (Closed): -i option doesn't work for multi-byte-char filenames on Windows Ruby2.5.1
- Z:\>touch あ
Z:\>ruby -v
ruby 2.5.1p57 (2018-03-29 revision 63029) [i386-mingw32]
Z:\>ruby -i.bak -pe p あ
-e:1: warning: Can't rename あ to あ.bak: No such file or directory, skipping file
Z:\>d:\Ruby24\bin\ruby.exe -v
ruby 2.4.1p111 ... -
09:08 AM Feature #13904 (Closed): getter for original information of Enumerator
- Applied in changeset trunk|r64205.
----------
enumerator.c: Introduce Enumerator::ArithmeticSequence
This commit introduces new core class Enumerator::ArithmeticSequence.
Enumerator::ArithmeticSequence is a subclass of Enumerator, and
... - 09:08 AM Revision 24daf140 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64206 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 09:08 AM Revision f1506933 (git): enumerator.c: Introduce Enumerator::ArithmeticSequence
- This commit introduces new core class Enumerator::ArithmeticSequence.
Enumerator::ArithmeticSequence is a subclass of Enumerator, and
represents a number generator of an arithmetic sequence.
After this commit, Numeric#step and Range#ste... - 08:42 AM Revision 1777e39c (git): test/ripper/test_parser_events.rb (test_block_variables): increase RLIMIT_AS
- Unfortunately, MJIT goes over the 100M RLIMIT_AS for this test
on x86-64 (Debian 9)
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64204 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
08:11 AM Bug #14969: Process.groups が返す GID が重複している場合がある
- つまり、
・specを直すに賛成である
・ただ、API docで Process.groups.sort.uniq がふつうの使い方みたいに教えてあげるのが親切と思う
の２つが意見です -
- Process.groupsが
・結果が昇順にソートされている保証はない（OS依存）
・Effective gidが入っているかどうかはOS依存
・重複するIDはそのままarrayに入っていることもあれば、重複が取り除かれていることもある（OS依存）
というあたりは、ドキュメントに記載してもいいのではないかと思いました -
- Process.groupsはgetgroups(2)のラッパってことで、重複を省くなどの余計なことはしない、に一票です。
idコマンドの結果を期待値にしているspecの方にそもそも無理を感じます。なので、specの方をいじる、でよいのではないでしょうか。 -
- Ubuntu 16.04 から 18.04 にアップグレードした環境で以下の ruby spec が失敗することに気づきました。
```
1)
Process.groups gets an Array of the gids of groups in the supplemental group access list FAILED
Expected [4, 24, 27, 30, 46, 110, 114, 120, 120, 121]
to equal... -
- > > http://ci.rvm.jp/results/trunk@P895/1173951
> or I will have to revert and reintroduce timer-thread :<
reverted for now :< r64203
> /me resumes beating his head against the wall... -
- > http://ci.rvm.jp/results/trunk@P895/1173951
Damnit, this is because IO#gets on blocking pipes doesn't
hit rb_wait_for_single_fd and thus never gets to check
sigwait_fd (self-pipe)
Anyways, I hope it is acceptable to make all... - 05:22 AM Revision 194a6a2c (git): thread_pthread.c: restore timer-thread for now :<
- [ruby-core:88306]
Revert "process.c: ensure th->interrupt lock is held when migrating"
This reverts commit 5ca416bdf6b6785cb20f139c2c514eda005fe42f (r64201)
Revert "process.c (rb_waitpid): reduce sigwait_fd bouncing"
This reverts com... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64202 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- In Scala, there's the concept of an Any type which can be used to match anything.
The implementation of which is quite simple: https://github.com/baweaver/any
```ruby
class Any
class << self
def ===(b)
true
end... - 01:06 AM Revision 5ca416bd (git): process.c: ensure th->interrupt lock is held when migrating
- w->cond may be changed without our knowledge in waitpid_nogvl
without th->interrupt_lock
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64201 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
08/05/2018
-
- A while ago, @hsbt committed r62990, and the following line was in `test\test_tmpdir.rb`:
```
TRAVERSAL_PATH.delete!(':') if /mswin|mingw/ =~ RUBY_PLATFORM
```
When it was backported to 2.5 (r62971), the line was omitted. I beli... -
- I recently got permission to repurpose the `Any` gem, which gives us this:
```
require 'any'
case {id: 1, name: 'foo', age: 42}
when {id: Any, name: /^f/, age: Any} then true
else false
end
# => true
case {id: 1, name: 'foo... -
- Could you test configuring ARCH_FLAG instead of CFLAGS/CXXFLAGS? I'm not sure which variable should be used for -mtune, but it seems that at least -march=barcelona is expected to be set as ARCH_FLAG like ARCH_FRAG="-march=barcelona". I e...
-
- after some investigation, I found the problem is my build options
this builds successfully
```
rb_mjit_header_ok.h
"CXXFLAGS='-O3'",
"CFLAGS='-O3'"
```
but if I add march/mtune it fails
```
rb_mjit_header_fail.h
"CXXFLAGS='... -
- > Is it a known problem?
No, thanks to report.
> ...
I intend to support at least gcc on msys2/MinGW in MJIT and sometimes check if it works.
> Windows 10 64bit, x86_64-w64-mingw32
> ...
I'm using Windows 10 64bit too, and:
... -
- I'm using MSYS1 that could be a problem, but I don't see any difference or a reason why it shouldn't work. You don't pass any additional flags in ruby loco, also you have some patches, but none of them seem to be related to this error. M...
-
- @ahorek
The most recent ruby-loco build (MinGW) passed all tests and had the following output when running test_jit.rb locally:
```
Finished tests in 279.718157s, 0.2789 tests/s, 1.7696 assertions/s.
78 tests, 495 assertions, 0 f... -
- > [...] I can compile the lastest Ruby 2.5.1 with the same options.
> ...
I assume that k0kubun is working on the mjit-component right now (possibly
excluding Sundays :D) - he is like super-busy changing mjit code almost
every day. :)... -
- I'm having trouble building Ruby 2.6 on Windows.
this is the first error:
```
building rb_mjit_header.h
rb_mjit_header.h updated
building .ext/include/x64-mingw32/rb_mjit_min_header-2.6.0.h
./miniruby.exe -I../ruby_2_6/lib -I. -I... - 09:27 PM Revision 217bdd77 (git): process.c (rb_waitpid): reduce sigwait_fd bouncing
- Once a thread has acquired sigwait_fd, hold onto it until
waitpid is complete. This prevents unnecessary migration
and atomic operations.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64200 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r64197.
----------
thread_pthread: stop trying to deal with cancellation
We don't use pthreads cancellation ourselves and it's painful to
use correctly. Any cancelled threads would break
vm->living_threads, ... - 08:06 PM Revision 9f395f11 (git): test/ruby/test_thread.rb (test_thread_timer_and_interrupt): add timeouts
- Trying to diagnose CI failures from i686-linux on Debian 7.
This also fixes a potential GC problem with Thread.start or
IO#read potentially closing the write-end of the pipe due
to allocation.
cf. http://www.rubyist.net/~akr/chkbuild/d... - 08:06 PM Revision d17c7ba3 (git): * 2018-08-06
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64198 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 08:06 PM Revision 2ba640f3 (git): thread_pthread: stop trying to deal with cancellation
- We don't use pthreads cancellation ourselves and it's painful to
use correctly. Any cancelled threads would break
vm->living_threads, GVL, thread_sync.c, autoload, etc...
So don't bother caring; because we can't stop rogue extensions
f... -
06:25 PM Bug #14965 (Third Party's Issue): Segmentation fault at 0x0000000000000000
- I had installed rabbit (`$ gem install rabbit`) and created this file
```Markdown
# NES
```
I then run `$ rabbit --type file presentation.md` and it crashed. :´(
-
- @h.shirosaki, thanks for your work on this. I tested your patch 0001-dir.c-performance-fix-with-braces.patch (ruby head + braces) based on the current trunk https://github.com/ruby/ruby/pull/1864
environment:
```
Samsung 850 Pro 250... -
- This option makes sure that the argument is C source file.
Probably this is not needed, but since I'm debugging it, I want to
exclude any failure possibility for now.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64196 b2dd03c8-39d4... -
11:00 AM Bug #14350: Strange behavior for Array.min in ruby 2.5.0
- ruby_2_5 r64195 merged revision(s) 61766.
-
- vm_insnhelper.c: search in the indexing order
* vm_insnhelper.c (vm_opt_newarray_max, vm_opt_newarray_min):
search in the indexing order, as well as usual methods.
[ruby-core:84821] [Bug #14350]
git-svn-id: ... - 08:56 AM Revision 14d13bc1 (git): test/ruby/test_process.rb (test_wait_and_sigchld): allow extra SIGCHLD
- MJIT way generate an extra SIGCHLD, so we'll have to deal with it.
Any realistic Ruby program may hit unexpected SIGCHLD, too,
since any spawned subprocess could have extra grandchildren
which get reaped by the main Ruby process, and SI... - 08:56 AM Revision b3aa256c (git): thread_pthread.c (native_sleep): reduce ppoll sleeps
- By holding into sigwait_fd until after we acquire GVL, we can
hit the faster native_cond_sleep path instead of ppoll when
another thread wants to start sleeping. ppoll-ing on sigwait_fd
isn't really useful in program where GVL is conten... -
- I am in Narita and I will try to come to the meeting. The only reason why I won't make it is because I get lost on the way :)
I would like to discuss the following issues:
https://bugs.ruby-lang.org/issues/14736
https://bugs.rub... -
- This is needed to resolve:
"error LNK2011: precompiled object not linked in; image may not run"
win32/Makefile.sub: Use the same flags as ones for precompiled header.
This is needed to resolve:
"error C2855: command-line option '/Z7' i... -
- Just moved make_pch into `#else` of `#ifdef _MSC_VER`.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64191 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- on mswin properly.
Deleted code to attempt make_pch for mswin, since it won't be needed.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64190 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- file name correctly. This allows to use the header installed by r64188.
win32/Makefile.sub: define prebuilt precompiled header path instead of
unused min header path
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64189 b2dd03c8-39d4...
08/04/2018
-
- See the comment in win32/Makefile.sub.
Not only .pch, but also .obj needs to be installed and used on runtime.
.gitignore: ignore .pch that will be built by this.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64188 b2dd03c8-39d4-4d... - 11:33 PM Revision ff1e6657 (git): test/ruby/test_io.rb (test_select_leak): speedup and reduce memory use
- We can reuse the sub-thread and exception with Thread#raise to
reproduce the old memory leak with less overhead. This allows
us to to run more iterations and improve reliability of the
actual test, particularly on platforms without USE_... - 10:58 PM Revision 80e973f0 (git): test/ruby/test_thread.rb (test_thread_interrupt_for_killed_thread): conserve resources
- Use Thread.pass to let the sub-thread finish. This should avoid
running out of memory on resource-constrained systems.
(We don't want to use Thread#join to hit the exception)
This results in a significant memory usage reduction in this... - 08:38 PM Revision 291a82f7 (git): thread.c (consume_communication_pipe): do not retry after short read
- Saves a syscall and slightly improves vm_thread_condvar1
benchmark slightly (more improvements on the way):
r64170 this patch
vm_thread_condvar1 0.917 1.065
git-svn-id: svn+ssh://ci.ruby-la... - 08:34 PM Revision 3dbd8d1f (git): test/ruby/test_io.rb (test_race_gets_and_close): timeout each thread
- Still looking into CI failures on P895 (and seemingly no other boxes):
http://ci.rvm.jp/results/trunk@P895/1190369
:<
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64184 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I recently got permission to repurpose the `Any` gem, which gives us this:
```
require 'any'
case ['Foo', 25]
when [/^F/, Any] then true
else false
end
# => true
```
That should make this even more flexible, and eliminate ... -
- I would agree with `===` being more useful than `<=`, as `case`, `all?`, `grep`, and other methods use it implicitly.
This would be an amazing addition for Ruby, and would bring us closer to pattern matching syntax.
The great part ... - 03:12 PM Revision 32d6becb (git): * 2018-08-05
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64183 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Since it's impossible to leave macro when preprocessing C source file
with cl.exe, I decided to create precompiled header on Ruby's build time
instead.
We're not doing it for non-mswin environment for 2 reasons:
1) Precompiled header ma...
08/03/2018
- 09:53 PM Revision 81f1285b (git): spec/ruby/library/socket/socket/getaddrinfo_spec.rb: avoid nonsensical lookup
- "http" is a TCP service, so /etc/services on typical GNU/Linux systems
only specify a TCP port for it. Use "discard" since it seems
used for other specs and is specified as both TCP and UDP.
This caused many CI failures like the follow... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64180 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64179 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * Clarify logic and add spec.
* Now passes test-all with the JSON fix.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64178 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * See https://github.com/flori/json/issues/342
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64177 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 03:11 PM Revision 27f34274 (git): * 2018-08-04
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64176 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64175 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
02:49 PM Bug #14963 (Closed): Since r64107, on Solaris, spec test of rb_io_wait_readable hangs up
- Since r64107 (removal of timer thread), on Solaris (both on Solaris 10 and Solaris 11, both on x86 and sparc),
`make test-rubyspec` never ends in the test of rb_io_wait_readable in spec/ruby/optional/capi/io_spec.rb.
~~~
C-API IO fu... -
- * This reverts commit fb253d2032e51f333e6577aa4fcf0c03f9c6fc02.
* The CI is failing, this seems a bug in the JSON C extension.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64174 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * Clarify logic and add spec.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64173 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * Add spec.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64172 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64171 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
10:52 AM Feature #14473: Add Range#subrange?
- Great, thank you tarui
-
03:04 AM Feature #14473: Add Range#subrange?
- I am happy that match opinion with you.
I will commit based on your patch. It'll take a little while.
-
- robert.wiegmann@gmail.com wrote:
> https://bugs.ruby-lang.org/issues/14961
queue_sleep. Is that combined with fork? Could be [Bug #14634]
(fixed in trunk, not in 2.5 branch, yet). -
- No clue other than that it crashed in this thread.
```
Thread 5 Crashed:: server.rb:286
0 libsystem_kernel.dylib 0x00007fffa8689d42 __pthread_kill + 10
1 libsystem_pthread.dylib 0x00007fffa8777457 pthread_kill + ... -
-
- Thank you, @rafaelfranca.
It a fixed bug in the trunk, but doesn't seem backported to 2.5 yet. -
01:21 AM Bug #14959: Writing a "link_to" method and a "url_helper" with a request parameter under certain "if else" statement in Rails helper crashes with KERN_INVALID_ADDRESS at 0x0000000000000000
- also see: https://bugs.ruby-lang.org/issues/14894 probably the same issue.
-
- thread_pthread: stop trying to deal with cancellation
We don't use pthreads cancellation ourselves and it's painful to
use correctly. Any cancelled threads would break
vm->living_threads, GVL, thread_sync.c, autoload, etc...
So ... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64170 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * random.c (rand_range): moved call of domain_error(), not to
raise an exception in range_values().
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64169 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ast.c (Init_ast): undefine allocator of Node, as a method call
on an uninitialized Node causes segfault.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64168 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r64167.
----------
random.c: endless range random
* random.c (range_values): cannot determine the domain of an endless
range. [ruby-core:88261] [Bug #14958] -
- * random.c (range_values): cannot determine the domain of an endless
range. [ruby-core:88261] [Bug #14958]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64167 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- It seems to be unavailable on some platforms including my Android phone.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64166 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Done some more investigating. The following code I've run four ways.
Using two versions of ruby 2.6.0dev (2018-08-03 trunk 64164) [x64-mingw32], one built with gcc 7.3.0, and one with gcc 8.2.0. I've run the same code on Appveyor & ...
08/02/2018
-
10:11 PM Bug #14961 (Closed): Segfault when running RSpec / Capybara / Rails
- After upgrading to 2.5.1, we consistently see a segfault when running RSpec + Capybara against a Rails application.
-
- http://ci.rvm.jp/results/trunk_clang_38@silicon-docker/1185552
:<
> ko1@atdot.net wrote:
> > http://ci.rvm.jp/results/trunk-test@frontier/1153126
ko1: is frontier also on Docker? I seem to remember hearing of
some UDP problems... -
- ko1@atdot.net wrote:
> http://ci.rvm.jp/results/trunk-test@frontier/1153126
Oh, different test, that is test_timestampns getting stuck.
Trying r64157:
test/socket/test_socket.rb (test_timestampns): retry send
It looks like we... -
- Applied in changeset trunk|r64157.
----------
test/socket/test_socket.rb (test_timestampns): retry send
It looks like we need to retry test_timestampns in addition
to test_timestamp; so share some code while we're at it.
cf. http://ci... - 09:13 PM Revision 8c2ae6e3 (git): thread_pthread.c (gvl_acquire_common): persist timeout across calls
- Reuse old expiration time if the previous native_cond_timedwait
did not return ETIMEDOUT. This should improve timeslice
accuracy for Timeout.timeout rubyspec without causing excessive
wakeups on uncontended GVL acquisition.
cf. http://... -
07:46 PM Bug #14959: Writing a "link_to" method and a "url_helper" with a request parameter under certain "if else" statement in Rails helper crashes with KERN_INVALID_ADDRESS at 0x0000000000000000
- Minimal reproduction steps.
~~~ruby
code = <<~CODE
module ApplicationHelper
def broken_helper_in_application_helper
if true
else
link_to 'somewhere', some_view_path(foo: 'false')
end
end
end
CODE
RubyV... -
07:00 PM Bug #14959 (Closed): Writing a "link_to" method and a "url_helper" with a request parameter under certain "if else" statement in Rails helper crashes with KERN_INVALID_ADDRESS at 0x0000000000000000
- # Disclaimer
Sorry about the problem being rails, and not ruby specific. I couldn't narrow down the problem and wording it correctly.
As it turns out that the problem derived from the ruby vm used in my Rails application, I decided to... -
07:38 PM Bug #14960 (Closed): Segmentation fault
- rbenv/versions/2.5.1/lib/ruby/gems/2.5.0/gems/bootsnap-1.3.0/lib/bootsnap/compile_cache/iseq.rb:12: [BUG] Segmentation fault at 0x0000000000000000
ruby 2.5.1p57 (2018-03-29 revision 63029) [x86_64-darwin17] -
- Closing this as it doesn't seem to be an issue in recent Ruby/OpenBSD versions.
-
- I changed the failing test from test_unload_units to test_compile_insn_putspecialobject_putiseq in r64163 because unload_units is actually working fine and the bad one is putiseq.
-
- Yeah, the status is intentional. I checked many things for linking `rb_mRubyVMFrozenCore` properly but still no luck.
We may be able to avoid referring to `rb_mRubyVMFrozenCore`, but we have no confidence on performing link and load o... -
- @k0kubun
Re above message, after r64161, JIT tests are working again. I tried test_unload_units, and that is still failing. Also, the build was using gcc 8.2.0.
Thanks for the work, and I'll run r64162 soon, Greg - 03:35 PM Revision 0a03394b (git): * 2018-08-03
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64164 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Actually unload_units is working on MinGW, but putiseq is behaving
badly.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64163 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- because linking multiple .o files is problematic without having `static`
to the same function definitions.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64162 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- is specified.
This is needed for MinGW because MJIT_BUILD_DIR doesn't prefix path
like "C:\msys64", so it can't be read without msys2's conversion.
The workaround is not needed for Windows (LOAD_RELATIVE looks defined by
default) anywa... -
- on MinGW with __atomic_exchange_n(). It returns the previous pointer value but
obviously it's not needed in MJIT's usage.
mjit.c: In function 'compact_all_jit_code':
ruby_atomic.h:11:36: warning: value computed is not used [-Wunused-val... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64159 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
07:16 AM Feature #14951: New operator to evaluate truthy/falsy/logical equivalence
- After getting the feedback here, I no longer support my original proposal. But I would be happy if something like `Object#iff?` existed instead. I think logical equivalence is a legitimate use case. And alternaive expressions for logical...
- 06:09 AM Revision 6f7b3de1 (git): * 2018-08-02
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64158 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 06:09 AM Revision 12f11714 (git): test/socket/test_socket.rb (test_timestampns): retry send
- It looks like we need to retry test_timestampns in addition
to test_timestamp; so share some code while we're at it.
cf. http://ci.rvm.jp/results/trunk-test@frontier/1153126
[ruby-core:88104] [Bug #14898]
git-svn-id: svn+ssh://ci.ruby-... -
- Wow awesome news @normalperson this is going to make a massive difference with Ruby 2.6!