Activity
From 02/24/2018 to 03/02/2018
03/02/2018
-
09:46 PM Bug #14571 (Closed): File descriptor leak in resolv.rb
- There's an edge case in resolv.rb that can lead to file descriptor leaks on a highly saturated system (logstash in our case).
: Make File.expand_path/real_path casing consistent on Windows
- `File.realpath` returns the path with the same upper/lower case characters as the input parameter. But `File.expand_path` is different. It adjusts the last part of the path (and only this) to the upper/lower case characters given from th...
-
09:28 PM Bug #14569: Ruby dumps core involving XML file
- It may be the same as #14273.
-
08:54 PM Bug #14569 (Closed): Ruby dumps core involving XML file
- See https://github.com/projectblacklight/blacklight/issues/1840
-
02:45 PM Bug #14568 (Closed): Build failures - MinGW ruby-loco since 62622 2018-03-01
- Applied in changeset trunk|r62637.
----------
openssl: search winsock
* ext/openssl/extconf.rb: on Windows search winsock library
always, regardless pkg-config. direct use of winsock is not
region of OpenSSL. [ruby-core:85895] [B... -
02:33 PM Bug #14568: Build failures - MinGW ruby-loco since 62622 2018-03-01
- @nobu,
From the MSYS2 shell -
```
$ pkg-config --libs openssl
-LE:/msys64/mingw64/lib -lssl -lcrypto
```
-
- nobu (Nobuyoshi Nakada) wrote:
> Do you have `pkg-config` command?
> ...
Sorry, `pkg-config --libs openssl`.
I also failed it for a while today, by cygwin's `pkg-config`.
-
- Do you have `pkg-config` command?
If so, what does `pkg-config --libs` return? -
- Since 62622, MinGW builds have been failing (62627, 62628, 62631). See https://ci.appveyor.com/project/MSP-Greg/ruby-loco/history.
I just tried 62633 locally, and had a similar failure.
Using gcc 7.3.0 & OpenSSL 1.1.0g.
Text in... -
- * ext/openssl/extconf.rb: on Windows search winsock library
always, regardless pkg-config. direct use of winsock is not
region of OpenSSL. [ruby-core:85895] [Bug #14568]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62637 b2dd... -
01:08 PM Misc #14567: Clarify YAML docs
- @Eregon, thanks for merging!
BTW, as we are here, I have posted several doc.patches lately, and they had no reactions:
https://bugs.ruby-lang.org/issues/14483
https://bugs.ruby-lang.org/issues/14450
https://bugs.ruby-lang.org/issue... -
12:57 PM Misc #14567: Clarify YAML docs
- @zverok Thank you for the patch!
-
- Applied in changeset trunk|r62635.
----------
Clarify the documentation of the YAML module [Misc #14567]
Based on a patch from Victor Shepelev -
- Sounds good to me, I'll commit it.
-
- The problem I am trying to solve: If you try to understand what methods do `YAML` have, and what parameters, say, `YAML.load_file` accept, the "official" docs look [pretty unhelpful](https://docs.ruby-lang.org/en/2.5.0/YAML.html), saying...
-
12:59 PM Bug #14118: Please backport r59454, r59954
- ruby_2_4 r62636 merged revision(s) 59454,59954.
-
- configure.in: use libtool
* configure.in: use libtool on macOS to suppress a warning against
debug_counter.o, which has no symbols unless USE_DEBUG_COUNTER
is set to non-zero.
configure.in: use newer... -
- Based on a patch from Victor Shepelev
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62635 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_4 r62634 merged revision(s) 62506,62508.
-
- test_time_tz.rb: past Japanese DST tzdata fix
* test/ruby/test_time_tz.rb (TestTimeTZ#test_asia_tokyo): follow
the tzdata 2018 fix of Japanese DST transitions (1948-1951).
[ruby-core:85373] [Bug #14438]
... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62633 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
08:25 AM Bug #14557: rubyコマンド引数にファイルを渡す際, プロセス置換を使用するとエラー
- ruby_2_5 r62632 merged revision(s) 62606,62607.
-
- file.c: get rid of useless conversion
* file.c (rb_file_s_stat): File.stat does not accept an IO
object as trying conversion to path name string first. skip
conversion to IO and try stat(2) only.
fi... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62631 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * win32/Makefile.sub: fix missing suffix of user32.lib.
[Bug #14422]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62630 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * win32/Makefile.sub: always link user32.lib which provides a lot
of very common library functions. [Bug #14422]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62629 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Seems marking dead fiber's stack.
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62628 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Applied in changeset trunk|r62627.
----------
configure.ac: library options to MAINLIBS
* configure.ac (MAINLIBS): moved library options for main program
and static libruby, and append MAINLIBS to LIBRUBYARG_STATIC, as
these librar... -
- * configure.ac (MAINLIBS): moved library options for main program
and static libruby, and append MAINLIBS to LIBRUBYARG_STATIC, as
these libraries are not needed for linking to shared libruby.
[ruby-core:85882] [Bug #14422]
git-sv... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62626 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62625 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:36 AM Bug #14566 (Closed): `raise` in `Exception#message` causes infinite loop
- This code does not stop.
```ruby
class A < StandardError
def message
raise
end
end
raise A
```
The following code also does not stop.
```ruby
class A < StandardError
def message
1/0
end
end
...
03/01/2018
- 10:49 PM Revision 72df2630 (git): * 2018-03-02
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62624 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Passing options to configure like as `configure MJIT_OPTFLAGS=-O
MJIT_DEBUGFLAGS=-g` overrides options to be used to compile JIT
code, separately from the default options to be used for ruby
itself.
git-svn-id: svn+ssh://ci.ruby-lang.or... -
- @shevegen If you press "Edit", the form has `Description [Edit]` field, and you can edit description there.
-
05:49 PM Feature #14565: Simpler, one-liner, failsafe require in ruby? [Suggested names: require_failsafe, require_safe, require_try, require_add)
- (I have a few typos above; is there a way to edit the first post in the
bug tracker? I only seem to be able to edit in subsequent posts... hmm) -
- I have quite a bit of code like this:
```ruby
begin
require 'x/tools/cdrskin.rb'
rescue LoadError; end
```
I also use the longer variant, e.g.,
```ruby
begin
require 'foobar'
rescue LoadError
puts 'project foobar i... -
03:56 PM Bug #14561: Consistent 2.5.0 seg fault in GC, related to accessing an enumerator in a thread
- harbirg (Harbir G) wrote:
> I can also reproduce the same crash on MacOS High Sierra 10.13.2. Occurs on both 2.5.0 and 2.6.0-preview1.
+1. Reliably reproducible on Mac, ruby 2.5.0 OSX El Capitan 10.11.6
Currently causing unit t... -
10:44 AM Bug #14561: Consistent 2.5.0 seg fault in GC, related to accessing an enumerator in a thread
- I can reproduce, MacOS High Sierra 10.13.3 (17D47)
```
nedims-MacBook-Pro:~ nedim$ irb
2.5.0 :001 > enum = Enumerator.new { |y| y << 1 }
=> #<Enumerator: #<Enumerator::Generator:0x00007fe043133b90>:each>
2.5.0 :002 > thread = Th... -
06:04 AM Bug #14561: Consistent 2.5.0 seg fault in GC, related to accessing an enumerator in a thread
- I can also reproduce the same crash on MacOS High Sierra 10.13.2. Occurs on both 2.5.0 and 2.6.0-preview1.
-
05:28 AM Bug #14561: Consistent 2.5.0 seg fault in GC, related to accessing an enumerator in a thread
- Yes, I have been able to reproduce this issue only on mac.
-
03:09 AM Bug #14561: Consistent 2.5.0 seg fault in GC, related to accessing an enumerator in a thread
- I can't reproduce this issue with current trunk (2.6) on Linux / Windows.
clang (mac) issue?
-
- Was already proposed as a "bury" (direct antonym to `dig`) and rejected: https://bugs.ruby-lang.org/issues/11747 and https://bugs.ruby-lang.org/issues/13179
Matz's response:
* "It's not clear to generate either Hash, Array, or Stru... -
- I have nothing against the functionality, but I think the name .expand()
is not a good one. When I read .expand, I think of the opposite of
flatten; or it reminds me of .extend.
I don't have a better name suggestion myself, though. -
08:57 AM Feature #14564 (Open): `dig` opposite method
- We have nice `dig` method that helps a lot.
Though we didn't have an opposite method that allows setting a value.
I know we already have these:
https://bugs.ruby-lang.org/issues/11747
https://bugs.ruby-lang.org/issues/13179
Both wer... -
10:52 AM Bug #14422: Ruby configuration options should not be reused for gem builds
- So I have another issue with the configuration options. I tried to enable GMP support in Ruby on Fedora. Therefore, the Ruby build now requires "gmp-devel" and the configuration scripts configures the ruby to link against GMP. So far so ...
-
- > 1) Revisions become meaningless hashes; it's totally impossible to look at a revision id and know where it fits in relation to other revision ids.
Looking at the committer date is enough to know the relation if we rebase (which is s... -
- * compile.c (ibf_load_object_unsupported, ibf_load_object_class):
should raise an exception. rejection of invalid input is not a
bug.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62622 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * compile.c (ibf_dump_object_regexp): do not truncate VALUE to
long. it makes invalid VALUE on IL32LLP64 platforms where long
is shorter than VALUE.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62621 b2dd03c8-39d4-4d8f-98ff-82... -
06:41 AM Bug #14563 (Closed): irb in irb raises a FATAL error
- Start irb in irb, then C-c and C-d cause a fatal error.
~~~ text
$ irb
irb(main):001:0> irb
irb#1(main):001:0> ^C
irb#1(main):001:0>
Traceback (most recent call last):
16: from /Users/hkdnet/.anyenv/envs/rbenv/versions/2.... -
- Applied in changeset trunk|r62620.
----------
parse.y: refine assign_in_cond warning
* parse.y (assign_in_cond): refine a warning message for
assignment of a literal in conditinal expression.
[ruby-core:85872] [Bug #14562] -
- Just remove `if`.
It is the warning for assignment of a **literal**, which is not "conditional". -
01:15 AM Bug #14562 (Closed): Do not warn for assignment in conditionals inside ()
- Ruby warns against this code, which is very helpful.
```
% ruby -we 'if a=1; p a; end'
-e:1: warning: found = in conditional, should be ==
1
```
So there's a commonly known practice. In order to express that we're intentionall... -
- * parse.y (assign_in_cond): refine a warning message for
assignment of a literal in conditinal expression.
[ruby-core:85872] [Bug #14562]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62620 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62619 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * tool/bisect.sh: also srcs needs Makefile, must in the build but
not the source directory.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62618 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I filed a separate issue https://bugs.ruby-lang.org/issues/14561 with a small repro case involving Enumerator and threads, which seems to yield the same C backtrace as the ones reported here.
-
- This can be closed by #13969?
-
- * compile.c (ibf_load_iseq_each): realpath may be nil. follow up
r59709. [fix https://github.com/Shopify/bootsnap/issues/132]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62617 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
02/28/2018
-
- This seg fault happens consistently on OSX (specifically I'm reproing it on a late 2015 Macbook pro running 10.13.3, but it seems to happen on similar machines as well). It happens only on Ruby 2.5.0.
Small repro case:
```ruby
enu... - 11:31 PM Revision 7d55ee28 (git): * 2018-03-01
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62616 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * compile.c (ibf_dump_object_list): `dump->obj_list` is not fixed
yet, as new objects are pushed by lbf_dump_object_object.
fixes crash by buffer overflow.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62615 b2dd03c8-39d4-4d8f-9... -
- I wish the original backtrace order is back. If at least the order was consistent. I must agree that the current situation is unbearable.
-
- I think I understand what Goro Fuji refers to.
It sometimes takes me a while as well to adjust to the change, too.
What I found in particular hard is when it is a long backtrace AND
when the .rb file names are long and deeply bran... -
08:20 AM Bug #14558: "Backtrace in reverse order" always upsets my brain!
- mrkn (Kenta Murata) wrote:
> > it sometimes "reversed", sometimes "non-reversed"
> ...
Might be acceptable, or at least it's better than the current "random" order.
Why not provide a way to customize it, for example `RubyVM.backtr... -
08:10 AM Bug #14558: "Backtrace in reverse order" always upsets my brain!
- > it sometimes "reversed", sometimes "non-reversed"
Is it acceptable that the backtrace is always new, 2.5-style order?
-
- A Ruby 2.5.0 feature "backtrace in reverse order", issued in https://bugs.ruby-lang.org/issues/8661, is confusing in developing Rails applications because I can't expect the order: it sometimes "reversed", sometimes "non-reversed". It ju...
-
07:25 PM Feature #13618: [PATCH] auto fiber schedule for rb_wait_for_single_fd and rb_waitpid
- I would argue strongly for keeping simpler one-word naming conventions where possible. Ruby is built upon a simple elegance, and having to type out things such as Thread::Attr.new(type: :coop) feels very unintuitive.
It also stands th... -
07:02 PM Feature #14463: Allow comments to precede dots in member expressions
- shevegen (Robert A. Heiler) wrote:
> > I still find it very odd that it's inconsistent.
> ...
It wasn't more than a month in that I first got bit. Like I said earlier, Ruby isn't my primary language (I started with Java, and JavaScript... -
06:22 PM Feature #14551: What's missing to switch to Git instead of using Subversion?
- duerst@it.aoyama.ac.jp wrote:
> Two points that would be worse for git, the first is general,
> the second is personal:
> 1) Revisions become meaningless hashes; it's totally
> impossible to look at a revision id and know where it f... -
- duerst (Martin Dürst) wrote:
> 1) Revisions become meaningless hashes; it's totally impossible to look at a revision id and know where it fits in relation to other revision ids.
The revision shown by `ruby -v` can be managed by addin... -
05:43 AM Feature #14551: What's missing to switch to Git instead of using Subversion?
- Two points that would be worse for git, the first is general, the second is personal:
1) Revisions become meaningless hashes; it's totally impossible to look at a revision id and know where it fits in relation to other revision ids.
2)... -
04:22 PM Bug #14560 (Closed): Segmentation fault near the end of large Rails test suite
- I am consistently getting a Segmentation Fault about 1800 tests into a test suite with about 1900 tests. This is for a Rails 5.1.5 project using Ruby 2.5.0.
Crash report follows:
/Users/mmo/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0... -
02:31 PM Revision 9af2ab9d (git): NEWS: resurrect ticket number [ci skip]
- which was unintentionally dropped at r62612.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62614 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- [ci-skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62613 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Seems sensible.
-
08:39 AM Feature #14559 (Closed): ENV.slice
- I would like to request `ENV.slice`, which should behave analogous to `Hash#slice`.
```ruby
ENV.slice("PATH", "FOO")
# => {"PATH" => "/foo:/bar", "FOO" => "foo"}
``` -
- I forgot to have a link to this ticket in r62612.
Ruby 2.5's ERB.new interface will continue to be available until Ruby 2.5 becomes EOL. So you don't need to branch ERB.new usage in many places. The deprecation warning is shown only ... -
- I changed my mind and thought branching ERB.new in all libraries is too
hard. Code becomes too ugly. I increased the warn level to 2, and the
old initializer will be removed when Ruby 2.5 becomes EOL.
-S option of erb(1) stays in the sam... -
11:12 AM Revision 9d16226f (git): Prefer to use %x instead of backtick.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62611 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- ruby_2_5 r62610 merged revision(s) 62572.
-
- date_core.c: defensive code
* ext/date/date_core.c (f_cmp): check comparison failure.
* ext/date/date_core.c (d_lite_step): deal with the comparison
result more defensively. [ruby-core:85796] [Bug #14549]
gi... -
- ruby_2_5 r62609 merged revision(s) 62506,62508.
-
- test_time_tz.rb: past Japanese DST tzdata fix
* test/ruby/test_time_tz.rb (TestTimeTZ#test_asia_tokyo): follow
the tzdata 2018 fix of Japanese DST transitions (1948-1951).
[ruby-core:85373] [Bug #14438]
... -
- * test/ruby/test_time.rb (test_strftime_no_hidden_garbage): this test
checks no object allocation while specific process, however another
thread can generate objects.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62608 b2dd03c8... -
- What is wrong with using `fetch`?
```ruby
{a: "a"}.fetch(:b) # => KeyError: key not found: :b
``` -
- Applied in changeset trunk|r62607.
----------
file.c: realpath on special symlink
* file.c (realpath_rec): fallback to symlink path when it is
accessible but the link target is not actual entry on file
systems. [ruby-dev:50487] [B... -
02:35 AM Bug #14557 (Closed): rubyコマンド引数にファイルを渡す際, プロセス置換を使用するとエラー
- BashやZshにはプロセス置換があり, コマンドにファイル名を渡す代わりにプロセスの出力を渡すことができる. rubyコマンドにプロセスを渡した際にファイルディスクリプタが読めない旨のエラーを得た. 添付したtest.shをbashとzshで実行し標準出力と標準エラーをlog.txtに記録した.
-
- * file.c (realpath_rec): fallback to symlink path when it is
accessible but the link target is not actual entry on file
systems. [ruby-dev:50487] [Bug #14557]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62607 b2dd03c8-39d4-4d... -
- * file.c (rb_file_s_stat): File.stat does not accept an IO
object as trying conversion to path name string first. skip
conversion to IO and try stat(2) only.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62606 b2dd03c8-39d4-4d8... -
01:06 AM Feature #13901 (Closed): Add branch coverage
- Thank you marcandre for proposing the format, and really sorry for my super-late reply.
I considered it seriously (before release of 2.5.0). I understand its advantage (easy and efficient to merge). But I thought it was difficult to... -
- Branch coverage has been already implemented at #13901 and released in Ruby 2.5.0.
Closing this ticket. Sorry for leaving it untouched.
Of course, your contribution is welcome. You may want to read:
https://bugs.ruby-lang.org/pro...
02/27/2018
-
- This still happens on 2.2.9, should it be backported too?
(On gcc (GCC) 7.2.1 20170915 (Red Hat 7.2.1-2)) -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62605 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * It is now part of mspec in spec/mspec/tool/pull-latest-mspec-spec
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62604 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 08:21 PM Revision a5023c33 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62603 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62602 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 08:21 PM Revision ecf03376 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62601 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62600 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- The spec reflects the current state but of course it's fine to change.
The change to specs looks good, except the description should be updated:
- is an identity function if the string is frozen
+ deduplicates frozen strings
(We ne... -
- sam.saffron@gmail.com wrote:
> But this seems to break the test/ruby/test_string.rb cause
> there is some edge case we are missing here.
I didn't see a failure in test_string.rb, but got one rubyspec failure:
```
1)
String#-@... -
07:03 AM Feature #14478: String #uminus should de-dupe unconditionally
- I just tried the trivial patch of:
```
diff --git a/string.c b/string.c
index ebf5618..a9b991f 100644
--- a/string.c
+++ b/string.c
@@ -2605,20 +2605,16 @@ str_uplus(VALUE str)
* call-seq:
* -str -> str (frozen)
*
- ... - 04:45 PM Revision cfe9836b (git): * 2018-02-28
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62599 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 04:45 PM Revision fe2a6f65 (git): Support two `to_r`-responding args in Rational()
- * rational.c (nurat_s_convert): call `to_r` to convert non-Numeric
objects also if argc == 2 in Rational().
* test/ruby/test_rational.rb: add tests.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62598 b2dd03c8-39d4-4d8f-98ff-823f... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62597 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Example:
$ ruby tool/make-snapshot -archname=snapshot -s3=tmp /tmp trunk
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62596 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * random.c (InitVM_Random): extend Random itself by Formatter
module, as well as the `bytes` method used by the module.
[Feature #4938]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62595 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- > nobu
How about this? -
08:45 AM Bug #14556: Please fetch Ripper's new features from nobu's patches bag (irb-ripper branch)
- I eliminate the commit below;
https://github.com/nobu/ruby/commit/0eb5f3f128b352079b447af0faa495bd9ba746a6
because it's already added by https://bugs.ruby-lang.org/issues/13686. -
- I need new features for Ripper because I'm trying to use Ripper for IRB.
@nobu's feature/irb-ripper branch on GitHub contains what all I need:
https://github.com/nobu/ruby/commits/feature/irb-ripper
Specifically, I need commits be... -
12:07 PM Feature #4095: C1 Coverage
- nahi (Hiroshi Nakamura) wrote:
> Contribution are welcomed...
I am planning to contribute to ruby project (starting with this issue), any pointers (where to start wiki/guide) will be much appreciated. -
- Improving code like r62590. See r62529 for details.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62594 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62593 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- vo.x (Vit Ondruch) wrote:
> I tried `--with-setjmp-type=setjmp` and the build passed. But I have no idea what is the performance impact.
Thank you for checking.
> ...
Yes, they are used for the exception handling in Ruby :)
-
03:14 AM Bug #14127 (Rejected): (CSV) generating UTF-16LE encoded file without BOM
- nobu almost said.
You should write BOM by yourself when you use `CSV.generate`.
If you don't want to write BOM by yourself, you should use `CSV.open(..., "w:UTF-16")`:
```ruby
CSV.open("utf16.csv", "w:UTF-16:utf-8") do |csv|
... -
- You can implement it with the following code:
```ruby
CSV.open(path) do |csv|
loop do
begin
row = csv.shift
rescue ArgumentError # For old csv library
# ignore
rescue CSV::MalformedCSVError # For the l... -
-
- > I still find it very odd that it's inconsistent.
Tsuyoshi Sawada pointed out something similar in the issue that
was referred to 5 years ago and I also agree with it.
I know little to nothing how ruby works internally but I woul... -
- isiahmeadows (Isiah Meadows) wrote:
> duerst (Martin Dürst) wrote:
> ...
Sorry.
> I still find it very odd that it's inconsistent. The alternative to my proposal would be to make the third also error (as I presume it did previously)... -
- duerst (Martin Dürst) wrote:
> There is extensive discussion on this at #7636. Please check.
I presume you meant #7639...
I never found that due to probably its age and the fact it was in the other project.
I still find it very... -
- marcandre (Marc-Andre Lafortune) wrote:
> As Matz clearly stated, even if a long time ago, bang is not strictly for mutating versions of methods. Note that there is `Process#exit!` (which is not a mutating version of `Process#exit`). Ra... - 01:17 AM Revision 34560d95 (git): * 2018-02-27
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62592 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62591 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Coming from a JS background, it seems super baffling that OpenStruct is *incredibly* slow\*, slower than even a standard hash. When I looked at the implementation, I could see one very odd design choice: the implementation didn't even *t...
-
- I think this is a good change; I just noticed it from the NEWS
file at:
https://github.com/ruby/ruby/blob/trunk/NEWS
I think of .select and .reject as filters already - we filter
either for what we want to keep, or for what we w...
02/26/2018
-
10:11 PM Misc #14470: Use Commit together with co-authors Github feature in svn commits
- +1 for this idea. I've got one pull request waiting to be merged and I'd love to be listed as a real contributor to ruby.
-
- I tried `--with-setjmp-type=setjmp` and the build passed. But I have no idea what is the performance impact.
Nevertheless, there are two more comments from GCC people. The first is [1]:
> Jeff Law 2018-02-26 17:01:13 CET
> ...
Ba... -
- It sounds good to fix by `--with-setjmp-type`, if it works.
-
- tl;dr:
* `rb_ec_tag_jump()` causes SEGV on aarch64 when it is built with `-fomit-frame-pointer` optimization that is the default of `-O1` of gcc-8.0.1-0.13.
* It is confirmed that `-fno-omit-frame-pointer` optflags can avoid the is... -
- > /usr/local/Cellar/ruby/2.5.0_2/lib/ruby/2.5.0/rdoc/markup/to_html.rb:389: [BUG] Segmentation fault at 0x0000000000000020
I am not completely sure but I think I saw this error before. Can't recall where; probably another issue report... -
06:09 PM Bug #14554 (Closed): gem update crashes
- upon running:
$ gem update
I receive a crash. Logfile plus CLI output is attached. -
06:26 PM Bug #13882: Exception in `ensure` stops threads from exiting
- ko1 (Koichi Sasada) wrote:
> Sorry for long absent.
> ...
No problem! The problem with Ctrl-C is that will fix it for user facing scripts, but not background processes. The example we ran into with this, was using Puma with forked chil... -
- Obviously it's Bootsnap's issue. Bootsnap doesn't work with Ruby 2.6.0. No JIT-related logs are found in your logs too. Please remove bootsnap from your Gemfile first.
-
05:40 PM Bug #14553 (Closed): Maybe this is too early for this but i encountered issues when using jit with rails
- ```
50 ruby 0x000000010c6a9b71 rb_load_internal0 + 337
51 ruby 0x000000010c6aaa1f rb_f_load + 159
52 ruby 0x000000010c7d43a8 vm_call_cfunc... -
04:57 PM Feature #14546: Hash#delete!
- As Matz clearly stated, even if a long time ago, bang is not strictly for mutating versions of methods. Note that there is `Process#exit!` (which is not a mutating version of `Process#exit`). Rails also has many bang methods which aren't...
-
- I could not `make` trunk (62585) without this patch.
```
$ make -j4 && make install
BASERUBY = /home/pocke/.rbenv/shims/ruby --disable=gems
CC = gcc
LD = ld
LDSHARED = gcc -shared
CFLAGS = -O3 -gg... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62589 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62588 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:39 PM Feature #14551: What's missing to switch to Git instead of using Subversion?
- Eregon (Benoit Daloze) wrote:
> Some people might be willing to help once it's clear what needs to be done.
If it is an extra pair of hands you are looking for I can volunteer.
A clean git development environment is something I'm ... -
- naruse (Yui NARUSE) wrote:
> You need to read previous discussion in detail.
> ...
What's the point?
That we need a planner showing the merits and listing issues?
The title of #10547 sounds like that issue should be about listing i... -
- Duplicated with #10547
> 1) I have heard some scripts might stop working if we switch to Git and nobody knows a list of those scripts.
You can find some of those scripts in tool/ of ruby's repo.
> ...
* External people can contr... -
- I have a plan to migrate git from subversion. But I have no enough time to figure out it.
Because I need to update the infrastructure of distribution and mailing-list in this year.
-
12:32 PM Bug #14542: syswrite spuriously empties the given string
- It seems so far that it is indeed a multithreading problem on my side, possibly specific to the test suite. My apologies for the noise, and thanks a lot to Eric for his help.
I don't find a way to close this ... -
-
- https://github.com/ruby/csv/pull/4 was already merged.
-
-
- 08:43 AM Revision cc47d873 (git): * 2018-02-26
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@62587 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Merge ruby/spec@fd56cd4
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@62586 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * Makefile.in (mjit_config.h): Alternative value with $@ and
printf without argument are not portable, could fail on some
platforms.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62585 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62584 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62583 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 07:57 AM Revision 2234edf0 (git): Use RB_INTEGER_TYPE_P instead of rb_obj_is_kind_of
- For checking whether an object is an Integer, because a subclass of
Integer is meaningless in Ruby, RB_INTEGER_TYPE_P is better than
rb_obj_is_kind_of for speed.
* object.c (rb_to_integer): Use RB_INTEGER_TYPE_P instead of rb_obj_is_kin... -
- ruby_2_5 r62568 merged revision(s) 62071.
-
- Applied in changeset trunk|r62581.
----------
Check the result of to_int in Kernel#Integer
[ruby-core:85813] [Bug #14552]
* object.c (rb_convert_to_integer):
Check the result of to_int in Kernel#Integer
* test/ruby/test_integer.rb:... -
- I found a bug that Kernel#Integer returns any non-nil object which is a result of to_int.
```ruby
obj = Object.new
def obj.to_int
"str"
end
Integer(obj) #=> "str"
``` - 07:31 AM Revision cc4be225 (git): Check the result of to_int in Kernel#Integer
- [ruby-core:85813] [Bug #14552]
* object.c (rb_convert_to_integer):
Check the result of to_int in Kernel#Integer
* test/ruby/test_integer.rb: add tests.
* spec/ruby/core/kernel/Integer_spec.rb: fix examples.
git-svn-id: svn+ssh://ci... - 06:00 AM Revision 6549f20e (git): * 2018-02-26
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62580 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * tool/make-snapshot (package): export ChangLog file under the
exported directory. Git can work only under a git repository.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62579 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62578 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * tool/vcs.rb (VCS::GIT#export): do not remove .git directory.
should remove it by after_export.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62577 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Merged at https://github.com/ruby/csv/commit/75127b4ad00a748762effe9add3f91edeb0dc94f
It will merge ruby core repository until Ruby 2.6 releasing. -
- avit (Andrew Vit) wrote:
> If adding keyword options, would it make sense to add the possibility to enumerate by `>>` for whole months instead of only `succ` days, or is that out of scope here?
Please write a separate feature describ...
02/25/2018
-
07:51 PM Feature #14550: Support keyword arguments with Date#step
- If adding keyword options, would it make sense to add the possibility to enumerate by `>>` for whole months instead of only `succ` days, or is that out of scope here?
-
08:37 AM Feature #14550: Support keyword arguments with Date#step
- Thank you for reviewing.
I updated the documentation for Date#step also. (date-step-2.patch) -
- > I know this feature request already reject but still posting in
> ...
I think it was said that the net benefit may have been too small
at that moment in time, but if I remember correctly, it was also
said that this can be re-evaluat... -
- For point #1, perhaps the issue here could collect all files that
would need modification (or a new file that handles git; though
ideally, the existing files could be adapted to use both svn
and git, so that if it is ever decided to c... -
- I know migrating to Git get asked at least every year at RubyKaigi, and this should be a motivation to change.
#14470 is one example making me wonder why we still use such an ancient technology like Subversion.
To be clear, this does... -
- Applied in changeset trunk|r62575.
----------
Add a new #filter alias for #select
* In Enumerable, Enumerator::Lazy, Array, Hash and Set
[Feature #13784] [ruby-core:82285]
* Share specs for the various #select#select! methods and
r... - 01:52 PM Revision a60a1c03 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62576 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * In Enumerable, Enumerator::Lazy, Array, Hash and Set
[Feature #13784] [ruby-core:82285]
* Share specs for the various #select#select! methods and
reuse them for #filter/#filter!.
* Add corresponding filter tests for select tests.
*... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62574 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- If you don't want to add extra spaces with indent, use `transitive: true` option:
```ruby
require 'rexml/document'
xml_string = ''
REXML::Document.new(xml_string).tap do |doc|
doc.add_element('root').tap do |root|
write... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62573 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- 後方互換性がなくなってしまうのでどうするかなぁと考えてみたんですが、もともと重複していた場合はなにを返すかわからない、という仕様だったので変わっても大丈夫かなぁと言う気持ちになったので、同じになるようにしました。
-
- Applied in changeset trunk|r62572.
----------
date_core.c: defensive code
* ext/date/date_core.c (f_cmp): check comparison failure.
* ext/date/date_core.c (d_lite_step): deal with the comparison
result more defensively. [ruby-core:... -
- * ext/date/date_core.c (f_cmp): check comparison failure.
* ext/date/date_core.c (d_lite_step): deal with the comparison
result more defensively. [ruby-core:85796] [Bug #14549]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62572... -
- I have recently read something which may be incorrect; but perhaps it may
be correct too, I do not know. The comment I read was sort of meant as a
joke perhaps ... or it was a first april joke. But it's not quite first
april so I shou... -
- > I see back-ticks are used improperly all the time.
> ...
I am not sure if this is a good approach. What if someone really
just prefers the shorter `` rather than system()? I mean, it is not
a problem for me since I use `` only in co... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62571 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- `rb_str_append` may trigger GC, and in that case eargp might be GCed.
Probably for protecting it, `RB_GC_GUARD(execarg_obj)` can be seen in
other places.
Hoping to fix:
http://ci.rvm.jp/results/trunk_gcc5@silicon-docker/569818
git-svn-... - 12:36 AM Revision b043343c (git): * 2018-02-25
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@62569 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- defined? returns nil for toplevel constant lookup
* variable.c (rb_const_defined_0): toplevel constant lookup has
been removed, should return nil too.
[ruby-core:85142] [Bug #14407] [Fix GH-1800]
Fro...
02/24/2018
-
- Seems ok.
For others, here is a quick link to the documentation for Date
in current ruby 2.5.0:
http://ruby-doc.org/stdlib-2.5.0/libdoc/date/rdoc/Date.html#method-i-step -
- How about supporting keyword arguments with Date#step like Numeric#step?
~~~
from = Date.new(2018, 1, 1)
to = Date.new(2018, 2, 1)
from.step(to: to, by: 3).to_a
~~~
I expected that this is already supported.
But not. - 03:36 PM Revision 591baf8f (git): rb_int_powm: call rb_int_pow directly
- * bignum.c (rb_int_powm): call rb_int_pow directly instead of calling `**`
operator.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62567 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 03:06 PM Revision da9300dc (git): * 2018-02-25
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62566 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:06 PM Revision c225d3c9 (git): complex.c, rational.c: remove dead code
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62565 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 02:56 PM Revision daa67ca3 (git): rational.c: simplify a branch condition
- * rational.c (nurat_s_convert): simplify a branch condition.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62564 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I agree with the direction. After resolving the slowness on Rails, we might be able to tune the default for discourse benchmark or something, to improve the boot time.
-
- One simple way that might help here is to make the default for --jit-min-calls much higher.
Compiling after only 5 calls by default seems very early.
Figuring out a better compilation threshold or heuristic would compile much less duri... -
- > A big question though is if the binaries can have some sort of manifest that allows you to run a pre-processor and do a simple string replace?
This might resolve performance decrease in indirection. But the optimized code relies on ... -
- ~~~ruby
require 'date'
o = Object.new
def o.<=>(*)
2
end
Date.new(2000, 1, 1).step(3, o) { }
#=> abort
~~~
I think, It's not intentional behavior.
And it should raise `TypeError` or `ArgumentError`, maybe. -
- > as I understand ! does not mean destructive, but rather
> ...
You may still have the issue of semantics.
For example, .fetch() semantic is different than .delete().
The way how I remember methods with a "!", even if this is
not... -
04:42 AM Feature #14546: Hash#delete!
- nobu (Nobuyoshi Nakada) wrote:
> `Hash#delete` is destructive, so appending `!` doesn't seem making sense.
I'm as guilty of it as anyone, but as I understand [`!` does not mean destructive](https://www.ruby-forum.com/topic/176830#773... -
- `Hash#delete` is destructive, so appending `!` doesn't seem making sense.
Rather, a destructive version of `Hash#fetch` feels better. -
08:54 AM Revision 8b9a3eab (git): lib/erb.rb: Add uplevel to warn
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62563 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- ruby_2_5 r62562 merged revision(s) 62555.
-
- Applied in changeset trunk|r62555.
----------
rational.c: segfault on Rational exponent
* rational.c (read_num): fix segfault on Rational() with positive
but less than the length of fractional part exponent. should be
negated to c... -
- rational.c: segfault on Rational exponent
* rational.c (read_num): fix segfault on Rational() with positive
but less than the length of fractional part exponent. should be
negated to convert to divisor which... -
- ruby_2_5 r62561 merged revision(s) 62513.
-
- Update url with 404 status on LEGAL file.
* Update redirected and upstream url.
* Added the Wayback Machine url for missing link.
[Bug #12762][ruby-dev:49802]
From: SHIBATA Hiroshi <hsbt@ruby-lang... -
- On cross compilation, ruby command uses fake RUBY_VERSION.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62560 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62559 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62558 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62557 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * rational.c (read_num): exp(0) is 1, no need to multiply.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62556 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- It was introduced at [r52422] once, but removed soon at [r52430] by a matz's objection.
[r52422]: https://github.com/ruby/ruby/commit/dbf73f6fc2a4b0414110eea64a9f98d33c2cf930
[r52430]: https://github.com/ruby/ruby/commit/a3ee54f8a653... -
- The ticked is closed already, and now set "Backport" to "2.5: REQUIRED".
"Backport REQUIRED" in "Closed" ticket is the mark for backporting. -
02:13 AM Bug #14500: Missing Regexp documentation and clarification on behavior of \K for edge case
- oh, I didn't check with `$10`. I'd tried with backreference. Any idea how to use `\10`?
```
$ echo 'abcdefghij' | ruby -pe 'sub(/(.)(.)(.)(.)(.)(.)(.)(.)(.)(.)/, ":\\9:")'
:i:
$ echo 'abcdefghij' | ruby -pe 'sub(/(.)(.)(.)(.)(.)(.)... -
- Sundeep (Sundeep Agarwal) wrote:
> * suggestion to add that numbered capturing groups is limited to `9`
I don't think so.
Why did you think so?
```
irb -r irb/completion --simple-prompt
> ...
=> 0
>> $10
=> "a"
``` -
- * rational.c (read_num): fix segfault on Rational() with positive
but less than the length of fractional part exponent. should be
negated to convert to divisor which is a reciprocal.
[ruby-core:85783] [Bug #14547]
git-svn-id: svn... -
- * array.c (rb_ary_sample): Adds examples for the use of the
optional parameter random for Array#sample and unifies the style
with the documentation of Array#shuffle.
[Fix GH-1825]
From: Alberto Almagro <alberto.almagro@rakuten.com>... -
- This information is backported from the draft of 2.6.0-preview1 release
note. NEWS for final 2.6.0 release will be different.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62552 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Typo in a comment about "evaluator body".
[Fix GH-1824]
From: hkdnet <satoko.itse@gmail.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62551 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 12:40 AM Revision f6445718 (git): * 2018-02-24
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62550 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62549 b2dd03c8-39d4-4d8f-98ff-823fe69b080e