Activity
From 01/18/2018 to 01/24/2018
01/24/2018
-
11:30 PM Feature #14399 (Open): Add Enumerable#product
- For similar reasons for creating `Enumerable#sum` a companion method
`Enumerable#product` is also very useful. Taking the product of
numbers in arrays is a common operation in many numerical algorithms,
especially in number theory and... -
11:17 PM Revision 3010d5ee (git): optparse.rb: literal newline
- * lib/optparse.rb (OptionParser#summarize): use literal newline to
join option summaries as IO#puts does, not the special gloval
variable $/.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62032 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
10:41 PM Feature #14394: Class.descendants
- Thanks for the reply, shevegen, those are helpful questions :)
The gems I've seen implement this are active-support and dry-rb, with other people checking ObjectSpace to get the list (which can be very slow for large apps).
The mos... -
09:01 PM Feature #14394: Class.descendants
- I do not know if it was suggested before, but it could be discussed
at the ruby developer meeting perhaps (unless it was already rejected).
I think it may be symmetrical to .ancestors too.
To complete your suggestion, could you de... -
- There have been numerous implementations of the method Class.descendants by various gems. However, I can't help but think that this ability should be included in the Ruby language itself. Especially since Ruby already offers the counterp...
-
10:41 PM Bug #14398 (Closed): [BUG] Bus Error
- Hi Folks, not sure it this is appropriate place to send my bug.
I noticed this error when I tried to apply Puppet manifest https://github.com/kmonticolo/OpenBSD-owncloud-puppet/blob/master/site.pp on OpenBSD 6.2 machine using # puppet a... - 10:40 PM Revision 69d6e7d9 (git): vm.c: remove unnecessary branch
- th->altstack is never NULL, and even if it were, POSIX
stipulates free(3) on NULL to be a no-op.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62031 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 10:39 PM Revision 7c8b7975 (git): load.c: use fstring instead of OBJ_FREEZE
- These strings already exist (or will exist soon) in the fstring
table, so avoid the duplicate, sooner.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62030 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
09:41 PM Feature #14392: Pipe operator
- shevegen (Robert A. Heiler) wrote:
> No |> though.
Hi Robert, many thanks for the extensive comment.
The idea of using `"|>"` as the proposed pipe operator came from my analysis of https://bugs.ruby-lang.org/issues/13581 issue c... -
- > It will be reject anyways but I will still continue to seek
> ...
Who knows - but I think it may be too difficult to change it at
this point.
When it comes to personal preferences, what may work for you may
not work for others.
... -
- zverok (Victor Shepelev) wrote:
> That's the way, obviously.
Fortunately not every one look at things the same way, and I believe ruby core allows us to come in and discuss matters.
This is an important matter to me.
I know not m... -
- zverok (Victor Shepelev) wrote:
> It already looks messed up :)
Didn't understand very well how messed up it is.
Is that syntax impossible to implement or messed up just because the way ruby people tend to look at code syntax?
... -
03:16 PM Feature #14392: Pipe operator
- >> `private def bar(var)`
> ...
So, what you saying is "I don't like how the consistent set of features in language looks [it can't even be said to be "verbose", man!], so please introduce a new inconsistent feature for me to like it"... -
- Let me, then, introduce some philosphy here (I know this issue will be rejected anyways, so whatever).
When you propose new language feature, it is often useful to think a bit of it: how it plays with other features and general langua... -
- Hanmac (Hans Mackowiak) wrote:
> `private def bar(var)`
I don't like the syntax it provides.
What I do currently is:
```ruby
class Foo
def bar(var)
puts “Hello #{var}!”
end
private :bar
def baz(arg)
... -
- zverok (Victor Shepelev) wrote:
> We already have yield_self (2.5+) exactly for this.
I will not use it like that.
Not for the situations I presented.
To ugly and verbose. -
02:47 PM Feature #14392: Pipe operator
~~~ ruby
class Foo
private def bar(var)
puts “Hello #{var}!”
end
def baz(arg)
bar(arg)
end
end
~~~
method def already return their method name, so they can be used with private/protected
-
- We already have `yield_self` (2.5+) exactly for this.
```ruby
class Foo
##
# Bar public method.
def bar(*args)
args.select do { |arg| arg =~ /regex/ }.first
yield_self(&method(:good))
end.yield_self(&meth... -
- I would like to see implemented in ruby a pipe operator as we have in elixir.
An example of application I have in mind is this:
```ruby
class Foo
def bar(var)
puts “Hello #{var}!”
end |> private
def baz(arg)
... -
09:28 PM Feature #14396 (Rejected): public, protected and private should return their arguments instead of self
- 誤ってruby-devに投げてしまったのでこっちは閉じます。
[Feature #14397] を参照。 -
- Matsuda-san suggested me that `public`, `protected` and `private` should return their arguments instead of self,
to write such code:
```Ruby
require "finalist"
# see https://github.com/joker1007/finalist
class Foo
extend Fina... -
- Matsuda-san suggested me that `public`, `protected` and `private` should return their arguments instead of `self`,
to write such code:`
```Ruby
require "finalist"
# see https://github.com/joker1007/finalist
class Foo
extend F... -
09:13 PM Bug #14314: Marshalling broken in Ruby 2.5.0 for Structs with keyword_init: true
- The YAML issue has also been fixed on trunk.
-
09:07 PM Misc #14381 (Closed): [PATCH] ruby/ruby.h: remove unnecessary exports from C-API - Applied in changeset trunk|r62029.
----------
ruby/ruby.h: remove unnecessary exports from C-API
Needlessly exporting can reduce performance locally and increase
binary size.
Increasing the footprint of our C-API larger is also detrim... - 09:07 PM Revision 7e669f40 (git): ruby/ruby.h: remove unnecessary exports from C-API
- Needlessly exporting can reduce performance locally and increase
binary size.
Increasing the footprint of our C-API larger is also detrimental
to our development as it encourages tighter coupling with our
internals; making it harder for... -
- Would be nice.
I must admit that I have not used drb in a really long time - but I
am a firm believer in ruby objects dwelling everywhere, and communicating
with them. :)
- 07:06 PM Feature #14393 (Open): Support sending file descriptors (on local machine) via DRb UNIX
- Ruby: `2.4.3p205 (2017-12-14 revision 61247) [x86_64-linux]`
Currently DRb supports UNIX domain sockets, via `drbunix://`
UNIX sockets can transmit file descriptors via `send_io()`/`recv_io()` methods. Unfortunately DRb via `drbuni... -
08:52 PM Misc #14395 (Closed): [PATCH] internal.h: add BITFIELD macro
- Pretty trivial, will commit soon.
internal.h: add BITFIELD macro
I plan to use this macro to pack other enums in the VM while
preserving portability to non-C99 compilers.
* internal.h: add BITFIELD macro
* method.h: use BITF... - 08:50 PM Revision 0a0b71f3 (git): * 2018-01-25
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62028 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 08:50 PM Revision a41386a2 (git): ruby.c (open_load_file): avoid shadowing variable for errno
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62027 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
05:49 PM Bug #14376: OpenSSL::X509::Store#verify_callback= requires Qtrue, not just truthy
- Please close in favor of #14377.
-
- Please close.
I need to learn to read docs. The fact that `Store#verify_callback=` is method (so listed in left pane) while `SSLContext#verify_callback=` is attribute (so NOT listed in left pane) completely got me. -
04:46 PM Feature #14235: Merge MJIT infrastructure with conservative JIT compiler
- k0kubun (Takashi Kokubun) wrote:
> Vladimir, thank you for your opinion on this!
> ...
You are welcome. You are doing a great job.
> > --jit-wait/--jit-threshold are very useful options for testers. They should be used to test JIT ... -
04:42 PM Feature #14235: Merge MJIT infrastructure with conservative JIT compiler
- > I also think that in the future setting JIT features and params through environment variable(s) might improve JIT usage experience too.
Ah, that's a topic that was discussed today too. I'm not going to have them at initial merge, bu... -
- larskanis (Lars Kanis) wrote:
> I like your last proposal most (using `--jit-X` options). It would also allow this in the future:
> ...
I think 16 is too aggressive. It is not only worker threads (many of them will be in a wait state ... -
- Vladimir, thank you for your opinion on this!
> --jit-wait/--jit-threshold are very useful options for testers. They should be used to test JIT on ruby tests (e.g. make check) because without them JIT practically has no time to compil... -
- k0kubun (Takashi Kokubun) wrote:
> > The short form should be there for convenience IMHO
> ...
They look ok to me. I believe people at the developers meeting have the best experience with designing options for C-Ruby. I created origi... -
04:05 PM Feature #14235: Merge MJIT infrastructure with conservative JIT compiler
- I like your last proposal most (using `--jit-X` options). It would also allow this in the future:
```
--jit [<threads>] use MJIT with the number of parallel workers (default: 16)
```
... or even the short form `-jX` .
-
- > having "-jX" instead of "-j:t=X" would be very reasonable interface.
I rethought that it's still aggressive to add it while we have --jit-xxx too. Never mind about that part. -
- > Vladimirs command line option -j:t=X sets the number of parallel running compile tasks, which is similar to what -j is typically used for.
Then using "-j" for non-parallel JIT-ing purpose may make it confusing. When JIT becomes stab... -
- Vladimirs command line [option -j:t=X](https://github.com/vnmakarov/ruby/blob/rtl_mjit_branch/ruby.c#L267) sets the number of parallel running compile tasks, which is similar to what `-j` is typically used for. And it is therefore an int...
-
- > The short form should be there for convenience IMHO
TBH I don't have strong preference on having the short versions or not. But I'm expecting that the only option normal user uses would be only "--jit" and others are basically for V... -
10:43 AM Feature #14235: Merge MJIT infrastructure with conservative JIT compiler
- Just my opinion: -j only makes sense in the context of a tool/script which can run in parallel (build tool like make, package manager like bundler, etc).
For Ruby, a programming language interpreter, I think -j as --jobs would be meanin... -
- Before we merge MJIT, we need to consider what CLI options ruby should have.
Current implementation with some modification that I'll add:
~~~
-j, --jit use MJIT with default options
-j:option, --jit:option
... -
- zverok (Victor Shepelev) wrote:
> map(&Math|>sqrt), each(&|>puts) (too confusable with Elixir-like pipe, probably)
I tend to agree with that.
In fact I was hoping to get the pipe operator introduced in ruby. (Created an issue wit... -
- Just to push this forward, here are all the syntaxes from this and duplicate #12125.
I am taking `Math.sqrt` and `puts` as examples:
* `map(&Math->sqrt)` (and just `each(&->puts)` probably?) -- Matz is explicitly against it;
* `map(... -
- NEWS: added an entry for `exception: true` option.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62026 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset r62025.
For rosenfeld's suggestion, open3 would be a good place to have the functionality. -
- I created a patch for exception: true. https://github.com/ruby/ruby/pull/1795
-
07:14 AM Feature #14386: Add option to let Kernel.#system raise error instead of returning false
- Agree with adding keyword argument to specify raising an exception (`exception:true` sounds reasonable).
Matz.
-
07:11 AM Feature #14386: Add option to let Kernel.#system raise error instead of returning false
- I don't like the keyword name, "assert_status".
I think "exception" is better.
It is consistent with read_nonblock, etc. -
- > I have nothing against it. I think it would change existing behaviour
though, if I read http://ruby-doc.org/core-2.5.0/Kernel.html#method-i-system
correctly
I don't get what you mean. Do you mean existing program may be passing :a... -
- to raise error when it fails.
[Feature 14386] [GH-1795]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62025 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:57 PM Bug #14391 (Closed): Integer#digitsが遅い
- Integer#digitsが遅い
大きなIntegerのdigitsがto_sと比べてかなり遅い(計算量のオーダーが違う)ようです。
~~~ ruby
(9999**9999).to_s.chars.map(&:to_i).reverse # 0.030225秒
(9999**9999).digits # 1.187126秒 (40倍)
(99999**99999).to_s.chars.map(&:to_i).reverse # 1.88821... -
12:30 PM Bug #14389: Reflected XSS
- shevegen (Robert A. Heiler) wrote:
> The twitter link above gives me "This account's Tweets are protected.", just
> ...
So what do I have to do? -
- The twitter link above gives me "This account's Tweets are protected.", just
for your information. -
- Hello,
Reflected Xss found ..
https://docs.ruby-lang.org/ja/search/query:import/query:callback/%22%3E%3C/title%3Ealert(XSS%20A%C3%A7%C4%B1%C4%9F%C4%B1)%3C/script%3E%3E%3Cmarquee%3E%3Ch1%3EXSSa%C3%A7%C4%B1%C4%9F%C4%B1%3C/h1%3E%3C/ma... -
- @shevegen I am well aware of the process, thanks. In my head, it also includes "ideas are discussed in this bug tracker, then they are added (or not) to next dev.meeting agenda." Do you have a suggestion of the shortcut way of adding it ...
-
- > Ugh, seems it duplicates answer-less #10879.
It can probably be referenced to the other report, and your issue
here closed (or the other one; I think it does not matter which
one).
Some issues are unanswered but this does not n... -
- Ugh, seems it duplicates answer-less #10879.
Though, I'd be happy to raise the priority of discussion higher, and to provide some real-life examples :) -
- I believe that it could be somewhat useful to have UnboundMethod converted to proc (accepting the object to bind to, as a first argument).
Practical(ish) example, paired with [Proc#rcurry](https://bugs.ruby-lang.org/issues/11161) prop... -
- Started to write my own ticket, but found this one :)
My explanation was like this:
---
Considering two widespread Ruby patterns:
* Last method arguments are frequently options/settings/clarifications of the call;
* `Method#to... -
- Rejected. It would cause too much confusion than convenience.
Matz.
-
08:39 AM Feature #14371: New option "recursive: true" for Hash#transform_keys!
- FYI, ActiveSupport implemented these functionalities as separate methods:
* [Hash#deep_transform_keys](http://api.rubyonrails.org/classes/Hash.html#method-i-deep_transform_keys)
* [Hash#deep_transform_keys!](http://api.rubyonrails.or... -
- I don't think this proposal is a good idea for following reasons:
* `transform_keys` method to modify value part of `Hash`
* `recursive` option to change the behavior this much
* it is much harder to implement `transform_keys(recurs... -
- 関連すると思われるささださんの昔のメールを見つけました: ruby-dev:31579
```
1) 右辺が重複しないローカル変数の列だったら今まで通り
（副作用はないので問題ない）
2) そうじゃなければ，色々コストをかけて順番通りに実行
ということにしたいと思います．多分，(1) がほとんどではないかと期待．
ネストした多重代入は (1) にはあてはまりませんが，まぁしょうがない．
``` -
- * lib/mkmf.rb (MakeMakefile#try_ldflags): enable warning checking
on mswin, link.exe warns -l options but does not fail.
[Bug #13069]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62024 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- We discussed this issue at today's developper meeting.
We (including matz) agree produce warnings for 5 variables ($; $, $/ $\ $.) when it is written in
ruby code except -e argument.
The warning is produced at compile time.
So th... -
08:14 AM Bug #14388 (Closed): 不正エンコーディング文字列から切り出した正当なエンコーディング文字列が invalid encoding になる
- ~~~ ruby
data = "\xFFaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"
p data.encoding #=> #<Encoding:UTF-8>
p data #=> "\xFFaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"
p data.valid_encoding? #=> false
data2 = da... -
08:11 AM Bug #14269: backport r61562, r61563, r61566, r61568, r61569 (fix SEGV touching uninitialized memory)
- ruby_2_5 r62023 merged revision(s) 61562,61563,61566,61568,61569.
-
- fix SEGV touching uninitialized memory
This function can be called from boot_defclass().
No assumption can be made about object internals.
(lldb) run
Process 2386 launched: './miniruby' (x86_64)
... -
08:02 AM Bug #14380 (Assigned): Expected transform_keys! to work just as transform_keys, but it doesn't
-
08:00 AM Bug #14246: Inconsistent C source code indentation
- We discussed this issue in today's developer meeting.
- We agreed _not_ to batch update the indents at once. Indents should become consistent over time.
- Matz has no strong opinion on this topic.
- We agreed to move to spaces only... -
08:00 AM Feature #12732: An option to pass to `Integer`, `Float`, to return `nil` instead of raise an exception
- Just for the record, `Integer(x, rescue: default_value)` might be an idea, if anything other than `nil` (like zero) would be desired.
-
- Aaron's comment in #note-6 sounds reasonable. Accepted.
Matz.
-
- Applied in changeset trunk|r62022.
----------
dir.c: Dir#each_child
* dir.c (dir_each_child_m): new instance methods Dir#each_child
and Dir#children. [Feature #13969] -
- Agreed.
Matz.
-
- * dir.c (dir_each_child_m): new instance methods Dir#each_child
and Dir#children. [Feature #13969]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62022 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62021 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- I agree with the original proposal. We are not going to enhance `raise` behavior (yet).
Matz.
-
- Applied in changeset trunk|r62020.
----------
vm_args.c: to_proc refinements
* vm_args.c (vm_to_proc): enable #to_proc by refinements at Proc
passing as a block. patched by osyo (manga osyo).
[Feature #14223] -
- 良さそうに思えます。取り込んでみましょう。
Matz.
-
- * vm_args.c (vm_to_proc): enable #to_proc by refinements at Proc
passing as a block. patched by osyo (manga osyo).
[Feature #14223]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62020 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
06:17 AM Feature #14382: Make public access of a private constant call const_missing
- matz (Yukihiro Matsumoto) wrote:
> The idea seems OK to me. Can you experiment?
With the attached patch, both test-all and test-spec pass.
The only time I can see this causing an issue is in a class/module that overrides `const_mi... -
- The idea seems OK to me. Can you experiment?
Matz.
-
- Well, I did say "serious" math, didn't I.
```
2.5.0 :097 > 2**256
=> 115792089237316195423570985008687907853269984665640564039457584007913129639936
2.5.0 :099 > n = 2**256 + 1; tm{ pp n.factors }
[[1238926361552897, ... -
- Rational and BigDecimal do not cover irrational numbers.
```ruby
require 'bigdecimal'
p (BigDecimal("2.0")**BigDecimal("0.5"))**BigDecimal("2.0")
#=> 0.19999999932878736e1
```
You'd need a mathematical solver, not a mere numeri... -
12:29 AM Bug #14387 (Closed): Ruby 2.5 を Alpine Linux で実行すると比較的浅めで SystemStackError 例外になる
- CircleCI で Alpine Linux を使って Ruby 2.5.0 で Rubocop を実行した時に遭遇した例外です(Ruby 2.4.3 では発生しませんでした)。
Ruby のバージョンによって、再帰が止められるまでの回数に大きな違いがあるのはなぜでしょうか？
これは、意図された挙動なのか、Ruby の変更によるものでは無く Alpine Linux 固有の問題なのか、教えていただく事は可能でしょうか？
Alpine Linux の Tr... -
12:12 AM Revision c786db20 (git): Fix a typo
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62019 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 12:03 AM Bug #14264 (Closed): RDoc comment of warn does not mention uplevel:
- Applied in changeset trunk|r62018.
----------
Add documentation for the Kernel#warn :uplevel keyword
[ruby-core:84574] [Bug #14264]
Author: Jeremy Evans <code@jeremyevans.net> -
12:03 AM Revision 49a23c27 (git): Add documentation for the Kernel#warn :uplevel keyword
- [ruby-core:84574] [Bug #14264]
Author: Jeremy Evans <code@jeremyevans.net>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62018 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
01/23/2018
-
- Unless I copy-pasted wrong your `prime_division2` is /significantly/ slower for small numbers:
```
$ ruby bm.rb
prime_division - current in prime.rb
prime_division_2 - proposed version in #14383 by jzakiya
`factor` - sp... -
- The major problem with `prime_division` trying to accommodate negative numbers is
that, mathematically, [prime factorization](https://en.wikipedia.org/wiki/Integer_factorization) is really only considered over positive integers > 1.
I... -
- Currently, `prime_division` can factorize any negative integers that are less than -1 like:
```
[2] pry(main)> -12.prime_division
=> [[-1, 1], [2, 2], [3, 1]]
```
Do you think how to treat these cases?
I think raising Math::D... -
- I won't go into all points since your issue makes even my issue
requests seem small. :-)
It may be easier to split your suggestions into separate issues
though.
For example, the 0 and -1 situation, if it is a bug (probably
is bu... -
- I have been running old code in Ruby 2.5.0 (released 2017.12.25) to check for
speed and compatibility. I still see the codebase in `prime.rb` hardly has
changed at all (except for replacing `Math.sqrt` with `Integer.sqrt`).
To achie... -
06:57 PM Feature #14386: Add option to let Kernel.#system raise error instead of returning false
- If an option would be used to make system raise instead of returning a boolean, then it would make more sense to return the combined err + out output instead of true or false. That could be quite useful and simpler to use than Open3's ca...
-
- If I understood it correctly, you mean to pass in an optional hash
to be the second argument to system() right?
I have nothing against it. I think it would change existing behaviour
though, if I read http://ruby-doc.org/core-2.5.0/... -
- I sometimes write code like:
~~~ ruby
system('git pull origin master') || raise('Failed to execute: git pull origin master')
system('bundle check || bundle install') || raise('Failed to execute: bundle check || bundle install')
~~~... -
- IMHO this is way too incompatible and using %x{} only makes it less nice/readable/intuitive.
What's wrong with the very convenient backtick notation ? -
- nobu@ruby-lang.org wrote:
> Matz's intention is to use back-ticks for a different syntax,
> not to deprecate the command substitution feature.
I think that is dangerous to have the meaning of any syntax element
become something el... -
- Hanmac (Hans Mackowiak) wrote:
> is there already any info for what this syntax (`) might be used for?
I haven't heard it. -
- nobu (Nobuyoshi Nakada) wrote:
> `%x{}` will not change.
> ...
i am okay with that, imo %x is most cases still not the right for me
is there already any info for what this syntax (`) might be used for? -
- `%x{}` will not change.
Matz's intention is to use back-ticks for a different syntax, not to deprecate the command substitution feature. -
- would that affect `%x{}` too or whould that be done later?
i mean in most cases they might not what i want and need to use exec or popen -
- Thank you for the early notice - there are now lots of entries for the developer meeting
compared to a few days ago. Looking forward to the (more important) results of the
meeting. :)
I agree with the summary. It would be nice if w... -
11:03 AM Feature #14385 (Rejected): Deprecate back-tick for Ruby 3.
- From https://bugs.ruby-lang.org/projects/ruby/wiki/DevelopersMeeting20171212Japan#From-attendees
Matz hopes to deprecate backtick syntax(``) for Ruby 3. We should warn about it at Ruby 2.6 (or 2.7?)
We need to consider them.
* w... -
05:42 PM Feature #14362: use BigDecimal instead of Float by default
- nobu (Nobuyoshi Nakada) wrote:
> You can write "exact" number by `1.2r`.
Rational numbers work fine for `+`, `-`, `*` and `/` but once you encounter an irrational number, you'll have numerical errors again: ¯\\_(ツ)_/¯
```ruby
(2.... -
- hsbt@ruby-lang.org wrote:
> We discussed your proposal at last developer meeting (Dec 26, 2017)
Awesome news.
> - Name this "Thread", or something Thread-ish word than Fiber-ish
So if we just use "Thread", then existing Thread... -
- Hi, Eric.
We discussed your proposal at last developer meeting (Dec 26, 2017)
- Name this "Thread", or something Thread-ish word than Fiber-ish
- Matz doesn't have a strong opinion on the name but prefers 2 words (auto-fiber) than... -
- It still doesn't make sense for me since it's only possible to add instance variables starting with @ when using the public exposed API, so it seems completely unnecessary to require the @ when using the public API, regardless of how the...
-
- jeremyevans0 (Jeremy Evans) wrote:
> You can actually store instance variables that don't start with @ using the C-API
Thanks for the clarification. That makes perfect sense.
I suspected there would be some good explanation for th... -
- dsferreira (Daniel Ferreira) wrote:
> I believe it would be great to have:
> ...
The reason this doesn't work is by design. You can actually store instance variables that don't start with @ using the C-API (rb_ivar_set), these are hid... -
- nobu (Nobuyoshi Nakada) wrote:
> Do you want to access constants without the first upper case letter by const_get?
Would you like me to open an issue to discuss it? This String vs Symbol discussion is already to problematic in natu... -
- `@` is a part of instance variable names.
Do you want to access constants without the first upper case letter by `const_get`?
```ruby
class X
Constant = 1
end
X.const_get(:onstant) #=> 1
``` -
- nobu (Nobuyoshi Nakada) wrote:
> Instance variables must start with @ in ruby.
> ...
What I meant was what Rodrigo stated. (Thanks Rodrigo).
But that was just a side note. Maybe I'll open an issue to discuss that some day.
I bel... -
- nobu (Nobuyoshi Nakada) wrote:
> Why and how do you think it will break that code?
Sorry Nobu. Now I can see it maps to the first example of the description. I misread it. So it will not break Hans example.
Not sure what will bre... -
- > I ALREADY did! data for color gradient (see above). Just theating that my example doesn't exist to prof your point.
I was talking specifically about dealing with common cases, not exceptions. I told you that you'll find hashes using... -
- > Instance variables must start with @ in ruby.
I believe that was exactly the point of Daniel. Since it must start with @, why having to include the @ while declaring the instance variable? Why not just the variable name? I also neve... -
- dsferreira (Daniel Ferreira) wrote:
> Are you aware of the new keyword feature that will break that code?
> ...
Why and how do you think it will break that code?
dsferreira (Daniel Ferreira) wrote:
> Note: I don't understand why we... -
- wouldn't this be beautiful:
```ruby
%w/height width tileheight tilewith/.each do |dimension|
instance_variable_set("@#{dimension}".to_sym, node[dimension])
end
```
Now imagine this:
```ruby
%w/height width tileheight til... -
- Hanmac (Hans Mackowiak) wrote:
> and old (pre keyword) example how to make it work
I don't know what to think about that.
Isn't the all point of the discussion to find a solution that could allow us to handle those situations wit... -
- dsferreira (Daniel Ferreira) wrote:
> Hans, now I completely missed your point.
> ...
and old (pre keyword) example how to make it work for all three user input (keys or strings), hash data from json or nodes from xml
i did some o... -
- Hans, now I completely missed your point.
What does this prove?
```ruby
@height = (node[:height] || node["height"]).to_i
@width = (node[:width] || node["width"]).to_i
@tileheight = (node[:tileheight] || node["tileheight"]).to_i
... -
- some older code of mine where i needed to handle both user input and input from xml or json
https://github.com/Hanmac/tmx-ruby/blob/master/lib/tiled_tmx/map.rb#L29-L34
that was before ruby got keyarguments
i know how to handle both
... -
- It's not about what I think makes sense. I can provide you tons of code where people are using HWIA because it's a real problem Rubyists face every day some place around the globe. It's not hard to find too many examples on strings and s...
-
- rosenfeld (Rodrigo Rosenfeld Rosas) wrote:
> > why are you guys not have a problem with that h[0] != h[0.0] ?
> ...
what if you have hash data for a color gradient?
then you have `{ 0 => 'start color', 0.5 => 'step color', 1.0 => 'end... -
- > why are you guys not have a problem with that h[0] != h[0.0] ?
Aren't you exaggerating? When did you ever need to use a non integer number as a hash key? I never did and I never saw a single code base using non integer numeric value... -
- rosenfeld (Rodrigo Rosenfeld Rosas) wrote:
> I give up on this discussion until someone brings a new perspective into it.
Rodrigo I'm working in a concrete proposal.
Matz statement that _"symbol is the fundamental part of the lan... -
- rosenfeld (Rodrigo Rosenfeld Rosas) wrote:
> I give up on this discussion since I'm very low on free time these days and it's clear to me that I'm talking to the wind here, since most people discussing here seems to believe that "h[:a] ... -
- I give up on this discussion since I'm very low on free time these days and it's clear to me that I'm talking to the wind here, since most people discussing here seems to believe that "h[:a] != h['a']" is a non issue and that it's always...
-
- rosenfeld (Rodrigo Rosenfeld Rosas) wrote:
> > it means that the developer doesn't think about his own application enough to know if something would be a String or Symbol, or uses user input without checking which is even worse
> ...
i... -
- > it means that the developer doesn't think about his own application enough to know if something would be a String or Symbol, or uses user input without checking which is even worse
It has nothing to do with the developer but with th... -
- rosenfeld (Rodrigo Rosenfeld Rosas) wrote:
> But even if you had, that wouldn't completely fix the issue, because part of the application might use strings as keys while another part of the application might use symbols.
thats its... -
- The message does not come from `rb_w32_strerror` but `gai_strerror` in WinSock2 library.
-
- Applied in changeset trunk|r62017.
----------
init.c: encode socket error message
* ext/socket/init.c (rsock_raise_socket_error): on Windows, encode
error messages from wide characters to the default encodings.
[ruby-core:84972] [B... -
02:50 AM Bug #14384 (Closed): CompatibilityError is thrown when formatting a non-ASCII string with a binary string argument
- The following script:
~~~
# coding: utf-8
require 'socket'
begin
TCPSocket.open('nowhere', 80)
rescue => e
puts "証明書をリクエストできませんでした: %s" % e.message
end
~~~
Produces an error on Windows instead of printing message:
~~... -
- * ext/socket/init.c (rsock_raise_socket_error): on Windows, encode
error messages from wide characters to the default encodings.
[ruby-core:84972] [Bug #14384]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62017 b2dd03c8-39d4-4d... - 03:31 PM Revision d6aa4916 (git): * 2018-01-24
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62016 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * ext/socket/getaddrinfo.c (ai_errlist): used only if gai_strerror
is missing.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62015 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62014 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- yimutang (Joey Zhou) wrote:
> For example, I want to mix two *groups* of files, not two files:
`FileGroup` ? -
- Just noticed it for the upcoming developer meeting. I agree with the
functionality; not sure if `FileArray` is a good name, but I also can
not suggest a better name. (The functionality is fine in my opinion) -
08:09 AM Feature #4831: Integer#prime_factors
- I am not against adding such an alias but I'd like to think with more inputs. At this moment, I don't have strong reason to justify the name.
From a certain perspective, the alias is simply wrong because the method returns not only pr... -
07:23 AM Bug #8402: Segfault when precompiling rails assets
- I has the same trouble with Ruby 2.2.8 and Rails 4.2.10.
After cleanup project's cache directory it working fine. -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62013 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62012 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * parse.y (heredoc_dedent): concat literal strings after dedented.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62011 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 02:23 AM Revision c16c30ac (git): * 2018-01-23
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62010 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62009 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:52 AM Feature #14370: Directly mark instruction operands and avoid mark_ary usage on rb_iseq_constant_body
- I've been doing more investigation about performance of this patch. Using the same Rails application I used for the initial graphs, I walked the heap for all instruction sequences and output the size of `iseq_encoded` along with the num...
01/22/2018
-
- Thanks, Matz, it certainly helps, but there are plenty of cases where we are not in the control of how hashes are serialized/deserialized. For example, when using Redis, the interface accepts a hash and it will serialize behind the scene...
-
- Eregon (Benoit Daloze) wrote:
> Isn't Module#deprecate_constant specifically for this usage?
`Module#deprecate_constant` deprecates all usage of the constant, both public and private. If you want to keep a constant but change the vi... -
- Isn't Module#deprecate_constant specifically for this usage?
-
- Calling `obj.foo` where `foo` is a private method of `obj` calls `method_missing`. You would expect `klass::FOO` where `FOO` is a private constant of `klass` to call `const_missing`, but currently it doesn't. This makes a small change s...
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62008 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Could you let us know where those functions are used?
It's better to get rid of them, I think. -
- Applied in changeset trunk|r62007.
----------
mkmf.rb: ignore linker warnings
* lib/mkmf.rb (try_ldflags): ignore linker warnings. they cause
unexpected failures on OpenBSD. [ruby-core:78827] [Bug #13069] -
10:24 AM Bug #13069: mkmf: ignore linker warnings on OpenBSD
- The issue is affecting my gem, [cld3-ruby](https://github.com/akihikodaki/cld3-ruby).
[Build failure on OpenBSD · Issue #16 · akihikodaki/cld3-ruby](https://github.com/akihikodaki/cld3-ruby/issues/16)
> Those warnings are always emit... -
- * lib/mkmf.rb (try_ldflags): ignore linker warnings. they cause
unexpected failures on OpenBSD. [ruby-core:78827] [Bug #13069]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62007 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- phluid61 (Matthew Kerwin) wrote:
> IIRC this was discussed when the feature was originally proposed.
Here you are. https://bugs.ruby-lang.org/issues/13583 - 03:04 AM Revision 218b8324 (git): time.c (num_exact): use predefined IDs
- No need to waste space on "to_r" and "to_int" which are
predefined in defs/id.def
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62006 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 12:40 AM Revision 8a6c76b5 (git): time.c: constify compat_* tables
- compat_common_month_table and compat_leap_month_table should
not be writable.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62005 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:27 AM Feature #7019 (Rejected): allow `private` and `protected` keywords to take blocks
- #3753 adds `private def ...` support. If you still want this feature, please reopen this issue.
-
- #3753 で`private def ...`と書けるようになって必要なくなったので閉じます。
01/21/2018
-
11:24 PM Bug #14380: Expected transform_keys! to work just as transform_keys, but it doesn't
- taw (Tomasz Wegrzanowski) wrote:
> Oops, I meant to suggest this, accidentally said "values" instead of "keys" :
> ...
IIRC this was discussed when the feature was originally proposed. What happens to a `break` inside the block? -
10:24 PM Bug #14380: Expected transform_keys! to work just as transform_keys, but it doesn't
- Oops, I meant to suggest this, accidentally said "values" instead of "keys" :
class Hash
def transform_keys!(&block)
replace transform_keys(&block)
end
end
-
- Thanks for the report, I'll take a look.
This spec looks rather hacky at first sight. - 03:26 PM Revision 96240fa4 (git): * 2018-01-22
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62004 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62003 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62002 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Ack. Like I said I have no strong opinion on this.
-
01:21 PM Bug #14349: Fix Net::HTTP documentation around connection reuse
- Makes sense, I've attached a patch that fixes the documentation (generated from https://github.com/ruby/ruby/pull/1794).
-
- * defs/keywords (struct kwtable): shrink since members do not
exceed 16bit. lex_state needs to be int (or enum lex_state_e)
when EXPR_MAX_STATE reaches it.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62001 b2dd03c8-39d4-4d8f-... -
- * parse.y (parser_yylex): as well as `tLBRACE_ARG` (expr block),
`tLBRACE` (primary block) also does not accept a label. only
hash brace accepts a label.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62000 b2dd03c8-39d4-4d8f-98... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61999 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61998 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61997 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
06:51 AM Feature #14378: Increase Fixnum range on Windows from 31 bits to 63 bits
- a mere data point:
(cygwin-64 ruby includes the full 64-bit Fixnum)
```
>> RUBY_VERSION
=> "2.2.5"
> ...
=> "x86_64 Cygwin\n"
>> (1<<61).class
=> Fixnum
> ...
=> Bignum
``` -
- sxysxygm@gmail.com wrote:
>
> what I only want to say is 'why didn't use typedef?...'
In the 1980s, when the 'int' type was fluctuating between 16 bits and
32 bits, we learned to _NEVER_ trust naked C types.
This defensive tact... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61996 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
01/20/2018
-
- Note this depends on r61995, will wait a few days for review
(ENOSPC on my end to run gem-codesearch)
```
Needlessly exporting can reduce performance locally and increase
binary size.
Increasing the footprint of our C-API larger... - 10:07 PM Revision 903b6628 (git): load.c: use rb_warning directly
- This removes the last dependency on rb_mWarning outside of
error.c and allows future commits to mark it static.
Yes, I expect this to slow down the emitting of a warning
message in a cold code path slightly :P
git-svn-id: svn+ssh://ci.... -
- Here is the current documentation:
http://ruby-doc.org/core-2.5.0/Hash.html#method-i-transform_keys
After looking at the example you gave, I can not say whether this is
deliberate or not - but either way, I think IF the behaviour ... -
- This seriously violates the Principle of Least Surprise to me:
{1 => :a, -1 => :b}.transform_keys{|k| -k} #=> {-1=>:a, 1=>:b}
{1 => :a, -1 => :b}.transform_keys!{|k| -k} # => {1=>:a}
# This fails:
ht=(1..10).map{|... -
05:52 PM Revision 8a489a7d (git): ext/ripper/tools/dsl.rb: Use String#sub instead of delete_suffix
- It fails when baseruby is old.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61994 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61993 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61992 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- To avoid the unspecified behavior (the evaluation order of arguments).
In `$$ = foo(bar(), baz());`, it is unspecified which `bar` or `baz` is
called earlier.
This commit changes the code to `v1=bar(); v2=baz(); $$ = foo();`.
git-svn-i... -
04:50 PM Bug #14379: Exit code 3 when running the sass compiler
- Oh, never thought about Onedrive, thank you!
Also, I apologize for the source file name, I forgot to change it, it slipped ||._. -
- Seems #14047.
-
- Edit: It shouldn't be a SASS error, as my colleague is working with the same Ruby release, SASS release, and SCSS source file
-
- Hi,
I was told by my IDE (JetBrains' WebStorm) support center to upload here a report about
a problem I'm encountering on windows 10 64bit, when launching the SASS compiler.
I installed Ruby 2.4.3-1 (x64), using the Installer.
I've... -
04:34 PM Bug #13496: Patches for MinGW builds - gnu_printf in 'config' & defines.h
- Since I've been building trunk, the gnu_printf patch has moved from
Configure.in -> Configure.ac -> tool/m4/ruby_check_printf_prefix.m4
Given that both ruby-loco and RubyInstaller2 use a patch for this, it would certainly be helpfu... -
- Currently, parser.y includes core parser and Ripper parser obscurity.
In addition, *some* Ripper code uses the result of the core parser,
which make it difficult to separate the two parsers.
I want to simplify this, not by separating th... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61989 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61988 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61987 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61986 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 04:21 PM Revision 4b902422 (git): * 2018-01-21
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61985 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61984 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Please ignore the above files. Patch is located at https://github.com/MSP-Greg/ruby-loco/blob/498b640b81d798c8d69badb7f24738b977caad00/patches/gte20600/spec-ruby-core-file-chmod_umask.patch or https://raw.githubusercontent.com/MSP-Greg/...
-
- This is indeed very surprising that on a platform with 64-bit pointers, Fixnum are still only 30 bits.
+1 to making this more intuitive.
It creates a lot of weird edge cases in ruby/spec.
There are also places in the code where VALU... -
12:01 PM Feature #14378: Increase Fixnum range on Windows from 31 bits to 63 bits
- nobu (Nobuyoshi Nakada) wrote:
> To "fix" this, or relax this limitation, we have to replace tons of `long` in the source code.
Oh...I tried just now. The codes uses so large amount of '#define' to alias types' names, it makes the wo... -
- I'm using vs2017 and embed ruby interpreter in my game engine. In certain situation I need to use Fixnum to pass values of pointers(64-bits pointers). So ruby will use big integer to pass the pointer's values, what may cause unsatisfying...
-
- HfCloud (Xiangyu Shi) wrote:
> So, it is that FIXNUM of the 64-bits ruby is a 32-bits data?
Yes, we are using `long` for fixnums, and Windows is the so-called IL32LLP64 platform.
To "fix" this, or relax this limitation, we have to r... -
- On windows, start an IRB of a 64-bits ruby, enter these code:
~~~ruby
(1<<29).equal?(1<<29)
#=>true
(1<<30).equal?(1<<30)
#=>false
~~~
So, it is that FIXNUM of the 64-bits ruby is a 32-bits data?
But my friend try these co... -
- Just add comment by:
sed -i $'1i\\\n# -*- Autoconf -*-' tool/m4/*.m4
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61983 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- We do not use aclocal(1) by default. But in case users do so,
AC_CONFIG_MACRO_DIRS help them reconstruct the same contents as
this commit includes.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61982 b2dd03c8-39d4-4d8f-98ff-823fe69b... -
- This does not (yet) change anything. The generated configure file
is the identical to previous one (except several empty lines added
and deleted).
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61981 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * win32/Makefile.sub (MISSING): nan() is available since msvcrr120.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61980 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I thought this trick was needed because the result of var_field was
passed to different arguments, as follows:
```
$1 = var_field(p, $1);
$$ = backref_assign_error(p, $1, $1, &@$);
```
Currently the DSL supports that one result is pass... -
- * parse.y (dot_or_colon): made type of `dot_or_colon` and EXPR_DOT
tokens to <id> and set those IDs at tokenization. type cast at
primary in ripper is no longer needed.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61978 b2dd03... -
- * parse.y (block_param): embed excessed_comma event result in
place of rest argument, instead of dispatching with the whole
parameters.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61977 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ext/ripper/tools/dsl.rb (DSL#initialize): define `p` for `struct
parser_params *p`.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61976 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ext/ripper/tools/dsl.rb (DSL#method_missing): expand ID
constnats without parentheses.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61975 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ext/ripper/tools/dsl.rb (DSL.const_missing): define to expand
Qnil and Qundef as-is.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61974 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ext/ripper/tools/dsl.rb (DSL#generate): indent after surrounding
by braces.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61973 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61972 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- instead of scattering #ifdef HAVE_NANF here and there define our
own nan() unless defined elsewhere.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61971 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ko1 (Koichi Sasada) wrote:
> Cool.
> ...
Yes. I had to add marking for catch table iseq as well as marking the instructions. To verify the array contents I used the iterator code from this patch and printed out addresses from the ins... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61970 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- In case it's relevant, certs were generated using
```
openssl req -x509 -newkey rsa:4096 -sha512 -nodes -keyout server.key -out server.crt -subj "/CN=server"
openssl req -x509 -newkey rsa:4096 -sha512 -nodes -keyout client.key -out ...
01/19/2018
-
- I'm trying to use `OpenSSL::X509::Store#verify_callback=` to ignore all error during certificate validation, which according to `man SSL_CTX_set_verify` should be possible:
> If verify_callback always returns 1, the TLS/SSL handshake ... -
- `OpenSSL::X509::Store#verify_callback=` must return `true` exactly, not just anything truthy. Switching the check in ossl_x509store.c:88 to
if (ret == Qfalse || ret == Qnil) {
if (X509_STORE_CTX_get_error(ctx) == X509_V_OK)
X5... -
- @Eregon,
Attached are three files (one patch, and two spec files from repo). Changes allow it to pass on MinGW. Rearranged things, not sure if that's appropriate (or done correctly)...
Thanks, Greg -
- Below are the results of spec tests for 61964. The previous build, `ruby 2.6.0dev (2018-01-19 trunk 61949) [x64-mingw32]` did not have these failures.
Thanks, Greg
```
1)
File#chmod always succeeds with any numeric values FAIL... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61969 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61968 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61967 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61966 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61965 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- I think that they are not used.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61964 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 03:22 PM Revision 2a628a43 (git): * 2018-01-20
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61963 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- `foo!(...)` means Ripper event, and `foo(...)` means C function/macro
call. This is for fail-safe; if I forget `!` accidentally, it would
fail to compile, instead of wrongly adding a new Ripper event.
git-svn-id: svn+ssh://ci.ruby-lang... -
- https://github.com/nobu/ruby/tree/feature/14371-transform_keys-recursive
-
- * test/ruby/test_io.rb (TestIO#test_copy_stream_socket7): reduce
memory usage so the worker process will not die by OOM.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61961 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * parse.y (command): assign to $$. should not rely upon
undocumented behavior.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61960 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- My apologies!
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61959 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61958 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Instead of `_foo`. This makes it useful to do word boundary search of
the editor.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61957 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ``lib/net/protocol.rb:214: warning: `*' interpreted as argument prefix``
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61956 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61955 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- It was replaced with `/*% ripper[brace]: ... %*/`
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61954 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 10:48 AM Revision 340dc036 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61953 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Currently, parse.y actions are hard to read and write because the code
has double meaning (for core parser and for ripper). I think that, if
it is easy to write ripper's code shortly and simply, the double meaning
trick is not needed.
... -
- I believe that the assignment to `$$` was just forgotten.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61951 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- POSIX only defines mode_t to be "an integer typea", and in fact
MacOS defines it to be uint16_t. We didn't have NUM2USHORT before
so it did not make sense but now that we have it. Why not check
apptopriately.
git-svn-id: svn+ssh://ci.... -
- In general, it is said that `for` statement and `each` method call are similar, except for the scope of loop variables.
I found another difference, since 1.9.
```ruby
a = [Struct.new(:to_ary).new([1, 2])]
a.each {|i, j| p [i, j]} ... -
- r61827, r61947 was about to fix this. The proper way to allocate
memory region is called ALLOCV_N.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61949 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Previous commit fails in CI.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61948 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- r61827 was about to fix this. The proper way to allocate memory
region is called ALLOCV_N.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61947 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- introduce new enum for it.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61946 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * vm_args.c (KW_SPECIFIED_BITS_MAX): subtracted 1bit for
FIXNUM_FLAG. [ruby-core:84921] [Bug #14373]
* vm_insnhelper.c (vm_check_keyword): unsigned for bit operation.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61945 b2dd03c8-... -
- gcc -Wjump-misses-init warns this goto. That is a false alert.
However why on earth do we need to use goto here?
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61944 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61943 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61942 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61941 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- It’s not clear for me all the implications of this change.
Would it be possible to exemplify the before and after behaviours in the description?
It feels to me that with this implementation it would be possible to consider both symbo... -
- Applied in changeset trunk|r61940.
----------
vm_insnhelper.c: fix many keyword arguments
* vm_insnhelper.c (vm_check_keyword): if the index exceeds the
width of unspecified bits, that argument is specified.
`unspecified_bits` stil... -
- * vm_insnhelper.c (vm_check_keyword): if the index exceeds the
width of unspecified bits, that argument is specified.
`unspecified_bits` still be a fixnum if the actual arguments do
not exceed the limit, regardless the formal param... -
- * vm_insnhelper.c (vm_check_keyword): invert unspecified value
flag as `checkkeyword` result. fix up r58390.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61939 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:16 AM Feature #14370: Directly mark instruction operands and avoid mark_ary usage on rb_iseq_constant_body
- Cool.
Did you verify the references between your patch and current implementation?
You can have two sets of referring objects from iseq->mark_ary and iseq (w/ your patch) and you can compare them to verify the reference.
> I fig... -
- matz (Yukihiro Matsumoto) wrote:
> rosenfeld (Rodrigo Rosenfeld Rosas), that sounds like if the de-facto JSON library can automatically convert map keys to symbols, most of the needs are fulfilled. And that must be much easier and sim... -
- matz (Yukihiro Matsumoto) wrote:
> @rosenfeld, that sounds like if the de-facto JSON library can automatically convert map keys to symbols, most of the needs are fulfilled. And that must be much easier and simpler than unifying symbols ... -
- @rosenfeld, that sounds like if the de-facto JSON library can automatically convert map keys to symbols, most of the needs are fulfilled. And that must be much easier and simpler than unifying symbols and strings.
Matz.
-
- It seems HUGE_VAL is already used. Why not eliminate INTINITY.
NAN is also float. That of double is called nan(). This is also
fixed.
Signed-off-by: Urabe, Shyouhei <shyouhei@ruby-lang.org>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/t...
01/18/2018
-
09:34 PM Bug #14372: Memory leak in require with Pathnames in the $LOAD_PATH in 2.3/2.4
- I did a small change to see how the number of Pathnames in the `$LOAD_PATH` changes the leak amount at the script's completion.
It looks like the memory leak is linear:
1 74.6 MB
2 149.5 MB
3 214 MB
4 290 MB
5 353.6 MB
9 575.4 ... -
- It's worth mentioning that more `Pathname` objects in the `$LOAD_PATH` may make this leak worse as even on ruby 2.5.0, the time for require increases with each added Pathname to the `$LOAD_PATH`.
-
- There is a memory leak that we have found on ruby 2.3.6 and 2.4.3 that happens on Mac OSX and Linux. Ruby 2.2.6 and 2.5.0 do not leak. We have not tested other platforms.
If `$LOAD_PATH` contains one or more Pathname objects, `requi... -
- normalperson (Eric Wong) wrote:
> tenderlove@ruby-lang.org wrote:
> ...
I figured this might be the case. This patch should make ISeq marking slower, but I wasn't sure if it would be mitigated by the fact that the ISeq objects get old... -
- I ran the code and indeed, this is very strange behaviour.
The bigget surprise to me was the "prints nothing in 2.5, prints
a1 in 2.4 and 2.3" part. I know way too little to say anything
but to me this looks like a bug/regression.
... -
05:23 PM Bug #14373 (Closed): Methods with more than 32 keyword arguments with default values have some of the arguments set to default despite being passed in.
- ~~~ ruby
class Test
# 33 keyword arguments
def test1(a0: '', a1: '', a2: '', a3: '', a4: '', a5: '', a6: '', a7: '', a8: '', b0: '', b1: '', b2: '', b3: '', b4: '', b5: '', b6: '', b7: '', b8: '', c0: '', c1: '', c2: '', c3: '', ... - 03:48 PM Revision 09b4d6e8 (git): * 2018-01-19
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61937 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * compile.c (ibf_dump_object_list): allocate known-size array by
ALLOCV_N instead of rb_ary_tmp_new.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61936 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- r61883
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61935 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61934 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- I agree with the proposal.
If it is approved, please do not forget meaningful documentation + perhaps
at the least one short example for using it (I refer to the recursive: true
option; http://ruby-doc.org/core-2.5.0/Hash.html#metho... -
05:59 AM Feature #14371: New option "recursive: true" for Hash#transform_keys!
- > Why prefer `each` over `transform_keys!`?
> ...
Your points are correct. The ideal pseudo code is here:
```ruby
def transform_keys!(recursive: false, &block)
# do original transform_keys! here
values.each do |v|
if v.re... -
- tagomoris (Satoshi TAGOMORI) wrote:
> ```ruby
> ...
Why prefer `each` over `transform_keys!`?
And probably you wanted to write `elsif`. -
- `Hash#transform_keys!` is available when we want to symbolize hash keys.
But in some/many cases (for example, receiver hash object is nested configuration tree loaded from any files), hash object are
nested object, which has hashes or ... -
- * rememberd -> remembered
* refered -> referred
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61933 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61932 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61931 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61930 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61929 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61928 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61927 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61926 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61925 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61924 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61923 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61922 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61921 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61920 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61919 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61918 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61917 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61916 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61915 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61914 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61913 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- This is the -Wsuggest-attribute=noreturn equivalent option for clang.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61912 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61911 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61910 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61909 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61908 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61907 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61906 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61905 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * vm_eval.c (rb_type_str): moved `case`s and semicolons so auto
indentation works.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61904 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * eval_intern.h (pass_passed_block_handler): remove duplicate
check. vm_block_handler_verify() is called in the successive
function call.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61903 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
04:42 AM Bug #14232: Unused refinement still breaks method search
- You cannot refine Module on 2.3.x.
I set DONTNEED for 2.3. -
- It your ruby is compiled with that option, `long long` should not be used.
-
- You can write "exact" number by `1.2r`.
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61902 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
-
- * parse.y (assignable): no longer needs to undef since r61899.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61901 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61900 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * parse.y (REQUIRED_KEYWORD): special argument for required
keyword argument, for core and ripper.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61899 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r61898.
----------
resolv.rb: NUL hosts
* lib/resolv.rb (Resolv::Hosts::DefaultFileName): fallback to NUL
device when Win32::Resolv.get_hosts_path() returned nil, to get
rid of TypeError in lazy_initializ... -
- What configuration causes it?
No TCP/IP stack? -
- * lib/resolv.rb (Resolv::Hosts::DefaultFileName): fallback to NUL
device when Win32::Resolv.get_hosts_path() returned nil, to get
rid of TypeError in lazy_initialize.
[ruby-core:84907] [Bug #14369] [Fix GH-1791]
git-svn-id: svn+s... -
- * lib/resolv.rb (each_address): use safe navigation operator to
avoid extra hash lookups, as well as each_name since r56890.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61897 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * marshal.c (r_object0): initialize `keywords` and removed
`keyword_init` flag, to get rid of maybe-uninitialized warning.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61896 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ext/win32/lib/win32/resolv.rb: call rb_w32_osid instead of
direct GetVersionExA API.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61895 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 12:52 AM Revision f729089f (git): logger: use safe navigation operator
- Saves a few hundred bytes of bytecode in a frequently loaded module.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61894 b2dd03c8-39d4-4d8f-98ff-823fe69b080e