Activity
From 01/10/2018 to 01/16/2018
01/16/2018
-
10:05 PM Bug #14366 (Rejected): Not possible to compile ruby C extension when using `-std=c90`
- DeveloperHowto says that ruby should be C90, not C99, however it's not possible
to compile C extension using `-std=c90` command line argument with error:
```
C:/Ruby25/include/ruby-2.5.0/ruby/defines.h:224:25: warning: ISO C90 does ... -
09:34 PM Feature #14365: irreconcilable ancestor chain ordering expectations should perhaps produce an error
- > would it not be better if this were an error?
I have not yet reached the build-up chain that you described above,
but I think the biggest issue in your report so far is the focus
on an error.
Why should this be an error? The sy... -
05:34 PM Feature #14365 (Open): irreconcilable ancestor chain ordering expectations should perhaps produce an error
- ```ruby
module Module1
def foo
puts 'Module1#foo'
super
end
end
module Module2
include Module1
def foo
puts 'Module2#foo'
super
end
end
class SuperClass1
def foo
puts "SuperClass1#f... -
05:53 PM Feature #14362: use BigDecimal instead of Float by default
- That's absolutely true. However, it's much less likely and I would say less surprising than the issues you find with a `Float`. Switching to use `Rational` where possible is an option but felt like a step too far. In short, it's not perf...
-
09:00 AM Feature #14362: use BigDecimal instead of Float by default
- "arbitrary-precision" doesn't mean that `BigDecimal` is immune to rounding problems:
```ruby
a = BigDecimal(1)
b = BigDecimal(3)
(a / b) * b
#=> 0.999999999999999999e0
``` -
05:33 PM Feature #14183: "Real" keyword argument
- I've filed a bug report some time ago, maybe you could add it as a related issue: https://bugs.ruby-lang.org/issues/11993
-
05:23 PM Bug #14364 (Open): Regexp last match variable in procs
- While working on TruffleRuby's regexp variables implementation I found the following behaviour when comparing our behaviour with MRI 2.3.5 and 2.5.0.
Some core methods such as `String#scan` take an optional block argument, and if this... -
05:14 PM Bug #14353: $SAFE should stay at least thread-local for compatibility
- > Of course, I proposed $SAFE as Fiber local.
:)
If $SAFE had no effect at all, then I think it would be fine to make $SAFE a normal process-wide global variable.
But this is not the case, $SAFE still causes SecurityError.
Theref... -
03:14 AM Bug #14353: $SAFE should stay at least thread-local for compatibility
- Of course, I proposed `$SAFE` as `Fiber` local.
However, Matz said process global is enough.
akr also said nobody use `$SAFE` correctly, so that such incompatibility is not a matter.
I'm neutral. Matz, please decide it.
-
04:48 PM Bug #14361: Segmentation fault when array includes two nil's without a comma between them: [nil nil, nil]
- Confirmed with 2.5.0, 2.4.3 did not occur. Below shows 2.6/trunk info:
```
ruby 2.6.0dev (2017-12-31 trunk 61522) [x64-mingw32] Failed SEGV
ruby 2.6.0dev (2018-01-01 trunk 61530) [x64-mingw32] Passed Syntax Error
ruby 2.5.... -
03:12 PM Revision f8a0c7d6 (git): parse.y: Refactor for-statement generation
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61879 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:12 PM Revision 0160006b (git): parse.y (new_args_tail): Use human-friendly variable names
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61878 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:12 PM Revision d52e51ec (git): * 2018-01-17
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61877 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:12 PM Revision 5fd143c1 (git): node.c: Separately allocate a struct having flexible array
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61876 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:03 PM Feature #12306: Implement String #blank? #present? and improve #strip and family to handle unicode
- I would also like to have `blank?` and `present?` in Ruby. @matz says he doesn't see the benefit of having them, but I think they improve readability.
-
12:21 PM Bug #14360: Regression CSV#open method for writing from Ruby 2.4.3 to 2.5.0
- jeremyevans0 (Jeremy Evans) wrote:
> This isn't a regression, it's an intentional bug fix. If you tell it to write the headers, it should write the headers even if there are no rows. See #9988 and r59640. If someone really wants the ... -
09:21 AM Revision 96268c1d (git): nested flexible array member is a GCCism
- This is NG. The ISO C section 6.7.2.1 explicitly states that
structs having flexible array members "shall not be a member
of a structure or an element of an array."
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61875 b2dd03c8-39d4-4... -
08:35 AM Revision 7edb0a27 (git): -Wno-overlength-strings
- as per https://bugs.ruby-lang.org/projects/ruby-trunk/wiki/Assumptions
we are officially giving up 509 characters limit of C string
literal length.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61874 b2dd03c8-39d4-4d8f-98ff-823fe69b... -
08:21 AM Revision b343c53d (git): parse.y: unified local_push argument
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61873 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
08:05 AM Revision 1c0073fa (git): parse.y: simplified compstmt
- * parse.y (top_compstmt, compstmt): unified void_stmts with
ripper.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61872 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:52 AM Bug #14363 (Closed): each_grapheme_cluster.size returns the wrong size
- Ruby 2.5 adds `String#each_grapheme_cluster` to enumerate the string's grapheme clusters:
```ruby
str = "a\u0300i\u0301" #=> "àí"
str.each_grapheme_cluster.to_a #=> ["à", "í"]
```
Unfortunately, the enumerator's `s... -
07:24 AM Revision 4b6f3bce (git): node.c: Stop double meaning of NODE_FOR by introducing NODE_FOR_MASGN
- NODE_FOR was used both for "for"-statement itself and for
multi-assignment of for-statement (for x, y, in...end).
This change separates the two purposes, NODE_FOR for the former, and
newly introduced NODE_FOR_MASGN for the latter.
git-s... - 06:36 AM Revision 56524df9 (git): timev.h: just use "unsigned int" for bitfields
- There's no point in having separate types depending on C dialect
when using bitfields, "unsigned int" bitfields are bitfields
anywhere.
Note: we also have test_memsize in test_time.rb in case
users of other platforms want to enable size... -
05:49 AM Revision f62a2fd1 (git): fix macro argument names inconsistency
- * include/ruby/defines.h (RUBY_ALIGNAS): Fix macro definition.
Fix compile error with Fujitsu C Compiler (fcc) on Solaris.
* include/ruby/defines.h (RUBY_ALIGNOF): Fix macro argument name.
Fix compile error with fcc and Oracle Solar... -
05:27 AM Revision ce769284 (git): parse.y (expr_value_do): factor out COND_PUSH->expr_value->do->COND_POP
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61868 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:16 AM Revision 96dcd215 (git): parse.y: removed PARSER_ARG macro
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61867 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:16 AM Revision 28e554a6 (git): parse.y: expand tokadd_mbchar
- * parse.y (tokadd_mbchar): renamed and expand callers with p.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61866 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:09 AM Revision dc1e6f17 (git): sizeof(uintptr_t) != sizeof(uintptr_t *)
- Reported by mame. Thanks.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61865 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:27 AM Revision 840d0dc1 (git): parse.y: set location of nodes that lexer generates
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61864 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
02:00 AM Revision 6fe72f29 (git): parse.y: set location of string/literals in the lexer instead of actions
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61863 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:43 AM Revision cf924a05 (git): parse.y (new_regexp): Fix SEGV of `/#{"\u3042"}#{'い'}/` in non UTF-8
- Mixing other encoding string literals in one Regexp caused SEGV.
This bug was found by CoverityScan.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61862 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:32 AM Revision fb1172bc (git): parse.y (symbol_append): Added to factor out `%i[]` and `%I[]`
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61861 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
01/15/2018
- 11:43 PM Revision f6c65935 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61860 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
11:43 PM Revision 0f3dcbdf (git): Add tests for Node code locations
- * test/-ext-/ast/test_ast.rb: Add tests for Node
code locations. This file tests
1. There are no Node whose code location is default
value (#test_not_cared)
2. There are no Node whose children's code locations
exceed pa... -
10:25 PM Feature #14362: use BigDecimal instead of Float by default
- > I realize this goes against the 3x3 goal but I think BigDecimal
> ...
That's an interesting comment. :)
You could ask matz whether 3x3 is more important than making life
of developers easier. I am not saying that your proposal mak... -
09:32 PM Feature #14362 (Rejected): use BigDecimal instead of Float by default
- When writing a decimal the default type assigned is `Float`:
```ruby
> 1.2.class
=> Float
```
This is great for memory savings and for application speed but it comes with accuracy issues:
```ruby
> ...
=> 12994.999999999998
... -
10:07 PM Bug #9572: Restarting Coverage does not produce correct coverage result
- Well, well, well Aaron. What have you been doing? Gmail has an eye on you!
Your messages are being considered spam. :-)
Is it just me again? -
10:03 PM Bug #9572: Restarting Coverage does not produce correct coverage result
- I am seeing emails from Aaron's comments.
-
09:56 PM Bug #9572: Restarting Coverage does not produce correct coverage result
- Aaron, why aren’t we seeing email notifications from your comments? Or is it just me?
-
09:54 PM Bug #9572: Restarting Coverage does not produce correct coverage result
- > Pause / Resume just seems like ignoring coverage information for some code.
Yes, the goal would be to ignore it for some code, but with reduced performance costs.
My thought was much of the performance cost was related to tracki... -
07:10 PM Bug #10643: 2.2: TestRubyOptions#test_command_line_progname_nonascii test failure (MinGW)
- Hello,
Below are the two failures for `test_rubyoptions.rb`, using `ruby 2.4.4p228 (2018-01-15 revision 61854) [x64-mingw32]` and `test_rubyoptions.rb` at the same commit:
```
# Note - Two skips for 'platform dependent feature'
... -
01:37 PM Bug #10643: 2.2: TestRubyOptions#test_command_line_progname_nonascii test failure (MinGW)
- Hello, Grep
Thank you very much for your investigation!
I confirmed that the revision r59040 was depend on some other changesets, and it isn't clear that it can be backported without unexpected behavior change.
Anyway please show ... -
05:51 PM Bug #14360: Regression CSV#open method for writing from Ruby 2.4.3 to 2.5.0
- This isn't a regression, it's an intentional bug fix. If you tell it to write the headers, it should write the headers even if there are no rows. See #9988 and r59640. If someone really wants the old broken behavior, maybe we can add ...
-
05:32 PM Bug #14360: Regression CSV#open method for writing from Ruby 2.4.3 to 2.5.0
- Eric Wong <normalperson@yhbt.net> wrote:
> doc/maintainers.rdoc points to GH.
... for the CSV gem; as parts of the stdlib are separated into
different repos. -
05:32 PM Bug #14360: Regression CSV#open method for writing from Ruby 2.4.3 to 2.5.0
- shevegen@gmail.com wrote:
> Issue #14360 has been updated by shevegen (Robert A. Heiler).
> > This issue is also open in its repository because it's not clear to me
> > where is the appropriate place to open the issue
>
> Don't wo... -
03:02 PM Bug #14360: Regression CSV#open method for writing from Ruby 2.4.3 to 2.5.0
- > This issue is also open in its repository because it's not clear to me
> ...
Don't worry - the tracker here is still the official bug/feature/misc
tracker for the ruby language. Github issues are secondary and often
primarily useful... -
02:20 PM Bug #14360 (Rejected): Regression CSV#open method for writing from Ruby 2.4.3 to 2.5.0
- I have noticed a different behaviour between Ruby <= 2.4.3 and Ruby 2.5.0 for the `#open` method.
This issue is also open in its repository because it's not clear to me where is the appropriate place to open the issue, https://github.... -
05:42 PM Bug #14361 (Closed): Segmentation fault when array includes two nil's without a comma between them: [nil nil, nil]
- Easily reproduced segmentation fault relating to forgetting to type a comma between nil's in an array. Doesn't occur if array only contains the `nil nil` entry, instead throws a syntax error, which is what I would expect in this case.
... -
04:12 PM Revision e947f26f (git): parse.y: Removes unneeded Ripper/Parser guards
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61858 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:04 PM Revision e7c8b324 (git): * 2018-01-16
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61857 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:04 PM Revision ef1b0f36 (git): parse.y (new_command_qcall): Receives a block (optional)
- There were four cases that uses new_command_qcall and then
method_add_block. This change factors out the four rules.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61856 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:01 PM Revision bd313552 (git): test/ruby/test_syntax.rb (test_command_with_cmd_brace_block): Added
- The bison rules were not covered.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61855 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:54 PM Bug #14359 (Closed): IO#ungetbyte integer overflow
- In Ruby's IO, a "byte" means an integer of range 0...256.
However IO#ungetbyte is the only exception.
It does not check the argument to accept liberal integers.
```ruby
File.open("/dev/zero") {|f| f.ungetbyte(-1); p f.read(2) } # =... -
01:27 PM Bug #13794: Infinite loop of sched_yield
- ruby_2_4 r61854 merged revision(s) 60079.
-
01:27 PM Revision e25eace6 (git): merge revision(s) 60079: [Backport #13794]
- thread_pthread.c: do not wakeup inside child processes
* thread_pthread.c (rb_thread_wakeup_timer_thread): check
ownership before incrementing
(rb_thread_wakeup_timer_thread_low): ditto
[Bug #13794]... -
12:25 PM Revision 79a25170 (git): test_console_attr.rb: fix test
- * test/-ext-/win32/test_console_attr.rb (reverse_video): fix test
when reverse video is set.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61853 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:00 PM Revision c420603f (git): Fix a typo.
- * gc.c: beacuse -> because.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61852 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
11:58 AM Bug #14356: Backport 61605
- It's a private team.
-
06:45 AM Bug #14356: Backport 61605
- What is that slack channel?
Is it open to subscription? -
03:48 AM Bug #14356 (Closed): Backport 61605
- It fixed secure token of the slack channel.
-
11:53 AM Bug #14358 (Closed): URI.encode_www_form_component doesn't encode bad chars properly
- ~~~ruby
URI.encode_www_form_component "\u02DA", Encoding::WINDOWS_1252
#=> "%26730%3B"
# Expected:
#=> "%26%23730%3B"
~~~
As per http://www.w3.org/TR/2013/CR-html5-20130806/forms.html#url-encoded-form-data :
"For each charac... -
10:09 AM Revision 2701001b (git): Fix a typo.
- * win32/win32.c: wrok -> work
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61851 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
10:00 AM Bug #14357 (Closed): thread_safe tests suite segfaults
- The thread_safe gem is not maintained anymore, but I don't see any reason why its test suite should segfault with Ruby 2.5.
~~~
+ rspec -Ilib spec
Randomized with seed 62008
............./builddir/build/BUILD/thread_safe-0.3.6/usr/... -
08:54 AM Revision 4d073d53 (git): parse.y: Removes unreachable warnings
- tIDENTIFIER is now always a local id (except fname).
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61850 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
08:54 AM Revision 6bdd1989 (git): parse.y: Removes unneeded NULL checks
- Nowadays, there are less rules whose return value is NULL.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61849 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:54 AM Revision 84cf66cc (git): parse.y: Remove unneeded NULL check
- There are many usages assuming that bodystmt always returns non-null.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61848 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:39 AM Revision 8ac73660 (git): parse.y (last_arg_append, rest_arg_append): factor out the code clones
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61847 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
07:32 AM Revision 194d4e99 (git): __declspec(align(#)) does not take sizeof()
- same as r61833
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61846 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:30 AM Revision 8a52dbdb (git): ruby_aligned_char no longer needed.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61845 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
07:01 AM Revision 995717e1 (git): raddrinfo.c: fix parse_numeric_port
- * ext/socket/raddrinfo.c (parse_numeric_port): necessary
regardless of GETADDRINFO_EMU.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61844 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
06:47 AM Revision 8699a7a0 (git): take alignof instead of sizeof
- win32ole.c includes ALLOCA_N(struct myCPINFOEX, 1). On such case
it is not a wise idea to align to the size of that struct.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61843 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
06:25 AM Revision 7c088b96 (git): parse.y (new_ary_op_assign): Factor out the typical code clone
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61842 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
06:25 AM Revision c2052b02 (git): parse.y: Fix a bug of `obj[42, &blk] ||= foo bar`
- Follow up of r28123 (!)
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61841 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
06:25 AM Revision 53c6960d (git): parse.y (begin_block): Factor out BEGIN {} process.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61840 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
05:51 AM Revision 369aca64 (git): also blacklist gcc 4.9 for __builtin_alloca_with_align
- Reports show that gcc (Raspbian 4.9.2-10) 4.9.2 fails here.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61839 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
05:27 AM Revision 55af6259 (git): tool/ruby_vm/models/attribute.rb: void for empty arguments
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61838 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
05:17 AM Revision 52a5f76e (git): parse.y: Remove unused code comment blocks
- The code fragments were commented out in YARV merge era.
I believe that it will be never needed in near future.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61837 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
04:36 AM Revision 39ee36f6 (git): disable __builtin_alloca_with_align for GCC 4.8
- It seems to be a false positive that the configure detects this
undocumented function to be available on the compiler.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61836 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
04:36 AM Revision e41b4a45 (git): give up RSTRING_PTR() being VALUE-aligned
- rb_setup_fake_str() can take arbitrary char* address, typicalluy
C string literals. These arguments have no guarantee of
alignment at all. It was not a wise idea for me to think
RSTRING_PTR can be aligned.
git-svn-id: svn+ssh://ci.rub... -
04:36 AM Revision bca40b8b (git): sorry, this hunk was a garbage. [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61834 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
02:59 AM Revision cabc3b65 (git): __declspec(align(#)) does not take sizeof()
- Use compile-time constant expression instead.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61833 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:39 AM Revision 65236c06 (git): more ytab.sed fixes
- * tool/ytab.sed: fix for more old bison which does not support %lex-param
at yydestruct (missed at the previous commit).
define yy_stack_print macro to add `p` argument instead of
replacement at callers.
git-svn-id: svn+ssh://ci.r... -
02:37 AM Bug #14246: Inconsistent C source code indentation
- I can't count to 8 in
```
xargs grep --files-with-match '^ '`
```
, sorry, just ignore me. :/ -
02:26 AM Bug #14246: Inconsistent C source code indentation
- @graywolf we are talking about C codes here. The "Do not use TABs" policy applies to non-C files.
-
02:35 AM Revision 8f745a2f (git): more support for NORETURN
- Before this NORETURN was checked only for __attribute__ or __declspec,
but nowadays other ways are there to tell compilers that a function
never returns. Take them into account.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61831 b... -
02:35 AM Revision df9a7090 (git): __builtin_alloca_with_align for optimal memory access
- ALLOCA_N takes type arugment. It is natural that the returned
value to be used as an array of type, thus type-aligned.
Luckily GCC has a builtin to tell compiler such alignment info.
This should generate beter instructions.
git-svn-id:... -
02:35 AM Revision 39cfa67b (git): __builtin_assume_aligned for *(foo *) casts
- These casts are guarded. Must be safe to assume alignments.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61829 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:35 AM Revision 21429b14 (git): __alignof__ to take alignment of a type
- C11 and C++11 has this feature so why not use it when available.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61828 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:35 AM Revision f089a528 (git): __attibute__((__aligned__)) for RSTRING_PTR()
- For instance array.c:rb_ary_product() uses RSTRING_PTR() as an
array of int. So to avoid misaligned memory access RSTRING_PTR()
must at least be sizeof(int)-aligned. However the type of
RSTRING_PTR() is char*, which of course can expect... -
02:23 AM Revision 630ab3b9 (git): more ytab.sed fixes
- * tool/ytab.sed: `p` is too short to distinguish alone from other
names. fix for more old bison which does not support %lex-param
at yydestruct. add `p` argument to non-prototype declaration of
yy_stack_print.
git-svn-id: svn+ss... - 12:45 AM Revision 5f3ddb32 (git): * 2018-01-15
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61825 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:45 AM Revision 4cc98948 (git): tool/ytab.sed: Support some old bison implementations
- At least, I confirmed bison 2.3 (because macOS uses the version).
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61824 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
01/14/2018
-
11:53 PM Bug #9572: Restarting Coverage does not produce correct coverage result
- > The more important piece of the change is being able to pause and resume coverage.
Pause / Resume just seems like ignoring coverage information for some code. This case seems like you can handle by taking snapshots around the execu... -
09:10 PM Bug #9572: Restarting Coverage does not produce correct coverage result
- Thanks for the reply... So you are right about the calculating the current coverage with `peek_result` and if we want to avoid complexity, it would be fine to drop the reset method and have the user app handle calculating the difference....
-
08:31 PM Bug #9572: Restarting Coverage does not produce correct coverage result
- I have two questions:
1. How is this different than recording the current coverage with `peek_result`, then subtracting later? Like this for example: https://gist.github.com/tenderlove/eefcce7dcadb0ed48968f575698e3f04
2. Is there ... -
05:55 PM Bug #9572: Restarting Coverage does not produce correct coverage result
- I would like to work on closing this out but I believe due to changes in the API expectations since the bug was filed this is likely to not be considered a bug anymore but more likely to be considered to be expanding the feature set. I a...
-
08:12 PM Bug #14355 (Rejected): clone issue
- As documented, `Object#clone` and `Object#dup` do shallow copies by default, so this behavior is expected. Create your own class and override `initialize_copy` (or `initialize_dup` and `initialize_clone`) as appropriate for the behavior...
-
07:27 PM Bug #14355 (Rejected): clone issue
- #!/usr/bin/env ruby
aMutantSpeak = [[nil,nil],[nil,nil]]
aDogSpeak = aMutantSpeak.clone
aCatSpeak = aMutantSpeak.clone
aDogSpeak[0][0] = "W"
aCatSpeak[0][0] = "m"
aCatSpeak[0][1] = "e"
aDogSpeak[0][1] = "O"
aCatSpeak[1][0] = "o"
... -
05:56 PM Bug #14246: Inconsistent C source code indentation
- As @vo.x already pointed out, there are guidelines for the indentation. So based on the guidelines the 101 files are (probably) correctly indented and the 76 (10 + 66) files are (probably) wrongly indented.
-
03:39 PM Bug #10643: 2.2: TestRubyOptions#test_command_line_progname_nonascii test failure (MinGW)
- @nagachika
First of all, I'd like to apologize for the above, as it is incorrect. I revisited this (ruby-loco 'broke' due to the renaming of configure.in to configure.ac), and the commit that fixed the failure was 59040 aac0b43 (by @... -
03:24 PM Misc #13968: [Ruby 3.x perhaps] - A (minimal?) static variant of ruby
- What You think about mrubyc ?
Second idea is turn off float and stdio
-
02:44 PM Revision 5c0748b6 (git): parse.y (parser_heredoc_dedent): Removed
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61823 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
02:28 PM Revision 07d356ee (git): parse.y: yydebug
- * parse.y (yydebug): define to disable a global variable and get
rid of linker error when static linked ext.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61822 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:17 PM Revision a9f25963 (git): parse.y: Remove unused a macro "FIXME"
- I don't know what it was, but seems that it has been already fixed since
r12117.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61821 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:14 PM Revision 99e52bcd (git): parse.y: ripper no longer uses rb_discard_node
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61820 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
02:09 PM Revision 269856a4 (git): parse.y: Remove a code for old yacc
- The current parse.y won't compile with yacc since it depends on many
bison's extensions. Also, configure.ac does not have a check for yacc,
so the macro OLD_YACC is no longer used.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@6181... -
01:51 PM Revision 15352965 (git): parse.y: Remove almost all *_gen macros by passing parser_params explicitly
- In parse.y many functions were suffixed "_gen" and had companion macros
to pass struct parser_params implicitly, which made parse.c bigger and
more obscure.
This change expands and removes almost all "*_gen" macros. This
requires expli... -
01:51 PM Revision 97b98999 (git): parse.y: Expand global-like accessor macros for struct parser_params
- For example, `lex_strterm` is expanded to `p->lex.strterm`.
I believe that this expansion make the code straightforward.
They look not so annoying because "parser" was renamed to "p".
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61... -
01:51 PM Revision 14be478d (git): parse.y: Use "p" for the variable of struct parser_params consistently
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61816 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:51 PM Revision ca6e1620 (git): parse.y: Avoid "p" as a variable name
- Because I want to use the name "p" for struct parser_params through
parse.c. This change renames "p" to "ptr", "paren", etc. depending upon
the context.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61815 b2dd03c8-39d4-4d8f-98ff-82... -
01:41 PM Bug #14354 (Closed): Remove confusing doc comments for 2.3
- Broken doc comments are removed at @56285:
https://bugs.ruby-lang.org/projects/ruby-trunk/repository/revisions/56285/diff
An issue is reported to RDoc because of this is not backported to 2.3:
https://github.com/ruby/rdoc/issues/429 -
11:19 AM Revision 6b5e0bd9 (git): exclude flexible array size with old compilers
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61814 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
02:44 AM Feature #14339 (Closed): [PATCH] net/http: use writev for HTTP chunked request bodies - Applied in changeset trunk|r61812.
----------
net/http: use writev for HTTP chunked request bodies
This reduces both user and system CPU time for large
uploads with dynamically-generated request bodies.
user system ... - 02:44 AM Revision bbea0270 (git): * 2018-01-14
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61813 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 02:44 AM Revision 7db24a62 (git): net/http: use writev for HTTP chunked request bodies
- This reduces both user and system CPU time for large
uploads with dynamically-generated request bodies.
user system total real
before: 0.393334 1.580000 1.973334 ( 1.971066)
after: 0.223334 0.97...
01/13/2018
-
10:23 PM Bug #14353: $SAFE should stay at least thread-local for compatibility
- I have seen $VERBOSE used in ways very similar as you described though and have used
it myself; most commonly I used it e. g. when I would use syck for yaml files rather
than psych, in order to suppress warnings I'd get during loading.... -
07:33 PM Bug #14353 (Closed): $SAFE should stay at least thread-local for compatibility
- In #14250 $SAFE changed from a frame+thread-local variable to a process-wide global variable.
This feels wrong and breaks the most common usage of $SAFE in tests:
~~~ ruby
Thread.new {
$SAFE = 1
sth that should be checked to... -
01:08 PM Revision 982e9e62 (git): string.c (struct mapping_buffer): Use FLEX_ARY_LEN
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61811 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:00 PM Revision c33ba4a6 (git): compile.c (struct ibf_object_*): Use FLEX_ARY_LEN
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61810 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:00 PM Revision fb4b6f70 (git): compile.c (struct ibf_id_entry): Just removed.
- It looked unused.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61809 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:44 PM Revision 7ad9975f (git): iseq.h (struct iseq_catch_table_entry, iseq_compile_data_storage): Use FLEX_ARY_LEN
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61808 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:25 PM Revision 879df66d (git): file.c (struct apply_arg): Use FLEX_ARY_LEN
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61807 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:17 PM Revision ccc5c732 (git): variable.c (struct gen_ivtbl): Use FLEX_ARY_LEN.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61806 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:09 PM Revision 2768bae8 (git): node.c (node_buffer_elem_t): Use FLEX_ARY_LEN
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61805 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
11:45 AM Revision 7da77161 (git): internal.h (FLEX_ARY_LEN): Add a macro to define a flexible array
- Also, use it in iseq.c.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61804 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
11:10 AM Revision afcd060a (git): Fix a typo.
- configure.ac: delcares -> declares.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61803 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
10:47 AM Revision 90cb7d30 (git): __VA_ARGS__ is a C99ism
- give up CALL_ATTRIBUTE macro.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61802 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
10:47 AM Revision 307547f0 (git): flexible array member is a C99ism
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61801 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
09:23 AM Revision 982e27e9 (git): Update dependencies
- * common.mk: enc/unicode.$(OBJEXT) depends on onigmo.h via
oniguruma.h.
* common.mk: dependencies of *prelude.$(OBJEXT) are defined for
each generated C sources.
* enc/depend: casefold.h and name2ctype.h are located under
$(UNICO... -
04:11 AM Feature #14352: Array#pack("M") Quoted-Printable with binary mode
- 皆様ご意見いただきありがとうございます。
成瀬さんのおっしゃる通り、私の手元では現状はpack("M")の出力にgsubを付加して、呼び出し側で回避するコードを入れています。
また、Mailライブラリ側でも同種の議論があり、バイナリの場合はto_crlfで改変しないようにするのか、
pack("M")呼び出し時に、後処理をするのかなど、試行錯誤していますが、まだ落ち着いていない状況です。
https://github.com/mikel/mail/i... -
01:54 AM Feature #14352: Array#pack("M") Quoted-Printable with binary mode
- 2018/01/13 10:53追記 \rと\nの表記が逆になっていたため訂正しました。
-
12:30 AM Revision e02e13d7 (git): Update dependencies using `tool/update-deps`
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61799 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
01/12/2018
-
07:51 PM Feature #14339: [PATCH] net/http: use writev for HTTP chunked request bodies
- naruse@airemix.jp wrote:
> > @debug_output << Array(strs).map(&:dump).join if @debug_output
>
> I thought strs is always Array.
> Is Array() is needed here?
No, will remove before committing.
> other parts are looks good to m... -
01:02 PM Feature #14339: [PATCH] net/http: use writev for HTTP chunked request bodies
- > @debug_output << Array(strs).map(&:dump).join if @debug_output
I thought strs is always Array.
Is Array() is needed here?
other parts are looks good to me. -
05:48 PM Feature #14352: Array#pack("M") Quoted-Printable with binary mode
- まず報告の\rと\nが逆なように思います。
で、検討にあたって互換性というかまず現状を考えたいのです。
そもそも quoted-printable は改行がCRLFであるべきところ、pack("M")の出力はLFだけを通すんですよね。
という挙動だけ見るとこれはバイナリモードなのかと最初考えますが、
LFのままではネットワークに流せませんからこの出力をメールなどで出す場合は s/\n/\r\n/g すればよい……
とみせかけてそうすると今度は物理改行が... -
04:49 AM Feature #14352: Array#pack("M") Quoted-Printable with binary mode
- うささんの案には惹かれるものがありますが、 M を削除するよりは将来の挙動を変更すると警告するほうが良いと思います。で、デフォルトでどちらかによせるかというとバイナリかな?
Matz.
-
04:24 AM Feature #14352: Array#pack("M") Quoted-Printable with binary mode
- 遠藤さんのRFCの解釈内容に同意します。
直さなければいけないのも同意しますが、互換性はやっぱり大切、というか、
テキストかバイナリかは本来必ず指定されなければいけない(判断のしようがない)と
思いますので、やはりここはオプションを追加して、
`M` : 従来挙動。ただし将来削除するものとして警告を出す
`M0`: RFC2045テキスト準拠
`M1`: RFC2045バイナリ準拠
というのを提案します。
`0` と `1` は安直にbinm... -
01:35 AM Feature #14352: Array#pack("M") Quoted-Printable with binary mode
- 遠藤と申します。ご報告ありがとうございます。
Quoted-Printable を規定しているのは RFC 2045 の "6.7. Quoted-Printable Content-Transfer-Encoding" だと思います。関連しそうなところを中心にルールを要約すると
(1) canonical form での CRLF 改行の CR と LF 以外の文字は、原則として =0C のようにエンコードする。ただし他のルールが別表現を許している場... - 03:59 PM Revision 4ebde39c (git): * 2018-01-13
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61798 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:59 PM Revision 1b102b71 (git): parse.y: Remove meaningless ifndef guards
- Because the part of the code is already within `#ifndef RIPPER`.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61797 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:25 PM Revision 21f03063 (git): parse.y (token_info_push, token_info_pop): Refactoring
- * remove unused argument len
* factor out initialization code of token_info
* make the condition of "mismatched indentations" warning easy to understand
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61796 b2dd03c8-39d4-4d8f-98ff-823... -
02:25 PM Revision ccf3a0d6 (git): parse.y (token_info_push, token_info_pop): Use code_location
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61795 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:25 PM Revision a1d6fba3 (git): suppress warning for VC12
- It says "warning C4146: unary minus operator applied
to unsigned type, result still unsigned"
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61794 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:22 PM Revision c4858f34 (git): parse.y: Remove unneeded dependence on pointer representatin
- A simple comparison is enough in this case
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61793 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:14 PM Revision 84012cd1 (git): merge revision: 61746
- `signed` is required for Rasbian (x86_64).
* tool/ruby_vm/views/_insn_stack_increase.erb: specify `signed` explicitly
for systems which use `unsigned` for `char` type.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61792 b2dd03c8... -
01:05 PM Revision 4b190c48 (git): Fix a typo.
- * template/unicode_norm_gen.tmpl: ouput -> output
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61791 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 09:31 AM Revision 3f059374 (git): sample/iseq_loader: use File.open instead of Kernel#open
- This makes auditing for inadvertant command execution
easier.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61790 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 09:31 AM Revision 6ef345ab (git): sample/iseq_loader.rb: spelling fix
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61789 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
09:07 AM Revision d675b9de (git): Fixed typos.
- * sample/trick2013/kinaba/remarks.markdown: algorthim -> algorithm
* sample/trick2015/ksk_1/remarks.markdown: Limination -> Limitation
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61788 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
08:38 AM Revision fbacf5fa (git): tool/ruby_vm support for pre-2.0 BASERUBY
- This was not requested :) but actually easier than the previous
so I just did it anyway.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61787 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
08:38 AM Revision 8a72c77c (git): tool/ruby_vm support for pre-2.1 BASERUBY
- as requested by devs, support for BASERUBY prior to 2.1
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61786 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
08:38 AM Revision 069e9ff5 (git): tool/ruby_vm support for pre-2.3 BASERUBY
- as requested by devs, support for BASERUBY prior to 2.3
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61785 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
08:38 AM Revision f6ea3763 (git): delete tool/instruction.rb (2nd try)
- Previous commit changed insns.def format. Now is the time for its
generators. In doing so I chose to modernize the system, not just
patch. My attempt includes
- extensive use of Onigumo regular expressions
- split from one big file (in... -
08:38 AM Revision 9456f88f (git): [ci skip] add comments about file format (2nd try)
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61783 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
08:38 AM Revision e2b7cb9d (git): new insns.def format (2nd try)
- - Gave up @j comments
- Room for sp_inc to be a proper grammer element
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61782 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:22 AM Feature #14340: [PATCH/RFC] exclude expensive MDNS test
- Thank you naruse!
-
12:16 AM Revision 7994269c (git): Add `103 Early Hints` to `Net::HTTP::STATUS_CODES` [ci skip]
- Update by `ruby lib/net/http/status.rb | sponge lib/net/http/status.rb`
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61781 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:16 AM Revision f4937c62 (git): doc/NEWS-2.5.0: `step` is not `Integer#step` but `Numeric#step` [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61780 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 12:15 AM Revision 99886a91 (git): thread.c (thread_cleanup_func): document small leak
- It's minor, I haven't analyzed how fixable it is, but we should
at least note it, here.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61779 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
01/11/2018
-
09:32 PM Feature #14197: `Enumerable#{select,reject}` accept a pattern argument
- I have personally found it useful to implement Regexp#to_proc as in https://bugs.ruby-lang.org/issues/7883 which permits collection.reject(&/re/) and more besides.
-
07:41 PM Revision afe296be (git): fix for IPv6 env
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61778 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
07:37 PM Revision 82a97145 (git): NEWS: Matrix#antisymmetric?
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61777 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 07:36 PM Revision aae7c645 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61776 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
07:36 PM Revision 3b51e3a1 (git): matrix.rb: add Matrix#antisymmetric?
- * lib/matrix.rb: add Matrix#antisymmetric?.
Proposed by Yilo (@yiloo). Patch by Marcus Stollsteimer (@stomar).
[Fix GH-1788]
* spec/ruby/library/matrix/antisymmetric_spec.rb: add specs.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/tr... -
06:26 PM Feature #14340 (Closed): [PATCH/RFC] exclude expensive MDNS test
- Applied in changeset trunk|r61774.
----------
Mock fetching data from real DNS [Feature #14340]
This test just tests MDNS#each_address method. -
06:26 PM Revision 9e677261 (git): Mock fetching data from real DNS [Feature #14340]
- This test just tests MDNS#each_address method.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61774 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
04:51 PM Feature #14336: Create new method String#symbol? and deprecate Symbol class
- Matz, if you don't mind, I'd like to give your questions a try:
>So, to persuade me, you have to answer following questions very clearly, concretely:
> ...
Serializing values to and from JSON is becoming a very very common operatio... -
03:35 PM Feature #14336: Create new method String#symbol? and deprecate Symbol class
- rosenfeld (Rodrigo Rosenfeld Rosas) wrote:
> Daniel, I have no ideas on why you got those impressions.
Nothing related to you Rodrigo. We are fine and I’m counting on you to provide me your feedback. ;-) -
03:16 PM Feature #14336: Create new method String#symbol? and deprecate Symbol class
- > Meanwhile all your feedback is more than welcome but if you show up just to rant me like many did in this discussion understand that I will not consider any of your lines in my exercise.
Daniel, I have no ideas on why you got those ... -
03:07 PM Feature #14336: Create new method String#symbol? and deprecate Symbol class
- matz (Yukihiro Matsumoto) wrote:
> Daniel, don't try to read my mind. I tried years ago because I wanted to experiment what others liked (yes, we had similar people like you since the old days).
Thanks for the clarification Matz. I... -
02:25 PM Feature #14336: Create new method String#symbol? and deprecate Symbol class
- Daniel, don't try to read my mind. I tried years ago because I wanted to experiment what others liked (yes, we had similar people like you since the old days). And so many of our tests, samples, and utilities were failed miserably. Durin...
-
09:18 AM Feature #14336: Create new method String#symbol? and deprecate Symbol class
- > doc/extension.rdoc should tell you what you need to know.
Thanks Eric.
> ...
as I'm willing to help you on this topic.
Hopefully someone will be able to answer one or two questions. :-)
> IMHO, the incompatibility is too bi... -
09:08 AM Feature #14336: Create new method String#symbol? and deprecate Symbol class
- danieldasilvaferreira@gmail.com wrote:
> I will say it again that I expect someone from the core team
> to work closely with me as a mentor. Until the day that person
> exists I will work by myself and this is a commitment.
doc/ex... -
08:23 AM Feature #14336: Create new method String#symbol? and deprecate Symbol class
- we might talk about the different size of RString and RSymbol struct in MRI
or why Strings bigger than 23 characters are different than < 23 ones -
07:55 AM Feature #14336: Create new method String#symbol? and deprecate Symbol class
- The fact that in Smalltalk Symbol is a subclass of String makes perfect sense.
It is key in the discussion we are having.
Why did Matz tried to unify symbols and strings pior to ruby 1.9?
Because it made sense to do so. The attempt... -
02:10 AM Feature #14336: Create new method String#symbol? and deprecate Symbol class
- Thank you for confirming, Daniel. Indeed it seems the confusion would be about the same except that it seems symbols are seldom used in Smalltalk from what I've read in this thread. But it's good to know that Ruby and Smalltalk symbols v...
- 03:54 PM Revision ddb79963 (git): * 2018-01-12
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61773 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:54 PM Revision 35b2038e (git): parse.y: Remove LEXPOP hack
- cmdarg_stack became inconsistent state due to look-ahead, and LEXPOP
hack smoothed over the inconsistency.
This commit fixes the inconsisitent state itself, and removes LEXPOP
hack.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@617... -
03:08 PM Feature #14352 (Closed): Array#pack("M") Quoted-Printable with binary mode
- 英語で書こうと思ったのですが、うまく伝えられないかもしれないので日本語で書かせてください。すみません。
mail libraryというgemを使ってメールをパースしたり、書きだしたりしているのですが、
Quoted-Printableでエンコードされたバイナリがメールに含まれていた場合に、メールを破壊する
可能性があるということが分かりました。
調査してみると、RubyのArray#Pack("M")を使ったときに、以下のように
\rは=0Dに変換して... -
01:56 PM Revision fda5e85e (git): Fix a typo [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61771 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:56 PM Revision cf6f7292 (git): Fix indent and use as skipped message instead of comment
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61770 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:42 PM Revision 69c8feb2 (git): parse.y: disentangle the lexer handling of ')', ']', and '}'
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61769 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:42 PM Revision f2bffa16 (git): parse.y: simplify and add a comment for paren_nest and lpar_beg
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61768 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:01 PM Feature #14328: SIMD vectorization
- I had tried to use SIMD in some parts.
But its performance improvement is limited.
Of course it can improve performance so much, but it is only in special use cases.
In usual Ruby handles small data and they can't ignore SIMD overhe... -
12:58 PM Feature #14316: Update Status Code classes
- > I wonder if we should slowly move towards using classes based on
> ...
I think `Net::HTTP::STATUS_CODES` is added for such purpose.
https://bugs.ruby-lang.org/issues/12935 -
08:34 AM Revision 64be4cfb (git): iseq.c: child iseq encoding
- * iseq.c (iseq_inspect): preserve the encoding of child iseqs.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61767 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
08:26 AM Bug #14350 (Closed): Strange behavior for Array.min in ruby 2.5.0
- Applied in changeset trunk|r61766.
----------
vm_insnhelper.c: search in the indexing order
* vm_insnhelper.c (vm_opt_newarray_max, vm_opt_newarray_min):
search in the indexing order, as well as usual methods.
[ruby-core:84821] [Bu... -
08:20 AM Bug #14350: Strange behavior for Array.min in ruby 2.5.0
- `1` is not greater than `1.0`, and vice versa.
The both results are correct in this case.
But the previous behavior may be better in the case of `Numeric`-like objects.
-
01:11 AM Bug #14350: Strange behavior for Array.min in ruby 2.5.0
- I doubt if this behavioural change is a bug that should be fixed.
-
08:26 AM Revision 83ac2dfe (git): vm_insnhelper.c: search in the indexing order
- * vm_insnhelper.c (vm_opt_newarray_max, vm_opt_newarray_min):
search in the indexing order, as well as usual methods.
[ruby-core:84821] [Bug #14350]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61766 b2dd03c8-39d4-4d8f-98ff-823... -
04:25 AM Revision f41b4b1b (git): parse.y: add a simple comment for COND_* and CMDARG_*
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61765 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:23 AM Revision 5ab288f5 (git): parse.y (local_push_gen): Rewrite the condition of "unused var" warning
- It was unnecessarily too complex, IMO.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61764 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
01/10/2018
-
07:36 PM Bug #14349: Fix Net::HTTP documentation around connection reuse
- rohitpaulk@gmail.com wrote:
> From [Net::HTTP's docs](http://ruby-doc.org/stdlib-2.5.0/libdoc/net/http/rdoc/Net/HTTP.html#class-Net::HTTP-label-How+to+use+Net-3A-3AHTTP):
> > If you wish to re-use a connection across multiple HTTP
... -
06:35 PM Bug #14349: Fix Net::HTTP documentation around connection reuse
- I think this is a bad idea. If you do:
~~~ ruby
http = Net::HTTP.new('httpbin.org', 80)
http.get("/")
~~~
then it doesn't close the connection when making the GET request, and that's a bad thing. This breaks backwards compatibi... -
05:37 PM Bug #14349: Fix Net::HTTP documentation around connection reuse
- > This happens because when start is called without a block and a connection doesn't exist, it proxies to a call with a block.
Oops, this should've read: "When request is called and a connection doesn't exist, it proxies to a `start` ... -
05:34 PM Bug #14349 (Closed): Fix Net::HTTP documentation around connection reuse
- From [Net::HTTP's docs](http://ruby-doc.org/stdlib-2.5.0/libdoc/net/http/rdoc/Net/HTTP.html#class-Net::HTTP-label-How+to+use+Net-3A-3AHTTP):
> ::start immediately creates a connection to an HTTP server which is kept open for the dura... -
06:53 PM Bug #14350 (Closed): Strange behavior for Array.min in ruby 2.5.0
- 2.4.2
~~~ ruby
[[1, 0.0].max, 1.0].min
=> 1
~~~
2.5.0
~~~ ruby
[[1, 0.0].max, 1.0].min
=> 1.0
[[1, 0.0].max, 1.0]
=> [1, 1.0]
[1, 1.0].min
=> 1
~~~
I think it`s regression for ruby 2.5.0 -
06:22 PM Feature #14344: refine at class level
- I was proposing the former, which would be to have `refine` be a class method that would effectively be the same as `using` with an anonymous module. I get what you're saying about it being different between a class and a module but I'm ...
-
06:05 PM Feature #14344: refine at class level
- kddeisz (Kevin Deisz) wrote:
> Just to take a real example from my current application, here's a job (from Rails ActiveJob) that I want to refine by moving the logic into the class in which it belongs. It currently looks like this:
T... -
04:05 PM Feature #14344: refine at class level
- Just to take a real example from my current application, here's a job (from Rails ActiveJob) that I want to refine by moving the logic into the class in which it belongs. It currently looks like this:
~~~ruby
class EventEndActionsJob... -
06:00 PM Feature #14336: Create new method String#symbol? and deprecate Symbol class
- Rodrigo they are indeed different objects and they convert between each other like in ruby.
See:
* https://www.gnu.org/software/smalltalk/manual-base/html_node/String_002dconverting.html#String_002dconverting
* https://www.gnu.org... -
01:48 PM Feature #14336: Create new method String#symbol? and deprecate Symbol class
- Hi Daniel, I've read your previous comment, but I also read this from Bill Kelly:
> Smalltalk's hash (dictionary) does indeed allow both symbols and strings
as keys (and the language differentiates between them as Ruby does.)
I've... -
11:15 AM Feature #14336: Create new method String#symbol? and deprecate Symbol class
- rosenfeld (Rodrigo Rosenfeld Rosas) wrote:
> Is it possible to generate a symbol from a string in SmallTalk, such as Ruby's 'string'.to_sym?
Symbol is a subclass of String in Smalltalk. See one of my previous comments.
> ...
The... -
10:42 AM Feature #14336: Create new method String#symbol? and deprecate Symbol class
- Thanks for the explanation on SmallTalk symbols, Bill and Daniel.
It seems to be that symbols are seldom used in SmallTalk while they are often used in Ruby applications, which might explain why SmallTalk users might not complain that... -
07:33 AM Feature #14336: Create new method String#symbol? and deprecate Symbol class
- Thank you very much Matz.
I don’t mind to give my time on that task. For a long time I’ve been willing to contribute to ruby core but my professional contracts didn’t allow me.
Today I believe the situation is about to change.
I wil... -
06:58 AM Feature #14336: Create new method String#symbol? and deprecate Symbol class
- In the early stage of Ruby1.9 development, I tried to unify strings and symbols, first by making Symbol class compatible with String class. But so many existing Ruby programs failed to run. So I gave up. If we would unify strings and sym...
- 03:44 PM Revision e3d7bc60 (git): * 2018-01-11
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61763 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:44 PM Revision 35e63127 (git): tool/downloader.rb: retry against Errno::ETIMEDOUT
- instead of Errno::ECONNREFUSED.
As I commented in r61498, at that moment I was not sure if the actual
exception is really `Errno::ECONNREFUSED` or not.
In https://ci.appveyor.com/project/ruby/ruby/build/1.0.6974, I could
confirm that t... -
02:17 PM Feature #13604: Exposing alternative interface of readline
- any update on this?
-
02:13 PM Revision 9c650ee3 (git): Fix typos.
- * doc/contributors.rdoc: pathces -> patches.
* doc/syntax/refinements.rdoc: exmaple -> example.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61761 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:51 PM Feature #13179: Deep Hash Update Method
- bettisworth (wurde _) wrote:
> I came across a scenario where I needed the ability to update a deeply nested hash (Rails i18n yaml files). This seemed like something that would exist naturally in the DSL of ruby, but I could only find d... -
01:30 PM Revision 205f0dcf (git): spec/: skip some specs so that no failure occurs in root privilege
- Follow up of r61757, This change makes `sudo make test-spec` pass on my
machine.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61760 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:30 PM Revision 5d0103f9 (git): spec/ruby/library/etc/getlogin_spec.rb: Use `logname` as an expected result
- It had used `id -un`, but it is not always equal to `Etc.getlogin`.
`id` returns the current user of the process, and `Etc.getlogin` returns
the user name logged in on the controlling terminal of the process.
This change uses `logname` ... -
01:24 PM Feature #14340: [PATCH/RFC] exclude expensive MDNS test
- I get no results on my mac too.
So I think it is expected behavior in network without requested resources.
```
% time ruby test.rb
real:0.20s user:0.13s sys:0.03s cpu:80% mem:0+0k 0pf+0w IO:0+0 ruby test.rb
```
And I get ... -
11:34 AM Feature #14348 (Open): win32ole: enable using coclass-es with multiple IDispatch implementations
- Currently win32ole requires coclass to directly implement (one) IDispatch. That
works fine for
```
coclass Good {
[default] interface GoodIface2;
interface GoodIface1;
};
interface GoodIface1 : IDispatch {
// snip
};
i... -
10:39 AM Revision b496220a (git): skip some tests so that no failure occurs in root privilege
- Some tests had failed on `sudo make test-all`, mainly because root can
access any files regardless of permission. This change adds `skip`
guards into such tests.
Note that almost all tests in which `skip` guards is added, already have
... -
09:48 AM Bug #13628: rdoc json.gz files differ across builds
- I reviewed this at upstream:
https://github.com/ruby/rdoc/pull/569
@bmwiedemann Please check the upstream issue. -
09:36 AM Bug #13627: created.rid prevents reproducible builds
- This is adopted at upstream:
https://github.com/ruby/rdoc/pull/570
@hsbt Please close this. -
08:27 AM Feature #14347: Explain How Symbols Differ From Strings in Symbol's Rdoc
- Yay for better documentation. \o/
-
05:14 AM Feature #14347: Explain How Symbols Differ From Strings in Symbol's Rdoc
- duerst (Martin Dürst) wrote:
> Thanks, great idea. Just a small point: There should be at least a pointer, or some parallel explanation, in the documentation on String.
I agree. Attached is a new patch that modifies the Rdoc for bot... -
05:03 AM Feature #14347: Explain How Symbols Differ From Strings in Symbol's Rdoc
- dsferreira (Daniel Ferreira) wrote:
> Thanks Jeremy for this patch.
> ...
I don't think there is ruby-specific context here, the standard computing definition applies ("name that identifies either a unique object or a unique class of o... -
04:56 AM Feature #14347: Explain How Symbols Differ From Strings in Symbol's Rdoc
- jeremyevans0 (Jeremy Evans) wrote:
> This adds more detail to Symbol's RDoc, explaining how symbols differ from strings, and giving examples showing how ruby returns symbols for internal identifiers.
Thanks, great idea. Just a small ... -
04:07 AM Feature #14347: Explain How Symbols Differ From Strings in Symbol's Rdoc
- Thanks Jeremy for this patch.
Could we add to the documentation the definition of identifier in ruby land?
Examples of good usage of symbols would be helpful as well.
This piece could also be extended for the hash in order to sp... -
03:04 AM Feature #14347 (Closed): Explain How Symbols Differ From Strings in Symbol's Rdoc
- This adds more detail to Symbol's RDoc, explaining how symbols differ from strings, and giving examples showing how ruby returns symbols for internal identifiers.
-
07:06 AM Feature #14277 (Rejected): Improve strings vs symbols ambiguity
- I didn't reject this proposal because I wanted to keep the place you can express why you want to unify them. As I stated https://bugs.ruby-lang.org/issues/14336#note-16 strings and symbols are two totally different things. Some Ruby user...
-
05:58 AM Bug #10643: 2.2: TestRubyOptions#test_command_line_progname_nonascii test failure (MinGW)
- @nagachika,
Sorry for not reporting more. I think this issue was fixed sometime around 01-June, but I'm not totally sure, which was why I thought I'd look into it further.
Here's what I found from my saved builds:
```
TestRuby... -
05:07 AM Bug #10643 (Closed): 2.2: TestRubyOptions#test_command_line_progname_nonascii test failure (MinGW)
- Thank you MSP-Greg,
So the issue was fixed on trunk during 2.5.0 development.
I have to find which revisions fixed this failure.
I roughly seek related revisions and found r58767.
But I don't have environment to confirm the resul... -
05:57 AM Revision 0542d61e (git): iseq.c: Succinct bitvector now supports 32-bit machine
- Second try of succinct bitvector.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61757 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 03:54 AM Revision b8757110 (git): should cause preprocess error as other cases
- * string.c (NONASCII_MASK): should cause preprocess error immediately if the
compiler does not satisfy our assumptions.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61756 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:00 AM Bug #14264: RDoc comment of warn does not mention uplevel:
- Here's a patch that adds documentation of uplevel keyword to Kernel#warn.
-
02:40 AM Bug #14261: invalid syntax segfaults: "x, true"
- git bisect tell me that the SEGV was introduced by r60829 (https://github.com/ruby/ruby/commit/28d00c2fb2949c67f9510d61c41ad58047c4ab01).
After some exploration with debugger, it's obvious that the SEGV occured because `item` is NULL in... -
01:53 AM Revision 5ad95486 (git): merge revisions 61753:61750 61747:61740 61737:61728
- Revert all the VM generator rewrites; requested by naruse
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61755 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:12 AM Bug #14234: Failed to build on CentOS 6.9
- ewaters (Evan Waters) wrote:
> Do we know when the next version of ruby is likely to be released, and if it will include this patch? I'm trying to build ruby 2.5.0 for CentOS 6 and running into this same issue.
There are good news an... -
01:07 AM Bug #14346 (Closed): [PATCH] dir.c: pass flags to openat(2) correctly - Applied in changeset trunk|r61754.
----------
dir.c: pass flags to openat(2) correctly
Flags are 3rd argument of openat(2) while the 4th argument
(mode_t) is unnecessary for our uses. This bug exists since
Ruby 2.5 from r58860 and was... -
01:06 AM Bug #14346 (Closed): [PATCH] dir.c: pass flags to openat(2) correctly
- dir.c: pass flags to openat(2) correctly
Flags are 3rd argument of openat(2) while the 4th argument
(mode_t) is unnecessary for our uses. This bug exists since
Ruby 2.5 from r58860 and was discoverd by strace.
* dir.c (nogvl_ope... - 01:07 AM Revision 7c7d47d2 (git): dir.c: pass flags to openat(2) correctly
- Flags are 3rd argument of openat(2) while the 4th argument
(mode_t) is unnecessary for our uses. This bug exists since
Ruby 2.5 from r58860 and was discoverd by strace.
* dir.c (nogvl_opendir_at): use openat correctly
[Feature #13056... - 01:00 AM Revision 60a1dcea (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61753 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:00 AM Revision 2340d5e7 (git): Fixed typos.
- * tool/ruby_vm/loaders/opt_operand_def.rb: grammer -> grammar
* tool/ruby_vm/scripts/insns2vm.rb: beginnig -> beginning
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61752 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:12 AM Bug #14345 (Closed): http_proxy setting should respect both parent domain and subdomain
- When a ruby app is run in an environment where an http proxy is configured, it is not possible to provide separate settings for both a domain and it's subdomain for outbound http calls. This coupling assumes that both should follow the s...
-
12:01 AM Revision a3ecb0f8 (git): Fix a typo [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61751 b2dd03c8-39d4-4d8f-98ff-823fe69b080e