Activity
From 12/13/2017 to 12/19/2017
12/19/2017
-
05:09 PM Revision b37fc5aa (git): skip test_aspawn_too_long_path on Solaris 10 or earlier
- * test/ruby/test_process.rb (TestProcess#test_aspawn_too_long_path):
skip test_aspawn_too_long_path on Solaris 10 or earlier versions
because they lack Process::RLIMIT_NPROC and the test creates
extraordinary number of processes th... -
- Applied in changeset trunk|r61344.
----------
Workaround for optimization bug of Oracle Developer Studio 12.4-12.6
* pack.c (pack_unpack, AVOID_CC_BUG): Very ugly workaround for
optimization bug of Oracle Developer Studio (Oracle Sol... -
- Reopen because this is also observed with Oracle Developer Studio 12.6.
-
- * pack.c (pack_unpack, AVOID_CC_BUG): Very ugly workaround for
optimization bug of Oracle Developer Studio (Oracle Solaris Studio)
12.4, 12.5, and 12.6 on Solaris 10 with -xO4 optimization option.
[Bug #11684] [ruby-core:84351]
g... -
03:42 PM Bug #14171: can't alloc thread (ThreadError) in DRbServer#main_loop
- I also applied @seki's fix in r61342.
- 03:40 PM Revision 8c34a8a1 (git): * 2017-12-20
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61343 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * Patch by @seki:
https://gist.github.com/seki/ae8bef20238c37c94a91b5461c4bfbdd
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61342 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:37 PM Bug #14206 (Closed): Null-byte ignored inside class/module/method bodies
- I would have expected the following code to not be accepted by the Ruby parser, but instead it acts as if the zero-byte wasn't part of the string.
~~~ ruby
eval("def m\n\0end")
~~~
Changing to a block to start with begin
~~~ r... -
02:26 PM Bug #14203 (Closed): miniruby crashes just after r61309 on mswin CI
- Applied in changeset trunk|r61341.
----------
Revert "Improve performance of creating Hash object"
This reverts commit r61309
Because it was unstable on mswin CI.
[ruby-dev:50370][Bug #14203] -
- 調査が難しそうなので、いったん r61309 は revert しておきます。お騒がせしました。
-
09:38 AM Bug #14203 (Assigned): miniruby crashes just after r61309 on mswin CI
-
- r61309 のマージ後、mswin CIで、minirubyがクラッシュするようになっています。
http://mswinci.japaneast.cloudapp.azure.com/vc12-x64/ruby-trunk/recent.html
手元で再現できてないので残念ながらまだ詳細はわかりませんが、とにかくヤバそうということで。 -
- This reverts commit r61309
Because it was unstable on mswin CI.
[ruby-dev:50370][Bug #14203]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61341 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:28 PM Revision 26529d3d (git): Update version number of Psych
- From: SHIBATA Hiroshi <hsbt@ruby-lang.org>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61340 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- From: SHIBATA Hiroshi <hsbt@ruby-lang.org>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61339 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:20 PM Revision d20f4eb1 (git): st.c: fix up
- * st.c (_st_table_list, _st_table_pool): symbols beginning with an
underscore and a lower letter are preserved by the standard.
* st.c (get_st_table): protoized.
* st.c (st_insert_generic): adjust local variable type to an
argument... -
- * thread_sync.c (define_thread_class): hide rb_define_class_under
from rdoc, so that fake code to teach rdoc takes effect.
* thread_sync.c (Init_thread_sync): teach rdoc Mutex.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61337 ... -
10:08 AM Bug #14205: Unsanitizied filename leads to command injection in 'resolv.rb'
- PoC Concept Code
~~~ ruby
require 'resolv'
a = Resolv::Hosts::new("|echo 1 > /tmp/rce")
a.getaddress("test")
~~~
-
- Here is the pull request
https://github.com/ruby/ruby/pull/1777 -
- It version changed fallback option to keywoad argument
on `Yaml.load` method. It break backword compatiblity.
see detailed discuttion: https://github.com/ruby/psych/issues/340
From: SHIBATA Hiroshi <hsbt@ruby-lang.org>
git-svn-id:... -
07:49 AM Bug #14204 (Closed): [PATCH] socket: use frozen string buffer when releasing GVL
- ```
socket: use frozen string buffer when releasing GVL
Using a non-frozen string buffer when GVL is released is
dangerous because another thread may modify that buffer.
This may lead to the contents of an invalid pointer being
wr... -
- I updated gemspec at r61333.
But I couldn't ship strscan gem to rubygems.org:
https://github.com/rubygems/rubygems.org/pull/1696
If above pull request is not handled until Ruby 2.5 release, I will release strscan-1.0.0 in next y... -
06:57 AM Bug #14023: SyntaxError on array argument and block
- https://bugs.ruby-lang.org/projects/ruby-trunk/repository/revisions/19197
Matz's intention is very clear that this kind of expression shall render syntax errors. -
- * error.c (key_err_receiver, key_err_key): [DOC] documents of
KeyError methods.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61335 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * tool/vcs.rb (VCS::GIT#commit): no --add-author-from option if
author equals committer.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61334 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- But we couldn't ship strscan (and stringio) gem. Because rubygems.org
still masked them.
https://github.com/rubygems/rubygems.org/pull/1696
I'm going to ship them after it deployed.
From: SHIBATA Hiroshi <hsbt@ruby-lang.org>
gi... -
- It needs to support header file installation and uninstallation.
But current RubyGems didn't support it feature yet.
From: SHIBATA Hiroshi <hsbt@ruby-lang.org>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61332 b2dd03c8-39d4-4d8... -
- * compile.c (compile_array): pop splat result without creating a
new hash if the whole hash is popped.
[ruby-core:84340] [Bug #14201]
From: Nobuyoshi Nakada <nobu@ruby-lang.org>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@613... -
- When doing the difference of a small array with a big one it is not
efficient in both time and memory to convert the second one to a hash.
From: Ana María Martínez Gómez <ammartinez@suse.de>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/... -
- Applied in changeset trunk|r61329.
----------
compile.c: side effect in splat
* compile.c (compile_array): splat which may have side effects
should be compiled even if the result will be popped.
[ruby-core:84340] [Bug #14201]
From... -
- * compile.c (compile_array): splat which may have side effects
should be compiled even if the result will be popped.
[ruby-core:84340] [Bug #14201]
From: Nobuyoshi Nakada <nobu@ruby-lang.org>
git-svn-id: svn+ssh://ci.ruby-lang.org/... -
12:30 AM Bug #13670: [BUG] Bus Error at 0xefce7b (armv7l) (ruby 2.3.4p301)
- Can confirm this occurs with 2.4.1, just install bootsnap and try and launch a rails application.
Tested on a H3 (armv7l) -
-
- `system` also accepts redirections.
And child processes inherit STDIN/STDOUT/STDERR from their parent process by the default, you don't need such arguments at all usually.
If you want to capture the outputs and the errors, `IO.popen(%w...
12/18/2017
-
08:54 PM Bug #14202 (Closed): gem install rails fails
- When running 'gem install rails' I get the attached error and printed core dump.
-
08:27 PM Bug #14201 (Closed): Regression due to over optimization of hash splat
- The following doesn't print anything nor raise anything in 2.5.0-rc1 or trunk:
```
$ ruby -e "{**puts('hello')}; 42"
```
It should be the same as in Ruby 2.0-2.4:
```
hello
-e:1:in `<main>': no implicit conversion of nil into ... -
06:01 PM Bug #14198: Error forwarding standard input to subprocess
- Using `Process.spawn` indeed works :) Unfortunately, I cannot figure out a way to forward the standard output and standard error to the console (i.e, STDOUT and STDERR) as well as storing that output in a variable.
The example in `tes... -
- I din't have a windows machine right now so not sure this is the solution for you. But JFYI you can reroute the IOs by specifying arguments to spawn like this:
```ruby
def exec(cmd)
pid = Process.spawn(cmd, in: STDIN, out: STDOUT... -
- I am developing a wrapper for Terraform (https://www.terraform.io/), which at some point during its execution, it may request user input. So, my application must forward everything typed on its stdin to the subprocess' stdin. The followi...
-
04:52 PM Bug #14073: Crash on boot sice Ruby 2.4.0
- ruby_2_4 r61328 merged revision(s) 59748.
-
- st.c: fix num_entries
* st.c (st_insert2): should manage num_entries when the key is
undefined, as well as st_insert().
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@61328 b2dd03c8-39d4-4d8f-98ff-823fe... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61327 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Applied in changeset trunk|r61326.
----------
Support C89 if possible
* addr2line.c: Because stdbool.h is a C99 feature, compile error
occurs with some old compilers without specifying C99 options.
Fix compile error with Oracle Sol... -
- r60841 にて、 addr2line.c では stdbool.h を使用するようになりましたが、
stdbool.h は C99 にて追加された仕様のため、
デフォルトが C89 になっている Solaris 10 上の古めのコンパイラの多くでは、
Solarisの標準ヘッダファイルに含まれるC標準バージョンチェックを通過できず、
以下のようなエラーになり、コンパイルに失敗します。
~~~
cc -errtags=yes -xO4 -xtarge... -
- * addr2line.c: Because stdbool.h is a C99 feature, compile error
occurs with some old compilers without specifying C99 options.
Fix compile error with Oracle Solaris Studio 12.4 on Solaris 10.
[Bug #14200] [ruby-dev:50366]
* missi... -
- とりあえず、ここ(redmine)で該当リビジョンを表示し、「関連するチケット」の「追加」をしてやれば、ここでの見た目上だけは、なんかうまくやったように誤魔化すことができます :)
(なお将来バックポートが必要とかになったときにメンテナが助かるので割と推奨) -
- Applied in changeset r61324
しかし、svnのコミットログに `[Bug #14199] [ruby-dev:50365]` を含めるのをうっかり忘れていました。 -
- おそらく r61154 以降、Solaris 10 上の Oracle Solaris Studio 12.4 にて、
下記のエラーにより eval.c のコンパイルに失敗します。
write_warn, write_warn2, write_warn_str の各マクロ定義中にて、
三項演算子「? :」の右側の2項（「AAA ? BBB : CCC」の BBB と CCC）の型が不統一、
具体的には void型を返す関数 と VALUE型を返す関数が混在し... - 03:46 PM Revision 5a2a9577 (git): * 2017-12-19
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61325 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * eval_error.c (write_warn, write_warn2, write_warn_str): Fix compile
error "operands have incompatible types" with Oracle Solaris Studio
12.4 on Solaris 10.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61324 b2dd03c8-39d4-4d8... -
03:27 PM Bug #13358: OpenStruct overriding allocate
- Any chance this could be backported to ruby 2.3? It's creating issues because we're loading OpenStruct from the database and Ruby 2.4 is still several months ahead for this project.
-
03:04 PM Feature #9992: Access Modifiers (Internal Interfaces)
- Sorry. The previous code was with a bug. I corrected it but here it is again:
What about this use case:
~~~ruby
module Foo; end
##
# Template class
#
# ==== Example
#
# Foo::SubClass.run(:arg1)
# ... -
- What about this use case:
~~~ruby
module Foo; end
##
# Template class
#
# ==== Example
#
# Foo::SubClass.run(:arg1)
# #=> ...
class Foo::Base
def initialize(arg)
@arg = arg
end
... -
12:42 PM Feature #14197 (Open): `Enumerable#{select,reject}` accept a pattern argument
- `#all?`, `#any?`, `#none?`, and `#one?` accept pattern arguments since 2.5.0.
`#grep`, and `#grep_v` have such feature, but it is hard for me to remember them since I would be thinking of using `#select`, or `#reject`, and `#select` a... -
-
09:11 AM Bug #14192: rb_frame_method_id_and_class not exported, breaks ruby-prof and other gems
- Assuming the method gets removed with 2.6, how should we replace it?
Can it be replaced now?
I haven't found a replacement for it. -
- Greg.mpls@gmail.com wrote:
> I tried the attached patch to remove the :uplevel parameter
> for ruby < 2.5, and it passed on Appveyor & Travis for Ruby
> 2.4. Assumes 2.10 never exists. Most Ruby 2.3 versions had
> one failure.
... -
08:54 AM Bug #14189 (Closed): Webrick 1.4.0. release requires unreleased ruby version 2.5.0dev - Applied in changeset trunk|r61322.
----------
webrick 1.4.1 release
* lib/webrick/version.rb: bump version
* lib/webrick/webrick.gemspec: support Ruby 2.3+
[Bug #14189] -
- hsbt@ruby-lang.org wrote:
> Issue #14189 has been updated by hsbt (Hiroshi SHIBATA).
>
> Status changed from Open to Assigned
> Assignee changed from hsbt (Hiroshi SHIBATA) to normalperson (Eric Wong)
>
> >Personally, I do not l... -
- >Personally, I do not like version guards, either.
A current implementation of webrick works with Ruby 2.3/2.4
https://api.travis-ci.org/v3/job/317931661/log.txt
But `lib/webrick/util.rb` is not supported Ruby 2.2. So, We could ... -
09:03 AM Revision 027b576b (git): suppress warning: 'const' attribute on function returning 'void'
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61323 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 08:54 AM Revision 74ceabb3 (git): webrick 1.4.1 release
- * lib/webrick/version.rb: bump version
* lib/webrick/webrick.gemspec: support Ruby 2.3+
[Bug #14189]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61322 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/ruby/test_io.rb (test_read_command): unusable character
causes Errno::EINVAL on Windows.
From: Nobuyoshi Nakada <nobu@ruby-lang.org>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61321 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * io.c (rb_io_open_generic): try to open the named file as usual,
if klass is not IO nor File, so that Errno::ENOENT will be
raised probably. calling on File will be same in the future.
From: Nobuyoshi Nakada <nobu@ruby-lang.org>
... -
- * io.c (rb_io_s_binread): fix r61317, unintentional change.
From: Nobuyoshi Nakada <nobu@ruby-lang.org>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61319 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Closing. Thanks anyway!
-
06:08 AM Bug #14196: Signal.trap overrides pre-existing "SIG_IGN" handler on a process
- shyouhei (Shyouhei Urabe) wrote:
> shayonj (Shayon Mukherjee) wrote:
> ...
Thanks! I realize that `Signal.trap` returns the previously set handler, though I didn't realize, we don't wish to preserve the previously set handler. I guess ... -
- shayonj (Shayon Mukherjee) wrote:
> I believe, if a process already has a `SIG_IGN` then the same should be respected/restore.
I don't think so. Signal handlers are per-prorcess global resources. If a program decides to set one, th... -
- Came across while debugging an issue with bundler https://github.com/bundler/bundler/issues/6150
The issue is, if a process already has a `SIG_IGN` / `IGNORE` present on it, then doing a `Signal.trap` overrides the handler on the same... -
05:15 AM Feature #14187: `make test` and `make check` to run all test suites
- I think it would be good to have a table for this proposal, with three columns:
1) What is tested
2) What is the target name currently
3) What is the proposed new target name
That will be much easier to understand than a lengthy desc... -
- nobu (Nobuyoshi Nakada) wrote:
> There would be old Makefile, remove it and retry.
I removed the Makefile. When I used my usual make command (make up unicode-up install-nodoc runnable), I got the following error:
```
GNUmakefile:... -
04:42 AM Revision c740951f (git): check EOPNOTSUPP.
- * test/ruby/test_file.rb (test_open_tempfile_path): skip EOPNOTSUPP
(observed on Ubuntu 16 on Docker).
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61318 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * io.c (rb_io_open_generic): when external command will be invoked
as other than IO singleton method, probably unintentionally,
warn if it is File or raise ArgumentError.
From: Nobuyoshi Nakada <nobu@ruby-lang.org>
git-svn-id: svn+... -
- * test/lib/envutil.rb (verbose_warning): flush is called on STDOUT
and STDERR sometimes.
From: Nobuyoshi Nakada <nobu@ruby-lang.org>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61316 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- From: Nobuyoshi Nakada <nobu@ruby-lang.org>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61315 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * io.c (open_key_args): open by rb_io_open always also when
open_args: option is given.
From: Nobuyoshi Nakada <nobu@ruby-lang.org>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61314 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:57 AM Bug #14191: Coverage decreased between 2.4.3 and 2.5.0rc1
- I have just fixed the issue. I'd appreciate if you could try r61313 and tell me if the coverage is measured correctly.
Your report was *really* helpful. Thank you very much! -
- Applied in changeset trunk|r61313.
----------
iseq.c (finish_iseq_build): fix coverage leakage [Bug #14191]
Before this change, coverage.so had failed to measure some multiple-line
code fragments. This is because removing trace instru... -
- Before this change, coverage.so had failed to measure some multiple-line
code fragments. This is because removing trace instructions (#14104)
changed TracePoint's lineno (new lineno), and coverage counter array was
based on old lineno.
... -
- From: Nobuyoshi Nakada <nobu@ruby-lang.org>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61312 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61311 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- - Followup of https://bugs.ruby-lang.org/issues/14123
From: Prathamesh Sonpatki <csonpatki@gmail.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61310 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r61309.
----------
Improve performance of creating Hash object
When generate Hash object, the heap area of st_table will be always allocated in internally
and seems it take a time.
To improve performance of ... -
- watson1978 (Shizuo Fujita) wrote:
> > Any chances you tried --with-jemalloc ? It might perhaps exhibit something different.
> ...
Thank you! The patch seems perfect except one thing... ccan/list is already included in ccan/list/list.h... -
- When generate Hash object, the heap area of st_table will be always allocated in internally
and seems it take a time.
To improve performance of creating Hash object,
this patch will reduce count of allocating heap areas for st_table by ... -
- I think this is a feature but a bug.
https://github.com/nobu/ruby/tree/feature/13129-refine-method_missing -
12:35 AM Feature #8257: Exception#cause to carry originating exception along with new one
- Is there a reason not to do caused-by stack trace printing? Or has it just not been implemented by anyone yet?
-
- moskkitow (Marcelo Cruz) wrote:
> shyouhei (Shyouhei Urabe) wrote:
> ...
Yes please. That is exactly what I meant.
12/17/2017
-
- normalperson@yhbt.net wrote:
> I think some ext/socket methods (sendmsg, setsockopt) may need this, too;
> and fcntl/ioctl/getsockopt will need locktmp for strings...
N/M, *sockopt do not; but I think others do.
Will work on it la... -
- Since we release GVL, we must freeze a duplicate the string buffer
to prevent other threads from modifying our buffer while we
are waiting on pwrite(2).
* io.c (rb_io_pwrite): use_rb_str_tmp_frozen_{acquire/release}
Trivial bug... - 06:43 PM Revision 73da429c (git): `BASERUBY` may be not available when building from tarball
- * common.mk ($(REVISION_H)): revert a part of r61055 because this obstructs
building ruby from tarball in clean (no ruby) environment.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61308 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- When writing specs, I discovered that coercion was failing for allbits.
I modified all three methods to apply coercion with `to_int` if needed. - 06:19 PM Revision ae1d6cdd (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61307 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 06:19 PM Revision 22ee6b2c (git): * 2017-12-18
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61306 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 06:19 PM Revision 907508b2 (git): Integer#{any|all|no}_bits: Fix coercion. Add specs [#12753]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61305 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
05:36 PM Bug #14194 (Closed): --enable-frozen-string-literal ruby runner.rb cgi
- Assuming `--enable-frozen-string-literal`, `ruby runner.rb cgi`
Running without patch:
```
1) Failure:
CGIMultipartTest#test_cgi_multipart_without_tempfile [E:/GitHub/ruby/test/cgi/test_cgi_multipart.rb:353]:
1. [2/2] Assert... -
04:51 PM Bug #14193: --enable-frozen-string-literal and rubygems, erb, & rdoc
- > I'd certainly appreciate it if someone familiar with RDoc had a look, as it seems that both its code and its tests may need changes/additions.
I believe RDoc upstream is https://github.com/ruby/rdoc and it's just copied from that pl... -
-
- k0kubun (Takashi Kokubun) wrote:
> > frozen_erb.patch
> ...
You're right; I was a bit frustrated while working on it, as some work has been done in Rdoc with frozen strings.
> While it's hard to understand the actual cause of the ... -
- > frozen_erb.patch
Thank you for your work to fix it, but I'm strongly against silently suppressing all StandardError exceptions. That makes very hard to find bugs other than ones you expected.
Also, note that frozen_string_literal... -
03:02 PM Feature #14142: Add Method#===
- 返信が遅れてしまいましたが、ありがとうございました。
-
- * common.mk (exts-note): show notes of non-configured extension
libraries.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61304 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * thread.c (timeval_add): adjusted indent and parenthesized in
braces.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61303 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- nobu@ruby-lang.org wrote:
> LGTM, and `timeval_add()` and `timeval_update_expire()` seem
> to worth extracting first.
Thanks for the review and you're right; they're not needed in
the final patch to fix the problem, I did not need... -
- LGTM, and `timeval_add()` and `timeval_update_expire()` seem to worth extracting first.
- 08:26 AM Revision db9523ef (git): thread.c: fix overly long Thread#join w/ timeout
- * test/ruby/test_thread.rb (test_signal_at_join): test with timeout
* thread.c (sleep_wait_for_interrupt): remove
(thread_join_sleep): use native_sleep directly to avoid extra
missing thread status change
[Bug #14181]
git-svn-id: ... - 08:26 AM Revision 78cc1491 (git): thread.c: hoist out timeval arithmetic functions
- timeval arithmetic may be reused in other places and this
makes sleep_timeval easier-to-read.
* thread.c (timeval_add): hoist out of sleep_timeval
(timeval_update_expire): ditto
(sleep_timeval): use new functions
git-svn-id: svn+ss... - 05:35 AM Revision 1389cdab (git): * 2017-12-17
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61300 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * vm_method.c (prepare_callable_method_entry): empty method table
has no entries.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61299 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * vm_method.c (method_definition_addref_complement): fix debug
message, show complemented_count instead of alias_count.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61298 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
12/16/2017
-
- A popular gem that I use for my doc site doesn’t currently test against MinGW trunk, but I’ve got a PR there for that. Noticed that the current CI’s were failing, and took a look.
One could debate the practicality of doing so, but fo... -
04:56 PM Bug #14159: [BUG] Segmentation fault at 0x0000000000000000 ruby 2.4.2p198 (2017-09-14 revision 59899) [x86_64-linux] - Mailcatcher
- shyouhei (Shyouhei Urabe) wrote:
> moskkitow (Marcelo Cruz) wrote:
> ...
Sorry for the delay on respond to this. I was really busy. What did you mean about contact the authors? To go after the eventmachine guys and see if they have a s... -
- > Any chances you tried --with-jemalloc ? It might perhaps exhibit something different.
I tried jemalloc at https://github.com/ruby/ruby/pull/1766#issuecomment-350553062
Just used jemalloc, I got a performance improvement 4.381M -> 7... -
- normalperson (Eric Wong) wrote:
> The thing is, ruby 2.4 and earlier do not have webrick installed as a
> ...
You're correct. Considering that I have Travis & Appveyor pages that show that info, I should have checked.
I tried the ... -
- Greg.mpls@gmail.com wrote:
> Eric,
>
> Looking over 61155, it does seem rather odd to constrain updates to WEBrick to ruby >= 2.5 for two warnings. Also, I believe WEBrick is the only gem affected by it. Don't know what your thoug... -
- Eric,
Looking over 61155, it does seem rather odd to constrain updates to WEBrick to ruby >= 2.5 for two warnings. I believe WEBrick is the only gem affected by it. Don't know what your thoughts are...
Also, re users not needing ... -
- * ruby.c (process_options): fallback to the encoding of the script
name since rb_realpath_internal() cannot convert the encoding
when it is ASCII-8BIT.
* test/ruby/test_rubyoptions.rb (test___dir__encoding): explicitly
pass enviro... -
- Applied in changeset trunk|r61296.
----------
vm.c: always export rb_frame_method_id_and_class
Functions declared in include/ruby/backward.h is exported only when
the condition `!defined RUBY_EXPORT && !defined RUBY_NO_OLD_COMPATIBILIT... -
- See https://github.com/ruby/ruby/commit/857827e3eed915543ac9d4d2541179ea4ded8eee
-
- rb_frame_method_id_and_class is currently available in the header files as deprecated, but the corresponding symbol is not exported from the library.
Witness the following compile and execution log excerpts:
~~~
../../../../ext/ru... -
- Functions declared in include/ruby/backward.h is exported only when
the condition `!defined RUBY_EXPORT && !defined RUBY_NO_OLD_COMPATIBILITY`
is met (i.e. included by include/ruby/ruby.h).
So if it is not the case when ruby is built, t... -
- no longer relevant
-
- Eric Wong <normalperson@yhbt.net> wrote:
> That might be correct, but I don't like making the sleep_*
> ...
Something like below (maybe more cleanups possible,
timeval is tedious to use...):
```diff
diff --git a/test/ruby/test_thr... - 06:05 AM Revision f319aa85 (git): should install after test
- * common.mk (love): should install after test (but this change does not gurantee
the order).
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61295 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 01:56 AM Revision d837e532 (git): aliases
- * tool/merger.rb: aliases for removetag command.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61294 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@61293 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- 開発者会議で議論し、GVL 開放せずにループで良いだろうということになりました。
そしてさきほど r61292 で修正したので閉じます。（コミットログに書き忘れました。すみません） -
- getrandom(2) and read(2) (from /dev/urandom) may return a random buffer
whose length is shorter than required. This change makes sure that they
get enough buffer by using a loop.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61292 ... -
- * test/ruby/test_vm_dump.rb (assert_darwin_vm_dump_works): gcc seems
not to chain some frames like Apple's clang.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61291 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * string.c (undump_after_backslash): fix multiple codepoints in
braces.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61290 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * string.c (str_undump): suppress maybe-uninitialized warning by
gcc 7 and later.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61289 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
12/15/2017
-
- Thank you for the report!
I found that #14104 changed TracePoint's lineno, which broke coverage.so. I'll fix it with ko1. -
06:52 PM Bug #14191 (Closed): Coverage decreased between 2.4.3 and 2.5.0rc1
- Just ran the test suite on my Rails app on the new rc and noticed that the coverage dropped by a full 3%. After some investigation discovered a lot of lines aren't being reported as covered anymore even though they clearly are. Here are ...
-
- I'm not familiar with $SAFE, but the scope seems finer:
```
$ ruby -e 'f = proc { $SAFE = 1; p [:in_proc, $SAFE] }; f.call; p [:out_of_proc, $SAFE]'
[:in_proc, 1]
[:out_of_proc, 0]
``` -
- $SAFE is documented in many places as thread-local, but it seems more than that.
For example:
# a.rb
$SAFE=1
p $SAFE
require "#{Dir.pwd.untaint}/b.rb"
# b.rb
p [:in_b, $SAFE]
gives:
$ ruby -r.... - 09:55 PM Revision d02f2996 (git): NEWS: update for WEBrick Proc body responses
- Better late than never :x [Feature #855]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61288 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 09:49 PM Revision 3ed8d398 (git): NEWS: updates about trivial GVL release changes
- No tickets, but all pretty trivial changes which avoids
stalls on slow/non-responsive filesytems.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61287 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 08:15 PM Revision 4eac6eb3 (git): lib/erb: Update doc [ci-skip] [doc]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61286 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- shevegen@gmail.com wrote:
> Good catch.
>
> I guess the japanese hackers all happily use ruby 2.5.x already. :)
/me is not Japanese, but yes, I mainly use 2.5.x
> 2.4.3 was recently released. Guess it is a stable variant on t... -
06:44 PM Bug #14189: Webrick 1.4.0. release requires unreleased ruby version 2.5.0dev
- Good catch.
I guess the japanese hackers all happily use ruby 2.5.x already. :)
2.4.3 was recently released. Guess it is a stable variant on the
2.4.x branch.
Webrick at https://rubygems.org/gems/webrick has the ">= 2.5.0dev"
... -
12:20 PM Bug #14189 (Closed): Webrick 1.4.0. release requires unreleased ruby version 2.5.0dev
- Hi Team!
We have just encountered a blocking bug in the Webrick gem version 1.4.0.
The gemspec is requiring an as yet unreleased version of ruby:
Gem::InstallError: webrick requires Ruby version >= 2.5.0dev.
An error occurred whi... -
- I have difficulty opening the zip files on my linux box.
It tells me:
warning [/Depot/jjjj/passenger-log.zip]: zipfile claims to be last disk of a multi-part archive;
attempting to process anyway, assuming all parts have been c... -
10:01 AM Bug #14188 (Third Party's Issue): With install Ruby 2.4.3 and Passenger 5.1.12 ALL sites will fail to open
- With install Ruby 2.4.3 and Passenger 5.1.12 ALL sites will fail to open
https://github.com/phusion/passenger/issues/2010
Answer:
**Hi, this doesn't look like an issue with Passenger, but instead with Ruby, see the error message... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61285 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 05:44 PM Revision f941bdf2 (git): * 2017-12-16
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61284 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61283 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- It works for me. How did you test?
```
$ cat t.rb
p 1
return
p 2
$ ruby -v t.rb
ruby 2.4.2p198 (2017-09-14 revision 59899) [x86_64-linux]
t.rb:3: warning: statement not reached
1
$ /tmp/local/bin/ruby -v t.rb
ruby 2.5.0rc1 ... -
02:21 PM Feature #4840: Allow returning from require
- Could someone please explain me what is the current status of this feature? I thought I would be able to return from the top-level when requiring a file, but it still seems to be an invalid syntax to this day. Am I missing something?
-
- * tool/gperf.sed: comment out arguments part only, to keep the
following declarations static. [Feature #13883]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61282 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- mame (Yusuke Endoh) wrote:
> I think when a casual user build and install ruby, s/he will expect `make test` or `make check` to run all recommended test suites because many other projects uses them as the semantics.
Eregon (Benoit Da... -
- This looks good to me.
I think we should still have a way to run each of the 3 groups individually: "basic tests", test-all and test-spec.
I often run test/ and spec/ individually while working on MRI.
Specifically, I think test-all s... -
- Yes, I (mswin-build) will be critically affected by this change.
But I'll be able to fix it.
If you really believe that this is necessary, I'll not oppose.
My only hope is that the timing of the change is appropriate.
For example, ... -
- Currently, MRI has many test suites: "`bootstraptest/`", "`KNOWNBUGS.rb`", "`basictest/`", "`test/`", and "`spec/`". And, the target name design of `make` is really complicated:
* `make test` runs the first three suites
* `make test... -
- ko1 (Koichi Sasada) wrote:
> I reconsider about this line and
> ...
Ideally, I think referring to the documentation of Thread::report_on_exception directly would be the most helpful, so something like:
#<Thread:0x000055c6660d0b1... -
- (bikeshed)
Eregon (Benoit Daloze) wrote:
> #<Thread:0x000055c6660d0b10@report.rb:3 run> terminated with exception (report_on_exception is true):
I reconsider about this line and
`#<Thread:0x000055c6660d0b10@report.rb:3 run> termi... -
12:29 PM Feature #14177: PATCH: File::Stat#dev on Windows
- > I'm curious why/how do you use rdev/ino on Windows.
I don't have actual plan to use rdev/ino. Just curious about it.
> ...
If I don't misread it, does it means that rdev/ino read in a process
may be different from that in anothe... -
- Revert part of r61278 [Bug #13655]
[ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61281 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61280 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61279 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- This seems regression caused by Bug #13547
```
% RBENV_VERSION=2.3.5 ruby -c -e 'a [] {}'
Syntax OK
% RBENV_VERSION=2.3.5 ruby -c -e '1.upto 2 {|i|p i}'
-e:1: syntax error, unexpected '{', expecting end-of-input
1.upto 2 {|i|p i}... -
- Applied in changeset trunk|r61278.
----------
IO.new doesn't recive "-" as external_encoding [Bug #13655] -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61278 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- chucke (Tiago Cardoso) wrote:
> Bitten by this as well. I'd go the route proposed earlier:
> ...
HTML's encoding is definition is bit different from usual encoding converters as described at WHATWG Encoding Standard.
https://encoding.... -
08:19 AM Revision 42c4ca63 (git): openssl: suppress report_on_exception warning
- Import a commit from upstream:
33a67ac96492 test/utils: disable Thread's report_on_exception in start_server
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61277 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- nobu@ruby-lang.org wrote:
> normalperson (Eric Wong) wrote:
> > I guess the sleep_wait_for_interrupt path when !forever has the
> > same problem and might sleep too long..
>
> How about this patch?
That might be correct, but ... -
- normalperson (Eric Wong) wrote:
> I guess the sleep_wait_for_interrupt path when !forever has the
> ...
How about this patch?
```diff
diff --git i/thread.c w/thread.c
index cc62ea3905..138c26cb09 100644
--- i/thread.c
+++ w/thr... -
- Applied in changeset trunk|r61274.
----------
thread.c: fix deadlock
* thread.c (thread_join_sleep): the target thread may exit during
`RUBY_VM_CHECK_INTS_BLOCKING`, but `sleep_forever` does not
consider the condition change to wai... -
- nobu@ruby-lang.org wrote:
> It seems the signal trap causes thread switching then `Process.waitpid` exits.
> That means the target thread status can change during `RUBY_VM_CHECK_INTS_BLOCKING`, but `sleep_forever` doesn't consider the... -
- It seems the signal trap causes thread switching then `Process.waitpid` exits.
That means the target thread status can change during `RUBY_VM_CHECK_INTS_BLOCKING`, but `sleep_forever` doesn't consider the condition to wait at that momen... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61276 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * subscript out of range
* enumerated type mixed with another type
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61275 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * thread.c (thread_join_sleep): the target thread may exit during
`RUBY_VM_CHECK_INTS_BLOCKING`, but `sleep_forever` does not
consider the condition change to wait.
[ruby-core:84248] [Bug #14181]
git-svn-id: svn+ssh://ci.ruby-lang... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61273 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61272 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61271 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61270 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:22 AM Revision e13d347d (git): add `removetag` command
- * tool/merger.rb (remove_tag): add `removetag` command.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61269 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * thread.c (terminate_all): fix funtion name in debug messages.
* thread.c (terminate_all, thread_join_sleep, thread_join): show
the status of the target thread in debug messages.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@612... - 03:04 AM Revision 3b10f702 (git): check the existence of specified tag
- * tool/merger.rb (tag): check the existence of specified tag before tagging to
get rid of careless mistakes.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61267 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
12/14/2017
- 08:02 PM Feature #13173 (Closed): Gemify webrick
- Applied in changeset trunk|r61266.
----------
webrick 1.4.0 release
* lib/webrick/version.rb: change VERSION to 1.4.0
* lib/webrick/webrick.gemspec: require_relative for version,
update date and contact info
[Feature #13173] - 08:02 PM Revision 9cbb3bd1 (git): webrick 1.4.0 release
- * lib/webrick/version.rb: change VERSION to 1.4.0
* lib/webrick/webrick.gemspec: require_relative for version,
update date and contact info
[Feature #13173]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61266 b2dd03c8-39d4-4d8f-... -
- Isn't this a duplicate of #14141?
-
03:51 PM Feature #6286: Add Exception#format method
- I would still love to see this accepted.
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61265 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 06:49 PM Revision 8dbc8caa (git): * version.h: Bump version to 2.3.7
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@61264 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- fix r61261
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61263 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
04:58 PM Feature #11256: anonymous block forwarding
- Eregon (Benoit Daloze) wrote:
>
> ...
ko1 convinced matz to accept this and he provided his reasons, simplicity of notation, not requiring an otherwise pointless variable. Which makes sense to me.
Also keep in mind that lazy proc ... -
- Just my opinion, but I think the shortcut syntax is going to cause more confusion than it would help.
`&` as argument without a `&` as a parameter looks very weird to me (it's like `it` in other languages, I would strongly advise agains... -
- According to ko1, Matz said that the details of the spec is not mature yet, so this ticket is postponed to 2.6.
A patch that allow `def foo; bar(&); end`:
```diff
diff --git a/compile.c b/compile.c
index 1b7158979a..79fde2f1a9 10... -
- Great!
I released Ruby 2.5.0-rc1 with those fixes! [ruby-core:84271] -
- Since Appveyor mswin build is rather backed up, MinGW results below:
```
0 Total Failures/Errors Build No 245 Job Id vqgsjbu2ik757ekn
ruby 2.5.0dev (2017-12-14 trunk 61242) [x64-mingw32]
2017-12-14 ... - 04:47 PM Revision 677dcecc (git): * 2017-12-15
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61262 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- It cause warnings when ruby remove error= on compiling ext/*.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61261 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- r61055 breaks build
- 03:08 PM Revision 02b8978f (git): * test/net/ftp/test_ftp.rb (process_port_or_eprt): merge a part of
- r56973 to pass the test introduced at previous commit.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@61255 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 02:56 PM Revision e1808b52 (git): forgotten to update
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@61252 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 02:55 PM Revision 3ec034c5 (git): * test/net/ftp/test_ftp.rb (process_port_or_eprt): merge a part of
- r56973 to pass the test introduced at previous commit.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@61251 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- This is still issue. Gemifying IRB might help with that ...
-
- This is not relevant anymore and was probably resolved already.
-
- ruby_2_3 r61248 merged revision(s) 61242.
-
- ruby_2_4 r61245 merged revision(s) 61242.
-
- Backport 管理用チケットです。
- 01:55 PM Revision 1cfe43fd (git): merge revision(s) 61242: [Backport #14185]
- Fix a command injection vulnerability in Net::FTP.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@61248 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 01:53 PM Revision 0207c68e (git): merge revision(s) 61242: [Backport #14185]
- Fix a command injection vulnerability in Net::FTP.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@61246 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Fix a command injection vulnerability in Net::FTP.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@61245 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 01:50 PM Revision fc824f2a (git): merge revision(s) 60149: [Backport #14003]
- Merge rubygems-2.6.14 changes.
It fixed http://blog.rubygems.org/2017/10/09/unsafe-object-deserialization-vulnerability.html
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@61244 b2dd03c8-39d4-4d8f-98ff-823fe69b... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61242 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- This is the glibc maintainer response [1]:
> […]
> ...
It would be nice if this was fixed in Ruby.
[1]: https://bugzilla.redhat.com/show_bug.cgi?id=1500863#c5 -
- ruby_2_3 r61241 merged revision(s) 61197.
-
- ruby_2_4 r61238 merged revision(s) 61197.
-
- バックポート管理用チケットです。
- 01:36 PM Revision ccbe964c (git): merge revision(s) 61197: [Backport #14184]
- webrick: compile RE correctly for beginning and end match
Using ^ and $ in regexps means we can accidentally get fooled
by "%0a" in HTTP request paths being decoded to newline
characters. Use \A and \z to match ... -
- ruby_2_3 r61240 merged revision(s) 60172,60189,60208,60210,60211.
-
- ruby_2_4 r61239 merged revision(s) 60123,60172,60189,60208,60210,60211.
- 01:33 PM Revision 1beda297 (git): merge revision(s) 60172,60189,60208,60210,60211: [Backport #14005]
- webrick: do not hang acceptor on slow TLS connections
OpenSSL::SSL::SSLSocket#accept may block indefinitely on clients
which negotiate the TCP connection, but fail (or are slow) to
negotiate the subsequent TLS ha... -
- This seems to be fixed by Ruby 2.4.2, because there was no build failure since this version is available in Fedora. So it was probably the same issue as #13605 pointed out by wanabe.
-
- webrick: avoid unnecessary IO#sync= call
Sockets and pipes are always created with FMODE_SYNC flag
already set (otherwise many things would be broken).
* lib/webrick/server.rb (accept_client): remove unnecessary... -
- webrick: compile RE correctly for beginning and end match
Using ^ and $ in regexps means we can accidentally get fooled
by "%0a" in HTTP request paths being decoded to newline
characters. Use \A and \z to match ... -
- Documentation updated and improved in r61216.
The main Thread now also has report_on_exception=true for consistency with r61237 (it is not used though).
I think this feature is ready for 2.5. -
- * Adapt test and add specs.
* See [Feature #14143] [ruby-core:84227]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61237 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61236 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Import Ruby/OpenSSL 2.1.0. Commits since v2.1.0.beta2 can be found at:
https://github.com/ruby/openssl/compare/v2.1.0.beta2...v2.1.0
----------------------------------------------------------------
Kazuki Yamaguchi (8):
t... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61234 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
10:25 AM Revision df15754b (git): numeric.c: [DOC] grammar fixes
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61233 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61232 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61231 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61230 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * enum.c: [DOC] reword docs for Enumerable#{any?,all?,none?,one?}
to not mention the receiver (`enum') from call-seq, because it
does not appear in the call-seq of the rendered HTML docs.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/... -
08:52 AM Feature #12275: String unescape
- I committed this under the approval of @naruse . https://github.com/ruby/ruby/pull/1765#pullrequestreview-83409358
Thanks a lot. - 08:47 AM Feature #12275 (Closed): String unescape
- Applied in changeset trunk|r61228.
----------
Implement String#undump to unescape String#dump-ed string
[Feature #12275] [close GH-1765] -
- [Feature #12275] [close GH-1765]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61228 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
08:27 AM Feature #14183: "Real" keyword argument
- For a method definition like:
~~~
def foo(hsh={})
end
~~~
Will either of the following continue to work?:
~~~
foo(key: val)
foo(:key => val)
~~~
One performance issue with keyword arguments is that keyword splats alloca... -
- In RubyWorld Conference 2017 and RubyConf 2017, Matz officially said that Ruby 3.0 will have "real" keyword arguments. AFAIK there is no ticket about it, so I'm creating this (based on my understanding).
In Ruby 2, the keyword argume... -
- Just refactoring.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61227 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- cody@cutrer.us wrote:
> pid = Process.spawn('sleep 1')
Btw, much faster to reproduce the problem with either
script using "true" instead of "sleep 1"
(And I'm falling asleep and unable to continue working on this tonight :<) -
- Thanks. It seems the culprit is Timeout using Thread#join.
Our deadlock checking code might be buggy...
I write similar process management code all the time without
Timeout and never have this problem, so I'll investigate
(but no... -
04:50 AM Bug #14181 (Closed): hangs or deadlocks from waitpid, threads, and trapping SIGCHLD
- I'm not exactly sure what's going on here, but the end result is basically a thread is getting killed unexpectedly during a waitpid call, when SIGCHLD is being handled. In a more complex scenario, we end up hanging because Thread#join is...
- 06:38 AM Revision 9178645d (git): Thread.current.report_on_exception = false
- * test/win32ole/test_win32ole.rb: set report_on_exception = false in threads
which are expected to be throw some exceptions.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61226 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61225 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- There would be old Makefile, remove it and retry.
-
- I am up to date at r61221 and have restarted with `./configure`, but part of the errors continue, as follows:
```
compiling bigdecimal.c
bigdecimal.c: In function ‘BigDecimal_version’:
bigdecimal.c:150:3: error: #error RUBY_BIGDECI... -
- Applied in changeset trunk|r61221.
----------
bigdecimal: dependency
* ext/bigdecimal/extconf.rb: extconf.h depends on the gemspec
file. [ruby-core:84247] [Bug #14180] -
- When compiling the newest checkout, I get the error messages in the attached file.
The first few lines of the error messages are as follows:
```
compiling bigdecimal.c
bigdecimal.c: In function ‘BigDecimal_version’:
bigdecimal.c... -
- nd_set_column -> nd_first_set_column
nd_lineno -> nd_first_lineno
nd_set_lineno -> nd_first_set_lineno
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61224 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- at least, not in 2.5
-
- I'm curious why/how do you use rdev/ino on Windows.
They are not guaranteed as stable across processes. -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61223 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- I requested to remove `strscan` name from a reserved list of rubygems.org at 2weeks ago. But I didn't get it response.
-
- https://github.com/ruby/ruby/pull/1640
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61222 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * ext/bigdecimal/extconf.rb: extconf.h depends on the gemspec
file. [ruby-core:84247] [Bug #14180]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61221 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:43 AM Bug #14179 (Closed): Forwardable Segmentation fault ruby 2.2.8p477 (2017-09-14 revision 59906)
- Hello,
Delegating `backtrace` causes a segmentation fault on ruby 2.2.8.
Seems to be related to this change: https://github.com/ruby/ruby/commit/a14ba6e3d58d6f63f47c0549f60306c4989478ba
Looking at that change, seems like the `$@... - 02:29 AM Revision 98b6b9e1 (git): * gems/bundled_gems: Upgrade the did_you_mean gem to 1.2.0
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61220 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61219 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:11 AM Bug #8352 (Closed): URI squeezes a sequence of slashes in merging paths when it shouldn't
- Applied in changeset trunk|r61218.
----------
Allow empty path components in a URI [Bug #8352]
* generic.rb (URI::Generic#merge, URI::Generic#route_to): Fix a bug
where a sequence of slashes in the path part gets collapsed to a
sin... - 01:11 AM Revision b53ec390 (git): Allow empty path components in a URI [Bug #8352]
- * generic.rb (URI::Generic#merge, URI::Generic#route_to): Fix a bug
where a sequence of slashes in the path part gets collapsed to a
single slash. According to the relevant RFCs and WHATWG URL
Standard, empty path components are s...
12/13/2017
-
- Two files are identical when pairs of File::Stat#dev and File::Stat#ino
are same on unix. However when a volume (disk partition) is mounted on
a directory they may not identical even when the pairs are same on Windows
because File::St... -
- Thanks to shyouhei, mame, and especially naruse, I was able to brush up the patch.
v3.patch is attached. Improvements are diverse.
Spec change:
* use RuntimeError instead of ArgumentError for invalid formed (self) string
* no ... -
- Note that Ruby 2.5 improves this since #13196 if `options` has only symbol keys:
asd(42, {a:1}) # => ArgumentError: unknown keyword: a
I agree the message could still be improved as you suggest. -
05:21 PM Bug #14176 (Closed): Unclear error message when calling method with keyword arguments
- I (wrongly) created a method with the following signature:
def asd(first, options: {}); end
(notice that options is a keyword argument)
I called the method this way:
asd(arg, options)
And got the following misleading error... -
- I observe the following test error on Fedora builders:
~~~
1) Error:
TestResolvMDNS#test_mdns_each_address:
Errno::EPERM: Operation not permitted - sendto(2) for "224.0.0.251" port 5353
/builddir/build/BUILD/ruby-2.5.0-r6116... -
- This makes easier to debug scripts related to r59950.
* before
$ ./ruby --dump=insns -e '"#{a}"'
== disasm: #<ISeq:<main>@-e>============================================
0000 putobject "" ... -
- * Improve and clarify the documentation of Thread.report_on_exception
and related methods.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61216 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- hsbt (Hiroshi SHIBATA) wrote:
> nalsh was reverted it at https://github.com/ruby/ruby/commit/4b4f7c428c86deb7fa8743173e695122d00e66b1
Thx!
> ...
Yep it works with r61214
> Note: `tool/make-snapshot` is our central toolchain fo... -
- Hi Vit. Thanks always.
I confirmed to `make-snapshot` was broken.
https://github.com/ruby/ruby/commit/3234d6a6cba4e013cea778664ce4a8b372905ea1 is a reason for broken status.
nalsh was reverted it at https://github.com/ruby/ruby... - 03:36 PM Revision 3874e0d1 (git): NEWS: bigdecimal 1.3.3
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61215 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:28 PM Revision 06d36a1a (git): * 2017-12-14
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61214 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:28 PM Revision 61e58f7d (git): bigdecimal: version 1.3.3
- Import bigdecimal version 1.3.3. The full commit log is here:
https://github.com/ruby/bigdecimal/compare/v1.3.2...v1.3.3
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61213 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:26 PM Bug #13848 (Assigned): BigDecimal.new('200.') raises an exception
- I'm working this bug at https://github.com/ruby/bigdecimal/pull/87
-
- https://github.com/ruby/bigdecimal/issues/79
-
-
- ref https://github.com/rurema/doctree/pull/816
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61212 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * tool/vcs.rb (VCS#get_revisions): raise VCS::NotFoundError when
command not found.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61211 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61210 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * The new one produces many warnings like:
warning: Insecure world writable dir /usr/local/clang-5.0.0/bin in PATH, mode 040777
* Workaround from https://blog.travis-ci.com/2017-12-12-new-trusty-images-q4-launch
git-svn-id: svn+ssh://... -
10:55 AM Revision f7fd4cb6 (git): NEWS: typo [DOC] [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61208 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61207 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Applied in changeset trunk|r61206.
----------
test_process.rb: fix error when empty groups
* test/ruby/test_process.rb (test_maxgroups): set one element at
least get rid of ZeroDivisionError when no process groups.
[ruby-core:84224... -
- * test/ruby/test_process.rb (test_maxgroups): set one element at
least get rid of ZeroDivisionError when no process groups.
[ruby-core:84224] [Bug #14174]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61206 b2dd03c8-39d4-4d8f-98... -
- Applied in changeset trunk|r61205.
----------
Ripper::Lexer bit predicates
* ext/ripper/lib/ripper/lexer.rb (Ripper::Lexer): added allbits?,
anybits? and nobits? methods, as well as Integer. a patch by
aycabta. [Feature #14170] -
- * ext/ripper/lib/ripper/lexer.rb (Ripper::Lexer): added allbits?,
anybits? and nobits? methods, as well as Integer. a patch by
aycabta. [Feature #14170]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61205 b2dd03c8-39d4-4d8f-98... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61204 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61203 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
09:13 AM Feature #14097: Add union and difference to Array
- > I'm not in favor of adding methods to the core classes simply because they are useful in certain cases. If we added every method to the core classes that was useful in specific cases, we'd eventually have thousands of methods in each c...
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61202 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- I gave up to apply at Ruby 2.5. I try this next year.
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61201 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61200 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- The corresponding issue in GitHub: https://github.com/ruby/bigdecimal/issues/84
-
- I decided to make a BigDecimal is frozen and remove dup-support.
But it introduces incompatibilities, so during Ruby 2.5 period, I'll make them deprecated and issue warning messages. -
- The previous git clone command is not work, the protocol in URL should be https
[fix GH-1772]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61199 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
-
- I understood this issue. I try to resolve current specification at Ruby 2.6.
-
01:10 AM Revision 564dd286 (git): parse.y: Revert r61196
- * parse.y: Because top_stmts is generated from none (not "/* none */"),
@0 is not set by YYLLOC_DEFAULT. So @0 is a meaningless location.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61198 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 12:38 AM Revision aac91cb7 (git): webrick: compile RE correctly for beginning and end match
- Using ^ and $ in regexps means we can accidentally get fooled
by "%0a" in HTTP request paths being decoded to newline
characters. Use \A and \z to match beginning and end-of-string
respectively, instead.
Thanks to mame and hsbt for rep...