Activity
From 11/29/2017 to 12/05/2017
12/05/2017
- 11:34 PM Revision b034a9d2 (git): * 2017-12-06
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61036 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
11:34 PM Revision 5abf308a (git): test_syntax.rb: Add a test case for `not()`
- * test/ruby/test_syntax.rb (TestSyntax#test_keyword_not_parens):
Currently `not()` is tested by only TestRipper::ParserEvents#test_unary,
so I think it's better to test this syntax directly.
git-svn-id: svn+ssh://ci.ruby-lang.org/ru... -
06:23 PM Feature #13050: Readline: expose rl_completion_quote_character variable
- This has been open for a year. Is there anything I can do towards getting the patch accepted?
-
05:00 PM Bug #14058: [bundler] program-suffixを付けるとbundle gem -> rake buildなどが動作しない
- I got same error with ruby-2.4.2 and bundler-1.16.0.
~~~
$ bundle gem mygem
:
$ rake2.4 build
rake aborted!
sh: 1: gem: not found
~~~ -
04:52 PM Bug #14096: Psych allows invalid single quote escape character
- Pull request https://github.com/yaml/libyaml/pull/74 has been created for libyaml, which means this is likely to percolate up to MRI over the coming years.
It might be good to get ahead of it and patch Psych to forbid the single quote... -
01:49 PM Revision f24efa28 (git): parse.y: nd_line of new node
- * parse.y (nd_set_loc): set nd_line of the newly created node to
the first location.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61034 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * parse.y (call_uni_op): set nd_line to the unary operator
location, same as non-operator method calls.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61033 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * parse.y (logop): set nd_line to the logical operator location,
same as non-operator method calls.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61032 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * parse.y (match_op): set nd_line to the match operator location,
same as non-operator method calls.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61031 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * parse.y (call_bin_op): set nd_line to the binary operator
location, same as non-operator method calls.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61030 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
11:08 AM Revision 25d6a7ef (git): Bump version to rdoc-6.0.0.
- There is no changes from rdoc-6.0.0.bebta4.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61029 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
09:45 AM Revision e5614fbc (git): iseq.c (iseq_load, iseq_data_to_ary): Fix a type error (for clang)
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61028 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- I disclosed it incorrectly at r61025. Sorry.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61027 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- This change makes method coverage result have not only first lineno of
method defintion, but also code range (i.e. first lineno, first column,
last lineno, and last column).
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61026 b2dd03... -
- This change makes each ISeq keep NODE's code range. This information is
needed for method coverage.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61025 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * node.c (COMPOUND_FIELD, FIELD_BLOCK): moved block outside
arguments like as SIMPLE_FIELD.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61024 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I think it is intended.
`dirname` for a path without directory is ".", and this does not come from the argument string. -
07:32 AM Bug #9912: URI#to_s with an empty host formats the string incorrectly
- [I wrote this directly to ruby-core because I didn't see the issue, but want to make sure it's in the right place.]
The "postgres:" URI scheme isn't even mentioned in the registry at https://www.iana.org/assignments/uri-schemes/uri-sc... -
- Traditionally, method coverage measurement was implemented by inserting
`trace2` instruction to the head of method iseq. So, it just measured
methods defined by `def` keyword.
This commit drastically changes the measuring mechanism of ... -
05:26 AM Bug #14154: Ruby 2.4 and support for rails 3
- See also https://www.ruby-lang.org/en/news/2013/12/21/ruby-version-policy-changes-with-2-1-0/
-
04:55 AM Bug #14154 (Closed): Ruby 2.4 and support for rails 3
- Thanks for your report. 2.4 is not fully compatible with older versions of Ruby, and that's intentional. Please refer to our maintenance policy https://bugs.ruby-lang.org/projects/ruby/wiki/GeneralMaintenancePolicy and the discussion aro...
-
- This affects only `--dump=parsetree` and `--dump=parsetree_with_comment`.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61022 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Fixed at r61020
- 01:10 AM Revision 133b0cf2 (git): * remove trailing spaces.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61021 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Currently the Fiber stack size is small for powerpc64 and it causes
test/ruby/test_backtrace.rb test to break, since it is using a 8kb stack
size.
It breaks on powerpc64 due to the fact that a frame in the stack is
usually 50% bigger on... -
12:59 AM Revision 65c0f47f (git): Remove unnecessary read_timeout.
- http://ci.rvm.jp/results/trunk-asserts-nopara@ruby-sky1/219867
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61019 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:52 AM Feature #14153: [PATCH] resurrection of # -*- warn_past_scope: true -*-
- @shevegen Yes. You can write multiple magic comments
- at once, like this:
# -*- coding: utf-8; frozen_string_literal: true; warn_indent: true; warn_past_scope: true -*-
- or, line by line like this:
# coding:... -
- * bignum.c (int_pow_tmp2): unified DLONG and none DLONG code.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61018 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
12/04/2017
- 11:59 PM Revision 984759ef (git): * 2017-12-05
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61017 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * parse.y: Fix to only include a range of exc_var.
e.g. The locations of the NODE_DASGN_CURR and NODE_ERRINFO are fixed:
```
begin
1
rescue => e
2
end
```
* Before
```
NODE_DASGN_CURR (line: 3, first_lineno:... -
07:00 PM Bug #13757: TestBacktrace#test_caller_lev segaults on PPC
- Hi,
I've been investigating this issue, and I think I found the solution:
stack_check() is checking the lambda stack size against a very small stack size (8Kb). This is a quite small stack size, and powerpc usually have a bigger fr... -
06:04 PM Feature #14153: [PATCH] resurrection of # -*- warn_past_scope: true -*-
- Seems to me to be more appropriate as a Rubocop cop.
-
04:44 PM Feature #14153: [PATCH] resurrection of # -*- warn_past_scope: true -*-
- I have no pro or con opinion so I will not comment on the suggestion.
I have one question though, apologies for a bit of side tracking:
- Can this be combined with other comment options such as "# frozen_string_literal: true"
?
... -
- This patch works like this:
```
% ./ruby --disable-gems -w -ve '[1, 2, 3].sample.tap { |rand| puts "Random value: #{rand}" }; puts "Another random value: #{rand}"'
ruby 2.5.0dev (2017-12-04 warn_past_scope 61011) [x86_64-darwin15]
... -
- ```patch
From 2addeedcf8838dc15d127fffd888962b34879439 Mon Sep 17 00:00:00 2001
From: "Urabe, Shyouhei" <shyouhei@ruby-lang.org>
Date: Mon, 4 Dec 2017 19:28:55 +0900
Subject: [PATCH] resurrection of # -*- warn_past_scope: true -*-
... -
- Matz, this was on the agenda for the developers meeting, was it discussed?
-
- phluid61 (Matthew Kerwin) wrote:
> If there was a way to explicitly signal the end of the "infectious nil" I'd probably find it useful
There is one way, and it is the same as with all the cases where the precedence doesn't go the way... -
12:28 PM Feature #11816: Partial safe navigation operator
- sawa (Tsuyoshi Sawada) wrote:
>
> ...
I think `.nil?`, `.inspect`, `.tap` could all be legitimately used on a value or nil.
It makes sense to me that `&.` is just a safe version of `.`, not some sort of "infectious nil" operation t... -
11:07 AM Feature #11816: Partial safe navigation operator
- znz (Kazuhiro NISHIYAMA) wrote:
> marcandre (Marc-Andre Lafortune) wrote:
> ...
I don't think that is a real use case. The linked article mentions coding style. It suggests not to use the safe navigation operator without thinking or wh... -
01:55 PM Bug #14154 (Closed): Ruby 2.4 and support for rails 3
- After upgrading a Rails project from 2.1.5 to 2.4.2 I ran into a number of failing tests. Seems like a behavior of **ActiveSupport::Duration can't be coerced into Integer**
I’ve looked at some important changes that are part of the Ru... -
- * win32/win32.c (FILE_ID_128): defined on mingw already.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61015 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:31 PM Revision 378f0280 (git): [DOC] improve rdoc formatting for links [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61014 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
11:44 AM Bug #14075: File.dirname("path without dir".taint) returns untainted string
- I found that File.split also returns untainted string with a tainted argument.
~~~
$ ruby -e 'p File.split("foo/bar".taint).map(&:tainted?); p File.split("hoge".taint).map(&:tainted?)'
[true, true]
[false, true]
~~~
-
11:35 AM Feature #14145: Proposal: Better Method#inspect
- ko1 (Koichi Sasada) wrote:
> I don't have strong opinions on your proposal, but source location information seems also helpful. Which is important or both?
I believe that source location is less necesary. I mean, what I had in mind w... -
08:15 AM Feature #14145: Proposal: Better Method#inspect
- ko1 (Koichi Sasada) wrote:
> I don't have strong opinions on your proposal, but source location information seems also helpful. Which is important or both?
i didn't looked at the ruby source code for now, but might it be possible to ... -
07:54 AM Feature #14145: Proposal: Better Method#inspect
- I don't have strong opinions on your proposal, but source location information seems also helpful. Which is important or both?
-
11:28 AM Feature #14142: Add Method#===
- ```ruby
case value
when proc { |v| receiver.hoge(v) }
end
```
とすることもできますが、この issue にあるパッチで実現される方法のほうが Rubyish で良いと思います。
```ruby
case value
when receiver.method(:hoge).to_proc
end
```
とすれば今でも意図と同じものは可能ですが、微妙に Proc っぽいけど P... -
- This issue may have been fixed with https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=60976. Nobu, please close if that's true.
-
10:48 AM Misc #13702 (Closed): TZ checking in rb_w32_fstati64()
- Applied in changeset trunk|r61013.
----------
support nanosec file timestamp on newer Windows
Support nanosec file timestamp on Windows 8 or later.
Original patches are written by kubo (Kubo Takehiro).
Windows 7 and earlier also suppor... -
- Applied in changeset trunk|r61013.
----------
support nanosec file timestamp on newer Windows
Support nanosec file timestamp on Windows 8 or later.
Original patches are written by kubo (Kubo Takehiro).
Windows 7 and earlier also suppor... -
- @larskanis, thank you for information.
larskanis (Lars Kanis) wrote:
> So to remove these inconsistencies we could truncate file times to 1/64 precision, when GetSystemTimePreciseAsFileTime() is not available?
OK, I'll test it. -
07:21 AM Feature #13726: PATCH: Windows builds - fractional second file times
- @usa I think the reason is, that precise file times are working as expected on Windows 7, but Time.now has a precision of 1/64 seconds only. This is because Windows 7 doesn't support GetSystemTimePreciseAsFileTime(), which is required to...
- 10:48 AM Revision ce7c1c05 (git): support nanosec file timestamp on newer Windows
- Support nanosec file timestamp on Windows 8 or later.
Original patches are written by kubo (Kubo Takehiro).
Windows 7 and earlier also supports nanosec file timestamp, but it's too
accurate than system time. so, this feature is disabled... -
- watson1978 (Shizuo Fujita) wrote:
> I updated the patch to keep binary compatibility.
> ...
Good. However, I think you should consider using ccan/list. It is field proven.
> And I took a benchmark on Linux. Seem that Linux's mallo... -
- * bignum.c (int_pow_tmp2): explicitly cast to get rid of implicit
conversion.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61012 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
08:50 AM Feature #14141: Add a method to Exception for retrieving formatted exception for logging purpose (Exception#{formatted,display})
- > I'm not sure this name is proper, suggestions appreciated
How about "to_formatted_s"?
Active Support has this method for some core classes, and so I guess this name may sound familiar to the Rails people. https://github.com/rails/r... -
- * parse.y (arg_append_gen): Update the last location of
NODE_BLOCK_PASS when NODE is appended to nd_head.
e.g. The locations of the NODE_BLOCK_PASS is fixed:
```
o[1, &bl] = :c
```
* Before
```
NODE_BLOCK_PASS (line: ... -
- osa (Shunsuke OSA) wrote:
> I used to use FTP and need this feature.
> ...
I don't have any use case of this feature either, so I close this issue.
-
06:40 AM Feature #13382: [PATCH] Options for FTP PORT command
- I used to use FTP and need this feature.
But now, I don't use it and lose motivation to implement this feature.
I'm so sorry.
Please close this issue.
(I guess I can't close this issue.) -
- * parse.y (arg_append_gen): Update the last location of
NODE_ARGSCAT when NODE is appended to nd_body.
e.g. The locations of the NODE_ARGSCAT is fixed:
```
m(*a, :b, :c)
```
* Before
```
NODE_ARGSCAT (line: 1, first_l... -
- Matz:
> but there is another motivation of this feature: the simplicity of the notation
With proposal syntax, we don't need to use a variable name for block parameter. What do you think about it?
-
- * marshal.c (compat_allocator_table): hide the wrapper object of
compat_allocator_tbl.
* process.c (rb_execarg_new): hide wrapper objects of struct
rb_execarg.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61009 b2dd03c8-39d4-4... -
- * parse.y: Fix the first location to be equal to the location
of the first element of NODE_ARRAY.
e.g. The locations of the NODE_ARRAY is fixed:
```
m(*a, :b, :c)
```
* Before
```
NODE_ARRAY (line: 1, first_lineno: 1,... - 06:41 AM Revision b7de978e (git): try to pass compiling with VC12
- * win32/win32.c (FILE_ID_128): it's not defined in SDK with VC10, but seems to
be defined in SDK with VC12.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61007 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ext/socket/ifaddr.c (ifaddr_memsize): do not count the whole
rb_ifaddr_t array for each elements. the header size is
included in the first element for the time being.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61006 b2dd03... -
04:09 AM Bug #14148: Longstanding behavior regarding correspondence of toplevel with Object is surprising
- Hi @mame,
I agree that the change from warning to NameError is intended, and this behavior change is not the concern:
> I don't think is a problem for 2.5. The overall behavior seems consistent with 2.4, if surprising. My surprise ... -
- This change is intended. See https://bugs.ruby-lang.org/issues/11547. Matz said in that ticket:
> I am for this proposal, but also concern about code breakage. Let's try removing top-level constant look-up in 2.4dev and see how much... -
- stat構造体の変更は大掛かりなことになる上に、[Feature #13726] にはちょっと問題が発生しているので、とりあえず `File.identical?` のみ対応しました。
stat構造体の方は 2.5 には入らないかもしれません。 -
- Applied in changeset trunk|r61005.
----------
support `File.identical?` on ReFS
* file.c (rb_file_idenitical_p): move Windows dependent code to win32/win32.c.
* win32/win32.c (rb_w32_file_identical_p): support ReFS.
see [Feature #13... - 03:33 AM Revision 8e7560bb (git): support `File.identical?` on ReFS
- * file.c (rb_file_idenitical_p): move Windows dependent code to win32/win32.c.
* win32/win32.c (rb_w32_file_identical_p): support ReFS.
see [Feature #13731] [ruby-dev:50166]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61005 b2... -
02:35 AM Feature #12508 (Closed): Integer#mod_pow
- Applied in changeset ruby-trunk:trunk|r61003.
----------
bignum.c, numeric.c: add Integer#pow(b, m)
This commit is based on the pull-request #1320 created by Makoto Kishimoto.
[Feature #12508] [Feature #11003] [close GH-1320]
* bignum... - 02:35 AM Revision 8903ab2e (git): NEWS: add Integer#pow(b, m)
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61004 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 02:35 AM Revision 9b09cc8a (git): bignum.c, numeric.c: add Integer#pow(b, m)
- This commit is based on the pull-request #1320 created by Makoto Kishimoto.
[Feature #12508] [Feature #11003] [close GH-1320]
* bignum.c (rb_int_powm): Added for Integer#pow(b, m).
* internal.h (rb_int_powm): Declared to refer in numer... - 12:23 AM Revision 58b3f365 (git): revert r60999
- * test/logger/test_logdevice.rb: revert r60999 because it was caused by not
committed changes.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61002 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
12/03/2017
-
- * ext/socket/ifaddr.c (struct rb_ifaddr_tag): removed set but
unused member root.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61001 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * parse.y: Fix to only include a range of opt_call_args.
e.g. The locations of the NODE_ZARRAY is fixed:
```
a[] ||= 1
```
* Before
```
NODE_ZARRAY (line: 1, first_lineno: 1, first_column: 0, last_lineno: 1, last_column... -
- I am not sure that the information above alone is sufficient for the ruby
core team.
Can you get the full stack trace as a text file perhaps, in particular the
specific code at hand that can cause/evoke it/the above crash?
The ru... -
12:30 PM Bug #14152 (Third Party's Issue): faceing issue while creating box
- Hi Team,
I am facing below mentioned issue.
You may have encountered a bug in the Ruby interpreter or extension libraries.
Bug reports are welcome.
For details: http://www.ruby-lang.org/bugreport.html
This application has... -
- Actually, I think there may also be a bug ... I can not yet pinpoint
what causes it and I have to soon go to get some sleep, but switching
between ruby version triggers a NameError for me:
ruby 2.5.0dev (2017-11-30 trunk 60945) [x... -
04:29 PM Feature #13726: PATCH: Windows builds - fractional second file times
- usa (Usaku NAKAMURA) wrote:
> I've tested the patches, and I found that my Windows7 box often set the ctime and mtime as a little future -- some hundreds nano seconds.
> ...
Thanks for looking at it. I'll look over the patches I'm usi... -
- I've tested the patches, and I found that my Windows7 box often set the ctime and mtime as a little future -- some hundreds nano seconds.
I can't find the reason, but it makes some troubles with test-all and test-spec... -
04:01 PM Feature #14146: Improve performance of creating Hash object
- I updated the patch to keep binary compatibility.
https://github.com/ruby/ruby/pull/1766/commits/70a7b48aa18cdcaa9abf5acf93e2307c24b40a33
And I took a benchmark on Linux. Seem that Linux's malloc is better than macOS's about performa... - 03:49 PM Revision 389bda45 (git): * 2017-12-04
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60999 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:49 PM Revision eff0a1cc (git): give a change to determine to rotate the log or not
- * test/logger/test_logdevice.rb (test_shifting_{age,period_suffix}): give a
chance to determine to rotate the log or not.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60998 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:03 PM Feature #14151: Make Matrix#[]= public method
- shevegen (Robert A. Heiler) wrote:
>
> ...
I completely forgot that private method can be invoked using send so I'm using send now. But still it would be better if it was public.
-
- Matrix seems a bit weird ... it does not allow for a Matrix.new either.
The documentation is also lacking, as if the one who wrote it did not
finish writing the documentation:
https://ruby-doc.org/stdlib/libdoc/matrix/rdoc/Mat... -
- I don't even understand why this method hasn't been public since the beginning. I've come to a point when I have to create a matrix in a specific way using row and column indices and I can't use #build with a block because then indices g...
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60997 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * parse.y (new_args_tail_gen): Set only a location of NODE_DVAR.
e.g. The locations of the NODE_DVAR is fixed:
```
def a(k: 1, **kws) end
```
* Before
```
NODE_DVAR (line: 1, first_lineno: 1, first_column: 6, last_linen... -
12:11 PM Revision 71c2e599 (git): Set binmode to handle non ASCII commit message
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60995 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * common.mk ($(REVISION_H)): ignore error when git not found.
`--suppress_not_found` option suppresses a warning but does not
ignore the error.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60994 b2dd03c8-39d4-4d8f-98ff-823fe69b... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60993 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
11:07 AM Feature #12275: String unescape
- A few days ago, I attended at Ruby developers' meeting.
We concluded that the implementation is immature, so I need to improve in several points before commit.
* Encoding of a `undump`ed string which including `\uXXXX` before `undump... -
- Applied in changeset trunk|r60992.
----------
Specify refinement inheritance by Module#include.
[ruby-core:79880] [Bug #13271] -
- [ruby-core:79880] [Bug #13271]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60992 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r60991.
----------
Fix a documentation error of IO#putc.
IO#putc is multi-byte character safe when a String is given as its argument.
[ruby-core:82019] [Bug #13741] -
- IO#putc is multi-byte character safe when a String is given as its argument.
[ruby-core:82019] [Bug #13741]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60991 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60990 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60989 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * parse.y (top_stmt): wrap BEGIN statement to store the whole
location for each block.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60988 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60987 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * parse.y: Fix to only include a range of the first argument of cond.
e.g. The locations of the NODE_MATCH2 and NODE_GVAR are fixed:
```
1 while /#{:a}/
```
* Before
```
NODE_MATCH2 (line: 1, first_lineno: 1, first_colu... -
- * win32/setup.mak (-basic-vars-): moved BASERUBY and HAVE_BASERUBY
definition to make Makefile stable when they have been defaulted.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60985 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Otherwise, VM_ASSERT(callable_method_entry_p(cme)) in
prepare_callable_method_entry() fails if VM_CHECK_MODE is 2.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60984 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
12/02/2017
-
- > should be something like toplevel::X
I think that one problem here is that a new method? Or keyword, aka
"toplevel", would be added in the case that you showed. So that would
be a change to the status quo and I am not sure it is (... -
- I edited the title of this issue. I reported this initially as 2.5.0 issue, as I discovered it while playing around with the 2.5.0 changes regarding toplevel constant lookup. Now, this ticket is more about surprising behavior in genera...
-
- Only `Kernel` and `BasicObject`, but not modules included at the top level?
It feels weird a little to me.
-
- After some clarifying discussions with @matthewd, I don't think is a problem for 2.5. The overall behavior seems consistent with 2.4, if surprising. My surprise mostly revolves around the strange correspondence of toplevel with Object....
-
- Further down the rabbit hole, ruby 2.4.0p0:
~~~ ruby
class BasicObject
X = 1
end
String::X #=> 1
class Object
X = 2
end
String::X #=> 2
# warning: toplevel constant X referenced by String::X
~~~
On ruby 2.5.0-... -
- Behavior on 2.4.0p0:
~~~ ruby
module Kernel
X = 1
end
String::X #=> 1
X = 2
String::X #=> 2
# warning: toplevel constant X referenced by String::X
~~~
~~~ ruby
class Object
X = 1
end
String.superclass #=> Ob... -
- Expected behavior: `String::X` should continue to evaluate to `1` after `X = 2` at the toplevel
Actual behavior: `String::X` results in NameError after `X = 2` at the toplevel
more strangeness:
~~~ ruby
class Object
X = 1
e... -
- ~~~ ruby
module Kernel
X = 1
end
puts String::X
X = 2
puts String::X
~~~
~~~
$ ruby test.rb
1
Traceback (most recent call last):
test.rb:9:in `<main>': uninitialized constant String::X (NameError)
Did you mean? X
... -
09:37 PM Bug #12689: Thread isolation of $~ and $_
- ko1 (Koichi Sasada) wrote:
> Each frame has a map (thread -> MatchData)?
Conceptually yes, but it is allocated lazily and it specializes for being accessed by a single thread.
A Java ThreadLocal is used in the general case when more... - 03:41 PM Revision 4897750f (git): * 2017-12-03
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60983 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60982 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60981 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Applied in changeset trunk|r60980.
----------
Modules should not have subclasses.
When refining a module, the module was set to the superclass of its refinement,
and a segmentation fault occurred.
The superclass of the refinement shoul... -
- When refining a module, the module was set to the superclass of its refinement,
and a segmentation fault occurred.
The superclass of the refinement should be an iclass of the module.
[ruby-core:83617] [Bug #14070]
git-svn-id: svn+ssh://... -
- marcandre (Marc-Andre Lafortune) wrote:
> As a reminder, there's currently no real use for `foo&.bar.baz` or similar. We are forced to write `foo&.bar&.baz` even though this could introduce unwanted errors, e.g. if `bar` was erroneously... -
- Applied in changeset trunk|r60979.
----------
string.c: fix rb_external_str_new_with_enc
* string.c (rb_external_str_new_with_enc): do not search non-ascii
by NULL pointer. [ruby-core:84055] [Bug #14150] -
02:15 AM Bug #14150 (Closed): ruby 2.5.0dev SEGV by rb_external_str_new_with_enc(NULL, 0, rb_usascii_encoding())
- `rb_external_str_new_with_enc(NULL, 0, rb_usascii_encoding())` gets segmentation fault in ruby 2.5.0-preview1 and ruby 2.5.0dev.
It returns an empty string in released versions.
I made test code which calls following functions.
1.... -
- * string.c (rb_external_str_new_with_enc): do not search non-ascii
by NULL pointer. [ruby-core:84055] [Bug #14150]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60979 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * common.mk (update-unicode-property-files): fix emoji version in
the message.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60978 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * common.mk: download emoji-data.txt. As emoji data files are
located in a separate directory in Unicode.org site, reearranged
Unicode data files directories same as the site.
* tool/enc-unicode.rb (get_file): search emoji data fil... -
- * tool/enc-unicode.rb: support for gperf 3.1, which defines length
arguments as `size_t` but a local variable as `unsigned int`.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60976 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I myself started to use Ruby a very long time ago.
I have used perl for some time, and it was ok, but I kept on doing
newbie mistakes. For example, I often forgot ';' which was annoying.
I also did not really build ... anything too... -
- Hello Ruby-people in general,
Matz recently gave a keynote presentation and he mentioned that ruby's birthday will be
in 2018 (25 years; I think matz mentioned that he counts when the name was chosen but
ruby itself may have alread... -
- I agree; I think the documentation should mention that at http://ruby-doc.org/core/Array.html#method-i-sample. One can look at the source there :) but ... I guess more people will understand an explanation of the code, rather than the C ...
12/01/2017
-
- Hm, this is surprising:
~~~ ruby
module Kernel
X = 1
end
puts String::X
X = 2
puts String::X
~~~
~~~
$ ruby test.rb
1
Traceback (most recent call last):
test.rb:9:in `<main>': uninitialized constant String::X (Na... -
11:45 PM Misc #14147 (Closed): Array#sample documentation is unclear about order
- Does `Array#sample` only guarantee a random subset, or also random order? It's not clear. I think the current reference implementation does produce random order, but the documentation doesn't guarantee it, so I can't rely on it. If rando...
-
- phluid61 (Matthew Kerwin) wrote:
> exist/exists is tense, bit/bits is plurality, so it is unrelated.
Oh, thank you...I understand. -
- aycabta (ayca bta) wrote:
> Hi @naruse, matz said below.
> ...
exist/exists is tense, bit/bits is plurality, so it is unrelated. -
- Hi @naruse, matz said below.
matz (Yukihiro Matsumoto) wrote:
> I vote for `allbit?`, `anybit?` and `nobit?`. I am not sure about plurality though.
For your action, as you know, [Dir.exists?](https://bugs.ruby-lang.org/projects/ru... -
- A patch is as follows:
```diff
diff --git a/numeric.c b/numeric.c
index 1858113c09..511155a3ac 100644
--- a/numeric.c
+++ b/numeric.c
@@ -3209,6 +3209,45 @@ int_even_p(VALUE num)
return Qfalse;
}
+/*
+ * call-seq:
... -
- phluid61 (Matthew Kerwin) wrote:
> It introduces a strange paradox, though:
> ...
I discussed it with @watson1978 (Shizuo Fujita). We guess the behavior is not strange.
The allbits? means "The receiver checks that all standing bits ... -
09:40 PM Bug #9664: cannot resume transferred Fiber even if it should resume
- This bug or limitation still exists on Ruby 2.4.2. Any plans to address it?
This thread on stackoverflow.com identifies a possible bug in the C code.
https://stackoverflow.com/questions/38199283/ruby-fiber-resuming-transferred-fibe... -
09:34 PM Bug #14144: __FILE__ displays wrong value for executables when run from project root w/Ruby 2.4.1
- Thanks for that recognition. I've also put it on Stack Overflow at https://stackoverflow.com/questions/47584283/file-pointing-to-the-wrong-file-in-ruby-2-4-1-under-rvm/47584284#47584284 for that same reason.
-
- Thanks for your explanation how you resolved it - other ruby hackers may benefit from it.
-
- matz (Yukihiro Matsumoto) wrote:
> Making `Zlib::GzipReader#ungetc` accept nil does not help anybody. You should keep as it is.
Agreed.
> ...
I think we should, it seems a bug to me. -
- naruse (Yui NARUSE) wrote:
> But it breaks command line utilities which handles encoding other than locale.
What kind of utilities use a different encoding than the locale?
Do you have an example?
It seems to me that if an utility ... -
- > What do you think of having STDOUT, STDERR and STDIN internal_encoding be set by default?
> ...
For STDOUT, it's worth considering.
But it breaks command line utilities which handles encoding other than locale.
I think people who wa... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60975 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
05:23 PM Feature #14143: Thread.report_on_exception should be true by default
- I think clarification on what the semantics should be would be helpful.
Should **ANY** exception raised in a Thread be considered a reasonable way of ending a thread? Yes or No
Yes - You execute your program and it does not work ri... -
- > One detail, where would we define this Local class?
> ...
The `Local` class is meant to be private. It's behavior should be the same/similar for both Fiber and Thread. Putting it under the Thread namespace makes sense to me since Fibe... -
- mathn is out of scope from release engineering.
-
04:02 PM Feature #10982: Clarify location of NoMethod error
- parkr (Parker M) wrote:
> This new syntax is a pretty sizable divergence from traditional Ruby error reporting.
Yes, and I would consider that a good thing.
> ...
I don't think this suggestion implies removing the stack trace, whic... -
- Can we commit a fix for this?
I now put the spec using `refine module` in quarantine until this is resolved:
https://github.com/ruby/ruby/commit/4d7b0b9112f2adf9e87ef75056f930bf7c1f3dc4#diff-d3d17e341ab819948121f31a45de9bdf - 03:41 PM Revision 60775cc4 (git): * append newline at EOF.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60974 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60973 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60972 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Fixed it at r60970.
-
- I found the description in URL spec.
Therefore I fixed it at r60970. - 03:09 PM Revision 0f42035e (git): * 2017-12-02
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60971 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- https://url.spec.whatwg.org/#url-serializing
> Otherwise, if url’s host is null and url’s scheme is "file", append "//" to output.
URL spec doesn't says anything about postgres, but assume the same thing.
git-svn-id: svn+ssh://ci.ruby-... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60969 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 02:08 PM Revision 4a607519 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60968 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60967 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- [Bug #10402] allows [ and ].
Therefore it's not problem in practical. -
- Applied in changeset trunk|r60966.
----------
Update to Onigmo 6.1.3-669ac9997619954c298da971fcfacccf36909d05.
[Bug #13892] -
- [Bug #13892]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60966 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * parse.y: Fix to only include a range of for_var.
e.g. The locations of the NODE_ARGS and NODE_DVAR are fixed:
```
for a in m do n end
```
* Before
```
NODE_ARGS (line: 1, first_lineno: 1, first_column: 0, last_lineno:... -
-
12:26 PM Revision 857827e3 (git): vm.c: partially revert r60558
- because it was actually used in
https://github.com/tmm1/rbtrace/blob/v0.4.8/ext/rbtrace.c#L329
and deprecated in r60579 AFTER removal in r60558.
ko1 agreed that we should keep just deprecated in Ruby 2.5 and remove it
later, and I'm com... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60963 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * vm_trace.c (rb_suppress_tracing): remove duplicate flag
`tracing`, which equals to `ec->trace_arg != NULL`. and that
`ec->trace_arg` points `dummy_trace_arg` means it was NULL at
the beginning.
git-svn-id: svn+ssh://ci.ruby-lan... -
- akr-san, thank you!
Eregon, I think `$VERBOSE` dance is also thread-unsafe. So I personally like `Warning.ignore` if it is thread-local. I don't know how difficult it is to implement, though. -
10:49 AM Feature #14123: Kernel#pp by default
- mame (Yusuke Endoh) wrote:
> Okay, my third try: https://bugs.ruby-lang.org/projects/ruby-trunk/repository/revisions/60948
> ...
It is still not thread safe.
Consider a thread context switch at just after defining Kernel#pp
before ... -
- jeremyevans0 (Jeremy Evans) wrote:
> Unless the thread switch is completely blocked during the execution of required code, it seems like this is still not thread safe.
Nice catch!
@mame I think the new code is worth a comment that... -
- Okay, my third try: https://bugs.ruby-lang.org/projects/ruby-trunk/repository/revisions/60948
Thank you! -
- Avoid a race condition which a context switch
occur after replacing Kernel#pp but before
defining PP class.
Following patch, inserting sleep, makes
this problem reproducible.
```
Index: lib/pp.rb
=======================================... -
- * parse.y: Fix to only include a range of assocs.
e.g. The locations of the NODE_HASH is fixed:
```
a(1, b: 10, &block)
```
* Before
```
NODE_HASH (line: 1, first_lineno: 1, first_column: 2, last_lineno: 1, last_column:... -
- > is slightly different than what the C code does, if the message spans multiple lines (then the (#{e.class}) is still on the first line).
meh, yes, I just gave up to write the exact Ruby code with the C-level behavior... - 08:35 AM Revision b35f6f04 (git): NEWS: Net::HTTP is a stdlib
- [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60959 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- The same function was accepted in #12508
-
- * parse.y: Use @1 to only include a range of tLABEL.
e.g. The locations of the NODE_LIT(:b) is fixed:
```
a(1, b: 10)
```
* Before
```
NODE_LIT (line: 1, first_lineno: 1, first_column: 5, last_lineno: 1, last_column: 10... - 05:32 AM Revision c88c7d91 (git): bold/underscore support in traceback before Windows10
- * io.c (rb_write_error2): call `rb_w32_write_console()` when the device is tty,
like `rb_write_error_str()`.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60957 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Hi, @headius .
> * Clarify for me please: are the new gemified stdlibs all going to use the default gem mechanism?
I promoted following libraries to default gems at Ruby 2.5
```
cmath csv date dbm digest etc fcntl fiddle fileut... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60956 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60955 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60954 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- > So you pool st_table to avoid malloc. The speedup depends on which malloc implementation you use.
Exactly. you're right.
> ...
I guess macOS's malloc is slower than Linux's.
However, I guess my patch will effect to all platfor... -
- - You modified. st.h. Effectively killed binary compatibility.
- So you pool st_table to avoid malloc. The speedup depends on which malloc implementation you use. Isn't it because mac OS's malloc is slow? -
- * template/prelude.c.tmpl: split prelude code into blocks so that
each elements do not exceed the string literal size limit in
C89.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60953 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60952 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- See NEWS file for this update details.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60951 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 01:29 AM Revision b4070513 (git): revert r60873
- * template/prelude.c.tmpl (translate): revert r60873 because when some errors or
warnings are shown their line numbers are shifted.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60950 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 12:41 AM Revision 59638882 (git): * 2017-12-01
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60949 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60948 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
11/30/2017
-
- Nobu, thank you for your quick attention to this issue.
The problem occurred with both directory names, `exe` and `bin`.
This appears to have been an rvm issue. When I would gem uninstall rvm's executable_hooks gem, the behavior w... -
- Although I can't reproduce the exact same result, the file under `bin` directory should be a wrapper script generated by rubygems.
Your script is installed in the `exe` directory.
It should be a spec of rubygems. -
- Looks like a rubygems issue.
-
- This problem can be illustrated by using the attached tar file, or the Github repo at https://github.com/keithrbennett/underscore_file_test.
When Ruby version == 2.4.1
and
current directory is the project root of this project
a... -
09:41 PM Feature #14123: Kernel#pp by default
- Eregon (Benoit Daloze) wrote:
> Right, multiple calls to `require "pp"` will wait for one another and only one will actually load the file.
> ...
What happens in the following circumstance:
* Thread 1 calls `Kernel#pp`, defined in p... -
- $ ruby -ryaml -e 'pp YAML.load_file ".travis.yml"'
is probably a nice example for this feature :) -
- mame (Yusuke Endoh) wrote:
> I misunderstood. Ko1 said to me that the current `require` does exclusive control, so the redefinition warning issue should not occur (if it occurs, it is a bug). I'll commit it soon.
Right, multiple ca... -
- Applied in changeset trunk|r60944.
----------
prelude.rb: Add Kernel#pp, a trigger for lib/pp.rb
[Feature #14123] -
- mame (Yusuke Endoh) wrote:
> "Redefinition warnings" issue remains
I misunderstood. Ko1 said to me that the current `require` does exclusive control, so the redefinition warning issue should not occur (if it occurs, it is a bug). I... -
- We discussed this issue at today's Ruby committer's meeting, and matz accepted the feature itself.
jeremyevans0 (Jeremy Evans) wrote:
> I request the implementation be thread-safe and that it fall back to `Kernel#p` if requiring `pp`... -
- cremes (Chuck Remes) wrote:
> I have an alternative suggestion. Since @shyouhei says that my original suggestion is too difficult a transition path, here is an alternative.
> ...
This looks good to me.
I think we can make it a bit n... -
- I have an alternative suggestion. Since @shyouhei says that my original suggestion is too difficult a transition path, here is an alternative.
```
# Convenience class to be used by Thread and Fiber. Those classes
# have ... -
- +1 on an easy way to get a formatted exception.
BTW, "#{e.message} (#{e.class})\n\t#{e.backtrace.join("\n\t")}"
is slightly different than what the C code does, if the message spans multiple lines (then the (#{e.class}) is still on t... -
-
- Hmm. Changed my mind. Implemented `Exception#formatted` with this patch.
I'm not sure this name is proper, suggestions appreciated -
- `Kernel#display` outputs to `STDOUT` by the default.
https://github.com/nobu/ruby/tree/feature/Exception%23display -
- @shevegen
> However had, in that particular case that you showed above, I would personally not want it.
Just curious: why? I mean, I'd understood "Don't think I need it", but to disgust it so much to propose having options for it -- ... -
@zverok some changes for your code:
use Method#owner to get the class/module where the method is defined
that can make a difference for Singleton methods on a non-module object
also use `with_index(1)` instead of the `i+1` in y...-
- I have nothing at all against better diagnostics, introspection etc...
However had, in that particular case that you showed above, I would
personally not want it, even though I normally am always in favour
of introspection. But to e... -
- The idea: When investigating (in example scripts, debugger or console) the library you are unfamiliar with, Ruby's reflection is very useful mechanism to understand "what it can": classes, modules, their constants, methods and so on.
I ... -
- When generate Hash object, the heap area of st_table will be always allocated in internally
and seems it take a time.
To improve performance of creating Hash object,
this patch will reduce count of allocating heap areas for st_table... -
- ruby_2_3 r60947 merged revision(s) 58499,58500.
- 02:38 PM Revision d69b1e3b (git): merge revision(s) 58499,58500: [Backport #13181]
- parse.y: fix line in rescue
* parse.y (set_line_body, primary): fix line number of bodystmt as
the beginning of the block. [ruby-core:79388] [Bug #13181]
parse.y: set_line_body is not used in ripper
git-svn-... -
- ruby_2_3 r60946 merged revision(s) 60149.
- 02:29 PM Revision 9ad02399 (git): merge revision(s) 60149: [Backport #14003]
- Merge rubygems-2.6.14 changes.
It fixed http://blog.rubygems.org/2017/10/09/unsafe-object-deserialization-vulnerability.html
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@60946 b2dd03c8-39d4-4d8f-98ff-823fe69b... -
- I can create a repository on GitHub. ex. "https://github.com/ruby/elisp"
We will discuss this issue at next developer meeting at Dec, 12th. -
- @shevegen (Robert A. Heiler) wrote:
> So to me, that first initial step, to find out how to deal with
> ...
I think it is also a problem even for experienced rubyists.
I often forget to add Thread.{report or abort}_on_exception = true... -
- I have too little experience with threads to meaningfully comment on this.
But I have used Thread-methods before, in particular in ruby-gtk.
I distinctly remember having had to set:
Thread.abort_on_exception = true
in som... -
-
- I've confused because your first report says.
```
>/home/hone/.rvm/gems/ruby-2.4.1@global/bin/bundle:22...
```
I try your instructions. but I couldn't reproduce it. In current trunk:
```
./configure --with-openssl-dir=/usr/lo... -
06:40 AM Bug #13997: Bundler gem binstub broken
- hsbt (Hiroshi SHIBATA) wrote:
> @hone
> ...
Hi @hsbt, we don't use RVM on Heroku at all. This is just my local machine. -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60945 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- [Feature #14123]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60944 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- marcandre (Marc-Andre Lafortune) wrote:
> Could you clarify?
> ...
I don't remember there were discussions about inclusion in this topic. There were ones for prepending only. From what I understand the intention of prepending a modul... -
- This was migrated to https://github.com/ruby/bigdecimal/issues/82
-
- It was migrated to https://github.com/ruby/bigdecimal/issues/81.
11/29/2017
-
- Real-world libraries like Sidekiq implement their own thread exception handler:
https://github.com/mperham/sidekiq/blob/a60a91d3dd857592a532965f0701d285f13f28f1/lib/sidekiq/util.rb#L15-L27
Interestingly, this is named "safe_thread", ... -
- I am really liking the flow of
```ruby
Thread.on_exception do
some stuff
end
``` -
- Perhaps "on by default" would be more palatable to people if we could also specify *how* to handle these unhandled exceptions?
In Java, all threads will report a bubbled-out exception if you do not specify a handler for those exceptio... -
- I think everyone knows where I stand.
-
- I think it is time to do this, and most rubyists using threads with Ruby seem to agree with this
(see #6647 and I can say at least JRuby & TruffleRuby implementers want this).
Other threads should write a backtrace just like the main... -
- Extracted from #6647 to focus on the default value now that the feature is implemented.
I strongly believe we should have Thread.report_on_exception = true by default.
It only adds some extra stderr output for apps which let thread... -
- mikegee (Michael Gee) wrote:
>
> ...
This is one of the Rubocop cops I always disable, because I don't find #empty? conceptually clearer (or necessarily even accurate) unless that's what I wrote in the first place.
`File.stat` is a... -
02:42 PM Feature #14136: Implement #empty? on more classes
- There seems to be some confusion about what I'm asking for here. I know how to use these classes to make my code work. I'm not asking for help using the existing methods.
I am proposing that all classes that implement `#size` or `#len... -
- nobu (Nobuyoshi Nakada) wrote:
> I'd suggest `File.empty?` instead.
`File.empty?` might not always work because you might want lstat or other stat objects
but `File::Stat#size?` might be interesting, it does return nil on empty si... -
- mikegee (Michael Gee) wrote:
> The discussion began because a user reported Rubocop complaining about this code:
> ...
It's a Rubocop's issue.
I'd suggest `File.empty?` instead.
-
- Sorry, that Rubocop issue does have a bunch of unrelated discussion. I should have summarized the parts I was referring to. Thanks for your feedback.
The discussion began because a user reported Rubocop complaining about this code:
... - 07:46 PM Revision 87bcbf9e (git): Cherrypick 9f8d3d0 from ruby/spec
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60943 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- This issue is closed since the feature was implemented.
I'll continue the discussion of the default value in #14143. -
- Great, thank you!
Done. -
06:55 AM Feature #14133: Module#{define|alias|undef}_method should be made public
- OK, I understand. They will be public in 2.5
Matz.
-
- Great, thank you :-)
Done. -
- OK, I understand. They will be public in 2.5
Matz.
- 05:47 PM Revision 0c03a89e (git): Make Module#{define|alias|undef|remove}_method public [#14133]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60942 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 05:47 PM Revision 6186e520 (git): * 2017-11-30
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60941 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 05:47 PM Revision 7298ae9e (git): Make Module#attr{accessor|reader|writer|} public [#14132]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60940 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- shyouhei (Shyouhei Urabe) wrote:
> Thus, matz started thinking that if a module is prepended multiple times, that should appear more than once in a method chain.
Could you clarify?
For inclusion/prepending, there are two questions... -
- Thank you for the consideration.
May I add two observations?
1) `prepend` had similar behavior (ignoring already prepended modules) in 2.0 and 2.1. It was changed in 2.2 and I don't remember incompatibility problems.
2) If incom... -
- The incompatibility that will be caused by the change is intolerable. Any attempt to address the change will make the language far more complex than it currently is.
I have to reject.
Matz.
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60939 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- At least that satisfies my need. I think advanced error logging can be achieved by existing Exception#{class,message,backtrace}.
-
- Do you really want `display` that prints to `IO` or some other method that generates a formatted string?
Matz. -
- Most people want to log caught exceptions to stderr (or somewhere else) then continues their program as usual.
```
def the_program
# ...
raise "failure!"
# ...
rescue RuntimeError => e
$stderr.puts "#{e.message} (#{e.cla... -
12:26 PM Feature #14142 (Closed): Add Method#===
- ## 概要
Ruby の `Method` クラスに対する提案になります。
初めてこちらを利用するので内容や書き方などに対する問題があれば教えていただけると助かります。
## 提案
`Method#call` と同等の `Method#===` を定義する。
## 理由
`Proc` では `Proc#===` が `Proc#call` の同等のメソッドとして定義されています。
`Method` が `Proc` のように... -
- Applied in changeset trunk|r60938.
----------
Update information about Oniguruma/Onigmo [Bug #13818] -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60938 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- rather than ignoring test definition to know untestability when
executing test with `-v`.
Also this simplifies check using `MiniTest::Unit::Guard#windows?`.
This change is suggested by @MSP-Greg here:
https://github.com/ruby/ruby/commi... -
- Applied in changeset trunk|r60936.
----------
Typo... the feature committed at r60935
[Feature #14140] [ruby-core:83963] -
- Note: I proposed this at today's meeting https://bugs.ruby-lang.org/projects/ruby/wiki/DevelopersMeeting20171129Japan
-
- We're already branching error logging format for TTY and non-TTY.
This patch adds bold and underline ANSI color sequence to an error log for TTY.
 -
- [Feature #14140] [ruby-core:83963]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60936 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Print error message in bold/underlined text if STDERR is unchanged and a tty.
[Feature #14160] [experimental]
Screenshot: https://img.sorah.jp/s/2017-11-29_1711_xj2fu.png
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60935 b2dd03c8... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60934 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Applied in changeset trunk|r60933.
----------
file.c: File.lutime
* file.c (utime_internal): add File.lutime. [Feature #4052] -
- Accepted.
Matz.
-
- * file.c (utime_internal): add File.lutime. [Feature #4052]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60933 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- As @mame stated, we don't need it after we had lazy `Proc` allocation.
Matz.
-
- OK, I made a decision. I took option 1 above as proposed.
We can do as following:
~~~
[1, 3.14, 2ri].all?(Numeric) # => true
if should_be_all_symbols.any?(String)
...
end
some_strings.none?(/aeiou/i)
~~~
Matz. -
- Use URI::HTTP.hostname which unwraps the bracket.
```
u = URI("http://[::1]/bar")
p u.hostname #=> "::1"
p u.host #=> "[::1]"
``` -
- Making `Zlib::GzipReader#ungetc` accept nil does not help anybody. You should keep as it is.
I am not sure if we should fix `IO#ungetc` or not (yet). Let me consider.
Matz.
-
- After discussion at the developer meeting, cp_lr may be an consensus.
-
- Accepted, but I am against the name `ln_r` because it behaves differently from `ln -r` (relative).
Matz.
-
- @hone
Can you reproduce without rvm environment?
I think it's problem for ruby_executable_hooks with rvm. like followings.
* https://stackoverflow.com/questions/32308978/ruby-file-ruby-executable-hooks-syntax-error
* https://st... -
- Now we can implement the feature by redefining `Warning.warn`.
Matz.
-
- I don't think the change does not worth the potential incompatibility.
Matz.
-
- Applied in changeset trunk|r60931.
----------
Unused module refinement shouldn't break method search.
Use rb_callable_method_entry_t::defined_class instead of
rb_callable_method_entry_t::owner, because the superclass of iclass
should b... - 08:39 AM Revision 6839932a (git): * remove trailing spaces.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60932 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Use rb_callable_method_entry_t::defined_class instead of
rb_callable_method_entry_t::owner, because the superclass of iclass
should be searched for modules. [ruby-core:83613] [Bug #14068]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trun... -
- Use-case? Is it more useful than `n % m == 0`?
Matz.
-
- Already fixed.
Matz.
-
- Applied in changeset trunk|r60930.
----------
object.c: deprecate Data
* object.c (InitVM_Object): Data is deprecated now.
[Feature #3072] -
- Agreed. How about making `Data` alias to `Object`.
It may be removed in the future (3.0?).
Matz.
-
- * object.c (InitVM_Object): Data is deprecated now.
[Feature #3072]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60930 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I agree too so +1 from me.
Similar to pp by default, I shied away from suggesting the above
because I assumed that there may be speed issues.
If, however had, there are no considerable speed penalties then,
similar to pp, I'd be ... -
- Charles,
+1
You mentioned several good points. I've got them doc'd in the ['Top Level Namespace'](https://msp-greg.github.io/ruby_trunk/Core/top-level-namespace.html) of my doc site so I could find the source, it would be nice if ... -
-
- ```
現状
両端ともすべてASCII数字である場合には、数的な順序
両端ともASCII1文字である場合には、ASCII文字コード的な順序
になってます。で、このいずれにもあてはまらないケースの仕様は
正直確定してません。苦労してもあんまり使われなさそうだし。
ただ、
両端が共通の先頭部分を持ち、非共通部分がすべてASCII数字で ある場合には数的な順序
というのは採用しようと思ってます。あとは、ある文字列から別の
文字列にsuccの連鎖で到達... -
- もうちょっと放置。
Matz.
-
- Applied in changeset trunk|r60929.
----------
strscan.c: add MatchData-like methods
* ext/strscan/strscan.c: added `size`, `captures` and `values_at`
to StringScanner, shorthands of accessing the matched data.
based on the patch by... -
- * ext/strscan/strscan.c: added `size`, `captures` and `values_at`
to StringScanner, shorthands of accessing the matched data.
based on the patch by apeiros (Stefan Rusterholz) at
[ruby-core:20412]. [Feature #836]
git-svn-id: svn+... -
- My enthusiastic -1.
-
- The proposal has been changed from the original. I close this for now. Please re-submit the new proposal (if you want).
Matz.
-
- Unlike the past, it's not smart to add the standard library. Use gem.
Matz.
-
-
- Please use TracePoint API.
-
- Use `source_location`.
Matz.
-
- There is a C preprocessor flag USE_UNICODE_PROPERTIES that is used e.g. in enc/unicode/10.0.0/name2ctype.h. I have never actually seen this, but it may be possible that your version of Ruby is compiled without this flag on. I don't see a...
-
- The incompatibility that will be caused by the change is intolerable. Any attempt to address the change will make the language far more complex than it currently is.
I have to reject.
Matz.
-
- Oops.
```
class Binding
def set_attributes(attrs = self.eval('method(__method__).parameters.map{|t, v| v}'))
attrs.each{|attr|
self.receiver.instance_variable_set(:"@#{attr}", self.local_variable_get(attr))
}
e... -
- My opinion has not been changed from https://bugs.ruby-lang.org/issues/8563#note-3
I am strongly against code like
~~~
def initialize(@foo, @bar)
end
~~~
I don't care about `define_attr_initialize` not being "the solution".
... -
- Not so serious idea.
```
class Binding
def set_attributes(attrs = self.local_variables)
attrs.each{|attr|
self.receiver.instance_variable_set(:"@#{attr}", self.local_variable_get(attr))
}
end
end
class C
... -
- My opinion has not been changed from https://bugs.ruby-lang.org/issues/8563#note-3
I am strongly against code like
~~~
def initialize(@foo, @bar)
end
~~~
I don't care about `define_attr_initialize` not being "the solution".
... -
- My opinion has not been changed from https://bugs.ruby-lang.org/issues/8563#note-3
I am strongly against code like
~~~
def initialize(@foo, @bar)
end
~~~
I don't care about `define_attr_initialize` not being "the solution".
... -
- I had changed the mind, sorry.
-
- Sounds good. Need to discuss implementation detail.
Matz.
-
-
- Eregon (Benoit Daloze) wrote:
> FWIW, TruffleRuby always stores the MatchData $? in a thread-local storage per frame.
> ...
Each frame has a map (thread -> MachData)? -
-
01:17 AM Bug #13746: windows-pr gemのRuby 2.4 32bit版でのSEGV
- https://github.com/cosmo0920/win32-api/pull/31 にて解決しました。
gccのオプション `-fno-omit-frame-pointer` がRubyInstaller2では指定されていないのが原因でi386の時のみフレームポインタが使われていました。x86_64ではうまい具合にフレームポインタが使われる最適化がなされていたようで、こちらではクラッシュしていませんでした。 -
- Link to https://github.com/yaml/libyaml/issues/68
-
- huntertim (Tim Hunter) wrote:
> I compiled a version on windows and this is fixed in
> ...
Yes, this issue was fixed in #14047. Please wait a backport release. Thank you anyway.